src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java
author jlahoda
Thu, 12 Sep 2019 17:47:24 +0200
branchJDK-8226585-branch
changeset 58109 ee07de0d2c16
parent 55622 0b470386f5f7
child 58290 d885633d9de4
permissions -rw-r--r--
Updating javac behavior w.r.t. preview API. Based on darcy's patch.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
53390
46db9786cd67 8214345: infinite recursion while checking super class
bsrbnd
parents: 53037
diff changeset
     2
 * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
import java.util.*;
53037
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
    29
import java.util.function.Supplier;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
    30
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
    31
import javax.tools.JavaFileManager;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.tools.javac.code.*;
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
    34
import com.sun.tools.javac.code.Attribute.Compound;
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
    35
import com.sun.tools.javac.code.Directive.ExportsDirective;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
    36
import com.sun.tools.javac.code.Directive.RequiresDirective;
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
    37
import com.sun.tools.javac.code.Source.Feature;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
    38
import com.sun.tools.javac.comp.Annotate.AnnotationTypeMetadata;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
import com.sun.tools.javac.jvm.*;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    40
import com.sun.tools.javac.resources.CompilerProperties.Errors;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    41
import com.sun.tools.javac.resources.CompilerProperties.Fragments;
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
    42
import com.sun.tools.javac.resources.CompilerProperties.Warnings;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    43
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    44
import com.sun.tools.javac.util.*;
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
    45
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticFlag;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    46
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
    47
import com.sun.tools.javac.util.JCDiagnostic.Error;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
    48
import com.sun.tools.javac.util.JCDiagnostic.Fragment;
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
    49
import com.sun.tools.javac.util.JCDiagnostic.Warning;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    50
import com.sun.tools.javac.util.List;
06bc494ca11e Initial load
duke
parents:
diff changeset
    51
06bc494ca11e Initial load
duke
parents:
diff changeset
    52
import com.sun.tools.javac.code.Lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    53
import com.sun.tools.javac.code.Lint.LintCategory;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
    54
import com.sun.tools.javac.code.Scope.WriteableScope;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    55
import com.sun.tools.javac.code.Type.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
import com.sun.tools.javac.code.Symbol.*;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
    57
import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
15705
c4124695db0c 8007463: Cleanup inference related classes
mcimadamore
parents: 15385
diff changeset
    58
import com.sun.tools.javac.comp.Infer.FreeTypeListener;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15361
diff changeset
    59
import com.sun.tools.javac.tree.JCTree.*;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    60
06bc494ca11e Initial load
duke
parents:
diff changeset
    61
import static com.sun.tools.javac.code.Flags.*;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    62
import static com.sun.tools.javac.code.Flags.ANNOTATION;
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    63
import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    64
import static com.sun.tools.javac.code.Kinds.*;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
    65
import static com.sun.tools.javac.code.Kinds.Kind.*;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
    66
import static com.sun.tools.javac.code.Scope.LookupKind.NON_RECURSIVE;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    67
import static com.sun.tools.javac.code.TypeTag.*;
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    68
import static com.sun.tools.javac.code.TypeTag.WILDCARD;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    69
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    70
import static com.sun.tools.javac.tree.JCTree.Tag.*;
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    71
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
/** Type checking helper class for the attribution phase.
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    74
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    75
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    79
public class Check {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
    80
    protected static final Context.Key<Check> checkKey = new Context.Key<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    82
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
    private final Log log;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
    84
    private final Resolve rs;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
    private final Symtab syms;
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    86
    private final Enter enter;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
    87
    private final DeferredAttr deferredAttr;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
    private final Infer infer;
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
    private final Types types;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
    90
    private final TypeAnnotations typeAnnotations;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    91
    private final JCDiagnostic.Factory diags;
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
    92
    private final JavaFileManager fileManager;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    93
    private final Source source;
50250
04f9bb270ab8 8203488: Remove error generation from TransTypes
mcimadamore
parents: 50213
diff changeset
    94
    private final Target target;
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
    95
    private final Profile profile;
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
    96
    private final Preview preview;
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
    97
    private final boolean warnOnAnyAccessToMembers;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
    // The set of lint options currently in effect. It is initialized
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
    // from the context, and then is set/reset as needed by Attr as it
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
    // visits all the various parts of the trees during attribution.
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
    private Lint lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   104
    // The method being analyzed in Attr - it is set/reset as needed by
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   105
    // Attr as it visits new method declarations.
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   106
    private MethodSymbol method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   107
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   108
    public static Check instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   109
        Check instance = context.get(checkKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
   110
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   111
            instance = new Check(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   112
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
   113
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   114
06bc494ca11e Initial load
duke
parents:
diff changeset
   115
    protected Check(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
        context.put(checkKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   118
        names = Names.instance(context);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   119
        dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   120
            names.FIELD, names.METHOD, names.CONSTRUCTOR,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   121
            names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
        log = Log.instance(context);
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   123
        rs = Resolve.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   124
        syms = Symtab.instance(context);
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
   125
        enter = Enter.instance(context);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   126
        deferredAttr = DeferredAttr.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
        infer = Infer.instance(context);
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   128
        types = Types.instance(context);
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   129
        typeAnnotations = TypeAnnotations.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   130
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   132
        lint = Lint.instance(context);
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
   133
        fileManager = context.get(JavaFileManager.class);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   135
        source = Source.instance(context);
50250
04f9bb270ab8 8203488: Remove error generation from TransTypes
mcimadamore
parents: 50213
diff changeset
   136
        target = Target.instance(context);
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
   137
        warnOnAnyAccessToMembers = options.isSet("warnOnAccessToMembers");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   138
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   139
        Target target = Target.instance(context);
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   140
        syntheticNameChar = target.syntheticNameChar();
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   141
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   142
        profile = Profile.instance(context);
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   143
        preview = Preview.instance(context);
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   144
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   145
        boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   146
        boolean verboseRemoval = lint.isEnabled(LintCategory.REMOVAL);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   147
        boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   148
        boolean verbosePreview = lint.isEnabled(LintCategory.PREVIEW);
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
   149
        boolean enforceMandatoryWarnings = true;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   151
        deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   152
                enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   153
        removalHandler = new MandatoryWarningHandler(log, verboseRemoval,
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   154
                enforceMandatoryWarnings, "removal", LintCategory.REMOVAL);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   155
        uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   156
                enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
35810
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
   157
        sunApiHandler = new MandatoryWarningHandler(log, false,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   158
                enforceMandatoryWarnings, "sunapi", null);
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   159
        previewHandler = new MandatoryWarningHandler(log, verbosePreview,
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   160
                enforceMandatoryWarnings, "preview", null);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   161
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   162
        deferredLintHandler = DeferredLintHandler.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   163
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   164
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   165
    /** Character for synthetic names
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   166
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   167
    char syntheticNameChar;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   168
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   169
    /** A table mapping flat names of all compiled classes for each module in this run
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   170
     *  to their symbols; maintained from outside.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   171
     */
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   172
    private Map<Pair<ModuleSymbol, Name>,ClassSymbol> compiled = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   173
06bc494ca11e Initial load
duke
parents:
diff changeset
   174
    /** A handler for messages about deprecated usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   175
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   176
    private MandatoryWarningHandler deprecationHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   177
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   178
    /** A handler for messages about deprecated-for-removal usage.
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   179
     */
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   180
    private MandatoryWarningHandler removalHandler;
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   181
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   182
    /** A handler for messages about unchecked or unsafe usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   183
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   184
    private MandatoryWarningHandler uncheckedHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   186
    /** A handler for messages about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   187
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   188
    private MandatoryWarningHandler sunApiHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   189
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   190
    /** A handler for messages about preview features.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   191
     */
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   192
    private MandatoryWarningHandler previewHandler;
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   193
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   194
    /** A handler for deferred lint warnings.
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   195
     */
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   196
    private DeferredLintHandler deferredLintHandler;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   197
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   198
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   199
 * Errors and Warnings
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   201
06bc494ca11e Initial load
duke
parents:
diff changeset
   202
    Lint setLint(Lint newLint) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   203
        Lint prev = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   204
        lint = newLint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   205
        return prev;
06bc494ca11e Initial load
duke
parents:
diff changeset
   206
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   207
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   208
    MethodSymbol setMethod(MethodSymbol newMethod) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   209
        MethodSymbol prev = method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   210
        method = newMethod;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   211
        return prev;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   212
    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   213
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   214
    /** Warn about deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   215
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   216
     *  @param sym        The deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   218
    void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   219
        if (sym.isDeprecatedForRemoval()) {
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   220
            if (!lint.isSuppressed(LintCategory.REMOVAL)) {
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   221
                if (sym.kind == MDL) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   222
                    removalHandler.report(pos, Warnings.HasBeenDeprecatedForRemovalModule(sym));
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   223
                } else {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   224
                    removalHandler.report(pos, Warnings.HasBeenDeprecatedForRemoval(sym, sym.location()));
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   225
                }
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   226
            }
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   227
        } else if (!lint.isSuppressed(LintCategory.DEPRECATION)) {
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   228
            if (sym.kind == MDL) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   229
                deprecationHandler.report(pos, Warnings.HasBeenDeprecatedModule(sym));
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   230
            } else {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   231
                deprecationHandler.report(pos, Warnings.HasBeenDeprecated(sym, sym.location()));
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
   232
            }
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   233
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   234
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   235
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   236
    /** Warn about deprecated symbol.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   237
     *  @param pos        Position to be used for error reporting.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   238
     *  @param sym        The deprecated symbol.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   239
     */
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   240
    void warnPreview(DiagnosticPosition pos, Symbol sym) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   241
        if ((sym.flags() & PREVIEW_ESSENTIAL_API) != 0) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   242
            previewHandler.report(pos, Warnings.IsPreview(sym));
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   243
        } else {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   244
            warnPreview(pos, Warnings.IsPreview(sym));
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   245
        }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   246
    }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   247
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   248
    /** Log a preview warning.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   249
     *  @param pos        Position to be used for error reporting.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   250
     *  @param msg        A Warning describing the problem.
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   251
     */
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   252
    public void warnPreview(DiagnosticPosition pos, Warning warnKey) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   253
        if (!lint.isSuppressed(LintCategory.PREVIEW))
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   254
            previewHandler.report(pos, warnKey);
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   255
    }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   256
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
    /** Warn about unchecked operation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   258
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
     *  @param msg        A string describing the problem.
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
     */
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   261
    public void warnUnchecked(DiagnosticPosition pos, Warning warnKey) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
        if (!lint.isSuppressed(LintCategory.UNCHECKED))
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   263
            uncheckedHandler.report(pos, warnKey);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   266
    /** Warn about unsafe vararg method decl.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   267
     *  @param pos        Position to be used for error reporting.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   268
     */
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   269
    void warnUnsafeVararg(DiagnosticPosition pos, Warning warnKey) {
51047
860a3648c494 8028563: Remove javac support for 6/1.6 source and target values
darcy
parents: 50539
diff changeset
   270
        if (lint.isEnabled(LintCategory.VARARGS))
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   271
            log.warning(LintCategory.VARARGS, pos, warnKey);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   272
    }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   273
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   274
    public void warnStatic(DiagnosticPosition pos, Warning warnKey) {
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   275
        if (lint.isEnabled(LintCategory.STATIC))
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   276
            log.warning(LintCategory.STATIC, pos, warnKey);
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   277
    }
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   278
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   279
    /** Warn about division by integer constant zero.
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   280
     *  @param pos        Position to be used for error reporting.
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   281
     */
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   282
    void warnDivZero(DiagnosticPosition pos) {
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   283
        if (lint.isEnabled(LintCategory.DIVZERO))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   284
            log.warning(LintCategory.DIVZERO, pos, Warnings.DivZero);
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   285
    }
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   286
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   287
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
     * Report any deferred diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
    public void reportDeferredDiagnostics() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
        deprecationHandler.reportDeferredDiagnostic();
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
   292
        removalHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
        uncheckedHandler.reportDeferredDiagnostic();
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   294
        sunApiHandler.reportDeferredDiagnostic();
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
   295
        previewHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   297
06bc494ca11e Initial load
duke
parents:
diff changeset
   298
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
    /** Report a failure to complete a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
     *  @param ex         The failure to report.
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
    public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   304
        log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, Errors.CantAccess(ex.sym, ex.getDetailValue()));
45910
c7092e4591b2 8182450: javac aborts when generating ct.sym intermittently
jlahoda
parents: 45867
diff changeset
   305
        return syms.errType;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
06bc494ca11e Initial load
duke
parents:
diff changeset
   308
    /** Report an error that wrong type tag was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
     *  @param required   An internationalized string describing the type tag
06bc494ca11e Initial load
duke
parents:
diff changeset
   311
     *                    required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
     */
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   314
    Type typeTagError(DiagnosticPosition pos, JCDiagnostic required, Object found) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   315
        // this error used to be raised by the parser,
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   316
        // but has been delayed to this point:
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   317
        if (found instanceof Type && ((Type)found).hasTag(VOID)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   318
            log.error(pos, Errors.IllegalStartOfType);
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   319
            return syms.errType;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   320
        }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   321
        log.error(pos, Errors.TypeFoundReq(found, required));
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   322
        return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
    /** Report an error that symbol cannot be referenced before super
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
     *  has been called.
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
     *  @param sym        The referenced symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
    void earlyRefError(DiagnosticPosition pos, Symbol sym) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   331
        log.error(pos, Errors.CantRefBeforeCtorCalled(sym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
    /** Report duplicate declaration error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   336
    void duplicateError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
        if (!sym.type.isErroneous()) {
10626
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   338
            Symbol location = sym.location();
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   339
            if (location.kind == MTH &&
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   340
                    ((MethodSymbol)location).isStaticOrInstanceInit()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   341
                log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   342
                          Errors.AlreadyDefinedInClinit(kindName(sym),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   343
                                                        sym,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   344
                                                        kindName(sym.location()),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   345
                                                        kindName(sym.location().enclClass()),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   346
                                                        sym.location().enclClass()));
10626
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   347
            } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   348
                log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   349
                          Errors.AlreadyDefined(kindName(sym),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   350
                                                sym,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   351
                                                kindName(sym.location()),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   352
                                                sym.location()));
10626
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   353
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   356
06bc494ca11e Initial load
duke
parents:
diff changeset
   357
    /** Report array/varargs duplicate declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
    void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   361
            log.error(pos, Errors.ArrayAndVarargs(sym1, sym2, sym2.location()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
 * duplicate declaration checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
    /** Check that variable does not hide variable with same name in
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
     *  immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   371
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
     *  @param v             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   373
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
    void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   376
        for (Symbol sym : s.getSymbolsByName(v.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   377
            if (sym.owner != v.owner) break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   378
            if (sym.kind == VAR &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
   379
                sym.owner.kind.matches(KindSelector.VAL_MTH) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   380
                v.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   381
                duplicateError(pos, sym);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   382
                return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   383
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   384
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   385
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   386
06bc494ca11e Initial load
duke
parents:
diff changeset
   387
    /** Check that a class or interface does not hide a class or
06bc494ca11e Initial load
duke
parents:
diff changeset
   388
     *  interface with same name in immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   389
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   390
     *  @param c             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   391
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   392
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
    void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   394
        for (Symbol sym : s.getSymbolsByName(c.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   395
            if (sym.owner != c.owner) break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   396
            if (sym.kind == TYP && !sym.type.hasTag(TYPEVAR) &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
   397
                sym.owner.kind.matches(KindSelector.VAL_MTH) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   398
                c.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   399
                duplicateError(pos, sym);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   400
                return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   401
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   402
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   403
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   404
06bc494ca11e Initial load
duke
parents:
diff changeset
   405
    /** Check that class does not have the same name as one of
06bc494ca11e Initial load
duke
parents:
diff changeset
   406
     *  its enclosing classes, or as a class defined in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   407
     *  return true if class is unique in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   408
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
     *  @param name          The class name.
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
     *  @param s             The enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
    boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   413
        for (Symbol sym : s.getSymbolsByName(name, NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   414
            if (sym.kind == TYP && sym.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   415
                duplicateError(pos, sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   416
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   417
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   418
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   419
        for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   420
            if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   421
                duplicateError(pos, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   422
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   423
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   424
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   425
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   426
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   427
06bc494ca11e Initial load
duke
parents:
diff changeset
   428
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   429
 * Class name generation
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   432
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   433
    private Map<Pair<Name, Name>, Integer> localClassNameIndexes = new HashMap<>();
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   434
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   435
    /** Return name of local class.
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   436
     *  This is of the form   {@code <enclClass> $ n <classname> }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   437
     *  where
06bc494ca11e Initial load
duke
parents:
diff changeset
   438
     *    enclClass is the flat name of the enclosing class,
06bc494ca11e Initial load
duke
parents:
diff changeset
   439
     *    classname is the simple name of the local class
06bc494ca11e Initial load
duke
parents:
diff changeset
   440
     */
55622
0b470386f5f7 8223443: Calling Trees.getScope early changes names of local/anonymous classes
jlahoda
parents: 55358
diff changeset
   441
    public Name localClassName(ClassSymbol c) {
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   442
        Name enclFlatname = c.owner.enclClass().flatname;
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   443
        String enclFlatnameStr = enclFlatname.toString();
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   444
        Pair<Name, Name> key = new Pair<>(enclFlatname, c.name);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   445
        Integer index = localClassNameIndexes.get(key);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   446
        for (int i = (index == null) ? 1 : index; ; i++) {
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   447
            Name flatname = names.fromString(enclFlatnameStr
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   448
                    + syntheticNameChar + i + c.name);
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   449
            if (getCompiled(c.packge().modle, flatname) == null) {
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   450
                localClassNameIndexes.put(key, i + 1);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   451
                return flatname;
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   452
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   453
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   454
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   455
55622
0b470386f5f7 8223443: Calling Trees.getScope early changes names of local/anonymous classes
jlahoda
parents: 55358
diff changeset
   456
    public void clearLocalClassNameIndexes(ClassSymbol c) {
43139
1d768b91ae4b 8171325: NPE in Check.clearLocalClassNameIndexes
vromero
parents: 42828
diff changeset
   457
        if (c.owner != null && c.owner.kind != NIL) {
1d768b91ae4b 8171325: NPE in Check.clearLocalClassNameIndexes
vromero
parents: 42828
diff changeset
   458
            localClassNameIndexes.remove(new Pair<>(
1d768b91ae4b 8171325: NPE in Check.clearLocalClassNameIndexes
vromero
parents: 42828
diff changeset
   459
                    c.owner.enclClass().flatname, c.name));
1d768b91ae4b 8171325: NPE in Check.clearLocalClassNameIndexes
vromero
parents: 42828
diff changeset
   460
        }
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   461
    }
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   462
23810
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   463
    public void newRound() {
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   464
        compiled.clear();
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   465
        localClassNameIndexes.clear();
23810
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   466
    }
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   467
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   468
    public void putCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   469
        compiled.put(Pair.of(csym.packge().modle, csym.flatname), csym);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   470
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   471
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   472
    public ClassSymbol getCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   473
        return compiled.get(Pair.of(csym.packge().modle, csym.flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   474
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   475
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   476
    public ClassSymbol getCompiled(ModuleSymbol msym, Name flatname) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   477
        return compiled.get(Pair.of(msym, flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   478
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   479
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   480
    public void removeCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   481
        compiled.remove(Pair.of(csym.packge().modle, csym.flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   482
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   483
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   484
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   485
 * Type Checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   486
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   487
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   488
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   489
     * A check context is an object that can be used to perform compatibility
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   490
     * checks - depending on the check context, meaning of 'compatibility' might
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   491
     * vary significantly.
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   492
     */
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   493
    public interface CheckContext {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   494
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   495
         * Is type 'found' compatible with type 'req' in given context
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   496
         */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   497
        boolean compatible(Type found, Type req, Warner warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   498
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   499
         * Report a check error
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   500
         */
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   501
        void report(DiagnosticPosition pos, JCDiagnostic details);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   502
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   503
         * Obtain a warner for this check context
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   504
         */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   505
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   506
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   507
        public InferenceContext inferenceContext();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   508
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   509
        public DeferredAttr.DeferredAttrContext deferredAttrContext();
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   510
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   511
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   512
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   513
     * This class represent a check context that is nested within another check
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   514
     * context - useful to check sub-expressions. The default behavior simply
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   515
     * redirects all method calls to the enclosing check context leveraging
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   516
     * the forwarding pattern.
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   517
     */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   518
    static class NestedCheckContext implements CheckContext {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   519
        CheckContext enclosingContext;
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   520
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   521
        NestedCheckContext(CheckContext enclosingContext) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   522
            this.enclosingContext = enclosingContext;
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   523
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   524
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   525
        public boolean compatible(Type found, Type req, Warner warn) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   526
            return enclosingContext.compatible(found, req, warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   527
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   528
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   529
        public void report(DiagnosticPosition pos, JCDiagnostic details) {
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   530
            enclosingContext.report(pos, details);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   531
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   532
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   533
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   534
            return enclosingContext.checkWarner(pos, found, req);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   535
        }
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   536
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   537
        public InferenceContext inferenceContext() {
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   538
            return enclosingContext.inferenceContext();
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   539
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   540
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   541
        public DeferredAttrContext deferredAttrContext() {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   542
            return enclosingContext.deferredAttrContext();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   543
        }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   544
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   545
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   546
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   547
     * Check context to be used when evaluating assignment/return statements
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   548
     */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   549
    CheckContext basicHandler = new CheckContext() {
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   550
        public void report(DiagnosticPosition pos, JCDiagnostic details) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   551
            log.error(pos, Errors.ProbFoundReq(details));
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   552
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   553
        public boolean compatible(Type found, Type req, Warner warn) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   554
            return types.isAssignable(found, req, warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   555
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   556
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   557
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   558
            return convertWarner(pos, found, req);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   559
        }
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   560
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   561
        public InferenceContext inferenceContext() {
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   562
            return infer.emptyContext;
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   563
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   564
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   565
        public DeferredAttrContext deferredAttrContext() {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   566
            return deferredAttr.emptyDeferredAttrContext;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   567
        }
24226
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   568
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   569
        @Override
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   570
        public String toString() {
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   571
            return "CheckContext: basicHandler";
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   572
        }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   573
    };
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   574
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   575
    /** Check that a given type is assignable to a given proto-type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   576
     *  If it is, return the type, otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
   577
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   578
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   579
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   580
     */
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   581
    public Type checkType(DiagnosticPosition pos, Type found, Type req) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   582
        return checkType(pos, found, req, basicHandler);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   583
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   584
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   585
    Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   586
        final InferenceContext inferenceContext = checkContext.inferenceContext();
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25276
diff changeset
   587
        if (inferenceContext.free(req) || inferenceContext.free(found)) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   588
            inferenceContext.addFreeTypeListener(List.of(req, found),
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   589
                    solvedContext -> checkType(pos, solvedContext.asInstType(found), solvedContext.asInstType(req), checkContext));
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   590
        }
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   591
        if (req.hasTag(ERROR))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   592
            return req;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   593
        if (req.hasTag(NONE))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   594
            return found;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   595
        if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   596
            return found;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   597
        } else {
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
   598
            if (found.isNumeric() && req.isNumeric()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   599
                checkContext.report(pos, diags.fragment(Fragments.PossibleLossOfPrecision(found, req)));
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   600
                return types.createErrorType(found);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   601
            }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   602
            checkContext.report(pos, diags.fragment(Fragments.InconvertibleTypes(found, req)));
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   603
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   604
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   605
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   606
06bc494ca11e Initial load
duke
parents:
diff changeset
   607
    /** Check that a given type can be cast to a given target type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   608
     *  Return the result of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   609
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   610
     *  @param found      The type that is being cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   611
     *  @param req        The target type of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   612
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   613
    Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   614
        return checkCastable(pos, found, req, basicHandler);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   615
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   616
    Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12335
diff changeset
   617
        if (types.isCastable(found, req, castWarner(pos, found, req))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   618
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   619
        } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   620
            checkContext.report(pos, diags.fragment(Fragments.InconvertibleTypes(found, req)));
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   621
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   622
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   623
    }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   624
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   625
    /** Check for redundant casts (i.e. where source type is a subtype of target type)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   626
     * The problem should only be reported for non-292 cast
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   627
     */
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   628
    public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   629
        if (!tree.type.isErroneous()
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   630
                && types.isSameType(tree.expr.type, tree.clazz.type)
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   631
                && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   632
                && !is292targetTypeCast(tree)) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   633
            deferredLintHandler.report(() -> {
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   634
                if (lint.isEnabled(LintCategory.CAST))
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   635
                    log.warning(LintCategory.CAST,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   636
                            tree.pos(), Warnings.RedundantCast(tree.clazz.type));
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   637
            });
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   638
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   639
    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   640
    //where
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   641
        private boolean is292targetTypeCast(JCTypeCast tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   642
            boolean is292targetTypeCast = false;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   643
            JCExpression expr = TreeInfo.skipParens(tree.expr);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   644
            if (expr.hasTag(APPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   645
                JCMethodInvocation apply = (JCMethodInvocation)expr;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   646
                Symbol sym = TreeInfo.symbol(apply.meth);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   647
                is292targetTypeCast = sym != null &&
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   648
                    sym.kind == MTH &&
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   649
                    (sym.flags() & HYPOTHETICAL) != 0;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   650
            }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   651
            return is292targetTypeCast;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   652
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   653
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   654
        private static final boolean ignoreAnnotatedCasts = true;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   655
06bc494ca11e Initial load
duke
parents:
diff changeset
   656
    /** Check that a type is within some bounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   657
     *
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   658
     *  Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   659
     *  type argument.
06bc494ca11e Initial load
duke
parents:
diff changeset
   660
     *  @param a             The type that should be bounded by bs.
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   661
     *  @param bound         The bound.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   662
     */
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
   663
    private boolean checkExtends(Type a, Type bound) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   664
         if (a.isUnbound()) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   665
             return true;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   666
         } else if (!a.hasTag(WILDCARD)) {
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24604
diff changeset
   667
             a = types.cvarUpperBound(a);
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
   668
             return types.isSubtype(a, bound);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   669
         } else if (a.isExtendsBound()) {
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24604
diff changeset
   670
             return types.isCastable(bound, types.wildUpperBound(a), types.noWarnings);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   671
         } else if (a.isSuperBound()) {
24293
0d889f759fac 8033718: Inference ignores capture variable as upper bound
dlsmith
parents: 24226
diff changeset
   672
             return !types.notSoftSubtype(types.wildLowerBound(a), bound);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   673
         }
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   674
         return true;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   675
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   676
06bc494ca11e Initial load
duke
parents:
diff changeset
   677
    /** Check that type is different from 'void'.
06bc494ca11e Initial load
duke
parents:
diff changeset
   678
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   679
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   680
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   681
    Type checkNonVoid(DiagnosticPosition pos, Type t) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   682
        if (t.hasTag(VOID)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   683
            log.error(pos, Errors.VoidNotAllowedHere);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   684
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   685
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   686
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   687
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   688
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   689
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   690
    Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   691
        if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   692
            return typeTagError(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   693
                                diags.fragment(Fragments.TypeReqClassArray),
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   694
                                asTypeParam(t));
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   695
        } else {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   696
            return t;
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   697
        }
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   698
    }
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   699
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   700
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   701
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   702
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   703
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   704
    Type checkClassType(DiagnosticPosition pos, Type t) {
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   705
        if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   706
            return typeTagError(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   707
                                diags.fragment(Fragments.TypeReqClass),
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   708
                                asTypeParam(t));
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   709
        } else {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   710
            return t;
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   711
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   712
    }
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   713
    //where
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   714
        private Object asTypeParam(Type t) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   715
            return (t.hasTag(TYPEVAR))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   716
                                    ? diags.fragment(Fragments.TypeParameter(t))
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   717
                                    : t;
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   718
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   719
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   720
    /** Check that type is a valid qualifier for a constructor reference expression
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   721
     */
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   722
    Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   723
        t = checkClassOrArrayType(pos, t);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   724
        if (t.hasTag(CLASS)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   725
            if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   726
                log.error(pos, Errors.AbstractCantBeInstantiated(t.tsym));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   727
                t = types.createErrorType(t);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   728
            } else if ((t.tsym.flags() & ENUM) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   729
                log.error(pos, Errors.EnumCantBeInstantiated);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   730
                t = types.createErrorType(t);
16340
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   731
            } else {
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   732
                t = checkClassType(pos, t, true);
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   733
            }
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   734
        } else if (t.hasTag(ARRAY)) {
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   735
            if (!types.isReifiable(((ArrayType)t).elemtype)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   736
                log.error(pos, Errors.GenericArrayCreation);
16340
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   737
                t = types.createErrorType(t);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   738
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   739
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   740
        return t;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   741
    }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   742
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   743
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   744
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   745
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   746
     *  @param noBounds    True if type bounds are illegal here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   747
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   748
    Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   749
        t = checkClassType(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   750
        if (noBounds && t.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   751
            List<Type> args = t.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
   752
            while (args.nonEmpty()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   753
                if (args.head.hasTag(WILDCARD))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   754
                    return typeTagError(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   755
                                        diags.fragment(Fragments.TypeReqExact),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   756
                                        args.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
                args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   758
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   759
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   760
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   761
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   762
06bc494ca11e Initial load
duke
parents:
diff changeset
   763
    /** Check that type is a reference type, i.e. a class, interface or array type
06bc494ca11e Initial load
duke
parents:
diff changeset
   764
     *  or a type variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   768
    Type checkRefType(DiagnosticPosition pos, Type t) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   769
        if (t.isReference())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   770
            return t;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   771
        else
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   772
            return typeTagError(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   773
                                diags.fragment(Fragments.TypeReqRef),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   774
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   775
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   776
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   777
    /** Check that each type is a reference type, i.e. a class, interface or array type
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   778
     *  or a type variable.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   779
     *  @param trees         Original trees, used for error reporting.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   780
     *  @param types         The types to be checked.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   781
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   782
    List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   783
        List<JCExpression> tl = trees;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   784
        for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   785
            l.head = checkRefType(tl.head.pos(), l.head);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   786
            tl = tl.tail;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   787
        }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   788
        return types;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   789
    }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   790
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   791
    /** Check that type is a null or reference type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   792
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   793
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   794
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   795
    Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
   796
        if (t.isReference() || t.hasTag(BOT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   797
            return t;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   798
        else
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   799
            return typeTagError(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   800
                                diags.fragment(Fragments.TypeReqRef),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   801
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   802
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   803
06bc494ca11e Initial load
duke
parents:
diff changeset
   804
    /** Check that flag set does not contain elements of two conflicting sets. s
06bc494ca11e Initial load
duke
parents:
diff changeset
   805
     *  Return true if it doesn't.
06bc494ca11e Initial load
duke
parents:
diff changeset
   806
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   807
     *  @param flags         The set of flags to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   808
     *  @param set1          Conflicting flags set #1.
06bc494ca11e Initial load
duke
parents:
diff changeset
   809
     *  @param set2          Conflicting flags set #2.
06bc494ca11e Initial load
duke
parents:
diff changeset
   810
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   811
    boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   812
        if ((flags & set1) != 0 && (flags & set2) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   813
            log.error(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   814
                      Errors.IllegalCombinationOfModifiers(asFlagSet(TreeInfo.firstFlag(flags & set1)),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   815
                                                           asFlagSet(TreeInfo.firstFlag(flags & set2))));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   816
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   817
        } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   818
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   819
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   820
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   821
    /** Check that usage of diamond operator is correct (i.e. diamond should not
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   822
     * be used with non-generic classes or in anonymous class creation expressions)
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   823
     */
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   824
    Type checkDiamond(JCNewClass tree, Type t) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   825
        if (!TreeInfo.isDiamond(tree) ||
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   826
                t.isErroneous()) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   827
            return checkClassType(tree.clazz.pos(), t, true);
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   828
        } else {
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
   829
            if (tree.def != null && !Feature.DIAMOND_WITH_ANONYMOUS_CLASS_CREATION.allowedInSource(source)) {
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   830
                log.error(DiagnosticFlag.SOURCE_LEVEL, tree.clazz.pos(),
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
   831
                        Errors.CantApplyDiamond1(t, Feature.DIAMOND_WITH_ANONYMOUS_CLASS_CREATION.fragment(source.name)));
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   832
            }
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   833
            if (t.tsym.type.getTypeArguments().isEmpty()) {
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   834
                log.error(tree.clazz.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   835
                          Errors.CantApplyDiamond1(t,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   836
                                                   Fragments.DiamondNonGeneric(t)));
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   837
                return types.createErrorType(t);
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   838
            } else if (tree.typeargs != null &&
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   839
                    tree.typeargs.nonEmpty()) {
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   840
                log.error(tree.clazz.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   841
                          Errors.CantApplyDiamond1(t,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   842
                                                   Fragments.DiamondAndExplicitParams(t)));
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   843
                return types.createErrorType(t);
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   844
            } else {
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   845
                return t;
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
   846
            }
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   847
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   848
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   849
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   850
    /** Check that the type inferred using the diamond operator does not contain
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   851
     *  non-denotable types such as captured types or intersection types.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   852
     *  @param t the type inferred using the diamond operator
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   853
     *  @return  the (possibly empty) list of non-denotable types.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   854
     */
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   855
    List<Type> checkDiamondDenotable(ClassType t) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   856
        ListBuffer<Type> buf = new ListBuffer<>();
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   857
        for (Type arg : t.allparams()) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   858
            if (!checkDenotable(arg)) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   859
                buf.append(arg);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   860
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   861
        }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   862
        return buf.toList();
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   863
    }
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   864
49294
3556298e481d 8199910: Compiler crashes with -g option and variables of intersection type inferred by `var`
mcimadamore
parents: 48721
diff changeset
   865
    public boolean checkDenotable(Type t) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   866
        return denotableChecker.visit(t, null);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   867
    }
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   868
        // where
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   869
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   870
        /** diamondTypeChecker: A type visitor that descends down the given type looking for non-denotable
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   871
         *  types. The visit methods return false as soon as a non-denotable type is encountered and true
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   872
         *  otherwise.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   873
         */
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   874
        private static final Types.SimpleVisitor<Boolean, Void> denotableChecker = new Types.SimpleVisitor<Boolean, Void>() {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   875
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   876
            public Boolean visitType(Type t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   877
                return true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   878
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   879
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   880
            public Boolean visitClassType(ClassType t, Void s) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   881
                if (t.isUnion() || t.isIntersection()) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   882
                    return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   883
                }
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   884
                for (Type targ : t.allparams()) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   885
                    if (!visit(targ, s)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   886
                        return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   887
                    }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   888
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   889
                return true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   890
            }
30403
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   891
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   892
            @Override
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   893
            public Boolean visitTypeVar(TypeVar t, Void s) {
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   894
                /* Any type variable mentioned in the inferred type must have been declared as a type parameter
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   895
                  (i.e cannot have been produced by inference (18.4))
30403
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   896
                */
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   897
                return (t.tsym.flags() & SYNTHETIC) == 0;
30403
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   898
            }
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   899
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   900
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   901
            public Boolean visitCapturedType(CapturedType t, Void s) {
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   902
                /* Any type variable mentioned in the inferred type must have been declared as a type parameter
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   903
                  (i.e cannot have been produced by capture conversion (5.1.10))
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   904
                */
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   905
                return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   906
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   907
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   908
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   909
            public Boolean visitArrayType(ArrayType t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   910
                return visit(t.elemtype, s);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   911
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   912
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   913
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   914
            public Boolean visitWildcardType(WildcardType t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   915
                return visit(t.type, s);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   916
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   917
        };
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   918
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   919
    void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   920
        MethodSymbol m = tree.sym;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   921
        boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   922
        Type varargElemType = null;
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   923
        if (m.isVarArgs()) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   924
            varargElemType = types.elemtype(tree.params.last().type);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   925
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   926
        if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   927
            if (varargElemType != null) {
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
   928
                JCDiagnostic msg = Feature.PRIVATE_SAFE_VARARGS.allowedInSource(source) ?
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   929
                        diags.fragment(Fragments.VarargsTrustmeOnVirtualVarargs(m)) :
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   930
                        diags.fragment(Fragments.VarargsTrustmeOnVirtualVarargsFinalOnly(m));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   931
                log.error(tree,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   932
                          Errors.VarargsInvalidTrustmeAnno(syms.trustMeType.tsym,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   933
                                                           msg));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   934
            } else {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   935
                log.error(tree,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   936
                          Errors.VarargsInvalidTrustmeAnno(syms.trustMeType.tsym,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
   937
                                                           Fragments.VarargsTrustmeOnNonVarargsMeth(m)));
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   938
            }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   939
        } else if (hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   940
                            types.isReifiable(varargElemType)) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   941
            warnUnsafeVararg(tree, Warnings.VarargsRedundantTrustmeAnno(
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   942
                                syms.trustMeType.tsym,
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   943
                                diags.fragment(Fragments.VarargsTrustmeOnReifiableVarargs(varargElemType))));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   944
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   945
        else if (!hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   946
                !types.isReifiable(varargElemType)) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
   947
            warnUnchecked(tree.params.head.pos(), Warnings.UncheckedVarargsNonReifiableType(varargElemType));
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   948
        }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   949
    }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   950
    //where
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   951
        private boolean isTrustMeAllowedOnMethod(Symbol s) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   952
            return (s.flags() & VARARGS) != 0 &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   953
                (s.isConstructor() ||
25283
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   954
                    (s.flags() & (STATIC | FINAL |
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
   955
                                  (Feature.PRIVATE_SAFE_VARARGS.allowedInSource(source) ? PRIVATE : 0) )) != 0);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   956
        }
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   957
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   958
    Type checkLocalVarType(DiagnosticPosition pos, Type t, Name name) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   959
        //check that resulting type is not the null type
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   960
        if (t.hasTag(BOT)) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   961
            log.error(pos, Errors.CantInferLocalVarType(name, Fragments.LocalCantInferNull));
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   962
            return types.createErrorType(t);
47934
6373d9a0ad82 8191834: Assigning a void expression to a "var" crashes the compiler
mcimadamore
parents: 47873
diff changeset
   963
        } else if (t.hasTag(VOID)) {
6373d9a0ad82 8191834: Assigning a void expression to a "var" crashes the compiler
mcimadamore
parents: 47873
diff changeset
   964
            log.error(pos, Errors.CantInferLocalVarType(name, Fragments.LocalCantInferVoid));
6373d9a0ad82 8191834: Assigning a void expression to a "var" crashes the compiler
mcimadamore
parents: 47873
diff changeset
   965
            return types.createErrorType(t);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   966
        }
47959
5dd899009525 8191802: Upward projection result is A<? extends Number> instead of A<? super Integer>
mcimadamore
parents: 47948
diff changeset
   967
5dd899009525 8191802: Upward projection result is A<? extends Number> instead of A<? super Integer>
mcimadamore
parents: 47948
diff changeset
   968
        //upward project the initializer type
5dd899009525 8191802: Upward projection result is A<? extends Number> instead of A<? super Integer>
mcimadamore
parents: 47948
diff changeset
   969
        return types.upward(t, types.captures(t));
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   970
    }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   971
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   972
    Type checkMethod(final Type mtype,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   973
            final Symbol sym,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   974
            final Env<AttrContext> env,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   975
            final List<JCExpression> argtrees,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   976
            final List<Type> argtypes,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   977
            final boolean useVarargs,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   978
            InferenceContext inferenceContext) {
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   979
        // System.out.println("call   : " + env.tree);
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   980
        // System.out.println("method : " + owntype);
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   981
        // System.out.println("actuals: " + argtypes);
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   982
        if (inferenceContext.free(mtype)) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   983
            inferenceContext.addFreeTypeListener(List.of(mtype),
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
   984
                    solvedContext -> checkMethod(solvedContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, solvedContext));
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   985
            return mtype;
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   986
        }
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   987
        Type owntype = mtype;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   988
        List<Type> formals = owntype.getParameterTypes();
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   989
        List<Type> nonInferred = sym.type.getParameterTypes();
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   990
        if (nonInferred.length() != formals.length()) nonInferred = formals;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   991
        Type last = useVarargs ? formals.last() : null;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   992
        if (sym.name == names.init && sym.owner == syms.enumSym) {
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   993
            formals = formals.tail.tail;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   994
            nonInferred = nonInferred.tail.tail;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   995
        }
47248
22d665f53a4a 8044853: Attr synthesizes nullcheck tree nodes
jlahoda
parents: 47216
diff changeset
   996
        if ((sym.flags() & ANONCONSTR_BASED) != 0) {
22d665f53a4a 8044853: Attr synthesizes nullcheck tree nodes
jlahoda
parents: 47216
diff changeset
   997
            formals = formals.tail;
22d665f53a4a 8044853: Attr synthesizes nullcheck tree nodes
jlahoda
parents: 47216
diff changeset
   998
            nonInferred = nonInferred.tail;
22d665f53a4a 8044853: Attr synthesizes nullcheck tree nodes
jlahoda
parents: 47216
diff changeset
   999
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1000
        List<JCExpression> args = argtrees;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1001
        if (args != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1002
            //this is null when type-checking a method reference
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1003
            while (formals.head != last) {
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1004
                JCTree arg = args.head;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1005
                Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1006
                assertConvertible(arg, arg.type, formals.head, warn);
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1007
                args = args.tail;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1008
                formals = formals.tail;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1009
                nonInferred = nonInferred.tail;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1010
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1011
            if (useVarargs) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1012
                Type varArg = types.elemtype(last);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1013
                while (args.tail != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1014
                    JCTree arg = args.head;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1015
                    Warner warn = convertWarner(arg.pos(), arg.type, varArg);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1016
                    assertConvertible(arg, arg.type, varArg, warn);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1017
                    args = args.tail;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1018
                }
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1019
            } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1020
                // non-varargs call to varargs method
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1021
                Type varParam = owntype.getParameterTypes().last();
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
  1022
                Type lastArg = argtypes.last();
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1023
                if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1024
                    !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1025
                    log.warning(argtrees.last().pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1026
                                Warnings.InexactNonVarargsCall(types.elemtype(varParam),varParam));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1027
            }
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
  1028
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1029
        if (useVarargs) {
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1030
            Type argtype = owntype.getParameterTypes().last();
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1031
            if (!types.isReifiable(argtype) &&
51047
860a3648c494 8028563: Remove javac support for 6/1.6 source and target values
darcy
parents: 50539
diff changeset
  1032
                (sym.baseSymbol().attribute(syms.trustMeType.tsym) == null ||
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1033
                 !isTrustMeAllowedOnMethod(sym))) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  1034
                warnUnchecked(env.tree.pos(), Warnings.UncheckedGenericArrayCreation(argtype));
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1035
            }
50250
04f9bb270ab8 8203488: Remove error generation from TransTypes
mcimadamore
parents: 50213
diff changeset
  1036
            TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
04f9bb270ab8 8203488: Remove error generation from TransTypes
mcimadamore
parents: 50213
diff changeset
  1037
         }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1038
         return owntype;
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
  1039
    }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
  1040
    //where
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1041
    private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1042
        if (types.isConvertible(actual, formal, warn))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1043
            return;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1044
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1045
        if (formal.isCompound()
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1046
            && types.isSubtype(actual, types.supertype(formal))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1047
            && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1048
            return;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1049
    }
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
  1050
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1051
    /**
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1052
     * Check that type 't' is a valid instantiation of a generic class
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1053
     * (see JLS 4.5)
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1054
     *
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1055
     * @param t class type to be checked
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1056
     * @return true if 't' is well-formed
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1057
     */
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1058
    public boolean checkValidGenericType(Type t) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1059
        return firstIncompatibleTypeArg(t) == null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1060
    }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1061
    //WHERE
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1062
        private Type firstIncompatibleTypeArg(Type type) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1063
            List<Type> formals = type.tsym.type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1064
            List<Type> actuals = type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1065
            List<Type> args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1066
            List<Type> forms = type.tsym.type.getTypeArguments();
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1067
            ListBuffer<Type> bounds_buf = new ListBuffer<>();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1068
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1069
            // For matching pairs of actual argument types `a' and
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1070
            // formal type parameters with declared bound `b' ...
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1071
            while (args.nonEmpty() && forms.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1072
                // exact type arguments needs to know their
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1073
                // bounds (for upper and lower bound
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1074
                // calculations).  So we create new bounds where
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1075
                // type-parameters are replaced with actuals argument types.
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1076
                bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1077
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1078
                forms = forms.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1079
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1080
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1081
            args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1082
            List<Type> tvars_cap = types.substBounds(formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1083
                                      formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1084
                                      types.capture(type).allparams());
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1085
            while (args.nonEmpty() && tvars_cap.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1086
                // Let the actual arguments know their bound
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1087
                args.head.withTypeVar((TypeVar)tvars_cap.head);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1088
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1089
                tvars_cap = tvars_cap.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1090
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1091
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1092
            args = type.getTypeArguments();
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1093
            List<Type> bounds = bounds_buf.toList();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1094
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1095
            while (args.nonEmpty() && bounds.nonEmpty()) {
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1096
                Type actual = args.head;
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1097
                if (!isTypeArgErroneous(actual) &&
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1098
                        !bounds.head.isErroneous() &&
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1099
                        !checkExtends(actual, bounds.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1100
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1101
                }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1102
                args = args.tail;
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1103
                bounds = bounds.tail;
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1104
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1105
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1106
            args = type.getTypeArguments();
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1107
            bounds = bounds_buf.toList();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1108
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1109
            for (Type arg : types.capture(type).getTypeArguments()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1110
                if (arg.hasTag(TYPEVAR) &&
8044
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
  1111
                        arg.getUpperBound().isErroneous() &&
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1112
                        !bounds.head.isErroneous() &&
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1113
                        !isTypeArgErroneous(args.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1114
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1115
                }
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1116
                bounds = bounds.tail;
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1117
                args = args.tail;
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1118
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1119
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1120
            return null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1121
        }
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1122
        //where
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1123
        boolean isTypeArgErroneous(Type t) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1124
            return isTypeArgErroneous.visit(t);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1125
        }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1126
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1127
        Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1128
            public Boolean visitType(Type t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1129
                return t.isErroneous();
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1130
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1131
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1132
            public Boolean visitTypeVar(TypeVar t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1133
                return visit(t.getUpperBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1134
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1135
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1136
            public Boolean visitCapturedType(CapturedType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1137
                return visit(t.getUpperBound()) ||
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1138
                        visit(t.getLowerBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1139
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1140
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1141
            public Boolean visitWildcardType(WildcardType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1142
                return visit(t.type);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1143
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1144
        };
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1145
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1146
    /** Check that given modifiers are legal for given symbol and
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1147
     *  return modifiers together with any implicit modifiers for that symbol.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1148
     *  Warning: we can't use flags() here since this method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1149
     *  is called during class enter, when flags() would cause a premature
06bc494ca11e Initial load
duke
parents:
diff changeset
  1150
     *  completion.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1151
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1152
     *  @param flags         The set of modifiers given in a definition.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1153
     *  @param sym           The defined symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1154
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1155
    long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1156
        long mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
        long implicit = 0;
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1158
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
        switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1160
        case VAR:
24903
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1161
            if (TreeInfo.isReceiverParam(tree))
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1162
                mask = ReceiverParamFlags;
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1163
            else if (sym.owner.kind != TYP)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
                mask = LocalVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
            else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
                mask = implicit = InterfaceVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
                mask = VarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
        case MTH:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
            if (sym.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
                if ((sym.owner.flags_field & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
                    // enum constructors cannot be declared public or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
                    // protected and must be implicitly or explicitly
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
                    // private
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
                    implicit = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
                    mask = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
                } else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
                    mask = ConstructorFlags;
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1180
            }  else if ((sym.owner.flags_field & INTERFACE) != 0) {
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1181
                if ((sym.owner.flags_field & ANNOTATION) != 0) {
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1182
                    mask = AnnotationTypeElementMask;
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1183
                    implicit = PUBLIC | ABSTRACT;
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1184
                } else if ((flags & (DEFAULT | STATIC | PRIVATE)) != 0) {
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1185
                    mask = InterfaceMethodMask;
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1186
                    implicit = (flags & PRIVATE) != 0 ? 0 : PUBLIC;
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1187
                    if ((flags & DEFAULT) != 0) {
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1188
                        implicit |= ABSTRACT;
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1189
                    }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1190
                } else {
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1191
                    mask = implicit = InterfaceMethodFlags;
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1192
                }
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1193
            } else {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1194
                mask = MethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1195
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1196
            // Imply STRICTFP if owner has STRICTFP set.
17281
7c38e715fd75 8012723: strictfp interface misses strictfp modifer on default method
vromero
parents: 16546
diff changeset
  1197
            if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
7c38e715fd75 8012723: strictfp interface misses strictfp modifer on default method
vromero
parents: 16546
diff changeset
  1198
                ((flags) & Flags.DEFAULT) != 0)
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1199
                implicit |= sym.owner.flags_field & STRICTFP;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1200
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1201
        case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1202
            if (sym.isLocal()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1203
                mask = LocalClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1204
                if ((sym.owner.flags_field & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1205
                    (flags & ENUM) != 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1206
                    log.error(pos, Errors.EnumsMustBeStatic);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1207
            } else if (sym.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1208
                mask = MemberClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1209
                if (sym.owner.owner.kind == PCK ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1210
                    (sym.owner.flags_field & STATIC) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1211
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1212
                else if ((flags & ENUM) != 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1213
                    log.error(pos, Errors.EnumsMustBeStatic);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1214
                // Nested interfaces and enums are always STATIC (Spec ???)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1215
                if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1216
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1217
                mask = ClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1218
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1219
            // Interfaces are always ABSTRACT
06bc494ca11e Initial load
duke
parents:
diff changeset
  1220
            if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1221
06bc494ca11e Initial load
duke
parents:
diff changeset
  1222
            if ((flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1223
                // enums can't be declared abstract or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1224
                mask &= ~(ABSTRACT | FINAL);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1225
                implicit |= implicitEnumFinalFlag(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1226
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1227
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1228
            implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1229
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1230
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1231
            throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1232
        }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1233
        long illegal = flags & ExtendedStandardFlags & ~mask;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1234
        if (illegal != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1235
            if ((illegal & INTERFACE) != 0) {
45867
ca77ebd05a06 8074364: Update error message for incorrect annotation type declaration
pmuthuswamy
parents: 45758
diff changeset
  1236
                log.error(pos, ((flags & ANNOTATION) != 0) ? Errors.AnnotationDeclNotAllowedHere : Errors.IntfNotAllowedHere);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1237
                mask |= INTERFACE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1238
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1239
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1240
                log.error(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1241
                          Errors.ModNotAllowedHere(asFlagSet(illegal)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1242
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
        else if ((sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1245
                  // ISSUE: Disallowing abstract&private is no longer appropriate
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
                  // in the presence of inner classes. Should it be deleted here?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1247
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1248
                                ABSTRACT,
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1249
                                PRIVATE | STATIC | DEFAULT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1250
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1251
                 checkDisjoint(pos, flags,
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1252
                                STATIC | PRIVATE,
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1253
                                DEFAULT)
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1254
                 &&
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1255
                 checkDisjoint(pos, flags,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
                               ABSTRACT | INTERFACE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
                               FINAL | NATIVE | SYNCHRONIZED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
                               PUBLIC,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
                               PRIVATE | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1263
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
                               PRIVATE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1265
                               PUBLIC | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1266
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1267
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
                               FINAL,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
                               VOLATILE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1271
                 (sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1272
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1273
                                ABSTRACT | NATIVE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1274
                                STRICTFP))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1275
            // skip
06bc494ca11e Initial load
duke
parents:
diff changeset
  1276
        }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1277
        return flags & (mask | ~ExtendedStandardFlags) | implicit;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1278
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1279
06bc494ca11e Initial load
duke
parents:
diff changeset
  1280
06bc494ca11e Initial load
duke
parents:
diff changeset
  1281
    /** Determine if this enum should be implicitly final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1282
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1283
     *  If the enum has no specialized enum contants, it is final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1284
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1285
     *  If the enum does have specialized enum contants, it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1286
     *  <i>not</i> final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1287
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
    private long implicitEnumFinalFlag(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  1289
        if (!tree.hasTag(CLASSDEF)) return 0;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1290
        class SpecialTreeVisitor extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1291
            boolean specialized;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1292
            SpecialTreeVisitor() {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1293
                this.specialized = false;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1294
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1295
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1296
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
            public void visitTree(JCTree tree) { /* no-op */ }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1299
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
            public void visitVarDef(JCVariableDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1301
                if ((tree.mods.flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
                    if (tree.init instanceof JCNewClass &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
                        ((JCNewClass) tree.init).def != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
                        specialized = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1307
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1308
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1309
06bc494ca11e Initial load
duke
parents:
diff changeset
  1310
        SpecialTreeVisitor sts = new SpecialTreeVisitor();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1311
        JCClassDecl cdef = (JCClassDecl) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1312
        for (JCTree defs: cdef.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1313
            defs.accept(sts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1314
            if (sts.specialized) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1315
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1316
        return FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1317
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1318
06bc494ca11e Initial load
duke
parents:
diff changeset
  1319
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1320
 * Type Validation
06bc494ca11e Initial load
duke
parents:
diff changeset
  1321
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1322
06bc494ca11e Initial load
duke
parents:
diff changeset
  1323
    /** Validate a type expression. That is,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1324
     *  check that all type arguments of a parametric type are within
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17552
diff changeset
  1325
     *  their bounds. This must be done in a second phase after type attribution
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
     *  since a class might have a subclass as type parameter bound. E.g:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
     *
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
  1328
     *  <pre>{@code
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1329
     *  class B<A extends C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1330
     *  class C extends B<C> { ... }
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
  1331
     *  }</pre>
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1332
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1333
     *  and we can't make sure that the bound is already attributed because
06bc494ca11e Initial load
duke
parents:
diff changeset
  1334
     *  of possible cycles.
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1335
     *
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1336
     * Visitor method: Validate a type expression, if it is not null, catching
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1337
     *  and reporting any completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1338
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1339
    void validate(JCTree tree, Env<AttrContext> env) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1340
        validate(tree, env, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1341
    }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1342
    void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1343
        new Validator(env).validateTree(tree, checkRaw, true);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1344
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1345
06bc494ca11e Initial load
duke
parents:
diff changeset
  1346
    /** Visitor method: Validate a list of type expressions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1347
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1348
    void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1349
        for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1350
            validate(l.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
06bc494ca11e Initial load
duke
parents:
diff changeset
  1353
    /** A visitor class for type validation.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1354
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1355
    class Validator extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1356
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1357
        boolean checkRaw;
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1358
        boolean isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1359
        Env<AttrContext> env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1360
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1361
        Validator(Env<AttrContext> env) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1362
            this.env = env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1363
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1364
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1365
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
        public void visitTypeArray(JCArrayTypeTree tree) {
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1367
            validateTree(tree.elemtype, checkRaw, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1368
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1369
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1370
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1371
        public void visitTypeApply(JCTypeApply tree) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1372
            if (tree.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
                List<JCExpression> args = tree.arguments;
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
  1374
                List<Type> forms = tree.type.tsym.type.getTypeArguments();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1375
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1376
                Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1377
                if (incompatibleArg != null) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1378
                    for (JCTree arg : tree.arguments) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1379
                        if (arg.type == incompatibleArg) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1380
                            log.error(arg, Errors.NotWithinBounds(incompatibleArg, forms.head));
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1381
                        }
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1382
                        forms = forms.tail;
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1383
                     }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1384
                 }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1385
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1386
                forms = tree.type.tsym.type.getTypeArguments();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1387
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1388
                boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1389
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
                // For matching pairs of actual argument types `a' and
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
                // formal type parameters with declared bound `b' ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1392
                while (args.nonEmpty() && forms.nonEmpty()) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1393
                    validateTree(args.head,
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1394
                            !(isOuter && is_java_lang_Class),
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1395
                            false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1396
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1397
                    forms = forms.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1398
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1399
06bc494ca11e Initial load
duke
parents:
diff changeset
  1400
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1401
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1402
                if (tree.type.getEnclosingType().isRaw())
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1403
                    log.error(tree.pos(), Errors.ImproperlyFormedTypeInnerRawParam);
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  1404
                if (tree.clazz.hasTag(SELECT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1405
                    visitSelectInternal((JCFieldAccess)tree.clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1406
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1407
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1408
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1409
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1410
        public void visitTypeParameter(JCTypeParameter tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1411
            validateTrees(tree.bounds, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1412
            checkClassBounds(tree.pos(), tree.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1413
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1414
06bc494ca11e Initial load
duke
parents:
diff changeset
  1415
        @Override
06bc494ca11e Initial load
duke
parents:
diff changeset
  1416
        public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1417
            if (tree.inner != null)
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1418
                validateTree(tree.inner, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1419
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1420
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1421
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1422
        public void visitSelect(JCFieldAccess tree) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1423
            if (tree.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1424
                visitSelectInternal(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1425
06bc494ca11e Initial load
duke
parents:
diff changeset
  1426
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1427
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1428
                if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1429
                    log.error(tree.pos(), Errors.ImproperlyFormedTypeParamMissing);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1430
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1431
        }
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1432
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1433
        public void visitSelectInternal(JCFieldAccess tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1434
            if (tree.type.tsym.isStatic() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1435
                tree.selected.type.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1436
                // The enclosing type is not a class, so we are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1437
                // looking at a static member type.  However, the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1438
                // qualifying expression is parameterized.
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1439
                log.error(tree.pos(), Errors.CantSelectStaticClassFromParamType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1440
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1441
                // otherwise validate the rest of the expression
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1442
                tree.selected.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1443
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1444
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1445
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1446
        @Override
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1447
        public void visitAnnotatedType(JCAnnotatedType tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1448
            tree.underlyingType.accept(this);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1449
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1450
21896
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1451
        @Override
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1452
        public void visitTypeIdent(JCPrimitiveTypeTree that) {
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1453
            if (that.type.hasTag(TypeTag.VOID)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1454
                log.error(that.pos(), Errors.VoidNotAllowedHere);
21896
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1455
            }
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1456
            super.visitTypeIdent(that);
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1457
        }
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1458
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1459
        /** Default visitor method: do nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1460
         */
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1461
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1462
        public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1463
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1464
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1465
        public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1466
            if (tree != null) {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1467
                boolean prevCheckRaw = this.checkRaw;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1468
                this.checkRaw = checkRaw;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1469
                this.isOuter = isOuter;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1470
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1471
                try {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1472
                    tree.accept(this);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1473
                    if (checkRaw)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1474
                        checkRaw(tree, env);
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1475
                } catch (CompletionFailure ex) {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1476
                    completionError(tree.pos(), ex);
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1477
                } finally {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1478
                    this.checkRaw = prevCheckRaw;
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1479
                }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1480
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1481
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1482
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1483
        public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1484
            for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1485
                validateTree(l.head, checkRaw, isOuter);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1486
        }
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1487
    }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1488
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1489
    void checkRaw(JCTree tree, Env<AttrContext> env) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1490
        if (lint.isEnabled(LintCategory.RAW) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1491
            tree.type.hasTag(CLASS) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1492
            !TreeInfo.isDiamond(tree) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1493
            !withinAnonConstr(env) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1494
            tree.type.isRaw()) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1495
            log.warning(LintCategory.RAW,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1496
                    tree.pos(), Warnings.RawClassUse(tree.type, tree.type.tsym.type));
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1497
        }
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1498
    }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1499
    //where
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1500
        private boolean withinAnonConstr(Env<AttrContext> env) {
10721
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1501
            return env.enclClass.name.isEmpty() &&
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1502
                    env.enclMethod != null && env.enclMethod.name == names.init;
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1503
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1504
06bc494ca11e Initial load
duke
parents:
diff changeset
  1505
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1506
 * Exception checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1507
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1508
06bc494ca11e Initial load
duke
parents:
diff changeset
  1509
    /* The following methods treat classes as sets that contain
06bc494ca11e Initial load
duke
parents:
diff changeset
  1510
     * the class itself and all their subclasses
06bc494ca11e Initial load
duke
parents:
diff changeset
  1511
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1512
06bc494ca11e Initial load
duke
parents:
diff changeset
  1513
    /** Is given type a subtype of some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1514
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1515
    boolean subset(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1516
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1517
            if (types.isSubtype(t, l.head)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1518
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1519
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1520
06bc494ca11e Initial load
duke
parents:
diff changeset
  1521
    /** Is given type a subtype or supertype of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1522
     *  some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1523
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
    boolean intersects(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
            if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
    /** Add type set to given type list, unless it is a subclass of some class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
     *  in the list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
    List<Type> incl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
        return subset(t, ts) ? ts : excl(t, ts).prepend(t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1535
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1536
06bc494ca11e Initial load
duke
parents:
diff changeset
  1537
    /** Remove type set from type set list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1538
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1539
    List<Type> excl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1540
        if (ts.isEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1541
            return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1542
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1543
            List<Type> ts1 = excl(t, ts.tail);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1544
            if (types.isSubtype(ts.head, t)) return ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1545
            else if (ts1 == ts.tail) return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1546
            else return ts1.prepend(ts.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1547
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1548
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1549
06bc494ca11e Initial load
duke
parents:
diff changeset
  1550
    /** Form the union of two type set lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
    List<Type> union(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1555
            ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1556
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1557
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1558
06bc494ca11e Initial load
duke
parents:
diff changeset
  1559
    /** Form the difference of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
    List<Type> diff(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1564
            ts = excl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
    /** Form the intersection of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1569
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
    public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
        List<Type> ts = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
        for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
            if (subset(l.head, ts2)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
            if (subset(l.head, ts1)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
    /** Is exc an exception symbol that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
    boolean isUnchecked(ClassSymbol exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
            exc.kind == ERR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
            exc.isSubClass(syms.errorType.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
            exc.isSubClass(syms.runtimeExceptionType.tsym, types);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1586
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1587
06bc494ca11e Initial load
duke
parents:
diff changeset
  1588
    /** Is exc an exception type that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1589
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1590
    boolean isUnchecked(Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1591
        return
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1592
            (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1593
            (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1594
            exc.hasTag(BOT);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1595
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1596
45756
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45504
diff changeset
  1597
    boolean isChecked(Type exc) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45504
diff changeset
  1598
        return !isUnchecked(exc);
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45504
diff changeset
  1599
    }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45504
diff changeset
  1600
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1601
    /** Same, but handling completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1602
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1603
    boolean isUnchecked(DiagnosticPosition pos, Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1605
            return isUnchecked(exc);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1606
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1607
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1608
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1609
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1610
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1611
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
    /** Is exc handled by given exception list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1613
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1614
    boolean isHandled(Type exc, List<Type> handled) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1615
        return isUnchecked(exc) || subset(exc, handled);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1616
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1617
06bc494ca11e Initial load
duke
parents:
diff changeset
  1618
    /** Return all exceptions in thrown list that are not in handled list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1619
     *  @param thrown     The list of thrown exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1620
     *  @param handled    The list of handled exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1621
     */
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1622
    List<Type> unhandled(List<Type> thrown, List<Type> handled) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1623
        List<Type> unhandled = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1624
        for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1625
            if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1626
        return unhandled;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1627
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
06bc494ca11e Initial load
duke
parents:
diff changeset
  1629
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1630
 * Overriding/Implementation checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1631
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1632
06bc494ca11e Initial load
duke
parents:
diff changeset
  1633
    /** The level of access protection given by a flag set,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1634
     *  where PRIVATE is highest and PUBLIC is lowest.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1635
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
    static int protection(long flags) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1637
        switch ((short)(flags & AccessFlags)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1638
        case PRIVATE: return 3;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
        case PROTECTED: return 1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1640
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1641
        case PUBLIC: return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1642
        case 0: return 2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1644
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
    /** A customized "cannot override" error message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1647
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1648
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1649
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1650
     */
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1651
    Fragment cannotOverride(MethodSymbol m, MethodSymbol other) {
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1652
        Symbol mloc = m.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1653
        Symbol oloc = other.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1654
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1655
        if ((other.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1656
            return Fragments.CantOverride(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1657
        else if ((m.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1658
            return Fragments.CantImplement(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1659
        else
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1660
            return Fragments.ClashesWith(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1662
06bc494ca11e Initial load
duke
parents:
diff changeset
  1663
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1664
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1665
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1666
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1667
     */
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1668
    Fragment uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1669
        Symbol mloc = m.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1670
        Symbol oloc = other.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1671
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1672
        if ((other.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1673
            return Fragments.UncheckedOverride(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
        else if ((m.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1675
            return Fragments.UncheckedImplement(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1676
        else
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1677
            return Fragments.UncheckedClashWith(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
06bc494ca11e Initial load
duke
parents:
diff changeset
  1680
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1682
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1683
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1684
     */
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1685
    Fragment varargsOverrides(MethodSymbol m, MethodSymbol other) {
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1686
        Symbol mloc = m.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1687
        Symbol oloc = other.location();
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1688
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1689
        if ((other.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1690
            return Fragments.VarargsOverride(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
        else  if ((m.owner.flags() & INTERFACE) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1692
            return Fragments.VarargsImplement(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
        else
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1694
            return Fragments.VarargsClashWith(m, mloc, other, oloc);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
    /** Check that this method conforms with overridden method 'other'.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1698
     *  where `origin' is the class where checking started.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1699
     *  Complications:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
     *  (1) Do not check overriding of synthetic methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1701
     *      (reason: they might be final).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1702
     *      todo: check whether this is still necessary.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1703
     *  (2) Admit the case where an interface proxy throws fewer exceptions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1704
     *      than the method it implements. Augment the proxy methods with the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
     *      undeclared exceptions in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
     *  (3) When generics are enabled, admit the case where an interface proxy
06bc494ca11e Initial load
duke
parents:
diff changeset
  1707
     *      has a result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1708
     *      extended by the result type of the method it implements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1709
     *      Change the proxies result type to the smaller type in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1710
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1711
     *  @param tree         The tree from which positions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
     *                      are extracted for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
     *  @param other        The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
     *  @param origin       The class of which the overriding method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
     *                      is a member.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
    void checkOverride(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1719
                       MethodSymbol m,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
                       MethodSymbol other,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
                       ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
        // Don't check overriding of synthetic methods or by bridge methods.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
        if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1724
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1725
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1726
06bc494ca11e Initial load
duke
parents:
diff changeset
  1727
        // Error if static method overrides instance method (JLS 8.4.6.2).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1728
        if ((m.flags() & STATIC) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1729
                   (other.flags() & STATIC) == 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1730
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1731
                      Errors.OverrideStatic(cannotOverride(m, other)));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1732
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1734
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1735
06bc494ca11e Initial load
duke
parents:
diff changeset
  1736
        // Error if instance method overrides static or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1737
        // method (JLS 8.4.6.1).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1738
        if ((other.flags() & FINAL) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
                 (m.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1740
                 (other.flags() & STATIC) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1741
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1742
                      Errors.OverrideMeth(cannotOverride(m, other),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1743
                                          asFlagSet(other.flags() & (FINAL | STATIC))));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1744
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1746
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1747
06bc494ca11e Initial load
duke
parents:
diff changeset
  1748
        if ((m.owner.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1749
            // handled in validateAnnotationMethod
06bc494ca11e Initial load
duke
parents:
diff changeset
  1750
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1751
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1752
06bc494ca11e Initial load
duke
parents:
diff changeset
  1753
        // Error if overriding method has weaker access (JLS 8.4.6.3).
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1754
        if (protection(m.flags()) > protection(other.flags())) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1755
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
23796
4c722b177a8f 8035956: javac, incomplete error message
kizune
parents: 23111
diff changeset
  1756
                      (other.flags() & AccessFlags) == 0 ?
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1757
                              Errors.OverrideWeakerAccess(cannotOverride(m, other),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1758
                                                          "package") :
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1759
                              Errors.OverrideWeakerAccess(cannotOverride(m, other),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1760
                                                          asFlagSet(other.flags() & AccessFlags)));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1761
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
        Type mt = types.memberType(origin.type, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1766
        Type ot = types.memberType(origin.type, other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1767
        // Error if overriding result type is different
06bc494ca11e Initial load
duke
parents:
diff changeset
  1768
        // (or, in the case of generics mode, not a subtype) of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1769
        // overridden result type. We have to rename any type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  1770
        // before comparing types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1771
        List<Type> mtvars = mt.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1772
        List<Type> otvars = ot.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1773
        Type mtres = mt.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1774
        Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1775
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1776
        overrideWarner.clear();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1777
        boolean resultTypesOK =
1874
891c2d6823bb 6797463: 6557199 breaks the jax-ws workspace
tbell
parents: 1868
diff changeset
  1778
            types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
        if (!resultTypesOK) {
33713
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1780
            if ((m.flags() & STATIC) != 0 && (other.flags() & STATIC) != 0) {
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1781
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1782
                          Errors.OverrideIncompatibleRet(Fragments.CantHide(m, m.location(), other,
33713
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1783
                                        other.location()), mtres, otres));
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1784
                m.flags_field |= BAD_OVERRIDE;
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1785
            } else {
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1786
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1787
                          Errors.OverrideIncompatibleRet(cannotOverride(m, other), mtres, otres));
33713
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1788
                m.flags_field |= BAD_OVERRIDE;
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1789
            }
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1790
            return;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1791
        } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1792
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  1793
                    Warnings.OverrideUncheckedRet(uncheckedOverrides(m, other), mtres, otres));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1794
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1795
06bc494ca11e Initial load
duke
parents:
diff changeset
  1796
        // Error if overriding method throws an exception not reported
06bc494ca11e Initial load
duke
parents:
diff changeset
  1797
        // by overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
        List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1799
        List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1800
        List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1801
        if (unhandledErased.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1802
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1803
                      Errors.OverrideMethDoesntThrow(cannotOverride(m, other), unhandledUnerased.head));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1804
            m.flags_field |= BAD_OVERRIDE;
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1805
            return;
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1806
        }
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1807
        else if (unhandledUnerased.nonEmpty()) {
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1808
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  1809
                          Warnings.OverrideUncheckedThrown(cannotOverride(m, other), unhandledUnerased.head));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1810
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1812
06bc494ca11e Initial load
duke
parents:
diff changeset
  1813
        // Optional warning if varargs don't agree
06bc494ca11e Initial load
duke
parents:
diff changeset
  1814
        if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1815
            && lint.isEnabled(LintCategory.OVERRIDES)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1816
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1817
                        ((m.flags() & Flags.VARARGS) != 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1818
                        ? Warnings.OverrideVarargsMissing(varargsOverrides(m, other))
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1819
                        : Warnings.OverrideVarargsExtra(varargsOverrides(m, other)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1820
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1821
06bc494ca11e Initial load
duke
parents:
diff changeset
  1822
        // Warn if instance method overrides bridge method (compiler spec ??)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1823
        if ((other.flags() & BRIDGE) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1824
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1825
                        Warnings.OverrideBridge(uncheckedOverrides(m, other)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1826
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1827
06bc494ca11e Initial load
duke
parents:
diff changeset
  1828
        // Warn if a deprecated method overridden by a non-deprecated one.
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1829
        if (!isDeprecatedOverrideIgnorable(other, origin)) {
23111
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1830
            Lint prevLint = setLint(lint.augment(m));
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1831
            try {
53037
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  1832
                checkDeprecated(() -> TreeInfo.diagnosticPositionFor(m, tree), m, other);
23111
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1833
            } finally {
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1834
                setLint(prevLint);
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1835
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1836
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1837
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1838
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1839
        private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1840
            // If the method, m, is defined in an interface, then ignore the issue if the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1841
            // is only inherited via a supertype and also implemented in the supertype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1842
            // because in that case, we will rediscover the issue when examining the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1843
            // in the supertype.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1844
            // If the method, m, is not defined in an interface, then the only time we need to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1845
            // address the issue is when the method is the supertype implemementation: any other
06bc494ca11e Initial load
duke
parents:
diff changeset
  1846
            // case, we will have dealt with when examining the supertype classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1847
            ClassSymbol mc = m.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1848
            Type st = types.supertype(origin.type);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1849
            if (!st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1850
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1851
            MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1852
06bc494ca11e Initial load
duke
parents:
diff changeset
  1853
            if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1854
                List<Type> intfs = types.interfaces(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1855
                return (intfs.contains(mc.type) ? false : (stimpl != null));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1856
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1857
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
                return (stimpl != m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1859
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1860
06bc494ca11e Initial load
duke
parents:
diff changeset
  1861
06bc494ca11e Initial load
duke
parents:
diff changeset
  1862
    // used to check if there were any unchecked conversions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1863
    Warner overrideWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1864
06bc494ca11e Initial load
duke
parents:
diff changeset
  1865
    /** Check that a class does not inherit two concrete methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1866
     *  with the same signature.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1867
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1868
     *  @param site         The class type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1870
    public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1871
        Type sup = types.supertype(site);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1872
        if (!sup.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1873
06bc494ca11e Initial load
duke
parents:
diff changeset
  1874
        for (Type t1 = sup;
19503
58688e470d3b 8022508: javac crashes if the generics arity of a base class is wrong
jlahoda
parents: 19492
diff changeset
  1875
             t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1876
             t1 = types.supertype(t1)) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1877
            for (Symbol s1 : t1.tsym.members().getSymbols(NON_RECURSIVE)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1878
                if (s1.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1879
                    (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
                    !s1.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1881
                    ((MethodSymbol)s1).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1882
                                                      types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1883
                                                      true) != s1)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1884
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1885
                Type st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1886
                int s1ArgsLength = st1.getParameterTypes().length();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1887
                if (st1 == s1.type) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
                for (Type t2 = sup;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1890
                     t2.hasTag(CLASS);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1891
                     t2 = types.supertype(t2)) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1892
                    for (Symbol s2 : t2.tsym.members().getSymbolsByName(s1.name)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
                        if (s2 == s1 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
                            s2.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
                            (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
                            s2.type.getParameterTypes().length() != s1ArgsLength ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1897
                            !s2.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1898
                            ((MethodSymbol)s2).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1899
                                                              types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1900
                                                              true) != s2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1901
                            continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1902
                        Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1903
                        if (types.overrideEquivalent(st1, st2))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1904
                            log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  1905
                                      Errors.ConcreteInheritanceConflict(s1, t1, s2, t2, sup));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1906
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1907
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1908
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1909
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1910
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1911
06bc494ca11e Initial load
duke
parents:
diff changeset
  1912
    /** Check that classes (or interfaces) do not each define an abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1913
     *  method with same name and arguments but incompatible return types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1914
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1915
     *  @param t1           The first argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
     *  @param t2           The second argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1917
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1918
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1919
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1920
                                            Type t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1921
                                            Type site) {
24902
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1922
        if ((site.tsym.flags() & COMPOUND) != 0) {
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1923
            // special case for intersections: need to eliminate wildcards in supertypes
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1924
            t1 = types.capture(t1);
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1925
            t2 = types.capture(t2);
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1926
        }
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1927
        return firstIncompatibility(pos, t1, t2, site) == null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
06bc494ca11e Initial load
duke
parents:
diff changeset
  1930
    /** Return the first method which is defined with same args
06bc494ca11e Initial load
duke
parents:
diff changeset
  1931
     *  but different return types in two given interfaces, or null if none
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
     *  exists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1933
     *  @param t1     The first type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1934
     *  @param t2     The second type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
     *  @param site   The most derived type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1936
     *  @returns symbol from t2 that conflicts with one in t1.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1937
     */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1938
    private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1939
        Map<TypeSymbol,Type> interfaces1 = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1940
        closure(t1, interfaces1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1941
        Map<TypeSymbol,Type> interfaces2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
        if (t1 == t2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
            interfaces2 = interfaces1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1944
        else
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1945
            closure(t2, interfaces1, interfaces2 = new HashMap<>());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1946
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
        for (Type t3 : interfaces1.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
            for (Type t4 : interfaces2.values()) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1949
                Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1950
                if (s != null) return s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1951
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1952
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1953
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1954
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1955
06bc494ca11e Initial load
duke
parents:
diff changeset
  1956
    /** Compute all the supertypes of t, indexed by type symbol. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1957
    private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1958
        if (!t.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1959
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1960
            closure(types.supertype(t), typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1961
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1962
                closure(i, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1963
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1964
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1965
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
    /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1967
    private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1968
        if (!t.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
        if (typesSkip.get(t.tsym) != null) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
            closure(types.supertype(t), typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
                closure(i, typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1975
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
    /** Return the first method in t2 that conflicts with a method from t1. */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1978
    private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1979
        for (Symbol s1 : t1.tsym.members().getSymbols(NON_RECURSIVE)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
            Type st1 = null;
14800
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1981
            if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1982
                    (s1.flags() & SYNTHETIC) != 0) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
            Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
            if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1985
            for (Symbol s2 : t2.tsym.members().getSymbolsByName(s1.name)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1986
                if (s1 == s2) continue;
14800
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1987
                if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1988
                        (s2.flags() & SYNTHETIC) != 0) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
                if (st1 == null) st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
                Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
                if (types.overrideEquivalent(st1, st2)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1992
                    List<Type> tvars1 = st1.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
                    List<Type> tvars2 = st2.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
                    Type rt1 = st1.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1995
                    Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1996
                    boolean compat =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1997
                        types.isSameType(rt1, rt2) ||
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1998
                        !rt1.isPrimitiveOrVoid() &&
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1999
                        !rt2.isPrimitiveOrVoid() &&
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2000
                        (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2001
                         types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2002
                         checkCommonOverriderIn(s1,s2,site);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2003
                    if (!compat) {
48352
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2004
                        log.error(pos, Errors.TypesIncompatible(t1, t2,
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2005
                                Fragments.IncompatibleDiffRet(s2.name, types.memberType(t2, s2).getParameterTypes())));
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2006
                        return s2;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2007
                    }
8610
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  2008
                } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  2009
                        !checkCommonOverriderIn(s1, s2, site)) {
45413
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2010
                    log.error(pos, Errors.NameClashSameErasureNoOverride(
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2011
                            s1.name, types.memberType(site, s1).asMethodType().getParameterTypes(), s1.location(),
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2012
                            s2.name, types.memberType(site, s2).asMethodType().getParameterTypes(), s2.location()));
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2013
                    return s2;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2014
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2015
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2016
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2017
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2018
    }
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2019
    //WHERE
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2020
    boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2021
        Map<TypeSymbol,Type> supertypes = new HashMap<>();
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2022
        Type st1 = types.memberType(site, s1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2023
        Type st2 = types.memberType(site, s2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2024
        closure(site, supertypes);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2025
        for (Type t : supertypes.values()) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2026
            for (Symbol s3 : t.tsym.members().getSymbolsByName(s1.name)) {
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2027
                if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2028
                Type st3 = types.memberType(site,s3);
18380
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  2029
                if (types.overrideEquivalent(st3, st1) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  2030
                        types.overrideEquivalent(st3, st2) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  2031
                        types.returnTypeSubstitutable(st3, st1) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  2032
                        types.returnTypeSubstitutable(st3, st2)) {
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  2033
                    return true;
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2034
                }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2035
            }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2036
        }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2037
        return false;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  2038
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2039
06bc494ca11e Initial load
duke
parents:
diff changeset
  2040
    /** Check that a given method conforms with any method it overrides.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2041
     *  @param tree         The tree from which positions are extracted
06bc494ca11e Initial load
duke
parents:
diff changeset
  2042
     *                      for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2043
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2044
     */
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2045
    void checkOverride(Env<AttrContext> env, JCMethodDecl tree, MethodSymbol m) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2046
        ClassSymbol origin = (ClassSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2047
        if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2048
            if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2049
                log.error(tree.pos(), Errors.EnumNoFinalize);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2050
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2051
            }
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2052
        for (Type t = origin.type; t.hasTag(CLASS);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2053
             t = types.supertype(t)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2054
            if (t != origin.type) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2055
                checkOverride(tree, t, origin, m);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2056
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2057
            for (Type t2 : types.interfaces(t)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2058
                checkOverride(tree, t2, origin, m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2059
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2060
        }
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2061
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2062
        final boolean explicitOverride = m.attribute(syms.overrideType.tsym) != null;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2063
        // Check if this method must override a super method due to being annotated with @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2064
        // or by virtue of being a member of a diamond inferred anonymous class. Latter case is to
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2065
        // be treated "as if as they were annotated" with @Override.
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2066
        boolean mustOverride = explicitOverride ||
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2067
                (env.info.isAnonymousDiamond && !m.isConstructor() && !m.isPrivate());
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2068
        if (mustOverride && !isOverrider(m)) {
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2069
            DiagnosticPosition pos = tree.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2070
            for (JCAnnotation a : tree.getModifiers().annotations) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2071
                if (a.annotationType.type.tsym == syms.overrideType.tsym) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2072
                    pos = a.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2073
                    break;
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2074
                }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2075
            }
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2076
            log.error(pos,
45758
b2a0122861f5 8068836: Error message should be updated when Override is used with static methods
sadayapalam
parents: 45756
diff changeset
  2077
                      explicitOverride ? (m.isStatic() ? Errors.StaticMethodsCannotBeAnnotatedWithOverride : Errors.MethodDoesNotOverrideSuperclass) :
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2078
                                Errors.AnonymousDiamondMethodDoesNotOverrideSuperclass(Fragments.DiamondAnonymousMethodsImplicitlyOverride));
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2079
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2080
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2081
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2082
    void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2083
        TypeSymbol c = site.tsym;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2084
        for (Symbol sym : c.members().getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2085
            if (m.overrides(sym, origin, types, false)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2086
                if ((sym.flags() & ABSTRACT) == 0) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2087
                    checkOverride(tree, m, (MethodSymbol)sym, origin);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2088
                }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2089
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2090
        }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2091
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2092
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  2093
    private Filter<Symbol> equalsHasCodeFilter = s -> MethodSymbol.implementation_filter.accepts(s) &&
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  2094
            (s.flags() & BAD_OVERRIDE) == 0;
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2095
16333
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2096
    public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2097
            ClassSymbol someClass) {
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2098
        /* At present, annotations cannot possibly have a method that is override
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2099
         * equivalent with Object.equals(Object) but in any case the condition is
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2100
         * fine for completeness.
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2101
         */
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2102
        if (someClass == (ClassSymbol)syms.objectType.tsym ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2103
            someClass.isInterface() || someClass.isEnum() ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2104
            (someClass.flags() & ANNOTATION) != 0 ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2105
            (someClass.flags() & ABSTRACT) != 0) return;
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2106
        //anonymous inner classes implementing interfaces need especial treatment
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2107
        if (someClass.isAnonymous()) {
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2108
            List<Type> interfaces =  types.interfaces(someClass.type);
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2109
            if (interfaces != null && !interfaces.isEmpty() &&
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2110
                interfaces.head.tsym == syms.comparatorType.tsym) return;
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2111
        }
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2112
        checkClassOverrideEqualsAndHash(pos, someClass);
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2113
    }
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2114
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2115
    private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2116
            ClassSymbol someClass) {
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2117
        if (lint.isEnabled(LintCategory.OVERRIDES)) {
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2118
            MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2119
                    .tsym.members().findFirst(names.equals);
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2120
            MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2121
                    .tsym.members().findFirst(names.hashCode);
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2122
            boolean overridesEquals = types.implementation(equalsAtObject,
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2123
                someClass, false, equalsHasCodeFilter).owner == someClass;
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2124
            boolean overridesHashCode = types.implementation(hashCodeAtObject,
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2125
                someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2126
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2127
            if (overridesEquals && !overridesHashCode) {
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2128
                log.warning(LintCategory.OVERRIDES, pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2129
                            Warnings.OverrideEqualsButNotHashcode(someClass));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2130
            }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2131
        }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2132
    }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2133
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2134
    public void checkModuleName (JCModuleDecl tree) {
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2135
        Name moduleName = tree.sym.name;
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2136
        Assert.checkNonNull(moduleName);
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2137
        if (lint.isEnabled(LintCategory.MODULE)) {
44568
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2138
            JCExpression qualId = tree.qualId;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2139
            while (qualId != null) {
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2140
                Name componentName;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2141
                DiagnosticPosition pos;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2142
                switch (qualId.getTag()) {
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2143
                    case SELECT:
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2144
                        JCFieldAccess selectNode = ((JCFieldAccess) qualId);
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2145
                        componentName = selectNode.name;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2146
                        pos = selectNode.pos();
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2147
                        qualId = selectNode.selected;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2148
                        break;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2149
                    case IDENT:
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2150
                        componentName = ((JCIdent) qualId).name;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2151
                        pos = qualId.pos();
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2152
                        qualId = null;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2153
                        break;
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2154
                    default:
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2155
                        throw new AssertionError("Unexpected qualified identifier: " + qualId.toString());
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2156
                }
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2157
                if (componentName != null) {
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2158
                    String moduleNameComponentString = componentName.toString();
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2159
                    int nameLength = moduleNameComponentString.length();
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2160
                    if (nameLength > 0 && Character.isDigit(moduleNameComponentString.charAt(nameLength - 1))) {
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2161
                        log.warning(Lint.LintCategory.MODULE, pos, Warnings.PoorChoiceForModuleName(componentName));
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2162
                    }
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 43588
diff changeset
  2163
                }
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2164
            }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2165
        }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2166
    }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  2167
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2168
    private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2169
        ClashFilter cf = new ClashFilter(origin.type);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2170
        return (cf.accepts(s1) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2171
                cf.accepts(s2) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2172
                types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2173
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2174
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2175
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2176
    /** Check that all abstract members of given class have definitions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2177
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2178
     *  @param c            The class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2179
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2180
    void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
28459
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2181
        MethodSymbol undef = types.firstUnimplementedAbstract(c);
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2182
        if (undef != null) {
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2183
            MethodSymbol undef1 =
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2184
                new MethodSymbol(undef.flags(), undef.name,
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2185
                                 types.memberType(c.type, undef), undef.owner);
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2186
            log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2187
                      Errors.DoesNotOverrideAbstract(c, undef1, undef1.location()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2188
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2189
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2190
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2191
    void checkNonCyclicDecl(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2192
        CycleChecker cc = new CycleChecker();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2193
        cc.scan(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2194
        if (!cc.errorFound && !cc.partialCheck) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2195
            tree.sym.flags_field |= ACYCLIC;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2196
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2197
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2198
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2199
    class CycleChecker extends TreeScanner {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2200
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2201
        List<Symbol> seenClasses = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2202
        boolean errorFound = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2203
        boolean partialCheck = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2204
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2205
        private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2206
            if (sym != null && sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2207
                Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2208
                if (classEnv != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2209
                    DiagnosticSource prevSource = log.currentSource();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2210
                    try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2211
                        log.useSource(classEnv.toplevel.sourcefile);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2212
                        scan(classEnv.tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2213
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2214
                    finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2215
                        log.useSource(prevSource.getFile());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2216
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2217
                } else if (sym.kind == TYP) {
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2218
                    checkClass(pos, sym, List.nil());
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2219
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2220
            } else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2221
                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2222
                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2223
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2224
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2225
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2226
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2227
        public void visitSelect(JCFieldAccess tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2228
            super.visitSelect(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2229
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2230
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2231
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2232
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2233
        public void visitIdent(JCIdent tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2234
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2235
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2236
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2237
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2238
        public void visitTypeApply(JCTypeApply tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2239
            scan(tree.clazz);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2240
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2241
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2242
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2243
        public void visitTypeArray(JCArrayTypeTree tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2244
            scan(tree.elemtype);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2245
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2246
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2247
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2248
        public void visitClassDef(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2249
            List<JCTree> supertypes = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2250
            if (tree.getExtendsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2251
                supertypes = supertypes.prepend(tree.getExtendsClause());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2252
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2253
            if (tree.getImplementsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2254
                for (JCTree intf : tree.getImplementsClause()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2255
                    supertypes = supertypes.prepend(intf);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2256
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2257
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2258
            checkClass(tree.pos(), tree.sym, supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2259
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2260
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2261
        void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2262
            if ((c.flags_field & ACYCLIC) != 0)
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2263
                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2264
            if (seenClasses.contains(c)) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2265
                errorFound = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2266
                noteCyclic(pos, (ClassSymbol)c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2267
            } else if (!c.type.isErroneous()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2268
                try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2269
                    seenClasses = seenClasses.prepend(c);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2270
                    if (c.type.hasTag(CLASS)) {
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2271
                        if (supertypes.nonEmpty()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2272
                            scan(supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2273
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2274
                        else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2275
                            ClassType ct = (ClassType)c.type;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2276
                            if (ct.supertype_field == null ||
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2277
                                    ct.interfaces_field == null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2278
                                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2279
                                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2280
                                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2281
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2282
                            checkSymbol(pos, ct.supertype_field.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2283
                            for (Type intf : ct.interfaces_field) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2284
                                checkSymbol(pos, intf.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2285
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2286
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2287
                        if (c.owner.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2288
                            checkSymbol(pos, c.owner);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2289
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2290
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2291
                } finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2292
                    seenClasses = seenClasses.tail;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2293
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2294
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2295
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2296
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2297
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2298
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2299
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2300
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2301
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2302
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2303
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
    void checkNonCyclic(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2305
        checkNonCyclicInternal(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2306
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2307
06bc494ca11e Initial load
duke
parents:
diff changeset
  2308
06bc494ca11e Initial load
duke
parents:
diff changeset
  2309
    void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2310
        checkNonCyclic1(pos, t, List.nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2311
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2312
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  2313
    private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2314
        final TypeVar tv;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2315
        if  (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  2316
            return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2317
        if (seen.contains(t)) {
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24293
diff changeset
  2318
            tv = (TypeVar)t;
53515
a772e65727c5 8193367: Annotated type variable bounds crash javac
bsrbnd
parents: 53390
diff changeset
  2319
            tv.setUpperBound(types.createErrorType(t));
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2320
            log.error(pos, Errors.CyclicInheritance(t));
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2321
        } else if (t.hasTag(TYPEVAR)) {
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24293
diff changeset
  2322
            tv = (TypeVar)t;
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  2323
            seen = seen.prepend(tv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2324
            for (Type b : types.getBounds(tv))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2325
                checkNonCyclic1(pos, b, seen);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2326
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2327
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2328
06bc494ca11e Initial load
duke
parents:
diff changeset
  2329
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2330
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2331
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2332
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2333
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2334
     *  @returns        True if the check completed on all attributed classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  2335
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2336
    private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2337
        boolean complete = true; // was the check complete?
06bc494ca11e Initial load
duke
parents:
diff changeset
  2338
        //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  2339
        Symbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2340
        if ((c.flags_field & ACYCLIC) != 0) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2341
06bc494ca11e Initial load
duke
parents:
diff changeset
  2342
        if ((c.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2343
            noteCyclic(pos, (ClassSymbol)c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
        } else if (!c.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2345
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2346
                c.flags_field |= LOCKED;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2347
                if (c.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2348
                    ClassType clazz = (ClassType)c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2349
                    if (clazz.interfaces_field != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2350
                        for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2351
                            complete &= checkNonCyclicInternal(pos, l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2352
                    if (clazz.supertype_field != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2353
                        Type st = clazz.supertype_field;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2354
                        if (st != null && st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2355
                            complete &= checkNonCyclicInternal(pos, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2356
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2357
                    if (c.owner.kind == TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2358
                        complete &= checkNonCyclicInternal(pos, c.owner.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2359
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2360
            } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2361
                c.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2362
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2363
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2364
        if (complete)
30066
d74c06a92bd8 8078600: Infinite loop when compiling annotations with -XDcompletionDeps
alundblad
parents: 29959
diff changeset
  2365
            complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.isCompleted();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2366
        if (complete) c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2367
        return complete;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2368
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2369
06bc494ca11e Initial load
duke
parents:
diff changeset
  2370
    /** Note that we found an inheritance cycle. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2371
    private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2372
        log.error(pos, Errors.CyclicInheritance(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2373
        for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2374
            l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2375
        Type st = types.supertype(c.type);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2376
        if (st.hasTag(CLASS))
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2377
            ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2378
        c.type = types.createErrorType(c, c.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2379
        c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2380
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2381
06bc494ca11e Initial load
duke
parents:
diff changeset
  2382
    /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2383
     *  method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2384
     *  @param tree         The class definition whose members are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2385
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2386
    void checkImplementations(JCClassDecl tree) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2387
        checkImplementations(tree, tree.sym, tree.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2388
    }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2389
    //where
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2390
        /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2391
         *  method in `ic' conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2392
         */
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2393
        void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2394
            for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2395
                ClassSymbol lc = (ClassSymbol)l.head.tsym;
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2396
                if ((lc.flags() & ABSTRACT) != 0) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2397
                    for (Symbol sym : lc.members().getSymbols(NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2398
                        if (sym.kind == MTH &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2399
                            (sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2400
                            MethodSymbol absmeth = (MethodSymbol)sym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2401
                            MethodSymbol implmeth = absmeth.implementation(origin, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2402
                            if (implmeth != null && implmeth != absmeth &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2403
                                (implmeth.owner.flags() & INTERFACE) ==
06bc494ca11e Initial load
duke
parents:
diff changeset
  2404
                                (origin.flags() & INTERFACE)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2405
                                // don't check if implmeth is in a class, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
  2406
                                // origin is an interface. This case arises only
06bc494ca11e Initial load
duke
parents:
diff changeset
  2407
                                // if implmeth is declared in Object. The reason is
06bc494ca11e Initial load
duke
parents:
diff changeset
  2408
                                // that interfaces really don't inherit from
06bc494ca11e Initial load
duke
parents:
diff changeset
  2409
                                // Object it's just that the compiler represents
06bc494ca11e Initial load
duke
parents:
diff changeset
  2410
                                // things that way.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2411
                                checkOverride(tree, implmeth, absmeth, origin);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2412
                            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2413
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2414
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2415
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2416
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2417
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2418
06bc494ca11e Initial load
duke
parents:
diff changeset
  2419
    /** Check that all abstract methods implemented by a class are
06bc494ca11e Initial load
duke
parents:
diff changeset
  2420
     *  mutually compatible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2421
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2422
     *  @param c            The class whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2423
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2424
    void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2425
        List<Type> supertypes = types.interfaces(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2426
        Type supertype = types.supertype(c);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2427
        if (supertype.hasTag(CLASS) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2428
            (supertype.tsym.flags() & ABSTRACT) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2429
            supertypes = supertypes.prepend(supertype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2430
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2431
            if (!l.head.getTypeArguments().isEmpty() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2432
                !checkCompatibleAbstracts(pos, l.head, l.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2433
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2434
            for (List<Type> m = supertypes; m != l; m = m.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2435
                if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2436
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2437
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2438
        checkCompatibleConcretes(pos, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2439
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2440
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2441
    /** Check that all non-override equivalent methods accessible from 'site'
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2442
     *  are mutually compatible (JLS 8.4.8/9.4.1).
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2443
     *
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2444
     *  @param pos  Position to be used for error reporting.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2445
     *  @param site The class whose methods are checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2446
     *  @param sym  The method symbol to be checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2447
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2448
    void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2449
         ClashFilter cf = new ClashFilter(site);
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2450
        //for each method m1 that is overridden (directly or indirectly)
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2451
        //by method 'sym' in 'site'...
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2452
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2453
        List<MethodSymbol> potentiallyAmbiguousList = List.nil();
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2454
        boolean overridesAny = false;
55358
28f4594b19c2 8224161: Check.checkOverrideClashes n^2 algorithm
ronsh
parents: 53515
diff changeset
  2455
        ArrayList<Symbol> symbolsByName = new ArrayList<>();
28f4594b19c2 8224161: Check.checkOverrideClashes n^2 algorithm
ronsh
parents: 53515
diff changeset
  2456
        types.membersClosure(site, false).getSymbolsByName(sym.name, cf).forEach(symbolsByName::add);
28f4594b19c2 8224161: Check.checkOverrideClashes n^2 algorithm
ronsh
parents: 53515
diff changeset
  2457
        for (Symbol m1 : symbolsByName) {
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2458
            if (!sym.overrides(m1, site.tsym, types, false)) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2459
                if (m1 == sym) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2460
                    continue;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2461
                }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2462
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2463
                if (!overridesAny) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2464
                    potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2465
                }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2466
                continue;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2467
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2468
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2469
            if (m1 != sym) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2470
                overridesAny = true;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2471
                potentiallyAmbiguousList = List.nil();
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2472
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2473
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2474
            //...check each method m2 that is a member of 'site'
55358
28f4594b19c2 8224161: Check.checkOverrideClashes n^2 algorithm
ronsh
parents: 53515
diff changeset
  2475
            for (Symbol m2 : symbolsByName) {
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2476
                if (m2 == m1) continue;
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2477
                //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2478
                //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
  2479
                if (!types.isSubSignature(sym.type, types.memberType(site, m2), Feature.STRICT_METHOD_CLASH_CHECK.allowedInSource(source)) &&
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2480
                        types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2481
                    sym.flags_field |= CLASH;
45413
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2482
                    if (m1 == sym) {
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2483
                        log.error(pos, Errors.NameClashSameErasureNoOverride(
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2484
                            m1.name, types.memberType(site, m1).asMethodType().getParameterTypes(), m1.location(),
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2485
                            m2.name, types.memberType(site, m2).asMethodType().getParameterTypes(), m2.location()));
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2486
                    } else {
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2487
                        ClassType ct = (ClassType)site;
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2488
                        String kind = ct.isInterface() ? "interface" : "class";
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2489
                        log.error(pos, Errors.NameClashSameErasureNoOverride1(
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2490
                            kind,
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2491
                            ct.tsym.name,
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2492
                            m1.name,
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2493
                            types.memberType(site, m1).asMethodType().getParameterTypes(),
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2494
                            m1.location(),
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2495
                            m2.name,
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2496
                            types.memberType(site, m2).asMethodType().getParameterTypes(),
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2497
                            m2.location()));
75202c6b2c35 7170058: Confusing error message from javac when overriding a method from a raw supertype
vromero
parents: 44576
diff changeset
  2498
                    }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2499
                    return;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2500
                }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2501
            }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2502
        }
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2503
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2504
        if (!overridesAny) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2505
            for (MethodSymbol m: potentiallyAmbiguousList) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2506
                checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2507
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2508
        }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2509
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2510
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2511
    /** Check that all static methods accessible from 'site' are
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2512
     *  mutually compatible (JLS 8.4.8).
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2513
     *
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2514
     *  @param pos  Position to be used for error reporting.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2515
     *  @param site The class whose methods are checked.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2516
     *  @param sym  The method symbol to be checked.
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2517
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2518
    void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2519
        ClashFilter cf = new ClashFilter(site);
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2520
        //for each method m1 that is a member of 'site'...
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2521
        for (Symbol s : types.membersClosure(site, true).getSymbolsByName(sym.name, cf)) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2522
            //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2523
            //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
  2524
            if (!types.isSubSignature(sym.type, types.memberType(site, s), Feature.STRICT_METHOD_CLASH_CHECK.allowedInSource(source))) {
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2525
                if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2526
                    log.error(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2527
                              Errors.NameClashSameErasureNoHide(sym, sym.location(), s, s.location()));
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2528
                    return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2529
                } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2530
                    checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2531
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2532
            }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2533
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2534
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2535
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2536
     //where
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2537
     private class ClashFilter implements Filter<Symbol> {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2538
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2539
         Type site;
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2540
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2541
         ClashFilter(Type site) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2542
             this.site = site;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2543
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2544
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2545
         boolean shouldSkip(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2546
             return (s.flags() & CLASH) != 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2547
                s.owner == site.tsym;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2548
         }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2549
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2550
         public boolean accepts(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2551
             return s.kind == MTH &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2552
                     (s.flags() & SYNTHETIC) == 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2553
                     !shouldSkip(s) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2554
                     s.isInheritedIn(site.tsym, types) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2555
                     !s.isConstructor();
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2556
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2557
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2558
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2559
    void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2560
        DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2561
        for (Symbol m : types.membersClosure(site, false).getSymbols(dcf)) {
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2562
            Assert.check(m.kind == MTH);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2563
            List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2564
            if (prov.size() > 1) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 20240
diff changeset
  2565
                ListBuffer<Symbol> abstracts = new ListBuffer<>();
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 20240
diff changeset
  2566
                ListBuffer<Symbol> defaults = new ListBuffer<>();
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2567
                for (MethodSymbol provSym : prov) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2568
                    if ((provSym.flags() & DEFAULT) != 0) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2569
                        defaults = defaults.append(provSym);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2570
                    } else if ((provSym.flags() & ABSTRACT) != 0) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2571
                        abstracts = abstracts.append(provSym);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2572
                    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2573
                    if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2574
                        //strong semantics - issue an error if two sibling interfaces
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2575
                        //have two override-equivalent defaults - or if one is abstract
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2576
                        //and the other is default
48352
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2577
                        Fragment diagKey;
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2578
                        Symbol s1 = defaults.first();
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2579
                        Symbol s2;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2580
                        if (defaults.size() > 1) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2581
                            s2 = defaults.toList().tail.head;
48352
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2582
                            diagKey = Fragments.IncompatibleUnrelatedDefaults(Kinds.kindName(site.tsym), site,
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2583
                                    m.name, types.memberType(site, m).getParameterTypes(),
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2584
                                    s1.location(), s2.location());
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2585
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2586
                        } else {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2587
                            s2 = abstracts.first();
48352
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2588
                            diagKey = Fragments.IncompatibleAbstractDefault(Kinds.kindName(site.tsym), site,
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2589
                                    m.name, types.memberType(site, m).getParameterTypes(),
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2590
                                    s1.location(), s2.location());
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2591
                        }
48352
9b700a5c4381 8057650: uniform error diagnostics for inconsistent inherited method signatures
mcimadamore
parents: 48054
diff changeset
  2592
                        log.error(pos, Errors.TypesIncompatible(s1.location().type, s2.location().type, diagKey));
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2593
                        break;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2594
                    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2595
                }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2596
            }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2597
        }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2598
    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2599
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2600
    //where
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2601
     private class DefaultMethodClashFilter implements Filter<Symbol> {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2602
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2603
         Type site;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2604
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2605
         DefaultMethodClashFilter(Type site) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2606
             this.site = site;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2607
         }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2608
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2609
         public boolean accepts(Symbol s) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2610
             return s.kind == MTH &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2611
                     (s.flags() & DEFAULT) != 0 &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2612
                     s.isInheritedIn(site.tsym, types) &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2613
                     !s.isConstructor();
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2614
         }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2615
     }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2616
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2617
    /**
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2618
      * Report warnings for potentially ambiguous method declarations. Two declarations
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2619
      * are potentially ambiguous if they feature two unrelated functional interface
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2620
      * in same argument position (in which case, a call site passing an implicit
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2621
      * lambda would be ambiguous).
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2622
      */
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2623
    void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2624
            MethodSymbol msym1, MethodSymbol msym2) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2625
        if (msym1 != msym2 &&
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47959
diff changeset
  2626
                Feature.DEFAULT_METHODS.allowedInSource(source) &&
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2627
                lint.isEnabled(LintCategory.OVERLOADS) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2628
                (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2629
                (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2630
            Type mt1 = types.memberType(site, msym1);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2631
            Type mt2 = types.memberType(site, msym2);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2632
            //if both generic methods, adjust type variables
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2633
            if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2634
                    types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2635
                mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2636
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2637
            //expand varargs methods if needed
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2638
            int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2639
            List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2640
            List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2641
            //if arities don't match, exit
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2642
            if (args1.length() != args2.length()) return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2643
            boolean potentiallyAmbiguous = false;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2644
            while (args1.nonEmpty() && args2.nonEmpty()) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2645
                Type s = args1.head;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2646
                Type t = args2.head;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2647
                if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2648
                    if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2649
                            types.findDescriptorType(s).getParameterTypes().length() > 0 &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2650
                            types.findDescriptorType(s).getParameterTypes().length() ==
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2651
                            types.findDescriptorType(t).getParameterTypes().length()) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2652
                        potentiallyAmbiguous = true;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2653
                    } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2654
                        break;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2655
                    }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2656
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2657
                args1 = args1.tail;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2658
                args2 = args2.tail;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2659
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2660
            if (potentiallyAmbiguous) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2661
                //we found two incompatible functional interfaces with same arity
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2662
                //this means a call site passing an implicit lambda would be ambigiuous
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2663
                msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2664
                msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2665
                log.warning(LintCategory.OVERLOADS, pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2666
                            Warnings.PotentiallyAmbiguousOverload(msym1, msym1.location(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2667
                                                                  msym2, msym2.location()));
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2668
                return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2669
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2670
        }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2671
    }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2672
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2673
    void checkAccessFromSerializableElement(final JCTree tree, boolean isLambda) {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2674
        if (warnOnAnyAccessToMembers ||
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2675
            (lint.isEnabled(LintCategory.SERIAL) &&
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2676
            !lint.isSuppressed(LintCategory.SERIAL) &&
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2677
            isLambda)) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2678
            Symbol sym = TreeInfo.symbol(tree);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  2679
            if (!sym.kind.matches(KindSelector.VAL_MTH)) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2680
                return;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2681
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2682
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2683
            if (sym.kind == VAR) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2684
                if ((sym.flags() & PARAMETER) != 0 ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2685
                    sym.isLocal() ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2686
                    sym.name == names._this ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2687
                    sym.name == names._super) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2688
                    return;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2689
                }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2690
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2691
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2692
            if (!types.isSubtype(sym.owner.type, syms.serializableType) &&
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2693
                isEffectivelyNonPublic(sym)) {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2694
                if (isLambda) {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2695
                    if (belongsToRestrictedPackage(sym)) {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2696
                        log.warning(LintCategory.SERIAL, tree.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2697
                                    Warnings.AccessToMemberFromSerializableLambda(sym));
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2698
                    }
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2699
                } else {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2700
                    log.warning(tree.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2701
                                Warnings.AccessToMemberFromSerializableElement(sym));
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2702
                }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2703
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2704
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2705
    }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2706
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2707
    private boolean isEffectivelyNonPublic(Symbol sym) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2708
        if (sym.packge() == syms.rootPackage) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2709
            return false;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2710
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2711
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  2712
        while (sym.kind != PCK) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2713
            if ((sym.flags() & PUBLIC) == 0) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2714
                return true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2715
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2716
            sym = sym.owner;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2717
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2718
        return false;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2719
    }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2720
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2721
    private boolean belongsToRestrictedPackage(Symbol sym) {
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2722
        String fullName = sym.packge().fullname.toString();
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2723
        return fullName.startsWith("java.") ||
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2724
                fullName.startsWith("javax.") ||
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2725
                fullName.startsWith("sun.") ||
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2726
                fullName.contains(".internal.");
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2727
    }
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2728
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2729
    /** Check that class c does not implement directly or indirectly
06bc494ca11e Initial load
duke
parents:
diff changeset
  2730
     *  the same parameterized interface with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2731
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2732
     *  @param type         The type whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2733
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2734
    void checkClassBounds(DiagnosticPosition pos, Type type) {
22165
ec53c8946fc2 8030807: langtools should still build using jdk 7
vromero
parents: 22163
diff changeset
  2735
        checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2736
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2737
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2738
        /** Enter all interfaces of type `type' into the hash table `seensofar'
06bc494ca11e Initial load
duke
parents:
diff changeset
  2739
         *  with their class symbol as key and their type as value. Make
06bc494ca11e Initial load
duke
parents:
diff changeset
  2740
         *  sure no class is entered with two different types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2741
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2742
        void checkClassBounds(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2743
                              Map<TypeSymbol,Type> seensofar,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2744
                              Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2745
            if (type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2746
            for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2747
                Type it = l.head;
53390
46db9786cd67 8214345: infinite recursion while checking super class
bsrbnd
parents: 53037
diff changeset
  2748
                if (type.hasTag(CLASS) && !it.hasTag(CLASS)) continue; // JLS 8.1.5
46db9786cd67 8214345: infinite recursion while checking super class
bsrbnd
parents: 53037
diff changeset
  2749
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2750
                Type oldit = seensofar.put(it.tsym, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2751
                if (oldit != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2752
                    List<Type> oldparams = oldit.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2753
                    List<Type> newparams = it.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2754
                    if (!types.containsTypeEquivalent(oldparams, newparams))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2755
                        log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2756
                                  Errors.CantInheritDiffArg(it.tsym,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2757
                                                            Type.toString(oldparams),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2758
                                                            Type.toString(newparams)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2759
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2760
                checkClassBounds(pos, seensofar, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2761
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2762
            Type st = types.supertype(type);
53390
46db9786cd67 8214345: infinite recursion while checking super class
bsrbnd
parents: 53037
diff changeset
  2763
            if (type.hasTag(CLASS) && !st.hasTag(CLASS)) return; // JLS 8.1.4
25276
59c17f73fee3 8034147: javac crashes with a NullPointerException during bounds checking
dlsmith
parents: 24903
diff changeset
  2764
            if (st != Type.noType) checkClassBounds(pos, seensofar, st);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2765
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2766
06bc494ca11e Initial load
duke
parents:
diff changeset
  2767
    /** Enter interface into into set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2768
     *  If it existed already, issue a "repeated interface" error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2769
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2770
    void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2771
        if (its.contains(it))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2772
            log.error(pos, Errors.RepeatedInterface);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2773
        else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2774
            its.add(it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2775
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2776
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2777
06bc494ca11e Initial load
duke
parents:
diff changeset
  2778
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2779
 * Check annotations
06bc494ca11e Initial load
duke
parents:
diff changeset
  2780
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2781
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2782
    /**
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2783
     * Recursively validate annotations values
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2784
     */
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2785
    void validateAnnotationTree(JCTree tree) {
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2786
        class AnnotationValidator extends TreeScanner {
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2787
            @Override
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2788
            public void visitAnnotation(JCAnnotation tree) {
52777
7d3391e9df19 8206325: AssertionError in TypeSymbol.getAnnotationTypeMetadata
sadayapalam
parents: 51047
diff changeset
  2789
                if (!tree.type.isErroneous() && tree.type.tsym.isAnnotationType()) {
9814
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2790
                    super.visitAnnotation(tree);
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2791
                    validateAnnotation(tree);
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2792
                }
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2793
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2794
        }
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2795
        tree.accept(new AnnotationValidator());
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2796
    }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2797
13844
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2798
    /**
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2799
     *  {@literal
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2800
     *  Annotation types are restricted to primitives, String, an
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2801
     *  enum, an annotation, Class, Class<?>, Class<? extends
06bc494ca11e Initial load
duke
parents:
diff changeset
  2802
     *  Anything>, arrays of the preceding.
13844
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2803
     *  }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2804
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2805
    void validateAnnotationType(JCTree restype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2806
        // restype may be null if an error occurred, so don't bother validating it
06bc494ca11e Initial load
duke
parents:
diff changeset
  2807
        if (restype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2808
            validateAnnotationType(restype.pos(), restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2809
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2810
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2811
06bc494ca11e Initial load
duke
parents:
diff changeset
  2812
    void validateAnnotationType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2813
        if (type.isPrimitive()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2814
        if (types.isSameType(type, syms.stringType)) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2815
        if ((type.tsym.flags() & Flags.ENUM) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2816
        if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
24293
0d889f759fac 8033718: Inference ignores capture variable as upper bound
dlsmith
parents: 24226
diff changeset
  2817
        if (types.cvarLowerBound(type).tsym == syms.classType.tsym) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2818
        if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2819
            validateAnnotationType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2820
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2821
        }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2822
        log.error(pos, Errors.InvalidAnnotationMemberType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2823
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2824
06bc494ca11e Initial load
duke
parents:
diff changeset
  2825
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2826
     * "It is also a compile-time error if any method declared in an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2827
     * annotation type has a signature that is override-equivalent to
06bc494ca11e Initial load
duke
parents:
diff changeset
  2828
     * that of any public or protected method declared in class Object
06bc494ca11e Initial load
duke
parents:
diff changeset
  2829
     * or in the interface annotation.Annotation."
06bc494ca11e Initial load
duke
parents:
diff changeset
  2830
     *
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9073
diff changeset
  2831
     * @jls 9.6 Annotation Types
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2832
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2833
    void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2834
        for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2835
            Scope s = sup.tsym.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2836
            for (Symbol sym : s.getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2837
                if (sym.kind == MTH &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2838
                    (sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2839
                    types.overrideEquivalent(m.type, sym.type))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2840
                    log.error(pos, Errors.IntfAnnotationMemberClash(sym, sup));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2841
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2842
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2843
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2844
06bc494ca11e Initial load
duke
parents:
diff changeset
  2845
    /** Check the annotations of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2846
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2847
    public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2848
        for (JCAnnotation a : annotations)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2849
            validateAnnotation(a, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2850
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2851
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2852
    /** Check the type annotations.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2853
     */
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2854
    public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2855
        for (JCAnnotation a : annotations)
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2856
            validateTypeAnnotation(a, isTypeParameter);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2857
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2858
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2859
    /** Check an annotation of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2860
     */
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2861
    private void validateAnnotation(JCAnnotation a, Symbol s) {
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2862
        validateAnnotationTree(a);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2863
43279
9afb33b0a3ab 8171322: AssertionError in TypeSymbol.getAnnotationTypeMetadata.
sadayapalam
parents: 43139
diff changeset
  2864
        if (a.type.tsym.isAnnotationType() && !annotationApplicable(a, s))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2865
            log.error(a.pos(), Errors.AnnotationTypeNotApplicable);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2866
15361
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2867
        if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2868
            if (s.kind != TYP) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2869
                log.error(a.pos(), Errors.BadFunctionalIntfAnno);
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2870
            } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2871
                log.error(a.pos(), Errors.BadFunctionalIntfAnno1(Fragments.NotAFunctionalIntf(s)));
15361
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2872
            }
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2873
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2874
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2875
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2876
    public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
25848
3bc09f4676a9 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks.
jlahoda
parents: 25445
diff changeset
  2877
        Assert.checkNonNull(a.type);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2878
        validateAnnotationTree(a);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2879
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2880
        if (a.hasTag(TYPE_ANNOTATION) &&
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2881
                !a.annotationType.type.isErroneous() &&
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2882
                !isTypeAnnotation(a, isTypeParameter)) {
29959
61bfc66866da 8073534: Confusing / incorrect error message regarding annotations on non-declarations
alundblad
parents: 29842
diff changeset
  2883
            log.error(a.pos(), Errors.AnnotationTypeNotApplicableToType(a.type));
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2884
        }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2885
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2886
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2887
    /**
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2888
     * Validate the proposed container 'repeatable' on the
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2889
     * annotation type symbol 's'. Report errors at position
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2890
     * 'pos'.
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2891
     *
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2892
     * @param s The (annotation)type declaration annotated with a @Repeatable
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2893
     * @param repeatable the @Repeatable on 's'
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2894
     * @param pos where to report errors
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2895
     */
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2896
    public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2897
        Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2898
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2899
        Type t = null;
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2900
        List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2901
        if (!l.isEmpty()) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2902
            Assert.check(l.head.fst.name == names.value);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2903
            t = ((Attribute.Class)l.head.snd).getValue();
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2904
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2905
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2906
        if (t == null) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2907
            // errors should already have been reported during Annotate
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2908
            return;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2909
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2910
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2911
        validateValue(t.tsym, s, pos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2912
        validateRetention(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2913
        validateDocumented(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2914
        validateInherited(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2915
        validateTarget(t.tsym, s, pos);
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2916
        validateDefault(t.tsym, pos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2917
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2918
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2919
    private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2920
        Symbol sym = container.members().findFirst(names.value);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2921
        if (sym != null && sym.kind == MTH) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2922
            MethodSymbol m = (MethodSymbol) sym;
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2923
            Type ret = m.getReturnType();
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2924
            if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2925
                log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2926
                          Errors.InvalidRepeatableAnnotationValueReturn(container,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2927
                                                                        ret,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2928
                                                                        types.makeArrayType(contained.type)));
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2929
            }
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2930
        } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2931
            log.error(pos, Errors.InvalidRepeatableAnnotationNoValue(container));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2932
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2933
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2934
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2935
    private void validateRetention(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2936
        Attribute.RetentionPolicy containerRetention = types.getRetention(container);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2937
        Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2938
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2939
        boolean error = false;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2940
        switch (containedRetention) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2941
        case RUNTIME:
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2942
            if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2943
                error = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2944
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2945
            break;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2946
        case CLASS:
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2947
            if (containerRetention == Attribute.RetentionPolicy.SOURCE)  {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2948
                error = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2949
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2950
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2951
        if (error ) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2952
            log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2953
                      Errors.InvalidRepeatableAnnotationRetention(container,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2954
                                                                  containerRetention.name(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2955
                                                                  contained,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2956
                                                                  containedRetention.name()));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2957
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2958
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2959
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2960
    private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2961
        if (contained.attribute(syms.documentedType.tsym) != null) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2962
            if (container.attribute(syms.documentedType.tsym) == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2963
                log.error(pos, Errors.InvalidRepeatableAnnotationNotDocumented(container, contained));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2964
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2965
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2966
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2967
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2968
    private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2969
        if (contained.attribute(syms.inheritedType.tsym) != null) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2970
            if (container.attribute(syms.inheritedType.tsym) == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  2971
                log.error(pos, Errors.InvalidRepeatableAnnotationNotInherited(container, contained));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2972
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2973
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2974
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2975
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2976
    private void validateTarget(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2977
        // The set of targets the container is applicable to must be a subset
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2978
        // (with respect to annotation target semantics) of the set of targets
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2979
        // the contained is applicable to. The target sets may be implicit or
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2980
        // explicit.
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2981
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2982
        Set<Name> containerTargets;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2983
        Attribute.Array containerTarget = getAttributeTargetAttribute(container);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2984
        if (containerTarget == null) {
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2985
            containerTargets = getDefaultTargetSet();
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2986
        } else {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2987
            containerTargets = new HashSet<>();
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2988
            for (Attribute app : containerTarget.values) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2989
                if (!(app instanceof Attribute.Enum)) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2990
                    continue; // recovery
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2991
                }
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2992
                Attribute.Enum e = (Attribute.Enum)app;
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2993
                containerTargets.add(e.value.name);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2994
            }
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2995
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2996
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2997
        Set<Name> containedTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2998
        Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2999
        if (containedTarget == null) {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3000
            containedTargets = getDefaultTargetSet();
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3001
        } else {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3002
            containedTargets = new HashSet<>();
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3003
            for (Attribute app : containedTarget.values) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3004
                if (!(app instanceof Attribute.Enum)) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3005
                    continue; // recovery
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3006
                }
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3007
                Attribute.Enum e = (Attribute.Enum)app;
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3008
                containedTargets.add(e.value.name);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3009
            }
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3010
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3011
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3012
        if (!isTargetSubsetOf(containerTargets, containedTargets)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3013
            log.error(pos, Errors.InvalidRepeatableAnnotationIncompatibleTarget(container, contained));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3014
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3015
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3016
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3017
    /* get a set of names for the default target */
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3018
    private Set<Name> getDefaultTargetSet() {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3019
        if (defaultTargets == null) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3020
            Set<Name> targets = new HashSet<>();
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3021
            targets.add(names.ANNOTATION_TYPE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3022
            targets.add(names.CONSTRUCTOR);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3023
            targets.add(names.FIELD);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3024
            targets.add(names.LOCAL_VARIABLE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3025
            targets.add(names.METHOD);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3026
            targets.add(names.PACKAGE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3027
            targets.add(names.PARAMETER);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3028
            targets.add(names.TYPE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3029
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3030
            defaultTargets = java.util.Collections.unmodifiableSet(targets);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3031
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3032
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3033
        return defaultTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3034
    }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3035
    private Set<Name> defaultTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3036
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3037
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3038
    /** Checks that s is a subset of t, with respect to ElementType
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3039
     * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE},
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3040
     * and {TYPE_USE} covers the set {ANNOTATION_TYPE, TYPE, TYPE_USE,
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3041
     * TYPE_PARAMETER}.
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3042
     */
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3043
    private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3044
        // Check that all elements in s are present in t
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3045
        for (Name n2 : s) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3046
            boolean currentElementOk = false;
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  3047
            for (Name n1 : t) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3048
                if (n1 == n2) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3049
                    currentElementOk = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3050
                    break;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3051
                } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3052
                    currentElementOk = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3053
                    break;
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3054
                } else if (n1 == names.TYPE_USE &&
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3055
                        (n2 == names.TYPE ||
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3056
                         n2 == names.ANNOTATION_TYPE ||
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3057
                         n2 == names.TYPE_PARAMETER)) {
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3058
                    currentElementOk = true;
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3059
                    break;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3060
                }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3061
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3062
            if (!currentElementOk)
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3063
                return false;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3064
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3065
        return true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3066
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3067
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  3068
    private void validateDefault(Symbol container, DiagnosticPosition pos) {
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3069
        // validate that all other elements of containing type has defaults
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3070
        Scope scope = container.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3071
        for(Symbol elm : scope.getSymbols()) {
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3072
            if (elm.name != names.value &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  3073
                elm.kind == MTH &&
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3074
                ((MethodSymbol)elm).defaultValue == null) {
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3075
                log.error(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3076
                          Errors.InvalidRepeatableAnnotationElemNondefault(container, elm));
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3077
            }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3078
        }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3079
    }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  3080
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3081
    /** Is s a method symbol that overrides a method in a superclass? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3082
    boolean isOverrider(Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3083
        if (s.kind != MTH || s.isStatic())
06bc494ca11e Initial load
duke
parents:
diff changeset
  3084
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3085
        MethodSymbol m = (MethodSymbol)s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3086
        TypeSymbol owner = (TypeSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3087
        for (Type sup : types.closure(owner.type)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3088
            if (sup == owner.type)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3089
                continue; // skip "this"
06bc494ca11e Initial load
duke
parents:
diff changeset
  3090
            Scope scope = sup.tsym.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3091
            for (Symbol sym : scope.getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3092
                if (!sym.isStatic() && m.overrides(sym, owner, types, true))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3093
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3094
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3095
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3096
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3097
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3098
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3099
    /** Is the annotation applicable to types? */
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3100
    protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
30069
5686d5e44a83 8044196: Incorrect applying of repeatable annotations with incompatible target to type parameter
alundblad
parents: 30066
diff changeset
  3101
        List<Attribute> targets = typeAnnotations.annotationTargets(a.annotationType.type.tsym);
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3102
        return (targets == null) ?
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3103
                false :
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3104
                targets.stream()
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3105
                        .anyMatch(attr -> isTypeAnnotation(attr, isTypeParameter));
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3106
    }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3107
    //where
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3108
        boolean isTypeAnnotation(Attribute a, boolean isTypeParameter) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3109
            Attribute.Enum e = (Attribute.Enum)a;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3110
            return (e.value.name == names.TYPE_USE ||
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3111
                    (isTypeParameter && e.value.name == names.TYPE_PARAMETER));
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3112
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3113
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3114
    /** Is the annotation applicable to the symbol? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3115
    boolean annotationApplicable(JCAnnotation a, Symbol s) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3116
        Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3117
        Name[] targets;
22003
ed437c411fbd 8028699: Compiler crash during speculative attribution of annotated type
jlahoda
parents: 21896
diff changeset
  3118
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3119
        if (arr == null) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3120
            targets = defaultTargetMetaInfo(a, s);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3121
        } else {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3122
            // TODO: can we optimize this?
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3123
            targets = new Name[arr.values.length];
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3124
            for (int i=0; i<arr.values.length; ++i) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3125
                Attribute app = arr.values[i];
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3126
                if (!(app instanceof Attribute.Enum)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3127
                    return true; // recovery
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3128
                }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3129
                Attribute.Enum e = (Attribute.Enum) app;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3130
                targets[i] = e.value.name;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3131
            }
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3132
        }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3133
        for (Name target : targets) {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3134
            if (target == names.TYPE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3135
                if (s.kind == TYP)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3136
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3137
            } else if (target == names.FIELD) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3138
                if (s.kind == VAR && s.owner.kind != MTH)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3139
                    return true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3140
            } else if (target == names.METHOD) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3141
                if (s.kind == MTH && !s.isConstructor())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3142
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3143
            } else if (target == names.PARAMETER) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3144
                if (s.kind == VAR && s.owner.kind == MTH &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3145
                      (s.flags() & PARAMETER) != 0) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3146
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3147
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3148
            } else if (target == names.CONSTRUCTOR) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3149
                if (s.kind == MTH && s.isConstructor())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3150
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3151
            } else if (target == names.LOCAL_VARIABLE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3152
                if (s.kind == VAR && s.owner.kind == MTH &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3153
                      (s.flags() & PARAMETER) == 0) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3154
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3155
                }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3156
            } else if (target == names.ANNOTATION_TYPE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3157
                if (s.kind == TYP && (s.flags() & ANNOTATION) != 0) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3158
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3159
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3160
            } else if (target == names.PACKAGE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3161
                if (s.kind == PCK)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3162
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3163
            } else if (target == names.TYPE_USE) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3164
                if (s.kind == VAR && s.owner.kind == MTH && s.type.hasTag(NONE)) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3165
                    //cannot type annotate implictly typed locals
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3166
                    return false;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3167
                } else if (s.kind == TYP || s.kind == VAR ||
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3168
                        (s.kind == MTH && !s.isConstructor() &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3169
                                !s.type.getReturnType().hasTag(VOID)) ||
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3170
                        (s.kind == MTH && s.isConstructor())) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3171
                    return true;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3172
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3173
            } else if (target == names.TYPE_PARAMETER) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3174
                if (s.kind == TYP && s.type.hasTag(TYPEVAR))
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  3175
                    return true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3176
            } else
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3177
                return true; // Unknown ElementType. This should be an error at declaration site,
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3178
                             // assume applicable.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3179
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3180
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3181
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3182
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3183
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3184
    Attribute.Array getAttributeTargetAttribute(TypeSymbol s) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3185
        Attribute.Compound atTarget = s.getAnnotationTypeMetadata().getTarget();
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3186
        if (atTarget == null) return null; // ok, is applicable
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3187
        Attribute atValue = atTarget.member(names.value);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3188
        if (!(atValue instanceof Attribute.Array)) return null; // error recovery
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3189
        return (Attribute.Array) atValue;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3190
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3191
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3192
    private final Name[] dfltTargetMeta;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3193
    private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3194
        return dfltTargetMeta;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3195
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3196
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3197
    /** Check an annotation value.
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3198
     *
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3199
     * @param a The annotation tree to check
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3200
     * @return true if this annotation tree is valid, otherwise false
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3201
     */
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3202
    public boolean validateAnnotationDeferErrors(JCAnnotation a) {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3203
        boolean res = false;
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3204
        final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3205
        try {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3206
            res = validateAnnotation(a);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3207
        } finally {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3208
            log.popDiagnosticHandler(diagHandler);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3209
        }
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3210
        return res;
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3211
    }
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3212
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3213
    private boolean validateAnnotation(JCAnnotation a) {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3214
        boolean isValid = true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3215
        AnnotationTypeMetadata metadata = a.annotationType.type.tsym.getAnnotationTypeMetadata();
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3216
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3217
        // collect an inventory of the annotation elements
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3218
        Set<MethodSymbol> elements = metadata.getAnnotationElements();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3219
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3220
        // remove the ones that are assigned values
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3221
        for (JCTree arg : a.args) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3222
            if (!arg.hasTag(ASSIGN)) continue; // recovery
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3223
            JCAssign assign = (JCAssign)arg;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3224
            Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3225
            if (m == null || m.type.isErroneous()) continue;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3226
            if (!elements.remove(m)) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3227
                isValid = false;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3228
                log.error(assign.lhs.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3229
                          Errors.DuplicateAnnotationMemberValue(m.name, a.type));
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3230
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3231
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3232
06bc494ca11e Initial load
duke
parents:
diff changeset
  3233
        // all the remaining ones better have default values
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3234
        List<Name> missingDefaults = List.nil();
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3235
        Set<MethodSymbol> membersWithDefault = metadata.getAnnotationElementsWithDefault();
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3236
        for (MethodSymbol m : elements) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3237
            if (m.type.isErroneous())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3238
                continue;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3239
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3240
            if (!membersWithDefault.contains(m))
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3241
                missingDefaults = missingDefaults.append(m.name);
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3242
        }
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3243
        missingDefaults = missingDefaults.reverse();
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3244
        if (missingDefaults.nonEmpty()) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3245
            isValid = false;
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3246
            Error errorKey = (missingDefaults.size() > 1)
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3247
                    ? Errors.AnnotationMissingDefaultValue1(a.type, missingDefaults)
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3248
                    : Errors.AnnotationMissingDefaultValue(a.type, missingDefaults);
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3249
            log.error(a.pos(), errorKey);
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3250
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3251
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3252
        return isValid && validateTargetAnnotationValue(a);
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3253
    }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3254
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3255
    /* Validate the special java.lang.annotation.Target annotation */
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3256
    boolean validateTargetAnnotationValue(JCAnnotation a) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3257
        // special case: java.lang.annotation.Target must not have
06bc494ca11e Initial load
duke
parents:
diff changeset
  3258
        // repeated values in its value member
06bc494ca11e Initial load
duke
parents:
diff changeset
  3259
        if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3260
                a.args.tail == null)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3261
            return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3262
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3263
        boolean isValid = true;
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3264
        if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3265
        JCAssign assign = (JCAssign) a.args.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3266
        Symbol m = TreeInfo.symbol(assign.lhs);
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3267
        if (m.name != names.value) return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3268
        JCTree rhs = assign.rhs;
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3269
        if (!rhs.hasTag(NEWARRAY)) return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3270
        JCNewArray na = (JCNewArray) rhs;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3271
        Set<Symbol> targets = new HashSet<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3272
        for (JCTree elem : na.elems) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3273
            if (!targets.add(TreeInfo.symbol(elem))) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3274
                isValid = false;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3275
                log.error(elem.pos(), Errors.RepeatedAnnotationTarget);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3276
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3277
        }
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3278
        return isValid;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3279
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3280
06bc494ca11e Initial load
duke
parents:
diff changeset
  3281
    void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
40772
de87954b8f20 8164073: Javac should unconditionally warn if deprecated javadoc tag is used without @Deprecated annotation
sadayapalam
parents: 40504
diff changeset
  3282
        if (lint.isEnabled(LintCategory.DEP_ANN) && s.isDeprecatableViaAnnotation() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3283
            (s.flags() & DEPRECATED) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3284
            !syms.deprecatedType.isErroneous() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3285
            s.attribute(syms.deprecatedType.tsym) == null) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3286
            log.warning(LintCategory.DEP_ANN,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3287
                    pos, Warnings.MissingDeprecatedAnnotation);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3288
        }
40313
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39674
diff changeset
  3289
        // Note: @Deprecated has no effect on local variables, parameters and package decls.
40772
de87954b8f20 8164073: Javac should unconditionally warn if deprecated javadoc tag is used without @Deprecated annotation
sadayapalam
parents: 40504
diff changeset
  3290
        if (lint.isEnabled(LintCategory.DEPRECATION) && !s.isDeprecatableViaAnnotation()) {
40313
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39674
diff changeset
  3291
            if (!syms.deprecatedType.isErroneous() && s.attribute(syms.deprecatedType.tsym) != null) {
40772
de87954b8f20 8164073: Javac should unconditionally warn if deprecated javadoc tag is used without @Deprecated annotation
sadayapalam
parents: 40504
diff changeset
  3292
                log.warning(LintCategory.DEPRECATION, pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3293
                            Warnings.DeprecatedAnnotationHasNoEffect(Kinds.kindName(s)));
40313
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39674
diff changeset
  3294
            }
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39674
diff changeset
  3295
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3296
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3297
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3298
    void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
53037
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  3299
        checkDeprecated(() -> pos, other, s);
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  3300
    }
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  3301
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  3302
    void checkDeprecated(Supplier<DiagnosticPosition> pos, final Symbol other, final Symbol s) {
41637
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
  3303
        if ( (s.isDeprecatedForRemoval()
7b24b4c32ee6 8145471: javac changes for enhanced deprecation
jjg
parents: 41629
diff changeset
  3304
                || s.isDeprecated() && !other.isDeprecated())
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
  3305
                && (s.outermostClass() != other.outermostClass() || s.outermostClass() == null)) {
53037
e84983c2735e 8215368: Make Check.checkOverride call diagnosticPositionFor lazily
cushon
parents: 52777
diff changeset
  3306
            deferredLintHandler.report(() -> warnDeprecated(pos.get(), s));
11314
b612aaca08d0 7120736: refactor javac option handling
jjg
parents: 10950
diff changeset
  3307
        }
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3308
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3309
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3310
    void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3311
        if ((s.flags() & PROPRIETARY) != 0) {
35810
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
  3312
            deferredLintHandler.report(() -> {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3313
                log.mandatoryWarning(pos, Warnings.SunProprietary(s));
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3314
            });
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3315
        }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3316
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3317
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3318
    void checkProfile(final DiagnosticPosition pos, final Symbol s) {
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3319
        if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3320
            log.error(pos, Errors.NotInProfile(s, profile));
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3321
        }
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3322
    }
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3323
58109
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3324
    void checkPreview(DiagnosticPosition pos, Symbol s) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3325
        if ((s.flags() & PREVIEW_API) != 0) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3326
            if ((s.flags() & PREVIEW_ESSENTIAL_API) != 0 && !preview.isEnabled()) {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3327
                log.error(pos, Errors.IsPreview(s));
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3328
            } else {
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3329
                deferredLintHandler.report(() -> warnPreview(pos, s));
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3330
            }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3331
        }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3332
    }
ee07de0d2c16 Updating javac behavior w.r.t. preview API. Based on darcy's patch.
jlahoda
parents: 55622
diff changeset
  3333
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3334
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3335
 * Check for recursive annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3336
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3337
06bc494ca11e Initial load
duke
parents:
diff changeset
  3338
    /** Check for cycles in the graph of annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3339
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3340
    void checkNonCyclicElements(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3341
        if ((tree.sym.flags_field & ANNOTATION) == 0) return;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  3342
        Assert.check((tree.sym.flags_field & LOCKED) == 0);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3343
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3344
            tree.sym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3345
            for (JCTree def : tree.defs) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3346
                if (!def.hasTag(METHODDEF)) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3347
                JCMethodDecl meth = (JCMethodDecl)def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3348
                checkAnnotationResType(meth.pos(), meth.restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3349
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3350
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3351
            tree.sym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3352
            tree.sym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3353
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3354
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3355
06bc494ca11e Initial load
duke
parents:
diff changeset
  3356
    void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3357
        if ((tsym.flags_field & ACYCLIC_ANN) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3358
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3359
        if ((tsym.flags_field & LOCKED) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3360
            log.error(pos, Errors.CyclicAnnotationElement(tsym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3361
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3362
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3363
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3364
            tsym.flags_field |= LOCKED;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3365
            for (Symbol s : tsym.members().getSymbols(NON_RECURSIVE)) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  3366
                if (s.kind != MTH)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3367
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3368
                checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  3369
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3370
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3371
            tsym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3372
            tsym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3373
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3374
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3375
06bc494ca11e Initial load
duke
parents:
diff changeset
  3376
    void checkAnnotationResType(DiagnosticPosition pos, Type type) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3377
        switch (type.getTag()) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3378
        case CLASS:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3379
            if ((type.tsym.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3380
                checkNonCyclicElementsInternal(pos, type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3381
            break;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3382
        case ARRAY:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3383
            checkAnnotationResType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3384
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3385
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3386
            break; // int etc
06bc494ca11e Initial load
duke
parents:
diff changeset
  3387
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3388
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3389
06bc494ca11e Initial load
duke
parents:
diff changeset
  3390
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3391
 * Check for cycles in the constructor call graph.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3392
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3393
06bc494ca11e Initial load
duke
parents:
diff changeset
  3394
    /** Check for cycles in the graph of constructors calling other
06bc494ca11e Initial load
duke
parents:
diff changeset
  3395
     *  constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3396
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3397
    void checkCyclicConstructors(JCClassDecl tree) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3398
        Map<Symbol,Symbol> callMap = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3399
06bc494ca11e Initial load
duke
parents:
diff changeset
  3400
        // enter each constructor this-call into the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  3401
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3402
            JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3403
            if (app == null) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3404
            JCMethodDecl meth = (JCMethodDecl) l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3405
            if (TreeInfo.name(app.meth) == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3406
                callMap.put(meth.sym, TreeInfo.symbol(app.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3407
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3408
                meth.sym.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3409
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3410
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3411
06bc494ca11e Initial load
duke
parents:
diff changeset
  3412
        // Check for cycles in the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  3413
        Symbol[] ctors = new Symbol[0];
06bc494ca11e Initial load
duke
parents:
diff changeset
  3414
        ctors = callMap.keySet().toArray(ctors);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3415
        for (Symbol caller : ctors) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3416
            checkCyclicConstructor(tree, caller, callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3417
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3418
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3419
06bc494ca11e Initial load
duke
parents:
diff changeset
  3420
    /** Look in the map to see if the given constructor is part of a
06bc494ca11e Initial load
duke
parents:
diff changeset
  3421
     *  call cycle.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3422
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3423
    private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3424
                                        Map<Symbol,Symbol> callMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3425
        if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3426
            if ((ctor.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3427
                log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3428
                          Errors.RecursiveCtorInvocation);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3429
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3430
                ctor.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3431
                checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3432
                ctor.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3433
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3434
            ctor.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3435
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3436
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3437
06bc494ca11e Initial load
duke
parents:
diff changeset
  3438
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3439
 * Miscellaneous
06bc494ca11e Initial load
duke
parents:
diff changeset
  3440
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3441
06bc494ca11e Initial load
duke
parents:
diff changeset
  3442
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  3443
     *  Check for division by integer constant zero
06bc494ca11e Initial load
duke
parents:
diff changeset
  3444
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3445
     *  @param operator      The operator for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  3446
     *  @param operand       The right hand operand for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  3447
     */
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3448
    void checkDivZero(final DiagnosticPosition pos, Symbol operator, Type operand) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3449
        if (operand.constValue() != null
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  3450
            && operand.getTag().isSubRangeOf(LONG)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3451
            && ((Number) (operand.constValue())).longValue() == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3452
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3453
            if (opc == ByteCodes.idiv || opc == ByteCodes.imod
06bc494ca11e Initial load
duke
parents:
diff changeset
  3454
                || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3455
                deferredLintHandler.report(() -> warnDivZero(pos));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3456
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3457
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3458
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3459
06bc494ca11e Initial load
duke
parents:
diff changeset
  3460
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  3461
     * Check for empty statements after if
06bc494ca11e Initial load
duke
parents:
diff changeset
  3462
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3463
    void checkEmptyIf(JCIf tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3464
        if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3465
                lint.isEnabled(LintCategory.EMPTY))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3466
            log.warning(LintCategory.EMPTY, tree.thenpart.pos(), Warnings.EmptyIf);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3467
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3468
06bc494ca11e Initial load
duke
parents:
diff changeset
  3469
    /** Check that symbol is unique in given scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3470
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3471
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3472
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3473
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3474
    boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3475
        if (sym.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  3476
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3477
        if (sym.owner.name == names.any) return false;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3478
        for (Symbol byName : s.getSymbolsByName(sym.name, NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3479
            if (sym != byName &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3480
                    (byName.flags() & CLASH) == 0 &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3481
                    sym.kind == byName.kind &&
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3482
                    sym.name != names.error &&
19938
a2ac24fff52e 8013846: javac fails to reject semantically equivalent generic method declarations
emc
parents: 19930
diff changeset
  3483
                    (sym.kind != MTH ||
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3484
                     types.hasSameArgs(sym.type, byName.type) ||
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3485
                     types.hasSameArgs(types.erasure(sym.type), types.erasure(byName.type)))) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3486
                if ((sym.flags() & VARARGS) != (byName.flags() & VARARGS)) {
48459
a5f815d1060b 8194932: no ambuguity error is emitted if classfile contains two identical methods with different return types
mcimadamore
parents: 48352
diff changeset
  3487
                    sym.flags_field |= CLASH;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3488
                    varargsDuplicateError(pos, sym, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3489
                    return true;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3490
                } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, byName.type, false)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3491
                    duplicateErasureError(pos, sym, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3492
                    sym.flags_field |= CLASH;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3493
                    return true;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3494
                } else {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3495
                    duplicateError(pos, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3496
                    return false;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3497
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3498
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3499
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3500
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3501
    }
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3502
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3503
    /** Report duplicate declaration error.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3504
     */
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3505
    void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3506
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3507
            log.error(pos, Errors.NameClashSameErasure(sym1, sym2));
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3508
        }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3509
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3510
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3511
    /**Check that types imported through the ordinary imports don't clash with types imported
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3512
     * by other (static or ordinary) imports. Note that two static imports may import two clashing
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3513
     * types without an error on the imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3514
     * @param toplevel       The toplevel tree for which the test should be performed.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3515
     */
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3516
    void checkImportsUnique(JCCompilationUnit toplevel) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3517
        WriteableScope ordinallyImportedSoFar = WriteableScope.create(toplevel.packge);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3518
        WriteableScope staticallyImportedSoFar = WriteableScope.create(toplevel.packge);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3519
        WriteableScope topLevelScope = toplevel.toplevelScope;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3520
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3521
        for (JCTree def : toplevel.defs) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3522
            if (!def.hasTag(IMPORT))
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3523
                continue;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3524
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3525
            JCImport imp = (JCImport) def;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3526
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3527
            if (imp.importScope == null)
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3528
                continue;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3529
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3530
            for (Symbol sym : imp.importScope.getSymbols(sym -> sym.kind == TYP)) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3531
                if (imp.isStatic()) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3532
                    checkUniqueImport(imp.pos(), ordinallyImportedSoFar, staticallyImportedSoFar, topLevelScope, sym, true);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3533
                    staticallyImportedSoFar.enter(sym);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3534
                } else {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3535
                    checkUniqueImport(imp.pos(), ordinallyImportedSoFar, staticallyImportedSoFar, topLevelScope, sym, false);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3536
                    ordinallyImportedSoFar.enter(sym);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3537
                }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3538
            }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3539
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3540
            imp.importScope = null;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3541
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3542
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3543
06bc494ca11e Initial load
duke
parents:
diff changeset
  3544
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3545
     *  but make an exception for two single-type imports which denote the same type.
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3546
     *  @param pos                     Position for error reporting.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3547
     *  @param ordinallyImportedSoFar  A Scope containing types imported so far through
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3548
     *                                 ordinary imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3549
     *  @param staticallyImportedSoFar A Scope containing types imported so far through
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3550
     *                                 static imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3551
     *  @param topLevelScope           The current file's top-level Scope
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3552
     *  @param sym                     The symbol.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3553
     *  @param staticImport            Whether or not this was a static import
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3554
     */
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3555
    private boolean checkUniqueImport(DiagnosticPosition pos, Scope ordinallyImportedSoFar,
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3556
                                      Scope staticallyImportedSoFar, Scope topLevelScope,
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3557
                                      Symbol sym, boolean staticImport) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3558
        Filter<Symbol> duplicates = candidate -> candidate != sym && !candidate.type.isErroneous();
47948
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3559
        Symbol ordinaryClashing = ordinallyImportedSoFar.findFirst(sym.name, duplicates);
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3560
        Symbol staticClashing = null;
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3561
        if (ordinaryClashing == null && !staticImport) {
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3562
            staticClashing = staticallyImportedSoFar.findFirst(sym.name, duplicates);
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3563
        }
47948
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3564
        if (ordinaryClashing != null || staticClashing != null) {
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3565
            if (ordinaryClashing != null)
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3566
                log.error(pos, Errors.AlreadyDefinedSingleImport(ordinaryClashing));
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3567
            else
47948
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3568
                log.error(pos, Errors.AlreadyDefinedStaticSingleImport(staticClashing));
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3569
            return false;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3570
        }
47948
8b11e4b32db3 8133616: compiler error messages for dup single type, single static import switched
jlahoda
parents: 47934
diff changeset
  3571
        Symbol clashing = topLevelScope.findFirst(sym.name, duplicates);
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3572
        if (clashing != null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3573
            log.error(pos, Errors.AlreadyDefinedThisUnit(clashing));
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3574
            return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3575
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3576
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3577
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3578
06bc494ca11e Initial load
duke
parents:
diff changeset
  3579
    /** Check that a qualified name is in canonical form (for import decls).
06bc494ca11e Initial load
duke
parents:
diff changeset
  3580
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3581
    public void checkCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3582
        if (!isCanonical(tree))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3583
            log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3584
                      Errors.ImportRequiresCanonical(TreeInfo.symbol(tree)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3585
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3586
        // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3587
        private boolean isCanonical(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3588
            while (tree.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3589
                JCFieldAccess s = (JCFieldAccess) tree;
47438
286cb51fd280 8187247: canonical import check compares classes by simple name
cushon
parents: 47268
diff changeset
  3590
                if (s.sym.owner.getQualifiedName() != TreeInfo.symbol(s.selected).getQualifiedName())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3591
                    return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3592
                tree = s.selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3593
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3594
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3595
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3596
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3597
    /** Check that an auxiliary class is not accessed from any other file than its own.
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3598
     */
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3599
    void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3600
        if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3601
            (c.flags() & AUXILIARY) != 0 &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3602
            rs.isAccessible(env, c) &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3603
            !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3604
        {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3605
            log.warning(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3606
                        Warnings.AuxiliaryClassAccessedFromOutsideOfItsSourceFile(c, c.sourcefile));
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3607
        }
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3608
    }
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3609
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3610
    private class ConversionWarner extends Warner {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3611
        final String uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3612
        final Type found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3613
        final Type expected;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3614
        public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3615
            super(pos);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3616
            this.uncheckedKey = uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3617
            this.found = found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3618
            this.expected = expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3619
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3620
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  3621
        @Override
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3622
        public void warn(LintCategory lint) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3623
            boolean warned = this.warned;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3624
            super.warn(lint);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3625
            if (warned) return; // suppress redundant diagnostics
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3626
            switch (lint) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3627
                case UNCHECKED:
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3628
                    Check.this.warnUnchecked(pos(), Warnings.ProbFoundReq(diags.fragment(uncheckedKey), found, expected));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3629
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3630
                case VARARGS:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3631
                    if (method != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3632
                            method.attribute(syms.trustMeType.tsym) != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3633
                            isTrustMeAllowedOnMethod(method) &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3634
                            !types.isReifiable(method.type.getParameterTypes().last())) {
48721
ef3557eb4306 8196403: remove the remaining use of string keys for errors and warnings in the compiler
vromero
parents: 48459
diff changeset
  3635
                        Check.this.warnUnsafeVararg(pos(), Warnings.VarargsUnsafeUseVarargsParam(method.params.last()));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3636
                    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3637
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3638
                default:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3639
                    throw new AssertionError("Unexpected lint: " + lint);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3640
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3641
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3642
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3643
06bc494ca11e Initial load
duke
parents:
diff changeset
  3644
    public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3645
        return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3646
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3647
06bc494ca11e Initial load
duke
parents:
diff changeset
  3648
    public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3649
        return new ConversionWarner(pos, "unchecked.assign", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3650
    }
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3651
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3652
    public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3653
        Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3654
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3655
        if (functionalType != null) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3656
            try {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3657
                types.findDescriptorSymbol((TypeSymbol)cs);
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3658
            } catch (Types.FunctionDescriptorLookupError ex) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3659
                DiagnosticPosition pos = tree.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3660
                for (JCAnnotation a : tree.getModifiers().annotations) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3661
                    if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3662
                        pos = a.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3663
                        break;
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3664
                    }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3665
                }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3666
                log.error(pos, Errors.BadFunctionalIntfAnno1(ex.getDiagnostic()));
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3667
            }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3668
        }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3669
    }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3670
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3671
    public void checkImportsResolvable(final JCCompilationUnit toplevel) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3672
        for (final JCImport imp : toplevel.getImports()) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3673
            if (!imp.staticImport || !imp.qualid.hasTag(SELECT))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3674
                continue;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3675
            final JCFieldAccess select = (JCFieldAccess) imp.qualid;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3676
            final Symbol origin;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3677
            if (select.name == names.asterisk || (origin = TreeInfo.symbol(select.selected)) == null || origin.kind != TYP)
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3678
                continue;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3679
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3680
            TypeSymbol site = (TypeSymbol) TreeInfo.symbol(select.selected);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3681
            if (!checkTypeContainsImportableElement(site, site, toplevel.packge, select.name, new HashSet<Symbol>())) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3682
                log.error(imp.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3683
                          Errors.CantResolveLocation(KindName.STATIC,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3684
                                                     select.name,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3685
                                                     null,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3686
                                                     null,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3687
                                                     Fragments.Location(kindName(site),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3688
                                                                        site,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3689
                                                                        null)));
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3690
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3691
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3692
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3693
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3694
    // Check that packages imported are in scope (JLS 7.4.3, 6.3, 6.5.3.1, 6.5.3.2)
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3695
    public void checkImportedPackagesObservable(final JCCompilationUnit toplevel) {
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3696
        OUTER: for (JCImport imp : toplevel.getImports()) {
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3697
            if (!imp.staticImport && TreeInfo.name(imp.qualid) == names.asterisk) {
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3698
                TypeSymbol tsym = ((JCFieldAccess)imp.qualid).selected.type.tsym;
50539
7bf4f1b5e438 8193302: Javac AssertionError: typeSig ERROR on usage of @Generated
jlahoda
parents: 50250
diff changeset
  3699
                if (tsym.kind == PCK && tsym.members().isEmpty() &&
7bf4f1b5e438 8193302: Javac AssertionError: typeSig ERROR on usage of @Generated
jlahoda
parents: 50250
diff changeset
  3700
                    !(Feature.IMPORT_ON_DEMAND_OBSERVABLE_PACKAGES.allowedInSource(source) && tsym.exists())) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 45413
diff changeset
  3701
                    log.error(DiagnosticFlag.RESOLVE_ERROR, imp.pos, Errors.DoesntExist(tsym));
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3702
                }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3703
            }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3704
        }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3705
    }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3706
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3707
    private boolean checkTypeContainsImportableElement(TypeSymbol tsym, TypeSymbol origin, PackageSymbol packge, Name name, Set<Symbol> processed) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3708
        if (tsym == null || !processed.add(tsym))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3709
            return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3710
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3711
            // also search through inherited names
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3712
        if (checkTypeContainsImportableElement(types.supertype(tsym.type).tsym, origin, packge, name, processed))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3713
            return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3714
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3715
        for (Type t : types.interfaces(tsym.type))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3716
            if (checkTypeContainsImportableElement(t.tsym, origin, packge, name, processed))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3717
                return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3718
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3719
        for (Symbol sym : tsym.members().getSymbolsByName(name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3720
            if (sym.isStatic() &&
29149
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3721
                importAccessible(sym, packge) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3722
                sym.isMemberOf(origin, types)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3723
                return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3724
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3725
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3726
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3727
        return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3728
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3729
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3730
    // is the sym accessible everywhere in packge?
29149
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3731
    public boolean importAccessible(Symbol sym, PackageSymbol packge) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3732
        try {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3733
            int flags = (int)(sym.flags() & AccessFlags);
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3734
            switch (flags) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3735
            default:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3736
            case PUBLIC:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3737
                return true;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3738
            case PRIVATE:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3739
                return false;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3740
            case 0:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3741
            case PROTECTED:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3742
                return sym.packge() == packge;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3743
            }
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3744
        } catch (ClassFinder.BadClassFile err) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3745
            throw err;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3746
        } catch (CompletionFailure ex) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3747
            return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3748
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3749
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3750
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3751
    public void checkLeaksNotAccessible(Env<AttrContext> env, JCClassDecl check) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3752
        JCCompilationUnit toplevel = env.toplevel;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3753
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3754
        if (   toplevel.modle == syms.unnamedModule
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3755
            || toplevel.modle == syms.noModule
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3756
            || (check.sym.flags() & COMPOUND) != 0) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3757
            return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3758
        }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3759
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3760
        ExportsDirective currentExport = findExport(toplevel.packge);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3761
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3762
        if (   currentExport == null //not exported
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3763
            || currentExport.modules != null) //don't check classes in qualified export
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3764
            return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3765
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3766
        new TreeScanner() {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3767
            Lint lint = env.info.lint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3768
            boolean inSuperType;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3769
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3770
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3771
            public void visitBlock(JCBlock tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3772
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3773
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3774
            public void visitMethodDef(JCMethodDecl tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3775
                if (!isAPISymbol(tree.sym))
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3776
                    return;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3777
                Lint prevLint = lint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3778
                try {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3779
                    lint = lint.augment(tree.sym);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3780
                    if (lint.isEnabled(LintCategory.EXPORTS)) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3781
                        super.visitMethodDef(tree);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3782
                    }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3783
                } finally {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3784
                    lint = prevLint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3785
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3786
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3787
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3788
            public void visitVarDef(JCVariableDecl tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3789
                if (!isAPISymbol(tree.sym) && tree.sym.owner.kind != MTH)
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3790
                    return;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3791
                Lint prevLint = lint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3792
                try {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3793
                    lint = lint.augment(tree.sym);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3794
                    if (lint.isEnabled(LintCategory.EXPORTS)) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3795
                        scan(tree.mods);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3796
                        scan(tree.vartype);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3797
                    }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3798
                } finally {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3799
                    lint = prevLint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3800
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3801
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3802
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3803
            public void visitClassDef(JCClassDecl tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3804
                if (tree != check)
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3805
                    return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3806
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3807
                if (!isAPISymbol(tree.sym))
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3808
                    return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3809
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3810
                Lint prevLint = lint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3811
                try {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3812
                    lint = lint.augment(tree.sym);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3813
                    if (lint.isEnabled(LintCategory.EXPORTS)) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3814
                        scan(tree.mods);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3815
                        scan(tree.typarams);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3816
                        try {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3817
                            inSuperType = true;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3818
                            scan(tree.extending);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3819
                            scan(tree.implementing);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3820
                        } finally {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3821
                            inSuperType = false;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3822
                        }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3823
                        scan(tree.defs);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3824
                    }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3825
                } finally {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3826
                    lint = prevLint;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3827
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3828
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3829
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3830
            public void visitTypeApply(JCTypeApply tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3831
                scan(tree.clazz);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3832
                boolean oldInSuperType = inSuperType;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3833
                try {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3834
                    inSuperType = false;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3835
                    scan(tree.arguments);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3836
                } finally {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3837
                    inSuperType = oldInSuperType;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3838
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3839
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3840
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3841
            public void visitIdent(JCIdent tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3842
                Symbol sym = TreeInfo.symbol(tree);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3843
                if (sym.kind == TYP && !sym.type.hasTag(TYPEVAR)) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3844
                    checkVisible(tree.pos(), sym, toplevel.packge, inSuperType);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3845
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3846
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3847
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3848
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3849
            public void visitSelect(JCFieldAccess tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3850
                Symbol sym = TreeInfo.symbol(tree);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3851
                Symbol sitesym = TreeInfo.symbol(tree.selected);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3852
                if (sym.kind == TYP && sitesym.kind == PCK) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3853
                    checkVisible(tree.pos(), sym, toplevel.packge, inSuperType);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3854
                } else {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3855
                    super.visitSelect(tree);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3856
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3857
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3858
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3859
            @Override
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3860
            public void visitAnnotation(JCAnnotation tree) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3861
                if (tree.attribute.type.tsym.getAnnotation(java.lang.annotation.Documented.class) != null)
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3862
                    super.visitAnnotation(tree);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3863
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3864
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3865
        }.scan(check);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3866
    }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3867
        //where:
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3868
        private ExportsDirective findExport(PackageSymbol pack) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3869
            for (ExportsDirective d : pack.modle.exports) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3870
                if (d.packge == pack)
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3871
                    return d;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3872
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3873
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3874
            return null;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3875
        }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3876
        private boolean isAPISymbol(Symbol sym) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3877
            while (sym.kind != PCK) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3878
                if ((sym.flags() & Flags.PUBLIC) == 0 && (sym.flags() & Flags.PROTECTED) == 0) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3879
                    return false;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3880
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3881
                sym = sym.owner;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3882
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3883
            return true;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3884
        }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3885
        private void checkVisible(DiagnosticPosition pos, Symbol what, PackageSymbol inPackage, boolean inSuperType) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3886
            if (!isAPISymbol(what) && !inSuperType) { //package private/private element
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3887
                log.warning(LintCategory.EXPORTS, pos, Warnings.LeaksNotAccessible(kindName(what), what, what.packge().modle));
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3888
                return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3889
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3890
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3891
            PackageSymbol whatPackage = what.packge();
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3892
            ExportsDirective whatExport = findExport(whatPackage);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3893
            ExportsDirective inExport = findExport(inPackage);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3894
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3895
            if (whatExport == null) { //package not exported:
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3896
                log.warning(LintCategory.EXPORTS, pos, Warnings.LeaksNotAccessibleUnexported(kindName(what), what, what.packge().modle));
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3897
                return ;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3898
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3899
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3900
            if (whatExport.modules != null) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3901
                if (inExport.modules == null || !whatExport.modules.containsAll(inExport.modules)) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3902
                    log.warning(LintCategory.EXPORTS, pos, Warnings.LeaksNotAccessibleUnexportedQualified(kindName(what), what, what.packge().modle));
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3903
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3904
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3905
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3906
            if (whatPackage.modle != inPackage.modle && whatPackage.modle != syms.java_base) {
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
  3907
                //check that relativeTo.modle requires transitive what.modle, somehow:
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3908
                List<ModuleSymbol> todo = List.of(inPackage.modle);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3909
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3910
                while (todo.nonEmpty()) {
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3911
                    ModuleSymbol current = todo.head;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3912
                    todo = todo.tail;
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3913
                    if (current == whatPackage.modle)
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3914
                        return ; //OK
47873
7944849362f3 8191112: javac OutOfMemoryError caused by \"-Xlint:exports\" option
jlahoda
parents: 47438
diff changeset
  3915
                    if ((current.flags() & Flags.AUTOMATIC_MODULE) != 0)
7944849362f3 8191112: javac OutOfMemoryError caused by \"-Xlint:exports\" option
jlahoda
parents: 47438
diff changeset
  3916
                        continue; //for automatic modules, don't look into their dependencies
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3917
                    for (RequiresDirective req : current.requires) {
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
  3918
                        if (req.isTransitive()) {
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3919
                            todo = todo.prepend(req.module);
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3920
                        }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3921
                    }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3922
                }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3923
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41637
diff changeset
  3924
                log.warning(LintCategory.EXPORTS, pos, Warnings.LeaksNotAccessibleNotRequiredTransitive(kindName(what), what, what.packge().modle));
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3925
            }
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 40772
diff changeset
  3926
        }
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3927
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3928
    void checkModuleExists(final DiagnosticPosition pos, ModuleSymbol msym) {
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3929
        if (msym.kind != MDL) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3930
            deferredLintHandler.report(() -> {
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3931
                if (lint.isEnabled(LintCategory.MODULE))
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3932
                    log.warning(LintCategory.MODULE, pos, Warnings.ModuleNotFound(msym));
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3933
            });
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3934
        }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3935
    }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42407
diff changeset
  3936
43588
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3937
    void checkPackageExistsForOpens(final DiagnosticPosition pos, PackageSymbol packge) {
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3938
        if (packge.members().isEmpty() &&
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3939
            ((packge.flags() & Flags.HAS_RESOURCE) == 0)) {
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3940
            deferredLintHandler.report(() -> {
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3941
                if (lint.isEnabled(LintCategory.OPENS))
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3942
                    log.warning(pos, Warnings.PackageEmptyOrNotFound(packge));
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3943
            });
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3944
        }
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3945
    }
6a0e0ea0e93b 8172901: javac: 'opens' statement cannot specify non observable package
jjg
parents: 43279
diff changeset
  3946
44576
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3947
    void checkModuleRequires(final DiagnosticPosition pos, final RequiresDirective rd) {
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3948
        if ((rd.module.flags() & Flags.AUTOMATIC_MODULE) != 0) {
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3949
            deferredLintHandler.report(() -> {
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3950
                if (rd.isTransitive() && lint.isEnabled(LintCategory.REQUIRES_TRANSITIVE_AUTOMATIC)) {
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3951
                    log.warning(pos, Warnings.RequiresTransitiveAutomatic);
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3952
                } else if (lint.isEnabled(LintCategory.REQUIRES_AUTOMATIC)) {
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3953
                    log.warning(pos, Warnings.RequiresAutomatic);
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3954
                }
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3955
            });
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3956
        }
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3957
    }
9e18c9ce29e7 8178011: Automatic module warnings
jlahoda
parents: 44568
diff changeset
  3958
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3959
}