langtools/src/share/classes/com/sun/tools/javac/comp/Check.java
author mcimadamore
Mon, 07 Mar 2011 14:31:50 +0000
changeset 8635 383a416a2bdf
parent 8628 9e31f1c01bd4
child 9073 a29adf86aa0c
permissions -rw-r--r--
7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Summary: Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR) Reviewed-by: jjg
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
8031
d5fe2c1cecfc 6992999: fully remove JSR 308 from langtools
jjg
parents: 7681
diff changeset
     2
 * Copyright (c) 1999, 2011, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
import java.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    29
import java.util.Set;
06bc494ca11e Initial load
duke
parents:
diff changeset
    30
06bc494ca11e Initial load
duke
parents:
diff changeset
    31
import com.sun.tools.javac.code.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
import com.sun.tools.javac.jvm.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    34
import com.sun.tools.javac.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
import com.sun.tools.javac.util.List;
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
06bc494ca11e Initial load
duke
parents:
diff changeset
    38
import com.sun.tools.javac.tree.JCTree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
import com.sun.tools.javac.code.Lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    40
import com.sun.tools.javac.code.Lint.LintCategory;
06bc494ca11e Initial load
duke
parents:
diff changeset
    41
import com.sun.tools.javac.code.Type.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    42
import com.sun.tools.javac.code.Symbol.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    43
06bc494ca11e Initial load
duke
parents:
diff changeset
    44
import static com.sun.tools.javac.code.Flags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    45
import static com.sun.tools.javac.code.Kinds.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    46
import static com.sun.tools.javac.code.TypeTags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    47
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    48
import static com.sun.tools.javac.main.OptionName.*;
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    49
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    50
/** Type checking helper class for the attribution phase.
06bc494ca11e Initial load
duke
parents:
diff changeset
    51
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    52
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    53
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    54
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    55
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    57
public class Check {
06bc494ca11e Initial load
duke
parents:
diff changeset
    58
    protected static final Context.Key<Check> checkKey =
06bc494ca11e Initial load
duke
parents:
diff changeset
    59
        new Context.Key<Check>();
06bc494ca11e Initial load
duke
parents:
diff changeset
    60
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    61
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    62
    private final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
    63
    private final Symtab syms;
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    64
    private final Enter enter;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
    private final Infer infer;
06bc494ca11e Initial load
duke
parents:
diff changeset
    66
    private final Types types;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    67
    private final JCDiagnostic.Factory diags;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
    private final boolean skipAnnotations;
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
    69
    private boolean warnOnSyntheticConflicts;
5842
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
    70
    private boolean suppressAbortOnBadClassFile;
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
    71
    private boolean enableSunApiLintControl;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
    private final TreeInfo treeinfo;
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
06bc494ca11e Initial load
duke
parents:
diff changeset
    74
    // The set of lint options currently in effect. It is initialized
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
    // from the context, and then is set/reset as needed by Attr as it
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
    // visits all the various parts of the trees during attribution.
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
    private Lint lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    79
    // The method being analyzed in Attr - it is set/reset as needed by
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    80
    // Attr as it visits new method declarations.
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    81
    private MethodSymbol method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    82
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
    public static Check instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    84
        Check instance = context.get(checkKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
    86
            instance = new Check(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
    protected Check(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    91
        context.put(checkKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    93
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    94
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    95
        syms = Symtab.instance(context);
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    96
        enter = Enter.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    97
        infer = Infer.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
        this.types = Types.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    99
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
        lint = Lint.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
        treeinfo = TreeInfo.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
        Source source = Source.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
        allowGenerics = source.allowGenerics();
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
        allowAnnotations = source.allowAnnotations();
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   107
        allowCovariantReturns = source.allowCovariantReturns();
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   108
        allowSimplifiedVarargs = source.allowSimplifiedVarargs();
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   109
        complexInference = options.isSet(COMPLEXINFERENCE);
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   110
        skipAnnotations = options.isSet("skipAnnotations");
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   111
        warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   112
        suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   113
        enableSunApiLintControl = options.isSet("enableSunApiLintControl");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   114
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   115
        Target target = Target.instance(context);
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   116
        syntheticNameChar = target.syntheticNameChar();
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   117
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   118
        boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
06bc494ca11e Initial load
duke
parents:
diff changeset
   119
        boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   120
        boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   121
        boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   123
        deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   124
                enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   125
        uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   126
                enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   127
        sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   128
                enforceMandatoryWarnings, "sunapi", null);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   129
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   130
        deferredLintHandler = DeferredLintHandler.immediateHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   132
06bc494ca11e Initial load
duke
parents:
diff changeset
   133
    /** Switch: generics enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   135
    boolean allowGenerics;
06bc494ca11e Initial load
duke
parents:
diff changeset
   136
06bc494ca11e Initial load
duke
parents:
diff changeset
   137
    /** Switch: annotations enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   138
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   139
    boolean allowAnnotations;
06bc494ca11e Initial load
duke
parents:
diff changeset
   140
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   141
    /** Switch: covariant returns enabled?
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   142
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   143
    boolean allowCovariantReturns;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   144
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   145
    /** Switch: simplified varargs enabled?
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   146
     */
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   147
    boolean allowSimplifiedVarargs;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   148
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   149
    /** Switch: -complexinference option set?
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
    boolean complexInference;
06bc494ca11e Initial load
duke
parents:
diff changeset
   152
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   153
    /** Character for synthetic names
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   154
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   155
    char syntheticNameChar;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   156
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   157
    /** A table mapping flat names of all compiled classes in this run to their
06bc494ca11e Initial load
duke
parents:
diff changeset
   158
     *  symbols; maintained from outside.
06bc494ca11e Initial load
duke
parents:
diff changeset
   159
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   160
    public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
   161
06bc494ca11e Initial load
duke
parents:
diff changeset
   162
    /** A handler for messages about deprecated usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   163
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   164
    private MandatoryWarningHandler deprecationHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   165
06bc494ca11e Initial load
duke
parents:
diff changeset
   166
    /** A handler for messages about unchecked or unsafe usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   167
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   168
    private MandatoryWarningHandler uncheckedHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   169
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   170
    /** A handler for messages about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   171
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   172
    private MandatoryWarningHandler sunApiHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   173
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   174
    /** A handler for deferred lint warnings.
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   175
     */
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   176
    private DeferredLintHandler deferredLintHandler;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   177
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   178
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   179
 * Errors and Warnings
06bc494ca11e Initial load
duke
parents:
diff changeset
   180
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   181
06bc494ca11e Initial load
duke
parents:
diff changeset
   182
    Lint setLint(Lint newLint) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   183
        Lint prev = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   184
        lint = newLint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
        return prev;
06bc494ca11e Initial load
duke
parents:
diff changeset
   186
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   187
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   188
    DeferredLintHandler setDeferredLintHandler(DeferredLintHandler newDeferredLintHandler) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   189
        DeferredLintHandler prev = deferredLintHandler;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   190
        deferredLintHandler = newDeferredLintHandler;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   191
        return prev;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   192
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   193
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   194
    MethodSymbol setMethod(MethodSymbol newMethod) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   195
        MethodSymbol prev = method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   196
        method = newMethod;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   197
        return prev;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   198
    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   199
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
    /** Warn about deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   201
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   202
     *  @param sym        The deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   203
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   204
    void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   205
        if (!lint.isSuppressed(LintCategory.DEPRECATION))
06bc494ca11e Initial load
duke
parents:
diff changeset
   206
            deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   207
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   208
06bc494ca11e Initial load
duke
parents:
diff changeset
   209
    /** Warn about unchecked operation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   210
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   211
     *  @param msg        A string describing the problem.
06bc494ca11e Initial load
duke
parents:
diff changeset
   212
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   213
    public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   214
        if (!lint.isSuppressed(LintCategory.UNCHECKED))
06bc494ca11e Initial load
duke
parents:
diff changeset
   215
            uncheckedHandler.report(pos, msg, args);
06bc494ca11e Initial load
duke
parents:
diff changeset
   216
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   218
    /** Warn about unsafe vararg method decl.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   219
     *  @param pos        Position to be used for error reporting.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   220
     *  @param sym        The deprecated symbol.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   221
     */
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   222
    void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   223
        if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   224
            log.warning(LintCategory.VARARGS, pos, key, args);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   225
    }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   226
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   227
    /** Warn about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   228
     *  @param pos        Position to be used for error reporting.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   229
     *  @param msg        A string describing the problem.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   230
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   231
    public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   232
        if (!lint.isSuppressed(LintCategory.SUNAPI))
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   233
            sunApiHandler.report(pos, msg, args);
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   234
    }
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   235
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   236
    public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   237
        if (lint.isEnabled(LintCategory.STATIC))
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   238
            log.warning(LintCategory.STATIC, pos, msg, args);
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   239
    }
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   240
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   241
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   242
     * Report any deferred diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
   243
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   244
    public void reportDeferredDiagnostics() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   245
        deprecationHandler.reportDeferredDiagnostic();
06bc494ca11e Initial load
duke
parents:
diff changeset
   246
        uncheckedHandler.reportDeferredDiagnostic();
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   247
        sunApiHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   248
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   249
06bc494ca11e Initial load
duke
parents:
diff changeset
   250
06bc494ca11e Initial load
duke
parents:
diff changeset
   251
    /** Report a failure to complete a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   252
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   253
     *  @param ex         The failure to report.
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   255
    public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
169
ff76730e430e 6668794: javac puts localized text in raw diagnostics
jjg
parents: 10
diff changeset
   256
        log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
5842
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
   257
        if (ex instanceof ClassReader.BadClassFile
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
   258
                && !suppressAbortOnBadClassFile) throw new Abort();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
        else return syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
    /** Report a type error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   263
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
     *  @param problem    A string describing the error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   266
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   267
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   268
    Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   269
        log.error(pos, "prob.found.req",
06bc494ca11e Initial load
duke
parents:
diff changeset
   270
                  problem, found, req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   271
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   272
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
    Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
        log.error(pos, "prob.found.req.1", problem, found, req, explanation);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   276
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
06bc494ca11e Initial load
duke
parents:
diff changeset
   279
    /** Report an error that wrong type tag was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   280
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   281
     *  @param required   An internationalized string describing the type tag
06bc494ca11e Initial load
duke
parents:
diff changeset
   282
     *                    required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   283
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   284
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
    Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   286
        // this error used to be raised by the parser,
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   287
        // but has been delayed to this point:
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   288
        if (found instanceof Type && ((Type)found).tag == VOID) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   289
            log.error(pos, "illegal.start.of.type");
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   290
            return syms.errType;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   291
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
        log.error(pos, "type.found.req", found, required);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   293
        return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   294
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   295
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
    /** Report an error that symbol cannot be referenced before super
06bc494ca11e Initial load
duke
parents:
diff changeset
   297
     *  has been called.
06bc494ca11e Initial load
duke
parents:
diff changeset
   298
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
     *  @param sym        The referenced symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
    void earlyRefError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
        log.error(pos, "cant.ref.before.ctor.called", sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   304
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
    /** Report duplicate declaration error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
    void duplicateError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   308
        if (!sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
            log.error(pos, "already.defined", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   311
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
    /** Report array/varargs duplicate declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
    void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
            log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
 * duplicate declaration checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
    /** Check that variable does not hide variable with same name in
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
     *  immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
     *  @param v             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
    void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
            for (Scope.Entry e = s.next.lookup(v.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
                 e.scope != null && e.sym.owner == v.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
                 e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   336
                if (e.sym.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   338
                    v.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   339
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   340
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   341
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   342
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   343
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   345
06bc494ca11e Initial load
duke
parents:
diff changeset
   346
    /** Check that a class or interface does not hide a class or
06bc494ca11e Initial load
duke
parents:
diff changeset
   347
     *  interface with same name in immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   348
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
     *  @param c             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   351
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   352
    void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   353
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
            for (Scope.Entry e = s.next.lookup(c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
                 e.scope != null && e.sym.owner == c.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   356
                 e = e.next()) {
6352
217d5a69681a 6977800: Regression: invalid resolution of supertype for local class
mcimadamore
parents: 6351
diff changeset
   357
                if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
                    c.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
    /** Check that class does not have the same name as one of
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
     *  its enclosing classes, or as a class defined in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
     *  return true if class is unique in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   371
     *  @param name          The class name.
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
     *  @param s             The enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   373
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
    boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
        for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
            if (e.sym.kind == TYP && e.sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   377
                duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   378
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   379
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   380
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   381
        for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   382
            if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   383
                duplicateError(pos, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   384
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   385
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   386
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   387
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   388
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   389
06bc494ca11e Initial load
duke
parents:
diff changeset
   390
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   391
 * Class name generation
06bc494ca11e Initial load
duke
parents:
diff changeset
   392
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
06bc494ca11e Initial load
duke
parents:
diff changeset
   394
    /** Return name of local class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   395
     *  This is of the form    <enclClass> $ n <classname>
06bc494ca11e Initial load
duke
parents:
diff changeset
   396
     *  where
06bc494ca11e Initial load
duke
parents:
diff changeset
   397
     *    enclClass is the flat name of the enclosing class,
06bc494ca11e Initial load
duke
parents:
diff changeset
   398
     *    classname is the simple name of the local class
06bc494ca11e Initial load
duke
parents:
diff changeset
   399
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   400
    Name localClassName(ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   401
        for (int i=1; ; i++) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   402
            Name flatname = names.
06bc494ca11e Initial load
duke
parents:
diff changeset
   403
                fromString("" + c.owner.enclClass().flatname +
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   404
                           syntheticNameChar + i +
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   405
                           c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   406
            if (compiled.get(flatname) == null) return flatname;
06bc494ca11e Initial load
duke
parents:
diff changeset
   407
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   408
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
 * Type Checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   413
06bc494ca11e Initial load
duke
parents:
diff changeset
   414
    /** Check that a given type is assignable to a given proto-type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   415
     *  If it is, return the type, otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
   416
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   417
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   418
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   419
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   420
    Type checkType(DiagnosticPosition pos, Type found, Type req) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   421
        return checkType(pos, found, req, "incompatible.types");
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   422
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   423
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   424
    Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   425
        if (req.tag == ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   426
            return req;
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   427
        if (found.tag == FORALL)
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   428
            return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   429
        if (req.tag == NONE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
        if (types.isAssignable(found, req, convertWarner(pos, found, req)))
06bc494ca11e Initial load
duke
parents:
diff changeset
   432
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   433
        if (found.tag <= DOUBLE && req.tag <= DOUBLE)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   434
            return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   435
        if (found.isSuperBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   436
            log.error(pos, "assignment.from.super-bound", found);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   437
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   438
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   439
        if (req.isExtendsBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   440
            log.error(pos, "assignment.to.extends-bound", req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   441
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   442
        }
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   443
        return typeError(pos, diags.fragment(errKey), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   444
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   445
06bc494ca11e Initial load
duke
parents:
diff changeset
   446
    /** Instantiate polymorphic type to some prototype, unless
06bc494ca11e Initial load
duke
parents:
diff changeset
   447
     *  prototype is `anyPoly' in which case polymorphic type
06bc494ca11e Initial load
duke
parents:
diff changeset
   448
     *  is returned unchanged.
06bc494ca11e Initial load
duke
parents:
diff changeset
   449
     */
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   450
    Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   451
        if (pt == Infer.anyPoly && complexInference) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   452
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   453
        } else if (pt == Infer.anyPoly || pt.tag == NONE) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   454
            Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   455
            return instantiatePoly(pos, t, newpt, warn);
06bc494ca11e Initial load
duke
parents:
diff changeset
   456
        } else if (pt.tag == ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   457
            return pt;
06bc494ca11e Initial load
duke
parents:
diff changeset
   458
        } else {
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   459
            try {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   460
                return infer.instantiateExpr(t, pt, warn);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   461
            } catch (Infer.NoInstanceException ex) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   462
                if (ex.isAmbiguous) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   463
                    JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   464
                    log.error(pos,
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   465
                              "undetermined.type" + (d!=null ? ".1" : ""),
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   466
                              t, d);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   467
                    return types.createErrorType(pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   468
                } else {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   469
                    JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   470
                    return typeError(pos,
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   471
                                     diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   472
                                     t, pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   473
                }
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   474
            } catch (Infer.InvalidInstanceException ex) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   475
                JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   476
                log.error(pos, "invalid.inferred.types", t.tvars, d);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   477
                return types.createErrorType(pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   478
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   479
        }
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   480
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   481
06bc494ca11e Initial load
duke
parents:
diff changeset
   482
    /** Check that a given type can be cast to a given target type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   483
     *  Return the result of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   484
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   485
     *  @param found      The type that is being cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   486
     *  @param req        The target type of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   487
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   488
    Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   489
        if (found.tag == FORALL) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   490
            instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
06bc494ca11e Initial load
duke
parents:
diff changeset
   491
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   492
        } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   493
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   494
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   495
            return typeError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   496
                             diags.fragment("inconvertible.types"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   497
                             found, req);
06bc494ca11e Initial load
duke
parents:
diff changeset
   498
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   499
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   500
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
   501
        /** Is type a type variable, or a (possibly multi-dimensional) array of
06bc494ca11e Initial load
duke
parents:
diff changeset
   502
         *  type variables?
06bc494ca11e Initial load
duke
parents:
diff changeset
   503
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
   504
        boolean isTypeVar(Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   505
            return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
06bc494ca11e Initial load
duke
parents:
diff changeset
   506
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   507
06bc494ca11e Initial load
duke
parents:
diff changeset
   508
    /** Check that a type is within some bounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   509
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   510
     *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
06bc494ca11e Initial load
duke
parents:
diff changeset
   511
     *  type argument.
06bc494ca11e Initial load
duke
parents:
diff changeset
   512
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   513
     *  @param a             The type that should be bounded by bs.
06bc494ca11e Initial load
duke
parents:
diff changeset
   514
     *  @param bs            The bound.
06bc494ca11e Initial load
duke
parents:
diff changeset
   515
     */
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   516
    private boolean checkExtends(Type a, TypeVar bs) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   517
         if (a.isUnbound()) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   518
             return true;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   519
         } else if (a.tag != WILDCARD) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   520
             a = types.upperBound(a);
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   521
             return types.isSubtype(a, bs.bound);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   522
         } else if (a.isExtendsBound()) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   523
             return types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   524
         } else if (a.isSuperBound()) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   525
             return !types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound());
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   526
         }
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   527
         return true;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   528
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   529
06bc494ca11e Initial load
duke
parents:
diff changeset
   530
    /** Check that type is different from 'void'.
06bc494ca11e Initial load
duke
parents:
diff changeset
   531
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   532
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   533
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   534
    Type checkNonVoid(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   535
        if (t.tag == VOID) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   536
            log.error(pos, "void.not.allowed.here");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   537
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   538
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   539
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   540
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   541
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   542
06bc494ca11e Initial load
duke
parents:
diff changeset
   543
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   544
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   545
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   546
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   547
    Type checkClassType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   548
        if (t.tag != CLASS && t.tag != ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   549
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   550
                                diags.fragment("type.req.class"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   551
                                (t.tag == TYPEVAR)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   552
                                ? diags.fragment("type.parameter", t)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   553
                                : t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   554
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
   555
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   556
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   557
06bc494ca11e Initial load
duke
parents:
diff changeset
   558
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   559
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   560
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   561
     *  @param noBounds    True if type bounds are illegal here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   562
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   563
    Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   564
        t = checkClassType(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   565
        if (noBounds && t.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   566
            List<Type> args = t.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
   567
            while (args.nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   568
                if (args.head.tag == WILDCARD)
06bc494ca11e Initial load
duke
parents:
diff changeset
   569
                    return typeTagError(pos,
6032
03b276d8e6a6 6968497: localized text appears in raw diagnostic
jjg
parents: 5848
diff changeset
   570
                                        diags.fragment("type.req.exact"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   571
                                        args.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
   572
                args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   573
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   574
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   575
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   576
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   577
06bc494ca11e Initial load
duke
parents:
diff changeset
   578
    /** Check that type is a reifiable class, interface or array type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   579
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   580
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   581
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   582
    Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   583
        if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   584
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   585
                                diags.fragment("type.req.class.array"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   586
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   587
        } else if (!types.isReifiable(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   588
            log.error(pos, "illegal.generic.type.for.instof");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   589
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   590
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   591
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   592
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   593
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   594
06bc494ca11e Initial load
duke
parents:
diff changeset
   595
    /** Check that type is a reference type, i.e. a class, interface or array type
06bc494ca11e Initial load
duke
parents:
diff changeset
   596
     *  or a type variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   597
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   598
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   599
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   600
    Type checkRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   601
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   602
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   603
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   604
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   605
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   606
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   607
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   608
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   609
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   610
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   611
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   612
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   613
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   614
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   615
    /** Check that each type is a reference type, i.e. a class, interface or array type
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   616
     *  or a type variable.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   617
     *  @param trees         Original trees, used for error reporting.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   618
     *  @param types         The types to be checked.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   619
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   620
    List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   621
        List<JCExpression> tl = trees;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   622
        for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   623
            l.head = checkRefType(tl.head.pos(), l.head);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   624
            tl = tl.tail;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   625
        }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   626
        return types;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   627
    }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   628
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   629
    /** Check that type is a null or reference type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   630
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   631
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   632
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   633
    Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   634
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   635
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   636
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   637
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   638
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   639
        case BOT:
06bc494ca11e Initial load
duke
parents:
diff changeset
   640
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   641
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   642
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   643
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   644
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   645
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   646
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   647
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   648
06bc494ca11e Initial load
duke
parents:
diff changeset
   649
    /** Check that flag set does not contain elements of two conflicting sets. s
06bc494ca11e Initial load
duke
parents:
diff changeset
   650
     *  Return true if it doesn't.
06bc494ca11e Initial load
duke
parents:
diff changeset
   651
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   652
     *  @param flags         The set of flags to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   653
     *  @param set1          Conflicting flags set #1.
06bc494ca11e Initial load
duke
parents:
diff changeset
   654
     *  @param set2          Conflicting flags set #2.
06bc494ca11e Initial load
duke
parents:
diff changeset
   655
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   656
    boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   657
        if ((flags & set1) != 0 && (flags & set2) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   658
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
   659
                      "illegal.combination.of.modifiers",
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   660
                      asFlagSet(TreeInfo.firstFlag(flags & set1)),
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   661
                      asFlagSet(TreeInfo.firstFlag(flags & set2)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   662
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   663
        } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   664
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   665
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   667
    /** Check that usage of diamond operator is correct (i.e. diamond should not
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   668
     * be used with non-generic classes or in anonymous class creation expressions)
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   669
     */
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   670
    Type checkDiamond(JCNewClass tree, Type t) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   671
        if (!TreeInfo.isDiamond(tree) ||
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   672
                t.isErroneous()) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   673
            return checkClassType(tree.clazz.pos(), t, true);
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   674
        } else if (tree.def != null) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   675
            log.error(tree.clazz.pos(),
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   676
                    "cant.apply.diamond.1",
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   677
                    t, diags.fragment("diamond.and.anon.class", t));
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   678
            return types.createErrorType(t);
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   679
        } else if (!t.tsym.type.isParameterized()) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   680
            log.error(tree.clazz.pos(),
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   681
                "cant.apply.diamond.1",
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   682
                t, diags.fragment("diamond.non.generic", t));
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   683
            return types.createErrorType(t);
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   684
        } else {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   685
            return t;
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   686
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   687
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   688
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   689
    void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   690
        MethodSymbol m = tree.sym;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   691
        if (!allowSimplifiedVarargs) return;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   692
        boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   693
        Type varargElemType = null;
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   694
        if (m.isVarArgs()) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   695
            varargElemType = types.elemtype(tree.params.last().type);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   696
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   697
        if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   698
            if (varargElemType != null) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   699
                log.error(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   700
                        "varargs.invalid.trustme.anno",
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   701
                        syms.trustMeType.tsym,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   702
                        diags.fragment("varargs.trustme.on.virtual.varargs", m));
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   703
            } else {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   704
                log.error(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   705
                            "varargs.invalid.trustme.anno",
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   706
                            syms.trustMeType.tsym,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   707
                            diags.fragment("varargs.trustme.on.non.varargs.meth", m));
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   708
            }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   709
        } else if (hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   710
                            types.isReifiable(varargElemType)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   711
            warnUnsafeVararg(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   712
                            "varargs.redundant.trustme.anno",
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   713
                            syms.trustMeType.tsym,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   714
                            diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   715
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   716
        else if (!hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   717
                !types.isReifiable(varargElemType)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   718
            warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   719
        }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   720
    }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   721
    //where
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   722
        private boolean isTrustMeAllowedOnMethod(Symbol s) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   723
            return (s.flags() & VARARGS) != 0 &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   724
                (s.isConstructor() ||
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   725
                    (s.flags() & (STATIC | FINAL)) != 0);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   726
        }
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   727
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   728
    /**
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   729
     * Check that vararg method call is sound
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   730
     * @param pos Position to be used for error reporting.
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   731
     * @param argtypes Actual arguments supplied to vararg method.
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   732
     */
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   733
    void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym) {
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   734
        Type argtype = argtypes.last();
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   735
        if (!types.isReifiable(argtype) &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   736
                (!allowSimplifiedVarargs ||
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   737
                msym.attribute(syms.trustMeType.tsym) == null ||
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   738
                !isTrustMeAllowedOnMethod(msym))) {
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   739
            warnUnchecked(pos,
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   740
                              "unchecked.generic.array.creation",
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   741
                              argtype);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   742
        }
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   743
    }
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   744
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   745
    /**
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   746
     * Check that type 't' is a valid instantiation of a generic class
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   747
     * (see JLS 4.5)
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   748
     *
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   749
     * @param t class type to be checked
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   750
     * @return true if 't' is well-formed
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   751
     */
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   752
    public boolean checkValidGenericType(Type t) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   753
        return firstIncompatibleTypeArg(t) == null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   754
    }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   755
    //WHERE
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   756
        private Type firstIncompatibleTypeArg(Type type) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   757
            List<Type> formals = type.tsym.type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   758
            List<Type> actuals = type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   759
            List<Type> args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   760
            List<Type> forms = type.tsym.type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   761
            ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   762
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   763
            // For matching pairs of actual argument types `a' and
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   764
            // formal type parameters with declared bound `b' ...
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   765
            while (args.nonEmpty() && forms.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   766
                // exact type arguments needs to know their
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   767
                // bounds (for upper and lower bound
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   768
                // calculations).  So we create new TypeVars with
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   769
                // bounds substed with actuals.
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   770
                tvars_buf.append(types.substBound(((TypeVar)forms.head),
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   771
                                                  formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   772
                                                  actuals));
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   773
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   774
                forms = forms.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   775
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   776
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   777
            args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   778
            List<Type> tvars_cap = types.substBounds(formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   779
                                      formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   780
                                      types.capture(type).allparams());
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   781
            while (args.nonEmpty() && tvars_cap.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   782
                // Let the actual arguments know their bound
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   783
                args.head.withTypeVar((TypeVar)tvars_cap.head);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   784
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   785
                tvars_cap = tvars_cap.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   786
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   787
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   788
            args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   789
            List<Type> tvars = tvars_buf.toList();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   790
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   791
            while (args.nonEmpty() && tvars.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   792
                Type actual = types.subst(args.head,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   793
                    type.tsym.type.getTypeArguments(),
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   794
                    tvars_buf.toList());
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   795
                if (!isTypeArgErroneous(actual) &&
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   796
                        !tvars.head.getUpperBound().isErroneous() &&
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   797
                        !checkExtends(actual, (TypeVar)tvars.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   798
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   799
                }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   800
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   801
                tvars = tvars.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   802
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   803
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   804
            args = type.getTypeArguments();
8044
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
   805
            tvars = tvars_buf.toList();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   806
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   807
            for (Type arg : types.capture(type).getTypeArguments()) {
8044
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
   808
                if (arg.tag == TYPEVAR &&
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
   809
                        arg.getUpperBound().isErroneous() &&
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   810
                        !tvars.head.getUpperBound().isErroneous() &&
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   811
                        !isTypeArgErroneous(args.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   812
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   813
                }
8044
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
   814
                tvars = tvars.tail;
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   815
                args = args.tail;
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   816
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   817
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   818
            return null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   819
        }
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   820
        //where
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   821
        boolean isTypeArgErroneous(Type t) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   822
            return isTypeArgErroneous.visit(t);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   823
        }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   824
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   825
        Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   826
            public Boolean visitType(Type t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   827
                return t.isErroneous();
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   828
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   829
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   830
            public Boolean visitTypeVar(TypeVar t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   831
                return visit(t.getUpperBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   832
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   833
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   834
            public Boolean visitCapturedType(CapturedType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   835
                return visit(t.getUpperBound()) ||
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   836
                        visit(t.getLowerBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   837
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   838
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   839
            public Boolean visitWildcardType(WildcardType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   840
                return visit(t.type);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   841
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
   842
        };
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   843
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   844
    /** Check that given modifiers are legal for given symbol and
06bc494ca11e Initial load
duke
parents:
diff changeset
   845
     *  return modifiers together with any implicit modififiers for that symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   846
     *  Warning: we can't use flags() here since this method
06bc494ca11e Initial load
duke
parents:
diff changeset
   847
     *  is called during class enter, when flags() would cause a premature
06bc494ca11e Initial load
duke
parents:
diff changeset
   848
     *  completion.
06bc494ca11e Initial load
duke
parents:
diff changeset
   849
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   850
     *  @param flags         The set of modifiers given in a definition.
06bc494ca11e Initial load
duke
parents:
diff changeset
   851
     *  @param sym           The defined symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   852
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   853
    long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   854
        long mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   855
        long implicit = 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   856
        switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   857
        case VAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   858
            if (sym.owner.kind != TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
   859
                mask = LocalVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   860
            else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   861
                mask = implicit = InterfaceVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   862
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
   863
                mask = VarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   864
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   865
        case MTH:
06bc494ca11e Initial load
duke
parents:
diff changeset
   866
            if (sym.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   867
                if ((sym.owner.flags_field & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   868
                    // enum constructors cannot be declared public or
06bc494ca11e Initial load
duke
parents:
diff changeset
   869
                    // protected and must be implicitly or explicitly
06bc494ca11e Initial load
duke
parents:
diff changeset
   870
                    // private
06bc494ca11e Initial load
duke
parents:
diff changeset
   871
                    implicit = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   872
                    mask = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   873
                } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   874
                    mask = ConstructorFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   875
            }  else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   876
                mask = implicit = InterfaceMethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   877
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   878
                mask = MethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   879
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   880
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   881
            if (((flags|implicit) & Flags.ABSTRACT) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   882
              implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   883
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   884
        case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
   885
            if (sym.isLocal()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   886
                mask = LocalClassFlags;
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   887
                if (sym.name.isEmpty()) { // Anonymous class
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   888
                    // Anonymous classes in static methods are themselves static;
06bc494ca11e Initial load
duke
parents:
diff changeset
   889
                    // that's why we admit STATIC here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   890
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   891
                    // JLS: Anonymous classes are final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   892
                    implicit |= FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
   893
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   894
                if ((sym.owner.flags_field & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   895
                    (flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   896
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   897
            } else if (sym.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   898
                mask = MemberClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   899
                if (sym.owner.owner.kind == PCK ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   900
                    (sym.owner.flags_field & STATIC) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   901
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   902
                else if ((flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   903
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   904
                // Nested interfaces and enums are always STATIC (Spec ???)
06bc494ca11e Initial load
duke
parents:
diff changeset
   905
                if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   906
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   907
                mask = ClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   908
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   909
            // Interfaces are always ABSTRACT
06bc494ca11e Initial load
duke
parents:
diff changeset
   910
            if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
   911
06bc494ca11e Initial load
duke
parents:
diff changeset
   912
            if ((flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   913
                // enums can't be declared abstract or final
06bc494ca11e Initial load
duke
parents:
diff changeset
   914
                mask &= ~(ABSTRACT | FINAL);
06bc494ca11e Initial load
duke
parents:
diff changeset
   915
                implicit |= implicitEnumFinalFlag(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
   916
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   917
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   918
            implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   919
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   920
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   921
            throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
   922
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   923
        long illegal = flags & StandardFlags & ~mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   924
        if (illegal != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   925
            if ((illegal & INTERFACE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   926
                log.error(pos, "intf.not.allowed.here");
06bc494ca11e Initial load
duke
parents:
diff changeset
   927
                mask |= INTERFACE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   928
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   929
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   930
                log.error(pos,
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   931
                          "mod.not.allowed.here", asFlagSet(illegal));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   932
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   933
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   934
        else if ((sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   935
                  // ISSUE: Disallowing abstract&private is no longer appropriate
06bc494ca11e Initial load
duke
parents:
diff changeset
   936
                  // in the presence of inner classes. Should it be deleted here?
06bc494ca11e Initial load
duke
parents:
diff changeset
   937
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   938
                                ABSTRACT,
06bc494ca11e Initial load
duke
parents:
diff changeset
   939
                                PRIVATE | STATIC))
06bc494ca11e Initial load
duke
parents:
diff changeset
   940
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   941
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   942
                               ABSTRACT | INTERFACE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   943
                               FINAL | NATIVE | SYNCHRONIZED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   944
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   945
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   946
                               PUBLIC,
06bc494ca11e Initial load
duke
parents:
diff changeset
   947
                               PRIVATE | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   948
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   949
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   950
                               PRIVATE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   951
                               PUBLIC | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   952
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   953
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   954
                               FINAL,
06bc494ca11e Initial load
duke
parents:
diff changeset
   955
                               VOLATILE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   956
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   957
                 (sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   958
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   959
                                ABSTRACT | NATIVE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   960
                                STRICTFP))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   961
            // skip
06bc494ca11e Initial load
duke
parents:
diff changeset
   962
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   963
        return flags & (mask | ~StandardFlags) | implicit;
06bc494ca11e Initial load
duke
parents:
diff changeset
   964
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   965
06bc494ca11e Initial load
duke
parents:
diff changeset
   966
06bc494ca11e Initial load
duke
parents:
diff changeset
   967
    /** Determine if this enum should be implicitly final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   968
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   969
     *  If the enum has no specialized enum contants, it is final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   970
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   971
     *  If the enum does have specialized enum contants, it is
06bc494ca11e Initial load
duke
parents:
diff changeset
   972
     *  <i>not</i> final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   973
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   974
    private long implicitEnumFinalFlag(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   975
        if (tree.getTag() != JCTree.CLASSDEF) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   976
        class SpecialTreeVisitor extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
   977
            boolean specialized;
06bc494ca11e Initial load
duke
parents:
diff changeset
   978
            SpecialTreeVisitor() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   979
                this.specialized = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   980
            };
06bc494ca11e Initial load
duke
parents:
diff changeset
   981
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   982
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   983
            public void visitTree(JCTree tree) { /* no-op */ }
06bc494ca11e Initial load
duke
parents:
diff changeset
   984
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   985
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   986
            public void visitVarDef(JCVariableDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   987
                if ((tree.mods.flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   988
                    if (tree.init instanceof JCNewClass &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   989
                        ((JCNewClass) tree.init).def != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   990
                        specialized = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   991
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   992
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   993
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   994
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   995
06bc494ca11e Initial load
duke
parents:
diff changeset
   996
        SpecialTreeVisitor sts = new SpecialTreeVisitor();
06bc494ca11e Initial load
duke
parents:
diff changeset
   997
        JCClassDecl cdef = (JCClassDecl) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
   998
        for (JCTree defs: cdef.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   999
            defs.accept(sts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1000
            if (sts.specialized) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1001
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1002
        return FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1003
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1004
06bc494ca11e Initial load
duke
parents:
diff changeset
  1005
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1006
 * Type Validation
06bc494ca11e Initial load
duke
parents:
diff changeset
  1007
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1008
06bc494ca11e Initial load
duke
parents:
diff changeset
  1009
    /** Validate a type expression. That is,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1010
     *  check that all type arguments of a parametric type are within
06bc494ca11e Initial load
duke
parents:
diff changeset
  1011
     *  their bounds. This must be done in a second phase after type attributon
06bc494ca11e Initial load
duke
parents:
diff changeset
  1012
     *  since a class might have a subclass as type parameter bound. E.g:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1013
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1014
     *  class B<A extends C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1015
     *  class C extends B<C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1016
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1017
     *  and we can't make sure that the bound is already attributed because
06bc494ca11e Initial load
duke
parents:
diff changeset
  1018
     *  of possible cycles.
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1019
     *
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1020
     * Visitor method: Validate a type expression, if it is not null, catching
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1021
     *  and reporting any completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1022
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1023
    void validate(JCTree tree, Env<AttrContext> env) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1024
        validate(tree, env, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1025
    }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1026
    void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1027
        new Validator(env).validateTree(tree, checkRaw, true);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1028
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1029
06bc494ca11e Initial load
duke
parents:
diff changeset
  1030
    /** Visitor method: Validate a list of type expressions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1031
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1032
    void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1033
        for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1034
            validate(l.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1035
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1036
06bc494ca11e Initial load
duke
parents:
diff changeset
  1037
    /** A visitor class for type validation.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1038
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1039
    class Validator extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1040
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1041
        boolean isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1042
        Env<AttrContext> env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1043
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1044
        Validator(Env<AttrContext> env) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1045
            this.env = env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1046
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1047
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1048
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1049
        public void visitTypeArray(JCArrayTypeTree tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1050
            tree.elemtype.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1051
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1052
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1053
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1054
        public void visitTypeApply(JCTypeApply tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1055
            if (tree.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1056
                List<JCExpression> args = tree.arguments;
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
  1057
                List<Type> forms = tree.type.tsym.type.getTypeArguments();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1058
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1059
                Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1060
                if (incompatibleArg != null) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1061
                    for (JCTree arg : tree.arguments) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1062
                        if (arg.type == incompatibleArg) {
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1063
                            log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1064
                        }
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1065
                        forms = forms.tail;
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1066
                     }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1067
                 }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1068
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1069
                forms = tree.type.tsym.type.getTypeArguments();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1070
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1071
                boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1072
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1073
                // For matching pairs of actual argument types `a' and
06bc494ca11e Initial load
duke
parents:
diff changeset
  1074
                // formal type parameters with declared bound `b' ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1075
                while (args.nonEmpty() && forms.nonEmpty()) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1076
                    validateTree(args.head,
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1077
                            !(isOuter && is_java_lang_Class),
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1078
                            false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1079
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1080
                    forms = forms.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1081
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1082
06bc494ca11e Initial load
duke
parents:
diff changeset
  1083
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1084
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1085
                if (tree.type.getEnclosingType().isRaw())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1086
                    log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1087
                if (tree.clazz.getTag() == JCTree.SELECT)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1088
                    visitSelectInternal((JCFieldAccess)tree.clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1089
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1090
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1091
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1092
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1093
        public void visitTypeParameter(JCTypeParameter tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1094
            validateTrees(tree.bounds, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1095
            checkClassBounds(tree.pos(), tree.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1096
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
06bc494ca11e Initial load
duke
parents:
diff changeset
  1098
        @Override
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
        public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
            if (tree.inner != null)
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1101
                validateTree(tree.inner, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1103
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1104
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
        public void visitSelect(JCFieldAccess tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
            if (tree.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1107
                visitSelectInternal(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1108
06bc494ca11e Initial load
duke
parents:
diff changeset
  1109
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1110
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1111
                if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1112
                    log.error(tree.pos(), "improperly.formed.type.param.missing");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1113
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1114
        }
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1115
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1116
        public void visitSelectInternal(JCFieldAccess tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1117
            if (tree.type.tsym.isStatic() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1118
                tree.selected.type.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1119
                // The enclosing type is not a class, so we are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1120
                // looking at a static member type.  However, the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1121
                // qualifying expression is parameterized.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1122
                log.error(tree.pos(), "cant.select.static.class.from.param.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1123
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1124
                // otherwise validate the rest of the expression
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1125
                tree.selected.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1126
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1127
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1128
06bc494ca11e Initial load
duke
parents:
diff changeset
  1129
        /** Default visitor method: do nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1130
         */
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1131
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1132
        public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1133
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1134
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1135
        public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1136
            try {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1137
                if (tree != null) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1138
                    this.isOuter = isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1139
                    tree.accept(this);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1140
                    if (checkRaw)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1141
                        checkRaw(tree, env);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1142
                }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1143
            } catch (CompletionFailure ex) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1144
                completionError(tree.pos(), ex);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1145
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1146
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1147
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1148
        public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1149
            for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1150
                validateTree(l.head, checkRaw, isOuter);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1151
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1152
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1153
        void checkRaw(JCTree tree, Env<AttrContext> env) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1154
            if (lint.isEnabled(LintCategory.RAW) &&
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1155
                tree.type.tag == CLASS &&
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1156
                !TreeInfo.isDiamond(tree) &&
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1157
                !env.enclClass.name.isEmpty() &&  //anonymous or intersection
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1158
                tree.type.isRaw()) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1159
                log.warning(LintCategory.RAW,
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1160
                        tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1161
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1162
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
 * Exception checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
    /* The following methods treat classes as sets that contain
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
     * the class itself and all their subclasses
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
    /** Is given type a subtype of some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
    boolean subset(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
            if (types.isSubtype(t, l.head)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1180
06bc494ca11e Initial load
duke
parents:
diff changeset
  1181
    /** Is given type a subtype or supertype of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1182
     *  some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1183
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1184
    boolean intersects(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1185
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1186
            if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1187
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1188
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1189
06bc494ca11e Initial load
duke
parents:
diff changeset
  1190
    /** Add type set to given type list, unless it is a subclass of some class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1191
     *  in the list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1192
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1193
    List<Type> incl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1194
        return subset(t, ts) ? ts : excl(t, ts).prepend(t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1195
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1196
06bc494ca11e Initial load
duke
parents:
diff changeset
  1197
    /** Remove type set from type set list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1198
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1199
    List<Type> excl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1200
        if (ts.isEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1201
            return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1202
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1203
            List<Type> ts1 = excl(t, ts.tail);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1204
            if (types.isSubtype(ts.head, t)) return ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1205
            else if (ts1 == ts.tail) return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1206
            else return ts1.prepend(ts.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1207
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1208
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1209
06bc494ca11e Initial load
duke
parents:
diff changeset
  1210
    /** Form the union of two type set lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1211
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1212
    List<Type> union(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1213
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1214
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1215
            ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1216
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1217
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1218
06bc494ca11e Initial load
duke
parents:
diff changeset
  1219
    /** Form the difference of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1220
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1221
    List<Type> diff(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1222
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1223
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1224
            ts = excl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1225
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1226
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1227
06bc494ca11e Initial load
duke
parents:
diff changeset
  1228
    /** Form the intersection of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1229
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1230
    public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1231
        List<Type> ts = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1232
        for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1233
            if (subset(l.head, ts2)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1234
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1235
            if (subset(l.head, ts1)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1236
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1237
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1238
06bc494ca11e Initial load
duke
parents:
diff changeset
  1239
    /** Is exc an exception symbol that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1240
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1241
    boolean isUnchecked(ClassSymbol exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1242
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
            exc.kind == ERR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
            exc.isSubClass(syms.errorType.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1245
            exc.isSubClass(syms.runtimeExceptionType.tsym, types);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1247
06bc494ca11e Initial load
duke
parents:
diff changeset
  1248
    /** Is exc an exception type that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1249
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1250
    boolean isUnchecked(Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1251
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1252
            (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1253
            (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
            exc.tag == BOT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1255
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
    /** Same, but handling completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
    boolean isUnchecked(DiagnosticPosition pos, Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
            return isUnchecked(exc);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1263
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1265
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1266
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1267
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
    /** Is exc handled by given exception list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
    boolean isHandled(Type exc, List<Type> handled) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1271
        return isUnchecked(exc) || subset(exc, handled);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1272
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1273
06bc494ca11e Initial load
duke
parents:
diff changeset
  1274
    /** Return all exceptions in thrown list that are not in handled list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1275
     *  @param thrown     The list of thrown exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1276
     *  @param handled    The list of handled exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1277
     */
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1278
    List<Type> unhandled(List<Type> thrown, List<Type> handled) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1279
        List<Type> unhandled = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1280
        for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1281
            if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1282
        return unhandled;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1283
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1284
06bc494ca11e Initial load
duke
parents:
diff changeset
  1285
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1286
 * Overriding/Implementation checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1287
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
06bc494ca11e Initial load
duke
parents:
diff changeset
  1289
    /** The level of access protection given by a flag set,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1290
     *  where PRIVATE is highest and PUBLIC is lowest.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1291
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1292
    static int protection(long flags) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1293
        switch ((short)(flags & AccessFlags)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1294
        case PRIVATE: return 3;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1295
        case PROTECTED: return 1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1296
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
        case PUBLIC: return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
        case 0: return 2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1299
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1301
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
    /** A customized "cannot override" error message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1307
    Object cannotOverride(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1308
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1309
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1310
            key = "cant.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1311
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1312
            key = "cant.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1313
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1314
            key = "clashes.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1315
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1316
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1317
06bc494ca11e Initial load
duke
parents:
diff changeset
  1318
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1319
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1320
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1321
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1322
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1323
    Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1324
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1325
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
            key = "unchecked.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1328
            key = "unchecked.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1329
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1330
            key = "unchecked.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1331
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1332
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1333
06bc494ca11e Initial load
duke
parents:
diff changeset
  1334
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1335
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1336
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1337
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1338
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1339
    Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1340
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1341
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1342
            key = "varargs.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1343
        else  if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1344
            key = "varargs.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1345
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1346
            key = "varargs.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1347
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1348
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1349
06bc494ca11e Initial load
duke
parents:
diff changeset
  1350
    /** Check that this method conforms with overridden method 'other'.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
     *  where `origin' is the class where checking started.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
     *  Complications:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1353
     *  (1) Do not check overriding of synthetic methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1354
     *      (reason: they might be final).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1355
     *      todo: check whether this is still necessary.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1356
     *  (2) Admit the case where an interface proxy throws fewer exceptions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1357
     *      than the method it implements. Augment the proxy methods with the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1358
     *      undeclared exceptions in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1359
     *  (3) When generics are enabled, admit the case where an interface proxy
06bc494ca11e Initial load
duke
parents:
diff changeset
  1360
     *      has a result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1361
     *      extended by the result type of the method it implements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1362
     *      Change the proxies result type to the smaller type in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1363
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1364
     *  @param tree         The tree from which positions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1365
     *                      are extracted for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1367
     *  @param other        The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1368
     *  @param origin       The class of which the overriding method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1369
     *                      is a member.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1370
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1371
    void checkOverride(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1372
                       MethodSymbol m,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
                       MethodSymbol other,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1374
                       ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1375
        // Don't check overriding of synthetic methods or by bridge methods.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1376
        if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1377
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1378
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
06bc494ca11e Initial load
duke
parents:
diff changeset
  1380
        // Error if static method overrides instance method (JLS 8.4.6.2).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1381
        if ((m.flags() & STATIC) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1382
                   (other.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1383
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1384
                      cannotOverride(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1385
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1386
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1387
06bc494ca11e Initial load
duke
parents:
diff changeset
  1388
        // Error if instance method overrides static or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1389
        // method (JLS 8.4.6.1).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
        if ((other.flags() & FINAL) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
                 (m.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1392
                 (other.flags() & STATIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1393
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1394
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1395
                      asFlagSet(other.flags() & (FINAL | STATIC)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1396
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1397
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1398
06bc494ca11e Initial load
duke
parents:
diff changeset
  1399
        if ((m.owner.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1400
            // handled in validateAnnotationMethod
06bc494ca11e Initial load
duke
parents:
diff changeset
  1401
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1402
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1403
06bc494ca11e Initial load
duke
parents:
diff changeset
  1404
        // Error if overriding method has weaker access (JLS 8.4.6.3).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1405
        if ((origin.flags() & INTERFACE) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1406
                 protection(m.flags()) > protection(other.flags())) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1407
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1408
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1409
                      other.flags() == 0 ?
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1410
                          Flag.PACKAGE :
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1411
                          asFlagSet(other.flags() & AccessFlags));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1412
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1413
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1414
06bc494ca11e Initial load
duke
parents:
diff changeset
  1415
        Type mt = types.memberType(origin.type, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1416
        Type ot = types.memberType(origin.type, other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1417
        // Error if overriding result type is different
06bc494ca11e Initial load
duke
parents:
diff changeset
  1418
        // (or, in the case of generics mode, not a subtype) of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1419
        // overridden result type. We have to rename any type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  1420
        // before comparing types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1421
        List<Type> mtvars = mt.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1422
        List<Type> otvars = ot.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1423
        Type mtres = mt.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1424
        Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1425
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1426
        overrideWarner.clear();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1427
        boolean resultTypesOK =
1874
891c2d6823bb 6797463: 6557199 breaks the jax-ws workspace
tbell
parents: 1868
diff changeset
  1428
            types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1429
        if (!resultTypesOK) {
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1430
            if (!allowCovariantReturns &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1431
                m.owner != origin &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1432
                m.owner.isSubClass(other.owner, types)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1433
                // allow limited interoperability with covariant returns
06bc494ca11e Initial load
duke
parents:
diff changeset
  1434
            } else {
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1435
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1436
                          "override.incompatible.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1437
                          cannotOverride(m, other),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1438
                          mtres, otres);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1439
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1440
            }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1441
        } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1442
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1443
                    "override.unchecked.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1444
                    uncheckedOverrides(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1445
                    mtres, otres);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1446
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1447
06bc494ca11e Initial load
duke
parents:
diff changeset
  1448
        // Error if overriding method throws an exception not reported
06bc494ca11e Initial load
duke
parents:
diff changeset
  1449
        // by overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1450
        List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1451
        List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1452
        List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1453
        if (unhandledErased.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1454
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1455
                      "override.meth.doesnt.throw",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1456
                      cannotOverride(m, other),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1457
                      unhandledUnerased.head);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1458
            return;
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1459
        }
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1460
        else if (unhandledUnerased.nonEmpty()) {
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1461
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1462
                          "override.unchecked.thrown",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1463
                         cannotOverride(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1464
                         unhandledUnerased.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1465
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1466
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1467
06bc494ca11e Initial load
duke
parents:
diff changeset
  1468
        // Optional warning if varargs don't agree
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
        if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1470
            && lint.isEnabled(LintCategory.OVERRIDES)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
                        ((m.flags() & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1473
                        ? "override.varargs.missing"
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
                        : "override.varargs.extra",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
                        varargsOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
        // Warn if instance method overrides bridge method (compiler spec ??)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1479
        if ((other.flags() & BRIDGE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
            log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1481
                        uncheckedOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1482
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1483
06bc494ca11e Initial load
duke
parents:
diff changeset
  1484
        // Warn if a deprecated method overridden by a non-deprecated one.
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1485
        if (!isDeprecatedOverrideIgnorable(other, origin)) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1486
            checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1487
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1489
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1490
        private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1491
            // If the method, m, is defined in an interface, then ignore the issue if the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1492
            // is only inherited via a supertype and also implemented in the supertype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1493
            // because in that case, we will rediscover the issue when examining the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1494
            // in the supertype.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1495
            // If the method, m, is not defined in an interface, then the only time we need to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1496
            // address the issue is when the method is the supertype implemementation: any other
06bc494ca11e Initial load
duke
parents:
diff changeset
  1497
            // case, we will have dealt with when examining the supertype classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1498
            ClassSymbol mc = m.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1499
            Type st = types.supertype(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1500
            if (st.tag != CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1501
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1502
            MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1503
06bc494ca11e Initial load
duke
parents:
diff changeset
  1504
            if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1505
                List<Type> intfs = types.interfaces(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1506
                return (intfs.contains(mc.type) ? false : (stimpl != null));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1507
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1508
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1509
                return (stimpl != m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1510
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1511
06bc494ca11e Initial load
duke
parents:
diff changeset
  1512
06bc494ca11e Initial load
duke
parents:
diff changeset
  1513
    // used to check if there were any unchecked conversions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1514
    Warner overrideWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1515
06bc494ca11e Initial load
duke
parents:
diff changeset
  1516
    /** Check that a class does not inherit two concrete methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1517
     *  with the same signature.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1518
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1519
     *  @param site         The class type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1520
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1521
    public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1522
        Type sup = types.supertype(site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1523
        if (sup.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
        for (Type t1 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
             t1.tsym.type.isParameterized();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
             t1 = types.supertype(t1)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
            for (Scope.Entry e1 = t1.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
                 e1 != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
                 e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
                Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
                if (s1.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
                    (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
                    !s1.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1535
                    ((MethodSymbol)s1).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1536
                                                      types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1537
                                                      true) != s1)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1538
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1539
                Type st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1540
                int s1ArgsLength = st1.getParameterTypes().length();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1541
                if (st1 == s1.type) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1542
06bc494ca11e Initial load
duke
parents:
diff changeset
  1543
                for (Type t2 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1544
                     t2.tag == CLASS;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1545
                     t2 = types.supertype(t2)) {
508
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1546
                    for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1547
                         e2.scope != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1548
                         e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1549
                        Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1550
                        if (s2 == s1 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
                            s2.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
                            (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
                            s2.type.getParameterTypes().length() != s1ArgsLength ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
                            !s2.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1555
                            ((MethodSymbol)s2).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1556
                                                              types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1557
                                                              true) != s2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1558
                            continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1559
                        Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
                        if (types.overrideEquivalent(st1, st2))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
                            log.error(pos, "concrete.inheritance.conflict",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
                                      s1, t1, s2, t2, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1564
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
06bc494ca11e Initial load
duke
parents:
diff changeset
  1569
    /** Check that classes (or interfaces) do not each define an abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
     *  method with same name and arguments but incompatible return types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
     *  @param t1           The first argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
     *  @param t2           The second argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
                                            Type t2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
        return checkCompatibleAbstracts(pos, t1, t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
                                        types.makeCompoundType(t1, t2));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
                                            Type t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
                                            Type site) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1586
        return firstIncompatibility(pos, t1, t2, site) == null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1587
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1588
06bc494ca11e Initial load
duke
parents:
diff changeset
  1589
    /** Return the first method which is defined with same args
06bc494ca11e Initial load
duke
parents:
diff changeset
  1590
     *  but different return types in two given interfaces, or null if none
06bc494ca11e Initial load
duke
parents:
diff changeset
  1591
     *  exists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1592
     *  @param t1     The first type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1593
     *  @param t2     The second type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1594
     *  @param site   The most derived type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1595
     *  @returns symbol from t2 that conflicts with one in t1.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1596
     */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1597
    private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1598
        Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1599
        closure(t1, interfaces1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1600
        Map<TypeSymbol,Type> interfaces2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1601
        if (t1 == t2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1602
            interfaces2 = interfaces1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1603
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
            closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1605
06bc494ca11e Initial load
duke
parents:
diff changeset
  1606
        for (Type t3 : interfaces1.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1607
            for (Type t4 : interfaces2.values()) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1608
                Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1609
                if (s != null) return s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1610
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1611
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1613
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1614
06bc494ca11e Initial load
duke
parents:
diff changeset
  1615
    /** Compute all the supertypes of t, indexed by type symbol. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1616
    private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1617
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1618
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1619
            closure(types.supertype(t), typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1620
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1621
                closure(i, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1622
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1623
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1624
06bc494ca11e Initial load
duke
parents:
diff changeset
  1625
    /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1626
    private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1627
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
        if (typesSkip.get(t.tsym) != null) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1629
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1630
            closure(types.supertype(t), typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1631
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1632
                closure(i, typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1633
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1634
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1635
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
    /** Return the first method in t2 that conflicts with a method from t1. */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1637
    private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1638
        for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
            Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1640
            Type st1 = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1641
            if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1642
            Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
            if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1644
            for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
                Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
                if (s1 == s2) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1647
                if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1648
                if (st1 == null) st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1649
                Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1650
                if (types.overrideEquivalent(st1, st2)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1651
                    List<Type> tvars1 = st1.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1652
                    List<Type> tvars2 = st2.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1653
                    Type rt1 = st1.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1654
                    Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1655
                    boolean compat =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1656
                        types.isSameType(rt1, rt2) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1657
                        rt1.tag >= CLASS && rt2.tag >= CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1658
                        (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1659
                         types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1660
                         checkCommonOverriderIn(s1,s2,site);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1661
                    if (!compat) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1662
                        log.error(pos, "types.incompatible.diff.ret",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1663
                            t1, t2, s2.name +
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1664
                            "(" + types.memberType(t2, s2).getParameterTypes() + ")");
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1665
                        return s2;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1666
                    }
8610
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  1667
                } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  1668
                        !checkCommonOverriderIn(s1, s2, site)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1669
                    log.error(pos,
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1670
                            "name.clash.same.erasure.no.override",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1671
                            s1, s1.location(),
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1672
                            s2, s2.location());
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1673
                    return s2;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1675
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1676
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1677
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
    }
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1679
    //WHERE
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1680
    boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1681
        Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1682
        Type st1 = types.memberType(site, s1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1683
        Type st2 = types.memberType(site, s2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1684
        closure(site, supertypes);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1685
        for (Type t : supertypes.values()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1686
            for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1687
                Symbol s3 = e.sym;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1688
                if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1689
                Type st3 = types.memberType(site,s3);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1690
                if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1691
                    if (s3.owner == site.tsym) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1692
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1693
                    }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1694
                    List<Type> tvars1 = st1.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1695
                    List<Type> tvars2 = st2.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1696
                    List<Type> tvars3 = st3.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1697
                    Type rt1 = st1.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1698
                    Type rt2 = st2.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1699
                    Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1700
                    Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1701
                    boolean compat =
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1702
                        rt13.tag >= CLASS && rt23.tag >= CLASS &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1703
                        (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1704
                         types.covariantReturnType(rt23, rt2, Warner.noWarnings));
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1705
                    if (compat)
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1706
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1707
                }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1708
            }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1709
        }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1710
        return false;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1711
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
    /** Check that a given method conforms with any method it overrides.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
     *  @param tree         The tree from which positions are extracted
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
     *                      for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
    void checkOverride(JCTree tree, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1719
        ClassSymbol origin = (ClassSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
        if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
            if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
                log.error(tree.pos(), "enum.no.finalize");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1724
            }
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1725
        for (Type t = origin.type; t.tag == CLASS;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1726
             t = types.supertype(t)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1727
            if (t != origin.type) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1728
                checkOverride(tree, t, origin, m);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1729
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1730
            for (Type t2 : types.interfaces(t)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1731
                checkOverride(tree, t2, origin, m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1732
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1734
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1735
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1736
    void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1737
        TypeSymbol c = site.tsym;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1738
        Scope.Entry e = c.members().lookup(m.name);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1739
        while (e.scope != null) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1740
            if (m.overrides(e.sym, origin, types, false)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1741
                if ((e.sym.flags() & ABSTRACT) == 0) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1742
                    checkOverride(tree, m, (MethodSymbol)e.sym, origin);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1743
                }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1744
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1745
            e = e.next();
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1746
        }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1747
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1748
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1749
    private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  1750
        ClashFilter cf = new ClashFilter(origin.type);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  1751
        return (cf.accepts(s1) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  1752
                cf.accepts(s2) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  1753
                types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1754
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1755
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1756
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1757
    /** Check that all abstract members of given class have definitions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1758
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1759
     *  @param c            The class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1760
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1761
    void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
            MethodSymbol undef = firstUndef(c, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
            if (undef != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
                if ((c.flags() & ENUM) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1766
                    types.supertype(c.type).tsym == syms.enumSym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1767
                    (c.flags() & FINAL) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1768
                    // add the ABSTRACT flag to an enum
06bc494ca11e Initial load
duke
parents:
diff changeset
  1769
                    c.flags_field |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1770
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1771
                    MethodSymbol undef1 =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1772
                        new MethodSymbol(undef.flags(), undef.name,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1773
                                         types.memberType(c.type, undef), undef.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1774
                    log.error(pos, "does.not.override.abstract",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1775
                              c, undef1, undef1.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1776
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1777
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1778
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1780
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1781
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1782
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1783
        /** Return first abstract member of class `c' that is not defined
06bc494ca11e Initial load
duke
parents:
diff changeset
  1784
         *  in `impl', null if there is none.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1785
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1786
        private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1787
            MethodSymbol undef = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1788
            // Do not bother to search in classes that are not abstract,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1789
            // since they cannot have abstract members.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1790
            if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1791
                Scope s = c.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1792
                for (Scope.Entry e = s.elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1793
                     undef == null && e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1794
                     e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1795
                    if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1796
                        (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1797
                        MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
                        MethodSymbol implmeth = absmeth.implementation(impl, types, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1799
                        if (implmeth == null || implmeth == absmeth)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1800
                            undef = absmeth;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1801
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1802
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1803
                if (undef == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1804
                    Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1805
                    if (st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1806
                        undef = firstUndef(impl, (ClassSymbol)st.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1807
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1808
                for (List<Type> l = types.interfaces(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1809
                     undef == null && l.nonEmpty();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1810
                     l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
                    undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1812
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1813
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1814
            return undef;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1815
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1816
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1817
    void checkNonCyclicDecl(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1818
        CycleChecker cc = new CycleChecker();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1819
        cc.scan(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1820
        if (!cc.errorFound && !cc.partialCheck) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1821
            tree.sym.flags_field |= ACYCLIC;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1822
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1823
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1824
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1825
    class CycleChecker extends TreeScanner {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1826
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1827
        List<Symbol> seenClasses = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1828
        boolean errorFound = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1829
        boolean partialCheck = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1830
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1831
        private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1832
            if (sym != null && sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1833
                Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1834
                if (classEnv != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1835
                    DiagnosticSource prevSource = log.currentSource();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1836
                    try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1837
                        log.useSource(classEnv.toplevel.sourcefile);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1838
                        scan(classEnv.tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1839
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1840
                    finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1841
                        log.useSource(prevSource.getFile());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1842
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1843
                } else if (sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1844
                    checkClass(pos, sym, List.<JCTree>nil());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1845
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1846
            } else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1847
                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1848
                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1849
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1850
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1851
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1852
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1853
        public void visitSelect(JCFieldAccess tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1854
            super.visitSelect(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1855
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1856
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1857
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1858
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1859
        public void visitIdent(JCIdent tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1860
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1861
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1862
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1863
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1864
        public void visitTypeApply(JCTypeApply tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1865
            scan(tree.clazz);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1866
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1867
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1868
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1869
        public void visitTypeArray(JCArrayTypeTree tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1870
            scan(tree.elemtype);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1871
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1872
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1873
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1874
        public void visitClassDef(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1875
            List<JCTree> supertypes = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1876
            if (tree.getExtendsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1877
                supertypes = supertypes.prepend(tree.getExtendsClause());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1878
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1879
            if (tree.getImplementsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1880
                for (JCTree intf : tree.getImplementsClause()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1881
                    supertypes = supertypes.prepend(intf);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1882
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1883
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1884
            checkClass(tree.pos(), tree.sym, supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1885
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1886
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1887
        void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1888
            if ((c.flags_field & ACYCLIC) != 0)
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1889
                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1890
            if (seenClasses.contains(c)) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1891
                errorFound = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1892
                noteCyclic(pos, (ClassSymbol)c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1893
            } else if (!c.type.isErroneous()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1894
                try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1895
                    seenClasses = seenClasses.prepend(c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1896
                    if (c.type.tag == CLASS) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1897
                        if (supertypes.nonEmpty()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1898
                            scan(supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1899
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1900
                        else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1901
                            ClassType ct = (ClassType)c.type;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1902
                            if (ct.supertype_field == null ||
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1903
                                    ct.interfaces_field == null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1904
                                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1905
                                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1906
                                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1907
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1908
                            checkSymbol(pos, ct.supertype_field.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1909
                            for (Type intf : ct.interfaces_field) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1910
                                checkSymbol(pos, intf.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1911
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1912
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1913
                        if (c.owner.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1914
                            checkSymbol(pos, c.owner);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1915
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1916
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1917
                } finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1918
                    seenClasses = seenClasses.tail;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1919
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1920
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1921
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1922
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1923
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1924
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1925
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1926
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1927
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1930
    void checkNonCyclic(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1931
        checkNonCyclicInternal(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1933
06bc494ca11e Initial load
duke
parents:
diff changeset
  1934
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
    void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1936
        checkNonCyclic1(pos, t, List.<TypeVar>nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1937
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1938
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1939
    private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1940
        final TypeVar tv;
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1941
        if  (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1942
            return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
        if (seen.contains(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1944
            tv = (TypeVar)t;
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1945
            tv.bound = types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1946
            log.error(pos, "cyclic.inheritance", t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
        } else if (t.tag == TYPEVAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
            tv = (TypeVar)t;
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1949
            seen = seen.prepend(tv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1950
            for (Type b : types.getBounds(tv))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1951
                checkNonCyclic1(pos, b, seen);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1952
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1953
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1954
06bc494ca11e Initial load
duke
parents:
diff changeset
  1955
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1956
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1957
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1958
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1959
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1960
     *  @returns        True if the check completed on all attributed classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1961
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1962
    private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1963
        boolean complete = true; // was the check complete?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1964
        //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  1965
        Symbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
        if ((c.flags_field & ACYCLIC) != 0) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1967
06bc494ca11e Initial load
duke
parents:
diff changeset
  1968
        if ((c.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
            noteCyclic(pos, (ClassSymbol)c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
        } else if (!c.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
                c.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
                if (c.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
                    ClassType clazz = (ClassType)c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1975
                    if (clazz.interfaces_field != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
                        for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
                            complete &= checkNonCyclicInternal(pos, l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1978
                    if (clazz.supertype_field != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1979
                        Type st = clazz.supertype_field;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
                        if (st != null && st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1981
                            complete &= checkNonCyclicInternal(pos, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1982
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
                    if (c.owner.kind == TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
                        complete &= checkNonCyclicInternal(pos, c.owner.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1985
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1986
            } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1987
                c.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1988
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
        if (complete)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
            complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1992
        if (complete) c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
        return complete;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1995
06bc494ca11e Initial load
duke
parents:
diff changeset
  1996
    /** Note that we found an inheritance cycle. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1997
    private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1998
        log.error(pos, "cyclic.inheritance", c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1999
        for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2000
            l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2001
        Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2002
        if (st.tag == CLASS)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2003
            ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2004
        c.type = types.createErrorType(c, c.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2005
        c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2006
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2007
06bc494ca11e Initial load
duke
parents:
diff changeset
  2008
    /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2009
     *  method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2010
     *  @param tree         The class definition whose members are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2011
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2012
    void checkImplementations(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2013
        checkImplementations(tree, tree.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2014
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2015
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2016
        /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2017
         *  method in `ic' conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2018
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2019
        void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2020
            ClassSymbol origin = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2021
            for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2022
                ClassSymbol lc = (ClassSymbol)l.head.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2023
                if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2024
                    for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2025
                        if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2026
                            (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2027
                            MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2028
                            MethodSymbol implmeth = absmeth.implementation(origin, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2029
                            if (implmeth != null && implmeth != absmeth &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2030
                                (implmeth.owner.flags() & INTERFACE) ==
06bc494ca11e Initial load
duke
parents:
diff changeset
  2031
                                (origin.flags() & INTERFACE)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2032
                                // don't check if implmeth is in a class, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
  2033
                                // origin is an interface. This case arises only
06bc494ca11e Initial load
duke
parents:
diff changeset
  2034
                                // if implmeth is declared in Object. The reason is
06bc494ca11e Initial load
duke
parents:
diff changeset
  2035
                                // that interfaces really don't inherit from
06bc494ca11e Initial load
duke
parents:
diff changeset
  2036
                                // Object it's just that the compiler represents
06bc494ca11e Initial load
duke
parents:
diff changeset
  2037
                                // things that way.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2038
                                checkOverride(tree, implmeth, absmeth, origin);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2039
                            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2040
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2041
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2042
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2043
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2044
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2045
06bc494ca11e Initial load
duke
parents:
diff changeset
  2046
    /** Check that all abstract methods implemented by a class are
06bc494ca11e Initial load
duke
parents:
diff changeset
  2047
     *  mutually compatible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2048
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2049
     *  @param c            The class whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2050
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2051
    void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2052
        List<Type> supertypes = types.interfaces(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2053
        Type supertype = types.supertype(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2054
        if (supertype.tag == CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2055
            (supertype.tsym.flags() & ABSTRACT) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2056
            supertypes = supertypes.prepend(supertype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2057
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2058
            if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2059
                !checkCompatibleAbstracts(pos, l.head, l.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2060
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2061
            for (List<Type> m = supertypes; m != l; m = m.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2062
                if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2063
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2064
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2065
        checkCompatibleConcretes(pos, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2066
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2067
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2068
    void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2069
        for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2070
            for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2071
                // VM allows methods and variables with differing types
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2072
                if (sym.kind == e.sym.kind &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2073
                    types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2074
                    sym != e.sym &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2075
                    (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
6147
0074061d0efd 6964669: javac reports error on miranda methods
mcimadamore
parents: 6032
diff changeset
  2076
                    (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2077
                    (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2078
                    syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2079
                    return;
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2080
                }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2081
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2082
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2083
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2084
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2085
    /** Check that all non-override equivalent methods accessible from 'site'
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2086
     *  are mutually compatible (JLS 8.4.8/9.4.1).
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2087
     *
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2088
     *  @param pos  Position to be used for error reporting.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2089
     *  @param site The class whose methods are checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2090
     *  @param sym  The method symbol to be checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2091
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2092
    void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2093
         ClashFilter cf = new ClashFilter(site);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2094
         //for each method m1 that is a member of 'site'...
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2095
         for (Symbol s1 : types.membersClosure(site).getElementsByName(sym.name, cf)) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2096
            //...find another method m2 that is overridden (directly or indirectly)
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2097
            //by method 'sym' in 'site'
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2098
            for (Symbol s2 : types.membersClosure(site).getElementsByName(sym.name, cf)) {
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2099
                if (s1 == s2 || !sym.overrides(s2, site.tsym, types, false)) continue;
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2100
                //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2101
                //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
8628
9e31f1c01bd4 7022054: Invalid compiler error on covariant overriding methods with the same erasure
mcimadamore
parents: 8610
diff changeset
  2102
                if (!types.isSubSignature(sym.type, types.memberType(site, s1), false) &&
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2103
                        types.hasSameArgs(s1.erasure(types), s2.erasure(types))) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2104
                    sym.flags_field |= CLASH;
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2105
                    String key = s2 == sym ?
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2106
                            "name.clash.same.erasure.no.override" :
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2107
                            "name.clash.same.erasure.no.override.1";
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2108
                    log.error(pos,
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2109
                            key,
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2110
                            sym, sym.location(),
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2111
                            s1, s1.location(),
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2112
                            s2, s2.location());
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2113
                    return;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2114
                }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2115
            }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2116
        }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2117
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2118
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2119
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2120
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2121
    /** Check that all static methods accessible from 'site' are
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2122
     *  mutually compatible (JLS 8.4.8).
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2123
     *
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2124
     *  @param pos  Position to be used for error reporting.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2125
     *  @param site The class whose methods are checked.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2126
     *  @param sym  The method symbol to be checked.
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2127
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2128
    void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2129
        ClashFilter cf = new ClashFilter(site);
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2130
        //for each method m1 that is a member of 'site'...
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2131
        for (Symbol s : types.membersClosure(site).getElementsByName(sym.name, cf)) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2132
            //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2133
            //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
8628
9e31f1c01bd4 7022054: Invalid compiler error on covariant overriding methods with the same erasure
mcimadamore
parents: 8610
diff changeset
  2134
            if (!types.isSubSignature(sym.type, types.memberType(site, s), false) &&
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2135
                    types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2136
                log.error(pos,
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2137
                        "name.clash.same.erasure.no.hide",
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2138
                        sym, sym.location(),
8427
703181b01773 7017664: Add listeners infrastracture to javac scopes
mcimadamore
parents: 8242
diff changeset
  2139
                        s, s.location());
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2140
                return;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2141
             }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2142
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2143
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2144
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2145
     //where
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2146
     private class ClashFilter implements Filter<Symbol> {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2147
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2148
         Type site;
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2149
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2150
         ClashFilter(Type site) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2151
             this.site = site;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2152
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2153
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2154
         boolean shouldSkip(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2155
             return (s.flags() & CLASH) != 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2156
                s.owner == site.tsym;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2157
         }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2158
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2159
         public boolean accepts(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2160
             return s.kind == MTH &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2161
                     (s.flags() & SYNTHETIC) == 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2162
                     !shouldSkip(s) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2163
                     s.isInheritedIn(site.tsym, types) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2164
                     !s.isConstructor();
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2165
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2166
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2167
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2168
    /** Report a conflict between a user symbol and a synthetic symbol.
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2169
     */
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2170
    private void syntheticError(DiagnosticPosition pos, Symbol sym) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2171
        if (!sym.type.isErroneous()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2172
            if (warnOnSyntheticConflicts) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2173
                log.warning(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2174
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2175
            else {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2176
                log.error(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2177
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2178
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2179
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2180
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2181
    /** Check that class c does not implement directly or indirectly
06bc494ca11e Initial load
duke
parents:
diff changeset
  2182
     *  the same parameterized interface with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2183
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2184
     *  @param type         The type whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2185
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2186
    void checkClassBounds(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2187
        checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2188
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2189
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2190
        /** Enter all interfaces of type `type' into the hash table `seensofar'
06bc494ca11e Initial load
duke
parents:
diff changeset
  2191
         *  with their class symbol as key and their type as value. Make
06bc494ca11e Initial load
duke
parents:
diff changeset
  2192
         *  sure no class is entered with two different types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2193
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2194
        void checkClassBounds(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2195
                              Map<TypeSymbol,Type> seensofar,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2196
                              Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2197
            if (type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2198
            for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2199
                Type it = l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2200
                Type oldit = seensofar.put(it.tsym, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2201
                if (oldit != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2202
                    List<Type> oldparams = oldit.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2203
                    List<Type> newparams = it.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2204
                    if (!types.containsTypeEquivalent(oldparams, newparams))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2205
                        log.error(pos, "cant.inherit.diff.arg",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2206
                                  it.tsym, Type.toString(oldparams),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2207
                                  Type.toString(newparams));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2208
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2209
                checkClassBounds(pos, seensofar, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2210
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2211
            Type st = types.supertype(type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2212
            if (st != null) checkClassBounds(pos, seensofar, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2213
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2214
06bc494ca11e Initial load
duke
parents:
diff changeset
  2215
    /** Enter interface into into set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2216
     *  If it existed already, issue a "repeated interface" error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2217
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2218
    void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2219
        if (its.contains(it))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2220
            log.error(pos, "repeated.interface");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2221
        else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2222
            its.add(it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2223
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2224
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2225
06bc494ca11e Initial load
duke
parents:
diff changeset
  2226
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2227
 * Check annotations
06bc494ca11e Initial load
duke
parents:
diff changeset
  2228
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2229
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2230
    /**
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2231
     * Recursively validate annotations values
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2232
     */
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2233
    void validateAnnotationTree(JCTree tree) {
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2234
        class AnnotationValidator extends TreeScanner {
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2235
            @Override
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2236
            public void visitAnnotation(JCAnnotation tree) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2237
                super.visitAnnotation(tree);
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2238
                validateAnnotation(tree);
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2239
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2240
        }
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2241
        tree.accept(new AnnotationValidator());
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2242
    }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2243
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2244
    /** Annotation types are restricted to primitives, String, an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2245
     *  enum, an annotation, Class, Class<?>, Class<? extends
06bc494ca11e Initial load
duke
parents:
diff changeset
  2246
     *  Anything>, arrays of the preceding.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2247
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2248
    void validateAnnotationType(JCTree restype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2249
        // restype may be null if an error occurred, so don't bother validating it
06bc494ca11e Initial load
duke
parents:
diff changeset
  2250
        if (restype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2251
            validateAnnotationType(restype.pos(), restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2252
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2253
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2254
06bc494ca11e Initial load
duke
parents:
diff changeset
  2255
    void validateAnnotationType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2256
        if (type.isPrimitive()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2257
        if (types.isSameType(type, syms.stringType)) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2258
        if ((type.tsym.flags() & Flags.ENUM) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2259
        if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2260
        if (types.lowerBound(type).tsym == syms.classType.tsym) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2261
        if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2262
            validateAnnotationType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2263
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2264
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2265
        log.error(pos, "invalid.annotation.member.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2266
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2267
06bc494ca11e Initial load
duke
parents:
diff changeset
  2268
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2269
     * "It is also a compile-time error if any method declared in an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2270
     * annotation type has a signature that is override-equivalent to
06bc494ca11e Initial load
duke
parents:
diff changeset
  2271
     * that of any public or protected method declared in class Object
06bc494ca11e Initial load
duke
parents:
diff changeset
  2272
     * or in the interface annotation.Annotation."
06bc494ca11e Initial load
duke
parents:
diff changeset
  2273
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2274
     * @jls3 9.6 Annotation Types
06bc494ca11e Initial load
duke
parents:
diff changeset
  2275
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2276
    void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2277
        for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2278
            Scope s = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2279
            for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2280
                if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2281
                    (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2282
                    types.overrideEquivalent(m.type, e.sym.type))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2283
                    log.error(pos, "intf.annotation.member.clash", e.sym, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2284
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2285
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2286
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2287
06bc494ca11e Initial load
duke
parents:
diff changeset
  2288
    /** Check the annotations of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2289
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2290
    public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2291
        if (skipAnnotations) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2292
        for (JCAnnotation a : annotations)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2293
            validateAnnotation(a, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2294
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2295
06bc494ca11e Initial load
duke
parents:
diff changeset
  2296
    /** Check an annotation of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2297
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2298
    public void validateAnnotation(JCAnnotation a, Symbol s) {
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2299
        validateAnnotationTree(a);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2300
06bc494ca11e Initial load
duke
parents:
diff changeset
  2301
        if (!annotationApplicable(a, s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2302
            log.error(a.pos(), "annotation.type.not.applicable");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2303
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
        if (a.annotationType.type.tsym == syms.overrideType.tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2305
            if (!isOverrider(s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2306
                log.error(a.pos(), "method.does.not.override.superclass");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2307
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2308
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2309
06bc494ca11e Initial load
duke
parents:
diff changeset
  2310
    /** Is s a method symbol that overrides a method in a superclass? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2311
    boolean isOverrider(Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2312
        if (s.kind != MTH || s.isStatic())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2313
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2314
        MethodSymbol m = (MethodSymbol)s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2315
        TypeSymbol owner = (TypeSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2316
        for (Type sup : types.closure(owner.type)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2317
            if (sup == owner.type)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2318
                continue; // skip "this"
06bc494ca11e Initial load
duke
parents:
diff changeset
  2319
            Scope scope = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2320
            for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2321
                if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2322
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2323
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2324
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2325
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2326
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2327
06bc494ca11e Initial load
duke
parents:
diff changeset
  2328
    /** Is the annotation applicable to the symbol? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2329
    boolean annotationApplicable(JCAnnotation a, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2330
        Attribute.Compound atTarget =
06bc494ca11e Initial load
duke
parents:
diff changeset
  2331
            a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2332
        if (atTarget == null) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2333
        Attribute atValue = atTarget.member(names.value);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2334
        if (!(atValue instanceof Attribute.Array)) return true; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2335
        Attribute.Array arr = (Attribute.Array) atValue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2336
        for (Attribute app : arr.values) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2337
            if (!(app instanceof Attribute.Enum)) return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2338
            Attribute.Enum e = (Attribute.Enum) app;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2339
            if (e.value.name == names.TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2340
                { if (s.kind == TYP) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2341
            else if (e.value.name == names.FIELD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2342
                { if (s.kind == VAR && s.owner.kind != MTH) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2343
            else if (e.value.name == names.METHOD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
                { if (s.kind == MTH && !s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2345
            else if (e.value.name == names.PARAMETER)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2346
                { if (s.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2347
                      s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2348
                      (s.flags() & PARAMETER) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2349
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2350
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2351
            else if (e.value.name == names.CONSTRUCTOR)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2352
                { if (s.kind == MTH && s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2353
            else if (e.value.name == names.LOCAL_VARIABLE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2354
                { if (s.kind == VAR && s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2355
                      (s.flags() & PARAMETER) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2356
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2357
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2358
            else if (e.value.name == names.ANNOTATION_TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2359
                { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2360
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2361
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2362
            else if (e.value.name == names.PACKAGE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2363
                { if (s.kind == PCK) return true; }
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2364
            else if (e.value.name == names.TYPE_USE)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2365
                { if (s.kind == TYP ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2366
                      s.kind == VAR ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2367
                      (s.kind == MTH && !s.isConstructor() &&
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2368
                       s.type.getReturnType().tag != VOID))
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2369
                    return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2370
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2371
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2372
                return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2373
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2374
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2375
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2376
06bc494ca11e Initial load
duke
parents:
diff changeset
  2377
    /** Check an annotation value.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2378
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2379
    public void validateAnnotation(JCAnnotation a) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2380
        if (a.type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2381
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2382
        // collect an inventory of the members (sorted alphabetically)
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2383
        Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2384
            public int compare(Symbol t, Symbol t1) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2385
                return t.name.compareTo(t1.name);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2386
            }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2387
        });
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2388
        for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2389
             e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2390
             e = e.sibling)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2391
            if (e.sym.kind == MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2392
                members.add((MethodSymbol) e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2393
06bc494ca11e Initial load
duke
parents:
diff changeset
  2394
        // count them off as they're annotated
06bc494ca11e Initial load
duke
parents:
diff changeset
  2395
        for (JCTree arg : a.args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2396
            if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2397
            JCAssign assign = (JCAssign) arg;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2398
            Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2399
            if (m == null || m.type.isErroneous()) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2400
            if (!members.remove(m))
4867
7f4efc9b2f9f 6919944: incorrect position given for duplicate annotation value error
jjg
parents: 3780
diff changeset
  2401
                log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2402
                          m.name, a.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2403
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2404
06bc494ca11e Initial load
duke
parents:
diff changeset
  2405
        // all the remaining ones better have default values
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2406
        ListBuffer<Name> missingDefaults = ListBuffer.lb();
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2407
        for (MethodSymbol m : members) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2408
            if (m.defaultValue == null && !m.type.isErroneous()) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2409
                missingDefaults.append(m.name);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2410
            }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2411
        }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2412
        if (missingDefaults.nonEmpty()) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2413
            String key = (missingDefaults.size() > 1)
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2414
                    ? "annotation.missing.default.value.1"
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2415
                    : "annotation.missing.default.value";
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2416
            log.error(a.pos(), key, a.type, missingDefaults);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2417
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2418
06bc494ca11e Initial load
duke
parents:
diff changeset
  2419
        // special case: java.lang.annotation.Target must not have
06bc494ca11e Initial load
duke
parents:
diff changeset
  2420
        // repeated values in its value member
06bc494ca11e Initial load
duke
parents:
diff changeset
  2421
        if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  2422
            a.args.tail == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2423
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2424
06bc494ca11e Initial load
duke
parents:
diff changeset
  2425
        if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2426
        JCAssign assign = (JCAssign) a.args.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2427
        Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2428
        if (m.name != names.value) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2429
        JCTree rhs = assign.rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2430
        if (rhs.getTag() != JCTree.NEWARRAY) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2431
        JCNewArray na = (JCNewArray) rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2432
        Set<Symbol> targets = new HashSet<Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2433
        for (JCTree elem : na.elems) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2434
            if (!targets.add(TreeInfo.symbol(elem))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2435
                log.error(elem.pos(), "repeated.annotation.target");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2436
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2437
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2438
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2439
06bc494ca11e Initial load
duke
parents:
diff changeset
  2440
    void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2441
        if (allowAnnotations &&
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2442
            lint.isEnabled(LintCategory.DEP_ANN) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2443
            (s.flags() & DEPRECATED) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2444
            !syms.deprecatedType.isErroneous() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2445
            s.attribute(syms.deprecatedType.tsym) == null) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2446
            log.warning(LintCategory.DEP_ANN,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  2447
                    pos, "missing.deprecated.annotation");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2448
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2449
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2450
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2451
    void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2452
        if ((s.flags() & DEPRECATED) != 0 &&
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2453
                (other.flags() & DEPRECATED) == 0 &&
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2454
                s.outermostClass() != other.outermostClass()) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2455
            deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2456
                @Override
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2457
                public void report() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2458
                    warnDeprecated(pos, s);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2459
                }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2460
            });
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2461
        };
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2462
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2463
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2464
    void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2465
        if ((s.flags() & PROPRIETARY) != 0) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2466
            deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2467
                public void report() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2468
                    if (enableSunApiLintControl)
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2469
                      warnSunApi(pos, "sun.proprietary", s);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2470
                    else
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2471
                      log.strictWarning(pos, "sun.proprietary", s);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2472
                }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2473
            });
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2474
        }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2475
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  2476
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2477
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2478
 * Check for recursive annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2479
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2480
06bc494ca11e Initial load
duke
parents:
diff changeset
  2481
    /** Check for cycles in the graph of annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2482
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2483
    void checkNonCyclicElements(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2484
        if ((tree.sym.flags_field & ANNOTATION) == 0) return;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  2485
        Assert.check((tree.sym.flags_field & LOCKED) == 0);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2486
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2487
            tree.sym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2488
            for (JCTree def : tree.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2489
                if (def.getTag() != JCTree.METHODDEF) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2490
                JCMethodDecl meth = (JCMethodDecl)def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2491
                checkAnnotationResType(meth.pos(), meth.restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2492
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2493
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2494
            tree.sym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2495
            tree.sym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2496
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2497
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2498
06bc494ca11e Initial load
duke
parents:
diff changeset
  2499
    void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2500
        if ((tsym.flags_field & ACYCLIC_ANN) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2501
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2502
        if ((tsym.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2503
            log.error(pos, "cyclic.annotation.element");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2504
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2505
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2506
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2507
            tsym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2508
            for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2509
                Symbol s = e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2510
                if (s.kind != Kinds.MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2511
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2512
                checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  2513
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2514
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2515
            tsym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2516
            tsym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2517
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2518
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2519
06bc494ca11e Initial load
duke
parents:
diff changeset
  2520
    void checkAnnotationResType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2521
        switch (type.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2522
        case TypeTags.CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2523
            if ((type.tsym.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2524
                checkNonCyclicElementsInternal(pos, type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2525
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2526
        case TypeTags.ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2527
            checkAnnotationResType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2528
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2529
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2530
            break; // int etc
06bc494ca11e Initial load
duke
parents:
diff changeset
  2531
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2532
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2533
06bc494ca11e Initial load
duke
parents:
diff changeset
  2534
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2535
 * Check for cycles in the constructor call graph.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2536
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2537
06bc494ca11e Initial load
duke
parents:
diff changeset
  2538
    /** Check for cycles in the graph of constructors calling other
06bc494ca11e Initial load
duke
parents:
diff changeset
  2539
     *  constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2540
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2541
    void checkCyclicConstructors(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2542
        Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2543
06bc494ca11e Initial load
duke
parents:
diff changeset
  2544
        // enter each constructor this-call into the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2545
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2546
            JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2547
            if (app == null) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2548
            JCMethodDecl meth = (JCMethodDecl) l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2549
            if (TreeInfo.name(app.meth) == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2550
                callMap.put(meth.sym, TreeInfo.symbol(app.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2551
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2552
                meth.sym.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2553
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2554
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2555
06bc494ca11e Initial load
duke
parents:
diff changeset
  2556
        // Check for cycles in the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2557
        Symbol[] ctors = new Symbol[0];
06bc494ca11e Initial load
duke
parents:
diff changeset
  2558
        ctors = callMap.keySet().toArray(ctors);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2559
        for (Symbol caller : ctors) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2560
            checkCyclicConstructor(tree, caller, callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2561
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2562
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2563
06bc494ca11e Initial load
duke
parents:
diff changeset
  2564
    /** Look in the map to see if the given constructor is part of a
06bc494ca11e Initial load
duke
parents:
diff changeset
  2565
     *  call cycle.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2566
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2567
    private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2568
                                        Map<Symbol,Symbol> callMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2569
        if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2570
            if ((ctor.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2571
                log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2572
                          "recursive.ctor.invocation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2573
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2574
                ctor.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2575
                checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2576
                ctor.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2577
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2578
            ctor.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2579
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2580
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2581
06bc494ca11e Initial load
duke
parents:
diff changeset
  2582
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2583
 * Miscellaneous
06bc494ca11e Initial load
duke
parents:
diff changeset
  2584
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2585
06bc494ca11e Initial load
duke
parents:
diff changeset
  2586
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2587
     * Return the opcode of the operator but emit an error if it is an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2588
     * error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2589
     * @param pos        position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2590
     * @param operator   an operator
06bc494ca11e Initial load
duke
parents:
diff changeset
  2591
     * @param tag        a tree tag
06bc494ca11e Initial load
duke
parents:
diff changeset
  2592
     * @param left       type of left hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2593
     * @param right      type of right hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2594
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2595
    int checkOperator(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2596
                       OperatorSymbol operator,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2597
                       int tag,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2598
                       Type left,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2599
                       Type right) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2600
        if (operator.opcode == ByteCodes.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2601
            log.error(pos,
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2602
                      "operator.cant.be.applied.1",
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2603
                      treeinfo.operatorName(tag),
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2604
                      left, right);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2605
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2606
        return operator.opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2607
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2608
06bc494ca11e Initial load
duke
parents:
diff changeset
  2609
06bc494ca11e Initial load
duke
parents:
diff changeset
  2610
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2611
     *  Check for division by integer constant zero
06bc494ca11e Initial load
duke
parents:
diff changeset
  2612
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2613
     *  @param operator      The operator for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2614
     *  @param operand       The right hand operand for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2615
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2616
    void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2617
        if (operand.constValue() != null
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2618
            && lint.isEnabled(LintCategory.DIVZERO)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2619
            && operand.tag <= LONG
06bc494ca11e Initial load
duke
parents:
diff changeset
  2620
            && ((Number) (operand.constValue())).longValue() == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2621
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2622
            if (opc == ByteCodes.idiv || opc == ByteCodes.imod
06bc494ca11e Initial load
duke
parents:
diff changeset
  2623
                || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2624
                log.warning(LintCategory.DIVZERO, pos, "div.zero");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2625
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2626
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2627
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2628
06bc494ca11e Initial load
duke
parents:
diff changeset
  2629
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2630
     * Check for empty statements after if
06bc494ca11e Initial load
duke
parents:
diff changeset
  2631
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2632
    void checkEmptyIf(JCIf tree) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2633
        if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(LintCategory.EMPTY))
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2634
            log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2635
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2636
06bc494ca11e Initial load
duke
parents:
diff changeset
  2637
    /** Check that symbol is unique in given scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2638
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2639
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2640
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2641
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2642
    boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2643
        if (sym.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2644
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2645
        if (sym.owner.name == names.any) return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2646
        for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2647
            if (sym != e.sym &&
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2648
                    (e.sym.flags() & CLASH) == 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2649
                    sym.kind == e.sym.kind &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2650
                    sym.name != names.error &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2651
                    (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2652
                if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2653
                    varargsDuplicateError(pos, sym, e.sym);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2654
                    return true;
8628
9e31f1c01bd4 7022054: Invalid compiler error on covariant overriding methods with the same erasure
mcimadamore
parents: 8610
diff changeset
  2655
                } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, e.sym.type, false)) {
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2656
                    duplicateErasureError(pos, sym, e.sym);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2657
                    sym.flags_field |= CLASH;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2658
                    return true;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2659
                } else {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2660
                    duplicateError(pos, e.sym);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2661
                    return false;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2662
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2663
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2664
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2665
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2666
    }
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2667
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2668
    /** Report duplicate declaration error.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2669
     */
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2670
    void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2671
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2672
            log.error(pos, "name.clash.same.erasure", sym1, sym2);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  2673
        }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2674
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2675
06bc494ca11e Initial load
duke
parents:
diff changeset
  2676
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2677
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2678
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2679
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2680
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2681
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2682
    boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2683
        return checkUniqueImport(pos, sym, s, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2684
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2685
06bc494ca11e Initial load
duke
parents:
diff changeset
  2686
    /** Check that static single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2687
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2688
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2689
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2690
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2691
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2692
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2693
    boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2694
        return checkUniqueImport(pos, sym, s, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2695
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2696
06bc494ca11e Initial load
duke
parents:
diff changeset
  2697
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2698
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2699
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2700
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2701
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2702
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2703
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2704
    private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2705
        for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2706
            // is encountered class entered via a class declaration?
06bc494ca11e Initial load
duke
parents:
diff changeset
  2707
            boolean isClassDecl = e.scope == s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2708
            if ((isClassDecl || sym != e.sym) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2709
                sym.kind == e.sym.kind &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2710
                sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2711
                if (!e.sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2712
                    String what = e.sym.toString();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2713
                    if (!isClassDecl) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2714
                        if (staticImport)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2715
                            log.error(pos, "already.defined.static.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2716
                        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2717
                            log.error(pos, "already.defined.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2718
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2719
                    else if (sym != e.sym)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2720
                        log.error(pos, "already.defined.this.unit", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2721
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2722
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2723
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2724
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2725
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2726
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2727
06bc494ca11e Initial load
duke
parents:
diff changeset
  2728
    /** Check that a qualified name is in canonical form (for import decls).
06bc494ca11e Initial load
duke
parents:
diff changeset
  2729
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2730
    public void checkCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2731
        if (!isCanonical(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2732
            log.error(tree.pos(), "import.requires.canonical",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2733
                      TreeInfo.symbol(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2734
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2735
        // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2736
        private boolean isCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2737
            while (tree.getTag() == JCTree.SELECT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2738
                JCFieldAccess s = (JCFieldAccess) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2739
                if (s.sym.owner != TreeInfo.symbol(s.selected))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2740
                    return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2741
                tree = s.selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2742
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2743
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2744
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2745
06bc494ca11e Initial load
duke
parents:
diff changeset
  2746
    private class ConversionWarner extends Warner {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2747
        final String uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2748
        final Type found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2749
        final Type expected;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2750
        public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2751
            super(pos);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2752
            this.uncheckedKey = uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2753
            this.found = found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2754
            this.expected = expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2755
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2756
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  2757
        @Override
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2758
        public void warn(LintCategory lint) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2759
            boolean warned = this.warned;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2760
            super.warn(lint);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2761
            if (warned) return; // suppress redundant diagnostics
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2762
            switch (lint) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2763
                case UNCHECKED:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2764
                    Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2765
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2766
                case VARARGS:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2767
                    if (method != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2768
                            method.attribute(syms.trustMeType.tsym) != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2769
                            isTrustMeAllowedOnMethod(method) &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2770
                            !types.isReifiable(method.type.getParameterTypes().last())) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2771
                        Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2772
                    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2773
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2774
                default:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2775
                    throw new AssertionError("Unexpected lint: " + lint);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  2776
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2777
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2778
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2779
06bc494ca11e Initial load
duke
parents:
diff changeset
  2780
    public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2781
        return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2782
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2783
06bc494ca11e Initial load
duke
parents:
diff changeset
  2784
    public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2785
        return new ConversionWarner(pos, "unchecked.assign", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2786
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2787
}