langtools/src/share/classes/com/sun/tools/javac/comp/Check.java
author mcimadamore
Thu, 09 Dec 2010 15:50:34 +0000
changeset 7628 e7baeb97d164
parent 7214 26dfa4a69593
child 7643 a067a0cda531
permissions -rw-r--r--
6476118: compiler bug causes runtime ClassCastException for generics overloading Summary: compiler allows bridge methods to override unrelated method Reviewed-by: jjg
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     2
 * Copyright (c) 1999, 2009, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
import java.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    29
import java.util.Set;
06bc494ca11e Initial load
duke
parents:
diff changeset
    30
06bc494ca11e Initial load
duke
parents:
diff changeset
    31
import com.sun.tools.javac.code.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
import com.sun.tools.javac.jvm.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    34
import com.sun.tools.javac.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
import com.sun.tools.javac.util.List;
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
06bc494ca11e Initial load
duke
parents:
diff changeset
    38
import com.sun.tools.javac.tree.JCTree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
import com.sun.tools.javac.code.Lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    40
import com.sun.tools.javac.code.Lint.LintCategory;
06bc494ca11e Initial load
duke
parents:
diff changeset
    41
import com.sun.tools.javac.code.Type.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    42
import com.sun.tools.javac.code.Symbol.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    43
06bc494ca11e Initial load
duke
parents:
diff changeset
    44
import static com.sun.tools.javac.code.Flags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    45
import static com.sun.tools.javac.code.Kinds.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    46
import static com.sun.tools.javac.code.TypeTags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    47
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    48
import static com.sun.tools.javac.main.OptionName.*;
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    49
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    50
/** Type checking helper class for the attribution phase.
06bc494ca11e Initial load
duke
parents:
diff changeset
    51
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    52
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    53
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    54
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    55
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    57
public class Check {
06bc494ca11e Initial load
duke
parents:
diff changeset
    58
    protected static final Context.Key<Check> checkKey =
06bc494ca11e Initial load
duke
parents:
diff changeset
    59
        new Context.Key<Check>();
06bc494ca11e Initial load
duke
parents:
diff changeset
    60
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    61
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    62
    private final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
    63
    private final Symtab syms;
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    64
    private final Enter enter;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
    private final Infer infer;
06bc494ca11e Initial load
duke
parents:
diff changeset
    66
    private final Types types;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    67
    private final JCDiagnostic.Factory diags;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
    private final boolean skipAnnotations;
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
    69
    private boolean warnOnSyntheticConflicts;
5842
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
    70
    private boolean suppressAbortOnBadClassFile;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    71
    private final TreeInfo treeinfo;
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
    // The set of lint options currently in effect. It is initialized
06bc494ca11e Initial load
duke
parents:
diff changeset
    74
    // from the context, and then is set/reset as needed by Attr as it
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
    // visits all the various parts of the trees during attribution.
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
    private Lint lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
    public static Check instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    79
        Check instance = context.get(checkKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
            instance = new Check(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    82
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
    84
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
    protected Check(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    86
        context.put(checkKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    88
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
        syms = Symtab.instance(context);
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    91
        enter = Enter.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
        infer = Infer.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
        this.types = Types.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    94
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    95
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    96
        lint = Lint.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    97
        treeinfo = TreeInfo.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
        Source source = Source.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
        allowGenerics = source.allowGenerics();
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
        allowAnnotations = source.allowAnnotations();
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   102
        allowCovariantReturns = source.allowCovariantReturns();
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   103
        complexInference = options.isSet(COMPLEXINFERENCE);
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   104
        skipAnnotations = options.isSet("skipAnnotations");
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   105
        warnOnSyntheticConflicts = options.isSet("warnOnSyntheticConflicts");
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
   106
        suppressAbortOnBadClassFile = options.isSet("suppressAbortOnBadClassFile");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   107
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   108
        Target target = Target.instance(context);
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   109
        syntheticNameChar = target.syntheticNameChar();
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   110
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   111
        boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
06bc494ca11e Initial load
duke
parents:
diff changeset
   112
        boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   113
        boolean verboseVarargs = lint.isEnabled(LintCategory.VARARGS);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   114
        boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   115
        boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   117
        deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   118
                enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   119
        uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   120
                enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   121
        unsafeVarargsHandler = new MandatoryWarningHandler(log, verboseVarargs,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   122
                enforceMandatoryWarnings, "varargs", LintCategory.VARARGS);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   123
        sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   124
                enforceMandatoryWarnings, "sunapi", null);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   125
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   126
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
    /** Switch: generics enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   128
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   129
    boolean allowGenerics;
06bc494ca11e Initial load
duke
parents:
diff changeset
   130
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
    /** Switch: annotations enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   132
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   133
    boolean allowAnnotations;
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   135
    /** Switch: covariant returns enabled?
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   136
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   137
    boolean allowCovariantReturns;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   138
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   139
    /** Switch: -complexinference option set?
06bc494ca11e Initial load
duke
parents:
diff changeset
   140
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   141
    boolean complexInference;
06bc494ca11e Initial load
duke
parents:
diff changeset
   142
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   143
    /** Character for synthetic names
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   144
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   145
    char syntheticNameChar;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   146
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   147
    /** A table mapping flat names of all compiled classes in this run to their
06bc494ca11e Initial load
duke
parents:
diff changeset
   148
     *  symbols; maintained from outside.
06bc494ca11e Initial load
duke
parents:
diff changeset
   149
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
    public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
06bc494ca11e Initial load
duke
parents:
diff changeset
   152
    /** A handler for messages about deprecated usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   153
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   154
    private MandatoryWarningHandler deprecationHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   155
06bc494ca11e Initial load
duke
parents:
diff changeset
   156
    /** A handler for messages about unchecked or unsafe usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   157
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   158
    private MandatoryWarningHandler uncheckedHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   159
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   160
    /** A handler for messages about unchecked or unsafe vararg method decl.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   161
     */
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   162
    private MandatoryWarningHandler unsafeVarargsHandler;
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   163
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   164
    /** A handler for messages about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   165
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   166
    private MandatoryWarningHandler sunApiHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   167
06bc494ca11e Initial load
duke
parents:
diff changeset
   168
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   169
 * Errors and Warnings
06bc494ca11e Initial load
duke
parents:
diff changeset
   170
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   171
06bc494ca11e Initial load
duke
parents:
diff changeset
   172
    Lint setLint(Lint newLint) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   173
        Lint prev = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   174
        lint = newLint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   175
        return prev;
06bc494ca11e Initial load
duke
parents:
diff changeset
   176
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   177
06bc494ca11e Initial load
duke
parents:
diff changeset
   178
    /** Warn about deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   179
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   180
     *  @param sym        The deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   181
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   182
    void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   183
        if (!lint.isSuppressed(LintCategory.DEPRECATION))
06bc494ca11e Initial load
duke
parents:
diff changeset
   184
            deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   186
06bc494ca11e Initial load
duke
parents:
diff changeset
   187
    /** Warn about unchecked operation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   188
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   189
     *  @param msg        A string describing the problem.
06bc494ca11e Initial load
duke
parents:
diff changeset
   190
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   191
    public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   192
        if (!lint.isSuppressed(LintCategory.UNCHECKED))
06bc494ca11e Initial load
duke
parents:
diff changeset
   193
            uncheckedHandler.report(pos, msg, args);
06bc494ca11e Initial load
duke
parents:
diff changeset
   194
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   195
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   196
    /** Warn about unsafe vararg method decl.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   197
     *  @param pos        Position to be used for error reporting.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   198
     *  @param sym        The deprecated symbol.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   199
     */
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   200
    void warnUnsafeVararg(DiagnosticPosition pos, Type elemType) {
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   201
        if (!lint.isSuppressed(LintCategory.VARARGS))
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   202
            unsafeVarargsHandler.report(pos, "varargs.non.reifiable.type", elemType);
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   203
    }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   204
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   205
    /** Warn about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   206
     *  @param pos        Position to be used for error reporting.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   207
     *  @param msg        A string describing the problem.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   208
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   209
    public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   210
        if (!lint.isSuppressed(LintCategory.SUNAPI))
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   211
            sunApiHandler.report(pos, msg, args);
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   212
    }
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   213
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   214
    public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   215
        if (lint.isEnabled(LintCategory.STATIC))
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   216
            log.warning(LintCategory.STATIC, pos, msg, args);
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   217
    }
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   218
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   219
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   220
     * Report any deferred diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
   221
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   222
    public void reportDeferredDiagnostics() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   223
        deprecationHandler.reportDeferredDiagnostic();
06bc494ca11e Initial load
duke
parents:
diff changeset
   224
        uncheckedHandler.reportDeferredDiagnostic();
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   225
        unsafeVarargsHandler.reportDeferredDiagnostic();
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   226
        sunApiHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   227
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   228
06bc494ca11e Initial load
duke
parents:
diff changeset
   229
06bc494ca11e Initial load
duke
parents:
diff changeset
   230
    /** Report a failure to complete a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   231
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   232
     *  @param ex         The failure to report.
06bc494ca11e Initial load
duke
parents:
diff changeset
   233
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   234
    public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
169
ff76730e430e 6668794: javac puts localized text in raw diagnostics
jjg
parents: 10
diff changeset
   235
        log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
5842
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
   236
        if (ex instanceof ClassReader.BadClassFile
714e365b4b1b 6955264: add option to suppress Abort in Check.completionError
jjg
parents: 5654
diff changeset
   237
                && !suppressAbortOnBadClassFile) throw new Abort();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   238
        else return syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   239
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   240
06bc494ca11e Initial load
duke
parents:
diff changeset
   241
    /** Report a type error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   242
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   243
     *  @param problem    A string describing the error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   244
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   245
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   246
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   247
    Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   248
        log.error(pos, "prob.found.req",
06bc494ca11e Initial load
duke
parents:
diff changeset
   249
                  problem, found, req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   250
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   251
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   252
06bc494ca11e Initial load
duke
parents:
diff changeset
   253
    Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
        log.error(pos, "prob.found.req.1", problem, found, req, explanation);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   255
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   256
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
06bc494ca11e Initial load
duke
parents:
diff changeset
   258
    /** Report an error that wrong type tag was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
     *  @param required   An internationalized string describing the type tag
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
     *                    required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   263
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
    Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   265
        // this error used to be raised by the parser,
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   266
        // but has been delayed to this point:
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   267
        if (found instanceof Type && ((Type)found).tag == VOID) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   268
            log.error(pos, "illegal.start.of.type");
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   269
            return syms.errType;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   270
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   271
        log.error(pos, "type.found.req", found, required);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   272
        return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
    /** Report an error that symbol cannot be referenced before super
06bc494ca11e Initial load
duke
parents:
diff changeset
   276
     *  has been called.
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
     *  @param sym        The referenced symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   279
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   280
    void earlyRefError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   281
        log.error(pos, "cant.ref.before.ctor.called", sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   282
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   283
06bc494ca11e Initial load
duke
parents:
diff changeset
   284
    /** Report duplicate declaration error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   286
    void duplicateError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   287
        if (!sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
            log.error(pos, "already.defined", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
    /** Report array/varargs duplicate declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   294
    void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   295
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
            log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   297
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   298
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
 * duplicate declaration checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
06bc494ca11e Initial load
duke
parents:
diff changeset
   304
    /** Check that variable does not hide variable with same name in
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
     *  immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
     *  @param v             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   308
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
    void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   311
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
            for (Scope.Entry e = s.next.lookup(v.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
                 e.scope != null && e.sym.owner == v.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
                 e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
                if (e.sym.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
                    v.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
    /** Check that a class or interface does not hide a class or
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
     *  interface with same name in immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
     *  @param c             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
    void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
            for (Scope.Entry e = s.next.lookup(c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
                 e.scope != null && e.sym.owner == c.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
                 e = e.next()) {
6352
217d5a69681a 6977800: Regression: invalid resolution of supertype for local class
mcimadamore
parents: 6351
diff changeset
   336
                if (e.sym.kind == TYP && e.sym.type.tag != TYPEVAR &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   338
                    c.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   339
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   340
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   341
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   342
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   343
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   345
06bc494ca11e Initial load
duke
parents:
diff changeset
   346
    /** Check that class does not have the same name as one of
06bc494ca11e Initial load
duke
parents:
diff changeset
   347
     *  its enclosing classes, or as a class defined in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   348
     *  return true if class is unique in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
     *  @param name          The class name.
06bc494ca11e Initial load
duke
parents:
diff changeset
   351
     *  @param s             The enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   352
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   353
    boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
        for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
            if (e.sym.kind == TYP && e.sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   356
                duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   357
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
        for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
            if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
                duplicateError(pos, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
 * Class name generation
06bc494ca11e Initial load
duke
parents:
diff changeset
   371
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
06bc494ca11e Initial load
duke
parents:
diff changeset
   373
    /** Return name of local class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
     *  This is of the form    <enclClass> $ n <classname>
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
     *  where
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
     *    enclClass is the flat name of the enclosing class,
06bc494ca11e Initial load
duke
parents:
diff changeset
   377
     *    classname is the simple name of the local class
06bc494ca11e Initial load
duke
parents:
diff changeset
   378
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   379
    Name localClassName(ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   380
        for (int i=1; ; i++) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   381
            Name flatname = names.
06bc494ca11e Initial load
duke
parents:
diff changeset
   382
                fromString("" + c.owner.enclClass().flatname +
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   383
                           syntheticNameChar + i +
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   384
                           c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   385
            if (compiled.get(flatname) == null) return flatname;
06bc494ca11e Initial load
duke
parents:
diff changeset
   386
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   387
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   388
06bc494ca11e Initial load
duke
parents:
diff changeset
   389
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   390
 * Type Checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   391
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   392
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
    /** Check that a given type is assignable to a given proto-type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   394
     *  If it is, return the type, otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
   395
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   396
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   397
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   398
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   399
    Type checkType(DiagnosticPosition pos, Type found, Type req) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   400
        return checkType(pos, found, req, "incompatible.types");
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   401
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   402
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   403
    Type checkType(DiagnosticPosition pos, Type found, Type req, String errKey) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   404
        if (req.tag == ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   405
            return req;
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   406
        if (found.tag == FORALL)
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   407
            return instantiatePoly(pos, (ForAll)found, req, convertWarner(pos, found, req));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   408
        if (req.tag == NONE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
        if (types.isAssignable(found, req, convertWarner(pos, found, req)))
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
        if (found.tag <= DOUBLE && req.tag <= DOUBLE)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   413
            return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   414
        if (found.isSuperBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   415
            log.error(pos, "assignment.from.super-bound", found);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   416
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   417
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   418
        if (req.isExtendsBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   419
            log.error(pos, "assignment.to.extends-bound", req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   420
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   421
        }
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   422
        return typeError(pos, diags.fragment(errKey), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   423
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   424
06bc494ca11e Initial load
duke
parents:
diff changeset
   425
    /** Instantiate polymorphic type to some prototype, unless
06bc494ca11e Initial load
duke
parents:
diff changeset
   426
     *  prototype is `anyPoly' in which case polymorphic type
06bc494ca11e Initial load
duke
parents:
diff changeset
   427
     *  is returned unchanged.
06bc494ca11e Initial load
duke
parents:
diff changeset
   428
     */
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   429
    Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
        if (pt == Infer.anyPoly && complexInference) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   432
        } else if (pt == Infer.anyPoly || pt.tag == NONE) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   433
            Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   434
            return instantiatePoly(pos, t, newpt, warn);
06bc494ca11e Initial load
duke
parents:
diff changeset
   435
        } else if (pt.tag == ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   436
            return pt;
06bc494ca11e Initial load
duke
parents:
diff changeset
   437
        } else {
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   438
            try {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   439
                return infer.instantiateExpr(t, pt, warn);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   440
            } catch (Infer.NoInstanceException ex) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   441
                if (ex.isAmbiguous) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   442
                    JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   443
                    log.error(pos,
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   444
                              "undetermined.type" + (d!=null ? ".1" : ""),
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   445
                              t, d);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   446
                    return types.createErrorType(pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   447
                } else {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   448
                    JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   449
                    return typeError(pos,
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   450
                                     diags.fragment("incompatible.types" + (d!=null ? ".1" : ""), d),
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   451
                                     t, pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   452
                }
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   453
            } catch (Infer.InvalidInstanceException ex) {
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   454
                JCDiagnostic d = ex.getDiagnostic();
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   455
                log.error(pos, "invalid.inferred.types", t.tvars, d);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   456
                return types.createErrorType(pt);
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   457
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   458
        }
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
   459
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   460
06bc494ca11e Initial load
duke
parents:
diff changeset
   461
    /** Check that a given type can be cast to a given target type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   462
     *  Return the result of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   463
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   464
     *  @param found      The type that is being cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   465
     *  @param req        The target type of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   466
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   467
    Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   468
        if (found.tag == FORALL) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   469
            instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
06bc494ca11e Initial load
duke
parents:
diff changeset
   470
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   471
        } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   472
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   473
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   474
            return typeError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   475
                             diags.fragment("inconvertible.types"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   476
                             found, req);
06bc494ca11e Initial load
duke
parents:
diff changeset
   477
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   478
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   479
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
   480
        /** Is type a type variable, or a (possibly multi-dimensional) array of
06bc494ca11e Initial load
duke
parents:
diff changeset
   481
         *  type variables?
06bc494ca11e Initial load
duke
parents:
diff changeset
   482
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
   483
        boolean isTypeVar(Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   484
            return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
06bc494ca11e Initial load
duke
parents:
diff changeset
   485
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   486
06bc494ca11e Initial load
duke
parents:
diff changeset
   487
    /** Check that a type is within some bounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   488
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   489
     *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
06bc494ca11e Initial load
duke
parents:
diff changeset
   490
     *  type argument.
06bc494ca11e Initial load
duke
parents:
diff changeset
   491
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   492
     *  @param a             The type that should be bounded by bs.
06bc494ca11e Initial load
duke
parents:
diff changeset
   493
     *  @param bs            The bound.
06bc494ca11e Initial load
duke
parents:
diff changeset
   494
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   495
    private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   496
         if (a.isUnbound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   497
             return;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   498
         } else if (a.tag != WILDCARD) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   499
             a = types.upperBound(a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   500
             for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   501
                 if (!types.isSubtype(a, l.head)) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   502
                     log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   503
                     return;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   504
                 }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   505
             }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   506
         } else if (a.isExtendsBound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   507
             if (!types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings))
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   508
                 log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   509
         } else if (a.isSuperBound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   510
             if (types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound()))
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   511
                 log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   512
         }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   513
     }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   514
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   515
    /** Check that a type is within some bounds.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   516
     *
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   517
     *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   518
     *  type argument.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   519
     *  @param pos           Position to be used for error reporting.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   520
     *  @param a             The type that should be bounded by bs.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   521
     *  @param bs            The bound.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   522
     */
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   523
    private void checkCapture(JCTypeApply tree) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   524
        List<JCExpression> args = tree.getTypeArguments();
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   525
        for (Type arg : types.capture(tree.type).getTypeArguments()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   526
            if (arg.tag == TYPEVAR && arg.getUpperBound().isErroneous()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   527
                log.error(args.head.pos, "not.within.bounds", args.head.type);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   528
                break;
938
13aae74ca013 6594284: NPE thrown when calling a method on an intersection type
mcimadamore
parents: 937
diff changeset
   529
            }
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   530
            args = args.tail;
938
13aae74ca013 6594284: NPE thrown when calling a method on an intersection type
mcimadamore
parents: 937
diff changeset
   531
        }
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   532
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   533
06bc494ca11e Initial load
duke
parents:
diff changeset
   534
    /** Check that type is different from 'void'.
06bc494ca11e Initial load
duke
parents:
diff changeset
   535
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   536
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   537
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   538
    Type checkNonVoid(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   539
        if (t.tag == VOID) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   540
            log.error(pos, "void.not.allowed.here");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   541
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   542
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   543
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   544
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   545
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   546
06bc494ca11e Initial load
duke
parents:
diff changeset
   547
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   548
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   549
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   550
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   551
    Type checkClassType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   552
        if (t.tag != CLASS && t.tag != ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   553
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   554
                                diags.fragment("type.req.class"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   555
                                (t.tag == TYPEVAR)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   556
                                ? diags.fragment("type.parameter", t)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   557
                                : t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   558
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
   559
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   560
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   561
06bc494ca11e Initial load
duke
parents:
diff changeset
   562
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   563
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   564
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   565
     *  @param noBounds    True if type bounds are illegal here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   566
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   567
    Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   568
        t = checkClassType(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   569
        if (noBounds && t.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   570
            List<Type> args = t.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
   571
            while (args.nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   572
                if (args.head.tag == WILDCARD)
06bc494ca11e Initial load
duke
parents:
diff changeset
   573
                    return typeTagError(pos,
6032
03b276d8e6a6 6968497: localized text appears in raw diagnostic
jjg
parents: 5848
diff changeset
   574
                                        diags.fragment("type.req.exact"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   575
                                        args.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
   576
                args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   577
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   578
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   579
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   580
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   581
06bc494ca11e Initial load
duke
parents:
diff changeset
   582
    /** Check that type is a reifiable class, interface or array type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   583
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   584
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   585
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   586
    Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   587
        if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   588
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   589
                                diags.fragment("type.req.class.array"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   590
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   591
        } else if (!types.isReifiable(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   592
            log.error(pos, "illegal.generic.type.for.instof");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   593
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   594
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   595
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   596
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   597
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   598
06bc494ca11e Initial load
duke
parents:
diff changeset
   599
    /** Check that type is a reference type, i.e. a class, interface or array type
06bc494ca11e Initial load
duke
parents:
diff changeset
   600
     *  or a type variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   601
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   602
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   603
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   604
    Type checkRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   605
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   606
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   607
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   608
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   609
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   610
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   611
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   612
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   613
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   614
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   615
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   616
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   617
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   618
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   619
    /** Check that each type is a reference type, i.e. a class, interface or array type
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   620
     *  or a type variable.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   621
     *  @param trees         Original trees, used for error reporting.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   622
     *  @param types         The types to be checked.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   623
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   624
    List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   625
        List<JCExpression> tl = trees;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   626
        for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   627
            l.head = checkRefType(tl.head.pos(), l.head);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   628
            tl = tl.tail;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   629
        }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   630
        return types;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   631
    }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   632
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   633
    /** Check that type is a null or reference type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   634
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   635
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   636
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   637
    Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   638
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   639
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   640
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   641
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   642
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   643
        case BOT:
06bc494ca11e Initial load
duke
parents:
diff changeset
   644
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   645
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   646
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   647
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   648
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   649
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   650
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   651
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   652
06bc494ca11e Initial load
duke
parents:
diff changeset
   653
    /** Check that flag set does not contain elements of two conflicting sets. s
06bc494ca11e Initial load
duke
parents:
diff changeset
   654
     *  Return true if it doesn't.
06bc494ca11e Initial load
duke
parents:
diff changeset
   655
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   656
     *  @param flags         The set of flags to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   657
     *  @param set1          Conflicting flags set #1.
06bc494ca11e Initial load
duke
parents:
diff changeset
   658
     *  @param set2          Conflicting flags set #2.
06bc494ca11e Initial load
duke
parents:
diff changeset
   659
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   660
    boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   661
        if ((flags & set1) != 0 && (flags & set2) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   662
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
   663
                      "illegal.combination.of.modifiers",
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   664
                      asFlagSet(TreeInfo.firstFlag(flags & set1)),
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   665
                      asFlagSet(TreeInfo.firstFlag(flags & set2)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   667
        } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   668
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   669
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   670
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   671
    /** Check that the type inferred using the diamond operator does not contain
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   672
     *  non-denotable types such as captured types or intersection types.
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   673
     *  @param t the type inferred using the diamond operator
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   674
     */
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   675
    List<Type> checkDiamond(ClassType t) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   676
        DiamondTypeChecker dtc = new DiamondTypeChecker();
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   677
        ListBuffer<Type> buf = ListBuffer.lb();
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   678
        for (Type arg : t.getTypeArguments()) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   679
            if (!dtc.visit(arg, null)) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   680
                buf.append(arg);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   681
            }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   682
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   683
        return buf.toList();
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   684
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   685
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   686
    static class DiamondTypeChecker extends Types.SimpleVisitor<Boolean, Void> {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   687
        public Boolean visitType(Type t, Void s) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   688
            return true;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   689
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   690
        @Override
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   691
        public Boolean visitClassType(ClassType t, Void s) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   692
            if (t.isCompound()) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   693
                return false;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   694
            }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   695
            for (Type targ : t.getTypeArguments()) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   696
                if (!visit(targ, s)) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   697
                    return false;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   698
                }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   699
            }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   700
            return true;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   701
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   702
        @Override
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   703
        public Boolean visitCapturedType(CapturedType t, Void s) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   704
            return false;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   705
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   706
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   707
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   708
    void checkVarargMethodDecl(JCMethodDecl tree) {
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   709
        MethodSymbol m = tree.sym;
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   710
        //check the element type of the vararg
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   711
        if (m.isVarArgs()) {
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   712
            Type varargElemType = types.elemtype(tree.params.last().type);
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   713
            if (!types.isReifiable(varargElemType)) {
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   714
                warnUnsafeVararg(tree.params.head.pos(), varargElemType);
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   715
            }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   716
        }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   717
    }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   718
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   719
    /**
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   720
     * Check that vararg method call is sound
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   721
     * @param pos Position to be used for error reporting.
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   722
     * @param argtypes Actual arguments supplied to vararg method.
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   723
     */
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   724
    void checkVararg(DiagnosticPosition pos, List<Type> argtypes, Symbol msym, Env<AttrContext> env) {
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   725
        Env<AttrContext> calleeLintEnv = env;
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   726
        while (calleeLintEnv.info.lint == null)
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   727
            calleeLintEnv = calleeLintEnv.next;
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   728
        Lint calleeLint = calleeLintEnv.info.lint.augment(msym.attributes_field, msym.flags());
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   729
        Type argtype = argtypes.last();
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   730
        if (!types.isReifiable(argtype) && !calleeLint.isSuppressed(Lint.LintCategory.VARARGS)) {
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   731
            warnUnchecked(pos,
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   732
                              "unchecked.generic.array.creation",
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   733
                              argtype);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   734
        }
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   735
    }
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   736
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   737
    /** Check that given modifiers are legal for given symbol and
06bc494ca11e Initial load
duke
parents:
diff changeset
   738
     *  return modifiers together with any implicit modififiers for that symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   739
     *  Warning: we can't use flags() here since this method
06bc494ca11e Initial load
duke
parents:
diff changeset
   740
     *  is called during class enter, when flags() would cause a premature
06bc494ca11e Initial load
duke
parents:
diff changeset
   741
     *  completion.
06bc494ca11e Initial load
duke
parents:
diff changeset
   742
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   743
     *  @param flags         The set of modifiers given in a definition.
06bc494ca11e Initial load
duke
parents:
diff changeset
   744
     *  @param sym           The defined symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   745
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   746
    long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   747
        long mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   748
        long implicit = 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   749
        switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   750
        case VAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   751
            if (sym.owner.kind != TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
   752
                mask = LocalVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   753
            else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   754
                mask = implicit = InterfaceVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   755
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
   756
                mask = VarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   758
        case MTH:
06bc494ca11e Initial load
duke
parents:
diff changeset
   759
            if (sym.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   760
                if ((sym.owner.flags_field & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   761
                    // enum constructors cannot be declared public or
06bc494ca11e Initial load
duke
parents:
diff changeset
   762
                    // protected and must be implicitly or explicitly
06bc494ca11e Initial load
duke
parents:
diff changeset
   763
                    // private
06bc494ca11e Initial load
duke
parents:
diff changeset
   764
                    implicit = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
                    mask = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
                } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
                    mask = ConstructorFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   768
            }  else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   769
                mask = implicit = InterfaceMethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   770
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   771
                mask = MethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   772
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   773
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   774
            if (((flags|implicit) & Flags.ABSTRACT) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   775
              implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   776
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   777
        case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
   778
            if (sym.isLocal()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   779
                mask = LocalClassFlags;
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   780
                if (sym.name.isEmpty()) { // Anonymous class
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   781
                    // Anonymous classes in static methods are themselves static;
06bc494ca11e Initial load
duke
parents:
diff changeset
   782
                    // that's why we admit STATIC here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   783
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   784
                    // JLS: Anonymous classes are final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   785
                    implicit |= FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
   786
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   787
                if ((sym.owner.flags_field & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   788
                    (flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   789
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   790
            } else if (sym.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   791
                mask = MemberClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   792
                if (sym.owner.owner.kind == PCK ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   793
                    (sym.owner.flags_field & STATIC) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   794
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   795
                else if ((flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   796
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   797
                // Nested interfaces and enums are always STATIC (Spec ???)
06bc494ca11e Initial load
duke
parents:
diff changeset
   798
                if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   799
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   800
                mask = ClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   801
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   802
            // Interfaces are always ABSTRACT
06bc494ca11e Initial load
duke
parents:
diff changeset
   803
            if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
   804
06bc494ca11e Initial load
duke
parents:
diff changeset
   805
            if ((flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   806
                // enums can't be declared abstract or final
06bc494ca11e Initial load
duke
parents:
diff changeset
   807
                mask &= ~(ABSTRACT | FINAL);
06bc494ca11e Initial load
duke
parents:
diff changeset
   808
                implicit |= implicitEnumFinalFlag(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
   809
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   810
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   811
            implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   812
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   813
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   814
            throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
   815
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   816
        long illegal = flags & StandardFlags & ~mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   817
        if (illegal != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   818
            if ((illegal & INTERFACE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   819
                log.error(pos, "intf.not.allowed.here");
06bc494ca11e Initial load
duke
parents:
diff changeset
   820
                mask |= INTERFACE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   821
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   822
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   823
                log.error(pos,
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   824
                          "mod.not.allowed.here", asFlagSet(illegal));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   825
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   826
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   827
        else if ((sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   828
                  // ISSUE: Disallowing abstract&private is no longer appropriate
06bc494ca11e Initial load
duke
parents:
diff changeset
   829
                  // in the presence of inner classes. Should it be deleted here?
06bc494ca11e Initial load
duke
parents:
diff changeset
   830
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   831
                                ABSTRACT,
06bc494ca11e Initial load
duke
parents:
diff changeset
   832
                                PRIVATE | STATIC))
06bc494ca11e Initial load
duke
parents:
diff changeset
   833
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   834
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   835
                               ABSTRACT | INTERFACE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   836
                               FINAL | NATIVE | SYNCHRONIZED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   837
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   838
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   839
                               PUBLIC,
06bc494ca11e Initial load
duke
parents:
diff changeset
   840
                               PRIVATE | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   841
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   842
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   843
                               PRIVATE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   844
                               PUBLIC | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   845
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   846
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   847
                               FINAL,
06bc494ca11e Initial load
duke
parents:
diff changeset
   848
                               VOLATILE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   849
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   850
                 (sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   851
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   852
                                ABSTRACT | NATIVE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   853
                                STRICTFP))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   854
            // skip
06bc494ca11e Initial load
duke
parents:
diff changeset
   855
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   856
        return flags & (mask | ~StandardFlags) | implicit;
06bc494ca11e Initial load
duke
parents:
diff changeset
   857
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   858
06bc494ca11e Initial load
duke
parents:
diff changeset
   859
06bc494ca11e Initial load
duke
parents:
diff changeset
   860
    /** Determine if this enum should be implicitly final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   861
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   862
     *  If the enum has no specialized enum contants, it is final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   863
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   864
     *  If the enum does have specialized enum contants, it is
06bc494ca11e Initial load
duke
parents:
diff changeset
   865
     *  <i>not</i> final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   866
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   867
    private long implicitEnumFinalFlag(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   868
        if (tree.getTag() != JCTree.CLASSDEF) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   869
        class SpecialTreeVisitor extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
   870
            boolean specialized;
06bc494ca11e Initial load
duke
parents:
diff changeset
   871
            SpecialTreeVisitor() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   872
                this.specialized = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   873
            };
06bc494ca11e Initial load
duke
parents:
diff changeset
   874
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   875
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   876
            public void visitTree(JCTree tree) { /* no-op */ }
06bc494ca11e Initial load
duke
parents:
diff changeset
   877
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   878
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   879
            public void visitVarDef(JCVariableDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   880
                if ((tree.mods.flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   881
                    if (tree.init instanceof JCNewClass &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   882
                        ((JCNewClass) tree.init).def != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   883
                        specialized = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   884
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   885
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   886
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   887
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   888
06bc494ca11e Initial load
duke
parents:
diff changeset
   889
        SpecialTreeVisitor sts = new SpecialTreeVisitor();
06bc494ca11e Initial load
duke
parents:
diff changeset
   890
        JCClassDecl cdef = (JCClassDecl) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
   891
        for (JCTree defs: cdef.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   892
            defs.accept(sts);
06bc494ca11e Initial load
duke
parents:
diff changeset
   893
            if (sts.specialized) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   894
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   895
        return FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
   896
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   897
06bc494ca11e Initial load
duke
parents:
diff changeset
   898
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   899
 * Type Validation
06bc494ca11e Initial load
duke
parents:
diff changeset
   900
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   901
06bc494ca11e Initial load
duke
parents:
diff changeset
   902
    /** Validate a type expression. That is,
06bc494ca11e Initial load
duke
parents:
diff changeset
   903
     *  check that all type arguments of a parametric type are within
06bc494ca11e Initial load
duke
parents:
diff changeset
   904
     *  their bounds. This must be done in a second phase after type attributon
06bc494ca11e Initial load
duke
parents:
diff changeset
   905
     *  since a class might have a subclass as type parameter bound. E.g:
06bc494ca11e Initial load
duke
parents:
diff changeset
   906
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   907
     *  class B<A extends C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
   908
     *  class C extends B<C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
   909
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   910
     *  and we can't make sure that the bound is already attributed because
06bc494ca11e Initial load
duke
parents:
diff changeset
   911
     *  of possible cycles.
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   912
     *
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   913
     * Visitor method: Validate a type expression, if it is not null, catching
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   914
     *  and reporting any completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
   915
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   916
    void validate(JCTree tree, Env<AttrContext> env) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   917
        validate(tree, env, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   918
    }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   919
    void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   920
        new Validator(env).validateTree(tree, checkRaw, true);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   921
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   922
06bc494ca11e Initial load
duke
parents:
diff changeset
   923
    /** Visitor method: Validate a list of type expressions.
06bc494ca11e Initial load
duke
parents:
diff changeset
   924
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   925
    void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   926
        for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   927
            validate(l.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   928
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   929
06bc494ca11e Initial load
duke
parents:
diff changeset
   930
    /** A visitor class for type validation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   931
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   932
    class Validator extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
   933
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   934
        boolean isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   935
        Env<AttrContext> env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   936
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   937
        Validator(Env<AttrContext> env) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   938
            this.env = env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   939
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   940
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   941
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   942
        public void visitTypeArray(JCArrayTypeTree tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   943
            tree.elemtype.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   944
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   945
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   946
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   947
        public void visitTypeApply(JCTypeApply tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   948
            if (tree.type.tag == CLASS) {
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   949
                List<Type> formals = tree.type.tsym.type.allparams();
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   950
                List<Type> actuals = tree.type.allparams();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   951
                List<JCExpression> args = tree.arguments;
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   952
                List<Type> forms = tree.type.tsym.type.getTypeArguments();
5648
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   953
                ListBuffer<Type> tvars_buf = new ListBuffer<Type>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   954
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   955
                boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   956
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   957
                // For matching pairs of actual argument types `a' and
06bc494ca11e Initial load
duke
parents:
diff changeset
   958
                // formal type parameters with declared bound `b' ...
06bc494ca11e Initial load
duke
parents:
diff changeset
   959
                while (args.nonEmpty() && forms.nonEmpty()) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   960
                    validateTree(args.head,
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   961
                            !(isOuter && is_java_lang_Class),
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
   962
                            false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   963
06bc494ca11e Initial load
duke
parents:
diff changeset
   964
                    // exact type arguments needs to know their
06bc494ca11e Initial load
duke
parents:
diff changeset
   965
                    // bounds (for upper and lower bound
06bc494ca11e Initial load
duke
parents:
diff changeset
   966
                    // calculations).  So we create new TypeVars with
06bc494ca11e Initial load
duke
parents:
diff changeset
   967
                    // bounds substed with actuals.
06bc494ca11e Initial load
duke
parents:
diff changeset
   968
                    tvars_buf.append(types.substBound(((TypeVar)forms.head),
06bc494ca11e Initial load
duke
parents:
diff changeset
   969
                                                      formals,
937
457a11ae2e84 6651719: Compiler crashes possibly during forward reference of TypeParameter
mcimadamore
parents: 815
diff changeset
   970
                                                      actuals));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   971
06bc494ca11e Initial load
duke
parents:
diff changeset
   972
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   973
                    forms = forms.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   974
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   975
06bc494ca11e Initial load
duke
parents:
diff changeset
   976
                args = tree.arguments;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   977
                List<Type> tvars_cap = types.substBounds(formals,
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   978
                                          formals,
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   979
                                          types.capture(tree.type).allparams());
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   980
                while (args.nonEmpty() && tvars_cap.nonEmpty()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   981
                    // Let the actual arguments know their bound
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   982
                    args.head.type.withTypeVar((TypeVar)tvars_cap.head);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   983
                    args = args.tail;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   984
                    tvars_cap = tvars_cap.tail;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   985
                }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   986
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   987
                args = tree.arguments;
5648
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   988
                List<Type> tvars = tvars_buf.toList();
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   989
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   990
                while (args.nonEmpty() && tvars.nonEmpty()) {
5648
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   991
                    Type actual = types.subst(args.head.type,
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   992
                        tree.type.tsym.type.getTypeArguments(),
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   993
                        tvars_buf.toList());
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   994
                    checkExtends(args.head.pos(),
5648
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   995
                                 actual,
e8aa492874b5 6880344: Recursive type parameters do not compile
mcimadamore
parents: 5489
diff changeset
   996
                                 (TypeVar)tvars.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   997
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   998
                    tvars = tvars.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   999
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1000
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
  1001
                checkCapture(tree);
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
  1002
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1003
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1004
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1005
                if (tree.type.getEnclosingType().isRaw())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1006
                    log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1007
                if (tree.clazz.getTag() == JCTree.SELECT)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1008
                    visitSelectInternal((JCFieldAccess)tree.clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1009
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1010
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1011
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1012
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1013
        public void visitTypeParameter(JCTypeParameter tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1014
            validateTrees(tree.bounds, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1015
            checkClassBounds(tree.pos(), tree.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1016
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1017
06bc494ca11e Initial load
duke
parents:
diff changeset
  1018
        @Override
06bc494ca11e Initial load
duke
parents:
diff changeset
  1019
        public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1020
            if (tree.inner != null)
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1021
                validateTree(tree.inner, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1022
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1023
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1024
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1025
        public void visitSelect(JCFieldAccess tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1026
            if (tree.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1027
                visitSelectInternal(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1028
06bc494ca11e Initial load
duke
parents:
diff changeset
  1029
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1030
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1031
                if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1032
                    log.error(tree.pos(), "improperly.formed.type.param.missing");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1033
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1034
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1035
        public void visitSelectInternal(JCFieldAccess tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1036
            if (tree.type.tsym.isStatic() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1037
                tree.selected.type.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1038
                // The enclosing type is not a class, so we are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1039
                // looking at a static member type.  However, the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1040
                // qualifying expression is parameterized.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1041
                log.error(tree.pos(), "cant.select.static.class.from.param.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1042
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1043
                // otherwise validate the rest of the expression
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1044
                tree.selected.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1045
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1046
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1047
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1048
        @Override
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1049
        public void visitAnnotatedType(JCAnnotatedType tree) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1050
            tree.underlyingType.accept(this);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1051
        }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1052
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1053
        /** Default visitor method: do nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1054
         */
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1055
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1056
        public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1057
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1058
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1059
        public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1060
            try {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1061
                if (tree != null) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1062
                    this.isOuter = isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1063
                    tree.accept(this);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1064
                    if (checkRaw)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1065
                        checkRaw(tree, env);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1066
                }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1067
            } catch (CompletionFailure ex) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1068
                completionError(tree.pos(), ex);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1069
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1070
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1071
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1072
        public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1073
            for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1074
                validateTree(l.head, checkRaw, isOuter);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1075
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1076
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1077
        void checkRaw(JCTree tree, Env<AttrContext> env) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1078
            if (lint.isEnabled(Lint.LintCategory.RAW) &&
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1079
                tree.type.tag == CLASS &&
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1080
                !TreeInfo.isDiamond(tree) &&
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1081
                !env.enclClass.name.isEmpty() &&  //anonymous or intersection
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1082
                tree.type.isRaw()) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1083
                log.warning(Lint.LintCategory.RAW,
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1084
                        tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1085
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1086
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1087
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1088
06bc494ca11e Initial load
duke
parents:
diff changeset
  1089
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1090
 * Exception checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1091
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1092
06bc494ca11e Initial load
duke
parents:
diff changeset
  1093
    /* The following methods treat classes as sets that contain
06bc494ca11e Initial load
duke
parents:
diff changeset
  1094
     * the class itself and all their subclasses
06bc494ca11e Initial load
duke
parents:
diff changeset
  1095
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1096
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
    /** Is given type a subtype of some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1098
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
    boolean subset(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1101
            if (types.isSubtype(t, l.head)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1103
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1104
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
    /** Is given type a subtype or supertype of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
     *  some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1107
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1108
    boolean intersects(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1109
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1110
            if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1111
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1112
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1113
06bc494ca11e Initial load
duke
parents:
diff changeset
  1114
    /** Add type set to given type list, unless it is a subclass of some class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1115
     *  in the list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1116
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1117
    List<Type> incl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1118
        return subset(t, ts) ? ts : excl(t, ts).prepend(t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1119
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1120
06bc494ca11e Initial load
duke
parents:
diff changeset
  1121
    /** Remove type set from type set list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1122
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1123
    List<Type> excl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1124
        if (ts.isEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1125
            return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1126
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1127
            List<Type> ts1 = excl(t, ts.tail);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1128
            if (types.isSubtype(ts.head, t)) return ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1129
            else if (ts1 == ts.tail) return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1130
            else return ts1.prepend(ts.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1131
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1132
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1133
06bc494ca11e Initial load
duke
parents:
diff changeset
  1134
    /** Form the union of two type set lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1135
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1136
    List<Type> union(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1137
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1138
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1139
            ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1140
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1141
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1142
06bc494ca11e Initial load
duke
parents:
diff changeset
  1143
    /** Form the difference of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1144
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1145
    List<Type> diff(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1146
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1147
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1148
            ts = excl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1149
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1150
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1151
06bc494ca11e Initial load
duke
parents:
diff changeset
  1152
    /** Form the intersection of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1153
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1154
    public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1155
        List<Type> ts = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1156
        for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
            if (subset(l.head, ts2)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1158
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
            if (subset(l.head, ts1)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1160
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1161
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1162
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
    /** Is exc an exception symbol that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
    boolean isUnchecked(ClassSymbol exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
            exc.kind == ERR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
            exc.isSubClass(syms.errorType.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
            exc.isSubClass(syms.runtimeExceptionType.tsym, types);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
    /** Is exc an exception type that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
    boolean isUnchecked(Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
            (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
            (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
            exc.tag == BOT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1180
06bc494ca11e Initial load
duke
parents:
diff changeset
  1181
    /** Same, but handling completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1182
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1183
    boolean isUnchecked(DiagnosticPosition pos, Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1184
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1185
            return isUnchecked(exc);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1186
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1187
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1188
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1189
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1190
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1191
06bc494ca11e Initial load
duke
parents:
diff changeset
  1192
    /** Is exc handled by given exception list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1193
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1194
    boolean isHandled(Type exc, List<Type> handled) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1195
        return isUnchecked(exc) || subset(exc, handled);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1196
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1197
06bc494ca11e Initial load
duke
parents:
diff changeset
  1198
    /** Return all exceptions in thrown list that are not in handled list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1199
     *  @param thrown     The list of thrown exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1200
     *  @param handled    The list of handled exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1201
     */
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1202
    List<Type> unhandled(List<Type> thrown, List<Type> handled) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1203
        List<Type> unhandled = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1204
        for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1205
            if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1206
        return unhandled;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1207
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1208
06bc494ca11e Initial load
duke
parents:
diff changeset
  1209
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1210
 * Overriding/Implementation checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1211
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1212
06bc494ca11e Initial load
duke
parents:
diff changeset
  1213
    /** The level of access protection given by a flag set,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1214
     *  where PRIVATE is highest and PUBLIC is lowest.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1215
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1216
    static int protection(long flags) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1217
        switch ((short)(flags & AccessFlags)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1218
        case PRIVATE: return 3;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1219
        case PROTECTED: return 1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1220
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1221
        case PUBLIC: return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1222
        case 0: return 2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1223
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1224
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1225
06bc494ca11e Initial load
duke
parents:
diff changeset
  1226
    /** A customized "cannot override" error message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1227
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1228
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1229
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1230
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1231
    Object cannotOverride(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1232
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1233
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1234
            key = "cant.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1235
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1236
            key = "cant.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1237
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1238
            key = "clashes.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1239
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1240
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1241
06bc494ca11e Initial load
duke
parents:
diff changeset
  1242
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1245
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1247
    Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1248
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1249
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1250
            key = "unchecked.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1251
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1252
            key = "unchecked.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1253
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
            key = "unchecked.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1255
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1263
    Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1265
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1266
            key = "varargs.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1267
        else  if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
            key = "varargs.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
            key = "varargs.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1271
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1272
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1273
06bc494ca11e Initial load
duke
parents:
diff changeset
  1274
    /** Check that this method conforms with overridden method 'other'.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1275
     *  where `origin' is the class where checking started.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1276
     *  Complications:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1277
     *  (1) Do not check overriding of synthetic methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1278
     *      (reason: they might be final).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1279
     *      todo: check whether this is still necessary.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1280
     *  (2) Admit the case where an interface proxy throws fewer exceptions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1281
     *      than the method it implements. Augment the proxy methods with the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1282
     *      undeclared exceptions in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1283
     *  (3) When generics are enabled, admit the case where an interface proxy
06bc494ca11e Initial load
duke
parents:
diff changeset
  1284
     *      has a result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1285
     *      extended by the result type of the method it implements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1286
     *      Change the proxies result type to the smaller type in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1287
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
     *  @param tree         The tree from which positions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1289
     *                      are extracted for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1290
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1291
     *  @param other        The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1292
     *  @param origin       The class of which the overriding method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1293
     *                      is a member.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1294
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1295
    void checkOverride(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1296
                       MethodSymbol m,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
                       MethodSymbol other,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
                       ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1299
        // Don't check overriding of synthetic methods or by bridge methods.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
        if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1301
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
        // Error if static method overrides instance method (JLS 8.4.6.2).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
        if ((m.flags() & STATIC) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
                   (other.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1307
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1308
                      cannotOverride(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1309
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1310
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1311
06bc494ca11e Initial load
duke
parents:
diff changeset
  1312
        // Error if instance method overrides static or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1313
        // method (JLS 8.4.6.1).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1314
        if ((other.flags() & FINAL) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1315
                 (m.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1316
                 (other.flags() & STATIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1317
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1318
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1319
                      asFlagSet(other.flags() & (FINAL | STATIC)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1320
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1321
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1322
06bc494ca11e Initial load
duke
parents:
diff changeset
  1323
        if ((m.owner.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1324
            // handled in validateAnnotationMethod
06bc494ca11e Initial load
duke
parents:
diff changeset
  1325
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
06bc494ca11e Initial load
duke
parents:
diff changeset
  1328
        // Error if overriding method has weaker access (JLS 8.4.6.3).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1329
        if ((origin.flags() & INTERFACE) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1330
                 protection(m.flags()) > protection(other.flags())) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1331
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1332
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1333
                      other.flags() == 0 ?
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1334
                          Flag.PACKAGE :
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1335
                          asFlagSet(other.flags() & AccessFlags));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1336
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1337
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1338
06bc494ca11e Initial load
duke
parents:
diff changeset
  1339
        Type mt = types.memberType(origin.type, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1340
        Type ot = types.memberType(origin.type, other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1341
        // Error if overriding result type is different
06bc494ca11e Initial load
duke
parents:
diff changeset
  1342
        // (or, in the case of generics mode, not a subtype) of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1343
        // overridden result type. We have to rename any type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  1344
        // before comparing types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1345
        List<Type> mtvars = mt.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1346
        List<Type> otvars = ot.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1347
        Type mtres = mt.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1348
        Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1349
06bc494ca11e Initial load
duke
parents:
diff changeset
  1350
        overrideWarner.warned = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
        boolean resultTypesOK =
1874
891c2d6823bb 6797463: 6557199 breaks the jax-ws workspace
tbell
parents: 1868
diff changeset
  1352
            types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1353
        if (!resultTypesOK) {
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1354
            if (!allowCovariantReturns &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1355
                m.owner != origin &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1356
                m.owner.isSubClass(other.owner, types)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1357
                // allow limited interoperability with covariant returns
06bc494ca11e Initial load
duke
parents:
diff changeset
  1358
            } else {
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1359
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1360
                          "override.incompatible.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1361
                          cannotOverride(m, other),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1362
                          mtres, otres);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1363
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1364
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1365
        } else if (overrideWarner.warned) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1367
                    "override.unchecked.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1368
                    uncheckedOverrides(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1369
                    mtres, otres);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1370
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1371
06bc494ca11e Initial load
duke
parents:
diff changeset
  1372
        // Error if overriding method throws an exception not reported
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
        // by overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1374
        List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1375
        List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1376
        List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1377
        if (unhandledErased.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1378
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
                      "override.meth.doesnt.throw",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1380
                      cannotOverride(m, other),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1381
                      unhandledUnerased.head);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1382
            return;
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1383
        }
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1384
        else if (unhandledUnerased.nonEmpty()) {
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1385
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1386
                          "override.unchecked.thrown",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1387
                         cannotOverride(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1388
                         unhandledUnerased.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1389
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
06bc494ca11e Initial load
duke
parents:
diff changeset
  1392
        // Optional warning if varargs don't agree
06bc494ca11e Initial load
duke
parents:
diff changeset
  1393
        if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1394
            && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1395
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1396
                        ((m.flags() & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1397
                        ? "override.varargs.missing"
06bc494ca11e Initial load
duke
parents:
diff changeset
  1398
                        : "override.varargs.extra",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1399
                        varargsOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1400
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1401
06bc494ca11e Initial load
duke
parents:
diff changeset
  1402
        // Warn if instance method overrides bridge method (compiler spec ??)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1403
        if ((other.flags() & BRIDGE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1404
            log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1405
                        uncheckedOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1406
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1407
06bc494ca11e Initial load
duke
parents:
diff changeset
  1408
        // Warn if a deprecated method overridden by a non-deprecated one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1409
        if ((other.flags() & DEPRECATED) != 0
06bc494ca11e Initial load
duke
parents:
diff changeset
  1410
            && (m.flags() & DEPRECATED) == 0
06bc494ca11e Initial load
duke
parents:
diff changeset
  1411
            && m.outermostClass() != other.outermostClass()
06bc494ca11e Initial load
duke
parents:
diff changeset
  1412
            && !isDeprecatedOverrideIgnorable(other, origin)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1413
            warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1414
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1415
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1416
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1417
        private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1418
            // If the method, m, is defined in an interface, then ignore the issue if the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1419
            // is only inherited via a supertype and also implemented in the supertype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1420
            // because in that case, we will rediscover the issue when examining the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1421
            // in the supertype.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1422
            // If the method, m, is not defined in an interface, then the only time we need to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1423
            // address the issue is when the method is the supertype implemementation: any other
06bc494ca11e Initial load
duke
parents:
diff changeset
  1424
            // case, we will have dealt with when examining the supertype classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1425
            ClassSymbol mc = m.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1426
            Type st = types.supertype(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1427
            if (st.tag != CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1428
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1429
            MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1430
06bc494ca11e Initial load
duke
parents:
diff changeset
  1431
            if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1432
                List<Type> intfs = types.interfaces(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1433
                return (intfs.contains(mc.type) ? false : (stimpl != null));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1434
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1435
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1436
                return (stimpl != m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1437
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1438
06bc494ca11e Initial load
duke
parents:
diff changeset
  1439
06bc494ca11e Initial load
duke
parents:
diff changeset
  1440
    // used to check if there were any unchecked conversions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1441
    Warner overrideWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1442
06bc494ca11e Initial load
duke
parents:
diff changeset
  1443
    /** Check that a class does not inherit two concrete methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1444
     *  with the same signature.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1445
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1446
     *  @param site         The class type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1447
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1448
    public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1449
        Type sup = types.supertype(site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1450
        if (sup.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1451
06bc494ca11e Initial load
duke
parents:
diff changeset
  1452
        for (Type t1 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1453
             t1.tsym.type.isParameterized();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1454
             t1 = types.supertype(t1)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1455
            for (Scope.Entry e1 = t1.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1456
                 e1 != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1457
                 e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1458
                Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1459
                if (s1.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1460
                    (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1461
                    !s1.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1462
                    ((MethodSymbol)s1).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1463
                                                      types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1464
                                                      true) != s1)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1465
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1466
                Type st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1467
                int s1ArgsLength = st1.getParameterTypes().length();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1468
                if (st1 == s1.type) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
                for (Type t2 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
                     t2.tag == CLASS;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
                     t2 = types.supertype(t2)) {
508
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1473
                    for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
                         e2.scope != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
                         e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
                        Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
                        if (s2 == s1 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
                            s2.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1479
                            (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
                            s2.type.getParameterTypes().length() != s1ArgsLength ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1481
                            !s2.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1482
                            ((MethodSymbol)s2).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1483
                                                              types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1484
                                                              true) != s2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1485
                            continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1486
                        Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1487
                        if (types.overrideEquivalent(st1, st2))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
                            log.error(pos, "concrete.inheritance.conflict",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1489
                                      s1, t1, s2, t2, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1490
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1491
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1492
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1493
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1494
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1495
06bc494ca11e Initial load
duke
parents:
diff changeset
  1496
    /** Check that classes (or interfaces) do not each define an abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1497
     *  method with same name and arguments but incompatible return types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1498
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1499
     *  @param t1           The first argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1500
     *  @param t2           The second argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1501
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1502
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1503
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1504
                                            Type t2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1505
        return checkCompatibleAbstracts(pos, t1, t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1506
                                        types.makeCompoundType(t1, t2));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1507
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1508
06bc494ca11e Initial load
duke
parents:
diff changeset
  1509
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1510
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1511
                                            Type t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1512
                                            Type site) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1513
        return firstIncompatibility(pos, t1, t2, site) == null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1514
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1515
06bc494ca11e Initial load
duke
parents:
diff changeset
  1516
    /** Return the first method which is defined with same args
06bc494ca11e Initial load
duke
parents:
diff changeset
  1517
     *  but different return types in two given interfaces, or null if none
06bc494ca11e Initial load
duke
parents:
diff changeset
  1518
     *  exists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1519
     *  @param t1     The first type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1520
     *  @param t2     The second type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1521
     *  @param site   The most derived type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1522
     *  @returns symbol from t2 that conflicts with one in t1.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1523
     */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1524
    private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
        Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
        closure(t1, interfaces1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
        Map<TypeSymbol,Type> interfaces2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
        if (t1 == t2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
            interfaces2 = interfaces1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
            closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
        for (Type t3 : interfaces1.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
            for (Type t4 : interfaces2.values()) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1535
                Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1536
                if (s != null) return s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1537
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1538
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1539
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1540
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1541
06bc494ca11e Initial load
duke
parents:
diff changeset
  1542
    /** Compute all the supertypes of t, indexed by type symbol. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1543
    private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1544
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1545
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1546
            closure(types.supertype(t), typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1547
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1548
                closure(i, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1549
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1550
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
    /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
    private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1555
        if (typesSkip.get(t.tsym) != null) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1556
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1557
            closure(types.supertype(t), typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1558
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1559
                closure(i, typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
    /** Return the first method in t2 that conflicts with a method from t1. */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1564
    private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
        for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
            Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
            Type st1 = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
            if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1569
            Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
            if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
            for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
                Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
                if (s1 == s2) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
                if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
                if (st1 == null) st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
                Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
                if (types.overrideEquivalent(st1, st2)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
                    List<Type> tvars1 = st1.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
                    List<Type> tvars2 = st2.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
                    Type rt1 = st1.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
                    Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
                    boolean compat =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
                        types.isSameType(rt1, rt2) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
                        rt1.tag >= CLASS && rt2.tag >= CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
                        (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1586
                         types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1587
                         checkCommonOverriderIn(s1,s2,site);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1588
                    if (!compat) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1589
                        log.error(pos, "types.incompatible.diff.ret",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1590
                            t1, t2, s2.name +
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1591
                            "(" + types.memberType(t2, s2).getParameterTypes() + ")");
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1592
                        return s2;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1593
                    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1594
                } else if (!checkNameClash((ClassSymbol)site.tsym, s1, s2)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1595
                    log.error(pos,
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1596
                            "name.clash.same.erasure.no.override",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1597
                            s1, s1.location(),
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1598
                            s2, s2.location());
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1599
                    return s2;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1600
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1601
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1602
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1603
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
    }
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1605
    //WHERE
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1606
    boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1607
        Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1608
        Type st1 = types.memberType(site, s1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1609
        Type st2 = types.memberType(site, s2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1610
        closure(site, supertypes);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1611
        for (Type t : supertypes.values()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1612
            for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1613
                Symbol s3 = e.sym;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1614
                if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1615
                Type st3 = types.memberType(site,s3);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1616
                if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1617
                    if (s3.owner == site.tsym) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1618
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1619
                    }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1620
                    List<Type> tvars1 = st1.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1621
                    List<Type> tvars2 = st2.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1622
                    List<Type> tvars3 = st3.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1623
                    Type rt1 = st1.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1624
                    Type rt2 = st2.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1625
                    Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1626
                    Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1627
                    boolean compat =
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1628
                        rt13.tag >= CLASS && rt23.tag >= CLASS &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1629
                        (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1630
                         types.covariantReturnType(rt23, rt2, Warner.noWarnings));
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1631
                    if (compat)
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1632
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1633
                }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1634
            }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1635
        }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1636
        return false;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1637
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1638
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
    /** Check that a given method conforms with any method it overrides.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1640
     *  @param tree         The tree from which positions are extracted
06bc494ca11e Initial load
duke
parents:
diff changeset
  1641
     *                      for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1642
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1644
    void checkOverride(JCTree tree, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
        ClassSymbol origin = (ClassSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
        if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1647
            if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1648
                log.error(tree.pos(), "enum.no.finalize");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1649
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1650
            }
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1651
        for (Type t = origin.type; t.tag == CLASS;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1652
             t = types.supertype(t)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1653
            if (t != origin.type) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1654
                checkOverride(tree, t, origin, m);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1655
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1656
            for (Type t2 : types.interfaces(t)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1657
                checkOverride(tree, t2, origin, m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1658
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1659
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1660
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1662
    void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1663
        TypeSymbol c = site.tsym;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1664
        Scope.Entry e = c.members().lookup(m.name);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1665
        while (e.scope != null) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1666
            if (m.overrides(e.sym, origin, types, false)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1667
                if ((e.sym.flags() & ABSTRACT) == 0) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1668
                    checkOverride(tree, m, (MethodSymbol)e.sym, origin);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1669
                }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1670
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1671
            e = e.next();
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1672
        }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1673
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1674
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1675
    private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1676
        if (s1.kind == MTH &&
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1677
                    s1.isInheritedIn(origin, types) &&
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1678
                    (s1.flags() & SYNTHETIC) == 0 &&
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1679
                    !s2.isConstructor()) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1680
            Type er1 = s2.erasure(types);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1681
            Type er2 = s1.erasure(types);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1682
            if (types.isSameTypes(er1.getParameterTypes(),
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1683
                    er2.getParameterTypes())) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1684
                    return false;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1685
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1686
        }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1687
        return true;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1688
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1689
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1690
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
    /** Check that all abstract members of given class have definitions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1692
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
     *  @param c            The class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1694
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
    void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
            MethodSymbol undef = firstUndef(c, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1698
            if (undef != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1699
                if ((c.flags() & ENUM) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
                    types.supertype(c.type).tsym == syms.enumSym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1701
                    (c.flags() & FINAL) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1702
                    // add the ABSTRACT flag to an enum
06bc494ca11e Initial load
duke
parents:
diff changeset
  1703
                    c.flags_field |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1704
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
                    MethodSymbol undef1 =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
                        new MethodSymbol(undef.flags(), undef.name,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1707
                                         types.memberType(c.type, undef), undef.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1708
                    log.error(pos, "does.not.override.abstract",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1709
                              c, undef1, undef1.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1710
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1711
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
        /** Return first abstract member of class `c' that is not defined
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
         *  in `impl', null if there is none.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1719
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
        private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
            MethodSymbol undef = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
            // Do not bother to search in classes that are not abstract,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
            // since they cannot have abstract members.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1724
            if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1725
                Scope s = c.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1726
                for (Scope.Entry e = s.elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1727
                     undef == null && e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1728
                     e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1729
                    if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1730
                        (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1731
                        MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1732
                        MethodSymbol implmeth = absmeth.implementation(impl, types, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
                        if (implmeth == null || implmeth == absmeth)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1734
                            undef = absmeth;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1735
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1736
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1737
                if (undef == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1738
                    Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
                    if (st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1740
                        undef = firstUndef(impl, (ClassSymbol)st.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1741
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1742
                for (List<Type> l = types.interfaces(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1743
                     undef == null && l.nonEmpty();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1744
                     l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
                    undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1746
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1747
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1748
            return undef;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1749
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1750
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1751
    void checkNonCyclicDecl(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1752
        CycleChecker cc = new CycleChecker();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1753
        cc.scan(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1754
        if (!cc.errorFound && !cc.partialCheck) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1755
            tree.sym.flags_field |= ACYCLIC;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1756
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1757
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1758
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1759
    class CycleChecker extends TreeScanner {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1760
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1761
        List<Symbol> seenClasses = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1762
        boolean errorFound = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1763
        boolean partialCheck = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1764
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1765
        private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1766
            if (sym != null && sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1767
                Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1768
                if (classEnv != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1769
                    DiagnosticSource prevSource = log.currentSource();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1770
                    try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1771
                        log.useSource(classEnv.toplevel.sourcefile);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1772
                        scan(classEnv.tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1773
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1774
                    finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1775
                        log.useSource(prevSource.getFile());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1776
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1777
                } else if (sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1778
                    checkClass(pos, sym, List.<JCTree>nil());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1779
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1780
            } else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1781
                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1782
                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1783
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1784
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1785
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1786
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1787
        public void visitSelect(JCFieldAccess tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1788
            super.visitSelect(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1789
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1790
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1791
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1792
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1793
        public void visitIdent(JCIdent tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1794
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1795
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1796
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1797
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1798
        public void visitTypeApply(JCTypeApply tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1799
            scan(tree.clazz);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1800
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1801
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1802
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1803
        public void visitTypeArray(JCArrayTypeTree tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1804
            scan(tree.elemtype);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1805
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1806
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1807
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1808
        public void visitClassDef(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1809
            List<JCTree> supertypes = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1810
            if (tree.getExtendsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1811
                supertypes = supertypes.prepend(tree.getExtendsClause());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1812
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1813
            if (tree.getImplementsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1814
                for (JCTree intf : tree.getImplementsClause()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1815
                    supertypes = supertypes.prepend(intf);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1816
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1817
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1818
            checkClass(tree.pos(), tree.sym, supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1819
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1820
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1821
        void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1822
            if ((c.flags_field & ACYCLIC) != 0)
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1823
                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1824
            if (seenClasses.contains(c)) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1825
                errorFound = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1826
                noteCyclic(pos, (ClassSymbol)c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1827
            } else if (!c.type.isErroneous()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1828
                try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1829
                    seenClasses = seenClasses.prepend(c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1830
                    if (c.type.tag == CLASS) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1831
                        if (supertypes.nonEmpty()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1832
                            scan(supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1833
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1834
                        else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1835
                            ClassType ct = (ClassType)c.type;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1836
                            if (ct.supertype_field == null ||
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1837
                                    ct.interfaces_field == null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1838
                                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1839
                                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1840
                                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1841
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1842
                            checkSymbol(pos, ct.supertype_field.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1843
                            for (Type intf : ct.interfaces_field) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1844
                                checkSymbol(pos, intf.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1845
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1846
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1847
                        if (c.owner.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1848
                            checkSymbol(pos, c.owner);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1849
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1850
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1851
                } finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1852
                    seenClasses = seenClasses.tail;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1853
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1854
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1855
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1856
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  1857
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1859
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1860
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1861
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1862
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1863
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1864
    void checkNonCyclic(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1865
        checkNonCyclicInternal(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1866
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1867
06bc494ca11e Initial load
duke
parents:
diff changeset
  1868
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
    void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1870
        checkNonCyclic1(pos, t, List.<TypeVar>nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1871
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1872
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1873
    private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1874
        final TypeVar tv;
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1875
        if  (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1876
            return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1877
        if (seen.contains(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1878
            tv = (TypeVar)t;
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1879
            tv.bound = types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
            log.error(pos, "cyclic.inheritance", t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1881
        } else if (t.tag == TYPEVAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1882
            tv = (TypeVar)t;
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1883
            seen = seen.prepend(tv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1884
            for (Type b : types.getBounds(tv))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1885
                checkNonCyclic1(pos, b, seen);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1886
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1887
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1890
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1891
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
     *  @returns        True if the check completed on all attributed classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
    private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1897
        boolean complete = true; // was the check complete?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1898
        //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  1899
        Symbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1900
        if ((c.flags_field & ACYCLIC) != 0) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1901
06bc494ca11e Initial load
duke
parents:
diff changeset
  1902
        if ((c.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1903
            noteCyclic(pos, (ClassSymbol)c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1904
        } else if (!c.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1905
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1906
                c.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1907
                if (c.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1908
                    ClassType clazz = (ClassType)c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1909
                    if (clazz.interfaces_field != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1910
                        for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1911
                            complete &= checkNonCyclicInternal(pos, l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1912
                    if (clazz.supertype_field != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1913
                        Type st = clazz.supertype_field;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1914
                        if (st != null && st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1915
                            complete &= checkNonCyclicInternal(pos, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1917
                    if (c.owner.kind == TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1918
                        complete &= checkNonCyclicInternal(pos, c.owner.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1919
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1920
            } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1921
                c.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1922
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1923
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1924
        if (complete)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1925
            complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1926
        if (complete) c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1927
        return complete;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
06bc494ca11e Initial load
duke
parents:
diff changeset
  1930
    /** Note that we found an inheritance cycle. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1931
    private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
        log.error(pos, "cyclic.inheritance", c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1933
        for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1934
            l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
        Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1936
        if (st.tag == CLASS)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1937
            ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1938
        c.type = types.createErrorType(c, c.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1939
        c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1940
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1941
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
    /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
     *  method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1944
     *  @param tree         The class definition whose members are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1945
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1946
    void checkImplementations(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
        checkImplementations(tree, tree.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1949
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1950
        /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  1951
         *  method in `ic' conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1952
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1953
        void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1954
            ClassSymbol origin = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1955
            for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1956
                ClassSymbol lc = (ClassSymbol)l.head.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1957
                if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1958
                    for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1959
                        if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1960
                            (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1961
                            MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1962
                            MethodSymbol implmeth = absmeth.implementation(origin, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1963
                            if (implmeth != null && implmeth != absmeth &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1964
                                (implmeth.owner.flags() & INTERFACE) ==
06bc494ca11e Initial load
duke
parents:
diff changeset
  1965
                                (origin.flags() & INTERFACE)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
                                // don't check if implmeth is in a class, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
  1967
                                // origin is an interface. This case arises only
06bc494ca11e Initial load
duke
parents:
diff changeset
  1968
                                // if implmeth is declared in Object. The reason is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
                                // that interfaces really don't inherit from
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
                                // Object it's just that the compiler represents
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
                                // things that way.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
                                checkOverride(tree, implmeth, absmeth, origin);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
                            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1975
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1978
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1979
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
    /** Check that all abstract methods implemented by a class are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1981
     *  mutually compatible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1982
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
     *  @param c            The class whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1985
    void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1986
        List<Type> supertypes = types.interfaces(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1987
        Type supertype = types.supertype(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1988
        if (supertype.tag == CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
            (supertype.tsym.flags() & ABSTRACT) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
            supertypes = supertypes.prepend(supertype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1992
            if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
                !checkCompatibleAbstracts(pos, l.head, l.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1995
            for (List<Type> m = supertypes; m != l; m = m.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1996
                if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1997
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1998
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1999
        checkCompatibleConcretes(pos, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2000
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2001
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2002
    void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2003
        for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2004
            for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2005
                // VM allows methods and variables with differing types
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2006
                if (sym.kind == e.sym.kind &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2007
                    types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2008
                    sym != e.sym &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2009
                    (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
6147
0074061d0efd 6964669: javac reports error on miranda methods
mcimadamore
parents: 6032
diff changeset
  2010
                    (sym.flags() & IPROXY) == 0 && (e.sym.flags() & IPROXY) == 0 &&
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2011
                    (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2012
                    syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2013
                    return;
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2014
                }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2015
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2016
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2017
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2018
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2019
    /** Check that all non-override equivalent methods accessible from 'site'
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2020
     *  are mutually compatible (JLS 8.4.8/9.4.1).
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2021
     *
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2022
     *  @param pos  Position to be used for error reporting.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2023
     *  @param site The class whose methods are checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2024
     *  @param sym  The method symbol to be checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2025
     */
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2026
    void checkClashes(DiagnosticPosition pos, Type site, Symbol sym) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2027
        List<Type> supertypes = types.closure(site);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2028
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2029
            for (List<Type> m = supertypes; m.nonEmpty(); m = m.tail) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2030
                checkClashes(pos, l.head, m.head, site, sym);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2031
            }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2032
        }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2033
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2034
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2035
    /** Reports an error whenever 'sym' seen as a member of type 't1' clashes with
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2036
     *  some unrelated method defined in 't2'.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2037
     */
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2038
    private void checkClashes(DiagnosticPosition pos, Type t1, Type t2, Type site, Symbol s1) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2039
        ClashFilter cf = new ClashFilter(site);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2040
        s1 = ((MethodSymbol)s1).implementedIn(t1.tsym, types);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2041
        if (s1 == null) return;
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2042
        Type st1 = types.memberType(site, s1);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2043
        for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name, cf); e2.scope != null; e2 = e2.next(cf)) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2044
            Symbol s2 = e2.sym;
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2045
            if (s1 == s2) continue;
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2046
            Type st2 = types.memberType(site, s2);
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2047
            if (!types.overrideEquivalent(st1, st2) &&
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2048
                    !checkNameClash((ClassSymbol)site.tsym, s1, s2)) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2049
                log.error(pos,
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2050
                        "name.clash.same.erasure.no.override",
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2051
                        s1, s1.location(),
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2052
                        s2, s2.location());
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2053
            }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2054
        }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2055
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2056
    //where
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2057
    private class ClashFilter implements Filter<Symbol> {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2058
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2059
        Type site;
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2060
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2061
        ClashFilter(Type site) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2062
            this.site = site;
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2063
        }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2064
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2065
        public boolean accepts(Symbol s) {
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2066
            return s.kind == MTH &&
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2067
                    (s.flags() & SYNTHETIC) == 0 &&
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2068
                    s.isInheritedIn(site.tsym, types) &&
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2069
                    !s.isConstructor();
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2070
        }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2071
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2072
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2073
    /** Report a conflict between a user symbol and a synthetic symbol.
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2074
     */
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2075
    private void syntheticError(DiagnosticPosition pos, Symbol sym) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2076
        if (!sym.type.isErroneous()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2077
            if (warnOnSyntheticConflicts) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2078
                log.warning(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2079
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2080
            else {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2081
                log.error(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2082
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2083
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2084
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2085
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2086
    /** Check that class c does not implement directly or indirectly
06bc494ca11e Initial load
duke
parents:
diff changeset
  2087
     *  the same parameterized interface with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2088
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2089
     *  @param type         The type whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2090
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2091
    void checkClassBounds(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2092
        checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2093
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2094
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2095
        /** Enter all interfaces of type `type' into the hash table `seensofar'
06bc494ca11e Initial load
duke
parents:
diff changeset
  2096
         *  with their class symbol as key and their type as value. Make
06bc494ca11e Initial load
duke
parents:
diff changeset
  2097
         *  sure no class is entered with two different types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2098
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2099
        void checkClassBounds(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2100
                              Map<TypeSymbol,Type> seensofar,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2101
                              Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2102
            if (type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2103
            for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2104
                Type it = l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2105
                Type oldit = seensofar.put(it.tsym, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2106
                if (oldit != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2107
                    List<Type> oldparams = oldit.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2108
                    List<Type> newparams = it.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2109
                    if (!types.containsTypeEquivalent(oldparams, newparams))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2110
                        log.error(pos, "cant.inherit.diff.arg",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2111
                                  it.tsym, Type.toString(oldparams),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2112
                                  Type.toString(newparams));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2113
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2114
                checkClassBounds(pos, seensofar, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2115
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2116
            Type st = types.supertype(type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2117
            if (st != null) checkClassBounds(pos, seensofar, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2118
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2119
06bc494ca11e Initial load
duke
parents:
diff changeset
  2120
    /** Enter interface into into set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2121
     *  If it existed already, issue a "repeated interface" error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2122
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2123
    void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2124
        if (its.contains(it))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2125
            log.error(pos, "repeated.interface");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2126
        else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2127
            its.add(it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2128
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2129
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2130
06bc494ca11e Initial load
duke
parents:
diff changeset
  2131
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2132
 * Check annotations
06bc494ca11e Initial load
duke
parents:
diff changeset
  2133
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2134
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2135
    /**
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2136
     * Recursively validate annotations values
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2137
     */
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2138
    void validateAnnotationTree(JCTree tree) {
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2139
        class AnnotationValidator extends TreeScanner {
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2140
            @Override
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2141
            public void visitAnnotation(JCAnnotation tree) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2142
                super.visitAnnotation(tree);
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2143
                validateAnnotation(tree);
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2144
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2145
        }
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2146
        tree.accept(new AnnotationValidator());
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2147
    }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2148
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2149
    /** Annotation types are restricted to primitives, String, an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2150
     *  enum, an annotation, Class, Class<?>, Class<? extends
06bc494ca11e Initial load
duke
parents:
diff changeset
  2151
     *  Anything>, arrays of the preceding.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2152
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2153
    void validateAnnotationType(JCTree restype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2154
        // restype may be null if an error occurred, so don't bother validating it
06bc494ca11e Initial load
duke
parents:
diff changeset
  2155
        if (restype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2156
            validateAnnotationType(restype.pos(), restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2157
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2158
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2159
06bc494ca11e Initial load
duke
parents:
diff changeset
  2160
    void validateAnnotationType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2161
        if (type.isPrimitive()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2162
        if (types.isSameType(type, syms.stringType)) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2163
        if ((type.tsym.flags() & Flags.ENUM) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2164
        if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2165
        if (types.lowerBound(type).tsym == syms.classType.tsym) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2166
        if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2167
            validateAnnotationType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2168
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2169
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2170
        log.error(pos, "invalid.annotation.member.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2171
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2172
06bc494ca11e Initial load
duke
parents:
diff changeset
  2173
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2174
     * "It is also a compile-time error if any method declared in an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2175
     * annotation type has a signature that is override-equivalent to
06bc494ca11e Initial load
duke
parents:
diff changeset
  2176
     * that of any public or protected method declared in class Object
06bc494ca11e Initial load
duke
parents:
diff changeset
  2177
     * or in the interface annotation.Annotation."
06bc494ca11e Initial load
duke
parents:
diff changeset
  2178
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2179
     * @jls3 9.6 Annotation Types
06bc494ca11e Initial load
duke
parents:
diff changeset
  2180
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2181
    void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2182
        for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2183
            Scope s = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2184
            for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2185
                if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2186
                    (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2187
                    types.overrideEquivalent(m.type, e.sym.type))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2188
                    log.error(pos, "intf.annotation.member.clash", e.sym, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2189
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2190
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2191
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2192
06bc494ca11e Initial load
duke
parents:
diff changeset
  2193
    /** Check the annotations of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2194
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2195
    public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2196
        if (skipAnnotations) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2197
        for (JCAnnotation a : annotations)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2198
            validateAnnotation(a, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2199
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2200
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2201
    /** Check the type annotations
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2202
     */
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2203
    public void validateTypeAnnotations(List<JCTypeAnnotation> annotations, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2204
        if (skipAnnotations) return;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2205
        for (JCTypeAnnotation a : annotations)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2206
            validateTypeAnnotation(a, isTypeParameter);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2207
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2208
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2209
    /** Check an annotation of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2210
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2211
    public void validateAnnotation(JCAnnotation a, Symbol s) {
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2212
        validateAnnotationTree(a);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2213
06bc494ca11e Initial load
duke
parents:
diff changeset
  2214
        if (!annotationApplicable(a, s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2215
            log.error(a.pos(), "annotation.type.not.applicable");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2216
06bc494ca11e Initial load
duke
parents:
diff changeset
  2217
        if (a.annotationType.type.tsym == syms.overrideType.tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2218
            if (!isOverrider(s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2219
                log.error(a.pos(), "method.does.not.override.superclass");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2220
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2221
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2222
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2223
    public void validateTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2224
        if (a.type == null)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2225
            throw new AssertionError("annotation tree hasn't been attributed yet: " + a);
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2226
        validateAnnotationTree(a);
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2227
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2228
        if (!isTypeAnnotation(a, isTypeParameter))
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2229
            log.error(a.pos(), "annotation.type.not.applicable");
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2230
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2231
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2232
    /** Is s a method symbol that overrides a method in a superclass? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2233
    boolean isOverrider(Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2234
        if (s.kind != MTH || s.isStatic())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2235
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2236
        MethodSymbol m = (MethodSymbol)s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2237
        TypeSymbol owner = (TypeSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2238
        for (Type sup : types.closure(owner.type)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2239
            if (sup == owner.type)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2240
                continue; // skip "this"
06bc494ca11e Initial load
duke
parents:
diff changeset
  2241
            Scope scope = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2242
            for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2243
                if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2244
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2245
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2246
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2247
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2248
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2249
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2250
    /** Is the annotation applicable to type annotations */
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2251
    boolean isTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2252
        Attribute.Compound atTarget =
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2253
            a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2254
        if (atTarget == null) return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2255
        Attribute atValue = atTarget.member(names.value);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2256
        if (!(atValue instanceof Attribute.Array)) return true; // error recovery
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2257
        Attribute.Array arr = (Attribute.Array) atValue;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2258
        for (Attribute app : arr.values) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2259
            if (!(app instanceof Attribute.Enum)) return true; // recovery
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2260
            Attribute.Enum e = (Attribute.Enum) app;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2261
            if (!isTypeParameter && e.value.name == names.TYPE_USE)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2262
                return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2263
            else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2264
                return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2265
        }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2266
        return false;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2267
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2268
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2269
    /** Is the annotation applicable to the symbol? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2270
    boolean annotationApplicable(JCAnnotation a, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2271
        Attribute.Compound atTarget =
06bc494ca11e Initial load
duke
parents:
diff changeset
  2272
            a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2273
        if (atTarget == null) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2274
        Attribute atValue = atTarget.member(names.value);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2275
        if (!(atValue instanceof Attribute.Array)) return true; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2276
        Attribute.Array arr = (Attribute.Array) atValue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2277
        for (Attribute app : arr.values) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2278
            if (!(app instanceof Attribute.Enum)) return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2279
            Attribute.Enum e = (Attribute.Enum) app;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2280
            if (e.value.name == names.TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2281
                { if (s.kind == TYP) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2282
            else if (e.value.name == names.FIELD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2283
                { if (s.kind == VAR && s.owner.kind != MTH) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2284
            else if (e.value.name == names.METHOD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2285
                { if (s.kind == MTH && !s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2286
            else if (e.value.name == names.PARAMETER)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2287
                { if (s.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2288
                      s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2289
                      (s.flags() & PARAMETER) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2290
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2291
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2292
            else if (e.value.name == names.CONSTRUCTOR)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2293
                { if (s.kind == MTH && s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2294
            else if (e.value.name == names.LOCAL_VARIABLE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2295
                { if (s.kind == VAR && s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2296
                      (s.flags() & PARAMETER) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2297
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2298
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2299
            else if (e.value.name == names.ANNOTATION_TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2300
                { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2301
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2302
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2303
            else if (e.value.name == names.PACKAGE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
                { if (s.kind == PCK) return true; }
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2305
            else if (e.value.name == names.TYPE_USE)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2306
                { if (s.kind == TYP ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2307
                      s.kind == VAR ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2308
                      (s.kind == MTH && !s.isConstructor() &&
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2309
                       s.type.getReturnType().tag != VOID))
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2310
                    return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2311
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2312
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2313
                return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2314
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2315
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2316
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2317
06bc494ca11e Initial load
duke
parents:
diff changeset
  2318
    /** Check an annotation value.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2319
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2320
    public void validateAnnotation(JCAnnotation a) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2321
        if (a.type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2322
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2323
        // collect an inventory of the members (sorted alphabetically)
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2324
        Set<MethodSymbol> members = new TreeSet<MethodSymbol>(new Comparator<Symbol>() {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2325
            public int compare(Symbol t, Symbol t1) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2326
                return t.name.compareTo(t1.name);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2327
            }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2328
        });
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2329
        for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2330
             e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2331
             e = e.sibling)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2332
            if (e.sym.kind == MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2333
                members.add((MethodSymbol) e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2334
06bc494ca11e Initial load
duke
parents:
diff changeset
  2335
        // count them off as they're annotated
06bc494ca11e Initial load
duke
parents:
diff changeset
  2336
        for (JCTree arg : a.args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2337
            if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2338
            JCAssign assign = (JCAssign) arg;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2339
            Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2340
            if (m == null || m.type.isErroneous()) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2341
            if (!members.remove(m))
4867
7f4efc9b2f9f 6919944: incorrect position given for duplicate annotation value error
jjg
parents: 3780
diff changeset
  2342
                log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2343
                          m.name, a.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2345
06bc494ca11e Initial load
duke
parents:
diff changeset
  2346
        // all the remaining ones better have default values
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2347
        ListBuffer<Name> missingDefaults = ListBuffer.lb();
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2348
        for (MethodSymbol m : members) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2349
            if (m.defaultValue == null && !m.type.isErroneous()) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2350
                missingDefaults.append(m.name);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2351
            }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2352
        }
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2353
        if (missingDefaults.nonEmpty()) {
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2354
            String key = (missingDefaults.size() > 1)
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2355
                    ? "annotation.missing.default.value.1"
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2356
                    : "annotation.missing.default.value";
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2357
            log.error(a.pos(), key, a.type, missingDefaults);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  2358
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2359
06bc494ca11e Initial load
duke
parents:
diff changeset
  2360
        // special case: java.lang.annotation.Target must not have
06bc494ca11e Initial load
duke
parents:
diff changeset
  2361
        // repeated values in its value member
06bc494ca11e Initial load
duke
parents:
diff changeset
  2362
        if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  2363
            a.args.tail == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2364
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2365
06bc494ca11e Initial load
duke
parents:
diff changeset
  2366
        if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2367
        JCAssign assign = (JCAssign) a.args.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2368
        Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2369
        if (m.name != names.value) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2370
        JCTree rhs = assign.rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2371
        if (rhs.getTag() != JCTree.NEWARRAY) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2372
        JCNewArray na = (JCNewArray) rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2373
        Set<Symbol> targets = new HashSet<Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2374
        for (JCTree elem : na.elems) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2375
            if (!targets.add(TreeInfo.symbol(elem))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2376
                log.error(elem.pos(), "repeated.annotation.target");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2377
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2378
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2379
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2380
06bc494ca11e Initial load
duke
parents:
diff changeset
  2381
    void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2382
        if (allowAnnotations &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2383
            lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2384
            (s.flags() & DEPRECATED) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2385
            !syms.deprecatedType.isErroneous() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2386
            s.attribute(syms.deprecatedType.tsym) == null) {
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  2387
            log.warning(Lint.LintCategory.DEP_ANN,
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  2388
                    pos, "missing.deprecated.annotation");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2389
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2390
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2391
06bc494ca11e Initial load
duke
parents:
diff changeset
  2392
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2393
 * Check for recursive annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2394
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2395
06bc494ca11e Initial load
duke
parents:
diff changeset
  2396
    /** Check for cycles in the graph of annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2397
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2398
    void checkNonCyclicElements(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2399
        if ((tree.sym.flags_field & ANNOTATION) == 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2400
        assert (tree.sym.flags_field & LOCKED) == 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2401
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2402
            tree.sym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2403
            for (JCTree def : tree.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2404
                if (def.getTag() != JCTree.METHODDEF) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2405
                JCMethodDecl meth = (JCMethodDecl)def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2406
                checkAnnotationResType(meth.pos(), meth.restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2407
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2408
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2409
            tree.sym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2410
            tree.sym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2411
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2412
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2413
06bc494ca11e Initial load
duke
parents:
diff changeset
  2414
    void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2415
        if ((tsym.flags_field & ACYCLIC_ANN) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2416
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2417
        if ((tsym.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2418
            log.error(pos, "cyclic.annotation.element");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2419
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2420
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2421
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2422
            tsym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2423
            for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2424
                Symbol s = e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2425
                if (s.kind != Kinds.MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2426
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2427
                checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  2428
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2429
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2430
            tsym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2431
            tsym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2432
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2433
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2434
06bc494ca11e Initial load
duke
parents:
diff changeset
  2435
    void checkAnnotationResType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2436
        switch (type.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2437
        case TypeTags.CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2438
            if ((type.tsym.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2439
                checkNonCyclicElementsInternal(pos, type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2440
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2441
        case TypeTags.ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2442
            checkAnnotationResType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2443
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2444
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2445
            break; // int etc
06bc494ca11e Initial load
duke
parents:
diff changeset
  2446
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2447
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2448
06bc494ca11e Initial load
duke
parents:
diff changeset
  2449
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2450
 * Check for cycles in the constructor call graph.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2451
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2452
06bc494ca11e Initial load
duke
parents:
diff changeset
  2453
    /** Check for cycles in the graph of constructors calling other
06bc494ca11e Initial load
duke
parents:
diff changeset
  2454
     *  constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2455
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2456
    void checkCyclicConstructors(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2457
        Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2458
06bc494ca11e Initial load
duke
parents:
diff changeset
  2459
        // enter each constructor this-call into the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2460
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2461
            JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2462
            if (app == null) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2463
            JCMethodDecl meth = (JCMethodDecl) l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2464
            if (TreeInfo.name(app.meth) == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2465
                callMap.put(meth.sym, TreeInfo.symbol(app.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2466
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2467
                meth.sym.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2468
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2469
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2470
06bc494ca11e Initial load
duke
parents:
diff changeset
  2471
        // Check for cycles in the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2472
        Symbol[] ctors = new Symbol[0];
06bc494ca11e Initial load
duke
parents:
diff changeset
  2473
        ctors = callMap.keySet().toArray(ctors);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2474
        for (Symbol caller : ctors) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2475
            checkCyclicConstructor(tree, caller, callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2476
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2477
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2478
06bc494ca11e Initial load
duke
parents:
diff changeset
  2479
    /** Look in the map to see if the given constructor is part of a
06bc494ca11e Initial load
duke
parents:
diff changeset
  2480
     *  call cycle.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2481
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2482
    private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2483
                                        Map<Symbol,Symbol> callMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2484
        if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2485
            if ((ctor.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2486
                log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2487
                          "recursive.ctor.invocation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2488
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2489
                ctor.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2490
                checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2491
                ctor.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2492
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2493
            ctor.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2494
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2495
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2496
06bc494ca11e Initial load
duke
parents:
diff changeset
  2497
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2498
 * Miscellaneous
06bc494ca11e Initial load
duke
parents:
diff changeset
  2499
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2500
06bc494ca11e Initial load
duke
parents:
diff changeset
  2501
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2502
     * Return the opcode of the operator but emit an error if it is an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2503
     * error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2504
     * @param pos        position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2505
     * @param operator   an operator
06bc494ca11e Initial load
duke
parents:
diff changeset
  2506
     * @param tag        a tree tag
06bc494ca11e Initial load
duke
parents:
diff changeset
  2507
     * @param left       type of left hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2508
     * @param right      type of right hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2509
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2510
    int checkOperator(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2511
                       OperatorSymbol operator,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2512
                       int tag,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2513
                       Type left,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2514
                       Type right) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2515
        if (operator.opcode == ByteCodes.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2516
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2517
                      "operator.cant.be.applied",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2518
                      treeinfo.operatorName(tag),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  2519
                      List.of(left, right));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2520
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2521
        return operator.opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2522
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2523
06bc494ca11e Initial load
duke
parents:
diff changeset
  2524
06bc494ca11e Initial load
duke
parents:
diff changeset
  2525
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2526
     *  Check for division by integer constant zero
06bc494ca11e Initial load
duke
parents:
diff changeset
  2527
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2528
     *  @param operator      The operator for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2529
     *  @param operand       The right hand operand for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2530
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2531
    void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2532
        if (operand.constValue() != null
06bc494ca11e Initial load
duke
parents:
diff changeset
  2533
            && lint.isEnabled(Lint.LintCategory.DIVZERO)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2534
            && operand.tag <= LONG
06bc494ca11e Initial load
duke
parents:
diff changeset
  2535
            && ((Number) (operand.constValue())).longValue() == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2536
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2537
            if (opc == ByteCodes.idiv || opc == ByteCodes.imod
06bc494ca11e Initial load
duke
parents:
diff changeset
  2538
                || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  2539
                log.warning(Lint.LintCategory.DIVZERO, pos, "div.zero");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2540
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2541
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2542
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2543
06bc494ca11e Initial load
duke
parents:
diff changeset
  2544
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2545
     * Check for empty statements after if
06bc494ca11e Initial load
duke
parents:
diff changeset
  2546
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2547
    void checkEmptyIf(JCIf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2548
        if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  2549
            log.warning(Lint.LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2550
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2551
06bc494ca11e Initial load
duke
parents:
diff changeset
  2552
    /** Check that symbol is unique in given scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2553
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2554
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2555
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2556
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2557
    boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2558
        if (sym.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2559
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2560
        if (sym.owner.name == names.any) return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2561
        for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2562
            if (sym != e.sym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2563
                sym.kind == e.sym.kind &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2564
                sym.name != names.error &&
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2565
                (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2566
                if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2567
                    varargsDuplicateError(pos, sym, e.sym);
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2568
                else if (sym.kind == MTH && !types.overrideEquivalent(sym.type, e.sym.type))
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2569
                    duplicateErasureError(pos, sym, e.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2570
                else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2571
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2572
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2573
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2574
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2575
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2576
    }
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2577
    //where
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2578
    /** Report duplicate declaration error.
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2579
     */
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2580
    void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2581
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2582
            log.error(pos, "name.clash.same.erasure", sym1, sym2);
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2583
        }
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2584
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2585
06bc494ca11e Initial load
duke
parents:
diff changeset
  2586
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2587
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2588
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2589
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2590
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2591
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2592
    boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2593
        return checkUniqueImport(pos, sym, s, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2594
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2595
06bc494ca11e Initial load
duke
parents:
diff changeset
  2596
    /** Check that static single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2597
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2598
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2599
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2600
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2601
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2602
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2603
    boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2604
        return checkUniqueImport(pos, sym, s, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2605
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2606
06bc494ca11e Initial load
duke
parents:
diff changeset
  2607
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2608
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2609
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2610
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2611
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2612
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2613
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2614
    private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2615
        for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2616
            // is encountered class entered via a class declaration?
06bc494ca11e Initial load
duke
parents:
diff changeset
  2617
            boolean isClassDecl = e.scope == s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2618
            if ((isClassDecl || sym != e.sym) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2619
                sym.kind == e.sym.kind &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2620
                sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2621
                if (!e.sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2622
                    String what = e.sym.toString();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2623
                    if (!isClassDecl) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2624
                        if (staticImport)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2625
                            log.error(pos, "already.defined.static.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2626
                        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2627
                            log.error(pos, "already.defined.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2628
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2629
                    else if (sym != e.sym)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2630
                        log.error(pos, "already.defined.this.unit", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2631
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2632
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2633
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2634
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2635
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2636
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2637
06bc494ca11e Initial load
duke
parents:
diff changeset
  2638
    /** Check that a qualified name is in canonical form (for import decls).
06bc494ca11e Initial load
duke
parents:
diff changeset
  2639
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2640
    public void checkCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2641
        if (!isCanonical(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2642
            log.error(tree.pos(), "import.requires.canonical",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2643
                      TreeInfo.symbol(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2644
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2645
        // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2646
        private boolean isCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2647
            while (tree.getTag() == JCTree.SELECT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2648
                JCFieldAccess s = (JCFieldAccess) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2649
                if (s.sym.owner != TreeInfo.symbol(s.selected))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2650
                    return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2651
                tree = s.selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2652
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2653
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2654
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2655
06bc494ca11e Initial load
duke
parents:
diff changeset
  2656
    private class ConversionWarner extends Warner {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2657
        final String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2658
        final Type found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2659
        final Type expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2660
        public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2661
            super(pos);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2662
            this.key = key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2663
            this.found = found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2664
            this.expected = expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2665
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2666
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  2667
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2668
        public void warnUnchecked() {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2669
            boolean warned = this.warned;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2670
            super.warnUnchecked();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2671
            if (warned) return; // suppress redundant diagnostics
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  2672
            Object problem = diags.fragment(key);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2673
            Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2674
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2675
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2676
06bc494ca11e Initial load
duke
parents:
diff changeset
  2677
    public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2678
        return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2679
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2680
06bc494ca11e Initial load
duke
parents:
diff changeset
  2681
    public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2682
        return new ConversionWarner(pos, "unchecked.assign", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2683
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2684
}