langtools/src/share/classes/com/sun/tools/javac/comp/Check.java
author mcimadamore
Thu, 27 Aug 2009 13:40:48 +0100
changeset 3765 9548183897cb
parent 3661 104c425e96aa
child 3780 368edd3d2082
permissions -rw-r--r--
6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond') Summary: diamond operator implementation (simple approach) Reviewed-by: jjg
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
2212
1d3dc0e0ba0c 6814575: Update copyright year
xdono
parents: 1874
diff changeset
     2
 * Copyright 1999-2009 Sun Microsystems, Inc.  All Rights Reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
06bc494ca11e Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.  Sun designates this
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
06bc494ca11e Initial load
duke
parents:
diff changeset
     9
 * by Sun in the LICENSE file that accompanied this code.
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    21
 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
06bc494ca11e Initial load
duke
parents:
diff changeset
    22
 * CA 95054 USA or visit www.sun.com if you need additional information or
06bc494ca11e Initial load
duke
parents:
diff changeset
    23
 * have any questions.
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
import java.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    29
import java.util.Set;
06bc494ca11e Initial load
duke
parents:
diff changeset
    30
06bc494ca11e Initial load
duke
parents:
diff changeset
    31
import com.sun.tools.javac.code.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
import com.sun.tools.javac.jvm.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    34
import com.sun.tools.javac.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
import com.sun.tools.javac.util.List;
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
06bc494ca11e Initial load
duke
parents:
diff changeset
    38
import com.sun.tools.javac.tree.JCTree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
import com.sun.tools.javac.code.Lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    40
import com.sun.tools.javac.code.Lint.LintCategory;
06bc494ca11e Initial load
duke
parents:
diff changeset
    41
import com.sun.tools.javac.code.Type.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    42
import com.sun.tools.javac.code.Symbol.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    43
06bc494ca11e Initial load
duke
parents:
diff changeset
    44
import static com.sun.tools.javac.code.Flags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    45
import static com.sun.tools.javac.code.Kinds.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    46
import static com.sun.tools.javac.code.TypeTags.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    47
06bc494ca11e Initial load
duke
parents:
diff changeset
    48
/** Type checking helper class for the attribution phase.
06bc494ca11e Initial load
duke
parents:
diff changeset
    49
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    50
 *  <p><b>This is NOT part of any API supported by Sun Microsystems.  If
06bc494ca11e Initial load
duke
parents:
diff changeset
    51
 *  you write code that depends on this, you do so at your own risk.
06bc494ca11e Initial load
duke
parents:
diff changeset
    52
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    53
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    54
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    55
public class Check {
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
    protected static final Context.Key<Check> checkKey =
06bc494ca11e Initial load
duke
parents:
diff changeset
    57
        new Context.Key<Check>();
06bc494ca11e Initial load
duke
parents:
diff changeset
    58
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    59
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    60
    private final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
    61
    private final Symtab syms;
06bc494ca11e Initial load
duke
parents:
diff changeset
    62
    private final Infer infer;
06bc494ca11e Initial load
duke
parents:
diff changeset
    63
    private final Target target;
06bc494ca11e Initial load
duke
parents:
diff changeset
    64
    private final Source source;
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
    private final Types types;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    66
    private final JCDiagnostic.Factory diags;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    67
    private final boolean skipAnnotations;
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
    68
    private boolean warnOnSyntheticConflicts;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    69
    private final TreeInfo treeinfo;
06bc494ca11e Initial load
duke
parents:
diff changeset
    70
06bc494ca11e Initial load
duke
parents:
diff changeset
    71
    // The set of lint options currently in effect. It is initialized
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
    // from the context, and then is set/reset as needed by Attr as it
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
    // visits all the various parts of the trees during attribution.
06bc494ca11e Initial load
duke
parents:
diff changeset
    74
    private Lint lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
    public static Check instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
        Check instance = context.get(checkKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
    79
            instance = new Check(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
    82
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
    protected Check(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    84
        context.put(checkKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    86
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
        syms = Symtab.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
        infer = Infer.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
        this.types = Types.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    91
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
        target = Target.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    94
        source = Source.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    95
        lint = Lint.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    96
        treeinfo = TreeInfo.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    97
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
        Source source = Source.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
        allowGenerics = source.allowGenerics();
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
        allowAnnotations = source.allowAnnotations();
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
        complexInference = options.get("-complexinference") != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
        skipAnnotations = options.get("skipAnnotations") != null;
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
   103
        warnOnSyntheticConflicts = options.get("warnOnSyntheticConflicts") != null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
        boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
        boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   107
        boolean verboseSunApi = lint.isEnabled(LintCategory.SUNAPI);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   108
        boolean enforceMandatoryWarnings = source.enforceMandatoryWarnings();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   109
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   110
        deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   111
                enforceMandatoryWarnings, "deprecated");
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   112
        uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   113
                enforceMandatoryWarnings, "unchecked");
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   114
        sunApiHandler = new MandatoryWarningHandler(log, verboseSunApi,
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   115
                enforceMandatoryWarnings, "sunapi");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
06bc494ca11e Initial load
duke
parents:
diff changeset
   118
    /** Switch: generics enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   119
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   120
    boolean allowGenerics;
06bc494ca11e Initial load
duke
parents:
diff changeset
   121
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
    /** Switch: annotations enabled?
06bc494ca11e Initial load
duke
parents:
diff changeset
   123
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   124
    boolean allowAnnotations;
06bc494ca11e Initial load
duke
parents:
diff changeset
   125
06bc494ca11e Initial load
duke
parents:
diff changeset
   126
    /** Switch: -complexinference option set?
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   128
    boolean complexInference;
06bc494ca11e Initial load
duke
parents:
diff changeset
   129
06bc494ca11e Initial load
duke
parents:
diff changeset
   130
    /** A table mapping flat names of all compiled classes in this run to their
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
     *  symbols; maintained from outside.
06bc494ca11e Initial load
duke
parents:
diff changeset
   132
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   133
    public Map<Name,ClassSymbol> compiled = new HashMap<Name, ClassSymbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
06bc494ca11e Initial load
duke
parents:
diff changeset
   135
    /** A handler for messages about deprecated usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   136
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   137
    private MandatoryWarningHandler deprecationHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   138
06bc494ca11e Initial load
duke
parents:
diff changeset
   139
    /** A handler for messages about unchecked or unsafe usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   140
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   141
    private MandatoryWarningHandler uncheckedHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   142
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   143
    /** A handler for messages about using Sun proprietary API.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   144
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   145
    private MandatoryWarningHandler sunApiHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   146
06bc494ca11e Initial load
duke
parents:
diff changeset
   147
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   148
 * Errors and Warnings
06bc494ca11e Initial load
duke
parents:
diff changeset
   149
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
    Lint setLint(Lint newLint) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   152
        Lint prev = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   153
        lint = newLint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   154
        return prev;
06bc494ca11e Initial load
duke
parents:
diff changeset
   155
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   156
06bc494ca11e Initial load
duke
parents:
diff changeset
   157
    /** Warn about deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   158
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   159
     *  @param sym        The deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   160
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   161
    void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   162
        if (!lint.isSuppressed(LintCategory.DEPRECATION))
06bc494ca11e Initial load
duke
parents:
diff changeset
   163
            deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   164
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   165
06bc494ca11e Initial load
duke
parents:
diff changeset
   166
    /** Warn about unchecked operation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   167
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   168
     *  @param msg        A string describing the problem.
06bc494ca11e Initial load
duke
parents:
diff changeset
   169
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   170
    public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   171
        if (!lint.isSuppressed(LintCategory.UNCHECKED))
06bc494ca11e Initial load
duke
parents:
diff changeset
   172
            uncheckedHandler.report(pos, msg, args);
06bc494ca11e Initial load
duke
parents:
diff changeset
   173
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   174
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   175
    /** Warn about using Sun proprietary API.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   176
     *  @param pos        Position to be used for error reporting.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   177
     *  @param msg        A string describing the problem.
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   178
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   179
    public void warnSunApi(DiagnosticPosition pos, String msg, Object... args) {
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   180
        if (!lint.isSuppressed(LintCategory.SUNAPI))
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   181
            sunApiHandler.report(pos, msg, args);
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   182
    }
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   183
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   184
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
     * Report any deferred diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
   186
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   187
    public void reportDeferredDiagnostics() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   188
        deprecationHandler.reportDeferredDiagnostic();
06bc494ca11e Initial load
duke
parents:
diff changeset
   189
        uncheckedHandler.reportDeferredDiagnostic();
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   190
        sunApiHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   191
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   192
06bc494ca11e Initial load
duke
parents:
diff changeset
   193
06bc494ca11e Initial load
duke
parents:
diff changeset
   194
    /** Report a failure to complete a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   195
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   196
     *  @param ex         The failure to report.
06bc494ca11e Initial load
duke
parents:
diff changeset
   197
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   198
    public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
169
ff76730e430e 6668794: javac puts localized text in raw diagnostics
jjg
parents: 10
diff changeset
   199
        log.error(pos, "cant.access", ex.sym, ex.getDetailValue());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
        if (ex instanceof ClassReader.BadClassFile) throw new Abort();
06bc494ca11e Initial load
duke
parents:
diff changeset
   201
        else return syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   202
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   203
06bc494ca11e Initial load
duke
parents:
diff changeset
   204
    /** Report a type error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   205
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   206
     *  @param problem    A string describing the error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   207
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   208
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   209
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   210
    Type typeError(DiagnosticPosition pos, Object problem, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   211
        log.error(pos, "prob.found.req",
06bc494ca11e Initial load
duke
parents:
diff changeset
   212
                  problem, found, req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   213
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   214
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   215
06bc494ca11e Initial load
duke
parents:
diff changeset
   216
    Type typeError(DiagnosticPosition pos, String problem, Type found, Type req, Object explanation) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
        log.error(pos, "prob.found.req.1", problem, found, req, explanation);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   218
        return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   219
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   220
06bc494ca11e Initial load
duke
parents:
diff changeset
   221
    /** Report an error that wrong type tag was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   222
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   223
     *  @param required   An internationalized string describing the type tag
06bc494ca11e Initial load
duke
parents:
diff changeset
   224
     *                    required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   225
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   226
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   227
    Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   228
        // this error used to be raised by the parser,
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   229
        // but has been delayed to this point:
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   230
        if (found instanceof Type && ((Type)found).tag == VOID) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   231
            log.error(pos, "illegal.start.of.type");
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   232
            return syms.errType;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   233
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   234
        log.error(pos, "type.found.req", found, required);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   235
        return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   236
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   237
06bc494ca11e Initial load
duke
parents:
diff changeset
   238
    /** Report an error that symbol cannot be referenced before super
06bc494ca11e Initial load
duke
parents:
diff changeset
   239
     *  has been called.
06bc494ca11e Initial load
duke
parents:
diff changeset
   240
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   241
     *  @param sym        The referenced symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   242
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   243
    void earlyRefError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   244
        log.error(pos, "cant.ref.before.ctor.called", sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   245
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   246
06bc494ca11e Initial load
duke
parents:
diff changeset
   247
    /** Report duplicate declaration error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   248
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   249
    void duplicateError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   250
        if (!sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   251
            log.error(pos, "already.defined", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   252
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   253
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
06bc494ca11e Initial load
duke
parents:
diff changeset
   255
    /** Report array/varargs duplicate declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
   256
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
    void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   258
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
            log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
06bc494ca11e Initial load
duke
parents:
diff changeset
   263
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
 * duplicate declaration checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   266
06bc494ca11e Initial load
duke
parents:
diff changeset
   267
    /** Check that variable does not hide variable with same name in
06bc494ca11e Initial load
duke
parents:
diff changeset
   268
     *  immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   269
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   270
     *  @param v             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   271
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   272
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
    void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
            for (Scope.Entry e = s.next.lookup(v.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   276
                 e.scope != null && e.sym.owner == v.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
                 e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
                if (e.sym.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   279
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   280
                    v.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   281
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   282
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   283
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   284
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   286
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   287
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
    /** Check that a class or interface does not hide a class or
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
     *  interface with same name in immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
     *  @param c             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   294
    void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   295
        if (s.next != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
            for (Scope.Entry e = s.next.lookup(c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   297
                 e.scope != null && e.sym.owner == c.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
   298
                 e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
                if (e.sym.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
                    (e.sym.owner.kind & (VAR | MTH)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
                    c.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
   304
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   308
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
    /** Check that class does not have the same name as one of
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
     *  its enclosing classes, or as a class defined in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   311
     *  return true if class is unique in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
     *  @param name          The class name.
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
     *  @param s             The enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
    boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
        for (Scope.Entry e = s.lookup(name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
            if (e.sym.kind == TYP && e.sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
                duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
        for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
            if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
                duplicateError(pos, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
 * Class name generation
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
06bc494ca11e Initial load
duke
parents:
diff changeset
   336
    /** Return name of local class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
     *  This is of the form    <enclClass> $ n <classname>
06bc494ca11e Initial load
duke
parents:
diff changeset
   338
     *  where
06bc494ca11e Initial load
duke
parents:
diff changeset
   339
     *    enclClass is the flat name of the enclosing class,
06bc494ca11e Initial load
duke
parents:
diff changeset
   340
     *    classname is the simple name of the local class
06bc494ca11e Initial load
duke
parents:
diff changeset
   341
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   342
    Name localClassName(ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   343
        for (int i=1; ; i++) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
            Name flatname = names.
06bc494ca11e Initial load
duke
parents:
diff changeset
   345
                fromString("" + c.owner.enclClass().flatname +
06bc494ca11e Initial load
duke
parents:
diff changeset
   346
                           target.syntheticNameChar() + i +
06bc494ca11e Initial load
duke
parents:
diff changeset
   347
                           c.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
   348
            if (compiled.get(flatname) == null) return flatname;
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   351
06bc494ca11e Initial load
duke
parents:
diff changeset
   352
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   353
 * Type Checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
06bc494ca11e Initial load
duke
parents:
diff changeset
   356
    /** Check that a given type is assignable to a given proto-type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   357
     *  If it is, return the type, otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
    Type checkType(DiagnosticPosition pos, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
        if (req.tag == ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
        if (req.tag == NONE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
        if (types.isAssignable(found, req, convertWarner(pos, found, req)))
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
            return found;
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
        if (found.tag <= DOUBLE && req.tag <= DOUBLE)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   370
            return typeError(pos, diags.fragment("possible.loss.of.precision"), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   371
        if (found.isSuperBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
            log.error(pos, "assignment.from.super-bound", found);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   373
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
        if (req.isExtendsBound()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
            log.error(pos, "assignment.to.extends-bound", req);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   377
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   378
        }
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   379
        return typeError(pos, diags.fragment("incompatible.types"), found, req);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   380
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   381
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   382
    Type checkReturnType(DiagnosticPosition pos, Type found, Type req) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   383
        if (found.tag == FORALL) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   384
            try {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   385
                return instantiatePoly(pos, (ForAll) found, req, convertWarner(pos, found, req));
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   386
            } catch (Infer.NoInstanceException ex) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   387
                if (ex.isAmbiguous) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   388
                    JCDiagnostic d = ex.getDiagnostic();
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   389
                    log.error(pos,
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   390
                            "undetermined.type" + (d != null ? ".1" : ""),
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   391
                            found, d);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   392
                    return types.createErrorType(req);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   393
                } else {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   394
                    JCDiagnostic d = ex.getDiagnostic();
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   395
                    return typeError(pos,
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   396
                            diags.fragment("incompatible.types" + (d != null ? ".1" : ""), d),
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   397
                            found, req);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   398
                }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   399
            } catch (Infer.InvalidInstanceException ex) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   400
                JCDiagnostic d = ex.getDiagnostic();
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   401
                log.error(pos, "invalid.inferred.types", ((ForAll)found).tvars, d);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   402
                return types.createErrorType(req);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   403
            }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   404
        } else {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   405
            return checkType(pos, found, req);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   406
        }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   407
    }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   408
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
    /** Instantiate polymorphic type to some prototype, unless
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
     *  prototype is `anyPoly' in which case polymorphic type
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
     *  is returned unchanged.
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
     */
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   413
    Type instantiatePoly(DiagnosticPosition pos, ForAll t, Type pt, Warner warn) throws Infer.NoInstanceException {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   414
        if (pt == Infer.anyPoly && complexInference) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   415
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   416
        } else if (pt == Infer.anyPoly || pt.tag == NONE) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   417
            Type newpt = t.qtype.tag <= VOID ? t.qtype : syms.objectType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   418
            return instantiatePoly(pos, t, newpt, warn);
06bc494ca11e Initial load
duke
parents:
diff changeset
   419
        } else if (pt.tag == ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   420
            return pt;
06bc494ca11e Initial load
duke
parents:
diff changeset
   421
        } else {
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   422
            return infer.instantiateExpr(t, pt, warn);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   423
        }
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   424
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   425
06bc494ca11e Initial load
duke
parents:
diff changeset
   426
    /** Check that a given type can be cast to a given target type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   427
     *  Return the result of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   428
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   429
     *  @param found      The type that is being cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
     *  @param req        The target type of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   432
    Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   433
        if (found.tag == FORALL) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   434
            instantiatePoly(pos, (ForAll) found, req, castWarner(pos, found, req));
06bc494ca11e Initial load
duke
parents:
diff changeset
   435
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   436
        } else if (types.isCastable(found, req, castWarner(pos, found, req))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   437
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   438
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   439
            return typeError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   440
                             diags.fragment("inconvertible.types"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   441
                             found, req);
06bc494ca11e Initial load
duke
parents:
diff changeset
   442
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   443
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   444
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
   445
        /** Is type a type variable, or a (possibly multi-dimensional) array of
06bc494ca11e Initial load
duke
parents:
diff changeset
   446
         *  type variables?
06bc494ca11e Initial load
duke
parents:
diff changeset
   447
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
   448
        boolean isTypeVar(Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   449
            return t.tag == TYPEVAR || t.tag == ARRAY && isTypeVar(types.elemtype(t));
06bc494ca11e Initial load
duke
parents:
diff changeset
   450
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   451
06bc494ca11e Initial load
duke
parents:
diff changeset
   452
    /** Check that a type is within some bounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   453
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   454
     *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
06bc494ca11e Initial load
duke
parents:
diff changeset
   455
     *  type argument.
06bc494ca11e Initial load
duke
parents:
diff changeset
   456
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   457
     *  @param a             The type that should be bounded by bs.
06bc494ca11e Initial load
duke
parents:
diff changeset
   458
     *  @param bs            The bound.
06bc494ca11e Initial load
duke
parents:
diff changeset
   459
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   460
    private void checkExtends(DiagnosticPosition pos, Type a, TypeVar bs) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   461
         if (a.isUnbound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   462
             return;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   463
         } else if (a.tag != WILDCARD) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   464
             a = types.upperBound(a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   465
             for (List<Type> l = types.getBounds(bs); l.nonEmpty(); l = l.tail) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   466
                 if (!types.isSubtype(a, l.head)) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   467
                     log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   468
                     return;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   469
                 }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   470
             }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   471
         } else if (a.isExtendsBound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   472
             if (!types.isCastable(bs.getUpperBound(), types.upperBound(a), Warner.noWarnings))
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   473
                 log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   474
         } else if (a.isSuperBound()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   475
             if (types.notSoftSubtype(types.lowerBound(a), bs.getUpperBound()))
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   476
                 log.error(pos, "not.within.bounds", a);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   477
         }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   478
     }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   479
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   480
    /** Check that a type is within some bounds.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   481
     *
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   482
     *  Used in TypeApply to verify that, e.g., X in V<X> is a valid
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   483
     *  type argument.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   484
     *  @param pos           Position to be used for error reporting.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   485
     *  @param a             The type that should be bounded by bs.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   486
     *  @param bs            The bound.
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   487
     */
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   488
    private void checkCapture(JCTypeApply tree) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   489
        List<JCExpression> args = tree.getTypeArguments();
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   490
        for (Type arg : types.capture(tree.type).getTypeArguments()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   491
            if (arg.tag == TYPEVAR && arg.getUpperBound().isErroneous()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   492
                log.error(args.head.pos, "not.within.bounds", args.head.type);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   493
                break;
938
13aae74ca013 6594284: NPE thrown when calling a method on an intersection type
mcimadamore
parents: 937
diff changeset
   494
            }
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   495
            args = args.tail;
938
13aae74ca013 6594284: NPE thrown when calling a method on an intersection type
mcimadamore
parents: 937
diff changeset
   496
        }
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   497
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   498
06bc494ca11e Initial load
duke
parents:
diff changeset
   499
    /** Check that type is different from 'void'.
06bc494ca11e Initial load
duke
parents:
diff changeset
   500
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   501
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   502
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   503
    Type checkNonVoid(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   504
        if (t.tag == VOID) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   505
            log.error(pos, "void.not.allowed.here");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   506
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   507
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   508
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   509
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   510
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   511
06bc494ca11e Initial load
duke
parents:
diff changeset
   512
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   513
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   514
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   515
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   516
    Type checkClassType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   517
        if (t.tag != CLASS && t.tag != ERROR)
06bc494ca11e Initial load
duke
parents:
diff changeset
   518
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   519
                                diags.fragment("type.req.class"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   520
                                (t.tag == TYPEVAR)
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   521
                                ? diags.fragment("type.parameter", t)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   522
                                : t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   523
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
   524
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   525
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   526
06bc494ca11e Initial load
duke
parents:
diff changeset
   527
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   528
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   529
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   530
     *  @param noBounds    True if type bounds are illegal here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   531
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   532
    Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   533
        t = checkClassType(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   534
        if (noBounds && t.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   535
            List<Type> args = t.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
   536
            while (args.nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   537
                if (args.head.tag == WILDCARD)
06bc494ca11e Initial load
duke
parents:
diff changeset
   538
                    return typeTagError(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
   539
                                        log.getLocalizedString("type.req.exact"),
06bc494ca11e Initial load
duke
parents:
diff changeset
   540
                                        args.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
   541
                args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   542
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   543
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   544
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   545
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   546
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   547
    /** Check that type is a valid type for a new expression. If the type contains
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   548
     * some uninferred type variables, instantiate them exploiting the expected
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   549
     * type.
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   550
     *
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   551
     *  @param pos           Position to be used for error reporting.
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   552
     *  @param t             The type to be checked.
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   553
     *  @param noBounds    True if type bounds are illegal here.
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   554
     *  @param pt          Expected type (used with diamond operator)
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   555
     */
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   556
    Type checkNewClassType(DiagnosticPosition pos, Type t, boolean noBounds, Type pt) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   557
        if (t.tag == FORALL) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   558
            try {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   559
                t = instantiatePoly(pos, (ForAll)t, pt, Warner.noWarnings);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   560
            }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   561
            catch (Infer.NoInstanceException ex) {
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   562
                JCDiagnostic d = ex.getDiagnostic();
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   563
                log.error(pos, "cant.apply.diamond", t.getTypeArguments(), d);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   564
                return types.createErrorType(pt);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   565
            }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   566
        }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   567
        return checkClassType(pos, t, noBounds);
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   568
    }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   569
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   570
    /** Check that type is a reifiable class, interface or array type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   571
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   572
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   573
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   574
    Type checkReifiableReferenceType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   575
        if (t.tag != CLASS && t.tag != ARRAY && t.tag != ERROR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   576
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   577
                                diags.fragment("type.req.class.array"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   578
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   579
        } else if (!types.isReifiable(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   580
            log.error(pos, "illegal.generic.type.for.instof");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   581
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   582
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   583
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   584
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   585
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   586
06bc494ca11e Initial load
duke
parents:
diff changeset
   587
    /** Check that type is a reference type, i.e. a class, interface or array type
06bc494ca11e Initial load
duke
parents:
diff changeset
   588
     *  or a type variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   589
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   590
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   591
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   592
    Type checkRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   593
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   594
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   595
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   596
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   597
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   598
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   599
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   600
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   601
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   602
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   603
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   604
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   605
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   606
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   607
    /** Check that each type is a reference type, i.e. a class, interface or array type
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   608
     *  or a type variable.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   609
     *  @param trees         Original trees, used for error reporting.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   610
     *  @param types         The types to be checked.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   611
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   612
    List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   613
        List<JCExpression> tl = trees;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   614
        for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   615
            l.head = checkRefType(tl.head.pos(), l.head);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   616
            tl = tl.tail;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   617
        }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   618
        return types;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   619
    }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   620
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   621
    /** Check that type is a null or reference type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   622
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   623
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   624
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   625
    Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   626
        switch (t.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   627
        case CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
   628
        case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
   629
        case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   630
        case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
   631
        case BOT:
06bc494ca11e Initial load
duke
parents:
diff changeset
   632
        case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   633
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   634
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   635
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   636
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   637
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   638
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   639
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   640
06bc494ca11e Initial load
duke
parents:
diff changeset
   641
    /** Check that flag set does not contain elements of two conflicting sets. s
06bc494ca11e Initial load
duke
parents:
diff changeset
   642
     *  Return true if it doesn't.
06bc494ca11e Initial load
duke
parents:
diff changeset
   643
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   644
     *  @param flags         The set of flags to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   645
     *  @param set1          Conflicting flags set #1.
06bc494ca11e Initial load
duke
parents:
diff changeset
   646
     *  @param set2          Conflicting flags set #2.
06bc494ca11e Initial load
duke
parents:
diff changeset
   647
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   648
    boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   649
        if ((flags & set1) != 0 && (flags & set2) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   650
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
   651
                      "illegal.combination.of.modifiers",
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   652
                      asFlagSet(TreeInfo.firstFlag(flags & set1)),
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   653
                      asFlagSet(TreeInfo.firstFlag(flags & set2)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   654
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   655
        } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   656
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   657
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   658
06bc494ca11e Initial load
duke
parents:
diff changeset
   659
    /** Check that given modifiers are legal for given symbol and
06bc494ca11e Initial load
duke
parents:
diff changeset
   660
     *  return modifiers together with any implicit modififiers for that symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   661
     *  Warning: we can't use flags() here since this method
06bc494ca11e Initial load
duke
parents:
diff changeset
   662
     *  is called during class enter, when flags() would cause a premature
06bc494ca11e Initial load
duke
parents:
diff changeset
   663
     *  completion.
06bc494ca11e Initial load
duke
parents:
diff changeset
   664
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   665
     *  @param flags         The set of modifiers given in a definition.
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
     *  @param sym           The defined symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   667
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   668
    long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   669
        long mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   670
        long implicit = 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   671
        switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   672
        case VAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
   673
            if (sym.owner.kind != TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
   674
                mask = LocalVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   675
            else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   676
                mask = implicit = InterfaceVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   677
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
   678
                mask = VarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   679
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   680
        case MTH:
06bc494ca11e Initial load
duke
parents:
diff changeset
   681
            if (sym.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   682
                if ((sym.owner.flags_field & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   683
                    // enum constructors cannot be declared public or
06bc494ca11e Initial load
duke
parents:
diff changeset
   684
                    // protected and must be implicitly or explicitly
06bc494ca11e Initial load
duke
parents:
diff changeset
   685
                    // private
06bc494ca11e Initial load
duke
parents:
diff changeset
   686
                    implicit = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   687
                    mask = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   688
                } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   689
                    mask = ConstructorFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   690
            }  else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   691
                mask = implicit = InterfaceMethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   692
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   693
                mask = MethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   694
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   695
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   696
            if (((flags|implicit) & Flags.ABSTRACT) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   697
              implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   698
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   699
        case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
   700
            if (sym.isLocal()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   701
                mask = LocalClassFlags;
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   702
                if (sym.name.isEmpty()) { // Anonymous class
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   703
                    // Anonymous classes in static methods are themselves static;
06bc494ca11e Initial load
duke
parents:
diff changeset
   704
                    // that's why we admit STATIC here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   705
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   706
                    // JLS: Anonymous classes are final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   707
                    implicit |= FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
   708
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   709
                if ((sym.owner.flags_field & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   710
                    (flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   711
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   712
            } else if (sym.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   713
                mask = MemberClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   714
                if (sym.owner.owner.kind == PCK ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   715
                    (sym.owner.flags_field & STATIC) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   716
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   717
                else if ((flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   718
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
   719
                // Nested interfaces and enums are always STATIC (Spec ???)
06bc494ca11e Initial load
duke
parents:
diff changeset
   720
                if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
   721
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   722
                mask = ClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
   723
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   724
            // Interfaces are always ABSTRACT
06bc494ca11e Initial load
duke
parents:
diff changeset
   725
            if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
   726
06bc494ca11e Initial load
duke
parents:
diff changeset
   727
            if ((flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   728
                // enums can't be declared abstract or final
06bc494ca11e Initial load
duke
parents:
diff changeset
   729
                mask &= ~(ABSTRACT | FINAL);
06bc494ca11e Initial load
duke
parents:
diff changeset
   730
                implicit |= implicitEnumFinalFlag(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
   731
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   732
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
   733
            implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   734
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
   735
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
   736
            throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
   737
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   738
        long illegal = flags & StandardFlags & ~mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
   739
        if (illegal != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   740
            if ((illegal & INTERFACE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   741
                log.error(pos, "intf.not.allowed.here");
06bc494ca11e Initial load
duke
parents:
diff changeset
   742
                mask |= INTERFACE;
06bc494ca11e Initial load
duke
parents:
diff changeset
   743
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   744
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   745
                log.error(pos,
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   746
                          "mod.not.allowed.here", asFlagSet(illegal));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   747
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   748
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   749
        else if ((sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   750
                  // ISSUE: Disallowing abstract&private is no longer appropriate
06bc494ca11e Initial load
duke
parents:
diff changeset
   751
                  // in the presence of inner classes. Should it be deleted here?
06bc494ca11e Initial load
duke
parents:
diff changeset
   752
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   753
                                ABSTRACT,
06bc494ca11e Initial load
duke
parents:
diff changeset
   754
                                PRIVATE | STATIC))
06bc494ca11e Initial load
duke
parents:
diff changeset
   755
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   756
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
                               ABSTRACT | INTERFACE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   758
                               FINAL | NATIVE | SYNCHRONIZED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   759
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   760
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   761
                               PUBLIC,
06bc494ca11e Initial load
duke
parents:
diff changeset
   762
                               PRIVATE | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   763
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   764
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
                               PRIVATE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
                               PUBLIC | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   768
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   769
                               FINAL,
06bc494ca11e Initial load
duke
parents:
diff changeset
   770
                               VOLATILE)
06bc494ca11e Initial load
duke
parents:
diff changeset
   771
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   772
                 (sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   773
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
   774
                                ABSTRACT | NATIVE,
06bc494ca11e Initial load
duke
parents:
diff changeset
   775
                                STRICTFP))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   776
            // skip
06bc494ca11e Initial load
duke
parents:
diff changeset
   777
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   778
        return flags & (mask | ~StandardFlags) | implicit;
06bc494ca11e Initial load
duke
parents:
diff changeset
   779
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   780
06bc494ca11e Initial load
duke
parents:
diff changeset
   781
06bc494ca11e Initial load
duke
parents:
diff changeset
   782
    /** Determine if this enum should be implicitly final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   783
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   784
     *  If the enum has no specialized enum contants, it is final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   785
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   786
     *  If the enum does have specialized enum contants, it is
06bc494ca11e Initial load
duke
parents:
diff changeset
   787
     *  <i>not</i> final.
06bc494ca11e Initial load
duke
parents:
diff changeset
   788
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   789
    private long implicitEnumFinalFlag(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   790
        if (tree.getTag() != JCTree.CLASSDEF) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   791
        class SpecialTreeVisitor extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
   792
            boolean specialized;
06bc494ca11e Initial load
duke
parents:
diff changeset
   793
            SpecialTreeVisitor() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   794
                this.specialized = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   795
            };
06bc494ca11e Initial load
duke
parents:
diff changeset
   796
06bc494ca11e Initial load
duke
parents:
diff changeset
   797
            public void visitTree(JCTree tree) { /* no-op */ }
06bc494ca11e Initial load
duke
parents:
diff changeset
   798
06bc494ca11e Initial load
duke
parents:
diff changeset
   799
            public void visitVarDef(JCVariableDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   800
                if ((tree.mods.flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   801
                    if (tree.init instanceof JCNewClass &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   802
                        ((JCNewClass) tree.init).def != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   803
                        specialized = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   804
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   805
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   806
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   807
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   808
06bc494ca11e Initial load
duke
parents:
diff changeset
   809
        SpecialTreeVisitor sts = new SpecialTreeVisitor();
06bc494ca11e Initial load
duke
parents:
diff changeset
   810
        JCClassDecl cdef = (JCClassDecl) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
   811
        for (JCTree defs: cdef.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   812
            defs.accept(sts);
06bc494ca11e Initial load
duke
parents:
diff changeset
   813
            if (sts.specialized) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
   814
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   815
        return FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
   816
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   817
06bc494ca11e Initial load
duke
parents:
diff changeset
   818
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   819
 * Type Validation
06bc494ca11e Initial load
duke
parents:
diff changeset
   820
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   821
06bc494ca11e Initial load
duke
parents:
diff changeset
   822
    /** Validate a type expression. That is,
06bc494ca11e Initial load
duke
parents:
diff changeset
   823
     *  check that all type arguments of a parametric type are within
06bc494ca11e Initial load
duke
parents:
diff changeset
   824
     *  their bounds. This must be done in a second phase after type attributon
06bc494ca11e Initial load
duke
parents:
diff changeset
   825
     *  since a class might have a subclass as type parameter bound. E.g:
06bc494ca11e Initial load
duke
parents:
diff changeset
   826
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   827
     *  class B<A extends C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
   828
     *  class C extends B<C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
   829
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   830
     *  and we can't make sure that the bound is already attributed because
06bc494ca11e Initial load
duke
parents:
diff changeset
   831
     *  of possible cycles.
06bc494ca11e Initial load
duke
parents:
diff changeset
   832
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   833
    private Validator validator = new Validator();
06bc494ca11e Initial load
duke
parents:
diff changeset
   834
06bc494ca11e Initial load
duke
parents:
diff changeset
   835
    /** Visitor method: Validate a type expression, if it is not null, catching
06bc494ca11e Initial load
duke
parents:
diff changeset
   836
     *  and reporting any completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
   837
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   838
    void validate(JCTree tree, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   839
        try {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   840
            if (tree != null) {
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   841
                validator.env = env;
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   842
                tree.accept(validator);
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   843
                checkRaw(tree, env);
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   844
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   845
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   846
            completionError(tree.pos(), ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
   847
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   848
    }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   849
    //where
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   850
    void checkRaw(JCTree tree, Env<AttrContext> env) {
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   851
        if (lint.isEnabled(Lint.LintCategory.RAW) &&
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   852
            tree.type.tag == CLASS &&
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   853
            !env.enclClass.name.isEmpty() &&  //anonymous or intersection
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   854
            tree.type.isRaw()) {
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   855
            log.warning(tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   856
        }
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   857
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   858
06bc494ca11e Initial load
duke
parents:
diff changeset
   859
    /** Visitor method: Validate a list of type expressions.
06bc494ca11e Initial load
duke
parents:
diff changeset
   860
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   861
    void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   862
        for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   863
            validate(l.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   864
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   865
06bc494ca11e Initial load
duke
parents:
diff changeset
   866
    /** A visitor class for type validation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   867
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   868
    class Validator extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
   869
06bc494ca11e Initial load
duke
parents:
diff changeset
   870
        public void visitTypeArray(JCArrayTypeTree tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   871
            validate(tree.elemtype, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   872
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   873
06bc494ca11e Initial load
duke
parents:
diff changeset
   874
        public void visitTypeApply(JCTypeApply tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   875
            if (tree.type.tag == CLASS) {
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   876
                List<Type> formals = tree.type.tsym.type.allparams();
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   877
                List<Type> actuals = tree.type.allparams();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   878
                List<JCExpression> args = tree.arguments;
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   879
                List<Type> forms = tree.type.tsym.type.getTypeArguments();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   880
                ListBuffer<TypeVar> tvars_buf = new ListBuffer<TypeVar>();
06bc494ca11e Initial load
duke
parents:
diff changeset
   881
06bc494ca11e Initial load
duke
parents:
diff changeset
   882
                // For matching pairs of actual argument types `a' and
06bc494ca11e Initial load
duke
parents:
diff changeset
   883
                // formal type parameters with declared bound `b' ...
06bc494ca11e Initial load
duke
parents:
diff changeset
   884
                while (args.nonEmpty() && forms.nonEmpty()) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   885
                    validate(args.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   886
06bc494ca11e Initial load
duke
parents:
diff changeset
   887
                    // exact type arguments needs to know their
06bc494ca11e Initial load
duke
parents:
diff changeset
   888
                    // bounds (for upper and lower bound
06bc494ca11e Initial load
duke
parents:
diff changeset
   889
                    // calculations).  So we create new TypeVars with
06bc494ca11e Initial load
duke
parents:
diff changeset
   890
                    // bounds substed with actuals.
06bc494ca11e Initial load
duke
parents:
diff changeset
   891
                    tvars_buf.append(types.substBound(((TypeVar)forms.head),
06bc494ca11e Initial load
duke
parents:
diff changeset
   892
                                                      formals,
937
457a11ae2e84 6651719: Compiler crashes possibly during forward reference of TypeParameter
mcimadamore
parents: 815
diff changeset
   893
                                                      actuals));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   894
06bc494ca11e Initial load
duke
parents:
diff changeset
   895
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   896
                    forms = forms.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   897
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   898
06bc494ca11e Initial load
duke
parents:
diff changeset
   899
                args = tree.arguments;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   900
                List<Type> tvars_cap = types.substBounds(formals,
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   901
                                          formals,
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
   902
                                          types.capture(tree.type).allparams());
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   903
                while (args.nonEmpty() && tvars_cap.nonEmpty()) {
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   904
                    // Let the actual arguments know their bound
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   905
                    args.head.type.withTypeVar((TypeVar)tvars_cap.head);
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   906
                    args = args.tail;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   907
                    tvars_cap = tvars_cap.tail;
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   908
                }
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   909
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   910
                args = tree.arguments;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   911
                List<TypeVar> tvars = tvars_buf.toList();
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   912
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   913
                while (args.nonEmpty() && tvars.nonEmpty()) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   914
                    checkExtends(args.head.pos(),
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   915
                                 args.head.type,
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   916
                                 tvars.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   917
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   918
                    tvars = tvars.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   919
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   920
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   921
                checkCapture(tree);
3765
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   922
            }
9548183897cb 6840638: Project Coin: Improved Type Inference for Generic Instance Creation (aka 'diamond')
mcimadamore
parents: 3661
diff changeset
   923
            if (tree.type.tag == CLASS || tree.type.tag == FORALL) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   924
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
   925
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
   926
                if (tree.type.getEnclosingType().isRaw())
06bc494ca11e Initial load
duke
parents:
diff changeset
   927
                    log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
06bc494ca11e Initial load
duke
parents:
diff changeset
   928
                if (tree.clazz.getTag() == JCTree.SELECT)
06bc494ca11e Initial load
duke
parents:
diff changeset
   929
                    visitSelectInternal((JCFieldAccess)tree.clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
   930
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   931
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   932
06bc494ca11e Initial load
duke
parents:
diff changeset
   933
        public void visitTypeParameter(JCTypeParameter tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   934
            validate(tree.bounds, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   935
            checkClassBounds(tree.pos(), tree.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
   936
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   937
06bc494ca11e Initial load
duke
parents:
diff changeset
   938
        @Override
06bc494ca11e Initial load
duke
parents:
diff changeset
   939
        public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   940
            if (tree.inner != null)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   941
                validate(tree.inner, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   942
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   943
06bc494ca11e Initial load
duke
parents:
diff changeset
   944
        public void visitSelect(JCFieldAccess tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   945
            if (tree.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   946
                visitSelectInternal(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
   947
06bc494ca11e Initial load
duke
parents:
diff changeset
   948
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
   949
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
   950
                if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
   951
                    log.error(tree.pos(), "improperly.formed.type.param.missing");
06bc494ca11e Initial load
duke
parents:
diff changeset
   952
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   953
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   954
        public void visitSelectInternal(JCFieldAccess tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   955
            if (tree.type.tsym.isStatic() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   956
                tree.selected.type.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   957
                // The enclosing type is not a class, so we are
06bc494ca11e Initial load
duke
parents:
diff changeset
   958
                // looking at a static member type.  However, the
06bc494ca11e Initial load
duke
parents:
diff changeset
   959
                // qualifying expression is parameterized.
06bc494ca11e Initial load
duke
parents:
diff changeset
   960
                log.error(tree.pos(), "cant.select.static.class.from.param.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
   961
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   962
                // otherwise validate the rest of the expression
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   963
                tree.selected.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   964
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   965
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   966
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
   967
        public void visitAnnotatedType(JCAnnotatedType tree) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
   968
            tree.underlyingType.accept(this);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
   969
        }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
   970
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   971
        /** Default visitor method: do nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
   972
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
   973
        public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   974
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   975
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   976
        Env<AttrContext> env;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   977
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   978
06bc494ca11e Initial load
duke
parents:
diff changeset
   979
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   980
 * Exception checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   981
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   982
06bc494ca11e Initial load
duke
parents:
diff changeset
   983
    /* The following methods treat classes as sets that contain
06bc494ca11e Initial load
duke
parents:
diff changeset
   984
     * the class itself and all their subclasses
06bc494ca11e Initial load
duke
parents:
diff changeset
   985
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   986
06bc494ca11e Initial load
duke
parents:
diff changeset
   987
    /** Is given type a subtype of some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
   988
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   989
    boolean subset(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   990
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   991
            if (types.isSubtype(t, l.head)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   992
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   993
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   994
06bc494ca11e Initial load
duke
parents:
diff changeset
   995
    /** Is given type a subtype or supertype of
06bc494ca11e Initial load
duke
parents:
diff changeset
   996
     *  some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
   997
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   998
    boolean intersects(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   999
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1000
            if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1001
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1002
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1003
06bc494ca11e Initial load
duke
parents:
diff changeset
  1004
    /** Add type set to given type list, unless it is a subclass of some class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1005
     *  in the list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1006
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1007
    List<Type> incl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1008
        return subset(t, ts) ? ts : excl(t, ts).prepend(t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1009
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1010
06bc494ca11e Initial load
duke
parents:
diff changeset
  1011
    /** Remove type set from type set list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1012
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1013
    List<Type> excl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1014
        if (ts.isEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1015
            return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1016
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1017
            List<Type> ts1 = excl(t, ts.tail);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1018
            if (types.isSubtype(ts.head, t)) return ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1019
            else if (ts1 == ts.tail) return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1020
            else return ts1.prepend(ts.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1021
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1022
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1023
06bc494ca11e Initial load
duke
parents:
diff changeset
  1024
    /** Form the union of two type set lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1025
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1026
    List<Type> union(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1027
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1028
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1029
            ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1030
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1031
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1032
06bc494ca11e Initial load
duke
parents:
diff changeset
  1033
    /** Form the difference of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1034
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1035
    List<Type> diff(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1036
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1037
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1038
            ts = excl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1039
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1040
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1041
06bc494ca11e Initial load
duke
parents:
diff changeset
  1042
    /** Form the intersection of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1043
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1044
    public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1045
        List<Type> ts = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1046
        for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1047
            if (subset(l.head, ts2)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1048
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1049
            if (subset(l.head, ts1)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1050
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1051
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1052
06bc494ca11e Initial load
duke
parents:
diff changeset
  1053
    /** Is exc an exception symbol that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1054
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1055
    boolean isUnchecked(ClassSymbol exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1056
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1057
            exc.kind == ERR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1058
            exc.isSubClass(syms.errorType.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1059
            exc.isSubClass(syms.runtimeExceptionType.tsym, types);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1060
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1061
06bc494ca11e Initial load
duke
parents:
diff changeset
  1062
    /** Is exc an exception type that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1063
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1064
    boolean isUnchecked(Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1065
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1066
            (exc.tag == TYPEVAR) ? isUnchecked(types.supertype(exc)) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1067
            (exc.tag == CLASS) ? isUnchecked((ClassSymbol)exc.tsym) :
06bc494ca11e Initial load
duke
parents:
diff changeset
  1068
            exc.tag == BOT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1069
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1070
06bc494ca11e Initial load
duke
parents:
diff changeset
  1071
    /** Same, but handling completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1072
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1073
    boolean isUnchecked(DiagnosticPosition pos, Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1074
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1075
            return isUnchecked(exc);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1076
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1077
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1078
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1079
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1080
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1081
06bc494ca11e Initial load
duke
parents:
diff changeset
  1082
    /** Is exc handled by given exception list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1083
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1084
    boolean isHandled(Type exc, List<Type> handled) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1085
        return isUnchecked(exc) || subset(exc, handled);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1086
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1087
06bc494ca11e Initial load
duke
parents:
diff changeset
  1088
    /** Return all exceptions in thrown list that are not in handled list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1089
     *  @param thrown     The list of thrown exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1090
     *  @param handled    The list of handled exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1091
     */
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1092
    List<Type> unhandled(List<Type> thrown, List<Type> handled) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1093
        List<Type> unhandled = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1094
        for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1095
            if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1096
        return unhandled;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1098
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
 * Overriding/Implementation checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1101
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
06bc494ca11e Initial load
duke
parents:
diff changeset
  1103
    /** The level of access protection given by a flag set,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1104
     *  where PRIVATE is highest and PUBLIC is lowest.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
    static int protection(long flags) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1107
        switch ((short)(flags & AccessFlags)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1108
        case PRIVATE: return 3;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1109
        case PROTECTED: return 1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1110
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1111
        case PUBLIC: return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1112
        case 0: return 2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1113
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1114
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1115
06bc494ca11e Initial load
duke
parents:
diff changeset
  1116
    /** A customized "cannot override" error message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1117
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1118
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1119
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1120
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1121
    Object cannotOverride(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1122
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1123
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1124
            key = "cant.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1125
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1126
            key = "cant.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1127
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1128
            key = "clashes.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1129
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1130
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1131
06bc494ca11e Initial load
duke
parents:
diff changeset
  1132
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1133
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1134
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1135
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1136
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1137
    Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1138
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1139
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1140
            key = "unchecked.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1141
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1142
            key = "unchecked.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1143
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1144
            key = "unchecked.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1145
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1146
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1147
06bc494ca11e Initial load
duke
parents:
diff changeset
  1148
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1149
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1150
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1151
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1152
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1153
    Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1154
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1155
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1156
            key = "varargs.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
        else  if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1158
            key = "varargs.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1160
            key = "varargs.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1161
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1162
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
    /** Check that this method conforms with overridden method 'other'.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
     *  where `origin' is the class where checking started.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
     *  Complications:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
     *  (1) Do not check overriding of synthetic methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
     *      (reason: they might be final).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
     *      todo: check whether this is still necessary.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
     *  (2) Admit the case where an interface proxy throws fewer exceptions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
     *      than the method it implements. Augment the proxy methods with the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
     *      undeclared exceptions in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
     *  (3) When generics are enabled, admit the case where an interface proxy
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
     *      has a result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
     *      extended by the result type of the method it implements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
     *      Change the proxies result type to the smaller type in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
     *  @param tree         The tree from which positions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
     *                      are extracted for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1180
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1181
     *  @param other        The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1182
     *  @param origin       The class of which the overriding method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1183
     *                      is a member.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1184
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1185
    void checkOverride(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1186
                       MethodSymbol m,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1187
                       MethodSymbol other,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1188
                       ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1189
        // Don't check overriding of synthetic methods or by bridge methods.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1190
        if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1191
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1192
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1193
06bc494ca11e Initial load
duke
parents:
diff changeset
  1194
        // Error if static method overrides instance method (JLS 8.4.6.2).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1195
        if ((m.flags() & STATIC) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1196
                   (other.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1197
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1198
                      cannotOverride(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1199
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1200
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1201
06bc494ca11e Initial load
duke
parents:
diff changeset
  1202
        // Error if instance method overrides static or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1203
        // method (JLS 8.4.6.1).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1204
        if ((other.flags() & FINAL) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1205
                 (m.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1206
                 (other.flags() & STATIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1207
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1208
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1209
                      asFlagSet(other.flags() & (FINAL | STATIC)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1210
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1211
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1212
06bc494ca11e Initial load
duke
parents:
diff changeset
  1213
        if ((m.owner.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1214
            // handled in validateAnnotationMethod
06bc494ca11e Initial load
duke
parents:
diff changeset
  1215
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1216
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1217
06bc494ca11e Initial load
duke
parents:
diff changeset
  1218
        // Error if overriding method has weaker access (JLS 8.4.6.3).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1219
        if ((origin.flags() & INTERFACE) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1220
                 protection(m.flags()) > protection(other.flags())) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1221
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1222
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1223
                      other.flags() == 0 ?
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1224
                          Flag.PACKAGE :
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1225
                          asFlagSet(other.flags() & AccessFlags));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1226
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1227
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1228
06bc494ca11e Initial load
duke
parents:
diff changeset
  1229
        Type mt = types.memberType(origin.type, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1230
        Type ot = types.memberType(origin.type, other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1231
        // Error if overriding result type is different
06bc494ca11e Initial load
duke
parents:
diff changeset
  1232
        // (or, in the case of generics mode, not a subtype) of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1233
        // overridden result type. We have to rename any type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  1234
        // before comparing types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1235
        List<Type> mtvars = mt.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1236
        List<Type> otvars = ot.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1237
        Type mtres = mt.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1238
        Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1239
06bc494ca11e Initial load
duke
parents:
diff changeset
  1240
        overrideWarner.warned = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1241
        boolean resultTypesOK =
1874
891c2d6823bb 6797463: 6557199 breaks the jax-ws workspace
tbell
parents: 1868
diff changeset
  1242
            types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
        if (!resultTypesOK) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
            if (!source.allowCovariantReturns() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1245
                m.owner != origin &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
                m.owner.isSubClass(other.owner, types)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1247
                // allow limited interoperability with covariant returns
06bc494ca11e Initial load
duke
parents:
diff changeset
  1248
            } else {
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1249
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1250
                          "override.incompatible.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1251
                          cannotOverride(m, other),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1252
                          mtres, otres);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1253
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1255
        } else if (overrideWarner.warned) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1257
                    "override.unchecked.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1258
                    uncheckedOverrides(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1259
                    mtres, otres);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
        // Error if overriding method throws an exception not reported
06bc494ca11e Initial load
duke
parents:
diff changeset
  1263
        // by overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
        List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1265
        List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1266
        List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1267
        if (unhandledErased.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
                      "override.meth.doesnt.throw",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
                      cannotOverride(m, other),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1271
                      unhandledUnerased.head);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1272
            return;
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1273
        }
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1274
        else if (unhandledUnerased.nonEmpty()) {
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1275
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1276
                          "override.unchecked.thrown",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1277
                         cannotOverride(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1278
                         unhandledUnerased.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1279
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1280
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1281
06bc494ca11e Initial load
duke
parents:
diff changeset
  1282
        // Optional warning if varargs don't agree
06bc494ca11e Initial load
duke
parents:
diff changeset
  1283
        if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1284
            && lint.isEnabled(Lint.LintCategory.OVERRIDES)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1285
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1286
                        ((m.flags() & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1287
                        ? "override.varargs.missing"
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
                        : "override.varargs.extra",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1289
                        varargsOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1290
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1291
06bc494ca11e Initial load
duke
parents:
diff changeset
  1292
        // Warn if instance method overrides bridge method (compiler spec ??)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1293
        if ((other.flags() & BRIDGE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1294
            log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1295
                        uncheckedOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1296
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
        // Warn if a deprecated method overridden by a non-deprecated one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1299
        if ((other.flags() & DEPRECATED) != 0
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
            && (m.flags() & DEPRECATED) == 0
06bc494ca11e Initial load
duke
parents:
diff changeset
  1301
            && m.outermostClass() != other.outermostClass()
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
            && !isDeprecatedOverrideIgnorable(other, origin)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
            warnDeprecated(TreeInfo.diagnosticPositionFor(m, tree), other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1307
        private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1308
            // If the method, m, is defined in an interface, then ignore the issue if the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1309
            // is only inherited via a supertype and also implemented in the supertype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1310
            // because in that case, we will rediscover the issue when examining the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1311
            // in the supertype.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1312
            // If the method, m, is not defined in an interface, then the only time we need to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1313
            // address the issue is when the method is the supertype implemementation: any other
06bc494ca11e Initial load
duke
parents:
diff changeset
  1314
            // case, we will have dealt with when examining the supertype classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1315
            ClassSymbol mc = m.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1316
            Type st = types.supertype(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1317
            if (st.tag != CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1318
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1319
            MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1320
06bc494ca11e Initial load
duke
parents:
diff changeset
  1321
            if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1322
                List<Type> intfs = types.interfaces(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1323
                return (intfs.contains(mc.type) ? false : (stimpl != null));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1324
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1325
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
                return (stimpl != m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1328
06bc494ca11e Initial load
duke
parents:
diff changeset
  1329
06bc494ca11e Initial load
duke
parents:
diff changeset
  1330
    // used to check if there were any unchecked conversions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1331
    Warner overrideWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1332
06bc494ca11e Initial load
duke
parents:
diff changeset
  1333
    /** Check that a class does not inherit two concrete methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1334
     *  with the same signature.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1335
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1336
     *  @param site         The class type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1337
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1338
    public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1339
        Type sup = types.supertype(site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1340
        if (sup.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1341
06bc494ca11e Initial load
duke
parents:
diff changeset
  1342
        for (Type t1 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1343
             t1.tsym.type.isParameterized();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1344
             t1 = types.supertype(t1)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1345
            for (Scope.Entry e1 = t1.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1346
                 e1 != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1347
                 e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1348
                Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1349
                if (s1.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1350
                    (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
                    !s1.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
                    ((MethodSymbol)s1).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1353
                                                      types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1354
                                                      true) != s1)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1355
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1356
                Type st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1357
                int s1ArgsLength = st1.getParameterTypes().length();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1358
                if (st1 == s1.type) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1359
06bc494ca11e Initial load
duke
parents:
diff changeset
  1360
                for (Type t2 = sup;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1361
                     t2.tag == CLASS;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1362
                     t2 = types.supertype(t2)) {
508
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1363
                    for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1364
                         e2.scope != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1365
                         e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
                        Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1367
                        if (s2 == s1 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1368
                            s2.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1369
                            (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1370
                            s2.type.getParameterTypes().length() != s1ArgsLength ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1371
                            !s2.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1372
                            ((MethodSymbol)s2).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
                                                              types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1374
                                                              true) != s2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1375
                            continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1376
                        Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1377
                        if (types.overrideEquivalent(st1, st2))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1378
                            log.error(pos, "concrete.inheritance.conflict",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
                                      s1, t1, s2, t2, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1380
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1381
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1382
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1383
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1384
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1385
06bc494ca11e Initial load
duke
parents:
diff changeset
  1386
    /** Check that classes (or interfaces) do not each define an abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1387
     *  method with same name and arguments but incompatible return types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1388
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1389
     *  @param t1           The first argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
     *  @param t2           The second argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1392
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1393
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1394
                                            Type t2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1395
        return checkCompatibleAbstracts(pos, t1, t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1396
                                        types.makeCompoundType(t1, t2));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1397
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1398
06bc494ca11e Initial load
duke
parents:
diff changeset
  1399
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1400
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1401
                                            Type t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1402
                                            Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1403
        Symbol sym = firstIncompatibility(t1, t2, site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1404
        if (sym != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1405
            log.error(pos, "types.incompatible.diff.ret",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1406
                      t1, t2, sym.name +
06bc494ca11e Initial load
duke
parents:
diff changeset
  1407
                      "(" + types.memberType(t2, sym).getParameterTypes() + ")");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1408
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1409
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1410
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1411
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1412
06bc494ca11e Initial load
duke
parents:
diff changeset
  1413
    /** Return the first method which is defined with same args
06bc494ca11e Initial load
duke
parents:
diff changeset
  1414
     *  but different return types in two given interfaces, or null if none
06bc494ca11e Initial load
duke
parents:
diff changeset
  1415
     *  exists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1416
     *  @param t1     The first type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1417
     *  @param t2     The second type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1418
     *  @param site   The most derived type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1419
     *  @returns symbol from t2 that conflicts with one in t1.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1420
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1421
    private Symbol firstIncompatibility(Type t1, Type t2, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1422
        Map<TypeSymbol,Type> interfaces1 = new HashMap<TypeSymbol,Type>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1423
        closure(t1, interfaces1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1424
        Map<TypeSymbol,Type> interfaces2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1425
        if (t1 == t2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1426
            interfaces2 = interfaces1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1427
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1428
            closure(t2, interfaces1, interfaces2 = new HashMap<TypeSymbol,Type>());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1429
06bc494ca11e Initial load
duke
parents:
diff changeset
  1430
        for (Type t3 : interfaces1.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1431
            for (Type t4 : interfaces2.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1432
                Symbol s = firstDirectIncompatibility(t3, t4, site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1433
                if (s != null) return s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1434
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1435
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1436
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1437
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1438
06bc494ca11e Initial load
duke
parents:
diff changeset
  1439
    /** Compute all the supertypes of t, indexed by type symbol. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1440
    private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1441
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1442
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1443
            closure(types.supertype(t), typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1444
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1445
                closure(i, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1446
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1447
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1448
06bc494ca11e Initial load
duke
parents:
diff changeset
  1449
    /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1450
    private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1451
        if (t.tag != CLASS) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1452
        if (typesSkip.get(t.tsym) != null) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1453
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1454
            closure(types.supertype(t), typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1455
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1456
                closure(i, typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1457
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1458
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1459
06bc494ca11e Initial load
duke
parents:
diff changeset
  1460
    /** Return the first method in t2 that conflicts with a method from t1. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1461
    private Symbol firstDirectIncompatibility(Type t1, Type t2, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1462
        for (Scope.Entry e1 = t1.tsym.members().elems; e1 != null; e1 = e1.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1463
            Symbol s1 = e1.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1464
            Type st1 = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1465
            if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1466
            Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1467
            if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1468
            for (Scope.Entry e2 = t2.tsym.members().lookup(s1.name); e2.scope != null; e2 = e2.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
                Symbol s2 = e2.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
                if (s1 == s2) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
                if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types)) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
                if (st1 == null) st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1473
                Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
                if (types.overrideEquivalent(st1, st2)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
                    List<Type> tvars1 = st1.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
                    List<Type> tvars2 = st2.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
                    Type rt1 = st1.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
                    Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1479
                    boolean compat =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
                        types.isSameType(rt1, rt2) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1481
                        rt1.tag >= CLASS && rt2.tag >= CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1482
                        (types.covariantReturnType(rt1, rt2, Warner.noWarnings) ||
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1483
                         types.covariantReturnType(rt2, rt1, Warner.noWarnings)) ||
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1484
                         checkCommonOverriderIn(s1,s2,site);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1485
                    if (!compat) return s2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1486
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1487
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1489
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1490
    }
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1491
    //WHERE
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1492
    boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1493
        Map<TypeSymbol,Type> supertypes = new HashMap<TypeSymbol,Type>();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1494
        Type st1 = types.memberType(site, s1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1495
        Type st2 = types.memberType(site, s2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1496
        closure(site, supertypes);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1497
        for (Type t : supertypes.values()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1498
            for (Scope.Entry e = t.tsym.members().lookup(s1.name); e.scope != null; e = e.next()) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1499
                Symbol s3 = e.sym;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1500
                if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1501
                Type st3 = types.memberType(site,s3);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1502
                if (types.overrideEquivalent(st3, st1) && types.overrideEquivalent(st3, st2)) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1503
                    if (s3.owner == site.tsym) {
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1504
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1505
                    }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1506
                    List<Type> tvars1 = st1.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1507
                    List<Type> tvars2 = st2.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1508
                    List<Type> tvars3 = st3.getTypeArguments();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1509
                    Type rt1 = st1.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1510
                    Type rt2 = st2.getReturnType();
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1511
                    Type rt13 = types.subst(st3.getReturnType(), tvars3, tvars1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1512
                    Type rt23 = types.subst(st3.getReturnType(), tvars3, tvars2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1513
                    boolean compat =
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1514
                        rt13.tag >= CLASS && rt23.tag >= CLASS &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1515
                        (types.covariantReturnType(rt13, rt1, Warner.noWarnings) &&
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1516
                         types.covariantReturnType(rt23, rt2, Warner.noWarnings));
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1517
                    if (compat)
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1518
                        return true;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1519
                }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1520
            }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1521
        }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1522
        return false;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1523
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
    /** Check that a given method conforms with any method it overrides.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
     *  @param tree         The tree from which positions are extracted
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
     *                      for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
    void checkOverride(JCTree tree, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
        ClassSymbol origin = (ClassSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
        if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
            if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
                log.error(tree.pos(), "enum.no.finalize");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1535
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1536
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1537
        for (Type t = types.supertype(origin.type); t.tag == CLASS;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1538
             t = types.supertype(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1539
            TypeSymbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1540
            Scope.Entry e = c.members().lookup(m.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1541
            while (e.scope != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1542
                if (m.overrides(e.sym, origin, types, false))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1543
                    checkOverride(tree, m, (MethodSymbol)e.sym, origin);
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1544
                else if (e.sym.kind == MTH &&
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1545
                        e.sym.isInheritedIn(origin, types) &&
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1546
                        (e.sym.flags() & SYNTHETIC) == 0 &&
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1547
                        !m.isConstructor()) {
508
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1548
                    Type er1 = m.erasure(types);
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1549
                    Type er2 = e.sym.erasure(types);
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1550
                    if (types.isSameTypes(er1.getParameterTypes(),
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  1551
                            er2.getParameterTypes())) {
508
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1552
                            log.error(TreeInfo.diagnosticPositionFor(m, tree),
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1553
                                    "name.clash.same.erasure.no.override",
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1554
                                    m, m.location(),
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1555
                                    e.sym, e.sym.location());
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1556
                    }
118e500e2e50 5009937: hiding versus generics versus binary compatibility
mcimadamore
parents: 169
diff changeset
  1557
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1558
                e = e.next();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1559
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
    /** Check that all abstract members of given class have definitions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1564
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
     *  @param c            The class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
    void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1569
            MethodSymbol undef = firstUndef(c, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
            if (undef != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
                if ((c.flags() & ENUM) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
                    types.supertype(c.type).tsym == syms.enumSym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
                    (c.flags() & FINAL) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
                    // add the ABSTRACT flag to an enum
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
                    c.flags_field |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
                    MethodSymbol undef1 =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
                        new MethodSymbol(undef.flags(), undef.name,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
                                         types.memberType(c.type, undef), undef.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
                    log.error(pos, "does.not.override.abstract",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
                              c, undef1, undef1.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1586
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1587
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1588
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1589
        /** Return first abstract member of class `c' that is not defined
06bc494ca11e Initial load
duke
parents:
diff changeset
  1590
         *  in `impl', null if there is none.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1591
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1592
        private MethodSymbol firstUndef(ClassSymbol impl, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1593
            MethodSymbol undef = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1594
            // Do not bother to search in classes that are not abstract,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1595
            // since they cannot have abstract members.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1596
            if (c == impl || (c.flags() & (ABSTRACT | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1597
                Scope s = c.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1598
                for (Scope.Entry e = s.elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1599
                     undef == null && e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1600
                     e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1601
                    if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1602
                        (e.sym.flags() & (ABSTRACT|IPROXY)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1603
                        MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
                        MethodSymbol implmeth = absmeth.implementation(impl, types, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1605
                        if (implmeth == null || implmeth == absmeth)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1606
                            undef = absmeth;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1607
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1608
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1609
                if (undef == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1610
                    Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1611
                    if (st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
                        undef = firstUndef(impl, (ClassSymbol)st.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1613
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1614
                for (List<Type> l = types.interfaces(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1615
                     undef == null && l.nonEmpty();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1616
                     l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1617
                    undef = firstUndef(impl, (ClassSymbol)l.head.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1618
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1619
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1620
            return undef;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1621
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1622
06bc494ca11e Initial load
duke
parents:
diff changeset
  1623
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1624
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1625
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1626
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1627
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1629
    void checkNonCyclic(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1630
        checkNonCyclicInternal(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1631
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1632
06bc494ca11e Initial load
duke
parents:
diff changeset
  1633
06bc494ca11e Initial load
duke
parents:
diff changeset
  1634
    void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1635
        checkNonCyclic1(pos, t, List.<TypeVar>nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1637
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1638
    private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
        final TypeVar tv;
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1640
        if  (t.tag == TYPEVAR && (t.tsym.flags() & UNATTRIBUTED) != 0)
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  1641
            return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1642
        if (seen.contains(t)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
            tv = (TypeVar)t;
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1644
            tv.bound = types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
            log.error(pos, "cyclic.inheritance", t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
        } else if (t.tag == TYPEVAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1647
            tv = (TypeVar)t;
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  1648
            seen = seen.prepend(tv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1649
            for (Type b : types.getBounds(tv))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1650
                checkNonCyclic1(pos, b, seen);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1651
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1652
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1653
06bc494ca11e Initial load
duke
parents:
diff changeset
  1654
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1655
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1656
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1657
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1658
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1659
     *  @returns        True if the check completed on all attributed classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1660
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
    private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1662
        boolean complete = true; // was the check complete?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1663
        //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  1664
        Symbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1665
        if ((c.flags_field & ACYCLIC) != 0) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1666
06bc494ca11e Initial load
duke
parents:
diff changeset
  1667
        if ((c.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1668
            noteCyclic(pos, (ClassSymbol)c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1669
        } else if (!c.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1670
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1671
                c.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1672
                if (c.type.tag == CLASS) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1673
                    ClassType clazz = (ClassType)c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
                    if (clazz.interfaces_field != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1675
                        for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1676
                            complete &= checkNonCyclicInternal(pos, l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1677
                    if (clazz.supertype_field != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
                        Type st = clazz.supertype_field;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
                        if (st != null && st.tag == CLASS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1680
                            complete &= checkNonCyclicInternal(pos, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1682
                    if (c.owner.kind == TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1683
                        complete &= checkNonCyclicInternal(pos, c.owner.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1684
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1685
            } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1686
                c.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1687
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1688
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1689
        if (complete)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1690
            complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.completer == null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
        if (complete) c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1692
        return complete;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1694
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
    /** Note that we found an inheritance cycle. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
    private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
        log.error(pos, "cyclic.inheritance", c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1698
        for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1699
            l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
        Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1701
        if (st.tag == CLASS)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1702
            ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  1703
        c.type = types.createErrorType(c, c.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1704
        c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
06bc494ca11e Initial load
duke
parents:
diff changeset
  1707
    /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  1708
     *  method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1709
     *  @param tree         The class definition whose members are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1710
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1711
    void checkImplementations(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
        checkImplementations(tree, tree.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
        /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
         *  method in `ic' conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
        void checkImplementations(JCClassDecl tree, ClassSymbol ic) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1719
            ClassSymbol origin = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
            for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
                ClassSymbol lc = (ClassSymbol)l.head.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
                if ((allowGenerics || origin != lc) && (lc.flags() & ABSTRACT) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
                    for (Scope.Entry e=lc.members().elems; e != null; e=e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1724
                        if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1725
                            (e.sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1726
                            MethodSymbol absmeth = (MethodSymbol)e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1727
                            MethodSymbol implmeth = absmeth.implementation(origin, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1728
                            if (implmeth != null && implmeth != absmeth &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1729
                                (implmeth.owner.flags() & INTERFACE) ==
06bc494ca11e Initial load
duke
parents:
diff changeset
  1730
                                (origin.flags() & INTERFACE)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1731
                                // don't check if implmeth is in a class, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
  1732
                                // origin is an interface. This case arises only
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
                                // if implmeth is declared in Object. The reason is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1734
                                // that interfaces really don't inherit from
06bc494ca11e Initial load
duke
parents:
diff changeset
  1735
                                // Object it's just that the compiler represents
06bc494ca11e Initial load
duke
parents:
diff changeset
  1736
                                // things that way.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1737
                                checkOverride(tree, implmeth, absmeth, origin);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1738
                            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1740
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1741
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1742
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1743
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1744
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
    /** Check that all abstract methods implemented by a class are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1746
     *  mutually compatible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1747
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1748
     *  @param c            The class whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1749
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1750
    void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1751
        List<Type> supertypes = types.interfaces(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1752
        Type supertype = types.supertype(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1753
        if (supertype.tag == CLASS &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1754
            (supertype.tsym.flags() & ABSTRACT) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1755
            supertypes = supertypes.prepend(supertype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1756
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1757
            if (allowGenerics && !l.head.getTypeArguments().isEmpty() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1758
                !checkCompatibleAbstracts(pos, l.head, l.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1759
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1760
            for (List<Type> m = supertypes; m != l; m = m.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1761
                if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
        checkCompatibleConcretes(pos, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1766
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1767
    void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1768
        for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1769
            for (Scope.Entry e = ct.tsym.members().lookup(sym.name); e.scope == ct.tsym.members(); e = e.next()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1770
                // VM allows methods and variables with differing types
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1771
                if (sym.kind == e.sym.kind &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1772
                    types.isSameType(types.erasure(sym.type), types.erasure(e.sym.type)) &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1773
                    sym != e.sym &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1774
                    (sym.flags() & Flags.SYNTHETIC) != (e.sym.flags() & Flags.SYNTHETIC) &&
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1775
                    (sym.flags() & BRIDGE) == 0 && (e.sym.flags() & BRIDGE) == 0) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1776
                    syntheticError(pos, (e.sym.flags() & SYNTHETIC) == 0 ? e.sym : sym);
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1777
                    return;
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1778
                }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1779
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1780
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1781
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1782
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1783
    /** Report a conflict between a user symbol and a synthetic symbol.
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1784
     */
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1785
    private void syntheticError(DiagnosticPosition pos, Symbol sym) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1786
        if (!sym.type.isErroneous()) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1787
            if (warnOnSyntheticConflicts) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1788
                log.warning(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1789
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1790
            else {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1791
                log.error(pos, "synthetic.name.conflict", sym, sym.location());
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1792
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1793
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1794
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  1795
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1796
    /** Check that class c does not implement directly or indirectly
06bc494ca11e Initial load
duke
parents:
diff changeset
  1797
     *  the same parameterized interface with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1799
     *  @param type         The type whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1800
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1801
    void checkClassBounds(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1802
        checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1803
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1804
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1805
        /** Enter all interfaces of type `type' into the hash table `seensofar'
06bc494ca11e Initial load
duke
parents:
diff changeset
  1806
         *  with their class symbol as key and their type as value. Make
06bc494ca11e Initial load
duke
parents:
diff changeset
  1807
         *  sure no class is entered with two different types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1808
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1809
        void checkClassBounds(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1810
                              Map<TypeSymbol,Type> seensofar,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
                              Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1812
            if (type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1813
            for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1814
                Type it = l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1815
                Type oldit = seensofar.put(it.tsym, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1816
                if (oldit != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1817
                    List<Type> oldparams = oldit.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1818
                    List<Type> newparams = it.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1819
                    if (!types.containsTypeEquivalent(oldparams, newparams))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1820
                        log.error(pos, "cant.inherit.diff.arg",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1821
                                  it.tsym, Type.toString(oldparams),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1822
                                  Type.toString(newparams));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1823
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1824
                checkClassBounds(pos, seensofar, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1825
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1826
            Type st = types.supertype(type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1827
            if (st != null) checkClassBounds(pos, seensofar, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1828
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1829
06bc494ca11e Initial load
duke
parents:
diff changeset
  1830
    /** Enter interface into into set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1831
     *  If it existed already, issue a "repeated interface" error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1832
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1833
    void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1834
        if (its.contains(it))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1835
            log.error(pos, "repeated.interface");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1836
        else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1837
            its.add(it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1838
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1839
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1840
06bc494ca11e Initial load
duke
parents:
diff changeset
  1841
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1842
 * Check annotations
06bc494ca11e Initial load
duke
parents:
diff changeset
  1843
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1844
06bc494ca11e Initial load
duke
parents:
diff changeset
  1845
    /** Annotation types are restricted to primitives, String, an
06bc494ca11e Initial load
duke
parents:
diff changeset
  1846
     *  enum, an annotation, Class, Class<?>, Class<? extends
06bc494ca11e Initial load
duke
parents:
diff changeset
  1847
     *  Anything>, arrays of the preceding.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1848
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1849
    void validateAnnotationType(JCTree restype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1850
        // restype may be null if an error occurred, so don't bother validating it
06bc494ca11e Initial load
duke
parents:
diff changeset
  1851
        if (restype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1852
            validateAnnotationType(restype.pos(), restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1853
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1854
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1855
06bc494ca11e Initial load
duke
parents:
diff changeset
  1856
    void validateAnnotationType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1857
        if (type.isPrimitive()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
        if (types.isSameType(type, syms.stringType)) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1859
        if ((type.tsym.flags() & Flags.ENUM) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1860
        if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1861
        if (types.lowerBound(type).tsym == syms.classType.tsym) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1862
        if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1863
            validateAnnotationType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1864
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1865
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1866
        log.error(pos, "invalid.annotation.member.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1867
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1868
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  1870
     * "It is also a compile-time error if any method declared in an
06bc494ca11e Initial load
duke
parents:
diff changeset
  1871
     * annotation type has a signature that is override-equivalent to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1872
     * that of any public or protected method declared in class Object
06bc494ca11e Initial load
duke
parents:
diff changeset
  1873
     * or in the interface annotation.Annotation."
06bc494ca11e Initial load
duke
parents:
diff changeset
  1874
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1875
     * @jls3 9.6 Annotation Types
06bc494ca11e Initial load
duke
parents:
diff changeset
  1876
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1877
    void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1878
        for (Type sup = syms.annotationType; sup.tag == CLASS; sup = types.supertype(sup)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1879
            Scope s = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
            for (Scope.Entry e = s.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1881
                if (e.sym.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1882
                    (e.sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1883
                    types.overrideEquivalent(m.type, e.sym.type))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1884
                    log.error(pos, "intf.annotation.member.clash", e.sym, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1885
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1886
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1887
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
    /** Check the annotations of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1890
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1891
    public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
        if (skipAnnotations) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
        for (JCAnnotation a : annotations)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
            validateAnnotation(a, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1897
    /** Check the type annotations
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1898
     */
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1899
    public void validateTypeAnnotations(List<JCTypeAnnotation> annotations, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1900
        if (skipAnnotations) return;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1901
        for (JCTypeAnnotation a : annotations)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1902
            validateTypeAnnotation(a, isTypeParameter);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1903
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1904
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1905
    /** Check an annotation of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1906
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1907
    public void validateAnnotation(JCAnnotation a, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1908
        validateAnnotation(a);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1909
06bc494ca11e Initial load
duke
parents:
diff changeset
  1910
        if (!annotationApplicable(a, s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1911
            log.error(a.pos(), "annotation.type.not.applicable");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1912
06bc494ca11e Initial load
duke
parents:
diff changeset
  1913
        if (a.annotationType.type.tsym == syms.overrideType.tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1914
            if (!isOverrider(s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1915
                log.error(a.pos(), "method.does.not.override.superclass");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1917
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1918
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1919
    public void validateTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1920
        if (a.type == null)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1921
            throw new AssertionError("annotation tree hasn't been attributed yet: " + a);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1922
        validateAnnotation(a);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1923
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1924
        if (!isTypeAnnotation(a, isTypeParameter))
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1925
            log.error(a.pos(), "annotation.type.not.applicable");
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1926
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1927
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
    /** Is s a method symbol that overrides a method in a superclass? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
    boolean isOverrider(Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1930
        if (s.kind != MTH || s.isStatic())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1931
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
        MethodSymbol m = (MethodSymbol)s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1933
        TypeSymbol owner = (TypeSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1934
        for (Type sup : types.closure(owner.type)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
            if (sup == owner.type)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1936
                continue; // skip "this"
06bc494ca11e Initial load
duke
parents:
diff changeset
  1937
            Scope scope = sup.tsym.members();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1938
            for (Scope.Entry e = scope.lookup(m.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1939
                if (!e.sym.isStatic() && m.overrides(e.sym, owner, types, true))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1940
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1941
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1944
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1945
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1946
    /** Is the annotation applicable to type annotations */
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1947
    boolean isTypeAnnotation(JCTypeAnnotation a, boolean isTypeParameter) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1948
        Attribute.Compound atTarget =
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1949
            a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1950
        if (atTarget == null) return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1951
        Attribute atValue = atTarget.member(names.value);
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1952
        if (!(atValue instanceof Attribute.Array)) return true; // error recovery
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1953
        Attribute.Array arr = (Attribute.Array) atValue;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1954
        for (Attribute app : arr.values) {
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1955
            if (!(app instanceof Attribute.Enum)) return true; // recovery
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1956
            Attribute.Enum e = (Attribute.Enum) app;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1957
            if (!isTypeParameter && e.value.name == names.TYPE_USE)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1958
                return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1959
            else if (isTypeParameter && e.value.name == names.TYPE_PARAMETER)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1960
                return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1961
        }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1962
        return false;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1963
    }
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  1964
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1965
    /** Is the annotation applicable to the symbol? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
    boolean annotationApplicable(JCAnnotation a, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1967
        Attribute.Compound atTarget =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1968
            a.annotationType.type.tsym.attribute(syms.annotationTargetType.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
        if (atTarget == null) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
        Attribute atValue = atTarget.member(names.value);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
        if (!(atValue instanceof Attribute.Array)) return true; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
        Attribute.Array arr = (Attribute.Array) atValue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
        for (Attribute app : arr.values) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
            if (!(app instanceof Attribute.Enum)) return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  1975
            Attribute.Enum e = (Attribute.Enum) app;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
            if (e.value.name == names.TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
                { if (s.kind == TYP) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1978
            else if (e.value.name == names.FIELD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1979
                { if (s.kind == VAR && s.owner.kind != MTH) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
            else if (e.value.name == names.METHOD)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1981
                { if (s.kind == MTH && !s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1982
            else if (e.value.name == names.PARAMETER)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
                { if (s.kind == VAR &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
                      s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1985
                      (s.flags() & PARAMETER) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1986
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1987
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1988
            else if (e.value.name == names.CONSTRUCTOR)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
                { if (s.kind == MTH && s.isConstructor()) return true; }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
            else if (e.value.name == names.LOCAL_VARIABLE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
                { if (s.kind == VAR && s.owner.kind == MTH &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1992
                      (s.flags() & PARAMETER) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1995
            else if (e.value.name == names.ANNOTATION_TYPE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1996
                { if (s.kind == TYP && (s.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1997
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1998
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1999
            else if (e.value.name == names.PACKAGE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2000
                { if (s.kind == PCK) return true; }
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2001
            else if (e.value.name == names.TYPE_USE)
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2002
                { if (s.kind == TYP ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2003
                      s.kind == VAR ||
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2004
                      (s.kind == MTH && !s.isConstructor() &&
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2005
                       s.type.getReturnType().tag != VOID))
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2006
                    return true;
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  2007
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2008
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2009
                return true; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2010
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2011
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2012
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2013
06bc494ca11e Initial load
duke
parents:
diff changeset
  2014
    /** Check an annotation value.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2015
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2016
    public void validateAnnotation(JCAnnotation a) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2017
        if (a.type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2018
06bc494ca11e Initial load
duke
parents:
diff changeset
  2019
        // collect an inventory of the members
06bc494ca11e Initial load
duke
parents:
diff changeset
  2020
        Set<MethodSymbol> members = new HashSet<MethodSymbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2021
        for (Scope.Entry e = a.annotationType.type.tsym.members().elems;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2022
             e != null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2023
             e = e.sibling)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2024
            if (e.sym.kind == MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2025
                members.add((MethodSymbol) e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2026
06bc494ca11e Initial load
duke
parents:
diff changeset
  2027
        // count them off as they're annotated
06bc494ca11e Initial load
duke
parents:
diff changeset
  2028
        for (JCTree arg : a.args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2029
            if (arg.getTag() != JCTree.ASSIGN) continue; // recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2030
            JCAssign assign = (JCAssign) arg;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2031
            Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2032
            if (m == null || m.type.isErroneous()) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2033
            if (!members.remove(m))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2034
                log.error(arg.pos(), "duplicate.annotation.member.value",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2035
                          m.name, a.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2036
            if (assign.rhs.getTag() == ANNOTATION)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2037
                validateAnnotation((JCAnnotation)assign.rhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2038
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2039
06bc494ca11e Initial load
duke
parents:
diff changeset
  2040
        // all the remaining ones better have default values
06bc494ca11e Initial load
duke
parents:
diff changeset
  2041
        for (MethodSymbol m : members)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2042
            if (m.defaultValue == null && !m.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2043
                log.error(a.pos(), "annotation.missing.default.value",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2044
                          a.type, m.name);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2045
06bc494ca11e Initial load
duke
parents:
diff changeset
  2046
        // special case: java.lang.annotation.Target must not have
06bc494ca11e Initial load
duke
parents:
diff changeset
  2047
        // repeated values in its value member
06bc494ca11e Initial load
duke
parents:
diff changeset
  2048
        if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  2049
            a.args.tail == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2050
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2051
06bc494ca11e Initial load
duke
parents:
diff changeset
  2052
        if (a.args.head.getTag() != JCTree.ASSIGN) return; // error recovery
06bc494ca11e Initial load
duke
parents:
diff changeset
  2053
        JCAssign assign = (JCAssign) a.args.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2054
        Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2055
        if (m.name != names.value) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2056
        JCTree rhs = assign.rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2057
        if (rhs.getTag() != JCTree.NEWARRAY) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2058
        JCNewArray na = (JCNewArray) rhs;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2059
        Set<Symbol> targets = new HashSet<Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2060
        for (JCTree elem : na.elems) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2061
            if (!targets.add(TreeInfo.symbol(elem))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2062
                log.error(elem.pos(), "repeated.annotation.target");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2063
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2064
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2065
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2066
06bc494ca11e Initial load
duke
parents:
diff changeset
  2067
    void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2068
        if (allowAnnotations &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2069
            lint.isEnabled(Lint.LintCategory.DEP_ANN) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2070
            (s.flags() & DEPRECATED) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2071
            !syms.deprecatedType.isErroneous() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2072
            s.attribute(syms.deprecatedType.tsym) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2073
            log.warning(pos, "missing.deprecated.annotation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2074
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2075
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2076
06bc494ca11e Initial load
duke
parents:
diff changeset
  2077
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2078
 * Check for recursive annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2079
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2080
06bc494ca11e Initial load
duke
parents:
diff changeset
  2081
    /** Check for cycles in the graph of annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2082
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2083
    void checkNonCyclicElements(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2084
        if ((tree.sym.flags_field & ANNOTATION) == 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2085
        assert (tree.sym.flags_field & LOCKED) == 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2086
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2087
            tree.sym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2088
            for (JCTree def : tree.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2089
                if (def.getTag() != JCTree.METHODDEF) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2090
                JCMethodDecl meth = (JCMethodDecl)def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2091
                checkAnnotationResType(meth.pos(), meth.restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2092
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2093
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2094
            tree.sym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2095
            tree.sym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2096
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2097
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2098
06bc494ca11e Initial load
duke
parents:
diff changeset
  2099
    void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2100
        if ((tsym.flags_field & ACYCLIC_ANN) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2101
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2102
        if ((tsym.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2103
            log.error(pos, "cyclic.annotation.element");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2104
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2105
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2106
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2107
            tsym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2108
            for (Scope.Entry e = tsym.members().elems; e != null; e = e.sibling) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2109
                Symbol s = e.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2110
                if (s.kind != Kinds.MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2111
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2112
                checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  2113
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2114
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2115
            tsym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2116
            tsym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2117
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2118
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2119
06bc494ca11e Initial load
duke
parents:
diff changeset
  2120
    void checkAnnotationResType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2121
        switch (type.tag) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2122
        case TypeTags.CLASS:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2123
            if ((type.tsym.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2124
                checkNonCyclicElementsInternal(pos, type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2125
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2126
        case TypeTags.ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2127
            checkAnnotationResType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2128
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2129
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2130
            break; // int etc
06bc494ca11e Initial load
duke
parents:
diff changeset
  2131
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2132
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2133
06bc494ca11e Initial load
duke
parents:
diff changeset
  2134
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2135
 * Check for cycles in the constructor call graph.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2136
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2137
06bc494ca11e Initial load
duke
parents:
diff changeset
  2138
    /** Check for cycles in the graph of constructors calling other
06bc494ca11e Initial load
duke
parents:
diff changeset
  2139
     *  constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2140
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2141
    void checkCyclicConstructors(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2142
        Map<Symbol,Symbol> callMap = new HashMap<Symbol, Symbol>();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2143
06bc494ca11e Initial load
duke
parents:
diff changeset
  2144
        // enter each constructor this-call into the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2145
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2146
            JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2147
            if (app == null) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2148
            JCMethodDecl meth = (JCMethodDecl) l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2149
            if (TreeInfo.name(app.meth) == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2150
                callMap.put(meth.sym, TreeInfo.symbol(app.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2151
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2152
                meth.sym.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2153
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2154
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2155
06bc494ca11e Initial load
duke
parents:
diff changeset
  2156
        // Check for cycles in the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  2157
        Symbol[] ctors = new Symbol[0];
06bc494ca11e Initial load
duke
parents:
diff changeset
  2158
        ctors = callMap.keySet().toArray(ctors);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2159
        for (Symbol caller : ctors) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2160
            checkCyclicConstructor(tree, caller, callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2161
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2162
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2163
06bc494ca11e Initial load
duke
parents:
diff changeset
  2164
    /** Look in the map to see if the given constructor is part of a
06bc494ca11e Initial load
duke
parents:
diff changeset
  2165
     *  call cycle.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2166
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2167
    private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2168
                                        Map<Symbol,Symbol> callMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2169
        if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2170
            if ((ctor.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2171
                log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2172
                          "recursive.ctor.invocation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2173
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2174
                ctor.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2175
                checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2176
                ctor.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2177
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2178
            ctor.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2179
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2180
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2181
06bc494ca11e Initial load
duke
parents:
diff changeset
  2182
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2183
 * Miscellaneous
06bc494ca11e Initial load
duke
parents:
diff changeset
  2184
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2185
06bc494ca11e Initial load
duke
parents:
diff changeset
  2186
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2187
     * Return the opcode of the operator but emit an error if it is an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2188
     * error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2189
     * @param pos        position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2190
     * @param operator   an operator
06bc494ca11e Initial load
duke
parents:
diff changeset
  2191
     * @param tag        a tree tag
06bc494ca11e Initial load
duke
parents:
diff changeset
  2192
     * @param left       type of left hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2193
     * @param right      type of right hand side
06bc494ca11e Initial load
duke
parents:
diff changeset
  2194
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2195
    int checkOperator(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2196
                       OperatorSymbol operator,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2197
                       int tag,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2198
                       Type left,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2199
                       Type right) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2200
        if (operator.opcode == ByteCodes.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2201
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2202
                      "operator.cant.be.applied",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2203
                      treeinfo.operatorName(tag),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  2204
                      List.of(left, right));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2205
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2206
        return operator.opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2207
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2208
06bc494ca11e Initial load
duke
parents:
diff changeset
  2209
06bc494ca11e Initial load
duke
parents:
diff changeset
  2210
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2211
     *  Check for division by integer constant zero
06bc494ca11e Initial load
duke
parents:
diff changeset
  2212
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2213
     *  @param operator      The operator for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2214
     *  @param operand       The right hand operand for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2215
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2216
    void checkDivZero(DiagnosticPosition pos, Symbol operator, Type operand) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2217
        if (operand.constValue() != null
06bc494ca11e Initial load
duke
parents:
diff changeset
  2218
            && lint.isEnabled(Lint.LintCategory.DIVZERO)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2219
            && operand.tag <= LONG
06bc494ca11e Initial load
duke
parents:
diff changeset
  2220
            && ((Number) (operand.constValue())).longValue() == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2221
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2222
            if (opc == ByteCodes.idiv || opc == ByteCodes.imod
06bc494ca11e Initial load
duke
parents:
diff changeset
  2223
                || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2224
                log.warning(pos, "div.zero");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2225
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2226
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2227
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2228
06bc494ca11e Initial load
duke
parents:
diff changeset
  2229
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2230
     * Check for empty statements after if
06bc494ca11e Initial load
duke
parents:
diff changeset
  2231
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2232
    void checkEmptyIf(JCIf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2233
        if (tree.thenpart.getTag() == JCTree.SKIP && tree.elsepart == null && lint.isEnabled(Lint.LintCategory.EMPTY))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2234
            log.warning(tree.thenpart.pos(), "empty.if");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2235
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2236
06bc494ca11e Initial load
duke
parents:
diff changeset
  2237
    /** Check that symbol is unique in given scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2238
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2239
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2240
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2241
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2242
    boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2243
        if (sym.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2244
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2245
        if (sym.owner.name == names.any) return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2246
        for (Scope.Entry e = s.lookup(sym.name); e.scope == s; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2247
            if (sym != e.sym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2248
                sym.kind == e.sym.kind &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2249
                sym.name != names.error &&
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2250
                (sym.kind != MTH || types.hasSameArgs(types.erasure(sym.type), types.erasure(e.sym.type)))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2251
                if ((sym.flags() & VARARGS) != (e.sym.flags() & VARARGS))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2252
                    varargsDuplicateError(pos, sym, e.sym);
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2253
                else if (sym.kind == MTH && !types.overrideEquivalent(sym.type, e.sym.type))
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2254
                    duplicateErasureError(pos, sym, e.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2255
                else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2256
                    duplicateError(pos, e.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2257
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2258
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2259
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2260
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2261
    }
2509
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2262
    //where
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2263
    /** Report duplicate declaration error.
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2264
     */
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2265
    void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2266
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2267
            log.error(pos, "name.clash.same.erasure", sym1, sym2);
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2268
        }
c8a1744c87fd 6182950: methods clash algorithm should not depend on return type
mcimadamore
parents: 2223
diff changeset
  2269
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2270
06bc494ca11e Initial load
duke
parents:
diff changeset
  2271
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2272
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2273
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2274
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2275
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2276
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2277
    boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2278
        return checkUniqueImport(pos, sym, s, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2279
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2280
06bc494ca11e Initial load
duke
parents:
diff changeset
  2281
    /** Check that static single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2282
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2283
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2284
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2285
     *  @param s             The scope
06bc494ca11e Initial load
duke
parents:
diff changeset
  2286
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2287
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2288
    boolean checkUniqueStaticImport(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2289
        return checkUniqueImport(pos, sym, s, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2290
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2291
06bc494ca11e Initial load
duke
parents:
diff changeset
  2292
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2293
     *  but make an exception for two single-type imports which denote the same type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2294
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2295
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2296
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2297
     *  @param staticImport  Whether or not this was a static import
06bc494ca11e Initial load
duke
parents:
diff changeset
  2298
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2299
    private boolean checkUniqueImport(DiagnosticPosition pos, Symbol sym, Scope s, boolean staticImport) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2300
        for (Scope.Entry e = s.lookup(sym.name); e.scope != null; e = e.next()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2301
            // is encountered class entered via a class declaration?
06bc494ca11e Initial load
duke
parents:
diff changeset
  2302
            boolean isClassDecl = e.scope == s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2303
            if ((isClassDecl || sym != e.sym) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
                sym.kind == e.sym.kind &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2305
                sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2306
                if (!e.sym.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2307
                    String what = e.sym.toString();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2308
                    if (!isClassDecl) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2309
                        if (staticImport)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2310
                            log.error(pos, "already.defined.static.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2311
                        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  2312
                            log.error(pos, "already.defined.single.import", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2313
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2314
                    else if (sym != e.sym)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2315
                        log.error(pos, "already.defined.this.unit", what);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2316
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2317
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2318
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2319
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2320
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2321
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2322
06bc494ca11e Initial load
duke
parents:
diff changeset
  2323
    /** Check that a qualified name is in canonical form (for import decls).
06bc494ca11e Initial load
duke
parents:
diff changeset
  2324
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2325
    public void checkCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2326
        if (!isCanonical(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2327
            log.error(tree.pos(), "import.requires.canonical",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2328
                      TreeInfo.symbol(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2329
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2330
        // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2331
        private boolean isCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2332
            while (tree.getTag() == JCTree.SELECT) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2333
                JCFieldAccess s = (JCFieldAccess) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2334
                if (s.sym.owner != TreeInfo.symbol(s.selected))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2335
                    return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2336
                tree = s.selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2337
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2338
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2339
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2340
06bc494ca11e Initial load
duke
parents:
diff changeset
  2341
    private class ConversionWarner extends Warner {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2342
        final String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2343
        final Type found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
        final Type expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2345
        public ConversionWarner(DiagnosticPosition pos, String key, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2346
            super(pos);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2347
            this.key = key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2348
            this.found = found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2349
            this.expected = expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2350
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2351
06bc494ca11e Initial load
duke
parents:
diff changeset
  2352
        public void warnUnchecked() {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2353
            boolean warned = this.warned;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2354
            super.warnUnchecked();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2355
            if (warned) return; // suppress redundant diagnostics
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  2356
            Object problem = diags.fragment(key);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2357
            Check.this.warnUnchecked(pos(), "prob.found.req", problem, found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2358
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2359
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2360
06bc494ca11e Initial load
duke
parents:
diff changeset
  2361
    public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2362
        return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2363
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2364
06bc494ca11e Initial load
duke
parents:
diff changeset
  2365
    public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2366
        return new ConversionWarner(pos, "unchecked.assign", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2367
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2368
}