langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java
author dlsmith
Thu, 14 Jul 2016 11:57:15 -0600
changeset 39674 de3b0e52ca17
parent 36526 3b41f1c69604
child 40313 a85f92c9a8ab
permissions -rw-r--r--
8161013: Never treat anonymous classes as 'final' Reviewed-by: vromero
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
35810
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
     2
 * Copyright (c) 1999, 2016, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5489
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
import java.util.*;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
    29
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
    30
import javax.tools.JavaFileManager;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    31
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
import com.sun.tools.javac.code.*;
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
    33
import com.sun.tools.javac.code.Attribute.Compound;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
    34
import com.sun.tools.javac.comp.Annotate.AnnotationTypeMetadata;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.tools.javac.jvm.*;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    36
import com.sun.tools.javac.resources.CompilerProperties.Errors;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    37
import com.sun.tools.javac.resources.CompilerProperties.Fragments;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    38
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
import com.sun.tools.javac.util.*;
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
    40
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticFlag;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    41
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
06bc494ca11e Initial load
duke
parents:
diff changeset
    42
import com.sun.tools.javac.util.List;
06bc494ca11e Initial load
duke
parents:
diff changeset
    43
06bc494ca11e Initial load
duke
parents:
diff changeset
    44
import com.sun.tools.javac.code.Lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    45
import com.sun.tools.javac.code.Lint.LintCategory;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
    46
import com.sun.tools.javac.code.Scope.WriteableScope;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    47
import com.sun.tools.javac.code.Type.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    48
import com.sun.tools.javac.code.Symbol.*;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
    49
import com.sun.tools.javac.comp.DeferredAttr.DeferredAttrContext;
15705
c4124695db0c 8007463: Cleanup inference related classes
mcimadamore
parents: 15385
diff changeset
    50
import com.sun.tools.javac.comp.Infer.FreeTypeListener;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15361
diff changeset
    51
import com.sun.tools.javac.tree.JCTree.*;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    52
06bc494ca11e Initial load
duke
parents:
diff changeset
    53
import static com.sun.tools.javac.code.Flags.*;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    54
import static com.sun.tools.javac.code.Flags.ANNOTATION;
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    55
import static com.sun.tools.javac.code.Flags.SYNCHRONIZED;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
import static com.sun.tools.javac.code.Kinds.*;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
    57
import static com.sun.tools.javac.code.Kinds.Kind.*;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
    58
import static com.sun.tools.javac.code.Scope.LookupKind.NON_RECURSIVE;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    59
import static com.sun.tools.javac.code.TypeTag.*;
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    60
import static com.sun.tools.javac.code.TypeTag.WILDCARD;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    61
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
    62
import static com.sun.tools.javac.tree.JCTree.Tag.*;
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6711
diff changeset
    63
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    64
/** Type checking helper class for the attribution phase.
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    66
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    67
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    69
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    70
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    71
public class Check {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
    72
    protected static final Context.Key<Check> checkKey = new Context.Key<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    74
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
    private final Log log;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
    76
    private final Resolve rs;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
    private final Symtab syms;
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
    78
    private final Enter enter;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
    79
    private final DeferredAttr deferredAttr;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
    private final Infer infer;
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
    private final Types types;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
    82
    private final TypeAnnotations typeAnnotations;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
    83
    private final JCDiagnostic.Factory diags;
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
    84
    private final JavaFileManager fileManager;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
    85
    private final Source source;
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
    86
    private final Profile profile;
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
    87
    private final boolean warnOnAccessToSensitiveMembers;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
    // The set of lint options currently in effect. It is initialized
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
    // from the context, and then is set/reset as needed by Attr as it
06bc494ca11e Initial load
duke
parents:
diff changeset
    91
    // visits all the various parts of the trees during attribution.
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
    private Lint lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    94
    // The method being analyzed in Attr - it is set/reset as needed by
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    95
    // Attr as it visits new method declarations.
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    96
    private MethodSymbol method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
    97
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
    public static Check instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
        Check instance = context.get(checkKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
            instance = new Check(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
    protected Check(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
        context.put(checkKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   107
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   108
        names = Names.instance(context);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   109
        dfltTargetMeta = new Name[] { names.PACKAGE, names.TYPE,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   110
            names.FIELD, names.METHOD, names.CONSTRUCTOR,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   111
            names.ANNOTATION_TYPE, names.LOCAL_VARIABLE, names.PARAMETER};
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   112
        log = Log.instance(context);
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   113
        rs = Resolve.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   114
        syms = Symtab.instance(context);
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
   115
        enter = Enter.instance(context);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   116
        deferredAttr = DeferredAttr.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
        infer = Infer.instance(context);
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   118
        types = Types.instance(context);
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   119
        typeAnnotations = TypeAnnotations.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   120
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   121
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
        lint = Lint.instance(context);
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
   123
        fileManager = context.get(JavaFileManager.class);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   124
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   125
        source = Source.instance(context);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   126
        allowSimplifiedVarargs = source.allowSimplifiedVarargs();
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   127
        allowDefaultMethods = source.allowDefaultMethods();
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
   128
        allowStrictMethodClashCheck = source.allowStrictMethodClashCheck();
25283
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   129
        allowPrivateSafeVarargs = source.allowPrivateSafeVarargs();
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   130
        allowDiamondWithAnonymousClassCreation = source.allowDiamondWithAnonymousClassCreation();
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
   131
        warnOnAccessToSensitiveMembers = options.isSet("warnOnAccessToSensitiveMembers");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   132
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   133
        Target target = Target.instance(context);
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   134
        syntheticNameChar = target.syntheticNameChar();
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   135
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   136
        profile = Profile.instance(context);
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
   137
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   138
        boolean verboseDeprecated = lint.isEnabled(LintCategory.DEPRECATION);
06bc494ca11e Initial load
duke
parents:
diff changeset
   139
        boolean verboseUnchecked = lint.isEnabled(LintCategory.UNCHECKED);
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
   140
        boolean enforceMandatoryWarnings = true;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   141
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   142
        deprecationHandler = new MandatoryWarningHandler(log, verboseDeprecated,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   143
                enforceMandatoryWarnings, "deprecated", LintCategory.DEPRECATION);
813
ab91293d33f4 6507179: javadoc -source 1.3 does not work with jdk6
jjg
parents: 812
diff changeset
   144
        uncheckedHandler = new MandatoryWarningHandler(log, verboseUnchecked,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   145
                enforceMandatoryWarnings, "unchecked", LintCategory.UNCHECKED);
35810
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
   146
        sunApiHandler = new MandatoryWarningHandler(log, false,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   147
                enforceMandatoryWarnings, "sunapi", null);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   148
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   149
        deferredLintHandler = DeferredLintHandler.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   152
    /** Switch: simplified varargs enabled?
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   153
     */
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   154
    boolean allowSimplifiedVarargs;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   155
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   156
    /** Switch: default methods enabled?
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   157
     */
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   158
    boolean allowDefaultMethods;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   159
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   160
    /** Switch: should unrelated return types trigger a method clash?
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   161
     */
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   162
    boolean allowStrictMethodClashCheck;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   163
25283
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   164
    /** Switch: can the @SafeVarargs annotation be applied to private methods?
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   165
     */
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   166
    boolean allowPrivateSafeVarargs;
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   167
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   168
    /** Switch: can diamond inference be used in anonymous instance creation ?
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   169
     */
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   170
    boolean allowDiamondWithAnonymousClassCreation;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   171
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   172
    /** Character for synthetic names
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   173
     */
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   174
    char syntheticNameChar;
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
   175
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   176
    /** A table mapping flat names of all compiled classes for each module in this run
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   177
     *  to their symbols; maintained from outside.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   178
     */
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   179
    private Map<Pair<ModuleSymbol, Name>,ClassSymbol> compiled = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   180
06bc494ca11e Initial load
duke
parents:
diff changeset
   181
    /** A handler for messages about deprecated usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   182
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   183
    private MandatoryWarningHandler deprecationHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   184
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
    /** A handler for messages about unchecked or unsafe usage.
06bc494ca11e Initial load
duke
parents:
diff changeset
   186
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   187
    private MandatoryWarningHandler uncheckedHandler;
06bc494ca11e Initial load
duke
parents:
diff changeset
   188
5848
c5a4ce47e780 6960407: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5847
diff changeset
   189
    /** A handler for messages about using proprietary API.
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   190
     */
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   191
    private MandatoryWarningHandler sunApiHandler;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   192
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   193
    /** A handler for deferred lint warnings.
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   194
     */
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   195
    private DeferredLintHandler deferredLintHandler;
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
   196
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   197
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   198
 * Errors and Warnings
06bc494ca11e Initial load
duke
parents:
diff changeset
   199
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
06bc494ca11e Initial load
duke
parents:
diff changeset
   201
    Lint setLint(Lint newLint) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   202
        Lint prev = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   203
        lint = newLint;
06bc494ca11e Initial load
duke
parents:
diff changeset
   204
        return prev;
06bc494ca11e Initial load
duke
parents:
diff changeset
   205
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   206
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   207
    MethodSymbol setMethod(MethodSymbol newMethod) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   208
        MethodSymbol prev = method;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   209
        method = newMethod;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   210
        return prev;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   211
    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   212
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   213
    /** Warn about deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   214
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   215
     *  @param sym        The deprecated symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   216
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
    void warnDeprecated(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   218
        if (!lint.isSuppressed(LintCategory.DEPRECATION))
06bc494ca11e Initial load
duke
parents:
diff changeset
   219
            deprecationHandler.report(pos, "has.been.deprecated", sym, sym.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   220
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   221
06bc494ca11e Initial load
duke
parents:
diff changeset
   222
    /** Warn about unchecked operation.
06bc494ca11e Initial load
duke
parents:
diff changeset
   223
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   224
     *  @param msg        A string describing the problem.
06bc494ca11e Initial load
duke
parents:
diff changeset
   225
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   226
    public void warnUnchecked(DiagnosticPosition pos, String msg, Object... args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   227
        if (!lint.isSuppressed(LintCategory.UNCHECKED))
06bc494ca11e Initial load
duke
parents:
diff changeset
   228
            uncheckedHandler.report(pos, msg, args);
06bc494ca11e Initial load
duke
parents:
diff changeset
   229
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   230
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   231
    /** Warn about unsafe vararg method decl.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   232
     *  @param pos        Position to be used for error reporting.
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   233
     */
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   234
    void warnUnsafeVararg(DiagnosticPosition pos, String key, Object... args) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   235
        if (lint.isEnabled(LintCategory.VARARGS) && allowSimplifiedVarargs)
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   236
            log.warning(LintCategory.VARARGS, pos, key, args);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   237
    }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   238
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   239
    public void warnStatic(DiagnosticPosition pos, String msg, Object... args) {
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   240
        if (lint.isEnabled(LintCategory.STATIC))
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
   241
            log.warning(LintCategory.STATIC, pos, msg, args);
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   242
    }
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 4867
diff changeset
   243
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   244
    /** Warn about division by integer constant zero.
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   245
     *  @param pos        Position to be used for error reporting.
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   246
     */
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   247
    void warnDivZero(DiagnosticPosition pos) {
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   248
        if (lint.isEnabled(LintCategory.DIVZERO))
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   249
            log.warning(LintCategory.DIVZERO, pos, "div.zero");
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   250
    }
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
   251
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   252
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   253
     * Report any deferred diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   255
    public void reportDeferredDiagnostics() {
06bc494ca11e Initial load
duke
parents:
diff changeset
   256
        deprecationHandler.reportDeferredDiagnostic();
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
        uncheckedHandler.reportDeferredDiagnostic();
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3560
diff changeset
   258
        sunApiHandler.reportDeferredDiagnostic();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
    /** Report a failure to complete a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   263
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
     *  @param ex         The failure to report.
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   266
    public Type completionError(DiagnosticPosition pos, CompletionFailure ex) {
16326
9b94bafef533 8009227: Certain diagnostics should not be deferred
mcimadamore
parents: 16320
diff changeset
   267
        log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, pos, "cant.access", ex.sym, ex.getDetailValue());
36153
ed5063b304be 8149600: javac, remove unused options, step 2
vromero
parents: 35810
diff changeset
   268
        if (ex instanceof ClassFinder.BadClassFile) throw new Abort();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   269
        else return syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   270
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   271
06bc494ca11e Initial load
duke
parents:
diff changeset
   272
    /** Report an error that wrong type tag was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
     *  @param required   An internationalized string describing the type tag
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
     *                    required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   276
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
    Type typeTagError(DiagnosticPosition pos, Object required, Object found) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   279
        // this error used to be raised by the parser,
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   280
        // but has been delayed to this point:
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   281
        if (found instanceof Type && ((Type)found).hasTag(VOID)) {
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   282
            log.error(pos, "illegal.start.of.type");
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   283
            return syms.errType;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   284
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
        log.error(pos, "type.found.req", found, required);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   286
        return types.createErrorType(found instanceof Type ? (Type)found : syms.errType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   287
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
    /** Report an error that symbol cannot be referenced before super
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
     *  has been called.
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
     *  @param sym        The referenced symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   294
    void earlyRefError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   295
        log.error(pos, "cant.ref.before.ctor.called", sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   297
06bc494ca11e Initial load
duke
parents:
diff changeset
   298
    /** Report duplicate declaration error.
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
    void duplicateError(DiagnosticPosition pos, Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
        if (!sym.type.isErroneous()) {
10626
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   302
            Symbol location = sym.location();
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   303
            if (location.kind == MTH &&
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   304
                    ((MethodSymbol)location).isStaticOrInstanceInit()) {
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   305
                log.error(pos, "already.defined.in.clinit", kindName(sym), sym,
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   306
                        kindName(sym.location()), kindName(sym.location().enclClass()),
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   307
                        sym.location().enclClass());
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   308
            } else {
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   309
                log.error(pos, "already.defined", kindName(sym), sym,
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   310
                        kindName(sym.location()), sym.location());
83f0c2860f5b 7086595: Error message bug: name of initializer is 'null'
mcimadamore
parents: 9814
diff changeset
   311
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
    /** Report array/varargs duplicate declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
    void varargsDuplicateError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
            log.error(pos, "array.and.varargs", sym1, sym2, sym2.location());
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
 * duplicate declaration checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
    /** Check that variable does not hide variable with same name in
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
     *  immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
     *  @param v             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
    void checkTransparentVar(DiagnosticPosition pos, VarSymbol v, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   334
        for (Symbol sym : s.getSymbolsByName(v.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   335
            if (sym.owner != v.owner) break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   336
            if (sym.kind == VAR &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
   337
                sym.owner.kind.matches(KindSelector.VAL_MTH) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   338
                v.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   339
                duplicateError(pos, sym);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   340
                return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   341
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   342
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   343
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
06bc494ca11e Initial load
duke
parents:
diff changeset
   345
    /** Check that a class or interface does not hide a class or
06bc494ca11e Initial load
duke
parents:
diff changeset
   346
     *  interface with same name in immediately enclosing local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   347
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   348
     *  @param c             The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   351
    void checkTransparentClass(DiagnosticPosition pos, ClassSymbol c, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   352
        for (Symbol sym : s.getSymbolsByName(c.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   353
            if (sym.owner != c.owner) break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   354
            if (sym.kind == TYP && !sym.type.hasTag(TYPEVAR) &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
   355
                sym.owner.kind.matches(KindSelector.VAL_MTH) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   356
                c.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   357
                duplicateError(pos, sym);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   358
                return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
    /** Check that class does not have the same name as one of
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
     *  its enclosing classes, or as a class defined in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
     *  return true if class is unique in its enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
     *  @param name          The class name.
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
     *  @param s             The enclosing scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
    boolean checkUniqueClassName(DiagnosticPosition pos, Name name, Scope s) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   371
        for (Symbol sym : s.getSymbolsByName(name, NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   372
            if (sym.kind == TYP && sym.name != names.error) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
   373
                duplicateError(pos, sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   377
        for (Symbol sym = s.owner; sym != null; sym = sym.owner) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   378
            if (sym.kind == TYP && sym.name == name && sym.name != names.error) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   379
                duplicateError(pos, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   380
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   381
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   382
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   383
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   384
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   385
06bc494ca11e Initial load
duke
parents:
diff changeset
   386
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   387
 * Class name generation
06bc494ca11e Initial load
duke
parents:
diff changeset
   388
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   389
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   390
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   391
    private Map<Pair<Name, Name>, Integer> localClassNameIndexes = new HashMap<>();
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   392
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
    /** Return name of local class.
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   394
     *  This is of the form   {@code <enclClass> $ n <classname> }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   395
     *  where
06bc494ca11e Initial load
duke
parents:
diff changeset
   396
     *    enclClass is the flat name of the enclosing class,
06bc494ca11e Initial load
duke
parents:
diff changeset
   397
     *    classname is the simple name of the local class
06bc494ca11e Initial load
duke
parents:
diff changeset
   398
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   399
    Name localClassName(ClassSymbol c) {
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   400
        Name enclFlatname = c.owner.enclClass().flatname;
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   401
        String enclFlatnameStr = enclFlatname.toString();
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   402
        Pair<Name, Name> key = new Pair<>(enclFlatname, c.name);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   403
        Integer index = localClassNameIndexes.get(key);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   404
        for (int i = (index == null) ? 1 : index; ; i++) {
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   405
            Name flatname = names.fromString(enclFlatnameStr
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   406
                    + syntheticNameChar + i + c.name);
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   407
            if (getCompiled(c.packge().modle, flatname) == null) {
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   408
                localClassNameIndexes.put(key, i + 1);
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   409
                return flatname;
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   410
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   413
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   414
    void clearLocalClassNameIndexes(ClassSymbol c) {
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   415
        localClassNameIndexes.remove(new Pair<>(
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   416
                c.owner.enclClass().flatname, c.name));
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   417
    }
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   418
23810
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   419
    public void newRound() {
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   420
        compiled.clear();
33020
7ed4f7ff42c5 8000316: Huge performance bottleneck in com.sun.tools.javac.comp.Check.localClassName
sadayapalam
parents: 32910
diff changeset
   421
        localClassNameIndexes.clear();
23810
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   422
    }
b92eb80925f0 8038455: Use single Context for all rounds of annotation processing
jlahoda
parents: 23803
diff changeset
   423
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   424
    public void putCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   425
        compiled.put(Pair.of(csym.packge().modle, csym.flatname), csym);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   426
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   427
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   428
    public ClassSymbol getCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   429
        return compiled.get(Pair.of(csym.packge().modle, csym.flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   430
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   431
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   432
    public ClassSymbol getCompiled(ModuleSymbol msym, Name flatname) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   433
        return compiled.get(Pair.of(msym, flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   434
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   435
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   436
    public void removeCompiled(ClassSymbol csym) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   437
        compiled.remove(Pair.of(csym.packge().modle, csym.flatname));
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   438
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
   439
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   440
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   441
 * Type Checking
06bc494ca11e Initial load
duke
parents:
diff changeset
   442
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   443
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   444
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   445
     * A check context is an object that can be used to perform compatibility
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   446
     * checks - depending on the check context, meaning of 'compatibility' might
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   447
     * vary significantly.
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   448
     */
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   449
    public interface CheckContext {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   450
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   451
         * Is type 'found' compatible with type 'req' in given context
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   452
         */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   453
        boolean compatible(Type found, Type req, Warner warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   454
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   455
         * Report a check error
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   456
         */
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   457
        void report(DiagnosticPosition pos, JCDiagnostic details);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   458
        /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   459
         * Obtain a warner for this check context
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   460
         */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   461
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req);
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   462
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   463
        public InferenceContext inferenceContext();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   464
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   465
        public DeferredAttr.DeferredAttrContext deferredAttrContext();
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   466
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   467
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   468
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   469
     * This class represent a check context that is nested within another check
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   470
     * context - useful to check sub-expressions. The default behavior simply
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   471
     * redirects all method calls to the enclosing check context leveraging
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   472
     * the forwarding pattern.
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   473
     */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   474
    static class NestedCheckContext implements CheckContext {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   475
        CheckContext enclosingContext;
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   476
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   477
        NestedCheckContext(CheckContext enclosingContext) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   478
            this.enclosingContext = enclosingContext;
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   479
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   480
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   481
        public boolean compatible(Type found, Type req, Warner warn) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   482
            return enclosingContext.compatible(found, req, warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   483
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   484
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   485
        public void report(DiagnosticPosition pos, JCDiagnostic details) {
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   486
            enclosingContext.report(pos, details);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   487
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   488
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   489
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   490
            return enclosingContext.checkWarner(pos, found, req);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   491
        }
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   492
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   493
        public InferenceContext inferenceContext() {
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   494
            return enclosingContext.inferenceContext();
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   495
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   496
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   497
        public DeferredAttrContext deferredAttrContext() {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   498
            return enclosingContext.deferredAttrContext();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   499
        }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   500
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   501
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   502
    /**
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   503
     * Check context to be used when evaluating assignment/return statements
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   504
     */
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   505
    CheckContext basicHandler = new CheckContext() {
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   506
        public void report(DiagnosticPosition pos, JCDiagnostic details) {
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   507
            log.error(pos, "prob.found.req", details);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   508
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   509
        public boolean compatible(Type found, Type req, Warner warn) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   510
            return types.isAssignable(found, req, warn);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   511
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   512
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   513
        public Warner checkWarner(DiagnosticPosition pos, Type found, Type req) {
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   514
            return convertWarner(pos, found, req);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   515
        }
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   516
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   517
        public InferenceContext inferenceContext() {
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   518
            return infer.emptyContext;
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   519
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   520
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   521
        public DeferredAttrContext deferredAttrContext() {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   522
            return deferredAttr.emptyDeferredAttrContext;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14054
diff changeset
   523
        }
24226
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   524
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   525
        @Override
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   526
        public String toString() {
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   527
            return "CheckContext: basicHandler";
08b586e22328 8030741: Inference: implement eager resolution of return types, consistent with JDK-8028800
vromero
parents: 24219
diff changeset
   528
        }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   529
    };
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   530
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   531
    /** Check that a given type is assignable to a given proto-type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   532
     *  If it is, return the type, otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
   533
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   534
     *  @param found      The type that was found.
06bc494ca11e Initial load
duke
parents:
diff changeset
   535
     *  @param req        The type that was required.
06bc494ca11e Initial load
duke
parents:
diff changeset
   536
     */
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   537
    public Type checkType(DiagnosticPosition pos, Type found, Type req) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   538
        return checkType(pos, found, req, basicHandler);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   539
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 6147
diff changeset
   540
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   541
    Type checkType(final DiagnosticPosition pos, final Type found, final Type req, final CheckContext checkContext) {
31937
ad43a6639c4a 8132215: class InferenceContext should live in a separate file
vromero
parents: 31560
diff changeset
   542
        final InferenceContext inferenceContext = checkContext.inferenceContext();
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25276
diff changeset
   543
        if (inferenceContext.free(req) || inferenceContext.free(found)) {
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25276
diff changeset
   544
            inferenceContext.addFreeTypeListener(List.of(req, found), new FreeTypeListener() {
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   545
                @Override
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   546
                public void typesInferred(InferenceContext inferenceContext) {
21488
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21041
diff changeset
   547
                    checkType(pos, inferenceContext.asInstType(found), inferenceContext.asInstType(req), checkContext);
14047
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   548
                }
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   549
            });
7c7a5611cf76 7175433: Inference cleanup: add helper class to handle inference variables
mcimadamore
parents: 13844
diff changeset
   550
        }
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   551
        if (req.hasTag(ERROR))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   552
            return req;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   553
        if (req.hasTag(NONE))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   554
            return found;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   555
        if (checkContext.compatible(found, req, checkContext.checkWarner(pos, found, req))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   556
            return found;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   557
        } else {
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
   558
            if (found.isNumeric() && req.isNumeric()) {
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   559
                checkContext.report(pos, diags.fragment("possible.loss.of.precision", found, req));
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   560
                return types.createErrorType(found);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   561
            }
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   562
            checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   563
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   564
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   565
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   566
06bc494ca11e Initial load
duke
parents:
diff changeset
   567
    /** Check that a given type can be cast to a given target type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   568
     *  Return the result of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   569
     *  @param pos        Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   570
     *  @param found      The type that is being cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   571
     *  @param req        The target type of the cast.
06bc494ca11e Initial load
duke
parents:
diff changeset
   572
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   573
    Type checkCastable(DiagnosticPosition pos, Type found, Type req) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   574
        return checkCastable(pos, found, req, basicHandler);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   575
    }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   576
    Type checkCastable(DiagnosticPosition pos, Type found, Type req, CheckContext checkContext) {
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12335
diff changeset
   577
        if (types.isCastable(found, req, castWarner(pos, found, req))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   578
            return req;
06bc494ca11e Initial load
duke
parents:
diff changeset
   579
        } else {
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12915
diff changeset
   580
            checkContext.report(pos, diags.fragment("inconvertible.types", found, req));
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   581
            return types.createErrorType(found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   582
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   583
    }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   584
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   585
    /** Check for redundant casts (i.e. where source type is a subtype of target type)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   586
     * The problem should only be reported for non-292 cast
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   587
     */
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   588
    public void checkRedundantCast(Env<AttrContext> env, final JCTypeCast tree) {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   589
        if (!tree.type.isErroneous()
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   590
                && types.isSameType(tree.expr.type, tree.clazz.type)
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   591
                && !(ignoreAnnotatedCasts && TreeInfo.containsTypeAnnotation(tree.clazz))
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   592
                && !is292targetTypeCast(tree)) {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   593
            deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   594
                @Override
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   595
                public void report() {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   596
                    if (lint.isEnabled(Lint.LintCategory.CAST))
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   597
                        log.warning(Lint.LintCategory.CAST,
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   598
                                tree.pos(), "redundant.cast", tree.clazz.type);
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   599
                }
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19938
diff changeset
   600
            });
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   601
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   602
    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   603
    //where
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   604
        private boolean is292targetTypeCast(JCTypeCast tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   605
            boolean is292targetTypeCast = false;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   606
            JCExpression expr = TreeInfo.skipParens(tree.expr);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   607
            if (expr.hasTag(APPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   608
                JCMethodInvocation apply = (JCMethodInvocation)expr;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   609
                Symbol sym = TreeInfo.symbol(apply.meth);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   610
                is292targetTypeCast = sym != null &&
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   611
                    sym.kind == MTH &&
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   612
                    (sym.flags() & HYPOTHETICAL) != 0;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   613
            }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   614
            return is292targetTypeCast;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   615
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 12087
diff changeset
   616
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   617
        private static final boolean ignoreAnnotatedCasts = true;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   618
06bc494ca11e Initial load
duke
parents:
diff changeset
   619
    /** Check that a type is within some bounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   620
     *
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   621
     *  Used in TypeApply to verify that, e.g., X in {@code V<X>} is a valid
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   622
     *  type argument.
06bc494ca11e Initial load
duke
parents:
diff changeset
   623
     *  @param a             The type that should be bounded by bs.
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
   624
     *  @param bound         The bound.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   625
     */
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
   626
    private boolean checkExtends(Type a, Type bound) {
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   627
         if (a.isUnbound()) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   628
             return true;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   629
         } else if (!a.hasTag(WILDCARD)) {
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24604
diff changeset
   630
             a = types.cvarUpperBound(a);
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
   631
             return types.isSubtype(a, bound);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   632
         } else if (a.isExtendsBound()) {
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24604
diff changeset
   633
             return types.isCastable(bound, types.wildUpperBound(a), types.noWarnings);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   634
         } else if (a.isSuperBound()) {
24293
0d889f759fac 8033718: Inference ignores capture variable as upper bound
dlsmith
parents: 24226
diff changeset
   635
             return !types.notSoftSubtype(types.wildLowerBound(a), bound);
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   636
         }
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
   637
         return true;
1527
815e743a83ba 6732484: Bound error on wildcard code
mcimadamore
parents: 1358
diff changeset
   638
     }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   639
06bc494ca11e Initial load
duke
parents:
diff changeset
   640
    /** Check that type is different from 'void'.
06bc494ca11e Initial load
duke
parents:
diff changeset
   641
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   642
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   643
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   644
    Type checkNonVoid(DiagnosticPosition pos, Type t) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   645
        if (t.hasTag(VOID)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   646
            log.error(pos, "void.not.allowed.here");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
   647
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   648
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   649
            return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   650
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   651
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   652
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   653
    Type checkClassOrArrayType(DiagnosticPosition pos, Type t) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   654
        if (!t.hasTag(CLASS) && !t.hasTag(ARRAY) && !t.hasTag(ERROR)) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   655
            return typeTagError(pos,
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   656
                                diags.fragment("type.req.class.array"),
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   657
                                asTypeParam(t));
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   658
        } else {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   659
            return t;
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   660
        }
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   661
    }
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   662
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   663
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   664
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   665
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   667
    Type checkClassType(DiagnosticPosition pos, Type t) {
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   668
        if (!t.hasTag(CLASS) && !t.hasTag(ERROR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   669
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   670
                                diags.fragment("type.req.class"),
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   671
                                asTypeParam(t));
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   672
        } else {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   673
            return t;
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   674
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   675
    }
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   676
    //where
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   677
        private Object asTypeParam(Type t) {
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   678
            return (t.hasTag(TYPEVAR))
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   679
                                    ? diags.fragment("type.parameter", t)
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   680
                                    : t;
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   681
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   682
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   683
    /** Check that type is a valid qualifier for a constructor reference expression
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   684
     */
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   685
    Type checkConstructorRefType(DiagnosticPosition pos, Type t) {
15360
450af2a9e3c9 8005854: Add support for array constructor references
mcimadamore
parents: 15356
diff changeset
   686
        t = checkClassOrArrayType(pos, t);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   687
        if (t.hasTag(CLASS)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   688
            if ((t.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
16340
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   689
                log.error(pos, "abstract.cant.be.instantiated", t.tsym);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   690
                t = types.createErrorType(t);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   691
            } else if ((t.tsym.flags() & ENUM) != 0) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   692
                log.error(pos, "enum.cant.be.instantiated");
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   693
                t = types.createErrorType(t);
16340
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   694
            } else {
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   695
                t = checkClassType(pos, t, true);
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   696
            }
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   697
        } else if (t.hasTag(ARRAY)) {
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   698
            if (!types.isReifiable(((ArrayType)t).elemtype)) {
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   699
                log.error(pos, "generic.array.creation");
3c0af3413e0f 8008540: Constructor reference to non-reifiable array should be rejected
mcimadamore
parents: 16333
diff changeset
   700
                t = types.createErrorType(t);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   701
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   702
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   703
        return t;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   704
    }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   705
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   706
    /** Check that type is a class or interface type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   707
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   708
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   709
     *  @param noBounds    True if type bounds are illegal here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   710
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   711
    Type checkClassType(DiagnosticPosition pos, Type t, boolean noBounds) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   712
        t = checkClassType(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   713
        if (noBounds && t.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   714
            List<Type> args = t.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
   715
            while (args.nonEmpty()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   716
                if (args.head.hasTag(WILDCARD))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   717
                    return typeTagError(pos,
6032
03b276d8e6a6 6968497: localized text appears in raw diagnostic
jjg
parents: 5848
diff changeset
   718
                                        diags.fragment("type.req.exact"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   719
                                        args.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
   720
                args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
   721
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   722
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   723
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   724
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   725
06bc494ca11e Initial load
duke
parents:
diff changeset
   726
    /** Check that type is a reference type, i.e. a class, interface or array type
06bc494ca11e Initial load
duke
parents:
diff changeset
   727
     *  or a type variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   728
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   729
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   730
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   731
    Type checkRefType(DiagnosticPosition pos, Type t) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   732
        if (t.isReference())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   733
            return t;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   734
        else
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   735
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   736
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   737
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   738
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   739
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   740
    /** Check that each type is a reference type, i.e. a class, interface or array type
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   741
     *  or a type variable.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   742
     *  @param trees         Original trees, used for error reporting.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   743
     *  @param types         The types to be checked.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   744
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   745
    List<Type> checkRefTypes(List<JCExpression> trees, List<Type> types) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   746
        List<JCExpression> tl = trees;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   747
        for (List<Type> l = types; l.nonEmpty(); l = l.tail) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   748
            l.head = checkRefType(tl.head.pos(), l.head);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   749
            tl = tl.tail;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   750
        }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   751
        return types;
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   752
    }
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2509
diff changeset
   753
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   754
    /** Check that type is a null or reference type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   755
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   756
     *  @param t             The type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   758
    Type checkNullOrRefType(DiagnosticPosition pos, Type t) {
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
   759
        if (t.isReference() || t.hasTag(BOT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   760
            return t;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
   761
        else
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   762
            return typeTagError(pos,
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
   763
                                diags.fragment("type.req.ref"),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   764
                                t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
    /** Check that flag set does not contain elements of two conflicting sets. s
06bc494ca11e Initial load
duke
parents:
diff changeset
   768
     *  Return true if it doesn't.
06bc494ca11e Initial load
duke
parents:
diff changeset
   769
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
   770
     *  @param flags         The set of flags to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
   771
     *  @param set1          Conflicting flags set #1.
06bc494ca11e Initial load
duke
parents:
diff changeset
   772
     *  @param set2          Conflicting flags set #2.
06bc494ca11e Initial load
duke
parents:
diff changeset
   773
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   774
    boolean checkDisjoint(DiagnosticPosition pos, long flags, long set1, long set2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   775
        if ((flags & set1) != 0 && (flags & set2) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   776
            log.error(pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
   777
                      "illegal.combination.of.modifiers",
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   778
                      asFlagSet(TreeInfo.firstFlag(flags & set1)),
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
   779
                      asFlagSet(TreeInfo.firstFlag(flags & set2)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   780
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   781
        } else
06bc494ca11e Initial load
duke
parents:
diff changeset
   782
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   783
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   784
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   785
    /** Check that usage of diamond operator is correct (i.e. diamond should not
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   786
     * be used with non-generic classes or in anonymous class creation expressions)
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   787
     */
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   788
    Type checkDiamond(JCNewClass tree, Type t) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   789
        if (!TreeInfo.isDiamond(tree) ||
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   790
                t.isErroneous()) {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   791
            return checkClassType(tree.clazz.pos(), t, true);
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   792
        } else if (tree.def != null && !allowDiamondWithAnonymousClassCreation) {
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   793
            log.error(tree.clazz.pos(),
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   794
                    Errors.CantApplyDiamond1(t, Fragments.DiamondAndAnonClassNotSupportedInSource(source.name)));
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   795
            return types.createErrorType(t);
9073
a29adf86aa0c 7030687: Diamond: compiler accepts erroneous code where diamond is used with non-generic inner class
mcimadamore
parents: 8635
diff changeset
   796
        } else if (t.tsym.type.getTypeArguments().isEmpty()) {
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   797
            log.error(tree.clazz.pos(),
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   798
                "cant.apply.diamond.1",
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   799
                t, diags.fragment("diamond.non.generic", t));
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   800
            return types.createErrorType(t);
9604
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   801
        } else if (tree.typeargs != null &&
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   802
                tree.typeargs.nonEmpty()) {
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   803
            log.error(tree.clazz.pos(),
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   804
                "cant.apply.diamond.1",
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   805
                t, diags.fragment("diamond.and.explicit.params", t));
d7152128d22f 7039931: Project Coin: diamond inference fail with generic constructor explicit type-arguments
mcimadamore
parents: 9303
diff changeset
   806
            return types.createErrorType(t);
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   807
        } else {
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8628
diff changeset
   808
            return t;
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   809
        }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   810
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   811
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   812
    /** Check that the type inferred using the diamond operator does not contain
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   813
     *  non-denotable types such as captured types or intersection types.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   814
     *  @param t the type inferred using the diamond operator
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   815
     *  @return  the (possibly empty) list of non-denotable types.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   816
     */
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   817
    List<Type> checkDiamondDenotable(ClassType t) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   818
        ListBuffer<Type> buf = new ListBuffer<>();
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   819
        for (Type arg : t.allparams()) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   820
            if (!diamondTypeChecker.visit(arg, null)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   821
                buf.append(arg);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   822
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   823
        }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   824
        return buf.toList();
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   825
    }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   826
        // where
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   827
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   828
        /** diamondTypeChecker: A type visitor that descends down the given type looking for non-denotable
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   829
         *  types. The visit methods return false as soon as a non-denotable type is encountered and true
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   830
         *  otherwise.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   831
         */
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   832
        private static final Types.SimpleVisitor<Boolean, Void> diamondTypeChecker = new Types.SimpleVisitor<Boolean, Void>() {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   833
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   834
            public Boolean visitType(Type t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   835
                return true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   836
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   837
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   838
            public Boolean visitClassType(ClassType t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   839
                if (t.isCompound()) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   840
                    return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   841
                }
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   842
                for (Type targ : t.allparams()) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   843
                    if (!visit(targ, s)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   844
                        return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   845
                    }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   846
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   847
                return true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   848
            }
30403
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   849
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   850
            @Override
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   851
            public Boolean visitTypeVar(TypeVar t, Void s) {
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   852
                /* Any type variable mentioned in the inferred type must have been declared as a type parameter
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   853
                  (i.e cannot have been produced by inference (18.4))
30403
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   854
                */
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   855
                return t.tsym.owner.type.getTypeArguments().contains(t);
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   856
            }
c904bbdc5ec1 8078592: Compiler fails to reject erroneous use of diamond with anonymous classes involving "fresh" type variables.
sadayapalam
parents: 30069
diff changeset
   857
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   858
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   859
            public Boolean visitCapturedType(CapturedType t, Void s) {
32910
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   860
                /* Any type variable mentioned in the inferred type must have been declared as a type parameter
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   861
                  (i.e cannot have been produced by capture conversion (5.1.10))
064f2f066668 8132535: Compiler fails with diamond anonymous class creation with intersection bound of enclosing class
sadayapalam
parents: 32709
diff changeset
   862
                */
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   863
                return false;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   864
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   865
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   866
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   867
            public Boolean visitArrayType(ArrayType t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   868
                return visit(t.elemtype, s);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   869
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   870
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   871
            @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   872
            public Boolean visitWildcardType(WildcardType t, Void s) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   873
                return visit(t.type, s);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   874
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   875
        };
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
   876
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   877
    void checkVarargsMethodDecl(Env<AttrContext> env, JCMethodDecl tree) {
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   878
        MethodSymbol m = tree.sym;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   879
        if (!allowSimplifiedVarargs) return;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   880
        boolean hasTrustMeAnno = m.attribute(syms.trustMeType.tsym) != null;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   881
        Type varargElemType = null;
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   882
        if (m.isVarArgs()) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   883
            varargElemType = types.elemtype(tree.params.last().type);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   884
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   885
        if (hasTrustMeAnno && !isTrustMeAllowedOnMethod(m)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   886
            if (varargElemType != null) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   887
                log.error(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   888
                        "varargs.invalid.trustme.anno",
25283
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   889
                          syms.trustMeType.tsym,
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   890
                          allowPrivateSafeVarargs ?
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   891
                          diags.fragment("varargs.trustme.on.virtual.varargs", m) :
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   892
                          diags.fragment("varargs.trustme.on.virtual.varargs.final.only", m));
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   893
            } else {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   894
                log.error(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   895
                            "varargs.invalid.trustme.anno",
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   896
                            syms.trustMeType.tsym,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   897
                            diags.fragment("varargs.trustme.on.non.varargs.meth", m));
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   898
            }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   899
        } else if (hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   900
                            types.isReifiable(varargElemType)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   901
            warnUnsafeVararg(tree,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   902
                            "varargs.redundant.trustme.anno",
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   903
                            syms.trustMeType.tsym,
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   904
                            diags.fragment("varargs.trustme.on.reifiable.varargs", varargElemType));
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   905
        }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   906
        else if (!hasTrustMeAnno && varargElemType != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   907
                !types.isReifiable(varargElemType)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   908
            warnUnchecked(tree.params.head.pos(), "unchecked.varargs.non.reifiable.type", varargElemType);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   909
        }
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   910
    }
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   911
    //where
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   912
        private boolean isTrustMeAllowedOnMethod(Symbol s) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   913
            return (s.flags() & VARARGS) != 0 &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   914
                (s.isConstructor() ||
25283
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   915
                    (s.flags() & (STATIC | FINAL |
082d51b7010b 7196160: Project Coin: allow @SafeVarargs on private methods
darcy
parents: 25279
diff changeset
   916
                                  (allowPrivateSafeVarargs ? PRIVATE : 0) )) != 0);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   917
        }
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   918
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   919
    Type checkMethod(final Type mtype,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   920
            final Symbol sym,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   921
            final Env<AttrContext> env,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   922
            final List<JCExpression> argtrees,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   923
            final List<Type> argtypes,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   924
            final boolean useVarargs,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   925
            InferenceContext inferenceContext) {
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   926
        // System.out.println("call   : " + env.tree);
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   927
        // System.out.println("method : " + owntype);
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   928
        // System.out.println("actuals: " + argtypes);
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   929
        if (inferenceContext.free(mtype)) {
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   930
            inferenceContext.addFreeTypeListener(List.of(mtype), new FreeTypeListener() {
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   931
                public void typesInferred(InferenceContext inferenceContext) {
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   932
                    checkMethod(inferenceContext.asInstType(mtype), sym, env, argtrees, argtypes, useVarargs, inferenceContext);
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   933
                }
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   934
            });
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   935
            return mtype;
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   936
        }
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   937
        Type owntype = mtype;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   938
        List<Type> formals = owntype.getParameterTypes();
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   939
        List<Type> nonInferred = sym.type.getParameterTypes();
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   940
        if (nonInferred.length() != formals.length()) nonInferred = formals;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   941
        Type last = useVarargs ? formals.last() : null;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   942
        if (sym.name == names.init && sym.owner == syms.enumSym) {
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   943
            formals = formals.tail.tail;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   944
            nonInferred = nonInferred.tail.tail;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   945
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   946
        List<JCExpression> args = argtrees;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   947
        if (args != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   948
            //this is null when type-checking a method reference
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   949
            while (formals.head != last) {
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   950
                JCTree arg = args.head;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   951
                Warner warn = convertWarner(arg.pos(), arg.type, nonInferred.head);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   952
                assertConvertible(arg, arg.type, formals.head, warn);
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   953
                args = args.tail;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   954
                formals = formals.tail;
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   955
                nonInferred = nonInferred.tail;
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   956
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   957
            if (useVarargs) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   958
                Type varArg = types.elemtype(last);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   959
                while (args.tail != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   960
                    JCTree arg = args.head;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   961
                    Warner warn = convertWarner(arg.pos(), arg.type, varArg);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   962
                    assertConvertible(arg, arg.type, varArg, warn);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   963
                    args = args.tail;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   964
                }
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
   965
            } else if ((sym.flags() & (VARARGS | SIGNATURE_POLYMORPHIC)) == VARARGS) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   966
                // non-varargs call to varargs method
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   967
                Type varParam = owntype.getParameterTypes().last();
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   968
                Type lastArg = argtypes.last();
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   969
                if (types.isSubtypeUnchecked(lastArg, types.elemtype(varParam)) &&
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   970
                    !types.isSameType(types.erasure(varParam), types.erasure(lastArg)))
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   971
                    log.warning(argtrees.last().pos(), "inexact.non-varargs.call",
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   972
                                types.elemtype(varParam), varParam);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
   973
            }
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5842
diff changeset
   974
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   975
        if (useVarargs) {
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   976
            Type argtype = owntype.getParameterTypes().last();
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   977
            if (!types.isReifiable(argtype) &&
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   978
                (!allowSimplifiedVarargs ||
28594
f462f1662741 8069254: Warning issued despite @SafeVarargs annotation on constructor
jlahoda
parents: 28459
diff changeset
   979
                 sym.baseSymbol().attribute(syms.trustMeType.tsym) == null ||
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   980
                 !isTrustMeAllowedOnMethod(sym))) {
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   981
                warnUnchecked(env.tree.pos(),
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   982
                                  "unchecked.generic.array.creation",
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   983
                                  argtype);
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   984
            }
18389
a425d0819f36 8016569: javac, add new flag for polymorphic method signatures
vromero
parents: 18381
diff changeset
   985
            if ((sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) == 0) {
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18380
diff changeset
   986
                TreeInfo.setVarargsElement(env.tree, types.elemtype(argtype));
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   987
            }
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   988
         }
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   989
         return owntype;
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
   990
    }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12079
diff changeset
   991
    //where
19506
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   992
    private void assertConvertible(JCTree tree, Type actual, Type formal, Warner warn) {
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   993
        if (types.isConvertible(actual, formal, warn))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   994
            return;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   995
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   996
        if (formal.isCompound()
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   997
            && types.isSubtype(actual, types.supertype(formal))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   998
            && types.isSubtypeUnchecked(actual, types.interfaces(formal), warn))
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
   999
            return;
9314c30fef42 7182350: Regression in wording of unchecked warning message
kizune
parents: 19503
diff changeset
  1000
    }
5489
e7af65bf7577 6730476: invalid "unchecked generic array" warning
mcimadamore
parents: 5321
diff changeset
  1001
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1002
    /**
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1003
     * Check that type 't' is a valid instantiation of a generic class
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1004
     * (see JLS 4.5)
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1005
     *
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1006
     * @param t class type to be checked
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1007
     * @return true if 't' is well-formed
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1008
     */
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1009
    public boolean checkValidGenericType(Type t) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1010
        return firstIncompatibleTypeArg(t) == null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1011
    }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1012
    //WHERE
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1013
        private Type firstIncompatibleTypeArg(Type type) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1014
            List<Type> formals = type.tsym.type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1015
            List<Type> actuals = type.allparams();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1016
            List<Type> args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1017
            List<Type> forms = type.tsym.type.getTypeArguments();
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1018
            ListBuffer<Type> bounds_buf = new ListBuffer<>();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1019
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1020
            // For matching pairs of actual argument types `a' and
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1021
            // formal type parameters with declared bound `b' ...
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1022
            while (args.nonEmpty() && forms.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1023
                // exact type arguments needs to know their
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1024
                // bounds (for upper and lower bound
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1025
                // calculations).  So we create new bounds where
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1026
                // type-parameters are replaced with actuals argument types.
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1027
                bounds_buf.append(types.subst(forms.head.getUpperBound(), formals, actuals));
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1028
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1029
                forms = forms.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1030
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1031
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1032
            args = type.getTypeArguments();
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1033
            List<Type> tvars_cap = types.substBounds(formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1034
                                      formals,
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1035
                                      types.capture(type).allparams());
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1036
            while (args.nonEmpty() && tvars_cap.nonEmpty()) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1037
                // Let the actual arguments know their bound
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1038
                args.head.withTypeVar((TypeVar)tvars_cap.head);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1039
                args = args.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1040
                tvars_cap = tvars_cap.tail;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1041
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1042
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1043
            args = type.getTypeArguments();
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1044
            List<Type> bounds = bounds_buf.toList();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1045
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1046
            while (args.nonEmpty() && bounds.nonEmpty()) {
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1047
                Type actual = args.head;
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1048
                if (!isTypeArgErroneous(actual) &&
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1049
                        !bounds.head.isErroneous() &&
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1050
                        !checkExtends(actual, bounds.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1051
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1052
                }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1053
                args = args.tail;
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1054
                bounds = bounds.tail;
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1055
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1056
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1057
            args = type.getTypeArguments();
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1058
            bounds = bounds_buf.toList();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1059
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1060
            for (Type arg : types.capture(type).getTypeArguments()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1061
                if (arg.hasTag(TYPEVAR) &&
8044
7fd529d4472c 6943278: spurious error message for inference and type-variable with erroneous bound
mcimadamore
parents: 8037
diff changeset
  1062
                        arg.getUpperBound().isErroneous() &&
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1063
                        !bounds.head.isErroneous() &&
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1064
                        !isTypeArgErroneous(args.head)) {
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1065
                    return args.head;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1066
                }
12077
2038f4fe956e 7148242: Regression: valid code rejected during generic type well-formedness check
mcimadamore
parents: 11868
diff changeset
  1067
                bounds = bounds.tail;
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1068
                args = args.tail;
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1069
            }
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1070
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1071
            return null;
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1072
        }
8238
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1073
        //where
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1074
        boolean isTypeArgErroneous(Type t) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1075
            return isTypeArgErroneous.visit(t);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1076
        }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1077
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1078
        Types.UnaryVisitor<Boolean> isTypeArgErroneous = new Types.UnaryVisitor<Boolean>() {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1079
            public Boolean visitType(Type t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1080
                return t.isErroneous();
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1081
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1082
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1083
            public Boolean visitTypeVar(TypeVar t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1084
                return visit(t.getUpperBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1085
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1086
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1087
            public Boolean visitCapturedType(CapturedType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1088
                return visit(t.getUpperBound()) ||
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1089
                        visit(t.getLowerBound());
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1090
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1091
            @Override
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1092
            public Boolean visitWildcardType(WildcardType t, Void s) {
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1093
                return visit(t.type);
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1094
            }
15ff254ff5c2 6969184: poor error recovery after symbol not found
mcimadamore
parents: 8237
diff changeset
  1095
        };
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1096
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
    /** Check that given modifiers are legal for given symbol and
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1098
     *  return modifiers together with any implicit modifiers for that symbol.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
     *  Warning: we can't use flags() here since this method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
     *  is called during class enter, when flags() would cause a premature
06bc494ca11e Initial load
duke
parents:
diff changeset
  1101
     *  completion.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
     *  @param pos           Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1103
     *  @param flags         The set of modifiers given in a definition.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1104
     *  @param sym           The defined symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
    long checkFlags(DiagnosticPosition pos, long flags, Symbol sym, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1107
        long mask;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1108
        long implicit = 0;
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1109
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1110
        switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1111
        case VAR:
24903
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1112
            if (TreeInfo.isReceiverParam(tree))
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1113
                mask = ReceiverParamFlags;
41e1812d6b4c 8027886: javac allows illegal receiver parameters
pgovereau
parents: 24902
diff changeset
  1114
            else if (sym.owner.kind != TYP)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1115
                mask = LocalVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1116
            else if ((sym.owner.flags_field & INTERFACE) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1117
                mask = implicit = InterfaceVarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1118
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1119
                mask = VarFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1120
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1121
        case MTH:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1122
            if (sym.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1123
                if ((sym.owner.flags_field & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1124
                    // enum constructors cannot be declared public or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1125
                    // protected and must be implicitly or explicitly
06bc494ca11e Initial load
duke
parents:
diff changeset
  1126
                    // private
06bc494ca11e Initial load
duke
parents:
diff changeset
  1127
                    implicit = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1128
                    mask = PRIVATE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1129
                } else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1130
                    mask = ConstructorFlags;
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1131
            }  else if ((sym.owner.flags_field & INTERFACE) != 0) {
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1132
                if ((sym.owner.flags_field & ANNOTATION) != 0) {
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1133
                    mask = AnnotationTypeElementMask;
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1134
                    implicit = PUBLIC | ABSTRACT;
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1135
                } else if ((flags & (DEFAULT | STATIC | PRIVATE)) != 0) {
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1136
                    mask = InterfaceMethodMask;
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1137
                    implicit = (flags & PRIVATE) != 0 ? 0 : PUBLIC;
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1138
                    if ((flags & DEFAULT) != 0) {
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1139
                        implicit |= ABSTRACT;
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1140
                    }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1141
                } else {
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1142
                    mask = implicit = InterfaceMethodFlags;
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1143
                }
19930
b6181c0049f3 8022322: Reject default and static methods in annotation
emc
parents: 19914
diff changeset
  1144
            } else {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1145
                mask = MethodFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1146
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1147
            // Imply STRICTFP if owner has STRICTFP set.
17281
7c38e715fd75 8012723: strictfp interface misses strictfp modifer on default method
vromero
parents: 16546
diff changeset
  1148
            if (((flags|implicit) & Flags.ABSTRACT) == 0 ||
7c38e715fd75 8012723: strictfp interface misses strictfp modifer on default method
vromero
parents: 16546
diff changeset
  1149
                ((flags) & Flags.DEFAULT) != 0)
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1150
                implicit |= sym.owner.flags_field & STRICTFP;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1151
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1152
        case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1153
            if (sym.isLocal()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1154
                mask = LocalClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1155
                if ((sym.owner.flags_field & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1156
                    (flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1158
            } else if (sym.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
                mask = MemberClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1160
                if (sym.owner.owner.kind == PCK ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1161
                    (sym.owner.flags_field & STATIC) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1162
                    mask |= STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
                else if ((flags & ENUM) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
                    log.error(pos, "enums.must.be.static");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
                // Nested interfaces and enums are always STATIC (Spec ???)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
                if ((flags & (INTERFACE | ENUM)) != 0 ) implicit = STATIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
                mask = ClassFlags;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
            // Interfaces are always ABSTRACT
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
            if ((flags & INTERFACE) != 0) implicit |= ABSTRACT;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
            if ((flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
                // enums can't be declared abstract or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
                mask &= ~(ABSTRACT | FINAL);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
                implicit |= implicitEnumFinalFlag(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
            // Imply STRICTFP if owner has STRICTFP set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
            implicit |= sym.owner.flags_field & STRICTFP;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1180
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1181
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1182
            throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1183
        }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1184
        long illegal = flags & ExtendedStandardFlags & ~mask;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1185
        if (illegal != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1186
            if ((illegal & INTERFACE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1187
                log.error(pos, "intf.not.allowed.here");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1188
                mask |= INTERFACE;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1189
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1190
            else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1191
                log.error(pos,
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1192
                          "mod.not.allowed.here", asFlagSet(illegal));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1193
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1194
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1195
        else if ((sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1196
                  // ISSUE: Disallowing abstract&private is no longer appropriate
06bc494ca11e Initial load
duke
parents:
diff changeset
  1197
                  // in the presence of inner classes. Should it be deleted here?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1198
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1199
                                ABSTRACT,
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1200
                                PRIVATE | STATIC | DEFAULT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1201
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1202
                 checkDisjoint(pos, flags,
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1203
                                STATIC | PRIVATE,
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1204
                                DEFAULT)
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1205
                 &&
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  1206
                 checkDisjoint(pos, flags,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1207
                               ABSTRACT | INTERFACE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1208
                               FINAL | NATIVE | SYNCHRONIZED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1209
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1210
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1211
                               PUBLIC,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1212
                               PRIVATE | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1213
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1214
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1215
                               PRIVATE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1216
                               PUBLIC | PROTECTED)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1217
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1218
                 checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1219
                               FINAL,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1220
                               VOLATILE)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1221
                 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1222
                 (sym.kind == TYP ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1223
                  checkDisjoint(pos, flags,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1224
                                ABSTRACT | NATIVE,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1225
                                STRICTFP))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1226
            // skip
06bc494ca11e Initial load
duke
parents:
diff changeset
  1227
        }
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
  1228
        return flags & (mask | ~ExtendedStandardFlags) | implicit;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1229
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1230
06bc494ca11e Initial load
duke
parents:
diff changeset
  1231
06bc494ca11e Initial load
duke
parents:
diff changeset
  1232
    /** Determine if this enum should be implicitly final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1233
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1234
     *  If the enum has no specialized enum contants, it is final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1235
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1236
     *  If the enum does have specialized enum contants, it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1237
     *  <i>not</i> final.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1238
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1239
    private long implicitEnumFinalFlag(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  1240
        if (!tree.hasTag(CLASSDEF)) return 0;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1241
        class SpecialTreeVisitor extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1242
            boolean specialized;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
            SpecialTreeVisitor() {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
                this.specialized = false;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1245
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1247
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1248
            public void visitTree(JCTree tree) { /* no-op */ }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1249
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1250
            @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1251
            public void visitVarDef(JCVariableDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1252
                if ((tree.mods.flags & ENUM) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1253
                    if (tree.init instanceof JCNewClass &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
                        ((JCNewClass) tree.init).def != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1255
                        specialized = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
        SpecialTreeVisitor sts = new SpecialTreeVisitor();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
        JCClassDecl cdef = (JCClassDecl) tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1263
        for (JCTree defs: cdef.defs) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
            defs.accept(sts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1265
            if (sts.specialized) return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1266
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1267
        return FINAL;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1271
 * Type Validation
06bc494ca11e Initial load
duke
parents:
diff changeset
  1272
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1273
06bc494ca11e Initial load
duke
parents:
diff changeset
  1274
    /** Validate a type expression. That is,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1275
     *  check that all type arguments of a parametric type are within
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17552
diff changeset
  1276
     *  their bounds. This must be done in a second phase after type attribution
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1277
     *  since a class might have a subclass as type parameter bound. E.g:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1278
     *
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
  1279
     *  <pre>{@code
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1280
     *  class B<A extends C> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1281
     *  class C extends B<C> { ... }
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14062
diff changeset
  1282
     *  }</pre>
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1283
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1284
     *  and we can't make sure that the bound is already attributed because
06bc494ca11e Initial load
duke
parents:
diff changeset
  1285
     *  of possible cycles.
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1286
     *
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1287
     * Visitor method: Validate a type expression, if it is not null, catching
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
     *  and reporting any completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1289
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1290
    void validate(JCTree tree, Env<AttrContext> env) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1291
        validate(tree, env, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1292
    }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1293
    void validate(JCTree tree, Env<AttrContext> env, boolean checkRaw) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1294
        new Validator(env).validateTree(tree, checkRaw, true);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1295
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1296
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
    /** Visitor method: Validate a list of type expressions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
     */
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1299
    void validate(List<? extends JCTree> trees, Env<AttrContext> env) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
        for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1301
            validate(l.head, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
    /** A visitor class for type validation.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
    class Validator extends JCTree.Visitor {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1307
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1308
        boolean checkRaw;
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1309
        boolean isOuter;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1310
        Env<AttrContext> env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1311
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1312
        Validator(Env<AttrContext> env) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1313
            this.env = env;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1314
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1315
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1316
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1317
        public void visitTypeArray(JCArrayTypeTree tree) {
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1318
            validateTree(tree.elemtype, checkRaw, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1319
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1320
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1321
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1322
        public void visitTypeApply(JCTypeApply tree) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1323
            if (tree.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1324
                List<JCExpression> args = tree.arguments;
1531
37df4e42719a 6557954: Inner class type parameters doesn't get substituted when checking type well-formedness
mcimadamore
parents: 1527
diff changeset
  1325
                List<Type> forms = tree.type.tsym.type.getTypeArguments();
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1326
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1327
                Type incompatibleArg = firstIncompatibleTypeArg(tree.type);
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1328
                if (incompatibleArg != null) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1329
                    for (JCTree arg : tree.arguments) {
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1330
                        if (arg.type == incompatibleArg) {
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1331
                            log.error(arg, "not.within.bounds", incompatibleArg, forms.head);
8037
b3f278fe95d6 7007432: Test generic types well-formedness
mcimadamore
parents: 8032
diff changeset
  1332
                        }
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1333
                        forms = forms.tail;
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1334
                     }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1335
                 }
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1336
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8044
diff changeset
  1337
                forms = tree.type.tsym.type.getTypeArguments();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1338
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1339
                boolean is_java_lang_Class = tree.type.tsym.flatName() == names.java_lang_Class;
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1340
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1341
                // For matching pairs of actual argument types `a' and
06bc494ca11e Initial load
duke
parents:
diff changeset
  1342
                // formal type parameters with declared bound `b' ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1343
                while (args.nonEmpty() && forms.nonEmpty()) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1344
                    validateTree(args.head,
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1345
                            !(isOuter && is_java_lang_Class),
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1346
                            false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1347
                    args = args.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1348
                    forms = forms.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1349
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1350
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1353
                if (tree.type.getEnclosingType().isRaw())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1354
                    log.error(tree.pos(), "improperly.formed.type.inner.raw.param");
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  1355
                if (tree.clazz.hasTag(SELECT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1356
                    visitSelectInternal((JCFieldAccess)tree.clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1357
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1358
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1359
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1360
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1361
        public void visitTypeParameter(JCTypeParameter tree) {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1362
            validateTrees(tree.bounds, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1363
            checkClassBounds(tree.pos(), tree.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1364
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1365
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
        @Override
06bc494ca11e Initial load
duke
parents:
diff changeset
  1367
        public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1368
            if (tree.inner != null)
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1369
                validateTree(tree.inner, true, isOuter);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1370
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1371
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1372
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
        public void visitSelect(JCFieldAccess tree) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1374
            if (tree.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1375
                visitSelectInternal(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1376
06bc494ca11e Initial load
duke
parents:
diff changeset
  1377
                // Check that this type is either fully parameterized, or
06bc494ca11e Initial load
duke
parents:
diff changeset
  1378
                // not parameterized at all.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
                if (tree.selected.type.isParameterized() && tree.type.tsym.type.getTypeArguments().nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1380
                    log.error(tree.pos(), "improperly.formed.type.param.missing");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1381
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1382
        }
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1383
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1384
        public void visitSelectInternal(JCFieldAccess tree) {
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1385
            if (tree.type.tsym.isStatic() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1386
                tree.selected.type.isParameterized()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1387
                // The enclosing type is not a class, so we are
06bc494ca11e Initial load
duke
parents:
diff changeset
  1388
                // looking at a static member type.  However, the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1389
                // qualifying expression is parameterized.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
                log.error(tree.pos(), "cant.select.static.class.from.param.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1392
                // otherwise validate the rest of the expression
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1393
                tree.selected.accept(this);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1394
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1395
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1396
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1397
        @Override
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1398
        public void visitAnnotatedType(JCAnnotatedType tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1399
            tree.underlyingType.accept(this);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1400
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1401
21896
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1402
        @Override
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1403
        public void visitTypeIdent(JCPrimitiveTypeTree that) {
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1404
            if (that.type.hasTag(TypeTag.VOID)) {
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1405
                log.error(that.pos(), "void.not.allowed.here");
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1406
            }
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1407
            super.visitTypeIdent(that);
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1408
        }
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21712
diff changeset
  1409
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1410
        /** Default visitor method: do nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1411
         */
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  1412
        @Override
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1413
        public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1414
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1415
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1416
        public void validateTree(JCTree tree, boolean checkRaw, boolean isOuter) {
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1417
            if (tree != null) {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1418
                boolean prevCheckRaw = this.checkRaw;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1419
                this.checkRaw = checkRaw;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1420
                this.isOuter = isOuter;
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1421
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1422
                try {
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1423
                    tree.accept(this);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1424
                    if (checkRaw)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1425
                        checkRaw(tree, env);
20240
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1426
                } catch (CompletionFailure ex) {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1427
                    completionError(tree.pos(), ex);
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1428
                } finally {
1818352eef49 8022567: Javac Should Generate Warnings For Raw Array Type
jlahoda
parents: 19942
diff changeset
  1429
                    this.checkRaw = prevCheckRaw;
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1430
                }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1431
            }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1432
        }
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1433
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1434
        public void validateTrees(List<? extends JCTree> trees, boolean checkRaw, boolean isOuter) {
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1435
            for (List<? extends JCTree> l = trees; l.nonEmpty(); l = l.tail)
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1436
                validateTree(l.head, checkRaw, isOuter);
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1437
        }
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1438
    }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1439
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1440
    void checkRaw(JCTree tree, Env<AttrContext> env) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1441
        if (lint.isEnabled(LintCategory.RAW) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1442
            tree.type.hasTag(CLASS) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1443
            !TreeInfo.isDiamond(tree) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1444
            !withinAnonConstr(env) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1445
            tree.type.isRaw()) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1446
            log.warning(LintCategory.RAW,
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1447
                    tree.pos(), "raw.class.use", tree.type, tree.type.tsym.type);
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  1448
        }
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1449
    }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1450
    //where
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17578
diff changeset
  1451
        private boolean withinAnonConstr(Env<AttrContext> env) {
10721
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1452
            return env.enclClass.name.isEmpty() &&
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1453
                    env.enclMethod != null && env.enclMethod.name == names.init;
ca322e50ddb7 7090499: missing rawtypes warnings in anonymous inner class
mcimadamore
parents: 10626
diff changeset
  1454
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1455
06bc494ca11e Initial load
duke
parents:
diff changeset
  1456
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1457
 * Exception checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1458
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1459
06bc494ca11e Initial load
duke
parents:
diff changeset
  1460
    /* The following methods treat classes as sets that contain
06bc494ca11e Initial load
duke
parents:
diff changeset
  1461
     * the class itself and all their subclasses
06bc494ca11e Initial load
duke
parents:
diff changeset
  1462
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1463
06bc494ca11e Initial load
duke
parents:
diff changeset
  1464
    /** Is given type a subtype of some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1465
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1466
    boolean subset(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1467
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1468
            if (types.isSubtype(t, l.head)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
    /** Is given type a subtype or supertype of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1473
     *  some of the types in given list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
    boolean intersects(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
        for (List<Type> l = ts; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
            if (types.isSubtype(t, l.head) || types.isSubtype(l.head, t)) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1479
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
06bc494ca11e Initial load
duke
parents:
diff changeset
  1481
    /** Add type set to given type list, unless it is a subclass of some class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1482
     *  in the list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1483
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1484
    List<Type> incl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1485
        return subset(t, ts) ? ts : excl(t, ts).prepend(t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1486
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1487
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
    /** Remove type set from type set list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1489
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1490
    List<Type> excl(Type t, List<Type> ts) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1491
        if (ts.isEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1492
            return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1493
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1494
            List<Type> ts1 = excl(t, ts.tail);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1495
            if (types.isSubtype(ts.head, t)) return ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1496
            else if (ts1 == ts.tail) return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1497
            else return ts1.prepend(ts.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1498
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1499
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1500
06bc494ca11e Initial load
duke
parents:
diff changeset
  1501
    /** Form the union of two type set lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1502
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1503
    List<Type> union(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1504
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1505
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1506
            ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1507
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1508
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1509
06bc494ca11e Initial load
duke
parents:
diff changeset
  1510
    /** Form the difference of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1511
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1512
    List<Type> diff(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1513
        List<Type> ts = ts1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1514
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1515
            ts = excl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1516
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1517
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1518
06bc494ca11e Initial load
duke
parents:
diff changeset
  1519
    /** Form the intersection of two type lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1520
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1521
    public List<Type> intersect(List<Type> ts1, List<Type> ts2) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1522
        List<Type> ts = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1523
        for (List<Type> l = ts1; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
            if (subset(l.head, ts2)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
        for (List<Type> l = ts2; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
            if (subset(l.head, ts1)) ts = incl(l.head, ts);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
        return ts;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
    /** Is exc an exception symbol that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
    boolean isUnchecked(ClassSymbol exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
            exc.kind == ERR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1535
            exc.isSubClass(syms.errorType.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1536
            exc.isSubClass(syms.runtimeExceptionType.tsym, types);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1537
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1538
06bc494ca11e Initial load
duke
parents:
diff changeset
  1539
    /** Is exc an exception type that need not be declared?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1540
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1541
    boolean isUnchecked(Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1542
        return
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1543
            (exc.hasTag(TYPEVAR)) ? isUnchecked(types.supertype(exc)) :
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1544
            (exc.hasTag(CLASS)) ? isUnchecked((ClassSymbol)exc.tsym) :
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1545
            exc.hasTag(BOT);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1546
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1547
06bc494ca11e Initial load
duke
parents:
diff changeset
  1548
    /** Same, but handling completion failures.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1549
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1550
    boolean isUnchecked(DiagnosticPosition pos, Type exc) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
            return isUnchecked(exc);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
            completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1555
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1556
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1557
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1558
06bc494ca11e Initial load
duke
parents:
diff changeset
  1559
    /** Is exc handled by given exception list?
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
    boolean isHandled(Type exc, List<Type> handled) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
        return isUnchecked(exc) || subset(exc, handled);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1564
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
    /** Return all exceptions in thrown list that are not in handled list.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
     *  @param thrown     The list of thrown exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
     *  @param handled    The list of handled exceptions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
     */
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1569
    List<Type> unhandled(List<Type> thrown, List<Type> handled) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
        List<Type> unhandled = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
        for (List<Type> l = thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
            if (!isHandled(l.head, handled)) unhandled = unhandled.prepend(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
        return unhandled;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
 * Overriding/Implementation checking
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
    /** The level of access protection given by a flag set,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
     *  where PRIVATE is highest and PUBLIC is lowest.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
    static int protection(long flags) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
        switch ((short)(flags & AccessFlags)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
        case PRIVATE: return 3;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1586
        case PROTECTED: return 1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1587
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1588
        case PUBLIC: return 0;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1589
        case 0: return 2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1590
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1591
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1592
06bc494ca11e Initial load
duke
parents:
diff changeset
  1593
    /** A customized "cannot override" error message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1594
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1595
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1596
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1597
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1598
    Object cannotOverride(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1599
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1600
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1601
            key = "cant.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1602
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1603
            key = "cant.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1605
            key = "clashes.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1606
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1607
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1608
06bc494ca11e Initial load
duke
parents:
diff changeset
  1609
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1610
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1611
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1613
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1614
    Object uncheckedOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1615
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1616
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1617
            key = "unchecked.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1618
        else if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1619
            key = "unchecked.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1620
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1621
            key = "unchecked.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1622
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1623
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1624
06bc494ca11e Initial load
duke
parents:
diff changeset
  1625
    /** A customized "override" warning message.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1626
     *  @param m      The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1627
     *  @param other  The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
     *  @return       An internationalized string.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1629
     */
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1630
    Object varargsOverrides(MethodSymbol m, MethodSymbol other) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1631
        String key;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1632
        if ((other.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1633
            key = "varargs.override";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1634
        else  if ((m.owner.flags() & INTERFACE) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1635
            key = "varargs.implement";
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
        else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1637
            key = "varargs.clash.with";
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 939
diff changeset
  1638
        return diags.fragment(key, m, m.location(), other, other.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1640
06bc494ca11e Initial load
duke
parents:
diff changeset
  1641
    /** Check that this method conforms with overridden method 'other'.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1642
     *  where `origin' is the class where checking started.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
     *  Complications:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1644
     *  (1) Do not check overriding of synthetic methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
     *      (reason: they might be final).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
     *      todo: check whether this is still necessary.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1647
     *  (2) Admit the case where an interface proxy throws fewer exceptions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1648
     *      than the method it implements. Augment the proxy methods with the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1649
     *      undeclared exceptions in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1650
     *  (3) When generics are enabled, admit the case where an interface proxy
06bc494ca11e Initial load
duke
parents:
diff changeset
  1651
     *      has a result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1652
     *      extended by the result type of the method it implements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1653
     *      Change the proxies result type to the smaller type in this case.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1654
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1655
     *  @param tree         The tree from which positions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1656
     *                      are extracted for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1657
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1658
     *  @param other        The overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1659
     *  @param origin       The class of which the overriding method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1660
     *                      is a member.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1662
    void checkOverride(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1663
                       MethodSymbol m,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1664
                       MethodSymbol other,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1665
                       ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1666
        // Don't check overriding of synthetic methods or by bridge methods.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1667
        if ((m.flags() & (SYNTHETIC|BRIDGE)) != 0 || (other.flags() & SYNTHETIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1668
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1669
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1670
06bc494ca11e Initial load
duke
parents:
diff changeset
  1671
        // Error if static method overrides instance method (JLS 8.4.6.2).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1672
        if ((m.flags() & STATIC) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1673
                   (other.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.static",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1675
                      cannotOverride(m, other));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1676
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1677
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
06bc494ca11e Initial load
duke
parents:
diff changeset
  1680
        // Error if instance method overrides static or final
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
        // method (JLS 8.4.6.1).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1682
        if ((other.flags() & FINAL) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1683
                 (m.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1684
                 (other.flags() & STATIC) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1685
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.meth",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1686
                      cannotOverride(m, other),
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1687
                      asFlagSet(other.flags() & (FINAL | STATIC)));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1688
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1689
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1690
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
06bc494ca11e Initial load
duke
parents:
diff changeset
  1692
        if ((m.owner.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
            // handled in validateAnnotationMethod
06bc494ca11e Initial load
duke
parents:
diff changeset
  1694
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
        // Error if overriding method has weaker access (JLS 8.4.6.3).
29293
1583c6dd6df7 8071453: Allow interface methods to be private
sadayapalam
parents: 29149
diff changeset
  1698
        if (protection(m.flags()) > protection(other.flags())) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1699
            log.error(TreeInfo.diagnosticPositionFor(m, tree), "override.weaker.access",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
                      cannotOverride(m, other),
23796
4c722b177a8f 8035956: javac, incomplete error message
kizune
parents: 23111
diff changeset
  1701
                      (other.flags() & AccessFlags) == 0 ?
18411
58e11c41d705 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits
vromero
parents: 18395
diff changeset
  1702
                          "package" :
939
38e24969c7e9 6717241: some diagnostic argument is prematurely converted into a String object
mcimadamore
parents: 938
diff changeset
  1703
                          asFlagSet(other.flags() & AccessFlags));
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1704
            m.flags_field |= BAD_OVERRIDE;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1707
06bc494ca11e Initial load
duke
parents:
diff changeset
  1708
        Type mt = types.memberType(origin.type, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1709
        Type ot = types.memberType(origin.type, other);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1710
        // Error if overriding result type is different
06bc494ca11e Initial load
duke
parents:
diff changeset
  1711
        // (or, in the case of generics mode, not a subtype) of
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
        // overridden result type. We have to rename any type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
        // before comparing types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
        List<Type> mtvars = mt.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
        List<Type> otvars = ot.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
        Type mtres = mt.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
        Type otres = types.subst(ot.getReturnType(), otvars, mtvars);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1719
        overrideWarner.clear();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
        boolean resultTypesOK =
1874
891c2d6823bb 6797463: 6557199 breaks the jax-ws workspace
tbell
parents: 1868
diff changeset
  1721
            types.returnTypeSubstitutable(mt, ot, otres, overrideWarner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
        if (!resultTypesOK) {
33713
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1723
            if ((m.flags() & STATIC) != 0 && (other.flags() & STATIC) != 0) {
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1724
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1725
                        Errors.OverrideIncompatibleRet(Fragments.CantHide(m, m.location(), other,
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1726
                                        other.location()), mtres, otres));
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1727
                m.flags_field |= BAD_OVERRIDE;
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1728
            } else {
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1729
                log.error(TreeInfo.diagnosticPositionFor(m, tree),
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1730
                        "override.incompatible.ret",
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1731
                        cannotOverride(m, other),
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1732
                        mtres, otres);
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1733
                m.flags_field |= BAD_OVERRIDE;
dc1d2632935c 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods
sadayapalam
parents: 33709
diff changeset
  1734
            }
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1735
            return;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1736
        } else if (overrideWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1737
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1738
                    "override.unchecked.ret",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1739
                    uncheckedOverrides(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1740
                    mtres, otres);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1741
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1742
06bc494ca11e Initial load
duke
parents:
diff changeset
  1743
        // Error if overriding method throws an exception not reported
06bc494ca11e Initial load
duke
parents:
diff changeset
  1744
        // by overridden method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
        List<Type> otthrown = types.subst(ot.getThrownTypes(), otvars, mtvars);
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1746
        List<Type> unhandledErased = unhandled(mt.getThrownTypes(), types.erasure(otthrown));
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1747
        List<Type> unhandledUnerased = unhandled(mt.getThrownTypes(), otthrown);
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1748
        if (unhandledErased.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1749
            log.error(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1750
                      "override.meth.doesnt.throw",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1751
                      cannotOverride(m, other),
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1752
                      unhandledUnerased.head);
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  1753
            m.flags_field |= BAD_OVERRIDE;
3560
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1754
            return;
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1755
        }
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1756
        else if (unhandledUnerased.nonEmpty()) {
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1757
            warnUnchecked(TreeInfo.diagnosticPositionFor(m, tree),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1758
                          "override.unchecked.thrown",
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1759
                         cannotOverride(m, other),
bbfccbd92afe 6199153: Generic throws and overriding
mcimadamore
parents: 3557
diff changeset
  1760
                         unhandledUnerased.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1761
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
        // Optional warning if varargs don't agree
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
        if ((((m.flags() ^ other.flags()) & Flags.VARARGS) != 0)
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1766
            && lint.isEnabled(LintCategory.OVERRIDES)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1767
            log.warning(TreeInfo.diagnosticPositionFor(m, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1768
                        ((m.flags() & Flags.VARARGS) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1769
                        ? "override.varargs.missing"
06bc494ca11e Initial load
duke
parents:
diff changeset
  1770
                        : "override.varargs.extra",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1771
                        varargsOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1772
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1773
06bc494ca11e Initial load
duke
parents:
diff changeset
  1774
        // Warn if instance method overrides bridge method (compiler spec ??)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1775
        if ((other.flags() & BRIDGE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1776
            log.warning(TreeInfo.diagnosticPositionFor(m, tree), "override.bridge",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1777
                        uncheckedOverrides(m, other));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1778
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
06bc494ca11e Initial load
duke
parents:
diff changeset
  1780
        // Warn if a deprecated method overridden by a non-deprecated one.
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  1781
        if (!isDeprecatedOverrideIgnorable(other, origin)) {
23111
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1782
            Lint prevLint = setLint(lint.augment(m));
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1783
            try {
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1784
                checkDeprecated(TreeInfo.diagnosticPositionFor(m, tree), m, other);
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1785
            } finally {
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1786
                setLint(prevLint);
ef4562cfb234 8033421: @SuppressWarnings("deprecation") does not work when overriding deprecated method
jlahoda
parents: 22688
diff changeset
  1787
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1788
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1789
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1790
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1791
        private boolean isDeprecatedOverrideIgnorable(MethodSymbol m, ClassSymbol origin) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1792
            // If the method, m, is defined in an interface, then ignore the issue if the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1793
            // is only inherited via a supertype and also implemented in the supertype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1794
            // because in that case, we will rediscover the issue when examining the method
06bc494ca11e Initial load
duke
parents:
diff changeset
  1795
            // in the supertype.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1796
            // If the method, m, is not defined in an interface, then the only time we need to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1797
            // address the issue is when the method is the supertype implemementation: any other
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
            // case, we will have dealt with when examining the supertype classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  1799
            ClassSymbol mc = m.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1800
            Type st = types.supertype(origin.type);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1801
            if (!st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1802
                return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1803
            MethodSymbol stimpl = m.implementation((ClassSymbol)st.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1804
06bc494ca11e Initial load
duke
parents:
diff changeset
  1805
            if (mc != null && ((mc.flags() & INTERFACE) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1806
                List<Type> intfs = types.interfaces(origin.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1807
                return (intfs.contains(mc.type) ? false : (stimpl != null));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1808
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1809
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1810
                return (stimpl != m);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1812
06bc494ca11e Initial load
duke
parents:
diff changeset
  1813
06bc494ca11e Initial load
duke
parents:
diff changeset
  1814
    // used to check if there were any unchecked conversions
06bc494ca11e Initial load
duke
parents:
diff changeset
  1815
    Warner overrideWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1816
06bc494ca11e Initial load
duke
parents:
diff changeset
  1817
    /** Check that a class does not inherit two concrete methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1818
     *  with the same signature.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1819
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1820
     *  @param site         The class type to be checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1821
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1822
    public void checkCompatibleConcretes(DiagnosticPosition pos, Type site) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1823
        Type sup = types.supertype(site);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1824
        if (!sup.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1825
06bc494ca11e Initial load
duke
parents:
diff changeset
  1826
        for (Type t1 = sup;
19503
58688e470d3b 8022508: javac crashes if the generics arity of a base class is wrong
jlahoda
parents: 19492
diff changeset
  1827
             t1.hasTag(CLASS) && t1.tsym.type.isParameterized();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1828
             t1 = types.supertype(t1)) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1829
            for (Symbol s1 : t1.tsym.members().getSymbols(NON_RECURSIVE)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1830
                if (s1.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1831
                    (s1.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1832
                    !s1.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1833
                    ((MethodSymbol)s1).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1834
                                                      types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1835
                                                      true) != s1)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1836
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1837
                Type st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1838
                int s1ArgsLength = st1.getParameterTypes().length();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1839
                if (st1 == s1.type) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1840
06bc494ca11e Initial load
duke
parents:
diff changeset
  1841
                for (Type t2 = sup;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1842
                     t2.hasTag(CLASS);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1843
                     t2 = types.supertype(t2)) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1844
                    for (Symbol s2 : t2.tsym.members().getSymbolsByName(s1.name)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1845
                        if (s2 == s1 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1846
                            s2.kind != MTH ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1847
                            (s2.flags() & (STATIC|SYNTHETIC|BRIDGE)) != 0 ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1848
                            s2.type.getParameterTypes().length() != s1ArgsLength ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1849
                            !s2.isInheritedIn(site.tsym, types) ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  1850
                            ((MethodSymbol)s2).implementation(site.tsym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1851
                                                              types,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1852
                                                              true) != s2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1853
                            continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1854
                        Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1855
                        if (types.overrideEquivalent(st1, st2))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1856
                            log.error(pos, "concrete.inheritance.conflict",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1857
                                      s1, t1, s2, t2, sup);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1859
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1860
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1861
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1862
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1863
06bc494ca11e Initial load
duke
parents:
diff changeset
  1864
    /** Check that classes (or interfaces) do not each define an abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1865
     *  method with same name and arguments but incompatible return types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1866
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1867
     *  @param t1           The first argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1868
     *  @param t2           The second argument type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1870
    public boolean checkCompatibleAbstracts(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1871
                                            Type t1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1872
                                            Type t2,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1873
                                            Type site) {
24902
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1874
        if ((site.tsym.flags() & COMPOUND) != 0) {
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1875
            // special case for intersections: need to eliminate wildcards in supertypes
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1876
            t1 = types.capture(t1);
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1877
            t2 = types.capture(t2);
de6c922c8712 8015101: Covariance of return type implied by upper bounding on type parameter is ignored
dlsmith
parents: 24612
diff changeset
  1878
        }
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1879
        return firstIncompatibility(pos, t1, t2, site) == null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1881
06bc494ca11e Initial load
duke
parents:
diff changeset
  1882
    /** Return the first method which is defined with same args
06bc494ca11e Initial load
duke
parents:
diff changeset
  1883
     *  but different return types in two given interfaces, or null if none
06bc494ca11e Initial load
duke
parents:
diff changeset
  1884
     *  exists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1885
     *  @param t1     The first type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1886
     *  @param t2     The second type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1887
     *  @param site   The most derived type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
     *  @returns symbol from t2 that conflicts with one in t1.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
     */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1890
    private Symbol firstIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1891
        Map<TypeSymbol,Type> interfaces1 = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
        closure(t1, interfaces1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
        Map<TypeSymbol,Type> interfaces2;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
        if (t1 == t2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
            interfaces2 = interfaces1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
        else
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1897
            closure(t2, interfaces1, interfaces2 = new HashMap<>());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1898
06bc494ca11e Initial load
duke
parents:
diff changeset
  1899
        for (Type t3 : interfaces1.values()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1900
            for (Type t4 : interfaces2.values()) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1901
                Symbol s = firstDirectIncompatibility(pos, t3, t4, site);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1902
                if (s != null) return s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1903
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1904
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1905
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1906
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1907
06bc494ca11e Initial load
duke
parents:
diff changeset
  1908
    /** Compute all the supertypes of t, indexed by type symbol. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1909
    private void closure(Type t, Map<TypeSymbol,Type> typeMap) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1910
        if (!t.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1911
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1912
            closure(types.supertype(t), typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1913
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1914
                closure(i, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1915
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1917
06bc494ca11e Initial load
duke
parents:
diff changeset
  1918
    /** Compute all the supertypes of t, indexed by type symbol (except thise in typesSkip). */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1919
    private void closure(Type t, Map<TypeSymbol,Type> typesSkip, Map<TypeSymbol,Type> typeMap) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1920
        if (!t.hasTag(CLASS)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1921
        if (typesSkip.get(t.tsym) != null) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1922
        if (typeMap.put(t.tsym, t) == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1923
            closure(types.supertype(t), typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1924
            for (Type i : types.interfaces(t))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1925
                closure(i, typesSkip, typeMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1926
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1927
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
    /** Return the first method in t2 that conflicts with a method from t1. */
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1930
    private Symbol firstDirectIncompatibility(DiagnosticPosition pos, Type t1, Type t2, Type site) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1931
        for (Symbol s1 : t1.tsym.members().getSymbols(NON_RECURSIVE)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
            Type st1 = null;
14800
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1933
            if (s1.kind != MTH || !s1.isInheritedIn(site.tsym, types) ||
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1934
                    (s1.flags() & SYNTHETIC) != 0) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
            Symbol impl = ((MethodSymbol)s1).implementation(site.tsym, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1936
            if (impl != null && (impl.flags() & ABSTRACT) == 0) continue;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1937
            for (Symbol s2 : t2.tsym.members().getSymbolsByName(s1.name)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1938
                if (s1 == s2) continue;
14800
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1939
                if (s2.kind != MTH || !s2.isInheritedIn(site.tsym, types) ||
4bed1223fdf2 8004094: Javac compiler error - synthetic method accessor generated with duplicate name
mcimadamore
parents: 14547
diff changeset
  1940
                        (s2.flags() & SYNTHETIC) != 0) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1941
                if (st1 == null) st1 = types.memberType(t1, s1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
                Type st2 = types.memberType(t2, s2);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
                if (types.overrideEquivalent(st1, st2)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1944
                    List<Type> tvars1 = st1.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1945
                    List<Type> tvars2 = st2.getTypeArguments();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1946
                    Type rt1 = st1.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
                    Type rt2 = types.subst(st2.getReturnType(), tvars2, tvars1);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
                    boolean compat =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1949
                        types.isSameType(rt1, rt2) ||
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1950
                        !rt1.isPrimitiveOrVoid() &&
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1951
                        !rt2.isPrimitiveOrVoid() &&
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  1952
                        (types.covariantReturnType(rt1, rt2, types.noWarnings) ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  1953
                         types.covariantReturnType(rt2, rt1, types.noWarnings)) ||
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1954
                         checkCommonOverriderIn(s1,s2,site);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1955
                    if (!compat) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1956
                        log.error(pos, "types.incompatible.diff.ret",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1957
                            t1, t2, s2.name +
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1958
                            "(" + types.memberType(t2, s2).getParameterTypes() + ")");
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1959
                        return s2;
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1960
                    }
8610
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  1961
                } else if (checkNameClash((ClassSymbol)site.tsym, s1, s2) &&
62e3274feecc 7020657: Javac rejects a fairly common idiom with raw override and interfaces
mcimadamore
parents: 8427
diff changeset
  1962
                        !checkCommonOverriderIn(s1, s2, site)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1963
                    log.error(pos,
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1964
                            "name.clash.same.erasure.no.override",
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1965
                            s1, s1.location(),
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1966
                            s2, s2.location());
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  1967
                    return s2;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1968
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
    }
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1973
    //WHERE
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1974
    boolean checkCommonOverriderIn(Symbol s1, Symbol s2, Type site) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  1975
        Map<TypeSymbol,Type> supertypes = new HashMap<>();
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1976
        Type st1 = types.memberType(site, s1);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1977
        Type st2 = types.memberType(site, s2);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1978
        closure(site, supertypes);
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1979
        for (Type t : supertypes.values()) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  1980
            for (Symbol s3 : t.tsym.members().getSymbolsByName(s1.name)) {
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1981
                if (s3 == s1 || s3 == s2 || s3.kind != MTH || (s3.flags() & (BRIDGE|SYNTHETIC)) != 0) continue;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1982
                Type st3 = types.memberType(site,s3);
18380
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  1983
                if (types.overrideEquivalent(st3, st1) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  1984
                        types.overrideEquivalent(st3, st2) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  1985
                        types.returnTypeSubstitutable(st3, st1) &&
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  1986
                        types.returnTypeSubstitutable(st3, st2)) {
2abcb1c3a593 8008627: Compiler mishandles three-way return-type-substitutability
mcimadamore
parents: 17805
diff changeset
  1987
                    return true;
812
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1988
                }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1989
            }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1990
        }
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1991
        return false;
d60171f70ade 6294779: Problem with interface inheritance and covariant return types
mcimadamore
parents: 661
diff changeset
  1992
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
    /** Check that a given method conforms with any method it overrides.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1995
     *  @param tree         The tree from which positions are extracted
06bc494ca11e Initial load
duke
parents:
diff changeset
  1996
     *                      for errors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1997
     *  @param m            The overriding method.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1998
     */
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  1999
    void checkOverride(Env<AttrContext> env, JCMethodDecl tree, MethodSymbol m) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2000
        ClassSymbol origin = (ClassSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2001
        if ((origin.flags() & ENUM) != 0 && names.finalize.equals(m.name))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2002
            if (m.overrides(syms.enumFinalFinalize, origin, types, false)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2003
                log.error(tree.pos(), "enum.no.finalize");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2004
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2005
            }
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2006
        for (Type t = origin.type; t.hasTag(CLASS);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2007
             t = types.supertype(t)) {
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2008
            if (t != origin.type) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2009
                checkOverride(tree, t, origin, m);
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2010
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2011
            for (Type t2 : types.interfaces(t)) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2012
                checkOverride(tree, t2, origin, m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2013
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2014
        }
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2015
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2016
        final boolean explicitOverride = m.attribute(syms.overrideType.tsym) != null;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2017
        // Check if this method must override a super method due to being annotated with @Override
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2018
        // or by virtue of being a member of a diamond inferred anonymous class. Latter case is to
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2019
        // be treated "as if as they were annotated" with @Override.
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2020
        boolean mustOverride = explicitOverride ||
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2021
                (env.info.isAnonymousDiamond && !m.isConstructor() && !m.isPrivate());
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29293
diff changeset
  2022
        if (mustOverride && !isOverrider(m)) {
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2023
            DiagnosticPosition pos = tree.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2024
            for (JCAnnotation a : tree.getModifiers().annotations) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2025
                if (a.annotationType.type.tsym == syms.overrideType.tsym) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2026
                    pos = a.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2027
                    break;
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2028
                }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2029
            }
36272
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2030
            log.error(pos,
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2031
                      explicitOverride ? Errors.MethodDoesNotOverrideSuperclass :
950bd442a822 8151018: javac should emit a clearer diagnostic when a <> inferred anonymous type's non-private methods don't override super's
sadayapalam
parents: 36153
diff changeset
  2032
                                Errors.AnonymousDiamondMethodDoesNotOverrideSuperclass(Fragments.DiamondAnonymousMethodsImplicitlyOverride));
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2033
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2034
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2035
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2036
    void checkOverride(JCTree tree, Type site, ClassSymbol origin, MethodSymbol m) {
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2037
        TypeSymbol c = site.tsym;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2038
        for (Symbol sym : c.members().getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2039
            if (m.overrides(sym, origin, types, false)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2040
                if ((sym.flags() & ABSTRACT) == 0) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2041
                    checkOverride(tree, m, (MethodSymbol)sym, origin);
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2042
                }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2043
            }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2044
        }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2045
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2046
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2047
    private Filter<Symbol> equalsHasCodeFilter = new Filter<Symbol>() {
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2048
        public boolean accepts(Symbol s) {
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2049
            return MethodSymbol.implementation_filter.accepts(s) &&
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2050
                    (s.flags() & BAD_OVERRIDE) == 0;
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2051
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2052
        }
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2053
    };
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2054
16333
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2055
    public void checkClassOverrideEqualsAndHashIfNeeded(DiagnosticPosition pos,
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2056
            ClassSymbol someClass) {
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2057
        /* At present, annotations cannot possibly have a method that is override
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2058
         * equivalent with Object.equals(Object) but in any case the condition is
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2059
         * fine for completeness.
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2060
         */
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2061
        if (someClass == (ClassSymbol)syms.objectType.tsym ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2062
            someClass.isInterface() || someClass.isEnum() ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2063
            (someClass.flags() & ANNOTATION) != 0 ||
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2064
            (someClass.flags() & ABSTRACT) != 0) return;
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2065
        //anonymous inner classes implementing interfaces need especial treatment
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2066
        if (someClass.isAnonymous()) {
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2067
            List<Type> interfaces =  types.interfaces(someClass.type);
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2068
            if (interfaces != null && !interfaces.isEmpty() &&
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2069
                interfaces.head.tsym == syms.comparatorType.tsym) return;
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2070
        }
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2071
        checkClassOverrideEqualsAndHash(pos, someClass);
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2072
    }
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2073
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2074
    private void checkClassOverrideEqualsAndHash(DiagnosticPosition pos,
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2075
            ClassSymbol someClass) {
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2076
        if (lint.isEnabled(LintCategory.OVERRIDES)) {
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2077
            MethodSymbol equalsAtObject = (MethodSymbol)syms.objectType
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2078
                    .tsym.members().findFirst(names.equals);
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2079
            MethodSymbol hashCodeAtObject = (MethodSymbol)syms.objectType
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2080
                    .tsym.members().findFirst(names.hashCode);
16320
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2081
            boolean overridesEquals = types.implementation(equalsAtObject,
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2082
                someClass, false, equalsHasCodeFilter).owner == someClass;
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2083
            boolean overridesHashCode = types.implementation(hashCodeAtObject,
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2084
                someClass, false, equalsHasCodeFilter) != hashCodeAtObject;
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2085
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2086
            if (overridesEquals && !overridesHashCode) {
92ba27b7aaf3 8008436: javac should not issue a warning for overriding equals without hasCode if hashCode has been overriden by a superclass
vromero
parents: 16316
diff changeset
  2087
                log.warning(LintCategory.OVERRIDES, pos,
16333
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16326
diff changeset
  2088
                        "override.equals.but.not.hashcode", someClass);
16301
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2089
            }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2090
        }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2091
    }
b6fd735ea78e 6563143: javac should issue a warning for overriding equals without hashCode
vromero
parents: 16292
diff changeset
  2092
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2093
    private boolean checkNameClash(ClassSymbol origin, Symbol s1, Symbol s2) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2094
        ClashFilter cf = new ClashFilter(origin.type);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2095
        return (cf.accepts(s1) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2096
                cf.accepts(s2) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2097
                types.hasSameArgs(s1.erasure(types), s2.erasure(types)));
7214
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2098
    }
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2099
26dfa4a69593 6985719: Alike methods in interfaces (Inheritance and Overriding)
mcimadamore
parents: 6721
diff changeset
  2100
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2101
    /** Check that all abstract members of given class have definitions.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2102
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2103
     *  @param c            The class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2104
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2105
    void checkAllDefined(DiagnosticPosition pos, ClassSymbol c) {
28459
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2106
        MethodSymbol undef = types.firstUnimplementedAbstract(c);
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2107
        if (undef != null) {
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2108
            MethodSymbol undef1 =
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2109
                new MethodSymbol(undef.flags(), undef.name,
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2110
                                 types.memberType(c.type, undef), undef.owner);
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2111
            log.error(pos, "does.not.override.abstract",
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 27857
diff changeset
  2112
                      c, undef1, undef1.location());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2113
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2114
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2115
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2116
    void checkNonCyclicDecl(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2117
        CycleChecker cc = new CycleChecker();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2118
        cc.scan(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2119
        if (!cc.errorFound && !cc.partialCheck) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2120
            tree.sym.flags_field |= ACYCLIC;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2121
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2122
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2123
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2124
    class CycleChecker extends TreeScanner {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2125
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2126
        List<Symbol> seenClasses = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2127
        boolean errorFound = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2128
        boolean partialCheck = false;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2129
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2130
        private void checkSymbol(DiagnosticPosition pos, Symbol sym) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2131
            if (sym != null && sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2132
                Env<AttrContext> classEnv = enter.getEnv((TypeSymbol)sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2133
                if (classEnv != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2134
                    DiagnosticSource prevSource = log.currentSource();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2135
                    try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2136
                        log.useSource(classEnv.toplevel.sourcefile);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2137
                        scan(classEnv.tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2138
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2139
                    finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2140
                        log.useSource(prevSource.getFile());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2141
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2142
                } else if (sym.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2143
                    checkClass(pos, sym, List.<JCTree>nil());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2144
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2145
            } else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2146
                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2147
                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2148
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2149
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2150
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2151
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2152
        public void visitSelect(JCFieldAccess tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2153
            super.visitSelect(tree);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2154
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2155
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2156
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2157
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2158
        public void visitIdent(JCIdent tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2159
            checkSymbol(tree.pos(), tree.sym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2160
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2161
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2162
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2163
        public void visitTypeApply(JCTypeApply tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2164
            scan(tree.clazz);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2165
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2166
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2167
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2168
        public void visitTypeArray(JCArrayTypeTree tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2169
            scan(tree.elemtype);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2170
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2171
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2172
        @Override
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2173
        public void visitClassDef(JCClassDecl tree) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2174
            List<JCTree> supertypes = List.nil();
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2175
            if (tree.getExtendsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2176
                supertypes = supertypes.prepend(tree.getExtendsClause());
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2177
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2178
            if (tree.getImplementsClause() != null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2179
                for (JCTree intf : tree.getImplementsClause()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2180
                    supertypes = supertypes.prepend(intf);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2181
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2182
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2183
            checkClass(tree.pos(), tree.sym, supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2184
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2185
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2186
        void checkClass(DiagnosticPosition pos, Symbol c, List<JCTree> supertypes) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2187
            if ((c.flags_field & ACYCLIC) != 0)
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2188
                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2189
            if (seenClasses.contains(c)) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2190
                errorFound = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2191
                noteCyclic(pos, (ClassSymbol)c);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2192
            } else if (!c.type.isErroneous()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2193
                try {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2194
                    seenClasses = seenClasses.prepend(c);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2195
                    if (c.type.hasTag(CLASS)) {
6711
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2196
                        if (supertypes.nonEmpty()) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2197
                            scan(supertypes);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2198
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2199
                        else {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2200
                            ClassType ct = (ClassType)c.type;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2201
                            if (ct.supertype_field == null ||
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2202
                                    ct.interfaces_field == null) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2203
                                //not completed yet
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2204
                                partialCheck = true;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2205
                                return;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2206
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2207
                            checkSymbol(pos, ct.supertype_field.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2208
                            for (Type intf : ct.interfaces_field) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2209
                                checkSymbol(pos, intf.tsym);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2210
                            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2211
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2212
                        if (c.owner.kind == TYP) {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2213
                            checkSymbol(pos, c.owner);
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2214
                        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2215
                    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2216
                } finally {
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2217
                    seenClasses = seenClasses.tail;
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2218
                }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2219
            }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2220
        }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2221
    }
fc9732adc790 6863465: javac doesn't detect circular subclass dependencies via qualified names
mcimadamore
parents: 6352
diff changeset
  2222
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2223
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2224
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2225
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2226
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2227
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2228
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2229
    void checkNonCyclic(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2230
        checkNonCyclicInternal(pos, t);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2231
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2232
06bc494ca11e Initial load
duke
parents:
diff changeset
  2233
06bc494ca11e Initial load
duke
parents:
diff changeset
  2234
    void checkNonCyclic(DiagnosticPosition pos, TypeVar t) {
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  2235
        checkNonCyclic1(pos, t, List.<TypeVar>nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2236
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2237
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  2238
    private void checkNonCyclic1(DiagnosticPosition pos, Type t, List<TypeVar> seen) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2239
        final TypeVar tv;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2240
        if  (t.hasTag(TYPEVAR) && (t.tsym.flags() & UNATTRIBUTED) != 0)
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 508
diff changeset
  2241
            return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2242
        if (seen.contains(t)) {
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24293
diff changeset
  2243
            tv = (TypeVar)t;
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2244
            tv.bound = types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2245
            log.error(pos, "cyclic.inheritance", t);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2246
        } else if (t.hasTag(TYPEVAR)) {
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24293
diff changeset
  2247
            tv = (TypeVar)t;
2219
03b1b17c4b2e 6804733: javac generates spourious diagnostics for ill-formed type-variable bounds
mcimadamore
parents: 1874
diff changeset
  2248
            seen = seen.prepend(tv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2249
            for (Type b : types.getBounds(tv))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2250
                checkNonCyclic1(pos, b, seen);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2251
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2252
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2253
06bc494ca11e Initial load
duke
parents:
diff changeset
  2254
    /** Check for cyclic references. Issue an error if the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2255
     *  symbol of the type referred to has a LOCKED flag set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2256
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
  2257
     *  @param pos      Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2258
     *  @param t        The type referred to.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2259
     *  @returns        True if the check completed on all attributed classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  2260
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2261
    private boolean checkNonCyclicInternal(DiagnosticPosition pos, Type t) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2262
        boolean complete = true; // was the check complete?
06bc494ca11e Initial load
duke
parents:
diff changeset
  2263
        //- System.err.println("checkNonCyclicInternal("+t+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  2264
        Symbol c = t.tsym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2265
        if ((c.flags_field & ACYCLIC) != 0) return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2266
06bc494ca11e Initial load
duke
parents:
diff changeset
  2267
        if ((c.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2268
            noteCyclic(pos, (ClassSymbol)c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2269
        } else if (!c.type.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2270
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2271
                c.flags_field |= LOCKED;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2272
                if (c.type.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2273
                    ClassType clazz = (ClassType)c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2274
                    if (clazz.interfaces_field != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2275
                        for (List<Type> l=clazz.interfaces_field; l.nonEmpty(); l=l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2276
                            complete &= checkNonCyclicInternal(pos, l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2277
                    if (clazz.supertype_field != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2278
                        Type st = clazz.supertype_field;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2279
                        if (st != null && st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2280
                            complete &= checkNonCyclicInternal(pos, st);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2281
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2282
                    if (c.owner.kind == TYP)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2283
                        complete &= checkNonCyclicInternal(pos, c.owner.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2284
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2285
            } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2286
                c.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2287
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2288
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2289
        if (complete)
30066
d74c06a92bd8 8078600: Infinite loop when compiling annotations with -XDcompletionDeps
alundblad
parents: 29959
diff changeset
  2290
            complete = ((c.flags_field & UNATTRIBUTED) == 0) && c.isCompleted();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2291
        if (complete) c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2292
        return complete;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2293
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2294
06bc494ca11e Initial load
duke
parents:
diff changeset
  2295
    /** Note that we found an inheritance cycle. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2296
    private void noteCyclic(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2297
        log.error(pos, "cyclic.inheritance", c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2298
        for (List<Type> l=types.interfaces(c.type); l.nonEmpty(); l=l.tail)
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2299
            l.head = types.createErrorType((ClassSymbol)l.head.tsym, Type.noType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2300
        Type st = types.supertype(c.type);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2301
        if (st.hasTag(CLASS))
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2302
            ((ClassType)c.type).supertype_field = types.createErrorType((ClassSymbol)st.tsym, Type.noType);
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1040
diff changeset
  2303
        c.type = types.createErrorType(c, c.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
        c.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2305
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2306
06bc494ca11e Initial load
duke
parents:
diff changeset
  2307
    /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2308
     *  method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2309
     *  @param tree         The class definition whose members are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2310
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2311
    void checkImplementations(JCClassDecl tree) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2312
        checkImplementations(tree, tree.sym, tree.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2313
    }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2314
    //where
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2315
        /** Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  2316
         *  method in `ic' conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2317
         */
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14443
diff changeset
  2318
        void checkImplementations(JCTree tree, ClassSymbol origin, ClassSymbol ic) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2319
            for (List<Type> l = types.closure(ic.type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2320
                ClassSymbol lc = (ClassSymbol)l.head.tsym;
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2321
                if ((lc.flags() & ABSTRACT) != 0) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2322
                    for (Symbol sym : lc.members().getSymbols(NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2323
                        if (sym.kind == MTH &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2324
                            (sym.flags() & (STATIC|ABSTRACT)) == ABSTRACT) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2325
                            MethodSymbol absmeth = (MethodSymbol)sym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2326
                            MethodSymbol implmeth = absmeth.implementation(origin, types, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2327
                            if (implmeth != null && implmeth != absmeth &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  2328
                                (implmeth.owner.flags() & INTERFACE) ==
06bc494ca11e Initial load
duke
parents:
diff changeset
  2329
                                (origin.flags() & INTERFACE)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2330
                                // don't check if implmeth is in a class, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
  2331
                                // origin is an interface. This case arises only
06bc494ca11e Initial load
duke
parents:
diff changeset
  2332
                                // if implmeth is declared in Object. The reason is
06bc494ca11e Initial load
duke
parents:
diff changeset
  2333
                                // that interfaces really don't inherit from
06bc494ca11e Initial load
duke
parents:
diff changeset
  2334
                                // Object it's just that the compiler represents
06bc494ca11e Initial load
duke
parents:
diff changeset
  2335
                                // things that way.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2336
                                checkOverride(tree, implmeth, absmeth, origin);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2337
                            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2338
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2339
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2340
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2341
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2342
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2343
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
    /** Check that all abstract methods implemented by a class are
06bc494ca11e Initial load
duke
parents:
diff changeset
  2345
     *  mutually compatible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2346
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2347
     *  @param c            The class whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2348
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2349
    void checkCompatibleSupertypes(DiagnosticPosition pos, Type c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2350
        List<Type> supertypes = types.interfaces(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2351
        Type supertype = types.supertype(c);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2352
        if (supertype.hasTag(CLASS) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2353
            (supertype.tsym.flags() & ABSTRACT) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2354
            supertypes = supertypes.prepend(supertype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2355
        for (List<Type> l = supertypes; l.nonEmpty(); l = l.tail) {
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2356
            if (!l.head.getTypeArguments().isEmpty() &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2357
                !checkCompatibleAbstracts(pos, l.head, l.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2358
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2359
            for (List<Type> m = supertypes; m != l; m = m.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2360
                if (!checkCompatibleAbstracts(pos, l.head, m.head, c))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2361
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2362
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2363
        checkCompatibleConcretes(pos, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2364
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2365
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2366
    void checkConflicts(DiagnosticPosition pos, Symbol sym, TypeSymbol c) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2367
        for (Type ct = c.type; ct != Type.noType ; ct = types.supertype(ct)) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2368
            for (Symbol sym2 : ct.tsym.members().getSymbolsByName(sym.name, NON_RECURSIVE)) {
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2369
                // VM allows methods and variables with differing types
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2370
                if (sym.kind == sym2.kind &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2371
                    types.isSameType(types.erasure(sym.type), types.erasure(sym2.type)) &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2372
                    sym != sym2 &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2373
                    (sym.flags() & Flags.SYNTHETIC) != (sym2.flags() & Flags.SYNTHETIC) &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2374
                    (sym.flags() & BRIDGE) == 0 && (sym2.flags() & BRIDGE) == 0) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2375
                    syntheticError(pos, (sym2.flags() & SYNTHETIC) == 0 ? sym2 : sym);
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2376
                    return;
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2377
                }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2378
            }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2379
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2380
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2381
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2382
    /** Check that all non-override equivalent methods accessible from 'site'
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2383
     *  are mutually compatible (JLS 8.4.8/9.4.1).
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2384
     *
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2385
     *  @param pos  Position to be used for error reporting.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2386
     *  @param site The class whose methods are checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2387
     *  @param sym  The method symbol to be checked.
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2388
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2389
    void checkOverrideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2390
         ClashFilter cf = new ClashFilter(site);
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2391
        //for each method m1 that is overridden (directly or indirectly)
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2392
        //by method 'sym' in 'site'...
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2393
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2394
        List<MethodSymbol> potentiallyAmbiguousList = List.nil();
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2395
        boolean overridesAny = false;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2396
        for (Symbol m1 : types.membersClosure(site, false).getSymbolsByName(sym.name, cf)) {
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2397
            if (!sym.overrides(m1, site.tsym, types, false)) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2398
                if (m1 == sym) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2399
                    continue;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2400
                }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2401
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2402
                if (!overridesAny) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2403
                    potentiallyAmbiguousList = potentiallyAmbiguousList.prepend((MethodSymbol)m1);
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2404
                }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2405
                continue;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2406
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2407
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2408
            if (m1 != sym) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2409
                overridesAny = true;
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2410
                potentiallyAmbiguousList = List.nil();
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2411
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2412
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2413
            //...check each method m2 that is a member of 'site'
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2414
            for (Symbol m2 : types.membersClosure(site, false).getSymbolsByName(sym.name, cf)) {
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2415
                if (m2 == m1) continue;
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2416
                //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2417
                //a member of 'site') and (ii) m1 has the same erasure as m2, issue an error
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2418
                if (!types.isSubSignature(sym.type, types.memberType(site, m2), allowStrictMethodClashCheck) &&
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2419
                        types.hasSameArgs(m2.erasure(types), m1.erasure(types))) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2420
                    sym.flags_field |= CLASH;
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2421
                    String key = m1 == sym ?
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2422
                            "name.clash.same.erasure.no.override" :
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2423
                            "name.clash.same.erasure.no.override.1";
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2424
                    log.error(pos,
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2425
                            key,
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2426
                            sym, sym.location(),
11868
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2427
                            m2, m2.location(),
35f55dadfe88 7142086: performance problem in Check.checkOverrideClashes(...)
mcimadamore
parents: 11314
diff changeset
  2428
                            m1, m1.location());
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2429
                    return;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2430
                }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2431
            }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2432
        }
21025
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2433
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2434
        if (!overridesAny) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2435
            for (MethodSymbol m: potentiallyAmbiguousList) {
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2436
                checkPotentiallyAmbiguousOverloads(pos, site, sym, m);
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2437
            }
9d4e765fe447 8024947: javac should issue the potentially ambiguous overload warning only where the problem appears
vromero
parents: 21018
diff changeset
  2438
        }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2439
    }
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2440
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2441
    /** Check that all static methods accessible from 'site' are
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2442
     *  mutually compatible (JLS 8.4.8).
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2443
     *
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2444
     *  @param pos  Position to be used for error reporting.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2445
     *  @param site The class whose methods are checked.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2446
     *  @param sym  The method symbol to be checked.
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2447
     */
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2448
    void checkHideClashes(DiagnosticPosition pos, Type site, MethodSymbol sym) {
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2449
        ClashFilter cf = new ClashFilter(site);
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2450
        //for each method m1 that is a member of 'site'...
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2451
        for (Symbol s : types.membersClosure(site, true).getSymbolsByName(sym.name, cf)) {
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2452
            //if (i) the signature of 'sym' is not a subsignature of m1 (seen as
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2453
            //a member of 'site') and (ii) 'sym' has the same erasure as m1, issue an error
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2454
            if (!types.isSubSignature(sym.type, types.memberType(site, s), allowStrictMethodClashCheck)) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2455
                if (types.hasSameArgs(s.erasure(types), sym.erasure(types))) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2456
                    log.error(pos,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2457
                            "name.clash.same.erasure.no.hide",
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2458
                            sym, sym.location(),
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2459
                            s, s.location());
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2460
                    return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2461
                } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2462
                    checkPotentiallyAmbiguousOverloads(pos, site, sym, (MethodSymbol)s);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2463
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2464
            }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2465
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2466
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2467
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2468
     //where
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2469
     private class ClashFilter implements Filter<Symbol> {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2470
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2471
         Type site;
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2472
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2473
         ClashFilter(Type site) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2474
             this.site = site;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2475
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2476
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2477
         boolean shouldSkip(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2478
             return (s.flags() & CLASH) != 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2479
                s.owner == site.tsym;
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2480
         }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2481
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2482
         public boolean accepts(Symbol s) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2483
             return s.kind == MTH &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2484
                     (s.flags() & SYNTHETIC) == 0 &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2485
                     !shouldSkip(s) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2486
                     s.isInheritedIn(site.tsym, types) &&
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2487
                     !s.isConstructor();
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2488
         }
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  2489
     }
7628
e7baeb97d164 6476118: compiler bug causes runtime ClassCastException for generics overloading
mcimadamore
parents: 7214
diff changeset
  2490
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2491
    void checkDefaultMethodClashes(DiagnosticPosition pos, Type site) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2492
        DefaultMethodClashFilter dcf = new DefaultMethodClashFilter(site);
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2493
        for (Symbol m : types.membersClosure(site, false).getSymbols(dcf)) {
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2494
            Assert.check(m.kind == MTH);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2495
            List<MethodSymbol> prov = types.interfaceCandidates(site, (MethodSymbol)m);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2496
            if (prov.size() > 1) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 20240
diff changeset
  2497
                ListBuffer<Symbol> abstracts = new ListBuffer<>();
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 20240
diff changeset
  2498
                ListBuffer<Symbol> defaults = new ListBuffer<>();
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2499
                for (MethodSymbol provSym : prov) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2500
                    if ((provSym.flags() & DEFAULT) != 0) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2501
                        defaults = defaults.append(provSym);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2502
                    } else if ((provSym.flags() & ABSTRACT) != 0) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2503
                        abstracts = abstracts.append(provSym);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2504
                    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2505
                    if (defaults.nonEmpty() && defaults.size() + abstracts.size() >= 2) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2506
                        //strong semantics - issue an error if two sibling interfaces
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2507
                        //have two override-equivalent defaults - or if one is abstract
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2508
                        //and the other is default
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2509
                        String errKey;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2510
                        Symbol s1 = defaults.first();
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2511
                        Symbol s2;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2512
                        if (defaults.size() > 1) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2513
                            errKey = "types.incompatible.unrelated.defaults";
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2514
                            s2 = defaults.toList().tail.head;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2515
                        } else {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2516
                            errKey = "types.incompatible.abstract.default";
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2517
                            s2 = abstracts.first();
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2518
                        }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2519
                        log.error(pos, errKey,
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2520
                                Kinds.kindName(site.tsym), site,
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2521
                                m.name, types.memberType(site, m).getParameterTypes(),
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2522
                                s1.location(), s2.location());
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2523
                        break;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2524
                    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2525
                }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2526
            }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2527
        }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2528
    }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2529
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2530
    //where
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2531
     private class DefaultMethodClashFilter implements Filter<Symbol> {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2532
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2533
         Type site;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2534
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2535
         DefaultMethodClashFilter(Type site) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2536
             this.site = site;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2537
         }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2538
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2539
         public boolean accepts(Symbol s) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2540
             return s.kind == MTH &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2541
                     (s.flags() & DEFAULT) != 0 &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2542
                     s.isInheritedIn(site.tsym, types) &&
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2543
                     !s.isConstructor();
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2544
         }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2545
     }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  2546
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2547
    /**
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2548
      * Report warnings for potentially ambiguous method declarations. Two declarations
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2549
      * are potentially ambiguous if they feature two unrelated functional interface
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2550
      * in same argument position (in which case, a call site passing an implicit
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2551
      * lambda would be ambiguous).
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2552
      */
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2553
    void checkPotentiallyAmbiguousOverloads(DiagnosticPosition pos, Type site,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2554
            MethodSymbol msym1, MethodSymbol msym2) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2555
        if (msym1 != msym2 &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2556
                allowDefaultMethods &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2557
                lint.isEnabled(LintCategory.OVERLOADS) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2558
                (msym1.flags() & POTENTIALLY_AMBIGUOUS) == 0 &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2559
                (msym2.flags() & POTENTIALLY_AMBIGUOUS) == 0) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2560
            Type mt1 = types.memberType(site, msym1);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2561
            Type mt2 = types.memberType(site, msym2);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2562
            //if both generic methods, adjust type variables
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2563
            if (mt1.hasTag(FORALL) && mt2.hasTag(FORALL) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2564
                    types.hasSameBounds((ForAll)mt1, (ForAll)mt2)) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2565
                mt2 = types.subst(mt2, ((ForAll)mt2).tvars, ((ForAll)mt1).tvars);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2566
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2567
            //expand varargs methods if needed
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2568
            int maxLength = Math.max(mt1.getParameterTypes().length(), mt2.getParameterTypes().length());
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2569
            List<Type> args1 = rs.adjustArgs(mt1.getParameterTypes(), msym1, maxLength, true);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2570
            List<Type> args2 = rs.adjustArgs(mt2.getParameterTypes(), msym2, maxLength, true);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2571
            //if arities don't match, exit
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2572
            if (args1.length() != args2.length()) return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2573
            boolean potentiallyAmbiguous = false;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2574
            while (args1.nonEmpty() && args2.nonEmpty()) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2575
                Type s = args1.head;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2576
                Type t = args2.head;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2577
                if (!types.isSubtype(t, s) && !types.isSubtype(s, t)) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2578
                    if (types.isFunctionalInterface(s) && types.isFunctionalInterface(t) &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2579
                            types.findDescriptorType(s).getParameterTypes().length() > 0 &&
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2580
                            types.findDescriptorType(s).getParameterTypes().length() ==
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2581
                            types.findDescriptorType(t).getParameterTypes().length()) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2582
                        potentiallyAmbiguous = true;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2583
                    } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2584
                        break;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2585
                    }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2586
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2587
                args1 = args1.tail;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2588
                args2 = args2.tail;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2589
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2590
            if (potentiallyAmbiguous) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2591
                //we found two incompatible functional interfaces with same arity
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2592
                //this means a call site passing an implicit lambda would be ambigiuous
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2593
                msym1.flags_field |= POTENTIALLY_AMBIGUOUS;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2594
                msym2.flags_field |= POTENTIALLY_AMBIGUOUS;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2595
                log.warning(LintCategory.OVERLOADS, pos, "potentially.ambiguous.overload",
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2596
                            msym1, msym1.location(),
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2597
                            msym2, msym2.location());
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2598
                return;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2599
            }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2600
        }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2601
    }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19660
diff changeset
  2602
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2603
    void checkElemAccessFromSerializableLambda(final JCTree tree) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2604
        if (warnOnAccessToSensitiveMembers) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2605
            Symbol sym = TreeInfo.symbol(tree);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  2606
            if (!sym.kind.matches(KindSelector.VAL_MTH)) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2607
                return;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2608
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2609
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2610
            if (sym.kind == VAR) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2611
                if ((sym.flags() & PARAMETER) != 0 ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2612
                    sym.isLocal() ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2613
                    sym.name == names._this ||
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2614
                    sym.name == names._super) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2615
                    return;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2616
                }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2617
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2618
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2619
            if (!types.isSubtype(sym.owner.type, syms.serializableType) &&
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2620
                    isEffectivelyNonPublic(sym)) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2621
                log.warning(tree.pos(),
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2622
                        "access.to.sensitive.member.from.serializable.element", sym);
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2623
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2624
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2625
    }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2626
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2627
    private boolean isEffectivelyNonPublic(Symbol sym) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2628
        if (sym.packge() == syms.rootPackage) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2629
            return false;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2630
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2631
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  2632
        while (sym.kind != PCK) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2633
            if ((sym.flags() & PUBLIC) == 0) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2634
                return true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2635
            }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2636
            sym = sym.owner;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2637
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2638
        return false;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2639
    }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 23810
diff changeset
  2640
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2641
    /** Report a conflict between a user symbol and a synthetic symbol.
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2642
     */
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2643
    private void syntheticError(DiagnosticPosition pos, Symbol sym) {
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2644
        if (!sym.type.isErroneous()) {
36153
ed5063b304be 8149600: javac, remove unused options, step 2
vromero
parents: 35810
diff changeset
  2645
            log.error(pos, "synthetic.name.conflict", sym, sym.location());
3557
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2646
        }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2647
    }
a803afefa115 6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
mcimadamore
parents: 3149
diff changeset
  2648
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2649
    /** Check that class c does not implement directly or indirectly
06bc494ca11e Initial load
duke
parents:
diff changeset
  2650
     *  the same parameterized interface with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2651
     *  @param pos          Position to be used for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2652
     *  @param type         The type whose interfaces are checked.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2653
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2654
    void checkClassBounds(DiagnosticPosition pos, Type type) {
22165
ec53c8946fc2 8030807: langtools should still build using jdk 7
vromero
parents: 22163
diff changeset
  2655
        checkClassBounds(pos, new HashMap<TypeSymbol,Type>(), type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2656
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2657
//where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2658
        /** Enter all interfaces of type `type' into the hash table `seensofar'
06bc494ca11e Initial load
duke
parents:
diff changeset
  2659
         *  with their class symbol as key and their type as value. Make
06bc494ca11e Initial load
duke
parents:
diff changeset
  2660
         *  sure no class is entered with two different types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2661
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2662
        void checkClassBounds(DiagnosticPosition pos,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2663
                              Map<TypeSymbol,Type> seensofar,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2664
                              Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2665
            if (type.isErroneous()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2666
            for (List<Type> l = types.interfaces(type); l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2667
                Type it = l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2668
                Type oldit = seensofar.put(it.tsym, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2669
                if (oldit != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2670
                    List<Type> oldparams = oldit.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2671
                    List<Type> newparams = it.allparams();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2672
                    if (!types.containsTypeEquivalent(oldparams, newparams))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2673
                        log.error(pos, "cant.inherit.diff.arg",
06bc494ca11e Initial load
duke
parents:
diff changeset
  2674
                                  it.tsym, Type.toString(oldparams),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2675
                                  Type.toString(newparams));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2676
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2677
                checkClassBounds(pos, seensofar, it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2678
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2679
            Type st = types.supertype(type);
25276
59c17f73fee3 8034147: javac crashes with a NullPointerException during bounds checking
dlsmith
parents: 24903
diff changeset
  2680
            if (st != Type.noType) checkClassBounds(pos, seensofar, st);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2681
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2682
06bc494ca11e Initial load
duke
parents:
diff changeset
  2683
    /** Enter interface into into set.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2684
     *  If it existed already, issue a "repeated interface" error.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2685
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2686
    void checkNotRepeated(DiagnosticPosition pos, Type it, Set<Type> its) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2687
        if (its.contains(it))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2688
            log.error(pos, "repeated.interface");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2689
        else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2690
            its.add(it);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2691
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2692
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2693
06bc494ca11e Initial load
duke
parents:
diff changeset
  2694
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  2695
 * Check annotations
06bc494ca11e Initial load
duke
parents:
diff changeset
  2696
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  2697
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2698
    /**
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2699
     * Recursively validate annotations values
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2700
     */
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2701
    void validateAnnotationTree(JCTree tree) {
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2702
        class AnnotationValidator extends TreeScanner {
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2703
            @Override
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2704
            public void visitAnnotation(JCAnnotation tree) {
9814
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2705
                if (!tree.type.isErroneous()) {
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2706
                    super.visitAnnotation(tree);
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2707
                    validateAnnotation(tree);
978b696e85ad 7042623: Regression: javac silently crash when attributing non-existent annotation
jjg
parents: 9812
diff changeset
  2708
                }
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2709
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2710
        }
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2711
        tree.accept(new AnnotationValidator());
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2712
    }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6151
diff changeset
  2713
13844
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2714
    /**
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2715
     *  {@literal
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2716
     *  Annotation types are restricted to primitives, String, an
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2717
     *  enum, an annotation, Class, Class<?>, Class<? extends
06bc494ca11e Initial load
duke
parents:
diff changeset
  2718
     *  Anything>, arrays of the preceding.
13844
56339cf983a3 7177970: fix issues in langtools doc comments
jjg
parents: 13689
diff changeset
  2719
     *  }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2720
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2721
    void validateAnnotationType(JCTree restype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2722
        // restype may be null if an error occurred, so don't bother validating it
06bc494ca11e Initial load
duke
parents:
diff changeset
  2723
        if (restype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2724
            validateAnnotationType(restype.pos(), restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2725
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2726
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2727
06bc494ca11e Initial load
duke
parents:
diff changeset
  2728
    void validateAnnotationType(DiagnosticPosition pos, Type type) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2729
        if (type.isPrimitive()) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2730
        if (types.isSameType(type, syms.stringType)) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2731
        if ((type.tsym.flags() & Flags.ENUM) != 0) return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2732
        if ((type.tsym.flags() & Flags.ANNOTATION) != 0) return;
24293
0d889f759fac 8033718: Inference ignores capture variable as upper bound
dlsmith
parents: 24226
diff changeset
  2733
        if (types.cvarLowerBound(type).tsym == syms.classType.tsym) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2734
        if (types.isArray(type) && !types.isArray(types.elemtype(type))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2735
            validateAnnotationType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2736
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2737
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2738
        log.error(pos, "invalid.annotation.member.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2739
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2740
06bc494ca11e Initial load
duke
parents:
diff changeset
  2741
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  2742
     * "It is also a compile-time error if any method declared in an
06bc494ca11e Initial load
duke
parents:
diff changeset
  2743
     * annotation type has a signature that is override-equivalent to
06bc494ca11e Initial load
duke
parents:
diff changeset
  2744
     * that of any public or protected method declared in class Object
06bc494ca11e Initial load
duke
parents:
diff changeset
  2745
     * or in the interface annotation.Annotation."
06bc494ca11e Initial load
duke
parents:
diff changeset
  2746
     *
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9073
diff changeset
  2747
     * @jls 9.6 Annotation Types
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2748
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2749
    void validateAnnotationMethod(DiagnosticPosition pos, MethodSymbol m) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2750
        for (Type sup = syms.annotationType; sup.hasTag(CLASS); sup = types.supertype(sup)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2751
            Scope s = sup.tsym.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2752
            for (Symbol sym : s.getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2753
                if (sym.kind == MTH &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2754
                    (sym.flags() & (PUBLIC | PROTECTED)) != 0 &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2755
                    types.overrideEquivalent(m.type, sym.type))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2756
                    log.error(pos, "intf.annotation.member.clash", sym, sup);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2757
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2758
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2759
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2760
06bc494ca11e Initial load
duke
parents:
diff changeset
  2761
    /** Check the annotations of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2762
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2763
    public void validateAnnotations(List<JCAnnotation> annotations, Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2764
        for (JCAnnotation a : annotations)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2765
            validateAnnotation(a, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2766
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2767
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2768
    /** Check the type annotations.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2769
     */
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2770
    public void validateTypeAnnotations(List<JCAnnotation> annotations, boolean isTypeParameter) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2771
        for (JCAnnotation a : annotations)
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2772
            validateTypeAnnotation(a, isTypeParameter);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2773
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2774
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2775
    /** Check an annotation of a symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2776
     */
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2777
    private void validateAnnotation(JCAnnotation a, Symbol s) {
6347
947437d52cc1 6976649: javac does not enforce required annotation elements in arrays
mcimadamore
parents: 6345
diff changeset
  2778
        validateAnnotationTree(a);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2779
06bc494ca11e Initial load
duke
parents:
diff changeset
  2780
        if (!annotationApplicable(a, s))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2781
            log.error(a.pos(), "annotation.type.not.applicable");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2782
15361
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2783
        if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2784
            if (s.kind != TYP) {
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2785
                log.error(a.pos(), "bad.functional.intf.anno");
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2786
            } else if (!s.isInterface() || (s.flags() & ANNOTATION) != 0) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  2787
                log.error(a.pos(), "bad.functional.intf.anno.1", diags.fragment("not.a.functional.intf", s));
15361
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2788
            }
01f1828683e6 8005299: Add FunctionalInterface checking to javac
mcimadamore
parents: 15360
diff changeset
  2789
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2790
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2791
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2792
    public void validateTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
25848
3bc09f4676a9 8043643: Add an crules analyzer avoiding string concatenation in messages of Assert checks.
jlahoda
parents: 25445
diff changeset
  2793
        Assert.checkNonNull(a.type);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2794
        validateAnnotationTree(a);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2795
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2796
        if (a.hasTag(TYPE_ANNOTATION) &&
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2797
                !a.annotationType.type.isErroneous() &&
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2798
                !isTypeAnnotation(a, isTypeParameter)) {
29959
61bfc66866da 8073534: Confusing / incorrect error message regarding annotations on non-declarations
alundblad
parents: 29842
diff changeset
  2799
            log.error(a.pos(), Errors.AnnotationTypeNotApplicableToType(a.type));
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21025
diff changeset
  2800
        }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2801
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2802
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2803
    /**
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2804
     * Validate the proposed container 'repeatable' on the
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2805
     * annotation type symbol 's'. Report errors at position
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2806
     * 'pos'.
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2807
     *
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2808
     * @param s The (annotation)type declaration annotated with a @Repeatable
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2809
     * @param repeatable the @Repeatable on 's'
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2810
     * @param pos where to report errors
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2811
     */
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2812
    public void validateRepeatable(TypeSymbol s, Attribute.Compound repeatable, DiagnosticPosition pos) {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2813
        Assert.check(types.isSameType(repeatable.type, syms.repeatableType));
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2814
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2815
        Type t = null;
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2816
        List<Pair<MethodSymbol,Attribute>> l = repeatable.values;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2817
        if (!l.isEmpty()) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2818
            Assert.check(l.head.fst.name == names.value);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2819
            t = ((Attribute.Class)l.head.snd).getValue();
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2820
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2821
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2822
        if (t == null) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2823
            // errors should already have been reported during Annotate
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2824
            return;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2825
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2826
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2827
        validateValue(t.tsym, s, pos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2828
        validateRetention(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2829
        validateDocumented(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2830
        validateInherited(t.tsym, s, pos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2831
        validateTarget(t.tsym, s, pos);
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2832
        validateDefault(t.tsym, pos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2833
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2834
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2835
    private void validateValue(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2836
        Symbol sym = container.members().findFirst(names.value);
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2837
        if (sym != null && sym.kind == MTH) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2838
            MethodSymbol m = (MethodSymbol) sym;
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2839
            Type ret = m.getReturnType();
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2840
            if (!(ret.hasTag(ARRAY) && types.isSameType(((ArrayType)ret).elemtype, contained.type))) {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2841
                log.error(pos, "invalid.repeatable.annotation.value.return",
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2842
                        container, ret, types.makeArrayType(contained.type));
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2843
            }
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2844
        } else {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2845
            log.error(pos, "invalid.repeatable.annotation.no.value", container);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2846
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2847
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2848
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2849
    private void validateRetention(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2850
        Attribute.RetentionPolicy containerRetention = types.getRetention(container);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2851
        Attribute.RetentionPolicy containedRetention = types.getRetention(contained);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2852
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2853
        boolean error = false;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2854
        switch (containedRetention) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2855
        case RUNTIME:
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2856
            if (containerRetention != Attribute.RetentionPolicy.RUNTIME) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2857
                error = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2858
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2859
            break;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2860
        case CLASS:
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2861
            if (containerRetention == Attribute.RetentionPolicy.SOURCE)  {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2862
                error = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2863
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2864
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2865
        if (error ) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2866
            log.error(pos, "invalid.repeatable.annotation.retention",
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2867
                      container, containerRetention,
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2868
                      contained, containedRetention);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2869
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2870
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2871
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2872
    private void validateDocumented(Symbol container, Symbol contained, DiagnosticPosition pos) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2873
        if (contained.attribute(syms.documentedType.tsym) != null) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2874
            if (container.attribute(syms.documentedType.tsym) == null) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2875
                log.error(pos, "invalid.repeatable.annotation.not.documented", container, contained);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2876
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2877
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2878
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2879
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2880
    private void validateInherited(Symbol container, Symbol contained, DiagnosticPosition pos) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2881
        if (contained.attribute(syms.inheritedType.tsym) != null) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2882
            if (container.attribute(syms.inheritedType.tsym) == null) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2883
                log.error(pos, "invalid.repeatable.annotation.not.inherited", container, contained);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2884
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2885
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2886
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2887
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2888
    private void validateTarget(TypeSymbol container, TypeSymbol contained, DiagnosticPosition pos) {
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2889
        // The set of targets the container is applicable to must be a subset
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2890
        // (with respect to annotation target semantics) of the set of targets
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2891
        // the contained is applicable to. The target sets may be implicit or
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2892
        // explicit.
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2893
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2894
        Set<Name> containerTargets;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2895
        Attribute.Array containerTarget = getAttributeTargetAttribute(container);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2896
        if (containerTarget == null) {
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2897
            containerTargets = getDefaultTargetSet();
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2898
        } else {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2899
            containerTargets = new HashSet<>();
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2900
            for (Attribute app : containerTarget.values) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2901
                if (!(app instanceof Attribute.Enum)) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2902
                    continue; // recovery
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2903
                }
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2904
                Attribute.Enum e = (Attribute.Enum)app;
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2905
                containerTargets.add(e.value.name);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2906
            }
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2907
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2908
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2909
        Set<Name> containedTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2910
        Attribute.Array containedTarget = getAttributeTargetAttribute(contained);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2911
        if (containedTarget == null) {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2912
            containedTargets = getDefaultTargetSet();
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2913
        } else {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2914
            containedTargets = new HashSet<>();
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2915
            for (Attribute app : containedTarget.values) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2916
                if (!(app instanceof Attribute.Enum)) {
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2917
                    continue; // recovery
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2918
                }
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2919
                Attribute.Enum e = (Attribute.Enum)app;
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2920
                containedTargets.add(e.value.name);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2921
            }
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2922
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2923
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2924
        if (!isTargetSubsetOf(containerTargets, containedTargets)) {
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2925
            log.error(pos, "invalid.repeatable.annotation.incompatible.target", container, contained);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2926
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2927
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2928
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2929
    /* get a set of names for the default target */
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2930
    private Set<Name> getDefaultTargetSet() {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2931
        if (defaultTargets == null) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  2932
            Set<Name> targets = new HashSet<>();
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2933
            targets.add(names.ANNOTATION_TYPE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2934
            targets.add(names.CONSTRUCTOR);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2935
            targets.add(names.FIELD);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2936
            targets.add(names.LOCAL_VARIABLE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2937
            targets.add(names.METHOD);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2938
            targets.add(names.PACKAGE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2939
            targets.add(names.PARAMETER);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2940
            targets.add(names.TYPE);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2941
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2942
            defaultTargets = java.util.Collections.unmodifiableSet(targets);
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2943
        }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2944
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2945
        return defaultTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2946
    }
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2947
    private Set<Name> defaultTargets;
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2948
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2949
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2950
    /** Checks that s is a subset of t, with respect to ElementType
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2951
     * semantics, specifically {ANNOTATION_TYPE} is a subset of {TYPE},
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2952
     * and {TYPE_USE} covers the set {ANNOTATION_TYPE, TYPE, TYPE_USE,
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2953
     * TYPE_PARAMETER}.
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2954
     */
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2955
    private boolean isTargetSubsetOf(Set<Name> s, Set<Name> t) {
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2956
        // Check that all elements in s are present in t
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2957
        for (Name n2 : s) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2958
            boolean currentElementOk = false;
16546
49a9c3f37e64 8006547: Repeating annotations: No Target on container annotation with all targets on base annotation gives compiler error
jfranck
parents: 16340
diff changeset
  2959
            for (Name n1 : t) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2960
                if (n1 == n2) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2961
                    currentElementOk = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2962
                    break;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2963
                } else if (n1 == names.TYPE && n2 == names.ANNOTATION_TYPE) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2964
                    currentElementOk = true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2965
                    break;
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2966
                } else if (n1 == names.TYPE_USE &&
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2967
                        (n2 == names.TYPE ||
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2968
                         n2 == names.ANNOTATION_TYPE ||
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2969
                         n2 == names.TYPE_PARAMETER)) {
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2970
                    currentElementOk = true;
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2971
                    break;
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2972
                }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2973
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2974
            if (!currentElementOk)
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2975
                return false;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2976
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2977
        return true;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2978
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  2979
22688
304eb013ac63 8029017: ElementType.TYPE_USE should be a logical superset of ElementType.TYPE and ANNOTATION_TYPE
jfranck
parents: 22165
diff changeset
  2980
    private void validateDefault(Symbol container, DiagnosticPosition pos) {
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2981
        // validate that all other elements of containing type has defaults
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2982
        Scope scope = container.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  2983
        for(Symbol elm : scope.getSymbols()) {
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2984
            if (elm.name != names.value &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  2985
                elm.kind == MTH &&
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2986
                ((MethodSymbol)elm).defaultValue == null) {
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2987
                log.error(pos,
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14804
diff changeset
  2988
                          "invalid.repeatable.annotation.elem.nondefault",
14054
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2989
                          container,
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2990
                          elm);
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2991
            }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2992
        }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2993
    }
7ae16dd77c90 7199925: Separate compilation breaks check that elements have a default for the containing annotation
jfranck
parents: 14047
diff changeset
  2994
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2995
    /** Is s a method symbol that overrides a method in a superclass? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2996
    boolean isOverrider(Symbol s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2997
        if (s.kind != MTH || s.isStatic())
06bc494ca11e Initial load
duke
parents:
diff changeset
  2998
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2999
        MethodSymbol m = (MethodSymbol)s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3000
        TypeSymbol owner = (TypeSymbol)m.owner;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3001
        for (Type sup : types.closure(owner.type)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3002
            if (sup == owner.type)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3003
                continue; // skip "this"
06bc494ca11e Initial load
duke
parents:
diff changeset
  3004
            Scope scope = sup.tsym.members();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3005
            for (Symbol sym : scope.getSymbolsByName(m.name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3006
                if (!sym.isStatic() && m.overrides(sym, owner, types, true))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3007
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3008
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3009
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3010
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3011
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3012
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3013
    /** Is the annotation applicable to types? */
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3014
    protected boolean isTypeAnnotation(JCAnnotation a, boolean isTypeParameter) {
30069
5686d5e44a83 8044196: Incorrect applying of repeatable annotations with incompatible target to type parameter
alundblad
parents: 30066
diff changeset
  3015
        List<Attribute> targets = typeAnnotations.annotationTargets(a.annotationType.type.tsym);
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3016
        return (targets == null) ?
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3017
                false :
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3018
                targets.stream()
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3019
                        .anyMatch(attr -> isTypeAnnotation(attr, isTypeParameter));
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3020
    }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3021
    //where
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3022
        boolean isTypeAnnotation(Attribute a, boolean isTypeParameter) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3023
            Attribute.Enum e = (Attribute.Enum)a;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3024
            return (e.value.name == names.TYPE_USE ||
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3025
                    (isTypeParameter && e.value.name == names.TYPE_PARAMETER));
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3026
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3027
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3028
    /** Is the annotation applicable to the symbol? */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3029
    boolean annotationApplicable(JCAnnotation a, Symbol s) {
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3030
        Attribute.Array arr = getAttributeTargetAttribute(a.annotationType.type.tsym);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3031
        Name[] targets;
22003
ed437c411fbd 8028699: Compiler crash during speculative attribution of annotated type
jlahoda
parents: 21896
diff changeset
  3032
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3033
        if (arr == null) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3034
            targets = defaultTargetMetaInfo(a, s);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3035
        } else {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3036
            // TODO: can we optimize this?
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3037
            targets = new Name[arr.values.length];
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3038
            for (int i=0; i<arr.values.length; ++i) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3039
                Attribute app = arr.values[i];
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3040
                if (!(app instanceof Attribute.Enum)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3041
                    return true; // recovery
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3042
                }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3043
                Attribute.Enum e = (Attribute.Enum) app;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3044
                targets[i] = e.value.name;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3045
            }
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3046
        }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3047
        for (Name target : targets) {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3048
            if (target == names.TYPE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3049
                if (s.kind == TYP)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3050
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3051
            } else if (target == names.FIELD) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3052
                if (s.kind == VAR && s.owner.kind != MTH)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3053
                    return true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3054
            } else if (target == names.METHOD) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3055
                if (s.kind == MTH && !s.isConstructor())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3056
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3057
            } else if (target == names.PARAMETER) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3058
                if (s.kind == VAR && s.owner.kind == MTH &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3059
                      (s.flags() & PARAMETER) != 0) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3060
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3061
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3062
            } else if (target == names.CONSTRUCTOR) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3063
                if (s.kind == MTH && s.isConstructor())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3064
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3065
            } else if (target == names.LOCAL_VARIABLE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3066
                if (s.kind == VAR && s.owner.kind == MTH &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3067
                      (s.flags() & PARAMETER) == 0) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3068
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3069
                }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3070
            } else if (target == names.ANNOTATION_TYPE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3071
                if (s.kind == TYP && (s.flags() & ANNOTATION) != 0) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3072
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3073
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3074
            } else if (target == names.PACKAGE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3075
                if (s.kind == PCK)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3076
                    return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3077
            } else if (target == names.TYPE_USE) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3078
                if (s.kind == TYP || s.kind == VAR ||
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3079
                        (s.kind == MTH && !s.isConstructor() &&
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3080
                                !s.type.getReturnType().hasTag(VOID)) ||
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3081
                        (s.kind == MTH && s.isConstructor())) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3082
                    return true;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3083
                }
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3084
            } else if (target == names.TYPE_PARAMETER) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3085
                if (s.kind == TYP && s.type.hasTag(TYPEVAR))
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3140
diff changeset
  3086
                    return true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3087
            } else
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3088
                return true; // Unknown ElementType. This should be an error at declaration site,
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3089
                             // assume applicable.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3090
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3091
        return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3092
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3093
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3094
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3095
    Attribute.Array getAttributeTargetAttribute(TypeSymbol s) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3096
        Attribute.Compound atTarget = s.getAnnotationTypeMetadata().getTarget();
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3097
        if (atTarget == null) return null; // ok, is applicable
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3098
        Attribute atValue = atTarget.member(names.value);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3099
        if (!(atValue instanceof Attribute.Array)) return null; // error recovery
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3100
        return (Attribute.Array) atValue;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3101
    }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13438
diff changeset
  3102
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3103
    private final Name[] dfltTargetMeta;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3104
    private Name[] defaultTargetMetaInfo(JCAnnotation a, Symbol s) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3105
        return dfltTargetMeta;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3106
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3107
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3108
    /** Check an annotation value.
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3109
     *
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3110
     * @param a The annotation tree to check
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3111
     * @return true if this annotation tree is valid, otherwise false
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3112
     */
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3113
    public boolean validateAnnotationDeferErrors(JCAnnotation a) {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3114
        boolean res = false;
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3115
        final Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3116
        try {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3117
            res = validateAnnotation(a);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3118
        } finally {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3119
            log.popDiagnosticHandler(diagHandler);
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3120
        }
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3121
        return res;
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3122
    }
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3123
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3124
    private boolean validateAnnotation(JCAnnotation a) {
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3125
        boolean isValid = true;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3126
        AnnotationTypeMetadata metadata = a.annotationType.type.tsym.getAnnotationTypeMetadata();
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3127
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3128
        // collect an inventory of the annotation elements
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3129
        Set<MethodSymbol> elements = metadata.getAnnotationElements();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3130
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3131
        // remove the ones that are assigned values
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3132
        for (JCTree arg : a.args) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3133
            if (!arg.hasTag(ASSIGN)) continue; // recovery
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3134
            JCAssign assign = (JCAssign)arg;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3135
            Symbol m = TreeInfo.symbol(assign.lhs);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3136
            if (m == null || m.type.isErroneous()) continue;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3137
            if (!elements.remove(m)) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3138
                isValid = false;
4867
7f4efc9b2f9f 6919944: incorrect position given for duplicate annotation value error
jjg
parents: 3780
diff changeset
  3139
                log.error(assign.lhs.pos(), "duplicate.annotation.member.value",
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3140
                        m.name, a.type);
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3141
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3142
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3143
06bc494ca11e Initial load
duke
parents:
diff changeset
  3144
        // all the remaining ones better have default values
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3145
        List<Name> missingDefaults = List.nil();
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3146
        Set<MethodSymbol> membersWithDefault = metadata.getAnnotationElementsWithDefault();
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3147
        for (MethodSymbol m : elements) {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3148
            if (m.type.isErroneous())
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3149
                continue;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3150
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3151
            if (!membersWithDefault.contains(m))
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3152
                missingDefaults = missingDefaults.append(m.name);
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3153
        }
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3154
        missingDefaults = missingDefaults.reverse();
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3155
        if (missingDefaults.nonEmpty()) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3156
            isValid = false;
6345
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3157
            String key = (missingDefaults.size() > 1)
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3158
                    ? "annotation.missing.default.value.1"
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3159
                    : "annotation.missing.default.value";
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3160
            log.error(a.pos(), key, a.type, missingDefaults);
7d98c298aafd 6975231: Regression test for 6881115 is failing with compiler output not matching expected output
mcimadamore
parents: 6342
diff changeset
  3161
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3162
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3163
        return isValid && validateTargetAnnotationValue(a);
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3164
    }
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3165
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3166
    /* Validate the special java.lang.annotation.Target annotation */
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3167
    boolean validateTargetAnnotationValue(JCAnnotation a) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3168
        // special case: java.lang.annotation.Target must not have
06bc494ca11e Initial load
duke
parents:
diff changeset
  3169
        // repeated values in its value member
06bc494ca11e Initial load
duke
parents:
diff changeset
  3170
        if (a.annotationType.type.tsym != syms.annotationTargetType.tsym ||
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3171
                a.args.tail == null)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3172
            return true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3173
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  3174
        boolean isValid = true;
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3175
        if (!a.args.head.hasTag(ASSIGN)) return false; // error recovery
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3176
        JCAssign assign = (JCAssign) a.args.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3177
        Symbol m = TreeInfo.symbol(assign.lhs);
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3178
        if (m.name != names.value) return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3179
        JCTree rhs = assign.rhs;
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3180
        if (!rhs.hasTag(NEWARRAY)) return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3181
        JCNewArray na = (JCNewArray) rhs;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3182
        Set<Symbol> targets = new HashSet<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3183
        for (JCTree elem : na.elems) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3184
            if (!targets.add(TreeInfo.symbol(elem))) {
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3185
                isValid = false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3186
                log.error(elem.pos(), "repeated.annotation.target");
06bc494ca11e Initial load
duke
parents:
diff changeset
  3187
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3188
        }
14804
f93a8d60b9a4 8001114: Container annotation is not checked for semantic correctness
jfranck
parents: 14800
diff changeset
  3189
        return isValid;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3190
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3191
06bc494ca11e Initial load
duke
parents:
diff changeset
  3192
    void checkDeprecatedAnnotation(DiagnosticPosition pos, Symbol s) {
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3193
        if (lint.isEnabled(LintCategory.DEP_ANN) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3194
            (s.flags() & DEPRECATED) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3195
            !syms.deprecatedType.isErroneous() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3196
            s.attribute(syms.deprecatedType.tsym) == null) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3197
            log.warning(LintCategory.DEP_ANN,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  3198
                    pos, "missing.deprecated.annotation");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3199
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3200
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3201
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3202
    void checkDeprecated(final DiagnosticPosition pos, final Symbol other, final Symbol s) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3203
        if ((s.flags() & DEPRECATED) != 0 &&
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3204
                (other.flags() & DEPRECATED) == 0 &&
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3205
                s.outermostClass() != other.outermostClass()) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3206
            deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3207
                @Override
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3208
                public void report() {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3209
                    warnDeprecated(pos, s);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3210
                }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3211
            });
11314
b612aaca08d0 7120736: refactor javac option handling
jjg
parents: 10950
diff changeset
  3212
        }
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3213
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3214
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3215
    void checkSunAPI(final DiagnosticPosition pos, final Symbol s) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3216
        if ((s.flags() & PROPRIETARY) != 0) {
35810
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
  3217
            deferredLintHandler.report(() -> {
9ee6e90d679c 8148808: javac, remove unused options, step 1
vromero
parents: 33713
diff changeset
  3218
                log.mandatoryWarning(pos, "sun.proprietary", s);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3219
            });
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3220
        }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3221
    }
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8229
diff changeset
  3222
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3223
    void checkProfile(final DiagnosticPosition pos, final Symbol s) {
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3224
        if (profile != Profile.DEFAULT && (s.flags() & NOT_IN_PROFILE) != 0) {
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3225
            log.error(pos, "not.in.profile", s, profile);
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3226
        }
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3227
    }
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14804
diff changeset
  3228
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3229
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3230
 * Check for recursive annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3231
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3232
06bc494ca11e Initial load
duke
parents:
diff changeset
  3233
    /** Check for cycles in the graph of annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3234
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3235
    void checkNonCyclicElements(JCClassDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3236
        if ((tree.sym.flags_field & ANNOTATION) == 0) return;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  3237
        Assert.check((tree.sym.flags_field & LOCKED) == 0);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3238
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3239
            tree.sym.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3240
            for (JCTree def : tree.defs) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3241
                if (!def.hasTag(METHODDEF)) continue;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3242
                JCMethodDecl meth = (JCMethodDecl)def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3243
                checkAnnotationResType(meth.pos(), meth.restype.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3244
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3245
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3246
            tree.sym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3247
            tree.sym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3248
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3249
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3250
06bc494ca11e Initial load
duke
parents:
diff changeset
  3251
    void checkNonCyclicElementsInternal(DiagnosticPosition pos, TypeSymbol tsym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3252
        if ((tsym.flags_field & ACYCLIC_ANN) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3253
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3254
        if ((tsym.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3255
            log.error(pos, "cyclic.annotation.element");
06bc494ca11e Initial load
duke
parents:
diff changeset
  3256
            return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3257
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3258
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3259
            tsym.flags_field |= LOCKED;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3260
            for (Symbol s : tsym.members().getSymbols(NON_RECURSIVE)) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 25874
diff changeset
  3261
                if (s.kind != MTH)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3262
                    continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3263
                checkAnnotationResType(pos, ((MethodSymbol)s).type.getReturnType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  3264
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3265
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3266
            tsym.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3267
            tsym.flags_field |= ACYCLIC_ANN;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3268
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3269
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3270
06bc494ca11e Initial load
duke
parents:
diff changeset
  3271
    void checkAnnotationResType(DiagnosticPosition pos, Type type) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3272
        switch (type.getTag()) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3273
        case CLASS:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3274
            if ((type.tsym.flags() & ANNOTATION) != 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3275
                checkNonCyclicElementsInternal(pos, type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3276
            break;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3277
        case ARRAY:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3278
            checkAnnotationResType(pos, types.elemtype(type));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3279
            break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3280
        default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3281
            break; // int etc
06bc494ca11e Initial load
duke
parents:
diff changeset
  3282
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3283
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3284
06bc494ca11e Initial load
duke
parents:
diff changeset
  3285
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3286
 * Check for cycles in the constructor call graph.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3287
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3288
06bc494ca11e Initial load
duke
parents:
diff changeset
  3289
    /** Check for cycles in the graph of constructors calling other
06bc494ca11e Initial load
duke
parents:
diff changeset
  3290
     *  constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3291
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3292
    void checkCyclicConstructors(JCClassDecl tree) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22003
diff changeset
  3293
        Map<Symbol,Symbol> callMap = new HashMap<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3294
06bc494ca11e Initial load
duke
parents:
diff changeset
  3295
        // enter each constructor this-call into the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  3296
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3297
            JCMethodInvocation app = TreeInfo.firstConstructorCall(l.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3298
            if (app == null) continue;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3299
            JCMethodDecl meth = (JCMethodDecl) l.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3300
            if (TreeInfo.name(app.meth) == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3301
                callMap.put(meth.sym, TreeInfo.symbol(app.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3302
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3303
                meth.sym.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3304
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3305
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3306
06bc494ca11e Initial load
duke
parents:
diff changeset
  3307
        // Check for cycles in the map
06bc494ca11e Initial load
duke
parents:
diff changeset
  3308
        Symbol[] ctors = new Symbol[0];
06bc494ca11e Initial load
duke
parents:
diff changeset
  3309
        ctors = callMap.keySet().toArray(ctors);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3310
        for (Symbol caller : ctors) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3311
            checkCyclicConstructor(tree, caller, callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3312
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3313
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3314
06bc494ca11e Initial load
duke
parents:
diff changeset
  3315
    /** Look in the map to see if the given constructor is part of a
06bc494ca11e Initial load
duke
parents:
diff changeset
  3316
     *  call cycle.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3317
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3318
    private void checkCyclicConstructor(JCClassDecl tree, Symbol ctor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3319
                                        Map<Symbol,Symbol> callMap) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3320
        if (ctor != null && (ctor.flags_field & ACYCLIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3321
            if ((ctor.flags_field & LOCKED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3322
                log.error(TreeInfo.diagnosticPositionFor(ctor, tree),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3323
                          "recursive.ctor.invocation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  3324
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3325
                ctor.flags_field |= LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3326
                checkCyclicConstructor(tree, callMap.remove(ctor), callMap);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3327
                ctor.flags_field &= ~LOCKED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3328
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3329
            ctor.flags_field |= ACYCLIC;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3330
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3331
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3332
06bc494ca11e Initial load
duke
parents:
diff changeset
  3333
/* *************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
  3334
 * Miscellaneous
06bc494ca11e Initial load
duke
parents:
diff changeset
  3335
 **************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3336
06bc494ca11e Initial load
duke
parents:
diff changeset
  3337
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  3338
     *  Check for division by integer constant zero
06bc494ca11e Initial load
duke
parents:
diff changeset
  3339
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3340
     *  @param operator      The operator for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  3341
     *  @param operand       The right hand operand for the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  3342
     */
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3343
    void checkDivZero(final DiagnosticPosition pos, Symbol operator, Type operand) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3344
        if (operand.constValue() != null
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  3345
            && operand.getTag().isSubRangeOf(LONG)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3346
            && ((Number) (operand.constValue())).longValue() == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3347
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3348
            if (opc == ByteCodes.idiv || opc == ByteCodes.imod
06bc494ca11e Initial load
duke
parents:
diff changeset
  3349
                || opc == ByteCodes.ldiv || opc == ByteCodes.lmod) {
25301
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3350
                deferredLintHandler.report(new DeferredLintHandler.LintLogger() {
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3351
                    @Override
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3352
                    public void report() {
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3353
                        warnDivZero(pos);
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3354
                    }
e5da086c7d43 6707032: Division by zero warning not suppressed properly in some cases
jlahoda
parents: 25283
diff changeset
  3355
                });
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3356
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3357
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3358
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3359
06bc494ca11e Initial load
duke
parents:
diff changeset
  3360
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
  3361
     * Check for empty statements after if
06bc494ca11e Initial load
duke
parents:
diff changeset
  3362
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3363
    void checkEmptyIf(JCIf tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3364
        if (tree.thenpart.hasTag(SKIP) && tree.elsepart == null &&
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3365
                lint.isEnabled(LintCategory.EMPTY))
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3366
            log.warning(LintCategory.EMPTY, tree.thenpart.pos(), "empty.if");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3367
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3368
06bc494ca11e Initial load
duke
parents:
diff changeset
  3369
    /** Check that symbol is unique in given scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3370
     *  @param pos           Position for error reporting.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3371
     *  @param sym           The symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3372
     *  @param s             The scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3373
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3374
    boolean checkUnique(DiagnosticPosition pos, Symbol sym, Scope s) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3375
        if (sym.type.isErroneous())
06bc494ca11e Initial load
duke
parents:
diff changeset
  3376
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3377
        if (sym.owner.name == names.any) return false;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3378
        for (Symbol byName : s.getSymbolsByName(sym.name, NON_RECURSIVE)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3379
            if (sym != byName &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3380
                    (byName.flags() & CLASH) == 0 &&
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3381
                    sym.kind == byName.kind &&
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3382
                    sym.name != names.error &&
19938
a2ac24fff52e 8013846: javac fails to reject semantically equivalent generic method declarations
emc
parents: 19930
diff changeset
  3383
                    (sym.kind != MTH ||
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3384
                     types.hasSameArgs(sym.type, byName.type) ||
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3385
                     types.hasSameArgs(types.erasure(sym.type), types.erasure(byName.type)))) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3386
                if ((sym.flags() & VARARGS) != (byName.flags() & VARARGS)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3387
                    varargsDuplicateError(pos, sym, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3388
                    return true;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3389
                } else if (sym.kind == MTH && !types.hasSameArgs(sym.type, byName.type, false)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3390
                    duplicateErasureError(pos, sym, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3391
                    sym.flags_field |= CLASH;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3392
                    return true;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3393
                } else {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3394
                    duplicateError(pos, byName);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3395
                    return false;
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3396
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3397
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3398
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3399
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3400
    }
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3401
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3402
    /** Report duplicate declaration error.
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3403
     */
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3404
    void duplicateErasureError(DiagnosticPosition pos, Symbol sym1, Symbol sym2) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3405
        if (!sym1.type.isErroneous() && !sym2.type.isErroneous()) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3406
            log.error(pos, "name.clash.same.erasure", sym1, sym2);
8228
4e6ee38974b2 6910550: javac 1.5.0_17 fails with incorrect error message
mcimadamore
parents: 8045
diff changeset
  3407
        }
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8238
diff changeset
  3408
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3409
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3410
    /**Check that types imported through the ordinary imports don't clash with types imported
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3411
     * by other (static or ordinary) imports. Note that two static imports may import two clashing
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3412
     * types without an error on the imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3413
     * @param toplevel       The toplevel tree for which the test should be performed.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3414
     */
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3415
    void checkImportsUnique(JCCompilationUnit toplevel) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3416
        WriteableScope ordinallyImportedSoFar = WriteableScope.create(toplevel.packge);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3417
        WriteableScope staticallyImportedSoFar = WriteableScope.create(toplevel.packge);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3418
        WriteableScope topLevelScope = toplevel.toplevelScope;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3419
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3420
        for (JCTree def : toplevel.defs) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3421
            if (!def.hasTag(IMPORT))
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3422
                continue;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3423
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3424
            JCImport imp = (JCImport) def;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3425
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3426
            if (imp.importScope == null)
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3427
                continue;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3428
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3429
            for (Symbol sym : imp.importScope.getSymbols(sym -> sym.kind == TYP)) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3430
                if (imp.isStatic()) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3431
                    checkUniqueImport(imp.pos(), ordinallyImportedSoFar, staticallyImportedSoFar, topLevelScope, sym, true);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3432
                    staticallyImportedSoFar.enter(sym);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3433
                } else {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3434
                    checkUniqueImport(imp.pos(), ordinallyImportedSoFar, staticallyImportedSoFar, topLevelScope, sym, false);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3435
                    ordinallyImportedSoFar.enter(sym);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3436
                }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3437
            }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3438
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3439
            imp.importScope = null;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3440
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3441
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3442
06bc494ca11e Initial load
duke
parents:
diff changeset
  3443
    /** Check that single-type import is not already imported or top-level defined,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3444
     *  but make an exception for two single-type imports which denote the same type.
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3445
     *  @param pos                     Position for error reporting.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3446
     *  @param ordinallyImportedSoFar  A Scope containing types imported so far through
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3447
     *                                 ordinary imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3448
     *  @param staticallyImportedSoFar A Scope containing types imported so far through
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3449
     *                                 static imports.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3450
     *  @param topLevelScope           The current file's top-level Scope
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3451
     *  @param sym                     The symbol.
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3452
     *  @param staticImport            Whether or not this was a static import
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3453
     */
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3454
    private boolean checkUniqueImport(DiagnosticPosition pos, Scope ordinallyImportedSoFar,
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3455
                                      Scope staticallyImportedSoFar, Scope topLevelScope,
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3456
                                      Symbol sym, boolean staticImport) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3457
        Filter<Symbol> duplicates = candidate -> candidate != sym && !candidate.type.isErroneous();
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3458
        Symbol clashing = ordinallyImportedSoFar.findFirst(sym.name, duplicates);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3459
        if (clashing == null && !staticImport) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3460
            clashing = staticallyImportedSoFar.findFirst(sym.name, duplicates);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3461
        }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3462
        if (clashing != null) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3463
            if (staticImport)
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3464
                log.error(pos, "already.defined.static.single.import", clashing);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3465
            else
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3466
                log.error(pos, "already.defined.single.import", clashing);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3467
            return false;
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3468
        }
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3469
        clashing = topLevelScope.findFirst(sym.name, duplicates);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3470
        if (clashing != null) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3471
            log.error(pos, "already.defined.this.unit", clashing);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3472
            return false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3473
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3474
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3475
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3476
06bc494ca11e Initial load
duke
parents:
diff changeset
  3477
    /** Check that a qualified name is in canonical form (for import decls).
06bc494ca11e Initial load
duke
parents:
diff changeset
  3478
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3479
    public void checkCanonical(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3480
        if (!isCanonical(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3481
            log.error(tree.pos(), "import.requires.canonical",
06bc494ca11e Initial load
duke
parents:
diff changeset
  3482
                      TreeInfo.symbol(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3483
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3484
        // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3485
        private boolean isCanonical(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10721
diff changeset
  3486
            while (tree.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3487
                JCFieldAccess s = (JCFieldAccess) tree;
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3488
                if (s.sym.owner.name != TreeInfo.symbol(s.selected).name)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3489
                    return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3490
                tree = s.selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3491
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3492
            return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3493
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3494
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3495
    /** Check that an auxiliary class is not accessed from any other file than its own.
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3496
     */
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3497
    void checkForBadAuxiliaryClassAccess(DiagnosticPosition pos, Env<AttrContext> env, ClassSymbol c) {
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3498
        if (lint.isEnabled(Lint.LintCategory.AUXILIARYCLASS) &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3499
            (c.flags() & AUXILIARY) != 0 &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3500
            rs.isAccessible(env, c) &&
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3501
            !fileManager.isSameFile(c.sourcefile, env.toplevel.sourcefile))
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3502
        {
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3503
            log.warning(pos, "auxiliary.class.accessed.from.outside.of.its.source.file",
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3504
                        c, c.sourcefile);
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3505
        }
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3506
    }
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14359
diff changeset
  3507
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3508
    private class ConversionWarner extends Warner {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3509
        final String uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3510
        final Type found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3511
        final Type expected;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3512
        public ConversionWarner(DiagnosticPosition pos, String uncheckedKey, Type found, Type expected) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3513
            super(pos);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3514
            this.uncheckedKey = uncheckedKey;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3515
            this.found = found;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3516
            this.expected = expected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3517
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3518
3780
368edd3d2082 6874249: Check has duplicate local variable and field for "source"
jjg
parents: 3765
diff changeset
  3519
        @Override
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3520
        public void warn(LintCategory lint) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3521
            boolean warned = this.warned;
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3522
            super.warn(lint);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3523
            if (warned) return; // suppress redundant diagnostics
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3524
            switch (lint) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3525
                case UNCHECKED:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3526
                    Check.this.warnUnchecked(pos(), "prob.found.req", diags.fragment(uncheckedKey), found, expected);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3527
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3528
                case VARARGS:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3529
                    if (method != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3530
                            method.attribute(syms.trustMeType.tsym) != null &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3531
                            isTrustMeAllowedOnMethod(method) &&
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3532
                            !types.isReifiable(method.type.getParameterTypes().last())) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3533
                        Check.this.warnUnsafeVararg(pos(), "varargs.unsafe.use.varargs.param", method.params.last());
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3534
                    }
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3535
                    break;
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3536
                default:
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3537
                    throw new AssertionError("Unexpected lint: " + lint);
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3538
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3539
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3540
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3541
06bc494ca11e Initial load
duke
parents:
diff changeset
  3542
    public Warner castWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3543
        return new ConversionWarner(pos, "unchecked.cast.to.type", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3544
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3545
06bc494ca11e Initial load
duke
parents:
diff changeset
  3546
    public Warner convertWarner(DiagnosticPosition pos, Type found, Type expected) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3547
        return new ConversionWarner(pos, "unchecked.assign", found, expected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3548
    }
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3549
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3550
    public void checkFunctionalInterface(JCClassDecl tree, ClassSymbol cs) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3551
        Compound functionalType = cs.attribute(syms.functionalInterfaceType.tsym);
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3552
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3553
        if (functionalType != null) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3554
            try {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3555
                types.findDescriptorSymbol((TypeSymbol)cs);
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3556
            } catch (Types.FunctionDescriptorLookupError ex) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3557
                DiagnosticPosition pos = tree.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3558
                for (JCAnnotation a : tree.getModifiers().annotations) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3559
                    if (a.annotationType.type.tsym == syms.functionalInterfaceType.tsym) {
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3560
                        pos = a.pos();
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3561
                        break;
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3562
                    }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3563
                }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3564
                log.error(pos, "bad.functional.intf.anno.1", ex.getDiagnostic());
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3565
            }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3566
        }
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  3567
    }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3568
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3569
    public void checkImportsResolvable(final JCCompilationUnit toplevel) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3570
        for (final JCImport imp : toplevel.getImports()) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3571
            if (!imp.staticImport || !imp.qualid.hasTag(SELECT))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3572
                continue;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3573
            final JCFieldAccess select = (JCFieldAccess) imp.qualid;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3574
            final Symbol origin;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3575
            if (select.name == names.asterisk || (origin = TreeInfo.symbol(select.selected)) == null || origin.kind != TYP)
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3576
                continue;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3577
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3578
            TypeSymbol site = (TypeSymbol) TreeInfo.symbol(select.selected);
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3579
            if (!checkTypeContainsImportableElement(site, site, toplevel.packge, select.name, new HashSet<Symbol>())) {
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3580
                log.error(imp.pos(), "cant.resolve.location",
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3581
                          KindName.STATIC,
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3582
                          select.name, List.<Type>nil(), List.<Type>nil(),
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3583
                          Kinds.typeKindName(TreeInfo.symbol(select.selected).type),
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27224
diff changeset
  3584
                          TreeInfo.symbol(select.selected).type);
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3585
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3586
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3587
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3588
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3589
    // Check that packages imported are in scope (JLS 7.4.3, 6.3, 6.5.3.1, 6.5.3.2)
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3590
    public void checkImportedPackagesObservable(final JCCompilationUnit toplevel) {
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3591
        OUTER: for (JCImport imp : toplevel.getImports()) {
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3592
            if (!imp.staticImport && TreeInfo.name(imp.qualid) == names.asterisk) {
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3593
                TypeSymbol tsym = ((JCFieldAccess)imp.qualid).selected.type.tsym;
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3594
                if (toplevel.modle.visiblePackages != null) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3595
                    //TODO - unclear: selects like javax.* will get resolved from the current module
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3596
                    //(as javax is not an exported package from any module). And as javax in the current
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3597
                    //module typically does not contain any classes or subpackages, we need to go through
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3598
                    //the visible packages to find a sub-package:
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3599
                    for (PackageSymbol known : toplevel.modle.visiblePackages.values()) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3600
                        if (Convert.packagePart(known.fullname) == tsym.flatName())
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3601
                            continue OUTER;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3602
                    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36272
diff changeset
  3603
                }
31299
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3604
                if (tsym.kind == PCK && tsym.members().isEmpty() && !tsym.exists()) {
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3605
                    log.error(DiagnosticFlag.RESOLVE_ERROR, imp.pos, "doesnt.exist", tsym);
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3606
                }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3607
            }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3608
        }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3609
    }
81ce5febcae8 4869999: Error on import statement naming package containing no class files
sadayapalam
parents: 31212
diff changeset
  3610
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3611
    private boolean checkTypeContainsImportableElement(TypeSymbol tsym, TypeSymbol origin, PackageSymbol packge, Name name, Set<Symbol> processed) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3612
        if (tsym == null || !processed.add(tsym))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3613
            return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3614
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3615
            // also search through inherited names
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3616
        if (checkTypeContainsImportableElement(types.supertype(tsym.type).tsym, origin, packge, name, processed))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3617
            return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3618
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3619
        for (Type t : types.interfaces(tsym.type))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3620
            if (checkTypeContainsImportableElement(t.tsym, origin, packge, name, processed))
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3621
                return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3622
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3623
        for (Symbol sym : tsym.members().getSymbolsByName(name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3624
            if (sym.isStatic() &&
29149
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3625
                importAccessible(sym, packge) &&
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3626
                sym.isMemberOf(origin, types)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3627
                return true;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3628
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3629
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3630
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3631
        return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3632
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3633
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3634
    // is the sym accessible everywhere in packge?
29149
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3635
    public boolean importAccessible(Symbol sym, PackageSymbol packge) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3636
        try {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3637
            int flags = (int)(sym.flags() & AccessFlags);
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3638
            switch (flags) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3639
            default:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3640
            case PUBLIC:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3641
                return true;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3642
            case PRIVATE:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3643
                return false;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3644
            case 0:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3645
            case PROTECTED:
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3646
                return sym.packge() == packge;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3647
            }
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3648
        } catch (ClassFinder.BadClassFile err) {
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3649
            throw err;
3fa94aad0264 8067886: Inaccessible nested classes can be incorrectly imported
jlahoda
parents: 29051
diff changeset
  3650
        } catch (CompletionFailure ex) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3651
            return false;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3652
        }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3653
    }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25301
diff changeset
  3654
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3655
}