src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
author mcimadamore
Mon, 04 Dec 2017 17:54:49 +0000
changeset 48054 702043a4cdeb
parent 47318 423f5e46016e
child 48246 aadc02050d3b
permissions -rw-r--r--
8189749: Devise strategy for making source level checks more uniform Summary: Create a 'feature' enum which is responsible for handling source version checks and related diagnostic generation Reviewed-by: jjg, jlahoda
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
44060
f420de7e26fa 8175790: field JCVariableDecl.vartype can't be null after post attribution analysis
vromero
parents: 43761
diff changeset
     2
 * Copyright (c) 1999, 2017, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    28
import java.util.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    29
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    30
import javax.lang.model.element.ElementKind;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    31
import javax.tools.JavaFileObject;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.source.tree.IdentifierTree;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
    34
import com.sun.source.tree.MemberReferenceTree.ReferenceMode;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.source.tree.MemberSelectTree;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
import com.sun.source.tree.TreeVisitor;
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
import com.sun.source.util.SimpleTreeVisitor;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    38
import com.sun.tools.javac.code.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    39
import com.sun.tools.javac.code.Lint.LintCategory;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
    40
import com.sun.tools.javac.code.Scope.WriteableScope;
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
    41
import com.sun.tools.javac.code.Source.Feature;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    42
import com.sun.tools.javac.code.Symbol.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    43
import com.sun.tools.javac.code.Type.*;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
    44
import com.sun.tools.javac.code.TypeMetadata.Annotations;
29553
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
    45
import com.sun.tools.javac.code.Types.FunctionDescriptorLookupError;
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
    46
import com.sun.tools.javac.comp.ArgumentAttr.LocalCacheContext;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    47
import com.sun.tools.javac.comp.Check.CheckContext;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    48
import com.sun.tools.javac.comp.DeferredAttr.AttrMode;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    49
import com.sun.tools.javac.jvm.*;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
    50
import static com.sun.tools.javac.resources.CompilerProperties.Fragments.Diamond;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
    51
import static com.sun.tools.javac.resources.CompilerProperties.Fragments.DiamondInvalidArg;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
    52
import static com.sun.tools.javac.resources.CompilerProperties.Fragments.DiamondInvalidArgs;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
    53
import com.sun.tools.javac.resources.CompilerProperties.Errors;
29553
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
    54
import com.sun.tools.javac.resources.CompilerProperties.Fragments;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
    55
import com.sun.tools.javac.resources.CompilerProperties.Warnings;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    56
import com.sun.tools.javac.tree.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    57
import com.sun.tools.javac.tree.JCTree.*;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
    58
import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    59
import com.sun.tools.javac.util.*;
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
    60
import com.sun.tools.javac.util.DefinedBy.Api;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    61
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
    62
import com.sun.tools.javac.util.JCDiagnostic.Fragment;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    63
import com.sun.tools.javac.util.List;
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
    64
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
import static com.sun.tools.javac.code.Flags.*;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    66
import static com.sun.tools.javac.code.Flags.ANNOTATION;
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    67
import static com.sun.tools.javac.code.Flags.BLOCK;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
import static com.sun.tools.javac.code.Kinds.*;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
    69
import static com.sun.tools.javac.code.Kinds.Kind.*;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    70
import static com.sun.tools.javac.code.TypeTag.*;
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    71
import static com.sun.tools.javac.code.TypeTag.WILDCARD;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    72
import static com.sun.tools.javac.tree.JCTree.Tag.*;
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
    73
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticFlag;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    74
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
/** This is the main context-dependent analysis phase in GJC. It
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
 *  encompasses name resolution, type checking and constant folding as
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
 *  subtasks. Some subtasks involve auxiliary classes.
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
 *  @see Check
06bc494ca11e Initial load
duke
parents:
diff changeset
    79
 *  @see Resolve
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
 *  @see ConstFold
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
 *  @see Infer
06bc494ca11e Initial load
duke
parents:
diff changeset
    82
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    83
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    84
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    86
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
public class Attr extends JCTree.Visitor {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
    89
    protected static final Context.Key<Attr> attrKey = new Context.Key<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    91
    final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
    final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
    final Symtab syms;
06bc494ca11e Initial load
duke
parents:
diff changeset
    94
    final Resolve rs;
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
    95
    final Operators operators;
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
    96
    final Infer infer;
28142
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
    97
    final Analyzer analyzer;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
    98
    final DeferredAttr deferredAttr;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
    final Check chk;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   100
    final Flow flow;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
    final MemberEnter memberEnter;
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
   102
    final TypeEnter typeEnter;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
    final TreeMaker make;
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
    final ConstFold cfolder;
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
    final Enter enter;
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
    final Target target;
06bc494ca11e Initial load
duke
parents:
diff changeset
   107
    final Types types;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 941
diff changeset
   108
    final JCDiagnostic.Factory diags;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   109
    final TypeAnnotations typeAnnotations;
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
   110
    final DeferredLintHandler deferredLintHandler;
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   111
    final TypeEnvs typeEnvs;
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   112
    final Dependencies dependencies;
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
   113
    final Annotate annotate;
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   114
    final ArgumentAttr argumentAttr;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   115
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
    public static Attr instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
        Attr instance = context.get(attrKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
   118
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   119
            instance = new Attr(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   120
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
   121
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
06bc494ca11e Initial load
duke
parents:
diff changeset
   123
    protected Attr(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   124
        context.put(attrKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   125
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   126
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   128
        syms = Symtab.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   129
        rs = Resolve.instance(context);
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
   130
        operators = Operators.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
        chk = Check.instance(context);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   132
        flow = Flow.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   133
        memberEnter = MemberEnter.instance(context);
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
   134
        typeEnter = TypeEnter.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   135
        make = TreeMaker.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   136
        enter = Enter.instance(context);
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   137
        infer = Infer.instance(context);
28142
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   138
        analyzer = Analyzer.instance(context);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   139
        deferredAttr = DeferredAttr.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   140
        cfolder = ConstFold.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   141
        target = Target.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   142
        types = Types.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 941
diff changeset
   143
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   144
        annotate = Annotate.instance(context);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   145
        typeAnnotations = TypeAnnotations.instance(context);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
   146
        deferredLintHandler = DeferredLintHandler.instance(context);
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   147
        typeEnvs = TypeEnvs.instance(context);
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   148
        dependencies = Dependencies.instance(context);
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   149
        argumentAttr = ArgumentAttr.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   152
06bc494ca11e Initial load
duke
parents:
diff changeset
   153
        Source source = Source.instance(context);
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   154
        allowStringsInSwitch = Feature.STRINGS_IN_SWITCH.allowedInSource(source);
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   155
        allowPoly = Feature.POLY.allowedInSource(source);
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   156
        allowTypeAnnos = Feature.TYPE_ANNOTATIONS.allowedInSource(source);
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   157
        allowLambda = Feature.LAMBDA.allowedInSource(source);
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   158
        allowDefaultMethods = Feature.DEFAULT_METHODS.allowedInSource(source);
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
   159
        allowStaticInterfaceMethods = Feature.STATIC_INTERFACE_METHODS.allowedInSource(source);
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   160
        sourceName = source.name;
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6710
diff changeset
   161
        useBeforeDeclarationWarning = options.isSet("useBeforeDeclarationWarning");
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   162
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   163
        statInfo = new ResultInfo(KindSelector.NIL, Type.noType);
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
   164
        varAssignmentInfo = new ResultInfo(KindSelector.ASG, Type.noType);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   165
        unknownExprInfo = new ResultInfo(KindSelector.VAL, Type.noType);
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   166
        methodAttrInfo = new MethodAttrInfo();
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   167
        unknownTypeInfo = new ResultInfo(KindSelector.TYP, Type.noType);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   168
        unknownTypeExprInfo = new ResultInfo(KindSelector.VAL_TYP, Type.noType);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   169
        recoveryInfo = new RecoveryInfo(deferredAttr.emptyDeferredAttrContext);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   170
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   171
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   172
    /** Switch: support target-typing inference
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   173
     */
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   174
    boolean allowPoly;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   175
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   176
    /** Switch: support type annotations.
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   177
     */
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   178
    boolean allowTypeAnnos;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   179
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   180
    /** Switch: support lambda expressions ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   181
     */
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   182
    boolean allowLambda;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   183
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   184
    /** Switch: support default methods ?
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   185
     */
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   186
    boolean allowDefaultMethods;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   187
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   188
    /** Switch: static interface methods enabled?
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   189
     */
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   190
    boolean allowStaticInterfaceMethods;
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   191
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   192
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   193
     * Switch: warn about use of variable before declaration?
06bc494ca11e Initial load
duke
parents:
diff changeset
   194
     * RFE: 6425594
06bc494ca11e Initial load
duke
parents:
diff changeset
   195
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   196
    boolean useBeforeDeclarationWarning;
06bc494ca11e Initial load
duke
parents:
diff changeset
   197
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3559
diff changeset
   198
    /**
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   199
     * Switch: allow strings in switch?
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   200
     */
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   201
    boolean allowStringsInSwitch;
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   202
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   203
    /**
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   204
     * Switch: name of source level; used for error reporting.
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   205
     */
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   206
    String sourceName;
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   207
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   208
    /** Check kind and type of given tree against protokind and prototype.
06bc494ca11e Initial load
duke
parents:
diff changeset
   209
     *  If check succeeds, store type in tree and return it.
06bc494ca11e Initial load
duke
parents:
diff changeset
   210
     *  If check fails, store errType in tree and return it.
06bc494ca11e Initial load
duke
parents:
diff changeset
   211
     *  No checks are performed if the prototype is a method type.
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   212
     *  It is not necessary in this case since we know that kind and type
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   213
     *  are correct.
06bc494ca11e Initial load
duke
parents:
diff changeset
   214
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   215
     *  @param tree     The tree whose kind and type is checked
28336
9a6ae3c3efb5 8066871: java.lang.VerifyError: Bad local variable type - local final String
mcimadamore
parents: 28148
diff changeset
   216
     *  @param found    The computed type of the tree
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
     *  @param ownkind  The computed kind of the tree
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   218
     *  @param resultInfo  The expected result of the tree
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   219
     */
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   220
    Type check(final JCTree tree,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   221
               final Type found,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   222
               final KindSelector ownkind,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   223
               final ResultInfo resultInfo) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   224
        InferenceContext inferenceContext = resultInfo.checkContext.inferenceContext();
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   225
        Type owntype;
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   226
        boolean shouldCheck = !found.hasTag(ERROR) &&
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   227
                !resultInfo.pt.hasTag(METHOD) &&
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   228
                !resultInfo.pt.hasTag(FORALL);
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   229
        if (shouldCheck && !ownkind.subset(resultInfo.pkind)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   230
            log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   231
                      Errors.UnexpectedType(resultInfo.pkind.kindNames(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   232
                                            ownkind.kindNames()));
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   233
            owntype = types.createErrorType(found);
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   234
        } else if (allowPoly && inferenceContext.free(found)) {
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   235
            //delay the check if there are inference variables in the found type
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   236
            //this means we are dealing with a partially inferred poly expression
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   237
            owntype = shouldCheck ? resultInfo.pt : found;
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   238
            if (resultInfo.checkMode.installPostInferenceHook()) {
35423
36c7b4ec7a8b 8148213: Regression: nested unchecked call does not trigger erasure of return type
mcimadamore
parents: 35350
diff changeset
   239
                inferenceContext.addFreeTypeListener(List.of(found),
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   240
                        instantiatedContext -> {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   241
                            ResultInfo pendingResult =
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   242
                                    resultInfo.dup(inferenceContext.asInstType(resultInfo.pt));
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   243
                            check(tree, inferenceContext.asInstType(found), ownkind, pendingResult);
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   244
                        });
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   245
            }
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   246
        } else {
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   247
            owntype = shouldCheck ?
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   248
            resultInfo.check(tree, found) :
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   249
            found;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   250
        }
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   251
        if (resultInfo.checkMode.updateTreeType()) {
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   252
            tree.type = owntype;
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
   253
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
        return owntype;
06bc494ca11e Initial load
duke
parents:
diff changeset
   255
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   256
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
    /** Is given blank final variable assignable, i.e. in a scope where it
06bc494ca11e Initial load
duke
parents:
diff changeset
   258
     *  may be assigned to even though it is final?
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
     *  @param v      The blank final variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
    boolean isAssignableAsBlankFinal(VarSymbol v, Env<AttrContext> env) {
25846
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
   263
        Symbol owner = env.info.scope.owner;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
           // owner refers to the innermost variable, method or
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
           // initializer block declaration at this point.
06bc494ca11e Initial load
duke
parents:
diff changeset
   266
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
   267
            v.owner == owner
06bc494ca11e Initial load
duke
parents:
diff changeset
   268
            ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   269
            ((owner.name == names.init ||    // i.e. we are in a constructor
06bc494ca11e Initial load
duke
parents:
diff changeset
   270
              owner.kind == VAR ||           // i.e. we are in a variable initializer
06bc494ca11e Initial load
duke
parents:
diff changeset
   271
              (owner.flags() & BLOCK) != 0)  // i.e. we are in an initializer block
06bc494ca11e Initial load
duke
parents:
diff changeset
   272
             &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
             v.owner == owner.owner
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
             &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
             ((v.flags() & STATIC) != 0) == Resolve.isStatic(env));
06bc494ca11e Initial load
duke
parents:
diff changeset
   276
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
    /** Check that variable can be assigned to.
06bc494ca11e Initial load
duke
parents:
diff changeset
   279
     *  @param pos    The current source code position.
31751
ec251536a004 8080880: some docs cleanup for langtools
avstepan
parents: 31560
diff changeset
   280
     *  @param v      The assigned variable
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   281
     *  @param base   If the variable is referred to in a Select, the part
06bc494ca11e Initial load
duke
parents:
diff changeset
   282
     *                to the left of the `.', null otherwise.
06bc494ca11e Initial load
duke
parents:
diff changeset
   283
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   284
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
    void checkAssignable(DiagnosticPosition pos, VarSymbol v, JCTree base, Env<AttrContext> env) {
36713
592302b6161b 8027999: Poorly worded error message when attempting to assign to this
alundblad
parents: 36526
diff changeset
   286
        if (v.name == names._this) {
592302b6161b 8027999: Poorly worded error message when attempting to assign to this
alundblad
parents: 36526
diff changeset
   287
            log.error(pos, Errors.CantAssignValToThis);
592302b6161b 8027999: Poorly worded error message when attempting to assign to this
alundblad
parents: 36526
diff changeset
   288
        } else if ((v.flags() & FINAL) != 0 &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
            ((v.flags() & HASINIT) != 0
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
             ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
             !((base == null ||
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
   292
               (base.hasTag(IDENT) && TreeInfo.name(base) == names._this)) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
               isAssignableAsBlankFinal(v, env)))) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   294
            if (v.isResourceVariable()) { //TWR resource
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   295
                log.error(pos, Errors.TryResourceMayNotBeAssigned(v));
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   296
            } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   297
                log.error(pos, Errors.CantAssignValToFinalVar(v));
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   298
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   299
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
    /** Does tree represent a static reference to an identifier?
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
     *  It is assumed that tree is either a SELECT or an IDENT.
06bc494ca11e Initial load
duke
parents:
diff changeset
   304
     *  We have to weed out selects from non-type names here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
     *  @param tree    The candidate tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
    boolean isStaticReference(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
   308
        if (tree.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
            Symbol lsym = TreeInfo.symbol(((JCFieldAccess) tree).selected);
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
            if (lsym == null || lsym.kind != TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   311
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
    /** Is this symbol a type?
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
    static boolean isType(Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
        return sym != null && sym.kind == TYP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
    /** The current `this' symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
    Symbol thisSym(DiagnosticPosition pos, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
        return rs.resolveSelf(pos, env, env.enclClass.sym, names._this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
    /** Attribute a parsed identifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
     * @param tree Parsed identifier name
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
     * @param topLevel The toplevel to use
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
    public Symbol attribIdent(JCTree tree, JCCompilationUnit topLevel) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
        Env<AttrContext> localEnv = enter.topLevelEnv(topLevel);
06bc494ca11e Initial load
duke
parents:
diff changeset
   336
        localEnv.enclClass = make.ClassDef(make.Modifiers(0),
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
                                           syms.errSymbol.name,
06bc494ca11e Initial load
duke
parents:
diff changeset
   338
                                           null, null, null, null);
06bc494ca11e Initial load
duke
parents:
diff changeset
   339
        localEnv.enclClass.sym = syms.errSymbol;
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   340
        return attribIdent(tree, localEnv);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   341
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   342
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   343
    /** Attribute a parsed identifier.
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   344
     * @param tree Parsed identifier name
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   345
     * @param env The env to use
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   346
     */
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   347
    public Symbol attribIdent(JCTree tree, Env<AttrContext> env) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
   348
        return tree.accept(identAttributer, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
   351
        private TreeVisitor<Symbol,Env<AttrContext>> identAttributer = new IdentAttributer();
06bc494ca11e Initial load
duke
parents:
diff changeset
   352
        private class IdentAttributer extends SimpleTreeVisitor<Symbol,Env<AttrContext>> {
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
   353
            @Override @DefinedBy(Api.COMPILER_TREE)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
            public Symbol visitMemberSelect(MemberSelectTree node, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
                Symbol site = visit(node.getExpression(), env);
43138
680d378b9d64 8169197: Improve error reporting for compiling against unexported package
jlahoda
parents: 42828
diff changeset
   356
                if (site.kind == ERR || site.kind == ABSENT_TYP || site.kind == HIDDEN)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   357
                    return site;
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
                Name name = (Name)node.getIdentifier();
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
                if (site.kind == PCK) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
                    env.toplevel.packge = (PackageSymbol)site;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   361
                    return rs.findIdentInPackage(env, (TypeSymbol)site, name,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   362
                            KindSelector.TYP_PCK);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   364
                    env.enclClass.sym = (ClassSymbol)site;
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
                    return rs.findMemberType(env, site.asType(), name, (TypeSymbol)site);
06bc494ca11e Initial load
duke
parents:
diff changeset
   366
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
   369
            @Override @DefinedBy(Api.COMPILER_TREE)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
            public Symbol visitIdentifier(IdentifierTree node, Env<AttrContext> env) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   371
                return rs.findIdent(env, (Name)node.getName(), KindSelector.TYP_PCK);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   373
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
06bc494ca11e Initial load
duke
parents:
diff changeset
   375
    public Type coerce(Type etype, Type ttype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
        return cfolder.coerce(etype, ttype);
06bc494ca11e Initial load
duke
parents:
diff changeset
   377
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   378
06bc494ca11e Initial load
duke
parents:
diff changeset
   379
    public Type attribType(JCTree node, TypeSymbol sym) {
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   380
        Env<AttrContext> env = typeEnvs.get(sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   381
        Env<AttrContext> localEnv = env.dup(node, env.info.dup());
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   382
        return attribTree(node, localEnv, unknownTypeInfo);
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   383
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   384
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   385
    public Type attribImportQualifier(JCImport tree, Env<AttrContext> env) {
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   386
        // Attribute qualifying package or class.
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   387
        JCFieldAccess s = (JCFieldAccess)tree.qualid;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   388
        return attribTree(s.selected, env,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   389
                          new ResultInfo(tree.staticImport ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   390
                                         KindSelector.TYP : KindSelector.TYP_PCK,
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   391
                       Type.noType));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   392
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
06bc494ca11e Initial load
duke
parents:
diff changeset
   394
    public Env<AttrContext> attribExprToTree(JCTree expr, Env<AttrContext> env, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   395
        breakTree = tree;
3144
202fa249dc34 6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception
mcimadamore
parents: 2723
diff changeset
   396
        JavaFileObject prev = log.useSource(env.toplevel.sourcefile);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   397
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   398
            attribExpr(expr, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   399
        } catch (BreakAttr b) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   400
            return b.env;
6587
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   401
        } catch (AssertionError ae) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   402
            if (ae.getCause() instanceof BreakAttr) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   403
                return ((BreakAttr)(ae.getCause())).env;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   404
            } else {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   405
                throw ae;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   406
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   407
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   408
            breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
            log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   411
        return env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   413
06bc494ca11e Initial load
duke
parents:
diff changeset
   414
    public Env<AttrContext> attribStatToTree(JCTree stmt, Env<AttrContext> env, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   415
        breakTree = tree;
3144
202fa249dc34 6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception
mcimadamore
parents: 2723
diff changeset
   416
        JavaFileObject prev = log.useSource(env.toplevel.sourcefile);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   417
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   418
            attribStat(stmt, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   419
        } catch (BreakAttr b) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   420
            return b.env;
6587
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   421
        } catch (AssertionError ae) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   422
            if (ae.getCause() instanceof BreakAttr) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   423
                return ((BreakAttr)(ae.getCause())).env;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   424
            } else {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   425
                throw ae;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   426
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   427
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   428
            breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   429
            log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
        return env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   432
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   433
06bc494ca11e Initial load
duke
parents:
diff changeset
   434
    private JCTree breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   435
06bc494ca11e Initial load
duke
parents:
diff changeset
   436
    private static class BreakAttr extends RuntimeException {
06bc494ca11e Initial load
duke
parents:
diff changeset
   437
        static final long serialVersionUID = -6924771130405446405L;
06bc494ca11e Initial load
duke
parents:
diff changeset
   438
        private Env<AttrContext> env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   439
        private BreakAttr(Env<AttrContext> env) {
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   440
            this.env = env;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   441
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   442
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   443
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   444
    /**
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   445
     * Mode controlling behavior of Attr.Check
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   446
     */
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   447
    enum CheckMode {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   448
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   449
        NORMAL,
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   450
44392
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   451
        /**
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   452
         * Mode signalling 'fake check' - skip tree update. A side-effect of this mode is
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   453
         * that the captured var cache in {@code InferenceContext} will be used in read-only
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   454
         * mode when performing inference checks.
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   455
         */
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   456
        NO_TREE_UPDATE {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   457
            @Override
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   458
            public boolean updateTreeType() {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   459
                return false;
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   460
            }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   461
        },
44392
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   462
        /**
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   463
         * Mode signalling that caller will manage free types in tree decorations.
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   464
         */
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
   465
        NO_INFERENCE_HOOK {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   466
            @Override
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   467
            public boolean installPostInferenceHook() {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   468
                return false;
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   469
            }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   470
        };
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   471
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   472
        public boolean updateTreeType() {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   473
            return true;
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   474
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   475
        public boolean installPostInferenceHook() {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   476
            return true;
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   477
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   478
    }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   479
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   480
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   481
    class ResultInfo {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   482
        final KindSelector pkind;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   483
        final Type pt;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   484
        final CheckContext checkContext;
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   485
        final CheckMode checkMode;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   486
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   487
        ResultInfo(KindSelector pkind, Type pt) {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   488
            this(pkind, pt, chk.basicHandler, CheckMode.NORMAL);
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   489
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   490
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   491
        ResultInfo(KindSelector pkind, Type pt, CheckMode checkMode) {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   492
            this(pkind, pt, chk.basicHandler, checkMode);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   493
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   494
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   495
        protected ResultInfo(KindSelector pkind,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   496
                             Type pt, CheckContext checkContext) {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   497
            this(pkind, pt, checkContext, CheckMode.NORMAL);
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   498
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   499
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   500
        protected ResultInfo(KindSelector pkind,
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   501
                             Type pt, CheckContext checkContext, CheckMode checkMode) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   502
            this.pkind = pkind;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   503
            this.pt = pt;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   504
            this.checkContext = checkContext;
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   505
            this.checkMode = checkMode;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   506
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   507
44571
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   508
        /**
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   509
         * Should {@link Attr#attribTree} use the {@ArgumentAttr} visitor instead of this one?
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   510
         * @param tree The tree to be type-checked.
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   511
         * @return true if {@ArgumentAttr} should be used.
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   512
         */
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   513
        protected boolean needsArgumentAttr(JCTree tree) { return false; }
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   514
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   515
        protected Type check(final DiagnosticPosition pos, final Type found) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   516
            return chk.checkType(pos, found, pt, checkContext);
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   517
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   518
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   519
        protected ResultInfo dup(Type newPt) {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   520
            return new ResultInfo(pkind, newPt, checkContext, checkMode);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   521
        }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   522
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   523
        protected ResultInfo dup(CheckContext newContext) {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   524
            return new ResultInfo(pkind, pt, newContext, checkMode);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   525
        }
21488
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   526
24401
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   527
        protected ResultInfo dup(Type newPt, CheckContext newContext) {
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   528
            return new ResultInfo(pkind, newPt, newContext, checkMode);
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   529
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   530
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   531
        protected ResultInfo dup(Type newPt, CheckContext newContext, CheckMode newMode) {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   532
            return new ResultInfo(pkind, newPt, newContext, newMode);
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   533
        }
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   534
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   535
        protected ResultInfo dup(CheckMode newMode) {
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
   536
            return new ResultInfo(pkind, pt, checkContext, newMode);
24401
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   537
        }
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   538
21488
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   539
        @Override
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   540
        public String toString() {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   541
            if (pt != null) {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   542
                return pt.toString();
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   543
            } else {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   544
                return "";
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   545
            }
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   546
        }
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   547
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   548
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   549
    class MethodAttrInfo extends ResultInfo {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   550
        public MethodAttrInfo() {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   551
            this(chk.basicHandler);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   552
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   553
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   554
        public MethodAttrInfo(CheckContext checkContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   555
            super(KindSelector.VAL, Infer.anyPoly, checkContext);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   556
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   557
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   558
        @Override
44571
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   559
        protected boolean needsArgumentAttr(JCTree tree) {
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   560
            return true;
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   561
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   562
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   563
        protected ResultInfo dup(Type newPt) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   564
            throw new IllegalStateException();
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   565
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   566
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   567
        protected ResultInfo dup(CheckContext newContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   568
            return new MethodAttrInfo(newContext);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   569
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   570
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   571
        protected ResultInfo dup(Type newPt, CheckContext newContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   572
            throw new IllegalStateException();
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   573
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   574
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   575
        protected ResultInfo dup(Type newPt, CheckContext newContext, CheckMode newMode) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   576
            throw new IllegalStateException();
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   577
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   578
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   579
        protected ResultInfo dup(CheckMode newMode) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   580
            throw new IllegalStateException();
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   581
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   582
    }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   583
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   584
    class RecoveryInfo extends ResultInfo {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   585
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   586
        public RecoveryInfo(final DeferredAttr.DeferredAttrContext deferredAttrContext) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   587
            super(KindSelector.VAL, Type.recoveryType,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   588
                  new Check.NestedCheckContext(chk.basicHandler) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   589
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   590
                public DeferredAttr.DeferredAttrContext deferredAttrContext() {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   591
                    return deferredAttrContext;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   592
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   593
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   594
                public boolean compatible(Type found, Type req, Warner warn) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   595
                    return true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   596
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   597
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   598
                public void report(DiagnosticPosition pos, JCDiagnostic details) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   599
                    chk.basicHandler.report(pos, details);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   600
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   601
            });
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   602
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   603
    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   604
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   605
    final ResultInfo statInfo;
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
   606
    final ResultInfo varAssignmentInfo;
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   607
    final ResultInfo methodAttrInfo;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   608
    final ResultInfo unknownExprInfo;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   609
    final ResultInfo unknownTypeInfo;
16975
124c8436d59c 8010923: Avoid redundant speculative attribution
mcimadamore
parents: 16972
diff changeset
   610
    final ResultInfo unknownTypeExprInfo;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   611
    final ResultInfo recoveryInfo;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   612
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   613
    Type pt() {
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   614
        return resultInfo.pt;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   615
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   616
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   617
    KindSelector pkind() {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   618
        return resultInfo.pkind;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   619
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   620
06bc494ca11e Initial load
duke
parents:
diff changeset
   621
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   622
 * Visitor methods
06bc494ca11e Initial load
duke
parents:
diff changeset
   623
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   624
06bc494ca11e Initial load
duke
parents:
diff changeset
   625
    /** Visitor argument: the current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   626
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   627
    Env<AttrContext> env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   628
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   629
    /** Visitor argument: the currently expected attribution result.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   630
     */
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   631
    ResultInfo resultInfo;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   632
06bc494ca11e Initial load
duke
parents:
diff changeset
   633
    /** Visitor result: the computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   634
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   635
    Type result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   636
06bc494ca11e Initial load
duke
parents:
diff changeset
   637
    /** Visitor method: attribute a tree, catching any completion failure
06bc494ca11e Initial load
duke
parents:
diff changeset
   638
     *  exceptions. Return the tree's type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   639
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   640
     *  @param tree    The tree to be visited.
06bc494ca11e Initial load
duke
parents:
diff changeset
   641
     *  @param env     The environment visitor argument.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   642
     *  @param resultInfo   The result info visitor argument.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   643
     */
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   644
    Type attribTree(JCTree tree, Env<AttrContext> env, ResultInfo resultInfo) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   645
        Env<AttrContext> prevEnv = this.env;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   646
        ResultInfo prevResult = this.resultInfo;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   647
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   648
            this.env = env;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   649
            this.resultInfo = resultInfo;
44571
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   650
            if (resultInfo.needsArgumentAttr(tree)) {
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   651
                result = argumentAttr.attribArg(tree, env);
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   652
            } else {
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   653
                tree.accept(this);
1140b8dad6bb 8177933: Stackoverflow during compilation, starting jdk-9+163
mcimadamore
parents: 44393
diff changeset
   654
            }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   655
            if (tree == breakTree &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   656
                    resultInfo.checkContext.deferredAttrContext().mode == AttrMode.CHECK) {
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   657
                throw new BreakAttr(copyEnv(env));
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   658
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   659
            return result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   660
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   661
            tree.type = syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   662
            return chk.completionError(tree.pos(), ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
   663
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   664
            this.env = prevEnv;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   665
            this.resultInfo = prevResult;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   667
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   668
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   669
    Env<AttrContext> copyEnv(Env<AttrContext> env) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   670
        Env<AttrContext> newEnv =
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   671
                env.dup(env.tree, env.info.dup(copyScope(env.info.scope)));
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   672
        if (newEnv.outer != null) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   673
            newEnv.outer = copyEnv(newEnv.outer);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   674
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   675
        return newEnv;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   676
    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   677
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   678
    WriteableScope copyScope(WriteableScope sc) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   679
        WriteableScope newScope = WriteableScope.create(sc.owner);
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   680
        List<Symbol> elemsList = List.nil();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   681
        for (Symbol sym : sc.getSymbols()) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   682
            elemsList = elemsList.prepend(sym);
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   683
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   684
        for (Symbol s : elemsList) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   685
            newScope.enter(s);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   686
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   687
        return newScope;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   688
    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   689
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   690
    /** Derived visitor method: attribute an expression tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   691
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   692
    public Type attribExpr(JCTree tree, Env<AttrContext> env, Type pt) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   693
        return attribTree(tree, env, new ResultInfo(KindSelector.VAL, !pt.hasTag(ERROR) ? pt : Type.noType));
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   694
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   695
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   696
    /** Derived visitor method: attribute an expression tree with
06bc494ca11e Initial load
duke
parents:
diff changeset
   697
     *  no constraints on the computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   698
     */
14541
36f9d11fc9aa 7021614: extend com.sun.source API to support parsing javadoc comments
jjg
parents: 14538
diff changeset
   699
    public Type attribExpr(JCTree tree, Env<AttrContext> env) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   700
        return attribTree(tree, env, unknownExprInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   701
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   702
06bc494ca11e Initial load
duke
parents:
diff changeset
   703
    /** Derived visitor method: attribute a type tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   704
     */
14541
36f9d11fc9aa 7021614: extend com.sun.source API to support parsing javadoc comments
jjg
parents: 14538
diff changeset
   705
    public Type attribType(JCTree tree, Env<AttrContext> env) {
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   706
        Type result = attribType(tree, env, Type.noType);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   707
        return result;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   708
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   709
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   710
    /** Derived visitor method: attribute a type tree.
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   711
     */
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   712
    Type attribType(JCTree tree, Env<AttrContext> env, Type pt) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   713
        Type result = attribTree(tree, env, new ResultInfo(KindSelector.TYP, pt));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   714
        return result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   715
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   716
06bc494ca11e Initial load
duke
parents:
diff changeset
   717
    /** Derived visitor method: attribute a statement or definition tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   718
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   719
    public Type attribStat(JCTree tree, Env<AttrContext> env) {
45605
8d019eee3515 8181911: Lambda Analyzer causes compile-time error
jlahoda
parents: 45504
diff changeset
   720
        Env<AttrContext> analyzeEnv = analyzer.copyEnvIfNeeded(tree, env);
28142
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   721
        try {
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   722
            return attribTree(tree, env, statInfo);
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   723
        } finally {
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   724
            analyzer.analyzeIfNeeded(tree, analyzeEnv);
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   725
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   726
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   727
06bc494ca11e Initial load
duke
parents:
diff changeset
   728
    /** Attribute a list of expressions, returning a list of types.
06bc494ca11e Initial load
duke
parents:
diff changeset
   729
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   730
    List<Type> attribExprs(List<JCExpression> trees, Env<AttrContext> env, Type pt) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
   731
        ListBuffer<Type> ts = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   732
        for (List<JCExpression> l = trees; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   733
            ts.append(attribExpr(l.head, env, pt));
06bc494ca11e Initial load
duke
parents:
diff changeset
   734
        return ts.toList();
06bc494ca11e Initial load
duke
parents:
diff changeset
   735
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   736
06bc494ca11e Initial load
duke
parents:
diff changeset
   737
    /** Attribute a list of statements, returning nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
   738
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   739
    <T extends JCTree> void attribStats(List<T> trees, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   740
        for (List<T> l = trees; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   741
            attribStat(l.head, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   742
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   743
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   744
    /** Attribute the arguments in a method call, returning the method kind.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   745
     */
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   746
    KindSelector attribArgs(KindSelector initialKind, List<JCExpression> trees, Env<AttrContext> env, ListBuffer<Type> argtypes) {
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   747
        KindSelector kind = initialKind;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   748
        for (JCExpression arg : trees) {
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   749
            Type argtype = chk.checkNonVoid(arg, attribTree(arg, env, allowPoly ? methodAttrInfo : unknownExprInfo));
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
   750
            if (argtype.hasTag(DEFERRED)) {
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   751
                kind = KindSelector.of(KindSelector.POLY, kind);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   752
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   753
            argtypes.append(argtype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   754
        }
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   755
        return kind;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   756
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
06bc494ca11e Initial load
duke
parents:
diff changeset
   758
    /** Attribute a type argument list, returning a list of types.
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   759
     *  Caller is responsible for calling checkRefTypes.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   760
     */
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   761
    List<Type> attribAnyTypes(List<JCExpression> trees, Env<AttrContext> env) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
   762
        ListBuffer<Type> argtypes = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   763
        for (List<JCExpression> l = trees; l.nonEmpty(); l = l.tail)
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   764
            argtypes.append(attribType(l.head, env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
        return argtypes.toList();
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   768
    /** Attribute a type argument list, returning a list of types.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   769
     *  Check that all the types are references.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   770
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   771
    List<Type> attribTypes(List<JCExpression> trees, Env<AttrContext> env) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   772
        List<Type> types = attribAnyTypes(trees, env);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   773
        return chk.checkRefTypes(trees, types);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   774
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   775
06bc494ca11e Initial load
duke
parents:
diff changeset
   776
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   777
     * Attribute type variables (of generic classes or methods).
06bc494ca11e Initial load
duke
parents:
diff changeset
   778
     * Compound types are attributed later in attribBounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   779
     * @param typarams the type variables to enter
06bc494ca11e Initial load
duke
parents:
diff changeset
   780
     * @param env      the current environment
06bc494ca11e Initial load
duke
parents:
diff changeset
   781
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   782
    void attribTypeVariables(List<JCTypeParameter> typarams, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   783
        for (JCTypeParameter tvar : typarams) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   784
            TypeVar a = (TypeVar)tvar.type;
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   785
            a.tsym.flags_field |= UNATTRIBUTED;
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   786
            a.bound = Type.noType;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   787
            if (!tvar.bounds.isEmpty()) {
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   788
                List<Type> bounds = List.of(attribType(tvar.bounds.head, env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   789
                for (JCExpression bound : tvar.bounds.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   790
                    bounds = bounds.prepend(attribType(bound, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
   791
                types.setBounds(a, bounds.reverse());
06bc494ca11e Initial load
duke
parents:
diff changeset
   792
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   793
                // if no bounds are given, assume a single bound of
06bc494ca11e Initial load
duke
parents:
diff changeset
   794
                // java.lang.Object.
06bc494ca11e Initial load
duke
parents:
diff changeset
   795
                types.setBounds(a, List.of(syms.objectType));
06bc494ca11e Initial load
duke
parents:
diff changeset
   796
            }
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   797
            a.tsym.flags_field &= ~UNATTRIBUTED;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   798
        }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   799
        for (JCTypeParameter tvar : typarams) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   800
            chk.checkNonCyclic(tvar.pos(), (TypeVar)tvar.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
   801
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   802
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   803
06bc494ca11e Initial load
duke
parents:
diff changeset
   804
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   805
     * Attribute the type references in a list of annotations.
06bc494ca11e Initial load
duke
parents:
diff changeset
   806
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   807
    void attribAnnotationTypes(List<JCAnnotation> annotations,
06bc494ca11e Initial load
duke
parents:
diff changeset
   808
                               Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   809
        for (List<JCAnnotation> al = annotations; al.nonEmpty(); al = al.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   810
            JCAnnotation a = al.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
   811
            attribType(a.annotationType, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   812
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   813
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   814
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   815
    /**
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   816
     * Attribute a "lazy constant value".
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   817
     *  @param env         The env for the const value
31751
ec251536a004 8080880: some docs cleanup for langtools
avstepan
parents: 31560
diff changeset
   818
     *  @param variable    The initializer for the const value
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   819
     *  @param type        The expected type, or null
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14258
diff changeset
   820
     *  @see VarSymbol#setLazyConstValue
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   821
     */
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   822
    public Object attribLazyConstantValue(Env<AttrContext> env,
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   823
                                      JCVariableDecl variable,
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   824
                                      Type type) {
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   825
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   826
        DiagnosticPosition prevLintPos
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   827
                = deferredLintHandler.setPos(variable.pos());
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   828
38607
eb4a0b7e67a1 8154052: Java compiler error displays line from the wrong file
sadayapalam
parents: 38538
diff changeset
   829
        final JavaFileObject prevSource = log.useSource(env.toplevel.sourcefile);
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   830
        try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   831
            Type itype = attribExpr(variable.init, env, type);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   832
            if (variable.isImplicitlyTyped()) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   833
                //fixup local variable type
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   834
                type = variable.type = variable.sym.type = chk.checkLocalVarType(variable, itype.baseType(), variable.name);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
   835
            }
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   836
            if (itype.constValue() != null) {
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   837
                return coerce(itype, type).constValue();
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   838
            } else {
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   839
                return null;
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   840
            }
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   841
        } finally {
38607
eb4a0b7e67a1 8154052: Java compiler error displays line from the wrong file
sadayapalam
parents: 38538
diff changeset
   842
            log.useSource(prevSource);
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   843
            deferredLintHandler.setPos(prevLintPos);
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   844
        }
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   845
    }
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   846
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   847
    /** Attribute type reference in an `extends' or `implements' clause.
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   848
     *  Supertypes of anonymous inner classes are usually already attributed.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   849
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   850
     *  @param tree              The tree making up the type reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
   851
     *  @param env               The environment current at the reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
   852
     *  @param classExpected     true if only a class is expected here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   853
     *  @param interfaceExpected true if only an interface is expected here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   854
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   855
    Type attribBase(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
   856
                    Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
   857
                    boolean classExpected,
06bc494ca11e Initial load
duke
parents:
diff changeset
   858
                    boolean interfaceExpected,
06bc494ca11e Initial load
duke
parents:
diff changeset
   859
                    boolean checkExtensible) {
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   860
        Type t = tree.type != null ?
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   861
            tree.type :
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   862
            attribType(tree, env);
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   863
        return checkBase(t, tree, env, classExpected, interfaceExpected, checkExtensible);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   864
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   865
    Type checkBase(Type t,
06bc494ca11e Initial load
duke
parents:
diff changeset
   866
                   JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
   867
                   Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
   868
                   boolean classExpected,
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   869
                   boolean interfaceExpected,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   870
                   boolean checkExtensible) {
33907
9ee2b1641949 8073616: Duplicate error message: cannot inherit from final (class) F
sadayapalam
parents: 33708
diff changeset
   871
        final DiagnosticPosition pos = tree.hasTag(TYPEAPPLY) ?
9ee2b1641949 8073616: Duplicate error message: cannot inherit from final (class) F
sadayapalam
parents: 33708
diff changeset
   872
                (((JCTypeApply) tree).clazz).pos() : tree.pos();
23809
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   873
        if (t.tsym.isAnonymous()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   874
            log.error(pos, Errors.CantInheritFromAnon);
23809
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   875
            return types.createErrorType(t);
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   876
        }
6582
c7a4fb5a2f86 6403465: javac should defer diagnostics until it can be determined they are persistent
jjg
parents: 6351
diff changeset
   877
        if (t.isErroneous())
c7a4fb5a2f86 6403465: javac should defer diagnostics until it can be determined they are persistent
jjg
parents: 6351
diff changeset
   878
            return t;
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   879
        if (t.hasTag(TYPEVAR) && !classExpected && !interfaceExpected) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   880
            // check that type variable is already visible
06bc494ca11e Initial load
duke
parents:
diff changeset
   881
            if (t.getUpperBound() == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   882
                log.error(pos, Errors.IllegalForwardRef);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   883
                return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   884
            }
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   885
        } else {
33907
9ee2b1641949 8073616: Duplicate error message: cannot inherit from final (class) F
sadayapalam
parents: 33708
diff changeset
   886
            t = chk.checkClassType(pos, t, checkExtensible);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   887
        }
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   888
        if (interfaceExpected && (t.tsym.flags() & INTERFACE) == 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   889
            log.error(pos, Errors.IntfExpectedHere);
21009
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   890
            // return errType is necessary since otherwise there might
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   891
            // be undetected cycles which cause attribution to loop
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   892
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   893
        } else if (checkExtensible &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   894
                   classExpected &&
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   895
                   (t.tsym.flags() & INTERFACE) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   896
            log.error(pos, Errors.NoIntfExpectedHere);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   897
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   898
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   899
        if (checkExtensible &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   900
            ((t.tsym.flags() & FINAL) != 0)) {
33907
9ee2b1641949 8073616: Duplicate error message: cannot inherit from final (class) F
sadayapalam
parents: 33708
diff changeset
   901
            log.error(pos,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   902
                      Errors.CantInheritFromFinal(t.tsym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   903
        }
33907
9ee2b1641949 8073616: Duplicate error message: cannot inherit from final (class) F
sadayapalam
parents: 33708
diff changeset
   904
        chk.checkNonCyclic(pos, t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   905
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   906
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   907
12916
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   908
    Type attribIdentAsEnumType(Env<AttrContext> env, JCIdent id) {
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   909
        Assert.check((env.enclClass.sym.flags() & ENUM) != 0);
28142
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   910
        id.type = env.info.scope.owner.enclClass().type;
32a6b1af81b1 8064365: Better support for finder capabilities in target-typing context
mcimadamore
parents: 27857
diff changeset
   911
        id.sym = env.info.scope.owner.enclClass();
12916
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   912
        return id.type;
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   913
    }
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   914
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   915
    public void visitClassDef(JCClassDecl tree) {
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   916
        Optional<ArgumentAttr.LocalCacheContext> localCacheContext =
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   917
                Optional.ofNullable(env.info.isSpeculative ?
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   918
                        argumentAttr.withLocalCacheContext() : null);
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   919
        try {
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   920
            // Local and anonymous classes have not been entered yet, so we need to
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   921
            // do it now.
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   922
            if (env.info.scope.owner.kind.matches(KindSelector.VAL_MTH)) {
22440
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   923
                enter.classEnter(tree, env);
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   924
            } else {
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   925
                // If this class declaration is part of a class level annotation,
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   926
                // as in @MyAnno(new Object() {}) class MyClass {}, enter it in
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   927
                // order to simplify later steps and allow for sensible error
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   928
                // messages.
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   929
                if (env.tree.hasTag(NEWCLASS) && TreeInfo.isInAnnotation(env, tree))
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   930
                    enter.classEnter(tree, env);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   931
            }
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   932
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   933
            ClassSymbol c = tree.sym;
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   934
            if (c == null) {
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   935
                // exit in case something drastic went wrong during enter.
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   936
                result = null;
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   937
            } else {
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   938
                // make sure class has been completed:
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   939
                c.complete();
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   940
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   941
                // If this class appears as an anonymous class
41154
ed8625a2f0f1 8166108: VerifyError passing anonymous inner class to supertype constructor
sadayapalam
parents: 40504
diff changeset
   942
                // in a superclass constructor call
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   943
                // disable implicit outer instance from being passed.
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   944
                // (This would be an illegal access to "this before super").
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   945
                if (env.info.isSelfCall &&
41154
ed8625a2f0f1 8166108: VerifyError passing anonymous inner class to supertype constructor
sadayapalam
parents: 40504
diff changeset
   946
                        env.tree.hasTag(NEWCLASS)) {
35350
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   947
                    c.flags_field |= NOOUTERTHIS;
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   948
                }
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   949
                attribClass(tree.pos(), c);
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   950
                result = tree.type = c.type;
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   951
            }
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   952
        } finally {
5ec1564e7b1f 8147546: regression when type-checking generic calls inside nested declarations occurring in method context
mcimadamore
parents: 35349
diff changeset
   953
            localCacheContext.ifPresent(LocalCacheContext::leave);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   954
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   955
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   956
06bc494ca11e Initial load
duke
parents:
diff changeset
   957
    public void visitMethodDef(JCMethodDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   958
        MethodSymbol m = tree.sym;
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
   959
        boolean isDefaultMethod = (m.flags() & DEFAULT) != 0;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   960
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
   961
        Lint lint = env.info.lint.augment(m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   962
        Lint prevLint = chk.setLint(lint);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   963
        MethodSymbol prevMethod = chk.setMethod(m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   964
        try {
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
   965
            deferredLintHandler.flush(tree.pos());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   966
            chk.checkDeprecatedAnnotation(tree.pos(), m);
06bc494ca11e Initial load
duke
parents:
diff changeset
   967
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   968
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   969
            // Create a new environment with local scope
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   970
            // for attributing the method.
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   971
            Env<AttrContext> localEnv = memberEnter.methodEnv(tree, env);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   972
            localEnv.info.lint = lint;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   973
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   974
            attribStats(tree.typarams, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   975
06bc494ca11e Initial load
duke
parents:
diff changeset
   976
            // If we override any other methods, check that we do so properly.
06bc494ca11e Initial load
duke
parents:
diff changeset
   977
            // JLS ???
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   978
            if (m.isStatic()) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   979
                chk.checkHideClashes(tree.pos(), env.enclClass.type, m);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   980
            } else {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   981
                chk.checkOverrideClashes(tree.pos(), env.enclClass.type, m);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   982
            }
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
   983
            chk.checkOverride(env, tree, m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   984
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   985
            if (isDefaultMethod && types.overridesObjectMethod(m.enclClass(), m)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
   986
                log.error(tree, Errors.DefaultOverridesObjectMember(m.name, Kinds.kindName(m.location()), m.location()));
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   987
            }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   988
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   989
            // Enter all type parameters into the local method scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   990
            for (List<JCTypeParameter> l = tree.typarams; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   991
                localEnv.info.scope.enterIfAbsent(l.head.type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   992
06bc494ca11e Initial load
duke
parents:
diff changeset
   993
            ClassSymbol owner = env.enclClass.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
   994
            if ((owner.flags() & ANNOTATION) != 0 &&
44194
c868c8c24e18 8175198: Javac incorrectly allows receiver parameters in annotation methods
vromero
parents: 44184
diff changeset
   995
                    (tree.params.nonEmpty() ||
c868c8c24e18 8175198: Javac incorrectly allows receiver parameters in annotation methods
vromero
parents: 44184
diff changeset
   996
                    tree.recvparam != null))
c868c8c24e18 8175198: Javac incorrectly allows receiver parameters in annotation methods
vromero
parents: 44184
diff changeset
   997
                log.error(tree.params.nonEmpty() ?
c868c8c24e18 8175198: Javac incorrectly allows receiver parameters in annotation methods
vromero
parents: 44184
diff changeset
   998
                        tree.params.head.pos() :
c868c8c24e18 8175198: Javac incorrectly allows receiver parameters in annotation methods
vromero
parents: 44184
diff changeset
   999
                        tree.recvparam.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1000
                        Errors.IntfAnnotationMembersCantHaveParams);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1001
06bc494ca11e Initial load
duke
parents:
diff changeset
  1002
            // Attribute all value parameters.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1003
            for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1004
                attribStat(l.head, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1005
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1006
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1007
            chk.checkVarargsMethodDecl(localEnv, tree);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5654
diff changeset
  1008
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1009
            // Check that type parameters are well-formed.
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1010
            chk.validate(tree.typarams, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1011
06bc494ca11e Initial load
duke
parents:
diff changeset
  1012
            // Check that result type is well-formed.
21896
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21890
diff changeset
  1013
            if (tree.restype != null && !tree.restype.type.hasTag(VOID))
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21890
diff changeset
  1014
                chk.validate(tree.restype, localEnv);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1015
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1016
            // Check that receiver type is well-formed.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1017
            if (tree.recvparam != null) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1018
                // Use a new environment to check the receiver parameter.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1019
                // Otherwise I get "might not have been initialized" errors.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1020
                // Is there a better way?
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1021
                Env<AttrContext> newEnv = memberEnter.methodEnv(tree, env);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1022
                attribType(tree.recvparam, newEnv);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1023
                chk.validate(tree.recvparam, newEnv);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1024
            }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1025
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1026
            // annotation method checks
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1027
            if ((owner.flags() & ANNOTATION) != 0) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1028
                // annotation method cannot have throws clause
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1029
                if (tree.thrown.nonEmpty()) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1030
                    log.error(tree.thrown.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1031
                              Errors.ThrowsNotAllowedInIntfAnnotation);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1032
                }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1033
                // annotation method cannot declare type-parameters
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1034
                if (tree.typarams.nonEmpty()) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1035
                    log.error(tree.typarams.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1036
                              Errors.IntfAnnotationMembersCantHaveTypeParams);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1037
                }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1038
                // validate annotation method's return type (could be an annotation type)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1039
                chk.validateAnnotationType(tree.restype);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1040
                // ensure that annotation method does not clash with members of Object/Annotation
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1041
                chk.validateAnnotationMethod(tree.pos(), m);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1042
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
  1043
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1044
            for (List<JCExpression> l = tree.thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1045
                chk.checkType(l.head.pos(), l.head.type, syms.throwableType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1046
06bc494ca11e Initial load
duke
parents:
diff changeset
  1047
            if (tree.body == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1048
                // Empty bodies are only allowed for
06bc494ca11e Initial load
duke
parents:
diff changeset
  1049
                // abstract, native, or interface methods, or for methods
06bc494ca11e Initial load
duke
parents:
diff changeset
  1050
                // in a retrofit signature class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1051
                if (tree.defaultValue != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1052
                    if ((owner.flags() & ANNOTATION) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1053
                        log.error(tree.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1054
                                  Errors.DefaultAllowedInIntfAnnotationMember);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1055
                }
36153
ed5063b304be 8149600: javac, remove unused options, step 2
vromero
parents: 35423
diff changeset
  1056
                if (isDefaultMethod || (tree.sym.flags() & (ABSTRACT | NATIVE)) == 0)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1057
                    log.error(tree.pos(), Errors.MissingMethBodyOrDeclAbstract);
30845
43ddd58a5a56 8080726: Redundant error message on private abstract interface method with body.
sadayapalam
parents: 30405
diff changeset
  1058
            } else if ((tree.sym.flags() & (ABSTRACT|DEFAULT|PRIVATE)) == ABSTRACT) {
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  1059
                if ((owner.flags() & INTERFACE) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1060
                    log.error(tree.body.pos(), Errors.IntfMethCantHaveBody);
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  1061
                } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1062
                    log.error(tree.pos(), Errors.AbstractMethCantHaveBody);
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  1063
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1064
            } else if ((tree.mods.flags & NATIVE) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1065
                log.error(tree.pos(), Errors.NativeMethCantHaveBody);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1066
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1067
                // Add an implicit super() call unless an explicit call to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1068
                // super(...) or this(...) is given
06bc494ca11e Initial load
duke
parents:
diff changeset
  1069
                // or we are compiling class java.lang.Object.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1070
                if (tree.name == names.init && owner.type != syms.objectType) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1071
                    JCBlock body = tree.body;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1072
                    if (body.stats.isEmpty() ||
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1073
                            !TreeInfo.isSelfCall(body.stats.head)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1074
                        body.stats = body.stats.
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
  1075
                                prepend(typeEnter.SuperCall(make.at(body.pos),
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  1076
                                        List.nil(),
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  1077
                                        List.nil(),
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1078
                                        false));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1079
                    } else if ((env.enclClass.sym.flags() & ENUM) != 0 &&
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1080
                            (tree.mods.flags & GENERATEDCONSTR) == 0 &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1081
                            TreeInfo.isSuperCall(body.stats.head)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1082
                        // enum constructors are not allowed to call super
06bc494ca11e Initial load
duke
parents:
diff changeset
  1083
                        // directly, so make sure there aren't any super calls
06bc494ca11e Initial load
duke
parents:
diff changeset
  1084
                        // in enum constructors, except in the compiler
06bc494ca11e Initial load
duke
parents:
diff changeset
  1085
                        // generated one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1086
                        log.error(tree.body.stats.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1087
                                  Errors.CallToSuperNotAllowedInEnumCtor(env.enclClass.sym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1088
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1089
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1090
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1091
                // Attribute all type annotations in the body
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  1092
                annotate.queueScanTreeAndTypeAnnotate(tree.body, localEnv, m, null);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1093
                annotate.flush();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1094
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1095
                // Attribute method body.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1096
                attribStat(tree.body, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
            }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1098
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
            localEnv.info.scope.leave();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
            result = tree.type = m.type;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1101
        } finally {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
            chk.setLint(prevLint);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  1103
            chk.setMethod(prevMethod);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1104
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1107
    public void visitVarDef(JCVariableDecl tree) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1108
        // Local variables have not been entered yet, so we need to do it now:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1109
        if (env.info.scope.owner.kind == MTH) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1110
            if (tree.sym != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1111
                // parameters have already been entered
06bc494ca11e Initial load
duke
parents:
diff changeset
  1112
                env.info.scope.enter(tree.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1113
            } else {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1114
                if (tree.isImplicitlyTyped() && (tree.getModifiers().flags & PARAMETER) == 0) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1115
                    if (tree.init == null) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1116
                        //cannot use 'var' without initializer
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1117
                        log.error(tree, Errors.CantInferLocalVarType(tree.name, Fragments.LocalMissingInit));
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1118
                        tree.vartype = make.Erroneous();
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1119
                    } else {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1120
                        Fragment msg = canInferLocalVarType(tree);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1121
                        if (msg != null) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1122
                            //cannot use 'var' with initializer which require an explicit target
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1123
                            //(e.g. lambda, method reference, array initializer).
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1124
                            log.error(tree, Errors.CantInferLocalVarType(tree.name, msg));
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1125
                            tree.vartype = make.Erroneous();
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1126
                        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1127
                    }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1128
                }
27231
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
  1129
                try {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  1130
                    annotate.blockAnnotations();
27231
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
  1131
                    memberEnter.memberEnter(tree, env);
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
  1132
                } finally {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  1133
                    annotate.unblockAnnotations();
27231
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
  1134
                }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1135
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1136
        } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1137
            if (tree.init != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1138
                // Field initializer expression need to be entered.
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  1139
                annotate.queueScanTreeAndTypeAnnotate(tree.init, env, tree.sym, tree.pos());
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1140
                annotate.flush();
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1141
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1142
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1143
06bc494ca11e Initial load
duke
parents:
diff changeset
  1144
        VarSymbol v = tree.sym;
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1145
        Lint lint = env.info.lint.augment(v);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1146
        Lint prevLint = chk.setLint(lint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1147
1538
3cbbc9424f43 6763518: Impossible to suppress raw-type warnings
mcimadamore
parents: 1534
diff changeset
  1148
        // Check that the variable's declared type is well-formed.
17584
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1149
        boolean isImplicitLambdaParameter = env.tree.hasTag(LAMBDA) &&
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1150
                ((JCLambda)env.tree).paramKind == JCLambda.ParameterKind.IMPLICIT &&
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1151
                (tree.sym.flags() & PARAMETER) != 0;
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1152
        chk.validate(tree.vartype, env, !isImplicitLambdaParameter && !tree.isImplicitlyTyped());
1538
3cbbc9424f43 6763518: Impossible to suppress raw-type warnings
mcimadamore
parents: 1534
diff changeset
  1153
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1154
        try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1155
            v.getConstValue(); // ensure compile-time constant initializer is evaluated
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1156
            deferredLintHandler.flush(tree.pos());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
            chk.checkDeprecatedAnnotation(tree.pos(), v);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1158
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
            if (tree.init != null) {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1160
                if ((v.flags_field & FINAL) == 0 ||
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1161
                    !memberEnter.needsLazyConstValue(tree.init)) {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1162
                    // Not a compile-time constant
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
                    // Attribute initializer in a new environment
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
                    // with the declared variable as owner.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
                    // Check that initializer conforms to variable's declared type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
                    Env<AttrContext> initEnv = memberEnter.initEnv(tree, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
                    initEnv.info.lint = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
                    // In order to catch self-references, we set the variable's
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
                    // declaration position to maximal possible value, effectively
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
                    // marking the variable as undefined.
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  1171
                    initEnv.info.enclVar = v;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
                    attribExpr(tree.init, initEnv, v.type);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1173
                    if (tree.isImplicitlyTyped()) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1174
                        //fixup local variable type
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1175
                        v.type = chk.checkLocalVarType(tree, tree.init.type.baseType(), tree.name);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1176
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
                }
47318
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  1178
                if (tree.isImplicitlyTyped()) {
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  1179
                    setSyntheticVariableType(tree, v.type);
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  1180
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1181
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1182
            result = tree.type = v.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1183
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1184
        finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1185
            chk.setLint(prevLint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1186
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1187
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1188
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1189
    Fragment canInferLocalVarType(JCVariableDecl tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1190
        LocalInitScanner lis = new LocalInitScanner();
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1191
        lis.scan(tree.init);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1192
        return lis.badInferenceMsg;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1193
    }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1194
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1195
    static class LocalInitScanner extends TreeScanner {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1196
        Fragment badInferenceMsg = null;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1197
        boolean needsTarget = true;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1198
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1199
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1200
        public void visitNewArray(JCNewArray tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1201
            if (tree.elemtype == null && needsTarget) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1202
                badInferenceMsg = Fragments.LocalArrayMissingTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1203
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1204
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1205
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1206
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1207
        public void visitLambda(JCLambda tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1208
            if (needsTarget) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1209
                badInferenceMsg = Fragments.LocalLambdaMissingTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1210
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1211
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1212
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1213
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1214
        public void visitTypeCast(JCTypeCast tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1215
            boolean prevNeedsTarget = needsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1216
            try {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1217
                needsTarget = false;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1218
                super.visitTypeCast(tree);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1219
            } finally {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1220
                needsTarget = prevNeedsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1221
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1222
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1223
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1224
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1225
        public void visitReference(JCMemberReference tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1226
            if (needsTarget) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1227
                badInferenceMsg = Fragments.LocalMrefMissingTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1228
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1229
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1230
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1231
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1232
        public void visitNewClass(JCNewClass tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1233
            boolean prevNeedsTarget = needsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1234
            try {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1235
                needsTarget = false;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1236
                super.visitNewClass(tree);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1237
            } finally {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1238
                needsTarget = prevNeedsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1239
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1240
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1241
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1242
        @Override
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1243
        public void visitApply(JCMethodInvocation tree) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1244
            boolean prevNeedsTarget = needsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1245
            try {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1246
                needsTarget = false;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1247
                super.visitApply(tree);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1248
            } finally {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1249
                needsTarget = prevNeedsTarget;
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1250
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1251
        }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1252
    }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1253
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
    public void visitSkip(JCSkip tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1255
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
    public void visitBlock(JCBlock tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
        if (env.info.scope.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
            // Block is a static or instance initializer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1261
            // let the owner of the environment be a freshly
06bc494ca11e Initial load
duke
parents:
diff changeset
  1262
            // created BLOCK-method.
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1263
            Symbol fakeOwner =
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1264
                new MethodSymbol(tree.flags | BLOCK |
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1265
                    env.info.scope.owner.flags() & STRICTFP, names.empty, null,
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1266
                    env.info.scope.owner);
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1267
            final Env<AttrContext> localEnv =
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1268
                env.dup(tree, env.info.dup(env.info.scope.dupUnshared(fakeOwner)));
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  1269
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
            if ((tree.flags & STATIC) != 0) localEnv.info.staticLevel++;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1271
            // Attribute all type annotations in the block
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  1272
            annotate.queueScanTreeAndTypeAnnotate(tree, localEnv, localEnv.info.scope.owner, null);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1273
            annotate.flush();
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  1274
            attribStats(tree.stats, localEnv);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1275
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1276
            {
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1277
                // Store init and clinit type annotations with the ClassSymbol
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1278
                // to allow output in Gen.normalizeDefs.
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1279
                ClassSymbol cs = (ClassSymbol)env.info.scope.owner;
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1280
                List<Attribute.TypeCompound> tas = localEnv.info.scope.owner.getRawTypeAttributes();
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1281
                if ((tree.flags & STATIC) != 0) {
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1282
                    cs.appendClassInitTypeAttributes(tas);
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1283
                } else {
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1284
                    cs.appendInitTypeAttributes(tas);
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1285
                }
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1286
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1287
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1288
            // Create a new local environment with a local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1289
            Env<AttrContext> localEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1290
                env.dup(tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1291
            try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1292
                attribStats(tree.stats, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1293
            } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1294
                localEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1295
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1296
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1297
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1298
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1299
06bc494ca11e Initial load
duke
parents:
diff changeset
  1300
    public void visitDoLoop(JCDoWhileLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1301
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1302
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1303
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1304
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1305
06bc494ca11e Initial load
duke
parents:
diff changeset
  1306
    public void visitWhileLoop(JCWhileLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1307
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1308
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1309
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1310
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1311
06bc494ca11e Initial load
duke
parents:
diff changeset
  1312
    public void visitForLoop(JCForLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1313
        Env<AttrContext> loopEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1314
            env.dup(env.tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1315
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1316
            attribStats(tree.init, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1317
            if (tree.cond != null) attribExpr(tree.cond, loopEnv, syms.booleanType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1318
            loopEnv.tree = tree; // before, we were not in loop!
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1319
            attribStats(tree.step, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1320
            attribStat(tree.body, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1321
            result = null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1322
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1323
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1324
            loopEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1325
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
06bc494ca11e Initial load
duke
parents:
diff changeset
  1328
    public void visitForeachLoop(JCEnhancedForLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1329
        Env<AttrContext> loopEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1330
            env.dup(env.tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1331
        try {
18379
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1332
            //the Formal Parameter of a for-each loop is not in the scope when
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1333
            //attributing the for-each expression; we mimick this by attributing
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1334
            //the for-each expression first (against original scope).
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24609
diff changeset
  1335
            Type exprType = types.cvarUpperBound(attribExpr(tree.expr, loopEnv));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1336
            chk.checkNonVoid(tree.pos(), exprType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1337
            Type elemtype = types.elemtype(exprType); // perhaps expr is an array?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1338
            if (elemtype == null) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1339
                // or perhaps expr implements Iterable<T>?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1340
                Type base = types.asSuper(exprType, syms.iterableType.tsym);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1341
                if (base == null) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1342
                    log.error(tree.expr.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1343
                              Errors.ForeachNotApplicableToType(exprType,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1344
                                                                Fragments.TypeReqArrayOrIterable));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1345
                    elemtype = types.createErrorType(exprType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1346
                } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1347
                    List<Type> iterableParams = base.allparams();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1348
                    elemtype = iterableParams.isEmpty()
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1349
                        ? syms.objectType
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24609
diff changeset
  1350
                        : types.wildUpperBound(iterableParams.head);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1351
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
            }
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1353
            if (tree.var.isImplicitlyTyped()) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1354
                Type inferredType = chk.checkLocalVarType(tree.var, elemtype, tree.var.name);
47318
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  1355
                setSyntheticVariableType(tree.var, inferredType);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1356
            }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  1357
            attribStat(tree.var, loopEnv);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1358
            chk.checkType(tree.expr.pos(), elemtype, tree.var.sym.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1359
            loopEnv.tree = tree; // before, we were not in loop!
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1360
            attribStat(tree.body, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1361
            result = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1362
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1363
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1364
            loopEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1365
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1366
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1367
06bc494ca11e Initial load
duke
parents:
diff changeset
  1368
    public void visitLabelled(JCLabeledStatement tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1369
        // Check that label is not used in an enclosing statement
06bc494ca11e Initial load
duke
parents:
diff changeset
  1370
        Env<AttrContext> env1 = env;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1371
        while (env1 != null && !env1.tree.hasTag(CLASSDEF)) {
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1372
            if (env1.tree.hasTag(LABELLED) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1373
                ((JCLabeledStatement) env1.tree).label == tree.label) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1374
                log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1375
                          Errors.LabelAlreadyInUse(tree.label));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1376
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1377
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1378
            env1 = env1.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1380
06bc494ca11e Initial load
duke
parents:
diff changeset
  1381
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1382
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1383
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1384
06bc494ca11e Initial load
duke
parents:
diff changeset
  1385
    public void visitSwitch(JCSwitch tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1386
        Type seltype = attribExpr(tree.selector, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1387
06bc494ca11e Initial load
duke
parents:
diff changeset
  1388
        Env<AttrContext> switchEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1389
            env.dup(tree, env.info.dup(env.info.scope.dup()));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1390
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1391
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1392
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1393
            boolean enumSwitch = (seltype.tsym.flags() & Flags.ENUM) != 0;
40504
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
  1394
            boolean stringSwitch = types.isSameType(seltype, syms.stringType);
0a01f6710c84 8078561: Error message should be generated once when -source 6 is specified
jlahoda
parents: 40313
diff changeset
  1395
            if (stringSwitch && !allowStringsInSwitch) {
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
  1396
                log.error(DiagnosticFlag.SOURCE_LEVEL, tree.selector.pos(), Feature.STRINGS_IN_SWITCH.error(sourceName));
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
  1397
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1398
            if (!enumSwitch && !stringSwitch)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1399
                seltype = chk.checkType(tree.selector.pos(), seltype, syms.intType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1400
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1401
            // Attribute all cases and
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1402
            // check that there are no duplicate case labels or default clauses.
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  1403
            Set<Object> labels = new HashSet<>(); // The set of case labels.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1404
            boolean hasDefault = false;      // Is there a default label?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1405
            for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1406
                JCCase c = l.head;
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1407
                if (c.pat != null) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1408
                    if (enumSwitch) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1409
                        Symbol sym = enumConstant(c.pat, seltype);
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1410
                        if (sym == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1411
                            log.error(c.pat.pos(), Errors.EnumLabelMustBeUnqualifiedEnum);
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1412
                        } else if (!labels.add(sym)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1413
                            log.error(c.pos(), Errors.DuplicateCaseLabel);
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1414
                        }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1415
                    } else {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1416
                        Type pattype = attribExpr(c.pat, switchEnv, seltype);
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1417
                        if (!pattype.hasTag(ERROR)) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1418
                            if (pattype.constValue() == null) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1419
                                log.error(c.pat.pos(),
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1420
                                          (stringSwitch ? "string.const.req" : "const.expr.req"));
29430
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1421
                            } else if (!labels.add(pattype.constValue())) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1422
                                log.error(c.pos(), Errors.DuplicateCaseLabel);
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1423
                            }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1424
                        }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1425
                    }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1426
                } else if (hasDefault) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1427
                    log.error(c.pos(), Errors.DuplicateDefaultLabel);
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1428
                } else {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1429
                    hasDefault = true;
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1430
                }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1431
                Env<AttrContext> caseEnv =
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1432
                    switchEnv.dup(c, env.info.dup(switchEnv.info.scope.dup()));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1433
                try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1434
                    attribStats(c.stats, caseEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1435
                } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1436
                    caseEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1437
                    addVars(c.stats, switchEnv.info.scope);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1438
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1439
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1440
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1441
            result = null;
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
  1442
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1443
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1444
            switchEnv.info.scope.leave();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1445
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1446
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1447
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1448
        /** Add any variables defined in stats to the switch scope. */
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1449
        private static void addVars(List<JCStatement> stats, WriteableScope switchScope) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1450
            for (;stats.nonEmpty(); stats = stats.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1451
                JCTree stat = stats.head;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1452
                if (stat.hasTag(VARDEF))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1453
                    switchScope.enter(((JCVariableDecl) stat).sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1454
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1455
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1456
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1457
    /** Return the selected enumeration constant symbol, or null. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1458
    private Symbol enumConstant(JCTree tree, Type enumType) {
29430
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1459
        if (tree.hasTag(IDENT)) {
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1460
            JCIdent ident = (JCIdent)tree;
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1461
            Name name = ident.name;
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1462
            for (Symbol sym : enumType.tsym.members().getSymbolsByName(name)) {
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1463
                if (sym.kind == VAR) {
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1464
                    Symbol s = ident.sym = sym;
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1465
                    ((VarSymbol)s).getConstValue(); // ensure initializer is evaluated
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1466
                    ident.type = s.type;
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1467
                    return ((s.flags_field & Flags.ENUM) == 0)
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1468
                        ? null : s;
0fc887a8c519 8050021: Improper "duplicate case label" error
sadayapalam
parents: 29292
diff changeset
  1469
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1473
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
    public void visitSynchronized(JCSynchronized tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
        chk.checkRefType(tree.pos(), attribExpr(tree.lock, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
        attribStat(tree.body, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1479
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
06bc494ca11e Initial load
duke
parents:
diff changeset
  1481
    public void visitTry(JCTry tree) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1482
        // Create a new local environment with a local
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1483
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1484
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1485
            boolean isTryWithResource = tree.resources.nonEmpty();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1486
            // Create a nested environment for attributing the try block if needed
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1487
            Env<AttrContext> tryEnv = isTryWithResource ?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1488
                env.dup(tree, localEnv.info.dup(localEnv.info.scope.dup())) :
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1489
                localEnv;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1490
            try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1491
                // Attribute resource declarations
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1492
                for (JCTree resource : tree.resources) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1493
                    CheckContext twrContext = new Check.NestedCheckContext(resultInfo.checkContext) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1494
                        @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1495
                        public void report(DiagnosticPosition pos, JCDiagnostic details) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1496
                            chk.basicHandler.report(pos, diags.fragment(Fragments.TryNotApplicableToType(details)));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1497
                        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1498
                    };
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1499
                    ResultInfo twrResult =
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  1500
                        new ResultInfo(KindSelector.VAR,
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1501
                                       syms.autoCloseableType,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1502
                                       twrContext);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1503
                    if (resource.hasTag(VARDEF)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1504
                        attribStat(resource, tryEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1505
                        twrResult.check(resource, resource.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1506
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1507
                        //check that resource type cannot throw InterruptedException
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1508
                        checkAutoCloseable(resource.pos(), localEnv, resource.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1509
17557
9c6ace1881fe 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees
jlahoda
parents: 16975
diff changeset
  1510
                        VarSymbol var = ((JCVariableDecl) resource).sym;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1511
                        var.setData(ElementKind.RESOURCE_VARIABLE);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1512
                    } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1513
                        attribTree(resource, tryEnv, twrResult);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1514
                    }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
  1515
                }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1516
                // Attribute body
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1517
                attribStat(tree.body, tryEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1518
            } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1519
                if (isTryWithResource)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1520
                    tryEnv.info.scope.leave();
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1521
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1522
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1523
            // Attribute catch clauses
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1524
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1525
                JCCatch c = l.head;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1526
                Env<AttrContext> catchEnv =
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1527
                    localEnv.dup(c, localEnv.info.dup(localEnv.info.scope.dup()));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1528
                try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1529
                    Type ctype = attribStat(c.param, catchEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1530
                    if (TreeInfo.isMultiCatch(c)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1531
                        //multi-catch parameter is implicitly marked as final
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1532
                        c.param.sym.flags_field |= FINAL | UNION;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1533
                    }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1534
                    if (c.param.sym.kind == VAR) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1535
                        c.param.sym.setData(ElementKind.EXCEPTION_PARAMETER);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1536
                    }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1537
                    chk.checkType(c.param.vartype.pos(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1538
                                  chk.checkClassType(c.param.vartype.pos(), ctype),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1539
                                  syms.throwableType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1540
                    attribStat(c.body, catchEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1541
                } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1542
                    catchEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1543
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1544
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1545
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1546
            // Attribute finalizer
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1547
            if (tree.finalizer != null) attribStat(tree.finalizer, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1548
            result = null;
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1549
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1550
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1551
            localEnv.info.scope.leave();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1555
    void checkAutoCloseable(DiagnosticPosition pos, Env<AttrContext> env, Type resource) {
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1556
        if (!resource.isErroneous() &&
12013
fdcc73079b81 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself
darcy
parents: 11144
diff changeset
  1557
            types.asSuper(resource, syms.autoCloseableType.tsym) != null &&
fdcc73079b81 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself
darcy
parents: 11144
diff changeset
  1558
            !types.isSameType(resource, syms.autoCloseableType)) { // Don't emit warning for AutoCloseable itself
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1559
            Symbol close = syms.noSymbol;
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14443
diff changeset
  1560
            Log.DiagnosticHandler discardHandler = new Log.DiscardDiagnosticHandler(log);
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1561
            try {
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1562
                close = rs.resolveQualifiedMethod(pos,
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1563
                        env,
41156
251471aec877 8163027: AssertionError while compiling a program that uses try with resources.
sadayapalam
parents: 41154
diff changeset
  1564
                        types.skipTypeVars(resource, false),
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1565
                        names.close,
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  1566
                        List.nil(),
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  1567
                        List.nil());
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1568
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1569
            finally {
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14443
diff changeset
  1570
                log.popDiagnosticHandler(discardHandler);
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1571
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1572
            if (close.kind == MTH &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1573
                    close.overrides(syms.autoCloseableClose, resource.tsym, types, true) &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1574
                    chk.isHandled(syms.interruptedExceptionType, types.memberType(resource, close).getThrownTypes()) &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1575
                    env.info.lint.isEnabled(LintCategory.TRY)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1576
                log.warning(LintCategory.TRY, pos, Warnings.TryResourceThrowsInterruptedExc(resource));
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1577
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1578
        }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1579
    }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1580
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
    public void visitConditional(JCConditional tree) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1582
        Type condtype = attribExpr(tree.cond, env, syms.booleanType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1583
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1584
        tree.polyKind = (!allowPoly ||
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1585
                pt().hasTag(NONE) && pt() != Type.recoveryType && pt() != Infer.anyPoly ||
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1586
                isBooleanOrNumeric(env, tree)) ?
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1587
                PolyKind.STANDALONE : PolyKind.POLY;
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1588
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1589
        if (tree.polyKind == PolyKind.POLY && resultInfo.pt.hasTag(VOID)) {
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1590
            //this means we are returning a poly conditional from void-compatible lambda expression
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1591
            resultInfo.checkContext.report(tree, diags.fragment(Fragments.ConditionalTargetCantBeVoid));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1592
            result = tree.type = types.createErrorType(resultInfo.pt);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1593
            return;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1594
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1595
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1596
        ResultInfo condInfo = tree.polyKind == PolyKind.STANDALONE ?
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1597
                unknownExprInfo :
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1598
                resultInfo.dup(conditionalContext(resultInfo.checkContext));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1599
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1600
        Type truetype = attribTree(tree.truepart, env, condInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1601
        Type falsetype = attribTree(tree.falsepart, env, condInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1602
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1603
        Type owntype = (tree.polyKind == PolyKind.STANDALONE) ? condType(tree, truetype, falsetype) : pt();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1604
        if (condtype.constValue() != null &&
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1605
                truetype.constValue() != null &&
14953
89a34297b198 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method
mcimadamore
parents: 14725
diff changeset
  1606
                falsetype.constValue() != null &&
89a34297b198 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method
mcimadamore
parents: 14725
diff changeset
  1607
                !owntype.hasTag(NONE)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1608
            //constant folding
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1609
            owntype = cfolder.coerce(condtype.isTrue() ? truetype : falsetype, owntype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1610
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1611
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1613
    //where
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1614
        private boolean isBooleanOrNumeric(Env<AttrContext> env, JCExpression tree) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1615
            switch (tree.getTag()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1616
                case LITERAL: return ((JCLiteral)tree).typetag.isSubRangeOf(DOUBLE) ||
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1617
                              ((JCLiteral)tree).typetag == BOOLEAN ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1618
                              ((JCLiteral)tree).typetag == BOT;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1619
                case LAMBDA: case REFERENCE: return false;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1620
                case PARENS: return isBooleanOrNumeric(env, ((JCParens)tree).expr);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1621
                case CONDEXPR:
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1622
                    JCConditional condTree = (JCConditional)tree;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1623
                    return isBooleanOrNumeric(env, condTree.truepart) &&
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1624
                            isBooleanOrNumeric(env, condTree.falsepart);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1625
                case APPLY:
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1626
                    JCMethodInvocation speculativeMethodTree =
44393
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1627
                            (JCMethodInvocation)deferredAttr.attribSpeculative(
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1628
                                    tree, env, unknownExprInfo,
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1629
                                    argumentAttr.withLocalCacheContext());
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1630
                    Symbol msym = TreeInfo.symbol(speculativeMethodTree.meth);
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1631
                    Type receiverType = speculativeMethodTree.meth.hasTag(IDENT) ?
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1632
                            env.enclClass.type :
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1633
                            ((JCFieldAccess)speculativeMethodTree.meth).selected.type;
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1634
                    Type owntype = types.memberType(receiverType, msym).getReturnType();
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1635
                    return primitiveOrBoxed(owntype);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1636
                case NEWCLASS:
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1637
                    JCExpression className =
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1638
                            removeClassParams.translate(((JCNewClass)tree).clazz);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1639
                    JCExpression speculativeNewClassTree =
44393
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1640
                            (JCExpression)deferredAttr.attribSpeculative(
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1641
                                    className, env, unknownTypeInfo,
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1642
                                    argumentAttr.withLocalCacheContext());
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1643
                    return primitiveOrBoxed(speculativeNewClassTree.type);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1644
                default:
44393
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1645
                    Type speculativeType = deferredAttr.attribSpeculative(tree, env, unknownExprInfo,
ce94820fa9d1 8176714: javac is wrongly assuming that field JCMemberReference.overloadKind has been assigned to
vromero
parents: 44392
diff changeset
  1646
                            argumentAttr.withLocalCacheContext()).type;
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1647
                    return primitiveOrBoxed(speculativeType);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1648
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1649
        }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1650
        //where
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1651
            boolean primitiveOrBoxed(Type t) {
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1652
                return (!t.hasTag(TYPEVAR) && types.unboxedTypeOrType(t).isPrimitive());
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1653
            }
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1654
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1655
            TreeTranslator removeClassParams = new TreeTranslator() {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1656
                @Override
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1657
                public void visitTypeApply(JCTypeApply tree) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1658
                    result = translate(tree.clazz);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1659
                }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1660
            };
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1661
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1662
        CheckContext conditionalContext(CheckContext checkContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1663
            return new Check.NestedCheckContext(checkContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1664
                //this will use enclosing check context to check compatibility of
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1665
                //subexpression against target type; if we are in a method check context,
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1666
                //depending on whether boxing is allowed, we could have incompatibilities
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1667
                @Override
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1668
                public void report(DiagnosticPosition pos, JCDiagnostic details) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1669
                    enclosingContext.report(pos, diags.fragment(Fragments.IncompatibleTypeInConditional(details)));
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1670
                }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1671
            };
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1672
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  1673
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
        /** Compute the type of a conditional expression, after
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1675
         *  checking that it exists.  See JLS 15.25. Does not take into
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1676
         *  account the special case where condition and both arms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1677
         *  are constants.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
         *  @param pos      The source position to be used for error
06bc494ca11e Initial load
duke
parents:
diff changeset
  1680
         *                  diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
         *  @param thentype The type of the expression's then-part.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1682
         *  @param elsetype The type of the expression's else-part.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1683
         */
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  1684
        Type condType(DiagnosticPosition pos,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1685
                               Type thentype, Type elsetype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1686
            // If same type, that is the result
06bc494ca11e Initial load
duke
parents:
diff changeset
  1687
            if (types.isSameType(thentype, elsetype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1688
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1689
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1690
            Type thenUnboxed = (thentype.isPrimitive())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
                ? thentype : types.unboxedType(thentype);
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1692
            Type elseUnboxed = (elsetype.isPrimitive())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
                ? elsetype : types.unboxedType(elsetype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1694
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
            // Otherwise, if both arms can be converted to a numeric
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
            // type, return the least numeric type that fits both arms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
            // (i.e. return larger of the two, or return int if one
06bc494ca11e Initial load
duke
parents:
diff changeset
  1698
            // arm is short, the other is char).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1699
            if (thenUnboxed.isPrimitive() && elseUnboxed.isPrimitive()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
                // If one arm has an integer subrange type (i.e., byte,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1701
                // short, or char), and the other is an integer constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  1702
                // that fits into the subrange, return the subrange type.
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1703
                if (thenUnboxed.getTag().isStrictSubRangeOf(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1704
                    elseUnboxed.hasTag(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1705
                    types.isAssignable(elseUnboxed, thenUnboxed)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
                    return thenUnboxed.baseType();
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1707
                }
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1708
                if (elseUnboxed.getTag().isStrictSubRangeOf(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1709
                    thenUnboxed.hasTag(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1710
                    types.isAssignable(thenUnboxed, elseUnboxed)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1711
                    return elseUnboxed.baseType();
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1712
                }
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1713
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1714
                for (TypeTag tag : primitiveTags) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1715
                    Type candidate = syms.typeOfTag[tag.ordinal()];
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1716
                    if (types.isSubtype(thenUnboxed, candidate) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1717
                        types.isSubtype(elseUnboxed, candidate)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
                        return candidate;
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1719
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
            // Those were all the cases that could result in a primitive
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1724
            if (thentype.isPrimitive())
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1725
                thentype = types.boxedClass(thentype).type;
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1726
            if (elsetype.isPrimitive())
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1727
                elsetype = types.boxedClass(elsetype).type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1728
06bc494ca11e Initial load
duke
parents:
diff changeset
  1729
            if (types.isSubtype(thentype, elsetype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1730
                return elsetype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1731
            if (types.isSubtype(elsetype, thentype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1732
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1734
            if (thentype.hasTag(VOID) || elsetype.hasTag(VOID)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1735
                log.error(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1736
                          Errors.NeitherConditionalSubtype(thentype,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1737
                                                           elsetype));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1738
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1740
06bc494ca11e Initial load
duke
parents:
diff changeset
  1741
            // both are known to be reference types.  The result is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1742
            // lub(thentype,elsetype). This cannot fail, as it will
06bc494ca11e Initial load
duke
parents:
diff changeset
  1743
            // always be possible to infer "Object" if nothing better.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1744
            return types.lub(thentype.baseType(), elsetype.baseType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1746
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1747
    final static TypeTag[] primitiveTags = new TypeTag[]{
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1748
        BYTE,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1749
        CHAR,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1750
        SHORT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1751
        INT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1752
        LONG,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1753
        FLOAT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1754
        DOUBLE,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1755
        BOOLEAN,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1756
    };
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1757
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1758
    public void visitIf(JCIf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1759
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1760
        attribStat(tree.thenpart, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1761
        if (tree.elsepart != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
            attribStat(tree.elsepart, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
        chk.checkEmptyIf(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1766
06bc494ca11e Initial load
duke
parents:
diff changeset
  1767
    public void visitExec(JCExpressionStatement tree) {
6592
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1768
        //a fresh environment is required for 292 inference to work properly ---
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1769
        //see Infer.instantiatePolymorphicSignatureInstance()
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1770
        Env<AttrContext> localEnv = env.dup(tree);
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1771
        attribExpr(tree.expr, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1772
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1773
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1774
06bc494ca11e Initial load
duke
parents:
diff changeset
  1775
    public void visitBreak(JCBreak tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1776
        tree.target = findJumpTarget(tree.pos(), tree.getTag(), tree.label, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1777
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1778
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
06bc494ca11e Initial load
duke
parents:
diff changeset
  1780
    public void visitContinue(JCContinue tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1781
        tree.target = findJumpTarget(tree.pos(), tree.getTag(), tree.label, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1782
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1783
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1784
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1785
        /** Return the target of a break or continue statement, if it exists,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1786
         *  report an error if not.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1787
         *  Note: The target of a labelled break or continue is the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1788
         *  (non-labelled) statement tree referred to by the label,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1789
         *  not the tree representing the labelled statement itself.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1790
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1791
         *  @param pos     The position to be used for error diagnostics
06bc494ca11e Initial load
duke
parents:
diff changeset
  1792
         *  @param tag     The tag of the jump statement. This is either
06bc494ca11e Initial load
duke
parents:
diff changeset
  1793
         *                 Tree.BREAK or Tree.CONTINUE.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1794
         *  @param label   The label of the jump statement, or null if no
06bc494ca11e Initial load
duke
parents:
diff changeset
  1795
         *                 label is given.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1796
         *  @param env     The environment current at the jump statement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1797
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
        private JCTree findJumpTarget(DiagnosticPosition pos,
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1799
                                    JCTree.Tag tag,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1800
                                    Name label,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1801
                                    Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1802
            // Search environments outwards from the point of jump.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1803
            Env<AttrContext> env1 = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1804
            LOOP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1805
            while (env1 != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1806
                switch (env1.tree.getTag()) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1807
                    case LABELLED:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1808
                        JCLabeledStatement labelled = (JCLabeledStatement)env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1809
                        if (label == labelled.label) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1810
                            // If jump is a continue, check that target is a loop.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1811
                            if (tag == CONTINUE) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1812
                                if (!labelled.body.hasTag(DOLOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1813
                                        !labelled.body.hasTag(WHILELOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1814
                                        !labelled.body.hasTag(FORLOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1815
                                        !labelled.body.hasTag(FOREACHLOOP))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1816
                                    log.error(pos, Errors.NotLoopLabel(label));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1817
                                // Found labelled statement target, now go inwards
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1818
                                // to next non-labelled tree.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1819
                                return TreeInfo.referencedStatement(labelled);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1820
                            } else {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1821
                                return labelled;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1822
                            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1823
                        }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1824
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1825
                    case DOLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1826
                    case WHILELOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1827
                    case FORLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1828
                    case FOREACHLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1829
                        if (label == null) return env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1830
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1831
                    case SWITCH:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1832
                        if (label == null && tag == BREAK) return env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1833
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1834
                    case LAMBDA:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1835
                    case METHODDEF:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1836
                    case CLASSDEF:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1837
                        break LOOP;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1838
                    default:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1839
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1840
                env1 = env1.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1841
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1842
            if (label != null)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1843
                log.error(pos, Errors.UndefLabel(label));
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1844
            else if (tag == CONTINUE)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1845
                log.error(pos, Errors.ContOutsideLoop);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1846
            else
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1847
                log.error(pos, Errors.BreakOutsideSwitchLoop);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1848
            return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1849
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1850
06bc494ca11e Initial load
duke
parents:
diff changeset
  1851
    public void visitReturn(JCReturn tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1852
        // Check that there is an enclosing method which is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1853
        // nested within than the enclosing class.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1854
        if (env.info.returnResult == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1855
            log.error(tree.pos(), Errors.RetOutsideMeth);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1856
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1857
            // Attribute return expression, if it exists, and check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
            // it conforms to result type of enclosing method.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1859
            if (tree.expr != null) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1860
                if (env.info.returnResult.pt.hasTag(VOID)) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1861
                    env.info.returnResult.checkContext.report(tree.expr.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1862
                              diags.fragment(Fragments.UnexpectedRetVal));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1863
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1864
                attribTree(tree.expr, env, env.info.returnResult);
18902
972298345a83 8016059: Cannot compile following lambda
mcimadamore
parents: 18899
diff changeset
  1865
            } else if (!env.info.returnResult.pt.hasTag(VOID) &&
972298345a83 8016059: Cannot compile following lambda
mcimadamore
parents: 18899
diff changeset
  1866
                    !env.info.returnResult.pt.hasTag(NONE)) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1867
                env.info.returnResult.checkContext.report(tree.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1868
                              diags.fragment(Fragments.MissingRetVal(env.info.returnResult.pt)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1870
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1871
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1872
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1873
06bc494ca11e Initial load
duke
parents:
diff changeset
  1874
    public void visitThrow(JCThrow tree) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1875
        Type owntype = attribExpr(tree.expr, env, allowPoly ? Type.noType : syms.throwableType);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1876
        if (allowPoly) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1877
            chk.checkType(tree, owntype, syms.throwableType);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1878
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1879
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1881
06bc494ca11e Initial load
duke
parents:
diff changeset
  1882
    public void visitAssert(JCAssert tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1883
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1884
        if (tree.detail != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1885
            chk.checkNonVoid(tree.detail.pos(), attribExpr(tree.detail, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1886
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1887
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
06bc494ca11e Initial load
duke
parents:
diff changeset
  1890
     /** Visitor method for method invocations.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1891
     *  NOTE: The method part of an application will have in its type field
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
     *        the return type of the method, not the method's type itself!
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
    public void visitApply(JCMethodInvocation tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
        // The local environment of a method application is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
        // a new environment nested in the current one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1897
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1898
06bc494ca11e Initial load
duke
parents:
diff changeset
  1899
        // The types of the actual method arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1900
        List<Type> argtypes;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1901
06bc494ca11e Initial load
duke
parents:
diff changeset
  1902
        // The types of the actual method type arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1903
        List<Type> typeargtypes = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1904
06bc494ca11e Initial load
duke
parents:
diff changeset
  1905
        Name methName = TreeInfo.name(tree.meth);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1906
06bc494ca11e Initial load
duke
parents:
diff changeset
  1907
        boolean isConstructorCall =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1908
            methName == names._this || methName == names._super;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1909
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  1910
        ListBuffer<Type> argtypesBuf = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1911
        if (isConstructorCall) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1912
            // We are seeing a ...this(...) or ...super(...) call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1913
            // Check that this is the first statement in a constructor.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1914
            if (checkFirstConstructorStat(tree, env)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1915
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
                // Record the fact
06bc494ca11e Initial load
duke
parents:
diff changeset
  1917
                // that this is a constructor call (using isSelfCall).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1918
                localEnv.info.isSelfCall = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1919
06bc494ca11e Initial load
duke
parents:
diff changeset
  1920
                // Attribute arguments, yielding list of argument types.
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1921
                KindSelector kind = attribArgs(KindSelector.MTH, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1922
                argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1923
                typeargtypes = attribTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1924
06bc494ca11e Initial load
duke
parents:
diff changeset
  1925
                // Variable `site' points to the class in which the called
06bc494ca11e Initial load
duke
parents:
diff changeset
  1926
                // constructor is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1927
                Type site = env.enclClass.sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
                if (methName == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
                    if (site == syms.objectType) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1930
                        log.error(tree.meth.pos(), Errors.NoSuperclass(site));
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  1931
                        site = types.createErrorType(syms.objectType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1932
                    } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1933
                        site = types.supertype(site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1934
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1935
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1936
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1937
                if (site.hasTag(CLASS)) {
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1938
                    Type encl = site.getEnclosingType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1939
                    while (encl != null && encl.hasTag(TYPEVAR))
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1940
                        encl = encl.getUpperBound();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1941
                    if (encl.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
                        // we are calling a nested class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1944
                        if (tree.meth.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1945
                            JCTree qualifier = ((JCFieldAccess) tree.meth).selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1946
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
                            // We are seeing a prefixed call, of the form
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
                            //     <expr>.super(...).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1949
                            // Check that the prefix expression conforms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1950
                            // to the outer instance type of the class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1951
                            chk.checkRefType(qualifier.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1952
                                             attribExpr(qualifier, localEnv,
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1953
                                                        encl));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1954
                        } else if (methName == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1955
                            // qualifier omitted; check for existence
06bc494ca11e Initial load
duke
parents:
diff changeset
  1956
                            // of an appropriate implicit qualifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1957
                            rs.resolveImplicitThis(tree.meth.pos(),
8622
4f032629a0fd 6541876: "Enclosing Instance" error new in 1.6
mcimadamore
parents: 8616
diff changeset
  1958
                                                   localEnv, site, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1959
                        }
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1960
                    } else if (tree.meth.hasTag(SELECT)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1961
                        log.error(tree.meth.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  1962
                                  Errors.IllegalQualNotIcls(site.tsym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1963
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1964
06bc494ca11e Initial load
duke
parents:
diff changeset
  1965
                    // if we're calling a java.lang.Enum constructor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
                    // prefix the implicit String and int parameters
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1967
                    if (site.tsym == syms.enumSym)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1968
                        argtypes = argtypes.prepend(syms.intType).prepend(syms.stringType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
06bc494ca11e Initial load
duke
parents:
diff changeset
  1970
                    // Resolve the called constructor under the assumption
06bc494ca11e Initial load
duke
parents:
diff changeset
  1971
                    // that we are referring to a superclass instance of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1972
                    // current instance (JLS ???).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
                    boolean selectSuperPrev = localEnv.info.selectSuper;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
                    localEnv.info.selectSuper = true;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1975
                    localEnv.info.pendingResolutionPhase = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
                    Symbol sym = rs.resolveConstructor(
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
                        tree.meth.pos(), localEnv, site, argtypes, typeargtypes);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1978
                    localEnv.info.selectSuper = selectSuperPrev;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1979
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
                    // Set method symbol to resolved constructor...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1981
                    TreeInfo.setSymbol(tree.meth, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1982
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
                    // ...and check that it is legal in the current context.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
                    // (this will also set the tree's type)
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  1985
                    Type mpt = newMethodTemplate(resultInfo.pt, argtypes, typeargtypes);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1986
                    checkId(tree.meth, site, sym, localEnv,
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1987
                            new ResultInfo(kind, mpt));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1988
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
                // Otherwise, `site' is an error type and we do nothing
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
            result = tree.type = syms.voidType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1992
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1993
            // Otherwise, we are seeing a regular method call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1994
            // Attribute the arguments, yielding list of argument types, ...
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1995
            KindSelector kind = attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1996
            argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1997
            typeargtypes = attribAnyTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1998
06bc494ca11e Initial load
duke
parents:
diff changeset
  1999
            // ... and attribute the method using as a prototype a methodtype
06bc494ca11e Initial load
duke
parents:
diff changeset
  2000
            // whose formal argument types is exactly the list of actual
06bc494ca11e Initial load
duke
parents:
diff changeset
  2001
            // arguments (this will also set the method symbol).
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  2002
            Type mpt = newMethodTemplate(resultInfo.pt, argtypes, typeargtypes);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2003
            localEnv.info.pendingResolutionPhase = null;
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2004
            Type mtype = attribTree(tree.meth, localEnv, new ResultInfo(kind, mpt, resultInfo.checkContext));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2005
06bc494ca11e Initial load
duke
parents:
diff changeset
  2006
            // Compute the result type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2007
            Type restype = mtype.getReturnType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2008
            if (restype.hasTag(WILDCARD))
6710
b14e6fe7b290 5088624: cannot find symbol message should be more intelligent
mcimadamore
parents: 6594
diff changeset
  2009
                throw new AssertionError(mtype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2010
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2011
            Type qualifier = (tree.meth.hasTag(SELECT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2012
                    ? ((JCFieldAccess) tree.meth).selected.type
06bc494ca11e Initial load
duke
parents:
diff changeset
  2013
                    : env.enclClass.sym.type;
39810
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2014
            Symbol msym = TreeInfo.symbol(tree.meth);
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2015
            restype = adjustMethodReturnType(msym, qualifier, methName, argtypes, restype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2016
8036
17b976649c61 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls
mcimadamore
parents: 8032
diff changeset
  2017
            chk.checkRefTypes(tree.typeargs, typeargtypes);
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
  2018
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2019
            // Check that value of resulting type is admissible in the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2020
            // current context.  Also, capture the return type
33708
99085a01b536 8141613: Compiler fails to infer generic type
mcimadamore
parents: 33366
diff changeset
  2021
            Type capturedRes = resultInfo.checkContext.inferenceContext().cachedCapture(tree, restype, true);
99085a01b536 8141613: Compiler fails to infer generic type
mcimadamore
parents: 33366
diff changeset
  2022
            result = check(tree, capturedRes, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2023
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  2024
        chk.validate(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2025
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2026
    //where
39810
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2027
        Type adjustMethodReturnType(Symbol msym, Type qualifierType, Name methodName, List<Type> argtypes, Type restype) {
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2028
            if (msym != null &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2029
                    msym.owner == syms.objectType.tsym &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2030
                    methodName == names.getClass &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2031
                    argtypes.isEmpty()) {
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2032
                // as a special case, x.getClass() has type Class<? extends |X|>
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2033
                return new ClassType(restype.getEnclosingType(),
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2034
                        List.of(new WildcardType(types.erasure(qualifierType),
39810
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2035
                                BoundKind.EXTENDS,
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2036
                                syms.boundClass)),
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2037
                        restype.tsym,
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2038
                        restype.getMetadata());
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2039
            } else if (msym != null &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2040
                    msym.owner == syms.arrayClass &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2041
                    methodName == names.clone &&
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  2042
                    types.isArray(qualifierType)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2043
                // as a special case, array.clone() has a result that is
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2044
                // the same as static type of the array being cloned
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2045
                return qualifierType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2046
            } else {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2047
                return restype;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2048
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2049
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2050
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2051
        /** Check that given application node appears as first statement
06bc494ca11e Initial load
duke
parents:
diff changeset
  2052
         *  in a constructor call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2053
         *  @param tree   The application node
06bc494ca11e Initial load
duke
parents:
diff changeset
  2054
         *  @param env    The environment current at the application.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2055
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2056
        boolean checkFirstConstructorStat(JCMethodInvocation tree, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2057
            JCMethodDecl enclMethod = env.enclMethod;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2058
            if (enclMethod != null && enclMethod.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2059
                JCBlock body = enclMethod.body;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2060
                if (body.stats.head.hasTag(EXEC) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2061
                    ((JCExpressionStatement) body.stats.head).expr == tree)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2062
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2063
            }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2064
            log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2065
                      Errors.CallMustBeFirstStmtInCtor(TreeInfo.name(tree.meth)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2066
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2067
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2068
06bc494ca11e Initial load
duke
parents:
diff changeset
  2069
        /** Obtain a method type with given argument types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2070
         */
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  2071
        Type newMethodTemplate(Type restype, List<Type> argtypes, List<Type> typeargtypes) {
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2072
            MethodType mt = new MethodType(argtypes, restype, List.nil(), syms.methodClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2073
            return (typeargtypes == null) ? mt : (Type)new ForAll(typeargtypes, mt);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2074
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2075
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2076
    public void visitNewClass(final JCNewClass tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  2077
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2078
06bc494ca11e Initial load
duke
parents:
diff changeset
  2079
        // The local environment of a class creation is
06bc494ca11e Initial load
duke
parents:
diff changeset
  2080
        // a new environment nested in the current one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2081
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup());
06bc494ca11e Initial load
duke
parents:
diff changeset
  2082
06bc494ca11e Initial load
duke
parents:
diff changeset
  2083
        // The anonymous inner class definition of the new expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2084
        // if one is defined by it.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2085
        JCClassDecl cdef = tree.def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2086
06bc494ca11e Initial load
duke
parents:
diff changeset
  2087
        // If enclosing class is given, attribute it, and
06bc494ca11e Initial load
duke
parents:
diff changeset
  2088
        // complete class name to be fully qualified
06bc494ca11e Initial load
duke
parents:
diff changeset
  2089
        JCExpression clazz = tree.clazz; // Class field following new
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2090
        JCExpression clazzid;            // Identifier in class field
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2091
        JCAnnotatedType annoclazzid;     // Annotated type enclosing clazzid
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2092
        annoclazzid = null;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2093
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2094
        if (clazz.hasTag(TYPEAPPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2095
            clazzid = ((JCTypeApply) clazz).clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2096
            if (clazzid.hasTag(ANNOTATED_TYPE)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2097
                annoclazzid = (JCAnnotatedType) clazzid;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2098
                clazzid = annoclazzid.underlyingType;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2099
            }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2100
        } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2101
            if (clazz.hasTag(ANNOTATED_TYPE)) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2102
                annoclazzid = (JCAnnotatedType) clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2103
                clazzid = annoclazzid.underlyingType;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2104
            } else {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2105
                clazzid = clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2106
            }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2107
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2108
06bc494ca11e Initial load
duke
parents:
diff changeset
  2109
        JCExpression clazzid1 = clazzid; // The same in fully qualified form
06bc494ca11e Initial load
duke
parents:
diff changeset
  2110
06bc494ca11e Initial load
duke
parents:
diff changeset
  2111
        if (tree.encl != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2112
            // We are seeing a qualified new, of the form
06bc494ca11e Initial load
duke
parents:
diff changeset
  2113
            //    <expr>.new C <...> (...) ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  2114
            // In this case, we let clazz stand for the name of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2115
            // allocated class C prefixed with the type of the qualifier
06bc494ca11e Initial load
duke
parents:
diff changeset
  2116
            // expression, so that we can
06bc494ca11e Initial load
duke
parents:
diff changeset
  2117
            // resolve it with standard techniques later. I.e., if
06bc494ca11e Initial load
duke
parents:
diff changeset
  2118
            // <expr> has type T, then <expr>.new C <...> (...)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2119
            // yields a clazz T.C.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2120
            Type encltype = chk.checkRefType(tree.encl.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2121
                                             attribExpr(tree.encl, env));
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2122
            // TODO 308: in <expr>.new C, do we also want to add the type annotations
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2123
            // from expr to the combined type, or not? Yes, do this.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2124
            clazzid1 = make.at(clazz.pos).Select(make.Type(encltype),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2125
                                                 ((JCIdent) clazzid).name);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2126
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18920
diff changeset
  2127
            EndPosTable endPosTable = this.env.toplevel.endPositions;
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18920
diff changeset
  2128
            endPosTable.storeEnd(clazzid1, tree.getEndPosition(endPosTable));
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2129
            if (clazz.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2130
                JCAnnotatedType annoType = (JCAnnotatedType) clazz;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2131
                List<JCAnnotation> annos = annoType.annotations;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2132
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2133
                if (annoType.underlyingType.hasTag(TYPEAPPLY)) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2134
                    clazzid1 = make.at(tree.pos).
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2135
                        TypeApply(clazzid1,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2136
                                  ((JCTypeApply) clazz).arguments);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2137
                }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2138
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2139
                clazzid1 = make.at(tree.pos).
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2140
                    AnnotatedType(annos, clazzid1);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2141
            } else if (clazz.hasTag(TYPEAPPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2142
                clazzid1 = make.at(tree.pos).
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2143
                    TypeApply(clazzid1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2144
                              ((JCTypeApply) clazz).arguments);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2145
            }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2146
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2147
            clazz = clazzid1;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2148
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2149
06bc494ca11e Initial load
duke
parents:
diff changeset
  2150
        // Attribute clazz expression and store
06bc494ca11e Initial load
duke
parents:
diff changeset
  2151
        // symbol + type back into the attributed tree.
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2152
        Type clazztype;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2153
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2154
        try {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2155
            env.info.isNewClass = true;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2156
            clazztype = TreeInfo.isEnumInit(env.tree) ?
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2157
                attribIdentAsEnumType(env, (JCIdent)clazz) :
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2158
                attribType(clazz, env);
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2159
        } finally {
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2160
            env.info.isNewClass = false;
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  2161
        }
12916
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
  2162
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8625
diff changeset
  2163
        clazztype = chk.checkDiamond(tree, clazztype);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  2164
        chk.validate(clazz, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2165
        if (tree.encl != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2166
            // We have to work in this case to store
06bc494ca11e Initial load
duke
parents:
diff changeset
  2167
            // symbol + type back into the attributed tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2168
            tree.clazz.type = clazztype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2169
            TreeInfo.setSymbol(clazzid, TreeInfo.symbol(clazzid1));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2170
            clazzid.type = ((JCIdent) clazzid).sym.type;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2171
            if (annoclazzid != null) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2172
                annoclazzid.type = clazzid.type;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  2173
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2174
            if (!clazztype.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2175
                if (cdef != null && clazztype.tsym.isInterface()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2176
                    log.error(tree.encl.pos(), Errors.AnonClassImplIntfNoQualForNew);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2177
                } else if (clazztype.tsym.isStatic()) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2178
                    log.error(tree.encl.pos(), Errors.QualifiedNewOfStaticClass(clazztype.tsym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2179
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2180
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2181
        } else if (!clazztype.tsym.isInterface() &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2182
                   clazztype.getEnclosingType().hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2183
            // Check for the existence of an apropos outer instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  2184
            rs.resolveImplicitThis(tree.pos(), env, clazztype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2185
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2186
06bc494ca11e Initial load
duke
parents:
diff changeset
  2187
        // Attribute constructor arguments.
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2188
        ListBuffer<Type> argtypesBuf = new ListBuffer<>();
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2189
        final KindSelector pkind =
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  2190
            attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2191
        List<Type> argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2192
        List<Type> typeargtypes = attribTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2193
06bc494ca11e Initial load
duke
parents:
diff changeset
  2194
        // If we have made no mistakes in the class type...
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2195
        if (clazztype.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2196
            // Enums may not be instantiated except implicitly
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2197
            if ((clazztype.tsym.flags_field & Flags.ENUM) != 0 &&
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2198
                (!env.tree.hasTag(VARDEF) ||
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  2199
                 (((JCVariableDecl) env.tree).mods.flags & Flags.ENUM) == 0 ||
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2200
                 ((JCVariableDecl) env.tree).init != tree))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2201
                log.error(tree.pos(), Errors.EnumCantBeInstantiated);
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2202
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2203
            boolean isSpeculativeDiamondInferenceRound = TreeInfo.isDiamond(tree) &&
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2204
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2205
            boolean skipNonDiamondPath = false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2206
            // Check that class is not abstract
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2207
            if (cdef == null && !isSpeculativeDiamondInferenceRound && // class body may be nulled out in speculative tree copy
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2208
                (clazztype.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2209
                log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2210
                          Errors.AbstractCantBeInstantiated(clazztype.tsym));
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2211
                skipNonDiamondPath = true;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2212
            } else if (cdef != null && clazztype.tsym.isInterface()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2213
                // Check that no constructor arguments are given to
06bc494ca11e Initial load
duke
parents:
diff changeset
  2214
                // anonymous classes implementing an interface
06bc494ca11e Initial load
duke
parents:
diff changeset
  2215
                if (!argtypes.isEmpty())
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2216
                    log.error(tree.args.head.pos(), Errors.AnonClassImplIntfNoArgs);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2217
06bc494ca11e Initial load
duke
parents:
diff changeset
  2218
                if (!typeargtypes.isEmpty())
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2219
                    log.error(tree.typeargs.head.pos(), Errors.AnonClassImplIntfNoTypeargs);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2220
06bc494ca11e Initial load
duke
parents:
diff changeset
  2221
                // Error recovery: pretend no arguments were supplied.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2222
                argtypes = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2223
                typeargtypes = List.nil();
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2224
                skipNonDiamondPath = true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2225
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2226
            if (TreeInfo.isDiamond(tree)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2227
                ClassType site = new ClassType(clazztype.getEnclosingType(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2228
                            clazztype.tsym.type.getTypeArguments(),
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  2229
                                               clazztype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  2230
                                               clazztype.getMetadata());
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2231
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2232
                Env<AttrContext> diamondEnv = localEnv.dup(tree);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2233
                diamondEnv.info.selectSuper = cdef != null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2234
                diamondEnv.info.pendingResolutionPhase = null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2235
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2236
                //if the type of the instance creation expression is a class type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2237
                //apply method resolution inference (JLS 15.12.2.7). The return type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2238
                //of the resolved constructor will be a partially instantiated type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2239
                Symbol constructor = rs.resolveDiamond(tree.pos(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2240
                            diamondEnv,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2241
                            site,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2242
                            argtypes,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2243
                            typeargtypes);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2244
                tree.constructor = constructor.baseSymbol();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2245
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2246
                final TypeSymbol csym = clazztype.tsym;
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2247
                ResultInfo diamondResult = new ResultInfo(pkind, newMethodTemplate(resultInfo.pt, argtypes, typeargtypes),
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2248
                        diamondContext(tree, csym, resultInfo.checkContext), CheckMode.NO_TREE_UPDATE);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2249
                Type constructorType = tree.constructorType = types.createErrorType(clazztype);
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2250
                constructorType = checkId(tree, site,
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2251
                        constructor,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2252
                        diamondEnv,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2253
                        diamondResult);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2254
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2255
                tree.clazz.type = types.createErrorType(clazztype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2256
                if (!constructorType.isErroneous()) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2257
                    tree.clazz.type = clazz.type = constructorType.getReturnType();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2258
                    tree.constructorType = types.createMethodTypeWithReturn(constructorType, syms.voidType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2259
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2260
                clazztype = chk.checkClassType(tree.clazz, tree.clazz.type, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2261
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2262
06bc494ca11e Initial load
duke
parents:
diff changeset
  2263
            // Resolve the called constructor under the assumption
06bc494ca11e Initial load
duke
parents:
diff changeset
  2264
            // that we are referring to a superclass instance of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2265
            // current instance (JLS ???).
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2266
            else if (!skipNonDiamondPath) {
9724
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2267
                //the following code alters some of the fields in the current
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2268
                //AttrContext - hence, the current context must be dup'ed in
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2269
                //order to avoid downstream failures
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2270
                Env<AttrContext> rsEnv = localEnv.dup(tree);
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2271
                rsEnv.info.selectSuper = cdef != null;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2272
                rsEnv.info.pendingResolutionPhase = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2273
                tree.constructor = rs.resolveConstructor(
9724
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2274
                    tree.pos(), rsEnv, clazztype, argtypes, typeargtypes);
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2275
                if (cdef == null) { //do not check twice!
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2276
                    tree.constructorType = checkId(tree,
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2277
                            clazztype,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2278
                            tree.constructor,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2279
                            rsEnv,
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2280
                            new ResultInfo(pkind, newMethodTemplate(syms.voidType, argtypes, typeargtypes), CheckMode.NO_TREE_UPDATE));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2281
                    if (rsEnv.info.lastResolveVarargs())
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2282
                        Assert.check(tree.constructorType.isErroneous() || tree.varargsElement != null);
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2283
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2284
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2285
06bc494ca11e Initial load
duke
parents:
diff changeset
  2286
            if (cdef != null) {
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2287
                visitAnonymousClassDefinition(tree, clazz, clazztype, cdef, localEnv, argtypes, typeargtypes, pkind);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2288
                return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2289
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2290
06bc494ca11e Initial load
duke
parents:
diff changeset
  2291
            if (tree.constructor != null && tree.constructor.kind == MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2292
                owntype = clazztype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2293
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2294
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2295
        InferenceContext inferenceContext = resultInfo.checkContext.inferenceContext();
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2296
        if (tree.constructorType != null && inferenceContext.free(tree.constructorType)) {
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2297
            //we need to wait for inference to finish and then replace inference vars in the constructor type
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2298
            inferenceContext.addFreeTypeListener(List.of(tree.constructorType),
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2299
                    instantiatedContext -> {
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2300
                        tree.constructorType = instantiatedContext.asInstType(tree.constructorType);
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2301
                    });
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2302
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  2303
        chk.validate(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2304
    }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2305
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2306
        // where
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2307
        private void visitAnonymousClassDefinition(JCNewClass tree, JCExpression clazz, Type clazztype,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2308
                                                   JCClassDecl cdef, Env<AttrContext> localEnv,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2309
                                                   List<Type> argtypes, List<Type> typeargtypes,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2310
                                                   KindSelector pkind) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2311
            // We are seeing an anonymous class instance creation.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2312
            // In this case, the class instance creation
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2313
            // expression
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2314
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2315
            //    E.new <typeargs1>C<typargs2>(args) { ... }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2316
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2317
            // is represented internally as
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2318
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2319
            //    E . new <typeargs1>C<typargs2>(args) ( class <empty-name> { ... } )  .
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2320
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2321
            // This expression is then *transformed* as follows:
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2322
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2323
            // (1) add an extends or implements clause
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2324
            // (2) add a constructor.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2325
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2326
            // For instance, if C is a class, and ET is the type of E,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2327
            // the expression
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2328
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2329
            //    E.new <typeargs1>C<typargs2>(args) { ... }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2330
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2331
            // is translated to (where X is a fresh name and typarams is the
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2332
            // parameter list of the super constructor):
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2333
            //
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2334
            //   new <typeargs1>X(<*nullchk*>E, args) where
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2335
            //     X extends C<typargs2> {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2336
            //       <typarams> X(ET e, args) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2337
            //         e.<typeargs1>super(args)
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2338
            //       }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2339
            //       ...
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2340
            //     }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2341
            InferenceContext inferenceContext = resultInfo.checkContext.inferenceContext();
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2342
            final boolean isDiamond = TreeInfo.isDiamond(tree);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2343
            if (isDiamond
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2344
                    && ((tree.constructorType != null && inferenceContext.free(tree.constructorType))
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2345
                    || (tree.clazz.type != null && inferenceContext.free(tree.clazz.type)))) {
31113
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2346
                final ResultInfo resultInfoForClassDefinition = this.resultInfo;
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2347
                inferenceContext.addFreeTypeListener(List.of(tree.constructorType, tree.clazz.type),
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2348
                        instantiatedContext -> {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2349
                            tree.constructorType = instantiatedContext.asInstType(tree.constructorType);
32912
dd06b5fd9300 8133135: Compiler internall error (NPE) on anonymous class defined by qualified instance creation expression with diamond
sadayapalam
parents: 32709
diff changeset
  2350
                            tree.clazz.type = clazz.type = instantiatedContext.asInstType(clazz.type);
31113
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2351
                            ResultInfo prevResult = this.resultInfo;
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2352
                            try {
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2353
                                this.resultInfo = resultInfoForClassDefinition;
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2354
                                visitAnonymousClassDefinition(tree, clazz, clazz.type, cdef,
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2355
                                                            localEnv, argtypes, typeargtypes, pkind);
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2356
                            } finally {
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2357
                                this.resultInfo = prevResult;
646511cb5873 8081521: Compiler has trouble compiling nested diamond allocation constructs involving anonymous classes.
sadayapalam
parents: 30845
diff changeset
  2358
                            }
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2359
                        });
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2360
            } else {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2361
                if (isDiamond && clazztype.hasTag(CLASS)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2362
                    List<Type> invalidDiamondArgs = chk.checkDiamondDenotable((ClassType)clazztype);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2363
                    if (!clazztype.isErroneous() && invalidDiamondArgs.nonEmpty()) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2364
                        // One or more types inferred in the previous steps is non-denotable.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2365
                        Fragment fragment = Diamond(clazztype.tsym);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2366
                        log.error(tree.clazz.pos(),
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2367
                                Errors.CantApplyDiamond1(
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2368
                                        fragment,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2369
                                        invalidDiamondArgs.size() > 1 ?
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2370
                                                DiamondInvalidArgs(invalidDiamondArgs, fragment) :
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2371
                                                DiamondInvalidArg(invalidDiamondArgs, fragment)));
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2372
                    }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2373
                    // For <>(){}, inferred types must also be accessible.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2374
                    for (Type t : clazztype.getTypeArguments()) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2375
                        rs.checkAccessibleType(env, t);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2376
                    }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2377
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2378
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2379
                // If we already errored, be careful to avoid a further avalanche. ErrorType answers
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2380
                // false for isInterface call even when the original type is an interface.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2381
                boolean implementing = clazztype.tsym.isInterface() ||
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2382
                        clazztype.isErroneous() && clazztype.getOriginalType().tsym.isInterface();
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2383
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2384
                if (implementing) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2385
                    cdef.implementing = List.of(clazz);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2386
                } else {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2387
                    cdef.extending = clazz;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2388
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2389
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2390
                if (resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2391
                    isSerializable(clazztype)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2392
                    localEnv.info.isSerializable = true;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2393
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2394
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2395
                attribStat(cdef, localEnv);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2396
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2397
                List<Type> finalargtypes;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2398
                // If an outer instance is given,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2399
                // prefix it to the constructor arguments
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2400
                // and delete it from the new expression
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2401
                if (tree.encl != null && !clazztype.tsym.isInterface()) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2402
                    finalargtypes = argtypes.prepend(tree.encl.type);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2403
                } else {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2404
                    finalargtypes = argtypes;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2405
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2406
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2407
                // Reassign clazztype and recompute constructor. As this necessarily involves
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2408
                // another attribution pass for deferred types in the case of <>, replicate
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2409
                // them. Original arguments have right decorations already.
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2410
                if (isDiamond && pkind.contains(KindSelector.POLY)) {
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2411
                    finalargtypes = finalargtypes.map(deferredAttr.deferredCopier);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2412
                }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2413
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2414
                clazztype = cdef.sym.type;
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2415
                Symbol sym = tree.constructor = rs.resolveConstructor(
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2416
                        tree.pos(), localEnv, clazztype, finalargtypes, typeargtypes);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2417
                Assert.check(!sym.kind.isResolutionError());
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2418
                tree.constructor = sym;
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2419
                tree.constructorType = checkId(tree,
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2420
                        clazztype,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2421
                        tree.constructor,
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2422
                        localEnv,
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2423
                        new ResultInfo(pkind, newMethodTemplate(syms.voidType, finalargtypes, typeargtypes), CheckMode.NO_TREE_UPDATE));
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2424
            }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2425
            Type owntype = (tree.constructor != null && tree.constructor.kind == MTH) ?
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2426
                                clazztype : types.createErrorType(tree.type);
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  2427
            result = check(tree, owntype, KindSelector.VAL, resultInfo.dup(CheckMode.NO_INFERENCE_HOOK));
29776
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2428
            chk.validate(tree.typeargs, localEnv);
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2429
        }
984a79b71cfe 8062373: Project Coin: diamond and anonymous classes
sadayapalam
parents: 29774
diff changeset
  2430
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2431
        CheckContext diamondContext(JCNewClass clazz, TypeSymbol tsym, CheckContext checkContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2432
            return new Check.NestedCheckContext(checkContext) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2433
                @Override
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2434
                public void report(DiagnosticPosition _unused, JCDiagnostic details) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2435
                    enclosingContext.report(clazz.clazz,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2436
                            diags.fragment(Fragments.CantApplyDiamond1(Fragments.Diamond(tsym), details)));
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2437
                }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2438
            };
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2439
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2440
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2441
    /** Make an attributed null check tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2442
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2443
    public JCExpression makeNullCheck(JCExpression arg) {
41154
ed8625a2f0f1 8166108: VerifyError passing anonymous inner class to supertype constructor
sadayapalam
parents: 40504
diff changeset
  2444
        // optimization: new Outer() can never be null; skip null check
ed8625a2f0f1 8166108: VerifyError passing anonymous inner class to supertype constructor
sadayapalam
parents: 40504
diff changeset
  2445
        if (arg.getTag() == NEWCLASS)
ed8625a2f0f1 8166108: VerifyError passing anonymous inner class to supertype constructor
sadayapalam
parents: 40504
diff changeset
  2446
            return arg;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2447
        // optimization: X.this is never null; skip null check
06bc494ca11e Initial load
duke
parents:
diff changeset
  2448
        Name name = TreeInfo.name(arg);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2449
        if (name == names._this || name == names._super) return arg;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2450
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2451
        JCTree.Tag optag = NULLCHK;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2452
        JCUnary tree = make.at(arg.pos).Unary(optag, arg);
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  2453
        tree.operator = operators.resolveUnary(arg, optag, arg.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2454
        tree.type = arg.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2455
        return tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2456
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2457
06bc494ca11e Initial load
duke
parents:
diff changeset
  2458
    public void visitNewArray(JCNewArray tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  2459
        Type owntype = types.createErrorType(tree.type);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2460
        Env<AttrContext> localEnv = env.dup(tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2461
        Type elemtype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2462
        if (tree.elemtype != null) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2463
            elemtype = attribType(tree.elemtype, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2464
            chk.validate(tree.elemtype, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2465
            owntype = elemtype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2466
            for (List<JCExpression> l = tree.dims; l.nonEmpty(); l = l.tail) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2467
                attribExpr(l.head, localEnv, syms.intType);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  2468
                owntype = new ArrayType(owntype, syms.arrayClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2469
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2470
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2471
            // we are seeing an untyped aggregate { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2472
            // this is allowed only if the prototype is an array
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2473
            if (pt().hasTag(ARRAY)) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2474
                elemtype = types.elemtype(pt());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2475
            } else {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  2476
                if (!pt().hasTag(ERROR) &&
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  2477
                        (env.info.enclVar == null || !env.info.enclVar.type.isErroneous())) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2478
                    log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2479
                              Errors.IllegalInitializerForType(pt()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2480
                }
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2481
                elemtype = types.createErrorType(pt());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2482
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2483
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2484
        if (tree.elems != null) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2485
            attribExprs(tree.elems, localEnv, elemtype);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  2486
            owntype = new ArrayType(elemtype, syms.arrayClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2487
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2488
        if (!types.isReifiable(elemtype))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2489
            log.error(tree.pos(), Errors.GenericArrayCreation);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2490
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2491
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2492
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2493
    /*
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2494
     * A lambda expression can only be attributed when a target-type is available.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2495
     * In addition, if the target-type is that of a functional interface whose
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2496
     * descriptor contains inference variables in argument position the lambda expression
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2497
     * is 'stuck' (see DeferredAttr).
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2498
     */
11143
9dbe313bfb74 7115050: Add parser support for lambda expressions
mcimadamore
parents: 10950
diff changeset
  2499
    @Override
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2500
    public void visitLambda(final JCLambda that) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2501
        if (pt().isErroneous() || (pt().hasTag(NONE) && pt() != Type.recoveryType)) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  2502
            if (pt().hasTag(NONE) && (env.info.enclVar == null || !env.info.enclVar.type.isErroneous())) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2503
                //lambda only allowed in assignment or method invocation/cast context
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2504
                log.error(that.pos(), Errors.UnexpectedLambda);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2505
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2506
            result = that.type = types.createErrorType(pt());
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2507
            return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2508
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2509
        //create an environment for attribution of the lambda expression
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2510
        final Env<AttrContext> localEnv = lambdaEnv(that, env);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2511
        boolean needsRecovery =
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2512
                resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2513
        try {
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2514
            if (needsRecovery && isSerializable(pt())) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2515
                localEnv.info.isSerializable = true;
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  2516
                localEnv.info.isLambda = true;
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2517
            }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2518
            List<Type> explicitParamTypes = null;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2519
            if (that.paramKind == JCLambda.ParameterKind.EXPLICIT) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2520
                //attribute lambda parameters
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2521
                attribStats(that.params, localEnv);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2522
                explicitParamTypes = TreeInfo.types(that.params);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2523
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2524
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2525
            TargetInfo targetInfo = getTargetInfo(that, resultInfo, explicitParamTypes);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2526
            Type currentTarget = targetInfo.target;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2527
            Type lambdaType = targetInfo.descriptor;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2528
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2529
            if (currentTarget.isErroneous()) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2530
                result = that.type = currentTarget;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2531
                return;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2532
            }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2533
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2534
            setFunctionalInfo(localEnv, that, pt(), lambdaType, currentTarget, resultInfo.checkContext);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2535
14723
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2536
            if (lambdaType.hasTag(FORALL)) {
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2537
                //lambda expression target desc cannot be a generic method
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2538
                Fragment msg = Fragments.InvalidGenericLambdaTarget(lambdaType,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2539
                                                                    kindName(currentTarget.tsym),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2540
                                                                    currentTarget.tsym);
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2541
                resultInfo.checkContext.report(that, diags.fragment(msg));
14723
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2542
                result = that.type = types.createErrorType(pt());
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2543
                return;
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2544
            }
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2545
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2546
            if (that.paramKind == JCLambda.ParameterKind.IMPLICIT) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2547
                //add param type info in the AST
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2548
                List<Type> actuals = lambdaType.getParameterTypes();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2549
                List<JCVariableDecl> params = that.params;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2550
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2551
                boolean arityMismatch = false;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2552
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2553
                while (params.nonEmpty()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2554
                    if (actuals.isEmpty()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2555
                        //not enough actuals to perform lambda parameter inference
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2556
                        arityMismatch = true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2557
                    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2558
                    //reset previously set info
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2559
                    Type argType = arityMismatch ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2560
                            syms.errType :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2561
                            actuals.head;
47318
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  2562
                    setSyntheticVariableType(params.head, argType);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2563
                    params.head.sym = null;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2564
                    actuals = actuals.isEmpty() ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2565
                            actuals :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2566
                            actuals.tail;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2567
                    params = params.tail;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2568
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2569
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2570
                //attribute lambda parameters
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2571
                attribStats(that.params, localEnv);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2572
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2573
                if (arityMismatch) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2574
                    resultInfo.checkContext.report(that, diags.fragment(Fragments.IncompatibleArgTypesInLambda));
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2575
                        result = that.type = types.createErrorType(currentTarget);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2576
                        return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2577
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2578
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2579
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2580
            //from this point on, no recovery is needed; if we are in assignment context
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2581
            //we will be able to attribute the whole lambda body, regardless of errors;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2582
            //if we are in a 'check' method context, and the lambda is not compatible
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2583
            //with the target-type, it will be recovered anyway in Attr.checkId
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2584
            needsRecovery = false;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2585
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2586
            ResultInfo bodyResultInfo = localEnv.info.returnResult =
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2587
                    lambdaBodyResult(that, lambdaType, resultInfo);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2588
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2589
            if (that.getBodyKind() == JCLambda.BodyKind.EXPRESSION) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2590
                attribTree(that.getBody(), localEnv, bodyResultInfo);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2591
            } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2592
                JCBlock body = (JCBlock)that.body;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2593
                attribStats(body.stats, localEnv);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2594
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2595
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2596
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2597
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2598
            boolean isSpeculativeRound =
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2599
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2600
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2601
            preFlow(that);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2602
            flow.analyzeLambda(env, that, make, isSpeculativeRound);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2603
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  2604
            that.type = currentTarget; //avoids recovery at this stage
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2605
            checkLambdaCompatible(that, lambdaType, resultInfo.checkContext);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2606
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2607
            if (!isSpeculativeRound) {
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2608
                //add thrown types as bounds to the thrown types free variables if needed:
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2609
                if (resultInfo.checkContext.inferenceContext().free(lambdaType.getThrownTypes())) {
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2610
                    List<Type> inferredThrownTypes = flow.analyzeLambdaThrownTypes(env, that, make);
45756
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  2611
                    if(!checkExConstraints(inferredThrownTypes, lambdaType.getThrownTypes(), resultInfo.checkContext.inferenceContext())) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  2612
                        log.error(that, Errors.IncompatibleThrownTypesInMref(lambdaType.getThrownTypes()));
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  2613
                    }
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2614
                }
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2615
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2616
                checkAccessibleTypes(that, localEnv, resultInfo.checkContext.inferenceContext(), lambdaType, currentTarget);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2617
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2618
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2619
        } catch (Types.FunctionDescriptorLookupError ex) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2620
            JCDiagnostic cause = ex.getDiagnostic();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2621
            resultInfo.checkContext.report(that, cause);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2622
            result = that.type = types.createErrorType(pt());
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2623
            return;
30064
39493809b601 8077605: Initializing static fields causes unbounded recursion in javac
jlahoda
parents: 29959
diff changeset
  2624
        } catch (Throwable t) {
39493809b601 8077605: Initializing static fields causes unbounded recursion in javac
jlahoda
parents: 29959
diff changeset
  2625
            //when an unexpected exception happens, avoid attempts to attribute the same tree again
39493809b601 8077605: Initializing static fields causes unbounded recursion in javac
jlahoda
parents: 29959
diff changeset
  2626
            //as that would likely cause the same exception again.
39493809b601 8077605: Initializing static fields causes unbounded recursion in javac
jlahoda
parents: 29959
diff changeset
  2627
            needsRecovery = false;
39493809b601 8077605: Initializing static fields causes unbounded recursion in javac
jlahoda
parents: 29959
diff changeset
  2628
            throw t;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2629
        } finally {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2630
            localEnv.info.scope.leave();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2631
            if (needsRecovery) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2632
                attribTree(that, env, recoveryInfo);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2633
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2634
        }
11143
9dbe313bfb74 7115050: Add parser support for lambda expressions
mcimadamore
parents: 10950
diff changeset
  2635
    }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2636
    //where
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2637
        class TargetInfo {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2638
            Type target;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2639
            Type descriptor;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2640
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2641
            public TargetInfo(Type target, Type descriptor) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2642
                this.target = target;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2643
                this.descriptor = descriptor;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2644
            }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2645
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2646
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2647
        TargetInfo getTargetInfo(JCPolyExpression that, ResultInfo resultInfo, List<Type> explicitParamTypes) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2648
            Type lambdaType;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2649
            Type currentTarget = resultInfo.pt;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2650
            if (resultInfo.pt != Type.recoveryType) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2651
                /* We need to adjust the target. If the target is an
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2652
                 * intersection type, for example: SAM & I1 & I2 ...
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2653
                 * the target will be updated to SAM
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2654
                 */
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2655
                currentTarget = targetChecker.visit(currentTarget, that);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2656
                if (explicitParamTypes != null) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2657
                    currentTarget = infer.instantiateFunctionalInterface(that,
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2658
                            currentTarget, explicitParamTypes, resultInfo.checkContext);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2659
                }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2660
                currentTarget = types.removeWildcards(currentTarget);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2661
                lambdaType = types.findDescriptorType(currentTarget);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2662
            } else {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2663
                currentTarget = Type.recoveryType;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2664
                lambdaType = fallbackDescriptorType(that);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2665
            }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2666
            if (that.hasTag(LAMBDA) && lambdaType.hasTag(FORALL)) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2667
                //lambda expression target desc cannot be a generic method
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2668
                Fragment msg = Fragments.InvalidGenericLambdaTarget(lambdaType,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2669
                                                                    kindName(currentTarget.tsym),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2670
                                                                    currentTarget.tsym);
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2671
                resultInfo.checkContext.report(that, diags.fragment(msg));
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2672
                currentTarget = types.createErrorType(pt());
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2673
            }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2674
            return new TargetInfo(currentTarget, lambdaType);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2675
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2676
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2677
        void preFlow(JCLambda tree) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2678
            new PostAttrAnalyzer() {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2679
                @Override
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2680
                public void scan(JCTree tree) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2681
                    if (tree == null ||
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2682
                            (tree.type != null &&
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2683
                            tree.type == Type.stuckType)) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2684
                        //don't touch stuck expressions!
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2685
                        return;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2686
                    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2687
                    super.scan(tree);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2688
                }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2689
            }.scan(tree);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2690
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2691
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2692
        Types.MapVisitor<DiagnosticPosition> targetChecker = new Types.MapVisitor<DiagnosticPosition>() {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2693
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2694
            @Override
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2695
            public Type visitClassType(ClassType t, DiagnosticPosition pos) {
29147
4cba0458106b 8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
mcimadamore
parents: 29051
diff changeset
  2696
                return t.isIntersection() ?
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2697
                        visitIntersectionClassType((IntersectionClassType)t, pos) : t;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2698
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2699
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2700
            public Type visitIntersectionClassType(IntersectionClassType ict, DiagnosticPosition pos) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2701
                Symbol desc = types.findDescriptorSymbol(makeNotionalInterface(ict));
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2702
                Type target = null;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2703
                for (Type bound : ict.getExplicitComponents()) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2704
                    TypeSymbol boundSym = bound.tsym;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2705
                    if (types.isFunctionalInterface(boundSym) &&
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2706
                            types.findDescriptorSymbol(boundSym) == desc) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2707
                        target = bound;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2708
                    } else if (!boundSym.isInterface() || (boundSym.flags() & ANNOTATION) != 0) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2709
                        //bound must be an interface
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2710
                        reportIntersectionError(pos, "not.an.intf.component", boundSym);
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2711
                    }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  2712
                }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2713
                return target != null ?
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2714
                        target :
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2715
                        ict.getExplicitComponents().head; //error recovery
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  2716
            }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2717
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2718
            private TypeSymbol makeNotionalInterface(IntersectionClassType ict) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2719
                ListBuffer<Type> targs = new ListBuffer<>();
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2720
                ListBuffer<Type> supertypes = new ListBuffer<>();
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2721
                for (Type i : ict.interfaces_field) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2722
                    if (i.isParameterized()) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2723
                        targs.appendList(i.tsym.type.allparams());
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2724
                    }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2725
                    supertypes.append(i.tsym.type);
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2726
                }
29147
4cba0458106b 8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
mcimadamore
parents: 29051
diff changeset
  2727
                IntersectionClassType notionalIntf = types.makeIntersectionType(supertypes.toList());
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2728
                notionalIntf.allparams_field = targs.toList();
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2729
                notionalIntf.tsym.flags_field |= INTERFACE;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2730
                return notionalIntf.tsym;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2731
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2732
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2733
            private void reportIntersectionError(DiagnosticPosition pos, String key, Object... args) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2734
                resultInfo.checkContext.report(pos,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2735
                                               diags.fragment(Fragments.BadIntersectionTargetForFunctionalExpr(diags.fragment(key, args))));
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2736
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2737
        };
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2738
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2739
        private Type fallbackDescriptorType(JCExpression tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2740
            switch (tree.getTag()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2741
                case LAMBDA:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2742
                    JCLambda lambda = (JCLambda)tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2743
                    List<Type> argtypes = List.nil();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2744
                    for (JCVariableDecl param : lambda.params) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2745
                        argtypes = param.vartype != null ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2746
                                argtypes.append(param.vartype.type) :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2747
                                argtypes.append(syms.errType);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2748
                    }
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2749
                    return new MethodType(argtypes, Type.recoveryType,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2750
                            List.of(syms.throwableType), syms.methodClass);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2751
                case REFERENCE:
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2752
                    return new MethodType(List.nil(), Type.recoveryType,
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2753
                            List.of(syms.throwableType), syms.methodClass);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2754
                default:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2755
                    Assert.error("Cannot get here!");
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2756
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2757
            return null;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2758
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2759
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2760
        private void checkAccessibleTypes(final DiagnosticPosition pos, final Env<AttrContext> env,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2761
                final InferenceContext inferenceContext, final Type... ts) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2762
            checkAccessibleTypes(pos, env, inferenceContext, List.from(ts));
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2763
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2764
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2765
        private void checkAccessibleTypes(final DiagnosticPosition pos, final Env<AttrContext> env,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2766
                final InferenceContext inferenceContext, final List<Type> ts) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2767
            if (inferenceContext.free(ts)) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  2768
                inferenceContext.addFreeTypeListener(ts,
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  2769
                        solvedContext -> checkAccessibleTypes(pos, env, solvedContext, solvedContext.asInstTypes(ts)));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2770
            } else {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2771
                for (Type t : ts) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2772
                    rs.checkAccessibleType(env, t);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2773
                }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2774
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2775
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2776
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2777
        /**
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2778
         * Lambda/method reference have a special check context that ensures
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2779
         * that i.e. a lambda return type is compatible with the expected
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2780
         * type according to both the inherited context and the assignment
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2781
         * context.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2782
         */
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2783
        class FunctionalReturnContext extends Check.NestedCheckContext {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2784
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2785
            FunctionalReturnContext(CheckContext enclosingContext) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2786
                super(enclosingContext);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2787
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2788
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2789
            @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2790
            public boolean compatible(Type found, Type req, Warner warn) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2791
                //return type must be compatible in both current context and assignment context
38538
8bdc63ff6961 8157149: Inference: weird propagation of thrown inference variables
mcimadamore
parents: 38508
diff changeset
  2792
                return chk.basicHandler.compatible(inferenceContext().asUndetVar(found), inferenceContext().asUndetVar(req), warn);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2793
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2794
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2795
            @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2796
            public void report(DiagnosticPosition pos, JCDiagnostic details) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2797
                enclosingContext.report(pos, diags.fragment(Fragments.IncompatibleRetTypeInLambda(details)));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2798
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2799
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2800
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2801
        class ExpressionLambdaReturnContext extends FunctionalReturnContext {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2802
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2803
            JCExpression expr;
38508
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2804
            boolean expStmtExpected;
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2805
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2806
            ExpressionLambdaReturnContext(JCExpression expr, CheckContext enclosingContext) {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2807
                super(enclosingContext);
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2808
                this.expr = expr;
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2809
            }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2810
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2811
            @Override
38508
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2812
            public void report(DiagnosticPosition pos, JCDiagnostic details) {
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2813
                if (expStmtExpected) {
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2814
                    enclosingContext.report(pos, diags.fragment(Fragments.StatExprExpected));
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2815
                } else {
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2816
                    super.report(pos, details);
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2817
                }
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2818
            }
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2819
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2820
            @Override
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2821
            public boolean compatible(Type found, Type req, Warner warn) {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2822
                //a void return is compatible with an expression statement lambda
38508
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2823
                if (req.hasTag(VOID)) {
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2824
                    expStmtExpected = true;
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2825
                    return TreeInfo.isExpressionStatement(expr);
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2826
                } else {
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2827
                    return super.compatible(found, req, warn);
03c87ceca5fd 8153884: Expression lambda erroneously compatible with void-returning descriptor
mcimadamore
parents: 37634
diff changeset
  2828
                }
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2829
            }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2830
        }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2831
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2832
        ResultInfo lambdaBodyResult(JCLambda that, Type descriptor, ResultInfo resultInfo) {
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2833
            FunctionalReturnContext funcContext = that.getBodyKind() == JCLambda.BodyKind.EXPRESSION ?
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2834
                    new ExpressionLambdaReturnContext((JCExpression)that.getBody(), resultInfo.checkContext) :
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2835
                    new FunctionalReturnContext(resultInfo.checkContext);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2836
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2837
            return descriptor.getReturnType() == Type.recoveryType ?
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2838
                    recoveryInfo :
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2839
                    new ResultInfo(KindSelector.VAL,
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2840
                            descriptor.getReturnType(), funcContext);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2841
        }
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2842
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2843
        /**
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2844
        * Lambda compatibility. Check that given return types, thrown types, parameter types
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2845
        * are compatible with the expected functional interface descriptor. This means that:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2846
        * (i) parameter types must be identical to those of the target descriptor; (ii) return
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2847
        * types must be compatible with the return type of the expected descriptor.
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2848
        */
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2849
        void checkLambdaCompatible(JCLambda tree, Type descriptor, CheckContext checkContext) {
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2850
            Type returnType = checkContext.inferenceContext().asUndetVar(descriptor.getReturnType());
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2851
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2852
            //return values have already been checked - but if lambda has no return
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2853
            //values, we must ensure that void/value compatibility is correct;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2854
            //this amounts at checking that, if a lambda body can complete normally,
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2855
            //the descriptor's return type must be void
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2856
            if (tree.getBodyKind() == JCLambda.BodyKind.STATEMENT && tree.canCompleteNormally &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2857
                    !returnType.hasTag(VOID) && returnType != Type.recoveryType) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2858
                Fragment msg =
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2859
                        Fragments.IncompatibleRetTypeInLambda(Fragments.MissingRetVal(returnType));
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2860
                checkContext.report(tree,
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2861
                                    diags.fragment(msg));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2862
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2863
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2864
            List<Type> argTypes = checkContext.inferenceContext().asUndetVars(descriptor.getParameterTypes());
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2865
            if (!types.isSameTypes(argTypes, TreeInfo.types(tree.params))) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2866
                checkContext.report(tree, diags.fragment(Fragments.IncompatibleArgTypesInLambda));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2867
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2868
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2869
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2870
        /* Map to hold 'fake' clinit methods. If a lambda is used to initialize a
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2871
         * static field and that lambda has type annotations, these annotations will
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2872
         * also be stored at these fake clinit methods.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2873
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2874
         * LambdaToMethod also use fake clinit methods so they can be reused.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2875
         * Also as LTM is a phase subsequent to attribution, the methods from
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2876
         * clinits can be safely removed by LTM to save memory.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2877
         */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2878
        private Map<ClassSymbol, MethodSymbol> clinits = new HashMap<>();
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2879
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2880
        public MethodSymbol removeClinit(ClassSymbol sym) {
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2881
            return clinits.remove(sym);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2882
        }
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2883
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2884
        /* This method returns an environment to be used to attribute a lambda
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2885
         * expression.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2886
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2887
         * The owner of this environment is a method symbol. If the current owner
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2888
         * is not a method, for example if the lambda is used to initialize
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2889
         * a field, then if the field is:
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2890
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2891
         * - an instance field, we use the first constructor.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2892
         * - a static field, we create a fake clinit method.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2893
         */
24066
1dfb66929538 8029718: Should always use lambda body structure to disambiguate overload resolution
vromero
parents: 23969
diff changeset
  2894
        public Env<AttrContext> lambdaEnv(JCLambda that, Env<AttrContext> env) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2895
            Env<AttrContext> lambdaEnv;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2896
            Symbol owner = env.info.scope.owner;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2897
            if (owner.kind == VAR && owner.owner.kind == TYP) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2898
                //field initializer
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2899
                ClassSymbol enclClass = owner.enclClass();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2900
                Symbol newScopeOwner = env.info.scope.owner;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2901
                /* if the field isn't static, then we can get the first constructor
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2902
                 * and use it as the owner of the environment. This is what
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2903
                 * LTM code is doing to look for type annotations so we are fine.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2904
                 */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2905
                if ((owner.flags() & STATIC) == 0) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2906
                    for (Symbol s : enclClass.members_field.getSymbolsByName(names.init)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2907
                        newScopeOwner = s;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2908
                        break;
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2909
                    }
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2910
                } else {
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2911
                    /* if the field is static then we need to create a fake clinit
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2912
                     * method, this method can later be reused by LTM.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2913
                     */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2914
                    MethodSymbol clinit = clinits.get(enclClass);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2915
                    if (clinit == null) {
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2916
                        Type clinitType = new MethodType(List.nil(),
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2917
                                syms.voidType, List.nil(), syms.methodClass);
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2918
                        clinit = new MethodSymbol(STATIC | SYNTHETIC | PRIVATE,
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2919
                                names.clinit, clinitType, enclClass);
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  2920
                        clinit.params = List.nil();
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2921
                        clinits.put(enclClass, clinit);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2922
                    }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2923
                    newScopeOwner = clinit;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2924
                }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2925
                lambdaEnv = env.dup(that, env.info.dup(env.info.scope.dupUnshared(newScopeOwner)));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2926
            } else {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2927
                lambdaEnv = env.dup(that, env.info.dup(env.info.scope.dup()));
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2928
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2929
            return lambdaEnv;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2930
        }
11144
8a4ae514eedf 7115052: Add parser support for method references
mcimadamore
parents: 11143
diff changeset
  2931
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2932
    @Override
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2933
    public void visitReference(final JCMemberReference that) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2934
        if (pt().isErroneous() || (pt().hasTag(NONE) && pt() != Type.recoveryType)) {
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  2935
            if (pt().hasTag(NONE) && (env.info.enclVar == null || !env.info.enclVar.type.isErroneous())) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2936
                //method reference only allowed in assignment or method invocation/cast context
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2937
                log.error(that.pos(), Errors.UnexpectedMref);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2938
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2939
            result = that.type = types.createErrorType(pt());
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2940
            return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2941
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2942
        final Env<AttrContext> localEnv = env.dup(that);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2943
        try {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2944
            //attribute member reference qualifier - if this is a constructor
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2945
            //reference, the expected kind must be a type
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2946
            Type exprType = attribTree(that.expr, env, memberReferenceQualifierResult(that));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2947
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2948
            if (that.getMode() == JCMemberReference.ReferenceMode.NEW) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2949
                exprType = chk.checkConstructorRefType(that.expr, exprType);
19918
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2950
                if (!exprType.isErroneous() &&
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2951
                    exprType.isRaw() &&
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2952
                    that.typeargs != null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2953
                    log.error(that.expr.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2954
                              Errors.InvalidMref(Kinds.kindName(that.getMode()),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  2955
                                                 Fragments.MrefInferAndExplicitParams));
19918
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2956
                    exprType = types.createErrorType(exprType);
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2957
                }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2958
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2959
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2960
            if (exprType.isErroneous()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2961
                //if the qualifier expression contains problems,
15718
8e54c8e43d38 8008077: update reference impl for type-annotations
jjg
parents: 15717
diff changeset
  2962
                //give up attribution of method reference
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2963
                result = that.type = exprType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2964
                return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2965
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2966
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2967
            if (TreeInfo.isStaticSelector(that.expr, names)) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2968
                //if the qualifier is a type, validate it; raw warning check is
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2969
                //omitted as we don't know at this stage as to whether this is a
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2970
                //raw selector (because of inference)
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2971
                chk.validate(that.expr, env, false);
33363
f03a03067799 8139836: Can't use super::x method reference when x is protected
sadayapalam
parents: 32950
diff changeset
  2972
            } else {
f03a03067799 8139836: Can't use super::x method reference when x is protected
sadayapalam
parents: 32950
diff changeset
  2973
                Symbol lhsSym = TreeInfo.symbol(that.expr);
f03a03067799 8139836: Can't use super::x method reference when x is protected
sadayapalam
parents: 32950
diff changeset
  2974
                localEnv.info.selectSuper = lhsSym != null && lhsSym.name == names._super;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2975
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2976
            //attrib type-arguments
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2977
            List<Type> typeargtypes = List.nil();
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2978
            if (that.typeargs != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2979
                typeargtypes = attribTypes(that.typeargs, localEnv);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2980
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2981
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2982
            boolean isTargetSerializable =
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2983
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2984
                    isSerializable(pt());
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2985
            TargetInfo targetInfo = getTargetInfo(that, resultInfo, null);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2986
            Type currentTarget = targetInfo.target;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  2987
            Type desc = targetInfo.descriptor;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2988
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2989
            setFunctionalInfo(localEnv, that, pt(), desc, currentTarget, resultInfo.checkContext);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2990
            List<Type> argtypes = desc.getParameterTypes();
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2991
            Resolve.MethodCheck referenceCheck = rs.resolveMethodCheck;
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2992
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2993
            if (resultInfo.checkContext.inferenceContext().free(argtypes)) {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2994
                referenceCheck = rs.new MethodReferenceCheck(resultInfo.checkContext.inferenceContext());
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2995
            }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2996
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2997
            Pair<Symbol, Resolve.ReferenceLookupHelper> refResult = null;
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2998
            List<Type> saved_undet = resultInfo.checkContext.inferenceContext().save();
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2999
            try {
21718
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  3000
                refResult = rs.resolveMemberReference(localEnv, that, that.expr.type,
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  3001
                        that.name, argtypes, typeargtypes, referenceCheck,
28456
b87fdde1404d 8068995: Cleanup method reference lookup code
mcimadamore
parents: 28336
diff changeset
  3002
                        resultInfo.checkContext.inferenceContext(), rs.basicReferenceChooser);
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3003
            } finally {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3004
                resultInfo.checkContext.inferenceContext().rollback(saved_undet);
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3005
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3006
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3007
            Symbol refSym = refResult.fst;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3008
            Resolve.ReferenceLookupHelper lookupHelper = refResult.snd;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3009
29774
9d438163db79 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
vromero
parents: 29554
diff changeset
  3010
            /** this switch will need to go away and be replaced by the new RESOLUTION_TARGET testing
9d438163db79 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
vromero
parents: 29554
diff changeset
  3011
             *  JDK-8075541
9d438163db79 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
vromero
parents: 29554
diff changeset
  3012
             */
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3013
            if (refSym.kind != MTH) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3014
                boolean targetError;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3015
                switch (refSym.kind) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3016
                    case ABSENT_MTH:
29774
9d438163db79 8075184: javac is mistakenly considering an missing enclosing instance error as an overload error
vromero
parents: 29554
diff changeset
  3017
                    case MISSING_ENCL:
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3018
                        targetError = false;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3019
                        break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3020
                    case WRONG_MTH:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3021
                    case WRONG_MTHS:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3022
                    case AMBIGUOUS:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3023
                    case HIDDEN:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3024
                    case STATICERR:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3025
                        targetError = true;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3026
                        break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3027
                    default:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3028
                        Assert.error("unexpected result kind " + refSym.kind);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3029
                        targetError = false;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3030
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3031
24400
f05df7f58567 8037379: fix for JDK-8029569 doesn't cover all possible cases
vromero
parents: 24396
diff changeset
  3032
                JCDiagnostic detailsDiag = ((Resolve.ResolveError)refSym.baseSymbol()).getDiagnostic(JCDiagnostic.DiagnosticType.FRAGMENT,
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3033
                                that, exprType.tsym, exprType, that.name, argtypes, typeargtypes);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3034
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3035
                JCDiagnostic.DiagnosticType diagKind = targetError ?
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3036
                        JCDiagnostic.DiagnosticType.FRAGMENT : JCDiagnostic.DiagnosticType.ERROR;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3037
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3038
                JCDiagnostic diag = diags.create(diagKind, log.currentSource(), that,
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3039
                        "invalid.mref", Kinds.kindName(that.getMode()), detailsDiag);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3040
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3041
                if (targetError && currentTarget == Type.recoveryType) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3042
                    //a target error doesn't make sense during recovery stage
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3043
                    //as we don't know what actual parameter types are
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3044
                    result = that.type = currentTarget;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3045
                    return;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3046
                } else {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3047
                    if (targetError) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3048
                        resultInfo.checkContext.report(that, diag);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3049
                    } else {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3050
                        log.report(diag);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3051
                    }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3052
                    result = that.type = types.createErrorType(currentTarget);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3053
                    return;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3054
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3055
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3056
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3057
            that.sym = refSym.baseSymbol();
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3058
            that.kind = lookupHelper.referenceKind(that.sym);
16328
8b9eb42167f6 8009129: Illegal access error when calling method reference
mcimadamore
parents: 16323
diff changeset
  3059
            that.ownerAccessible = rs.isAccessible(localEnv, that.sym.enclClass());
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3060
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3061
            if (desc.getReturnType() == Type.recoveryType) {
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3062
                // stop here
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3063
                result = that.type = currentTarget;
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3064
                return;
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3065
            }
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3066
43582
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3067
            if (!env.info.isSpeculative && that.getMode() == JCMemberReference.ReferenceMode.NEW) {
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3068
                Type enclosingType = exprType.getEnclosingType();
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3069
                if (enclosingType != null && enclosingType.hasTag(CLASS)) {
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3070
                    // Check for the existence of an apropriate outer instance
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3071
                    rs.resolveImplicitThis(that.pos(), env, exprType);
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3072
                }
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3073
            }
a6c58d4cb05b 8173456: com.sun.tools.javac.util.Assert.error during code compilation
sadayapalam
parents: 43138
diff changeset
  3074
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3075
            if (resultInfo.checkContext.deferredAttrContext().mode == AttrMode.CHECK) {
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  3076
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3077
                if (that.getMode() == ReferenceMode.INVOKE &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3078
                        TreeInfo.isStaticSelector(that.expr, names) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3079
                        that.kind.isUnbound() &&
47315
31f541df4187 8063054: Incorrect raw type warning for method reference
mcimadamore
parents: 47268
diff changeset
  3080
                        lookupHelper.site.isRaw()) {
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3081
                    chk.checkRaw(that.expr, localEnv);
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3082
                }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  3083
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3084
                if (that.sym.isStatic() && TreeInfo.isStaticSelector(that.expr, names) &&
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3085
                        exprType.getTypeArguments().nonEmpty()) {
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3086
                    //static ref with class type-args
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3087
                    log.error(that.expr.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3088
                              Errors.InvalidMref(Kinds.kindName(that.getMode()),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3089
                                                 Fragments.StaticMrefWithTargs));
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3090
                    result = that.type = types.createErrorType(currentTarget);
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3091
                    return;
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3092
                }
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3093
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3094
                if (!refSym.isStatic() && that.kind == JCMemberReference.ReferenceKind.SUPER) {
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3095
                    // Check that super-qualified symbols are not abstract (JLS)
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3096
                    rs.checkNonAbstract(that.pos(), that.sym);
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  3097
                }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3098
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3099
                if (isTargetSerializable) {
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  3100
                    chk.checkAccessFromSerializableElement(that, true);
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3101
                }
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3102
            }
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  3103
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3104
            ResultInfo checkInfo =
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3105
                    resultInfo.dup(newMethodTemplate(
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3106
                        desc.getReturnType().hasTag(VOID) ? Type.noType : desc.getReturnType(),
24401
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
  3107
                        that.kind.isUnbound() ? argtypes.tail : argtypes, typeargtypes),
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  3108
                        new FunctionalReturnContext(resultInfo.checkContext), CheckMode.NO_TREE_UPDATE);
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  3109
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  3110
            Type refType = checkId(that, lookupHelper.site, refSym, localEnv, checkInfo);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3111
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3112
            if (that.kind.isUnbound() &&
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3113
                    resultInfo.checkContext.inferenceContext().free(argtypes.head)) {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3114
                //re-generate inference constraints for unbound receiver
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  3115
                if (!types.isSubtype(resultInfo.checkContext.inferenceContext().asUndetVar(argtypes.head), exprType)) {
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3116
                    //cannot happen as this has already been checked - we just need
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3117
                    //to regenerate the inference constraints, as that has been lost
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3118
                    //as a result of the call to inferenceContext.save()
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3119
                    Assert.error("Can't get here");
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3120
                }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3121
            }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  3122
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3123
            if (!refType.isErroneous()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3124
                refType = types.createMethodTypeWithReturn(refType,
39810
d290bef927c4 8161985: Spurious override of Object.getClass leads to NPE
mcimadamore
parents: 38829
diff changeset
  3125
                        adjustMethodReturnType(refSym, lookupHelper.site, that.name, checkInfo.pt.getParameterTypes(), refType.getReturnType()));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3126
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3127
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3128
            //go ahead with standard method reference compatibility check - note that param check
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3129
            //is a no-op (as this has been taken care during method applicability)
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3130
            boolean isSpeculativeRound =
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3131
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE;
28148
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  3132
6415a95b07fd 8066974: Compiler doesn't infer method's generic type information in lambda body
mcimadamore
parents: 28142
diff changeset
  3133
            that.type = currentTarget; //avoids recovery at this stage
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3134
            checkReferenceCompatible(that, desc, refType, resultInfo.checkContext, isSpeculativeRound);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3135
            if (!isSpeculativeRound) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3136
                checkAccessibleTypes(that, localEnv, resultInfo.checkContext.inferenceContext(), desc, currentTarget);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3137
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3138
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3139
        } catch (Types.FunctionDescriptorLookupError ex) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3140
            JCDiagnostic cause = ex.getDiagnostic();
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3141
            resultInfo.checkContext.report(that, cause);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3142
            result = that.type = types.createErrorType(pt());
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3143
            return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3144
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3145
    }
16294
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  3146
    //where
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  3147
        ResultInfo memberReferenceQualifierResult(JCMemberReference tree) {
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  3148
            //if this is a constructor reference, the expected kind must be a type
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3149
            return new ResultInfo(tree.getMode() == ReferenceMode.INVOKE ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3150
                                  KindSelector.VAL_TYP : KindSelector.TYP,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3151
                                  Type.noType);
16294
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  3152
        }
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  3153
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3154
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3155
    @SuppressWarnings("fallthrough")
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3156
    void checkReferenceCompatible(JCMemberReference tree, Type descriptor, Type refType, CheckContext checkContext, boolean speculativeAttr) {
28591
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3157
        InferenceContext inferenceContext = checkContext.inferenceContext();
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3158
        Type returnType = inferenceContext.asUndetVar(descriptor.getReturnType());
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3159
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3160
        Type resType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3161
        switch (tree.getMode()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3162
            case NEW:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3163
                if (!tree.expr.type.isRaw()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3164
                    resType = tree.expr.type;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3165
                    break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3166
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3167
            default:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3168
                resType = refType.getReturnType();
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3169
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3170
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3171
        Type incompatibleReturnType = resType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3172
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3173
        if (returnType.hasTag(VOID)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3174
            incompatibleReturnType = null;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3175
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3176
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3177
        if (!returnType.hasTag(VOID) && !resType.hasTag(VOID)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3178
            if (resType.isErroneous() ||
44184
606c14ee20ed 8175317: javac does not issue unchecked warnings when checking method reference return types
mcimadamore
parents: 44060
diff changeset
  3179
                    new FunctionalReturnContext(checkContext).compatible(resType, returnType,
606c14ee20ed 8175317: javac does not issue unchecked warnings when checking method reference return types
mcimadamore
parents: 44060
diff changeset
  3180
                            checkContext.checkWarner(tree, resType, returnType))) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3181
                incompatibleReturnType = null;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3182
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3183
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3184
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3185
        if (incompatibleReturnType != null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3186
            Fragment msg =
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3187
                    Fragments.IncompatibleRetTypeInMref(Fragments.InconvertibleTypes(resType, descriptor.getReturnType()));
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3188
            checkContext.report(tree, diags.fragment(msg));
28591
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3189
        } else {
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3190
            if (inferenceContext.free(refType)) {
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3191
                // we need to wait for inference to finish and then replace inference vars in the referent type
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3192
                inferenceContext.addFreeTypeListener(List.of(refType),
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3193
                        instantiatedContext -> {
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3194
                            tree.referentType = instantiatedContext.asInstType(refType);
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3195
                        });
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3196
            } else {
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3197
                tree.referentType = refType;
25f1384324ae 8046977: ClassCastException: typing information needed for method reference bridging not preserved
jfranck
parents: 28459
diff changeset
  3198
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3199
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3200
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3201
        if (!speculativeAttr) {
45756
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3202
            if (!checkExConstraints(refType.getThrownTypes(), descriptor.getThrownTypes(), inferenceContext)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3203
                log.error(tree, Errors.IncompatibleThrownTypesInMref(refType.getThrownTypes()));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3204
            }
45756
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3205
        }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3206
    }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3207
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3208
    boolean checkExConstraints(
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3209
            List<Type> thrownByFuncExpr,
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3210
            List<Type> thrownAtFuncType,
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3211
            InferenceContext inferenceContext) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3212
        /** 18.2.5: Otherwise, let E1, ..., En be the types in the function type's throws clause that
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3213
         *  are not proper types
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3214
         */
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3215
        List<Type> nonProperList = thrownAtFuncType.stream()
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3216
                .filter(e -> inferenceContext.free(e)).collect(List.collector());
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3217
        List<Type> properList = thrownAtFuncType.diff(nonProperList);
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3218
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3219
        /** Let X1,...,Xm be the checked exception types that the lambda body can throw or
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3220
         *  in the throws clause of the invocation type of the method reference's compile-time
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3221
         *  declaration
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3222
         */
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3223
        List<Type> checkedList = thrownByFuncExpr.stream()
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3224
                .filter(e -> chk.isChecked(e)).collect(List.collector());
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3225
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3226
        /** If n = 0 (the function type's throws clause consists only of proper types), then
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3227
         *  if there exists some i (1 <= i <= m) such that Xi is not a subtype of any proper type
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3228
         *  in the throws clause, the constraint reduces to false; otherwise, the constraint
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3229
         *  reduces to true
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3230
         */
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3231
        ListBuffer<Type> uncaughtByProperTypes = new ListBuffer<>();
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3232
        for (Type checked : checkedList) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3233
            boolean isSubtype = false;
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3234
            for (Type proper : properList) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3235
                if (types.isSubtype(checked, proper)) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3236
                    isSubtype = true;
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3237
                    break;
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3238
                }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3239
            }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3240
            if (!isSubtype) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3241
                uncaughtByProperTypes.add(checked);
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3242
            }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3243
        }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3244
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3245
        if (nonProperList.isEmpty() && !uncaughtByProperTypes.isEmpty()) {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3246
            return false;
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3247
        }
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3248
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3249
        /** If n > 0, the constraint reduces to a set of subtyping constraints:
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3250
         *  for all i (1 <= i <= m), if Xi is not a subtype of any proper type in the
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3251
         *  throws clause, then the constraints include, for all j (1 <= j <= n), <Xi <: Ej>
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3252
         */
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3253
        List<Type> nonProperAsUndet = inferenceContext.asUndetVars(nonProperList);
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3254
        uncaughtByProperTypes.forEach(checkedEx -> {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3255
            nonProperAsUndet.forEach(nonProper -> {
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3256
                types.isSubtype(checkedEx, nonProper);
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3257
            });
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3258
        });
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3259
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3260
        /** In addition, for all j (1 <= j <= n), the constraint reduces to the bound throws Ej
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3261
         */
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3262
        nonProperAsUndet.stream()
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3263
                .filter(t -> t.hasTag(UNDETVAR))
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3264
                .forEach(t -> ((UndetVar)t).setThrow());
67f4f8f4d34a 8182047: javac compile error on type-parameter-exceptions in lambda expressions
vromero
parents: 45750
diff changeset
  3265
        return true;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3266
    }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3267
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3268
    /**
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3269
     * Set functional type info on the underlying AST. Note: as the target descriptor
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3270
     * might contain inference variables, we might need to register an hook in the
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3271
     * current inference context.
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3272
     */
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3273
    private void setFunctionalInfo(final Env<AttrContext> env, final JCFunctionalExpression fExpr,
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3274
            final Type pt, final Type descriptorType, final Type primaryTarget, final CheckContext checkContext) {
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3275
        if (checkContext.inferenceContext().free(descriptorType)) {
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3276
            checkContext.inferenceContext().addFreeTypeListener(List.of(pt, descriptorType),
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3277
                    inferenceContext -> setFunctionalInfo(env, fExpr, pt, inferenceContext.asInstType(descriptorType),
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  3278
                    inferenceContext.asInstType(primaryTarget), checkContext));
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3279
        } else {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  3280
            ListBuffer<Type> targets = new ListBuffer<>();
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3281
            if (pt.hasTag(CLASS)) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3282
                if (pt.isCompound()) {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3283
                    targets.append(types.removeWildcards(primaryTarget)); //this goes first
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3284
                    for (Type t : ((IntersectionClassType)pt()).interfaces_field) {
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  3285
                        if (t != primaryTarget) {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3286
                            targets.append(types.removeWildcards(t));
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  3287
                        }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3288
                    }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3289
                } else {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3290
                    targets.append(types.removeWildcards(primaryTarget));
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3291
                }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3292
            }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3293
            fExpr.targets = targets.toList();
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3294
            if (checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3295
                    pt != Type.recoveryType) {
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3296
                //check that functional interface class is well-formed
25273
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3297
                try {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3298
                    /* Types.makeFunctionalInterfaceClass() may throw an exception
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3299
                     * when it's executed post-inference. See the listener code
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3300
                     * above.
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3301
                     */
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3302
                    ClassSymbol csym = types.makeFunctionalInterfaceClass(env,
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3303
                            names.empty, List.of(fExpr.targets.head), ABSTRACT);
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3304
                    if (csym != null) {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3305
                        chk.checkImplementations(env.tree, csym, csym);
29553
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3306
                        try {
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3307
                            //perform an additional functional interface check on the synthetic class,
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3308
                            //as there may be spurious errors for raw targets - because of existing issues
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3309
                            //with membership and inheritance (see JDK-8074570).
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3310
                            csym.flags_field |= INTERFACE;
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3311
                            types.findDescriptorType(csym.type);
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3312
                        } catch (FunctionDescriptorLookupError err) {
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3313
                            resultInfo.checkContext.report(fExpr,
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3314
                                    diags.fragment(Fragments.NoSuitableFunctionalIntfInst(fExpr.targets.head)));
716d47f5a45e 8074381: java.lang.AssertionError during compiling
mcimadamore
parents: 29552
diff changeset
  3315
                        }
25273
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3316
                    }
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3317
                } catch (Types.FunctionDescriptorLookupError ex) {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3318
                    JCDiagnostic cause = ex.getDiagnostic();
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  3319
                    resultInfo.checkContext.report(env.tree, cause);
19127
8a0cbd5cb055 8020804: javac crashes when speculative attribution infers intersection type with array component
mcimadamore
parents: 19122
diff changeset
  3320
                }
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  3321
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3322
        }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3323
    }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  3324
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3325
    public void visitParens(JCParens tree) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3326
        Type owntype = attribTree(tree.expr, env, resultInfo);
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3327
        result = check(tree, owntype, pkind(), resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3328
        Symbol sym = TreeInfo.symbol(tree);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3329
        if (sym != null && sym.kind.matches(KindSelector.TYP_PCK))
45750
15404afd36ab 8058408: Compiler should emit a clearer message for invalid parenthesized expression
sadayapalam
parents: 45605
diff changeset
  3330
            log.error(tree.pos(), Errors.IllegalParenthesizedExpression);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3331
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3332
06bc494ca11e Initial load
duke
parents:
diff changeset
  3333
    public void visitAssign(JCAssign tree) {
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3334
        Type owntype = attribTree(tree.lhs, env.dup(tree), varAssignmentInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3335
        Type capturedType = capture(owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3336
        attribExpr(tree.rhs, env, owntype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3337
        result = check(tree, capturedType, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3338
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3339
06bc494ca11e Initial load
duke
parents:
diff changeset
  3340
    public void visitAssignop(JCAssignOp tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3341
        // Attribute arguments.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3342
        Type owntype = attribTree(tree.lhs, env, varAssignmentInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3343
        Type operand = attribExpr(tree.rhs, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3344
        // Find operator.
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  3345
        Symbol operator = tree.operator = operators.resolveBinary(tree, tree.getTag().noAssignOp(), owntype, operand);
39920
4923274643f2 8161708: javac, consider a different way to handle access code for operators
vromero
parents: 39810
diff changeset
  3346
        if (operator != operators.noOpSymbol &&
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3347
                !owntype.isErroneous() &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3348
                !operand.isErroneous()) {
166
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  3349
            chk.checkDivZero(tree.rhs.pos(), operator, operand);
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  3350
            chk.checkCastable(tree.rhs.pos(),
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  3351
                              operator.type.getReturnType(),
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  3352
                              owntype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3353
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3354
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3355
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3356
06bc494ca11e Initial load
duke
parents:
diff changeset
  3357
    public void visitUnary(JCUnary tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3358
        // Attribute arguments.
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  3359
        Type argtype = (tree.getTag().isIncOrDecUnaryOp())
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3360
            ? attribTree(tree.arg, env, varAssignmentInfo)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3361
            : chk.checkNonVoid(tree.arg.pos(), attribExpr(tree.arg, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3362
06bc494ca11e Initial load
duke
parents:
diff changeset
  3363
        // Find operator.
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  3364
        Symbol operator = tree.operator = operators.resolveUnary(tree, tree.getTag(), argtype);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3365
        Type owntype = types.createErrorType(tree.type);
39920
4923274643f2 8161708: javac, consider a different way to handle access code for operators
vromero
parents: 39810
diff changeset
  3366
        if (operator != operators.noOpSymbol &&
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3367
                !argtype.isErroneous()) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  3368
            owntype = (tree.getTag().isIncOrDecUnaryOp())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3369
                ? tree.arg.type
06bc494ca11e Initial load
duke
parents:
diff changeset
  3370
                : operator.type.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3371
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3372
06bc494ca11e Initial load
duke
parents:
diff changeset
  3373
            // If the argument is constant, fold it.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3374
            if (argtype.constValue() != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3375
                Type ctype = cfolder.fold1(opc, argtype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3376
                if (ctype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3377
                    owntype = cfolder.coerce(ctype, owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3378
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3379
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3380
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3381
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3382
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3383
06bc494ca11e Initial load
duke
parents:
diff changeset
  3384
    public void visitBinary(JCBinary tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3385
        // Attribute arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3386
        Type left = chk.checkNonVoid(tree.lhs.pos(), attribExpr(tree.lhs, env));
29552
690d0becaf32 8074148: Attr.visitBinary flags error at wrong position
sadayapalam
parents: 29430
diff changeset
  3387
        Type right = chk.checkNonVoid(tree.rhs.pos(), attribExpr(tree.rhs, env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3388
        // Find operator.
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  3389
        Symbol operator = tree.operator = operators.resolveBinary(tree, tree.getTag(), left, right);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3390
        Type owntype = types.createErrorType(tree.type);
39920
4923274643f2 8161708: javac, consider a different way to handle access code for operators
vromero
parents: 39810
diff changeset
  3391
        if (operator != operators.noOpSymbol &&
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3392
                !left.isErroneous() &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3393
                !right.isErroneous()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3394
            owntype = operator.type.getReturnType();
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  3395
            int opc = ((OperatorSymbol)operator).opcode;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3396
            // If both arguments are constants, fold them.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3397
            if (left.constValue() != null && right.constValue() != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3398
                Type ctype = cfolder.fold2(opc, left, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3399
                if (ctype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3400
                    owntype = cfolder.coerce(ctype, owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3401
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3402
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3403
06bc494ca11e Initial load
duke
parents:
diff changeset
  3404
            // Check that argument types of a reference ==, != are
18662
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3405
            // castable to each other, (JLS 15.21).  Note: unboxing
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3406
            // comparisons will not have an acmp* opc at this point.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3407
            if ((opc == ByteCodes.if_acmpeq || opc == ByteCodes.if_acmpne)) {
29051
7244db2ab176 8071241: Investigate alternate strategy for type-checking operators
mcimadamore
parents: 28591
diff changeset
  3408
                if (!types.isCastable(left, right, new Warner(tree.pos()))) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3409
                    log.error(tree.pos(), Errors.IncomparableTypes(left, right));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3410
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3411
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3412
06bc494ca11e Initial load
duke
parents:
diff changeset
  3413
            chk.checkDivZero(tree.rhs.pos(), operator, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3414
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3415
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3416
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3417
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3418
    public void visitTypeCast(final JCTypeCast tree) {
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3419
        Type clazztype = attribType(tree.clazz, env);
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  3420
        chk.validate(tree.clazz, env, false);
6592
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3421
        //a fresh environment is required for 292 inference to work properly ---
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3422
        //see Infer.instantiatePolymorphicSignatureInstance()
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3423
        Env<AttrContext> localEnv = env.dup(tree);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3424
        //should we propagate the target type?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3425
        final ResultInfo castInfo;
16975
124c8436d59c 8010923: Avoid redundant speculative attribution
mcimadamore
parents: 16972
diff changeset
  3426
        JCExpression expr = TreeInfo.skipParens(tree.expr);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3427
        boolean isPoly = allowPoly && (expr.hasTag(LAMBDA) || expr.hasTag(REFERENCE));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3428
        if (isPoly) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3429
            //expression is a poly - we need to propagate target type info
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3430
            castInfo = new ResultInfo(KindSelector.VAL, clazztype,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3431
                                      new Check.NestedCheckContext(resultInfo.checkContext) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3432
                @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3433
                public boolean compatible(Type found, Type req, Warner warn) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3434
                    return types.isCastable(found, req, warn);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3435
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3436
            });
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3437
        } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3438
            //standalone cast - target-type info is not propagated
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3439
            castInfo = unknownExprInfo;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3440
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3441
        Type exprtype = attribTree(tree.expr, localEnv, castInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3442
        Type owntype = isPoly ? clazztype : chk.checkCastable(tree.expr.pos(), exprtype, clazztype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3443
        if (exprtype.constValue() != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3444
            owntype = cfolder.coerce(exprtype, owntype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3445
        result = check(tree, capture(owntype), KindSelector.VAL, resultInfo);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3446
        if (!isPoly)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3447
            chk.checkRedundantCast(localEnv, tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3448
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3449
06bc494ca11e Initial load
duke
parents:
diff changeset
  3450
    public void visitTypeTest(JCInstanceOf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3451
        Type exprtype = chk.checkNullOrRefType(
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3452
                tree.expr.pos(), attribExpr(tree.expr, env));
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3453
        Type clazztype = attribType(tree.clazz, env);
20251
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3454
        if (!clazztype.hasTag(TYPEVAR)) {
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3455
            clazztype = chk.checkClassOrArrayType(tree.clazz.pos(), clazztype);
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3456
        }
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3457
        if (!clazztype.isErroneous() && !types.isReifiable(clazztype)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3458
            log.error(tree.clazz.pos(), Errors.IllegalGenericTypeForInstof);
20251
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3459
            clazztype = types.createErrorType(clazztype);
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3460
        }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  3461
        chk.validate(tree.clazz, env, false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3462
        chk.checkCastable(tree.expr.pos(), exprtype, clazztype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3463
        result = check(tree, syms.booleanType, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3464
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3465
06bc494ca11e Initial load
duke
parents:
diff changeset
  3466
    public void visitIndexed(JCArrayAccess tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3467
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3468
        Type atype = attribExpr(tree.indexed, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3469
        attribExpr(tree.index, env, syms.intType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3470
        if (types.isArray(atype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3471
            owntype = types.elemtype(atype);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3472
        else if (!atype.hasTag(ERROR))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3473
            log.error(tree.pos(), Errors.ArrayReqButFound(atype));
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3474
        if (!pkind().contains(KindSelector.VAL))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3475
            owntype = capture(owntype);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3476
        result = check(tree, owntype, KindSelector.VAR, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3477
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3478
06bc494ca11e Initial load
duke
parents:
diff changeset
  3479
    public void visitIdent(JCIdent tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3480
        Symbol sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3481
06bc494ca11e Initial load
duke
parents:
diff changeset
  3482
        // Find symbol
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3483
        if (pt().hasTag(METHOD) || pt().hasTag(FORALL)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3484
            // If we are looking for a method, the prototype `pt' will be a
06bc494ca11e Initial load
duke
parents:
diff changeset
  3485
            // method type with the type of the call's arguments as parameters.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3486
            env.info.pendingResolutionPhase = null;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3487
            sym = rs.resolveMethod(tree.pos(), env, tree.name, pt().getParameterTypes(), pt().getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3488
        } else if (tree.sym != null && tree.sym.kind != VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3489
            sym = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3490
        } else {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3491
            sym = rs.resolveIdent(tree.pos(), env, tree.name, pkind());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3492
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3493
        tree.sym = sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3494
06bc494ca11e Initial load
duke
parents:
diff changeset
  3495
        // (1) Also find the environment current for the class where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3496
        //     sym is defined (`symEnv').
06bc494ca11e Initial load
duke
parents:
diff changeset
  3497
        // Only for pre-tiger versions (1.4 and earlier):
06bc494ca11e Initial load
duke
parents:
diff changeset
  3498
        // (2) Also determine whether we access symbol out of an anonymous
06bc494ca11e Initial load
duke
parents:
diff changeset
  3499
        //     class in a this or super call.  This is illegal for instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  3500
        //     members since such classes don't carry a this$n link.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3501
        //     (`noOuterThisPath').
06bc494ca11e Initial load
duke
parents:
diff changeset
  3502
        Env<AttrContext> symEnv = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3503
        boolean noOuterThisPath = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3504
        if (env.enclClass.sym.owner.kind != PCK && // we are in an inner class
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3505
            sym.kind.matches(KindSelector.VAL_MTH) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3506
            sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3507
            tree.name != names._this && tree.name != names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3508
06bc494ca11e Initial load
duke
parents:
diff changeset
  3509
            // Find environment in which identifier is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3510
            while (symEnv.outer != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3511
                   !sym.isMemberOf(symEnv.enclClass.sym, types)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3512
                if ((symEnv.enclClass.sym.flags() & NOOUTERTHIS) != 0)
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3513
                    noOuterThisPath = false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3514
                symEnv = symEnv.outer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3515
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3516
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3517
06bc494ca11e Initial load
duke
parents:
diff changeset
  3518
        // If symbol is a variable, ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3519
        if (sym.kind == VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3520
            VarSymbol v = (VarSymbol)sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3521
06bc494ca11e Initial load
duke
parents:
diff changeset
  3522
            // ..., evaluate its initializer, if it has one, and check for
06bc494ca11e Initial load
duke
parents:
diff changeset
  3523
            // illegal forward reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3524
            checkInit(tree, env, v, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3525
06bc494ca11e Initial load
duke
parents:
diff changeset
  3526
            // If we are expecting a variable (as opposed to a value), check
06bc494ca11e Initial load
duke
parents:
diff changeset
  3527
            // that the variable is assignable in the current environment.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3528
            if (KindSelector.ASG.subset(pkind()))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3529
                checkAssignable(tree.pos(), v, null, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3530
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3531
06bc494ca11e Initial load
duke
parents:
diff changeset
  3532
        // In a constructor body,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3533
        // if symbol is a field or instance method, check that it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3534
        // not accessed before the supertype constructor is called.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3535
        if ((symEnv.info.isSelfCall || noOuterThisPath) &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3536
            sym.kind.matches(KindSelector.VAL_MTH) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3537
            sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3538
            (sym.flags() & STATIC) == 0) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3539
            chk.earlyRefError(tree.pos(), sym.kind == VAR ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3540
                                          sym : thisSym(tree.pos(), env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3541
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3542
        Env<AttrContext> env1 = env;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3543
        if (sym.kind != ERR && sym.kind != TYP &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3544
            sym.owner != null && sym.owner != env1.enclClass.sym) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3545
            // If the found symbol is inaccessible, then it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3546
            // accessed through an enclosing instance.  Locate this
06bc494ca11e Initial load
duke
parents:
diff changeset
  3547
            // enclosing instance:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3548
            while (env1.outer != null && !rs.isAccessible(env, env1.enclClass.sym.type, sym))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3549
                env1 = env1.outer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3550
        }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3551
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3552
        if (env.info.isSerializable) {
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  3553
            chk.checkAccessFromSerializableElement(tree, env.info.isLambda);
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3554
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3555
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3556
        result = checkId(tree, env1.enclClass.sym.type, sym, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3557
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3558
06bc494ca11e Initial load
duke
parents:
diff changeset
  3559
    public void visitSelect(JCFieldAccess tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3560
        // Determine the expected kind of the qualifier expression.
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3561
        KindSelector skind = KindSelector.NIL;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3562
        if (tree.name == names._this || tree.name == names._super ||
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3563
                tree.name == names._class)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3564
        {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3565
            skind = KindSelector.TYP;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3566
        } else {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3567
            if (pkind().contains(KindSelector.PCK))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3568
                skind = KindSelector.of(skind, KindSelector.PCK);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3569
            if (pkind().contains(KindSelector.TYP))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3570
                skind = KindSelector.of(skind, KindSelector.TYP, KindSelector.PCK);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3571
            if (pkind().contains(KindSelector.VAL_MTH))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3572
                skind = KindSelector.of(skind, KindSelector.VAL, KindSelector.TYP);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3573
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3574
06bc494ca11e Initial load
duke
parents:
diff changeset
  3575
        // Attribute the qualifier expression, and determine its symbol (if any).
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  3576
        Type site = attribTree(tree.selected, env, new ResultInfo(skind, Type.noType));
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3577
        if (!pkind().contains(KindSelector.TYP_PCK))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3578
            site = capture(site); // Capture field access
06bc494ca11e Initial load
duke
parents:
diff changeset
  3579
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3580
        // don't allow T.class T[].class, etc
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3581
        if (skind == KindSelector.TYP) {
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  3582
            Type elt = site;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3583
            while (elt.hasTag(ARRAY))
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  3584
                elt = ((ArrayType)elt).elemtype;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3585
            if (elt.hasTag(TYPEVAR)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3586
                log.error(tree.pos(), Errors.TypeVarCantBeDeref);
26780
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3587
                result = tree.type = types.createErrorType(tree.name, site.tsym, site);
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3588
                tree.sym = tree.type.tsym;
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3589
                return ;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3590
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3591
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3592
06bc494ca11e Initial load
duke
parents:
diff changeset
  3593
        // If qualifier symbol is a type or `super', assert `selectSuper'
06bc494ca11e Initial load
duke
parents:
diff changeset
  3594
        // for the selection. This is relevant for determining whether
06bc494ca11e Initial load
duke
parents:
diff changeset
  3595
        // protected symbols are accessible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3596
        Symbol sitesym = TreeInfo.symbol(tree.selected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3597
        boolean selectSuperPrev = env.info.selectSuper;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3598
        env.info.selectSuper =
06bc494ca11e Initial load
duke
parents:
diff changeset
  3599
            sitesym != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3600
            sitesym.name == names._super;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3601
06bc494ca11e Initial load
duke
parents:
diff changeset
  3602
        // Determine the symbol represented by the selection.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3603
        env.info.pendingResolutionPhase = null;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3604
        Symbol sym = selectSym(tree, sitesym, site, env, resultInfo);
27845
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3605
        if (sym.kind == VAR && sym.name != names._super && env.info.defaultSuperCallSite != null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3606
            log.error(tree.selected.pos(), Errors.NotEnclClass(site.tsym));
27845
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3607
            sym = syms.errSymbol;
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3608
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3609
        if (sym.exists() && !isType(sym) && pkind().contains(KindSelector.TYP_PCK)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3610
            site = capture(site);
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3611
            sym = selectSym(tree, sitesym, site, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3612
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3613
        boolean varArgs = env.info.lastResolveVarargs();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3614
        tree.sym = sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3615
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3616
        if (site.hasTag(TYPEVAR) && !isType(sym) && sym.kind != ERR) {
29292
c10d63c667cd 8073842: Invalid method reference when referencing a method on a wildcard type
mcimadamore
parents: 29147
diff changeset
  3617
            site = types.skipTypeVars(site, true);
511
b3b5eadd2bca 6450290: Capture of nested wildcards causes type error
mcimadamore
parents: 325
diff changeset
  3618
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3619
06bc494ca11e Initial load
duke
parents:
diff changeset
  3620
        // If that symbol is a variable, ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3621
        if (sym.kind == VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3622
            VarSymbol v = (VarSymbol)sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3623
06bc494ca11e Initial load
duke
parents:
diff changeset
  3624
            // ..., evaluate its initializer, if it has one, and check for
06bc494ca11e Initial load
duke
parents:
diff changeset
  3625
            // illegal forward reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3626
            checkInit(tree, env, v, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3627
06bc494ca11e Initial load
duke
parents:
diff changeset
  3628
            // If we are expecting a variable (as opposed to a value), check
06bc494ca11e Initial load
duke
parents:
diff changeset
  3629
            // that the variable is assignable in the current environment.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3630
            if (KindSelector.ASG.subset(pkind()))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3631
                checkAssignable(tree.pos(), v, tree.selected, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3632
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3633
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3634
        if (sitesym != null &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3635
                sitesym.kind == VAR &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3636
                ((VarSymbol)sitesym).isResourceVariable() &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3637
                sym.kind == MTH &&
9079
e512a7712be3 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource
mcimadamore
parents: 9076
diff changeset
  3638
                sym.name.equals(names.close) &&
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3639
                sym.overrides(syms.autoCloseableClose, sitesym.type.tsym, types, true) &&
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3640
                env.info.lint.isEnabled(LintCategory.TRY)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3641
            log.warning(LintCategory.TRY, tree, Warnings.TryExplicitCloseCall);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3642
        }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3643
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3644
        // Disallow selecting a type from an expression
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3645
        if (isType(sym) && (sitesym == null || !sitesym.kind.matches(KindSelector.TYP_PCK))) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3646
            tree.type = check(tree.selected, pt(),
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3647
                              sitesym == null ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3648
                                      KindSelector.VAL : sitesym.kind.toSelector(),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3649
                              new ResultInfo(KindSelector.TYP_PCK, pt()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3650
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3651
06bc494ca11e Initial load
duke
parents:
diff changeset
  3652
        if (isType(sitesym)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3653
            if (sym.name == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3654
                // If `C' is the currently compiled class, check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3655
                // C.this' does not appear in a call to a super(...)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3656
                if (env.info.isSelfCall &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3657
                    site.tsym == env.enclClass.sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3658
                    chk.earlyRefError(tree.pos(), sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3659
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3660
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3661
                // Check if type-qualified fields or methods are static (JLS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3662
                if ((sym.flags() & STATIC) == 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3663
                    sym.name != names._super &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3664
                    (sym.kind == VAR || sym.kind == MTH)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3665
                    rs.accessBase(rs.new StaticError(sym),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3666
                              tree.pos(), site, sym.name, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3667
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3668
            }
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3669
            if (!allowStaticInterfaceMethods && sitesym.isInterface() &&
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3670
                    sym.isStatic() && sym.kind == MTH) {
48054
702043a4cdeb 8189749: Devise strategy for making source level checks more uniform
mcimadamore
parents: 47318
diff changeset
  3671
                log.error(DiagnosticFlag.SOURCE_LEVEL, tree.pos(), Feature.STATIC_INTERFACE_METHODS_INVOKE.error(sourceName));
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3672
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3673
        } else if (sym.kind != ERR &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3674
                   (sym.flags() & STATIC) != 0 &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3675
                   sym.name != names._class) {
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 5001
diff changeset
  3676
            // If the qualified item is not a type and the selected item is static, report
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 5001
diff changeset
  3677
            // a warning. Make allowance for the class of an array type e.g. Object[].class)
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3678
            chk.warnStatic(tree, "static.not.qualified.by.type",
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3679
                           sym.kind.kindName(), sym.owner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3680
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3681
06bc494ca11e Initial load
duke
parents:
diff changeset
  3682
        // If we are selecting an instance member via a `super', ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3683
        if (env.info.selectSuper && (sym.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3684
06bc494ca11e Initial load
duke
parents:
diff changeset
  3685
            // Check that super-qualified symbols are not abstract (JLS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3686
            rs.checkNonAbstract(tree.pos(), sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3687
06bc494ca11e Initial load
duke
parents:
diff changeset
  3688
            if (site.isRaw()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3689
                // Determine argument types for site.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3690
                Type site1 = types.asSuper(env.enclClass.sym.type, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3691
                if (site1 != null) site = site1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3692
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3693
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3694
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3695
        if (env.info.isSerializable) {
41629
9d203cde7d84 8026721: Enhance Lambda serialization
vromero
parents: 41444
diff changeset
  3696
            chk.checkAccessFromSerializableElement(tree, env.info.isLambda);
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3697
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3698
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3699
        env.info.selectSuper = selectSuperPrev;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3700
        result = checkId(tree, site, sym, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3701
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3702
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3703
        /** Determine symbol referenced by a Select expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3704
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  3705
         *  @param tree   The select tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3706
         *  @param site   The type of the selected expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3707
         *  @param env    The current environment.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3708
         *  @param resultInfo The current result.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3709
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3710
        private Symbol selectSym(JCFieldAccess tree,
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3711
                                 Symbol location,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3712
                                 Type site,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3713
                                 Env<AttrContext> env,
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3714
                                 ResultInfo resultInfo) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3715
            DiagnosticPosition pos = tree.pos();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3716
            Name name = tree.name;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3717
            switch (site.getTag()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3718
            case PACKAGE:
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3719
                return rs.accessBase(
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3720
                    rs.findIdentInPackage(env, site.tsym, name, resultInfo.pkind),
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3721
                    pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3722
            case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3723
            case CLASS:
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3724
                if (resultInfo.pt.hasTag(METHOD) || resultInfo.pt.hasTag(FORALL)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3725
                    return rs.resolveQualifiedMethod(
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3726
                        pos, env, location, site, name, resultInfo.pt.getParameterTypes(), resultInfo.pt.getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3727
                } else if (name == names._this || name == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3728
                    return rs.resolveSelf(pos, env, site.tsym, name);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3729
                } else if (name == names._class) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3730
                    // In this case, we have already made sure in
06bc494ca11e Initial load
duke
parents:
diff changeset
  3731
                    // visitSelect that qualifier expression is a type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3732
                    Type t = syms.classType;
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3733
                    List<Type> typeargs = List.of(types.erasure(site));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3734
                    t = new ClassType(t.getEnclosingType(), typeargs, t.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3735
                    return new VarSymbol(
06bc494ca11e Initial load
duke
parents:
diff changeset
  3736
                        STATIC | PUBLIC | FINAL, names._class, t, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3737
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3738
                    // We are seeing a plain identifier as selector.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3739
                    Symbol sym = rs.findIdentInType(env, site, name, resultInfo.pkind);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3740
                        sym = rs.accessBase(sym, pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3741
                    return sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3742
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3743
            case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3744
                throw new AssertionError(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3745
            case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3746
                // Normally, site.getUpperBound() shouldn't be null.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3747
                // It should only happen during memberEnter/attribBase
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3748
                // when determining the super type which *must* beac
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3749
                // done before attributing the type variables.  In
06bc494ca11e Initial load
duke
parents:
diff changeset
  3750
                // other words, we are seeing this illegal program:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3751
                // class B<T> extends A<T.foo> {}
06bc494ca11e Initial load
duke
parents:
diff changeset
  3752
                Symbol sym = (site.getUpperBound() != null)
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3753
                    ? selectSym(tree, location, capture(site.getUpperBound()), env, resultInfo)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3754
                    : null;
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  3755
                if (sym == null) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3756
                    log.error(pos, Errors.TypeVarCantBeDeref);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3757
                    return syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3758
                } else {
1528
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3759
                    Symbol sym2 = (sym.flags() & Flags.PRIVATE) != 0 ?
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3760
                        rs.new AccessError(env, site, sym) :
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3761
                                sym;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3762
                    rs.accessBase(sym2, pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3763
                    return sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3764
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3765
            case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3766
                // preserve identifier names through errors
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3767
                return types.createErrorType(name, site.tsym, site).tsym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3768
            default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3769
                // The qualifier expression is of a primitive type -- only
06bc494ca11e Initial load
duke
parents:
diff changeset
  3770
                // .class is allowed for these.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3771
                if (name == names._class) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3772
                    // In this case, we have already made sure in Select that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3773
                    // qualifier expression is a type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3774
                    Type t = syms.classType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3775
                    Type arg = types.boxedClass(site).type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3776
                    t = new ClassType(t.getEnclosingType(), List.of(arg), t.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3777
                    return new VarSymbol(
06bc494ca11e Initial load
duke
parents:
diff changeset
  3778
                        STATIC | PUBLIC | FINAL, names._class, t, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3779
                } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  3780
                    log.error(pos, Errors.CantDeref(site));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3781
                    return syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3782
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3783
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3784
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3785
06bc494ca11e Initial load
duke
parents:
diff changeset
  3786
        /** Determine type of identifier or select expression and check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3787
         *  (1) the referenced symbol is not deprecated
06bc494ca11e Initial load
duke
parents:
diff changeset
  3788
         *  (2) the symbol's type is safe (@see checkSafe)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3789
         *  (3) if symbol is a variable, check that its type and kind are
06bc494ca11e Initial load
duke
parents:
diff changeset
  3790
         *      compatible with the prototype and protokind.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3791
         *  (4) if symbol is an instance field of a raw type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3792
         *      which is being assigned to, issue an unchecked warning if its
06bc494ca11e Initial load
duke
parents:
diff changeset
  3793
         *      type changes under erasure.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3794
         *  (5) if symbol is an instance method of a raw type, issue an
06bc494ca11e Initial load
duke
parents:
diff changeset
  3795
         *      unchecked warning if its argument types change under erasure.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3796
         *  If checks succeed:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3797
         *    If symbol is a constant, return its constant type
06bc494ca11e Initial load
duke
parents:
diff changeset
  3798
         *    else if symbol is a method, return its result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  3799
         *    otherwise return its type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3800
         *  Otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3801
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  3802
         *  @param tree       The syntax tree representing the identifier
06bc494ca11e Initial load
duke
parents:
diff changeset
  3803
         *  @param site       If this is a select, the type of the selected
06bc494ca11e Initial load
duke
parents:
diff changeset
  3804
         *                    expression, otherwise the type of the current class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3805
         *  @param sym        The symbol representing the identifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3806
         *  @param env        The current environment.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3807
         *  @param resultInfo    The expected result
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3808
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3809
        Type checkId(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3810
                     Type site,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3811
                     Symbol sym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3812
                     Env<AttrContext> env,
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3813
                     ResultInfo resultInfo) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3814
            return (resultInfo.pt.hasTag(FORALL) || resultInfo.pt.hasTag(METHOD)) ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3815
                    checkMethodId(tree, site, sym, env, resultInfo) :
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3816
                    checkIdInternal(tree, site, sym, resultInfo.pt, env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3817
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3818
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3819
        Type checkMethodId(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3820
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3821
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3822
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3823
                     ResultInfo resultInfo) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3824
            boolean isPolymorhicSignature =
18389
a425d0819f36 8016569: javac, add new flag for polymorphic method signatures
vromero
parents: 18382
diff changeset
  3825
                (sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) != 0;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3826
            return isPolymorhicSignature ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3827
                    checkSigPolyMethodId(tree, site, sym, env, resultInfo) :
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3828
                    checkMethodIdInternal(tree, site, sym, env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3829
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3830
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3831
        Type checkSigPolyMethodId(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3832
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3833
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3834
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3835
                     ResultInfo resultInfo) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3836
            //recover original symbol for signature polymorphic methods
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3837
            checkMethodIdInternal(tree, site, sym.baseSymbol(), env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3838
            env.info.pendingResolutionPhase = Resolve.MethodResolutionPhase.BASIC;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3839
            return sym.type;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3840
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3841
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3842
        Type checkMethodIdInternal(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3843
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3844
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3845
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3846
                     ResultInfo resultInfo) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3847
            if (resultInfo.pkind.contains(KindSelector.POLY)) {
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3848
                Type pt = resultInfo.pt.map(deferredAttr.new RecoveryDeferredTypeMap(AttrMode.SPECULATIVE, sym, env.info.pendingResolutionPhase));
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3849
                Type owntype = checkIdInternal(tree, site, sym, pt, env, resultInfo);
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3850
                resultInfo.pt.map(deferredAttr.new RecoveryDeferredTypeMap(AttrMode.CHECK, sym, env.info.pendingResolutionPhase));
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3851
                return owntype;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3852
            } else {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3853
                return checkIdInternal(tree, site, sym, resultInfo.pt, env, resultInfo);
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3854
            }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3855
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3856
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3857
        Type checkIdInternal(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3858
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3859
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3860
                     Type pt,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3861
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3862
                     ResultInfo resultInfo) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3863
            if (pt.isErroneous()) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3864
                return types.createErrorType(site);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3865
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3866
            Type owntype; // The computed type of this identifier occurrence.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3867
            switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3868
            case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3869
                // For types, the computed type equals the symbol's type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3870
                // except for two situations:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3871
                owntype = sym.type;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3872
                if (owntype.hasTag(CLASS)) {
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14366
diff changeset
  3873
                    chk.checkForBadAuxiliaryClassAccess(tree.pos(), env, (ClassSymbol)sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3874
                    Type ownOuter = owntype.getEnclosingType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3875
06bc494ca11e Initial load
duke
parents:
diff changeset
  3876
                    // (a) If the symbol's type is parameterized, erase it
06bc494ca11e Initial load
duke
parents:
diff changeset
  3877
                    // because no type parameters were given.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3878
                    // We recover generic outer type later in visitTypeApply.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3879
                    if (owntype.tsym.type.getTypeArguments().nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3880
                        owntype = types.erasure(owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3881
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3882
06bc494ca11e Initial load
duke
parents:
diff changeset
  3883
                    // (b) If the symbol's type is an inner class, then
06bc494ca11e Initial load
duke
parents:
diff changeset
  3884
                    // we have to interpret its outer type as a superclass
06bc494ca11e Initial load
duke
parents:
diff changeset
  3885
                    // of the site type. Example:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3886
                    //
06bc494ca11e Initial load
duke
parents:
diff changeset
  3887
                    // class Tree<A> { class Visitor { ... } }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3888
                    // class PointTree extends Tree<Point> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3889
                    // ...PointTree.Visitor...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3890
                    //
06bc494ca11e Initial load
duke
parents:
diff changeset
  3891
                    // Then the type of the last expression above is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3892
                    // Tree<Point>.Visitor.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3893
                    else if (ownOuter.hasTag(CLASS) && site != ownOuter) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3894
                        Type normOuter = site;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3895
                        if (normOuter.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3896
                            normOuter = types.asEnclosingSuper(site, ownOuter.tsym);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3897
                        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3898
                        if (normOuter == null) // perhaps from an import
06bc494ca11e Initial load
duke
parents:
diff changeset
  3899
                            normOuter = types.erasure(ownOuter);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3900
                        if (normOuter != ownOuter)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3901
                            owntype = new ClassType(
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  3902
                                normOuter, List.nil(), owntype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  3903
                                owntype.getMetadata());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3904
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3905
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3906
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3907
            case VAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3908
                VarSymbol v = (VarSymbol)sym;
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3909
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3910
                if (env.info.enclVar != null
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3911
                        && v.type.hasTag(NONE)) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3912
                    //self reference to implicitly typed variable declaration
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3913
                    log.error(TreeInfo.positionFor(v, env.enclClass), Errors.CantInferLocalVarType(v.name, Fragments.LocalSelfRef));
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3914
                    return v.type = types.createErrorType(v.type);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3915
                }
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  3916
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3917
                // Test (4): if symbol is an instance field of a raw type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3918
                // which is being assigned to, issue an unchecked warning if
06bc494ca11e Initial load
duke
parents:
diff changeset
  3919
                // its type changes under erasure.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3920
                if (KindSelector.ASG.subset(pkind()) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3921
                    v.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3922
                    (v.flags() & STATIC) == 0 &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3923
                    (site.hasTag(CLASS) || site.hasTag(TYPEVAR))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3924
                    Type s = types.asOuterSuper(site, v.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3925
                    if (s != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3926
                        s.isRaw() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3927
                        !types.isSameType(v.type, v.erasure(types))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3928
                        chk.warnUnchecked(tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3929
                                          "unchecked.assign.to.var",
06bc494ca11e Initial load
duke
parents:
diff changeset
  3930
                                          v, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3931
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3932
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3933
                // The computed type of a variable is the type of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  3934
                // variable symbol, taken as a member of the site type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3935
                owntype = (sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3936
                           sym.name != names._this && sym.name != names._super)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3937
                    ? types.memberType(site, sym)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3938
                    : sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3939
06bc494ca11e Initial load
duke
parents:
diff changeset
  3940
                // If the variable is a constant, record constant value in
06bc494ca11e Initial load
duke
parents:
diff changeset
  3941
                // computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3942
                if (v.getConstValue() != null && isStaticReference(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3943
                    owntype = owntype.constType(v.getConstValue());
06bc494ca11e Initial load
duke
parents:
diff changeset
  3944
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3945
                if (resultInfo.pkind == KindSelector.VAL) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3946
                    owntype = capture(owntype); // capture "names as expressions"
06bc494ca11e Initial load
duke
parents:
diff changeset
  3947
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3948
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3949
            case MTH: {
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3950
                owntype = checkMethod(site, sym,
44392
e21b18355690 8177097: Generic method reference returning wildcard parameterized type does not compile
mcimadamore
parents: 44194
diff changeset
  3951
                        new ResultInfo(resultInfo.pkind, resultInfo.pt.getReturnType(), resultInfo.checkContext, resultInfo.checkMode),
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  3952
                        env, TreeInfo.args(env.tree), resultInfo.pt.getParameterTypes(),
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3953
                        resultInfo.pt.getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3954
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3955
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3956
            case PCK: case ERR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3957
                owntype = sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3958
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3959
            default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3960
                throw new AssertionError("unexpected kind: " + sym.kind +
06bc494ca11e Initial load
duke
parents:
diff changeset
  3961
                                         " in tree " + tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3962
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3963
32950
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3964
            // Emit a `deprecation' warning if symbol is deprecated.
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3965
            // (for constructors (but not for constructor references), the error
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3966
            // was given when the constructor was resolved)
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3967
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3968
            if (sym.name != names.init || tree.hasTag(REFERENCE)) {
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3969
                chk.checkDeprecated(tree.pos(), env.info.scope.owner, sym);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3970
                chk.checkSunAPI(tree.pos(), sym);
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14953
diff changeset
  3971
                chk.checkProfile(tree.pos(), sym);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3559
diff changeset
  3972
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3973
32950
22315d47485b 8065219: Deprecated warning in method reference are missing in some cases.
sadayapalam
parents: 32912
diff changeset
  3974
            // If symbol is a variable, check that its type and
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3975
            // kind are compatible with the prototype and protokind.
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3976
            return check(tree, owntype, sym.kind.toSelector(), resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3977
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3978
06bc494ca11e Initial load
duke
parents:
diff changeset
  3979
        /** Check that variable is initialized and evaluate the variable's
06bc494ca11e Initial load
duke
parents:
diff changeset
  3980
         *  initializer, if not yet done. Also check that variable is not
06bc494ca11e Initial load
duke
parents:
diff changeset
  3981
         *  referenced before it is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3982
         *  @param tree    The tree making up the variable reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3983
         *  @param env     The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3984
         *  @param v       The variable's symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3985
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3986
        private void checkInit(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3987
                               Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3988
                               VarSymbol v,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3989
                               boolean onlyWarning) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3990
            // A forward reference is diagnosed if the declaration position
06bc494ca11e Initial load
duke
parents:
diff changeset
  3991
            // of the variable is greater than the current tree position
06bc494ca11e Initial load
duke
parents:
diff changeset
  3992
            // and the tree and variable definition occur in the same class
06bc494ca11e Initial load
duke
parents:
diff changeset
  3993
            // definition.  Note that writes don't count as references.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3994
            // This check applies only to class and instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  3995
            // variables.  Local variables follow different scope rules,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3996
            // and are subject to definite assignment checking.
32164
6c65d5b414bc 8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
vromero
parents: 31937
diff changeset
  3997
            Env<AttrContext> initEnv = enclosingInitEnv(env);
6c65d5b414bc 8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
vromero
parents: 31937
diff changeset
  3998
            if (initEnv != null &&
6c65d5b414bc 8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
vromero
parents: 31937
diff changeset
  3999
                (initEnv.info.enclVar == v || v.pos > tree.pos) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4000
                v.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4001
                v.owner == env.info.scope.owner.enclClass() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4002
                ((v.flags() & STATIC) != 0) == Resolve.isStatic(env) &&
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4003
                (!env.tree.hasTag(ASSIGN) ||
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4004
                 TreeInfo.skipParens(((JCAssign) env.tree).lhs) != tree)) {
32164
6c65d5b414bc 8053906: javac is accepting a self-referencing variable initializer inside a lambda expression
vromero
parents: 31937
diff changeset
  4005
                String suffix = (initEnv.info.enclVar == v) ?
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  4006
                                "self.ref" : "forward.ref";
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4007
                if (!onlyWarning || isStaticEnumField(v)) {
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  4008
                    log.error(tree.pos(), "illegal." + suffix);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4009
                } else if (useBeforeDeclarationWarning) {
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  4010
                    log.warning(tree.pos(), suffix, v);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4011
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4012
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4013
06bc494ca11e Initial load
duke
parents:
diff changeset
  4014
            v.getConstValue(); // ensure initializer is evaluated
06bc494ca11e Initial load
duke
parents:
diff changeset
  4015
06bc494ca11e Initial load
duke
parents:
diff changeset
  4016
            checkEnumInitializer(tree, env, v);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4017
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4018
06bc494ca11e Initial load
duke
parents:
diff changeset
  4019
        /**
25846
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4020
         * Returns the enclosing init environment associated with this env (if any). An init env
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4021
         * can be either a field declaration env or a static/instance initializer env.
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4022
         */
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4023
        Env<AttrContext> enclosingInitEnv(Env<AttrContext> env) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4024
            while (true) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4025
                switch (env.tree.getTag()) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4026
                    case VARDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4027
                        JCVariableDecl vdecl = (JCVariableDecl)env.tree;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4028
                        if (vdecl.sym.owner.kind == TYP) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4029
                            //field
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4030
                            return env;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4031
                        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4032
                        break;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4033
                    case BLOCK:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4034
                        if (env.next.tree.hasTag(CLASSDEF)) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4035
                            //instance/static initializer
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4036
                            return env;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4037
                        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4038
                        break;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4039
                    case METHODDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4040
                    case CLASSDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4041
                    case TOPLEVEL:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4042
                        return null;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4043
                }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4044
                Assert.checkNonNull(env.next);
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4045
                env = env.next;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4046
            }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4047
        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4048
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  4049
        /**
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4050
         * Check for illegal references to static members of enum.  In
06bc494ca11e Initial load
duke
parents:
diff changeset
  4051
         * an enum type, constructors and initializers may not
06bc494ca11e Initial load
duke
parents:
diff changeset
  4052
         * reference its static members unless they are constant.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4053
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  4054
         * @param tree    The tree making up the variable reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4055
         * @param env     The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4056
         * @param v       The variable's symbol.
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
  4057
         * @jls  section 8.9 Enums
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4058
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4059
        private void checkEnumInitializer(JCTree tree, Env<AttrContext> env, VarSymbol v) {
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
  4060
            // JLS:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4061
            //
06bc494ca11e Initial load
duke
parents:
diff changeset
  4062
            // "It is a compile-time error to reference a static field
06bc494ca11e Initial load
duke
parents:
diff changeset
  4063
            // of an enum type that is not a compile-time constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  4064
            // (15.28) from constructors, instance initializer blocks,
06bc494ca11e Initial load
duke
parents:
diff changeset
  4065
            // or instance variable initializer expressions of that
06bc494ca11e Initial load
duke
parents:
diff changeset
  4066
            // type. It is a compile-time error for the constructors,
06bc494ca11e Initial load
duke
parents:
diff changeset
  4067
            // instance initializer blocks, or instance variable
06bc494ca11e Initial load
duke
parents:
diff changeset
  4068
            // initializer expressions of an enum constant e to refer
06bc494ca11e Initial load
duke
parents:
diff changeset
  4069
            // to itself or to an enum constant of the same type that
06bc494ca11e Initial load
duke
parents:
diff changeset
  4070
            // is declared to the right of e."
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4071
            if (isStaticEnumField(v)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4072
                ClassSymbol enclClass = env.info.scope.owner.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4073
06bc494ca11e Initial load
duke
parents:
diff changeset
  4074
                if (enclClass == null || enclClass.owner == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4075
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4076
06bc494ca11e Initial load
duke
parents:
diff changeset
  4077
                // See if the enclosing class is the enum (or a
06bc494ca11e Initial load
duke
parents:
diff changeset
  4078
                // subclass thereof) declaring v.  If not, this
06bc494ca11e Initial load
duke
parents:
diff changeset
  4079
                // reference is OK.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4080
                if (v.owner != enclClass && !types.isSubtype(enclClass.type, v.owner.type))
06bc494ca11e Initial load
duke
parents:
diff changeset
  4081
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4082
06bc494ca11e Initial load
duke
parents:
diff changeset
  4083
                // If the reference isn't from an initializer, then
06bc494ca11e Initial load
duke
parents:
diff changeset
  4084
                // the reference is OK.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4085
                if (!Resolve.isInitializer(env))
06bc494ca11e Initial load
duke
parents:
diff changeset
  4086
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4087
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4088
                log.error(tree.pos(), Errors.IllegalEnumStaticRef);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4089
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4090
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4091
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4092
        /** Is the given symbol a static, non-constant field of an Enum?
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4093
         *  Note: enum literals should not be regarded as such
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4094
         */
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4095
        private boolean isStaticEnumField(VarSymbol v) {
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4096
            return Flags.isEnum(v.owner) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4097
                   Flags.isStatic(v) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4098
                   !Flags.isConstant(v) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  4099
                   v.name != names._class;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4100
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4101
06bc494ca11e Initial load
duke
parents:
diff changeset
  4102
    /**
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  4103
     * Check that method arguments conform to its instantiation.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4104
     **/
06bc494ca11e Initial load
duke
parents:
diff changeset
  4105
    public Type checkMethod(Type site,
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4106
                            final Symbol sym,
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  4107
                            ResultInfo resultInfo,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  4108
                            Env<AttrContext> env,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  4109
                            final List<JCExpression> argtrees,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  4110
                            List<Type> argtypes,
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4111
                            List<Type> typeargtypes) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4112
        // Test (5): if symbol is an instance method of a raw type, issue
06bc494ca11e Initial load
duke
parents:
diff changeset
  4113
        // an unchecked warning if its argument types change under erasure.
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  4114
        if ((sym.flags() & STATIC) == 0 &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4115
            (site.hasTag(CLASS) || site.hasTag(TYPEVAR))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4116
            Type s = types.asOuterSuper(site, sym.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4117
            if (s != null && s.isRaw() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4118
                !types.isSameTypes(sym.type.getParameterTypes(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4119
                                   sym.erasure(types).getParameterTypes())) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4120
                chk.warnUnchecked(env.tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4121
                                  "unchecked.call.mbr.of.raw.type",
06bc494ca11e Initial load
duke
parents:
diff changeset
  4122
                                  sym, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4123
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4124
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4125
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4126
        if (env.info.defaultSuperCallSite != null) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4127
            for (Type sup : types.interfaces(env.enclClass.type).prepend(types.supertype((env.enclClass.type)))) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4128
                if (!sup.tsym.isSubClass(sym.enclClass(), types) ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4129
                        types.isSameType(sup, env.info.defaultSuperCallSite)) continue;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4130
                List<MethodSymbol> icand_sup =
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4131
                        types.interfaceCandidates(sup, (MethodSymbol)sym);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4132
                if (icand_sup.nonEmpty() &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4133
                        icand_sup.head != sym &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4134
                        icand_sup.head.overrides(sym, icand_sup.head.enclClass(), types, true)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4135
                    log.error(env.tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4136
                              Errors.IllegalDefaultSuperCall(env.info.defaultSuperCallSite, Fragments.OverriddenDefault(sym, sup)));
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4137
                    break;
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4138
                }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4139
            }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  4140
            env.info.defaultSuperCallSite = null;
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4141
        }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4142
16330
66e277848a69 8009299: Javac crashes when compiling method reference to static interface method
mcimadamore
parents: 16328
diff changeset
  4143
        if (sym.isStatic() && site.isInterface() && env.tree.hasTag(APPLY)) {
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4144
            JCMethodInvocation app = (JCMethodInvocation)env.tree;
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4145
            if (app.meth.hasTag(SELECT) &&
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4146
                    !TreeInfo.isStaticSelector(((JCFieldAccess)app.meth).selected, names)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4147
                log.error(env.tree.pos(), Errors.IllegalStaticIntfMethCall(site));
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4148
            }
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4149
        }
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  4150
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4151
        // Compute the identifier's instantiated type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4152
        // For methods, we need to compute the instance type by
06bc494ca11e Initial load
duke
parents:
diff changeset
  4153
        // Resolve.instantiate from the symbol's type as well as
06bc494ca11e Initial load
duke
parents:
diff changeset
  4154
        // any type arguments and value arguments.
35349
4a13a361309a 8147493: regression when type-checking unchecked method calls
mcimadamore
parents: 33907
diff changeset
  4155
        Warner noteWarner = new Warner();
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4156
        try {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4157
            Type owntype = rs.checkMethod(
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4158
                    env,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4159
                    site,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4160
                    sym,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4161
                    resultInfo,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4162
                    argtypes,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4163
                    typeargtypes,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4164
                    noteWarner);
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4165
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4166
            DeferredAttr.DeferredTypeMap checkDeferredMap =
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4167
                deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4168
29554
6d7957bd6866 8074100: Turn Type.Mapping into a true visitor
mcimadamore
parents: 29553
diff changeset
  4169
            argtypes = argtypes.map(checkDeferredMap);
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4170
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4171
            if (noteWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4172
                chk.warnUnchecked(env.tree.pos(),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4173
                        "unchecked.meth.invocation.applied",
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4174
                        kindName(sym),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4175
                        sym.name,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4176
                        rs.methodArguments(sym.type.getParameterTypes()),
29554
6d7957bd6866 8074100: Turn Type.Mapping into a true visitor
mcimadamore
parents: 29553
diff changeset
  4177
                        rs.methodArguments(argtypes.map(checkDeferredMap)),
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4178
                        kindName(sym.location()),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4179
                        sym.location());
43761
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4180
                if (resultInfo.pt != Infer.anyPoly ||
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4181
                        !owntype.hasTag(METHOD) ||
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4182
                        !owntype.isPartial()) {
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4183
                    //if this is not a partially inferred method type, erase return type. Otherwise,
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4184
                    //erasure is carried out in PartiallyInferredMethodType.check().
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4185
                    owntype = new MethodType(owntype.getParameterTypes(),
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4186
                            types.erasure(owntype.getReturnType()),
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4187
                            types.erasure(owntype.getThrownTypes()),
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4188
                            syms.methodClass);
f50592785b30 8174249: Regression in generic method unchecked calls
mcimadamore
parents: 43582
diff changeset
  4189
                }
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4190
            }
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  4191
32709
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4192
            PolyKind pkind = (sym.type.hasTag(FORALL) &&
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4193
                 sym.type.getReturnType().containsAny(((ForAll)sym.type).tvars)) ?
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4194
                 PolyKind.POLY : PolyKind.STANDALONE;
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4195
            TreeInfo.setPolyKind(env.tree, pkind);
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4196
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4197
            return (resultInfo.pt == Infer.anyPoly) ?
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4198
                    owntype :
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4199
                    chk.checkMethod(owntype, sym, env, argtrees, argtypes, env.info.lastResolveVarargs(),
55d136799f79 8078093: Severe compiler performance regression Java 7 to 8 for nested method invocations
mcimadamore
parents: 32164
diff changeset
  4200
                            resultInfo.checkContext.inferenceContext());
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4201
        } catch (Infer.InferenceException ex) {
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4202
            //invalid target type - propagate exception outwards or report error
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4203
            //depending on the current check context
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4204
            resultInfo.checkContext.report(env.tree.pos(), ex.getDiagnostic());
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4205
            return types.createErrorType(site);
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4206
        } catch (Resolve.InapplicableMethodException ex) {
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4207
            final JCDiagnostic diag = ex.getDiagnostic();
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4208
            Resolve.InapplicableSymbolError errSym = rs.new InapplicableSymbolError(null) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4209
                @Override
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4210
                protected Pair<Symbol, JCDiagnostic> errCandidate() {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  4211
                    return new Pair<>(sym, diag);
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4212
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4213
            };
29554
6d7957bd6866 8074100: Turn Type.Mapping into a true visitor
mcimadamore
parents: 29553
diff changeset
  4214
            List<Type> argtypes2 = argtypes.map(
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4215
                    rs.new ResolveDeferredRecoveryMap(AttrMode.CHECK, sym, env.info.pendingResolutionPhase));
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4216
            JCDiagnostic errDiag = errSym.getDiagnostic(JCDiagnostic.DiagnosticType.ERROR,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4217
                    env.tree, sym, site, sym.name, argtypes2, typeargtypes);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4218
            log.report(errDiag);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  4219
            return types.createErrorType(site);
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  4220
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  4221
    }
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  4222
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4223
    public void visitLiteral(JCLiteral tree) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4224
        result = check(tree, litType(tree.typetag).constType(tree.value),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4225
                KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4226
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4227
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  4228
    /** Return the type of a literal with given type tag.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4229
     */
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4230
    Type litType(TypeTag tag) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4231
        return (tag == CLASS) ? syms.stringType : syms.typeOfTag[tag.ordinal()];
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4232
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4233
06bc494ca11e Initial load
duke
parents:
diff changeset
  4234
    public void visitTypeIdent(JCPrimitiveTypeTree tree) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4235
        result = check(tree, syms.typeOfTag[tree.typetag.ordinal()], KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4236
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4237
06bc494ca11e Initial load
duke
parents:
diff changeset
  4238
    public void visitTypeArray(JCArrayTypeTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4239
        Type etype = attribType(tree.elemtype, env);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  4240
        Type type = new ArrayType(etype, syms.arrayClass);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  4241
        if (etype.isErroneous()) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  4242
            type = types.createErrorType(type);
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  4243
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4244
        result = check(tree, type, KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4245
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4246
06bc494ca11e Initial load
duke
parents:
diff changeset
  4247
    /** Visitor method for parameterized types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4248
     *  Bound checking is left until later, since types are attributed
06bc494ca11e Initial load
duke
parents:
diff changeset
  4249
     *  before supertype structure is completely known
06bc494ca11e Initial load
duke
parents:
diff changeset
  4250
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4251
    public void visitTypeApply(JCTypeApply tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  4252
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4253
06bc494ca11e Initial load
duke
parents:
diff changeset
  4254
        // Attribute functor part of application and make sure it's a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4255
        Type clazztype = chk.checkClassType(tree.clazz.pos(), attribType(tree.clazz, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  4256
06bc494ca11e Initial load
duke
parents:
diff changeset
  4257
        // Attribute type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  4258
        List<Type> actuals = attribTypes(tree.arguments, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4259
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4260
        if (clazztype.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4261
            List<Type> formals = clazztype.tsym.type.getTypeArguments();
10198
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  4262
            if (actuals.isEmpty()) //diamond
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  4263
                actuals = formals;
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  4264
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  4265
            if (actuals.length() == formals.length()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4266
                List<Type> a = actuals;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4267
                List<Type> f = formals;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4268
                while (a.nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4269
                    a.head = a.head.withTypeVar(f.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4270
                    a = a.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4271
                    f = f.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4272
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4273
                // Compute the proper generic outer
06bc494ca11e Initial load
duke
parents:
diff changeset
  4274
                Type clazzOuter = clazztype.getEnclosingType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4275
                if (clazzOuter.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4276
                    Type site;
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  4277
                    JCExpression clazz = TreeInfo.typeIn(tree.clazz);
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4278
                    if (clazz.hasTag(IDENT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4279
                        site = env.enclClass.sym.type;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4280
                    } else if (clazz.hasTag(SELECT)) {
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  4281
                        site = ((JCFieldAccess) clazz).selected.type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4282
                    } else throw new AssertionError(""+tree);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4283
                    if (clazzOuter.hasTag(CLASS) && site != clazzOuter) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4284
                        if (site.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4285
                            site = types.asOuterSuper(site, clazzOuter.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4286
                        if (site == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4287
                            site = types.erasure(clazzOuter);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4288
                        clazzOuter = site;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4289
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4290
                }
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  4291
                owntype = new ClassType(clazzOuter, actuals, clazztype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  4292
                                        clazztype.getMetadata());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4293
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4294
                if (formals.length() != 0) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4295
                    log.error(tree.pos(),
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4296
                              Errors.WrongNumberTypeArgs(Integer.toString(formals.length())));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4297
                } else {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4298
                    log.error(tree.pos(), Errors.TypeDoesntTakeParams(clazztype.tsym));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4299
                }
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  4300
                owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4301
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4302
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4303
        result = check(tree, owntype, KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4304
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4305
9300
c2de4dd9853b 7033809: Rename "disjunctive" to "union" in javax.lang.model
darcy
parents: 9079
diff changeset
  4306
    public void visitTypeUnion(JCTypeUnion tree) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  4307
        ListBuffer<Type> multicatchTypes = new ListBuffer<>();
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4308
        ListBuffer<Type> all_multicatchTypes = null; // lazy, only if needed
7622
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4309
        for (JCExpression typeTree : tree.alternatives) {
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4310
            Type ctype = attribType(typeTree, env);
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4311
            ctype = chk.checkType(typeTree.pos(),
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4312
                          chk.checkClassType(typeTree.pos(), ctype),
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4313
                          syms.throwableType);
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4314
            if (!ctype.isErroneous()) {
9300
c2de4dd9853b 7033809: Rename "disjunctive" to "union" in javax.lang.model
darcy
parents: 9079
diff changeset
  4315
                //check that alternatives of a union type are pairwise
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4316
                //unrelated w.r.t. subtyping
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4317
                if (chk.intersects(ctype,  multicatchTypes.toList())) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4318
                    for (Type t : multicatchTypes) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4319
                        boolean sub = types.isSubtype(ctype, t);
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4320
                        boolean sup = types.isSubtype(t, ctype);
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4321
                        if (sub || sup) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4322
                            //assume 'a' <: 'b'
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4323
                            Type a = sub ? ctype : t;
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4324
                            Type b = sub ? t : ctype;
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4325
                            log.error(typeTree.pos(), Errors.MulticatchTypesMustBeDisjoint(a, b));
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4326
                        }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4327
                    }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4328
                }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4329
                multicatchTypes.append(ctype);
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4330
                if (all_multicatchTypes != null)
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4331
                    all_multicatchTypes.append(ctype);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4332
            } else {
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4333
                if (all_multicatchTypes == null) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  4334
                    all_multicatchTypes = new ListBuffer<>();
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4335
                    all_multicatchTypes.appendList(multicatchTypes);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4336
                }
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4337
                all_multicatchTypes.append(ctype);
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  4338
            }
7622
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  4339
        }
30405
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  4340
        Type t = check(tree, types.lub(multicatchTypes.toList()),
3da6595b205f 8076279: Refactor Attr.check* methods to receive/handle a CheckMode enumeration
sadayapalam
parents: 30064
diff changeset
  4341
                KindSelector.TYP, resultInfo.dup(CheckMode.NO_TREE_UPDATE));
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4342
        if (t.hasTag(CLASS)) {
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4343
            List<Type> alternatives =
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4344
                ((all_multicatchTypes == null) ? multicatchTypes : all_multicatchTypes).toList();
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4345
            t = new UnionClassType((ClassType) t, alternatives);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4346
        }
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  4347
        tree.type = result = t;
5492
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 5489
diff changeset
  4348
    }
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 5489
diff changeset
  4349
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4350
    public void visitTypeIntersection(JCTypeIntersection tree) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4351
        attribTypes(tree.bounds, env);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4352
        tree.type = result = checkIntersection(tree, tree.bounds);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4353
    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4354
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4355
    public void visitTypeParameter(JCTypeParameter tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4356
        TypeVar typeVar = (TypeVar) tree.type;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4357
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4358
        if (tree.annotations != null && tree.annotations.nonEmpty()) {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4359
            annotate.annotateTypeParameterSecondStage(tree, tree.annotations);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4360
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4361
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4362
        if (!typeVar.bound.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4363
            //fixup type-parameter bound computed in 'attribTypeVariables'
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4364
            typeVar.bound = checkIntersection(tree, tree.bounds);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4365
        }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4366
    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4367
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4368
    Type checkIntersection(JCTree tree, List<JCExpression> bounds) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  4369
        Set<Type> boundSet = new HashSet<>();
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4370
        if (bounds.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4371
            // accept class or interface or typevar as first bound.
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
  4372
            bounds.head.type = checkBase(bounds.head.type, bounds.head, env, false, false, false);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4373
            boundSet.add(types.erasure(bounds.head.type));
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4374
            if (bounds.head.type.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4375
                return bounds.head.type;
1532
ae41c47516e5 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds
mcimadamore
parents: 1528
diff changeset
  4376
            }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4377
            else if (bounds.head.type.hasTag(TYPEVAR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4378
                // if first bound was a typevar, do not accept further bounds.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4379
                if (bounds.tail.nonEmpty()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4380
                    log.error(bounds.tail.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4381
                              Errors.TypeVarMayNotBeFollowedByOtherBounds);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4382
                    return bounds.head.type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4383
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4384
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4385
                // if first bound was a class or interface, accept only interfaces
06bc494ca11e Initial load
duke
parents:
diff changeset
  4386
                // as further bounds.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4387
                for (JCExpression bound : bounds.tail) {
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
  4388
                    bound.type = checkBase(bound.type, bound, env, false, true, false);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4389
                    if (bound.type.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4390
                        bounds = List.of(bound);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4391
                    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4392
                    else if (bound.type.hasTag(CLASS)) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4393
                        chk.checkNotRepeated(bound.pos(), types.erasure(bound.type), boundSet);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4394
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4395
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4396
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4397
        }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4398
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4399
        if (bounds.length() == 0) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4400
            return syms.objectType;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4401
        } else if (bounds.length() == 1) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4402
            return bounds.head.type;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4403
        } else {
29147
4cba0458106b 8071291: Compiler crashes trying to cast UnionType to IntersectionClassType
mcimadamore
parents: 29051
diff changeset
  4404
            Type owntype = types.makeIntersectionType(TreeInfo.types(bounds));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4405
            // ... the variable's bound is a class type flagged COMPOUND
06bc494ca11e Initial load
duke
parents:
diff changeset
  4406
            // (see comment for TypeVar.bound).
06bc494ca11e Initial load
duke
parents:
diff changeset
  4407
            // In this case, generate a class tree that represents the
06bc494ca11e Initial load
duke
parents:
diff changeset
  4408
            // bound class, ...
8625
6b51ef804d49 6639645: Modeling type implementing missing interfaces
jjg
parents: 8622
diff changeset
  4409
            JCExpression extending;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4410
            List<JCExpression> implementing;
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4411
            if (!bounds.head.type.isInterface()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4412
                extending = bounds.head;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4413
                implementing = bounds.tail;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4414
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4415
                extending = null;
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4416
                implementing = bounds;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4417
            }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4418
            JCClassDecl cd = make.at(tree).ClassDef(
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4419
                make.Modifiers(PUBLIC | ABSTRACT),
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  4420
                names.empty, List.nil(),
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  4421
                extending, implementing, List.nil());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4422
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4423
            ClassSymbol c = (ClassSymbol)owntype.tsym;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4424
            Assert.check((c.flags() & COMPOUND) != 0);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4425
            cd.sym = c;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4426
            c.sourcefile = env.toplevel.sourcefile;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4427
06bc494ca11e Initial load
duke
parents:
diff changeset
  4428
            // ... and attribute the bound class
06bc494ca11e Initial load
duke
parents:
diff changeset
  4429
            c.flags_field |= UNATTRIBUTED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4430
            Env<AttrContext> cenv = enter.classEnv(cd, env);
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4431
            typeEnvs.put(c, cenv);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4432
            attribClass(c);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4433
            return owntype;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4434
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4435
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4436
06bc494ca11e Initial load
duke
parents:
diff changeset
  4437
    public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4438
        //- System.err.println("visitWildcard("+tree+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  4439
        Type type = (tree.kind.kind == BoundKind.UNBOUND)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4440
            ? syms.objectType
06bc494ca11e Initial load
duke
parents:
diff changeset
  4441
            : attribType(tree.inner, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4442
        result = check(tree, new WildcardType(chk.checkRefType(tree.pos(), type),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4443
                                              tree.kind.kind,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  4444
                                              syms.boundClass),
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4445
                KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4446
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4447
06bc494ca11e Initial load
duke
parents:
diff changeset
  4448
    public void visitAnnotation(JCAnnotation tree) {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4449
        Assert.error("should be handled in annotate");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4450
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4451
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4452
    public void visitAnnotatedType(JCAnnotatedType tree) {
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4453
        attribAnnotationTypes(tree.annotations, env);
31560
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  4454
        Type underlyingType = attribType(tree.underlyingType, env);
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4455
        Type annotatedType = underlyingType.annotatedType(Annotations.TO_BE_SET);
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4456
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4457
        if (!env.info.isNewClass)
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4458
            annotate.annotateTypeSecondStage(tree, tree.annotations, annotatedType);
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4459
        result = tree.type = annotatedType;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4460
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4461
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4462
    public void visitErroneous(JCErroneous tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4463
        if (tree.errs != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4464
            for (JCTree err : tree.errs)
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4465
                attribTree(err, env, new ResultInfo(KindSelector.ERR, pt()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4466
        result = tree.type = syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4467
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4468
06bc494ca11e Initial load
duke
parents:
diff changeset
  4469
    /** Default visitor method for all other trees.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4470
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4471
    public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4472
        throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4473
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4474
8845
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4475
    /**
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4476
     * Attribute an env for either a top level tree or class or module declaration.
8845
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4477
     */
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4478
    public void attrib(Env<AttrContext> env) {
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4479
        switch (env.tree.getTag()) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4480
            case MODULEDEF:
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4481
                attribModule(env.tree.pos(), ((JCModuleDecl)env.tree).sym);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4482
                break;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4483
            case TOPLEVEL:
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4484
                attribTopLevel(env);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4485
                break;
40313
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4486
            case PACKAGEDEF:
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4487
                attribPackage(env.tree.pos(), ((JCPackageDecl) env.tree).packge);
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4488
                break;
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4489
            default:
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4490
                attribClass(env.tree.pos(), env.enclClass.sym);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4491
        }
8845
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4492
    }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4493
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4494
    /**
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4495
     * Attribute a top level tree. These trees are encountered when the
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4496
     * package declaration has annotations.
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4497
     */
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4498
    public void attribTopLevel(Env<AttrContext> env) {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4499
        JCCompilationUnit toplevel = env.toplevel;
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4500
        try {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4501
            annotate.flush();
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4502
        } catch (CompletionFailure ex) {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4503
            chk.completionError(toplevel.pos(), ex);
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4504
        }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4505
    }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4506
40313
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4507
    public void attribPackage(DiagnosticPosition pos, PackageSymbol p) {
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4508
        try {
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4509
            annotate.flush();
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4510
            attribPackage(p);
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4511
        } catch (CompletionFailure ex) {
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4512
            chk.completionError(pos, ex);
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4513
        }
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4514
    }
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4515
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4516
    void attribPackage(PackageSymbol p) {
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4517
        Env<AttrContext> env = typeEnvs.get(p);
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4518
        chk.checkDeprecatedAnnotation(((JCPackageDecl) env.tree).pid.pos(), p);
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4519
    }
a85f92c9a8ab 8068626: Add javac lint warning when the @Deprecated annotation is used where it is a no-op
sadayapalam
parents: 39920
diff changeset
  4520
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4521
    public void attribModule(DiagnosticPosition pos, ModuleSymbol m) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4522
        try {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4523
            annotate.flush();
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4524
            attribModule(m);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4525
        } catch (CompletionFailure ex) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4526
            chk.completionError(pos, ex);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4527
        }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4528
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4529
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4530
    void attribModule(ModuleSymbol m) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4531
        // Get environment current at the point of module definition.
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4532
        Env<AttrContext> env = enter.typeEnvs.get(m);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4533
        attribStat(env.tree, env);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4534
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4535
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4536
    /** Main method: attribute class definition associated with given class symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4537
     *  reporting completion failures at the given position.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4538
     *  @param pos The source position at which completion errors are to be
06bc494ca11e Initial load
duke
parents:
diff changeset
  4539
     *             reported.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4540
     *  @param c   The class symbol whose definition will be attributed.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4541
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4542
    public void attribClass(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4543
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4544
            annotate.flush();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4545
            attribClass(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4546
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4547
            chk.completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4548
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4549
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4550
06bc494ca11e Initial load
duke
parents:
diff changeset
  4551
    /** Attribute class definition associated with given class symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4552
     *  @param c   The class symbol whose definition will be attributed.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4553
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4554
    void attribClass(ClassSymbol c) throws CompletionFailure {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4555
        if (c.type.hasTag(ERROR)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4556
06bc494ca11e Initial load
duke
parents:
diff changeset
  4557
        // Check for cycles in the inheritance graph, which can arise from
06bc494ca11e Initial load
duke
parents:
diff changeset
  4558
        // ill-formed class files.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4559
        chk.checkNonCyclic(null, c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4560
06bc494ca11e Initial load
duke
parents:
diff changeset
  4561
        Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4562
        if ((c.flags_field & Flags.COMPOUND) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4563
            // First, attribute superclass.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4564
            if (st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4565
                attribClass((ClassSymbol)st.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4566
06bc494ca11e Initial load
duke
parents:
diff changeset
  4567
            // Next attribute owner, if it is a class.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4568
            if (c.owner.kind == TYP && c.owner.type.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4569
                attribClass((ClassSymbol)c.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4570
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4571
06bc494ca11e Initial load
duke
parents:
diff changeset
  4572
        // The previous operations might have attributed the current class
06bc494ca11e Initial load
duke
parents:
diff changeset
  4573
        // if there was a cycle. So we test first whether the class is still
06bc494ca11e Initial load
duke
parents:
diff changeset
  4574
        // UNATTRIBUTED.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4575
        if ((c.flags_field & UNATTRIBUTED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4576
            c.flags_field &= ~UNATTRIBUTED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4577
06bc494ca11e Initial load
duke
parents:
diff changeset
  4578
            // Get environment current at the point of class definition.
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4579
            Env<AttrContext> env = typeEnvs.get(c);
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4580
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4581
            // The info.lint field in the envs stored in typeEnvs is deliberately uninitialized,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4582
            // because the annotations were not available at the time the env was created. Therefore,
06bc494ca11e Initial load
duke
parents:
diff changeset
  4583
            // we look up the environment chain for the first enclosing environment for which the
06bc494ca11e Initial load
duke
parents:
diff changeset
  4584
            // lint value is set. Typically, this is the parent env, but might be further if there
06bc494ca11e Initial load
duke
parents:
diff changeset
  4585
            // are any envs created as a result of TypeParameter nodes.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4586
            Env<AttrContext> lintEnv = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4587
            while (lintEnv.info.lint == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4588
                lintEnv = lintEnv.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4589
06bc494ca11e Initial load
duke
parents:
diff changeset
  4590
            // Having found the enclosing lint value, we can initialize the lint value for this class
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  4591
            env.info.lint = lintEnv.info.lint.augment(c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4592
06bc494ca11e Initial load
duke
parents:
diff changeset
  4593
            Lint prevLint = chk.setLint(env.info.lint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4594
            JavaFileObject prev = log.useSource(c.sourcefile);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4595
            ResultInfo prevReturnRes = env.info.returnResult;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4596
06bc494ca11e Initial load
duke
parents:
diff changeset
  4597
            try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  4598
                deferredLintHandler.flush(env.tree);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4599
                env.info.returnResult = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4600
                // java.lang.Enum may not be subclassed by a non-enum
06bc494ca11e Initial load
duke
parents:
diff changeset
  4601
                if (st.tsym == syms.enumSym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4602
                    ((c.flags_field & (Flags.ENUM|Flags.COMPOUND)) == 0))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4603
                    log.error(env.tree.pos(), Errors.EnumNoSubclassing);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4604
06bc494ca11e Initial load
duke
parents:
diff changeset
  4605
                // Enums may not be extended by source-level classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  4606
                if (st.tsym != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4607
                    ((st.tsym.flags_field & Flags.ENUM) != 0) &&
16558
07c08ad4a700 8010179: Remove transitional target values from javac
darcy
parents: 16557
diff changeset
  4608
                    ((c.flags_field & (Flags.ENUM | Flags.COMPOUND)) == 0)) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4609
                    log.error(env.tree.pos(), Errors.EnumTypesNotExtensible);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4610
                }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4611
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4612
                if (isSerializable(c.type)) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4613
                    env.info.isSerializable = true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4614
                }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4615
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4616
                attribClassBody(env, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4617
06bc494ca11e Initial load
duke
parents:
diff changeset
  4618
                chk.checkDeprecatedAnnotation(env.tree.pos(), c);
16333
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16331
diff changeset
  4619
                chk.checkClassOverrideEqualsAndHashIfNeeded(env.tree.pos(), c);
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  4620
                chk.checkFunctionalInterface((JCClassDecl) env.tree, c);
41444
b61c805c6173 8153362: Add javac -Xlint warning to list exposed types which are not accessible
jlahoda
parents: 41156
diff changeset
  4621
                chk.checkLeaksNotAccessible(env, (JCClassDecl) env.tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4622
            } finally {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4623
                env.info.returnResult = prevReturnRes;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4624
                log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4625
                chk.setLint(prevLint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4626
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4627
06bc494ca11e Initial load
duke
parents:
diff changeset
  4628
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4629
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4630
06bc494ca11e Initial load
duke
parents:
diff changeset
  4631
    public void visitImport(JCImport tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4632
        // nothing to do
06bc494ca11e Initial load
duke
parents:
diff changeset
  4633
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4634
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4635
    public void visitModuleDef(JCModuleDecl tree) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4636
        tree.sym.completeUsesProvides();
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4637
        ModuleSymbol msym = tree.sym;
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4638
        Lint lint = env.outer.info.lint = env.outer.info.lint.augment(msym);
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4639
        Lint prevLint = chk.setLint(lint);
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents: 42416
diff changeset
  4640
        chk.checkModuleName(tree);
42407
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4641
        chk.checkDeprecatedAnnotation(tree, msym);
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4642
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4643
        try {
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4644
            deferredLintHandler.flush(tree.pos());
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4645
        } finally {
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4646
            chk.setLint(prevLint);
f3702cff2933 8169069: Module system implementation refresh (11/2016)
alanb
parents: 41932
diff changeset
  4647
        }
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4648
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  4649
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4650
    /** Finish the attribution of a class. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4651
    private void attribClassBody(Env<AttrContext> env, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4652
        JCClassDecl tree = (JCClassDecl)env.tree;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4653
        Assert.check(c == tree.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4654
06bc494ca11e Initial load
duke
parents:
diff changeset
  4655
        // Validate type parameters, supertype and interfaces.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4656
        attribStats(tree.typarams, env);
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4657
        if (!c.isAnonymous()) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4658
            //already checked if anonymous
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4659
            chk.validate(tree.typarams, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4660
            chk.validate(tree.extending, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4661
            chk.validate(tree.implementing, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4662
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4663
28459
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 28456
diff changeset
  4664
        c.markAbstractIfNeeded(types);
48a68a485760 8068517: Compiler may generate wrong InnerClasses attribute for static enum reference
jlahoda
parents: 28456
diff changeset
  4665
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4666
        // If this is a non-abstract class, check that it has no abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  4667
        // methods or unimplemented methods of an implemented interface.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4668
        if ((c.flags() & (ABSTRACT | INTERFACE)) == 0) {
36153
ed5063b304be 8149600: javac, remove unused options, step 2
vromero
parents: 35423
diff changeset
  4669
            chk.checkAllDefined(tree.pos(), c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4670
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4671
06bc494ca11e Initial load
duke
parents:
diff changeset
  4672
        if ((c.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4673
            if (tree.implementing.nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  4674
                log.error(tree.implementing.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4675
                          Errors.CantExtendIntfAnnotation);
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4676
            if (tree.typarams.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4677
                log.error(tree.typarams.head.pos(),
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4678
                          Errors.IntfAnnotationCantHaveTypeParams(c));
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4679
            }
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4680
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4681
            // If this annotation type has a @Repeatable, validate
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4682
            Attribute.Compound repeatable = c.getAnnotationTypeMetadata().getRepeatable();
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  4683
            // If this annotation type has a @Repeatable, validate
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4684
            if (repeatable != null) {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4685
                // get diagnostic position for error reporting
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4686
                DiagnosticPosition cbPos = getDiagnosticPosition(tree, repeatable.type);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4687
                Assert.checkNonNull(cbPos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4688
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4689
                chk.validateRepeatable(c, repeatable, cbPos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4690
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4691
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4692
            // Check that all extended classes and interfaces
06bc494ca11e Initial load
duke
parents:
diff changeset
  4693
            // are compatible (i.e. no two define methods with same arguments
06bc494ca11e Initial load
duke
parents:
diff changeset
  4694
            // yet different return types).  (JLS 8.4.6.3)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4695
            chk.checkCompatibleSupertypes(tree.pos(), c.type);
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4696
            if (allowDefaultMethods) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4697
                chk.checkDefaultMethodClashes(tree.pos(), c.type);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4698
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4699
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4700
06bc494ca11e Initial load
duke
parents:
diff changeset
  4701
        // Check that class does not import the same parameterized interface
06bc494ca11e Initial load
duke
parents:
diff changeset
  4702
        // with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4703
        chk.checkClassBounds(tree.pos(), c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4704
06bc494ca11e Initial load
duke
parents:
diff changeset
  4705
        tree.type = c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4706
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4707
        for (List<JCTypeParameter> l = tree.typarams;
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4708
             l.nonEmpty(); l = l.tail) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4709
             Assert.checkNonNull(env.info.scope.findFirst(l.head.name));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4710
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4711
06bc494ca11e Initial load
duke
parents:
diff changeset
  4712
        // Check that a generic class doesn't extend Throwable
06bc494ca11e Initial load
duke
parents:
diff changeset
  4713
        if (!c.type.allparams().isEmpty() && types.isSubtype(c.type, syms.throwableType))
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4714
            log.error(tree.extending.pos(), Errors.GenericThrowable);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4715
06bc494ca11e Initial load
duke
parents:
diff changeset
  4716
        // Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  4717
        // method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4718
        chk.checkImplementations(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4719
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4720
        //check that a resource implementing AutoCloseable cannot throw InterruptedException
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4721
        checkAutoCloseable(tree.pos(), env, c.type);
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4722
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4723
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4724
            // Attribute declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
  4725
            attribStat(l.head, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4726
            // Check that declarations in inner classes are not static (JLS 8.1.2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4727
            // Make an exception for static constants.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4728
            if (c.owner.kind != PCK &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4729
                ((c.flags() & STATIC) == 0 || c.name == names.empty) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4730
                (TreeInfo.flags(l.head) & (STATIC | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4731
                Symbol sym = null;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4732
                if (l.head.hasTag(VARDEF)) sym = ((JCVariableDecl) l.head).sym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4733
                if (sym == null ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  4734
                    sym.kind != VAR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  4735
                    ((VarSymbol) sym).getConstValue() == null)
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4736
                    log.error(l.head.pos(), Errors.IclsCantHaveStaticDecl(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4737
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4738
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4739
06bc494ca11e Initial load
duke
parents:
diff changeset
  4740
        // Check for cycles among non-initial constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4741
        chk.checkCyclicConstructors(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4742
06bc494ca11e Initial load
duke
parents:
diff changeset
  4743
        // Check for cycles among annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4744
        chk.checkNonCyclicElements(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4745
06bc494ca11e Initial load
duke
parents:
diff changeset
  4746
        // Check for proper use of serialVersionUID
37634
a5f740ef93f2 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
alundblad
parents: 36713
diff changeset
  4747
        if (env.info.lint.isEnabled(LintCategory.SERIAL)
a5f740ef93f2 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
alundblad
parents: 36713
diff changeset
  4748
                && isSerializable(c.type)
a5f740ef93f2 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
alundblad
parents: 36713
diff changeset
  4749
                && (c.flags() & Flags.ENUM) == 0
a5f740ef93f2 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
alundblad
parents: 36713
diff changeset
  4750
                && !c.isAnonymous()
a5f740ef93f2 7152104: javac should not warn about missing serialVersionUID for anonymous inner classes
alundblad
parents: 36713
diff changeset
  4751
                && checkForSerial(c)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4752
            checkSerialVersionUID(tree, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4753
        }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4754
        if (allowTypeAnnos) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4755
            // Correctly organize the postions of the type annotations
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4756
            typeAnnotations.organizeTypeAnnotationsBodies(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4757
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4758
            // Check type annotations applicability rules
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4759
            validateTypeAnnotations(tree, false);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4760
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4761
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4762
        // where
18899
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4763
        boolean checkForSerial(ClassSymbol c) {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4764
            if ((c.flags() & ABSTRACT) == 0) {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4765
                return true;
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4766
            } else {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4767
                return c.members().anyMatch(anyNonAbstractOrDefaultMethod);
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4768
            }
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4769
        }
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4770
42827
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  4771
        public static final Filter<Symbol> anyNonAbstractOrDefaultMethod = s ->
36468b5fa7f4 8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents: 42822
diff changeset
  4772
                s.kind == MTH && (s.flags() & (DEFAULT | ABSTRACT)) != ABSTRACT;
18899
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4773
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4774
        /** get a diagnostic position for an attribute of Type t, or null if attribute missing */
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4775
        private DiagnosticPosition getDiagnosticPosition(JCClassDecl tree, Type t) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4776
            for(List<JCAnnotation> al = tree.mods.annotations; !al.isEmpty(); al = al.tail) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4777
                if (types.isSameType(al.head.annotationType.type, t))
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4778
                    return al.head.pos();
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4779
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4780
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4781
            return null;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4782
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4783
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4784
        /** check if a type is a subtype of Serializable, if that is available. */
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4785
        boolean isSerializable(Type t) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4786
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4787
                syms.serializableType.complete();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4788
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4789
            catch (CompletionFailure e) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4790
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4791
            }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4792
            return types.isSubtype(t, syms.serializableType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4793
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4794
06bc494ca11e Initial load
duke
parents:
diff changeset
  4795
        /** Check that an appropriate serialVersionUID member is defined. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4796
        private void checkSerialVersionUID(JCClassDecl tree, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4797
06bc494ca11e Initial load
duke
parents:
diff changeset
  4798
            // check for presence of serialVersionUID
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4799
            VarSymbol svuid = null;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4800
            for (Symbol sym : c.members().getSymbolsByName(names.serialVersionUID)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4801
                if (sym.kind == VAR) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4802
                    svuid = (VarSymbol)sym;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4803
                    break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4804
                }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4805
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4806
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4807
            if (svuid == null) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4808
                log.warning(LintCategory.SERIAL,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4809
                        tree.pos(), Warnings.MissingSVUID(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4810
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4811
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4812
06bc494ca11e Initial load
duke
parents:
diff changeset
  4813
            // check that it is static final
06bc494ca11e Initial load
duke
parents:
diff changeset
  4814
            if ((svuid.flags() & (STATIC | FINAL)) !=
06bc494ca11e Initial load
duke
parents:
diff changeset
  4815
                (STATIC | FINAL))
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4816
                log.warning(LintCategory.SERIAL,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4817
                        TreeInfo.diagnosticPositionFor(svuid, tree), Warnings.ImproperSVUID(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4818
06bc494ca11e Initial load
duke
parents:
diff changeset
  4819
            // check that it is long
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4820
            else if (!svuid.type.hasTag(LONG))
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4821
                log.warning(LintCategory.SERIAL,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4822
                        TreeInfo.diagnosticPositionFor(svuid, tree), Warnings.LongSVUID(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4823
06bc494ca11e Initial load
duke
parents:
diff changeset
  4824
            // check constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  4825
            else if (svuid.getConstValue() == null)
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4826
                log.warning(LintCategory.SERIAL,
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  4827
                        TreeInfo.diagnosticPositionFor(svuid, tree), Warnings.ConstantSVUID(c));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4828
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4829
06bc494ca11e Initial load
duke
parents:
diff changeset
  4830
    private Type capture(Type type) {
18911
dcc1e26a8c9c 8012238: Nested method capture and inference
mcimadamore
parents: 18910
diff changeset
  4831
        return types.capture(type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4832
    }
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  4833
47318
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4834
    private void setSyntheticVariableType(JCVariableDecl tree, Type type) {
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4835
        if (type.isErroneous()) {
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4836
            tree.vartype = make.at(Position.NOPOS).Erroneous();
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4837
        } else {
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4838
            tree.vartype = make.at(Position.NOPOS).Type(type);
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4839
        }
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4840
    }
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  4841
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4842
    public void validateTypeAnnotations(JCTree tree, boolean sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4843
        tree.accept(new TypeAnnotationsValidator(sigOnly));
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4844
    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4845
    //where
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4846
    private final class TypeAnnotationsValidator extends TreeScanner {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4847
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4848
        private final boolean sigOnly;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4849
        public TypeAnnotationsValidator(boolean sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4850
            this.sigOnly = sigOnly;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4851
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4852
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4853
        public void visitAnnotation(JCAnnotation tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4854
            chk.validateTypeAnnotation(tree, false);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4855
            super.visitAnnotation(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4856
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4857
        public void visitAnnotatedType(JCAnnotatedType tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4858
            if (!tree.underlyingType.type.isErroneous()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4859
                super.visitAnnotatedType(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4860
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4861
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4862
        public void visitTypeParameter(JCTypeParameter tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4863
            chk.validateTypeAnnotations(tree.annotations, true);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4864
            scan(tree.bounds);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4865
            // Don't call super.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4866
            // This is needed because above we call validateTypeAnnotation with
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4867
            // false, which would forbid annotations on type parameters.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4868
            // super.visitTypeParameter(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4869
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4870
        public void visitMethodDef(JCMethodDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4871
            if (tree.recvparam != null &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4872
                    !tree.recvparam.vartype.type.isErroneous()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4873
                checkForDeclarationAnnotations(tree.recvparam.mods.annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4874
                        tree.recvparam.vartype.type.tsym);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4875
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4876
            if (tree.restype != null && tree.restype.type != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4877
                validateAnnotatedType(tree.restype, tree.restype.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4878
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4879
            if (sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4880
                scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4881
                scan(tree.restype);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4882
                scan(tree.typarams);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4883
                scan(tree.recvparam);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4884
                scan(tree.params);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4885
                scan(tree.thrown);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4886
            } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4887
                scan(tree.defaultValue);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4888
                scan(tree.body);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4889
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4890
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4891
        public void visitVarDef(final JCVariableDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4892
            //System.err.println("validateTypeAnnotations.visitVarDef " + tree);
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  4893
            if (tree.sym != null && tree.sym.type != null && !tree.isImplicitlyTyped())
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4894
                validateAnnotatedType(tree.vartype, tree.sym.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4895
            scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4896
            scan(tree.vartype);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4897
            if (!sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4898
                scan(tree.init);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4899
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4900
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4901
        public void visitTypeCast(JCTypeCast tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4902
            if (tree.clazz != null && tree.clazz.type != null)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4903
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4904
            super.visitTypeCast(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4905
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4906
        public void visitTypeTest(JCInstanceOf tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4907
            if (tree.clazz != null && tree.clazz.type != null)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4908
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4909
            super.visitTypeTest(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4910
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4911
        public void visitNewClass(JCNewClass tree) {
27851
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4912
            if (tree.clazz != null && tree.clazz.type != null) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4913
                if (tree.clazz.hasTag(ANNOTATED_TYPE)) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4914
                    checkForDeclarationAnnotations(((JCAnnotatedType) tree.clazz).annotations,
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4915
                            tree.clazz.type.tsym);
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4916
                }
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4917
                if (tree.def != null) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4918
                    checkForDeclarationAnnotations(tree.def.mods.annotations, tree.clazz.type.tsym);
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4919
                }
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4920
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4921
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4922
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4923
            super.visitNewClass(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4924
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4925
        public void visitNewArray(JCNewArray tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4926
            if (tree.elemtype != null && tree.elemtype.type != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4927
                if (tree.elemtype.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4928
                    checkForDeclarationAnnotations(((JCAnnotatedType) tree.elemtype).annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4929
                            tree.elemtype.type.tsym);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4930
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4931
                validateAnnotatedType(tree.elemtype, tree.elemtype.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4932
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4933
            super.visitNewArray(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4934
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4935
        public void visitClassDef(JCClassDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4936
            //System.err.println("validateTypeAnnotations.visitClassDef " + tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4937
            if (sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4938
                scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4939
                scan(tree.typarams);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4940
                scan(tree.extending);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4941
                scan(tree.implementing);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4942
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4943
            for (JCTree member : tree.defs) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4944
                if (member.hasTag(Tag.CLASSDEF)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4945
                    continue;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4946
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4947
                scan(member);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4948
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4949
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4950
        public void visitBlock(JCBlock tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4951
            if (!sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4952
                scan(tree.stats);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4953
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4954
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4955
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4956
        /* I would want to model this after
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4957
         * com.sun.tools.javac.comp.Check.Validator.visitSelectInternal(JCFieldAccess)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4958
         * and override visitSelect and visitTypeApply.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4959
         * However, we only set the annotated type in the top-level type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4960
         * of the symbol.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4961
         * Therefore, we need to override each individual location where a type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4962
         * can occur.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4963
         */
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4964
        private void validateAnnotatedType(final JCTree errtree, final Type type) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4965
            //System.err.println("Attr.validateAnnotatedType: " + errtree + " type: " + type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4966
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4967
            if (type.isPrimitiveOrVoid()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4968
                return;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4969
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4970
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4971
            JCTree enclTr = errtree;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4972
            Type enclTy = type;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4973
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4974
            boolean repeat = true;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4975
            while (repeat) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4976
                if (enclTr.hasTag(TYPEAPPLY)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4977
                    List<Type> tyargs = enclTy.getTypeArguments();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4978
                    List<JCExpression> trargs = ((JCTypeApply)enclTr).getTypeArguments();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4979
                    if (trargs.length() > 0) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4980
                        // Nothing to do for diamonds
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4981
                        if (tyargs.length() == trargs.length()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4982
                            for (int i = 0; i < tyargs.length(); ++i) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4983
                                validateAnnotatedType(trargs.get(i), tyargs.get(i));
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4984
                            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4985
                        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4986
                        // If the lengths don't match, it's either a diamond
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4987
                        // or some nested type that redundantly provides
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4988
                        // type arguments in the tree.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4989
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4990
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4991
                    // Look at the clazz part of a generic type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4992
                    enclTr = ((JCTree.JCTypeApply)enclTr).clazz;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4993
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4994
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4995
                if (enclTr.hasTag(SELECT)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4996
                    enclTr = ((JCTree.JCFieldAccess)enclTr).getExpression();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4997
                    if (enclTy != null &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4998
                            !enclTy.hasTag(NONE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4999
                        enclTy = enclTy.getEnclosingType();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5000
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5001
                } else if (enclTr.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5002
                    JCAnnotatedType at = (JCTree.JCAnnotatedType) enclTr;
31560
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5003
                    if (enclTy == null || enclTy.hasTag(NONE)) {
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5004
                        if (at.getAnnotations().size() == 1) {
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  5005
                            log.error(at.underlyingType.pos(), Errors.CantTypeAnnotateScoping1(at.getAnnotations().head.attribute));
31560
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5006
                        } else {
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5007
                            ListBuffer<Attribute.Compound> comps = new ListBuffer<>();
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5008
                            for (JCAnnotation an : at.getAnnotations()) {
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5009
                                comps.add(an.attribute);
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5010
                            }
45504
ea7475564d07 8170326: Inconsistencies between code, compiler.properties and comments
jlahoda
parents: 44571
diff changeset
  5011
                            log.error(at.underlyingType.pos(), Errors.CantTypeAnnotateScoping(comps.toList()));
31560
3a71b9271010 8130745: Revert fix pushed for JDK-8074346
sadayapalam
parents: 31212
diff changeset
  5012
                        }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5013
                        repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5014
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5015
                    enclTr = at.underlyingType;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5016
                    // enclTy doesn't need to be changed
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5017
                } else if (enclTr.hasTag(IDENT)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5018
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5019
                } else if (enclTr.hasTag(JCTree.Tag.WILDCARD)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5020
                    JCWildcard wc = (JCWildcard) enclTr;
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  5021
                    if (wc.getKind() == JCTree.Kind.EXTENDS_WILDCARD ||
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  5022
                            wc.getKind() == JCTree.Kind.SUPER_WILDCARD) {
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  5023
                        validateAnnotatedType(wc.getBound(), wc.getBound().type);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5024
                    } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5025
                        // Nothing to do for UNBOUND
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5026
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5027
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5028
                } else if (enclTr.hasTag(TYPEARRAY)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5029
                    JCArrayTypeTree art = (JCArrayTypeTree) enclTr;
47268
48ec75306997 8177466: Add compiler support for local variable type-inference
mcimadamore
parents: 47248
diff changeset
  5030
                    validateAnnotatedType(art.getType(), art.elemtype.type);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5031
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5032
                } else if (enclTr.hasTag(TYPEUNION)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5033
                    JCTypeUnion ut = (JCTypeUnion) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5034
                    for (JCTree t : ut.getTypeAlternatives()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5035
                        validateAnnotatedType(t, t.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5036
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5037
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5038
                } else if (enclTr.hasTag(TYPEINTERSECTION)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5039
                    JCTypeIntersection it = (JCTypeIntersection) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5040
                    for (JCTree t : it.getBounds()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5041
                        validateAnnotatedType(t, t.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5042
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5043
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5044
                } else if (enclTr.getKind() == JCTree.Kind.PRIMITIVE_TYPE ||
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5045
                           enclTr.getKind() == JCTree.Kind.ERRONEOUS) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5046
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5047
                } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5048
                    Assert.error("Unexpected tree: " + enclTr + " with kind: " + enclTr.getKind() +
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5049
                            " within: "+ errtree + " with kind: " + errtree.getKind());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5050
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5051
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5052
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5053
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5054
        private void checkForDeclarationAnnotations(List<? extends JCAnnotation> annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5055
                Symbol sym) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5056
            // Ensure that no declaration annotations are present.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5057
            // Note that a tree type might be an AnnotatedType with
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5058
            // empty annotations, if only declaration annotations were given.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5059
            // This method will raise an error for such a type.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5060
            for (JCAnnotation ai : annotations) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5061
                if (!ai.type.isErroneous() &&
29842
826ac2519523 8031744: Annotations on many Language Model elements are not returned
jjg
parents: 29776
diff changeset
  5062
                        typeAnnotations.annotationTargetType(ai.attribute, sym) == TypeAnnotations.AnnotationType.DECLARATION) {
29959
61bfc66866da 8073534: Confusing / incorrect error message regarding annotations on non-declarations
alundblad
parents: 29842
diff changeset
  5063
                    log.error(ai.pos(), Errors.AnnotationTypeNotApplicableToType(ai.type));
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5064
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5065
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5066
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5067
    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  5068
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5069
    // <editor-fold desc="post-attribution visitor">
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5070
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5071
    /**
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5072
     * Handle missing types/symbols in an AST. This routine is useful when
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5073
     * the compiler has encountered some errors (which might have ended up
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5074
     * terminating attribution abruptly); if the compiler is used in fail-over
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5075
     * mode (e.g. by an IDE) and the AST contains semantic errors, this routine
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5076
     * prevents NPE to be progagated during subsequent compilation steps.
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5077
     */
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  5078
    public void postAttr(JCTree tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  5079
        new PostAttrAnalyzer().scan(tree);
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5080
    }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5081
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5082
    class PostAttrAnalyzer extends TreeScanner {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5083
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5084
        private void initTypeIfNeeded(JCTree that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5085
            if (that.type == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5086
                if (that.hasTag(METHODDEF)) {
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5087
                    that.type = dummyMethodType((JCMethodDecl)that);
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5088
                } else {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5089
                    that.type = syms.unknownType;
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5090
                }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5091
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5092
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5093
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5094
        /* Construct a dummy method type. If we have a method declaration,
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5095
         * and the declared return type is void, then use that return type
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5096
         * instead of UNKNOWN to avoid spurious error messages in lambda
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5097
         * bodies (see:JDK-8041704).
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5098
         */
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5099
        private Type dummyMethodType(JCMethodDecl md) {
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5100
            Type restype = syms.unknownType;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5101
            if (md != null && md.restype.hasTag(TYPEIDENT)) {
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5102
                JCPrimitiveTypeTree prim = (JCPrimitiveTypeTree)md.restype;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5103
                if (prim.typetag == VOID)
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5104
                    restype = syms.voidType;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5105
            }
42828
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  5106
            return new MethodType(List.nil(), restype,
cce89649f958 8171371: Remove redundant type-arguments from generic method calls
mcimadamore
parents: 42827
diff changeset
  5107
                                  List.nil(), syms.methodClass);
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5108
        }
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5109
        private Type dummyMethodType() {
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  5110
            return dummyMethodType(null);
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5111
        }
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5112
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5113
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5114
        public void scan(JCTree tree) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5115
            if (tree == null) return;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5116
            if (tree instanceof JCExpression) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5117
                initTypeIfNeeded(tree);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5118
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5119
            super.scan(tree);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5120
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5121
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5122
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5123
        public void visitIdent(JCIdent that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5124
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5125
                that.sym = syms.unknownSymbol;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5126
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5127
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5128
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5129
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5130
        public void visitSelect(JCFieldAccess that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5131
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5132
                that.sym = syms.unknownSymbol;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5133
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5134
            super.visitSelect(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5135
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5136
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5137
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5138
        public void visitClassDef(JCClassDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5139
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5140
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5141
                that.sym = new ClassSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5142
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5143
            super.visitClassDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5144
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5145
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5146
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5147
        public void visitMethodDef(JCMethodDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5148
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5149
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5150
                that.sym = new MethodSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5151
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5152
            super.visitMethodDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5153
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5154
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5155
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5156
        public void visitVarDef(JCVariableDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5157
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5158
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5159
                that.sym = new VarSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5160
                that.sym.adr = 0;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5161
            }
44060
f420de7e26fa 8175790: field JCVariableDecl.vartype can't be null after post attribution analysis
vromero
parents: 43761
diff changeset
  5162
            if (that.vartype == null) {
47318
423f5e46016e 8188225: AST could be improved in presence of var types.
jlahoda
parents: 47315
diff changeset
  5163
                that.vartype = make.at(Position.NOPOS).Erroneous();
44060
f420de7e26fa 8175790: field JCVariableDecl.vartype can't be null after post attribution analysis
vromero
parents: 43761
diff changeset
  5164
            }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5165
            super.visitVarDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5166
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5167
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5168
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5169
        public void visitNewClass(JCNewClass that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5170
            if (that.constructor == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5171
                that.constructor = new MethodSymbol(0, names.init,
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5172
                        dummyMethodType(), syms.noSymbol);
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5173
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5174
            if (that.constructorType == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5175
                that.constructorType = syms.unknownType;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5176
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5177
            super.visitNewClass(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5178
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5179
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5180
        @Override
10187
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  5181
        public void visitAssignop(JCAssignOp that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5182
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5183
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5184
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5185
            }
10187
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  5186
            super.visitAssignop(that);
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  5187
        }
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  5188
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  5189
        @Override
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5190
        public void visitBinary(JCBinary that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5191
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5192
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5193
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5194
            }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5195
            super.visitBinary(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5196
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5197
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5198
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5199
        public void visitUnary(JCUnary that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5200
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5201
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5202
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5203
            }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5204
            super.visitUnary(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5205
        }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5206
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5207
        @Override
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5208
        public void visitLambda(JCLambda that) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5209
            super.visitLambda(that);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5210
            if (that.targets == null) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5211
                that.targets = List.nil();
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5212
            }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5213
        }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5214
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5215
        @Override
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5216
        public void visitReference(JCMemberReference that) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5217
            super.visitReference(that);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5218
            if (that.sym == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5219
                that.sym = new MethodSymbol(0, names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  5220
                        syms.noSymbol);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5221
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5222
            if (that.targets == null) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5223
                that.targets = List.nil();
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  5224
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  5225
        }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5226
    }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  5227
    // </editor-fold>
36526
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5228
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5229
    public void setPackageSymbols(JCExpression pid, Symbol pkg) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5230
        new TreeScanner() {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5231
            Symbol packge = pkg;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5232
            @Override
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5233
            public void visitIdent(JCIdent that) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5234
                that.sym = packge;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5235
            }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5236
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5237
            @Override
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5238
            public void visitSelect(JCFieldAccess that) {
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5239
                that.sym = packge;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5240
                packge = packge.owner;
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5241
                super.visitSelect(that);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5242
            }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5243
        }.scan(pid);
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5244
    }
3b41f1c69604 8142968: Module System implementation
alanb
parents: 36153
diff changeset
  5245
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  5246
}