langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java
author jlahoda
Wed, 03 Dec 2014 13:46:12 +0100
changeset 27857 7e913a535736
parent 27856 d4711a6931e2
child 28142 32a6b1af81b1
permissions -rw-r--r--
7101822: Compiling depends on order of imports 7177813: Static import to local nested class fails Summary: MemberEnter overhaul - TypeEnter is split out of MemberEnter; the TypeEnter consists of several Phases which ensure actions are done in the correct order. Reviewed-by: mcimadamore, jfranck, aeremeev Contributed-by: jan.lahoda@oracle.com, maurizio.cimadamore@oracle.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
22440
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
     2
 * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    28
import java.util.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    29
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    30
import javax.lang.model.element.ElementKind;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    31
import javax.tools.JavaFileObject;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.source.tree.IdentifierTree;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
    34
import com.sun.source.tree.MemberReferenceTree.ReferenceMode;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.source.tree.MemberSelectTree;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
import com.sun.source.tree.TreeVisitor;
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
import com.sun.source.util.SimpleTreeVisitor;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    38
import com.sun.tools.javac.code.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    39
import com.sun.tools.javac.code.Lint.LintCategory;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
    40
import com.sun.tools.javac.code.Scope.WriteableScope;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    41
import com.sun.tools.javac.code.Symbol.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    42
import com.sun.tools.javac.code.Type.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    43
import com.sun.tools.javac.comp.Check.CheckContext;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    44
import com.sun.tools.javac.comp.DeferredAttr.AttrMode;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    45
import com.sun.tools.javac.comp.Infer.InferenceContext;
15705
c4124695db0c 8007463: Cleanup inference related classes
mcimadamore
parents: 15385
diff changeset
    46
import com.sun.tools.javac.comp.Infer.FreeTypeListener;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    47
import com.sun.tools.javac.jvm.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    48
import com.sun.tools.javac.tree.*;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    49
import com.sun.tools.javac.tree.JCTree.*;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
    50
import com.sun.tools.javac.tree.JCTree.JCPolyExpression.*;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    51
import com.sun.tools.javac.util.*;
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
    52
import com.sun.tools.javac.util.DefinedBy.Api;
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
    53
import com.sun.tools.javac.util.Dependencies.AttributionKind;
14258
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    54
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
8d2148961366 8000663: clean up langtools imports
jjg
parents: 14062
diff changeset
    55
import com.sun.tools.javac.util.List;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
import static com.sun.tools.javac.code.Flags.*;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    57
import static com.sun.tools.javac.code.Flags.ANNOTATION;
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    58
import static com.sun.tools.javac.code.Flags.BLOCK;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    59
import static com.sun.tools.javac.code.Kinds.*;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
    60
import static com.sun.tools.javac.code.Kinds.Kind.*;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    61
import static com.sun.tools.javac.code.TypeTag.*;
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
    62
import static com.sun.tools.javac.code.TypeTag.WILDCARD;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
    63
import static com.sun.tools.javac.tree.JCTree.Tag.*;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    64
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
/** This is the main context-dependent analysis phase in GJC. It
06bc494ca11e Initial load
duke
parents:
diff changeset
    66
 *  encompasses name resolution, type checking and constant folding as
06bc494ca11e Initial load
duke
parents:
diff changeset
    67
 *  subtasks. Some subtasks involve auxiliary classes.
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
 *  @see Check
06bc494ca11e Initial load
duke
parents:
diff changeset
    69
 *  @see Resolve
06bc494ca11e Initial load
duke
parents:
diff changeset
    70
 *  @see ConstFold
06bc494ca11e Initial load
duke
parents:
diff changeset
    71
 *  @see Infer
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    73
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5846
diff changeset
    74
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
public class Attr extends JCTree.Visitor {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
    79
    protected static final Context.Key<Attr> attrKey = new Context.Key<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
    81
    final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    82
    final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
    final Symtab syms;
06bc494ca11e Initial load
duke
parents:
diff changeset
    84
    final Resolve rs;
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
    85
    final Infer infer;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
    86
    final DeferredAttr deferredAttr;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
    final Check chk;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
    88
    final Flow flow;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
    final MemberEnter memberEnter;
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
    90
    final TypeEnter typeEnter;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    91
    final TreeMaker make;
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
    final ConstFold cfolder;
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
    final Enter enter;
06bc494ca11e Initial load
duke
parents:
diff changeset
    94
    final Target target;
06bc494ca11e Initial load
duke
parents:
diff changeset
    95
    final Types types;
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 941
diff changeset
    96
    final JCDiagnostic.Factory diags;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    97
    final Annotate annotate;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
    98
    final TypeAnnotations typeAnnotations;
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
    99
    final DeferredLintHandler deferredLintHandler;
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   100
    final TypeEnvs typeEnvs;
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   101
    final Dependencies dependencies;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
    public static Attr instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
        Attr instance = context.get(attrKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
            instance = new Attr(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   107
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
   108
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   109
06bc494ca11e Initial load
duke
parents:
diff changeset
   110
    protected Attr(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   111
        context.put(attrKey, this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   112
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 1257
diff changeset
   113
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   114
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   115
        syms = Symtab.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
        rs = Resolve.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
        chk = Check.instance(context);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   118
        flow = Flow.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   119
        memberEnter = MemberEnter.instance(context);
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
   120
        typeEnter = TypeEnter.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   121
        make = TreeMaker.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
        enter = Enter.instance(context);
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   123
        infer = Infer.instance(context);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   124
        deferredAttr = DeferredAttr.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   125
        cfolder = ConstFold.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   126
        target = Target.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
        types = Types.instance(context);
1040
c0f5acfd9d15 6730423: Diagnostic formatter should be an instance field of JCDiagnostic
mcimadamore
parents: 941
diff changeset
   128
        diags = JCDiagnostic.Factory.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   129
        annotate = Annotate.instance(context);
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   130
        typeAnnotations = TypeAnnotations.instance(context);
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
   131
        deferredLintHandler = DeferredLintHandler.instance(context);
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   132
        typeEnvs = TypeEnvs.instance(context);
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   133
        dependencies = Dependencies.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
06bc494ca11e Initial load
duke
parents:
diff changeset
   135
        Options options = Options.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   136
06bc494ca11e Initial load
duke
parents:
diff changeset
   137
        Source source = Source.instance(context);
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   138
        allowStringsInSwitch = source.allowStringsInSwitch();
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   139
        allowPoly = source.allowPoly();
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   140
        allowTypeAnnos = source.allowTypeAnnotations();
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   141
        allowLambda = source.allowLambda();
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   142
        allowDefaultMethods = source.allowDefaultMethods();
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   143
        allowStaticInterfaceMethods = source.allowStaticInterfaceMethods();
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   144
        sourceName = source.name;
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6710
diff changeset
   145
        relax = (options.isSet("-retrofit") ||
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6710
diff changeset
   146
                 options.isSet("-relax"));
7081
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   147
        findDiamonds = options.get("findDiamond") != null &&
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   148
                 source.allowDiamond();
6721
d92073844278 6988436: Cleanup javac option handling
jjg
parents: 6710
diff changeset
   149
        useBeforeDeclarationWarning = options.isSet("useBeforeDeclarationWarning");
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   150
        identifyLambdaCandidate = options.getBoolean("identifyLambdaCandidate", false);
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   151
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   152
        statInfo = new ResultInfo(KindSelector.NIL, Type.noType);
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
   153
        varAssignmentInfo = new ResultInfo(KindSelector.ASG, Type.noType);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   154
        unknownExprInfo = new ResultInfo(KindSelector.VAL, Type.noType);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   155
        unknownAnyPolyInfo = new ResultInfo(KindSelector.VAL, Infer.anyPoly);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   156
        unknownTypeInfo = new ResultInfo(KindSelector.TYP, Type.noType);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   157
        unknownTypeExprInfo = new ResultInfo(KindSelector.VAL_TYP, Type.noType);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   158
        recoveryInfo = new RecoveryInfo(deferredAttr.emptyDeferredAttrContext);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   159
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   160
06bc494ca11e Initial load
duke
parents:
diff changeset
   161
    /** Switch: relax some constraints for retrofit mode.
06bc494ca11e Initial load
duke
parents:
diff changeset
   162
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   163
    boolean relax;
06bc494ca11e Initial load
duke
parents:
diff changeset
   164
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   165
    /** Switch: support target-typing inference
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   166
     */
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   167
    boolean allowPoly;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   168
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   169
    /** Switch: support type annotations.
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   170
     */
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   171
    boolean allowTypeAnnos;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   172
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   173
    /** Switch: support lambda expressions ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   174
     */
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   175
    boolean allowLambda;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   176
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   177
    /** Switch: support default methods ?
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   178
     */
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   179
    boolean allowDefaultMethods;
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   180
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   181
    /** Switch: static interface methods enabled?
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   182
     */
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   183
    boolean allowStaticInterfaceMethods;
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
   184
7081
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   185
    /** Switch: generates a warning if diamond can be safely applied
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   186
     *  to a given new expression
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   187
     */
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   188
    boolean findDiamonds;
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   189
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   190
    /**
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   191
     * Internally enables/disables diamond finder feature
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   192
     */
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   193
    static final boolean allowDiamondFinder = true;
94cfc5b65bed 6939780: add a warning to detect diamond sites
mcimadamore
parents: 7074
diff changeset
   194
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   195
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   196
     * Switch: warn about use of variable before declaration?
06bc494ca11e Initial load
duke
parents:
diff changeset
   197
     * RFE: 6425594
06bc494ca11e Initial load
duke
parents:
diff changeset
   198
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   199
    boolean useBeforeDeclarationWarning;
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3559
diff changeset
   201
    /**
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   202
     * Switch: generate warnings whenever an anonymous inner class that is convertible
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   203
     * to a lambda expression is found
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   204
     */
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   205
    boolean identifyLambdaCandidate;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   206
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   207
    /**
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   208
     * Switch: allow strings in switch?
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   209
     */
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   210
    boolean allowStringsInSwitch;
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   211
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   212
    /**
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   213
     * Switch: name of source level; used for error reporting.
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   214
     */
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   215
    String sourceName;
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
   216
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   217
    /** Check kind and type of given tree against protokind and prototype.
06bc494ca11e Initial load
duke
parents:
diff changeset
   218
     *  If check succeeds, store type in tree and return it.
06bc494ca11e Initial load
duke
parents:
diff changeset
   219
     *  If check fails, store errType in tree and return it.
06bc494ca11e Initial load
duke
parents:
diff changeset
   220
     *  No checks are performed if the prototype is a method type.
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   221
     *  It is not necessary in this case since we know that kind and type
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   222
     *  are correct.
06bc494ca11e Initial load
duke
parents:
diff changeset
   223
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   224
     *  @param tree     The tree whose kind and type is checked
06bc494ca11e Initial load
duke
parents:
diff changeset
   225
     *  @param ownkind  The computed kind of the tree
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   226
     *  @param resultInfo  The expected result of the tree
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   227
     */
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   228
    Type check(final JCTree tree,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   229
               final Type found,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   230
               final KindSelector ownkind,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   231
               final ResultInfo resultInfo) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   232
        InferenceContext inferenceContext = resultInfo.checkContext.inferenceContext();
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   233
        Type owntype;
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   234
        if (!found.hasTag(ERROR) && !resultInfo.pt.hasTag(METHOD) && !resultInfo.pt.hasTag(FORALL)) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   235
            if (!ownkind.subset(resultInfo.pkind)) {
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   236
                log.error(tree.pos(), "unexpected.type",
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   237
                        resultInfo.pkind.kindNames(),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   238
                        ownkind.kindNames());
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   239
                owntype = types.createErrorType(found);
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   240
            } else if (allowPoly && inferenceContext.free(found)) {
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   241
                //delay the check if there are inference variables in the found type
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   242
                //this means we are dealing with a partially inferred poly expression
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   243
                owntype = resultInfo.pt;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   244
                inferenceContext.addFreeTypeListener(List.of(found, resultInfo.pt), new FreeTypeListener() {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   245
                    @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   246
                    public void typesInferred(InferenceContext inferenceContext) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   247
                        ResultInfo pendingResult =
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   248
                                resultInfo.dup(inferenceContext.asInstType(resultInfo.pt));
15705
c4124695db0c 8007463: Cleanup inference related classes
mcimadamore
parents: 15385
diff changeset
   249
                        check(tree, inferenceContext.asInstType(found), ownkind, pendingResult);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   250
                    }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   251
                });
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   252
            } else {
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   253
                owntype = resultInfo.check(tree, found);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   254
            }
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   255
        } else {
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
   256
            owntype = found;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   257
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   258
        tree.type = owntype;
06bc494ca11e Initial load
duke
parents:
diff changeset
   259
        return owntype;
06bc494ca11e Initial load
duke
parents:
diff changeset
   260
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   261
06bc494ca11e Initial load
duke
parents:
diff changeset
   262
    /** Is given blank final variable assignable, i.e. in a scope where it
06bc494ca11e Initial load
duke
parents:
diff changeset
   263
     *  may be assigned to even though it is final?
06bc494ca11e Initial load
duke
parents:
diff changeset
   264
     *  @param v      The blank final variable.
06bc494ca11e Initial load
duke
parents:
diff changeset
   265
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   266
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   267
    boolean isAssignableAsBlankFinal(VarSymbol v, Env<AttrContext> env) {
25846
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
   268
        Symbol owner = env.info.scope.owner;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   269
           // owner refers to the innermost variable, method or
06bc494ca11e Initial load
duke
parents:
diff changeset
   270
           // initializer block declaration at this point.
06bc494ca11e Initial load
duke
parents:
diff changeset
   271
        return
06bc494ca11e Initial load
duke
parents:
diff changeset
   272
            v.owner == owner
06bc494ca11e Initial load
duke
parents:
diff changeset
   273
            ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   274
            ((owner.name == names.init ||    // i.e. we are in a constructor
06bc494ca11e Initial load
duke
parents:
diff changeset
   275
              owner.kind == VAR ||           // i.e. we are in a variable initializer
06bc494ca11e Initial load
duke
parents:
diff changeset
   276
              (owner.flags() & BLOCK) != 0)  // i.e. we are in an initializer block
06bc494ca11e Initial load
duke
parents:
diff changeset
   277
             &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   278
             v.owner == owner.owner
06bc494ca11e Initial load
duke
parents:
diff changeset
   279
             &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   280
             ((v.flags() & STATIC) != 0) == Resolve.isStatic(env));
06bc494ca11e Initial load
duke
parents:
diff changeset
   281
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   282
06bc494ca11e Initial load
duke
parents:
diff changeset
   283
    /** Check that variable can be assigned to.
06bc494ca11e Initial load
duke
parents:
diff changeset
   284
     *  @param pos    The current source code position.
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
     *  @param v      The assigned varaible
06bc494ca11e Initial load
duke
parents:
diff changeset
   286
     *  @param base   If the variable is referred to in a Select, the part
06bc494ca11e Initial load
duke
parents:
diff changeset
   287
     *                to the left of the `.', null otherwise.
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
    void checkAssignable(DiagnosticPosition pos, VarSymbol v, JCTree base, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
        if ((v.flags() & FINAL) != 0 &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
            ((v.flags() & HASINIT) != 0
06bc494ca11e Initial load
duke
parents:
diff changeset
   293
             ||
06bc494ca11e Initial load
duke
parents:
diff changeset
   294
             !((base == null ||
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
   295
               (base.hasTag(IDENT) && TreeInfo.name(base) == names._this)) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   296
               isAssignableAsBlankFinal(v, env)))) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   297
            if (v.isResourceVariable()) { //TWR resource
7211
163fe60f63de 6970016: Clean up ARM/try-with-resources implementation
mcimadamore
parents: 7208
diff changeset
   298
                log.error(pos, "try.resource.may.not.be.assigned", v);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   299
            } else {
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   300
                log.error(pos, "cant.assign.val.to.final.var", v);
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   301
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   302
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   303
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   304
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
    /** Does tree represent a static reference to an identifier?
06bc494ca11e Initial load
duke
parents:
diff changeset
   306
     *  It is assumed that tree is either a SELECT or an IDENT.
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
     *  We have to weed out selects from non-type names here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   308
     *  @param tree    The candidate tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   309
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   310
    boolean isStaticReference(JCTree tree) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
   311
        if (tree.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   312
            Symbol lsym = TreeInfo.symbol(((JCFieldAccess) tree).selected);
06bc494ca11e Initial load
duke
parents:
diff changeset
   313
            if (lsym == null || lsym.kind != TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   314
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
   315
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   316
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   317
        return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
   318
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   319
06bc494ca11e Initial load
duke
parents:
diff changeset
   320
    /** Is this symbol a type?
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   322
    static boolean isType(Symbol sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
        return sym != null && sym.kind == TYP;
06bc494ca11e Initial load
duke
parents:
diff changeset
   324
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   325
06bc494ca11e Initial load
duke
parents:
diff changeset
   326
    /** The current `this' symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
   327
     *  @param env    The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   328
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   329
    Symbol thisSym(DiagnosticPosition pos, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
        return rs.resolveSelf(pos, env, env.enclClass.sym, names._this);
06bc494ca11e Initial load
duke
parents:
diff changeset
   331
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   332
06bc494ca11e Initial load
duke
parents:
diff changeset
   333
    /** Attribute a parsed identifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
   334
     * @param tree Parsed identifier name
06bc494ca11e Initial load
duke
parents:
diff changeset
   335
     * @param topLevel The toplevel to use
06bc494ca11e Initial load
duke
parents:
diff changeset
   336
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   337
    public Symbol attribIdent(JCTree tree, JCCompilationUnit topLevel) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   338
        Env<AttrContext> localEnv = enter.topLevelEnv(topLevel);
06bc494ca11e Initial load
duke
parents:
diff changeset
   339
        localEnv.enclClass = make.ClassDef(make.Modifiers(0),
06bc494ca11e Initial load
duke
parents:
diff changeset
   340
                                           syms.errSymbol.name,
06bc494ca11e Initial load
duke
parents:
diff changeset
   341
                                           null, null, null, null);
06bc494ca11e Initial load
duke
parents:
diff changeset
   342
        localEnv.enclClass.sym = syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
   343
        return tree.accept(identAttributer, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   345
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
   346
        private TreeVisitor<Symbol,Env<AttrContext>> identAttributer = new IdentAttributer();
06bc494ca11e Initial load
duke
parents:
diff changeset
   347
        private class IdentAttributer extends SimpleTreeVisitor<Symbol,Env<AttrContext>> {
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
   348
            @Override @DefinedBy(Api.COMPILER_TREE)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   349
            public Symbol visitMemberSelect(MemberSelectTree node, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   350
                Symbol site = visit(node.getExpression(), env);
19505
df0bd8ca483c 7071377: Exception when javac -processor is given a class name with invalid postfix
ksrini
parents: 19502
diff changeset
   351
                if (site.kind == ERR || site.kind == ABSENT_TYP)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   352
                    return site;
06bc494ca11e Initial load
duke
parents:
diff changeset
   353
                Name name = (Name)node.getIdentifier();
06bc494ca11e Initial load
duke
parents:
diff changeset
   354
                if (site.kind == PCK) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   355
                    env.toplevel.packge = (PackageSymbol)site;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   356
                    return rs.findIdentInPackage(env, (TypeSymbol)site, name,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   357
                            KindSelector.TYP_PCK);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   358
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   359
                    env.enclClass.sym = (ClassSymbol)site;
06bc494ca11e Initial load
duke
parents:
diff changeset
   360
                    return rs.findMemberType(env, site.asType(), name, (TypeSymbol)site);
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   362
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   363
26266
2d24bda701dc 8056061: Mark implementations of public interfaces with an annotation
jlahoda
parents: 26107
diff changeset
   364
            @Override @DefinedBy(Api.COMPILER_TREE)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   365
            public Symbol visitIdentifier(IdentifierTree node, Env<AttrContext> env) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   366
                return rs.findIdent(env, (Name)node.getName(), KindSelector.TYP_PCK);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   367
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   368
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   369
06bc494ca11e Initial load
duke
parents:
diff changeset
   370
    public Type coerce(Type etype, Type ttype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   371
        return cfolder.coerce(etype, ttype);
06bc494ca11e Initial load
duke
parents:
diff changeset
   372
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   373
06bc494ca11e Initial load
duke
parents:
diff changeset
   374
    public Type attribType(JCTree node, TypeSymbol sym) {
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
   375
        Env<AttrContext> env = typeEnvs.get(sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   376
        Env<AttrContext> localEnv = env.dup(node, env.info.dup());
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   377
        return attribTree(node, localEnv, unknownTypeInfo);
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   378
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   379
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   380
    public Type attribImportQualifier(JCImport tree, Env<AttrContext> env) {
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   381
        // Attribute qualifying package or class.
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   382
        JCFieldAccess s = (JCFieldAccess)tree.qualid;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   383
        return attribTree(s.selected, env,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   384
                          new ResultInfo(tree.staticImport ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   385
                                         KindSelector.TYP : KindSelector.TYP_PCK,
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   386
                       Type.noType));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   387
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   388
06bc494ca11e Initial load
duke
parents:
diff changeset
   389
    public Env<AttrContext> attribExprToTree(JCTree expr, Env<AttrContext> env, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   390
        breakTree = tree;
3144
202fa249dc34 6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception
mcimadamore
parents: 2723
diff changeset
   391
        JavaFileObject prev = log.useSource(env.toplevel.sourcefile);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   392
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   393
            attribExpr(expr, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   394
        } catch (BreakAttr b) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   395
            return b.env;
6587
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   396
        } catch (AssertionError ae) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   397
            if (ae.getCause() instanceof BreakAttr) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   398
                return ((BreakAttr)(ae.getCause())).env;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   399
            } else {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   400
                throw ae;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   401
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   402
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   403
            breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   404
            log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
   405
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   406
        return env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   407
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   408
06bc494ca11e Initial load
duke
parents:
diff changeset
   409
    public Env<AttrContext> attribStatToTree(JCTree stmt, Env<AttrContext> env, JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   410
        breakTree = tree;
3144
202fa249dc34 6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception
mcimadamore
parents: 2723
diff changeset
   411
        JavaFileObject prev = log.useSource(env.toplevel.sourcefile);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   412
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   413
            attribStat(stmt, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   414
        } catch (BreakAttr b) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   415
            return b.env;
6587
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   416
        } catch (AssertionError ae) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   417
            if (ae.getCause() instanceof BreakAttr) {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   418
                return ((BreakAttr)(ae.getCause())).env;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   419
            } else {
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   420
                throw ae;
344aa81a3b35 6956462: AssertionError exception thrown in the Compiler Tree API in JDK 7.
sundar
parents: 6582
diff changeset
   421
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   422
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   423
            breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   424
            log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
   425
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   426
        return env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   427
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   428
06bc494ca11e Initial load
duke
parents:
diff changeset
   429
    private JCTree breakTree = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   430
06bc494ca11e Initial load
duke
parents:
diff changeset
   431
    private static class BreakAttr extends RuntimeException {
06bc494ca11e Initial load
duke
parents:
diff changeset
   432
        static final long serialVersionUID = -6924771130405446405L;
06bc494ca11e Initial load
duke
parents:
diff changeset
   433
        private Env<AttrContext> env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   434
        private BreakAttr(Env<AttrContext> env) {
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   435
            this.env = env;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   436
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   437
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   438
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   439
    class ResultInfo {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   440
        final KindSelector pkind;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   441
        final Type pt;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   442
        final CheckContext checkContext;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   443
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   444
        ResultInfo(KindSelector pkind, Type pt) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   445
            this(pkind, pt, chk.basicHandler);
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   446
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   447
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   448
        protected ResultInfo(KindSelector pkind,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   449
                             Type pt, CheckContext checkContext) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   450
            this.pkind = pkind;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   451
            this.pt = pt;
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   452
            this.checkContext = checkContext;
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   453
        }
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   454
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   455
        protected Type check(final DiagnosticPosition pos, final Type found) {
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
   456
            return chk.checkType(pos, found, pt, checkContext);
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   457
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   458
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   459
        protected ResultInfo dup(Type newPt) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   460
            return new ResultInfo(pkind, newPt, checkContext);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   461
        }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   462
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   463
        protected ResultInfo dup(CheckContext newContext) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   464
            return new ResultInfo(pkind, pt, newContext);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   465
        }
21488
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   466
24401
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   467
        protected ResultInfo dup(Type newPt, CheckContext newContext) {
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   468
            return new ResultInfo(pkind, newPt, newContext);
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   469
        }
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
   470
21488
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   471
        @Override
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   472
        public String toString() {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   473
            if (pt != null) {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   474
                return pt.toString();
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   475
            } else {
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   476
                return "";
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   477
            }
4a69e26aa999 8025290: javac implicit versus explicit lambda compilation error
vromero
parents: 21480
diff changeset
   478
        }
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   479
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   480
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   481
    class RecoveryInfo extends ResultInfo {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   482
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   483
        public RecoveryInfo(final DeferredAttr.DeferredAttrContext deferredAttrContext) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   484
            super(KindSelector.VAL, Type.recoveryType,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   485
                  new Check.NestedCheckContext(chk.basicHandler) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   486
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   487
                public DeferredAttr.DeferredAttrContext deferredAttrContext() {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   488
                    return deferredAttrContext;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   489
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   490
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   491
                public boolean compatible(Type found, Type req, Warner warn) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   492
                    return true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   493
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   494
                @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   495
                public void report(DiagnosticPosition pos, JCDiagnostic details) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   496
                    chk.basicHandler.report(pos, details);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   497
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   498
            });
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   499
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   500
    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   501
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   502
    final ResultInfo statInfo;
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
   503
    final ResultInfo varAssignmentInfo;
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   504
    final ResultInfo unknownAnyPolyInfo;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   505
    final ResultInfo unknownExprInfo;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   506
    final ResultInfo unknownTypeInfo;
16975
124c8436d59c 8010923: Avoid redundant speculative attribution
mcimadamore
parents: 16972
diff changeset
   507
    final ResultInfo unknownTypeExprInfo;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
   508
    final ResultInfo recoveryInfo;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   509
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   510
    Type pt() {
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   511
        return resultInfo.pt;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   512
    }
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   513
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   514
    KindSelector pkind() {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   515
        return resultInfo.pkind;
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   516
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   517
06bc494ca11e Initial load
duke
parents:
diff changeset
   518
/* ************************************************************************
06bc494ca11e Initial load
duke
parents:
diff changeset
   519
 * Visitor methods
06bc494ca11e Initial load
duke
parents:
diff changeset
   520
 *************************************************************************/
06bc494ca11e Initial load
duke
parents:
diff changeset
   521
06bc494ca11e Initial load
duke
parents:
diff changeset
   522
    /** Visitor argument: the current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
   523
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   524
    Env<AttrContext> env;
06bc494ca11e Initial load
duke
parents:
diff changeset
   525
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   526
    /** Visitor argument: the currently expected attribution result.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   527
     */
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   528
    ResultInfo resultInfo;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   529
06bc494ca11e Initial load
duke
parents:
diff changeset
   530
    /** Visitor result: the computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   531
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   532
    Type result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   533
06bc494ca11e Initial load
duke
parents:
diff changeset
   534
    /** Visitor method: attribute a tree, catching any completion failure
06bc494ca11e Initial load
duke
parents:
diff changeset
   535
     *  exceptions. Return the tree's type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   536
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   537
     *  @param tree    The tree to be visited.
06bc494ca11e Initial load
duke
parents:
diff changeset
   538
     *  @param env     The environment visitor argument.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   539
     *  @param resultInfo   The result info visitor argument.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   540
     */
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   541
    Type attribTree(JCTree tree, Env<AttrContext> env, ResultInfo resultInfo) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   542
        Env<AttrContext> prevEnv = this.env;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   543
        ResultInfo prevResult = this.resultInfo;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   544
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
   545
            this.env = env;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   546
            this.resultInfo = resultInfo;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   547
            tree.accept(this);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   548
            if (tree == breakTree &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   549
                    resultInfo.checkContext.deferredAttrContext().mode == AttrMode.CHECK) {
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   550
                throw new BreakAttr(copyEnv(env));
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   551
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   552
            return result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   553
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   554
            tree.type = syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
   555
            return chk.completionError(tree.pos(), ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
   556
        } finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
   557
            this.env = prevEnv;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   558
            this.resultInfo = prevResult;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   559
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   560
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   561
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   562
    Env<AttrContext> copyEnv(Env<AttrContext> env) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   563
        Env<AttrContext> newEnv =
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   564
                env.dup(env.tree, env.info.dup(copyScope(env.info.scope)));
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   565
        if (newEnv.outer != null) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   566
            newEnv.outer = copyEnv(newEnv.outer);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   567
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   568
        return newEnv;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   569
    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   570
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   571
    WriteableScope copyScope(WriteableScope sc) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   572
        WriteableScope newScope = WriteableScope.create(sc.owner);
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   573
        List<Symbol> elemsList = List.nil();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   574
        for (Symbol sym : sc.getSymbols()) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
   575
            elemsList = elemsList.prepend(sym);
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   576
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   577
        for (Symbol s : elemsList) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   578
            newScope.enter(s);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   579
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   580
        return newScope;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   581
    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
   582
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   583
    /** Derived visitor method: attribute an expression tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   584
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   585
    public Type attribExpr(JCTree tree, Env<AttrContext> env, Type pt) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   586
        return attribTree(tree, env, new ResultInfo(KindSelector.VAL, !pt.hasTag(ERROR) ? pt : Type.noType));
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   587
    }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
   588
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   589
    /** Derived visitor method: attribute an expression tree with
06bc494ca11e Initial load
duke
parents:
diff changeset
   590
     *  no constraints on the computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
   591
     */
14541
36f9d11fc9aa 7021614: extend com.sun.source API to support parsing javadoc comments
jjg
parents: 14538
diff changeset
   592
    public Type attribExpr(JCTree tree, Env<AttrContext> env) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   593
        return attribTree(tree, env, unknownExprInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   594
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   595
06bc494ca11e Initial load
duke
parents:
diff changeset
   596
    /** Derived visitor method: attribute a type tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   597
     */
14541
36f9d11fc9aa 7021614: extend com.sun.source API to support parsing javadoc comments
jjg
parents: 14538
diff changeset
   598
    public Type attribType(JCTree tree, Env<AttrContext> env) {
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   599
        Type result = attribType(tree, env, Type.noType);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   600
        return result;
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   601
    }
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   602
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   603
    /** Derived visitor method: attribute a type tree.
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   604
     */
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   605
    Type attribType(JCTree tree, Env<AttrContext> env, Type pt) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   606
        Type result = attribTree(tree, env, new ResultInfo(KindSelector.TYP, pt));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   607
        return result;
06bc494ca11e Initial load
duke
parents:
diff changeset
   608
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   609
06bc494ca11e Initial load
duke
parents:
diff changeset
   610
    /** Derived visitor method: attribute a statement or definition tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
   611
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   612
    public Type attribStat(JCTree tree, Env<AttrContext> env) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
   613
        return attribTree(tree, env, statInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   614
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   615
06bc494ca11e Initial load
duke
parents:
diff changeset
   616
    /** Attribute a list of expressions, returning a list of types.
06bc494ca11e Initial load
duke
parents:
diff changeset
   617
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   618
    List<Type> attribExprs(List<JCExpression> trees, Env<AttrContext> env, Type pt) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
   619
        ListBuffer<Type> ts = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   620
        for (List<JCExpression> l = trees; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   621
            ts.append(attribExpr(l.head, env, pt));
06bc494ca11e Initial load
duke
parents:
diff changeset
   622
        return ts.toList();
06bc494ca11e Initial load
duke
parents:
diff changeset
   623
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   624
06bc494ca11e Initial load
duke
parents:
diff changeset
   625
    /** Attribute a list of statements, returning nothing.
06bc494ca11e Initial load
duke
parents:
diff changeset
   626
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   627
    <T extends JCTree> void attribStats(List<T> trees, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   628
        for (List<T> l = trees; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   629
            attribStat(l.head, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   630
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   631
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   632
    /** Attribute the arguments in a method call, returning the method kind.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   633
     */
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   634
    KindSelector attribArgs(KindSelector initialKind, List<JCExpression> trees, Env<AttrContext> env, ListBuffer<Type> argtypes) {
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   635
        KindSelector kind = initialKind;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   636
        for (JCExpression arg : trees) {
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   637
            Type argtype;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   638
            if (allowPoly && deferredAttr.isDeferred(env, arg)) {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   639
                argtype = deferredAttr.new DeferredType(arg, env);
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   640
                kind = KindSelector.of(KindSelector.POLY, kind);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   641
            } else {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   642
                argtype = chk.checkNonVoid(arg, attribTree(arg, env, unknownAnyPolyInfo));
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
   643
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   644
            argtypes.append(argtype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
   645
        }
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
   646
        return kind;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   647
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   648
06bc494ca11e Initial load
duke
parents:
diff changeset
   649
    /** Attribute a type argument list, returning a list of types.
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   650
     *  Caller is responsible for calling checkRefTypes.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   651
     */
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   652
    List<Type> attribAnyTypes(List<JCExpression> trees, Env<AttrContext> env) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
   653
        ListBuffer<Type> argtypes = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   654
        for (List<JCExpression> l = trees; l.nonEmpty(); l = l.tail)
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   655
            argtypes.append(attribType(l.head, env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   656
        return argtypes.toList();
06bc494ca11e Initial load
duke
parents:
diff changeset
   657
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   658
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   659
    /** Attribute a type argument list, returning a list of types.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   660
     *  Check that all the types are references.
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   661
     */
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   662
    List<Type> attribTypes(List<JCExpression> trees, Env<AttrContext> env) {
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   663
        List<Type> types = attribAnyTypes(trees, env);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   664
        return chk.checkRefTypes(trees, types);
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
   665
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   666
06bc494ca11e Initial load
duke
parents:
diff changeset
   667
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   668
     * Attribute type variables (of generic classes or methods).
06bc494ca11e Initial load
duke
parents:
diff changeset
   669
     * Compound types are attributed later in attribBounds.
06bc494ca11e Initial load
duke
parents:
diff changeset
   670
     * @param typarams the type variables to enter
06bc494ca11e Initial load
duke
parents:
diff changeset
   671
     * @param env      the current environment
06bc494ca11e Initial load
duke
parents:
diff changeset
   672
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   673
    void attribTypeVariables(List<JCTypeParameter> typarams, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   674
        for (JCTypeParameter tvar : typarams) {
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   675
            dependencies.push(AttributionKind.TVAR, tvar);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   676
            TypeVar a = (TypeVar)tvar.type;
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   677
            a.tsym.flags_field |= UNATTRIBUTED;
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   678
            a.bound = Type.noType;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   679
            if (!tvar.bounds.isEmpty()) {
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   680
                List<Type> bounds = List.of(attribType(tvar.bounds.head, env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   681
                for (JCExpression bound : tvar.bounds.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   682
                    bounds = bounds.prepend(attribType(bound, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
   683
                types.setBounds(a, bounds.reverse());
06bc494ca11e Initial load
duke
parents:
diff changeset
   684
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   685
                // if no bounds are given, assume a single bound of
06bc494ca11e Initial load
duke
parents:
diff changeset
   686
                // java.lang.Object.
06bc494ca11e Initial load
duke
parents:
diff changeset
   687
                types.setBounds(a, List.of(syms.objectType));
06bc494ca11e Initial load
duke
parents:
diff changeset
   688
            }
661
9b2f1fe5c183 6677785: REGRESSION: StackOverFlowError with Cyclic Class level Type Parameters when used in constructors
mcimadamore
parents: 512
diff changeset
   689
            a.tsym.flags_field &= ~UNATTRIBUTED;
25844
48eab270456c 8048890: Add option to keep track of symbol completion dependencies
mcimadamore
parents: 25445
diff changeset
   690
            dependencies.pop();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   691
        }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   692
        for (JCTypeParameter tvar : typarams) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   693
            chk.checkNonCyclic(tvar.pos(), (TypeVar)tvar.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
   694
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   695
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   696
06bc494ca11e Initial load
duke
parents:
diff changeset
   697
    /**
06bc494ca11e Initial load
duke
parents:
diff changeset
   698
     * Attribute the type references in a list of annotations.
06bc494ca11e Initial load
duke
parents:
diff changeset
   699
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   700
    void attribAnnotationTypes(List<JCAnnotation> annotations,
06bc494ca11e Initial load
duke
parents:
diff changeset
   701
                               Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   702
        for (List<JCAnnotation> al = annotations; al.nonEmpty(); al = al.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   703
            JCAnnotation a = al.head;
06bc494ca11e Initial load
duke
parents:
diff changeset
   704
            attribType(a.annotationType, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
   705
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   706
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   707
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   708
    /**
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   709
     * Attribute a "lazy constant value".
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   710
     *  @param env         The env for the const value
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   711
     *  @param initializer The initializer for the const value
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   712
     *  @param type        The expected type, or null
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14258
diff changeset
   713
     *  @see VarSymbol#setLazyConstValue
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   714
     */
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   715
    public Object attribLazyConstantValue(Env<AttrContext> env,
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   716
                                      JCVariableDecl variable,
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   717
                                      Type type) {
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   718
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   719
        DiagnosticPosition prevLintPos
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   720
                = deferredLintHandler.setPos(variable.pos());
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   721
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   722
        try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   723
            Type itype = attribExpr(variable.init, env, type);
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   724
            if (itype.constValue() != null) {
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   725
                return coerce(itype, type).constValue();
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   726
            } else {
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   727
                return null;
18657
2bd14bebdf57 8016099: Some @SuppressWarnings annotations ignored ( unchecked, rawtypes )
vromero
parents: 18644
diff changeset
   728
            }
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   729
        } finally {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
   730
            deferredLintHandler.setPos(prevLintPos);
8225
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   731
        }
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   732
    }
e9e5670e6a71 6554097: "final" confuses @SuppressWarnings
jjg
parents: 8046
diff changeset
   733
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   734
    /** Attribute type reference in an `extends' or `implements' clause.
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   735
     *  Supertypes of anonymous inner classes are usually already attributed.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   736
     *
06bc494ca11e Initial load
duke
parents:
diff changeset
   737
     *  @param tree              The tree making up the type reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
   738
     *  @param env               The environment current at the reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
   739
     *  @param classExpected     true if only a class is expected here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   740
     *  @param interfaceExpected true if only an interface is expected here.
06bc494ca11e Initial load
duke
parents:
diff changeset
   741
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
   742
    Type attribBase(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
   743
                    Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
   744
                    boolean classExpected,
06bc494ca11e Initial load
duke
parents:
diff changeset
   745
                    boolean interfaceExpected,
06bc494ca11e Initial load
duke
parents:
diff changeset
   746
                    boolean checkExtensible) {
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   747
        Type t = tree.type != null ?
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   748
            tree.type :
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
   749
            attribType(tree, env);
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   750
        return checkBase(t, tree, env, classExpected, interfaceExpected, checkExtensible);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   751
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   752
    Type checkBase(Type t,
06bc494ca11e Initial load
duke
parents:
diff changeset
   753
                   JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
   754
                   Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
   755
                   boolean classExpected,
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   756
                   boolean interfaceExpected,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   757
                   boolean checkExtensible) {
23809
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   758
        if (t.tsym.isAnonymous()) {
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   759
            log.error(tree.pos(), "cant.inherit.from.anon");
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   760
            return types.createErrorType(t);
9405883da95f 8023945: javac wrongly allows a subclass of an anonymous class
pgovereau
parents: 23803
diff changeset
   761
        }
6582
c7a4fb5a2f86 6403465: javac should defer diagnostics until it can be determined they are persistent
jjg
parents: 6351
diff changeset
   762
        if (t.isErroneous())
c7a4fb5a2f86 6403465: javac should defer diagnostics until it can be determined they are persistent
jjg
parents: 6351
diff changeset
   763
            return t;
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   764
        if (t.hasTag(TYPEVAR) && !classExpected && !interfaceExpected) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   765
            // check that type variable is already visible
06bc494ca11e Initial load
duke
parents:
diff changeset
   766
            if (t.getUpperBound() == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
                log.error(tree.pos(), "illegal.forward.ref");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   768
                return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   769
            }
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   770
        } else {
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
   771
            t = chk.checkClassType(tree.pos(), t, checkExtensible);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   772
        }
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   773
        if (interfaceExpected && (t.tsym.flags() & INTERFACE) == 0) {
21009
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   774
            log.error(tree.pos(), "intf.expected.here");
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   775
            // return errType is necessary since otherwise there might
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   776
            // be undetected cycles which cause attribution to loop
b35973e2d42e 8019461: Clean up javac diagnostics
emc
parents: 20608
diff changeset
   777
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   778
        } else if (checkExtensible &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   779
                   classExpected &&
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
   780
                   (t.tsym.flags() & INTERFACE) != 0) {
20608
5cc020154cff 8021339: Compile-time error during casting array to intersection
emc
parents: 20599
diff changeset
   781
            log.error(tree.pos(), "no.intf.expected.here");
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
   782
            return types.createErrorType(t);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   783
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   784
        if (checkExtensible &&
06bc494ca11e Initial load
duke
parents:
diff changeset
   785
            ((t.tsym.flags() & FINAL) != 0)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   786
            log.error(tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
   787
                      "cant.inherit.from.final", t.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   788
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   789
        chk.checkNonCyclic(tree.pos(), t);
06bc494ca11e Initial load
duke
parents:
diff changeset
   790
        return t;
06bc494ca11e Initial load
duke
parents:
diff changeset
   791
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   792
12916
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   793
    Type attribIdentAsEnumType(Env<AttrContext> env, JCIdent id) {
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   794
        Assert.check((env.enclClass.sym.flags() & ENUM) != 0);
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   795
        id.type = env.info.scope.owner.type;
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   796
        id.sym = env.info.scope.owner;
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   797
        return id.type;
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   798
    }
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
   799
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   800
    public void visitClassDef(JCClassDecl tree) {
22440
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   801
        // Local and anonymous classes have not been entered yet, so we need to
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   802
        // do it now.
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
   803
        if (env.info.scope.owner.kind.matches(KindSelector.VAL_MTH)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   804
            enter.classEnter(tree, env);
22440
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   805
        } else {
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   806
            // If this class declaration is part of a class level annotation,
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   807
            // as in @MyAnno(new Object() {}) class MyClass {}, enter it in
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   808
            // order to simplify later steps and allow for sensible error
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   809
            // messages.
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   810
            if (env.tree.hasTag(NEWCLASS) && TreeInfo.isInAnnotation(env, tree))
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   811
                enter.classEnter(tree, env);
d40c30326317 8028389: NullPointerException compiling annotation values that have bodies
alundblad
parents: 22163
diff changeset
   812
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   813
06bc494ca11e Initial load
duke
parents:
diff changeset
   814
        ClassSymbol c = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
   815
        if (c == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   816
            // exit in case something drastic went wrong during enter.
06bc494ca11e Initial load
duke
parents:
diff changeset
   817
            result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
   818
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   819
            // make sure class has been completed:
06bc494ca11e Initial load
duke
parents:
diff changeset
   820
            c.complete();
06bc494ca11e Initial load
duke
parents:
diff changeset
   821
06bc494ca11e Initial load
duke
parents:
diff changeset
   822
            // If this class appears as an anonymous class
06bc494ca11e Initial load
duke
parents:
diff changeset
   823
            // in a superclass constructor call where
06bc494ca11e Initial load
duke
parents:
diff changeset
   824
            // no explicit outer instance is given,
06bc494ca11e Initial load
duke
parents:
diff changeset
   825
            // disable implicit outer instance from being passed.
06bc494ca11e Initial load
duke
parents:
diff changeset
   826
            // (This would be an illegal access to "this before super").
06bc494ca11e Initial load
duke
parents:
diff changeset
   827
            if (env.info.isSelfCall &&
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
   828
                env.tree.hasTag(NEWCLASS) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   829
                ((JCNewClass) env.tree).encl == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   830
            {
06bc494ca11e Initial load
duke
parents:
diff changeset
   831
                c.flags_field |= NOOUTERTHIS;
06bc494ca11e Initial load
duke
parents:
diff changeset
   832
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   833
            attribClass(tree.pos(), c);
06bc494ca11e Initial load
duke
parents:
diff changeset
   834
            result = tree.type = c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
   835
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   836
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   837
06bc494ca11e Initial load
duke
parents:
diff changeset
   838
    public void visitMethodDef(JCMethodDecl tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   839
        MethodSymbol m = tree.sym;
14267
6321fbe0cf50 7192245: Add parser support for default methods
mcimadamore
parents: 14259
diff changeset
   840
        boolean isDefaultMethod = (m.flags() & DEFAULT) != 0;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   841
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
   842
        Lint lint = env.info.lint.augment(m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   843
        Lint prevLint = chk.setLint(lint);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   844
        MethodSymbol prevMethod = chk.setMethod(m);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   845
        try {
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
   846
            deferredLintHandler.flush(tree.pos());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   847
            chk.checkDeprecatedAnnotation(tree.pos(), m);
06bc494ca11e Initial load
duke
parents:
diff changeset
   848
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   849
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   850
            // Create a new environment with local scope
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   851
            // for attributing the method.
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   852
            Env<AttrContext> localEnv = memberEnter.methodEnv(tree, env);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   853
            localEnv.info.lint = lint;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   854
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
   855
            attribStats(tree.typarams, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   856
06bc494ca11e Initial load
duke
parents:
diff changeset
   857
            // If we override any other methods, check that we do so properly.
06bc494ca11e Initial load
duke
parents:
diff changeset
   858
            // JLS ???
8242
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   859
            if (m.isStatic()) {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   860
                chk.checkHideClashes(tree.pos(), env.enclClass.type, m);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   861
            } else {
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   862
                chk.checkOverrideClashes(tree.pos(), env.enclClass.type, m);
3873b4aaf4a8 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123.
mcimadamore
parents: 8239
diff changeset
   863
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   864
            chk.checkOverride(tree, m);
06bc494ca11e Initial load
duke
parents:
diff changeset
   865
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
   866
            if (isDefaultMethod && types.overridesObjectMethod(m.enclClass(), m)) {
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   867
                log.error(tree, "default.overrides.object.member", m.name, Kinds.kindName(m.location()), m.location());
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   868
            }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   869
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   870
            // Enter all type parameters into the local method scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
   871
            for (List<JCTypeParameter> l = tree.typarams; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   872
                localEnv.info.scope.enterIfAbsent(l.head.type.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   873
06bc494ca11e Initial load
duke
parents:
diff changeset
   874
            ClassSymbol owner = env.enclClass.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
   875
            if ((owner.flags() & ANNOTATION) != 0 &&
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   876
                    tree.params.nonEmpty())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   877
                log.error(tree.params.head.pos(),
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   878
                        "intf.annotation.members.cant.have.params");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   879
06bc494ca11e Initial load
duke
parents:
diff changeset
   880
            // Attribute all value parameters.
06bc494ca11e Initial load
duke
parents:
diff changeset
   881
            for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   882
                attribStat(l.head, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
   883
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
   884
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   885
            chk.checkVarargsMethodDecl(localEnv, tree);
5846
6df0e6bcb388 6945418: Project Coin: Simplified Varargs Method Invocation
mcimadamore
parents: 5654
diff changeset
   886
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   887
            // Check that type parameters are well-formed.
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
   888
            chk.validate(tree.typarams, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   889
06bc494ca11e Initial load
duke
parents:
diff changeset
   890
            // Check that result type is well-formed.
21896
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21890
diff changeset
   891
            if (tree.restype != null && !tree.restype.type.hasTag(VOID))
f39003ba351f 8026374: javac accepts void as a method parameter
jlahoda
parents: 21890
diff changeset
   892
                chk.validate(tree.restype, localEnv);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   893
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   894
            // Check that receiver type is well-formed.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   895
            if (tree.recvparam != null) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   896
                // Use a new environment to check the receiver parameter.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   897
                // Otherwise I get "might not have been initialized" errors.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   898
                // Is there a better way?
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   899
                Env<AttrContext> newEnv = memberEnter.methodEnv(tree, env);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   900
                attribType(tree.recvparam, newEnv);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   901
                chk.validate(tree.recvparam, newEnv);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   902
            }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   903
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   904
            // annotation method checks
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   905
            if ((owner.flags() & ANNOTATION) != 0) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   906
                // annotation method cannot have throws clause
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   907
                if (tree.thrown.nonEmpty()) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   908
                    log.error(tree.thrown.head.pos(),
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   909
                            "throws.not.allowed.in.intf.annotation");
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   910
                }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   911
                // annotation method cannot declare type-parameters
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   912
                if (tree.typarams.nonEmpty()) {
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   913
                    log.error(tree.typarams.head.pos(),
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   914
                            "intf.annotation.members.cant.have.type.params");
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   915
                }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   916
                // validate annotation method's return type (could be an annotation type)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   917
                chk.validateAnnotationType(tree.restype);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   918
                // ensure that annotation method does not clash with members of Object/Annotation
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   919
                chk.validateAnnotationMethod(tree.pos(), m);
6342
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   920
            }
228b73431edb 6881115: javac permits nested anno w/o mandatory attrs => IncompleteAnnotationException
mcimadamore
parents: 6154
diff changeset
   921
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   922
            for (List<JCExpression> l = tree.thrown; l.nonEmpty(); l = l.tail)
06bc494ca11e Initial load
duke
parents:
diff changeset
   923
                chk.checkType(l.head.pos(), l.head.type, syms.throwableType);
06bc494ca11e Initial load
duke
parents:
diff changeset
   924
06bc494ca11e Initial load
duke
parents:
diff changeset
   925
            if (tree.body == null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   926
                // Empty bodies are only allowed for
06bc494ca11e Initial load
duke
parents:
diff changeset
   927
                // abstract, native, or interface methods, or for methods
06bc494ca11e Initial load
duke
parents:
diff changeset
   928
                // in a retrofit signature class.
06bc494ca11e Initial load
duke
parents:
diff changeset
   929
                if (tree.defaultValue != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   930
                    if ((owner.flags() & ANNOTATION) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
   931
                        log.error(tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
   932
                                  "default.allowed.in.intf.annotation.member");
06bc494ca11e Initial load
duke
parents:
diff changeset
   933
                }
26106
8af1fa613176 8054556: javac should report the error for default usage as the primary error
pgovereau
parents: 25846
diff changeset
   934
                if (isDefaultMethod || (tree.sym.flags() & (ABSTRACT | NATIVE)) == 0 &&
8af1fa613176 8054556: javac should report the error for default usage as the primary error
pgovereau
parents: 25846
diff changeset
   935
                    !relax)
8af1fa613176 8054556: javac should report the error for default usage as the primary error
pgovereau
parents: 25846
diff changeset
   936
                    log.error(tree.pos(), "missing.meth.body.or.decl.abstract");
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   937
            } else if ((tree.sym.flags() & ABSTRACT) != 0 && !isDefaultMethod) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   938
                if ((owner.flags() & INTERFACE) != 0) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   939
                    log.error(tree.body.pos(), "intf.meth.cant.have.body");
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   940
                } else {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   941
                    log.error(tree.pos(), "abstract.meth.cant.have.body");
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
   942
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   943
            } else if ((tree.mods.flags & NATIVE) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   944
                log.error(tree.pos(), "native.meth.cant.have.body");
06bc494ca11e Initial load
duke
parents:
diff changeset
   945
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
   946
                // Add an implicit super() call unless an explicit call to
06bc494ca11e Initial load
duke
parents:
diff changeset
   947
                // super(...) or this(...) is given
06bc494ca11e Initial load
duke
parents:
diff changeset
   948
                // or we are compiling class java.lang.Object.
06bc494ca11e Initial load
duke
parents:
diff changeset
   949
                if (tree.name == names.init && owner.type != syms.objectType) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   950
                    JCBlock body = tree.body;
06bc494ca11e Initial load
duke
parents:
diff changeset
   951
                    if (body.stats.isEmpty() ||
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   952
                            !TreeInfo.isSelfCall(body.stats.head)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   953
                        body.stats = body.stats.
27857
7e913a535736 7101822: Compiling depends on order of imports
jlahoda
parents: 27856
diff changeset
   954
                                prepend(typeEnter.SuperCall(make.at(body.pos),
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   955
                                        List.<Type>nil(),
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   956
                                        List.<JCVariableDecl>nil(),
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   957
                                        false));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   958
                    } else if ((env.enclClass.sym.flags() & ENUM) != 0 &&
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   959
                            (tree.mods.flags & GENERATEDCONSTR) == 0 &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   960
                            TreeInfo.isSuperCall(body.stats.head)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   961
                        // enum constructors are not allowed to call super
06bc494ca11e Initial load
duke
parents:
diff changeset
   962
                        // directly, so make sure there aren't any super calls
06bc494ca11e Initial load
duke
parents:
diff changeset
   963
                        // in enum constructors, except in the compiler
06bc494ca11e Initial load
duke
parents:
diff changeset
   964
                        // generated one.
06bc494ca11e Initial load
duke
parents:
diff changeset
   965
                        log.error(tree.body.stats.head.pos(),
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   966
                                "call.to.super.not.allowed.in.enum.ctor",
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   967
                                env.enclClass.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   968
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   969
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
   970
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   971
                // Attribute all type annotations in the body
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   972
                annotate.annotateTypeLater(tree.body, localEnv, m, null);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   973
                annotate.flush();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   974
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   975
                // Attribute method body.
06bc494ca11e Initial load
duke
parents:
diff changeset
   976
                attribStat(tree.body, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
   977
            }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
   978
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   979
            localEnv.info.scope.leave();
06bc494ca11e Initial load
duke
parents:
diff changeset
   980
            result = tree.type = m.type;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   981
        } finally {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   982
            chk.setLint(prevLint);
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
   983
            chk.setMethod(prevMethod);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   984
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
   985
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   986
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
   987
    public void visitVarDef(JCVariableDecl tree) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   988
        // Local variables have not been entered yet, so we need to do it now:
06bc494ca11e Initial load
duke
parents:
diff changeset
   989
        if (env.info.scope.owner.kind == MTH) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   990
            if (tree.sym != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   991
                // parameters have already been entered
06bc494ca11e Initial load
duke
parents:
diff changeset
   992
                env.info.scope.enter(tree.sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
   993
            } else {
27231
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   994
                try {
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   995
                    annotate.enterStart();
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   996
                    memberEnter.memberEnter(tree, env);
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   997
                } finally {
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   998
                    annotate.enterDone();
c1ca668b421e 8054448: (ann) Cannot reference field of inner class in an anonymous class
jfranck
parents: 27224
diff changeset
   999
                }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1000
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1001
        } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1002
            if (tree.init != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1003
                // Field initializer expression need to be entered.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1004
                annotate.annotateTypeLater(tree.init, env, tree.sym, tree.pos());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1005
                annotate.flush();
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1006
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1007
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1008
06bc494ca11e Initial load
duke
parents:
diff changeset
  1009
        VarSymbol v = tree.sym;
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1010
        Lint lint = env.info.lint.augment(v);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1011
        Lint prevLint = chk.setLint(lint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1012
1538
3cbbc9424f43 6763518: Impossible to suppress raw-type warnings
mcimadamore
parents: 1534
diff changeset
  1013
        // Check that the variable's declared type is well-formed.
17584
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1014
        boolean isImplicitLambdaParameter = env.tree.hasTag(LAMBDA) &&
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1015
                ((JCLambda)env.tree).paramKind == JCLambda.ParameterKind.IMPLICIT &&
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1016
                (tree.sym.flags() & PARAMETER) != 0;
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  1017
        chk.validate(tree.vartype, env, !isImplicitLambdaParameter);
1538
3cbbc9424f43 6763518: Impossible to suppress raw-type warnings
mcimadamore
parents: 1534
diff changeset
  1018
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1019
        try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1020
            v.getConstValue(); // ensure compile-time constant initializer is evaluated
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1021
            deferredLintHandler.flush(tree.pos());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1022
            chk.checkDeprecatedAnnotation(tree.pos(), v);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1023
06bc494ca11e Initial load
duke
parents:
diff changeset
  1024
            if (tree.init != null) {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1025
                if ((v.flags_field & FINAL) == 0 ||
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1026
                    !memberEnter.needsLazyConstValue(tree.init)) {
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  1027
                    // Not a compile-time constant
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1028
                    // Attribute initializer in a new environment
06bc494ca11e Initial load
duke
parents:
diff changeset
  1029
                    // with the declared variable as owner.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1030
                    // Check that initializer conforms to variable's declared type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1031
                    Env<AttrContext> initEnv = memberEnter.initEnv(tree, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1032
                    initEnv.info.lint = lint;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1033
                    // In order to catch self-references, we set the variable's
06bc494ca11e Initial load
duke
parents:
diff changeset
  1034
                    // declaration position to maximal possible value, effectively
06bc494ca11e Initial load
duke
parents:
diff changeset
  1035
                    // marking the variable as undefined.
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  1036
                    initEnv.info.enclVar = v;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1037
                    attribExpr(tree.init, initEnv, v.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1038
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1039
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1040
            result = tree.type = v.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1041
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1042
        finally {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1043
            chk.setLint(prevLint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1044
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1045
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1046
06bc494ca11e Initial load
duke
parents:
diff changeset
  1047
    public void visitSkip(JCSkip tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1048
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1049
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1050
06bc494ca11e Initial load
duke
parents:
diff changeset
  1051
    public void visitBlock(JCBlock tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1052
        if (env.info.scope.owner.kind == TYP) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1053
            // Block is a static or instance initializer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1054
            // let the owner of the environment be a freshly
06bc494ca11e Initial load
duke
parents:
diff changeset
  1055
            // created BLOCK-method.
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1056
            Symbol fakeOwner =
15710
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1057
                new MethodSymbol(tree.flags | BLOCK |
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1058
                    env.info.scope.owner.flags() & STRICTFP, names.empty, null,
5792a085da41 7166455: javac doesn't set ACC_STRICT bit on <clinit> for strictfp class
vromero
parents: 15705
diff changeset
  1059
                    env.info.scope.owner);
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1060
            final Env<AttrContext> localEnv =
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1061
                env.dup(tree, env.info.dup(env.info.scope.dupUnshared(fakeOwner)));
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  1062
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1063
            if ((tree.flags & STATIC) != 0) localEnv.info.staticLevel++;
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1064
            // Attribute all type annotations in the block
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1065
            annotate.annotateTypeLater(tree, localEnv, localEnv.info.scope.owner, null);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1066
            annotate.flush();
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  1067
            attribStats(tree.stats, localEnv);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1068
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1069
            {
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1070
                // Store init and clinit type annotations with the ClassSymbol
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1071
                // to allow output in Gen.normalizeDefs.
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1072
                ClassSymbol cs = (ClassSymbol)env.info.scope.owner;
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1073
                List<Attribute.TypeCompound> tas = localEnv.info.scope.owner.getRawTypeAttributes();
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1074
                if ((tree.flags & STATIC) != 0) {
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1075
                    cs.appendClassInitTypeAttributes(tas);
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1076
                } else {
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  1077
                    cs.appendInitTypeAttributes(tas);
17578
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1078
                }
46ac954e4a84 8013852: update reference impl for type-annotations
jjg
parents: 17557
diff changeset
  1079
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1080
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1081
            // Create a new local environment with a local scope.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1082
            Env<AttrContext> localEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1083
                env.dup(tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1084
            try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1085
                attribStats(tree.stats, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1086
            } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1087
                localEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1088
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1089
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1090
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1091
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1092
06bc494ca11e Initial load
duke
parents:
diff changeset
  1093
    public void visitDoLoop(JCDoWhileLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1094
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1095
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1096
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1097
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1098
06bc494ca11e Initial load
duke
parents:
diff changeset
  1099
    public void visitWhileLoop(JCWhileLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1100
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1101
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1103
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1104
06bc494ca11e Initial load
duke
parents:
diff changeset
  1105
    public void visitForLoop(JCForLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1106
        Env<AttrContext> loopEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1107
            env.dup(env.tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1108
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1109
            attribStats(tree.init, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1110
            if (tree.cond != null) attribExpr(tree.cond, loopEnv, syms.booleanType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1111
            loopEnv.tree = tree; // before, we were not in loop!
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1112
            attribStats(tree.step, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1113
            attribStat(tree.body, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1114
            result = null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1115
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1116
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1117
            loopEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1118
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1119
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1120
06bc494ca11e Initial load
duke
parents:
diff changeset
  1121
    public void visitForeachLoop(JCEnhancedForLoop tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1122
        Env<AttrContext> loopEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1123
            env.dup(env.tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1124
        try {
18379
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1125
            //the Formal Parameter of a for-each loop is not in the scope when
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1126
            //attributing the for-each expression; we mimick this by attributing
8dd20756448c 7139681: Enhanced for loop: local variable scope inconsistent with JLS
mcimadamore
parents: 18010
diff changeset
  1127
            //the for-each expression first (against original scope).
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24609
diff changeset
  1128
            Type exprType = types.cvarUpperBound(attribExpr(tree.expr, loopEnv));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1129
            attribStat(tree.var, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1130
            chk.checkNonVoid(tree.pos(), exprType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1131
            Type elemtype = types.elemtype(exprType); // perhaps expr is an array?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1132
            if (elemtype == null) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1133
                // or perhaps expr implements Iterable<T>?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1134
                Type base = types.asSuper(exprType, syms.iterableType.tsym);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1135
                if (base == null) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1136
                    log.error(tree.expr.pos(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1137
                            "foreach.not.applicable.to.type",
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1138
                            exprType,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1139
                            diags.fragment("type.req.array.or.iterable"));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1140
                    elemtype = types.createErrorType(exprType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1141
                } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1142
                    List<Type> iterableParams = base.allparams();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1143
                    elemtype = iterableParams.isEmpty()
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1144
                        ? syms.objectType
24612
75dc732b45af 8042338: Refactor Types.upperBound to treat wildcards and variables separately
dlsmith
parents: 24609
diff changeset
  1145
                        : types.wildUpperBound(iterableParams.head);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1146
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1147
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1148
            chk.checkType(tree.expr.pos(), elemtype, tree.var.sym.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1149
            loopEnv.tree = tree; // before, we were not in loop!
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1150
            attribStat(tree.body, loopEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1151
            result = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1152
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1153
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1154
            loopEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1155
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1156
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
06bc494ca11e Initial load
duke
parents:
diff changeset
  1158
    public void visitLabelled(JCLabeledStatement tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1159
        // Check that label is not used in an enclosing statement
06bc494ca11e Initial load
duke
parents:
diff changeset
  1160
        Env<AttrContext> env1 = env;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1161
        while (env1 != null && !env1.tree.hasTag(CLASSDEF)) {
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1162
            if (env1.tree.hasTag(LABELLED) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1163
                ((JCLabeledStatement) env1.tree).label == tree.label) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1164
                log.error(tree.pos(), "label.already.in.use",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1165
                          tree.label);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1166
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1168
            env1 = env1.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1169
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1170
06bc494ca11e Initial load
duke
parents:
diff changeset
  1171
        attribStat(tree.body, env.dup(tree));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1172
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1173
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1174
06bc494ca11e Initial load
duke
parents:
diff changeset
  1175
    public void visitSwitch(JCSwitch tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1176
        Type seltype = attribExpr(tree.selector, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1177
06bc494ca11e Initial load
duke
parents:
diff changeset
  1178
        Env<AttrContext> switchEnv =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1179
            env.dup(tree, env.info.dup(env.info.scope.dup()));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1180
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1181
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1182
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1183
            boolean enumSwitch = (seltype.tsym.flags() & Flags.ENUM) != 0;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1184
            boolean stringSwitch = false;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1185
            if (types.isSameType(seltype, syms.stringType)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1186
                if (allowStringsInSwitch) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1187
                    stringSwitch = true;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1188
                } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1189
                    log.error(tree.selector.pos(), "string.switch.not.supported.in.source", sourceName);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1190
                }
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
  1191
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1192
            if (!enumSwitch && !stringSwitch)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1193
                seltype = chk.checkType(tree.selector.pos(), seltype, syms.intType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1194
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1195
            // Attribute all cases and
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1196
            // check that there are no duplicate case labels or default clauses.
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  1197
            Set<Object> labels = new HashSet<>(); // The set of case labels.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1198
            boolean hasDefault = false;      // Is there a default label?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1199
            for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1200
                JCCase c = l.head;
27553
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1201
                if (c.pat != null) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1202
                    if (enumSwitch) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1203
                        Symbol sym = enumConstant(c.pat, seltype);
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1204
                        if (sym == null) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1205
                            log.error(c.pat.pos(), "enum.label.must.be.unqualified.enum");
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1206
                        } else if (!labels.add(sym)) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1207
                            log.error(c.pos(), "duplicate.case.label");
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1208
                        }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1209
                    } else {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1210
                        Type pattype = attribExpr(c.pat, switchEnv, seltype);
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1211
                        if (!pattype.hasTag(ERROR)) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1212
                            if (pattype.constValue() == null) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1213
                                log.error(c.pat.pos(),
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1214
                                          (stringSwitch ? "string.const.req" : "const.expr.req"));
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1215
                            } else if (labels.contains(pattype.constValue())) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1216
                                log.error(c.pos(), "duplicate.case.label");
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1217
                            } else {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1218
                                labels.add(pattype.constValue());
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1219
                            }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1220
                        }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1221
                    }
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1222
                } else if (hasDefault) {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1223
                    log.error(c.pos(), "duplicate.default.label");
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1224
                } else {
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1225
                    hasDefault = true;
75321debd020 8064362: WriteableScope.dupUnshared misbehaves on shared Scopes
jlahoda
parents: 27551
diff changeset
  1226
                }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1227
                Env<AttrContext> caseEnv =
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1228
                    switchEnv.dup(c, env.info.dup(switchEnv.info.scope.dup()));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1229
                try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1230
                    attribStats(c.stats, caseEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1231
                } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1232
                    caseEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1233
                    addVars(c.stats, switchEnv.info.scope);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1234
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1235
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1236
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1237
            result = null;
4142
bd950c8f4fb3 6827009: Project Coin: Strings in Switch
darcy
parents: 3765
diff changeset
  1238
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1239
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1240
            switchEnv.info.scope.leave();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1241
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1242
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1243
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1244
        /** Add any variables defined in stats to the switch scope. */
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1245
        private static void addVars(List<JCStatement> stats, WriteableScope switchScope) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1246
            for (;stats.nonEmpty(); stats = stats.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1247
                JCTree stat = stats.head;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1248
                if (stat.hasTag(VARDEF))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1249
                    switchScope.enter(((JCVariableDecl) stat).sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1250
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1251
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1252
    // where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1253
    /** Return the selected enumeration constant symbol, or null. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1254
    private Symbol enumConstant(JCTree tree, Type enumType) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1255
        if (!tree.hasTag(IDENT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1256
            log.error(tree.pos(), "enum.label.must.be.unqualified.enum");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1257
            return syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1258
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1259
        JCIdent ident = (JCIdent)tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1260
        Name name = ident.name;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1261
        for (Symbol sym : enumType.tsym.members().getSymbolsByName(name)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1262
            if (sym.kind == VAR) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  1263
                Symbol s = ident.sym = sym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1264
                ((VarSymbol)s).getConstValue(); // ensure initializer is evaluated
06bc494ca11e Initial load
duke
parents:
diff changeset
  1265
                ident.type = s.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1266
                return ((s.flags_field & Flags.ENUM) == 0)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1267
                    ? null : s;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1268
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1269
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1270
        return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1271
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1272
06bc494ca11e Initial load
duke
parents:
diff changeset
  1273
    public void visitSynchronized(JCSynchronized tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1274
        chk.checkRefType(tree.pos(), attribExpr(tree.lock, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1275
        attribStat(tree.body, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1276
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1277
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1278
06bc494ca11e Initial load
duke
parents:
diff changeset
  1279
    public void visitTry(JCTry tree) {
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1280
        // Create a new local environment with a local
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1281
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup(env.info.scope.dup()));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1282
        try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1283
            boolean isTryWithResource = tree.resources.nonEmpty();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1284
            // Create a nested environment for attributing the try block if needed
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1285
            Env<AttrContext> tryEnv = isTryWithResource ?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1286
                env.dup(tree, localEnv.info.dup(localEnv.info.scope.dup())) :
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1287
                localEnv;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1288
            try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1289
                // Attribute resource declarations
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1290
                for (JCTree resource : tree.resources) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1291
                    CheckContext twrContext = new Check.NestedCheckContext(resultInfo.checkContext) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1292
                        @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1293
                        public void report(DiagnosticPosition pos, JCDiagnostic details) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1294
                            chk.basicHandler.report(pos, diags.fragment("try.not.applicable.to.type", details));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1295
                        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1296
                    };
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1297
                    ResultInfo twrResult =
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  1298
                        new ResultInfo(KindSelector.VAR,
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1299
                                       syms.autoCloseableType,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1300
                                       twrContext);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1301
                    if (resource.hasTag(VARDEF)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1302
                        attribStat(resource, tryEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1303
                        twrResult.check(resource, resource.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1304
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1305
                        //check that resource type cannot throw InterruptedException
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1306
                        checkAutoCloseable(resource.pos(), localEnv, resource.type);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1307
17557
9c6ace1881fe 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees
jlahoda
parents: 16975
diff changeset
  1308
                        VarSymbol var = ((JCVariableDecl) resource).sym;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1309
                        var.setData(ElementKind.RESOURCE_VARIABLE);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1310
                    } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1311
                        attribTree(resource, tryEnv, twrResult);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1312
                    }
12334
29e1bfdcba4e 7151492: Encapsulate check logic into Attr.ResultInfo
mcimadamore
parents: 12333
diff changeset
  1313
                }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1314
                // Attribute body
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1315
                attribStat(tree.body, tryEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1316
            } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1317
                if (isTryWithResource)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1318
                    tryEnv.info.scope.leave();
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1319
            }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1320
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1321
            // Attribute catch clauses
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1322
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1323
                JCCatch c = l.head;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1324
                Env<AttrContext> catchEnv =
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1325
                    localEnv.dup(c, localEnv.info.dup(localEnv.info.scope.dup()));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1326
                try {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1327
                    Type ctype = attribStat(c.param, catchEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1328
                    if (TreeInfo.isMultiCatch(c)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1329
                        //multi-catch parameter is implicitly marked as final
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1330
                        c.param.sym.flags_field |= FINAL | UNION;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1331
                    }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1332
                    if (c.param.sym.kind == VAR) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1333
                        c.param.sym.setData(ElementKind.EXCEPTION_PARAMETER);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1334
                    }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1335
                    chk.checkType(c.param.vartype.pos(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1336
                                  chk.checkClassType(c.param.vartype.pos(), ctype),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1337
                                  syms.throwableType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1338
                    attribStat(c.body, catchEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1339
                } finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1340
                    catchEnv.info.scope.leave();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1341
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1342
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1343
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1344
            // Attribute finalizer
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1345
            if (tree.finalizer != null) attribStat(tree.finalizer, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1346
            result = null;
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  1347
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1348
        finally {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1349
            localEnv.info.scope.leave();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1350
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1351
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1352
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1353
    void checkAutoCloseable(DiagnosticPosition pos, Env<AttrContext> env, Type resource) {
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1354
        if (!resource.isErroneous() &&
12013
fdcc73079b81 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself
darcy
parents: 11144
diff changeset
  1355
            types.asSuper(resource, syms.autoCloseableType.tsym) != null &&
fdcc73079b81 7148025: javac should not warn about InterrupttedException on the declaration of AutoCloseable itself
darcy
parents: 11144
diff changeset
  1356
            !types.isSameType(resource, syms.autoCloseableType)) { // Don't emit warning for AutoCloseable itself
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1357
            Symbol close = syms.noSymbol;
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14443
diff changeset
  1358
            Log.DiagnosticHandler discardHandler = new Log.DiscardDiagnosticHandler(log);
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1359
            try {
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1360
                close = rs.resolveQualifiedMethod(pos,
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1361
                        env,
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1362
                        resource,
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1363
                        names.close,
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1364
                        List.<Type>nil(),
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1365
                        List.<Type>nil());
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1366
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1367
            finally {
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14443
diff changeset
  1368
                log.popDiagnosticHandler(discardHandler);
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1369
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1370
            if (close.kind == MTH &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1371
                    close.overrides(syms.autoCloseableClose, resource.tsym, types, true) &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1372
                    chk.isHandled(syms.interruptedExceptionType, types.memberType(resource, close).getThrownTypes()) &&
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1373
                    env.info.lint.isEnabled(LintCategory.TRY)) {
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1374
                log.warning(LintCategory.TRY, pos, "try.resource.throws.interrupted.exc", resource);
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1375
            }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1376
        }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1377
    }
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  1378
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1379
    public void visitConditional(JCConditional tree) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1380
        Type condtype = attribExpr(tree.cond, env, syms.booleanType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1381
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1382
        tree.polyKind = (!allowPoly ||
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1383
                pt().hasTag(NONE) && pt() != Type.recoveryType ||
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1384
                isBooleanOrNumeric(env, tree)) ?
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1385
                PolyKind.STANDALONE : PolyKind.POLY;
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1386
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1387
        if (tree.polyKind == PolyKind.POLY && resultInfo.pt.hasTag(VOID)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1388
            //cannot get here (i.e. it means we are returning from void method - which is already an error)
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1389
            resultInfo.checkContext.report(tree, diags.fragment("conditional.target.cant.be.void"));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1390
            result = tree.type = types.createErrorType(resultInfo.pt);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1391
            return;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1392
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1393
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1394
        ResultInfo condInfo = tree.polyKind == PolyKind.STANDALONE ?
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1395
                unknownExprInfo :
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1396
                resultInfo.dup(new Check.NestedCheckContext(resultInfo.checkContext) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1397
                    //this will use enclosing check context to check compatibility of
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1398
                    //subexpression against target type; if we are in a method check context,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1399
                    //depending on whether boxing is allowed, we could have incompatibilities
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1400
                    @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1401
                    public void report(DiagnosticPosition pos, JCDiagnostic details) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1402
                        enclosingContext.report(pos, diags.fragment("incompatible.type.in.conditional", details));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1403
                    }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1404
                });
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1405
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1406
        Type truetype = attribTree(tree.truepart, env, condInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1407
        Type falsetype = attribTree(tree.falsepart, env, condInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1408
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1409
        Type owntype = (tree.polyKind == PolyKind.STANDALONE) ? condType(tree, truetype, falsetype) : pt();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1410
        if (condtype.constValue() != null &&
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1411
                truetype.constValue() != null &&
14953
89a34297b198 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method
mcimadamore
parents: 14725
diff changeset
  1412
                falsetype.constValue() != null &&
89a34297b198 8004099: Bad compiler diagnostic generated when poly expression is passed to non-existent method
mcimadamore
parents: 14725
diff changeset
  1413
                !owntype.hasTag(NONE)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1414
            //constant folding
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1415
            owntype = cfolder.coerce(condtype.isTrue() ? truetype : falsetype, owntype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1416
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1417
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1418
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1419
    //where
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1420
        private boolean isBooleanOrNumeric(Env<AttrContext> env, JCExpression tree) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1421
            switch (tree.getTag()) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1422
                case LITERAL: return ((JCLiteral)tree).typetag.isSubRangeOf(DOUBLE) ||
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1423
                              ((JCLiteral)tree).typetag == BOOLEAN ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1424
                              ((JCLiteral)tree).typetag == BOT;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1425
                case LAMBDA: case REFERENCE: return false;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1426
                case PARENS: return isBooleanOrNumeric(env, ((JCParens)tree).expr);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1427
                case CONDEXPR:
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1428
                    JCConditional condTree = (JCConditional)tree;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1429
                    return isBooleanOrNumeric(env, condTree.truepart) &&
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1430
                            isBooleanOrNumeric(env, condTree.falsepart);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1431
                case APPLY:
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1432
                    JCMethodInvocation speculativeMethodTree =
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1433
                            (JCMethodInvocation)deferredAttr.attribSpeculative(tree, env, unknownExprInfo);
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1434
                    Symbol msym = TreeInfo.symbol(speculativeMethodTree.meth);
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1435
                    Type receiverType = speculativeMethodTree.meth.hasTag(IDENT) ?
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1436
                            env.enclClass.type :
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1437
                            ((JCFieldAccess)speculativeMethodTree.meth).selected.type;
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1438
                    Type owntype = types.memberType(receiverType, msym).getReturnType();
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1439
                    return primitiveOrBoxed(owntype);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1440
                case NEWCLASS:
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1441
                    JCExpression className =
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1442
                            removeClassParams.translate(((JCNewClass)tree).clazz);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1443
                    JCExpression speculativeNewClassTree =
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1444
                            (JCExpression)deferredAttr.attribSpeculative(className, env, unknownTypeInfo);
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1445
                    return primitiveOrBoxed(speculativeNewClassTree.type);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1446
                default:
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1447
                    Type speculativeType = deferredAttr.attribSpeculative(tree, env, unknownExprInfo).type;
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1448
                    return primitiveOrBoxed(speculativeType);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1449
            }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1450
        }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1451
        //where
27551
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1452
            boolean primitiveOrBoxed(Type t) {
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1453
                return (!t.hasTag(TYPEVAR) && types.unboxedTypeOrType(t).isPrimitive());
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1454
            }
14a74a56c4a0 8064464: regression with type inference of conditional expression
mcimadamore
parents: 27231
diff changeset
  1455
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1456
            TreeTranslator removeClassParams = new TreeTranslator() {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1457
                @Override
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1458
                public void visitTypeApply(JCTypeApply tree) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1459
                    result = translate(tree.clazz);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1460
                }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  1461
            };
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1462
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1463
        /** Compute the type of a conditional expression, after
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1464
         *  checking that it exists.  See JLS 15.25. Does not take into
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1465
         *  account the special case where condition and both arms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1466
         *  are constants.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1467
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1468
         *  @param pos      The source position to be used for error
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
         *                  diagnostics.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
         *  @param thentype The type of the expression's then-part.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1471
         *  @param elsetype The type of the expression's else-part.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1472
         */
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1473
        private Type condType(DiagnosticPosition pos,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1474
                               Type thentype, Type elsetype) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1475
            // If same type, that is the result
06bc494ca11e Initial load
duke
parents:
diff changeset
  1476
            if (types.isSameType(thentype, elsetype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1477
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1478
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1479
            Type thenUnboxed = (thentype.isPrimitive())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1480
                ? thentype : types.unboxedType(thentype);
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1481
            Type elseUnboxed = (elsetype.isPrimitive())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1482
                ? elsetype : types.unboxedType(elsetype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1483
06bc494ca11e Initial load
duke
parents:
diff changeset
  1484
            // Otherwise, if both arms can be converted to a numeric
06bc494ca11e Initial load
duke
parents:
diff changeset
  1485
            // type, return the least numeric type that fits both arms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1486
            // (i.e. return larger of the two, or return int if one
06bc494ca11e Initial load
duke
parents:
diff changeset
  1487
            // arm is short, the other is char).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
            if (thenUnboxed.isPrimitive() && elseUnboxed.isPrimitive()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1489
                // If one arm has an integer subrange type (i.e., byte,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1490
                // short, or char), and the other is an integer constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  1491
                // that fits into the subrange, return the subrange type.
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1492
                if (thenUnboxed.getTag().isStrictSubRangeOf(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1493
                    elseUnboxed.hasTag(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1494
                    types.isAssignable(elseUnboxed, thenUnboxed)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1495
                    return thenUnboxed.baseType();
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1496
                }
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1497
                if (elseUnboxed.getTag().isStrictSubRangeOf(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1498
                    thenUnboxed.hasTag(INT) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1499
                    types.isAssignable(thenUnboxed, elseUnboxed)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1500
                    return elseUnboxed.baseType();
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1501
                }
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1502
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1503
                for (TypeTag tag : primitiveTags) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1504
                    Type candidate = syms.typeOfTag[tag.ordinal()];
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1505
                    if (types.isSubtype(thenUnboxed, candidate) &&
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1506
                        types.isSubtype(elseUnboxed, candidate)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1507
                        return candidate;
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1508
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1509
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1510
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1511
06bc494ca11e Initial load
duke
parents:
diff changeset
  1512
            // Those were all the cases that could result in a primitive
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1513
            if (thentype.isPrimitive())
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1514
                thentype = types.boxedClass(thentype).type;
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1515
            if (elsetype.isPrimitive())
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1516
                elsetype = types.boxedClass(elsetype).type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1517
06bc494ca11e Initial load
duke
parents:
diff changeset
  1518
            if (types.isSubtype(thentype, elsetype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1519
                return elsetype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1520
            if (types.isSubtype(elsetype, thentype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1521
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1522
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1523
            if (thentype.hasTag(VOID) || elsetype.hasTag(VOID)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
                log.error(pos, "neither.conditional.subtype",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
                          thentype, elsetype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1526
                return thentype.baseType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1527
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1528
06bc494ca11e Initial load
duke
parents:
diff changeset
  1529
            // both are known to be reference types.  The result is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1530
            // lub(thentype,elsetype). This cannot fail, as it will
06bc494ca11e Initial load
duke
parents:
diff changeset
  1531
            // always be possible to infer "Object" if nothing better.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1532
            return types.lub(thentype.baseType(), elsetype.baseType());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1533
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1534
18395
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1535
    final static TypeTag[] primitiveTags = new TypeTag[]{
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1536
        BYTE,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1537
        CHAR,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1538
        SHORT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1539
        INT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1540
        LONG,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1541
        FLOAT,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1542
        DOUBLE,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1543
        BOOLEAN,
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1544
    };
d56a5fbf0b32 8016267: javac, TypeTag refactoring has provoked performance issues
vromero
parents: 18393
diff changeset
  1545
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1546
    public void visitIf(JCIf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1547
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1548
        attribStat(tree.thenpart, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1549
        if (tree.elsepart != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1550
            attribStat(tree.elsepart, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
        chk.checkEmptyIf(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1552
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1553
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1554
06bc494ca11e Initial load
duke
parents:
diff changeset
  1555
    public void visitExec(JCExpressionStatement tree) {
6592
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1556
        //a fresh environment is required for 292 inference to work properly ---
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1557
        //see Infer.instantiatePolymorphicSignatureInstance()
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1558
        Env<AttrContext> localEnv = env.dup(tree);
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  1559
        attribExpr(tree.expr, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1560
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1561
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1562
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
    public void visitBreak(JCBreak tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1564
        tree.target = findJumpTarget(tree.pos(), tree.getTag(), tree.label, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1565
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1566
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1567
06bc494ca11e Initial load
duke
parents:
diff changeset
  1568
    public void visitContinue(JCContinue tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1569
        tree.target = findJumpTarget(tree.pos(), tree.getTag(), tree.label, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1570
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1571
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1572
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  1573
        /** Return the target of a break or continue statement, if it exists,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1574
         *  report an error if not.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1575
         *  Note: The target of a labelled break or continue is the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1576
         *  (non-labelled) statement tree referred to by the label,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
         *  not the tree representing the labelled statement itself.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1578
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  1579
         *  @param pos     The position to be used for error diagnostics
06bc494ca11e Initial load
duke
parents:
diff changeset
  1580
         *  @param tag     The tag of the jump statement. This is either
06bc494ca11e Initial load
duke
parents:
diff changeset
  1581
         *                 Tree.BREAK or Tree.CONTINUE.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1582
         *  @param label   The label of the jump statement, or null if no
06bc494ca11e Initial load
duke
parents:
diff changeset
  1583
         *                 label is given.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1584
         *  @param env     The environment current at the jump statement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1585
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1586
        private JCTree findJumpTarget(DiagnosticPosition pos,
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1587
                                    JCTree.Tag tag,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1588
                                    Name label,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1589
                                    Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1590
            // Search environments outwards from the point of jump.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1591
            Env<AttrContext> env1 = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1592
            LOOP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  1593
            while (env1 != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1594
                switch (env1.tree.getTag()) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1595
                    case LABELLED:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1596
                        JCLabeledStatement labelled = (JCLabeledStatement)env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1597
                        if (label == labelled.label) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1598
                            // If jump is a continue, check that target is a loop.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1599
                            if (tag == CONTINUE) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1600
                                if (!labelled.body.hasTag(DOLOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1601
                                        !labelled.body.hasTag(WHILELOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1602
                                        !labelled.body.hasTag(FORLOOP) &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1603
                                        !labelled.body.hasTag(FOREACHLOOP))
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1604
                                    log.error(pos, "not.loop.label", label);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1605
                                // Found labelled statement target, now go inwards
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1606
                                // to next non-labelled tree.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1607
                                return TreeInfo.referencedStatement(labelled);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1608
                            } else {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1609
                                return labelled;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1610
                            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1611
                        }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1612
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1613
                    case DOLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1614
                    case WHILELOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1615
                    case FORLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1616
                    case FOREACHLOOP:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1617
                        if (label == null) return env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1618
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1619
                    case SWITCH:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1620
                        if (label == null && tag == BREAK) return env1.tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1621
                        break;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1622
                    case LAMBDA:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1623
                    case METHODDEF:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1624
                    case CLASSDEF:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1625
                        break LOOP;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  1626
                    default:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1627
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
                env1 = env1.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1629
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1630
            if (label != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1631
                log.error(pos, "undef.label", label);
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1632
            else if (tag == CONTINUE)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1633
                log.error(pos, "cont.outside.loop");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1634
            else
06bc494ca11e Initial load
duke
parents:
diff changeset
  1635
                log.error(pos, "break.outside.switch.loop");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
            return null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1637
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1638
06bc494ca11e Initial load
duke
parents:
diff changeset
  1639
    public void visitReturn(JCReturn tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1640
        // Check that there is an enclosing method which is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1641
        // nested within than the enclosing class.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1642
        if (env.info.returnResult == null) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1643
            log.error(tree.pos(), "ret.outside.meth");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1644
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1645
            // Attribute return expression, if it exists, and check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  1646
            // it conforms to result type of enclosing method.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1647
            if (tree.expr != null) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1648
                if (env.info.returnResult.pt.hasTag(VOID)) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1649
                    env.info.returnResult.checkContext.report(tree.expr.pos(),
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1650
                              diags.fragment("unexpected.ret.val"));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1651
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1652
                attribTree(tree.expr, env, env.info.returnResult);
18902
972298345a83 8016059: Cannot compile following lambda
mcimadamore
parents: 18899
diff changeset
  1653
            } else if (!env.info.returnResult.pt.hasTag(VOID) &&
972298345a83 8016059: Cannot compile following lambda
mcimadamore
parents: 18899
diff changeset
  1654
                    !env.info.returnResult.pt.hasTag(NONE)) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1655
                env.info.returnResult.checkContext.report(tree.pos(),
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1656
                              diags.fragment("missing.ret.val"));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1657
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1658
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1659
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1660
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
06bc494ca11e Initial load
duke
parents:
diff changeset
  1662
    public void visitThrow(JCThrow tree) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1663
        Type owntype = attribExpr(tree.expr, env, allowPoly ? Type.noType : syms.throwableType);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1664
        if (allowPoly) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1665
            chk.checkType(tree, owntype, syms.throwableType);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  1666
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1667
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1668
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1669
06bc494ca11e Initial load
duke
parents:
diff changeset
  1670
    public void visitAssert(JCAssert tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1671
        attribExpr(tree.cond, env, syms.booleanType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1672
        if (tree.detail != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1673
            chk.checkNonVoid(tree.detail.pos(), attribExpr(tree.detail, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1674
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1675
        result = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1676
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1677
06bc494ca11e Initial load
duke
parents:
diff changeset
  1678
     /** Visitor method for method invocations.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
     *  NOTE: The method part of an application will have in its type field
06bc494ca11e Initial load
duke
parents:
diff changeset
  1680
     *        the return type of the method, not the method's type itself!
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1682
    public void visitApply(JCMethodInvocation tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1683
        // The local environment of a method application is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1684
        // a new environment nested in the current one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1685
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1686
06bc494ca11e Initial load
duke
parents:
diff changeset
  1687
        // The types of the actual method arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1688
        List<Type> argtypes;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1689
06bc494ca11e Initial load
duke
parents:
diff changeset
  1690
        // The types of the actual method type arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1691
        List<Type> typeargtypes = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1692
06bc494ca11e Initial load
duke
parents:
diff changeset
  1693
        Name methName = TreeInfo.name(tree.meth);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1694
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
        boolean isConstructorCall =
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
            methName == names._this || methName == names._super;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  1698
        ListBuffer<Type> argtypesBuf = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1699
        if (isConstructorCall) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1700
            // We are seeing a ...this(...) or ...super(...) call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1701
            // Check that this is the first statement in a constructor.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1702
            if (checkFirstConstructorStat(tree, env)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1703
06bc494ca11e Initial load
duke
parents:
diff changeset
  1704
                // Record the fact
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
                // that this is a constructor call (using isSelfCall).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
                localEnv.info.isSelfCall = true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1707
06bc494ca11e Initial load
duke
parents:
diff changeset
  1708
                // Attribute arguments, yielding list of argument types.
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1709
                KindSelector kind = attribArgs(KindSelector.MTH, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1710
                argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1711
                typeargtypes = attribTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1712
06bc494ca11e Initial load
duke
parents:
diff changeset
  1713
                // Variable `site' points to the class in which the called
06bc494ca11e Initial load
duke
parents:
diff changeset
  1714
                // constructor is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1715
                Type site = env.enclClass.sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1716
                if (methName == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1717
                    if (site == syms.objectType) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
                        log.error(tree.meth.pos(), "no.superclass", site);
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  1719
                        site = types.createErrorType(syms.objectType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1720
                    } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
                        site = types.supertype(site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1722
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1723
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1724
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1725
                if (site.hasTag(CLASS)) {
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1726
                    Type encl = site.getEnclosingType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1727
                    while (encl != null && encl.hasTag(TYPEVAR))
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1728
                        encl = encl.getUpperBound();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1729
                    if (encl.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1730
                        // we are calling a nested class
06bc494ca11e Initial load
duke
parents:
diff changeset
  1731
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1732
                        if (tree.meth.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
                            JCTree qualifier = ((JCFieldAccess) tree.meth).selected;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1734
06bc494ca11e Initial load
duke
parents:
diff changeset
  1735
                            // We are seeing a prefixed call, of the form
06bc494ca11e Initial load
duke
parents:
diff changeset
  1736
                            //     <expr>.super(...).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1737
                            // Check that the prefix expression conforms
06bc494ca11e Initial load
duke
parents:
diff changeset
  1738
                            // to the outer instance type of the class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
                            chk.checkRefType(qualifier.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1740
                                             attribExpr(qualifier, localEnv,
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  1741
                                                        encl));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1742
                        } else if (methName == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1743
                            // qualifier omitted; check for existence
06bc494ca11e Initial load
duke
parents:
diff changeset
  1744
                            // of an appropriate implicit qualifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1745
                            rs.resolveImplicitThis(tree.meth.pos(),
8622
4f032629a0fd 6541876: "Enclosing Instance" error new in 1.6
mcimadamore
parents: 8616
diff changeset
  1746
                                                   localEnv, site, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1747
                        }
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1748
                    } else if (tree.meth.hasTag(SELECT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1749
                        log.error(tree.meth.pos(), "illegal.qual.not.icls",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1750
                                  site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1751
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1752
06bc494ca11e Initial load
duke
parents:
diff changeset
  1753
                    // if we're calling a java.lang.Enum constructor,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1754
                    // prefix the implicit String and int parameters
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1755
                    if (site.tsym == syms.enumSym)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1756
                        argtypes = argtypes.prepend(syms.intType).prepend(syms.stringType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1757
06bc494ca11e Initial load
duke
parents:
diff changeset
  1758
                    // Resolve the called constructor under the assumption
06bc494ca11e Initial load
duke
parents:
diff changeset
  1759
                    // that we are referring to a superclass instance of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1760
                    // current instance (JLS ???).
06bc494ca11e Initial load
duke
parents:
diff changeset
  1761
                    boolean selectSuperPrev = localEnv.info.selectSuper;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1762
                    localEnv.info.selectSuper = true;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1763
                    localEnv.info.pendingResolutionPhase = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1764
                    Symbol sym = rs.resolveConstructor(
06bc494ca11e Initial load
duke
parents:
diff changeset
  1765
                        tree.meth.pos(), localEnv, site, argtypes, typeargtypes);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1766
                    localEnv.info.selectSuper = selectSuperPrev;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1767
06bc494ca11e Initial load
duke
parents:
diff changeset
  1768
                    // Set method symbol to resolved constructor...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1769
                    TreeInfo.setSymbol(tree.meth, sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1770
06bc494ca11e Initial load
duke
parents:
diff changeset
  1771
                    // ...and check that it is legal in the current context.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1772
                    // (this will also set the tree's type)
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  1773
                    Type mpt = newMethodTemplate(resultInfo.pt, argtypes, typeargtypes);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1774
                    checkId(tree.meth, site, sym, localEnv,
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1775
                            new ResultInfo(kind, mpt));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1776
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1777
                // Otherwise, `site' is an error type and we do nothing
06bc494ca11e Initial load
duke
parents:
diff changeset
  1778
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
            result = tree.type = syms.voidType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1780
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1781
            // Otherwise, we are seeing a regular method call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1782
            // Attribute the arguments, yielding list of argument types, ...
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1783
            KindSelector kind = attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1784
            argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1785
            typeargtypes = attribAnyTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1786
06bc494ca11e Initial load
duke
parents:
diff changeset
  1787
            // ... and attribute the method using as a prototype a methodtype
06bc494ca11e Initial load
duke
parents:
diff changeset
  1788
            // whose formal argument types is exactly the list of actual
06bc494ca11e Initial load
duke
parents:
diff changeset
  1789
            // arguments (this will also set the method symbol).
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  1790
            Type mpt = newMethodTemplate(resultInfo.pt, argtypes, typeargtypes);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1791
            localEnv.info.pendingResolutionPhase = null;
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1792
            Type mtype = attribTree(tree.meth, localEnv, new ResultInfo(kind, mpt, resultInfo.checkContext));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1793
06bc494ca11e Initial load
duke
parents:
diff changeset
  1794
            // Compute the result type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1795
            Type restype = mtype.getReturnType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1796
            if (restype.hasTag(WILDCARD))
6710
b14e6fe7b290 5088624: cannot find symbol message should be more intelligent
mcimadamore
parents: 6594
diff changeset
  1797
                throw new AssertionError(mtype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1798
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1799
            Type qualifier = (tree.meth.hasTag(SELECT))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1800
                    ? ((JCFieldAccess) tree.meth).selected.type
06bc494ca11e Initial load
duke
parents:
diff changeset
  1801
                    : env.enclClass.sym.type;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1802
            restype = adjustMethodReturnType(qualifier, methName, argtypes, restype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1803
8036
17b976649c61 6992698: JSR 292: remove support for transient syntax in polymorphic signature calls
mcimadamore
parents: 8032
diff changeset
  1804
            chk.checkRefTypes(tree.typeargs, typeargtypes);
2723
b659ca23d5f5 6829189: Java programming with JSR 292 needs language support
jrose
parents: 2212
diff changeset
  1805
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1806
            // Check that value of resulting type is admissible in the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1807
            // current context.  Also, capture the return type
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1808
            result = check(tree, capture(restype), KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1809
        }
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1810
        chk.validate(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1812
    //where
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1813
        Type adjustMethodReturnType(Type qualifierType, Name methodName, List<Type> argtypes, Type restype) {
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1814
            if (methodName == names.clone && types.isArray(qualifierType)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1815
                // as a special case, array.clone() has a result that is
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1816
                // the same as static type of the array being cloned
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1817
                return qualifierType;
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1818
            } else if (methodName == names.getClass && argtypes.isEmpty()) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1819
                // as a special case, x.getClass() has type Class<? extends |X|>
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1820
                return new ClassType(restype.getEnclosingType(),
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1821
                              List.<Type>of(new WildcardType(types.erasure(qualifierType),
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1822
                                                               BoundKind.EXTENDS,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  1823
                                                             syms.boundClass)),
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  1824
                                     restype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  1825
                                     restype.getMetadata());
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1826
            } else {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1827
                return restype;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1828
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1829
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  1830
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1831
        /** Check that given application node appears as first statement
06bc494ca11e Initial load
duke
parents:
diff changeset
  1832
         *  in a constructor call.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1833
         *  @param tree   The application node
06bc494ca11e Initial load
duke
parents:
diff changeset
  1834
         *  @param env    The environment current at the application.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1835
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  1836
        boolean checkFirstConstructorStat(JCMethodInvocation tree, Env<AttrContext> env) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1837
            JCMethodDecl enclMethod = env.enclMethod;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1838
            if (enclMethod != null && enclMethod.name == names.init) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1839
                JCBlock body = enclMethod.body;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1840
                if (body.stats.head.hasTag(EXEC) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1841
                    ((JCExpressionStatement) body.stats.head).expr == tree)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1842
                    return true;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1843
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1844
            log.error(tree.pos(),"call.must.be.first.stmt.in.ctor",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1845
                      TreeInfo.name(tree.meth));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1846
            return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1847
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1848
06bc494ca11e Initial load
duke
parents:
diff changeset
  1849
        /** Obtain a method type with given argument types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1850
         */
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  1851
        Type newMethodTemplate(Type restype, List<Type> argtypes, List<Type> typeargtypes) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1852
            MethodType mt = new MethodType(argtypes, restype, List.<Type>nil(), syms.methodClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1853
            return (typeargtypes == null) ? mt : (Type)new ForAll(typeargtypes, mt);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1854
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1855
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1856
    public void visitNewClass(final JCNewClass tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  1857
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1858
06bc494ca11e Initial load
duke
parents:
diff changeset
  1859
        // The local environment of a class creation is
06bc494ca11e Initial load
duke
parents:
diff changeset
  1860
        // a new environment nested in the current one.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1861
        Env<AttrContext> localEnv = env.dup(tree, env.info.dup());
06bc494ca11e Initial load
duke
parents:
diff changeset
  1862
06bc494ca11e Initial load
duke
parents:
diff changeset
  1863
        // The anonymous inner class definition of the new expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1864
        // if one is defined by it.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1865
        JCClassDecl cdef = tree.def;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1866
06bc494ca11e Initial load
duke
parents:
diff changeset
  1867
        // If enclosing class is given, attribute it, and
06bc494ca11e Initial load
duke
parents:
diff changeset
  1868
        // complete class name to be fully qualified
06bc494ca11e Initial load
duke
parents:
diff changeset
  1869
        JCExpression clazz = tree.clazz; // Class field following new
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1870
        JCExpression clazzid;            // Identifier in class field
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1871
        JCAnnotatedType annoclazzid;     // Annotated type enclosing clazzid
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1872
        annoclazzid = null;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1873
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1874
        if (clazz.hasTag(TYPEAPPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1875
            clazzid = ((JCTypeApply) clazz).clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1876
            if (clazzid.hasTag(ANNOTATED_TYPE)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1877
                annoclazzid = (JCAnnotatedType) clazzid;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1878
                clazzid = annoclazzid.underlyingType;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1879
            }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1880
        } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1881
            if (clazz.hasTag(ANNOTATED_TYPE)) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1882
                annoclazzid = (JCAnnotatedType) clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1883
                clazzid = annoclazzid.underlyingType;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1884
            } else {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1885
                clazzid = clazz;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1886
            }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1887
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1888
06bc494ca11e Initial load
duke
parents:
diff changeset
  1889
        JCExpression clazzid1 = clazzid; // The same in fully qualified form
06bc494ca11e Initial load
duke
parents:
diff changeset
  1890
06bc494ca11e Initial load
duke
parents:
diff changeset
  1891
        if (tree.encl != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
            // We are seeing a qualified new, of the form
06bc494ca11e Initial load
duke
parents:
diff changeset
  1893
            //    <expr>.new C <...> (...) ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  1894
            // In this case, we let clazz stand for the name of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  1895
            // allocated class C prefixed with the type of the qualifier
06bc494ca11e Initial load
duke
parents:
diff changeset
  1896
            // expression, so that we can
06bc494ca11e Initial load
duke
parents:
diff changeset
  1897
            // resolve it with standard techniques later. I.e., if
06bc494ca11e Initial load
duke
parents:
diff changeset
  1898
            // <expr> has type T, then <expr>.new C <...> (...)
06bc494ca11e Initial load
duke
parents:
diff changeset
  1899
            // yields a clazz T.C.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1900
            Type encltype = chk.checkRefType(tree.encl.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1901
                                             attribExpr(tree.encl, env));
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1902
            // TODO 308: in <expr>.new C, do we also want to add the type annotations
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1903
            // from expr to the combined type, or not? Yes, do this.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1904
            clazzid1 = make.at(clazz.pos).Select(make.Type(encltype),
06bc494ca11e Initial load
duke
parents:
diff changeset
  1905
                                                 ((JCIdent) clazzid).name);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1906
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18920
diff changeset
  1907
            EndPosTable endPosTable = this.env.toplevel.endPositions;
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18920
diff changeset
  1908
            endPosTable.storeEnd(clazzid1, tree.getEndPosition(endPosTable));
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1909
            if (clazz.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1910
                JCAnnotatedType annoType = (JCAnnotatedType) clazz;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1911
                List<JCAnnotation> annos = annoType.annotations;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1912
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1913
                if (annoType.underlyingType.hasTag(TYPEAPPLY)) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1914
                    clazzid1 = make.at(tree.pos).
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1915
                        TypeApply(clazzid1,
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1916
                                  ((JCTypeApply) clazz).arguments);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1917
                }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1918
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1919
                clazzid1 = make.at(tree.pos).
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1920
                    AnnotatedType(annos, clazzid1);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1921
            } else if (clazz.hasTag(TYPEAPPLY)) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1922
                clazzid1 = make.at(tree.pos).
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1923
                    TypeApply(clazzid1,
06bc494ca11e Initial load
duke
parents:
diff changeset
  1924
                              ((JCTypeApply) clazz).arguments);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1925
            }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1926
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1927
            clazz = clazzid1;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1928
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1929
06bc494ca11e Initial load
duke
parents:
diff changeset
  1930
        // Attribute clazz expression and store
06bc494ca11e Initial load
duke
parents:
diff changeset
  1931
        // symbol + type back into the attributed tree.
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1932
        Type clazztype = TreeInfo.isEnumInit(env.tree) ?
12916
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
  1933
            attribIdentAsEnumType(env, (JCIdent)clazz) :
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
  1934
            attribType(clazz, env);
021c069e8e27 7160084: javac fails to compile an apparently valid class/interface combination
mcimadamore
parents: 12915
diff changeset
  1935
8635
383a416a2bdf 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes
mcimadamore
parents: 8625
diff changeset
  1936
        clazztype = chk.checkDiamond(tree, clazztype);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  1937
        chk.validate(clazz, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1938
        if (tree.encl != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1939
            // We have to work in this case to store
06bc494ca11e Initial load
duke
parents:
diff changeset
  1940
            // symbol + type back into the attributed tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1941
            tree.clazz.type = clazztype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  1942
            TreeInfo.setSymbol(clazzid, TreeInfo.symbol(clazzid1));
06bc494ca11e Initial load
duke
parents:
diff changeset
  1943
            clazzid.type = ((JCIdent) clazzid).sym.type;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1944
            if (annoclazzid != null) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1945
                annoclazzid.type = clazzid.type;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  1946
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1947
            if (!clazztype.isErroneous()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1948
                if (cdef != null && clazztype.tsym.isInterface()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1949
                    log.error(tree.encl.pos(), "anon.class.impl.intf.no.qual.for.new");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1950
                } else if (clazztype.tsym.isStatic()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1951
                    log.error(tree.encl.pos(), "qualified.new.of.static.class", clazztype.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1952
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1953
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1954
        } else if (!clazztype.tsym.isInterface() &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1955
                   clazztype.getEnclosingType().hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1956
            // Check for the existence of an apropos outer instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  1957
            rs.resolveImplicitThis(tree.pos(), env, clazztype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1958
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1959
06bc494ca11e Initial load
duke
parents:
diff changeset
  1960
        // Attribute constructor arguments.
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  1961
        ListBuffer<Type> argtypesBuf = new ListBuffer<>();
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  1962
        final KindSelector pkind =
27856
d4711a6931e2 8065986: Compiler fails to NullPointerException when calling super with Object<>()
mcimadamore
parents: 27851
diff changeset
  1963
            attribArgs(KindSelector.VAL, tree.args, localEnv, argtypesBuf);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  1964
        List<Type> argtypes = argtypesBuf.toList();
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  1965
        List<Type> typeargtypes = attribTypes(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1966
06bc494ca11e Initial load
duke
parents:
diff changeset
  1967
        // If we have made no mistakes in the class type...
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  1968
        if (clazztype.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1969
            // Enums may not be instantiated except implicitly
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1970
            if ((clazztype.tsym.flags_field & Flags.ENUM) != 0 &&
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  1971
                (!env.tree.hasTag(VARDEF) ||
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  1972
                 (((JCVariableDecl) env.tree).mods.flags & Flags.ENUM) == 0 ||
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1973
                 ((JCVariableDecl) env.tree).init != tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  1974
                log.error(tree.pos(), "enum.cant.be.instantiated");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1975
            // Check that class is not abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  1976
            if (cdef == null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  1977
                (clazztype.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1978
                log.error(tree.pos(), "abstract.cant.be.instantiated",
06bc494ca11e Initial load
duke
parents:
diff changeset
  1979
                          clazztype.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  1980
            } else if (cdef != null && clazztype.tsym.isInterface()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  1981
                // Check that no constructor arguments are given to
06bc494ca11e Initial load
duke
parents:
diff changeset
  1982
                // anonymous classes implementing an interface
06bc494ca11e Initial load
duke
parents:
diff changeset
  1983
                if (!argtypes.isEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1984
                    log.error(tree.args.head.pos(), "anon.class.impl.intf.no.args");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1985
06bc494ca11e Initial load
duke
parents:
diff changeset
  1986
                if (!typeargtypes.isEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  1987
                    log.error(tree.typeargs.head.pos(), "anon.class.impl.intf.no.typeargs");
06bc494ca11e Initial load
duke
parents:
diff changeset
  1988
06bc494ca11e Initial load
duke
parents:
diff changeset
  1989
                // Error recovery: pretend no arguments were supplied.
06bc494ca11e Initial load
duke
parents:
diff changeset
  1990
                argtypes = List.nil();
06bc494ca11e Initial load
duke
parents:
diff changeset
  1991
                typeargtypes = List.nil();
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1992
            } else if (TreeInfo.isDiamond(tree)) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1993
                ClassType site = new ClassType(clazztype.getEnclosingType(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1994
                            clazztype.tsym.type.getTypeArguments(),
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  1995
                                               clazztype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  1996
                                               clazztype.getMetadata());
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1997
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1998
                Env<AttrContext> diamondEnv = localEnv.dup(tree);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  1999
                diamondEnv.info.selectSuper = cdef != null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2000
                diamondEnv.info.pendingResolutionPhase = null;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2001
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2002
                //if the type of the instance creation expression is a class type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2003
                //apply method resolution inference (JLS 15.12.2.7). The return type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2004
                //of the resolved constructor will be a partially instantiated type
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2005
                Symbol constructor = rs.resolveDiamond(tree.pos(),
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2006
                            diamondEnv,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2007
                            site,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2008
                            argtypes,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2009
                            typeargtypes);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2010
                tree.constructor = constructor.baseSymbol();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2011
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2012
                final TypeSymbol csym = clazztype.tsym;
24794
22946bb4c27d 8041713: Type inference of non-existent method references crashes the compiler
vromero
parents: 24612
diff changeset
  2013
                ResultInfo diamondResult = new ResultInfo(pkind, newMethodTemplate(resultInfo.pt, argtypes, typeargtypes), new Check.NestedCheckContext(resultInfo.checkContext) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2014
                    @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2015
                    public void report(DiagnosticPosition _unused, JCDiagnostic details) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2016
                        enclosingContext.report(tree.clazz,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2017
                                diags.fragment("cant.apply.diamond.1", diags.fragment("diamond", csym), details));
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2018
                    }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2019
                });
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2020
                Type constructorType = tree.constructorType = types.createErrorType(clazztype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2021
                constructorType = checkId(tree, site,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2022
                        constructor,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2023
                        diamondEnv,
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2024
                        diamondResult);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2025
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2026
                tree.clazz.type = types.createErrorType(clazztype);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2027
                if (!constructorType.isErroneous()) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2028
                    tree.clazz.type = clazztype = constructorType.getReturnType();
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2029
                    tree.constructorType = types.createMethodTypeWithReturn(constructorType, syms.voidType);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2030
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2031
                clazztype = chk.checkClassType(tree.clazz, tree.clazz.type, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2032
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2033
06bc494ca11e Initial load
duke
parents:
diff changeset
  2034
            // Resolve the called constructor under the assumption
06bc494ca11e Initial load
duke
parents:
diff changeset
  2035
            // that we are referring to a superclass instance of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2036
            // current instance (JLS ???).
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2037
            else {
9724
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2038
                //the following code alters some of the fields in the current
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2039
                //AttrContext - hence, the current context must be dup'ed in
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2040
                //order to avoid downstream failures
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2041
                Env<AttrContext> rsEnv = localEnv.dup(tree);
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2042
                rsEnv.info.selectSuper = cdef != null;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2043
                rsEnv.info.pendingResolutionPhase = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2044
                tree.constructor = rs.resolveConstructor(
9724
1eab738591a7 7043922: Regression: internal compiler error for nested anonymous inner class featuring varargs constructor
mcimadamore
parents: 9599
diff changeset
  2045
                    tree.pos(), rsEnv, clazztype, argtypes, typeargtypes);
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2046
                if (cdef == null) { //do not check twice!
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2047
                    tree.constructorType = checkId(tree,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2048
                            clazztype,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2049
                            tree.constructor,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2050
                            rsEnv,
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2051
                            new ResultInfo(pkind, newMethodTemplate(syms.voidType, argtypes, typeargtypes)));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2052
                    if (rsEnv.info.lastResolveVarargs())
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2053
                        Assert.check(tree.constructorType.isErroneous() || tree.varargsElement != null);
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2054
                }
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2055
                if (cdef == null &&
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2056
                        !clazztype.isErroneous() &&
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2057
                        clazztype.getTypeArguments().nonEmpty() &&
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2058
                        findDiamonds) {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2059
                    findDiamond(localEnv, tree, clazztype);
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2060
                }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2061
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2062
06bc494ca11e Initial load
duke
parents:
diff changeset
  2063
            if (cdef != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2064
                // We are seeing an anonymous class instance creation.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2065
                // In this case, the class instance creation
06bc494ca11e Initial load
duke
parents:
diff changeset
  2066
                // expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2067
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2068
                //    E.new <typeargs1>C<typargs2>(args) { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2069
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2070
                // is represented internally as
06bc494ca11e Initial load
duke
parents:
diff changeset
  2071
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2072
                //    E . new <typeargs1>C<typargs2>(args) ( class <empty-name> { ... } )  .
06bc494ca11e Initial load
duke
parents:
diff changeset
  2073
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2074
                // This expression is then *transformed* as follows:
06bc494ca11e Initial load
duke
parents:
diff changeset
  2075
                //
23803
98c4ebaddefc 8034044: Class.getModifiers() returns "static" for anonymous classes
igerasim
parents: 23134
diff changeset
  2076
                // (1) add an extends or implements clause
98c4ebaddefc 8034044: Class.getModifiers() returns "static" for anonymous classes
igerasim
parents: 23134
diff changeset
  2077
                // (2) add a constructor.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2078
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2079
                // For instance, if C is a class, and ET is the type of E,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2080
                // the expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2081
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2082
                //    E.new <typeargs1>C<typargs2>(args) { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2083
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2084
                // is translated to (where X is a fresh name and typarams is the
06bc494ca11e Initial load
duke
parents:
diff changeset
  2085
                // parameter list of the super constructor):
06bc494ca11e Initial load
duke
parents:
diff changeset
  2086
                //
06bc494ca11e Initial load
duke
parents:
diff changeset
  2087
                //   new <typeargs1>X(<*nullchk*>E, args) where
06bc494ca11e Initial load
duke
parents:
diff changeset
  2088
                //     X extends C<typargs2> {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2089
                //       <typarams> X(ET e, args) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2090
                //         e.<typeargs1>super(args)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2091
                //       }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2092
                //       ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  2093
                //     }
5320
e2aaa958b02d 6939618: Revert 'simple' diamond implementation
mcimadamore
parents: 5002
diff changeset
  2094
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2095
                if (clazztype.tsym.isInterface()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2096
                    cdef.implementing = List.of(clazz);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2097
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2098
                    cdef.extending = clazz;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2099
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2100
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2101
                if (resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2102
                    isSerializable(clazztype)) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2103
                    localEnv.info.isSerializable = true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2104
                }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2105
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2106
                attribStat(cdef, localEnv);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2107
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2108
                checkLambdaCandidate(tree, cdef.sym, clazztype);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2109
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2110
                // If an outer instance is given,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2111
                // prefix it to the constructor arguments
06bc494ca11e Initial load
duke
parents:
diff changeset
  2112
                // and delete it from the new expression
06bc494ca11e Initial load
duke
parents:
diff changeset
  2113
                if (tree.encl != null && !clazztype.tsym.isInterface()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2114
                    tree.args = tree.args.prepend(makeNullCheck(tree.encl));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2115
                    argtypes = argtypes.prepend(tree.encl.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2116
                    tree.encl = null;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2117
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2118
06bc494ca11e Initial load
duke
parents:
diff changeset
  2119
                // Reassign clazztype and recompute constructor.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2120
                clazztype = cdef.sym.type;
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2121
                Symbol sym = tree.constructor = rs.resolveConstructor(
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2122
                    tree.pos(), localEnv, clazztype, argtypes, typeargtypes);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2123
                Assert.check(!sym.kind.isOverloadError());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2124
                tree.constructor = sym;
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2125
                tree.constructorType = checkId(tree,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2126
                    clazztype,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2127
                    tree.constructor,
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  2128
                    localEnv,
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2129
                    new ResultInfo(pkind, newMethodTemplate(syms.voidType, argtypes, typeargtypes)));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2130
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2131
06bc494ca11e Initial load
duke
parents:
diff changeset
  2132
            if (tree.constructor != null && tree.constructor.kind == MTH)
06bc494ca11e Initial load
duke
parents:
diff changeset
  2133
                owntype = clazztype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2134
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2135
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
1358
a51c5f89f8af 6747671: -Xlint:rawtypes
mcimadamore
parents: 1260
diff changeset
  2136
        chk.validate(tree.typeargs, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2137
    }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2138
    //where
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2139
        void findDiamond(Env<AttrContext> env, JCNewClass tree, Type clazztype) {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2140
            JCTypeApply ta = (JCTypeApply)tree.clazz;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2141
            List<JCExpression> prevTypeargs = ta.arguments;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2142
            try {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2143
                //create a 'fake' diamond AST node by removing type-argument trees
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2144
                ta.arguments = List.nil();
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2145
                ResultInfo findDiamondResult = new ResultInfo(KindSelector.VAL,
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2146
                        resultInfo.checkContext.inferenceContext().free(resultInfo.pt) ? Type.noType : pt());
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2147
                Type inferred = deferredAttr.attribSpeculative(tree, env, findDiamondResult).type;
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2148
                Type polyPt = allowPoly ?
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2149
                        syms.objectType :
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2150
                        clazztype;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2151
                if (!inferred.isErroneous() &&
19132
e2349c075315 8021338: Diamond finder may mark a required type argument as unnecessary
jlahoda
parents: 19127
diff changeset
  2152
                    (allowPoly && pt() == Infer.anyPoly ?
e2349c075315 8021338: Diamond finder may mark a required type argument as unnecessary
jlahoda
parents: 19127
diff changeset
  2153
                        types.isSameType(inferred, clazztype) :
e2349c075315 8021338: Diamond finder may mark a required type argument as unnecessary
jlahoda
parents: 19127
diff changeset
  2154
                        types.isAssignable(inferred, pt().hasTag(NONE) ? polyPt : pt(), types.noWarnings))) {
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2155
                    String key = types.isSameType(clazztype, inferred) ?
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2156
                        "diamond.redundant.args" :
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2157
                        "diamond.redundant.args.1";
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2158
                    log.warning(tree.clazz.pos(), key, clazztype, inferred);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2159
                }
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2160
            } finally {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  2161
                ta.arguments = prevTypeargs;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2162
            }
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  2163
        }
9075
cba34854a40e 7030150: Type inference for generic instance creation failed for formal type parameter
mcimadamore
parents: 9074
diff changeset
  2164
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2165
            private void checkLambdaCandidate(JCNewClass tree, ClassSymbol csym, Type clazztype) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2166
                if (allowLambda &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2167
                        identifyLambdaCandidate &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2168
                        clazztype.hasTag(CLASS) &&
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2169
                        !pt().hasTag(NONE) &&
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2170
                        types.isFunctionalInterface(clazztype.tsym)) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2171
                    Symbol descriptor = types.findDescriptorSymbol(clazztype.tsym);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2172
                    int count = 0;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2173
                    boolean found = false;
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2174
                    for (Symbol sym : csym.members().getSymbols()) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2175
                        if ((sym.flags() & SYNTHETIC) != 0 ||
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2176
                                sym.isConstructor()) continue;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2177
                        count++;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2178
                        if (sym.kind != MTH ||
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2179
                                !sym.name.equals(descriptor.name)) continue;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2180
                        Type mtype = types.memberType(clazztype, sym);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2181
                        if (types.overrideEquivalent(mtype, types.memberType(clazztype, descriptor))) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2182
                            found = true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2183
                        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2184
                    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2185
                    if (found && count == 1) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2186
                        log.note(tree.def, "potential.lambda.found");
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2187
                    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2188
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2189
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2190
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2191
    /** Make an attributed null check tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2192
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  2193
    public JCExpression makeNullCheck(JCExpression arg) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2194
        // optimization: X.this is never null; skip null check
06bc494ca11e Initial load
duke
parents:
diff changeset
  2195
        Name name = TreeInfo.name(arg);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2196
        if (name == names._this || name == names._super) return arg;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2197
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2198
        JCTree.Tag optag = NULLCHK;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2199
        JCUnary tree = make.at(arg.pos).Unary(optag, arg);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2200
        tree.operator = syms.nullcheck;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2201
        tree.type = arg.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2202
        return tree;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2203
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2204
06bc494ca11e Initial load
duke
parents:
diff changeset
  2205
    public void visitNewArray(JCNewArray tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  2206
        Type owntype = types.createErrorType(tree.type);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2207
        Env<AttrContext> localEnv = env.dup(tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2208
        Type elemtype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2209
        if (tree.elemtype != null) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2210
            elemtype = attribType(tree.elemtype, localEnv);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2211
            chk.validate(tree.elemtype, localEnv);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2212
            owntype = elemtype;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2213
            for (List<JCExpression> l = tree.dims; l.nonEmpty(); l = l.tail) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2214
                attribExpr(l.head, localEnv, syms.intType);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  2215
                owntype = new ArrayType(owntype, syms.arrayClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2216
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2217
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2218
            // we are seeing an untyped aggregate { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2219
            // this is allowed only if the prototype is an array
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2220
            if (pt().hasTag(ARRAY)) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2221
                elemtype = types.elemtype(pt());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2222
            } else {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2223
                if (!pt().hasTag(ERROR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2224
                    log.error(tree.pos(), "illegal.initializer.for.type",
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2225
                              pt());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2226
                }
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2227
                elemtype = types.createErrorType(pt());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2228
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2229
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2230
        if (tree.elems != null) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  2231
            attribExprs(tree.elems, localEnv, elemtype);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  2232
            owntype = new ArrayType(elemtype, syms.arrayClass);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2233
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2234
        if (!types.isReifiable(elemtype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  2235
            log.error(tree.pos(), "generic.array.creation");
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2236
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2237
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2238
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2239
    /*
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2240
     * A lambda expression can only be attributed when a target-type is available.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2241
     * In addition, if the target-type is that of a functional interface whose
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2242
     * descriptor contains inference variables in argument position the lambda expression
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2243
     * is 'stuck' (see DeferredAttr).
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2244
     */
11143
9dbe313bfb74 7115050: Add parser support for lambda expressions
mcimadamore
parents: 10950
diff changeset
  2245
    @Override
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2246
    public void visitLambda(final JCLambda that) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2247
        if (pt().isErroneous() || (pt().hasTag(NONE) && pt() != Type.recoveryType)) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2248
            if (pt().hasTag(NONE)) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2249
                //lambda only allowed in assignment or method invocation/cast context
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2250
                log.error(that.pos(), "unexpected.lambda");
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2251
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2252
            result = that.type = types.createErrorType(pt());
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2253
            return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2254
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2255
        //create an environment for attribution of the lambda expression
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2256
        final Env<AttrContext> localEnv = lambdaEnv(that, env);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2257
        boolean needsRecovery =
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2258
                resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2259
        try {
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2260
            Type currentTarget = pt();
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2261
            if (needsRecovery && isSerializable(currentTarget)) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2262
                localEnv.info.isSerializable = true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2263
            }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2264
            List<Type> explicitParamTypes = null;
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2265
            if (that.paramKind == JCLambda.ParameterKind.EXPLICIT) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2266
                //attribute lambda parameters
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2267
                attribStats(that.params, localEnv);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2268
                explicitParamTypes = TreeInfo.types(that.params);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2269
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2270
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2271
            Type lambdaType;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2272
            if (pt() != Type.recoveryType) {
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2273
                /* We need to adjust the target. If the target is an
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2274
                 * intersection type, for example: SAM & I1 & I2 ...
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2275
                 * the target will be updated to SAM
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2276
                 */
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2277
                currentTarget = targetChecker.visit(currentTarget, that);
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2278
                if (explicitParamTypes != null) {
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2279
                    currentTarget = infer.instantiateFunctionalInterface(that,
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2280
                            currentTarget, explicitParamTypes, resultInfo.checkContext);
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2281
                }
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
  2282
                currentTarget = types.removeWildcards(currentTarget);
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2283
                lambdaType = types.findDescriptorType(currentTarget);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2284
            } else {
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2285
                currentTarget = Type.recoveryType;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2286
                lambdaType = fallbackDescriptorType(that);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2287
            }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2288
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2289
            setFunctionalInfo(localEnv, that, pt(), lambdaType, currentTarget, resultInfo.checkContext);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2290
14723
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2291
            if (lambdaType.hasTag(FORALL)) {
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2292
                //lambda expression target desc cannot be a generic method
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2293
                resultInfo.checkContext.report(that, diags.fragment("invalid.generic.lambda.target",
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2294
                        lambdaType, kindName(currentTarget.tsym), currentTarget.tsym));
14723
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2295
                result = that.type = types.createErrorType(pt());
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2296
                return;
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2297
            }
46aa71a5e4e0 8004102: Add support for generic functional descriptors
mcimadamore
parents: 14722
diff changeset
  2298
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2299
            if (that.paramKind == JCLambda.ParameterKind.IMPLICIT) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2300
                //add param type info in the AST
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2301
                List<Type> actuals = lambdaType.getParameterTypes();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2302
                List<JCVariableDecl> params = that.params;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2303
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2304
                boolean arityMismatch = false;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2305
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2306
                while (params.nonEmpty()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2307
                    if (actuals.isEmpty()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2308
                        //not enough actuals to perform lambda parameter inference
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2309
                        arityMismatch = true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2310
                    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2311
                    //reset previously set info
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2312
                    Type argType = arityMismatch ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2313
                            syms.errType :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2314
                            actuals.head;
17584
3c4dfe34c2ec 8013222: Javac issues spurious raw type warnings when lambda has implicit parameter types
mcimadamore
parents: 17583
diff changeset
  2315
                    params.head.vartype = make.at(params.head).Type(argType);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2316
                    params.head.sym = null;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2317
                    actuals = actuals.isEmpty() ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2318
                            actuals :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2319
                            actuals.tail;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2320
                    params = params.tail;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2321
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2322
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2323
                //attribute lambda parameters
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2324
                attribStats(that.params, localEnv);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2325
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2326
                if (arityMismatch) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2327
                    resultInfo.checkContext.report(that, diags.fragment("incompatible.arg.types.in.lambda"));
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2328
                        result = that.type = types.createErrorType(currentTarget);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2329
                        return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2330
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2331
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2332
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2333
            //from this point on, no recovery is needed; if we are in assignment context
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2334
            //we will be able to attribute the whole lambda body, regardless of errors;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2335
            //if we are in a 'check' method context, and the lambda is not compatible
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2336
            //with the target-type, it will be recovered anyway in Attr.checkId
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2337
            needsRecovery = false;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2338
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2339
            FunctionalReturnContext funcContext = that.getBodyKind() == JCLambda.BodyKind.EXPRESSION ?
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2340
                    new ExpressionLambdaReturnContext((JCExpression)that.getBody(), resultInfo.checkContext) :
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2341
                    new FunctionalReturnContext(resultInfo.checkContext);
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2342
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2343
            ResultInfo bodyResultInfo = lambdaType.getReturnType() == Type.recoveryType ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2344
                recoveryInfo :
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2345
                new ResultInfo(KindSelector.VAL,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2346
                               lambdaType.getReturnType(), funcContext);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2347
            localEnv.info.returnResult = bodyResultInfo;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2348
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2349
            if (that.getBodyKind() == JCLambda.BodyKind.EXPRESSION) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2350
                attribTree(that.getBody(), localEnv, bodyResultInfo);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2351
            } else {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2352
                JCBlock body = (JCBlock)that.body;
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  2353
                attribStats(body.stats, localEnv);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2354
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2355
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2356
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2357
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2358
            boolean isSpeculativeRound =
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2359
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2360
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2361
            preFlow(that);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2362
            flow.analyzeLambda(env, that, make, isSpeculativeRound);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2363
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2364
            checkLambdaCompatible(that, lambdaType, resultInfo.checkContext);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2365
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2366
            if (!isSpeculativeRound) {
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2367
                //add thrown types as bounds to the thrown types free variables if needed:
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2368
                if (resultInfo.checkContext.inferenceContext().free(lambdaType.getThrownTypes())) {
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2369
                    List<Type> inferredThrownTypes = flow.analyzeLambdaThrownTypes(env, that, make);
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2370
                    List<Type> thrownTypes = resultInfo.checkContext.inferenceContext().asUndetVars(lambdaType.getThrownTypes());
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2371
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2372
                    chk.unhandled(inferredThrownTypes, thrownTypes);
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2373
                }
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2374
19916
5b5f188dbdd4 8023389: Javac fails to infer type for lambda used with intersection type and wildcards
vromero
parents: 19914
diff changeset
  2375
                checkAccessibleTypes(that, localEnv, resultInfo.checkContext.inferenceContext(), lambdaType, currentTarget);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2376
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2377
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2378
        } catch (Types.FunctionDescriptorLookupError ex) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2379
            JCDiagnostic cause = ex.getDiagnostic();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2380
            resultInfo.checkContext.report(that, cause);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2381
            result = that.type = types.createErrorType(pt());
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2382
            return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2383
        } finally {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2384
            localEnv.info.scope.leave();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2385
            if (needsRecovery) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2386
                attribTree(that, env, recoveryInfo);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2387
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2388
        }
11143
9dbe313bfb74 7115050: Add parser support for lambda expressions
mcimadamore
parents: 10950
diff changeset
  2389
    }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2390
    //where
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2391
        void preFlow(JCLambda tree) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2392
            new PostAttrAnalyzer() {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2393
                @Override
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2394
                public void scan(JCTree tree) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2395
                    if (tree == null ||
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2396
                            (tree.type != null &&
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2397
                            tree.type == Type.stuckType)) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2398
                        //don't touch stuck expressions!
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2399
                        return;
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2400
                    }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2401
                    super.scan(tree);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2402
                }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2403
            }.scan(tree);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2404
        }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18911
diff changeset
  2405
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2406
        Types.MapVisitor<DiagnosticPosition> targetChecker = new Types.MapVisitor<DiagnosticPosition>() {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2407
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2408
            @Override
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2409
            public Type visitClassType(ClassType t, DiagnosticPosition pos) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2410
                return t.isCompound() ?
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2411
                        visitIntersectionClassType((IntersectionClassType)t, pos) : t;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2412
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2413
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2414
            public Type visitIntersectionClassType(IntersectionClassType ict, DiagnosticPosition pos) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2415
                Symbol desc = types.findDescriptorSymbol(makeNotionalInterface(ict));
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2416
                Type target = null;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2417
                for (Type bound : ict.getExplicitComponents()) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2418
                    TypeSymbol boundSym = bound.tsym;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2419
                    if (types.isFunctionalInterface(boundSym) &&
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2420
                            types.findDescriptorSymbol(boundSym) == desc) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2421
                        target = bound;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2422
                    } else if (!boundSym.isInterface() || (boundSym.flags() & ANNOTATION) != 0) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2423
                        //bound must be an interface
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2424
                        reportIntersectionError(pos, "not.an.intf.component", boundSym);
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2425
                    }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  2426
                }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2427
                return target != null ?
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2428
                        target :
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2429
                        ict.getExplicitComponents().head; //error recovery
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  2430
            }
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2431
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2432
            private TypeSymbol makeNotionalInterface(IntersectionClassType ict) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2433
                ListBuffer<Type> targs = new ListBuffer<>();
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2434
                ListBuffer<Type> supertypes = new ListBuffer<>();
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2435
                for (Type i : ict.interfaces_field) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2436
                    if (i.isParameterized()) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2437
                        targs.appendList(i.tsym.type.allparams());
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2438
                    }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2439
                    supertypes.append(i.tsym.type);
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2440
                }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2441
                IntersectionClassType notionalIntf =
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2442
                        (IntersectionClassType)types.makeCompoundType(supertypes.toList());
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2443
                notionalIntf.allparams_field = targs.toList();
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2444
                notionalIntf.tsym.flags_field |= INTERFACE;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2445
                return notionalIntf.tsym;
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2446
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2447
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2448
            private void reportIntersectionError(DiagnosticPosition pos, String key, Object... args) {
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2449
                resultInfo.checkContext.report(pos, diags.fragment("bad.intersection.target.for.functional.expr",
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2450
                        diags.fragment(key, args)));
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2451
            }
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2452
        };
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2453
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2454
        private Type fallbackDescriptorType(JCExpression tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2455
            switch (tree.getTag()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2456
                case LAMBDA:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2457
                    JCLambda lambda = (JCLambda)tree;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2458
                    List<Type> argtypes = List.nil();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2459
                    for (JCVariableDecl param : lambda.params) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2460
                        argtypes = param.vartype != null ?
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2461
                                argtypes.append(param.vartype.type) :
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2462
                                argtypes.append(syms.errType);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2463
                    }
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2464
                    return new MethodType(argtypes, Type.recoveryType,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2465
                            List.of(syms.throwableType), syms.methodClass);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2466
                case REFERENCE:
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2467
                    return new MethodType(List.<Type>nil(), Type.recoveryType,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2468
                            List.of(syms.throwableType), syms.methodClass);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2469
                default:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2470
                    Assert.error("Cannot get here!");
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2471
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2472
            return null;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2473
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2474
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2475
        private void checkAccessibleTypes(final DiagnosticPosition pos, final Env<AttrContext> env,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2476
                final InferenceContext inferenceContext, final Type... ts) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2477
            checkAccessibleTypes(pos, env, inferenceContext, List.from(ts));
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2478
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2479
16972
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2480
        private void checkAccessibleTypes(final DiagnosticPosition pos, final Env<AttrContext> env,
b5e557f4d536 8011376: Spurious checked exception errors in nested method call
mcimadamore
parents: 16809
diff changeset
  2481
                final InferenceContext inferenceContext, final List<Type> ts) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2482
            if (inferenceContext.free(ts)) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2483
                inferenceContext.addFreeTypeListener(ts, new FreeTypeListener() {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2484
                    @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2485
                    public void typesInferred(InferenceContext inferenceContext) {
15705
c4124695db0c 8007463: Cleanup inference related classes
mcimadamore
parents: 15385
diff changeset
  2486
                        checkAccessibleTypes(pos, env, inferenceContext, inferenceContext.asInstTypes(ts));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2487
                    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2488
                });
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2489
            } else {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2490
                for (Type t : ts) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2491
                    rs.checkAccessibleType(env, t);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2492
                }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2493
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2494
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2495
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2496
        /**
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2497
         * Lambda/method reference have a special check context that ensures
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2498
         * that i.e. a lambda return type is compatible with the expected
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2499
         * type according to both the inherited context and the assignment
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2500
         * context.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2501
         */
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2502
        class FunctionalReturnContext extends Check.NestedCheckContext {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2503
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2504
            FunctionalReturnContext(CheckContext enclosingContext) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2505
                super(enclosingContext);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2506
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2507
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2508
            @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2509
            public boolean compatible(Type found, Type req, Warner warn) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2510
                //return type must be compatible in both current context and assignment context
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2511
                return chk.basicHandler.compatible(found, inferenceContext().asUndetVar(req), warn);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2512
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2513
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2514
            @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2515
            public void report(DiagnosticPosition pos, JCDiagnostic details) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2516
                enclosingContext.report(pos, diags.fragment("incompatible.ret.type.in.lambda", details));
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2517
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2518
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2519
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2520
        class ExpressionLambdaReturnContext extends FunctionalReturnContext {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2521
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2522
            JCExpression expr;
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2523
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2524
            ExpressionLambdaReturnContext(JCExpression expr, CheckContext enclosingContext) {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2525
                super(enclosingContext);
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2526
                this.expr = expr;
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2527
            }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2528
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2529
            @Override
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2530
            public boolean compatible(Type found, Type req, Warner warn) {
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2531
                //a void return is compatible with an expression statement lambda
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2532
                return TreeInfo.isExpressionStatement(expr) && req.hasTag(VOID) ||
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2533
                        super.compatible(found, req, warn);
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2534
            }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2535
        }
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2536
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2537
        /**
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2538
        * Lambda compatibility. Check that given return types, thrown types, parameter types
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2539
        * are compatible with the expected functional interface descriptor. This means that:
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2540
        * (i) parameter types must be identical to those of the target descriptor; (ii) return
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2541
        * types must be compatible with the return type of the expected descriptor.
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2542
        */
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19918
diff changeset
  2543
        private void checkLambdaCompatible(JCLambda tree, Type descriptor, CheckContext checkContext) {
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2544
            Type returnType = checkContext.inferenceContext().asUndetVar(descriptor.getReturnType());
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2545
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2546
            //return values have already been checked - but if lambda has no return
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2547
            //values, we must ensure that void/value compatibility is correct;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2548
            //this amounts at checking that, if a lambda body can complete normally,
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2549
            //the descriptor's return type must be void
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2550
            if (tree.getBodyKind() == JCLambda.BodyKind.STATEMENT && tree.canCompleteNormally &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2551
                    !returnType.hasTag(VOID) && returnType != Type.recoveryType) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2552
                checkContext.report(tree, diags.fragment("incompatible.ret.type.in.lambda",
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2553
                        diags.fragment("missing.ret.val", returnType)));
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2554
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2555
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2556
            List<Type> argTypes = checkContext.inferenceContext().asUndetVars(descriptor.getParameterTypes());
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2557
            if (!types.isSameTypes(argTypes, TreeInfo.types(tree.params))) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2558
                checkContext.report(tree, diags.fragment("incompatible.arg.types.in.lambda"));
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2559
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2560
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2561
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2562
        /* Map to hold 'fake' clinit methods. If a lambda is used to initialize a
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2563
         * static field and that lambda has type annotations, these annotations will
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2564
         * also be stored at these fake clinit methods.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2565
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2566
         * LambdaToMethod also use fake clinit methods so they can be reused.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2567
         * Also as LTM is a phase subsequent to attribution, the methods from
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2568
         * clinits can be safely removed by LTM to save memory.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2569
         */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2570
        private Map<ClassSymbol, MethodSymbol> clinits = new HashMap<>();
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2571
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2572
        public MethodSymbol removeClinit(ClassSymbol sym) {
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2573
            return clinits.remove(sym);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2574
        }
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2575
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2576
        /* This method returns an environment to be used to attribute a lambda
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2577
         * expression.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2578
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2579
         * The owner of this environment is a method symbol. If the current owner
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2580
         * is not a method, for example if the lambda is used to initialize
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2581
         * a field, then if the field is:
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2582
         *
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2583
         * - an instance field, we use the first constructor.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2584
         * - a static field, we create a fake clinit method.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2585
         */
24066
1dfb66929538 8029718: Should always use lambda body structure to disambiguate overload resolution
vromero
parents: 23969
diff changeset
  2586
        public Env<AttrContext> lambdaEnv(JCLambda that, Env<AttrContext> env) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2587
            Env<AttrContext> lambdaEnv;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2588
            Symbol owner = env.info.scope.owner;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2589
            if (owner.kind == VAR && owner.owner.kind == TYP) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2590
                //field initializer
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2591
                ClassSymbol enclClass = owner.enclClass();
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2592
                Symbol newScopeOwner = env.info.scope.owner;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2593
                /* if the field isn't static, then we can get the first constructor
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2594
                 * and use it as the owner of the environment. This is what
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2595
                 * LTM code is doing to look for type annotations so we are fine.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2596
                 */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2597
                if ((owner.flags() & STATIC) == 0) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2598
                    for (Symbol s : enclClass.members_field.getSymbolsByName(names.init)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2599
                        newScopeOwner = s;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2600
                        break;
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2601
                    }
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2602
                } else {
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2603
                    /* if the field is static then we need to create a fake clinit
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2604
                     * method, this method can later be reused by LTM.
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2605
                     */
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2606
                    MethodSymbol clinit = clinits.get(enclClass);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2607
                    if (clinit == null) {
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2608
                        Type clinitType = new MethodType(List.<Type>nil(),
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2609
                                syms.voidType, List.<Type>nil(), syms.methodClass);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2610
                        clinit = new MethodSymbol(STATIC | SYNTHETIC | PRIVATE,
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2611
                                names.clinit, clinitType, enclClass);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2612
                        clinit.params = List.<VarSymbol>nil();
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2613
                        clinits.put(enclClass, clinit);
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2614
                    }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2615
                    newScopeOwner = clinit;
22162
3b3e23e67329 8029721: javac crash for annotated parameter type of lambda in a field
vromero
parents: 22003
diff changeset
  2616
                }
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  2617
                lambdaEnv = env.dup(that, env.info.dup(env.info.scope.dupUnshared(newScopeOwner)));
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2618
            } else {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2619
                lambdaEnv = env.dup(that, env.info.dup(env.info.scope.dup()));
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2620
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2621
            return lambdaEnv;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  2622
        }
11144
8a4ae514eedf 7115052: Add parser support for method references
mcimadamore
parents: 11143
diff changeset
  2623
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2624
    @Override
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2625
    public void visitReference(final JCMemberReference that) {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2626
        if (pt().isErroneous() || (pt().hasTag(NONE) && pt() != Type.recoveryType)) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2627
            if (pt().hasTag(NONE)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2628
                //method reference only allowed in assignment or method invocation/cast context
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2629
                log.error(that.pos(), "unexpected.mref");
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2630
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2631
            result = that.type = types.createErrorType(pt());
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2632
            return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2633
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2634
        final Env<AttrContext> localEnv = env.dup(that);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2635
        try {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2636
            //attribute member reference qualifier - if this is a constructor
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2637
            //reference, the expected kind must be a type
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  2638
            Type exprType = attribTree(that.expr, env, memberReferenceQualifierResult(that));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2639
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2640
            if (that.getMode() == JCMemberReference.ReferenceMode.NEW) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2641
                exprType = chk.checkConstructorRefType(that.expr, exprType);
19918
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2642
                if (!exprType.isErroneous() &&
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2643
                    exprType.isRaw() &&
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2644
                    that.typeargs != null) {
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2645
                    log.error(that.expr.pos(), "invalid.mref", Kinds.kindName(that.getMode()),
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2646
                        diags.fragment("mref.infer.and.explicit.params"));
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2647
                    exprType = types.createErrorType(exprType);
3bdf0c6b869c 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied
vromero
parents: 19916
diff changeset
  2648
                }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2649
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2650
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2651
            if (exprType.isErroneous()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2652
                //if the qualifier expression contains problems,
15718
8e54c8e43d38 8008077: update reference impl for type-annotations
jjg
parents: 15717
diff changeset
  2653
                //give up attribution of method reference
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2654
                result = that.type = exprType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2655
                return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2656
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2657
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2658
            if (TreeInfo.isStaticSelector(that.expr, names)) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2659
                //if the qualifier is a type, validate it; raw warning check is
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2660
                //omitted as we don't know at this stage as to whether this is a
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2661
                //raw selector (because of inference)
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2662
                chk.validate(that.expr, env, false);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2663
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2664
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2665
            //attrib type-arguments
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2666
            List<Type> typeargtypes = List.nil();
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2667
            if (that.typeargs != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2668
                typeargtypes = attribTypes(that.typeargs, localEnv);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2669
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2670
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2671
            Type desc;
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2672
            Type currentTarget = pt();
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2673
            boolean isTargetSerializable =
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2674
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2675
                    isSerializable(currentTarget);
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2676
            if (currentTarget != Type.recoveryType) {
25279
a665d5cbb8c3 8044546: Crash on faulty reduce/lambda
vromero
parents: 25273
diff changeset
  2677
                currentTarget = types.removeWildcards(targetChecker.visit(currentTarget, that));
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2678
                desc = types.findDescriptorType(currentTarget);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2679
            } else {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2680
                currentTarget = Type.recoveryType;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2681
                desc = fallbackDescriptorType(that);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2682
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2683
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2684
            setFunctionalInfo(localEnv, that, pt(), desc, currentTarget, resultInfo.checkContext);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2685
            List<Type> argtypes = desc.getParameterTypes();
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2686
            Resolve.MethodCheck referenceCheck = rs.resolveMethodCheck;
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2687
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2688
            if (resultInfo.checkContext.inferenceContext().free(argtypes)) {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2689
                referenceCheck = rs.new MethodReferenceCheck(resultInfo.checkContext.inferenceContext());
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2690
            }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2691
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2692
            Pair<Symbol, Resolve.ReferenceLookupHelper> refResult = null;
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2693
            List<Type> saved_undet = resultInfo.checkContext.inferenceContext().save();
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2694
            try {
21718
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  2695
                refResult = rs.resolveMemberReference(localEnv, that, that.expr.type,
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  2696
                        that.name, argtypes, typeargtypes, referenceCheck,
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  2697
                        resultInfo.checkContext.inferenceContext(),
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  2698
                        resultInfo.checkContext.deferredAttrContext().mode);
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2699
            } finally {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2700
                resultInfo.checkContext.inferenceContext().rollback(saved_undet);
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2701
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2702
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2703
            Symbol refSym = refResult.fst;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2704
            Resolve.ReferenceLookupHelper lookupHelper = refResult.snd;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2705
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2706
            if (refSym.kind != MTH) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2707
                boolean targetError;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2708
                switch (refSym.kind) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2709
                    case ABSENT_MTH:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2710
                        targetError = false;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2711
                        break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2712
                    case WRONG_MTH:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2713
                    case WRONG_MTHS:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2714
                    case AMBIGUOUS:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2715
                    case HIDDEN:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2716
                    case STATICERR:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2717
                    case MISSING_ENCL:
21718
74a5882faf79 8026231: Look at 'static' flag when checking method references
vromero
parents: 21716
diff changeset
  2718
                    case WRONG_STATICNESS:
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2719
                        targetError = true;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2720
                        break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2721
                    default:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2722
                        Assert.error("unexpected result kind " + refSym.kind);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2723
                        targetError = false;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2724
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2725
24400
f05df7f58567 8037379: fix for JDK-8029569 doesn't cover all possible cases
vromero
parents: 24396
diff changeset
  2726
                JCDiagnostic detailsDiag = ((Resolve.ResolveError)refSym.baseSymbol()).getDiagnostic(JCDiagnostic.DiagnosticType.FRAGMENT,
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2727
                                that, exprType.tsym, exprType, that.name, argtypes, typeargtypes);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2728
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2729
                JCDiagnostic.DiagnosticType diagKind = targetError ?
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2730
                        JCDiagnostic.DiagnosticType.FRAGMENT : JCDiagnostic.DiagnosticType.ERROR;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2731
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2732
                JCDiagnostic diag = diags.create(diagKind, log.currentSource(), that,
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2733
                        "invalid.mref", Kinds.kindName(that.getMode()), detailsDiag);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2734
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2735
                if (targetError && currentTarget == Type.recoveryType) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2736
                    //a target error doesn't make sense during recovery stage
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2737
                    //as we don't know what actual parameter types are
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2738
                    result = that.type = currentTarget;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2739
                    return;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2740
                } else {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2741
                    if (targetError) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2742
                        resultInfo.checkContext.report(that, diag);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2743
                    } else {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2744
                        log.report(diag);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2745
                    }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2746
                    result = that.type = types.createErrorType(currentTarget);
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  2747
                    return;
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2748
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2749
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2750
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2751
            that.sym = refSym.baseSymbol();
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2752
            that.kind = lookupHelper.referenceKind(that.sym);
16328
8b9eb42167f6 8009129: Illegal access error when calling method reference
mcimadamore
parents: 16323
diff changeset
  2753
            that.ownerAccessible = rs.isAccessible(localEnv, that.sym.enclClass());
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2754
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2755
            if (desc.getReturnType() == Type.recoveryType) {
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2756
                // stop here
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2757
                result = that.type = currentTarget;
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2758
                return;
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2759
            }
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2760
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2761
            if (resultInfo.checkContext.deferredAttrContext().mode == AttrMode.CHECK) {
16323
c4409c235642 8008537: Missing method reference lookup error when unbound search finds a static method
mcimadamore
parents: 16320
diff changeset
  2762
17583
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2763
                if (that.getMode() == ReferenceMode.INVOKE &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2764
                        TreeInfo.isStaticSelector(that.expr, names) &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2765
                        that.kind.isUnbound() &&
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2766
                        !desc.getParameterTypes().head.isParameterized()) {
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2767
                    chk.checkRaw(that.expr, localEnv);
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2768
                }
91949b5f7651 8012685: Spurious raw types warning when using unbound method references
mcimadamore
parents: 17582
diff changeset
  2769
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2770
                if (that.sym.isStatic() && TreeInfo.isStaticSelector(that.expr, names) &&
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2771
                        exprType.getTypeArguments().nonEmpty()) {
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2772
                    //static ref with class type-args
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2773
                    log.error(that.expr.pos(), "invalid.mref", Kinds.kindName(that.getMode()),
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2774
                            diags.fragment("static.mref.with.targs"));
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2775
                    result = that.type = types.createErrorType(currentTarget);
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2776
                    return;
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2777
                }
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2778
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2779
                if (that.sym.isStatic() && !TreeInfo.isStaticSelector(that.expr, names) &&
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2780
                        !that.kind.isUnbound()) {
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2781
                    //no static bound mrefs
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2782
                    log.error(that.expr.pos(), "invalid.mref", Kinds.kindName(that.getMode()),
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2783
                            diags.fragment("static.bound.mref"));
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2784
                    result = that.type = types.createErrorType(currentTarget);
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2785
                    return;
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2786
                }
16293
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2787
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2788
                if (!refSym.isStatic() && that.kind == JCMemberReference.ReferenceKind.SUPER) {
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2789
                    // Check that super-qualified symbols are not abstract (JLS)
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2790
                    rs.checkNonAbstract(that.pos(), that.sym);
bf5e87940aee 8007285: AbstractMethodError instead of compile-time error when method reference with super and abstract
mcimadamore
parents: 15718
diff changeset
  2791
                }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2792
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2793
                if (isTargetSerializable) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2794
                    chk.checkElemAccessFromSerializableLambda(that);
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2795
                }
14724
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2796
            }
b542db73539a 8004101: Add checks for method reference well-formedness
mcimadamore
parents: 14723
diff changeset
  2797
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2798
            ResultInfo checkInfo =
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2799
                    resultInfo.dup(newMethodTemplate(
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2800
                        desc.getReturnType().hasTag(VOID) ? Type.noType : desc.getReturnType(),
24401
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
  2801
                        that.kind.isUnbound() ? argtypes.tail : argtypes, typeargtypes),
0d793293862a 8028503: javac, for method references a primitive type can be added as a bound
vromero
parents: 24400
diff changeset
  2802
                        new FunctionalReturnContext(resultInfo.checkContext));
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2803
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2804
            Type refType = checkId(that, lookupHelper.site, refSym, localEnv, checkInfo);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2805
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2806
            if (that.kind.isUnbound() &&
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2807
                    resultInfo.checkContext.inferenceContext().free(argtypes.head)) {
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2808
                //re-generate inference constraints for unbound receiver
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2809
                if (!types.isSubtype(resultInfo.checkContext.inferenceContext().asUndetVar(argtypes.head), exprType)) {
18910
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2810
                    //cannot happen as this has already been checked - we just need
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2811
                    //to regenerate the inference constraints, as that has been lost
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2812
                    //as a result of the call to inferenceContext.save()
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2813
                    Assert.error("Can't get here");
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2814
                }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2815
            }
c967bfda9283 8016175: Add bottom-up type-checking support for unambiguous method references
mcimadamore
parents: 18903
diff changeset
  2816
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2817
            if (!refType.isErroneous()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2818
                refType = types.createMethodTypeWithReturn(refType,
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2819
                        adjustMethodReturnType(lookupHelper.site, that.name, checkInfo.pt.getParameterTypes(), refType.getReturnType()));
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2820
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2821
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2822
            //go ahead with standard method reference compatibility check - note that param check
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2823
            //is a no-op (as this has been taken care during method applicability)
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2824
            boolean isSpeculativeRound =
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2825
                    resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2826
            checkReferenceCompatible(that, desc, refType, resultInfo.checkContext, isSpeculativeRound);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2827
            if (!isSpeculativeRound) {
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  2828
                checkAccessibleTypes(that, localEnv, resultInfo.checkContext.inferenceContext(), desc, currentTarget);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2829
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2830
            result = check(that, currentTarget, KindSelector.VAL, resultInfo);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2831
        } catch (Types.FunctionDescriptorLookupError ex) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2832
            JCDiagnostic cause = ex.getDiagnostic();
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2833
            resultInfo.checkContext.report(that, cause);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2834
            result = that.type = types.createErrorType(pt());
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2835
            return;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2836
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2837
    }
16294
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  2838
    //where
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  2839
        ResultInfo memberReferenceQualifierResult(JCMemberReference tree) {
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  2840
            //if this is a constructor reference, the expected kind must be a type
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2841
            return new ResultInfo(tree.getMode() == ReferenceMode.INVOKE ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2842
                                  KindSelector.VAL_TYP : KindSelector.TYP,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2843
                                  Type.noType);
16294
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  2844
        }
0c291a3cd60d 8007462: Fix provisional applicability for method references
mcimadamore
parents: 16293
diff changeset
  2845
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2846
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2847
    @SuppressWarnings("fallthrough")
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2848
    void checkReferenceCompatible(JCMemberReference tree, Type descriptor, Type refType, CheckContext checkContext, boolean speculativeAttr) {
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2849
        Type returnType = checkContext.inferenceContext().asUndetVar(descriptor.getReturnType());
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2850
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2851
        Type resType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2852
        switch (tree.getMode()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2853
            case NEW:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2854
                if (!tree.expr.type.isRaw()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2855
                    resType = tree.expr.type;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2856
                    break;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2857
                }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2858
            default:
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2859
                resType = refType.getReturnType();
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2860
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2861
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2862
        Type incompatibleReturnType = resType;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2863
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2864
        if (returnType.hasTag(VOID)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2865
            incompatibleReturnType = null;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2866
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2867
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  2868
        if (!returnType.hasTag(VOID) && !resType.hasTag(VOID)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2869
            if (resType.isErroneous() ||
14722
aaa39655aa2e 8004105: Expression statement lambdas should be void-compatible
mcimadamore
parents: 14547
diff changeset
  2870
                    new FunctionalReturnContext(checkContext).compatible(resType, returnType, types.noWarnings)) {
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2871
                incompatibleReturnType = null;
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2872
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2873
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2874
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2875
        if (incompatibleReturnType != null) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2876
            checkContext.report(tree, diags.fragment("incompatible.ret.type.in.mref",
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2877
                    diags.fragment("inconvertible.types", resType, descriptor.getReturnType())));
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2878
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2879
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2880
        if (!speculativeAttr) {
23132
00a059740d87 8035891: javac, rename method asFree() in InferenceContext to asUndetVar() which reflects better it's purpose
vromero
parents: 23129
diff changeset
  2881
            List<Type> thrownTypes = checkContext.inferenceContext().asUndetVars(descriptor.getThrownTypes());
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2882
            if (chk.unhandled(refType.getThrownTypes(), thrownTypes).nonEmpty()) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2883
                log.error(tree, "incompatible.thrown.types.in.mref", refType.getThrownTypes());
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2884
            }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2885
        }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2886
    }
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  2887
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2888
    /**
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2889
     * Set functional type info on the underlying AST. Note: as the target descriptor
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2890
     * might contain inference variables, we might need to register an hook in the
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2891
     * current inference context.
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2892
     */
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2893
    private void setFunctionalInfo(final Env<AttrContext> env, final JCFunctionalExpression fExpr,
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2894
            final Type pt, final Type descriptorType, final Type primaryTarget, final CheckContext checkContext) {
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2895
        if (checkContext.inferenceContext().free(descriptorType)) {
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2896
            checkContext.inferenceContext().addFreeTypeListener(List.of(pt, descriptorType), new FreeTypeListener() {
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2897
                public void typesInferred(InferenceContext inferenceContext) {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2898
                    setFunctionalInfo(env, fExpr, pt, inferenceContext.asInstType(descriptorType),
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2899
                            inferenceContext.asInstType(primaryTarget), checkContext);
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2900
                }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2901
            });
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2902
        } else {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  2903
            ListBuffer<Type> targets = new ListBuffer<>();
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2904
            if (pt.hasTag(CLASS)) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2905
                if (pt.isCompound()) {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2906
                    targets.append(types.removeWildcards(primaryTarget)); //this goes first
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2907
                    for (Type t : ((IntersectionClassType)pt()).interfaces_field) {
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2908
                        if (t != primaryTarget) {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2909
                            targets.append(types.removeWildcards(t));
16809
5acfcb821d65 8010822: Intersection type cast for functional expressions does not follow spec EDR
mcimadamore
parents: 16808
diff changeset
  2910
                        }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2911
                    }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2912
                } else {
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2913
                    targets.append(types.removeWildcards(primaryTarget));
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2914
                }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2915
            }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2916
            fExpr.targets = targets.toList();
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2917
            if (checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.CHECK &&
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2918
                    pt != Type.recoveryType) {
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2919
                //check that functional interface class is well-formed
25273
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2920
                try {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2921
                    /* Types.makeFunctionalInterfaceClass() may throw an exception
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2922
                     * when it's executed post-inference. See the listener code
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2923
                     * above.
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2924
                     */
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2925
                    ClassSymbol csym = types.makeFunctionalInterfaceClass(env,
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2926
                            names.empty, List.of(fExpr.targets.head), ABSTRACT);
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2927
                    if (csym != null) {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2928
                        chk.checkImplementations(env.tree, csym, csym);
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2929
                    }
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2930
                } catch (Types.FunctionDescriptorLookupError ex) {
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2931
                    JCDiagnostic cause = ex.getDiagnostic();
87443756f3ac 8038182: javac crash with FunctionDescriptorLookupError for invalid functional interface
vromero
parents: 25007
diff changeset
  2932
                    resultInfo.checkContext.report(env.tree, cause);
19127
8a0cbd5cb055 8020804: javac crashes when speculative attribution infers intersection type with array component
mcimadamore
parents: 19122
diff changeset
  2933
                }
18730
95354d510139 8016281: The SAM method should be passed to the metafactory as a MethodType not a MethodHandle
mcimadamore
parents: 18662
diff changeset
  2934
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2935
        }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2936
    }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  2937
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2938
    public void visitParens(JCParens tree) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2939
        Type owntype = attribTree(tree.expr, env, resultInfo);
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  2940
        result = check(tree, owntype, pkind(), resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2941
        Symbol sym = TreeInfo.symbol(tree);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2942
        if (sym != null && sym.kind.matches(KindSelector.TYP_PCK))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2943
            log.error(tree.pos(), "illegal.start.of.type");
06bc494ca11e Initial load
duke
parents:
diff changeset
  2944
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2945
06bc494ca11e Initial load
duke
parents:
diff changeset
  2946
    public void visitAssign(JCAssign tree) {
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  2947
        Type owntype = attribTree(tree.lhs, env.dup(tree), varAssignmentInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2948
        Type capturedType = capture(owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2949
        attribExpr(tree.rhs, env, owntype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2950
        result = check(tree, capturedType, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2951
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2952
06bc494ca11e Initial load
duke
parents:
diff changeset
  2953
    public void visitAssignop(JCAssignOp tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2954
        // Attribute arguments.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  2955
        Type owntype = attribTree(tree.lhs, env, varAssignmentInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2956
        Type operand = attribExpr(tree.rhs, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2957
        // Find operator.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2958
        Symbol operator = tree.operator = rs.resolveBinaryOperator(
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2959
            tree.pos(), tree.getTag().noAssignOp(), env,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2960
            owntype, operand);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2961
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2962
        if (operator.kind == MTH &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2963
                !owntype.isErroneous() &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2964
                !operand.isErroneous()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2965
            chk.checkOperator(tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  2966
                              (OperatorSymbol)operator,
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2967
                              tree.getTag().noAssignOp(),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2968
                              owntype,
06bc494ca11e Initial load
duke
parents:
diff changeset
  2969
                              operand);
166
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  2970
            chk.checkDivZero(tree.rhs.pos(), operator, operand);
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  2971
            chk.checkCastable(tree.rhs.pos(),
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  2972
                              operator.type.getReturnType(),
9f5e9d551da1 4741726: allow Object += String
jjg
parents: 164
diff changeset
  2973
                              owntype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2974
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  2975
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2976
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2977
06bc494ca11e Initial load
duke
parents:
diff changeset
  2978
    public void visitUnary(JCUnary tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2979
        // Attribute arguments.
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2980
        Type argtype = (tree.getTag().isIncOrDecUnaryOp())
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  2981
            ? attribTree(tree.arg, env, varAssignmentInfo)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2982
            : chk.checkNonVoid(tree.arg.pos(), attribExpr(tree.arg, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  2983
06bc494ca11e Initial load
duke
parents:
diff changeset
  2984
        // Find operator.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2985
        Symbol operator = tree.operator =
06bc494ca11e Initial load
duke
parents:
diff changeset
  2986
            rs.resolveUnaryOperator(tree.pos(), tree.getTag(), env, argtype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2987
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  2988
        Type owntype = types.createErrorType(tree.type);
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2989
        if (operator.kind == MTH &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  2990
                !argtype.isErroneous()) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  2991
            owntype = (tree.getTag().isIncOrDecUnaryOp())
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2992
                ? tree.arg.type
06bc494ca11e Initial load
duke
parents:
diff changeset
  2993
                : operator.type.getReturnType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  2994
            int opc = ((OperatorSymbol)operator).opcode;
06bc494ca11e Initial load
duke
parents:
diff changeset
  2995
06bc494ca11e Initial load
duke
parents:
diff changeset
  2996
            // If the argument is constant, fold it.
06bc494ca11e Initial load
duke
parents:
diff changeset
  2997
            if (argtype.constValue() != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  2998
                Type ctype = cfolder.fold1(opc, argtype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  2999
                if (ctype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3000
                    owntype = cfolder.coerce(ctype, owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3001
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3002
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3003
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3004
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3005
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3006
06bc494ca11e Initial load
duke
parents:
diff changeset
  3007
    public void visitBinary(JCBinary tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3008
        // Attribute arguments.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3009
        Type left = chk.checkNonVoid(tree.lhs.pos(), attribExpr(tree.lhs, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3010
        Type right = chk.checkNonVoid(tree.lhs.pos(), attribExpr(tree.rhs, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3011
        // Find operator.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3012
        Symbol operator = tree.operator =
06bc494ca11e Initial load
duke
parents:
diff changeset
  3013
            rs.resolveBinaryOperator(tree.pos(), tree.getTag(), env, left, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3014
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3015
        Type owntype = types.createErrorType(tree.type);
8237
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3016
        if (operator.kind == MTH &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3017
                !left.isErroneous() &&
d5ef8db7ad09 5017953: spurious cascaded diagnostics when name not found
mcimadamore
parents: 8236
diff changeset
  3018
                !right.isErroneous()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3019
            owntype = operator.type.getReturnType();
18662
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3020
            // This will figure out when unboxing can happen and
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3021
            // choose the right comparison operator.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3022
            int opc = chk.checkOperator(tree.lhs.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3023
                                        (OperatorSymbol)operator,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3024
                                        tree.getTag(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3025
                                        left,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3026
                                        right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3027
06bc494ca11e Initial load
duke
parents:
diff changeset
  3028
            // If both arguments are constants, fold them.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3029
            if (left.constValue() != null && right.constValue() != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3030
                Type ctype = cfolder.fold2(opc, left, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3031
                if (ctype != null) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3032
                    owntype = cfolder.coerce(ctype, owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3033
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3034
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3035
06bc494ca11e Initial load
duke
parents:
diff changeset
  3036
            // Check that argument types of a reference ==, != are
18662
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3037
            // castable to each other, (JLS 15.21).  Note: unboxing
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3038
            // comparisons will not have an acmp* opc at this point.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3039
            if ((opc == ByteCodes.if_acmpeq || opc == ByteCodes.if_acmpne)) {
18662
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3040
                if (!types.isEqualityComparable(left, right,
1cac45e71eb9 8013357: javac accepts erroneous binary comparison operations
emc
parents: 18657
diff changeset
  3041
                                                new Warner(tree.pos()))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3042
                    log.error(tree.pos(), "incomparable.types", left, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3043
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3044
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3045
06bc494ca11e Initial load
duke
parents:
diff changeset
  3046
            chk.checkDivZero(tree.rhs.pos(), operator, right);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3047
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3048
        result = check(tree, owntype, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3049
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3050
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3051
    public void visitTypeCast(final JCTypeCast tree) {
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3052
        Type clazztype = attribType(tree.clazz, env);
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  3053
        chk.validate(tree.clazz, env, false);
6592
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3054
        //a fresh environment is required for 292 inference to work properly ---
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3055
        //see Infer.instantiatePolymorphicSignatureInstance()
dc56420a69bc 6979327: method handle invocation should use casts instead of type parameters to specify return type
mcimadamore
parents: 6587
diff changeset
  3056
        Env<AttrContext> localEnv = env.dup(tree);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3057
        //should we propagate the target type?
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3058
        final ResultInfo castInfo;
16975
124c8436d59c 8010923: Avoid redundant speculative attribution
mcimadamore
parents: 16972
diff changeset
  3059
        JCExpression expr = TreeInfo.skipParens(tree.expr);
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3060
        boolean isPoly = allowPoly && (expr.hasTag(LAMBDA) || expr.hasTag(REFERENCE));
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3061
        if (isPoly) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3062
            //expression is a poly - we need to propagate target type info
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3063
            castInfo = new ResultInfo(KindSelector.VAL, clazztype,
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3064
                                      new Check.NestedCheckContext(resultInfo.checkContext) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3065
                @Override
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3066
                public boolean compatible(Type found, Type req, Warner warn) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3067
                    return types.isCastable(found, req, warn);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3068
                }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3069
            });
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3070
        } else {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3071
            //standalone cast - target-type info is not propagated
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3072
            castInfo = unknownExprInfo;
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3073
        }
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3074
        Type exprtype = attribTree(tree.expr, localEnv, castInfo);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3075
        Type owntype = isPoly ? clazztype : chk.checkCastable(tree.expr.pos(), exprtype, clazztype);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3076
        if (exprtype.constValue() != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3077
            owntype = cfolder.coerce(exprtype, owntype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3078
        result = check(tree, capture(owntype), KindSelector.VAL, resultInfo);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3079
        if (!isPoly)
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3080
            chk.checkRedundantCast(localEnv, tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3081
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3082
06bc494ca11e Initial load
duke
parents:
diff changeset
  3083
    public void visitTypeTest(JCInstanceOf tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3084
        Type exprtype = chk.checkNullOrRefType(
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3085
                tree.expr.pos(), attribExpr(tree.expr, env));
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3086
        Type clazztype = attribType(tree.clazz, env);
20251
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3087
        if (!clazztype.hasTag(TYPEVAR)) {
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3088
            clazztype = chk.checkClassOrArrayType(tree.clazz.pos(), clazztype);
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3089
        }
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3090
        if (!clazztype.isErroneous() && !types.isReifiable(clazztype)) {
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3091
            log.error(tree.clazz.pos(), "illegal.generic.type.for.instof");
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3092
            clazztype = types.createErrorType(clazztype);
90a73be53aa0 4881267: improve diagnostic for "instanceof T" for type parameter T
kizune
parents: 20249
diff changeset
  3093
        }
6351
84c44db80d06 6885255: Improve usability of raw warnings
mcimadamore
parents: 6347
diff changeset
  3094
        chk.validate(tree.clazz, env, false);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3095
        chk.checkCastable(tree.expr.pos(), exprtype, clazztype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3096
        result = check(tree, syms.booleanType, KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3097
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3098
06bc494ca11e Initial load
duke
parents:
diff changeset
  3099
    public void visitIndexed(JCArrayAccess tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3100
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3101
        Type atype = attribExpr(tree.indexed, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3102
        attribExpr(tree.index, env, syms.intType);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3103
        if (types.isArray(atype))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3104
            owntype = types.elemtype(atype);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3105
        else if (!atype.hasTag(ERROR))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3106
            log.error(tree.pos(), "array.req.but.found", atype);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3107
        if (!pkind().contains(KindSelector.VAL))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3108
            owntype = capture(owntype);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3109
        result = check(tree, owntype, KindSelector.VAR, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3110
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3111
06bc494ca11e Initial load
duke
parents:
diff changeset
  3112
    public void visitIdent(JCIdent tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3113
        Symbol sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3114
06bc494ca11e Initial load
duke
parents:
diff changeset
  3115
        // Find symbol
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3116
        if (pt().hasTag(METHOD) || pt().hasTag(FORALL)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3117
            // If we are looking for a method, the prototype `pt' will be a
06bc494ca11e Initial load
duke
parents:
diff changeset
  3118
            // method type with the type of the call's arguments as parameters.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3119
            env.info.pendingResolutionPhase = null;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3120
            sym = rs.resolveMethod(tree.pos(), env, tree.name, pt().getParameterTypes(), pt().getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3121
        } else if (tree.sym != null && tree.sym.kind != VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3122
            sym = tree.sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3123
        } else {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3124
            sym = rs.resolveIdent(tree.pos(), env, tree.name, pkind());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3125
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3126
        tree.sym = sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3127
06bc494ca11e Initial load
duke
parents:
diff changeset
  3128
        // (1) Also find the environment current for the class where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3129
        //     sym is defined (`symEnv').
06bc494ca11e Initial load
duke
parents:
diff changeset
  3130
        // Only for pre-tiger versions (1.4 and earlier):
06bc494ca11e Initial load
duke
parents:
diff changeset
  3131
        // (2) Also determine whether we access symbol out of an anonymous
06bc494ca11e Initial load
duke
parents:
diff changeset
  3132
        //     class in a this or super call.  This is illegal for instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  3133
        //     members since such classes don't carry a this$n link.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3134
        //     (`noOuterThisPath').
06bc494ca11e Initial load
duke
parents:
diff changeset
  3135
        Env<AttrContext> symEnv = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3136
        boolean noOuterThisPath = false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3137
        if (env.enclClass.sym.owner.kind != PCK && // we are in an inner class
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3138
            sym.kind.matches(KindSelector.VAL_MTH) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3139
            sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3140
            tree.name != names._this && tree.name != names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3141
06bc494ca11e Initial load
duke
parents:
diff changeset
  3142
            // Find environment in which identifier is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3143
            while (symEnv.outer != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3144
                   !sym.isMemberOf(symEnv.enclClass.sym, types)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3145
                if ((symEnv.enclClass.sym.flags() & NOOUTERTHIS) != 0)
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3146
                    noOuterThisPath = false;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3147
                symEnv = symEnv.outer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3148
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3149
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3150
06bc494ca11e Initial load
duke
parents:
diff changeset
  3151
        // If symbol is a variable, ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3152
        if (sym.kind == VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3153
            VarSymbol v = (VarSymbol)sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3154
06bc494ca11e Initial load
duke
parents:
diff changeset
  3155
            // ..., evaluate its initializer, if it has one, and check for
06bc494ca11e Initial load
duke
parents:
diff changeset
  3156
            // illegal forward reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3157
            checkInit(tree, env, v, false);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3158
06bc494ca11e Initial load
duke
parents:
diff changeset
  3159
            // If we are expecting a variable (as opposed to a value), check
06bc494ca11e Initial load
duke
parents:
diff changeset
  3160
            // that the variable is assignable in the current environment.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3161
            if (KindSelector.ASG.subset(pkind()))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3162
                checkAssignable(tree.pos(), v, null, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3163
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3164
06bc494ca11e Initial load
duke
parents:
diff changeset
  3165
        // In a constructor body,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3166
        // if symbol is a field or instance method, check that it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3167
        // not accessed before the supertype constructor is called.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3168
        if ((symEnv.info.isSelfCall || noOuterThisPath) &&
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3169
            sym.kind.matches(KindSelector.VAL_MTH) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3170
            sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3171
            (sym.flags() & STATIC) == 0) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3172
            chk.earlyRefError(tree.pos(), sym.kind == VAR ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3173
                                          sym : thisSym(tree.pos(), env));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3174
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3175
        Env<AttrContext> env1 = env;
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3176
        if (sym.kind != ERR && sym.kind != TYP &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3177
            sym.owner != null && sym.owner != env1.enclClass.sym) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3178
            // If the found symbol is inaccessible, then it is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3179
            // accessed through an enclosing instance.  Locate this
06bc494ca11e Initial load
duke
parents:
diff changeset
  3180
            // enclosing instance:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3181
            while (env1.outer != null && !rs.isAccessible(env, env1.enclClass.sym.type, sym))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3182
                env1 = env1.outer;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3183
        }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3184
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3185
        if (env.info.isSerializable) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3186
            chk.checkElemAccessFromSerializableLambda(tree);
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3187
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3188
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3189
        result = checkId(tree, env1.enclClass.sym.type, sym, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3190
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3191
06bc494ca11e Initial load
duke
parents:
diff changeset
  3192
    public void visitSelect(JCFieldAccess tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3193
        // Determine the expected kind of the qualifier expression.
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3194
        KindSelector skind = KindSelector.NIL;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3195
        if (tree.name == names._this || tree.name == names._super ||
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3196
                tree.name == names._class)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3197
        {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3198
            skind = KindSelector.TYP;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3199
        } else {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3200
            if (pkind().contains(KindSelector.PCK))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3201
                skind = KindSelector.of(skind, KindSelector.PCK);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3202
            if (pkind().contains(KindSelector.TYP))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3203
                skind = KindSelector.of(skind, KindSelector.TYP, KindSelector.PCK);
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3204
            if (pkind().contains(KindSelector.VAL_MTH))
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3205
                skind = KindSelector.of(skind, KindSelector.VAL, KindSelector.TYP);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3206
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3207
06bc494ca11e Initial load
duke
parents:
diff changeset
  3208
        // Attribute the qualifier expression, and determine its symbol (if any).
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3209
        Type site = attribTree(tree.selected, env, new ResultInfo(skind, Infer.anyPoly));
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3210
        if (!pkind().contains(KindSelector.TYP_PCK))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3211
            site = capture(site); // Capture field access
06bc494ca11e Initial load
duke
parents:
diff changeset
  3212
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  3213
        // don't allow T.class T[].class, etc
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3214
        if (skind == KindSelector.TYP) {
24895
dd091d389fbf 8027262: Determine location for type annotations earlier in compiler pipeline
emc
parents: 24794
diff changeset
  3215
            Type elt = site;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3216
            while (elt.hasTag(ARRAY))
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  3217
                elt = ((ArrayType)elt).elemtype;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3218
            if (elt.hasTag(TYPEVAR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3219
                log.error(tree.pos(), "type.var.cant.be.deref");
26780
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3220
                result = tree.type = types.createErrorType(tree.name, site.tsym, site);
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3221
                tree.sym = tree.type.tsym;
82b0aaba473d 8057794: Compiler Error when obtaining .class property
jlahoda
parents: 26532
diff changeset
  3222
                return ;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3223
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3224
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3225
06bc494ca11e Initial load
duke
parents:
diff changeset
  3226
        // If qualifier symbol is a type or `super', assert `selectSuper'
06bc494ca11e Initial load
duke
parents:
diff changeset
  3227
        // for the selection. This is relevant for determining whether
06bc494ca11e Initial load
duke
parents:
diff changeset
  3228
        // protected symbols are accessible.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3229
        Symbol sitesym = TreeInfo.symbol(tree.selected);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3230
        boolean selectSuperPrev = env.info.selectSuper;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3231
        env.info.selectSuper =
06bc494ca11e Initial load
duke
parents:
diff changeset
  3232
            sitesym != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3233
            sitesym.name == names._super;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3234
06bc494ca11e Initial load
duke
parents:
diff changeset
  3235
        // Determine the symbol represented by the selection.
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3236
        env.info.pendingResolutionPhase = null;
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3237
        Symbol sym = selectSym(tree, sitesym, site, env, resultInfo);
27845
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3238
        if (sym.kind == VAR && sym.name != names._super && env.info.defaultSuperCallSite != null) {
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3239
            log.error(tree.selected.pos(), "not.encl.class", site.tsym);
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3240
            sym = syms.errSymbol;
afce9de2de10 8059921: Missing compile error in Java 8 mode for Interface.super.field access
vromero
parents: 27844
diff changeset
  3241
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3242
        if (sym.exists() && !isType(sym) && pkind().contains(KindSelector.TYP_PCK)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3243
            site = capture(site);
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3244
            sym = selectSym(tree, sitesym, site, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3245
        }
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3246
        boolean varArgs = env.info.lastResolveVarargs();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3247
        tree.sym = sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3248
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3249
        if (site.hasTag(TYPEVAR) && !isType(sym) && sym.kind != ERR) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3250
            while (site.hasTag(TYPEVAR)) site = site.getUpperBound();
511
b3b5eadd2bca 6450290: Capture of nested wildcards causes type error
mcimadamore
parents: 325
diff changeset
  3251
            site = capture(site);
b3b5eadd2bca 6450290: Capture of nested wildcards causes type error
mcimadamore
parents: 325
diff changeset
  3252
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3253
06bc494ca11e Initial load
duke
parents:
diff changeset
  3254
        // If that symbol is a variable, ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3255
        if (sym.kind == VAR) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3256
            VarSymbol v = (VarSymbol)sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3257
06bc494ca11e Initial load
duke
parents:
diff changeset
  3258
            // ..., evaluate its initializer, if it has one, and check for
06bc494ca11e Initial load
duke
parents:
diff changeset
  3259
            // illegal forward reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3260
            checkInit(tree, env, v, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3261
06bc494ca11e Initial load
duke
parents:
diff changeset
  3262
            // If we are expecting a variable (as opposed to a value), check
06bc494ca11e Initial load
duke
parents:
diff changeset
  3263
            // that the variable is assignable in the current environment.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3264
            if (KindSelector.ASG.subset(pkind()))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3265
                checkAssignable(tree.pos(), v, tree.selected, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3266
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3267
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3268
        if (sitesym != null &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3269
                sitesym.kind == VAR &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3270
                ((VarSymbol)sitesym).isResourceVariable() &&
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3271
                sym.kind == MTH &&
9079
e512a7712be3 7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource
mcimadamore
parents: 9076
diff changeset
  3272
                sym.name.equals(names.close) &&
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3273
                sym.overrides(syms.autoCloseableClose, sitesym.type.tsym, types, true) &&
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3274
                env.info.lint.isEnabled(LintCategory.TRY)) {
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3275
            log.warning(LintCategory.TRY, tree, "try.explicit.close.call");
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3276
        }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5857
diff changeset
  3277
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3278
        // Disallow selecting a type from an expression
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3279
        if (isType(sym) && (sitesym == null || !sitesym.kind.matches(KindSelector.TYP_PCK))) {
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3280
            tree.type = check(tree.selected, pt(),
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3281
                              sitesym == null ?
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3282
                                      KindSelector.VAL : sitesym.kind.toSelector(),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3283
                              new ResultInfo(KindSelector.TYP_PCK, pt()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3284
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3285
06bc494ca11e Initial load
duke
parents:
diff changeset
  3286
        if (isType(sitesym)) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3287
            if (sym.name == names._this) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3288
                // If `C' is the currently compiled class, check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3289
                // C.this' does not appear in a call to a super(...)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3290
                if (env.info.isSelfCall &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3291
                    site.tsym == env.enclClass.sym) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3292
                    chk.earlyRefError(tree.pos(), sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3293
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3294
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3295
                // Check if type-qualified fields or methods are static (JLS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3296
                if ((sym.flags() & STATIC) == 0 &&
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  3297
                    !env.next.tree.hasTag(REFERENCE) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3298
                    sym.name != names._super &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3299
                    (sym.kind == VAR || sym.kind == MTH)) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3300
                    rs.accessBase(rs.new StaticError(sym),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3301
                              tree.pos(), site, sym.name, true);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3302
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3303
            }
24901
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3304
            if (!allowStaticInterfaceMethods && sitesym.isInterface() &&
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3305
                    sym.isStatic() && sym.kind == MTH) {
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3306
                log.error(tree.pos(), "static.intf.method.invoke.not.supported.in.source", sourceName);
73bacb7d064e 8037385: constant pool errors with -target 1.7 and static default methods
dlsmith
parents: 24900
diff changeset
  3307
            }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3308
        } else if (sym.kind != ERR &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3309
                   (sym.flags() & STATIC) != 0 &&
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3310
                   sym.name != names._class) {
5002
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 5001
diff changeset
  3311
            // If the qualified item is not a type and the selected item is static, report
12a9e8562200 4880220: Add a warning when accessing a static method via an reference
jjg
parents: 5001
diff changeset
  3312
            // a warning. Make allowance for the class of an array type e.g. Object[].class)
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3313
            chk.warnStatic(tree, "static.not.qualified.by.type",
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3314
                           sym.kind.kindName(), sym.owner);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3315
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3316
06bc494ca11e Initial load
duke
parents:
diff changeset
  3317
        // If we are selecting an instance member via a `super', ...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3318
        if (env.info.selectSuper && (sym.flags() & STATIC) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3319
06bc494ca11e Initial load
duke
parents:
diff changeset
  3320
            // Check that super-qualified symbols are not abstract (JLS)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3321
            rs.checkNonAbstract(tree.pos(), sym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3322
06bc494ca11e Initial load
duke
parents:
diff changeset
  3323
            if (site.isRaw()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3324
                // Determine argument types for site.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3325
                Type site1 = types.asSuper(env.enclClass.sym.type, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3326
                if (site1 != null) site = site1;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3327
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3328
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3329
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3330
        if (env.info.isSerializable) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3331
            chk.checkElemAccessFromSerializableLambda(tree);
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3332
        }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  3333
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3334
        env.info.selectSuper = selectSuperPrev;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3335
        result = checkId(tree, site, sym, env, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3336
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3337
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3338
        /** Determine symbol referenced by a Select expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3339
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  3340
         *  @param tree   The select tree.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3341
         *  @param site   The type of the selected expression,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3342
         *  @param env    The current environment.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3343
         *  @param resultInfo The current result.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3344
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3345
        private Symbol selectSym(JCFieldAccess tree,
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3346
                                 Symbol location,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3347
                                 Type site,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3348
                                 Env<AttrContext> env,
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3349
                                 ResultInfo resultInfo) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3350
            DiagnosticPosition pos = tree.pos();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3351
            Name name = tree.name;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3352
            switch (site.getTag()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3353
            case PACKAGE:
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3354
                return rs.accessBase(
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3355
                    rs.findIdentInPackage(env, site.tsym, name, resultInfo.pkind),
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3356
                    pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3357
            case ARRAY:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3358
            case CLASS:
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3359
                if (resultInfo.pt.hasTag(METHOD) || resultInfo.pt.hasTag(FORALL)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3360
                    return rs.resolveQualifiedMethod(
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3361
                        pos, env, location, site, name, resultInfo.pt.getParameterTypes(), resultInfo.pt.getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3362
                } else if (name == names._this || name == names._super) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3363
                    return rs.resolveSelf(pos, env, site.tsym, name);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3364
                } else if (name == names._class) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3365
                    // In this case, we have already made sure in
06bc494ca11e Initial load
duke
parents:
diff changeset
  3366
                    // visitSelect that qualifier expression is a type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3367
                    Type t = syms.classType;
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3368
                    List<Type> typeargs = List.of(types.erasure(site));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3369
                    t = new ClassType(t.getEnclosingType(), typeargs, t.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3370
                    return new VarSymbol(
06bc494ca11e Initial load
duke
parents:
diff changeset
  3371
                        STATIC | PUBLIC | FINAL, names._class, t, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3372
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3373
                    // We are seeing a plain identifier as selector.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3374
                    Symbol sym = rs.findIdentInType(env, site, name, resultInfo.pkind);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3375
                        sym = rs.accessBase(sym, pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3376
                    return sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3377
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3378
            case WILDCARD:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3379
                throw new AssertionError(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3380
            case TYPEVAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3381
                // Normally, site.getUpperBound() shouldn't be null.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3382
                // It should only happen during memberEnter/attribBase
8045
df2ca0edfbaa 6968793: issues with diagnostics
mcimadamore
parents: 8036
diff changeset
  3383
                // when determining the super type which *must* beac
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3384
                // done before attributing the type variables.  In
06bc494ca11e Initial load
duke
parents:
diff changeset
  3385
                // other words, we are seeing this illegal program:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3386
                // class B<T> extends A<T.foo> {}
06bc494ca11e Initial load
duke
parents:
diff changeset
  3387
                Symbol sym = (site.getUpperBound() != null)
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3388
                    ? selectSym(tree, location, capture(site.getUpperBound()), env, resultInfo)
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3389
                    : null;
3559
58cfcc0f1aa9 6569404: Cannot instantiate an inner class of a type variable
mcimadamore
parents: 3556
diff changeset
  3390
                if (sym == null) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3391
                    log.error(pos, "type.var.cant.be.deref");
06bc494ca11e Initial load
duke
parents:
diff changeset
  3392
                    return syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3393
                } else {
1528
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3394
                    Symbol sym2 = (sym.flags() & Flags.PRIVATE) != 0 ?
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3395
                        rs.new AccessError(env, site, sym) :
441d4ec466de 6711619: javac doesn't allow access to protected members in intersection types
mcimadamore
parents: 1358
diff changeset
  3396
                                sym;
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3397
                    rs.accessBase(sym2, pos, location, site, name, true);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3398
                    return sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3399
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3400
            case ERROR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3401
                // preserve identifier names through errors
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3402
                return types.createErrorType(name, site.tsym, site).tsym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3403
            default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3404
                // The qualifier expression is of a primitive type -- only
06bc494ca11e Initial load
duke
parents:
diff changeset
  3405
                // .class is allowed for these.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3406
                if (name == names._class) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3407
                    // In this case, we have already made sure in Select that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3408
                    // qualifier expression is a type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3409
                    Type t = syms.classType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3410
                    Type arg = types.boxedClass(site).type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3411
                    t = new ClassType(t.getEnclosingType(), List.of(arg), t.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3412
                    return new VarSymbol(
06bc494ca11e Initial load
duke
parents:
diff changeset
  3413
                        STATIC | PUBLIC | FINAL, names._class, t, site.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3414
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3415
                    log.error(pos, "cant.deref", site);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3416
                    return syms.errSymbol;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3417
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3418
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3419
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3420
06bc494ca11e Initial load
duke
parents:
diff changeset
  3421
        /** Determine type of identifier or select expression and check that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3422
         *  (1) the referenced symbol is not deprecated
06bc494ca11e Initial load
duke
parents:
diff changeset
  3423
         *  (2) the symbol's type is safe (@see checkSafe)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3424
         *  (3) if symbol is a variable, check that its type and kind are
06bc494ca11e Initial load
duke
parents:
diff changeset
  3425
         *      compatible with the prototype and protokind.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3426
         *  (4) if symbol is an instance field of a raw type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3427
         *      which is being assigned to, issue an unchecked warning if its
06bc494ca11e Initial load
duke
parents:
diff changeset
  3428
         *      type changes under erasure.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3429
         *  (5) if symbol is an instance method of a raw type, issue an
06bc494ca11e Initial load
duke
parents:
diff changeset
  3430
         *      unchecked warning if its argument types change under erasure.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3431
         *  If checks succeed:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3432
         *    If symbol is a constant, return its constant type
06bc494ca11e Initial load
duke
parents:
diff changeset
  3433
         *    else if symbol is a method, return its result type
06bc494ca11e Initial load
duke
parents:
diff changeset
  3434
         *    otherwise return its type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3435
         *  Otherwise return errType.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3436
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  3437
         *  @param tree       The syntax tree representing the identifier
06bc494ca11e Initial load
duke
parents:
diff changeset
  3438
         *  @param site       If this is a select, the type of the selected
06bc494ca11e Initial load
duke
parents:
diff changeset
  3439
         *                    expression, otherwise the type of the current class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3440
         *  @param sym        The symbol representing the identifier.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3441
         *  @param env        The current environment.
12081
42f541476d14 7133238: Merge proto-kind and proto-type into a single result class
mcimadamore
parents: 12080
diff changeset
  3442
         *  @param resultInfo    The expected result
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3443
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3444
        Type checkId(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3445
                     Type site,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3446
                     Symbol sym,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3447
                     Env<AttrContext> env,
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3448
                     ResultInfo resultInfo) {
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3449
            return (resultInfo.pt.hasTag(FORALL) || resultInfo.pt.hasTag(METHOD)) ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3450
                    checkMethodId(tree, site, sym, env, resultInfo) :
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3451
                    checkIdInternal(tree, site, sym, resultInfo.pt, env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3452
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3453
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3454
        Type checkMethodId(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3455
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3456
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3457
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3458
                     ResultInfo resultInfo) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3459
            boolean isPolymorhicSignature =
18389
a425d0819f36 8016569: javac, add new flag for polymorphic method signatures
vromero
parents: 18382
diff changeset
  3460
                (sym.baseSymbol().flags() & SIGNATURE_POLYMORPHIC) != 0;
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3461
            return isPolymorhicSignature ?
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3462
                    checkSigPolyMethodId(tree, site, sym, env, resultInfo) :
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3463
                    checkMethodIdInternal(tree, site, sym, env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3464
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3465
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3466
        Type checkSigPolyMethodId(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3467
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3468
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3469
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3470
                     ResultInfo resultInfo) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3471
            //recover original symbol for signature polymorphic methods
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3472
            checkMethodIdInternal(tree, site, sym.baseSymbol(), env, resultInfo);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3473
            env.info.pendingResolutionPhase = Resolve.MethodResolutionPhase.BASIC;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3474
            return sym.type;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3475
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3476
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3477
        Type checkMethodIdInternal(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3478
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3479
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3480
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3481
                     ResultInfo resultInfo) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3482
            if (resultInfo.pkind.contains(KindSelector.POLY)) {
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3483
                Type pt = resultInfo.pt.map(deferredAttr.new RecoveryDeferredTypeMap(AttrMode.SPECULATIVE, sym, env.info.pendingResolutionPhase));
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3484
                Type owntype = checkIdInternal(tree, site, sym, pt, env, resultInfo);
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3485
                resultInfo.pt.map(deferredAttr.new RecoveryDeferredTypeMap(AttrMode.CHECK, sym, env.info.pendingResolutionPhase));
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3486
                return owntype;
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3487
            } else {
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3488
                return checkIdInternal(tree, site, sym, resultInfo.pt, env, resultInfo);
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3489
            }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3490
        }
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3491
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3492
        Type checkIdInternal(JCTree tree,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3493
                     Type site,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3494
                     Symbol sym,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3495
                     Type pt,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3496
                     Env<AttrContext> env,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3497
                     ResultInfo resultInfo) {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3498
            if (pt.isErroneous()) {
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3499
                return types.createErrorType(site);
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3500
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3501
            Type owntype; // The computed type of this identifier occurrence.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3502
            switch (sym.kind) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3503
            case TYP:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3504
                // For types, the computed type equals the symbol's type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3505
                // except for two situations:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3506
                owntype = sym.type;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3507
                if (owntype.hasTag(CLASS)) {
14369
3d660d08d1f7 7153951: Add new lint option -Xlint:auxiliaryclass
ohrstrom
parents: 14366
diff changeset
  3508
                    chk.checkForBadAuxiliaryClassAccess(tree.pos(), env, (ClassSymbol)sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3509
                    Type ownOuter = owntype.getEnclosingType();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3510
06bc494ca11e Initial load
duke
parents:
diff changeset
  3511
                    // (a) If the symbol's type is parameterized, erase it
06bc494ca11e Initial load
duke
parents:
diff changeset
  3512
                    // because no type parameters were given.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3513
                    // We recover generic outer type later in visitTypeApply.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3514
                    if (owntype.tsym.type.getTypeArguments().nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3515
                        owntype = types.erasure(owntype);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3516
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3517
06bc494ca11e Initial load
duke
parents:
diff changeset
  3518
                    // (b) If the symbol's type is an inner class, then
06bc494ca11e Initial load
duke
parents:
diff changeset
  3519
                    // we have to interpret its outer type as a superclass
06bc494ca11e Initial load
duke
parents:
diff changeset
  3520
                    // of the site type. Example:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3521
                    //
06bc494ca11e Initial load
duke
parents:
diff changeset
  3522
                    // class Tree<A> { class Visitor { ... } }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3523
                    // class PointTree extends Tree<Point> { ... }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3524
                    // ...PointTree.Visitor...
06bc494ca11e Initial load
duke
parents:
diff changeset
  3525
                    //
06bc494ca11e Initial load
duke
parents:
diff changeset
  3526
                    // Then the type of the last expression above is
06bc494ca11e Initial load
duke
parents:
diff changeset
  3527
                    // Tree<Point>.Visitor.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3528
                    else if (ownOuter.hasTag(CLASS) && site != ownOuter) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3529
                        Type normOuter = site;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3530
                        if (normOuter.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3531
                            normOuter = types.asEnclosingSuper(site, ownOuter.tsym);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3532
                        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3533
                        if (normOuter == null) // perhaps from an import
06bc494ca11e Initial load
duke
parents:
diff changeset
  3534
                            normOuter = types.erasure(ownOuter);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3535
                        if (normOuter != ownOuter)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3536
                            owntype = new ClassType(
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  3537
                                normOuter, List.<Type>nil(), owntype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  3538
                                owntype.getMetadata());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3539
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3540
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3541
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3542
            case VAR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3543
                VarSymbol v = (VarSymbol)sym;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3544
                // Test (4): if symbol is an instance field of a raw type,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3545
                // which is being assigned to, issue an unchecked warning if
06bc494ca11e Initial load
duke
parents:
diff changeset
  3546
                // its type changes under erasure.
27844
8b5d79870a2f 7196163: Project Coin: Allow effectively final variables to be used as resources in try-with-resources
jlahoda
parents: 27553
diff changeset
  3547
                if (KindSelector.ASG.subset(pkind()) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3548
                    v.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3549
                    (v.flags() & STATIC) == 0 &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3550
                    (site.hasTag(CLASS) || site.hasTag(TYPEVAR))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3551
                    Type s = types.asOuterSuper(site, v.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3552
                    if (s != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3553
                        s.isRaw() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3554
                        !types.isSameType(v.type, v.erasure(types))) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3555
                        chk.warnUnchecked(tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3556
                                          "unchecked.assign.to.var",
06bc494ca11e Initial load
duke
parents:
diff changeset
  3557
                                          v, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3558
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3559
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3560
                // The computed type of a variable is the type of the
06bc494ca11e Initial load
duke
parents:
diff changeset
  3561
                // variable symbol, taken as a member of the site type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3562
                owntype = (sym.owner.kind == TYP &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3563
                           sym.name != names._this && sym.name != names._super)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3564
                    ? types.memberType(site, sym)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3565
                    : sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3566
06bc494ca11e Initial load
duke
parents:
diff changeset
  3567
                // If the variable is a constant, record constant value in
06bc494ca11e Initial load
duke
parents:
diff changeset
  3568
                // computed type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3569
                if (v.getConstValue() != null && isStaticReference(tree))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3570
                    owntype = owntype.constType(v.getConstValue());
06bc494ca11e Initial load
duke
parents:
diff changeset
  3571
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3572
                if (resultInfo.pkind == KindSelector.VAL) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3573
                    owntype = capture(owntype); // capture "names as expressions"
06bc494ca11e Initial load
duke
parents:
diff changeset
  3574
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3575
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3576
            case MTH: {
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3577
                owntype = checkMethod(site, sym,
18643
fdd7572e0c18 8016613: javac should avoid source 8 only analysis when compiling for source 7
vromero
parents: 18412
diff changeset
  3578
                        new ResultInfo(resultInfo.pkind, resultInfo.pt.getReturnType(), resultInfo.checkContext),
14051
9097cec96212 7188968: New instance creation expression using diamond is checked twice
mcimadamore
parents: 13689
diff changeset
  3579
                        env, TreeInfo.args(env.tree), resultInfo.pt.getParameterTypes(),
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3580
                        resultInfo.pt.getTypeArguments());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3581
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3582
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3583
            case PCK: case ERR:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3584
                owntype = sym.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3585
                break;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3586
            default:
06bc494ca11e Initial load
duke
parents:
diff changeset
  3587
                throw new AssertionError("unexpected kind: " + sym.kind +
06bc494ca11e Initial load
duke
parents:
diff changeset
  3588
                                         " in tree " + tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3589
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3590
06bc494ca11e Initial load
duke
parents:
diff changeset
  3591
            // Test (1): emit a `deprecation' warning if symbol is deprecated.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3592
            // (for constructors, the error was given when the constructor was
06bc494ca11e Initial load
duke
parents:
diff changeset
  3593
            // resolved)
8236
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3594
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3595
            if (sym.name != names.init) {
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3596
                chk.checkDeprecated(tree.pos(), env.info.scope.owner, sym);
0d8646b7c602 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable
mcimadamore
parents: 8225
diff changeset
  3597
                chk.checkSunAPI(tree.pos(), sym);
15724
3063fb01c8a1 8004182: Add support for profiles in javac
jjg
parents: 14953
diff changeset
  3598
                chk.checkProfile(tree.pos(), sym);
3661
104c425e96aa 6873845: refine access to symbol file
jjg
parents: 3559
diff changeset
  3599
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3600
06bc494ca11e Initial load
duke
parents:
diff changeset
  3601
            // Test (3): if symbol is a variable, check that its type and
06bc494ca11e Initial load
duke
parents:
diff changeset
  3602
            // kind are compatible with the prototype and protokind.
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3603
            return check(tree, owntype, sym.kind.toSelector(), resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3604
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3605
06bc494ca11e Initial load
duke
parents:
diff changeset
  3606
        /** Check that variable is initialized and evaluate the variable's
06bc494ca11e Initial load
duke
parents:
diff changeset
  3607
         *  initializer, if not yet done. Also check that variable is not
06bc494ca11e Initial load
duke
parents:
diff changeset
  3608
         *  referenced before it is defined.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3609
         *  @param tree    The tree making up the variable reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3610
         *  @param env     The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3611
         *  @param v       The variable's symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3612
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3613
        private void checkInit(JCTree tree,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3614
                               Env<AttrContext> env,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3615
                               VarSymbol v,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3616
                               boolean onlyWarning) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3617
//          System.err.println(v + " " + ((v.flags() & STATIC) != 0) + " " +
06bc494ca11e Initial load
duke
parents:
diff changeset
  3618
//                             tree.pos + " " + v.pos + " " +
06bc494ca11e Initial load
duke
parents:
diff changeset
  3619
//                             Resolve.isStatic(env));//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  3620
06bc494ca11e Initial load
duke
parents:
diff changeset
  3621
            // A forward reference is diagnosed if the declaration position
06bc494ca11e Initial load
duke
parents:
diff changeset
  3622
            // of the variable is greater than the current tree position
06bc494ca11e Initial load
duke
parents:
diff changeset
  3623
            // and the tree and variable definition occur in the same class
06bc494ca11e Initial load
duke
parents:
diff changeset
  3624
            // definition.  Note that writes don't count as references.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3625
            // This check applies only to class and instance
06bc494ca11e Initial load
duke
parents:
diff changeset
  3626
            // variables.  Local variables follow different scope rules,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3627
            // and are subject to definite assignment checking.
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  3628
            if ((env.info.enclVar == v || v.pos > tree.pos) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3629
                v.owner.kind == TYP &&
25846
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3630
                enclosingInitEnv(env) != null &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3631
                v.owner == env.info.scope.owner.enclClass() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3632
                ((v.flags() & STATIC) != 0) == Resolve.isStatic(env) &&
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  3633
                (!env.tree.hasTag(ASSIGN) ||
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3634
                 TreeInfo.skipParens(((JCAssign) env.tree).lhs) != tree)) {
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  3635
                String suffix = (env.info.enclVar == v) ?
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  3636
                                "self.ref" : "forward.ref";
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3637
                if (!onlyWarning || isStaticEnumField(v)) {
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  3638
                    log.error(tree.pos(), "illegal." + suffix);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3639
                } else if (useBeforeDeclarationWarning) {
1045
56f6e84f7825 6676362: Spurious forward reference error with final var + instance variable initializer
mcimadamore
parents: 1040
diff changeset
  3640
                    log.warning(tree.pos(), suffix, v);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3641
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3642
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3643
06bc494ca11e Initial load
duke
parents:
diff changeset
  3644
            v.getConstValue(); // ensure initializer is evaluated
06bc494ca11e Initial load
duke
parents:
diff changeset
  3645
06bc494ca11e Initial load
duke
parents:
diff changeset
  3646
            checkEnumInitializer(tree, env, v);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3647
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3648
06bc494ca11e Initial load
duke
parents:
diff changeset
  3649
        /**
25846
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3650
         * Returns the enclosing init environment associated with this env (if any). An init env
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3651
         * can be either a field declaration env or a static/instance initializer env.
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3652
         */
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3653
        Env<AttrContext> enclosingInitEnv(Env<AttrContext> env) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3654
            while (true) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3655
                switch (env.tree.getTag()) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3656
                    case VARDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3657
                        JCVariableDecl vdecl = (JCVariableDecl)env.tree;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3658
                        if (vdecl.sym.owner.kind == TYP) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3659
                            //field
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3660
                            return env;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3661
                        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3662
                        break;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3663
                    case BLOCK:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3664
                        if (env.next.tree.hasTag(CLASSDEF)) {
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3665
                            //instance/static initializer
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3666
                            return env;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3667
                        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3668
                        break;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3669
                    case METHODDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3670
                    case CLASSDEF:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3671
                    case TOPLEVEL:
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3672
                        return null;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3673
                }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3674
                Assert.checkNonNull(env.next);
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3675
                env = env.next;
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3676
            }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3677
        }
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3678
e7124d0dc984 8051958: Cannot assign a value to final variable in lambda
mcimadamore
parents: 25844
diff changeset
  3679
        /**
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3680
         * Check for illegal references to static members of enum.  In
06bc494ca11e Initial load
duke
parents:
diff changeset
  3681
         * an enum type, constructors and initializers may not
06bc494ca11e Initial load
duke
parents:
diff changeset
  3682
         * reference its static members unless they are constant.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3683
         *
06bc494ca11e Initial load
duke
parents:
diff changeset
  3684
         * @param tree    The tree making up the variable reference.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3685
         * @param env     The current environment.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3686
         * @param v       The variable's symbol.
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
  3687
         * @jls  section 8.9 Enums
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3688
         */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3689
        private void checkEnumInitializer(JCTree tree, Env<AttrContext> env, VarSymbol v) {
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
  3690
            // JLS:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3691
            //
06bc494ca11e Initial load
duke
parents:
diff changeset
  3692
            // "It is a compile-time error to reference a static field
06bc494ca11e Initial load
duke
parents:
diff changeset
  3693
            // of an enum type that is not a compile-time constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  3694
            // (15.28) from constructors, instance initializer blocks,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3695
            // or instance variable initializer expressions of that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3696
            // type. It is a compile-time error for the constructors,
06bc494ca11e Initial load
duke
parents:
diff changeset
  3697
            // instance initializer blocks, or instance variable
06bc494ca11e Initial load
duke
parents:
diff changeset
  3698
            // initializer expressions of an enum constant e to refer
06bc494ca11e Initial load
duke
parents:
diff changeset
  3699
            // to itself or to an enum constant of the same type that
06bc494ca11e Initial load
duke
parents:
diff changeset
  3700
            // is declared to the right of e."
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3701
            if (isStaticEnumField(v)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3702
                ClassSymbol enclClass = env.info.scope.owner.enclClass();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3703
06bc494ca11e Initial load
duke
parents:
diff changeset
  3704
                if (enclClass == null || enclClass.owner == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3705
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3706
06bc494ca11e Initial load
duke
parents:
diff changeset
  3707
                // See if the enclosing class is the enum (or a
06bc494ca11e Initial load
duke
parents:
diff changeset
  3708
                // subclass thereof) declaring v.  If not, this
06bc494ca11e Initial load
duke
parents:
diff changeset
  3709
                // reference is OK.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3710
                if (v.owner != enclClass && !types.isSubtype(enclClass.type, v.owner.type))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3711
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3712
06bc494ca11e Initial load
duke
parents:
diff changeset
  3713
                // If the reference isn't from an initializer, then
06bc494ca11e Initial load
duke
parents:
diff changeset
  3714
                // the reference is OK.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3715
                if (!Resolve.isInitializer(env))
06bc494ca11e Initial load
duke
parents:
diff changeset
  3716
                    return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3717
06bc494ca11e Initial load
duke
parents:
diff changeset
  3718
                log.error(tree.pos(), "illegal.enum.static.ref");
06bc494ca11e Initial load
duke
parents:
diff changeset
  3719
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3720
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3721
325
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3722
        /** Is the given symbol a static, non-constant field of an Enum?
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3723
         *  Note: enum literals should not be regarded as such
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3724
         */
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3725
        private boolean isStaticEnumField(VarSymbol v) {
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3726
            return Flags.isEnum(v.owner) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3727
                   Flags.isStatic(v) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3728
                   !Flags.isConstant(v) &&
44df0e9643b4 6509042: javac rejects class literals in enum constructors
mcimadamore
parents: 166
diff changeset
  3729
                   v.name != names._class;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3730
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3731
06bc494ca11e Initial load
duke
parents:
diff changeset
  3732
    Warner noteWarner = new Warner();
06bc494ca11e Initial load
duke
parents:
diff changeset
  3733
06bc494ca11e Initial load
duke
parents:
diff changeset
  3734
    /**
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  3735
     * Check that method arguments conform to its instantiation.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3736
     **/
06bc494ca11e Initial load
duke
parents:
diff changeset
  3737
    public Type checkMethod(Type site,
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3738
                            final Symbol sym,
12915
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3739
                            ResultInfo resultInfo,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3740
                            Env<AttrContext> env,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3741
                            final List<JCExpression> argtrees,
28cf1e0dafdc 7166552: Inference: cleanup usage of Type.ForAll
mcimadamore
parents: 12334
diff changeset
  3742
                            List<Type> argtypes,
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3743
                            List<Type> typeargtypes) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3744
        // Test (5): if symbol is an instance method of a raw type, issue
06bc494ca11e Initial load
duke
parents:
diff changeset
  3745
        // an unchecked warning if its argument types change under erasure.
25445
603f0c93d5c9 8011044: Remove support for 1.5 and earlier source and target options
ntoda
parents: 25443
diff changeset
  3746
        if ((sym.flags() & STATIC) == 0 &&
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3747
            (site.hasTag(CLASS) || site.hasTag(TYPEVAR))) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3748
            Type s = types.asOuterSuper(site, sym.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3749
            if (s != null && s.isRaw() &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  3750
                !types.isSameTypes(sym.type.getParameterTypes(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3751
                                   sym.erasure(types).getParameterTypes())) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3752
                chk.warnUnchecked(env.tree.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  3753
                                  "unchecked.call.mbr.of.raw.type",
06bc494ca11e Initial load
duke
parents:
diff changeset
  3754
                                  sym, s);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3755
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3756
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3757
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3758
        if (env.info.defaultSuperCallSite != null) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3759
            for (Type sup : types.interfaces(env.enclClass.type).prepend(types.supertype((env.enclClass.type)))) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3760
                if (!sup.tsym.isSubClass(sym.enclClass(), types) ||
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3761
                        types.isSameType(sup, env.info.defaultSuperCallSite)) continue;
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3762
                List<MethodSymbol> icand_sup =
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3763
                        types.interfaceCandidates(sup, (MethodSymbol)sym);
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3764
                if (icand_sup.nonEmpty() &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3765
                        icand_sup.head != sym &&
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3766
                        icand_sup.head.overrides(sym, icand_sup.head.enclClass(), types, true)) {
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3767
                    log.error(env.tree.pos(), "illegal.default.super.call", env.info.defaultSuperCallSite,
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3768
                        diags.fragment("overridden.default", sym, sup));
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3769
                    break;
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  3770
                }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  3771
            }
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14541
diff changeset
  3772
            env.info.defaultSuperCallSite = null;
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  3773
        }
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  3774
16330
66e277848a69 8009299: Javac crashes when compiling method reference to static interface method
mcimadamore
parents: 16328
diff changeset
  3775
        if (sym.isStatic() && site.isInterface() && env.tree.hasTag(APPLY)) {
15377
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3776
            JCMethodInvocation app = (JCMethodInvocation)env.tree;
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3777
            if (app.meth.hasTag(SELECT) &&
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3778
                    !TreeInfo.isStaticSelector(((JCFieldAccess)app.meth).selected, names)) {
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3779
                log.error(env.tree.pos(), "illegal.static.intf.meth.call", site);
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3780
            }
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3781
        }
515846bb6637 8005166: Add support for static interface methods
mcimadamore
parents: 15374
diff changeset
  3782
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3783
        // Compute the identifier's instantiated type.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3784
        // For methods, we need to compute the instance type by
06bc494ca11e Initial load
duke
parents:
diff changeset
  3785
        // Resolve.instantiate from the symbol's type as well as
06bc494ca11e Initial load
duke
parents:
diff changeset
  3786
        // any type arguments and value arguments.
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  3787
        noteWarner.clear();
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3788
        try {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3789
            Type owntype = rs.checkMethod(
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3790
                    env,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3791
                    site,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3792
                    sym,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3793
                    resultInfo,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3794
                    argtypes,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3795
                    typeargtypes,
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3796
                    noteWarner);
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3797
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3798
            DeferredAttr.DeferredTypeMap checkDeferredMap =
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3799
                deferredAttr.new DeferredTypeMap(DeferredAttr.AttrMode.CHECK, sym, env.info.pendingResolutionPhase);
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3800
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3801
            argtypes = Type.map(argtypes, checkDeferredMap);
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3802
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3803
            if (noteWarner.hasNonSilentLint(LintCategory.UNCHECKED)) {
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3804
                chk.warnUnchecked(env.tree.pos(),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3805
                        "unchecked.meth.invocation.applied",
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3806
                        kindName(sym),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3807
                        sym.name,
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3808
                        rs.methodArguments(sym.type.getParameterTypes()),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3809
                        rs.methodArguments(Type.map(argtypes, checkDeferredMap)),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3810
                        kindName(sym.location()),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3811
                        sym.location());
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3812
               owntype = new MethodType(owntype.getParameterTypes(),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3813
                       types.erasure(owntype.getReturnType()),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3814
                       types.erasure(owntype.getThrownTypes()),
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3815
                       syms.methodClass);
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3816
            }
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3817
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  3818
            return chk.checkMethod(owntype, sym, env, argtrees, argtypes, env.info.lastResolveVarargs(),
18381
56a7f54f4166 8015432: javac crashes with stack overflow when method called recursively from nested generic call
mcimadamore
parents: 18379
diff changeset
  3819
                    resultInfo.checkContext.inferenceContext());
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3820
        } catch (Infer.InferenceException ex) {
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3821
            //invalid target type - propagate exception outwards or report error
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3822
            //depending on the current check context
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3823
            resultInfo.checkContext.report(env.tree.pos(), ex.getDiagnostic());
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3824
            return types.createErrorType(site);
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3825
        } catch (Resolve.InapplicableMethodException ex) {
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3826
            final JCDiagnostic diag = ex.getDiagnostic();
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3827
            Resolve.InapplicableSymbolError errSym = rs.new InapplicableSymbolError(null) {
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3828
                @Override
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3829
                protected Pair<Symbol, JCDiagnostic> errCandidate() {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  3830
                    return new Pair<>(sym, diag);
19914
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3831
                }
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3832
            };
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3833
            List<Type> argtypes2 = Type.map(argtypes,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3834
                    rs.new ResolveDeferredRecoveryMap(AttrMode.CHECK, sym, env.info.pendingResolutionPhase));
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3835
            JCDiagnostic errDiag = errSym.getDiagnostic(JCDiagnostic.DiagnosticType.ERROR,
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3836
                    env.tree, sym, site, sym.name, argtypes2, typeargtypes);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3837
            log.report(errDiag);
d86271bd430a 8016177: structural most specific and stuckness
vromero
parents: 19656
diff changeset
  3838
            return types.createErrorType(site);
13438
83729994273a 7175911: Simplify error reporting API in Check.CheckContext interface
mcimadamore
parents: 12916
diff changeset
  3839
        }
12080
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  3840
    }
23101f54df44 7144506: Attr.checkMethod should be called after inference variables have been fixed
mcimadamore
parents: 12078
diff changeset
  3841
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3842
    public void visitLiteral(JCLiteral tree) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3843
        result = check(tree, litType(tree.typetag).constType(tree.value),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3844
                KindSelector.VAL, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3845
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3846
    //where
06bc494ca11e Initial load
duke
parents:
diff changeset
  3847
    /** Return the type of a literal with given type tag.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3848
     */
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3849
    Type litType(TypeTag tag) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3850
        return (tag == CLASS) ? syms.stringType : syms.typeOfTag[tag.ordinal()];
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3851
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3852
06bc494ca11e Initial load
duke
parents:
diff changeset
  3853
    public void visitTypeIdent(JCPrimitiveTypeTree tree) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3854
        result = check(tree, syms.typeOfTag[tree.typetag.ordinal()], KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3855
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3856
06bc494ca11e Initial load
duke
parents:
diff changeset
  3857
    public void visitTypeArray(JCArrayTypeTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3858
        Type etype = attribType(tree.elemtype, env);
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  3859
        Type type = new ArrayType(etype, syms.arrayClass);
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3860
        result = check(tree, type, KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3861
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3862
06bc494ca11e Initial load
duke
parents:
diff changeset
  3863
    /** Visitor method for parameterized types.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3864
     *  Bound checking is left until later, since types are attributed
06bc494ca11e Initial load
duke
parents:
diff changeset
  3865
     *  before supertype structure is completely known
06bc494ca11e Initial load
duke
parents:
diff changeset
  3866
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  3867
    public void visitTypeApply(JCTypeApply tree) {
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3868
        Type owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3869
06bc494ca11e Initial load
duke
parents:
diff changeset
  3870
        // Attribute functor part of application and make sure it's a class.
06bc494ca11e Initial load
duke
parents:
diff changeset
  3871
        Type clazztype = chk.checkClassType(tree.clazz.pos(), attribType(tree.clazz, env));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3872
06bc494ca11e Initial load
duke
parents:
diff changeset
  3873
        // Attribute type parameters
06bc494ca11e Initial load
duke
parents:
diff changeset
  3874
        List<Type> actuals = attribTypes(tree.arguments, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3875
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3876
        if (clazztype.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3877
            List<Type> formals = clazztype.tsym.type.getTypeArguments();
10198
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  3878
            if (actuals.isEmpty()) //diamond
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  3879
                actuals = formals;
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  3880
84698d93792c 7046778: Project Coin: problem with diamond and member inner classes
mcimadamore
parents: 10187
diff changeset
  3881
            if (actuals.length() == formals.length()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3882
                List<Type> a = actuals;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3883
                List<Type> f = formals;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3884
                while (a.nonEmpty()) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3885
                    a.head = a.head.withTypeVar(f.head);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3886
                    a = a.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3887
                    f = f.tail;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3888
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3889
                // Compute the proper generic outer
06bc494ca11e Initial load
duke
parents:
diff changeset
  3890
                Type clazzOuter = clazztype.getEnclosingType();
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3891
                if (clazzOuter.hasTag(CLASS)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3892
                    Type site;
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  3893
                    JCExpression clazz = TreeInfo.typeIn(tree.clazz);
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  3894
                    if (clazz.hasTag(IDENT)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3895
                        site = env.enclClass.sym.type;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  3896
                    } else if (clazz.hasTag(SELECT)) {
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  3897
                        site = ((JCFieldAccess) clazz).selected.type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3898
                    } else throw new AssertionError(""+tree);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3899
                    if (clazzOuter.hasTag(CLASS) && site != clazzOuter) {
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3900
                        if (site.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3901
                            site = types.asOuterSuper(site, clazzOuter.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3902
                        if (site == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  3903
                            site = types.erasure(clazzOuter);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3904
                        clazzOuter = site;
06bc494ca11e Initial load
duke
parents:
diff changeset
  3905
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3906
                }
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  3907
                owntype = new ClassType(clazzOuter, actuals, clazztype.tsym,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  3908
                                        clazztype.getMetadata());
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3909
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3910
                if (formals.length() != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3911
                    log.error(tree.pos(), "wrong.number.type.args",
06bc494ca11e Initial load
duke
parents:
diff changeset
  3912
                              Integer.toString(formals.length()));
06bc494ca11e Initial load
duke
parents:
diff changeset
  3913
                } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  3914
                    log.error(tree.pos(), "type.doesnt.take.params", clazztype.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  3915
                }
1257
873b053bf757 6557752: Original type of an AST should be made available even if it is replaced with an ErrorType
jjg
parents: 1045
diff changeset
  3916
                owntype = types.createErrorType(tree.type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3917
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3918
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3919
        result = check(tree, owntype, KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3920
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  3921
9300
c2de4dd9853b 7033809: Rename "disjunctive" to "union" in javax.lang.model
darcy
parents: 9079
diff changeset
  3922
    public void visitTypeUnion(JCTypeUnion tree) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  3923
        ListBuffer<Type> multicatchTypes = new ListBuffer<>();
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3924
        ListBuffer<Type> all_multicatchTypes = null; // lazy, only if needed
7622
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3925
        for (JCExpression typeTree : tree.alternatives) {
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3926
            Type ctype = attribType(typeTree, env);
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3927
            ctype = chk.checkType(typeTree.pos(),
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3928
                          chk.checkClassType(typeTree.pos(), ctype),
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3929
                          syms.throwableType);
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3930
            if (!ctype.isErroneous()) {
9300
c2de4dd9853b 7033809: Rename "disjunctive" to "union" in javax.lang.model
darcy
parents: 9079
diff changeset
  3931
                //check that alternatives of a union type are pairwise
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3932
                //unrelated w.r.t. subtyping
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3933
                if (chk.intersects(ctype,  multicatchTypes.toList())) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3934
                    for (Type t : multicatchTypes) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3935
                        boolean sub = types.isSubtype(ctype, t);
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3936
                        boolean sup = types.isSubtype(t, ctype);
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3937
                        if (sub || sup) {
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3938
                            //assume 'a' <: 'b'
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3939
                            Type a = sub ? ctype : t;
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3940
                            Type b = sub ? t : ctype;
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3941
                            log.error(typeTree.pos(), "multicatch.types.must.be.disjoint", a, b);
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3942
                        }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3943
                    }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3944
                }
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3945
                multicatchTypes.append(ctype);
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3946
                if (all_multicatchTypes != null)
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3947
                    all_multicatchTypes.append(ctype);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3948
            } else {
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3949
                if (all_multicatchTypes == null) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  3950
                    all_multicatchTypes = new ListBuffer<>();
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3951
                    all_multicatchTypes.appendList(multicatchTypes);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3952
                }
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3953
                all_multicatchTypes.append(ctype);
9074
76b505d19026 7030606: Project-coin: multi-catch types should be pairwise disjoint
mcimadamore
parents: 8845
diff changeset
  3954
            }
7622
ee16e77d07f0 7002070: If catch clause has an incompatible type, error pointer points to first exception type in list
mcimadamore
parents: 7618
diff changeset
  3955
        }
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3956
        Type t = check(tree, types.lub(multicatchTypes.toList()),
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  3957
                KindSelector.TYP, resultInfo);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  3958
        if (t.hasTag(CLASS)) {
9599
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3959
            List<Type> alternatives =
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3960
                ((all_multicatchTypes == null) ? multicatchTypes : all_multicatchTypes).toList();
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3961
            t = new UnionClassType((ClassType) t, alternatives);
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3962
        }
0996df19ea87 7029150: Project Coin: present union types from the tree API through to javax.lang.model
jjg
parents: 9303
diff changeset
  3963
        tree.type = result = t;
5492
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 5489
diff changeset
  3964
    }
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 5489
diff changeset
  3965
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3966
    public void visitTypeIntersection(JCTypeIntersection tree) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3967
        attribTypes(tree.bounds, env);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3968
        tree.type = result = checkIntersection(tree, tree.bounds);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3969
    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3970
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3971
    public void visitTypeParameter(JCTypeParameter tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3972
        TypeVar typeVar = (TypeVar) tree.type;
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3973
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3974
        if (tree.annotations != null && tree.annotations.nonEmpty()) {
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  3975
            annotateType(tree, tree.annotations);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3976
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  3977
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3978
        if (!typeVar.bound.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3979
            //fixup type-parameter bound computed in 'attribTypeVariables'
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3980
            typeVar.bound = checkIntersection(tree, tree.bounds);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3981
        }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3982
    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3983
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3984
    Type checkIntersection(JCTree tree, List<JCExpression> bounds) {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22162
diff changeset
  3985
        Set<Type> boundSet = new HashSet<>();
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3986
        if (bounds.nonEmpty()) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3987
            // accept class or interface or typevar as first bound.
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
  3988
            bounds.head.type = checkBase(bounds.head.type, bounds.head, env, false, false, false);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3989
            boundSet.add(types.erasure(bounds.head.type));
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3990
            if (bounds.head.type.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3991
                return bounds.head.type;
1532
ae41c47516e5 6680106: StackOverFlowError for Cyclic inheritance in TypeParameters with ArrayType Bounds
mcimadamore
parents: 1528
diff changeset
  3992
            }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3993
            else if (bounds.head.type.hasTag(TYPEVAR)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3994
                // if first bound was a typevar, do not accept further bounds.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3995
                if (bounds.tail.nonEmpty()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3996
                    log.error(bounds.tail.head.pos(),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3997
                              "type.var.may.not.be.followed.by.other.bounds");
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  3998
                    return bounds.head.type;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  3999
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4000
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4001
                // if first bound was a class or interface, accept only interfaces
06bc494ca11e Initial load
duke
parents:
diff changeset
  4002
                // as further bounds.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4003
                for (JCExpression bound : bounds.tail) {
21712
d363f367d4c0 8027439: Compile-time error in the case of ((Integer[] & Serializable)new Integer[1]).getClass()
emc
parents: 21704
diff changeset
  4004
                    bound.type = checkBase(bound.type, bound, env, false, true, false);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4005
                    if (bound.type.isErroneous()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4006
                        bounds = List.of(bound);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4007
                    }
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4008
                    else if (bound.type.hasTag(CLASS)) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4009
                        chk.checkNotRepeated(bound.pos(), types.erasure(bound.type), boundSet);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4010
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4011
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4012
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4013
        }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4014
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4015
        if (bounds.length() == 0) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4016
            return syms.objectType;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4017
        } else if (bounds.length() == 1) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4018
            return bounds.head.type;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4019
        } else {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4020
            Type owntype = types.makeCompoundType(TreeInfo.types(bounds));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4021
            // ... the variable's bound is a class type flagged COMPOUND
06bc494ca11e Initial load
duke
parents:
diff changeset
  4022
            // (see comment for TypeVar.bound).
06bc494ca11e Initial load
duke
parents:
diff changeset
  4023
            // In this case, generate a class tree that represents the
06bc494ca11e Initial load
duke
parents:
diff changeset
  4024
            // bound class, ...
8625
6b51ef804d49 6639645: Modeling type implementing missing interfaces
jjg
parents: 8622
diff changeset
  4025
            JCExpression extending;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4026
            List<JCExpression> implementing;
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4027
            if (!bounds.head.type.isInterface()) {
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4028
                extending = bounds.head;
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4029
                implementing = bounds.tail;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4030
            } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4031
                extending = null;
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4032
                implementing = bounds;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4033
            }
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4034
            JCClassDecl cd = make.at(tree).ClassDef(
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4035
                make.Modifiers(PUBLIC | ABSTRACT),
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4036
                names.empty, List.<JCTypeParameter>nil(),
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4037
                extending, implementing, List.<JCTree>nil());
06bc494ca11e Initial load
duke
parents:
diff changeset
  4038
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4039
            ClassSymbol c = (ClassSymbol)owntype.tsym;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4040
            Assert.check((c.flags() & COMPOUND) != 0);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4041
            cd.sym = c;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4042
            c.sourcefile = env.toplevel.sourcefile;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4043
06bc494ca11e Initial load
duke
parents:
diff changeset
  4044
            // ... and attribute the bound class
06bc494ca11e Initial load
duke
parents:
diff changeset
  4045
            c.flags_field |= UNATTRIBUTED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4046
            Env<AttrContext> cenv = enter.classEnv(cd, env);
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4047
            typeEnvs.put(c, cenv);
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4048
            attribClass(c);
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4049
            return owntype;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4050
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4051
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4052
06bc494ca11e Initial load
duke
parents:
diff changeset
  4053
    public void visitWildcard(JCWildcard tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4054
        //- System.err.println("visitWildcard("+tree+");");//DEBUG
06bc494ca11e Initial load
duke
parents:
diff changeset
  4055
        Type type = (tree.kind.kind == BoundKind.UNBOUND)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4056
            ? syms.objectType
06bc494ca11e Initial load
duke
parents:
diff changeset
  4057
            : attribType(tree.inner, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4058
        result = check(tree, new WildcardType(chk.checkRefType(tree.pos(), type),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4059
                                              tree.kind.kind,
26781
a786b07c7b91 8048614: Add TypeMetadata to contain type annotations and other type information
emc
parents: 26780
diff changeset
  4060
                                              syms.boundClass),
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4061
                KindSelector.TYP, resultInfo);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4062
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4063
06bc494ca11e Initial load
duke
parents:
diff changeset
  4064
    public void visitAnnotation(JCAnnotation tree) {
20599
5201f7144a3c 8022765: Compiler crashes with exception on wrong usage of an annotation.
jlahoda
parents: 20258
diff changeset
  4065
        Assert.error("should be handled in Annotate");
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4066
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4067
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4068
    public void visitAnnotatedType(JCAnnotatedType tree) {
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4069
        Type underlyingType = attribType(tree.getUnderlyingType(), env);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4070
        this.attribAnnotationTypes(tree.annotations, env);
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  4071
        annotateType(tree, tree.annotations);
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  4072
        result = tree.type = underlyingType;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4073
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4074
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4075
    /**
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4076
     * Apply the annotations to the particular type.
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4077
     */
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  4078
    public void annotateType(final JCTree tree, final List<JCAnnotation> annotations) {
21040
3e32f68d2151 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
jlahoda
parents: 21018
diff changeset
  4079
        annotate.typeAnnotation(new Annotate.Worker() {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4080
            @Override
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4081
            public String toString() {
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  4082
                return "annotate " + annotations + " onto " + tree;
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4083
            }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4084
            @Override
21040
3e32f68d2151 8026510: The name of com.sun.tools.javac.comp.Annotate.Annotator is confusing
jlahoda
parents: 21018
diff changeset
  4085
            public void run() {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4086
                List<Attribute.TypeCompound> compounds = fromAnnotations(annotations);
22696
0a916fd27b8b 8032980: Silent failure in Attr.annotateType
emc
parents: 22691
diff changeset
  4087
                Assert.check(annotations.size() == compounds.size());
24396
3c36c6afcbca 8040327: Eliminate AnnotatedType
emc
parents: 24296
diff changeset
  4088
                tree.type = tree.type.annotatedType(compounds);
21041
99f5e5e97425 8026564: import changes from type-annotations forest
jjg
parents: 21040
diff changeset
  4089
                }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4090
        });
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4091
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4092
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4093
    private static List<Attribute.TypeCompound> fromAnnotations(List<JCAnnotation> annotations) {
21498
58c2486db8d0 8006732: support correct bytecode storage of type annotations in multicatch
emc
parents: 21488
diff changeset
  4094
        if (annotations.isEmpty()) {
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4095
            return List.nil();
21498
58c2486db8d0 8006732: support correct bytecode storage of type annotations in multicatch
emc
parents: 21488
diff changeset
  4096
        }
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4097
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19942
diff changeset
  4098
        ListBuffer<Attribute.TypeCompound> buf = new ListBuffer<>();
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4099
        for (JCAnnotation anno : annotations) {
22691
ea96f68e3d9a 8032587: Change silent failure in Attr.java to assertion
emc
parents: 22685
diff changeset
  4100
            Assert.checkNonNull(anno.attribute);
ea96f68e3d9a 8032587: Change silent failure in Attr.java to assertion
emc
parents: 22685
diff changeset
  4101
            buf.append((Attribute.TypeCompound) anno.attribute);
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4102
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4103
        return buf.toList();
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4104
    }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 15377
diff changeset
  4105
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4106
    public void visitErroneous(JCErroneous tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4107
        if (tree.errs != null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4108
            for (JCTree err : tree.errs)
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4109
                attribTree(err, env, new ResultInfo(KindSelector.ERR, pt()));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4110
        result = tree.type = syms.errType;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4111
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4112
06bc494ca11e Initial load
duke
parents:
diff changeset
  4113
    /** Default visitor method for all other trees.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4114
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4115
    public void visitTree(JCTree tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4116
        throw new AssertionError();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4117
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4118
8845
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4119
    /**
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4120
     * Attribute an env for either a top level tree or class declaration.
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4121
     */
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4122
    public void attrib(Env<AttrContext> env) {
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4123
        if (env.tree.hasTag(TOPLEVEL))
8845
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4124
            attribTopLevel(env);
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4125
        else
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4126
            attribClass(env.tree.pos(), env.enclClass.sym);
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4127
    }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4128
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4129
    /**
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4130
     * Attribute a top level tree. These trees are encountered when the
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4131
     * package declaration has annotations.
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4132
     */
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4133
    public void attribTopLevel(Env<AttrContext> env) {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4134
        JCCompilationUnit toplevel = env.toplevel;
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4135
        try {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4136
            annotate.flush();
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4137
        } catch (CompletionFailure ex) {
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4138
            chk.completionError(toplevel.pos(), ex);
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4139
        }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4140
    }
42fb82dfbf52 6993311: annotations on packages are not validated
jjg
parents: 8635
diff changeset
  4141
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4142
    /** Main method: attribute class definition associated with given class symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4143
     *  reporting completion failures at the given position.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4144
     *  @param pos The source position at which completion errors are to be
06bc494ca11e Initial load
duke
parents:
diff changeset
  4145
     *             reported.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4146
     *  @param c   The class symbol whose definition will be attributed.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4147
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4148
    public void attribClass(DiagnosticPosition pos, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4149
        try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4150
            annotate.flush();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4151
            attribClass(c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4152
        } catch (CompletionFailure ex) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4153
            chk.completionError(pos, ex);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4154
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4155
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4156
06bc494ca11e Initial load
duke
parents:
diff changeset
  4157
    /** Attribute class definition associated with given class symbol.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4158
     *  @param c   The class symbol whose definition will be attributed.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4159
     */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4160
    void attribClass(ClassSymbol c) throws CompletionFailure {
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4161
        if (c.type.hasTag(ERROR)) return;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4162
06bc494ca11e Initial load
duke
parents:
diff changeset
  4163
        // Check for cycles in the inheritance graph, which can arise from
06bc494ca11e Initial load
duke
parents:
diff changeset
  4164
        // ill-formed class files.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4165
        chk.checkNonCyclic(null, c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4166
06bc494ca11e Initial load
duke
parents:
diff changeset
  4167
        Type st = types.supertype(c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4168
        if ((c.flags_field & Flags.COMPOUND) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4169
            // First, attribute superclass.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4170
            if (st.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4171
                attribClass((ClassSymbol)st.tsym);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4172
06bc494ca11e Initial load
duke
parents:
diff changeset
  4173
            // Next attribute owner, if it is a class.
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4174
            if (c.owner.kind == TYP && c.owner.type.hasTag(CLASS))
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4175
                attribClass((ClassSymbol)c.owner);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4176
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4177
06bc494ca11e Initial load
duke
parents:
diff changeset
  4178
        // The previous operations might have attributed the current class
06bc494ca11e Initial load
duke
parents:
diff changeset
  4179
        // if there was a cycle. So we test first whether the class is still
06bc494ca11e Initial load
duke
parents:
diff changeset
  4180
        // UNATTRIBUTED.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4181
        if ((c.flags_field & UNATTRIBUTED) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4182
            c.flags_field &= ~UNATTRIBUTED;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4183
06bc494ca11e Initial load
duke
parents:
diff changeset
  4184
            // Get environment current at the point of class definition.
25007
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4185
            Env<AttrContext> env = typeEnvs.get(c);
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4186
eb097d3a68f5 8038975: Access control in enhanced for
pgovereau
parents: 24901
diff changeset
  4187
            // The info.lint field in the envs stored in typeEnvs is deliberately uninitialized,
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4188
            // because the annotations were not available at the time the env was created. Therefore,
06bc494ca11e Initial load
duke
parents:
diff changeset
  4189
            // we look up the environment chain for the first enclosing environment for which the
06bc494ca11e Initial load
duke
parents:
diff changeset
  4190
            // lint value is set. Typically, this is the parent env, but might be further if there
06bc494ca11e Initial load
duke
parents:
diff changeset
  4191
            // are any envs created as a result of TypeParameter nodes.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4192
            Env<AttrContext> lintEnv = env;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4193
            while (lintEnv.info.lint == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4194
                lintEnv = lintEnv.next;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4195
06bc494ca11e Initial load
duke
parents:
diff changeset
  4196
            // Having found the enclosing lint value, we can initialize the lint value for this class
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17805
diff changeset
  4197
            env.info.lint = lintEnv.info.lint.augment(c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4198
06bc494ca11e Initial load
duke
parents:
diff changeset
  4199
            Lint prevLint = chk.setLint(env.info.lint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4200
            JavaFileObject prev = log.useSource(c.sourcefile);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4201
            ResultInfo prevReturnRes = env.info.returnResult;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4202
06bc494ca11e Initial load
duke
parents:
diff changeset
  4203
            try {
19942
e9dae0e41075 8021112: Spurious unchecked warning reported by javac
jlahoda
parents: 19933
diff changeset
  4204
                deferredLintHandler.flush(env.tree);
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4205
                env.info.returnResult = null;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4206
                // java.lang.Enum may not be subclassed by a non-enum
06bc494ca11e Initial load
duke
parents:
diff changeset
  4207
                if (st.tsym == syms.enumSym &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4208
                    ((c.flags_field & (Flags.ENUM|Flags.COMPOUND)) == 0))
06bc494ca11e Initial load
duke
parents:
diff changeset
  4209
                    log.error(env.tree.pos(), "enum.no.subclassing");
06bc494ca11e Initial load
duke
parents:
diff changeset
  4210
06bc494ca11e Initial load
duke
parents:
diff changeset
  4211
                // Enums may not be extended by source-level classes
06bc494ca11e Initial load
duke
parents:
diff changeset
  4212
                if (st.tsym != null &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4213
                    ((st.tsym.flags_field & Flags.ENUM) != 0) &&
16558
07c08ad4a700 8010179: Remove transitional target values from javac
darcy
parents: 16557
diff changeset
  4214
                    ((c.flags_field & (Flags.ENUM | Flags.COMPOUND)) == 0)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4215
                    log.error(env.tree.pos(), "enum.types.not.extensible");
06bc494ca11e Initial load
duke
parents:
diff changeset
  4216
                }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4217
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4218
                if (isSerializable(c.type)) {
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4219
                    env.info.isSerializable = true;
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4220
                }
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4221
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4222
                attribClassBody(env, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4223
06bc494ca11e Initial load
duke
parents:
diff changeset
  4224
                chk.checkDeprecatedAnnotation(env.tree.pos(), c);
16333
a6e1ded87200 8009138: javac, equals-hashCode warning tuning
vromero
parents: 16331
diff changeset
  4225
                chk.checkClassOverrideEqualsAndHashIfNeeded(env.tree.pos(), c);
21018
95d225149128 8014016: javac is too late detecting invalid annotation usage
jlahoda
parents: 21009
diff changeset
  4226
                chk.checkFunctionalInterface((JCClassDecl) env.tree, c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4227
            } finally {
14057
b4b0377b8dba 7177387: Add target-typing support in method context
mcimadamore
parents: 14051
diff changeset
  4228
                env.info.returnResult = prevReturnRes;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4229
                log.useSource(prev);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4230
                chk.setLint(prevLint);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4231
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4232
06bc494ca11e Initial load
duke
parents:
diff changeset
  4233
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4234
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4235
06bc494ca11e Initial load
duke
parents:
diff changeset
  4236
    public void visitImport(JCImport tree) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4237
        // nothing to do
06bc494ca11e Initial load
duke
parents:
diff changeset
  4238
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4239
06bc494ca11e Initial load
duke
parents:
diff changeset
  4240
    /** Finish the attribution of a class. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4241
    private void attribClassBody(Env<AttrContext> env, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4242
        JCClassDecl tree = (JCClassDecl)env.tree;
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4243
        Assert.check(c == tree.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4244
06bc494ca11e Initial load
duke
parents:
diff changeset
  4245
        // Validate type parameters, supertype and interfaces.
14725
65836e833f59 8002099: Add support for intersection types in cast expression
mcimadamore
parents: 14724
diff changeset
  4246
        attribStats(tree.typarams, env);
5321
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4247
        if (!c.isAnonymous()) {
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4248
            //already checked if anonymous
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4249
            chk.validate(tree.typarams, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4250
            chk.validate(tree.extending, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4251
            chk.validate(tree.implementing, env);
c8efe769cb3b 6939620: Switch to 'complex' diamond inference scheme
mcimadamore
parents: 5320
diff changeset
  4252
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4253
06bc494ca11e Initial load
duke
parents:
diff changeset
  4254
        // If this is a non-abstract class, check that it has no abstract
06bc494ca11e Initial load
duke
parents:
diff changeset
  4255
        // methods or unimplemented methods of an implemented interface.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4256
        if ((c.flags() & (ABSTRACT | INTERFACE)) == 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4257
            if (!relax)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4258
                chk.checkAllDefined(tree.pos(), c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4259
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4260
06bc494ca11e Initial load
duke
parents:
diff changeset
  4261
        if ((c.flags() & ANNOTATION) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4262
            if (tree.implementing.nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  4263
                log.error(tree.implementing.head.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4264
                          "cant.extend.intf.annotation");
06bc494ca11e Initial load
duke
parents:
diff changeset
  4265
            if (tree.typarams.nonEmpty())
06bc494ca11e Initial load
duke
parents:
diff changeset
  4266
                log.error(tree.typarams.head.pos(),
06bc494ca11e Initial load
duke
parents:
diff changeset
  4267
                          "intf.annotation.cant.have.type.params");
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4268
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4269
            // If this annotation has a @Repeatable, validate
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4270
            Attribute.Compound repeatable = c.attribute(syms.repeatableType.tsym);
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4271
            if (repeatable != null) {
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4272
                // get diagnostic position for error reporting
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4273
                DiagnosticPosition cbPos = getDiagnosticPosition(tree, repeatable.type);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4274
                Assert.checkNonNull(cbPos);
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4275
15356
cf312dc54c60 8006119: update javac to follow latest spec for repeatable annotations
jjg
parents: 14953
diff changeset
  4276
                chk.validateRepeatable(c, repeatable, cbPos);
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4277
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4278
        } else {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4279
            // Check that all extended classes and interfaces
06bc494ca11e Initial load
duke
parents:
diff changeset
  4280
            // are compatible (i.e. no two define methods with same arguments
06bc494ca11e Initial load
duke
parents:
diff changeset
  4281
            // yet different return types).  (JLS 8.4.6.3)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4282
            chk.checkCompatibleSupertypes(tree.pos(), c.type);
14443
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4283
            if (allowDefaultMethods) {
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4284
                chk.checkDefaultMethodClashes(tree.pos(), c.type);
91c05eb19277 7192246: Add type-checking support for default methods
mcimadamore
parents: 14369
diff changeset
  4285
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4286
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4287
06bc494ca11e Initial load
duke
parents:
diff changeset
  4288
        // Check that class does not import the same parameterized interface
06bc494ca11e Initial load
duke
parents:
diff changeset
  4289
        // with two different argument lists.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4290
        chk.checkClassBounds(tree.pos(), c.type);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4291
06bc494ca11e Initial load
duke
parents:
diff changeset
  4292
        tree.type = c.type;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4293
8032
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4294
        for (List<JCTypeParameter> l = tree.typarams;
e1aa25ccdabb 6396503: javac should not require assertions enabled
jjg
parents: 8031
diff changeset
  4295
             l.nonEmpty(); l = l.tail) {
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4296
             Assert.checkNonNull(env.info.scope.findFirst(l.head.name));
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4297
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4298
06bc494ca11e Initial load
duke
parents:
diff changeset
  4299
        // Check that a generic class doesn't extend Throwable
06bc494ca11e Initial load
duke
parents:
diff changeset
  4300
        if (!c.type.allparams().isEmpty() && types.isSubtype(c.type, syms.throwableType))
06bc494ca11e Initial load
duke
parents:
diff changeset
  4301
            log.error(tree.extending.pos(), "generic.throwable");
06bc494ca11e Initial load
duke
parents:
diff changeset
  4302
06bc494ca11e Initial load
duke
parents:
diff changeset
  4303
        // Check that all methods which implement some
06bc494ca11e Initial load
duke
parents:
diff changeset
  4304
        // method conform to the method they implement.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4305
        chk.checkImplementations(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4306
9076
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4307
        //check that a resource implementing AutoCloseable cannot throw InterruptedException
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4308
        checkAutoCloseable(tree.pos(), env, c.type);
45c73da050e9 7027157: Project Coin: javac warnings for AutoCloseable.close throwing InterruptedException
mcimadamore
parents: 9075
diff changeset
  4309
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4310
        for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4311
            // Attribute declaration
06bc494ca11e Initial load
duke
parents:
diff changeset
  4312
            attribStat(l.head, env);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4313
            // Check that declarations in inner classes are not static (JLS 8.1.2)
06bc494ca11e Initial load
duke
parents:
diff changeset
  4314
            // Make an exception for static constants.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4315
            if (c.owner.kind != PCK &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4316
                ((c.flags() & STATIC) == 0 || c.name == names.empty) &&
06bc494ca11e Initial load
duke
parents:
diff changeset
  4317
                (TreeInfo.flags(l.head) & (STATIC | INTERFACE)) != 0) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4318
                Symbol sym = null;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 10459
diff changeset
  4319
                if (l.head.hasTag(VARDEF)) sym = ((JCVariableDecl) l.head).sym;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4320
                if (sym == null ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  4321
                    sym.kind != VAR ||
06bc494ca11e Initial load
duke
parents:
diff changeset
  4322
                    ((VarSymbol) sym).getConstValue() == null)
8239
d2c934e951e2 7014715: javac returns different error code for certain failure(s)
mcimadamore
parents: 8237
diff changeset
  4323
                    log.error(l.head.pos(), "icls.cant.have.static.decl", c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4324
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4325
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4326
06bc494ca11e Initial load
duke
parents:
diff changeset
  4327
        // Check for cycles among non-initial constructors.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4328
        chk.checkCyclicConstructors(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4329
06bc494ca11e Initial load
duke
parents:
diff changeset
  4330
        // Check for cycles among annotation elements.
06bc494ca11e Initial load
duke
parents:
diff changeset
  4331
        chk.checkNonCyclicElements(tree);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4332
06bc494ca11e Initial load
duke
parents:
diff changeset
  4333
        // Check for proper use of serialVersionUID
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4334
        if (env.info.lint.isEnabled(LintCategory.SERIAL) &&
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4335
            isSerializable(c.type) &&
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4336
            (c.flags() & Flags.ENUM) == 0 &&
18899
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4337
            checkForSerial(c)) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4338
            checkSerialVersionUID(tree, c);
06bc494ca11e Initial load
duke
parents:
diff changeset
  4339
        }
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4340
        if (allowTypeAnnos) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4341
            // Correctly organize the postions of the type annotations
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4342
            typeAnnotations.organizeTypeAnnotationsBodies(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4343
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4344
            // Check type annotations applicability rules
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4345
            validateTypeAnnotations(tree, false);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4346
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4347
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4348
        // where
18899
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4349
        boolean checkForSerial(ClassSymbol c) {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4350
            if ((c.flags() & ABSTRACT) == 0) {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4351
                return true;
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4352
            } else {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4353
                return c.members().anyMatch(anyNonAbstractOrDefaultMethod);
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4354
            }
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4355
        }
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4356
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4357
        public static final Filter<Symbol> anyNonAbstractOrDefaultMethod = new Filter<Symbol>() {
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4358
            @Override
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4359
            public boolean accepts(Symbol s) {
27224
228abfa87080 8054457: Refactor Symbol kinds from small ints to an enum
emc
parents: 26991
diff changeset
  4360
                return s.kind == MTH &&
18899
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4361
                       (s.flags() & (DEFAULT | ABSTRACT)) != ABSTRACT;
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4362
            }
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4363
        };
2557b27d1f1c 6356530: -Xlint:serial does not flag abstract classes with concrete methods/members
vromero
parents: 18662
diff changeset
  4364
13689
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4365
        /** get a diagnostic position for an attribute of Type t, or null if attribute missing */
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4366
        private DiagnosticPosition getDiagnosticPosition(JCClassDecl tree, Type t) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4367
            for(List<JCAnnotation> al = tree.mods.annotations; !al.isEmpty(); al = al.tail) {
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4368
                if (types.isSameType(al.head.annotationType.type, t))
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4369
                    return al.head.pos();
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4370
            }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4371
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4372
            return null;
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4373
        }
4d519199a6aa 7151010: Add compiler support for repeating annotations
jfranck
parents: 13439
diff changeset
  4374
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4375
        /** check if a type is a subtype of Serializable, if that is available. */
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4376
        boolean isSerializable(Type t) {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4377
            try {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4378
                syms.serializableType.complete();
06bc494ca11e Initial load
duke
parents:
diff changeset
  4379
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4380
            catch (CompletionFailure e) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4381
                return false;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4382
            }
24219
e7dc661cafae 8029102: Enhance compiler warnings for Lambda
vromero
parents: 24066
diff changeset
  4383
            return types.isSubtype(t, syms.serializableType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4384
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4385
06bc494ca11e Initial load
duke
parents:
diff changeset
  4386
        /** Check that an appropriate serialVersionUID member is defined. */
06bc494ca11e Initial load
duke
parents:
diff changeset
  4387
        private void checkSerialVersionUID(JCClassDecl tree, ClassSymbol c) {
06bc494ca11e Initial load
duke
parents:
diff changeset
  4388
06bc494ca11e Initial load
duke
parents:
diff changeset
  4389
            // check for presence of serialVersionUID
25443
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4390
            VarSymbol svuid = null;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4391
            for (Symbol sym : c.members().getSymbolsByName(names.serialVersionUID)) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4392
                if (sym.kind == VAR) {
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4393
                    svuid = (VarSymbol)sym;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4394
                    break;
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4395
                }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4396
            }
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4397
9187d77f2c64 8031569: Refactor javac scope implementation to enable lazy imports
jlahoda
parents: 25279
diff changeset
  4398
            if (svuid == null) {
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4399
                log.warning(LintCategory.SERIAL,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  4400
                        tree.pos(), "missing.SVUID", c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4401
                return;
06bc494ca11e Initial load
duke
parents:
diff changeset
  4402
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4403
06bc494ca11e Initial load
duke
parents:
diff changeset
  4404
            // check that it is static final
06bc494ca11e Initial load
duke
parents:
diff changeset
  4405
            if ((svuid.flags() & (STATIC | FINAL)) !=
06bc494ca11e Initial load
duke
parents:
diff changeset
  4406
                (STATIC | FINAL))
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4407
                log.warning(LintCategory.SERIAL,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  4408
                        TreeInfo.diagnosticPositionFor(svuid, tree), "improper.SVUID", c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4409
06bc494ca11e Initial load
duke
parents:
diff changeset
  4410
            // check that it is long
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14267
diff changeset
  4411
            else if (!svuid.type.hasTag(LONG))
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4412
                log.warning(LintCategory.SERIAL,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  4413
                        TreeInfo.diagnosticPositionFor(svuid, tree), "long.SVUID", c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4414
06bc494ca11e Initial load
duke
parents:
diff changeset
  4415
            // check constant
06bc494ca11e Initial load
duke
parents:
diff changeset
  4416
            else if (svuid.getConstValue() == null)
7643
a067a0cda531 6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
mcimadamore
parents: 7628
diff changeset
  4417
                log.warning(LintCategory.SERIAL,
6151
dd513881e71d 6957438: improve code for generating warning messages containing option names
jjg
parents: 6148
diff changeset
  4418
                        TreeInfo.diagnosticPositionFor(svuid, tree), "constant.SVUID", c);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4419
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  4420
06bc494ca11e Initial load
duke
parents:
diff changeset
  4421
    private Type capture(Type type) {
18911
dcc1e26a8c9c 8012238: Nested method capture and inference
mcimadamore
parents: 18910
diff changeset
  4422
        return types.capture(type);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4423
    }
3149
0cd06d598d6f 6843077: JSR 308: Annotations on types
jjg
parents: 3144
diff changeset
  4424
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4425
    public void validateTypeAnnotations(JCTree tree, boolean sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4426
        tree.accept(new TypeAnnotationsValidator(sigOnly));
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4427
    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4428
    //where
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4429
    private final class TypeAnnotationsValidator extends TreeScanner {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4430
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4431
        private final boolean sigOnly;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4432
        public TypeAnnotationsValidator(boolean sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4433
            this.sigOnly = sigOnly;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4434
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4435
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4436
        public void visitAnnotation(JCAnnotation tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4437
            chk.validateTypeAnnotation(tree, false);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4438
            super.visitAnnotation(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4439
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4440
        public void visitAnnotatedType(JCAnnotatedType tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4441
            if (!tree.underlyingType.type.isErroneous()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4442
                super.visitAnnotatedType(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4443
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4444
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4445
        public void visitTypeParameter(JCTypeParameter tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4446
            chk.validateTypeAnnotations(tree.annotations, true);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4447
            scan(tree.bounds);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4448
            // Don't call super.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4449
            // This is needed because above we call validateTypeAnnotation with
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4450
            // false, which would forbid annotations on type parameters.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4451
            // super.visitTypeParameter(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4452
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4453
        public void visitMethodDef(JCMethodDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4454
            if (tree.recvparam != null &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4455
                    !tree.recvparam.vartype.type.isErroneous()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4456
                checkForDeclarationAnnotations(tree.recvparam.mods.annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4457
                        tree.recvparam.vartype.type.tsym);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4458
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4459
            if (tree.restype != null && tree.restype.type != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4460
                validateAnnotatedType(tree.restype, tree.restype.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4461
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4462
            if (sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4463
                scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4464
                scan(tree.restype);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4465
                scan(tree.typarams);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4466
                scan(tree.recvparam);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4467
                scan(tree.params);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4468
                scan(tree.thrown);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4469
            } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4470
                scan(tree.defaultValue);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4471
                scan(tree.body);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4472
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4473
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4474
        public void visitVarDef(final JCVariableDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4475
            //System.err.println("validateTypeAnnotations.visitVarDef " + tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4476
            if (tree.sym != null && tree.sym.type != null)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4477
                validateAnnotatedType(tree.vartype, tree.sym.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4478
            scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4479
            scan(tree.vartype);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4480
            if (!sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4481
                scan(tree.init);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4482
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4483
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4484
        public void visitTypeCast(JCTypeCast tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4485
            if (tree.clazz != null && tree.clazz.type != null)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4486
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4487
            super.visitTypeCast(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4488
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4489
        public void visitTypeTest(JCInstanceOf tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4490
            if (tree.clazz != null && tree.clazz.type != null)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4491
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4492
            super.visitTypeTest(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4493
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4494
        public void visitNewClass(JCNewClass tree) {
27851
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4495
            if (tree.clazz != null && tree.clazz.type != null) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4496
                if (tree.clazz.hasTag(ANNOTATED_TYPE)) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4497
                    checkForDeclarationAnnotations(((JCAnnotatedType) tree.clazz).annotations,
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4498
                            tree.clazz.type.tsym);
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4499
                }
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4500
                if (tree.def != null) {
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4501
                    checkForDeclarationAnnotations(tree.def.mods.annotations, tree.clazz.type.tsym);
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4502
                }
5f28577d20f6 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass
jfranck
parents: 27845
diff changeset
  4503
26532
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4504
                validateAnnotatedType(tree.clazz, tree.clazz.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4505
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4506
            super.visitNewClass(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4507
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4508
        public void visitNewArray(JCNewArray tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4509
            if (tree.elemtype != null && tree.elemtype.type != null) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4510
                if (tree.elemtype.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4511
                    checkForDeclarationAnnotations(((JCAnnotatedType) tree.elemtype).annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4512
                            tree.elemtype.type.tsym);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4513
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4514
                validateAnnotatedType(tree.elemtype, tree.elemtype.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4515
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4516
            super.visitNewArray(tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4517
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4518
        public void visitClassDef(JCClassDecl tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4519
            //System.err.println("validateTypeAnnotations.visitClassDef " + tree);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4520
            if (sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4521
                scan(tree.mods);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4522
                scan(tree.typarams);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4523
                scan(tree.extending);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4524
                scan(tree.implementing);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4525
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4526
            for (JCTree member : tree.defs) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4527
                if (member.hasTag(Tag.CLASSDEF)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4528
                    continue;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4529
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4530
                scan(member);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4531
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4532
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4533
        public void visitBlock(JCBlock tree) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4534
            if (!sigOnly) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4535
                scan(tree.stats);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4536
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4537
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4538
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4539
        /* I would want to model this after
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4540
         * com.sun.tools.javac.comp.Check.Validator.visitSelectInternal(JCFieldAccess)
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4541
         * and override visitSelect and visitTypeApply.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4542
         * However, we only set the annotated type in the top-level type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4543
         * of the symbol.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4544
         * Therefore, we need to override each individual location where a type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4545
         * can occur.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4546
         */
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4547
        private void validateAnnotatedType(final JCTree errtree, final Type type) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4548
            //System.err.println("Attr.validateAnnotatedType: " + errtree + " type: " + type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4549
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4550
            if (type.isPrimitiveOrVoid()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4551
                return;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4552
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4553
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4554
            JCTree enclTr = errtree;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4555
            Type enclTy = type;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4556
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4557
            boolean repeat = true;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4558
            while (repeat) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4559
                if (enclTr.hasTag(TYPEAPPLY)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4560
                    List<Type> tyargs = enclTy.getTypeArguments();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4561
                    List<JCExpression> trargs = ((JCTypeApply)enclTr).getTypeArguments();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4562
                    if (trargs.length() > 0) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4563
                        // Nothing to do for diamonds
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4564
                        if (tyargs.length() == trargs.length()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4565
                            for (int i = 0; i < tyargs.length(); ++i) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4566
                                validateAnnotatedType(trargs.get(i), tyargs.get(i));
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4567
                            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4568
                        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4569
                        // If the lengths don't match, it's either a diamond
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4570
                        // or some nested type that redundantly provides
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4571
                        // type arguments in the tree.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4572
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4573
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4574
                    // Look at the clazz part of a generic type
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4575
                    enclTr = ((JCTree.JCTypeApply)enclTr).clazz;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4576
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4577
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4578
                if (enclTr.hasTag(SELECT)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4579
                    enclTr = ((JCTree.JCFieldAccess)enclTr).getExpression();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4580
                    if (enclTy != null &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4581
                            !enclTy.hasTag(NONE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4582
                        enclTy = enclTy.getEnclosingType();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4583
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4584
                } else if (enclTr.hasTag(ANNOTATED_TYPE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4585
                    JCAnnotatedType at = (JCTree.JCAnnotatedType) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4586
                    if (enclTy == null || enclTy.hasTag(NONE)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4587
                        if (at.getAnnotations().size() == 1) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4588
                            log.error(at.underlyingType.pos(), "cant.type.annotate.scoping.1", at.getAnnotations().head.attribute);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4589
                        } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4590
                            ListBuffer<Attribute.Compound> comps = new ListBuffer<>();
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4591
                            for (JCAnnotation an : at.getAnnotations()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4592
                                comps.add(an.attribute);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4593
                            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4594
                            log.error(at.underlyingType.pos(), "cant.type.annotate.scoping", comps.toList());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4595
                        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4596
                        repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4597
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4598
                    enclTr = at.underlyingType;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4599
                    // enclTy doesn't need to be changed
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4600
                } else if (enclTr.hasTag(IDENT)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4601
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4602
                } else if (enclTr.hasTag(JCTree.Tag.WILDCARD)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4603
                    JCWildcard wc = (JCWildcard) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4604
                    if (wc.getKind() == JCTree.Kind.EXTENDS_WILDCARD) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4605
                        validateAnnotatedType(wc.getBound(), ((WildcardType)enclTy).getExtendsBound());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4606
                    } else if (wc.getKind() == JCTree.Kind.SUPER_WILDCARD) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4607
                        validateAnnotatedType(wc.getBound(), ((WildcardType)enclTy).getSuperBound());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4608
                    } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4609
                        // Nothing to do for UNBOUND
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4610
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4611
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4612
                } else if (enclTr.hasTag(TYPEARRAY)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4613
                    JCArrayTypeTree art = (JCArrayTypeTree) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4614
                    validateAnnotatedType(art.getType(), ((ArrayType)enclTy).getComponentType());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4615
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4616
                } else if (enclTr.hasTag(TYPEUNION)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4617
                    JCTypeUnion ut = (JCTypeUnion) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4618
                    for (JCTree t : ut.getTypeAlternatives()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4619
                        validateAnnotatedType(t, t.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4620
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4621
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4622
                } else if (enclTr.hasTag(TYPEINTERSECTION)) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4623
                    JCTypeIntersection it = (JCTypeIntersection) enclTr;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4624
                    for (JCTree t : it.getBounds()) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4625
                        validateAnnotatedType(t, t.type);
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4626
                    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4627
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4628
                } else if (enclTr.getKind() == JCTree.Kind.PRIMITIVE_TYPE ||
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4629
                           enclTr.getKind() == JCTree.Kind.ERRONEOUS) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4630
                    repeat = false;
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4631
                } else {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4632
                    Assert.error("Unexpected tree: " + enclTr + " with kind: " + enclTr.getKind() +
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4633
                            " within: "+ errtree + " with kind: " + errtree.getKind());
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4634
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4635
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4636
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4637
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4638
        private void checkForDeclarationAnnotations(List<? extends JCAnnotation> annotations,
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4639
                Symbol sym) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4640
            // Ensure that no declaration annotations are present.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4641
            // Note that a tree type might be an AnnotatedType with
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4642
            // empty annotations, if only declaration annotations were given.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4643
            // This method will raise an error for such a type.
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4644
            for (JCAnnotation ai : annotations) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4645
                if (!ai.type.isErroneous() &&
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4646
                        typeAnnotations.annotationType(ai.attribute, sym) == TypeAnnotations.AnnotationType.DECLARATION) {
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4647
                    log.error(ai.pos(), "annotation.type.not.applicable");
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4648
                }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4649
            }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4650
        }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4651
    }
aa84b6606229 8056021: checkin for JDK-8027262 breaks Checker Framework
jfranck
parents: 26266
diff changeset
  4652
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4653
    // <editor-fold desc="post-attribution visitor">
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4654
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4655
    /**
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4656
     * Handle missing types/symbols in an AST. This routine is useful when
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4657
     * the compiler has encountered some errors (which might have ended up
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4658
     * terminating attribution abruptly); if the compiler is used in fail-over
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4659
     * mode (e.g. by an IDE) and the AST contains semantic errors, this routine
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4660
     * prevents NPE to be progagated during subsequent compilation steps.
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4661
     */
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  4662
    public void postAttr(JCTree tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14057
diff changeset
  4663
        new PostAttrAnalyzer().scan(tree);
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4664
    }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4665
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4666
    class PostAttrAnalyzer extends TreeScanner {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4667
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4668
        private void initTypeIfNeeded(JCTree that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4669
            if (that.type == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4670
                if (that.hasTag(METHODDEF)) {
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4671
                    that.type = dummyMethodType((JCMethodDecl)that);
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4672
                } else {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4673
                    that.type = syms.unknownType;
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4674
                }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4675
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4676
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4677
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4678
        /* Construct a dummy method type. If we have a method declaration,
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4679
         * and the declared return type is void, then use that return type
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4680
         * instead of UNKNOWN to avoid spurious error messages in lambda
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4681
         * bodies (see:JDK-8041704).
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4682
         */
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4683
        private Type dummyMethodType(JCMethodDecl md) {
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4684
            Type restype = syms.unknownType;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4685
            if (md != null && md.restype.hasTag(TYPEIDENT)) {
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4686
                JCPrimitiveTypeTree prim = (JCPrimitiveTypeTree)md.restype;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4687
                if (prim.typetag == VOID)
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4688
                    restype = syms.voidType;
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4689
            }
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4690
            return new MethodType(List.<Type>nil(), restype,
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4691
                                  List.<Type>nil(), syms.methodClass);
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4692
        }
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4693
        private Type dummyMethodType() {
24609
5139d892e270 8041704: wrong error message when mixing lambda expression and inner class
pgovereau
parents: 24401
diff changeset
  4694
            return dummyMethodType(null);
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4695
        }
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4696
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4697
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4698
        public void scan(JCTree tree) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4699
            if (tree == null) return;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4700
            if (tree instanceof JCExpression) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4701
                initTypeIfNeeded(tree);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4702
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4703
            super.scan(tree);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4704
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4705
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4706
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4707
        public void visitIdent(JCIdent that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4708
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4709
                that.sym = syms.unknownSymbol;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4710
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4711
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4712
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4713
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4714
        public void visitSelect(JCFieldAccess that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4715
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4716
                that.sym = syms.unknownSymbol;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4717
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4718
            super.visitSelect(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4719
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4720
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4721
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4722
        public void visitClassDef(JCClassDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4723
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4724
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4725
                that.sym = new ClassSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4726
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4727
            super.visitClassDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4728
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4729
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4730
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4731
        public void visitMethodDef(JCMethodDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4732
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4733
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4734
                that.sym = new MethodSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4735
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4736
            super.visitMethodDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4737
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4738
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4739
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4740
        public void visitVarDef(JCVariableDecl that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4741
            initTypeIfNeeded(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4742
            if (that.sym == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4743
                that.sym = new VarSymbol(0, that.name, that.type, syms.noSymbol);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4744
                that.sym.adr = 0;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4745
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4746
            super.visitVarDef(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4747
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4748
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4749
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4750
        public void visitNewClass(JCNewClass that) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4751
            if (that.constructor == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4752
                that.constructor = new MethodSymbol(0, names.init,
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4753
                        dummyMethodType(), syms.noSymbol);
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4754
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4755
            if (that.constructorType == null) {
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4756
                that.constructorType = syms.unknownType;
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4757
            }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4758
            super.visitNewClass(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4759
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4760
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4761
        @Override
10187
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  4762
        public void visitAssignop(JCAssignOp that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4763
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4764
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4765
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4766
            }
10187
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  4767
            super.visitAssignop(that);
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  4768
        }
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  4769
983f0e987540 7060926: Attr.PostAttrAnalyzer misses a case
jjg
parents: 9724
diff changeset
  4770
        @Override
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4771
        public void visitBinary(JCBinary that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4772
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4773
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4774
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4775
            }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4776
            super.visitBinary(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4777
        }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4778
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4779
        @Override
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4780
        public void visitUnary(JCUnary that) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4781
            if (that.operator == null) {
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4782
                that.operator = new OperatorSymbol(names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4783
                        -1, syms.noSymbol);
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4784
            }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4785
            super.visitUnary(that);
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4786
        }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4787
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4788
        @Override
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4789
        public void visitLambda(JCLambda that) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4790
            super.visitLambda(that);
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4791
            if (that.targets == null) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4792
                that.targets = List.nil();
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4793
            }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4794
        }
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4795
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4796
        @Override
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4797
        public void visitReference(JCMemberReference that) {
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4798
            super.visitReference(that);
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4799
            if (that.sym == null) {
22685
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4800
                that.sym = new MethodSymbol(0, names.empty, dummyMethodType(),
c8d0807378b6 8030816: javac crashes when mixing lambdas and inner classes
vromero
parents: 22440
diff changeset
  4801
                        syms.noSymbol);
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4802
            }
15374
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4803
            if (that.targets == null) {
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4804
                that.targets = List.nil();
fb8f6acf09cc 8005244: Implement overload resolution as per latest spec EDR
mcimadamore
parents: 15356
diff changeset
  4805
            }
14062
b7439971a094 7177386: Add attribution support for method references
mcimadamore
parents: 14058
diff changeset
  4806
        }
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4807
    }
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6592
diff changeset
  4808
    // </editor-fold>
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  4809
}