src/hotspot/share/classfile/verifier.cpp
author lfoltan
Mon, 20 Aug 2018 08:25:57 -0400
changeset 51444 3e5d28e6de32
parent 51329 9c68699bebe5
child 51697 49e1b21d9878
permissions -rw-r--r--
8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation Summary: Clean up VM anonymous class terminology. Reviewed-by: coleenp, dholmes, mchung
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
49192
6734eeef4283 8198474: Move JNIHandles::resolve into jniHandles.inline.hpp
kbarrett
parents: 48826
diff changeset
     2
 * Copyright (c) 1998, 2018, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    25
#include "precompiled.hpp"
47765
b7c7428eaab9 8189610: Reconcile jvm.h and all jvm_md.h between java.base and hotspot
coleenp
parents: 47634
diff changeset
    26
#include "jvm.h"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    27
#include "classfile/classFileStream.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    28
#include "classfile/javaClasses.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    29
#include "classfile/stackMapTable.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    30
#include "classfile/stackMapFrame.hpp"
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    31
#include "classfile/stackMapTableFormat.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    32
#include "classfile/systemDictionary.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    33
#include "classfile/verifier.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    34
#include "classfile/vmSymbols.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    35
#include "interpreter/bytecodes.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    36
#include "interpreter/bytecodeStream.hpp"
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
    37
#include "logging/log.hpp"
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
    38
#include "logging/logStream.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    39
#include "memory/oopFactory.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    40
#include "memory/resourceArea.hpp"
49340
4e82736053ae 8191102: Incorrect include file use in classLoader.hpp
hseigel
parents: 49192
diff changeset
    41
#include "oops/constantPool.inline.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    42
#include "oops/instanceKlass.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    43
#include "oops/oop.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    44
#include "oops/typeArrayOop.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    45
#include "runtime/fieldDescriptor.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    46
#include "runtime/handles.inline.hpp"
49449
ef5d5d343e2a 8199263: Split interfaceSupport.hpp to not require including .inline.hpp files
coleenp
parents: 49340
diff changeset
    47
#include "runtime/interfaceSupport.inline.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    48
#include "runtime/javaCalls.hpp"
49192
6734eeef4283 8198474: Move JNIHandles::resolve into jniHandles.inline.hpp
kbarrett
parents: 48826
diff changeset
    49
#include "runtime/jniHandles.inline.hpp"
50429
83aec1d357d4 8204301: Make OrderAccess functions available to hpp rather than inline.hpp files
coleenp
parents: 49770
diff changeset
    50
#include "runtime/orderAccess.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    51
#include "runtime/os.hpp"
49594
898ef81cbc0e 8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents: 49449
diff changeset
    52
#include "runtime/safepointVerifiers.hpp"
31021
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
    53
#include "runtime/thread.hpp"
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
    54
#include "services/threadService.hpp"
46625
edefffab74e2 8183552: Move align functions to align.hpp
stefank
parents: 46620
diff changeset
    55
#include "utilities/align.hpp"
25715
d5a8dbdc5150 8049325: Introduce and clean up umbrella headers for the files in the cpu subdirectories.
goetz
parents: 24663
diff changeset
    56
#include "utilities/bytes.hpp"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    57
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
    58
#define NOFAILOVER_MAJOR_VERSION                       51
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
    59
#define NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION  51
16676
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
    60
#define STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION       52
46403
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
    61
#define MAX_ARRAY_DIMENSIONS 255
5683
116fea597b5d 6911922: JVM must throw VerifyError for jsr or jsr_w opcodes in class file v.51+
kamg
parents: 4571
diff changeset
    62
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
// Access to external entry for VerifyClassCodes - old byte code verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
extern "C" {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
  typedef jboolean (*verify_byte_codes_fn_t)(JNIEnv *, jclass, char *, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
  typedef jboolean (*verify_byte_codes_fn_new_t)(JNIEnv *, jclass, char *, jint, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
static void* volatile _verify_byte_codes_fn = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
static volatile jint _is_new_verify_byte_codes_fn = (jint) true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
static void* verify_byte_codes_fn() {
47634
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    75
  if (OrderAccess::load_acquire(&_verify_byte_codes_fn) == NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
    void *lib_handle = os::native_java_library();
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    77
    void *func = os::dll_lookup(lib_handle, "VerifyClassCodesForMajorVersion");
47634
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    78
    OrderAccess::release_store(&_verify_byte_codes_fn, func);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
    if (func == NULL) {
40887
8d35e19f5548 8158854: Ensure release_store is paired with load_acquire in lock-free code
dholmes
parents: 40856
diff changeset
    80
      _is_new_verify_byte_codes_fn = false;
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    81
      func = os::dll_lookup(lib_handle, "VerifyClassCodes");
47634
6a0c42c40cd1 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot
coleenp
parents: 47216
diff changeset
    82
      OrderAccess::release_store(&_verify_byte_codes_fn, func);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
  return (void*)_verify_byte_codes_fn;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
// Methods in Verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    91
bool Verifier::should_verify_for(oop class_loader, bool should_verify_class) {
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    92
  return (class_loader == NULL || !should_verify_class) ?
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
    BytecodeVerificationLocal : BytecodeVerificationRemote;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    94
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    95
40856
3378947a95e6 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent
rprotacio
parents: 39715
diff changeset
    96
bool Verifier::relax_access_for(oop loader) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    97
  bool trusted = java_lang_ClassLoader::is_trusted_loader(loader);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
  bool need_verify =
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
    // verifyAll
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
    (BytecodeVerificationLocal && BytecodeVerificationRemote) ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
   101
    // verifyRemote
489c9b5090e2 Initial load
duke
parents:
diff changeset
   102
    (!BytecodeVerificationLocal && BytecodeVerificationRemote && !trusted);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   103
  return !need_verify;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   104
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   105
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   106
void Verifier::trace_class_resolution(Klass* resolve_class, InstanceKlass* verify_class) {
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   107
  assert(verify_class != NULL, "Unexpected null verify_class");
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   108
  ResourceMark rm;
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   109
  Symbol* s = verify_class->source_file_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   110
  const char* source_file = (s != NULL ? s->as_C_string() : NULL);
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   111
  const char* verify = verify_class->external_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   112
  const char* resolve = resolve_class->external_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   113
  // print in a single call to reduce interleaving between threads
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   114
  if (source_file != NULL) {
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   115
    log_debug(class, resolve)("%s %s %s (verification)", verify, resolve, source_file);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   116
  } else {
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   117
    log_debug(class, resolve)("%s %s (verification)", verify, resolve);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   118
  }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   119
}
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   120
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   121
// Prints the end-verification message to the appropriate output.
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   122
void Verifier::log_end_verification(outputStream* st, const char* klassName, Symbol* exception_name, TRAPS) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   123
  if (HAS_PENDING_EXCEPTION) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   124
    st->print("Verification for %s has", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   125
    st->print_cr(" exception pending %s ",
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   126
                 PENDING_EXCEPTION->klass()->external_name());
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   127
  } else if (exception_name != NULL) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   128
    st->print_cr("Verification for %s failed", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   129
  }
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   130
  st->print_cr("End class verification for: %s", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   131
}
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   132
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   133
bool Verifier::verify(InstanceKlass* klass, Verifier::Mode mode, bool should_verify_class, TRAPS) {
46271
979ebd346ecf 8169881: Remove implicit Handle conversions oop->Handle
coleenp
parents: 41542
diff changeset
   134
  HandleMark hm(THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   135
  ResourceMark rm(THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   136
27159
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   137
  // Eagerly allocate the identity hash code for a klass. This is a fallout
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   138
  // from 6320749 and 8059924: hash code generator is not supposed to be called
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   139
  // during the safepoint, but it allows to sneak the hashcode in during
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   140
  // verification. Without this eager hashcode generation, we may end up
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   141
  // installing the hashcode during some other operation, which may be at
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   142
  // safepoint -- blowing up the checks. It was previously done as the side
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   143
  // effect (sic!) for external_name(), but instead of doing that, we opt to
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   144
  // explicitly push the hashcode in here. This is signify the following block
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   145
  // is IMPORTANT:
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   146
  if (klass->java_mirror() != NULL) {
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   147
    klass->java_mirror()->identity_hash();
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   148
  }
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   149
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   150
  if (!is_eligible_for_verification(klass, should_verify_class)) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   151
    return true;
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   152
  }
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   153
31021
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   154
  // Timer includes any side effects of class verification (resolution,
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   155
  // etc), but not recursive calls to Verifier::verify().
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   156
  JavaThread* jt = (JavaThread*)THREAD;
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   157
  PerfClassTraceTime timer(ClassLoader::perf_class_verify_time(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   158
                           ClassLoader::perf_class_verify_selftime(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   159
                           ClassLoader::perf_classes_verified(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   160
                           jt->get_thread_stat()->perf_recursion_counts_addr(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   161
                           jt->get_thread_stat()->perf_timers_addr(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   162
                           PerfClassTraceTime::CLASS_VERIFY);
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   163
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   164
  // If the class should be verified, first see if we can use the split
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   165
  // verifier.  If not, or if verification fails and FailOverToOldVerifier
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   166
  // is set, then call the inference verifier.
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   167
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   168
  Symbol* exception_name = NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   169
  const size_t message_buffer_len = klass->name()->utf8_length() + 1024;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   170
  char* message_buffer = NEW_RESOURCE_ARRAY(char, message_buffer_len);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   171
  char* exception_message = message_buffer;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   172
489c9b5090e2 Initial load
duke
parents:
diff changeset
   173
  const char* klassName = klass->external_name();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   174
  bool can_failover = FailOverToOldVerifier &&
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   175
     klass->major_version() < NOFAILOVER_MAJOR_VERSION;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   176
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   177
  log_info(class, init)("Start class verification for: %s", klassName);
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   178
  if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   179
    ClassVerifier split_verifier(klass, THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   180
    split_verifier.verify_class(THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   181
    exception_name = split_verifier.result();
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   182
    if (can_failover && !HAS_PENDING_EXCEPTION &&
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   183
        (exception_name == vmSymbols::java_lang_VerifyError() ||
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   184
         exception_name == vmSymbols::java_lang_ClassFormatError())) {
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
   185
      log_info(verification)("Fail over class verification to old verifier for: %s", klassName);
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   186
      log_info(class, init)("Fail over class verification to old verifier for: %s", klassName);
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   187
      exception_name = inference_verify(
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   188
        klass, message_buffer, message_buffer_len, THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   189
    }
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   190
    if (exception_name != NULL) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   191
      exception_message = split_verifier.exception_message();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   192
    }
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   193
  } else {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   194
    exception_name = inference_verify(
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   195
        klass, message_buffer, message_buffer_len, THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   196
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   197
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   198
  LogTarget(Info, class, init) lt1;
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   199
  if (lt1.is_enabled()) {
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   200
    LogStream ls(lt1);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   201
    log_end_verification(&ls, klassName, exception_name, THREAD);
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   202
  }
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   203
  LogTarget(Info, verification) lt2;
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   204
  if (lt2.is_enabled()) {
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   205
    LogStream ls(lt2);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   206
    log_end_verification(&ls, klassName, exception_name, THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   207
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   208
489c9b5090e2 Initial load
duke
parents:
diff changeset
   209
  if (HAS_PENDING_EXCEPTION) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   210
    return false; // use the existing exception
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   211
  } else if (exception_name == NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   212
    return true; // verifcation succeeded
489c9b5090e2 Initial load
duke
parents:
diff changeset
   213
  } else { // VerifyError or ClassFormatError to be created and thrown
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
    ResourceMark rm(THREAD);
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   215
    Klass* kls =
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
      SystemDictionary::resolve_or_fail(exception_name, true, CHECK_false);
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   217
    if (log_is_enabled(Debug, class, resolve)) {
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   218
      Verifier::trace_class_resolution(kls, klass);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   219
    }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   220
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   221
    while (kls != NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
      if (kls == klass) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   223
        // If the class being verified is the exception we're creating
489c9b5090e2 Initial load
duke
parents:
diff changeset
   224
        // or one of it's superclasses, we're in trouble and are going
489c9b5090e2 Initial load
duke
parents:
diff changeset
   225
        // to infinitely recurse when we try to initialize the exception.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   226
        // So bail out here by throwing the preallocated VM error.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   227
        THROW_OOP_(Universe::virtual_machine_error_instance(), false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   228
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   229
      kls = kls->super();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   230
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   231
    message_buffer[message_buffer_len - 1] = '\0'; // just to be sure
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   232
    THROW_MSG_(exception_name, exception_message, false);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   233
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   234
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   235
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   236
bool Verifier::is_eligible_for_verification(InstanceKlass* klass, bool should_verify_class) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   237
  Symbol* name = klass->name();
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   238
  Klass* refl_magic_klass = SystemDictionary::reflect_MagicAccessorImpl_klass();
19704
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   239
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   240
  bool is_reflect = refl_magic_klass != NULL && klass->is_subtype_of(refl_magic_klass);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   241
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   242
  return (should_verify_for(klass->class_loader(), should_verify_class) &&
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   243
    // return if the class is a bootstrapping class
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   244
    // or defineClass specified not to verify by default (flags override passed arg)
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   245
    // We need to skip the following four for bootstraping
489c9b5090e2 Initial load
duke
parents:
diff changeset
   246
    name != vmSymbols::java_lang_Object() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   247
    name != vmSymbols::java_lang_Class() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   248
    name != vmSymbols::java_lang_String() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   249
    name != vmSymbols::java_lang_Throwable() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   250
489c9b5090e2 Initial load
duke
parents:
diff changeset
   251
    // Can not verify the bytecodes for shared classes because they have
489c9b5090e2 Initial load
duke
parents:
diff changeset
   252
    // already been rewritten to contain constant pool cache indices,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   253
    // which the verifier can't understand.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   254
    // Shared classes shouldn't have stackmaps either.
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   255
    !klass->is_shared() &&
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   256
489c9b5090e2 Initial load
duke
parents:
diff changeset
   257
    // As of the fix for 4486457 we disable verification for all of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
   258
    // dynamically-generated bytecodes associated with the 1.4
489c9b5090e2 Initial load
duke
parents:
diff changeset
   259
    // reflection implementation, not just those associated with
37301
a936b4e01afb 8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents: 37261
diff changeset
   260
    // jdk/internal/reflect/SerializationConstructorAccessor.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   261
    // NOTE: this is called too early in the bootstrapping process to be
24456
8c7933fa5a1f 8025580: Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors
coleenp
parents: 24424
diff changeset
   262
    // guarded by Universe::is_gte_jdk14x_version().
19704
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   263
    // Also for lambda generated code, gte jdk8
24456
8c7933fa5a1f 8025580: Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors
coleenp
parents: 24424
diff changeset
   264
    (!is_reflect));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   265
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   266
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   267
Symbol* Verifier::inference_verify(
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   268
    InstanceKlass* klass, char* message, size_t message_len, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   269
  JavaThread* thread = (JavaThread*)THREAD;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
  JNIEnv *env = thread->jni_environment();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   271
489c9b5090e2 Initial load
duke
parents:
diff changeset
   272
  void* verify_func = verify_byte_codes_fn();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   273
489c9b5090e2 Initial load
duke
parents:
diff changeset
   274
  if (verify_func == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   275
    jio_snprintf(message, message_len, "Could not link verifier");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   276
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   277
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   278
489c9b5090e2 Initial load
duke
parents:
diff changeset
   279
  ResourceMark rm(THREAD);
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
   280
  log_info(verification)("Verifying class %s with old format", klass->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   281
489c9b5090e2 Initial load
duke
parents:
diff changeset
   282
  jclass cls = (jclass) JNIHandles::make_local(env, klass->java_mirror());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   283
  jint result;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   284
489c9b5090e2 Initial load
duke
parents:
diff changeset
   285
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   286
    HandleMark hm(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   287
    ThreadToNativeFromVM ttn(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   288
    // ThreadToNativeFromVM takes care of changing thread_state, so safepoint
489c9b5090e2 Initial load
duke
parents:
diff changeset
   289
    // code knows that we have left the VM
489c9b5090e2 Initial load
duke
parents:
diff changeset
   290
489c9b5090e2 Initial load
duke
parents:
diff changeset
   291
    if (_is_new_verify_byte_codes_fn) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   292
      verify_byte_codes_fn_new_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   293
        CAST_TO_FN_PTR(verify_byte_codes_fn_new_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   294
      result = (*func)(env, cls, message, (int)message_len,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   295
          klass->major_version());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   296
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   297
      verify_byte_codes_fn_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   298
        CAST_TO_FN_PTR(verify_byte_codes_fn_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   299
      result = (*func)(env, cls, message, (int)message_len);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   300
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   301
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   302
489c9b5090e2 Initial load
duke
parents:
diff changeset
   303
  JNIHandles::destroy_local(cls);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   304
489c9b5090e2 Initial load
duke
parents:
diff changeset
   305
  // These numbers are chosen so that VerifyClassCodes interface doesn't need
489c9b5090e2 Initial load
duke
parents:
diff changeset
   306
  // to be changed (still return jboolean (unsigned char)), and result is
489c9b5090e2 Initial load
duke
parents:
diff changeset
   307
  // 1 when verification is passed.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   308
  if (result == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   309
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   310
  } else if (result == 1) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   311
    return NULL; // verified.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   312
  } else if (result == 2) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   313
    THROW_MSG_(vmSymbols::java_lang_OutOfMemoryError(), message, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   314
  } else if (result == 3) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   315
    return vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   316
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   317
    ShouldNotReachHere();
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   318
    return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   319
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   320
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   321
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   322
TypeOrigin TypeOrigin::null() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   323
  return TypeOrigin();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   324
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   325
TypeOrigin TypeOrigin::local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   326
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   327
  return TypeOrigin(CF_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   328
     frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   329
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   330
TypeOrigin TypeOrigin::stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   331
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   332
  return TypeOrigin(CF_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   333
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   334
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   335
TypeOrigin TypeOrigin::sm_local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   336
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   337
  return TypeOrigin(SM_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   338
      frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   339
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   340
TypeOrigin TypeOrigin::sm_stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   341
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   342
  return TypeOrigin(SM_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   343
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   344
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   345
TypeOrigin TypeOrigin::bad_index(u2 index) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   346
  return TypeOrigin(BAD_INDEX, index, NULL, VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   347
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   348
TypeOrigin TypeOrigin::cp(u2 index, VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   349
  return TypeOrigin(CONST_POOL, index, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   350
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   351
TypeOrigin TypeOrigin::signature(VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   352
  return TypeOrigin(SIG, 0, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   353
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   354
TypeOrigin TypeOrigin::implicit(VerificationType t) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   355
  return TypeOrigin(IMPLICIT, 0, NULL, t);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   356
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   357
TypeOrigin TypeOrigin::frame(StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   358
  return TypeOrigin(FRAME_ONLY, 0, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   359
                    VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   360
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   361
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   362
void TypeOrigin::reset_frame() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   363
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   364
    _frame->restore();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   365
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   366
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   367
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   368
void TypeOrigin::details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   369
  _type.print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   370
  switch (_origin) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   371
    case CF_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   372
      ss->print(" (current frame, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   373
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   374
    case CF_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   375
      ss->print(" (current frame, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   376
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   377
    case SM_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   378
      ss->print(" (stack map, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   379
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   380
    case SM_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   381
      ss->print(" (stack map, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   382
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   383
    case CONST_POOL:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   384
      ss->print(" (constant pool %d)", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   385
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   386
    case SIG:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   387
      ss->print(" (from method signature)");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   388
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   389
    case IMPLICIT:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   390
    case FRAME_ONLY:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   391
    case NONE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   392
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   393
      ;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   394
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   395
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   396
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   397
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   398
void TypeOrigin::print_on(outputStream* str) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   399
  str->print("{%d,%d,%p:", _origin, _index, _frame);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   400
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   401
    _frame->print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   402
  } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   403
    str->print("null");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   404
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   405
  str->print(",");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   406
  _type.print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   407
  str->print("}");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   408
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   409
#endif
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   410
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   411
void ErrorContext::details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   412
  if (is_valid()) {
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   413
    ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   414
    ss->print_cr("Exception Details:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   415
    location_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   416
    reason_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   417
    frame_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   418
    bytecode_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   419
    handler_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   420
    stackmap_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   421
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   422
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   423
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   424
void ErrorContext::reason_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   425
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   426
  ss->indent().print_cr("Reason:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   427
  streamIndentor si2(ss);
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   428
  ss->indent().print("%s", "");
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   429
  switch (_fault) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   430
    case INVALID_BYTECODE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   431
      ss->print("Error exists in the bytecode");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   432
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   433
    case WRONG_TYPE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   434
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   435
        ss->print("Type ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   436
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   437
        ss->print(" is not assignable to ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   438
        _expected.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   439
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   440
        ss->print("Invalid type: ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   441
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   442
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   443
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   444
    case FLAGS_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   445
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   446
        ss->print("Current frame's flags are not assignable "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   447
                  "to stack map frame's.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   448
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   449
        ss->print("Current frame's flags are invalid in this context.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   450
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   451
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   452
    case BAD_CP_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   453
      ss->print("Constant pool index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   454
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   455
    case BAD_LOCAL_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   456
      ss->print("Local index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   457
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   458
    case LOCALS_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   459
      ss->print("Current frame's local size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   460
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   461
    case STACK_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   462
      ss->print("Current frame's stack size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   463
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   464
    case STACK_OVERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   465
      ss->print("Exceeded max stack size.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   466
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   467
    case STACK_UNDERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   468
      ss->print("Attempt to pop empty stack.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   469
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   470
    case MISSING_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   471
      ss->print("Expected stackmap frame at this location.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   472
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   473
    case BAD_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   474
      ss->print("Invalid stackmap specification.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   475
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   476
    case UNKNOWN:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   477
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   478
      ShouldNotReachHere();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   479
      ss->print_cr("Unknown");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   480
  }
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   481
  ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   482
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   483
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   484
void ErrorContext::location_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   485
  if (_bci != -1 && method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   486
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   487
    const char* bytecode_name = "<invalid>";
25714
87fa6860b5ae 8004128: NPG: remove stackwalking in Threads::gc_prologue and gc_epilogue code
coleenp
parents: 24663
diff changeset
   488
    if (method->validate_bci(_bci) != -1) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   489
      Bytecodes::Code code = Bytecodes::code_or_bp_at(method->bcp_from(_bci));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   490
      if (Bytecodes::is_defined(code)) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   491
          bytecode_name = Bytecodes::name(code);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   492
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   493
          bytecode_name = "<illegal>";
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   494
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   495
    }
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
   496
    InstanceKlass* ik = method->method_holder();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   497
    ss->indent().print_cr("Location:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   498
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   499
    ss->indent().print_cr("%s.%s%s @%d: %s",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   500
        ik->name()->as_C_string(), method->name()->as_C_string(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   501
        method->signature()->as_C_string(), _bci, bytecode_name);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   502
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   503
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   504
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   505
void ErrorContext::frame_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   506
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   507
  if (_type.is_valid() && _type.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   508
    ss->indent().print_cr("Current Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   509
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   510
    _type.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   511
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   512
  if (_expected.is_valid() && _expected.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   513
    ss->indent().print_cr("Stackmap Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   514
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   515
    _expected.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   516
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   517
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   518
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   519
void ErrorContext::bytecode_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   520
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   521
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   522
    ss->indent().print_cr("Bytecode:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   523
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   524
    ss->print_data(method->code_base(), method->code_size(), false);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   525
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   526
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   527
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   528
void ErrorContext::handler_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   529
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   530
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   531
    ExceptionTable table(method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   532
    if (table.length() > 0) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   533
      ss->indent().print_cr("Exception Handler Table:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   534
      streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   535
      for (int i = 0; i < table.length(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   536
        ss->indent().print_cr("bci [%d, %d] => handler: %d", table.start_pc(i),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   537
            table.end_pc(i), table.handler_pc(i));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   538
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   539
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   540
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   541
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   542
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   543
void ErrorContext::stackmap_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   544
  if (method != NULL && method->has_stackmap_table()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   545
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   546
    ss->indent().print_cr("Stackmap Table:");
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   547
    Array<u1>* data = method->stackmap_data();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   548
    stack_map_table* sm_table =
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   549
        stack_map_table::at((address)data->adr_at(0));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   550
    stack_map_frame* sm_frame = sm_table->entries();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   551
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   552
    int current_offset = -1;
43178
6fb98b21d035 8161218: Better bytecode loading
hseigel
parents: 41542
diff changeset
   553
    address end_of_sm_table = (address)sm_table + method->stackmap_data()->length();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   554
    for (u2 i = 0; i < sm_table->number_of_entries(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   555
      ss->indent();
43178
6fb98b21d035 8161218: Better bytecode loading
hseigel
parents: 41542
diff changeset
   556
      if (!sm_frame->verify((address)sm_frame, end_of_sm_table)) {
41542
c705c10c4914 8159511: Stack map validation
hseigel
parents: 40923
diff changeset
   557
        sm_frame->print_truncated(ss, current_offset);
c705c10c4914 8159511: Stack map validation
hseigel
parents: 40923
diff changeset
   558
        return;
c705c10c4914 8159511: Stack map validation
hseigel
parents: 40923
diff changeset
   559
      }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   560
      sm_frame->print_on(ss, current_offset);
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   561
      ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   562
      current_offset += sm_frame->offset_delta();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   563
      sm_frame = sm_frame->next();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   564
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   565
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   566
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   567
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   568
// Methods in ClassVerifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
   569
489c9b5090e2 Initial load
duke
parents:
diff changeset
   570
ClassVerifier::ClassVerifier(
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
   571
    InstanceKlass* klass, TRAPS)
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   572
    : _thread(THREAD), _exception_type(NULL), _message(NULL), _klass(klass) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   573
  _this_type = VerificationType::reference_type(klass->name());
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   574
  // Create list to hold symbols in reference area.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   575
  _symbols = new GrowableArray<Symbol*>(100, 0, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   576
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   577
489c9b5090e2 Initial load
duke
parents:
diff changeset
   578
ClassVerifier::~ClassVerifier() {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   579
  // Decrement the reference count for any symbols created.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   580
  for (int i = 0; i < _symbols->length(); i++) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   581
    Symbol* s = _symbols->at(i);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   582
    s->decrement_refcount();
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   583
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   584
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   585
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   586
VerificationType ClassVerifier::object_type() const {
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   587
  return VerificationType::reference_type(vmSymbols::java_lang_Object());
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   588
}
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   589
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   590
TypeOrigin ClassVerifier::ref_ctx(const char* sig, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   591
  VerificationType vt = VerificationType::reference_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   592
      create_temporary_symbol(sig, (int)strlen(sig), THREAD));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   593
  return TypeOrigin::implicit(vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   594
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   595
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   596
void ClassVerifier::verify_class(TRAPS) {
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
   597
  log_info(verification)("Verifying class %s with new format", _klass->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   598
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   599
  Array<Method*>* methods = _klass->methods();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   600
  int num_methods = methods->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   601
489c9b5090e2 Initial load
duke
parents:
diff changeset
   602
  for (int index = 0; index < num_methods; index++) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   603
    // Check for recursive re-verification before each method.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   604
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   605
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   606
    Method* m = methods->at(index);
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   607
    if (m->is_native() || m->is_abstract() || m->is_overpass()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   608
      // If m is native or abstract, skip it.  It is checked in class file
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   609
      // parser that methods do not override a final method.  Overpass methods
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   610
      // are trusted since the VM generates them.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   611
      continue;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   612
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   613
    verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   614
  }
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   615
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   616
  if (was_recursively_verified()){
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
   617
    log_info(verification)("Recursive verification detected for: %s", _klass->external_name());
38151
fffedc5e5cf8 8154110: Update class* and safepoint* logging subsystems
mockner
parents: 37301
diff changeset
   618
    log_info(class, init)("Recursive verification detected for: %s",
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   619
                        _klass->external_name());
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   620
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   621
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   622
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
   623
void ClassVerifier::verify_method(const methodHandle& m, TRAPS) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   624
  HandleMark hm(THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   625
  _method = m;   // initialize _method
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
   626
  log_info(verification)("Verifying method %s", m->name_and_sig_as_C_string());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   627
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   628
// For clang, the only good constant format string is a literal constant format string.
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   629
#define bad_type_msg "Bad type on operand stack in %s"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   630
13396
1b2b5f740ee0 7188911: nightly failures after JSR 292 lazy method handle update (round 2)
twisti
parents: 13283
diff changeset
   631
  int32_t max_stack = m->verifier_max_stack();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   632
  int32_t max_locals = m->max_locals();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   633
  constantPoolHandle cp(THREAD, m->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   634
489c9b5090e2 Initial load
duke
parents:
diff changeset
   635
  if (!SignatureVerifier::is_valid_method_signature(m->signature())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   636
    class_format_error("Invalid method signature");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   637
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   638
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   639
489c9b5090e2 Initial load
duke
parents:
diff changeset
   640
  // Initial stack map frame: offset is 0, stack is initially empty.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   641
  StackMapFrame current_frame(max_locals, max_stack, this);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   642
  // Set initial locals
489c9b5090e2 Initial load
duke
parents:
diff changeset
   643
  VerificationType return_type = current_frame.set_locals_from_arg(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   644
    m, current_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   645
489c9b5090e2 Initial load
duke
parents:
diff changeset
   646
  int32_t stackmap_index = 0; // index to the stackmap array
489c9b5090e2 Initial load
duke
parents:
diff changeset
   647
489c9b5090e2 Initial load
duke
parents:
diff changeset
   648
  u4 code_length = m->code_size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   649
489c9b5090e2 Initial load
duke
parents:
diff changeset
   650
  // Scan the bytecode and map each instruction's start offset to a number.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   651
  char* code_data = generate_code_data(m, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   652
489c9b5090e2 Initial load
duke
parents:
diff changeset
   653
  int ex_min = code_length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   654
  int ex_max = -1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   655
  // Look through each item on the exception table. Each of the fields must refer
489c9b5090e2 Initial load
duke
parents:
diff changeset
   656
  // to a legal instruction.
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   657
  if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   658
  verify_exception_handler_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   659
    code_length, code_data, ex_min, ex_max, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   660
489c9b5090e2 Initial load
duke
parents:
diff changeset
   661
  // Look through each entry on the local variable table and make sure
489c9b5090e2 Initial load
duke
parents:
diff changeset
   662
  // its range of code array offsets is valid. (4169817)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   663
  if (m->has_localvariable_table()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   664
    verify_local_variable_table(code_length, code_data, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   665
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   666
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   667
  Array<u1>* stackmap_data = m->stackmap_data();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   668
  StackMapStream stream(stackmap_data);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   669
  StackMapReader reader(this, &stream, code_data, code_length, THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   670
  StackMapTable stackmap_table(&reader, &current_frame, max_locals, max_stack,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   671
                               code_data, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   672
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   673
  LogTarget(Info, verification) lt;
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   674
  if (lt.is_enabled()) {
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   675
    ResourceMark rm(THREAD);
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   676
    LogStream ls(lt);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   677
    stackmap_table.print_on(&ls);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   678
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   679
489c9b5090e2 Initial load
duke
parents:
diff changeset
   680
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   681
489c9b5090e2 Initial load
duke
parents:
diff changeset
   682
  // Scan the byte code linearly from the start to the end
489c9b5090e2 Initial load
duke
parents:
diff changeset
   683
  bool no_control_flow = false; // Set to true when there is no direct control
489c9b5090e2 Initial load
duke
parents:
diff changeset
   684
                                // flow from current instruction to the next
489c9b5090e2 Initial load
duke
parents:
diff changeset
   685
                                // instruction in sequence
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
   686
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   687
  Bytecodes::Code opcode;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   688
  while (!bcs.is_last_bytecode()) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   689
    // Check for recursive re-verification before each bytecode.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   690
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   691
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   692
    opcode = bcs.raw_next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   693
    u2 bci = bcs.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   694
489c9b5090e2 Initial load
duke
parents:
diff changeset
   695
    // Set current frame's offset to bci
489c9b5090e2 Initial load
duke
parents:
diff changeset
   696
    current_frame.set_offset(bci);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   697
    current_frame.set_mark();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   698
489c9b5090e2 Initial load
duke
parents:
diff changeset
   699
    // Make sure every offset in stackmap table point to the beginning to
489c9b5090e2 Initial load
duke
parents:
diff changeset
   700
    // an instruction. Match current_frame to stackmap_table entry with
489c9b5090e2 Initial load
duke
parents:
diff changeset
   701
    // the same offset if exists.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   702
    stackmap_index = verify_stackmap_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   703
      stackmap_index, bci, &current_frame, &stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   704
      no_control_flow, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   705
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   706
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   707
    bool this_uninit = false;  // Set to true when invokespecial <init> initialized 'this'
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   708
    bool verified_exc_handlers = false;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   709
489c9b5090e2 Initial load
duke
parents:
diff changeset
   710
    // Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
   711
    {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   712
      u2 index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   713
      int target;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   714
      VerificationType type, type2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   715
      VerificationType atype;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   716
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   717
      LogTarget(Info, verification) lt;
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   718
      if (lt.is_enabled()) {
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   719
        ResourceMark rm(THREAD);
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   720
        LogStream ls(lt);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46625
diff changeset
   721
        current_frame.print_on(&ls);
51070
2f4c3cac8556 8206977: Minor improvements of runtime code.
goetz
parents: 50429
diff changeset
   722
        lt.print("offset = %d,  opcode = %s", bci,
2f4c3cac8556 8206977: Minor improvements of runtime code.
goetz
parents: 50429
diff changeset
   723
                 opcode == Bytecodes::_illegal ? "illegal" : Bytecodes::name(opcode));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   724
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   725
489c9b5090e2 Initial load
duke
parents:
diff changeset
   726
      // Make sure wide instruction is in correct format
489c9b5090e2 Initial load
duke
parents:
diff changeset
   727
      if (bcs.is_wide()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   728
        if (opcode != Bytecodes::_iinc   && opcode != Bytecodes::_iload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   729
            opcode != Bytecodes::_aload  && opcode != Bytecodes::_lload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   730
            opcode != Bytecodes::_istore && opcode != Bytecodes::_astore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   731
            opcode != Bytecodes::_lstore && opcode != Bytecodes::_fload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   732
            opcode != Bytecodes::_dload  && opcode != Bytecodes::_fstore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   733
            opcode != Bytecodes::_dstore) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   734
          /* Unreachable?  RawBytecodeStream's raw_next() returns 'illegal'
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   735
           * if we encounter a wide instruction that modifies an invalid
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   736
           * opcode (not one of the ones listed above) */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   737
          verify_error(ErrorContext::bad_code(bci), "Bad wide instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   738
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   739
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   740
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   741
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   742
      // Look for possible jump target in exception handlers and see if it
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   743
      // matches current_frame.  Do this check here for astore*, dstore*,
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   744
      // fstore*, istore*, and lstore* opcodes because they can change the type
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   745
      // state by adding a local.  JVM Spec says that the incoming type state
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   746
      // should be used for this check.  So, do the check here before a possible
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   747
      // local is added to the type state.
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   748
      if (Bytecodes::is_store_into_local(opcode) && bci >= ex_min && bci < ex_max) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   749
        if (was_recursively_verified()) return;
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   750
        verify_exception_handler_targets(
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   751
          bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   752
        verified_exc_handlers = true;
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   753
      }
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   754
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   755
      if (was_recursively_verified()) return;
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   756
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   757
      switch (opcode) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   758
        case Bytecodes::_nop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   759
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   760
        case Bytecodes::_aconst_null :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   761
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   762
            VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   763
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   764
        case Bytecodes::_iconst_m1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   765
        case Bytecodes::_iconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   766
        case Bytecodes::_iconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   767
        case Bytecodes::_iconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   768
        case Bytecodes::_iconst_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   769
        case Bytecodes::_iconst_4 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   770
        case Bytecodes::_iconst_5 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   771
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   772
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   773
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   774
        case Bytecodes::_lconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   775
        case Bytecodes::_lconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   776
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   777
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   778
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   779
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   780
        case Bytecodes::_fconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   781
        case Bytecodes::_fconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   782
        case Bytecodes::_fconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   783
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   784
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   785
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   786
        case Bytecodes::_dconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   787
        case Bytecodes::_dconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   788
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   789
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   790
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   791
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   792
        case Bytecodes::_sipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   793
        case Bytecodes::_bipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   794
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   795
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   796
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   797
        case Bytecodes::_ldc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   798
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   799
            opcode, bcs.get_index_u1(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   800
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   801
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   802
        case Bytecodes::_ldc_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   803
        case Bytecodes::_ldc2_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   804
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   805
            opcode, bcs.get_index_u2(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   806
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   807
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   808
        case Bytecodes::_iload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   809
          verify_iload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   810
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   811
        case Bytecodes::_iload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   812
        case Bytecodes::_iload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   813
        case Bytecodes::_iload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   814
        case Bytecodes::_iload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   815
          index = opcode - Bytecodes::_iload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   816
          verify_iload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   817
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   818
        case Bytecodes::_lload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   819
          verify_lload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   820
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   821
        case Bytecodes::_lload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   822
        case Bytecodes::_lload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   823
        case Bytecodes::_lload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   824
        case Bytecodes::_lload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   825
          index = opcode - Bytecodes::_lload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   826
          verify_lload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   827
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   828
        case Bytecodes::_fload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   829
          verify_fload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   830
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   831
        case Bytecodes::_fload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   832
        case Bytecodes::_fload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   833
        case Bytecodes::_fload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   834
        case Bytecodes::_fload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   835
          index = opcode - Bytecodes::_fload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   836
          verify_fload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   837
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   838
        case Bytecodes::_dload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   839
          verify_dload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   840
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   841
        case Bytecodes::_dload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   842
        case Bytecodes::_dload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   843
        case Bytecodes::_dload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   844
        case Bytecodes::_dload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   845
          index = opcode - Bytecodes::_dload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   846
          verify_dload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   847
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   848
        case Bytecodes::_aload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   849
          verify_aload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   850
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   851
        case Bytecodes::_aload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   852
        case Bytecodes::_aload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   853
        case Bytecodes::_aload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   854
        case Bytecodes::_aload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   855
          index = opcode - Bytecodes::_aload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   856
          verify_aload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   857
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   858
        case Bytecodes::_iaload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   859
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   860
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   861
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   862
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   863
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   864
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   865
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   866
                bad_type_msg, "iaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   867
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   868
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   869
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   870
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   871
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   872
        case Bytecodes::_baload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   873
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   874
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   875
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   876
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   877
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   878
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   879
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   880
                bad_type_msg, "baload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   881
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   882
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   883
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   884
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   885
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   886
        case Bytecodes::_caload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   887
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   888
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   889
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   890
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   891
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   892
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   893
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   894
                bad_type_msg, "caload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   895
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   896
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   897
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   898
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   899
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   900
        case Bytecodes::_saload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   901
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   902
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   903
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   904
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   905
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   906
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   907
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   908
                bad_type_msg, "saload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   909
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   910
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   911
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   912
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   913
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   914
        case Bytecodes::_laload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   915
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   916
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   917
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   918
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   919
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   920
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   921
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   922
                bad_type_msg, "laload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   923
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   924
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   925
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   926
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   927
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   928
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   929
        case Bytecodes::_faload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   930
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   931
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   932
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   933
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   934
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   935
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   936
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   937
                bad_type_msg, "faload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   938
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   939
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   940
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   941
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   942
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   943
        case Bytecodes::_daload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   944
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   945
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   946
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   947
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   948
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   949
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   950
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   951
                bad_type_msg, "daload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   952
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   953
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   954
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   955
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   956
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   957
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   958
        case Bytecodes::_aaload : {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   959
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   960
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   961
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   962
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   963
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   964
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   965
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   966
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   967
                bad_type_msg, "aaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   968
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   969
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   970
          if (atype.is_null()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   971
            current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   972
              VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   973
          } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   974
            VerificationType component =
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   975
              atype.get_component(this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   976
            current_frame.push_stack(component, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   977
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   978
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   979
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   980
        case Bytecodes::_istore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   981
          verify_istore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   982
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   983
        case Bytecodes::_istore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   984
        case Bytecodes::_istore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   985
        case Bytecodes::_istore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   986
        case Bytecodes::_istore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   987
          index = opcode - Bytecodes::_istore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   988
          verify_istore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   989
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   990
        case Bytecodes::_lstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   991
          verify_lstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   992
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   993
        case Bytecodes::_lstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   994
        case Bytecodes::_lstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   995
        case Bytecodes::_lstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   996
        case Bytecodes::_lstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   997
          index = opcode - Bytecodes::_lstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   998
          verify_lstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   999
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1000
        case Bytecodes::_fstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1001
          verify_fstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1002
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1003
        case Bytecodes::_fstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1004
        case Bytecodes::_fstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1005
        case Bytecodes::_fstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1006
        case Bytecodes::_fstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1007
          index = opcode - Bytecodes::_fstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1008
          verify_fstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1009
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1010
        case Bytecodes::_dstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1011
          verify_dstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1012
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1013
        case Bytecodes::_dstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1014
        case Bytecodes::_dstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1015
        case Bytecodes::_dstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1016
        case Bytecodes::_dstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1017
          index = opcode - Bytecodes::_dstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1018
          verify_dstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1019
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1020
        case Bytecodes::_astore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1021
          verify_astore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1022
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1023
        case Bytecodes::_astore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1024
        case Bytecodes::_astore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1025
        case Bytecodes::_astore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1026
        case Bytecodes::_astore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1027
          index = opcode - Bytecodes::_astore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1028
          verify_astore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1029
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1030
        case Bytecodes::_iastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1031
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1032
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1033
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1034
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1035
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1036
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1037
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1038
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1039
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1040
                bad_type_msg, "iastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1041
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1042
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1043
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1044
        case Bytecodes::_bastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1045
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1046
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1047
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1048
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1049
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1050
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1051
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1052
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1053
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1054
                bad_type_msg, "bastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1055
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1056
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1057
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1058
        case Bytecodes::_castore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1059
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1060
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1061
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1062
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1063
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1064
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1065
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1066
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1067
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1068
                bad_type_msg, "castore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1069
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1070
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1071
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1072
        case Bytecodes::_sastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1073
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1074
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1075
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1076
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1077
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1078
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1079
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1080
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1081
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1082
                bad_type_msg, "sastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1083
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1084
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1085
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1086
        case Bytecodes::_lastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1087
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1088
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1089
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1090
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1091
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1092
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1093
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1094
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1095
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1096
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1097
                bad_type_msg, "lastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1098
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1099
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1100
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1101
        case Bytecodes::_fastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1102
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1103
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1104
          current_frame.pop_stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1105
            (VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1106
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1107
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1108
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1109
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1110
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1111
                bad_type_msg, "fastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1112
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1113
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1114
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1115
        case Bytecodes::_dastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1116
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1117
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1118
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1119
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1120
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1121
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1122
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1123
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1124
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1125
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1126
                bad_type_msg, "dastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1127
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1128
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1129
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1130
        case Bytecodes::_aastore :
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1131
          type = current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1132
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1133
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1134
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1135
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1136
          // more type-checking is done at runtime
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1137
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1138
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1139
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1140
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1141
                bad_type_msg, "aastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1142
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1143
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1144
          // 4938384: relaxed constraint in JVMS 3nd edition.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1145
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1146
        case Bytecodes::_pop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1147
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1148
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1149
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1150
        case Bytecodes::_pop2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1151
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1152
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1153
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1154
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1155
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1156
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1157
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1158
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1159
            /* Unreachable? Would need a category2_1st on TOS
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1160
             * which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1161
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1162
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1163
                bad_type_msg, "pop2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1164
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1165
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1166
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1167
        case Bytecodes::_dup :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1168
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1169
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1170
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1171
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1172
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1173
        case Bytecodes::_dup_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1174
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1175
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1176
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1177
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1178
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1179
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1180
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1181
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1182
        case Bytecodes::_dup_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1183
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1184
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1185
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1186
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1187
          type2 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1188
          if (type2.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1189
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1190
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1191
          } else if (type2.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1192
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1193
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1194
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1195
            /* Unreachable? Would need a category2_1st at stack depth 2 with
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1196
             * a category1 on TOS which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1197
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1198
                bci, current_frame.stack_top_ctx()), bad_type_msg, "dup_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1199
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1200
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1201
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1202
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1203
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1204
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1205
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1206
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1207
        case Bytecodes::_dup2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1208
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1209
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1210
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1211
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1212
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1213
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1214
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1215
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1216
            /* Unreachable?  Would need a category2_1st on TOS which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1217
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1218
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1219
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1220
                bad_type_msg, "dup2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1221
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1222
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1223
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1224
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1225
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1226
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1227
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1228
        case Bytecodes::_dup2_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1229
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1230
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1231
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1232
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1233
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1234
              VerificationType::category1_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1235
          } else if (type.is_category2_2nd()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1236
            type2 = current_frame.pop_stack(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1237
              VerificationType::category2_check(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1238
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1239
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1240
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1241
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1242
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1243
                bad_type_msg, "dup2_x1");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1244
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1245
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1246
          type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1247
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1248
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1249
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1250
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1251
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1252
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1253
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1254
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1255
        case Bytecodes::_dup2_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1256
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1257
          VerificationType type3, type4;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1258
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1259
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1260
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1261
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1262
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1263
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1264
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1265
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1266
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1267
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1268
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1269
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1270
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1271
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1272
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1273
          type3 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1274
          if (type3.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1275
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1276
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1277
          } else if (type3.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1278
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1279
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1280
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1281
            /* Unreachable?  Would need a category2_1st on TOS after popping
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1282
             * a long/double or two category 1's, which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1283
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1284
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1285
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1286
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1287
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1288
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1289
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1290
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1291
          current_frame.push_stack(type4, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1292
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1293
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1294
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1295
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1296
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1297
        case Bytecodes::_swap :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1298
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1299
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1300
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1301
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1302
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1303
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1304
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1305
        case Bytecodes::_iadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1306
        case Bytecodes::_isub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1307
        case Bytecodes::_imul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1308
        case Bytecodes::_idiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1309
        case Bytecodes::_irem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1310
        case Bytecodes::_ishl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1311
        case Bytecodes::_ishr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1312
        case Bytecodes::_iushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1313
        case Bytecodes::_ior :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1314
        case Bytecodes::_ixor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1315
        case Bytecodes::_iand :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1316
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1317
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1318
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1319
        case Bytecodes::_ineg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1320
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1321
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1322
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1323
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1324
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1325
        case Bytecodes::_ladd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1326
        case Bytecodes::_lsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1327
        case Bytecodes::_lmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1328
        case Bytecodes::_ldiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1329
        case Bytecodes::_lrem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1330
        case Bytecodes::_land :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1331
        case Bytecodes::_lor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1332
        case Bytecodes::_lxor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1333
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1334
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1335
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1336
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1337
        case Bytecodes::_lneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1338
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1339
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1340
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1341
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1342
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1343
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1344
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1345
        case Bytecodes::_lshl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1346
        case Bytecodes::_lshr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1347
        case Bytecodes::_lushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1348
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1349
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1350
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1351
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1352
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1353
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1354
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1355
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1356
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1357
        case Bytecodes::_fadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1358
        case Bytecodes::_fsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1359
        case Bytecodes::_fmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1360
        case Bytecodes::_fdiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1361
        case Bytecodes::_frem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1362
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1363
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1364
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1365
        case Bytecodes::_fneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1366
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1367
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1368
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1369
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1370
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1371
        case Bytecodes::_dadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1372
        case Bytecodes::_dsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1373
        case Bytecodes::_dmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1374
        case Bytecodes::_ddiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1375
        case Bytecodes::_drem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1376
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1377
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1378
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1379
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1380
        case Bytecodes::_dneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1381
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1382
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1383
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1384
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1385
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1386
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1387
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1388
        case Bytecodes::_iinc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1389
          verify_iinc(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1390
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1391
        case Bytecodes::_i2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1392
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1393
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1394
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1395
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1396
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1397
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1398
       case Bytecodes::_l2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1399
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1400
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1401
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1402
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1403
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1404
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1405
        case Bytecodes::_i2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1406
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1407
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1408
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1409
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1410
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1411
        case Bytecodes::_i2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1412
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1413
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1414
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1415
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1416
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1417
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1418
        case Bytecodes::_l2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1419
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1420
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1421
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1422
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1423
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1424
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1425
        case Bytecodes::_l2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1426
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1427
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1428
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1429
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1430
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1431
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1432
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1433
        case Bytecodes::_f2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1434
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1435
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1436
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1437
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1438
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1439
        case Bytecodes::_f2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1440
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1441
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1442
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1443
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1444
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1445
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1446
        case Bytecodes::_f2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1447
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1448
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1449
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1450
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1451
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1452
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1453
        case Bytecodes::_d2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1454
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1455
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1456
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1457
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1458
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1459
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1460
        case Bytecodes::_d2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1461
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1462
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1463
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1464
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1465
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1466
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1467
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1468
        case Bytecodes::_d2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1469
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1470
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1471
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1472
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1473
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1474
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1475
        case Bytecodes::_i2b :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1476
        case Bytecodes::_i2c :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1477
        case Bytecodes::_i2s :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1478
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1479
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1480
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1481
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1482
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1483
        case Bytecodes::_lcmp :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1484
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1485
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1486
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1487
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1488
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1489
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1490
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1491
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1492
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1493
        case Bytecodes::_fcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1494
        case Bytecodes::_fcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1495
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1496
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1497
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1498
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1499
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1500
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1501
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1502
        case Bytecodes::_dcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1503
        case Bytecodes::_dcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1504
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1505
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1506
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1507
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1508
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1509
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1510
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1511
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1512
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1513
        case Bytecodes::_if_icmpeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1514
        case Bytecodes::_if_icmpne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1515
        case Bytecodes::_if_icmplt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1516
        case Bytecodes::_if_icmpge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1517
        case Bytecodes::_if_icmpgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1518
        case Bytecodes::_if_icmple:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1519
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1520
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1521
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1522
        case Bytecodes::_ifeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1523
        case Bytecodes::_ifne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1524
        case Bytecodes::_iflt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1525
        case Bytecodes::_ifge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1526
        case Bytecodes::_ifgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1527
        case Bytecodes::_ifle:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1528
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1529
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1530
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1531
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1532
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1533
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1534
        case Bytecodes::_if_acmpeq :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1535
        case Bytecodes::_if_acmpne :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1536
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1537
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1538
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1539
        case Bytecodes::_ifnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1540
        case Bytecodes::_ifnonnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1541
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1542
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1543
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1544
          stackmap_table.check_jump_target
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1545
            (&current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1546
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1547
        case Bytecodes::_goto :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1548
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1549
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1550
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1551
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1552
        case Bytecodes::_goto_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1553
          target = bcs.dest_w();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1554
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1555
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1556
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1557
        case Bytecodes::_tableswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1558
        case Bytecodes::_lookupswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1559
          verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1560
            &bcs, code_length, code_data, &current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1561
            &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1562
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1563
        case Bytecodes::_ireturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1564
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1565
            VerificationType::integer_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1566
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1567
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1568
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1569
        case Bytecodes::_lreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1570
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1571
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1572
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1573
            VerificationType::long_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1574
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1575
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1576
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1577
        case Bytecodes::_freturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1578
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1579
            VerificationType::float_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1580
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1581
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1582
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1583
        case Bytecodes::_dreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1584
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1585
            VerificationType::double2_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1586
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1587
            VerificationType::double_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1588
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1589
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1590
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1591
        case Bytecodes::_areturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1592
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1593
            VerificationType::reference_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1594
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1595
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1596
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1597
        case Bytecodes::_return :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1598
          if (return_type != VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1599
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1600
                         "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1601
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1602
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1603
          // Make sure "this" has been initialized if current method is an
33207
edc4431940b2 8139069: JVM should throw ClassFormatError for <init> methods in interfaces
hseigel
parents: 32825
diff changeset
  1604
          // <init>.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1605
          if (_method->name() == vmSymbols::object_initializer_name() &&
33207
edc4431940b2 8139069: JVM should throw ClassFormatError for <init> methods in interfaces
hseigel
parents: 32825
diff changeset
  1606
              current_frame.flag_this_uninit()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1607
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1608
                         "Constructor must call super() or this() "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1609
                         "before return");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1610
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1611
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1612
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1613
        case Bytecodes::_getstatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1614
        case Bytecodes::_putstatic :
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1615
          // pass TRUE, operand can be an array type for getstatic/putstatic.
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1616
          verify_field_instructions(
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1617
            &bcs, &current_frame, cp, true, CHECK_VERIFY(this));
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1618
          no_control_flow = false; break;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1619
        case Bytecodes::_getfield :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1620
        case Bytecodes::_putfield :
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1621
          // pass FALSE, operand can't be an array type for getfield/putfield.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1622
          verify_field_instructions(
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1623
            &bcs, &current_frame, cp, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1624
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1625
        case Bytecodes::_invokevirtual :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1626
        case Bytecodes::_invokespecial :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1627
        case Bytecodes::_invokestatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1628
          verify_invoke_instructions(
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1629
            &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1630
            &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1631
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1632
        case Bytecodes::_invokeinterface :
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  1633
        case Bytecodes::_invokedynamic :
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1634
          verify_invoke_instructions(
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1635
            &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1636
            &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1637
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1638
        case Bytecodes::_new :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1639
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1640
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1641
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1642
          VerificationType new_class_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1643
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1644
          if (!new_class_type.is_object()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1645
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1646
                TypeOrigin::cp(index, new_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1647
                "Illegal new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1648
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1649
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1650
          type = VerificationType::uninitialized_type(bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1651
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1652
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1653
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1654
        case Bytecodes::_newarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1655
          type = get_newarray_type(bcs.get_index(), bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1656
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1657
            VerificationType::integer_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1658
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1659
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1660
        case Bytecodes::_anewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1661
          verify_anewarray(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1662
            bci, bcs.get_index_u2(), cp, &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1663
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1664
        case Bytecodes::_arraylength :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1665
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1666
            VerificationType::reference_check(), CHECK_VERIFY(this));
381
e7275780f686 6692246: Regression : JDK 6u4 b01 fails two JCK tests when fallback is switched off
kamg
parents: 1
diff changeset
  1667
          if (!(type.is_null() || type.is_array())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1668
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1669
                bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1670
                bad_type_msg, "arraylength");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1671
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1672
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1673
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1674
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1675
        case Bytecodes::_checkcast :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1676
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1677
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1678
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1679
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1680
          VerificationType klass_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1681
            index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1682
          current_frame.push_stack(klass_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1683
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1684
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1685
        case Bytecodes::_instanceof : {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1686
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1687
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1688
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1689
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1690
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1691
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1692
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1693
        case Bytecodes::_monitorenter :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1694
        case Bytecodes::_monitorexit :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1695
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1696
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1697
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1698
        case Bytecodes::_multianewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1699
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1700
          index = bcs.get_index_u2();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1701
          u2 dim = *(bcs.bcp()+3);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1702
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1703
          VerificationType new_array_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1704
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1705
          if (!new_array_type.is_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1706
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1707
                TypeOrigin::cp(index, new_array_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1708
                "Illegal constant pool index in multianewarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1709
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1710
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1711
          if (dim < 1 || new_array_type.dimensions() < dim) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1712
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1713
                "Illegal dimension in multianewarray instruction: %d", dim);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1714
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1715
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1716
          for (int i = 0; i < dim; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1717
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1718
              VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1719
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1720
          current_frame.push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1721
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1722
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1723
        case Bytecodes::_athrow :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1724
          type = VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1725
            vmSymbols::java_lang_Throwable());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1726
          current_frame.pop_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1727
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1728
        default:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1729
          // We only need to check the valid bytecodes in class file.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1730
          // And jsr and ret are not in the new class file format in JDK1.5.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1731
          verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1732
              "Bad instruction: %02x", opcode);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1733
          no_control_flow = false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1734
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1735
      }  // end switch
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1736
    }  // end Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1737
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1738
    // Look for possible jump target in exception handlers and see if it matches
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1739
    // current_frame.  Don't do this check if it has already been done (for
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1740
    // ([a,d,f,i,l]store* opcodes).  This check cannot be done earlier because
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1741
    // opcodes, such as invokespecial, may set the this_uninit flag.
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1742
    assert(!(verified_exc_handlers && this_uninit),
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1743
      "Exception handler targets got verified before this_uninit got set");
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1744
    if (!verified_exc_handlers && bci >= ex_min && bci < ex_max) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1745
      if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1746
      verify_exception_handler_targets(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1747
        bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1748
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1749
  } // end while
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1750
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1751
  // Make sure that control flow does not fall through end of the method
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1752
  if (!no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1753
    verify_error(ErrorContext::bad_code(code_length),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1754
        "Control flow falls through code end");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1755
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1756
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1757
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1758
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  1759
#undef bad_type_message
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  1760
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1761
char* ClassVerifier::generate_code_data(const methodHandle& m, u4 code_length, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1762
  char* code_data = NEW_RESOURCE_ARRAY(char, code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1763
  memset(code_data, 0, sizeof(char) * code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1764
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1765
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1766
  while (!bcs.is_last_bytecode()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1767
    if (bcs.raw_next() != Bytecodes::_illegal) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1768
      int bci = bcs.bci();
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1769
      if (bcs.raw_code() == Bytecodes::_new) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1770
        code_data[bci] = NEW_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1771
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1772
        code_data[bci] = BYTECODE_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1773
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1774
    } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1775
      verify_error(ErrorContext::bad_code(bcs.bci()), "Bad instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1776
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1777
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1778
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1779
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1780
  return code_data;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1781
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1782
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1783
// Since this method references the constant pool, call was_recursively_verified()
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1784
// before calling this method to make sure a prior class load did not cause the
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1785
// current class to get verified.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1786
void ClassVerifier::verify_exception_handler_table(u4 code_length, char* code_data, int& min, int& max, TRAPS) {
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1787
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1788
  int exlength = exhandlers.length();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1789
  constantPoolHandle cp (THREAD, _method->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1790
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1791
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1792
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1793
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1794
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1795
    if (start_pc >= code_length || code_data[start_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1796
      class_format_error("Illegal exception table start_pc %d", start_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1797
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1798
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1799
    if (end_pc != code_length) {   // special case: end_pc == code_length
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1800
      if (end_pc > code_length || code_data[end_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1801
        class_format_error("Illegal exception table end_pc %d", end_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1802
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1803
      }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1804
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1805
    if (handler_pc >= code_length || code_data[handler_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1806
      class_format_error("Illegal exception table handler_pc %d", handler_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1807
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1808
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1809
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1810
    if (catch_type_index != 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1811
      VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1812
        catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1813
      VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1814
        VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1815
      bool is_subclass = throwable.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  1816
        catch_type, this, false, CHECK_VERIFY(this));
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1817
      if (!is_subclass) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1818
        // 4286534: should throw VerifyError according to recent spec change
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1819
        verify_error(ErrorContext::bad_type(handler_pc,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1820
            TypeOrigin::cp(catch_type_index, catch_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1821
            TypeOrigin::implicit(throwable)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1822
            "Catch type is not a subclass "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1823
            "of Throwable in exception handler %d", handler_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1824
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1825
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1826
    }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1827
    if (start_pc < min) min = start_pc;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1828
    if (end_pc > max) max = end_pc;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1829
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1830
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1831
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1832
void ClassVerifier::verify_local_variable_table(u4 code_length, char* code_data, TRAPS) {
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1833
  int localvariable_table_length = _method->localvariable_table_length();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1834
  if (localvariable_table_length > 0) {
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1835
    LocalVariableTableElement* table = _method->localvariable_table_start();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1836
    for (int i = 0; i < localvariable_table_length; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1837
      u2 start_bci = table[i].start_bci;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1838
      u2 length = table[i].length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1839
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1840
      if (start_bci >= code_length || code_data[start_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1841
        class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1842
          "Illegal local variable table start_pc %d", start_bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1843
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1844
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1845
      u4 end_bci = (u4)(start_bci + length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1846
      if (end_bci != code_length) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1847
        if (end_bci >= code_length || code_data[end_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1848
          class_format_error( "Illegal local variable table length %d", length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1849
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1850
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1851
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1852
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1853
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1854
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1855
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1856
u2 ClassVerifier::verify_stackmap_table(u2 stackmap_index, u2 bci,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1857
                                        StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1858
                                        StackMapTable* stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1859
                                        bool no_control_flow, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1860
  if (stackmap_index < stackmap_table->get_frame_count()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1861
    u2 this_offset = stackmap_table->get_offset(stackmap_index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1862
    if (no_control_flow && this_offset > bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1863
      verify_error(ErrorContext::missing_stackmap(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1864
                   "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1865
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1866
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1867
    if (this_offset == bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1868
      ErrorContext ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1869
      // See if current stack map can be assigned to the frame in table.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1870
      // current_frame is the stackmap frame got from the last instruction.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1871
      // If matched, current_frame will be updated by this method.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1872
      bool matches = stackmap_table->match_stackmap(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1873
        current_frame, this_offset, stackmap_index,
43179
06ccf3bfd0a3 8167104: Additional class construction refinements
hseigel
parents: 43178
diff changeset
  1874
        !no_control_flow, true, &ctx, CHECK_VERIFY_(this, 0));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1875
      if (!matches) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1876
        // report type error
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1877
        verify_error(ctx, "Instruction type does not match stack map");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1878
        return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1879
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1880
      stackmap_index++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1881
    } else if (this_offset < bci) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1882
      // current_offset should have met this_offset.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1883
      class_format_error("Bad stack map offset %d", this_offset);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1884
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1885
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1886
  } else if (no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1887
    verify_error(ErrorContext::bad_code(bci), "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1888
    return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1889
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1890
  return stackmap_index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1891
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1892
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1893
// Since this method references the constant pool, call was_recursively_verified()
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1894
// before calling this method to make sure a prior class load did not cause the
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1895
// current class to get verified.
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1896
void ClassVerifier::verify_exception_handler_targets(u2 bci, bool this_uninit,
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1897
                                                     StackMapFrame* current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1898
                                                     StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1899
  constantPoolHandle cp (THREAD, _method->constants());
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1900
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1901
  int exlength = exhandlers.length();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1902
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1903
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1904
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1905
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1906
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1907
    if(bci >= start_pc && bci < end_pc) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1908
      u1 flags = current_frame->flags();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1909
      if (this_uninit) {  flags |= FLAG_THIS_UNINIT; }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1910
      StackMapFrame* new_frame = current_frame->frame_in_exception_handler(flags);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1911
      if (catch_type_index != 0) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1912
        if (was_recursively_verified()) return;
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1913
        // We know that this index refers to a subclass of Throwable
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1914
        VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1915
          catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1916
        new_frame->push_stack(catch_type, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1917
      } else {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1918
        VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1919
          VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1920
        new_frame->push_stack(throwable, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1921
      }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1922
      ErrorContext ctx;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1923
      bool matches = stackmap_table->match_stackmap(
43179
06ccf3bfd0a3 8167104: Additional class construction refinements
hseigel
parents: 43178
diff changeset
  1924
        new_frame, handler_pc, true, false, &ctx, CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1925
      if (!matches) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1926
        verify_error(ctx, "Stack map does not match the one at "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1927
            "exception handler %d", handler_pc);
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1928
        return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1929
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1930
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1931
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1932
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1933
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1934
void ClassVerifier::verify_cp_index(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1935
    u2 bci, const constantPoolHandle& cp, int index, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1936
  int nconstants = cp->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1937
  if ((index <= 0) || (index >= nconstants)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1938
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1939
        "Illegal constant pool index %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1940
        index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1941
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1942
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1943
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1944
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1945
void ClassVerifier::verify_cp_type(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1946
    u2 bci, int index, const constantPoolHandle& cp, unsigned int types, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1947
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1948
  // In some situations, bytecode rewriting may occur while we're verifying.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1949
  // In this case, a constant pool cache exists and some indices refer to that
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1950
  // instead.  Be sure we don't pick up such indices by accident.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1951
  // We must check was_recursively_verified() before we get here.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1952
  guarantee(cp->cache() == NULL, "not rewritten yet");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1953
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1954
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1955
  unsigned int tag = cp->tag_at(index).value();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1956
  if ((types & (1 << tag)) == 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1957
    verify_error(ErrorContext::bad_cp_index(bci, index),
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1958
      "Illegal type at constant pool entry %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1959
      index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1960
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1961
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1962
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1963
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1964
void ClassVerifier::verify_cp_class_type(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1965
    u2 bci, int index, const constantPoolHandle& cp, TRAPS) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1966
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1967
  constantTag tag = cp->tag_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1968
  if (!tag.is_klass() && !tag.is_unresolved_klass()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1969
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1970
        "Illegal type at constant pool entry %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1971
        index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1972
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1973
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1974
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1975
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1976
void ClassVerifier::verify_error(ErrorContext ctx, const char* msg, ...) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1977
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1978
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1979
  ctx.reset_frames();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1980
  _exception_type = vmSymbols::java_lang_VerifyError();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1981
  _error_context = ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1982
  va_list va;
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1983
  va_start(va, msg);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1984
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1985
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1986
  _message = ss.as_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1987
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1988
  ResourceMark rm;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1989
  const char* exception_name = _exception_type->as_C_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1990
  Exceptions::debug_check_abort(exception_name, NULL);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1991
#endif // ndef ASSERT
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1992
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1993
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1994
void ClassVerifier::class_format_error(const char* msg, ...) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1995
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1996
  _exception_type = vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1997
  va_list va;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1998
  va_start(va, msg);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1999
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2000
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2001
  if (!_method.is_null()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2002
    ss.print(" in method %s", _method->name_and_sig_as_C_string());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2003
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2004
  _message = ss.as_string();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2005
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2006
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2007
Klass* ClassVerifier::load_class(Symbol* name, TRAPS) {
46271
979ebd346ecf 8169881: Remove implicit Handle conversions oop->Handle
coleenp
parents: 41542
diff changeset
  2008
  HandleMark hm(THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2009
  // Get current loader and protection domain first.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2010
  oop loader = current_class()->class_loader();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2011
  oop protection_domain = current_class()->protection_domain();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2012
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2013
  Klass* kls = SystemDictionary::resolve_or_fail(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2014
    name, Handle(THREAD, loader), Handle(THREAD, protection_domain),
27680
8ecc0871c18e 8064811: Use THREAD instead of CHECK_NULL in return statements
stefank
parents: 27171
diff changeset
  2015
    true, THREAD);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2016
49770
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2017
  if (kls != NULL) {
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2018
    current_class()->class_loader_data()->record_dependency(kls);
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2019
    if (log_is_enabled(Debug, class, resolve)) {
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2020
      InstanceKlass* cur_class = InstanceKlass::cast(current_class());
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2021
      Verifier::trace_class_resolution(kls, cur_class);
0a8a11767c3d 8189123: More consistent classloading
hseigel
parents: 49594
diff changeset
  2022
    }
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2023
  }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2024
  return kls;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2025
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2026
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
  2027
bool ClassVerifier::is_protected_access(InstanceKlass* this_class,
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2028
                                        Klass* target_class,
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2029
                                        Symbol* field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2030
                                        Symbol* field_sig,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2031
                                        bool is_method) {
35492
c8c0273e6b91 8146690: Make all classes in GC follow the naming convention.
david
parents: 35219
diff changeset
  2032
  NoSafepointVerifier nosafepoint;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2033
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2034
  // If target class isn't a super class of this class, we don't worry about this case
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2035
  if (!this_class->is_subclass_of(target_class)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2036
    return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2037
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2038
  // Check if the specified method or field is protected
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2039
  InstanceKlass* target_instance = InstanceKlass::cast(target_class);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2040
  fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2041
  if (is_method) {
28731
f7339cba0a6a 8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents: 28612
diff changeset
  2042
    Method* m = target_instance->uncached_lookup_method(field_name, field_sig, Klass::find_overpass);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2043
    if (m != NULL && m->is_protected()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2044
      if (!this_class->is_same_class_package(m->method_holder())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2045
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2046
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2047
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2048
  } else {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2049
    Klass* member_klass = target_instance->find_field(field_name, field_sig, &fd);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2050
    if (member_klass != NULL && fd.is_protected()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2051
      if (!this_class->is_same_class_package(member_klass)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2052
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2053
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2054
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2055
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2056
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2057
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2058
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2059
void ClassVerifier::verify_ldc(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2060
    int opcode, u2 index, StackMapFrame* current_frame,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2061
    const constantPoolHandle& cp, u2 bci, TRAPS) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2062
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2063
  constantTag tag = cp->tag_at(index);
48826
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2064
  unsigned int types = 0;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2065
  if (opcode == Bytecodes::_ldc || opcode == Bytecodes::_ldc_w) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2066
    if (!tag.is_unresolved_klass()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2067
      types = (1 << JVM_CONSTANT_Integer) | (1 << JVM_CONSTANT_Float)
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2068
            | (1 << JVM_CONSTANT_String)  | (1 << JVM_CONSTANT_Class)
48826
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2069
            | (1 << JVM_CONSTANT_MethodHandle) | (1 << JVM_CONSTANT_MethodType)
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2070
            | (1 << JVM_CONSTANT_Dynamic);
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2071
      // Note:  The class file parser already verified the legality of
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2072
      // MethodHandle and MethodType constants.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2073
      verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2074
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2075
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2076
    assert(opcode == Bytecodes::_ldc2_w, "must be ldc2_w");
48826
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2077
    types = (1 << JVM_CONSTANT_Double) | (1 << JVM_CONSTANT_Long)
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2078
          | (1 << JVM_CONSTANT_Dynamic);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2079
    verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2080
  }
1550
be2fc37a817f 6653858: dynamic languages need to be able to load anonymous classes
jrose
parents: 670
diff changeset
  2081
  if (tag.is_string() && cp->is_pseudo_string_at(index)) {
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  2082
    current_frame->push_stack(object_type(), CHECK_VERIFY(this));
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2083
  } else if (tag.is_string()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2084
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2085
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2086
        vmSymbols::java_lang_String()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2087
  } else if (tag.is_klass() || tag.is_unresolved_klass()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2088
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2089
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2090
        vmSymbols::java_lang_Class()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2091
  } else if (tag.is_int()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2092
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2093
      VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2094
  } else if (tag.is_float()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2095
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2096
      VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2097
  } else if (tag.is_double()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2098
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2099
      VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2100
      VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2101
  } else if (tag.is_long()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2102
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2103
      VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2104
      VerificationType::long2_type(), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2105
  } else if (tag.is_method_handle()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2106
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2107
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2108
        vmSymbols::java_lang_invoke_MethodHandle()), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2109
  } else if (tag.is_method_type()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2110
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2111
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2112
        vmSymbols::java_lang_invoke_MethodType()), CHECK_VERIFY(this));
48826
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2113
  } else if (tag.is_dynamic_constant()) {
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2114
    Symbol* constant_type = cp->uncached_signature_ref_at(index);
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2115
    if (!SignatureVerifier::is_valid_type_signature(constant_type)) {
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2116
      class_format_error(
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2117
        "Invalid type for dynamic constant in class %s referenced "
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2118
        "from constant pool index %d", _klass->external_name(), index);
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2119
      return;
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2120
    }
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2121
    assert(sizeof(VerificationType) == sizeof(uintptr_t),
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2122
          "buffer type must match VerificationType size");
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2123
    uintptr_t constant_type_buffer[2];
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2124
    VerificationType* v_constant_type = (VerificationType*)constant_type_buffer;
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2125
    SignatureStream sig_stream(constant_type, false);
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2126
    int n = change_sig_to_verificationType(
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2127
      &sig_stream, v_constant_type, CHECK_VERIFY(this));
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2128
    int opcode_n = (opcode == Bytecodes::_ldc2_w ? 2 : 1);
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2129
    if (n != opcode_n) {
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2130
      // wrong kind of ldc; reverify against updated type mask
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2131
      types &= ~(1 << JVM_CONSTANT_Dynamic);
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2132
      verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2133
    }
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2134
    for (int i = 0; i < n; i++) {
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2135
      current_frame->push_stack(v_constant_type[i], CHECK_VERIFY(this));
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2136
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2137
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2138
    /* Unreachable? verify_cp_type has already validated the cp type. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2139
    verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2140
        ErrorContext::bad_cp_index(bci, index), "Invalid index in ldc");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2141
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2142
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2143
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2144
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2145
void ClassVerifier::verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2146
    RawBytecodeStream* bcs, u4 code_length, char* code_data,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2147
    StackMapFrame* current_frame, StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2148
  int bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2149
  address bcp = bcs->bcp();
46620
750c6edff33b 8178500: Replace usages of round_to and round_down with align_up and align_down
stefank
parents: 46403
diff changeset
  2150
  address aligned_bcp = align_up(bcp + 1, jintSize);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2151
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2152
  if (_klass->major_version() < NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2153
    // 4639449 & 4647081: padding bytes must be 0
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2154
    u2 padding_offset = 1;
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2155
    while ((bcp + padding_offset) < aligned_bcp) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2156
      if(*(bcp + padding_offset) != 0) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2157
        verify_error(ErrorContext::bad_code(bci),
24663
48203b12ee8e 8043925: Fix typo in verifier.cpp
coleenp
parents: 24456
diff changeset
  2158
                     "Nonzero padding byte in lookupswitch or tableswitch");
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2159
        return;
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2160
      }
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2161
      padding_offset++;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2162
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2163
  }
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2164
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2165
  int default_offset = (int) Bytes::get_Java_u4(aligned_bcp);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2166
  int keys, delta;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2167
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2168
    VerificationType::integer_type(), CHECK_VERIFY(this));
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2169
  if (bcs->raw_code() == Bytecodes::_tableswitch) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2170
    jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2171
    jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2172
    if (low > high) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2173
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2174
          "low must be less than or equal to high in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2175
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2176
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2177
    keys = high - low + 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2178
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2179
      verify_error(ErrorContext::bad_code(bci), "too many keys in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2180
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2181
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2182
    delta = 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2183
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2184
    keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2185
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2186
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2187
                   "number of keys in lookupswitch less than 0");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2188
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2189
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2190
    delta = 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2191
    // Make sure that the lookupswitch items are sorted
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2192
    for (int i = 0; i < (keys - 1); i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2193
      jint this_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2194
      jint next_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i+2)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2195
      if (this_key >= next_key) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2196
        verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2197
                     "Bad lookupswitch instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2198
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2199
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2200
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2201
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2202
  int target = bci + default_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2203
  stackmap_table->check_jump_target(current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2204
  for (int i = 0; i < keys; i++) {
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2205
    // Because check_jump_target() may safepoint, the bytecode could have
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2206
    // moved, which means 'aligned_bcp' is no good and needs to be recalculated.
46620
750c6edff33b 8178500: Replace usages of round_to and round_down with align_up and align_down
stefank
parents: 46403
diff changeset
  2207
    aligned_bcp = align_up(bcs->bcp() + 1, jintSize);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2208
    target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2209
    stackmap_table->check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2210
      current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2211
  }
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2212
  NOT_PRODUCT(aligned_bcp = NULL);  // no longer valid at this point
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2213
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2214
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2215
bool ClassVerifier::name_in_supers(
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
  2216
    Symbol* ref_name, InstanceKlass* current) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2217
  Klass* super = current->super();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2218
  while (super != NULL) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2219
    if (super->name() == ref_name) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2220
      return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2221
    }
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2222
    super = super->super();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2223
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2224
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2225
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2226
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2227
void ClassVerifier::verify_field_instructions(RawBytecodeStream* bcs,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2228
                                              StackMapFrame* current_frame,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2229
                                              const constantPoolHandle& cp,
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2230
                                              bool allow_arrays,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2231
                                              TRAPS) {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2232
  u2 index = bcs->get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2233
  verify_cp_type(bcs->bci(), index, cp,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2234
      1 << JVM_CONSTANT_Fieldref, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2235
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2236
  // Get field name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2237
  Symbol* field_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2238
  Symbol* field_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2239
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2240
  if (!SignatureVerifier::is_valid_type_signature(field_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2241
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2242
      "Invalid signature for field in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2243
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2244
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2245
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2246
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2247
  // Get referenced class type
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2248
  VerificationType ref_class_type = cp_ref_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2249
    index, cp, CHECK_VERIFY(this));
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2250
  if (!ref_class_type.is_object() &&
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2251
    (!allow_arrays || !ref_class_type.is_array())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2252
    verify_error(ErrorContext::bad_type(bcs->bci(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2253
        TypeOrigin::cp(index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2254
        "Expecting reference to class in class %s at constant pool index %d",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2255
        _klass->external_name(), index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2256
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2257
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2258
  VerificationType target_class_type = ref_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2259
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2260
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2261
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2262
  uintptr_t field_type_buffer[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2263
  VerificationType* field_type = (VerificationType*)field_type_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2264
  // If we make a VerificationType[2] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2265
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2266
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2267
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2268
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2269
  SignatureStream sig_stream(field_sig, false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2270
  VerificationType stack_object_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2271
  int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2272
    &sig_stream, field_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2273
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2274
  bool is_assignable;
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2275
  switch (bcs->raw_code()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2276
    case Bytecodes::_getstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2277
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2278
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2279
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2280
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2281
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2282
    case Bytecodes::_putstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2283
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2284
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2285
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2286
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2287
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2288
    case Bytecodes::_getfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2289
      stack_object_type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2290
        target_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2291
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2292
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2293
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2294
      goto check_protected;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2295
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2296
    case Bytecodes::_putfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2297
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2298
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2299
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2300
      stack_object_type = current_frame->pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2301
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2302
      // The JVMS 2nd edition allows field initialization before the superclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2303
      // initializer, if the field is defined within the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2304
      fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2305
      if (stack_object_type == VerificationType::uninitialized_this_type() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2306
          target_class_type.equals(current_type()) &&
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2307
          _klass->find_local_field(field_name, field_sig, &fd)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2308
        stack_object_type = current_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2309
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2310
      is_assignable = target_class_type.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2311
        stack_object_type, this, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2312
      if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2313
        verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2314
            current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2315
            TypeOrigin::cp(index, target_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2316
            "Bad type on operand stack in putfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2317
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2318
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2319
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2320
    check_protected: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2321
      if (_this_type == stack_object_type)
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2322
        break; // stack_object_type must be assignable to _current_class_type
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2323
      if (was_recursively_verified()) return;
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2324
      Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2325
        cp->klass_name_at(cp->klass_ref_index_at(index));
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2326
      if (!name_in_supers(ref_class_name, current_class()))
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2327
        // stack_object_type must be assignable to _current_class_type since:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2328
        // 1. stack_object_type must be assignable to ref_class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2329
        // 2. ref_class must be _current_class or a subclass of it. It can't
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2330
        //    be a superclass of it. See revised JVMS 5.4.4.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2331
        break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2332
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2333
      Klass* ref_class_oop = load_class(ref_class_name, CHECK);
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2334
      if (is_protected_access(current_class(), ref_class_oop, field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2335
                              field_sig, false)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2336
        // It's protected access, check if stack object is assignable to
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2337
        // current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2338
        is_assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2339
          stack_object_type, this, true, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2340
        if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2341
          verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2342
              current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2343
              TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2344
              "Bad access to protected data in getfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2345
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2346
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2347
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2348
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2349
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2350
    default: ShouldNotReachHere();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2351
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2352
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2353
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2354
// Look at the method's handlers.  If the bci is in the handler's try block
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2355
// then check if the handler_pc is already on the stack.  If not, push it
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2356
// unless the handler has already been scanned.
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2357
void ClassVerifier::push_handlers(ExceptionTable* exhandlers,
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2358
                                  GrowableArray<u4>* handler_list,
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2359
                                  GrowableArray<u4>* handler_stack,
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2360
                                  u4 bci) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2361
  int exlength = exhandlers->length();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2362
  for(int x = 0; x < exlength; x++) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2363
    if (bci >= exhandlers->start_pc(x) && bci < exhandlers->end_pc(x)) {
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2364
      u4 exhandler_pc = exhandlers->handler_pc(x);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2365
      if (!handler_list->contains(exhandler_pc)) {
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2366
        handler_stack->append_if_missing(exhandler_pc);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2367
        handler_list->append(exhandler_pc);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2368
      }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2369
    }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2370
  }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2371
}
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2372
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2373
// Return TRUE if all code paths starting with start_bc_offset end in
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2374
// bytecode athrow or loop.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2375
bool ClassVerifier::ends_in_athrow(u4 start_bc_offset) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2376
  ResourceMark rm;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2377
  // Create bytecode stream.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2378
  RawBytecodeStream bcs(method());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2379
  u4 code_length = method()->code_size();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2380
  bcs.set_start(start_bc_offset);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2381
  u4 target;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2382
  // Create stack for storing bytecode start offsets for if* and *switch.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2383
  GrowableArray<u4>* bci_stack = new GrowableArray<u4>(30);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2384
  // Create stack for handlers for try blocks containing this handler.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2385
  GrowableArray<u4>* handler_stack = new GrowableArray<u4>(30);
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2386
  // Create list of handlers that have been pushed onto the handler_stack
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2387
  // so that handlers embedded inside of their own TRY blocks only get
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2388
  // scanned once.
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2389
  GrowableArray<u4>* handler_list = new GrowableArray<u4>(30);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2390
  // Create list of visited branch opcodes (goto* and if*).
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2391
  GrowableArray<u4>* visited_branches = new GrowableArray<u4>(30);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2392
  ExceptionTable exhandlers(_method());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2393
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2394
  while (true) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2395
    if (bcs.is_last_bytecode()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2396
      // if no more starting offsets to parse or if at the end of the
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2397
      // method then return false.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2398
      if ((bci_stack->is_empty()) || ((u4)bcs.end_bci() == code_length))
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2399
        return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2400
      // Pop a bytecode starting offset and scan from there.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2401
      bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2402
    }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2403
    Bytecodes::Code opcode = bcs.raw_next();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2404
    u4 bci = bcs.bci();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2405
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2406
    // If the bytecode is in a TRY block, push its handlers so they
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2407
    // will get parsed.
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2408
    push_handlers(&exhandlers, handler_list, handler_stack, bci);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2409
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2410
    switch (opcode) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2411
      case Bytecodes::_if_icmpeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2412
      case Bytecodes::_if_icmpne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2413
      case Bytecodes::_if_icmplt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2414
      case Bytecodes::_if_icmpge:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2415
      case Bytecodes::_if_icmpgt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2416
      case Bytecodes::_if_icmple:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2417
      case Bytecodes::_ifeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2418
      case Bytecodes::_ifne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2419
      case Bytecodes::_iflt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2420
      case Bytecodes::_ifge:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2421
      case Bytecodes::_ifgt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2422
      case Bytecodes::_ifle:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2423
      case Bytecodes::_if_acmpeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2424
      case Bytecodes::_if_acmpne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2425
      case Bytecodes::_ifnull:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2426
      case Bytecodes::_ifnonnull:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2427
        target = bcs.dest();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2428
        if (visited_branches->contains(bci)) {
39715
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2429
          if (bci_stack->is_empty()) {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2430
            if (handler_stack->is_empty()) {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2431
              return true;
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2432
            } else {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2433
              // Parse the catch handlers for try blocks containing athrow.
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2434
              bcs.set_start(handler_stack->pop());
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2435
            }
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2436
          } else {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2437
            // Pop a bytecode starting offset and scan from there.
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2438
            bcs.set_start(bci_stack->pop());
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2439
          }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2440
        } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2441
          if (target > bci) { // forward branch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2442
            if (target >= code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2443
            // Push the branch target onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2444
            bci_stack->push(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2445
            // then, scan bytecodes starting with next.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2446
            bcs.set_start(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2447
          } else { // backward branch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2448
            // Push bytecode offset following backward branch onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2449
            bci_stack->push(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2450
            // Check bytecodes starting with branch target.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2451
            bcs.set_start(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2452
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2453
          // Record target so we don't branch here again.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2454
          visited_branches->append(bci);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2455
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2456
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2457
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2458
      case Bytecodes::_goto:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2459
      case Bytecodes::_goto_w:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2460
        target = (opcode == Bytecodes::_goto ? bcs.dest() : bcs.dest_w());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2461
        if (visited_branches->contains(bci)) {
39715
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2462
          if (bci_stack->is_empty()) {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2463
            if (handler_stack->is_empty()) {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2464
              return true;
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2465
            } else {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2466
              // Parse the catch handlers for try blocks containing athrow.
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2467
              bcs.set_start(handler_stack->pop());
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2468
            }
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2469
          } else {
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2470
            // Been here before, pop new starting offset from stack.
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2471
            bcs.set_start(bci_stack->pop());
1cbba6073b15 8155981: Bolster bytecode verification
hseigel
parents: 38151
diff changeset
  2472
          }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2473
        } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2474
          if (target >= code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2475
          // Continue scanning from the target onward.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2476
          bcs.set_start(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2477
          // Record target so we don't branch here again.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2478
          visited_branches->append(bci);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2479
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2480
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2481
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2482
      // Check that all switch alternatives end in 'athrow' bytecodes. Since it
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2483
      // is  difficult to determine where each switch alternative ends, parse
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2484
      // each switch alternative until either hit a 'return', 'athrow', or reach
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2485
      // the end of the method's bytecodes.  This is gross but should be okay
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2486
      // because:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2487
      // 1. tableswitch and lookupswitch byte codes in handlers for ctor explicit
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2488
      //    constructor invocations should be rare.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2489
      // 2. if each switch alternative ends in an athrow then the parsing should be
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2490
      //    short.  If there is no athrow then it is bogus code, anyway.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2491
      case Bytecodes::_lookupswitch:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2492
      case Bytecodes::_tableswitch:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2493
        {
46620
750c6edff33b 8178500: Replace usages of round_to and round_down with align_up and align_down
stefank
parents: 46403
diff changeset
  2494
          address aligned_bcp = align_up(bcs.bcp() + 1, jintSize);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2495
          u4 default_offset = Bytes::get_Java_u4(aligned_bcp) + bci;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2496
          int keys, delta;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2497
          if (opcode == Bytecodes::_tableswitch) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2498
            jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2499
            jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2500
            // This is invalid, but let the regular bytecode verifier
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2501
            // report this because the user will get a better error message.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2502
            if (low > high) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2503
            keys = high - low + 1;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2504
            delta = 1;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2505
          } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2506
            keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2507
            delta = 2;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2508
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2509
          // Invalid, let the regular bytecode verifier deal with it.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2510
          if (keys < 0) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2511
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2512
          // Push the offset of the next bytecode onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2513
          bci_stack->push(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2514
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2515
          // Push the switch alternatives onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2516
          for (int i = 0; i < keys; i++) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2517
            u4 target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2518
            if (target > code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2519
            bci_stack->push(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2520
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2521
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2522
          // Start bytecode parsing for the switch at the default alternative.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2523
          if (default_offset > code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2524
          bcs.set_start(default_offset);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2525
          break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2526
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2527
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2528
      case Bytecodes::_return:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2529
        return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2530
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2531
      case Bytecodes::_athrow:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2532
        {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2533
          if (bci_stack->is_empty()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2534
            if (handler_stack->is_empty()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2535
              return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2536
            } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2537
              // Parse the catch handlers for try blocks containing athrow.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2538
              bcs.set_start(handler_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2539
            }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2540
          } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2541
            // Pop a bytecode offset and starting scanning from there.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2542
            bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2543
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2544
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2545
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2546
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2547
      default:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2548
        ;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2549
    } // end switch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2550
  } // end while loop
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2551
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2552
  return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2553
}
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2554
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2555
void ClassVerifier::verify_invoke_init(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2556
    RawBytecodeStream* bcs, u2 ref_class_index, VerificationType ref_class_type,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2557
    StackMapFrame* current_frame, u4 code_length, bool in_try_block,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2558
    bool *this_uninit, const constantPoolHandle& cp, StackMapTable* stackmap_table,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2559
    TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2560
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2561
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2562
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2563
  if (type == VerificationType::uninitialized_this_type()) {
12986
14b117407405 7160757: Problem with hotspot/runtime_classfile
kamg
parents: 9116
diff changeset
  2564
    // The method must be an <init> method of this class or its superclass
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2565
    Klass* superk = current_class()->super();
6172
e1d9c632fa3c 6964170: Verifier crashes
apangin
parents: 5882
diff changeset
  2566
    if (ref_class_type.name() != current_class()->name() &&
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2567
        ref_class_type.name() != superk->name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2568
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2569
          TypeOrigin::implicit(ref_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2570
          TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2571
          "Bad <init> method call");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2572
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2573
    }
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2574
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2575
    // If this invokespecial call is done from inside of a TRY block then make
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2576
    // sure that all catch clause paths end in a throw.  Otherwise, this can
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2577
    // result in returning an incomplete object.
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2578
    if (in_try_block) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2579
      ExceptionTable exhandlers(_method());
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2580
      int exlength = exhandlers.length();
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2581
      for(int i = 0; i < exlength; i++) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2582
        u2 start_pc = exhandlers.start_pc(i);
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2583
        u2 end_pc = exhandlers.end_pc(i);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2584
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2585
        if (bci >= start_pc && bci < end_pc) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2586
          if (!ends_in_athrow(exhandlers.handler_pc(i))) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2587
            verify_error(ErrorContext::bad_code(bci),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2588
              "Bad <init> method call from after the start of a try block");
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2589
            return;
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
  2590
          } else if (log_is_enabled(Info, verification)) {
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2591
            ResourceMark rm(THREAD);
37261
659ed5b20b48 8153026: Change logging tag 'verboseverification' to 'verification'
rprotacio
parents: 37242
diff changeset
  2592
            log_info(verification)("Survived call to ends_in_athrow(): %s",
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2593
                                          current_class()->name()->as_C_string());
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2594
          }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2595
        }
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2596
      }
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2597
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2598
      // Check the exception handler target stackmaps with the locals from the
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2599
      // incoming stackmap (before initialize_object() changes them to outgoing
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2600
      // state).
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2601
      if (was_recursively_verified()) return;
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2602
      verify_exception_handler_targets(bci, true, current_frame,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2603
                                       stackmap_table, CHECK_VERIFY(this));
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2604
    } // in_try_block
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2605
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2606
    current_frame->initialize_object(type, current_type());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2607
    *this_uninit = true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2608
  } else if (type.is_uninitialized()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2609
    u2 new_offset = type.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2610
    address new_bcp = bcs->bcp() - bci + new_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2611
    if (new_offset > (code_length - 3) || (*new_bcp) != Bytecodes::_new) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2612
      /* Unreachable?  Stack map parsing ensures valid type and new
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2613
       * instructions have a valid BCI. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2614
      verify_error(ErrorContext::bad_code(new_offset),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2615
                   "Expecting new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2616
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2617
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2618
    u2 new_class_index = Bytes::get_Java_u2(new_bcp + 1);
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2619
    if (was_recursively_verified()) return;
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2620
    verify_cp_class_type(bci, new_class_index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2621
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2622
    // The method must be an <init> method of the indicated class
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2623
    VerificationType new_class_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2624
      new_class_index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2625
    if (!new_class_type.equals(ref_class_type)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2626
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2627
          TypeOrigin::cp(new_class_index, new_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2628
          TypeOrigin::cp(ref_class_index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2629
          "Call to wrong <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2630
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2631
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2632
    // According to the VM spec, if the referent class is a superclass of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2633
    // current class, and is in a different runtime package, and the method is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2634
    // protected, then the objectref must be the current class or a subclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2635
    // of the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2636
    VerificationType objectref_type = new_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2637
    if (name_in_supers(ref_class_type.name(), current_class())) {
28371
92e60e58ba8b 8064335: Null pointer dereference in hotspot/src/share/vm/classfile/verifier.cpp
hseigel
parents: 27680
diff changeset
  2638
      Klass* ref_klass = load_class(ref_class_type.name(), CHECK);
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2639
      if (was_recursively_verified()) return;
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2640
      Method* m = InstanceKlass::cast(ref_klass)->uncached_lookup_method(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2641
        vmSymbols::object_initializer_name(),
23999
22eb7be3d99d 8033150: invokestatic: IncompatibleClassChangeError trying to invoke static method from a parent in presence of conflicting defaults.
lfoltan
parents: 21768
diff changeset
  2642
        cp->signature_ref_at(bcs->get_index_u2()),
28731
f7339cba0a6a 8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents: 28612
diff changeset
  2643
        Klass::find_overpass);
25509
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2644
      // Do nothing if method is not found.  Let resolution detect the error.
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2645
      if (m != NULL) {
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
  2646
        InstanceKlass* mh = m->method_holder();
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
  2647
        if (m->is_protected() && !mh->is_same_class_package(_klass)) {
25509
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2648
          bool assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2649
            objectref_type, this, true, CHECK_VERIFY(this));
25509
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2650
          if (!assignable) {
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2651
            verify_error(ErrorContext::bad_type(bci,
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2652
                TypeOrigin::cp(new_class_index, objectref_type),
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2653
                TypeOrigin::implicit(current_type())),
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2654
                "Bad access to protected <init> method");
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2655
            return;
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2656
          }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2657
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2658
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2659
    }
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2660
    // Check the exception handler target stackmaps with the locals from the
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2661
    // incoming stackmap (before initialize_object() changes them to outgoing
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2662
    // state).
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2663
    if (in_try_block) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2664
      if (was_recursively_verified()) return;
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2665
      verify_exception_handler_targets(bci, *this_uninit, current_frame,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2666
                                       stackmap_table, CHECK_VERIFY(this));
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2667
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2668
    current_frame->initialize_object(type, new_class_type);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2669
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2670
    verify_error(ErrorContext::bad_type(bci, current_frame->stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2671
        "Bad operand type when invoking <init>");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2672
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2673
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2674
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2675
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2676
bool ClassVerifier::is_same_or_direct_interface(
46329
53ccc37bda19 8155672: Remove instanceKlassHandles and KlassHandles
coleenp
parents: 46289
diff changeset
  2677
    InstanceKlass* klass,
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2678
    VerificationType klass_type,
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2679
    VerificationType ref_class_type) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2680
  if (ref_class_type.equals(klass_type)) return true;
51329
9c68699bebe5 8208999: Some use of Klass* should be replaced by InstanceKlass*
iklam
parents: 51070
diff changeset
  2681
  Array<InstanceKlass*>* local_interfaces = klass->local_interfaces();
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2682
  if (local_interfaces != NULL) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2683
    for (int x = 0; x < local_interfaces->length(); x++) {
51329
9c68699bebe5 8208999: Some use of Klass* should be replaced by InstanceKlass*
iklam
parents: 51070
diff changeset
  2684
      InstanceKlass* k = local_interfaces->at(x);
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2685
      assert (k != NULL && k->is_interface(), "invalid interface");
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2686
      if (ref_class_type.equals(VerificationType::reference_type(k->name()))) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2687
        return true;
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2688
      }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2689
    }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2690
  }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2691
  return false;
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2692
}
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2693
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2694
void ClassVerifier::verify_invoke_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2695
    RawBytecodeStream* bcs, u4 code_length, StackMapFrame* current_frame,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2696
    bool in_try_block, bool *this_uninit, VerificationType return_type,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2697
    const constantPoolHandle& cp, StackMapTable* stackmap_table, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2698
  // Make sure the constant pool item is the right type
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2699
  u2 index = bcs->get_index_u2();
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2700
  Bytecodes::Code opcode = bcs->raw_code();
48826
c4d9d1b08e2e 8186209: Tool support for ConstantDynamic
psandoz
parents: 47765
diff changeset
  2701
  unsigned int types = 0;
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2702
  switch (opcode) {
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2703
    case Bytecodes::_invokeinterface:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2704
      types = 1 << JVM_CONSTANT_InterfaceMethodref;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2705
      break;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2706
    case Bytecodes::_invokedynamic:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2707
      types = 1 << JVM_CONSTANT_InvokeDynamic;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2708
      break;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2709
    case Bytecodes::_invokespecial:
16676
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2710
    case Bytecodes::_invokestatic:
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2711
      types = (_klass->major_version() < STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION) ?
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2712
        (1 << JVM_CONSTANT_Methodref) :
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2713
        ((1 << JVM_CONSTANT_InterfaceMethodref) | (1 << JVM_CONSTANT_Methodref));
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2714
      break;
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2715
    default:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2716
      types = 1 << JVM_CONSTANT_Methodref;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2717
  }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2718
  verify_cp_type(bcs->bci(), index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2719
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2720
  // Get method name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2721
  Symbol* method_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2722
  Symbol* method_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2723
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2724
  if (!SignatureVerifier::is_valid_method_signature(method_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2725
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2726
      "Invalid method signature in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2727
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2728
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2729
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2730
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2731
  // Get referenced class type
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2732
  VerificationType ref_class_type;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2733
  if (opcode == Bytecodes::_invokedynamic) {
24322
c2978d1578e3 8036956: remove EnableInvokeDynamic flag
anoll
parents: 23999
diff changeset
  2734
    if (_klass->major_version() < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2735
      class_format_error(
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  2736
        "invokedynamic instructions not supported by this class file version (%d), class %s",
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  2737
        _klass->major_version(), _klass->external_name());
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2738
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2739
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2740
  } else {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2741
    ref_class_type = cp_ref_index_to_type(index, cp, CHECK_VERIFY(this));
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2742
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2743
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2744
  // For a small signature length, we just allocate 128 bytes instead
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2745
  // of parsing the signature once to find its size.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2746
  // -3 is for '(', ')' and return descriptor; multiply by 2 is for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2747
  // longs/doubles to be consertive.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2748
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2749
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2750
  uintptr_t on_stack_sig_types_buffer[128];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2751
  // If we make a VerificationType[128] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2752
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2753
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2754
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2755
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2756
  VerificationType* sig_types;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2757
  int size = (method_sig->utf8_length() - 3) * 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2758
  if (size > 128) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2759
    // Long and double occupies two slots here.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2760
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2761
    size = size_it.size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2762
    sig_types = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, VerificationType, size);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2763
  } else{
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2764
    sig_types = (VerificationType*)on_stack_sig_types_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2765
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2766
  SignatureStream sig_stream(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2767
  int sig_i = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2768
  while (!sig_stream.at_return_type()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2769
    sig_i += change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2770
      &sig_stream, &sig_types[sig_i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2771
    sig_stream.next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2772
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2773
  int nargs = sig_i;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2774
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2775
#ifdef ASSERT
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2776
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2777
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2778
    assert(nargs == size_it.size(), "Argument sizes do not match");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2779
    assert(nargs <= (method_sig->utf8_length() - 3) * 2, "estimate of max size isn't conservative enough");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2780
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2781
#endif
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2782
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2783
  // Check instruction operands
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2784
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2785
  if (opcode == Bytecodes::_invokeinterface) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2786
    address bcp = bcs->bcp();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2787
    // 4905268: count operand in invokeinterface should be nargs+1, not nargs.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2788
    // JSR202 spec: The count operand of an invokeinterface instruction is valid if it is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2789
    // the difference between the size of the operand stack before and after the instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2790
    // executes.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2791
    if (*(bcp+3) != (nargs+1)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2792
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2793
          "Inconsistent args count operand in invokeinterface");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2794
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2795
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2796
    if (*(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2797
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2798
          "Fourth operand byte of invokeinterface must be zero");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2799
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2800
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2801
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2802
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2803
  if (opcode == Bytecodes::_invokedynamic) {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2804
    address bcp = bcs->bcp();
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2805
    if (*(bcp+3) != 0 || *(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2806
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2807
          "Third and fourth operand bytes of invokedynamic must be zero");
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2808
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2809
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2810
  }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2811
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2812
  if (method_name->byte_at(0) == '<') {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2813
    // Make sure <init> can only be invoked by invokespecial
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2814
    if (opcode != Bytecodes::_invokespecial ||
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2815
        method_name != vmSymbols::object_initializer_name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2816
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2817
          "Illegal call to internal method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2818
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2819
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2820
  } else if (opcode == Bytecodes::_invokespecial
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2821
             && !is_same_or_direct_interface(current_class(), current_type(), ref_class_type)
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2822
             && !ref_class_type.equals(VerificationType::reference_type(
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2823
                  current_class()->super()->name()))) {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2824
    bool subtype = false;
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2825
    bool have_imr_indirect = cp->tag_at(index).value() == JVM_CONSTANT_InterfaceMethodref;
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2826
    if (!current_class()->is_unsafe_anonymous()) {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2827
      subtype = ref_class_type.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2828
                 current_type(), this, false, CHECK_VERIFY(this));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2829
    } else {
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2830
      VerificationType unsafe_anonymous_host_type =
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2831
                        VerificationType::reference_type(current_class()->unsafe_anonymous_host()->name());
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2832
      subtype = ref_class_type.is_assignable_from(unsafe_anonymous_host_type, this, false, CHECK_VERIFY(this));
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2833
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2834
      // If invokespecial of IMR, need to recheck for same or
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2835
      // direct interface relative to the host class
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2836
      have_imr_indirect = (have_imr_indirect &&
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2837
                           !is_same_or_direct_interface(
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2838
                             current_class()->unsafe_anonymous_host(),
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2839
                             unsafe_anonymous_host_type, ref_class_type));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2840
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2841
    if (!subtype) {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2842
      verify_error(ErrorContext::bad_code(bci),
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2843
          "Bad invokespecial instruction: "
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2844
          "current class isn't assignable to reference class.");
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2845
       return;
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2846
    } else if (have_imr_indirect) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2847
      verify_error(ErrorContext::bad_code(bci),
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2848
          "Bad invokespecial instruction: "
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2849
          "interface method reference is in an indirect superinterface.");
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2850
      return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2851
    }
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2852
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2853
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2854
  // Match method descriptor with operand stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2855
  for (int i = nargs - 1; i >= 0; i--) {  // Run backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2856
    current_frame->pop_stack(sig_types[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2857
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2858
  // Check objectref on operand stack
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2859
  if (opcode != Bytecodes::_invokestatic &&
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2860
      opcode != Bytecodes::_invokedynamic) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2861
    if (method_name == vmSymbols::object_initializer_name()) {  // <init> method
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2862
      verify_invoke_init(bcs, index, ref_class_type, current_frame,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2863
        code_length, in_try_block, this_uninit, cp, stackmap_table,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2864
        CHECK_VERIFY(this));
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2865
      if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2866
    } else {   // other methods
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2867
      // Ensures that target class is assignable to method class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2868
      if (opcode == Bytecodes::_invokespecial) {
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2869
        if (!current_class()->is_unsafe_anonymous()) {
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2870
          current_frame->pop_stack(current_type(), CHECK_VERIFY(this));
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2871
        } else {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2872
          // anonymous class invokespecial calls: check if the
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2873
          // objectref is a subtype of the unsafe_anonymous_host of the current class
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2874
          // to allow an anonymous class to reference methods in the unsafe_anonymous_host
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2875
          VerificationType top = current_frame->pop_stack(CHECK_VERIFY(this));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2876
          VerificationType hosttype =
51444
3e5d28e6de32 8209301: JVM rename is_anonymous, host_klass to unsafe specific terminology ahead of Unsafe.defineAnonymousClass deprecation
lfoltan
parents: 51329
diff changeset
  2877
            VerificationType::reference_type(current_class()->unsafe_anonymous_host()->name());
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2878
          bool subtype = hosttype.is_assignable_from(top, this, false, CHECK_VERIFY(this));
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2879
          if (!subtype) {
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2880
            verify_error( ErrorContext::bad_type(current_frame->offset(),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2881
              current_frame->stack_top_ctx(),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2882
              TypeOrigin::implicit(top)),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2883
              "Bad type on operand stack");
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2884
            return;
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2885
          }
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2886
        }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2887
      } else if (opcode == Bytecodes::_invokevirtual) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2888
        VerificationType stack_object_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2889
          current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2890
        if (current_type() != stack_object_type) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2891
          if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2892
          assert(cp->cache() == NULL, "not rewritten yet");
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2893
          Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2894
            cp->klass_name_at(cp->klass_ref_index_at(index));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2895
          // See the comments in verify_field_instructions() for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2896
          // the rationale behind this.
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2897
          if (name_in_supers(ref_class_name, current_class())) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2898
            Klass* ref_class = load_class(ref_class_name, CHECK);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2899
            if (is_protected_access(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2900
                  _klass, ref_class, method_name, method_sig, true)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2901
              // It's protected access, check if stack object is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2902
              // assignable to current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2903
              bool is_assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2904
                stack_object_type, this, true, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2905
              if (!is_assignable) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2906
                if (ref_class_type.name() == vmSymbols::java_lang_Object()
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2907
                    && stack_object_type.is_array()
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2908
                    && method_name == vmSymbols::clone_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2909
                  // Special case: arrays pretend to implement public Object
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2910
                  // clone().
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2911
                } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2912
                  verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2913
                      current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2914
                      TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2915
                      "Bad access to protected data in invokevirtual");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2916
                  return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2917
                }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2918
              }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2919
            }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2920
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2921
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2922
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2923
        assert(opcode == Bytecodes::_invokeinterface, "Unexpected opcode encountered");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2924
        current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2925
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2926
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2927
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2928
  // Push the result type.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2929
  if (sig_stream.type() != T_VOID) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2930
    if (method_name == vmSymbols::object_initializer_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2931
      // <init> method must have a void return type
33799
77ebbd9b0ecc 8139164: JVM should throw ClassFormatError for non-void methods named <clinit>
hseigel
parents: 33602
diff changeset
  2932
      /* Unreachable?  Class file parser verifies that methods with '<' have
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2933
       * void return */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2934
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2935
          "Return type must be void in <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2936
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2937
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2938
    VerificationType return_type[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2939
    int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2940
      &sig_stream, return_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2941
    for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2942
      current_frame->push_stack(return_type[i], CHECK_VERIFY(this)); // push types backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2943
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2944
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2945
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2946
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2947
VerificationType ClassVerifier::get_newarray_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2948
    u2 index, u2 bci, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2949
  const char* from_bt[] = {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2950
    NULL, NULL, NULL, NULL, "[Z", "[C", "[F", "[D", "[B", "[S", "[I", "[J",
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2951
  };
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2952
  if (index < T_BOOLEAN || index > T_LONG) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2953
    verify_error(ErrorContext::bad_code(bci), "Illegal newarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2954
    return VerificationType::bogus_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2955
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2956
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2957
  // from_bt[index] contains the array signature which has a length of 2
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2958
  Symbol* sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2959
    from_bt[index], 2, CHECK_(VerificationType::bogus_type()));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2960
  return VerificationType::reference_type(sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2961
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2962
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2963
void ClassVerifier::verify_anewarray(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2964
    u2 bci, u2 index, const constantPoolHandle& cp,
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2965
    StackMapFrame* current_frame, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2966
  verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2967
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2968
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2969
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2970
  if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2971
  VerificationType component_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2972
    cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2973
  int length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2974
  char* arr_sig_str;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2975
  if (component_type.is_array()) {     // it's an array
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2976
    const char* component_name = component_type.name()->as_utf8();
46403
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2977
    // Check for more than MAX_ARRAY_DIMENSIONS
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2978
    length = (int)strlen(component_name);
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2979
    if (length > MAX_ARRAY_DIMENSIONS &&
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2980
        component_name[MAX_ARRAY_DIMENSIONS - 1] == '[') {
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2981
      verify_error(ErrorContext::bad_code(bci),
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2982
        "Illegal anewarray instruction, array has more than 255 dimensions");
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2983
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2984
    // add one dimension to component
46403
f2b91b928476 8178949: The split verifier allows anewarray to create an array of more than 255 dimensions.
hseigel
parents: 46329
diff changeset
  2985
    length++;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2986
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2987
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2988
    strncpy(&arr_sig_str[1], component_name, length - 1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2989
  } else {         // it's an object or interface
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2990
    const char* component_name = component_type.name()->as_utf8();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2991
    // add one dimension to component with 'L' prepended and ';' postpended.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2992
    length = (int)strlen(component_name) + 3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2993
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2994
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2995
    arr_sig_str[1] = 'L';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2996
    strncpy(&arr_sig_str[2], component_name, length - 2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2997
    arr_sig_str[length - 1] = ';';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2998
  }
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2999
  Symbol* arr_sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3000
    arr_sig_str, length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3001
  VerificationType new_array_type = VerificationType::reference_type(arr_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3002
  current_frame->push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3003
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3004
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3005
void ClassVerifier::verify_iload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3006
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3007
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3008
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3009
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3010
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3011
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3012
void ClassVerifier::verify_lload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3013
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3014
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3015
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3016
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3017
    VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3018
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3019
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3020
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3021
void ClassVerifier::verify_fload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3022
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3023
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3024
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3025
    VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3026
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3027
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3028
void ClassVerifier::verify_dload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3029
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3030
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3031
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3032
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3033
    VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3034
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3035
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3036
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3037
void ClassVerifier::verify_aload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3038
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3039
    index, VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3040
  current_frame->push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3041
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3042
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3043
void ClassVerifier::verify_istore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3044
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3045
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3046
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3047
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3048
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3049
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3050
void ClassVerifier::verify_lstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3051
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3052
    VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3053
    VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3054
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3055
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3056
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3057
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3058
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3059
void ClassVerifier::verify_fstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3060
  current_frame->pop_stack(VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3061
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3062
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3063
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3064
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3065
void ClassVerifier::verify_dstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3066
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3067
    VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3068
    VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3069
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3070
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3071
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3072
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3073
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3074
void ClassVerifier::verify_astore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3075
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3076
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3077
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3078
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3079
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3080
void ClassVerifier::verify_iinc(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3081
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3082
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3083
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3084
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3085
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3086
void ClassVerifier::verify_return_value(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3087
    VerificationType return_type, VerificationType type, u2 bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3088
    StackMapFrame* current_frame, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3089
  if (return_type == VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3090
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3091
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3092
        "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3093
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3094
  }
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  3095
  bool match = return_type.is_assignable_from(type, this, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3096
  if (!match) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3097
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3098
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3099
        "Bad return type");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3100
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3101
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3102
}
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3103
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3104
// The verifier creates symbols which are substrings of Symbols.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3105
// These are stored in the verifier until the end of verification so that
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3106
// they can be reference counted.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3107
Symbol* ClassVerifier::create_temporary_symbol(const Symbol *s, int begin,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3108
                                               int end, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3109
  Symbol* sym = SymbolTable::new_symbol(s, begin, end, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3110
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3111
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3112
}
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3113
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3114
Symbol* ClassVerifier::create_temporary_symbol(const char *s, int length, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3115
  Symbol* sym = SymbolTable::new_symbol(s, length, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3116
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3117
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3118
}