hotspot/src/share/vm/classfile/verifier.cpp
author stefank
Mon, 04 Apr 2016 09:15:15 +0200
changeset 37242 91e5f98fff6f
parent 37078 dc9ee85e80d3
child 37261 659ed5b20b48
permissions -rw-r--r--
8152632: Rename LogHandle(...) to Log(...) Reviewed-by: brutisso, mlarsson, rprotacio
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
     2
 * Copyright (c) 1998, 2016, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    25
#include "precompiled.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    26
#include "classfile/classFileStream.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    27
#include "classfile/javaClasses.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    28
#include "classfile/stackMapTable.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    29
#include "classfile/stackMapFrame.hpp"
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    30
#include "classfile/stackMapTableFormat.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    31
#include "classfile/systemDictionary.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    32
#include "classfile/verifier.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    33
#include "classfile/vmSymbols.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    34
#include "interpreter/bytecodes.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    35
#include "interpreter/bytecodeStream.hpp"
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
    36
#include "logging/log.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    37
#include "memory/oopFactory.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    38
#include "memory/resourceArea.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    39
#include "oops/instanceKlass.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    40
#include "oops/oop.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    41
#include "oops/typeArrayOop.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    42
#include "prims/jvm.h"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    43
#include "runtime/fieldDescriptor.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    44
#include "runtime/handles.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    45
#include "runtime/interfaceSupport.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    46
#include "runtime/javaCalls.hpp"
24351
61b33cc6d3cf 8042195: Introduce umbrella header orderAccess.inline.hpp.
goetz
parents: 24322
diff changeset
    47
#include "runtime/orderAccess.inline.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    48
#include "runtime/os.hpp"
31021
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
    49
#include "runtime/thread.hpp"
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
    50
#include "services/threadService.hpp"
25715
d5a8dbdc5150 8049325: Introduce and clean up umbrella headers for the files in the cpu subdirectories.
goetz
parents: 24663
diff changeset
    51
#include "utilities/bytes.hpp"
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
    52
#include "logging/log.hpp"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    53
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
    54
#define NOFAILOVER_MAJOR_VERSION                       51
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
    55
#define NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION  51
16676
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
    56
#define STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION       52
5683
116fea597b5d 6911922: JVM must throw VerifyError for jsr or jsr_w opcodes in class file v.51+
kamg
parents: 4571
diff changeset
    57
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    58
// Access to external entry for VerifyClassCodes - old byte code verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    59
489c9b5090e2 Initial load
duke
parents:
diff changeset
    60
extern "C" {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    61
  typedef jboolean (*verify_byte_codes_fn_t)(JNIEnv *, jclass, char *, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    62
  typedef jboolean (*verify_byte_codes_fn_new_t)(JNIEnv *, jclass, char *, jint, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    64
489c9b5090e2 Initial load
duke
parents:
diff changeset
    65
static void* volatile _verify_byte_codes_fn = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
static volatile jint _is_new_verify_byte_codes_fn = (jint) true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
static void* verify_byte_codes_fn() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
  if (_verify_byte_codes_fn == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
    void *lib_handle = os::native_java_library();
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    72
    void *func = os::dll_lookup(lib_handle, "VerifyClassCodesForMajorVersion");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
    OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
    if (func == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
      OrderAccess::release_store(&_is_new_verify_byte_codes_fn, false);
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    76
      func = os::dll_lookup(lib_handle, "VerifyClassCodes");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
      OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    80
  return (void*)_verify_byte_codes_fn;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
489c9b5090e2 Initial load
duke
parents:
diff changeset
    84
// Methods in Verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    86
bool Verifier::should_verify_for(oop class_loader, bool should_verify_class) {
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    87
  return (class_loader == NULL || !should_verify_class) ?
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
    BytecodeVerificationLocal : BytecodeVerificationRemote;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
489c9b5090e2 Initial load
duke
parents:
diff changeset
    91
bool Verifier::relax_verify_for(oop loader) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    92
  bool trusted = java_lang_ClassLoader::is_trusted_loader(loader);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
  bool need_verify =
489c9b5090e2 Initial load
duke
parents:
diff changeset
    94
    // verifyAll
489c9b5090e2 Initial load
duke
parents:
diff changeset
    95
    (BytecodeVerificationLocal && BytecodeVerificationRemote) ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
    96
    // verifyRemote
489c9b5090e2 Initial load
duke
parents:
diff changeset
    97
    (!BytecodeVerificationLocal && BytecodeVerificationRemote && !trusted);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
  return !need_verify;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   101
void Verifier::trace_class_resolution(Klass* resolve_class, InstanceKlass* verify_class) {
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   102
  assert(verify_class != NULL, "Unexpected null verify_class");
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   103
  ResourceMark rm;
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   104
  Symbol* s = verify_class->source_file_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   105
  const char* source_file = (s != NULL ? s->as_C_string() : NULL);
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   106
  const char* verify = verify_class->external_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   107
  const char* resolve = resolve_class->external_name();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   108
  // print in a single call to reduce interleaving between threads
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   109
  if (source_file != NULL) {
37078
dc9ee85e80d3 8146551: The output from classresolve tag has been shortened and moved to debug level.
mockner
parents: 37044
diff changeset
   110
    log_debug(classresolve)("%s %s %s (verification)", verify, resolve, source_file);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   111
  } else {
37078
dc9ee85e80d3 8146551: The output from classresolve tag has been shortened and moved to debug level.
mockner
parents: 37044
diff changeset
   112
    log_debug(classresolve)("%s %s (verification)", verify, resolve);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   113
  }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   114
}
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   115
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   116
// Prints the end-verification message to the appropriate output.
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   117
void Verifier::log_end_verification(outputStream* st, const char* klassName, Symbol* exception_name, TRAPS) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   118
  if (HAS_PENDING_EXCEPTION) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   119
    st->print("Verification for %s has", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   120
    st->print_cr(" exception pending %s ",
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   121
                 PENDING_EXCEPTION->klass()->external_name());
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   122
  } else if (exception_name != NULL) {
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   123
    st->print_cr("Verification for %s failed", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   124
  }
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   125
  st->print_cr("End class verification for: %s", klassName);
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   126
}
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   127
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   128
bool Verifier::verify(instanceKlassHandle klass, Verifier::Mode mode, bool should_verify_class, TRAPS) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   129
  HandleMark hm;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   130
  ResourceMark rm(THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   131
27159
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   132
  // Eagerly allocate the identity hash code for a klass. This is a fallout
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   133
  // from 6320749 and 8059924: hash code generator is not supposed to be called
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   134
  // during the safepoint, but it allows to sneak the hashcode in during
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   135
  // verification. Without this eager hashcode generation, we may end up
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   136
  // installing the hashcode during some other operation, which may be at
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   137
  // safepoint -- blowing up the checks. It was previously done as the side
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   138
  // effect (sic!) for external_name(), but instead of doing that, we opt to
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   139
  // explicitly push the hashcode in here. This is signify the following block
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   140
  // is IMPORTANT:
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   141
  if (klass->java_mirror() != NULL) {
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   142
    klass->java_mirror()->identity_hash();
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   143
  }
3d2543e475e4 8059924: com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java: assert(Universe::verify_in_progress() || !SafepointSynchronize::is_at_safepoint()) failed: invariant
shade
parents: 27003
diff changeset
   144
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   145
  if (!is_eligible_for_verification(klass, should_verify_class)) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   146
    return true;
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   147
  }
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   148
31021
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   149
  // Timer includes any side effects of class verification (resolution,
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   150
  // etc), but not recursive calls to Verifier::verify().
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   151
  JavaThread* jt = (JavaThread*)THREAD;
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   152
  PerfClassTraceTime timer(ClassLoader::perf_class_verify_time(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   153
                           ClassLoader::perf_class_verify_selftime(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   154
                           ClassLoader::perf_classes_verified(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   155
                           jt->get_thread_stat()->perf_recursion_counts_addr(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   156
                           jt->get_thread_stat()->perf_timers_addr(),
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   157
                           PerfClassTraceTime::CLASS_VERIFY);
1dbe2a0324d6 8076319: jstat verified class fix
hseigel
parents: 30616
diff changeset
   158
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   159
  // If the class should be verified, first see if we can use the split
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   160
  // verifier.  If not, or if verification fails and FailOverToOldVerifier
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   161
  // is set, then call the inference verifier.
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   162
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   163
  Symbol* exception_name = NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   164
  const size_t message_buffer_len = klass->name()->utf8_length() + 1024;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   165
  char* message_buffer = NEW_RESOURCE_ARRAY(char, message_buffer_len);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   166
  char* exception_message = message_buffer;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   167
489c9b5090e2 Initial load
duke
parents:
diff changeset
   168
  const char* klassName = klass->external_name();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   169
  bool can_failover = FailOverToOldVerifier &&
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   170
     klass->major_version() < NOFAILOVER_MAJOR_VERSION;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   171
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   172
  log_info(classinit)("Start class verification for: %s", klassName);
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   173
  if (klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   174
    ClassVerifier split_verifier(klass, THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   175
    split_verifier.verify_class(THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   176
    exception_name = split_verifier.result();
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   177
    if (can_failover && !HAS_PENDING_EXCEPTION &&
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   178
        (exception_name == vmSymbols::java_lang_VerifyError() ||
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   179
         exception_name == vmSymbols::java_lang_ClassFormatError())) {
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   180
      log_info(verboseverification)("Fail over class verification to old verifier for: %s", klassName);
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   181
      log_info(classinit)("Fail over class verification to old verifier for: %s", klassName);
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   182
      exception_name = inference_verify(
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   183
        klass, message_buffer, message_buffer_len, THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   184
    }
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   185
    if (exception_name != NULL) {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   186
      exception_message = split_verifier.exception_message();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   187
    }
27003
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   188
  } else {
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   189
    exception_name = inference_verify(
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   190
        klass, message_buffer, message_buffer_len, THREAD);
19617f4c9dd0 8059595: Verifier::verify is wasting time before is_eligible_for_verification check
shade
parents: 26814
diff changeset
   191
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   192
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   193
  if (log_is_enabled(Info, classinit)){
37242
91e5f98fff6f 8152632: Rename LogHandle(...) to Log(...)
stefank
parents: 37078
diff changeset
   194
    log_end_verification(Log(classinit)::info_stream(), klassName, exception_name, THREAD);
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   195
  }
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   196
  if (log_is_enabled(Info, verboseverification)){
37242
91e5f98fff6f 8152632: Rename LogHandle(...) to Log(...)
stefank
parents: 37078
diff changeset
   197
    log_end_verification(Log(verboseverification)::info_stream(), klassName, exception_name, THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   198
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   199
489c9b5090e2 Initial load
duke
parents:
diff changeset
   200
  if (HAS_PENDING_EXCEPTION) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   201
    return false; // use the existing exception
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   202
  } else if (exception_name == NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   203
    return true; // verifcation succeeded
489c9b5090e2 Initial load
duke
parents:
diff changeset
   204
  } else { // VerifyError or ClassFormatError to be created and thrown
489c9b5090e2 Initial load
duke
parents:
diff changeset
   205
    ResourceMark rm(THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   206
    instanceKlassHandle kls =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   207
      SystemDictionary::resolve_or_fail(exception_name, true, CHECK_false);
37078
dc9ee85e80d3 8146551: The output from classresolve tag has been shortened and moved to debug level.
mockner
parents: 37044
diff changeset
   208
    if (log_is_enabled(Debug, classresolve)) {
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   209
      Verifier::trace_class_resolution(kls(), klass());
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   210
    }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
   211
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   212
    while (!kls.is_null()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   213
      if (kls == klass) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
        // If the class being verified is the exception we're creating
489c9b5090e2 Initial load
duke
parents:
diff changeset
   215
        // or one of it's superclasses, we're in trouble and are going
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
        // to infinitely recurse when we try to initialize the exception.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   217
        // So bail out here by throwing the preallocated VM error.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   218
        THROW_OOP_(Universe::virtual_machine_error_instance(), false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   219
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   220
      kls = kls->super();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   221
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
    message_buffer[message_buffer_len - 1] = '\0'; // just to be sure
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   223
    THROW_MSG_(exception_name, exception_message, false);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   224
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   225
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   226
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   227
bool Verifier::is_eligible_for_verification(instanceKlassHandle klass, bool should_verify_class) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   228
  Symbol* name = klass->name();
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   229
  Klass* refl_magic_klass = SystemDictionary::reflect_MagicAccessorImpl_klass();
19704
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   230
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   231
  bool is_reflect = refl_magic_klass != NULL && klass->is_subtype_of(refl_magic_klass);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   232
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   233
  return (should_verify_for(klass->class_loader(), should_verify_class) &&
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   234
    // return if the class is a bootstrapping class
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   235
    // or defineClass specified not to verify by default (flags override passed arg)
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   236
    // We need to skip the following four for bootstraping
489c9b5090e2 Initial load
duke
parents:
diff changeset
   237
    name != vmSymbols::java_lang_Object() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   238
    name != vmSymbols::java_lang_Class() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   239
    name != vmSymbols::java_lang_String() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   240
    name != vmSymbols::java_lang_Throwable() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   241
489c9b5090e2 Initial load
duke
parents:
diff changeset
   242
    // Can not verify the bytecodes for shared classes because they have
489c9b5090e2 Initial load
duke
parents:
diff changeset
   243
    // already been rewritten to contain constant pool cache indices,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   244
    // which the verifier can't understand.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   245
    // Shared classes shouldn't have stackmaps either.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   246
    !klass()->is_shared() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   247
489c9b5090e2 Initial load
duke
parents:
diff changeset
   248
    // As of the fix for 4486457 we disable verification for all of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
   249
    // dynamically-generated bytecodes associated with the 1.4
489c9b5090e2 Initial load
duke
parents:
diff changeset
   250
    // reflection implementation, not just those associated with
489c9b5090e2 Initial load
duke
parents:
diff changeset
   251
    // sun/reflect/SerializationConstructorAccessor.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   252
    // NOTE: this is called too early in the bootstrapping process to be
24456
8c7933fa5a1f 8025580: Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors
coleenp
parents: 24424
diff changeset
   253
    // guarded by Universe::is_gte_jdk14x_version().
19704
475be20c57de 8023872: Verification error in generated lambda classes
acorn
parents: 19692
diff changeset
   254
    // Also for lambda generated code, gte jdk8
24456
8c7933fa5a1f 8025580: Temporary flags: UseNewReflection and ReflectionWrapResolutionErrors
coleenp
parents: 24424
diff changeset
   255
    (!is_reflect));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   256
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   257
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   258
Symbol* Verifier::inference_verify(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   259
    instanceKlassHandle klass, char* message, size_t message_len, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   260
  JavaThread* thread = (JavaThread*)THREAD;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   261
  JNIEnv *env = thread->jni_environment();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   262
489c9b5090e2 Initial load
duke
parents:
diff changeset
   263
  void* verify_func = verify_byte_codes_fn();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   264
489c9b5090e2 Initial load
duke
parents:
diff changeset
   265
  if (verify_func == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   266
    jio_snprintf(message, message_len, "Could not link verifier");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   267
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   268
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   269
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
  ResourceMark rm(THREAD);
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   271
  log_info(verboseverification)("Verifying class %s with old format", klass->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   272
489c9b5090e2 Initial load
duke
parents:
diff changeset
   273
  jclass cls = (jclass) JNIHandles::make_local(env, klass->java_mirror());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   274
  jint result;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   275
489c9b5090e2 Initial load
duke
parents:
diff changeset
   276
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   277
    HandleMark hm(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   278
    ThreadToNativeFromVM ttn(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   279
    // ThreadToNativeFromVM takes care of changing thread_state, so safepoint
489c9b5090e2 Initial load
duke
parents:
diff changeset
   280
    // code knows that we have left the VM
489c9b5090e2 Initial load
duke
parents:
diff changeset
   281
489c9b5090e2 Initial load
duke
parents:
diff changeset
   282
    if (_is_new_verify_byte_codes_fn) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   283
      verify_byte_codes_fn_new_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   284
        CAST_TO_FN_PTR(verify_byte_codes_fn_new_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   285
      result = (*func)(env, cls, message, (int)message_len,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   286
          klass->major_version());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   287
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   288
      verify_byte_codes_fn_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   289
        CAST_TO_FN_PTR(verify_byte_codes_fn_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   290
      result = (*func)(env, cls, message, (int)message_len);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   291
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   292
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   293
489c9b5090e2 Initial load
duke
parents:
diff changeset
   294
  JNIHandles::destroy_local(cls);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   295
489c9b5090e2 Initial load
duke
parents:
diff changeset
   296
  // These numbers are chosen so that VerifyClassCodes interface doesn't need
489c9b5090e2 Initial load
duke
parents:
diff changeset
   297
  // to be changed (still return jboolean (unsigned char)), and result is
489c9b5090e2 Initial load
duke
parents:
diff changeset
   298
  // 1 when verification is passed.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   299
  if (result == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   300
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   301
  } else if (result == 1) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   302
    return NULL; // verified.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   303
  } else if (result == 2) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   304
    THROW_MSG_(vmSymbols::java_lang_OutOfMemoryError(), message, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   305
  } else if (result == 3) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   306
    return vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   307
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   308
    ShouldNotReachHere();
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   309
    return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   310
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   311
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   312
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   313
TypeOrigin TypeOrigin::null() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   314
  return TypeOrigin();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   315
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   316
TypeOrigin TypeOrigin::local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   317
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   318
  return TypeOrigin(CF_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   319
     frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   320
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   321
TypeOrigin TypeOrigin::stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   322
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   323
  return TypeOrigin(CF_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   324
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   325
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   326
TypeOrigin TypeOrigin::sm_local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   327
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   328
  return TypeOrigin(SM_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   329
      frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   330
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   331
TypeOrigin TypeOrigin::sm_stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   332
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   333
  return TypeOrigin(SM_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   334
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   335
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   336
TypeOrigin TypeOrigin::bad_index(u2 index) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   337
  return TypeOrigin(BAD_INDEX, index, NULL, VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   338
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   339
TypeOrigin TypeOrigin::cp(u2 index, VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   340
  return TypeOrigin(CONST_POOL, index, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   341
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   342
TypeOrigin TypeOrigin::signature(VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   343
  return TypeOrigin(SIG, 0, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   344
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   345
TypeOrigin TypeOrigin::implicit(VerificationType t) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   346
  return TypeOrigin(IMPLICIT, 0, NULL, t);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   347
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   348
TypeOrigin TypeOrigin::frame(StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   349
  return TypeOrigin(FRAME_ONLY, 0, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   350
                    VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   351
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   352
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   353
void TypeOrigin::reset_frame() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   354
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   355
    _frame->restore();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   356
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   357
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   358
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   359
void TypeOrigin::details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   360
  _type.print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   361
  switch (_origin) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   362
    case CF_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   363
      ss->print(" (current frame, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   364
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   365
    case CF_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   366
      ss->print(" (current frame, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   367
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   368
    case SM_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   369
      ss->print(" (stack map, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   370
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   371
    case SM_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   372
      ss->print(" (stack map, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   373
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   374
    case CONST_POOL:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   375
      ss->print(" (constant pool %d)", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   376
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   377
    case SIG:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   378
      ss->print(" (from method signature)");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   379
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   380
    case IMPLICIT:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   381
    case FRAME_ONLY:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   382
    case NONE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   383
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   384
      ;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   385
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   386
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   387
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   388
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   389
void TypeOrigin::print_on(outputStream* str) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   390
  str->print("{%d,%d,%p:", _origin, _index, _frame);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   391
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   392
    _frame->print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   393
  } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   394
    str->print("null");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   395
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   396
  str->print(",");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   397
  _type.print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   398
  str->print("}");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   399
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   400
#endif
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   401
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   402
void ErrorContext::details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   403
  if (is_valid()) {
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   404
    ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   405
    ss->print_cr("Exception Details:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   406
    location_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   407
    reason_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   408
    frame_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   409
    bytecode_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   410
    handler_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   411
    stackmap_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   412
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   413
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   414
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   415
void ErrorContext::reason_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   416
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   417
  ss->indent().print_cr("Reason:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   418
  streamIndentor si2(ss);
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   419
  ss->indent().print("%s", "");
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   420
  switch (_fault) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   421
    case INVALID_BYTECODE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   422
      ss->print("Error exists in the bytecode");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   423
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   424
    case WRONG_TYPE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   425
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   426
        ss->print("Type ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   427
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   428
        ss->print(" is not assignable to ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   429
        _expected.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   430
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   431
        ss->print("Invalid type: ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   432
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   433
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   434
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   435
    case FLAGS_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   436
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   437
        ss->print("Current frame's flags are not assignable "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   438
                  "to stack map frame's.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   439
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   440
        ss->print("Current frame's flags are invalid in this context.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   441
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   442
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   443
    case BAD_CP_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   444
      ss->print("Constant pool index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   445
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   446
    case BAD_LOCAL_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   447
      ss->print("Local index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   448
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   449
    case LOCALS_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   450
      ss->print("Current frame's local size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   451
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   452
    case STACK_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   453
      ss->print("Current frame's stack size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   454
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   455
    case STACK_OVERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   456
      ss->print("Exceeded max stack size.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   457
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   458
    case STACK_UNDERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   459
      ss->print("Attempt to pop empty stack.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   460
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   461
    case MISSING_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   462
      ss->print("Expected stackmap frame at this location.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   463
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   464
    case BAD_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   465
      ss->print("Invalid stackmap specification.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   466
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   467
    case UNKNOWN:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   468
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   469
      ShouldNotReachHere();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   470
      ss->print_cr("Unknown");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   471
  }
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   472
  ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   473
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   474
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   475
void ErrorContext::location_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   476
  if (_bci != -1 && method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   477
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   478
    const char* bytecode_name = "<invalid>";
25714
87fa6860b5ae 8004128: NPG: remove stackwalking in Threads::gc_prologue and gc_epilogue code
coleenp
parents: 24663
diff changeset
   479
    if (method->validate_bci(_bci) != -1) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   480
      Bytecodes::Code code = Bytecodes::code_or_bp_at(method->bcp_from(_bci));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   481
      if (Bytecodes::is_defined(code)) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   482
          bytecode_name = Bytecodes::name(code);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   483
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   484
          bytecode_name = "<illegal>";
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   485
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   486
    }
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
   487
    InstanceKlass* ik = method->method_holder();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   488
    ss->indent().print_cr("Location:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   489
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   490
    ss->indent().print_cr("%s.%s%s @%d: %s",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   491
        ik->name()->as_C_string(), method->name()->as_C_string(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   492
        method->signature()->as_C_string(), _bci, bytecode_name);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   493
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   494
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   495
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   496
void ErrorContext::frame_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   497
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   498
  if (_type.is_valid() && _type.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   499
    ss->indent().print_cr("Current Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   500
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   501
    _type.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   502
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   503
  if (_expected.is_valid() && _expected.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   504
    ss->indent().print_cr("Stackmap Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   505
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   506
    _expected.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   507
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   508
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   509
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   510
void ErrorContext::bytecode_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   511
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   512
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   513
    ss->indent().print_cr("Bytecode:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   514
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   515
    ss->print_data(method->code_base(), method->code_size(), false);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   516
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   517
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   518
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   519
void ErrorContext::handler_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   520
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   521
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   522
    ExceptionTable table(method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   523
    if (table.length() > 0) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   524
      ss->indent().print_cr("Exception Handler Table:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   525
      streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   526
      for (int i = 0; i < table.length(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   527
        ss->indent().print_cr("bci [%d, %d] => handler: %d", table.start_pc(i),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   528
            table.end_pc(i), table.handler_pc(i));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   529
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   530
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   531
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   532
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   533
17370
59a0620561fa 8003557: NPG: Klass* const k should be const Klass* k.
minqi
parents: 16676
diff changeset
   534
void ErrorContext::stackmap_details(outputStream* ss, const Method* method) const {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   535
  if (method != NULL && method->has_stackmap_table()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   536
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   537
    ss->indent().print_cr("Stackmap Table:");
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   538
    Array<u1>* data = method->stackmap_data();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   539
    stack_map_table* sm_table =
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   540
        stack_map_table::at((address)data->adr_at(0));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   541
    stack_map_frame* sm_frame = sm_table->entries();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   542
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   543
    int current_offset = -1;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   544
    for (u2 i = 0; i < sm_table->number_of_entries(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   545
      ss->indent();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   546
      sm_frame->print_on(ss, current_offset);
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   547
      ss->cr();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   548
      current_offset += sm_frame->offset_delta();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   549
      sm_frame = sm_frame->next();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   550
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   551
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   552
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   553
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   554
// Methods in ClassVerifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
   555
489c9b5090e2 Initial load
duke
parents:
diff changeset
   556
ClassVerifier::ClassVerifier(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   557
    instanceKlassHandle klass, TRAPS)
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   558
    : _thread(THREAD), _exception_type(NULL), _message(NULL), _klass(klass) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   559
  _this_type = VerificationType::reference_type(klass->name());
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   560
  // Create list to hold symbols in reference area.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   561
  _symbols = new GrowableArray<Symbol*>(100, 0, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   562
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   563
489c9b5090e2 Initial load
duke
parents:
diff changeset
   564
ClassVerifier::~ClassVerifier() {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   565
  // Decrement the reference count for any symbols created.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   566
  for (int i = 0; i < _symbols->length(); i++) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   567
    Symbol* s = _symbols->at(i);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   568
    s->decrement_refcount();
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   569
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   570
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   571
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   572
VerificationType ClassVerifier::object_type() const {
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   573
  return VerificationType::reference_type(vmSymbols::java_lang_Object());
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   574
}
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   575
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   576
TypeOrigin ClassVerifier::ref_ctx(const char* sig, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   577
  VerificationType vt = VerificationType::reference_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   578
      create_temporary_symbol(sig, (int)strlen(sig), THREAD));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   579
  return TypeOrigin::implicit(vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   580
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   581
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   582
void ClassVerifier::verify_class(TRAPS) {
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   583
  log_info(verboseverification)("Verifying class %s with new format", _klass->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   584
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   585
  Array<Method*>* methods = _klass->methods();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   586
  int num_methods = methods->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   587
489c9b5090e2 Initial load
duke
parents:
diff changeset
   588
  for (int index = 0; index < num_methods; index++) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   589
    // Check for recursive re-verification before each method.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   590
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   591
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   592
    Method* m = methods->at(index);
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   593
    if (m->is_native() || m->is_abstract() || m->is_overpass()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   594
      // If m is native or abstract, skip it.  It is checked in class file
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   595
      // parser that methods do not override a final method.  Overpass methods
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
   596
      // are trusted since the VM generates them.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   597
      continue;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   598
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   599
    verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   600
  }
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   601
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   602
  if (was_recursively_verified()){
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   603
    log_info(verboseverification)("Recursive verification detected for: %s", _klass->external_name());
34628
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   604
    log_info(classinit)("Recursive verification detected for: %s",
6d08ec72803b 8142976: Reimplement TraceClassInitialization with Unified Logging
mockner
parents: 33799
diff changeset
   605
                        _klass->external_name());
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   606
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   607
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   608
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
   609
void ClassVerifier::verify_method(const methodHandle& m, TRAPS) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   610
  HandleMark hm(THREAD);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   611
  _method = m;   // initialize _method
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   612
  log_info(verboseverification)("Verifying method %s", m->name_and_sig_as_C_string());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   613
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   614
// For clang, the only good constant format string is a literal constant format string.
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
   615
#define bad_type_msg "Bad type on operand stack in %s"
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   616
13396
1b2b5f740ee0 7188911: nightly failures after JSR 292 lazy method handle update (round 2)
twisti
parents: 13283
diff changeset
   617
  int32_t max_stack = m->verifier_max_stack();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   618
  int32_t max_locals = m->max_locals();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   619
  constantPoolHandle cp(THREAD, m->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   620
489c9b5090e2 Initial load
duke
parents:
diff changeset
   621
  if (!SignatureVerifier::is_valid_method_signature(m->signature())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   622
    class_format_error("Invalid method signature");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   623
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   624
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   625
489c9b5090e2 Initial load
duke
parents:
diff changeset
   626
  // Initial stack map frame: offset is 0, stack is initially empty.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   627
  StackMapFrame current_frame(max_locals, max_stack, this);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   628
  // Set initial locals
489c9b5090e2 Initial load
duke
parents:
diff changeset
   629
  VerificationType return_type = current_frame.set_locals_from_arg(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   630
    m, current_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   631
489c9b5090e2 Initial load
duke
parents:
diff changeset
   632
  int32_t stackmap_index = 0; // index to the stackmap array
489c9b5090e2 Initial load
duke
parents:
diff changeset
   633
489c9b5090e2 Initial load
duke
parents:
diff changeset
   634
  u4 code_length = m->code_size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   635
489c9b5090e2 Initial load
duke
parents:
diff changeset
   636
  // Scan the bytecode and map each instruction's start offset to a number.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   637
  char* code_data = generate_code_data(m, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   638
489c9b5090e2 Initial load
duke
parents:
diff changeset
   639
  int ex_min = code_length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   640
  int ex_max = -1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   641
  // Look through each item on the exception table. Each of the fields must refer
489c9b5090e2 Initial load
duke
parents:
diff changeset
   642
  // to a legal instruction.
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   643
  if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   644
  verify_exception_handler_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   645
    code_length, code_data, ex_min, ex_max, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   646
489c9b5090e2 Initial load
duke
parents:
diff changeset
   647
  // Look through each entry on the local variable table and make sure
489c9b5090e2 Initial load
duke
parents:
diff changeset
   648
  // its range of code array offsets is valid. (4169817)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   649
  if (m->has_localvariable_table()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   650
    verify_local_variable_table(code_length, code_data, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   651
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   652
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
   653
  Array<u1>* stackmap_data = m->stackmap_data();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   654
  StackMapStream stream(stackmap_data);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   655
  StackMapReader reader(this, &stream, code_data, code_length, THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   656
  StackMapTable stackmap_table(&reader, &current_frame, max_locals, max_stack,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   657
                               code_data, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   658
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   659
  if (log_is_enabled(Info, verboseverification)) {
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   660
    ResourceMark rm(THREAD);
37242
91e5f98fff6f 8152632: Rename LogHandle(...) to Log(...)
stefank
parents: 37078
diff changeset
   661
    stackmap_table.print_on(Log(verboseverification)::info_stream());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   662
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   663
489c9b5090e2 Initial load
duke
parents:
diff changeset
   664
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   665
489c9b5090e2 Initial load
duke
parents:
diff changeset
   666
  // Scan the byte code linearly from the start to the end
489c9b5090e2 Initial load
duke
parents:
diff changeset
   667
  bool no_control_flow = false; // Set to true when there is no direct control
489c9b5090e2 Initial load
duke
parents:
diff changeset
   668
                                // flow from current instruction to the next
489c9b5090e2 Initial load
duke
parents:
diff changeset
   669
                                // instruction in sequence
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
   670
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   671
  Bytecodes::Code opcode;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   672
  while (!bcs.is_last_bytecode()) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   673
    // Check for recursive re-verification before each bytecode.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   674
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   675
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   676
    opcode = bcs.raw_next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   677
    u2 bci = bcs.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   678
489c9b5090e2 Initial load
duke
parents:
diff changeset
   679
    // Set current frame's offset to bci
489c9b5090e2 Initial load
duke
parents:
diff changeset
   680
    current_frame.set_offset(bci);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   681
    current_frame.set_mark();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   682
489c9b5090e2 Initial load
duke
parents:
diff changeset
   683
    // Make sure every offset in stackmap table point to the beginning to
489c9b5090e2 Initial load
duke
parents:
diff changeset
   684
    // an instruction. Match current_frame to stackmap_table entry with
489c9b5090e2 Initial load
duke
parents:
diff changeset
   685
    // the same offset if exists.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   686
    stackmap_index = verify_stackmap_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   687
      stackmap_index, bci, &current_frame, &stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   688
      no_control_flow, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   689
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   690
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   691
    bool this_uninit = false;  // Set to true when invokespecial <init> initialized 'this'
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   692
    bool verified_exc_handlers = false;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   693
489c9b5090e2 Initial load
duke
parents:
diff changeset
   694
    // Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
   695
    {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   696
      u2 index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   697
      int target;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   698
      VerificationType type, type2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   699
      VerificationType atype;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   700
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   701
      if (log_is_enabled(Info, verboseverification)) {
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   702
        ResourceMark rm(THREAD);
37242
91e5f98fff6f 8152632: Rename LogHandle(...) to Log(...)
stefank
parents: 37078
diff changeset
   703
        current_frame.print_on(Log(verboseverification)::info_stream());
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
   704
        log_info(verboseverification)("offset = %d,  opcode = %s", bci, Bytecodes::name(opcode));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   705
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   706
489c9b5090e2 Initial load
duke
parents:
diff changeset
   707
      // Make sure wide instruction is in correct format
489c9b5090e2 Initial load
duke
parents:
diff changeset
   708
      if (bcs.is_wide()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   709
        if (opcode != Bytecodes::_iinc   && opcode != Bytecodes::_iload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   710
            opcode != Bytecodes::_aload  && opcode != Bytecodes::_lload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   711
            opcode != Bytecodes::_istore && opcode != Bytecodes::_astore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   712
            opcode != Bytecodes::_lstore && opcode != Bytecodes::_fload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   713
            opcode != Bytecodes::_dload  && opcode != Bytecodes::_fstore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   714
            opcode != Bytecodes::_dstore) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   715
          /* Unreachable?  RawBytecodeStream's raw_next() returns 'illegal'
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   716
           * if we encounter a wide instruction that modifies an invalid
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   717
           * opcode (not one of the ones listed above) */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   718
          verify_error(ErrorContext::bad_code(bci), "Bad wide instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   719
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   720
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   721
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   722
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   723
      // Look for possible jump target in exception handlers and see if it
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   724
      // matches current_frame.  Do this check here for astore*, dstore*,
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   725
      // fstore*, istore*, and lstore* opcodes because they can change the type
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   726
      // state by adding a local.  JVM Spec says that the incoming type state
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   727
      // should be used for this check.  So, do the check here before a possible
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   728
      // local is added to the type state.
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   729
      if (Bytecodes::is_store_into_local(opcode) && bci >= ex_min && bci < ex_max) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   730
        if (was_recursively_verified()) return;
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   731
        verify_exception_handler_targets(
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   732
          bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   733
        verified_exc_handlers = true;
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   734
      }
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
   735
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   736
      if (was_recursively_verified()) return;
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
   737
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   738
      switch (opcode) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   739
        case Bytecodes::_nop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   740
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   741
        case Bytecodes::_aconst_null :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   742
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   743
            VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   744
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   745
        case Bytecodes::_iconst_m1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   746
        case Bytecodes::_iconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   747
        case Bytecodes::_iconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   748
        case Bytecodes::_iconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   749
        case Bytecodes::_iconst_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   750
        case Bytecodes::_iconst_4 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   751
        case Bytecodes::_iconst_5 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   752
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   753
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   754
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   755
        case Bytecodes::_lconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   756
        case Bytecodes::_lconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   757
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   758
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   759
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   760
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   761
        case Bytecodes::_fconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   762
        case Bytecodes::_fconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   763
        case Bytecodes::_fconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   764
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   765
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   766
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   767
        case Bytecodes::_dconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   768
        case Bytecodes::_dconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   769
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   770
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   771
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   772
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   773
        case Bytecodes::_sipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   774
        case Bytecodes::_bipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   775
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   776
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   777
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   778
        case Bytecodes::_ldc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   779
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   780
            opcode, bcs.get_index_u1(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   781
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   782
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   783
        case Bytecodes::_ldc_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   784
        case Bytecodes::_ldc2_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   785
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   786
            opcode, bcs.get_index_u2(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   787
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   788
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   789
        case Bytecodes::_iload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   790
          verify_iload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   791
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   792
        case Bytecodes::_iload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   793
        case Bytecodes::_iload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   794
        case Bytecodes::_iload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   795
        case Bytecodes::_iload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   796
          index = opcode - Bytecodes::_iload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   797
          verify_iload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   798
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   799
        case Bytecodes::_lload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   800
          verify_lload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   801
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   802
        case Bytecodes::_lload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   803
        case Bytecodes::_lload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   804
        case Bytecodes::_lload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   805
        case Bytecodes::_lload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   806
          index = opcode - Bytecodes::_lload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   807
          verify_lload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   808
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   809
        case Bytecodes::_fload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   810
          verify_fload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   811
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   812
        case Bytecodes::_fload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   813
        case Bytecodes::_fload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   814
        case Bytecodes::_fload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   815
        case Bytecodes::_fload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   816
          index = opcode - Bytecodes::_fload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   817
          verify_fload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   818
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   819
        case Bytecodes::_dload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   820
          verify_dload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   821
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   822
        case Bytecodes::_dload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   823
        case Bytecodes::_dload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   824
        case Bytecodes::_dload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   825
        case Bytecodes::_dload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   826
          index = opcode - Bytecodes::_dload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   827
          verify_dload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   828
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   829
        case Bytecodes::_aload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   830
          verify_aload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   831
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   832
        case Bytecodes::_aload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   833
        case Bytecodes::_aload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   834
        case Bytecodes::_aload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   835
        case Bytecodes::_aload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   836
          index = opcode - Bytecodes::_aload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   837
          verify_aload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   838
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   839
        case Bytecodes::_iaload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   840
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   841
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   842
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   843
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   844
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   845
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   846
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   847
                bad_type_msg, "iaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   848
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   849
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   850
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   851
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   852
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   853
        case Bytecodes::_baload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   854
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   855
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   856
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   857
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   858
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   859
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   860
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   861
                bad_type_msg, "baload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   862
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   863
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   864
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   865
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   866
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   867
        case Bytecodes::_caload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   868
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   869
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   870
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   871
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   872
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   873
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   874
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   875
                bad_type_msg, "caload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   876
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   877
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   878
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   879
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   880
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   881
        case Bytecodes::_saload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   882
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   883
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   884
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   885
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   886
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   887
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   888
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   889
                bad_type_msg, "saload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   890
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   891
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   892
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   893
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   894
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   895
        case Bytecodes::_laload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   896
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   897
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   898
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   899
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   900
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   901
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   902
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   903
                bad_type_msg, "laload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   904
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   905
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   906
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   907
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   908
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   909
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   910
        case Bytecodes::_faload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   911
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   912
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   913
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   914
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   915
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   916
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   917
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   918
                bad_type_msg, "faload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   919
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   920
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   921
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   922
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   923
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   924
        case Bytecodes::_daload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   925
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   926
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   927
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   928
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   929
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   930
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   931
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   932
                bad_type_msg, "daload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   933
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   934
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   935
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   936
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   937
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   938
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   939
        case Bytecodes::_aaload : {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   940
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   941
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   942
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   943
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   944
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   945
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   946
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   947
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   948
                bad_type_msg, "aaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   949
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   950
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   951
          if (atype.is_null()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   952
            current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   953
              VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   954
          } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   955
            VerificationType component =
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   956
              atype.get_component(this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   957
            current_frame.push_stack(component, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   958
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   959
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   960
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   961
        case Bytecodes::_istore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   962
          verify_istore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   963
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   964
        case Bytecodes::_istore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   965
        case Bytecodes::_istore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   966
        case Bytecodes::_istore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   967
        case Bytecodes::_istore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   968
          index = opcode - Bytecodes::_istore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   969
          verify_istore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   970
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   971
        case Bytecodes::_lstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   972
          verify_lstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   973
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   974
        case Bytecodes::_lstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   975
        case Bytecodes::_lstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   976
        case Bytecodes::_lstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   977
        case Bytecodes::_lstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   978
          index = opcode - Bytecodes::_lstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   979
          verify_lstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   980
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   981
        case Bytecodes::_fstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   982
          verify_fstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   983
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   984
        case Bytecodes::_fstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   985
        case Bytecodes::_fstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   986
        case Bytecodes::_fstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   987
        case Bytecodes::_fstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   988
          index = opcode - Bytecodes::_fstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   989
          verify_fstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   990
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   991
        case Bytecodes::_dstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   992
          verify_dstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   993
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   994
        case Bytecodes::_dstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   995
        case Bytecodes::_dstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   996
        case Bytecodes::_dstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   997
        case Bytecodes::_dstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   998
          index = opcode - Bytecodes::_dstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   999
          verify_dstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1000
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1001
        case Bytecodes::_astore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1002
          verify_astore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1003
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1004
        case Bytecodes::_astore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1005
        case Bytecodes::_astore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1006
        case Bytecodes::_astore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1007
        case Bytecodes::_astore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1008
          index = opcode - Bytecodes::_astore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1009
          verify_astore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1010
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1011
        case Bytecodes::_iastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1012
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1013
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1014
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1015
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1016
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1017
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1018
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1019
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1020
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1021
                bad_type_msg, "iastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1022
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1023
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1024
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1025
        case Bytecodes::_bastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1026
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1027
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1028
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1029
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1030
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1031
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1032
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1033
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1034
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1035
                bad_type_msg, "bastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1036
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1037
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1038
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1039
        case Bytecodes::_castore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1040
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1041
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1042
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1043
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1044
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1045
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1046
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1047
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1048
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1049
                bad_type_msg, "castore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1050
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1051
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1052
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1053
        case Bytecodes::_sastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1054
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1055
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1056
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1057
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1058
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1059
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1060
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1061
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1062
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1063
                bad_type_msg, "sastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1064
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1065
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1066
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1067
        case Bytecodes::_lastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1068
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1069
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1070
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1071
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1072
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1073
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1074
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1075
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1076
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1077
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1078
                bad_type_msg, "lastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1079
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1080
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1081
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1082
        case Bytecodes::_fastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1083
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1084
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1085
          current_frame.pop_stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1086
            (VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1087
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1088
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1089
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1090
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1091
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1092
                bad_type_msg, "fastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1093
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1094
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1095
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1096
        case Bytecodes::_dastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1097
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1098
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1099
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1100
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1101
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1102
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1103
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1104
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1105
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1106
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1107
                bad_type_msg, "dastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1108
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1109
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1110
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1111
        case Bytecodes::_aastore :
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1112
          type = current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1113
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1114
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1115
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1116
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1117
          // more type-checking is done at runtime
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1118
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1119
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1120
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1121
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1122
                bad_type_msg, "aastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1123
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1124
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1125
          // 4938384: relaxed constraint in JVMS 3nd edition.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1126
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1127
        case Bytecodes::_pop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1128
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1129
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1130
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1131
        case Bytecodes::_pop2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1132
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1133
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1134
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1135
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1136
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1137
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1138
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1139
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1140
            /* Unreachable? Would need a category2_1st on TOS
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1141
             * which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1142
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1143
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1144
                bad_type_msg, "pop2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1145
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1146
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1147
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1148
        case Bytecodes::_dup :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1149
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1150
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1151
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1152
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1153
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1154
        case Bytecodes::_dup_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1155
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1156
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1157
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1158
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1159
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1160
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1161
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1162
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1163
        case Bytecodes::_dup_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1164
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1165
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1166
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1167
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1168
          type2 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1169
          if (type2.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1170
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1171
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1172
          } else if (type2.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1173
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1174
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1175
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1176
            /* Unreachable? Would need a category2_1st at stack depth 2 with
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1177
             * a category1 on TOS which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1178
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1179
                bci, current_frame.stack_top_ctx()), bad_type_msg, "dup_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1180
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1181
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1182
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1183
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1184
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1185
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1186
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1187
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1188
        case Bytecodes::_dup2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1189
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1190
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1191
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1192
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1193
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1194
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1195
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1196
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1197
            /* Unreachable?  Would need a category2_1st on TOS which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1198
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1199
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1200
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1201
                bad_type_msg, "dup2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1202
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1203
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1204
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1205
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1206
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1207
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1208
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1209
        case Bytecodes::_dup2_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1210
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1211
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1212
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1213
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1214
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1215
              VerificationType::category1_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1216
          } else if (type.is_category2_2nd()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1217
            type2 = current_frame.pop_stack(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1218
              VerificationType::category2_check(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1219
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1220
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1221
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1222
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1223
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1224
                bad_type_msg, "dup2_x1");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1225
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1226
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1227
          type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1228
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1229
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1230
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1231
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1232
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1233
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1234
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1235
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1236
        case Bytecodes::_dup2_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1237
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1238
          VerificationType type3, type4;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1239
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1240
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1241
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1242
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1243
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1244
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1245
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1246
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1247
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1248
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1249
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1250
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1251
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1252
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1253
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1254
          type3 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1255
          if (type3.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1256
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1257
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1258
          } else if (type3.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1259
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1260
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1261
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1262
            /* Unreachable?  Would need a category2_1st on TOS after popping
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1263
             * a long/double or two category 1's, which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1264
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1265
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1266
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1267
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1268
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1269
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1270
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1271
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1272
          current_frame.push_stack(type4, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1273
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1274
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1275
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1276
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1277
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1278
        case Bytecodes::_swap :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1279
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1280
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1281
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1282
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1283
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1284
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1285
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1286
        case Bytecodes::_iadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1287
        case Bytecodes::_isub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1288
        case Bytecodes::_imul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1289
        case Bytecodes::_idiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1290
        case Bytecodes::_irem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1291
        case Bytecodes::_ishl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1292
        case Bytecodes::_ishr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1293
        case Bytecodes::_iushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1294
        case Bytecodes::_ior :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1295
        case Bytecodes::_ixor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1296
        case Bytecodes::_iand :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1297
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1298
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1299
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1300
        case Bytecodes::_ineg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1301
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1302
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1303
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1304
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1305
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1306
        case Bytecodes::_ladd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1307
        case Bytecodes::_lsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1308
        case Bytecodes::_lmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1309
        case Bytecodes::_ldiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1310
        case Bytecodes::_lrem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1311
        case Bytecodes::_land :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1312
        case Bytecodes::_lor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1313
        case Bytecodes::_lxor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1314
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1315
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1316
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1317
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1318
        case Bytecodes::_lneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1319
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1320
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1321
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1322
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1323
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1324
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1325
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1326
        case Bytecodes::_lshl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1327
        case Bytecodes::_lshr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1328
        case Bytecodes::_lushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1329
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1330
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1331
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1332
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1333
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1334
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1335
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1336
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1337
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1338
        case Bytecodes::_fadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1339
        case Bytecodes::_fsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1340
        case Bytecodes::_fmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1341
        case Bytecodes::_fdiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1342
        case Bytecodes::_frem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1343
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1344
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1345
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1346
        case Bytecodes::_fneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1347
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1348
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1349
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1350
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1351
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1352
        case Bytecodes::_dadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1353
        case Bytecodes::_dsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1354
        case Bytecodes::_dmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1355
        case Bytecodes::_ddiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1356
        case Bytecodes::_drem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1357
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1358
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1359
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1360
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1361
        case Bytecodes::_dneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1362
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1363
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1364
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1365
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1366
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1367
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1368
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1369
        case Bytecodes::_iinc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1370
          verify_iinc(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1371
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1372
        case Bytecodes::_i2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1373
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1374
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1375
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1376
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1377
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1378
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1379
       case Bytecodes::_l2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1380
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1381
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1382
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1383
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1384
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1385
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1386
        case Bytecodes::_i2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1387
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1388
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1389
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1390
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1391
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1392
        case Bytecodes::_i2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1393
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1394
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1395
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1396
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1397
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1398
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1399
        case Bytecodes::_l2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1400
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1401
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1402
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1403
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1404
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1405
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1406
        case Bytecodes::_l2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1407
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1408
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1409
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1410
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1411
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1412
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1413
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1414
        case Bytecodes::_f2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1415
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1416
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1417
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1418
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1419
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1420
        case Bytecodes::_f2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1421
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1422
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1423
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1424
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1425
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1426
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1427
        case Bytecodes::_f2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1428
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1429
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1430
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1431
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1432
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1433
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1434
        case Bytecodes::_d2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1435
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1436
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1437
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1438
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1439
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1440
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1441
        case Bytecodes::_d2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1442
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1443
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1444
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1445
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1446
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1447
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1448
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1449
        case Bytecodes::_d2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1450
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1451
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1452
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1453
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1454
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1455
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1456
        case Bytecodes::_i2b :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1457
        case Bytecodes::_i2c :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1458
        case Bytecodes::_i2s :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1459
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1460
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1461
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1462
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1463
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1464
        case Bytecodes::_lcmp :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1465
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1466
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1467
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1468
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1469
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1470
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1471
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1472
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1473
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1474
        case Bytecodes::_fcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1475
        case Bytecodes::_fcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1476
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1477
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1478
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1479
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1480
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1481
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1482
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1483
        case Bytecodes::_dcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1484
        case Bytecodes::_dcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1485
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1486
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1487
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1488
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1489
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1490
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1491
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1492
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1493
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1494
        case Bytecodes::_if_icmpeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1495
        case Bytecodes::_if_icmpne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1496
        case Bytecodes::_if_icmplt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1497
        case Bytecodes::_if_icmpge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1498
        case Bytecodes::_if_icmpgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1499
        case Bytecodes::_if_icmple:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1500
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1501
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1502
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1503
        case Bytecodes::_ifeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1504
        case Bytecodes::_ifne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1505
        case Bytecodes::_iflt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1506
        case Bytecodes::_ifge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1507
        case Bytecodes::_ifgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1508
        case Bytecodes::_ifle:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1509
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1510
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1511
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1512
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1513
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1514
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1515
        case Bytecodes::_if_acmpeq :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1516
        case Bytecodes::_if_acmpne :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1517
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1518
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1519
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1520
        case Bytecodes::_ifnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1521
        case Bytecodes::_ifnonnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1522
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1523
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1524
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1525
          stackmap_table.check_jump_target
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1526
            (&current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1527
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1528
        case Bytecodes::_goto :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1529
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1530
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1531
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1532
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1533
        case Bytecodes::_goto_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1534
          target = bcs.dest_w();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1535
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1536
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1537
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1538
        case Bytecodes::_tableswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1539
        case Bytecodes::_lookupswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1540
          verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1541
            &bcs, code_length, code_data, &current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1542
            &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1543
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1544
        case Bytecodes::_ireturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1545
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1546
            VerificationType::integer_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1547
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1548
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1549
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1550
        case Bytecodes::_lreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1551
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1552
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1553
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1554
            VerificationType::long_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1555
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1556
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1557
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1558
        case Bytecodes::_freturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1559
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1560
            VerificationType::float_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1561
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1562
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1563
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1564
        case Bytecodes::_dreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1565
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1566
            VerificationType::double2_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1567
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1568
            VerificationType::double_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1569
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1570
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1571
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1572
        case Bytecodes::_areturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1573
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1574
            VerificationType::reference_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1575
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1576
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1577
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1578
        case Bytecodes::_return :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1579
          if (return_type != VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1580
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1581
                         "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1582
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1583
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1584
          // Make sure "this" has been initialized if current method is an
33207
edc4431940b2 8139069: JVM should throw ClassFormatError for <init> methods in interfaces
hseigel
parents: 32825
diff changeset
  1585
          // <init>.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1586
          if (_method->name() == vmSymbols::object_initializer_name() &&
33207
edc4431940b2 8139069: JVM should throw ClassFormatError for <init> methods in interfaces
hseigel
parents: 32825
diff changeset
  1587
              current_frame.flag_this_uninit()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1588
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1589
                         "Constructor must call super() or this() "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1590
                         "before return");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1591
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1592
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1593
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1594
        case Bytecodes::_getstatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1595
        case Bytecodes::_putstatic :
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1596
          // pass TRUE, operand can be an array type for getstatic/putstatic.
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1597
          verify_field_instructions(
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1598
            &bcs, &current_frame, cp, true, CHECK_VERIFY(this));
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1599
          no_control_flow = false; break;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1600
        case Bytecodes::_getfield :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1601
        case Bytecodes::_putfield :
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1602
          // pass FALSE, operand can't be an array type for getfield/putfield.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1603
          verify_field_instructions(
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  1604
            &bcs, &current_frame, cp, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1605
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1606
        case Bytecodes::_invokevirtual :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1607
        case Bytecodes::_invokespecial :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1608
        case Bytecodes::_invokestatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1609
          verify_invoke_instructions(
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1610
            &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1611
            &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1612
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1613
        case Bytecodes::_invokeinterface :
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  1614
        case Bytecodes::_invokedynamic :
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1615
          verify_invoke_instructions(
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1616
            &bcs, code_length, &current_frame, (bci >= ex_min && bci < ex_max),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  1617
            &this_uninit, return_type, cp, &stackmap_table, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1618
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1619
        case Bytecodes::_new :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1620
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1621
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1622
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1623
          VerificationType new_class_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1624
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1625
          if (!new_class_type.is_object()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1626
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1627
                TypeOrigin::cp(index, new_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1628
                "Illegal new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1629
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1630
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1631
          type = VerificationType::uninitialized_type(bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1632
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1633
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1634
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1635
        case Bytecodes::_newarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1636
          type = get_newarray_type(bcs.get_index(), bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1637
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1638
            VerificationType::integer_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1639
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1640
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1641
        case Bytecodes::_anewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1642
          verify_anewarray(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1643
            bci, bcs.get_index_u2(), cp, &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1644
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1645
        case Bytecodes::_arraylength :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1646
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1647
            VerificationType::reference_check(), CHECK_VERIFY(this));
381
e7275780f686 6692246: Regression : JDK 6u4 b01 fails two JCK tests when fallback is switched off
kamg
parents: 1
diff changeset
  1648
          if (!(type.is_null() || type.is_array())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1649
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1650
                bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1651
                bad_type_msg, "arraylength");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1652
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1653
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1654
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1655
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1656
        case Bytecodes::_checkcast :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1657
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1658
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1659
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1660
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1661
          VerificationType klass_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1662
            index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1663
          current_frame.push_stack(klass_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1664
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1665
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1666
        case Bytecodes::_instanceof : {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1667
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1668
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1669
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1670
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1671
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1672
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1673
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1674
        case Bytecodes::_monitorenter :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1675
        case Bytecodes::_monitorexit :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1676
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1677
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1678
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1679
        case Bytecodes::_multianewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1680
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1681
          index = bcs.get_index_u2();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1682
          u2 dim = *(bcs.bcp()+3);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1683
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1684
          VerificationType new_array_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1685
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1686
          if (!new_array_type.is_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1687
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1688
                TypeOrigin::cp(index, new_array_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1689
                "Illegal constant pool index in multianewarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1690
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1691
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1692
          if (dim < 1 || new_array_type.dimensions() < dim) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1693
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1694
                "Illegal dimension in multianewarray instruction: %d", dim);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1695
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1696
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1697
          for (int i = 0; i < dim; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1698
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1699
              VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1700
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1701
          current_frame.push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1702
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1703
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1704
        case Bytecodes::_athrow :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1705
          type = VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1706
            vmSymbols::java_lang_Throwable());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1707
          current_frame.pop_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1708
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1709
        default:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1710
          // We only need to check the valid bytecodes in class file.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1711
          // And jsr and ret are not in the new class file format in JDK1.5.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1712
          verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1713
              "Bad instruction: %02x", opcode);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1714
          no_control_flow = false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1715
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1716
      }  // end switch
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1717
    }  // end Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1718
30114
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1719
    // Look for possible jump target in exception handlers and see if it matches
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1720
    // current_frame.  Don't do this check if it has already been done (for
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1721
    // ([a,d,f,i,l]store* opcodes).  This check cannot be done earlier because
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1722
    // opcodes, such as invokespecial, may set the this_uninit flag.
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1723
    assert(!(verified_exc_handlers && this_uninit),
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1724
      "Exception handler targets got verified before this_uninit got set");
daa394b459e6 7127066: Class verifier accepts an invalid class file
hseigel
parents: 30102
diff changeset
  1725
    if (!verified_exc_handlers && bci >= ex_min && bci < ex_max) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1726
      if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1727
      verify_exception_handler_targets(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1728
        bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1729
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1730
  } // end while
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1731
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1732
  // Make sure that control flow does not fall through end of the method
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1733
  if (!no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1734
    verify_error(ErrorContext::bad_code(code_length),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1735
        "Control flow falls through code end");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1736
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1737
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1738
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1739
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  1740
#undef bad_type_message
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  1741
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1742
char* ClassVerifier::generate_code_data(const methodHandle& m, u4 code_length, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1743
  char* code_data = NEW_RESOURCE_ARRAY(char, code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1744
  memset(code_data, 0, sizeof(char) * code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1745
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1746
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1747
  while (!bcs.is_last_bytecode()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1748
    if (bcs.raw_next() != Bytecodes::_illegal) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1749
      int bci = bcs.bci();
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1750
      if (bcs.raw_code() == Bytecodes::_new) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1751
        code_data[bci] = NEW_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1752
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1753
        code_data[bci] = BYTECODE_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1754
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1755
    } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1756
      verify_error(ErrorContext::bad_code(bcs.bci()), "Bad instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1757
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1758
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1759
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1760
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1761
  return code_data;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1762
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1763
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1764
// Since this method references the constant pool, call was_recursively_verified()
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1765
// before calling this method to make sure a prior class load did not cause the
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1766
// current class to get verified.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1767
void ClassVerifier::verify_exception_handler_table(u4 code_length, char* code_data, int& min, int& max, TRAPS) {
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1768
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1769
  int exlength = exhandlers.length();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1770
  constantPoolHandle cp (THREAD, _method->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1771
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1772
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1773
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1774
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1775
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1776
    if (start_pc >= code_length || code_data[start_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1777
      class_format_error("Illegal exception table start_pc %d", start_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1778
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1779
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1780
    if (end_pc != code_length) {   // special case: end_pc == code_length
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1781
      if (end_pc > code_length || code_data[end_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1782
        class_format_error("Illegal exception table end_pc %d", end_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1783
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1784
      }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1785
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1786
    if (handler_pc >= code_length || code_data[handler_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1787
      class_format_error("Illegal exception table handler_pc %d", handler_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1788
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1789
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1790
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1791
    if (catch_type_index != 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1792
      VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1793
        catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1794
      VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1795
        VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1796
      bool is_subclass = throwable.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  1797
        catch_type, this, false, CHECK_VERIFY(this));
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1798
      if (!is_subclass) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1799
        // 4286534: should throw VerifyError according to recent spec change
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1800
        verify_error(ErrorContext::bad_type(handler_pc,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1801
            TypeOrigin::cp(catch_type_index, catch_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1802
            TypeOrigin::implicit(throwable)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1803
            "Catch type is not a subclass "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1804
            "of Throwable in exception handler %d", handler_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1805
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1806
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1807
    }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1808
    if (start_pc < min) min = start_pc;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1809
    if (end_pc > max) max = end_pc;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1810
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1811
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1812
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1813
void ClassVerifier::verify_local_variable_table(u4 code_length, char* code_data, TRAPS) {
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1814
  int localvariable_table_length = _method->localvariable_table_length();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1815
  if (localvariable_table_length > 0) {
35194
7151995ee79e 8144256: compiler/uncommontrap/TestStackBangRbp.java crashes VM on Solaris
coleenp
parents: 34628
diff changeset
  1816
    LocalVariableTableElement* table = _method->localvariable_table_start();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1817
    for (int i = 0; i < localvariable_table_length; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1818
      u2 start_bci = table[i].start_bci;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1819
      u2 length = table[i].length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1820
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1821
      if (start_bci >= code_length || code_data[start_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1822
        class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1823
          "Illegal local variable table start_pc %d", start_bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1824
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1825
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1826
      u4 end_bci = (u4)(start_bci + length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1827
      if (end_bci != code_length) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1828
        if (end_bci >= code_length || code_data[end_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1829
          class_format_error( "Illegal local variable table length %d", length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1830
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1831
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1832
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1833
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1834
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1835
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1836
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1837
u2 ClassVerifier::verify_stackmap_table(u2 stackmap_index, u2 bci,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1838
                                        StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1839
                                        StackMapTable* stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1840
                                        bool no_control_flow, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1841
  if (stackmap_index < stackmap_table->get_frame_count()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1842
    u2 this_offset = stackmap_table->get_offset(stackmap_index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1843
    if (no_control_flow && this_offset > bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1844
      verify_error(ErrorContext::missing_stackmap(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1845
                   "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1846
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1847
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1848
    if (this_offset == bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1849
      ErrorContext ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1850
      // See if current stack map can be assigned to the frame in table.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1851
      // current_frame is the stackmap frame got from the last instruction.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1852
      // If matched, current_frame will be updated by this method.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1853
      bool matches = stackmap_table->match_stackmap(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1854
        current_frame, this_offset, stackmap_index,
25899
337ed0e9c13c 8051012: Regression in verifier for <init> method call from inside of a branch
hseigel
parents: 25719
diff changeset
  1855
        !no_control_flow, true, false, &ctx, CHECK_VERIFY_(this, 0));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1856
      if (!matches) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1857
        // report type error
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1858
        verify_error(ctx, "Instruction type does not match stack map");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1859
        return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1860
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1861
      stackmap_index++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1862
    } else if (this_offset < bci) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1863
      // current_offset should have met this_offset.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1864
      class_format_error("Bad stack map offset %d", this_offset);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1865
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1866
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1867
  } else if (no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1868
    verify_error(ErrorContext::bad_code(bci), "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1869
    return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1870
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1871
  return stackmap_index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1872
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1873
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1874
// Since this method references the constant pool, call was_recursively_verified()
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1875
// before calling this method to make sure a prior class load did not cause the
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1876
// current class to get verified.
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1877
void ClassVerifier::verify_exception_handler_targets(u2 bci, bool this_uninit,
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1878
                                                     StackMapFrame* current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1879
                                                     StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1880
  constantPoolHandle cp (THREAD, _method->constants());
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1881
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1882
  int exlength = exhandlers.length();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1883
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1884
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1885
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1886
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1887
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1888
    if(bci >= start_pc && bci < end_pc) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1889
      u1 flags = current_frame->flags();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1890
      if (this_uninit) {  flags |= FLAG_THIS_UNINIT; }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1891
      StackMapFrame* new_frame = current_frame->frame_in_exception_handler(flags);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1892
      if (catch_type_index != 0) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  1893
        if (was_recursively_verified()) return;
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1894
        // We know that this index refers to a subclass of Throwable
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1895
        VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1896
          catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1897
        new_frame->push_stack(catch_type, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1898
      } else {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1899
        VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1900
          VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1901
        new_frame->push_stack(throwable, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1902
      }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1903
      ErrorContext ctx;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1904
      bool matches = stackmap_table->match_stackmap(
25899
337ed0e9c13c 8051012: Regression in verifier for <init> method call from inside of a branch
hseigel
parents: 25719
diff changeset
  1905
        new_frame, handler_pc, true, false, true, &ctx, CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1906
      if (!matches) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1907
        verify_error(ctx, "Stack map does not match the one at "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1908
            "exception handler %d", handler_pc);
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1909
        return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1910
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1911
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1912
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1913
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1914
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1915
void ClassVerifier::verify_cp_index(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1916
    u2 bci, const constantPoolHandle& cp, int index, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1917
  int nconstants = cp->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1918
  if ((index <= 0) || (index >= nconstants)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1919
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1920
        "Illegal constant pool index %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1921
        index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1922
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1923
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1924
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1925
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1926
void ClassVerifier::verify_cp_type(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1927
    u2 bci, int index, const constantPoolHandle& cp, unsigned int types, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1928
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1929
  // In some situations, bytecode rewriting may occur while we're verifying.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1930
  // In this case, a constant pool cache exists and some indices refer to that
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1931
  // instead.  Be sure we don't pick up such indices by accident.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1932
  // We must check was_recursively_verified() before we get here.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1933
  guarantee(cp->cache() == NULL, "not rewritten yet");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1934
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1935
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1936
  unsigned int tag = cp->tag_at(index).value();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1937
  if ((types & (1 << tag)) == 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1938
    verify_error(ErrorContext::bad_cp_index(bci, index),
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1939
      "Illegal type at constant pool entry %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1940
      index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1941
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1942
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1943
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1944
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1945
void ClassVerifier::verify_cp_class_type(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  1946
    u2 bci, int index, const constantPoolHandle& cp, TRAPS) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1947
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1948
  constantTag tag = cp->tag_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1949
  if (!tag.is_klass() && !tag.is_unresolved_klass()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1950
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1951
        "Illegal type at constant pool entry %d in class %s",
14391
df0a1573d5bd 8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents: 14385
diff changeset
  1952
        index, cp->pool_holder()->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1953
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1954
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1955
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1956
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1957
void ClassVerifier::verify_error(ErrorContext ctx, const char* msg, ...) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1958
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1959
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1960
  ctx.reset_frames();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1961
  _exception_type = vmSymbols::java_lang_VerifyError();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1962
  _error_context = ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1963
  va_list va;
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1964
  va_start(va, msg);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1965
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1966
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1967
  _message = ss.as_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1968
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1969
  ResourceMark rm;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1970
  const char* exception_name = _exception_type->as_C_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1971
  Exceptions::debug_check_abort(exception_name, NULL);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1972
#endif // ndef ASSERT
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1973
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1974
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1975
void ClassVerifier::class_format_error(const char* msg, ...) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1976
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1977
  _exception_type = vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1978
  va_list va;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1979
  va_start(va, msg);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1980
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1981
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1982
  if (!_method.is_null()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1983
    ss.print(" in method %s", _method->name_and_sig_as_C_string());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1984
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1985
  _message = ss.as_string();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1986
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1987
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  1988
Klass* ClassVerifier::load_class(Symbol* name, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1989
  // Get current loader and protection domain first.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1990
  oop loader = current_class()->class_loader();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1991
  oop protection_domain = current_class()->protection_domain();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1992
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  1993
  Klass* kls = SystemDictionary::resolve_or_fail(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1994
    name, Handle(THREAD, loader), Handle(THREAD, protection_domain),
27680
8ecc0871c18e 8064811: Use THREAD instead of CHECK_NULL in return statements
stefank
parents: 27171
diff changeset
  1995
    true, THREAD);
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  1996
37078
dc9ee85e80d3 8146551: The output from classresolve tag has been shortened and moved to debug level.
mockner
parents: 37044
diff changeset
  1997
  if (log_is_enabled(Debug, classresolve)) {
30616
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  1998
    instanceKlassHandle cur_class = current_class();
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  1999
    Verifier::trace_class_resolution(kls, cur_class());
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2000
  }
fde3a4fee412 8076318: split verifier needs to add TraceClassResolution
hseigel
parents: 30114
diff changeset
  2001
  return kls;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2002
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2003
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2004
bool ClassVerifier::is_protected_access(instanceKlassHandle this_class,
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2005
                                        Klass* target_class,
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2006
                                        Symbol* field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2007
                                        Symbol* field_sig,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2008
                                        bool is_method) {
35492
c8c0273e6b91 8146690: Make all classes in GC follow the naming convention.
david
parents: 35219
diff changeset
  2009
  NoSafepointVerifier nosafepoint;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2010
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2011
  // If target class isn't a super class of this class, we don't worry about this case
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2012
  if (!this_class->is_subclass_of(target_class)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2013
    return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2014
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2015
  // Check if the specified method or field is protected
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2016
  InstanceKlass* target_instance = InstanceKlass::cast(target_class);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2017
  fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2018
  if (is_method) {
28731
f7339cba0a6a 8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents: 28612
diff changeset
  2019
    Method* m = target_instance->uncached_lookup_method(field_name, field_sig, Klass::find_overpass);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2020
    if (m != NULL && m->is_protected()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2021
      if (!this_class->is_same_class_package(m->method_holder())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2022
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2023
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2024
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2025
  } else {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2026
    Klass* member_klass = target_instance->find_field(field_name, field_sig, &fd);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2027
    if (member_klass != NULL && fd.is_protected()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2028
      if (!this_class->is_same_class_package(member_klass)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2029
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2030
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2031
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2032
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2033
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2034
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2035
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2036
void ClassVerifier::verify_ldc(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2037
    int opcode, u2 index, StackMapFrame* current_frame,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2038
    const constantPoolHandle& cp, u2 bci, TRAPS) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2039
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2040
  constantTag tag = cp->tag_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2041
  unsigned int types;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2042
  if (opcode == Bytecodes::_ldc || opcode == Bytecodes::_ldc_w) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2043
    if (!tag.is_unresolved_klass()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2044
      types = (1 << JVM_CONSTANT_Integer) | (1 << JVM_CONSTANT_Float)
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2045
            | (1 << JVM_CONSTANT_String)  | (1 << JVM_CONSTANT_Class)
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2046
            | (1 << JVM_CONSTANT_MethodHandle) | (1 << JVM_CONSTANT_MethodType);
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2047
      // Note:  The class file parser already verified the legality of
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2048
      // MethodHandle and MethodType constants.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2049
      verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2050
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2051
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2052
    assert(opcode == Bytecodes::_ldc2_w, "must be ldc2_w");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2053
    types = (1 << JVM_CONSTANT_Double) | (1 << JVM_CONSTANT_Long);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2054
    verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2055
  }
1550
be2fc37a817f 6653858: dynamic languages need to be able to load anonymous classes
jrose
parents: 670
diff changeset
  2056
  if (tag.is_string() && cp->is_pseudo_string_at(index)) {
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  2057
    current_frame->push_stack(object_type(), CHECK_VERIFY(this));
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2058
  } else if (tag.is_string()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2059
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2060
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2061
        vmSymbols::java_lang_String()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2062
  } else if (tag.is_klass() || tag.is_unresolved_klass()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2063
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2064
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2065
        vmSymbols::java_lang_Class()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2066
  } else if (tag.is_int()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2067
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2068
      VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2069
  } else if (tag.is_float()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2070
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2071
      VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2072
  } else if (tag.is_double()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2073
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2074
      VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2075
      VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2076
  } else if (tag.is_long()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2077
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2078
      VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2079
      VerificationType::long2_type(), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2080
  } else if (tag.is_method_handle()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2081
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2082
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2083
        vmSymbols::java_lang_invoke_MethodHandle()), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2084
  } else if (tag.is_method_type()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2085
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2086
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2087
        vmSymbols::java_lang_invoke_MethodType()), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2088
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2089
    /* Unreachable? verify_cp_type has already validated the cp type. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2090
    verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2091
        ErrorContext::bad_cp_index(bci, index), "Invalid index in ldc");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2092
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2093
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2094
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2095
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2096
void ClassVerifier::verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2097
    RawBytecodeStream* bcs, u4 code_length, char* code_data,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2098
    StackMapFrame* current_frame, StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2099
  int bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2100
  address bcp = bcs->bcp();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2101
  address aligned_bcp = (address) round_to((intptr_t)(bcp + 1), jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2102
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2103
  if (_klass->major_version() < NONZERO_PADDING_BYTES_IN_SWITCH_MAJOR_VERSION) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2104
    // 4639449 & 4647081: padding bytes must be 0
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2105
    u2 padding_offset = 1;
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2106
    while ((bcp + padding_offset) < aligned_bcp) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2107
      if(*(bcp + padding_offset) != 0) {
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2108
        verify_error(ErrorContext::bad_code(bci),
24663
48203b12ee8e 8043925: Fix typo in verifier.cpp
coleenp
parents: 24456
diff changeset
  2109
                     "Nonzero padding byte in lookupswitch or tableswitch");
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2110
        return;
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2111
      }
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2112
      padding_offset++;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2113
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2114
  }
16442
a929bb40c0e8 8010667: Non-zero padding is not allowed in splitverifier for tableswitch/lookupswitch instructions.
hseigel
parents: 15736
diff changeset
  2115
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2116
  int default_offset = (int) Bytes::get_Java_u4(aligned_bcp);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2117
  int keys, delta;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2118
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2119
    VerificationType::integer_type(), CHECK_VERIFY(this));
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2120
  if (bcs->raw_code() == Bytecodes::_tableswitch) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2121
    jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2122
    jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2123
    if (low > high) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2124
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2125
          "low must be less than or equal to high in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2126
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2127
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2128
    keys = high - low + 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2129
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2130
      verify_error(ErrorContext::bad_code(bci), "too many keys in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2131
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2132
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2133
    delta = 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2134
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2135
    keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2136
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2137
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2138
                   "number of keys in lookupswitch less than 0");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2139
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2140
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2141
    delta = 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2142
    // Make sure that the lookupswitch items are sorted
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2143
    for (int i = 0; i < (keys - 1); i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2144
      jint this_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2145
      jint next_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i+2)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2146
      if (this_key >= next_key) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2147
        verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2148
                     "Bad lookupswitch instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2149
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2150
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2151
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2152
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2153
  int target = bci + default_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2154
  stackmap_table->check_jump_target(current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2155
  for (int i = 0; i < keys; i++) {
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2156
    // Because check_jump_target() may safepoint, the bytecode could have
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2157
    // moved, which means 'aligned_bcp' is no good and needs to be recalculated.
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2158
    aligned_bcp = (address)round_to((intptr_t)(bcs->bcp() + 1), jintSize);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2159
    target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2160
    stackmap_table->check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2161
      current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2162
  }
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2163
  NOT_PRODUCT(aligned_bcp = NULL);  // no longer valid at this point
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2164
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2165
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2166
bool ClassVerifier::name_in_supers(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2167
    Symbol* ref_name, instanceKlassHandle current) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2168
  Klass* super = current->super();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2169
  while (super != NULL) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2170
    if (super->name() == ref_name) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2171
      return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2172
    }
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2173
    super = super->super();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2174
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2175
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2176
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2177
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2178
void ClassVerifier::verify_field_instructions(RawBytecodeStream* bcs,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2179
                                              StackMapFrame* current_frame,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2180
                                              const constantPoolHandle& cp,
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2181
                                              bool allow_arrays,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2182
                                              TRAPS) {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2183
  u2 index = bcs->get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2184
  verify_cp_type(bcs->bci(), index, cp,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2185
      1 << JVM_CONSTANT_Fieldref, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2186
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2187
  // Get field name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2188
  Symbol* field_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2189
  Symbol* field_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2190
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2191
  if (!SignatureVerifier::is_valid_type_signature(field_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2192
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2193
      "Invalid signature for field in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2194
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2195
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2196
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2197
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2198
  // Get referenced class type
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2199
  VerificationType ref_class_type = cp_ref_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2200
    index, cp, CHECK_VERIFY(this));
28612
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2201
  if (!ref_class_type.is_object() &&
164db20ecb94 8055146: Split Verifier incorrectly throws VerifyError for getstatic of an array field
hseigel
parents: 28371
diff changeset
  2202
    (!allow_arrays || !ref_class_type.is_array())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2203
    verify_error(ErrorContext::bad_type(bcs->bci(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2204
        TypeOrigin::cp(index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2205
        "Expecting reference to class in class %s at constant pool index %d",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2206
        _klass->external_name(), index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2207
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2208
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2209
  VerificationType target_class_type = ref_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2210
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2211
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2212
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2213
  uintptr_t field_type_buffer[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2214
  VerificationType* field_type = (VerificationType*)field_type_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2215
  // If we make a VerificationType[2] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2216
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2217
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2218
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2219
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2220
  SignatureStream sig_stream(field_sig, false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2221
  VerificationType stack_object_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2222
  int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2223
    &sig_stream, field_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2224
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2225
  bool is_assignable;
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2226
  switch (bcs->raw_code()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2227
    case Bytecodes::_getstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2228
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2229
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2230
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2231
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2232
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2233
    case Bytecodes::_putstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2234
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2235
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2236
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2237
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2238
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2239
    case Bytecodes::_getfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2240
      stack_object_type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2241
        target_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2242
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2243
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2244
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2245
      goto check_protected;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2246
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2247
    case Bytecodes::_putfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2248
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2249
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2250
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2251
      stack_object_type = current_frame->pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2252
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2253
      // The JVMS 2nd edition allows field initialization before the superclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2254
      // initializer, if the field is defined within the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2255
      fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2256
      if (stack_object_type == VerificationType::uninitialized_this_type() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2257
          target_class_type.equals(current_type()) &&
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2258
          _klass->find_local_field(field_name, field_sig, &fd)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2259
        stack_object_type = current_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2260
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2261
      is_assignable = target_class_type.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2262
        stack_object_type, this, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2263
      if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2264
        verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2265
            current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2266
            TypeOrigin::cp(index, target_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2267
            "Bad type on operand stack in putfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2268
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2269
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2270
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2271
    check_protected: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2272
      if (_this_type == stack_object_type)
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2273
        break; // stack_object_type must be assignable to _current_class_type
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2274
      if (was_recursively_verified()) return;
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2275
      Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2276
        cp->klass_name_at(cp->klass_ref_index_at(index));
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2277
      if (!name_in_supers(ref_class_name, current_class()))
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2278
        // stack_object_type must be assignable to _current_class_type since:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2279
        // 1. stack_object_type must be assignable to ref_class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2280
        // 2. ref_class must be _current_class or a subclass of it. It can't
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2281
        //    be a superclass of it. See revised JVMS 5.4.4.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2282
        break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2283
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2284
      Klass* ref_class_oop = load_class(ref_class_name, CHECK);
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2285
      if (is_protected_access(current_class(), ref_class_oop, field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2286
                              field_sig, false)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2287
        // It's protected access, check if stack object is assignable to
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2288
        // current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2289
        is_assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2290
          stack_object_type, this, true, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2291
        if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2292
          verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2293
              current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2294
              TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2295
              "Bad access to protected data in getfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2296
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2297
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2298
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2299
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2300
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2301
    default: ShouldNotReachHere();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2302
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2303
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2304
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2305
// Look at the method's handlers.  If the bci is in the handler's try block
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2306
// then check if the handler_pc is already on the stack.  If not, push it
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2307
// unless the handler has already been scanned.
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2308
void ClassVerifier::push_handlers(ExceptionTable* exhandlers,
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2309
                                  GrowableArray<u4>* handler_list,
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2310
                                  GrowableArray<u4>* handler_stack,
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2311
                                  u4 bci) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2312
  int exlength = exhandlers->length();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2313
  for(int x = 0; x < exlength; x++) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2314
    if (bci >= exhandlers->start_pc(x) && bci < exhandlers->end_pc(x)) {
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2315
      u4 exhandler_pc = exhandlers->handler_pc(x);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2316
      if (!handler_list->contains(exhandler_pc)) {
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2317
        handler_stack->append_if_missing(exhandler_pc);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2318
        handler_list->append(exhandler_pc);
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2319
      }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2320
    }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2321
  }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2322
}
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2323
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2324
// Return TRUE if all code paths starting with start_bc_offset end in
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2325
// bytecode athrow or loop.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2326
bool ClassVerifier::ends_in_athrow(u4 start_bc_offset) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2327
  ResourceMark rm;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2328
  // Create bytecode stream.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2329
  RawBytecodeStream bcs(method());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2330
  u4 code_length = method()->code_size();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2331
  bcs.set_start(start_bc_offset);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2332
  u4 target;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2333
  // Create stack for storing bytecode start offsets for if* and *switch.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2334
  GrowableArray<u4>* bci_stack = new GrowableArray<u4>(30);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2335
  // Create stack for handlers for try blocks containing this handler.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2336
  GrowableArray<u4>* handler_stack = new GrowableArray<u4>(30);
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2337
  // Create list of handlers that have been pushed onto the handler_stack
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2338
  // so that handlers embedded inside of their own TRY blocks only get
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2339
  // scanned once.
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2340
  GrowableArray<u4>* handler_list = new GrowableArray<u4>(30);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2341
  // Create list of visited branch opcodes (goto* and if*).
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2342
  GrowableArray<u4>* visited_branches = new GrowableArray<u4>(30);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2343
  ExceptionTable exhandlers(_method());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2344
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2345
  while (true) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2346
    if (bcs.is_last_bytecode()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2347
      // if no more starting offsets to parse or if at the end of the
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2348
      // method then return false.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2349
      if ((bci_stack->is_empty()) || ((u4)bcs.end_bci() == code_length))
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2350
        return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2351
      // Pop a bytecode starting offset and scan from there.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2352
      bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2353
    }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2354
    Bytecodes::Code opcode = bcs.raw_next();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2355
    u4 bci = bcs.bci();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2356
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2357
    // If the bytecode is in a TRY block, push its handlers so they
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2358
    // will get parsed.
30102
d932845db0fe 8075118: JVM stuck in infinite loop during verification
hseigel
parents: 28738
diff changeset
  2359
    push_handlers(&exhandlers, handler_list, handler_stack, bci);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2360
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2361
    switch (opcode) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2362
      case Bytecodes::_if_icmpeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2363
      case Bytecodes::_if_icmpne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2364
      case Bytecodes::_if_icmplt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2365
      case Bytecodes::_if_icmpge:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2366
      case Bytecodes::_if_icmpgt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2367
      case Bytecodes::_if_icmple:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2368
      case Bytecodes::_ifeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2369
      case Bytecodes::_ifne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2370
      case Bytecodes::_iflt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2371
      case Bytecodes::_ifge:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2372
      case Bytecodes::_ifgt:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2373
      case Bytecodes::_ifle:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2374
      case Bytecodes::_if_acmpeq:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2375
      case Bytecodes::_if_acmpne:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2376
      case Bytecodes::_ifnull:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2377
      case Bytecodes::_ifnonnull:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2378
        target = bcs.dest();
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2379
        if (visited_branches->contains(bci)) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2380
          if (bci_stack->is_empty()) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2381
          // Pop a bytecode starting offset and scan from there.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2382
          bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2383
        } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2384
          if (target > bci) { // forward branch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2385
            if (target >= code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2386
            // Push the branch target onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2387
            bci_stack->push(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2388
            // then, scan bytecodes starting with next.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2389
            bcs.set_start(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2390
          } else { // backward branch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2391
            // Push bytecode offset following backward branch onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2392
            bci_stack->push(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2393
            // Check bytecodes starting with branch target.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2394
            bcs.set_start(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2395
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2396
          // Record target so we don't branch here again.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2397
          visited_branches->append(bci);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2398
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2399
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2400
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2401
      case Bytecodes::_goto:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2402
      case Bytecodes::_goto_w:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2403
        target = (opcode == Bytecodes::_goto ? bcs.dest() : bcs.dest_w());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2404
        if (visited_branches->contains(bci)) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2405
          if (bci_stack->is_empty()) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2406
          // Been here before, pop new starting offset from stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2407
          bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2408
        } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2409
          if (target >= code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2410
          // Continue scanning from the target onward.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2411
          bcs.set_start(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2412
          // Record target so we don't branch here again.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2413
          visited_branches->append(bci);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2414
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2415
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2416
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2417
      // Check that all switch alternatives end in 'athrow' bytecodes. Since it
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2418
      // is  difficult to determine where each switch alternative ends, parse
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2419
      // each switch alternative until either hit a 'return', 'athrow', or reach
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2420
      // the end of the method's bytecodes.  This is gross but should be okay
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2421
      // because:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2422
      // 1. tableswitch and lookupswitch byte codes in handlers for ctor explicit
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2423
      //    constructor invocations should be rare.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2424
      // 2. if each switch alternative ends in an athrow then the parsing should be
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2425
      //    short.  If there is no athrow then it is bogus code, anyway.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2426
      case Bytecodes::_lookupswitch:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2427
      case Bytecodes::_tableswitch:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2428
        {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2429
          address aligned_bcp = (address) round_to((intptr_t)(bcs.bcp() + 1), jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2430
          u4 default_offset = Bytes::get_Java_u4(aligned_bcp) + bci;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2431
          int keys, delta;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2432
          if (opcode == Bytecodes::_tableswitch) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2433
            jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2434
            jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2435
            // This is invalid, but let the regular bytecode verifier
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2436
            // report this because the user will get a better error message.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2437
            if (low > high) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2438
            keys = high - low + 1;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2439
            delta = 1;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2440
          } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2441
            keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2442
            delta = 2;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2443
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2444
          // Invalid, let the regular bytecode verifier deal with it.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2445
          if (keys < 0) return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2446
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2447
          // Push the offset of the next bytecode onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2448
          bci_stack->push(bcs.next_bci());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2449
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2450
          // Push the switch alternatives onto the stack.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2451
          for (int i = 0; i < keys; i++) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2452
            u4 target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2453
            if (target > code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2454
            bci_stack->push(target);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2455
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2456
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2457
          // Start bytecode parsing for the switch at the default alternative.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2458
          if (default_offset > code_length) return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2459
          bcs.set_start(default_offset);
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2460
          break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2461
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2462
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2463
      case Bytecodes::_return:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2464
        return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2465
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2466
      case Bytecodes::_athrow:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2467
        {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2468
          if (bci_stack->is_empty()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2469
            if (handler_stack->is_empty()) {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2470
              return true;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2471
            } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2472
              // Parse the catch handlers for try blocks containing athrow.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2473
              bcs.set_start(handler_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2474
            }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2475
          } else {
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2476
            // Pop a bytecode offset and starting scanning from there.
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2477
            bcs.set_start(bci_stack->pop());
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2478
          }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2479
        }
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2480
        break;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2481
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2482
      default:
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2483
        ;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2484
    } // end switch
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2485
  } // end while loop
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2486
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2487
  return false;
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2488
}
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2489
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2490
void ClassVerifier::verify_invoke_init(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2491
    RawBytecodeStream* bcs, u2 ref_class_index, VerificationType ref_class_type,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2492
    StackMapFrame* current_frame, u4 code_length, bool in_try_block,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2493
    bool *this_uninit, const constantPoolHandle& cp, StackMapTable* stackmap_table,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2494
    TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2495
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2496
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2497
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2498
  if (type == VerificationType::uninitialized_this_type()) {
12986
14b117407405 7160757: Problem with hotspot/runtime_classfile
kamg
parents: 9116
diff changeset
  2499
    // The method must be an <init> method of this class or its superclass
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2500
    Klass* superk = current_class()->super();
6172
e1d9c632fa3c 6964170: Verifier crashes
apangin
parents: 5882
diff changeset
  2501
    if (ref_class_type.name() != current_class()->name() &&
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2502
        ref_class_type.name() != superk->name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2503
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2504
          TypeOrigin::implicit(ref_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2505
          TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2506
          "Bad <init> method call");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2507
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2508
    }
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2509
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2510
    // If this invokespecial call is done from inside of a TRY block then make
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2511
    // sure that all catch clause paths end in a throw.  Otherwise, this can
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2512
    // result in returning an incomplete object.
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2513
    if (in_try_block) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2514
      ExceptionTable exhandlers(_method());
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2515
      int exlength = exhandlers.length();
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2516
      for(int i = 0; i < exlength; i++) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2517
        u2 start_pc = exhandlers.start_pc(i);
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2518
        u2 end_pc = exhandlers.end_pc(i);
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2519
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2520
        if (bci >= start_pc && bci < end_pc) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2521
          if (!ends_in_athrow(exhandlers.handler_pc(i))) {
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2522
            verify_error(ErrorContext::bad_code(bci),
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2523
              "Bad <init> method call from after the start of a try block");
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2524
            return;
37044
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2525
          } else if (log_is_enabled(Info, verboseverification)) {
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2526
            ResourceMark rm(THREAD);
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2527
            log_info(verboseverification)("Survived call to ends_in_athrow(): %s",
f1965d5d1055 8150083: Convert VerboseVerification to Unified Logging
rprotacio
parents: 35856
diff changeset
  2528
                                          current_class()->name()->as_C_string());
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2529
          }
25955
8ccc2eddcf22 8050485: super() in a try block in a ctor causes VerifyError
hseigel
parents: 25899
diff changeset
  2530
        }
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2531
      }
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2532
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2533
      // Check the exception handler target stackmaps with the locals from the
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2534
      // incoming stackmap (before initialize_object() changes them to outgoing
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2535
      // state).
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2536
      if (was_recursively_verified()) return;
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2537
      verify_exception_handler_targets(bci, true, current_frame,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2538
                                       stackmap_table, CHECK_VERIFY(this));
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2539
    } // in_try_block
25505
9bd829aeb960 8035119: Fix exceptions to bytecode verification
hseigel
parents: 24663
diff changeset
  2540
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2541
    current_frame->initialize_object(type, current_type());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2542
    *this_uninit = true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2543
  } else if (type.is_uninitialized()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2544
    u2 new_offset = type.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2545
    address new_bcp = bcs->bcp() - bci + new_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2546
    if (new_offset > (code_length - 3) || (*new_bcp) != Bytecodes::_new) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2547
      /* Unreachable?  Stack map parsing ensures valid type and new
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2548
       * instructions have a valid BCI. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2549
      verify_error(ErrorContext::bad_code(new_offset),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2550
                   "Expecting new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2551
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2552
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2553
    u2 new_class_index = Bytes::get_Java_u2(new_bcp + 1);
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2554
    if (was_recursively_verified()) return;
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2555
    verify_cp_class_type(bci, new_class_index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2556
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2557
    // The method must be an <init> method of the indicated class
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2558
    VerificationType new_class_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2559
      new_class_index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2560
    if (!new_class_type.equals(ref_class_type)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2561
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2562
          TypeOrigin::cp(new_class_index, new_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2563
          TypeOrigin::cp(ref_class_index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2564
          "Call to wrong <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2565
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2566
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2567
    // According to the VM spec, if the referent class is a superclass of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2568
    // current class, and is in a different runtime package, and the method is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2569
    // protected, then the objectref must be the current class or a subclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2570
    // of the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2571
    VerificationType objectref_type = new_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2572
    if (name_in_supers(ref_class_type.name(), current_class())) {
28371
92e60e58ba8b 8064335: Null pointer dereference in hotspot/src/share/vm/classfile/verifier.cpp
hseigel
parents: 27680
diff changeset
  2573
      Klass* ref_klass = load_class(ref_class_type.name(), CHECK);
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2574
      if (was_recursively_verified()) return;
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2575
      Method* m = InstanceKlass::cast(ref_klass)->uncached_lookup_method(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2576
        vmSymbols::object_initializer_name(),
23999
22eb7be3d99d 8033150: invokestatic: IncompatibleClassChangeError trying to invoke static method from a parent in presence of conflicting defaults.
lfoltan
parents: 21768
diff changeset
  2577
        cp->signature_ref_at(bcs->get_index_u2()),
28731
f7339cba0a6a 8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents: 28612
diff changeset
  2578
        Klass::find_overpass);
25509
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2579
      // Do nothing if method is not found.  Let resolution detect the error.
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2580
      if (m != NULL) {
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2581
        instanceKlassHandle mh(THREAD, m->method_holder());
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2582
        if (m->is_protected() && !mh->is_same_class_package(_klass())) {
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2583
          bool assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2584
            objectref_type, this, true, CHECK_VERIFY(this));
25509
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2585
          if (!assignable) {
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2586
            verify_error(ErrorContext::bad_type(bci,
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2587
                TypeOrigin::cp(new_class_index, objectref_type),
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2588
                TypeOrigin::implicit(current_type())),
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2589
                "Bad access to protected <init> method");
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2590
            return;
2677915ac7ef 8043454: Test case for 8037157 should not throw a VerifyError
hseigel
parents: 25508
diff changeset
  2591
          }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2592
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2593
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2594
    }
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2595
    // Check the exception handler target stackmaps with the locals from the
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2596
    // incoming stackmap (before initialize_object() changes them to outgoing
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2597
    // state).
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2598
    if (in_try_block) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2599
      if (was_recursively_verified()) return;
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2600
      verify_exception_handler_targets(bci, *this_uninit, current_frame,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2601
                                       stackmap_table, CHECK_VERIFY(this));
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2602
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2603
    current_frame->initialize_object(type, new_class_type);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2604
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2605
    verify_error(ErrorContext::bad_type(bci, current_frame->stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2606
        "Bad operand type when invoking <init>");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2607
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2608
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2609
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2610
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2611
bool ClassVerifier::is_same_or_direct_interface(
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2612
    instanceKlassHandle klass,
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2613
    VerificationType klass_type,
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2614
    VerificationType ref_class_type) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2615
  if (ref_class_type.equals(klass_type)) return true;
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2616
  Array<Klass*>* local_interfaces = klass->local_interfaces();
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2617
  if (local_interfaces != NULL) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2618
    for (int x = 0; x < local_interfaces->length(); x++) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2619
      Klass* k = local_interfaces->at(x);
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2620
      assert (k != NULL && k->is_interface(), "invalid interface");
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2621
      if (ref_class_type.equals(VerificationType::reference_type(k->name()))) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2622
        return true;
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2623
      }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2624
    }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2625
  }
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2626
  return false;
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2627
}
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2628
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2629
void ClassVerifier::verify_invoke_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2630
    RawBytecodeStream* bcs, u4 code_length, StackMapFrame* current_frame,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2631
    bool in_try_block, bool *this_uninit, VerificationType return_type,
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2632
    const constantPoolHandle& cp, StackMapTable* stackmap_table, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2633
  // Make sure the constant pool item is the right type
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2634
  u2 index = bcs->get_index_u2();
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2635
  Bytecodes::Code opcode = bcs->raw_code();
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2636
  unsigned int types;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2637
  switch (opcode) {
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2638
    case Bytecodes::_invokeinterface:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2639
      types = 1 << JVM_CONSTANT_InterfaceMethodref;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2640
      break;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2641
    case Bytecodes::_invokedynamic:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2642
      types = 1 << JVM_CONSTANT_InvokeDynamic;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2643
      break;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2644
    case Bytecodes::_invokespecial:
16676
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2645
    case Bytecodes::_invokestatic:
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2646
      types = (_klass->major_version() < STATIC_METHOD_IN_INTERFACE_MAJOR_VERSION) ?
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2647
        (1 << JVM_CONSTANT_Methodref) :
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2648
        ((1 << JVM_CONSTANT_InterfaceMethodref) | (1 << JVM_CONSTANT_Methodref));
ea5bba2e47e9 8011671: JCK tests on static interface methods fail under b84: Illegal type at constant pool entry 5
bharadwaj
parents: 16445
diff changeset
  2649
      break;
14385
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2650
    default:
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2651
      types = 1 << JVM_CONSTANT_Methodref;
959bbcc16725 7200776: Implement default methods in interfaces
kamg
parents: 13728
diff changeset
  2652
  }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2653
  verify_cp_type(bcs->bci(), index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2654
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2655
  // Get method name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2656
  Symbol* method_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2657
  Symbol* method_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2658
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2659
  if (!SignatureVerifier::is_valid_method_signature(method_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2660
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2661
      "Invalid method signature in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2662
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2663
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2664
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2665
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2666
  // Get referenced class type
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2667
  VerificationType ref_class_type;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2668
  if (opcode == Bytecodes::_invokedynamic) {
24322
c2978d1578e3 8036956: remove EnableInvokeDynamic flag
anoll
parents: 23999
diff changeset
  2669
    if (_klass->major_version() < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2670
      class_format_error(
24424
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  2671
        "invokedynamic instructions not supported by this class file version (%d), class %s",
2658d7834c6e 8037816: Fix for 8036122 breaks build with Xcode5/clang
drchase
parents: 24351
diff changeset
  2672
        _klass->major_version(), _klass->external_name());
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2673
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2674
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2675
  } else {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2676
    ref_class_type = cp_ref_index_to_type(index, cp, CHECK_VERIFY(this));
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2677
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2678
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2679
  // For a small signature length, we just allocate 128 bytes instead
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2680
  // of parsing the signature once to find its size.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2681
  // -3 is for '(', ')' and return descriptor; multiply by 2 is for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2682
  // longs/doubles to be consertive.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2683
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2684
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2685
  uintptr_t on_stack_sig_types_buffer[128];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2686
  // If we make a VerificationType[128] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2687
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2688
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2689
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2690
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2691
  VerificationType* sig_types;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2692
  int size = (method_sig->utf8_length() - 3) * 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2693
  if (size > 128) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2694
    // Long and double occupies two slots here.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2695
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2696
    size = size_it.size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2697
    sig_types = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, VerificationType, size);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2698
  } else{
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2699
    sig_types = (VerificationType*)on_stack_sig_types_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2700
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2701
  SignatureStream sig_stream(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2702
  int sig_i = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2703
  while (!sig_stream.at_return_type()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2704
    sig_i += change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2705
      &sig_stream, &sig_types[sig_i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2706
    sig_stream.next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2707
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2708
  int nargs = sig_i;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2709
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2710
#ifdef ASSERT
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2711
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2712
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2713
    assert(nargs == size_it.size(), "Argument sizes do not match");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2714
    assert(nargs <= (method_sig->utf8_length() - 3) * 2, "estimate of max size isn't conservative enough");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2715
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2716
#endif
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2717
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2718
  // Check instruction operands
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2719
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2720
  if (opcode == Bytecodes::_invokeinterface) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2721
    address bcp = bcs->bcp();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2722
    // 4905268: count operand in invokeinterface should be nargs+1, not nargs.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2723
    // JSR202 spec: The count operand of an invokeinterface instruction is valid if it is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2724
    // the difference between the size of the operand stack before and after the instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2725
    // executes.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2726
    if (*(bcp+3) != (nargs+1)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2727
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2728
          "Inconsistent args count operand in invokeinterface");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2729
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2730
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2731
    if (*(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2732
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2733
          "Fourth operand byte of invokeinterface must be zero");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2734
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2735
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2736
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2737
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2738
  if (opcode == Bytecodes::_invokedynamic) {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2739
    address bcp = bcs->bcp();
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2740
    if (*(bcp+3) != 0 || *(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2741
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2742
          "Third and fourth operand bytes of invokedynamic must be zero");
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2743
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2744
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2745
  }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2746
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2747
  if (method_name->byte_at(0) == '<') {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2748
    // Make sure <init> can only be invoked by invokespecial
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2749
    if (opcode != Bytecodes::_invokespecial ||
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2750
        method_name != vmSymbols::object_initializer_name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2751
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2752
          "Illegal call to internal method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2753
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2754
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2755
  } else if (opcode == Bytecodes::_invokespecial
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2756
             && !is_same_or_direct_interface(current_class(), current_type(), ref_class_type)
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2757
             && !ref_class_type.equals(VerificationType::reference_type(
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2758
                  current_class()->super()->name()))) {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2759
    bool subtype = false;
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2760
    bool have_imr_indirect = cp->tag_at(index).value() == JVM_CONSTANT_InterfaceMethodref;
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2761
    if (!current_class()->is_anonymous()) {
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2762
      subtype = ref_class_type.is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2763
                 current_type(), this, false, CHECK_VERIFY(this));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2764
    } else {
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2765
      VerificationType host_klass_type =
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2766
                        VerificationType::reference_type(current_class()->host_klass()->name());
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2767
      subtype = ref_class_type.is_assignable_from(host_klass_type, this, false, CHECK_VERIFY(this));
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2769
      // If invokespecial of IMR, need to recheck for same or
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2770
      // direct interface relative to the host class
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2771
      have_imr_indirect = (have_imr_indirect &&
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2772
                           !is_same_or_direct_interface(
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2773
                             InstanceKlass::cast(current_class()->host_klass()),
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2774
                             host_klass_type, ref_class_type));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2775
    }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2776
    if (!subtype) {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2777
      verify_error(ErrorContext::bad_code(bci),
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2778
          "Bad invokespecial instruction: "
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2779
          "current class isn't assignable to reference class.");
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2780
       return;
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2781
    } else if (have_imr_indirect) {
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2782
      verify_error(ErrorContext::bad_code(bci),
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2783
          "Bad invokespecial instruction: "
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2784
          "interface method reference is in an indirect superinterface.");
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2785
      return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2786
    }
21768
b7dba4cde1c6 8026065: InterfaceMethodref for invokespecial must name a direct superinterface
hseigel
parents: 21729
diff changeset
  2787
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2788
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2789
  // Match method descriptor with operand stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2790
  for (int i = nargs - 1; i >= 0; i--) {  // Run backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2791
    current_frame->pop_stack(sig_types[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2792
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2793
  // Check objectref on operand stack
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2794
  if (opcode != Bytecodes::_invokestatic &&
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2795
      opcode != Bytecodes::_invokedynamic) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2796
    if (method_name == vmSymbols::object_initializer_name()) {  // <init> method
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2797
      verify_invoke_init(bcs, index, ref_class_type, current_frame,
28512
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2798
        code_length, in_try_block, this_uninit, cp, stackmap_table,
968fe01e1f82 8058982: Better verification of an exceptional invokespecial
hseigel
parents: 28371
diff changeset
  2799
        CHECK_VERIFY(this));
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2800
      if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2801
    } else {   // other methods
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2802
      // Ensures that target class is assignable to method class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2803
      if (opcode == Bytecodes::_invokespecial) {
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2804
        if (!current_class()->is_anonymous()) {
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2805
          current_frame->pop_stack(current_type(), CHECK_VERIFY(this));
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2806
        } else {
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2807
          // anonymous class invokespecial calls: check if the
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2808
          // objectref is a subtype of the host_klass of the current class
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2809
          // to allow an anonymous class to reference methods in the host_klass
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2810
          VerificationType top = current_frame->pop_stack(CHECK_VERIFY(this));
20718
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2811
          VerificationType hosttype =
c4a5c7c1f6c9 8026365: NoClassDefinitionFound for anonymous class invokespecial.
acorn
parents: 20395
diff changeset
  2812
            VerificationType::reference_type(current_class()->host_klass()->name());
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2813
          bool subtype = hosttype.is_assignable_from(top, this, false, CHECK_VERIFY(this));
20395
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2814
          if (!subtype) {
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2815
            verify_error( ErrorContext::bad_type(current_frame->offset(),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2816
              current_frame->stack_top_ctx(),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2817
              TypeOrigin::implicit(top)),
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2818
              "Bad type on operand stack");
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2819
            return;
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2820
          }
55915f609319 8026022: Verifier: allow anon classes to invokespecial host class/intf methods.
acorn
parents: 19704
diff changeset
  2821
        }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2822
      } else if (opcode == Bytecodes::_invokevirtual) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2823
        VerificationType stack_object_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2824
          current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2825
        if (current_type() != stack_object_type) {
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2826
          if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2827
          assert(cp->cache() == NULL, "not rewritten yet");
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2828
          Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2829
            cp->klass_name_at(cp->klass_ref_index_at(index));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2830
          // See the comments in verify_field_instructions() for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2831
          // the rationale behind this.
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2832
          if (name_in_supers(ref_class_name, current_class())) {
13728
882756847a04 6964458: Reimplement class meta-data storage to use native memory
coleenp
parents: 13479
diff changeset
  2833
            Klass* ref_class = load_class(ref_class_name, CHECK);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2834
            if (is_protected_access(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2835
                  _klass, ref_class, method_name, method_sig, true)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2836
              // It's protected access, check if stack object is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2837
              // assignable to current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2838
              bool is_assignable = current_type().is_assignable_from(
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  2839
                stack_object_type, this, true, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2840
              if (!is_assignable) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2841
                if (ref_class_type.name() == vmSymbols::java_lang_Object()
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2842
                    && stack_object_type.is_array()
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2843
                    && method_name == vmSymbols::clone_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2844
                  // Special case: arrays pretend to implement public Object
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2845
                  // clone().
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2846
                } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2847
                  verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2848
                      current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2849
                      TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2850
                      "Bad access to protected data in invokevirtual");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2851
                  return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2852
                }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2853
              }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2854
            }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2855
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2856
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2857
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2858
        assert(opcode == Bytecodes::_invokeinterface, "Unexpected opcode encountered");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2859
        current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2860
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2861
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2862
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2863
  // Push the result type.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2864
  if (sig_stream.type() != T_VOID) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2865
    if (method_name == vmSymbols::object_initializer_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2866
      // <init> method must have a void return type
33799
77ebbd9b0ecc 8139164: JVM should throw ClassFormatError for non-void methods named <clinit>
hseigel
parents: 33602
diff changeset
  2867
      /* Unreachable?  Class file parser verifies that methods with '<' have
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2868
       * void return */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2869
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2870
          "Return type must be void in <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2871
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2872
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2873
    VerificationType return_type[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2874
    int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2875
      &sig_stream, return_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2876
    for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2877
      current_frame->push_stack(return_type[i], CHECK_VERIFY(this)); // push types backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2878
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2879
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2880
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2881
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2882
VerificationType ClassVerifier::get_newarray_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2883
    u2 index, u2 bci, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2884
  const char* from_bt[] = {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2885
    NULL, NULL, NULL, NULL, "[Z", "[C", "[F", "[D", "[B", "[S", "[I", "[J",
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2886
  };
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2887
  if (index < T_BOOLEAN || index > T_LONG) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2888
    verify_error(ErrorContext::bad_code(bci), "Illegal newarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2889
    return VerificationType::bogus_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2890
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2891
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2892
  // from_bt[index] contains the array signature which has a length of 2
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2893
  Symbol* sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2894
    from_bt[index], 2, CHECK_(VerificationType::bogus_type()));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2895
  return VerificationType::reference_type(sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2896
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2897
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2898
void ClassVerifier::verify_anewarray(
33593
60764a78fa5c 8140274: methodHandles and constantPoolHandles should be passed as const references
coleenp
parents: 33207
diff changeset
  2899
    u2 bci, u2 index, const constantPoolHandle& cp,
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2900
    StackMapFrame* current_frame, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2901
  verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2902
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2903
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2904
35856
9a7e9cdf11bf 8137314: vm crash from test java/security/Policy/SignedJar/SignedJarTest.java
hseigel
parents: 35492
diff changeset
  2905
  if (was_recursively_verified()) return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2906
  VerificationType component_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2907
    cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2908
  int length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2909
  char* arr_sig_str;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2910
  if (component_type.is_array()) {     // it's an array
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2911
    const char* component_name = component_type.name()->as_utf8();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2912
    // add one dimension to component
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2913
    length = (int)strlen(component_name) + 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2914
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2915
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2916
    strncpy(&arr_sig_str[1], component_name, length - 1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2917
  } else {         // it's an object or interface
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2918
    const char* component_name = component_type.name()->as_utf8();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2919
    // add one dimension to component with 'L' prepended and ';' postpended.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2920
    length = (int)strlen(component_name) + 3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2921
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2922
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2923
    arr_sig_str[1] = 'L';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2924
    strncpy(&arr_sig_str[2], component_name, length - 2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2925
    arr_sig_str[length - 1] = ';';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2926
  }
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2927
  Symbol* arr_sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2928
    arr_sig_str, length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2929
  VerificationType new_array_type = VerificationType::reference_type(arr_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2930
  current_frame->push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2931
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2932
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2933
void ClassVerifier::verify_iload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2934
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2935
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2936
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2937
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2938
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2939
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2940
void ClassVerifier::verify_lload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2941
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2942
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2943
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2944
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2945
    VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2946
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2947
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2948
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2949
void ClassVerifier::verify_fload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2950
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2951
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2952
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2953
    VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2954
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2955
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2956
void ClassVerifier::verify_dload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2957
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2958
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2959
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2960
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2961
    VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2962
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2963
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2964
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2965
void ClassVerifier::verify_aload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2966
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2967
    index, VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2968
  current_frame->push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2969
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2970
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2971
void ClassVerifier::verify_istore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2972
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2973
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2974
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2975
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2976
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2977
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2978
void ClassVerifier::verify_lstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2979
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2980
    VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2981
    VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2982
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2983
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2984
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2985
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2986
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2987
void ClassVerifier::verify_fstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2988
  current_frame->pop_stack(VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2989
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2990
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2991
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2992
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2993
void ClassVerifier::verify_dstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2994
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2995
    VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2996
    VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2997
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2998
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2999
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3000
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3001
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3002
void ClassVerifier::verify_astore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3003
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3004
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3005
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3006
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3007
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3008
void ClassVerifier::verify_iinc(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3009
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3010
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3011
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3012
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3013
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3014
void ClassVerifier::verify_return_value(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3015
    VerificationType return_type, VerificationType type, u2 bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3016
    StackMapFrame* current_frame, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3017
  if (return_type == VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3018
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3019
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3020
        "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3021
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3022
  }
27022
2db6fe33afc2 8036533: Method for correct defaults
hseigel
parents: 27003
diff changeset
  3023
  bool match = return_type.is_assignable_from(type, this, false, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3024
  if (!match) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3025
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3026
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  3027
        "Bad return type");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3028
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3029
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  3030
}
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3031
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3032
// The verifier creates symbols which are substrings of Symbols.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3033
// These are stored in the verifier until the end of verification so that
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3034
// they can be reference counted.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3035
Symbol* ClassVerifier::create_temporary_symbol(const Symbol *s, int begin,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3036
                                               int end, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3037
  Symbol* sym = SymbolTable::new_symbol(s, begin, end, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3038
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3039
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3040
}
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3041
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3042
Symbol* ClassVerifier::create_temporary_symbol(const char *s, int length, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3043
  Symbol* sym = SymbolTable::new_symbol(s, length, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3044
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3045
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  3046
}