hotspot/src/share/vm/classfile/verifier.cpp
author kamg
Mon, 06 Aug 2012 15:54:45 -0400
changeset 13476 471200fb94fd
parent 13283 a9e7a1234f89
child 13479 a378c53b46f0
permissions -rw-r--r--
7116786: RFE: Detailed information on VerifyErrors Summary: Provide additional detail in VerifyError messages Reviewed-by: sspitsyn, acorn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     1
/*
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
     2
 * Copyright (c) 1998, 2012, Oracle and/or its affiliates. All rights reserved.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     4
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
489c9b5090e2 Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
489c9b5090e2 Initial load
duke
parents:
diff changeset
     7
 * published by the Free Software Foundation.
489c9b5090e2 Initial load
duke
parents:
diff changeset
     8
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
489c9b5090e2 Initial load
duke
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
489c9b5090e2 Initial load
duke
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
489c9b5090e2 Initial load
duke
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
489c9b5090e2 Initial load
duke
parents:
diff changeset
    13
 * accompanied this code).
489c9b5090e2 Initial load
duke
parents:
diff changeset
    14
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
489c9b5090e2 Initial load
duke
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
489c9b5090e2 Initial load
duke
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
489c9b5090e2 Initial load
duke
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4571
diff changeset
    21
 * questions.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    22
 *
489c9b5090e2 Initial load
duke
parents:
diff changeset
    23
 */
489c9b5090e2 Initial load
duke
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    25
#include "precompiled.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    26
#include "classfile/classFileStream.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    27
#include "classfile/javaClasses.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    28
#include "classfile/stackMapTable.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    29
#include "classfile/stackMapFrame.hpp"
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    30
#include "classfile/stackMapTableFormat.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    31
#include "classfile/systemDictionary.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    32
#include "classfile/verifier.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    33
#include "classfile/vmSymbols.hpp"
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
    34
#include "interpreter/bytecodes.hpp"
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    35
#include "interpreter/bytecodeStream.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    36
#include "memory/oopFactory.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    37
#include "memory/resourceArea.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    38
#include "oops/instanceKlass.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    39
#include "oops/oop.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    40
#include "oops/typeArrayOop.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    41
#include "prims/jvm.h"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    42
#include "runtime/fieldDescriptor.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    43
#include "runtime/handles.inline.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    44
#include "runtime/interfaceSupport.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    45
#include "runtime/javaCalls.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    46
#include "runtime/orderAccess.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    47
#include "runtime/os.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    48
#ifdef TARGET_ARCH_x86
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    49
# include "bytes_x86.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    50
#endif
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    51
#ifdef TARGET_ARCH_sparc
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    52
# include "bytes_sparc.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    53
#endif
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    54
#ifdef TARGET_ARCH_zero
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    55
# include "bytes_zero.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 7382
diff changeset
    56
#endif
8107
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    57
#ifdef TARGET_ARCH_arm
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    58
# include "bytes_arm.hpp"
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    59
#endif
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    60
#ifdef TARGET_ARCH_ppc
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    61
# include "bytes_ppc.hpp"
78e5bd944384 7016023: Enable building ARM and PPC from src/closed repository
bobv
parents: 8076
diff changeset
    62
#endif
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    63
5683
116fea597b5d 6911922: JVM must throw VerifyError for jsr or jsr_w opcodes in class file v.51+
kamg
parents: 4571
diff changeset
    64
#define NOFAILOVER_MAJOR_VERSION 51
116fea597b5d 6911922: JVM must throw VerifyError for jsr or jsr_w opcodes in class file v.51+
kamg
parents: 4571
diff changeset
    65
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    66
// Access to external entry for VerifyClassCodes - old byte code verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    67
489c9b5090e2 Initial load
duke
parents:
diff changeset
    68
extern "C" {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    69
  typedef jboolean (*verify_byte_codes_fn_t)(JNIEnv *, jclass, char *, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    70
  typedef jboolean (*verify_byte_codes_fn_new_t)(JNIEnv *, jclass, char *, jint, jint);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    71
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    72
489c9b5090e2 Initial load
duke
parents:
diff changeset
    73
static void* volatile _verify_byte_codes_fn = NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    74
489c9b5090e2 Initial load
duke
parents:
diff changeset
    75
static volatile jint _is_new_verify_byte_codes_fn = (jint) true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    76
489c9b5090e2 Initial load
duke
parents:
diff changeset
    77
static void* verify_byte_codes_fn() {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    78
  if (_verify_byte_codes_fn == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    79
    void *lib_handle = os::native_java_library();
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    80
    void *func = os::dll_lookup(lib_handle, "VerifyClassCodesForMajorVersion");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    81
    OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    82
    if (func == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
    83
      OrderAccess::release_store(&_is_new_verify_byte_codes_fn, false);
7405
e6fc8d3926f8 6348631: remove the use of the HPI library from Hotspot
ikrylov
parents: 7397
diff changeset
    84
      func = os::dll_lookup(lib_handle, "VerifyClassCodes");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    85
      OrderAccess::release_store_ptr(&_verify_byte_codes_fn, func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
    86
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    87
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
    88
  return (void*)_verify_byte_codes_fn;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    89
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    90
489c9b5090e2 Initial load
duke
parents:
diff changeset
    91
489c9b5090e2 Initial load
duke
parents:
diff changeset
    92
// Methods in Verifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
    93
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    94
bool Verifier::should_verify_for(oop class_loader, bool should_verify_class) {
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
    95
  return (class_loader == NULL || !should_verify_class) ?
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
    96
    BytecodeVerificationLocal : BytecodeVerificationRemote;
489c9b5090e2 Initial load
duke
parents:
diff changeset
    97
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
    98
489c9b5090e2 Initial load
duke
parents:
diff changeset
    99
bool Verifier::relax_verify_for(oop loader) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   100
  bool trusted = java_lang_ClassLoader::is_trusted_loader(loader);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   101
  bool need_verify =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   102
    // verifyAll
489c9b5090e2 Initial load
duke
parents:
diff changeset
   103
    (BytecodeVerificationLocal && BytecodeVerificationRemote) ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
   104
    // verifyRemote
489c9b5090e2 Initial load
duke
parents:
diff changeset
   105
    (!BytecodeVerificationLocal && BytecodeVerificationRemote && !trusted);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   106
  return !need_verify;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   107
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   108
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   109
bool Verifier::verify(instanceKlassHandle klass, Verifier::Mode mode, bool should_verify_class, TRAPS) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   110
  HandleMark hm;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   111
  ResourceMark rm(THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   112
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   113
  Symbol* exception_name = NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   114
  const size_t message_buffer_len = klass->name()->utf8_length() + 1024;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   115
  char* message_buffer = NEW_RESOURCE_ARRAY(char, message_buffer_len);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   116
  char* exception_message = message_buffer;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   117
489c9b5090e2 Initial load
duke
parents:
diff changeset
   118
  const char* klassName = klass->external_name();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   119
  bool can_failover = FailOverToOldVerifier &&
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   120
      klass->major_version() < NOFAILOVER_MAJOR_VERSION;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   121
489c9b5090e2 Initial load
duke
parents:
diff changeset
   122
  // If the class should be verified, first see if we can use the split
489c9b5090e2 Initial load
duke
parents:
diff changeset
   123
  // verifier.  If not, or if verification fails and FailOverToOldVerifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
   124
  // is set, then call the inference verifier.
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   125
  if (is_eligible_for_verification(klass, should_verify_class)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   126
    if (TraceClassInitialization) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   127
      tty->print_cr("Start class verification for: %s", klassName);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   128
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   129
    if (UseSplitVerifier &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   130
        klass->major_version() >= STACKMAP_ATTRIBUTE_MAJOR_VERSION) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   131
      ClassVerifier split_verifier(klass, THREAD);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   132
      split_verifier.verify_class(THREAD);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   133
      exception_name = split_verifier.result();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   134
      if (can_failover && !HAS_PENDING_EXCEPTION &&
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   135
          (exception_name == vmSymbols::java_lang_VerifyError() ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
   136
           exception_name == vmSymbols::java_lang_ClassFormatError())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   137
        if (TraceClassInitialization || VerboseVerification) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   138
          tty->print_cr(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   139
            "Fail over class verification to old verifier for: %s", klassName);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   140
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   141
        exception_name = inference_verify(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   142
          klass, message_buffer, message_buffer_len, THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   143
      }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   144
      if (exception_name != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   145
        exception_message = split_verifier.exception_message();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   146
      }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   147
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   148
      exception_name = inference_verify(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   149
          klass, message_buffer, message_buffer_len, THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   150
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   151
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   152
    if (TraceClassInitialization || VerboseVerification) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   153
      if (HAS_PENDING_EXCEPTION) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   154
        tty->print("Verification for %s has", klassName);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   155
        tty->print_cr(" exception pending %s ",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   156
          instanceKlass::cast(PENDING_EXCEPTION->klass())->external_name());
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   157
      } else if (exception_name != NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   158
        tty->print_cr("Verification for %s failed", klassName);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   159
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   160
      tty->print_cr("End class verification for: %s", klassName);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   161
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   162
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   163
489c9b5090e2 Initial load
duke
parents:
diff changeset
   164
  if (HAS_PENDING_EXCEPTION) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   165
    return false; // use the existing exception
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   166
  } else if (exception_name == NULL) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   167
    return true; // verifcation succeeded
489c9b5090e2 Initial load
duke
parents:
diff changeset
   168
  } else { // VerifyError or ClassFormatError to be created and thrown
489c9b5090e2 Initial load
duke
parents:
diff changeset
   169
    ResourceMark rm(THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   170
    instanceKlassHandle kls =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   171
      SystemDictionary::resolve_or_fail(exception_name, true, CHECK_false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   172
    while (!kls.is_null()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   173
      if (kls == klass) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   174
        // If the class being verified is the exception we're creating
489c9b5090e2 Initial load
duke
parents:
diff changeset
   175
        // or one of it's superclasses, we're in trouble and are going
489c9b5090e2 Initial load
duke
parents:
diff changeset
   176
        // to infinitely recurse when we try to initialize the exception.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   177
        // So bail out here by throwing the preallocated VM error.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   178
        THROW_OOP_(Universe::virtual_machine_error_instance(), false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   179
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   180
      kls = kls->super();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   181
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   182
    message_buffer[message_buffer_len - 1] = '\0'; // just to be sure
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   183
    THROW_MSG_(exception_name, exception_message, false);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   184
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   185
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   186
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   187
bool Verifier::is_eligible_for_verification(instanceKlassHandle klass, bool should_verify_class) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   188
  Symbol* name = klass->name();
4571
80b553bddc26 6914300: ciEnv should export all well known classes
never
parents: 4429
diff changeset
   189
  klassOop refl_magic_klass = SystemDictionary::reflect_MagicAccessorImpl_klass();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   190
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   191
  return (should_verify_for(klass->class_loader(), should_verify_class) &&
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   192
    // return if the class is a bootstrapping class
3820
0a8fbbe180db 6830542: Performance: JVM_DefineClass already verified.
acorn
parents: 3261
diff changeset
   193
    // or defineClass specified not to verify by default (flags override passed arg)
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   194
    // We need to skip the following four for bootstraping
489c9b5090e2 Initial load
duke
parents:
diff changeset
   195
    name != vmSymbols::java_lang_Object() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   196
    name != vmSymbols::java_lang_Class() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   197
    name != vmSymbols::java_lang_String() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   198
    name != vmSymbols::java_lang_Throwable() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   199
489c9b5090e2 Initial load
duke
parents:
diff changeset
   200
    // Can not verify the bytecodes for shared classes because they have
489c9b5090e2 Initial load
duke
parents:
diff changeset
   201
    // already been rewritten to contain constant pool cache indices,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   202
    // which the verifier can't understand.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   203
    // Shared classes shouldn't have stackmaps either.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   204
    !klass()->is_shared() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   205
489c9b5090e2 Initial load
duke
parents:
diff changeset
   206
    // As of the fix for 4486457 we disable verification for all of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
   207
    // dynamically-generated bytecodes associated with the 1.4
489c9b5090e2 Initial load
duke
parents:
diff changeset
   208
    // reflection implementation, not just those associated with
489c9b5090e2 Initial load
duke
parents:
diff changeset
   209
    // sun/reflect/SerializationConstructorAccessor.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   210
    // NOTE: this is called too early in the bootstrapping process to be
489c9b5090e2 Initial load
duke
parents:
diff changeset
   211
    // guarded by Universe::is_gte_jdk14x_version()/UseNewReflection.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   212
    (refl_magic_klass == NULL ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
   213
     !klass->is_subtype_of(refl_magic_klass) ||
489c9b5090e2 Initial load
duke
parents:
diff changeset
   214
     VerifyReflectionBytecodes)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   215
  );
489c9b5090e2 Initial load
duke
parents:
diff changeset
   216
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   217
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   218
Symbol* Verifier::inference_verify(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   219
    instanceKlassHandle klass, char* message, size_t message_len, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   220
  JavaThread* thread = (JavaThread*)THREAD;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   221
  JNIEnv *env = thread->jni_environment();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   222
489c9b5090e2 Initial load
duke
parents:
diff changeset
   223
  void* verify_func = verify_byte_codes_fn();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   224
489c9b5090e2 Initial load
duke
parents:
diff changeset
   225
  if (verify_func == NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   226
    jio_snprintf(message, message_len, "Could not link verifier");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   227
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   228
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   229
489c9b5090e2 Initial load
duke
parents:
diff changeset
   230
  ResourceMark rm(THREAD);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   231
  if (VerboseVerification) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   232
    tty->print_cr("Verifying class %s with old format", klass->external_name());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   233
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   234
489c9b5090e2 Initial load
duke
parents:
diff changeset
   235
  jclass cls = (jclass) JNIHandles::make_local(env, klass->java_mirror());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   236
  jint result;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   237
489c9b5090e2 Initial load
duke
parents:
diff changeset
   238
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   239
    HandleMark hm(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   240
    ThreadToNativeFromVM ttn(thread);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   241
    // ThreadToNativeFromVM takes care of changing thread_state, so safepoint
489c9b5090e2 Initial load
duke
parents:
diff changeset
   242
    // code knows that we have left the VM
489c9b5090e2 Initial load
duke
parents:
diff changeset
   243
489c9b5090e2 Initial load
duke
parents:
diff changeset
   244
    if (_is_new_verify_byte_codes_fn) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   245
      verify_byte_codes_fn_new_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   246
        CAST_TO_FN_PTR(verify_byte_codes_fn_new_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   247
      result = (*func)(env, cls, message, (int)message_len,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   248
          klass->major_version());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   249
    } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   250
      verify_byte_codes_fn_t func =
489c9b5090e2 Initial load
duke
parents:
diff changeset
   251
        CAST_TO_FN_PTR(verify_byte_codes_fn_t, verify_func);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   252
      result = (*func)(env, cls, message, (int)message_len);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   253
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   254
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   255
489c9b5090e2 Initial load
duke
parents:
diff changeset
   256
  JNIHandles::destroy_local(cls);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   257
489c9b5090e2 Initial load
duke
parents:
diff changeset
   258
  // These numbers are chosen so that VerifyClassCodes interface doesn't need
489c9b5090e2 Initial load
duke
parents:
diff changeset
   259
  // to be changed (still return jboolean (unsigned char)), and result is
489c9b5090e2 Initial load
duke
parents:
diff changeset
   260
  // 1 when verification is passed.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   261
  if (result == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   262
    return vmSymbols::java_lang_VerifyError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   263
  } else if (result == 1) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   264
    return NULL; // verified.
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   265
  } else if (result == 2) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   266
    THROW_MSG_(vmSymbols::java_lang_OutOfMemoryError(), message, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   267
  } else if (result == 3) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   268
    return vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   269
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   270
    ShouldNotReachHere();
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   271
    return NULL;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   272
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   273
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   274
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   275
TypeOrigin TypeOrigin::null() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   276
  return TypeOrigin();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   277
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   278
TypeOrigin TypeOrigin::local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   279
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   280
  return TypeOrigin(CF_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   281
     frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   282
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   283
TypeOrigin TypeOrigin::stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   284
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   285
  return TypeOrigin(CF_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   286
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   287
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   288
TypeOrigin TypeOrigin::sm_local(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   289
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   290
  return TypeOrigin(SM_LOCALS, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   291
      frame->local_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   292
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   293
TypeOrigin TypeOrigin::sm_stack(u2 index, StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   294
  assert(frame != NULL, "Must have a frame");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   295
  return TypeOrigin(SM_STACK, index, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   296
      frame->stack_at(index));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   297
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   298
TypeOrigin TypeOrigin::bad_index(u2 index) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   299
  return TypeOrigin(BAD_INDEX, index, NULL, VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   300
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   301
TypeOrigin TypeOrigin::cp(u2 index, VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   302
  return TypeOrigin(CONST_POOL, index, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   303
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   304
TypeOrigin TypeOrigin::signature(VerificationType vt) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   305
  return TypeOrigin(SIG, 0, NULL, vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   306
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   307
TypeOrigin TypeOrigin::implicit(VerificationType t) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   308
  return TypeOrigin(IMPLICIT, 0, NULL, t);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   309
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   310
TypeOrigin TypeOrigin::frame(StackMapFrame* frame) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   311
  return TypeOrigin(FRAME_ONLY, 0, StackMapFrame::copy(frame),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   312
                    VerificationType::bogus_type());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   313
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   314
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   315
void TypeOrigin::reset_frame() {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   316
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   317
    _frame->restore();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   318
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   319
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   320
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   321
void TypeOrigin::details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   322
  _type.print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   323
  switch (_origin) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   324
    case CF_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   325
      ss->print(" (current frame, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   326
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   327
    case CF_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   328
      ss->print(" (current frame, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   329
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   330
    case SM_LOCALS:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   331
      ss->print(" (stack map, locals[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   332
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   333
    case SM_STACK:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   334
      ss->print(" (stack map, stack[%d])", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   335
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   336
    case CONST_POOL:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   337
      ss->print(" (constant pool %d)", _index);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   338
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   339
    case SIG:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   340
      ss->print(" (from method signature)");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   341
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   342
    case IMPLICIT:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   343
    case FRAME_ONLY:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   344
    case NONE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   345
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   346
      ;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   347
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   348
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   349
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   350
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   351
void TypeOrigin::print_on(outputStream* str) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   352
  str->print("{%d,%d,%p:", _origin, _index, _frame);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   353
  if (_frame != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   354
    _frame->print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   355
  } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   356
    str->print("null");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   357
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   358
  str->print(",");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   359
  _type.print_on(str);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   360
  str->print("}");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   361
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   362
#endif
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   363
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   364
void ErrorContext::details(outputStream* ss, methodOop method) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   365
  if (is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   366
    ss->print_cr("");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   367
    ss->print_cr("Exception Details:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   368
    location_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   369
    reason_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   370
    frame_details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   371
    bytecode_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   372
    handler_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   373
    stackmap_details(ss, method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   374
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   375
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   376
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   377
void ErrorContext::reason_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   378
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   379
  ss->indent().print_cr("Reason:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   380
  streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   381
  ss->indent().print("");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   382
  switch (_fault) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   383
    case INVALID_BYTECODE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   384
      ss->print("Error exists in the bytecode");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   385
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   386
    case WRONG_TYPE:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   387
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   388
        ss->print("Type ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   389
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   390
        ss->print(" is not assignable to ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   391
        _expected.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   392
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   393
        ss->print("Invalid type: ");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   394
        _type.details(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   395
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   396
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   397
    case FLAGS_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   398
      if (_expected.is_valid()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   399
        ss->print("Current frame's flags are not assignable "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   400
                  "to stack map frame's.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   401
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   402
        ss->print("Current frame's flags are invalid in this context.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   403
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   404
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   405
    case BAD_CP_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   406
      ss->print("Constant pool index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   407
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   408
    case BAD_LOCAL_INDEX:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   409
      ss->print("Local index %d is invalid", _type.index());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   410
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   411
    case LOCALS_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   412
      ss->print("Current frame's local size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   413
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   414
    case STACK_SIZE_MISMATCH:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   415
      ss->print("Current frame's stack size doesn't match stackmap.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   416
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   417
    case STACK_OVERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   418
      ss->print("Exceeded max stack size.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   419
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   420
    case STACK_UNDERFLOW:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   421
      ss->print("Attempt to pop empty stack.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   422
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   423
    case MISSING_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   424
      ss->print("Expected stackmap frame at this location.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   425
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   426
    case BAD_STACKMAP:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   427
      ss->print("Invalid stackmap specification.");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   428
      break;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   429
    case UNKNOWN:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   430
    default:
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   431
      ShouldNotReachHere();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   432
      ss->print_cr("Unknown");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   433
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   434
  ss->print_cr("");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   435
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   436
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   437
void ErrorContext::location_details(outputStream* ss, methodOop method) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   438
  if (_bci != -1 && method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   439
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   440
    const char* bytecode_name = "<invalid>";
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   441
    if (method->validate_bci_from_bcx(_bci) != -1) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   442
      Bytecodes::Code code = Bytecodes::code_or_bp_at(method->bcp_from(_bci));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   443
      if (Bytecodes::is_defined(code)) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   444
          bytecode_name = Bytecodes::name(code);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   445
      } else {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   446
          bytecode_name = "<illegal>";
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   447
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   448
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   449
    instanceKlass* ik = instanceKlass::cast(method->method_holder());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   450
    ss->indent().print_cr("Location:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   451
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   452
    ss->indent().print_cr("%s.%s%s @%d: %s",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   453
        ik->name()->as_C_string(), method->name()->as_C_string(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   454
        method->signature()->as_C_string(), _bci, bytecode_name);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   455
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   456
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   457
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   458
void ErrorContext::frame_details(outputStream* ss) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   459
  streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   460
  if (_type.is_valid() && _type.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   461
    ss->indent().print_cr("Current Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   462
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   463
    _type.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   464
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   465
  if (_expected.is_valid() && _expected.frame() != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   466
    ss->indent().print_cr("Stackmap Frame:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   467
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   468
    _expected.frame()->print_on(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   469
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   470
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   471
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   472
void ErrorContext::bytecode_details(outputStream* ss, methodOop method) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   473
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   474
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   475
    ss->indent().print_cr("Bytecode:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   476
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   477
    ss->print_data(method->code_base(), method->code_size(), false);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   478
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   479
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   480
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   481
void ErrorContext::handler_details(outputStream* ss, methodOop method) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   482
  if (method != NULL) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   483
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   484
    ExceptionTable table(method);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   485
    if (table.length() > 0) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   486
      ss->indent().print_cr("Exception Handler Table:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   487
      streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   488
      for (int i = 0; i < table.length(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   489
        ss->indent().print_cr("bci [%d, %d] => handler: %d", table.start_pc(i),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   490
            table.end_pc(i), table.handler_pc(i));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   491
      }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   492
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   493
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   494
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   495
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   496
void ErrorContext::stackmap_details(outputStream* ss, methodOop method) const {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   497
  if (method != NULL && method->has_stackmap_table()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   498
    streamIndentor si(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   499
    ss->indent().print_cr("Stackmap Table:");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   500
    typeArrayOop data = method->stackmap_data();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   501
    stack_map_table* sm_table =
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   502
        stack_map_table::at((address)data->byte_at_addr(0));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   503
    stack_map_frame* sm_frame = sm_table->entries();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   504
    streamIndentor si2(ss);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   505
    int current_offset = -1;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   506
    for (u2 i = 0; i < sm_table->number_of_entries(); ++i) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   507
      ss->indent();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   508
      sm_frame->print_on(ss, current_offset);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   509
      ss->print_cr("");
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   510
      current_offset += sm_frame->offset_delta();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   511
      sm_frame = sm_frame->next();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   512
    }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   513
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   514
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   515
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   516
// Methods in ClassVerifier
489c9b5090e2 Initial load
duke
parents:
diff changeset
   517
489c9b5090e2 Initial load
duke
parents:
diff changeset
   518
ClassVerifier::ClassVerifier(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   519
    instanceKlassHandle klass, TRAPS)
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   520
    : _thread(THREAD), _exception_type(NULL), _message(NULL), _klass(klass) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   521
  _this_type = VerificationType::reference_type(klass->name());
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   522
  // Create list to hold symbols in reference area.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   523
  _symbols = new GrowableArray<Symbol*>(100, 0, NULL);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   524
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   525
489c9b5090e2 Initial load
duke
parents:
diff changeset
   526
ClassVerifier::~ClassVerifier() {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   527
  // Decrement the reference count for any symbols created.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   528
  for (int i = 0; i < _symbols->length(); i++) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   529
    Symbol* s = _symbols->at(i);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   530
    s->decrement_refcount();
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   531
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   532
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   533
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   534
VerificationType ClassVerifier::object_type() const {
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   535
  return VerificationType::reference_type(vmSymbols::java_lang_Object());
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   536
}
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
   537
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   538
TypeOrigin ClassVerifier::ref_ctx(const char* sig, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   539
  VerificationType vt = VerificationType::reference_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   540
      create_temporary_symbol(sig, (int)strlen(sig), THREAD));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   541
  return TypeOrigin::implicit(vt);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   542
}
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   543
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   544
void ClassVerifier::verify_class(TRAPS) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   545
  if (VerboseVerification) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   546
    tty->print_cr("Verifying class %s with new format",
489c9b5090e2 Initial load
duke
parents:
diff changeset
   547
      _klass->external_name());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   548
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   549
489c9b5090e2 Initial load
duke
parents:
diff changeset
   550
  objArrayHandle methods(THREAD, _klass->methods());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   551
  int num_methods = methods->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   552
489c9b5090e2 Initial load
duke
parents:
diff changeset
   553
  for (int index = 0; index < num_methods; index++) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   554
    // Check for recursive re-verification before each method.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   555
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   556
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   557
    methodOop m = (methodOop)methods->obj_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   558
    if (m->is_native() || m->is_abstract()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   559
      // If m is native or abstract, skip it.  It is checked in class file
489c9b5090e2 Initial load
duke
parents:
diff changeset
   560
      // parser that methods do not override a final method.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   561
      continue;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   562
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   563
    verify_method(methodHandle(THREAD, m), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   564
  }
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   565
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   566
  if (VerboseVerification || TraceClassInitialization) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   567
    if (was_recursively_verified())
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   568
      tty->print_cr("Recursive verification detected for: %s",
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   569
          _klass->external_name());
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   570
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   571
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
   572
489c9b5090e2 Initial load
duke
parents:
diff changeset
   573
void ClassVerifier::verify_method(methodHandle m, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   574
  _method = m;   // initialize _method
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   575
  if (VerboseVerification) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   576
    tty->print_cr("Verifying method %s", m->name_and_sig_as_C_string());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   577
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   578
489c9b5090e2 Initial load
duke
parents:
diff changeset
   579
  const char* bad_type_msg = "Bad type on operand stack in %s";
489c9b5090e2 Initial load
duke
parents:
diff changeset
   580
489c9b5090e2 Initial load
duke
parents:
diff changeset
   581
  int32_t max_stack = m->max_stack();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   582
  int32_t max_locals = m->max_locals();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   583
  constantPoolHandle cp(THREAD, m->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   584
489c9b5090e2 Initial load
duke
parents:
diff changeset
   585
  if (!SignatureVerifier::is_valid_method_signature(m->signature())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   586
    class_format_error("Invalid method signature");
489c9b5090e2 Initial load
duke
parents:
diff changeset
   587
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   588
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   589
489c9b5090e2 Initial load
duke
parents:
diff changeset
   590
  // Initial stack map frame: offset is 0, stack is initially empty.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   591
  StackMapFrame current_frame(max_locals, max_stack, this);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   592
  // Set initial locals
489c9b5090e2 Initial load
duke
parents:
diff changeset
   593
  VerificationType return_type = current_frame.set_locals_from_arg(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   594
    m, current_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   595
489c9b5090e2 Initial load
duke
parents:
diff changeset
   596
  int32_t stackmap_index = 0; // index to the stackmap array
489c9b5090e2 Initial load
duke
parents:
diff changeset
   597
489c9b5090e2 Initial load
duke
parents:
diff changeset
   598
  u4 code_length = m->code_size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   599
489c9b5090e2 Initial load
duke
parents:
diff changeset
   600
  // Scan the bytecode and map each instruction's start offset to a number.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   601
  char* code_data = generate_code_data(m, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   602
489c9b5090e2 Initial load
duke
parents:
diff changeset
   603
  int ex_min = code_length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   604
  int ex_max = -1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   605
  // Look through each item on the exception table. Each of the fields must refer
489c9b5090e2 Initial load
duke
parents:
diff changeset
   606
  // to a legal instruction.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   607
  verify_exception_handler_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   608
    code_length, code_data, ex_min, ex_max, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   609
489c9b5090e2 Initial load
duke
parents:
diff changeset
   610
  // Look through each entry on the local variable table and make sure
489c9b5090e2 Initial load
duke
parents:
diff changeset
   611
  // its range of code array offsets is valid. (4169817)
489c9b5090e2 Initial load
duke
parents:
diff changeset
   612
  if (m->has_localvariable_table()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   613
    verify_local_variable_table(code_length, code_data, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   614
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   615
489c9b5090e2 Initial load
duke
parents:
diff changeset
   616
  typeArrayHandle stackmap_data(THREAD, m->stackmap_data());
489c9b5090e2 Initial load
duke
parents:
diff changeset
   617
  StackMapStream stream(stackmap_data);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   618
  StackMapReader reader(this, &stream, code_data, code_length, THREAD);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   619
  StackMapTable stackmap_table(&reader, &current_frame, max_locals, max_stack,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   620
                               code_data, code_length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   621
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   622
  if (VerboseVerification) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   623
    stackmap_table.print_on(tty);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   624
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   625
489c9b5090e2 Initial load
duke
parents:
diff changeset
   626
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
   627
489c9b5090e2 Initial load
duke
parents:
diff changeset
   628
  // Scan the byte code linearly from the start to the end
489c9b5090e2 Initial load
duke
parents:
diff changeset
   629
  bool no_control_flow = false; // Set to true when there is no direct control
489c9b5090e2 Initial load
duke
parents:
diff changeset
   630
                                // flow from current instruction to the next
489c9b5090e2 Initial load
duke
parents:
diff changeset
   631
                                // instruction in sequence
489c9b5090e2 Initial load
duke
parents:
diff changeset
   632
  Bytecodes::Code opcode;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   633
  while (!bcs.is_last_bytecode()) {
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   634
    // Check for recursive re-verification before each bytecode.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   635
    if (was_recursively_verified())  return;
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
   636
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   637
    opcode = bcs.raw_next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   638
    u2 bci = bcs.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
   639
489c9b5090e2 Initial load
duke
parents:
diff changeset
   640
    // Set current frame's offset to bci
489c9b5090e2 Initial load
duke
parents:
diff changeset
   641
    current_frame.set_offset(bci);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   642
    current_frame.set_mark();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   643
489c9b5090e2 Initial load
duke
parents:
diff changeset
   644
    // Make sure every offset in stackmap table point to the beginning to
489c9b5090e2 Initial load
duke
parents:
diff changeset
   645
    // an instruction. Match current_frame to stackmap_table entry with
489c9b5090e2 Initial load
duke
parents:
diff changeset
   646
    // the same offset if exists.
489c9b5090e2 Initial load
duke
parents:
diff changeset
   647
    stackmap_index = verify_stackmap_table(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   648
      stackmap_index, bci, &current_frame, &stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
   649
      no_control_flow, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   650
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   651
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   652
    bool this_uninit = false;  // Set to true when invokespecial <init> initialized 'this'
489c9b5090e2 Initial load
duke
parents:
diff changeset
   653
489c9b5090e2 Initial load
duke
parents:
diff changeset
   654
    // Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
   655
    {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   656
      u2 index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   657
      int target;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   658
      VerificationType type, type2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   659
      VerificationType atype;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   660
489c9b5090e2 Initial load
duke
parents:
diff changeset
   661
#ifndef PRODUCT
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   662
      if (VerboseVerification) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   663
        current_frame.print_on(tty);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   664
        tty->print_cr("offset = %d,  opcode = %s", bci, Bytecodes::name(opcode));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   665
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   666
#endif
489c9b5090e2 Initial load
duke
parents:
diff changeset
   667
489c9b5090e2 Initial load
duke
parents:
diff changeset
   668
      // Make sure wide instruction is in correct format
489c9b5090e2 Initial load
duke
parents:
diff changeset
   669
      if (bcs.is_wide()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   670
        if (opcode != Bytecodes::_iinc   && opcode != Bytecodes::_iload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   671
            opcode != Bytecodes::_aload  && opcode != Bytecodes::_lload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   672
            opcode != Bytecodes::_istore && opcode != Bytecodes::_astore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   673
            opcode != Bytecodes::_lstore && opcode != Bytecodes::_fload  &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   674
            opcode != Bytecodes::_dload  && opcode != Bytecodes::_fstore &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
   675
            opcode != Bytecodes::_dstore) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   676
          /* Unreachable?  RawBytecodeStream's raw_next() returns 'illegal'
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   677
           * if we encounter a wide instruction that modifies an invalid
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   678
           * opcode (not one of the ones listed above) */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   679
          verify_error(ErrorContext::bad_code(bci), "Bad wide instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   680
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   681
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   682
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   683
489c9b5090e2 Initial load
duke
parents:
diff changeset
   684
      switch (opcode) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   685
        case Bytecodes::_nop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   686
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   687
        case Bytecodes::_aconst_null :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   688
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   689
            VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   690
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   691
        case Bytecodes::_iconst_m1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   692
        case Bytecodes::_iconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   693
        case Bytecodes::_iconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   694
        case Bytecodes::_iconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   695
        case Bytecodes::_iconst_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   696
        case Bytecodes::_iconst_4 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   697
        case Bytecodes::_iconst_5 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   698
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   699
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   700
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   701
        case Bytecodes::_lconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   702
        case Bytecodes::_lconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   703
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   704
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   705
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   706
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   707
        case Bytecodes::_fconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   708
        case Bytecodes::_fconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   709
        case Bytecodes::_fconst_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   710
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   711
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   712
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   713
        case Bytecodes::_dconst_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   714
        case Bytecodes::_dconst_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   715
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   716
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   717
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   718
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   719
        case Bytecodes::_sipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   720
        case Bytecodes::_bipush :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   721
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   722
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   723
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   724
        case Bytecodes::_ldc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   725
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   726
            opcode, bcs.get_index_u1(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   727
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   728
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   729
        case Bytecodes::_ldc_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   730
        case Bytecodes::_ldc2_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   731
          verify_ldc(
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
   732
            opcode, bcs.get_index_u2(), &current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   733
            cp, bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   734
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   735
        case Bytecodes::_iload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   736
          verify_iload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   737
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   738
        case Bytecodes::_iload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   739
        case Bytecodes::_iload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   740
        case Bytecodes::_iload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   741
        case Bytecodes::_iload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   742
          index = opcode - Bytecodes::_iload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   743
          verify_iload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   744
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   745
        case Bytecodes::_lload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   746
          verify_lload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   747
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   748
        case Bytecodes::_lload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   749
        case Bytecodes::_lload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   750
        case Bytecodes::_lload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   751
        case Bytecodes::_lload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   752
          index = opcode - Bytecodes::_lload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   753
          verify_lload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   754
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   755
        case Bytecodes::_fload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   756
          verify_fload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   757
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   758
        case Bytecodes::_fload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   759
        case Bytecodes::_fload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   760
        case Bytecodes::_fload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   761
        case Bytecodes::_fload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   762
          index = opcode - Bytecodes::_fload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   763
          verify_fload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   764
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   765
        case Bytecodes::_dload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   766
          verify_dload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   767
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   768
        case Bytecodes::_dload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   769
        case Bytecodes::_dload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   770
        case Bytecodes::_dload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   771
        case Bytecodes::_dload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   772
          index = opcode - Bytecodes::_dload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   773
          verify_dload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   774
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   775
        case Bytecodes::_aload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   776
          verify_aload(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   777
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   778
        case Bytecodes::_aload_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   779
        case Bytecodes::_aload_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   780
        case Bytecodes::_aload_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   781
        case Bytecodes::_aload_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   782
          index = opcode - Bytecodes::_aload_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   783
          verify_aload(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   784
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   785
        case Bytecodes::_iaload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   786
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   787
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   788
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   789
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   790
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   791
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   792
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   793
                bad_type_msg, "iaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   794
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   795
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   796
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   797
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   798
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   799
        case Bytecodes::_baload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   800
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   801
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   802
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   803
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   804
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   805
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   806
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   807
                bad_type_msg, "baload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   808
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   809
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   810
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   811
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   812
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   813
        case Bytecodes::_caload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   814
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   815
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   816
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   817
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   818
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   819
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   820
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   821
                bad_type_msg, "caload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   822
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   823
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   824
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   825
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   826
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   827
        case Bytecodes::_saload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   828
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   829
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   830
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   831
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   832
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   833
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   834
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   835
                bad_type_msg, "saload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   836
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   837
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   838
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   839
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   840
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   841
        case Bytecodes::_laload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   842
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   843
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   844
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   845
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   846
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   847
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   848
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   849
                bad_type_msg, "laload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   850
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   851
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   852
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   853
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   854
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   855
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   856
        case Bytecodes::_faload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   857
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   858
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   859
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   860
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   861
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   862
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   863
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   864
                bad_type_msg, "faload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   865
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   866
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   867
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   868
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   869
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   870
        case Bytecodes::_daload :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   871
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   872
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   873
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   874
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   875
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   876
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   877
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   878
                bad_type_msg, "daload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   879
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   880
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   881
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   882
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
   883
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   884
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   885
        case Bytecodes::_aaload : {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   886
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   887
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   888
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   889
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   890
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   891
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   892
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   893
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   894
                bad_type_msg, "aaload");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   895
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   896
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   897
          if (atype.is_null()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   898
            current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   899
              VerificationType::null_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   900
          } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
   901
            VerificationType component =
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
   902
              atype.get_component(this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   903
            current_frame.push_stack(component, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   904
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   905
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   906
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   907
        case Bytecodes::_istore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   908
          verify_istore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   909
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   910
        case Bytecodes::_istore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   911
        case Bytecodes::_istore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   912
        case Bytecodes::_istore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   913
        case Bytecodes::_istore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   914
          index = opcode - Bytecodes::_istore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   915
          verify_istore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   916
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   917
        case Bytecodes::_lstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   918
          verify_lstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   919
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   920
        case Bytecodes::_lstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   921
        case Bytecodes::_lstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   922
        case Bytecodes::_lstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   923
        case Bytecodes::_lstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   924
          index = opcode - Bytecodes::_lstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   925
          verify_lstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   926
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   927
        case Bytecodes::_fstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   928
          verify_fstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   929
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   930
        case Bytecodes::_fstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   931
        case Bytecodes::_fstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   932
        case Bytecodes::_fstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   933
        case Bytecodes::_fstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   934
          index = opcode - Bytecodes::_fstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   935
          verify_fstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   936
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   937
        case Bytecodes::_dstore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   938
          verify_dstore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   939
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   940
        case Bytecodes::_dstore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   941
        case Bytecodes::_dstore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   942
        case Bytecodes::_dstore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   943
        case Bytecodes::_dstore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   944
          index = opcode - Bytecodes::_dstore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   945
          verify_dstore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   946
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   947
        case Bytecodes::_astore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   948
          verify_astore(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   949
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   950
        case Bytecodes::_astore_0 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   951
        case Bytecodes::_astore_1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   952
        case Bytecodes::_astore_2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   953
        case Bytecodes::_astore_3 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   954
          index = opcode - Bytecodes::_astore_0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   955
          verify_astore(index, &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   956
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   957
        case Bytecodes::_iastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   958
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   959
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   960
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   961
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   962
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   963
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   964
          if (!atype.is_int_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   965
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   966
                current_frame.stack_top_ctx(), ref_ctx("[I", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   967
                bad_type_msg, "iastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   968
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   969
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   970
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   971
        case Bytecodes::_bastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   972
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   973
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   974
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   975
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   976
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   977
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   978
          if (!atype.is_bool_array() && !atype.is_byte_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   979
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   980
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   981
                bad_type_msg, "bastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   982
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   983
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   984
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   985
        case Bytecodes::_castore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
   986
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   987
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   988
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   989
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   990
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
   991
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
   992
          if (!atype.is_char_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   993
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   994
                current_frame.stack_top_ctx(), ref_ctx("[C", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
   995
                bad_type_msg, "castore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
   996
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   997
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
   998
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
   999
        case Bytecodes::_sastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1000
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1001
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1002
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1003
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1004
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1005
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1006
          if (!atype.is_short_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1007
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1008
                current_frame.stack_top_ctx(), ref_ctx("[S", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1009
                bad_type_msg, "sastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1010
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1011
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1012
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1013
        case Bytecodes::_lastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1014
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1015
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1016
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1017
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1018
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1019
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1020
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1021
          if (!atype.is_long_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1022
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1023
                current_frame.stack_top_ctx(), ref_ctx("[J", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1024
                bad_type_msg, "lastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1025
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1026
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1027
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1028
        case Bytecodes::_fastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1029
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1030
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1031
          current_frame.pop_stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1032
            (VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1033
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1034
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1035
          if (!atype.is_float_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1036
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1037
                current_frame.stack_top_ctx(), ref_ctx("[F", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1038
                bad_type_msg, "fastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1039
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1040
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1041
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1042
        case Bytecodes::_dastore :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1043
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1044
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1045
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1046
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1047
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1048
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1049
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1050
          if (!atype.is_double_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1051
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1052
                current_frame.stack_top_ctx(), ref_ctx("[D", THREAD)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1053
                bad_type_msg, "dastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1054
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1055
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1056
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1057
        case Bytecodes::_aastore :
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1058
          type = current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1059
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1060
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1061
          atype = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1062
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1063
          // more type-checking is done at runtime
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1064
          if (!atype.is_reference_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1065
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1066
                current_frame.stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1067
                TypeOrigin::implicit(VerificationType::reference_check())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1068
                bad_type_msg, "aastore");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1069
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1070
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1071
          // 4938384: relaxed constraint in JVMS 3nd edition.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1072
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1073
        case Bytecodes::_pop :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1074
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1075
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1076
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1077
        case Bytecodes::_pop2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1078
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1079
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1080
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1081
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1082
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1083
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1084
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1085
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1086
            /* Unreachable? Would need a category2_1st on TOS
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1087
             * which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1088
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1089
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1090
                bad_type_msg, "pop2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1091
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1092
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1093
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1094
        case Bytecodes::_dup :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1095
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1096
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1097
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1098
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1099
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1100
        case Bytecodes::_dup_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1101
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1102
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1103
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1104
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1105
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1106
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1107
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1108
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1109
        case Bytecodes::_dup_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1110
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1111
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1112
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1113
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1114
          type2 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1115
          if (type2.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1116
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1117
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1118
          } else if (type2.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1119
            type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1120
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1121
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1122
            /* Unreachable? Would need a category2_1st at stack depth 2 with
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1123
             * a category1 on TOS which does not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1124
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1125
                bci, current_frame.stack_top_ctx()), bad_type_msg, "dup_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1126
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1127
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1128
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1129
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1130
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1131
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1132
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1133
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1134
        case Bytecodes::_dup2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1135
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1136
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1137
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1138
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1139
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1140
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1141
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1142
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1143
            /* Unreachable?  Would need a category2_1st on TOS which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1144
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1145
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1146
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1147
                bad_type_msg, "dup2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1148
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1149
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1150
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1151
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1152
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1153
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1154
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1155
        case Bytecodes::_dup2_x1 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1156
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1157
          VerificationType type3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1158
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1159
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1160
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1161
              VerificationType::category1_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1162
          } else if (type.is_category2_2nd()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1163
            type2 = current_frame.pop_stack(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1164
              VerificationType::category2_check(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1165
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1166
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1167
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1168
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1169
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1170
                bad_type_msg, "dup2_x1");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1171
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1172
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1173
          type3 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1174
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1175
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1176
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1177
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1178
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1179
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1180
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1181
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1182
        case Bytecodes::_dup2_x2 :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1183
        {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1184
          VerificationType type3, type4;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1185
          type = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1186
          if (type.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1187
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1188
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1189
          } else if (type.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1190
            type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1191
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1192
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1193
            /* Unreachable?  Would need a category2_1st on TOS which does
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1194
             * not appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1195
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1196
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1197
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1198
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1199
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1200
          type3 = current_frame.pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1201
          if (type3.is_category1()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1202
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1203
              VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1204
          } else if (type3.is_category2_2nd()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1205
            type4 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1206
              VerificationType::category2_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1207
          } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1208
            /* Unreachable?  Would need a category2_1st on TOS after popping
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1209
             * a long/double or two category 1's, which does not
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1210
             * appear possible. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1211
            verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1212
                ErrorContext::bad_type(bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1213
                bad_type_msg, "dup2_x2");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1214
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1215
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1216
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1217
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1218
          current_frame.push_stack(type4, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1219
          current_frame.push_stack(type3, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1220
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1221
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1222
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1223
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1224
        case Bytecodes::_swap :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1225
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1226
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1227
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1228
            VerificationType::category1_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1229
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1230
          current_frame.push_stack(type2, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1231
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1232
        case Bytecodes::_iadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1233
        case Bytecodes::_isub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1234
        case Bytecodes::_imul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1235
        case Bytecodes::_idiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1236
        case Bytecodes::_irem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1237
        case Bytecodes::_ishl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1238
        case Bytecodes::_ishr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1239
        case Bytecodes::_iushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1240
        case Bytecodes::_ior :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1241
        case Bytecodes::_ixor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1242
        case Bytecodes::_iand :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1243
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1244
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1245
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1246
        case Bytecodes::_ineg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1247
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1248
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1249
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1250
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1251
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1252
        case Bytecodes::_ladd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1253
        case Bytecodes::_lsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1254
        case Bytecodes::_lmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1255
        case Bytecodes::_ldiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1256
        case Bytecodes::_lrem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1257
        case Bytecodes::_land :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1258
        case Bytecodes::_lor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1259
        case Bytecodes::_lxor :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1260
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1261
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1262
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1263
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1264
        case Bytecodes::_lneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1265
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1266
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1267
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1268
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1269
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1270
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1271
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1272
        case Bytecodes::_lshl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1273
        case Bytecodes::_lshr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1274
        case Bytecodes::_lushr :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1275
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1276
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1277
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1278
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1279
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1280
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1281
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1282
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1283
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1284
        case Bytecodes::_fadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1285
        case Bytecodes::_fsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1286
        case Bytecodes::_fmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1287
        case Bytecodes::_fdiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1288
        case Bytecodes::_frem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1289
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1290
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1291
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1292
        case Bytecodes::_fneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1293
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1294
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1295
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1296
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1297
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1298
        case Bytecodes::_dadd :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1299
        case Bytecodes::_dsub :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1300
        case Bytecodes::_dmul :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1301
        case Bytecodes::_ddiv :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1302
        case Bytecodes::_drem :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1303
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1304
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1305
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1306
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1307
        case Bytecodes::_dneg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1308
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1309
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1310
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1311
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1312
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1313
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1314
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1315
        case Bytecodes::_iinc :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1316
          verify_iinc(bcs.get_index(), &current_frame, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1317
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1318
        case Bytecodes::_i2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1319
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1320
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1321
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1322
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1323
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1324
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1325
       case Bytecodes::_l2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1326
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1327
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1328
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1329
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1330
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1331
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1332
        case Bytecodes::_i2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1333
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1334
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1335
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1336
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1337
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1338
        case Bytecodes::_i2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1339
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1340
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1341
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1342
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1343
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1344
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1345
        case Bytecodes::_l2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1346
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1347
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1348
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1349
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1350
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1351
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1352
        case Bytecodes::_l2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1353
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1354
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1355
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1356
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1357
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1358
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1359
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1360
        case Bytecodes::_f2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1361
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1362
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1363
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1364
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1365
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1366
        case Bytecodes::_f2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1367
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1368
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1369
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1370
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1371
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1372
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1373
        case Bytecodes::_f2d :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1374
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1375
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1376
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1377
            VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1378
            VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1379
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1380
        case Bytecodes::_d2i :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1381
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1382
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1383
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1384
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1385
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1386
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1387
        case Bytecodes::_d2l :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1388
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1389
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1390
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1391
          current_frame.push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1392
            VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1393
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1394
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1395
        case Bytecodes::_d2f :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1396
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1397
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1398
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1399
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1400
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1401
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1402
        case Bytecodes::_i2b :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1403
        case Bytecodes::_i2c :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1404
        case Bytecodes::_i2s :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1405
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1406
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1407
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1408
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1409
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1410
        case Bytecodes::_lcmp :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1411
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1412
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1413
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1414
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1415
            VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1416
            VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1417
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1418
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1419
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1420
        case Bytecodes::_fcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1421
        case Bytecodes::_fcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1422
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1423
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1424
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1425
            VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1426
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1427
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1428
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1429
        case Bytecodes::_dcmpl :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1430
        case Bytecodes::_dcmpg :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1431
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1432
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1433
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1434
          current_frame.pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1435
            VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1436
            VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1437
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1438
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1439
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1440
        case Bytecodes::_if_icmpeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1441
        case Bytecodes::_if_icmpne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1442
        case Bytecodes::_if_icmplt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1443
        case Bytecodes::_if_icmpge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1444
        case Bytecodes::_if_icmpgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1445
        case Bytecodes::_if_icmple:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1446
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1447
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1448
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1449
        case Bytecodes::_ifeq:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1450
        case Bytecodes::_ifne:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1451
        case Bytecodes::_iflt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1452
        case Bytecodes::_ifge:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1453
        case Bytecodes::_ifgt:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1454
        case Bytecodes::_ifle:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1455
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1456
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1457
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1458
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1459
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1460
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1461
        case Bytecodes::_if_acmpeq :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1462
        case Bytecodes::_if_acmpne :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1463
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1464
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1465
          // fall through
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1466
        case Bytecodes::_ifnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1467
        case Bytecodes::_ifnonnull :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1468
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1469
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1470
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1471
          stackmap_table.check_jump_target
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1472
            (&current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1473
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1474
        case Bytecodes::_goto :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1475
          target = bcs.dest();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1476
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1477
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1478
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1479
        case Bytecodes::_goto_w :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1480
          target = bcs.dest_w();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1481
          stackmap_table.check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1482
            &current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1483
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1484
        case Bytecodes::_tableswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1485
        case Bytecodes::_lookupswitch :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1486
          verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1487
            &bcs, code_length, code_data, &current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1488
            &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1489
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1490
        case Bytecodes::_ireturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1491
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1492
            VerificationType::integer_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1493
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1494
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1495
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1496
        case Bytecodes::_lreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1497
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1498
            VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1499
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1500
            VerificationType::long_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1501
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1502
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1503
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1504
        case Bytecodes::_freturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1505
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1506
            VerificationType::float_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1507
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1508
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1509
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1510
        case Bytecodes::_dreturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1511
          type2 = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1512
            VerificationType::double2_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1513
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1514
            VerificationType::double_type(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1515
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1516
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1517
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1518
        case Bytecodes::_areturn :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1519
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1520
            VerificationType::reference_check(), CHECK_VERIFY(this));
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1521
          verify_return_value(return_type, type, bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1522
                              &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1523
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1524
        case Bytecodes::_return :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1525
          if (return_type != VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1526
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1527
                         "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1528
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1529
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1530
          // Make sure "this" has been initialized if current method is an
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1531
          // <init>
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1532
          if (_method->name() == vmSymbols::object_initializer_name() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1533
              current_frame.flag_this_uninit()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1534
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1535
                         "Constructor must call super() or this() "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1536
                         "before return");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1537
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1538
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1539
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1540
        case Bytecodes::_getstatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1541
        case Bytecodes::_putstatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1542
        case Bytecodes::_getfield :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1543
        case Bytecodes::_putfield :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1544
          verify_field_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1545
            &bcs, &current_frame, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1546
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1547
        case Bytecodes::_invokevirtual :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1548
        case Bytecodes::_invokespecial :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1549
        case Bytecodes::_invokestatic :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1550
          verify_invoke_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1551
            &bcs, code_length, &current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1552
            &this_uninit, return_type, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1553
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1554
        case Bytecodes::_invokeinterface :
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  1555
        case Bytecodes::_invokedynamic :
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1556
          verify_invoke_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1557
            &bcs, code_length, &current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1558
            &this_uninit, return_type, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1559
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1560
        case Bytecodes::_new :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1561
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1562
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1563
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1564
          VerificationType new_class_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1565
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1566
          if (!new_class_type.is_object()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1567
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1568
                TypeOrigin::cp(index, new_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1569
                "Illegal new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1570
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1571
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1572
          type = VerificationType::uninitialized_type(bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1573
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1574
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1575
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1576
        case Bytecodes::_newarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1577
          type = get_newarray_type(bcs.get_index(), bci, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1578
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1579
            VerificationType::integer_type(),  CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1580
          current_frame.push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1581
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1582
        case Bytecodes::_anewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1583
          verify_anewarray(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1584
            bci, bcs.get_index_u2(), cp, &current_frame, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1585
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1586
        case Bytecodes::_arraylength :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1587
          type = current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1588
            VerificationType::reference_check(), CHECK_VERIFY(this));
381
e7275780f686 6692246: Regression : JDK 6u4 b01 fails two JCK tests when fallback is switched off
kamg
parents: 1
diff changeset
  1589
          if (!(type.is_null() || type.is_array())) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1590
            verify_error(ErrorContext::bad_type(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1591
                bci, current_frame.stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1592
                bad_type_msg, "arraylength");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1593
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1594
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1595
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1596
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1597
        case Bytecodes::_checkcast :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1598
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1599
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1600
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1601
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1602
          VerificationType klass_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1603
            index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1604
          current_frame.push_stack(klass_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1605
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1606
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1607
        case Bytecodes::_instanceof : {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1608
          index = bcs.get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1609
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1610
          current_frame.pop_stack(object_type(), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1611
          current_frame.push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1612
            VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1613
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1614
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1615
        case Bytecodes::_monitorenter :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1616
        case Bytecodes::_monitorexit :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1617
          current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1618
            VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1619
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1620
        case Bytecodes::_multianewarray :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1621
        {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1622
          index = bcs.get_index_u2();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1623
          u2 dim = *(bcs.bcp()+3);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1624
          verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1625
          VerificationType new_array_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1626
            cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1627
          if (!new_array_type.is_array()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1628
            verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1629
                TypeOrigin::cp(index, new_array_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1630
                "Illegal constant pool index in multianewarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1631
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1632
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1633
          if (dim < 1 || new_array_type.dimensions() < dim) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1634
            verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1635
                "Illegal dimension in multianewarray instruction: %d", dim);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1636
            return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1637
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1638
          for (int i = 0; i < dim; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1639
            current_frame.pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1640
              VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1641
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1642
          current_frame.push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1643
          no_control_flow = false; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1644
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1645
        case Bytecodes::_athrow :
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1646
          type = VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1647
            vmSymbols::java_lang_Throwable());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1648
          current_frame.pop_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1649
          no_control_flow = true; break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1650
        default:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1651
          // We only need to check the valid bytecodes in class file.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1652
          // And jsr and ret are not in the new class file format in JDK1.5.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1653
          verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1654
              "Bad instruction: %02x", opcode);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1655
          no_control_flow = false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1656
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1657
      }  // end switch
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1658
    }  // end Merge with the next instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1659
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1660
    // Look for possible jump target in exception handlers and see if it
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1661
    // matches current_frame
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1662
    if (bci >= ex_min && bci < ex_max) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1663
      verify_exception_handler_targets(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1664
        bci, this_uninit, &current_frame, &stackmap_table, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1665
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1666
  } // end while
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1667
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1668
  // Make sure that control flow does not fall through end of the method
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1669
  if (!no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1670
    verify_error(ErrorContext::bad_code(code_length),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1671
        "Control flow falls through code end");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1672
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1673
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1674
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1675
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1676
char* ClassVerifier::generate_code_data(methodHandle m, u4 code_length, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1677
  char* code_data = NEW_RESOURCE_ARRAY(char, code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1678
  memset(code_data, 0, sizeof(char) * code_length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1679
  RawBytecodeStream bcs(m);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1680
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1681
  while (!bcs.is_last_bytecode()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1682
    if (bcs.raw_next() != Bytecodes::_illegal) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1683
      int bci = bcs.bci();
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  1684
      if (bcs.raw_code() == Bytecodes::_new) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1685
        code_data[bci] = NEW_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1686
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1687
        code_data[bci] = BYTECODE_OFFSET;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1688
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1689
    } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1690
      verify_error(ErrorContext::bad_code(bcs.bci()), "Bad instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1691
      return NULL;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1692
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1693
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1694
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1695
  return code_data;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1696
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1697
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1698
void ClassVerifier::verify_exception_handler_table(u4 code_length, char* code_data, int& min, int& max, TRAPS) {
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1699
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1700
  int exlength = exhandlers.length();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1701
  constantPoolHandle cp (THREAD, _method->constants());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1702
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1703
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1704
    //reacquire the table in case a GC happened
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1705
    ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1706
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1707
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1708
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1709
    if (start_pc >= code_length || code_data[start_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1710
      class_format_error("Illegal exception table start_pc %d", start_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1711
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1712
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1713
    if (end_pc != code_length) {   // special case: end_pc == code_length
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1714
      if (end_pc > code_length || code_data[end_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1715
        class_format_error("Illegal exception table end_pc %d", end_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1716
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1717
      }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1718
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1719
    if (handler_pc >= code_length || code_data[handler_pc] == 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1720
      class_format_error("Illegal exception table handler_pc %d", handler_pc);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1721
      return;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1722
    }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1723
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1724
    if (catch_type_index != 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1725
      VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1726
        catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1727
      VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1728
        VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1729
      bool is_subclass = throwable.is_assignable_from(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1730
        catch_type, this, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1731
      if (!is_subclass) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1732
        // 4286534: should throw VerifyError according to recent spec change
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1733
        verify_error(ErrorContext::bad_type(handler_pc,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1734
            TypeOrigin::cp(catch_type_index, catch_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1735
            TypeOrigin::implicit(throwable)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1736
            "Catch type is not a subclass "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1737
            "of Throwable in exception handler %d", handler_pc);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1738
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1739
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1740
    }
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1741
    if (start_pc < min) min = start_pc;
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1742
    if (end_pc > max) max = end_pc;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1743
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1744
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1745
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1746
void ClassVerifier::verify_local_variable_table(u4 code_length, char* code_data, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1747
  int localvariable_table_length = _method()->localvariable_table_length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1748
  if (localvariable_table_length > 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1749
    LocalVariableTableElement* table = _method()->localvariable_table_start();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1750
    for (int i = 0; i < localvariable_table_length; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1751
      u2 start_bci = table[i].start_bci;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1752
      u2 length = table[i].length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1753
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1754
      if (start_bci >= code_length || code_data[start_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1755
        class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1756
          "Illegal local variable table start_pc %d", start_bci);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1757
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1758
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1759
      u4 end_bci = (u4)(start_bci + length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1760
      if (end_bci != code_length) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1761
        if (end_bci >= code_length || code_data[end_bci] == 0) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1762
          class_format_error( "Illegal local variable table length %d", length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1763
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1764
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1765
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1766
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1767
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1768
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1769
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1770
u2 ClassVerifier::verify_stackmap_table(u2 stackmap_index, u2 bci,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1771
                                        StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1772
                                        StackMapTable* stackmap_table,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1773
                                        bool no_control_flow, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1774
  if (stackmap_index < stackmap_table->get_frame_count()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1775
    u2 this_offset = stackmap_table->get_offset(stackmap_index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1776
    if (no_control_flow && this_offset > bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1777
      verify_error(ErrorContext::missing_stackmap(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1778
                   "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1779
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1780
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1781
    if (this_offset == bci) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1782
      ErrorContext ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1783
      // See if current stack map can be assigned to the frame in table.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1784
      // current_frame is the stackmap frame got from the last instruction.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1785
      // If matched, current_frame will be updated by this method.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1786
      bool matches = stackmap_table->match_stackmap(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1787
        current_frame, this_offset, stackmap_index,
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1788
        !no_control_flow, true, &ctx, CHECK_VERIFY_(this, 0));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1789
      if (!matches) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1790
        // report type error
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1791
        verify_error(ctx, "Instruction type does not match stack map");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1792
        return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1793
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1794
      stackmap_index++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1795
    } else if (this_offset < bci) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1796
      // current_offset should have met this_offset.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1797
      class_format_error("Bad stack map offset %d", this_offset);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1798
      return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1799
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1800
  } else if (no_control_flow) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1801
    verify_error(ErrorContext::bad_code(bci), "Expecting a stack map frame");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1802
    return 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1803
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1804
  return stackmap_index;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1805
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1806
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1807
void ClassVerifier::verify_exception_handler_targets(u2 bci, bool this_uninit, StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1808
                                                     StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1809
  constantPoolHandle cp (THREAD, _method->constants());
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1810
  ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1811
  int exlength = exhandlers.length();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1812
  for(int i = 0; i < exlength; i++) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1813
    //reacquire the table in case a GC happened
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1814
    ExceptionTable exhandlers(_method());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1815
    u2 start_pc = exhandlers.start_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1816
    u2 end_pc = exhandlers.end_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1817
    u2 handler_pc = exhandlers.handler_pc(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1818
    int catch_type_index = exhandlers.catch_type_index(i);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1819
    if(bci >= start_pc && bci < end_pc) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1820
      u1 flags = current_frame->flags();
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1821
      if (this_uninit) {  flags |= FLAG_THIS_UNINIT; }
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1822
      StackMapFrame* new_frame = current_frame->frame_in_exception_handler(flags);
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1823
      if (catch_type_index != 0) {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1824
        // We know that this index refers to a subclass of Throwable
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1825
        VerificationType catch_type = cp_index_to_type(
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1826
          catch_type_index, cp, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1827
        new_frame->push_stack(catch_type, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1828
      } else {
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1829
        VerificationType throwable =
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1830
          VerificationType::reference_type(vmSymbols::java_lang_Throwable());
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1831
        new_frame->push_stack(throwable, CHECK_VERIFY(this));
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1832
      }
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1833
      ErrorContext ctx;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1834
      bool matches = stackmap_table->match_stackmap(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1835
        new_frame, handler_pc, true, false, &ctx, CHECK_VERIFY(this));
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1836
      if (!matches) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1837
        verify_error(ctx, "Stack map does not match the one at "
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1838
            "exception handler %d", handler_pc);
13282
9872915dd78d 7178145: Change constMethodOop::_exception_table to optionally inlined u2 table.
jiangli
parents: 12932
diff changeset
  1839
        return;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1840
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1841
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1842
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1843
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1844
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1845
void ClassVerifier::verify_cp_index(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1846
    u2 bci, constantPoolHandle cp, int index, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1847
  int nconstants = cp->length();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1848
  if ((index <= 0) || (index >= nconstants)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1849
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1850
        "Illegal constant pool index %d in class %s",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1851
        index, instanceKlass::cast(cp->pool_holder())->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1852
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1853
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1854
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1855
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1856
void ClassVerifier::verify_cp_type(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1857
    u2 bci, int index, constantPoolHandle cp, unsigned int types, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1858
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1859
  // In some situations, bytecode rewriting may occur while we're verifying.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1860
  // In this case, a constant pool cache exists and some indices refer to that
5693
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1861
  // instead.  Be sure we don't pick up such indices by accident.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1862
  // We must check was_recursively_verified() before we get here.
3015c564fcbc 6956164: nightly regressions from 6939207
jrose
parents: 5688
diff changeset
  1863
  guarantee(cp->cache() == NULL, "not rewritten yet");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1864
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1865
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1866
  unsigned int tag = cp->tag_at(index).value();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1867
  if ((types & (1 << tag)) == 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1868
    verify_error(ErrorContext::bad_cp_index(bci, index),
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1869
      "Illegal type at constant pool entry %d in class %s",
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1870
      index, instanceKlass::cast(cp->pool_holder())->external_name());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1871
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1872
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1873
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1874
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1875
void ClassVerifier::verify_cp_class_type(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1876
    u2 bci, int index, constantPoolHandle cp, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1877
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1878
  constantTag tag = cp->tag_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1879
  if (!tag.is_klass() && !tag.is_unresolved_klass()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1880
    verify_error(ErrorContext::bad_cp_index(bci, index),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1881
        "Illegal type at constant pool entry %d in class %s",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1882
        index, instanceKlass::cast(cp->pool_holder())->external_name());
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1883
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1884
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1885
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1886
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1887
void ClassVerifier::verify_error(ErrorContext ctx, const char* msg, ...) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1888
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1889
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1890
  ctx.reset_frames();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1891
  _exception_type = vmSymbols::java_lang_VerifyError();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1892
  _error_context = ctx;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1893
  va_list va;
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1894
  va_start(va, msg);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1895
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1896
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1897
  _message = ss.as_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1898
#ifdef ASSERT
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1899
  ResourceMark rm;
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1900
  const char* exception_name = _exception_type->as_C_string();
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1901
  Exceptions::debug_check_abort(exception_name, NULL);
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1902
#endif // ndef ASSERT
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1903
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1904
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1905
void ClassVerifier::class_format_error(const char* msg, ...) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1906
  stringStream ss;
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1907
  _exception_type = vmSymbols::java_lang_ClassFormatError();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1908
  va_list va;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1909
  va_start(va, msg);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1910
  ss.vprint(msg, va);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1911
  va_end(va);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1912
  if (!_method.is_null()) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1913
    ss.print(" in method %s", _method->name_and_sig_as_C_string());
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1914
  }
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1915
  _message = ss.as_string();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1916
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1917
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  1918
klassOop ClassVerifier::load_class(Symbol* name, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1919
  // Get current loader and protection domain first.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1920
  oop loader = current_class()->class_loader();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1921
  oop protection_domain = current_class()->protection_domain();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1922
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1923
  return SystemDictionary::resolve_or_fail(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1924
    name, Handle(THREAD, loader), Handle(THREAD, protection_domain),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1925
    true, CHECK_NULL);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1926
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1927
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1928
bool ClassVerifier::is_protected_access(instanceKlassHandle this_class,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1929
                                        klassOop target_class,
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  1930
                                        Symbol* field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  1931
                                        Symbol* field_sig,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1932
                                        bool is_method) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1933
  No_Safepoint_Verifier nosafepoint;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1934
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1935
  // If target class isn't a super class of this class, we don't worry about this case
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1936
  if (!this_class->is_subclass_of(target_class)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1937
    return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1938
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1939
  // Check if the specified method or field is protected
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1940
  instanceKlass* target_instance = instanceKlass::cast(target_class);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1941
  fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1942
  if (is_method) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1943
    methodOop m = target_instance->uncached_lookup_method(field_name, field_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1944
    if (m != NULL && m->is_protected()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1945
      if (!this_class->is_same_class_package(m->method_holder())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1946
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1947
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1948
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1949
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1950
    klassOop member_klass = target_instance->find_field(field_name, field_sig, &fd);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1951
    if (member_klass != NULL && fd.is_protected()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1952
      if (!this_class->is_same_class_package(member_klass)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1953
        return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1954
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1955
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1956
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1957
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1958
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1959
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1960
void ClassVerifier::verify_ldc(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1961
    int opcode, u2 index, StackMapFrame* current_frame,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1962
    constantPoolHandle cp, u2 bci, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1963
  verify_cp_index(bci, cp, index, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1964
  constantTag tag = cp->tag_at(index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1965
  unsigned int types;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1966
  if (opcode == Bytecodes::_ldc || opcode == Bytecodes::_ldc_w) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1967
    if (!tag.is_unresolved_string() && !tag.is_unresolved_klass()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1968
      types = (1 << JVM_CONSTANT_Integer) | (1 << JVM_CONSTANT_Float)
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  1969
            | (1 << JVM_CONSTANT_String)  | (1 << JVM_CONSTANT_Class)
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  1970
            | (1 << JVM_CONSTANT_MethodHandle) | (1 << JVM_CONSTANT_MethodType);
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  1971
      // Note:  The class file parser already verified the legality of
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  1972
      // MethodHandle and MethodType constants.
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1973
      verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1974
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1975
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1976
    assert(opcode == Bytecodes::_ldc2_w, "must be ldc2_w");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1977
    types = (1 << JVM_CONSTANT_Double) | (1 << JVM_CONSTANT_Long);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  1978
    verify_cp_type(bci, index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1979
  }
1550
be2fc37a817f 6653858: dynamic languages need to be able to load anonymous classes
jrose
parents: 670
diff changeset
  1980
  if (tag.is_string() && cp->is_pseudo_string_at(index)) {
7380
041cf7f1cce6 6865028: Illegal instructions passing verification prior to 'invokespecial Object.<init>'
kamg
parents: 6173
diff changeset
  1981
    current_frame->push_stack(object_type(), CHECK_VERIFY(this));
1550
be2fc37a817f 6653858: dynamic languages need to be able to load anonymous classes
jrose
parents: 670
diff changeset
  1982
  } else if (tag.is_string() || tag.is_unresolved_string()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1983
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1984
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1985
        vmSymbols::java_lang_String()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1986
  } else if (tag.is_klass() || tag.is_unresolved_klass()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1987
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1988
      VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1989
        vmSymbols::java_lang_Class()), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1990
  } else if (tag.is_int()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1991
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1992
      VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1993
  } else if (tag.is_float()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1994
    current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1995
      VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1996
  } else if (tag.is_double()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1997
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1998
      VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  1999
      VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2000
  } else if (tag.is_long()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2001
    current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2002
      VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2003
      VerificationType::long2_type(), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2004
  } else if (tag.is_method_handle()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2005
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2006
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2007
        vmSymbols::java_lang_invoke_MethodHandle()), CHECK_VERIFY(this));
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2008
  } else if (tag.is_method_type()) {
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2009
    current_frame->push_stack(
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2010
      VerificationType::reference_type(
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2011
        vmSymbols::java_lang_invoke_MethodType()), CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2012
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2013
    /* Unreachable? verify_cp_type has already validated the cp type. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2014
    verify_error(
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2015
        ErrorContext::bad_cp_index(bci, index), "Invalid index in ldc");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2016
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2017
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2018
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2019
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2020
void ClassVerifier::verify_switch(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2021
    RawBytecodeStream* bcs, u4 code_length, char* code_data,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2022
    StackMapFrame* current_frame, StackMapTable* stackmap_table, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2023
  int bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2024
  address bcp = bcs->bcp();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2025
  address aligned_bcp = (address) round_to((intptr_t)(bcp + 1), jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2026
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2027
  // 4639449 & 4647081: padding bytes must be 0
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2028
  u2 padding_offset = 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2029
  while ((bcp + padding_offset) < aligned_bcp) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2030
    if(*(bcp + padding_offset) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2031
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2032
                   "Nonzero padding byte in lookswitch or tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2033
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2034
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2035
    padding_offset++;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2036
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2037
  int default_offset = (int) Bytes::get_Java_u4(aligned_bcp);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2038
  int keys, delta;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2039
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2040
    VerificationType::integer_type(), CHECK_VERIFY(this));
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2041
  if (bcs->raw_code() == Bytecodes::_tableswitch) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2042
    jint low = (jint)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2043
    jint high = (jint)Bytes::get_Java_u4(aligned_bcp + 2*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2044
    if (low > high) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2045
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2046
          "low must be less than or equal to high in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2047
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2048
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2049
    keys = high - low + 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2050
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2051
      verify_error(ErrorContext::bad_code(bci), "too many keys in tableswitch");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2052
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2053
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2054
    delta = 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2055
  } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2056
    keys = (int)Bytes::get_Java_u4(aligned_bcp + jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2057
    if (keys < 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2058
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2059
                   "number of keys in lookupswitch less than 0");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2060
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2061
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2062
    delta = 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2063
    // Make sure that the lookupswitch items are sorted
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2064
    for (int i = 0; i < (keys - 1); i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2065
      jint this_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2066
      jint next_key = Bytes::get_Java_u4(aligned_bcp + (2+2*i+2)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2067
      if (this_key >= next_key) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2068
        verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2069
                     "Bad lookupswitch instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2070
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2071
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2072
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2073
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2074
  int target = bci + default_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2075
  stackmap_table->check_jump_target(current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2076
  for (int i = 0; i < keys; i++) {
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2077
    // Because check_jump_target() may safepoint, the bytecode could have
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2078
    // moved, which means 'aligned_bcp' is no good and needs to be recalculated.
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2079
    aligned_bcp = (address)round_to((intptr_t)(bcs->bcp() + 1), jintSize);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2080
    target = bci + (jint)Bytes::get_Java_u4(aligned_bcp+(3+i*delta)*jintSize);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2081
    stackmap_table->check_jump_target(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2082
      current_frame, target, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2083
  }
12932
16599c579430 7166498: JVM crash in ClassVerifier
kamg
parents: 9116
diff changeset
  2084
  NOT_PRODUCT(aligned_bcp = NULL);  // no longer valid at this point
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2085
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2086
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2087
bool ClassVerifier::name_in_supers(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2088
    Symbol* ref_name, instanceKlassHandle current) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2089
  klassOop super = current->super();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2090
  while (super != NULL) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2091
    if (super->klass_part()->name() == ref_name) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2092
      return true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2093
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2094
    super = super->klass_part()->super();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2095
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2096
  return false;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2097
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2098
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2099
void ClassVerifier::verify_field_instructions(RawBytecodeStream* bcs,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2100
                                              StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2101
                                              constantPoolHandle cp,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2102
                                              TRAPS) {
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2103
  u2 index = bcs->get_index_u2();
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2104
  verify_cp_type(bcs->bci(), index, cp,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2105
      1 << JVM_CONSTANT_Fieldref, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2106
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2107
  // Get field name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2108
  Symbol* field_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2109
  Symbol* field_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2110
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2111
  if (!SignatureVerifier::is_valid_type_signature(field_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2112
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2113
      "Invalid signature for field in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2114
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2115
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2116
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2117
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2118
  // Get referenced class type
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2119
  VerificationType ref_class_type = cp_ref_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2120
    index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2121
  if (!ref_class_type.is_object()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2122
    /* Unreachable?  Class file parser verifies Fieldref contents */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2123
    verify_error(ErrorContext::bad_type(bcs->bci(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2124
        TypeOrigin::cp(index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2125
        "Expecting reference to class in class %s at constant pool index %d",
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2126
        _klass->external_name(), index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2127
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2128
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2129
  VerificationType target_class_type = ref_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2130
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2131
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2132
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2133
  uintptr_t field_type_buffer[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2134
  VerificationType* field_type = (VerificationType*)field_type_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2135
  // If we make a VerificationType[2] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2136
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2137
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2138
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2139
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2140
  SignatureStream sig_stream(field_sig, false);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2141
  VerificationType stack_object_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2142
  int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2143
    &sig_stream, field_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2144
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2145
  bool is_assignable;
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2146
  switch (bcs->raw_code()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2147
    case Bytecodes::_getstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2148
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2149
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2150
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2151
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2152
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2153
    case Bytecodes::_putstatic: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2154
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2155
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2156
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2157
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2158
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2159
    case Bytecodes::_getfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2160
      stack_object_type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2161
        target_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2162
      for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2163
        current_frame->push_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2164
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2165
      goto check_protected;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2166
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2167
    case Bytecodes::_putfield: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2168
      for (int i = n - 1; i >= 0; i--) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2169
        current_frame->pop_stack(field_type[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2170
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2171
      stack_object_type = current_frame->pop_stack(CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2172
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2173
      // The JVMS 2nd edition allows field initialization before the superclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2174
      // initializer, if the field is defined within the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2175
      fieldDescriptor fd;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2176
      if (stack_object_type == VerificationType::uninitialized_this_type() &&
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2177
          target_class_type.equals(current_type()) &&
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2178
          _klass->find_local_field(field_name, field_sig, &fd)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2179
        stack_object_type = current_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2180
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2181
      is_assignable = target_class_type.is_assignable_from(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2182
        stack_object_type, this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2183
      if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2184
        verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2185
            current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2186
            TypeOrigin::cp(index, target_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2187
            "Bad type on operand stack in putfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2188
        return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2189
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2190
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2191
    check_protected: {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2192
      if (_this_type == stack_object_type)
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2193
        break; // stack_object_type must be assignable to _current_class_type
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2194
      Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2195
        cp->klass_name_at(cp->klass_ref_index_at(index));
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2196
      if (!name_in_supers(ref_class_name, current_class()))
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2197
        // stack_object_type must be assignable to _current_class_type since:
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2198
        // 1. stack_object_type must be assignable to ref_class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2199
        // 2. ref_class must be _current_class or a subclass of it. It can't
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2200
        //    be a superclass of it. See revised JVMS 5.4.4.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2201
        break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2202
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2203
      klassOop ref_class_oop = load_class(ref_class_name, CHECK);
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2204
      if (is_protected_access(current_class(), ref_class_oop, field_name,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2205
                              field_sig, false)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2206
        // It's protected access, check if stack object is assignable to
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2207
        // current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2208
        is_assignable = current_type().is_assignable_from(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2209
          stack_object_type, this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2210
        if (!is_assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2211
          verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2212
              current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2213
              TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2214
              "Bad access to protected data in getfield");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2215
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2216
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2217
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2218
      break;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2219
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2220
    default: ShouldNotReachHere();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2221
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2222
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2223
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2224
void ClassVerifier::verify_invoke_init(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2225
    RawBytecodeStream* bcs, u2 ref_class_index, VerificationType ref_class_type,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2226
    StackMapFrame* current_frame, u4 code_length, bool *this_uninit,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2227
    constantPoolHandle cp, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2228
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2229
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2230
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2231
  if (type == VerificationType::uninitialized_this_type()) {
12986
14b117407405 7160757: Problem with hotspot/runtime_classfile
kamg
parents: 9116
diff changeset
  2232
    // The method must be an <init> method of this class or its superclass
14b117407405 7160757: Problem with hotspot/runtime_classfile
kamg
parents: 9116
diff changeset
  2233
    klassOop superk = current_class()->super();
6172
e1d9c632fa3c 6964170: Verifier crashes
apangin
parents: 5882
diff changeset
  2234
    if (ref_class_type.name() != current_class()->name() &&
12986
14b117407405 7160757: Problem with hotspot/runtime_classfile
kamg
parents: 9116
diff changeset
  2235
        ref_class_type.name() != superk->klass_part()->name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2236
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2237
          TypeOrigin::implicit(ref_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2238
          TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2239
          "Bad <init> method call");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2240
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2241
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2242
    current_frame->initialize_object(type, current_type());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2243
    *this_uninit = true;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2244
  } else if (type.is_uninitialized()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2245
    u2 new_offset = type.bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2246
    address new_bcp = bcs->bcp() - bci + new_offset;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2247
    if (new_offset > (code_length - 3) || (*new_bcp) != Bytecodes::_new) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2248
      /* Unreachable?  Stack map parsing ensures valid type and new
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2249
       * instructions have a valid BCI. */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2250
      verify_error(ErrorContext::bad_code(new_offset),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2251
                   "Expecting new instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2252
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2253
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2254
    u2 new_class_index = Bytes::get_Java_u2(new_bcp + 1);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2255
    verify_cp_class_type(bci, new_class_index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2256
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2257
    // The method must be an <init> method of the indicated class
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2258
    VerificationType new_class_type = cp_index_to_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2259
      new_class_index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2260
    if (!new_class_type.equals(ref_class_type)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2261
      verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2262
          TypeOrigin::cp(new_class_index, new_class_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2263
          TypeOrigin::cp(ref_class_index, ref_class_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2264
          "Call to wrong <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2265
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2266
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2267
    // According to the VM spec, if the referent class is a superclass of the
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2268
    // current class, and is in a different runtime package, and the method is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2269
    // protected, then the objectref must be the current class or a subclass
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2270
    // of the current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2271
    VerificationType objectref_type = new_class_type;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2272
    if (name_in_supers(ref_class_type.name(), current_class())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2273
      klassOop ref_klass = load_class(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2274
        ref_class_type.name(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2275
      methodOop m = instanceKlass::cast(ref_klass)->uncached_lookup_method(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2276
        vmSymbols::object_initializer_name(),
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2277
        cp->signature_ref_at(bcs->get_index_u2()));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2278
      instanceKlassHandle mh(THREAD, m->method_holder());
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2279
      if (m->is_protected() && !mh->is_same_class_package(_klass())) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2280
        bool assignable = current_type().is_assignable_from(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2281
          objectref_type, this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2282
        if (!assignable) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2283
          verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2284
              TypeOrigin::cp(new_class_index, objectref_type),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2285
              TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2286
              "Bad access to protected <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2287
          return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2288
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2289
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2290
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2291
    current_frame->initialize_object(type, new_class_type);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2292
  } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2293
    verify_error(ErrorContext::bad_type(bci, current_frame->stack_top_ctx()),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2294
        "Bad operand type when invoking <init>");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2295
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2296
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2297
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2298
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2299
void ClassVerifier::verify_invoke_instructions(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2300
    RawBytecodeStream* bcs, u4 code_length, StackMapFrame* current_frame,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2301
    bool *this_uninit, VerificationType return_type,
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2302
    constantPoolHandle cp, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2303
  // Make sure the constant pool item is the right type
5688
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2304
  u2 index = bcs->get_index_u2();
9052dc91ea67 6939207: refactor constant pool index processing
jrose
parents: 4571
diff changeset
  2305
  Bytecodes::Code opcode = bcs->raw_code();
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2306
  unsigned int types = (opcode == Bytecodes::_invokeinterface
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2307
                                ? 1 << JVM_CONSTANT_InterfaceMethodref
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2308
                      : opcode == Bytecodes::_invokedynamic
9116
9bc44be338d6 6981791: remove experimental code for JSR 292
jrose
parents: 8676
diff changeset
  2309
                                ? 1 << JVM_CONSTANT_InvokeDynamic
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2310
                                : 1 << JVM_CONSTANT_Methodref);
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2311
  verify_cp_type(bcs->bci(), index, cp, types, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2312
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2313
  // Get method name and signature
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2314
  Symbol* method_name = cp->name_ref_at(index);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2315
  Symbol* method_sig = cp->signature_ref_at(index);
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2316
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2317
  if (!SignatureVerifier::is_valid_method_signature(method_sig)) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2318
    class_format_error(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2319
      "Invalid method signature in class %s referenced "
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2320
      "from constant pool index %d", _klass->external_name(), index);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2321
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2322
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2323
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2324
  // Get referenced class type
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2325
  VerificationType ref_class_type;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2326
  if (opcode == Bytecodes::_invokedynamic) {
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2327
    if (!EnableInvokeDynamic ||
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2328
        _klass->major_version() < Verifier::INVOKEDYNAMIC_MAJOR_VERSION) {
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2329
      class_format_error(
5882
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2330
        (!EnableInvokeDynamic ?
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2331
         "invokedynamic instructions not enabled in this JVM" :
6b2aecc4f7d8 6939203: JSR 292 needs method handle constants
jrose
parents: 5702
diff changeset
  2332
         "invokedynamic instructions not supported by this class file version"),
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2333
        _klass->external_name());
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2334
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2335
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2336
  } else {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2337
    ref_class_type = cp_ref_index_to_type(index, cp, CHECK_VERIFY(this));
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2338
  }
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2339
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2340
  // For a small signature length, we just allocate 128 bytes instead
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2341
  // of parsing the signature once to find its size.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2342
  // -3 is for '(', ')' and return descriptor; multiply by 2 is for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2343
  // longs/doubles to be consertive.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2344
  assert(sizeof(VerificationType) == sizeof(uintptr_t),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2345
        "buffer type must match VerificationType size");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2346
  uintptr_t on_stack_sig_types_buffer[128];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2347
  // If we make a VerificationType[128] array directly, the compiler calls
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2348
  // to the c-runtime library to do the allocation instead of just
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2349
  // stack allocating it.  Plus it would run constructors.  This shows up
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2350
  // in performance profiles.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2351
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2352
  VerificationType* sig_types;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2353
  int size = (method_sig->utf8_length() - 3) * 2;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2354
  if (size > 128) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2355
    // Long and double occupies two slots here.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2356
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2357
    size = size_it.size();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2358
    sig_types = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, VerificationType, size);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2359
  } else{
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2360
    sig_types = (VerificationType*)on_stack_sig_types_buffer;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2361
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2362
  SignatureStream sig_stream(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2363
  int sig_i = 0;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2364
  while (!sig_stream.at_return_type()) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2365
    sig_i += change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2366
      &sig_stream, &sig_types[sig_i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2367
    sig_stream.next();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2368
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2369
  int nargs = sig_i;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2370
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2371
#ifdef ASSERT
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2372
  {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2373
    ArgumentSizeComputer size_it(method_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2374
    assert(nargs == size_it.size(), "Argument sizes do not match");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2375
    assert(nargs <= (method_sig->utf8_length() - 3) * 2, "estimate of max size isn't conservative enough");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2376
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2377
#endif
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2378
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2379
  // Check instruction operands
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2380
  u2 bci = bcs->bci();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2381
  if (opcode == Bytecodes::_invokeinterface) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2382
    address bcp = bcs->bcp();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2383
    // 4905268: count operand in invokeinterface should be nargs+1, not nargs.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2384
    // JSR202 spec: The count operand of an invokeinterface instruction is valid if it is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2385
    // the difference between the size of the operand stack before and after the instruction
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2386
    // executes.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2387
    if (*(bcp+3) != (nargs+1)) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2388
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2389
          "Inconsistent args count operand in invokeinterface");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2390
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2391
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2392
    if (*(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2393
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2394
          "Fourth operand byte of invokeinterface must be zero");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2395
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2396
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2397
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2398
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2399
  if (opcode == Bytecodes::_invokedynamic) {
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2400
    address bcp = bcs->bcp();
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2401
    if (*(bcp+3) != 0 || *(bcp+4) != 0) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2402
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2403
          "Third and fourth operand bytes of invokedynamic must be zero");
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2404
      return;
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2405
    }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2406
  }
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2407
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2408
  if (method_name->byte_at(0) == '<') {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2409
    // Make sure <init> can only be invoked by invokespecial
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2410
    if (opcode != Bytecodes::_invokespecial ||
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2411
        method_name != vmSymbols::object_initializer_name()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2412
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2413
          "Illegal call to internal method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2414
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2415
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2416
  } else if (opcode == Bytecodes::_invokespecial
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2417
             && !ref_class_type.equals(current_type())
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2418
             && !ref_class_type.equals(VerificationType::reference_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2419
                  current_class()->super()->klass_part()->name()))) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2420
    bool subtype = ref_class_type.is_assignable_from(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2421
      current_type(), this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2422
    if (!subtype) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2423
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2424
          "Bad invokespecial instruction: "
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2425
          "current class isn't assignable to reference class.");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2426
       return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2427
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2428
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2429
  // Match method descriptor with operand stack
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2430
  for (int i = nargs - 1; i >= 0; i--) {  // Run backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2431
    current_frame->pop_stack(sig_types[i], CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2432
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2433
  // Check objectref on operand stack
2570
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2434
  if (opcode != Bytecodes::_invokestatic &&
ecc7862946d4 6655646: dynamic languages need dynamically linked call sites
jrose
parents: 1550
diff changeset
  2435
      opcode != Bytecodes::_invokedynamic) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2436
    if (method_name == vmSymbols::object_initializer_name()) {  // <init> method
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2437
      verify_invoke_init(bcs, index, ref_class_type, current_frame,
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2438
        code_length, this_uninit, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2439
    } else {   // other methods
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2440
      // Ensures that target class is assignable to method class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2441
      if (opcode == Bytecodes::_invokespecial) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2442
        current_frame->pop_stack(current_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2443
      } else if (opcode == Bytecodes::_invokevirtual) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2444
        VerificationType stack_object_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2445
          current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2446
        if (current_type() != stack_object_type) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2447
          assert(cp->cache() == NULL, "not rewritten yet");
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2448
          Symbol* ref_class_name =
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2449
            cp->klass_name_at(cp->klass_ref_index_at(index));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2450
          // See the comments in verify_field_instructions() for
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2451
          // the rationale behind this.
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2452
          if (name_in_supers(ref_class_name, current_class())) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2453
            klassOop ref_class = load_class(ref_class_name, CHECK);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2454
            if (is_protected_access(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2455
                  _klass, ref_class, method_name, method_sig, true)) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2456
              // It's protected access, check if stack object is
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2457
              // assignable to current class.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2458
              bool is_assignable = current_type().is_assignable_from(
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2459
                stack_object_type, this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2460
              if (!is_assignable) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2461
                if (ref_class_type.name() == vmSymbols::java_lang_Object()
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2462
                    && stack_object_type.is_array()
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2463
                    && method_name == vmSymbols::clone_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2464
                  // Special case: arrays pretend to implement public Object
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2465
                  // clone().
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2466
                } else {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2467
                  verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2468
                      current_frame->stack_top_ctx(),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2469
                      TypeOrigin::implicit(current_type())),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2470
                      "Bad access to protected data in invokevirtual");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2471
                  return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2472
                }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2473
              }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2474
            }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2475
          }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2476
        }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2477
      } else {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2478
        assert(opcode == Bytecodes::_invokeinterface, "Unexpected opcode encountered");
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2479
        current_frame->pop_stack(ref_class_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2480
      }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2481
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2482
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2483
  // Push the result type.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2484
  if (sig_stream.type() != T_VOID) {
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2485
    if (method_name == vmSymbols::object_initializer_name()) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2486
      // <init> method must have a void return type
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2487
      /* Unreachable?  Class file parser verifies that methods with '<' have
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2488
       * void return */
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2489
      verify_error(ErrorContext::bad_code(bci),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2490
          "Return type must be void in <init> method");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2491
      return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2492
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2493
    VerificationType return_type[2];
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2494
    int n = change_sig_to_verificationType(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2495
      &sig_stream, return_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2496
    for (int i = 0; i < n; i++) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2497
      current_frame->push_stack(return_type[i], CHECK_VERIFY(this)); // push types backwards
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2498
    }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2499
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2500
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2501
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2502
VerificationType ClassVerifier::get_newarray_type(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2503
    u2 index, u2 bci, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2504
  const char* from_bt[] = {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2505
    NULL, NULL, NULL, NULL, "[Z", "[C", "[F", "[D", "[B", "[S", "[I", "[J",
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2506
  };
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2507
  if (index < T_BOOLEAN || index > T_LONG) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2508
    verify_error(ErrorContext::bad_code(bci), "Illegal newarray instruction");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2509
    return VerificationType::bogus_type();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2510
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2511
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2512
  // from_bt[index] contains the array signature which has a length of 2
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2513
  Symbol* sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2514
    from_bt[index], 2, CHECK_(VerificationType::bogus_type()));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2515
  return VerificationType::reference_type(sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2516
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2517
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2518
void ClassVerifier::verify_anewarray(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2519
    u2 bci, u2 index, constantPoolHandle cp,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2520
    StackMapFrame* current_frame, TRAPS) {
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2521
  verify_cp_class_type(bci, index, cp, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2522
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2523
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2524
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2525
  VerificationType component_type =
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2526
    cp_index_to_type(index, cp, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2527
  int length;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2528
  char* arr_sig_str;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2529
  if (component_type.is_array()) {     // it's an array
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2530
    const char* component_name = component_type.name()->as_utf8();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2531
    // add one dimension to component
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2532
    length = (int)strlen(component_name) + 1;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2533
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2534
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2535
    strncpy(&arr_sig_str[1], component_name, length - 1);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2536
  } else {         // it's an object or interface
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2537
    const char* component_name = component_type.name()->as_utf8();
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2538
    // add one dimension to component with 'L' prepended and ';' postpended.
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2539
    length = (int)strlen(component_name) + 3;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2540
    arr_sig_str = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, length);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2541
    arr_sig_str[0] = '[';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2542
    arr_sig_str[1] = 'L';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2543
    strncpy(&arr_sig_str[2], component_name, length - 2);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2544
    arr_sig_str[length - 1] = ';';
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2545
  }
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2546
  Symbol* arr_sig = create_temporary_symbol(
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2547
    arr_sig_str, length, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2548
  VerificationType new_array_type = VerificationType::reference_type(arr_sig);
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2549
  current_frame->push_stack(new_array_type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2550
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2551
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2552
void ClassVerifier::verify_iload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2553
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2554
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2555
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2556
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2557
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2558
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2559
void ClassVerifier::verify_lload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2560
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2561
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2562
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2563
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2564
    VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2565
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2566
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2567
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2568
void ClassVerifier::verify_fload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2569
  current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2570
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2571
  current_frame->push_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2572
    VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2573
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2574
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2575
void ClassVerifier::verify_dload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2576
  current_frame->get_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2577
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2578
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2579
  current_frame->push_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2580
    VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2581
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2582
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2583
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2584
void ClassVerifier::verify_aload(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2585
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2586
    index, VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2587
  current_frame->push_stack(type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2588
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2589
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2590
void ClassVerifier::verify_istore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2591
  current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2592
    VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2593
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2594
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2595
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2596
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2597
void ClassVerifier::verify_lstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2598
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2599
    VerificationType::long2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2600
    VerificationType::long_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2601
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2602
    index, VerificationType::long_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2603
    VerificationType::long2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2604
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2605
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2606
void ClassVerifier::verify_fstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2607
  current_frame->pop_stack(VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2608
  current_frame->set_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2609
    index, VerificationType::float_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2610
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2611
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2612
void ClassVerifier::verify_dstore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2613
  current_frame->pop_stack_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2614
    VerificationType::double2_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2615
    VerificationType::double_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2616
  current_frame->set_local_2(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2617
    index, VerificationType::double_type(),
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2618
    VerificationType::double2_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2619
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2620
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2621
void ClassVerifier::verify_astore(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2622
  VerificationType type = current_frame->pop_stack(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2623
    VerificationType::reference_check(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2624
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2625
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2626
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2627
void ClassVerifier::verify_iinc(u2 index, StackMapFrame* current_frame, TRAPS) {
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2628
  VerificationType type = current_frame->get_local(
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2629
    index, VerificationType::integer_type(), CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2630
  current_frame->set_local(index, type, CHECK_VERIFY(this));
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2631
}
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2632
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2633
void ClassVerifier::verify_return_value(
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2634
    VerificationType return_type, VerificationType type, u2 bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2635
    StackMapFrame* current_frame, TRAPS) {
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2636
  if (return_type == VerificationType::bogus_type()) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2637
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2638
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2639
        "Method expects a return value");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2640
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2641
  }
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2642
  bool match = return_type.is_assignable_from(type, this, CHECK_VERIFY(this));
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2643
  if (!match) {
13476
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2644
    verify_error(ErrorContext::bad_type(bci,
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2645
        current_frame->stack_top_ctx(), TypeOrigin::signature(return_type)),
471200fb94fd 7116786: RFE: Detailed information on VerifyErrors
kamg
parents: 13283
diff changeset
  2646
        "Bad return type");
1
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2647
    return;
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2648
  }
489c9b5090e2 Initial load
duke
parents:
diff changeset
  2649
}
8076
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2650
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2651
// The verifier creates symbols which are substrings of Symbols.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2652
// These are stored in the verifier until the end of verification so that
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2653
// they can be reference counted.
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2654
Symbol* ClassVerifier::create_temporary_symbol(const Symbol *s, int begin,
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2655
                                               int end, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2656
  Symbol* sym = SymbolTable::new_symbol(s, begin, end, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2657
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2658
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2659
}
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2660
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2661
Symbol* ClassVerifier::create_temporary_symbol(const char *s, int length, TRAPS) {
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2662
  Symbol* sym = SymbolTable::new_symbol(s, length, CHECK_NULL);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2663
  _symbols->push(sym);
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2664
  return sym;
96d498ec7ae1 6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents: 7405
diff changeset
  2665
}