update TODO comments v_0
authorFrantišek Kučera <franta-hg@frantovo.cz>
Sun, 04 Oct 2020 19:59:03 +0200
branchv_0
changeset 18 7a74e9f9e674
parent 17 0fcd9944016a
child 19 dcd98589f4b8
update TODO comments
src/JackHandler.h
--- a/src/JackHandler.h	Sun Oct 04 18:26:59 2020 +0200
+++ b/src/JackHandler.h	Sun Oct 04 19:59:03 2020 +0200
@@ -205,12 +205,9 @@
 	}
 
 	void startRelation(const relpipe::common::type::StringX name, std::vector<relpipe::reader::handlers::AttributeMetadata> attributes) override {
-		// TODO: validate metadata and prepare attribute mappings (names and types are important, order does not matter)
-
 		relationContext = RelationContext();
 		relationContext.attributes = attributes;
 
-		// TODO: check also data types and skipt relation if important attributes are missing
 		// TODO: configurable relation name
 
 		if (!relationContext.hasAttribute(L"raw")) {
@@ -222,7 +219,7 @@
 
 	void attribute(const relpipe::common::type::StringX& value) override {
 		if (relationContext.skip) return;
-		// TODO: switch to RelationalReaderStringHandler
+		// TODO: switch to RelationalReaderValueHandler
 		// TODO: if (continueProcessing) {} ?
 
 		RelationContext& rel = relationContext;
@@ -287,8 +284,6 @@
 	}
 
 	void endOfPipe() {
-		// TODO: send optional (configurable) MIDI events
-
 		// Wait until the ring buffer is empty
 		while (continueProcessing && jack_ringbuffer_read_space(realTimeContext.ringBuffer)) usleep(1000);
 		usleep(1000000);