# HG changeset patch # User František Kučera # Date 1601834343 -7200 # Node ID 7a74e9f9e67447fd6917b776b9133a5a4553de00 # Parent 0fcd9944016a31e608d314d0c27536ab42237b24 update TODO comments diff -r 0fcd9944016a -r 7a74e9f9e674 src/JackHandler.h --- a/src/JackHandler.h Sun Oct 04 18:26:59 2020 +0200 +++ b/src/JackHandler.h Sun Oct 04 19:59:03 2020 +0200 @@ -205,12 +205,9 @@ } void startRelation(const relpipe::common::type::StringX name, std::vector attributes) override { - // TODO: validate metadata and prepare attribute mappings (names and types are important, order does not matter) - relationContext = RelationContext(); relationContext.attributes = attributes; - // TODO: check also data types and skipt relation if important attributes are missing // TODO: configurable relation name if (!relationContext.hasAttribute(L"raw")) { @@ -222,7 +219,7 @@ void attribute(const relpipe::common::type::StringX& value) override { if (relationContext.skip) return; - // TODO: switch to RelationalReaderStringHandler + // TODO: switch to RelationalReaderValueHandler // TODO: if (continueProcessing) {} ? RelationContext& rel = relationContext; @@ -287,8 +284,6 @@ } void endOfPipe() { - // TODO: send optional (configurable) MIDI events - // Wait until the ring buffer is empty while (continueProcessing && jack_ringbuffer_read_space(realTimeContext.ringBuffer)) usleep(1000); usleep(1000000);