hotspot/test/runtime/modules/AccessCheck/AccessExportTwice.java
author alanb
Fri, 10 Feb 2017 09:03:55 +0000
changeset 43665 4bb003cad9b9
parent 43444 e7abeb81e94a
child 44520 0553e129e0ec
permissions -rw-r--r--
8173393: Module system implementation refresh (2/2017) Reviewed-by: lfoltan, acorn, mchung Contributed-by: alan.bateman@oracle.com, george.triantafillou@oracle.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     1
/*
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     2
 * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     4
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     7
 * published by the Free Software Foundation.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     8
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    13
 * accompanied this code).
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    14
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    18
 *
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    21
 * questions.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    22
 */
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    23
/*
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    24
 * @test
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    25
 * @summary Class p1.c1 in an unnamed module cannot read p2.c2 in module second_mod,
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    26
 *          even after p2 is exported to all unnamed. Ensures constant
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    27
 *          access check answers when not accessible due to exportedness.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    28
 * @library /test/lib
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    29
 * @modules java.base/jdk.internal.misc
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    30
 * @modules java.base/jdk.internal.module
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    31
 * @compile myloaders/MySameClassLoader.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    32
 * @compile p2/c2.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    33
 * @compile p1/c1.java
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    34
 * @run main/othervm AccessExportTwice
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    35
 */
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    36
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    37
import static jdk.test.lib.Asserts.*;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    38
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    39
import java.lang.module.Configuration;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    40
import java.lang.module.ModuleDescriptor;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    41
import java.lang.module.ModuleFinder;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    42
import java.lang.reflect.Layer;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    43
import java.lang.reflect.Module;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    44
import java.util.HashMap;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    45
import java.util.Map;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    46
import java.util.Set;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    47
import myloaders.MySameClassLoader;
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    48
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    49
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    50
// ClassLoader1 --> defines first_mod --> no packages
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    51
//                  defines second_mod --> packages p2
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    52
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    53
// first_mod can read second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    54
// package p2 in second_mod is exported to first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    55
//
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    56
// class p1.c1 defined in an unnamed module tries to access p2.c2 defined in second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    57
// Access is not allowed, even after p2 is exported to all unnamed modules.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    58
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    59
public class AccessExportTwice {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    60
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    61
    // Create a Layer over the boot layer.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    62
    // Define modules within this layer to test access between
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    63
    // publicly defined classes within packages of those modules.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    64
    public void createLayerOnBoot() throws Throwable {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    65
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    66
        // Define module:     first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    67
        // Can read:          java.base, second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    68
        // Packages:          none
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    69
        // Packages exported: none
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    70
        ModuleDescriptor descriptor_first_mod =
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    71
                ModuleDescriptor.newModule("first_mod")
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    72
                        .requires("java.base")
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    73
                        .requires("second_mod")
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    74
                        .build();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    75
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    76
        // Define module:     second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    77
        // Can read:          java.base
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    78
        // Packages:          p2
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    79
        // Packages exported: p2 is exported to first_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    80
        ModuleDescriptor descriptor_second_mod =
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    81
                ModuleDescriptor.newModule("second_mod")
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    82
                        .requires("java.base")
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    83
                        .exports("p2", Set.of("first_mod"))
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    84
                        .build();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    85
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    86
        // Set up a ModuleFinder containing all modules for this layer
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    87
        ModuleFinder finder = ModuleLibrary.of(descriptor_first_mod, descriptor_second_mod);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    88
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    89
        // Resolves "first_mod"
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    90
        Configuration cf = Layer.boot()
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    91
                .configuration()
43665
4bb003cad9b9 8173393: Module system implementation refresh (2/2017)
alanb
parents: 43444
diff changeset
    92
                .resolve(finder, ModuleFinder.of(), Set.of("first_mod"));
43444
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    93
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    94
        // Map each module to the same class loader
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    95
        Map<String, ClassLoader> map = new HashMap<>();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    96
        map.put("first_mod", MySameClassLoader.loader1);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    97
        map.put("second_mod", MySameClassLoader.loader1);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    98
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
    99
        // Create Layer that contains first_mod & second_mod
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   100
        Layer layer = Layer.boot().defineModules(cf, map::get);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   101
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   102
        assertTrue(layer.findLoader("first_mod") == MySameClassLoader.loader1);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   103
        assertTrue(layer.findLoader("second_mod") == MySameClassLoader.loader1);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   104
        assertTrue(layer.findLoader("java.base") == null);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   105
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   106
        Class p2_c2_class = MySameClassLoader.loader1.loadClass("p2.c2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   107
        // Use the same loader to load class p1.c1
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   108
        Class p1_c1_class = MySameClassLoader.loader1.loadClass("p1.c1");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   109
        // First access check for p1.c1
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   110
        try {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   111
            p1_c1_class.newInstance();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   112
            throw new RuntimeException("Test Failed, the unnamed module should not have access to public type p2.c2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   113
        } catch (IllegalAccessError e) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   114
            String message = e.getMessage();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   115
            if (!(message.contains("cannot access") &&
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   116
                  message.contains("because module second_mod does not export p2 to unnamed module"))) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   117
                throw new RuntimeException("Wrong message: " + message);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   118
            } else {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   119
                System.out.println("Test Succeeded at attempt #1");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   120
            }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   121
        }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   122
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   123
        // Export second_mod/p2 to all unnamed modules.
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   124
        Module second_mod = p2_c2_class.getModule();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   125
        jdk.internal.module.Modules.addExportsToAllUnnamed(second_mod, "p2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   126
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   127
        // Second access check for p1.c1, should have same result as first
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   128
        try {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   129
            p1_c1_class.newInstance();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   130
            throw new RuntimeException("Test Failed, access should have been cached above");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   131
        } catch (IllegalAccessError e) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   132
            String message = e.getMessage();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   133
            if (!(message.contains("cannot access") &&
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   134
                  message.contains("because module second_mod does not export p2 to unnamed module"))) {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   135
                throw new RuntimeException("Wrong message: " + message);
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   136
            } else {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   137
                System.out.println("Test Succeeded at attempt #2");
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   138
            }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   139
        }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   140
    }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   141
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   142
    public static void main(String args[]) throws Throwable {
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   143
      AccessExportTwice test = new AccessExportTwice();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   144
      test.createLayerOnBoot();
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   145
    }
e7abeb81e94a 8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff changeset
   146
}