author | alanb |
Fri, 07 Apr 2017 08:04:46 +0000 | |
changeset 44520 | 0553e129e0ec |
parent 43665 | 4bb003cad9b9 |
permissions | -rw-r--r-- |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
1 |
/* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
2 |
* Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
4 |
* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
8 |
* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
13 |
* accompanied this code). |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
14 |
* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
18 |
* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
21 |
* questions. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
22 |
*/ |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
23 |
/* |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
24 |
* @test |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
25 |
* @summary Class p1.c1 in an unnamed module cannot read p2.c2 in module second_mod, |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
26 |
* even after p2 is exported to all unnamed. Ensures constant |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
27 |
* access check answers when not accessible due to exportedness. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
28 |
* @library /test/lib |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
29 |
* @modules java.base/jdk.internal.misc |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
30 |
* @modules java.base/jdk.internal.module |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
31 |
* @compile myloaders/MySameClassLoader.java |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
32 |
* @compile p2/c2.java |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
33 |
* @compile p1/c1.java |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
34 |
* @run main/othervm AccessExportTwice |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
35 |
*/ |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
36 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
37 |
import static jdk.test.lib.Asserts.*; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
38 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
39 |
import java.lang.module.Configuration; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
40 |
import java.lang.module.ModuleDescriptor; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
41 |
import java.lang.module.ModuleFinder; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
42 |
import java.util.HashMap; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
43 |
import java.util.Map; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
44 |
import java.util.Set; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
45 |
import myloaders.MySameClassLoader; |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
46 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
47 |
// |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
48 |
// ClassLoader1 --> defines first_mod --> no packages |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
49 |
// defines second_mod --> packages p2 |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
50 |
// |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
51 |
// first_mod can read second_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
52 |
// package p2 in second_mod is exported to first_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
53 |
// |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
54 |
// class p1.c1 defined in an unnamed module tries to access p2.c2 defined in second_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
55 |
// Access is not allowed, even after p2 is exported to all unnamed modules. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
56 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
57 |
public class AccessExportTwice { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
58 |
|
44520
0553e129e0ec
8177530: Module system implementation refresh (4/2017)
alanb
parents:
43665
diff
changeset
|
59 |
// Create a layer over the boot layer. |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
60 |
// Define modules within this layer to test access between |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
61 |
// publicly defined classes within packages of those modules. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
62 |
public void createLayerOnBoot() throws Throwable { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
63 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
64 |
// Define module: first_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
65 |
// Can read: java.base, second_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
66 |
// Packages: none |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
67 |
// Packages exported: none |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
68 |
ModuleDescriptor descriptor_first_mod = |
43665
4bb003cad9b9
8173393: Module system implementation refresh (2/2017)
alanb
parents:
43444
diff
changeset
|
69 |
ModuleDescriptor.newModule("first_mod") |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
70 |
.requires("java.base") |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
71 |
.requires("second_mod") |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
72 |
.build(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
73 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
74 |
// Define module: second_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
75 |
// Can read: java.base |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
76 |
// Packages: p2 |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
77 |
// Packages exported: p2 is exported to first_mod |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
78 |
ModuleDescriptor descriptor_second_mod = |
43665
4bb003cad9b9
8173393: Module system implementation refresh (2/2017)
alanb
parents:
43444
diff
changeset
|
79 |
ModuleDescriptor.newModule("second_mod") |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
80 |
.requires("java.base") |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
81 |
.exports("p2", Set.of("first_mod")) |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
82 |
.build(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
83 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
84 |
// Set up a ModuleFinder containing all modules for this layer |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
85 |
ModuleFinder finder = ModuleLibrary.of(descriptor_first_mod, descriptor_second_mod); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
86 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
87 |
// Resolves "first_mod" |
44520
0553e129e0ec
8177530: Module system implementation refresh (4/2017)
alanb
parents:
43665
diff
changeset
|
88 |
Configuration cf = ModuleLayer.boot() |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
89 |
.configuration() |
43665
4bb003cad9b9
8173393: Module system implementation refresh (2/2017)
alanb
parents:
43444
diff
changeset
|
90 |
.resolve(finder, ModuleFinder.of(), Set.of("first_mod")); |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
91 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
92 |
// Map each module to the same class loader |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
93 |
Map<String, ClassLoader> map = new HashMap<>(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
94 |
map.put("first_mod", MySameClassLoader.loader1); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
95 |
map.put("second_mod", MySameClassLoader.loader1); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
96 |
|
44520
0553e129e0ec
8177530: Module system implementation refresh (4/2017)
alanb
parents:
43665
diff
changeset
|
97 |
// Create layer that contains first_mod & second_mod |
0553e129e0ec
8177530: Module system implementation refresh (4/2017)
alanb
parents:
43665
diff
changeset
|
98 |
ModuleLayer layer = ModuleLayer.boot().defineModules(cf, map::get); |
43444
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
99 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
100 |
assertTrue(layer.findLoader("first_mod") == MySameClassLoader.loader1); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
101 |
assertTrue(layer.findLoader("second_mod") == MySameClassLoader.loader1); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
102 |
assertTrue(layer.findLoader("java.base") == null); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
103 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
104 |
Class p2_c2_class = MySameClassLoader.loader1.loadClass("p2.c2"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
105 |
// Use the same loader to load class p1.c1 |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
106 |
Class p1_c1_class = MySameClassLoader.loader1.loadClass("p1.c1"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
107 |
// First access check for p1.c1 |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
108 |
try { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
109 |
p1_c1_class.newInstance(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
110 |
throw new RuntimeException("Test Failed, the unnamed module should not have access to public type p2.c2"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
111 |
} catch (IllegalAccessError e) { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
112 |
String message = e.getMessage(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
113 |
if (!(message.contains("cannot access") && |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
114 |
message.contains("because module second_mod does not export p2 to unnamed module"))) { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
115 |
throw new RuntimeException("Wrong message: " + message); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
116 |
} else { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
117 |
System.out.println("Test Succeeded at attempt #1"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
118 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
119 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
120 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
121 |
// Export second_mod/p2 to all unnamed modules. |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
122 |
Module second_mod = p2_c2_class.getModule(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
123 |
jdk.internal.module.Modules.addExportsToAllUnnamed(second_mod, "p2"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
124 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
125 |
// Second access check for p1.c1, should have same result as first |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
126 |
try { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
127 |
p1_c1_class.newInstance(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
128 |
throw new RuntimeException("Test Failed, access should have been cached above"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
129 |
} catch (IllegalAccessError e) { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
130 |
String message = e.getMessage(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
131 |
if (!(message.contains("cannot access") && |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
132 |
message.contains("because module second_mod does not export p2 to unnamed module"))) { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
133 |
throw new RuntimeException("Wrong message: " + message); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
134 |
} else { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
135 |
System.out.println("Test Succeeded at attempt #2"); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
136 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
137 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
138 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
139 |
|
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
140 |
public static void main(String args[]) throws Throwable { |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
141 |
AccessExportTwice test = new AccessExportTwice(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
142 |
test.createLayerOnBoot(); |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
143 |
} |
e7abeb81e94a
8170821: Ensure access checks result in consistent answers
rprotacio
parents:
diff
changeset
|
144 |
} |