src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/verify/VerifyDebugUsage.java
author iveresov
Fri, 02 Feb 2018 17:28:17 -0800
changeset 48861 47f19ff9903c
parent 48190 25cfedf27edc
child 50858 2d3e99a72541
permissions -rw-r--r--
8194819: Update Graal Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     1
/*
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     2
 * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     4
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     7
 * published by the Free Software Foundation.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     8
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    13
 * accompanied this code).
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    14
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    18
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    21
 * questions.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    22
 */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    23
package org.graalvm.compiler.phases.verify;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    24
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    25
import static org.graalvm.compiler.debug.DebugContext.BASIC_LEVEL;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    26
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    27
import java.util.ArrayList;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    28
import java.util.Arrays;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    29
import java.util.HashSet;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    30
import java.util.List;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    31
import java.util.Set;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    32
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    33
import org.graalvm.compiler.core.common.type.ObjectStamp;
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    34
import org.graalvm.compiler.debug.DebugContext;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    35
import org.graalvm.compiler.debug.GraalError;
46509
b32d3928ad6a 8181369: Update Graal
iveresov
parents: 46459
diff changeset
    36
import org.graalvm.compiler.graph.Graph;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    37
import org.graalvm.compiler.graph.Node;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    38
import org.graalvm.compiler.graph.NodeInputList;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    39
import org.graalvm.compiler.nodes.CallTargetNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    40
import org.graalvm.compiler.nodes.Invoke;
48190
25cfedf27edc 8192814: Update Graal
dlong
parents: 47216
diff changeset
    41
import org.graalvm.compiler.nodes.NodeView;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    42
import org.graalvm.compiler.nodes.StructuredGraph;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    43
import org.graalvm.compiler.nodes.ValueNode;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    44
import org.graalvm.compiler.nodes.java.MethodCallTargetNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    45
import org.graalvm.compiler.nodes.java.NewArrayNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    46
import org.graalvm.compiler.nodes.java.StoreIndexedNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    47
import org.graalvm.compiler.phases.VerifyPhase;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    48
import org.graalvm.compiler.phases.tiers.PhaseContext;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    49
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    50
import jdk.vm.ci.meta.Constant;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    51
import jdk.vm.ci.meta.MetaAccessProvider;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    52
import jdk.vm.ci.meta.PrimitiveConstant;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    53
import jdk.vm.ci.meta.ResolvedJavaMethod;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    54
import jdk.vm.ci.meta.ResolvedJavaType;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    55
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    56
/**
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    57
 * Verifies that call sites calling one of the methods in {@link DebugContext} use them correctly.
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    58
 * Correct usage of the methods in {@link DebugContext} requires call sites to not eagerly evaluate
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    59
 * their arguments. Additionally this phase verifies that no argument is the result of a call to
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    60
 * {@link StringBuilder#toString()} or {@link StringBuffer#toString()}. Ideally the parameters at
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    61
 * call sites of {@link DebugContext} are eliminated, and do not produce additional allocations, if
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    62
 * {@link DebugContext#isDumpEnabled(int)} (or {@link DebugContext#isLogEnabled(int)}, ...) is
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    63
 * {@code false}.
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    64
 *
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    65
 * Methods in {@link DebugContext} checked by this phase are various different versions of
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    66
 * {@link DebugContext#log(String)} , {@link DebugContext#dump(int, Object, String)},
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    67
 * {@link DebugContext#logAndIndent(String)} and {@link DebugContext#verify(Object, String)}.
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    68
 */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    69
public class VerifyDebugUsage extends VerifyPhase<PhaseContext> {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    70
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    71
    @Override
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    72
    public boolean checkContract() {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    73
        return false;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    74
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    75
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    76
    MetaAccessProvider metaAccess;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    77
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    78
    @Override
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    79
    protected boolean verify(StructuredGraph graph, PhaseContext context) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    80
        metaAccess = context.getMetaAccess();
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    81
        ResolvedJavaType debugType = metaAccess.lookupJavaType(DebugContext.class);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    82
        ResolvedJavaType nodeType = metaAccess.lookupJavaType(Node.class);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    83
        ResolvedJavaType stringType = metaAccess.lookupJavaType(String.class);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    84
        ResolvedJavaType graalErrorType = metaAccess.lookupJavaType(GraalError.class);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    85
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    86
        for (MethodCallTargetNode t : graph.getNodes(MethodCallTargetNode.TYPE)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    87
            ResolvedJavaMethod callee = t.targetMethod();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    88
            String calleeName = callee.getName();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    89
            if (callee.getDeclaringClass().equals(debugType)) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    90
                boolean isDump = calleeName.equals("dump");
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    91
                if (calleeName.equals("log") || calleeName.equals("logAndIndent") || calleeName.equals("verify") || isDump) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    92
                    verifyParameters(t, graph, t.arguments(), stringType, isDump ? 2 : 1);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    93
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    94
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    95
            if (callee.getDeclaringClass().isAssignableFrom(nodeType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    96
                if (calleeName.equals("assertTrue") || calleeName.equals("assertFalse")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    97
                    verifyParameters(t, graph, t.arguments(), stringType, 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    98
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    99
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   100
            if (callee.getDeclaringClass().isAssignableFrom(graalErrorType) && !graph.method().getDeclaringClass().isAssignableFrom(graalErrorType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   101
                if (calleeName.equals("guarantee")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   102
                    verifyParameters(t, graph, t.arguments(), stringType, 0);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   103
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   104
                if (calleeName.equals("<init>") && callee.getSignature().getParameterCount(false) == 2) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   105
                    verifyParameters(t, graph, t.arguments(), stringType, 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   106
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   107
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   108
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   109
        return true;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   110
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   111
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   112
    private void verifyParameters(MethodCallTargetNode callTarget, StructuredGraph callerGraph, NodeInputList<? extends ValueNode> args, ResolvedJavaType stringType, int startArgIdx) {
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   113
        if (callTarget.targetMethod().isVarArgs() && args.get(args.count() - 1) instanceof NewArrayNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   114
            // unpack the arguments to the var args
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   115
            List<ValueNode> unpacked = new ArrayList<>(args.snapshot());
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   116
            NewArrayNode varArgParameter = (NewArrayNode) unpacked.remove(unpacked.size() - 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   117
            int firstVarArg = unpacked.size();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   118
            for (Node usage : varArgParameter.usages()) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   119
                if (usage instanceof StoreIndexedNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   120
                    StoreIndexedNode si = (StoreIndexedNode) usage;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   121
                    unpacked.add(si.value());
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   122
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   123
            }
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   124
            verifyParameters(callerGraph, callTarget, unpacked, stringType, startArgIdx, firstVarArg);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   125
        } else {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   126
            verifyParameters(callerGraph, callTarget, args, stringType, startArgIdx, -1);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   127
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   128
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   129
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   130
    private static final Set<Integer> DebugLevels = new HashSet<>(
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   131
                    Arrays.asList(DebugContext.ENABLED_LEVEL, BASIC_LEVEL, DebugContext.INFO_LEVEL, DebugContext.VERBOSE_LEVEL, DebugContext.DETAILED_LEVEL, DebugContext.VERY_DETAILED_LEVEL));
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   132
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   133
    /**
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   134
     * The set of methods allowed to call a {@code Debug.dump(...)} method with the {@code level}
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   135
     * parameter bound to {@link DebugContext#BASIC_LEVEL} and the {@code object} parameter bound to
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   136
     * a {@link StructuredGraph} value.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   137
     *
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   138
     * This whitelist exists to ensure any increase in graph dumps is in line with the policy
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   139
     * outlined by {@link DebugContext#BASIC_LEVEL}. If you add a *justified* graph dump at this
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   140
     * level, then update the whitelist.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   141
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   142
    private static final Set<String> BasicLevelStructuredGraphDumpWhitelist = new HashSet<>(Arrays.asList(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   143
                    "org.graalvm.compiler.phases.BasePhase.dumpAfter",
46536
79d8dffda212 8182018: Update Graal
iveresov
parents: 46509
diff changeset
   144
                    "org.graalvm.compiler.phases.BasePhase.dumpBefore",
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   145
                    "org.graalvm.compiler.core.GraalCompiler.emitFrontEnd",
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents: 48190
diff changeset
   146
                    "org.graalvm.compiler.truffle.compiler.PartialEvaluator.fastPartialEvaluation",
47f19ff9903c 8194819: Update Graal
iveresov
parents: 48190
diff changeset
   147
                    "org.graalvm.compiler.truffle.compiler.PartialEvaluator$PerformanceInformationHandler.reportPerformanceWarnings",
47f19ff9903c 8194819: Update Graal
iveresov
parents: 48190
diff changeset
   148
                    "org.graalvm.compiler.truffle.compiler.TruffleCompilerImpl.compilePEGraph",
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   149
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$ValidDumpUsagePhase.run",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   150
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidConcatDumpUsagePhase.run",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   151
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidDumpUsagePhase.run"));
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   152
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   153
    /**
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   154
     * The set of methods allowed to call a {@code Debug.dump(...)} method with the {@code level}
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   155
     * parameter bound to {@link DebugContext#INFO_LEVEL} and the {@code object} parameter bound to
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   156
     * a {@link StructuredGraph} value.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   157
     *
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   158
     * This whitelist exists to ensure any increase in graph dumps is in line with the policy
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   159
     * outlined by {@link DebugContext#INFO_LEVEL}. If you add a *justified* graph dump at this
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   160
     * level, then update the whitelist.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   161
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   162
    private static final Set<String> InfoLevelStructuredGraphDumpWhitelist = new HashSet<>(Arrays.asList(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   163
                    "org.graalvm.compiler.core.GraalCompiler.emitFrontEnd",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   164
                    "org.graalvm.compiler.phases.BasePhase.dumpAfter",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   165
                    "org.graalvm.compiler.replacements.ReplacementsImpl$GraphMaker.makeGraph",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   166
                    "org.graalvm.compiler.replacements.SnippetTemplate.instantiate"));
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   167
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   168
    private void verifyParameters(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, List<? extends ValueNode> args, ResolvedJavaType stringType, int startArgIdx,
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   169
                    int varArgsIndex) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   170
        ResolvedJavaMethod verifiedCallee = debugCallTarget.targetMethod();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   171
        Integer dumpLevel = null;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   172
        int argIdx = startArgIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   173
        int varArgsElementIndex = 0;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   174
        boolean reportVarArgs = false;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   175
        for (int i = 0; i < args.size(); i++) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   176
            ValueNode arg = args.get(i);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   177
            if (arg instanceof Invoke) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   178
                reportVarArgs = varArgsIndex >= 0 && argIdx >= varArgsIndex;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   179
                Invoke invoke = (Invoke) arg;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   180
                CallTargetNode callTarget = invoke.callTarget();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   181
                if (callTarget instanceof MethodCallTargetNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   182
                    ResolvedJavaMethod m = ((MethodCallTargetNode) callTarget).targetMethod();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   183
                    if (m.getName().equals("toString")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   184
                        int bci = invoke.bci();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   185
                        int nonVarArgIdx = reportVarArgs ? argIdx - varArgsElementIndex : argIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   186
                        verifyStringConcat(callerGraph, verifiedCallee, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1, m);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   187
                        verifyToStringCall(callerGraph, verifiedCallee, stringType, m, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   188
                    } else if (m.getName().equals("format")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   189
                        int bci = invoke.bci();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   190
                        int nonVarArgIdx = reportVarArgs ? argIdx - varArgsElementIndex : argIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   191
                        verifyFormatCall(callerGraph, verifiedCallee, stringType, m, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   192
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   193
                    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   194
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   195
            }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   196
            if (i == 1) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   197
                if (verifiedCallee.getName().equals("dump")) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   198
                    dumpLevel = verifyDumpLevelParameter(callerGraph, debugCallTarget, verifiedCallee, arg);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   199
                }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   200
            } else if (i == 2) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   201
                if (dumpLevel != null) {
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   202
                    verifyDumpObjectParameter(callerGraph, debugCallTarget, arg, verifiedCallee, dumpLevel);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   203
                }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   204
            }
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   205
            if (varArgsIndex >= 0 && i >= varArgsIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   206
                varArgsElementIndex++;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   207
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   208
            argIdx++;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   209
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   210
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   211
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   212
    /**
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   213
     * The {@code level} arg for the {@code Debug.dump(...)} methods must be a reference to one of
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   214
     * the {@code Debug.*_LEVEL} constants.
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   215
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   216
    protected Integer verifyDumpLevelParameter(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ResolvedJavaMethod verifiedCallee, ValueNode arg)
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   217
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   218
        // The 'level' arg for the Debug.dump(...) methods must be a reference to one of
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   219
        // the Debug.*_LEVEL constants.
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   220
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   221
        Constant c = arg.asConstant();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   222
        if (c != null) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   223
            Integer dumpLevel = ((PrimitiveConstant) c).asInt();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   224
            if (!DebugLevels.contains(dumpLevel)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   225
                StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   226
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   227
                                "In %s: parameter 0 of call to %s does not match a Debug.*_LEVEL constant: %s.%n", e, verifiedCallee.format("%H.%n(%p)"), dumpLevel);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   228
            }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   229
            return dumpLevel;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   230
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   231
        StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   232
        throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   233
                        "In %s: parameter 0 of call to %s must be a constant, not %s.%n", e, verifiedCallee.format("%H.%n(%p)"), arg);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   234
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   235
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   236
    protected void verifyDumpObjectParameter(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ValueNode arg, ResolvedJavaMethod verifiedCallee, Integer dumpLevel)
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   237
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
48190
25cfedf27edc 8192814: Update Graal
dlong
parents: 47216
diff changeset
   238
        ResolvedJavaType argType = ((ObjectStamp) arg.stamp(NodeView.DEFAULT)).type();
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   239
        if (metaAccess.lookupJavaType(Graph.class).isAssignableFrom(argType)) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   240
            verifyStructuredGraphDumping(callerGraph, debugCallTarget, verifiedCallee, dumpLevel);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   241
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   242
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   243
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   244
    /**
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   245
     * Verifies that dumping a {@link StructuredGraph} at level {@link DebugContext#BASIC_LEVEL} or
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   246
     * {@link DebugContext#INFO_LEVEL} only occurs in white-listed methods.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   247
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   248
    protected void verifyStructuredGraphDumping(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ResolvedJavaMethod verifiedCallee, Integer dumpLevel)
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   249
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   250
        if (dumpLevel == DebugContext.BASIC_LEVEL) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   251
            StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   252
            String qualifiedMethod = e.getClassName() + "." + e.getMethodName();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   253
            if (!BasicLevelStructuredGraphDumpWhitelist.contains(qualifiedMethod)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   254
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   255
                                "In %s: call to %s with level == DebugContext.BASIC_LEVEL not in %s.BasicLevelDumpWhitelist.%n", e, verifiedCallee.format("%H.%n(%p)"),
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   256
                                getClass().getName());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   257
            }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   258
        } else if (dumpLevel == DebugContext.INFO_LEVEL) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   259
            StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   260
            String qualifiedMethod = e.getClassName() + "." + e.getMethodName();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   261
            if (!InfoLevelStructuredGraphDumpWhitelist.contains(qualifiedMethod)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   262
                throw new VerificationError(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   263
                                "In %s: call to %s with level == Debug.INFO_LEVEL not in %s.InfoLevelDumpWhitelist.%n", e, verifiedCallee.format("%H.%n(%p)"),
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   264
                                getClass().getName());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   265
            }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   266
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   267
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   268
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   269
    /**
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   270
     * Checks that a given call is not to {@link StringBuffer#toString()} or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   271
     * {@link StringBuilder#toString()}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   272
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   273
    private static void verifyStringConcat(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, int bci, int argIdx, int varArgsElementIndex, ResolvedJavaMethod callee) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   274
        if (callee.getDeclaringClass().getName().equals("Ljava/lang/StringBuilder;") || callee.getDeclaringClass().getName().equals("Ljava/lang/StringBuffer;")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   275
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   276
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   277
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   278
                                "In %s: element %d of parameter %d of call to %s appears to be a String concatenation expression.%n", e, varArgsElementIndex, argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   279
                                verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   280
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   281
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   282
                                "In %s: parameter %d of call to %s appears to be a String concatenation expression.", e, argIdx, verifiedCallee.format("%H.%n(%p)"));
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   283
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   284
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   285
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   286
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   287
    /**
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   288
     * Checks that a given call is not to {@link Object#toString()}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   289
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   290
    private static void verifyToStringCall(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, ResolvedJavaType stringType, ResolvedJavaMethod callee, int bci, int argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   291
                    int varArgsElementIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   292
        if (callee.getSignature().getParameterCount(false) == 0 && callee.getSignature().getReturnType(callee.getDeclaringClass()).equals(stringType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   293
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   294
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   295
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   296
                                "In %s: element %d of parameter %d of call to %s is a call to toString() which is redundant (the callee will do it) and forces unnecessary eager evaluation.",
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   297
                                e, varArgsElementIndex, argIdx, verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   298
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   299
                throw new VerificationError("In %s: parameter %d of call to %s is a call to toString() which is redundant (the callee will do it) and forces unnecessary eager evaluation.", e, argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   300
                                verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   301
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   302
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   303
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   304
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   305
    /**
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   306
     * Checks that a given call is not to {@link String#format(String, Object...)} or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   307
     * {@link String#format(java.util.Locale, String, Object...)}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   308
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   309
    private static void verifyFormatCall(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, ResolvedJavaType stringType, ResolvedJavaMethod callee, int bci, int argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   310
                    int varArgsElementIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   311
        if (callee.getDeclaringClass().equals(stringType) && callee.getSignature().getReturnType(callee.getDeclaringClass()).equals(stringType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   312
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   313
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   314
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   315
                                "In %s: element %d of parameter %d of call to %s is a call to String.format() which is redundant (%s does formatting) and forces unnecessary eager evaluation.",
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   316
                                e, varArgsElementIndex, argIdx, verifiedCallee.format("%H.%n(%p)"), verifiedCallee.format("%h.%n"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   317
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   318
                throw new VerificationError("In %s: parameter %d of call to %s is a call to String.format() which is redundant (%s does formatting) and forces unnecessary eager evaluation.", e,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   319
                                argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   320
                                verifiedCallee.format("%H.%n(%p)"), verifiedCallee.format("%h.%n"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   321
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   322
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   323
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   324
}