hotspot/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/verify/VerifyDebugUsage.java
author iveresov
Fri, 07 Jul 2017 09:40:47 -0700
changeset 46640 70bdce04c59b
parent 46536 79d8dffda212
permissions -rw-r--r--
8183991: Update Graal Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     1
/*
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     2
 * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     4
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     7
 * published by the Free Software Foundation.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     8
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    13
 * accompanied this code).
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    14
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    18
 *
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    21
 * questions.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    22
 */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    23
package org.graalvm.compiler.phases.verify;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    24
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    25
import static org.graalvm.compiler.debug.DebugContext.BASIC_LEVEL;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    26
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    27
import java.util.ArrayList;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    28
import java.util.Arrays;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    29
import java.util.HashSet;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    30
import java.util.List;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    31
import java.util.Set;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    32
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    33
import org.graalvm.compiler.core.common.type.ObjectStamp;
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    34
import org.graalvm.compiler.debug.DebugContext;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    35
import org.graalvm.compiler.debug.GraalError;
46509
b32d3928ad6a 8181369: Update Graal
iveresov
parents: 46459
diff changeset
    36
import org.graalvm.compiler.graph.Graph;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    37
import org.graalvm.compiler.graph.Node;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    38
import org.graalvm.compiler.graph.NodeInputList;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    39
import org.graalvm.compiler.nodes.CallTargetNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    40
import org.graalvm.compiler.nodes.Invoke;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    41
import org.graalvm.compiler.nodes.StructuredGraph;
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    42
import org.graalvm.compiler.nodes.ValueNode;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    43
import org.graalvm.compiler.nodes.java.MethodCallTargetNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    44
import org.graalvm.compiler.nodes.java.NewArrayNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    45
import org.graalvm.compiler.nodes.java.StoreIndexedNode;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    46
import org.graalvm.compiler.phases.VerifyPhase;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    47
import org.graalvm.compiler.phases.tiers.PhaseContext;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    48
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    49
import jdk.vm.ci.meta.Constant;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    50
import jdk.vm.ci.meta.MetaAccessProvider;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    51
import jdk.vm.ci.meta.PrimitiveConstant;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    52
import jdk.vm.ci.meta.ResolvedJavaMethod;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    53
import jdk.vm.ci.meta.ResolvedJavaType;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    54
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    55
/**
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    56
 * Verifies that call sites calling one of the methods in {@link DebugContext} use them correctly.
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    57
 * Correct usage of the methods in {@link DebugContext} requires call sites to not eagerly evaluate
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    58
 * their arguments. Additionally this phase verifies that no argument is the result of a call to
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    59
 * {@link StringBuilder#toString()} or {@link StringBuffer#toString()}. Ideally the parameters at
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    60
 * call sites of {@link DebugContext} are eliminated, and do not produce additional allocations, if
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    61
 * {@link DebugContext#isDumpEnabled(int)} (or {@link DebugContext#isLogEnabled(int)}, ...) is
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    62
 * {@code false}.
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    63
 *
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    64
 * Methods in {@link DebugContext} checked by this phase are various different versions of
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    65
 * {@link DebugContext#log(String)} , {@link DebugContext#dump(int, Object, String)},
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    66
 * {@link DebugContext#logAndIndent(String)} and {@link DebugContext#verify(Object, String)}.
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    67
 */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    68
public class VerifyDebugUsage extends VerifyPhase<PhaseContext> {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    69
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    70
    @Override
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    71
    public boolean checkContract() {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    72
        return false;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    73
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    74
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    75
    MetaAccessProvider metaAccess;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    76
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    77
    @Override
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    78
    protected boolean verify(StructuredGraph graph, PhaseContext context) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    79
        metaAccess = context.getMetaAccess();
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
    80
        ResolvedJavaType debugType = metaAccess.lookupJavaType(DebugContext.class);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    81
        ResolvedJavaType nodeType = metaAccess.lookupJavaType(Node.class);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    82
        ResolvedJavaType stringType = metaAccess.lookupJavaType(String.class);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    83
        ResolvedJavaType graalErrorType = metaAccess.lookupJavaType(GraalError.class);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    84
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    85
        for (MethodCallTargetNode t : graph.getNodes(MethodCallTargetNode.TYPE)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    86
            ResolvedJavaMethod callee = t.targetMethod();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    87
            String calleeName = callee.getName();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    88
            if (callee.getDeclaringClass().equals(debugType)) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    89
                boolean isDump = calleeName.equals("dump");
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    90
                if (calleeName.equals("log") || calleeName.equals("logAndIndent") || calleeName.equals("verify") || isDump) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
    91
                    verifyParameters(t, graph, t.arguments(), stringType, isDump ? 2 : 1);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    92
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    93
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    94
            if (callee.getDeclaringClass().isAssignableFrom(nodeType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    95
                if (calleeName.equals("assertTrue") || calleeName.equals("assertFalse")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    96
                    verifyParameters(t, graph, t.arguments(), stringType, 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    97
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    98
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
    99
            if (callee.getDeclaringClass().isAssignableFrom(graalErrorType) && !graph.method().getDeclaringClass().isAssignableFrom(graalErrorType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   100
                if (calleeName.equals("guarantee")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   101
                    verifyParameters(t, graph, t.arguments(), stringType, 0);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   102
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   103
                if (calleeName.equals("<init>") && callee.getSignature().getParameterCount(false) == 2) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   104
                    verifyParameters(t, graph, t.arguments(), stringType, 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   105
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   106
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   107
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   108
        return true;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   109
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   110
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   111
    private void verifyParameters(MethodCallTargetNode callTarget, StructuredGraph callerGraph, NodeInputList<? extends ValueNode> args, ResolvedJavaType stringType, int startArgIdx) {
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   112
        if (callTarget.targetMethod().isVarArgs() && args.get(args.count() - 1) instanceof NewArrayNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   113
            // unpack the arguments to the var args
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   114
            List<ValueNode> unpacked = new ArrayList<>(args.snapshot());
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   115
            NewArrayNode varArgParameter = (NewArrayNode) unpacked.remove(unpacked.size() - 1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   116
            int firstVarArg = unpacked.size();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   117
            for (Node usage : varArgParameter.usages()) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   118
                if (usage instanceof StoreIndexedNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   119
                    StoreIndexedNode si = (StoreIndexedNode) usage;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   120
                    unpacked.add(si.value());
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   121
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   122
            }
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   123
            verifyParameters(callerGraph, callTarget, unpacked, stringType, startArgIdx, firstVarArg);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   124
        } else {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   125
            verifyParameters(callerGraph, callTarget, args, stringType, startArgIdx, -1);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   126
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   127
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   128
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   129
    private static final Set<Integer> DebugLevels = new HashSet<>(
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   130
                    Arrays.asList(DebugContext.ENABLED_LEVEL, BASIC_LEVEL, DebugContext.INFO_LEVEL, DebugContext.VERBOSE_LEVEL, DebugContext.DETAILED_LEVEL, DebugContext.VERY_DETAILED_LEVEL));
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   131
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   132
    /**
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   133
     * The set of methods allowed to call a {@code Debug.dump(...)} method with the {@code level}
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   134
     * parameter bound to {@link DebugContext#BASIC_LEVEL} and the {@code object} parameter bound to
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   135
     * a {@link StructuredGraph} value.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   136
     *
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   137
     * This whitelist exists to ensure any increase in graph dumps is in line with the policy
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   138
     * outlined by {@link DebugContext#BASIC_LEVEL}. If you add a *justified* graph dump at this
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   139
     * level, then update the whitelist.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   140
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   141
    private static final Set<String> BasicLevelStructuredGraphDumpWhitelist = new HashSet<>(Arrays.asList(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   142
                    "org.graalvm.compiler.phases.BasePhase.dumpAfter",
46536
79d8dffda212 8182018: Update Graal
iveresov
parents: 46509
diff changeset
   143
                    "org.graalvm.compiler.phases.BasePhase.dumpBefore",
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   144
                    "org.graalvm.compiler.core.GraalCompiler.emitFrontEnd",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   145
                    "org.graalvm.compiler.truffle.PartialEvaluator.fastPartialEvaluation",
46459
7d4e637d3f21 8180267: Update Graal
kvn
parents: 46371
diff changeset
   146
                    "org.graalvm.compiler.truffle.PartialEvaluator$PerformanceInformationHandler.reportPerformanceWarnings",
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   147
                    "org.graalvm.compiler.truffle.TruffleCompiler.compileMethodHelper",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   148
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$ValidDumpUsagePhase.run",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   149
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidConcatDumpUsagePhase.run",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   150
                    "org.graalvm.compiler.core.test.VerifyDebugUsageTest$InvalidDumpUsagePhase.run"));
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   151
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   152
    /**
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   153
     * The set of methods allowed to call a {@code Debug.dump(...)} method with the {@code level}
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   154
     * parameter bound to {@link DebugContext#INFO_LEVEL} and the {@code object} parameter bound to
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   155
     * a {@link StructuredGraph} value.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   156
     *
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   157
     * This whitelist exists to ensure any increase in graph dumps is in line with the policy
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   158
     * outlined by {@link DebugContext#INFO_LEVEL}. If you add a *justified* graph dump at this
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   159
     * level, then update the whitelist.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   160
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   161
    private static final Set<String> InfoLevelStructuredGraphDumpWhitelist = new HashSet<>(Arrays.asList(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   162
                    "org.graalvm.compiler.core.GraalCompiler.emitFrontEnd",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   163
                    "org.graalvm.compiler.phases.BasePhase.dumpAfter",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   164
                    "org.graalvm.compiler.replacements.ReplacementsImpl$GraphMaker.makeGraph",
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   165
                    "org.graalvm.compiler.replacements.SnippetTemplate.instantiate"));
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   166
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   167
    private void verifyParameters(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, List<? extends ValueNode> args, ResolvedJavaType stringType, int startArgIdx,
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   168
                    int varArgsIndex) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   169
        ResolvedJavaMethod verifiedCallee = debugCallTarget.targetMethod();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   170
        Integer dumpLevel = null;
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   171
        int argIdx = startArgIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   172
        int varArgsElementIndex = 0;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   173
        boolean reportVarArgs = false;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   174
        for (int i = 0; i < args.size(); i++) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   175
            ValueNode arg = args.get(i);
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   176
            if (arg instanceof Invoke) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   177
                reportVarArgs = varArgsIndex >= 0 && argIdx >= varArgsIndex;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   178
                Invoke invoke = (Invoke) arg;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   179
                CallTargetNode callTarget = invoke.callTarget();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   180
                if (callTarget instanceof MethodCallTargetNode) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   181
                    ResolvedJavaMethod m = ((MethodCallTargetNode) callTarget).targetMethod();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   182
                    if (m.getName().equals("toString")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   183
                        int bci = invoke.bci();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   184
                        int nonVarArgIdx = reportVarArgs ? argIdx - varArgsElementIndex : argIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   185
                        verifyStringConcat(callerGraph, verifiedCallee, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1, m);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   186
                        verifyToStringCall(callerGraph, verifiedCallee, stringType, m, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   187
                    } else if (m.getName().equals("format")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   188
                        int bci = invoke.bci();
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   189
                        int nonVarArgIdx = reportVarArgs ? argIdx - varArgsElementIndex : argIdx;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   190
                        verifyFormatCall(callerGraph, verifiedCallee, stringType, m, bci, nonVarArgIdx, reportVarArgs ? varArgsElementIndex : -1);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   191
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   192
                    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   193
                }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   194
            }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   195
            if (i == 1) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   196
                if (verifiedCallee.getName().equals("dump")) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   197
                    dumpLevel = verifyDumpLevelParameter(callerGraph, debugCallTarget, verifiedCallee, arg);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   198
                }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   199
            } else if (i == 2) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   200
                if (dumpLevel != null) {
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   201
                    verifyDumpObjectParameter(callerGraph, debugCallTarget, arg, verifiedCallee, dumpLevel);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   202
                }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   203
            }
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   204
            if (varArgsIndex >= 0 && i >= varArgsIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   205
                varArgsElementIndex++;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   206
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   207
            argIdx++;
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   208
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   209
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   210
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   211
    /**
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   212
     * The {@code level} arg for the {@code Debug.dump(...)} methods must be a reference to one of
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   213
     * the {@code Debug.*_LEVEL} constants.
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   214
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   215
    protected Integer verifyDumpLevelParameter(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ResolvedJavaMethod verifiedCallee, ValueNode arg)
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   216
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   217
        // The 'level' arg for the Debug.dump(...) methods must be a reference to one of
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   218
        // the Debug.*_LEVEL constants.
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   219
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   220
        Constant c = arg.asConstant();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   221
        if (c != null) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   222
            Integer dumpLevel = ((PrimitiveConstant) c).asInt();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   223
            if (!DebugLevels.contains(dumpLevel)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   224
                StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   225
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   226
                                "In %s: parameter 0 of call to %s does not match a Debug.*_LEVEL constant: %s.%n", e, verifiedCallee.format("%H.%n(%p)"), dumpLevel);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   227
            }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   228
            return dumpLevel;
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   229
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   230
        StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   231
        throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   232
                        "In %s: parameter 0 of call to %s must be a constant, not %s.%n", e, verifiedCallee.format("%H.%n(%p)"), arg);
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   233
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   234
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   235
    protected void verifyDumpObjectParameter(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ValueNode arg, ResolvedJavaMethod verifiedCallee, Integer dumpLevel)
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   236
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   237
        ResolvedJavaType argType = ((ObjectStamp) arg.stamp()).type();
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   238
        if (metaAccess.lookupJavaType(Graph.class).isAssignableFrom(argType)) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   239
            verifyStructuredGraphDumping(callerGraph, debugCallTarget, verifiedCallee, dumpLevel);
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   240
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   241
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   242
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   243
    /**
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   244
     * Verifies that dumping a {@link StructuredGraph} at level {@link DebugContext#BASIC_LEVEL} or
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   245
     * {@link DebugContext#INFO_LEVEL} only occurs in white-listed methods.
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   246
     */
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   247
    protected void verifyStructuredGraphDumping(StructuredGraph callerGraph, MethodCallTargetNode debugCallTarget, ResolvedJavaMethod verifiedCallee, Integer dumpLevel)
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   248
                    throws org.graalvm.compiler.phases.VerifyPhase.VerificationError {
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   249
        if (dumpLevel == DebugContext.BASIC_LEVEL) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   250
            StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   251
            String qualifiedMethod = e.getClassName() + "." + e.getMethodName();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   252
            if (!BasicLevelStructuredGraphDumpWhitelist.contains(qualifiedMethod)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   253
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   254
                                "In %s: call to %s with level == DebugContext.BASIC_LEVEL not in %s.BasicLevelDumpWhitelist.%n", e, verifiedCallee.format("%H.%n(%p)"),
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   255
                                getClass().getName());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   256
            }
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   257
        } else if (dumpLevel == DebugContext.INFO_LEVEL) {
46371
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   258
            StackTraceElement e = callerGraph.method().asStackTraceElement(debugCallTarget.invoke().bci());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   259
            String qualifiedMethod = e.getClassName() + "." + e.getMethodName();
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   260
            if (!InfoLevelStructuredGraphDumpWhitelist.contains(qualifiedMethod)) {
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   261
                throw new VerificationError(
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   262
                                "In %s: call to %s with level == Debug.INFO_LEVEL not in %s.InfoLevelDumpWhitelist.%n", e, verifiedCallee.format("%H.%n(%p)"),
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   263
                                getClass().getName());
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   264
            }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   265
        }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   266
    }
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   267
0337d0617e7b 8178088: Update Graal
iveresov
parents: 46344
diff changeset
   268
    /**
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   269
     * Checks that a given call is not to {@link StringBuffer#toString()} or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   270
     * {@link StringBuilder#toString()}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   271
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   272
    private static void verifyStringConcat(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, int bci, int argIdx, int varArgsElementIndex, ResolvedJavaMethod callee) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   273
        if (callee.getDeclaringClass().getName().equals("Ljava/lang/StringBuilder;") || callee.getDeclaringClass().getName().equals("Ljava/lang/StringBuffer;")) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   274
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   275
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   276
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   277
                                "In %s: element %d of parameter %d of call to %s appears to be a String concatenation expression.%n", e, varArgsElementIndex, argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   278
                                verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   279
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   280
                throw new VerificationError(
46640
70bdce04c59b 8183991: Update Graal
iveresov
parents: 46536
diff changeset
   281
                                "In %s: parameter %d of call to %s appears to be a String concatenation expression.", e, argIdx, verifiedCallee.format("%H.%n(%p)"));
43972
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   282
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   283
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   284
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   285
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   286
    /**
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   287
     * Checks that a given call is not to {@link Object#toString()}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   288
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   289
    private static void verifyToStringCall(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, ResolvedJavaType stringType, ResolvedJavaMethod callee, int bci, int argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   290
                    int varArgsElementIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   291
        if (callee.getSignature().getParameterCount(false) == 0 && callee.getSignature().getReturnType(callee.getDeclaringClass()).equals(stringType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   292
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   293
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   294
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   295
                                "In %s: element %d of parameter %d of call to %s is a call to toString() which is redundant (the callee will do it) and forces unnecessary eager evaluation.",
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   296
                                e, varArgsElementIndex, argIdx, verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   297
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   298
                throw new VerificationError("In %s: parameter %d of call to %s is a call to toString() which is redundant (the callee will do it) and forces unnecessary eager evaluation.", e, argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   299
                                verifiedCallee.format("%H.%n(%p)"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   300
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   301
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   302
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   303
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   304
    /**
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   305
     * Checks that a given call is not to {@link String#format(String, Object...)} or
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   306
     * {@link String#format(java.util.Locale, String, Object...)}.
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   307
     */
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   308
    private static void verifyFormatCall(StructuredGraph callerGraph, ResolvedJavaMethod verifiedCallee, ResolvedJavaType stringType, ResolvedJavaMethod callee, int bci, int argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   309
                    int varArgsElementIndex) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   310
        if (callee.getDeclaringClass().equals(stringType) && callee.getSignature().getReturnType(callee.getDeclaringClass()).equals(stringType)) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   311
            StackTraceElement e = callerGraph.method().asStackTraceElement(bci);
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   312
            if (varArgsElementIndex >= 0) {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   313
                throw new VerificationError(
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   314
                                "In %s: element %d of parameter %d of call to %s is a call to String.format() which is redundant (%s does formatting) and forces unnecessary eager evaluation.",
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   315
                                e, varArgsElementIndex, argIdx, verifiedCallee.format("%H.%n(%p)"), verifiedCallee.format("%h.%n"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   316
            } else {
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   317
                throw new VerificationError("In %s: parameter %d of call to %s is a call to String.format() which is redundant (%s does formatting) and forces unnecessary eager evaluation.", e,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   318
                                argIdx,
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   319
                                verifiedCallee.format("%H.%n(%p)"), verifiedCallee.format("%h.%n"));
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   320
            }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   321
        }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   322
    }
1ade39b8381b 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci
kvn
parents:
diff changeset
   323
}