author | tschatzl |
Fri, 08 Feb 2019 12:55:20 +0100 | |
changeset 53703 | 24341625d8f2 |
parent 51494 | 1906adbef2dc |
permissions | -rw-r--r-- |
1374 | 1 |
/* |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
2 |
* Copyright (c) 2001, 2019, Oracle and/or its affiliates. All rights reserved. |
1374 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4473
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4473
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
4473
diff
changeset
|
21 |
* questions. |
1374 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
30764 | 26 |
#include "gc/g1/collectionSetChooser.hpp" |
27 |
#include "gc/g1/g1CollectedHeap.inline.hpp" |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
28 |
#include "gc/g1/g1CollectionSetCandidates.hpp" |
49607
acffe6ff3ae7
8180415: Rebuild remembered sets during the concurrent cycle
tschatzl
parents:
49605
diff
changeset
|
29 |
#include "gc/g1/heapRegionRemSet.hpp" |
30764 | 30 |
#include "gc/shared/space.inline.hpp" |
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
37985
diff
changeset
|
31 |
#include "runtime/atomic.hpp" |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
32 |
#include "utilities/quickSort.hpp" |
1374 | 33 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
34 |
// Order regions according to GC efficiency. This will cause regions with a lot |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
35 |
// of live objects and large remembered sets to end up at the end of the array. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
36 |
// Given that we might skip collecting the last few old regions, if after a few |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
37 |
// mixed GCs the remaining have reclaimable bytes under a certain threshold, the |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
38 |
// hope is that the ones we'll skip are ones with both large remembered sets and |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
39 |
// a lot of live objects, not the ones with just a lot of live objects if we |
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
40 |
// ordered according to the amount of reclaimable bytes per region. |
12382
6aaecb1cbfe1
7145441: G1: collection set chooser-related cleanup
tonyp
parents:
12381
diff
changeset
|
41 |
static int order_regions(HeapRegion* hr1, HeapRegion* hr2) { |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
42 |
// Make sure that NULL entries are moved to the end. |
1374 | 43 |
if (hr1 == NULL) { |
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
44 |
if (hr2 == NULL) { |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
45 |
return 0; |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
46 |
} else { |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
47 |
return 1; |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
48 |
} |
1374 | 49 |
} else if (hr2 == NULL) { |
50 |
return -1; |
|
51 |
} |
|
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
52 |
|
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
53 |
double gc_eff1 = hr1->gc_efficiency(); |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
54 |
double gc_eff2 = hr2->gc_efficiency(); |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
55 |
|
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
56 |
if (gc_eff1 > gc_eff2) { |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
57 |
return -1; |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
58 |
} if (gc_eff1 < gc_eff2) { |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
59 |
return 1; |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
60 |
} else { |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
61 |
return 0; |
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
62 |
} |
1374 | 63 |
} |
64 |
||
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
65 |
// Determine collection set candidates: For all regions determine whether they |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
66 |
// should be a collection set candidates, calculate their efficiency, sort and |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
67 |
// return them as G1CollectionSetCandidates instance. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
68 |
// Threads calculate the GC efficiency of the regions they get to process, and |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
69 |
// put them into some work area unsorted. At the end the array is sorted and |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
70 |
// copied into the G1CollectionSetCandidates instance; the caller will be the new |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
71 |
// owner of this object. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
72 |
class G1BuildCandidateRegionsTask : public AbstractGangTask { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
73 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
74 |
// Work area for building the set of collection set candidates. Contains references |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
75 |
// to heap regions with their GC efficiencies calculated. To reduce contention |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
76 |
// on claiming array elements, worker threads claim parts of this array in chunks; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
77 |
// Array elements may be NULL as threads might not get enough regions to fill |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
78 |
// up their chunks completely. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
79 |
// Final sorting will remove them. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
80 |
class G1BuildCandidateArray : public StackObj { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
81 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
82 |
uint const _max_size; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
83 |
uint const _chunk_size; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
84 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
85 |
HeapRegion** _data; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
86 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
87 |
uint volatile _cur_claim_idx; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
88 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
89 |
// Calculates the maximum array size that will be used. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
90 |
static uint required_array_size(uint num_regions, uint num_workers, uint chunk_size) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
91 |
uint const max_waste = num_workers * chunk_size; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
92 |
// The array should be aligned with respect to chunk_size. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
93 |
uint const aligned_num_regions = ((num_regions + chunk_size - 1) / chunk_size) * chunk_size; |
1374 | 94 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
95 |
return aligned_num_regions + max_waste; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
96 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
97 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
98 |
public: |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
99 |
G1BuildCandidateArray(uint max_num_regions, uint num_workers, uint chunk_size) : |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
100 |
_max_size(required_array_size(max_num_regions, num_workers, chunk_size)), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
101 |
_chunk_size(chunk_size), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
102 |
_data(NEW_C_HEAP_ARRAY(HeapRegion*, _max_size, mtGC)), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
103 |
_cur_claim_idx(0) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
104 |
for (uint i = 0; i < _max_size; i++) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
105 |
_data[i] = NULL; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
106 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
107 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
108 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
109 |
~G1BuildCandidateArray() { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
110 |
FREE_C_HEAP_ARRAY(HeapRegion*, _data); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
111 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
112 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
113 |
// Claim a new chunk, returning its bounds [from, to[. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
114 |
void claim_chunk(uint& from, uint& to) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
115 |
uint result = Atomic::add(_chunk_size, &_cur_claim_idx); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
116 |
assert(_max_size > result - 1, |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
117 |
"Array too small, is %u should be %u with chunk size %u.", |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
118 |
_max_size, result, _chunk_size); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
119 |
from = result - _chunk_size; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
120 |
to = result; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
121 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
122 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
123 |
// Set element in array. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
124 |
void set(uint idx, HeapRegion* hr) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
125 |
assert(idx < _max_size, "Index %u out of bounds %u", idx, _max_size); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
126 |
assert(_data[idx] == NULL, "Value must not have been set."); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
127 |
_data[idx] = hr; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
128 |
} |
1374 | 129 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
130 |
void sort_and_copy_into(HeapRegion** dest, uint num_regions) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
131 |
if (_cur_claim_idx == 0) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
132 |
return; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
133 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
134 |
for (uint i = _cur_claim_idx; i < _max_size; i++) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
135 |
assert(_data[i] == NULL, "must be"); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
136 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
137 |
QuickSort::sort(_data, _cur_claim_idx, order_regions, true); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
138 |
for (uint i = num_regions; i < _max_size; i++) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
139 |
assert(_data[i] == NULL, "must be"); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
140 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
141 |
for (uint i = 0; i < num_regions; i++) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
142 |
dest[i] = _data[i]; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
143 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
144 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
145 |
}; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
146 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
147 |
// Per-region closure. In addition to determining whether a region should be |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
148 |
// added to the candidates, and calculating those regions' gc efficiencies, also |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
149 |
// gather additional statistics. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
150 |
class G1BuildCandidateRegionsClosure : public HeapRegionClosure { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
151 |
G1BuildCandidateArray* _array; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
152 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
153 |
uint _cur_chunk_idx; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
154 |
uint _cur_chunk_end; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
155 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
156 |
uint _regions_added; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
157 |
size_t _reclaimable_bytes_added; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
158 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
159 |
void add_region(HeapRegion* hr) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
160 |
if (_cur_chunk_idx == _cur_chunk_end) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
161 |
_array->claim_chunk(_cur_chunk_idx, _cur_chunk_end); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
162 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
163 |
assert(_cur_chunk_idx < _cur_chunk_end, "Must be"); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
164 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
165 |
hr->calc_gc_efficiency(); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
166 |
_array->set(_cur_chunk_idx, hr); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
167 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
168 |
_cur_chunk_idx++; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
169 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
170 |
_regions_added++; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
171 |
_reclaimable_bytes_added += hr->reclaimable_bytes(); |
1374 | 172 |
} |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
173 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
174 |
bool should_add(HeapRegion* hr) { return CollectionSetChooser::should_add(hr); } |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
175 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
176 |
public: |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
177 |
G1BuildCandidateRegionsClosure(G1BuildCandidateArray* array) : |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
178 |
_array(array), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
179 |
_cur_chunk_idx(0), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
180 |
_cur_chunk_end(0), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
181 |
_regions_added(0), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
182 |
_reclaimable_bytes_added(0) { } |
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
183 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
184 |
bool do_heap_region(HeapRegion* r) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
185 |
// We will skip any region that's currently used as an old GC |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
186 |
// alloc region (we should not consider those for collection |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
187 |
// before we fill them up). |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
188 |
if (should_add(r) && !G1CollectedHeap::heap()->is_old_gc_alloc_region(r)) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
189 |
add_region(r); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
190 |
} else if (r->is_old()) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
191 |
// Keep remembered sets for humongous regions, otherwise clean out remembered |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
192 |
// sets for old regions. |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
193 |
r->rem_set()->clear(true /* only_cardset */); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
194 |
} else { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
195 |
assert(r->is_archive() || !r->is_old() || !r->rem_set()->is_tracked(), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
196 |
"Missed to clear unused remembered set of region %u (%s) that is %s", |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
197 |
r->hrm_index(), r->get_type_str(), r->rem_set()->get_state_str()); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
198 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
199 |
return false; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
200 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
201 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
202 |
uint regions_added() const { return _regions_added; } |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
203 |
size_t reclaimable_bytes_added() const { return _reclaimable_bytes_added; } |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
204 |
}; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
205 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
206 |
G1CollectedHeap* _g1h; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
207 |
HeapRegionClaimer _hrclaimer; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
208 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
209 |
uint volatile _num_regions_added; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
210 |
size_t volatile _reclaimable_bytes_added; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
211 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
212 |
G1BuildCandidateArray _result; |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
213 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
214 |
void update_totals(uint num_regions, size_t reclaimable_bytes) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
215 |
if (num_regions > 0) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
216 |
assert(reclaimable_bytes > 0, "invariant"); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
217 |
Atomic::add(num_regions, &_num_regions_added); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
218 |
Atomic::add(reclaimable_bytes, &_reclaimable_bytes_added); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
219 |
} else { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
220 |
assert(reclaimable_bytes == 0, "invariant"); |
1374 | 221 |
} |
222 |
} |
|
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
223 |
|
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
224 |
public: |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
225 |
G1BuildCandidateRegionsTask(uint max_num_regions, uint chunk_size, uint num_workers) : |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
226 |
AbstractGangTask("G1 Build Candidate Regions"), |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
227 |
_g1h(G1CollectedHeap::heap()), |
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
228 |
_hrclaimer(num_workers), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
229 |
_num_regions_added(0), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
230 |
_reclaimable_bytes_added(0), |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
231 |
_result(max_num_regions, chunk_size, num_workers) { } |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
232 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
233 |
void work(uint worker_id) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
234 |
G1BuildCandidateRegionsClosure cl(&_result); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
235 |
_g1h->heap_region_par_iterate_from_worker_offset(&cl, &_hrclaimer, worker_id); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
236 |
update_totals(cl.regions_added(), cl.reclaimable_bytes_added()); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
237 |
} |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
238 |
|
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
239 |
G1CollectionSetCandidates* get_sorted_candidates() { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
240 |
HeapRegion** regions = NEW_C_HEAP_ARRAY(HeapRegion*, _num_regions_added, mtGC); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
241 |
_result.sort_and_copy_into(regions, _num_regions_added); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
242 |
return new G1CollectionSetCandidates(regions, |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
243 |
_num_regions_added, |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
244 |
_reclaimable_bytes_added); |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
245 |
} |
11756
28b6fe22e43d
7132029: G1: mixed GC phase lasts for longer than it should
tonyp
parents:
11396
diff
changeset
|
246 |
}; |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
247 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
248 |
uint CollectionSetChooser::calculate_work_chunk_size(uint num_workers, uint num_regions) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
249 |
assert(num_workers > 0, "Active gc workers should be greater than 0"); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
250 |
return MAX2(num_regions / num_workers, 1U); |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
251 |
} |
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
252 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
253 |
bool CollectionSetChooser::should_add(HeapRegion* hr) { |
50441
523c2a73a3dc
8204081: Mismatch in rebuild policy and collection set chooser causes remembered sets to be kept errorneously
tschatzl
parents:
49806
diff
changeset
|
254 |
return !hr->is_young() && |
523c2a73a3dc
8204081: Mismatch in rebuild policy and collection set chooser causes remembered sets to be kept errorneously
tschatzl
parents:
49806
diff
changeset
|
255 |
!hr->is_pinned() && |
523c2a73a3dc
8204081: Mismatch in rebuild policy and collection set chooser causes remembered sets to be kept errorneously
tschatzl
parents:
49806
diff
changeset
|
256 |
region_occupancy_low_enough_for_evac(hr->live_bytes()) && |
523c2a73a3dc
8204081: Mismatch in rebuild policy and collection set chooser causes remembered sets to be kept errorneously
tschatzl
parents:
49806
diff
changeset
|
257 |
hr->rem_set()->is_complete(); |
49605
784f3f2dea14
8197570: Make rules for choosing collection set candidates more explicit
tschatzl
parents:
48969
diff
changeset
|
258 |
} |
784f3f2dea14
8197570: Make rules for choosing collection set candidates more explicit
tschatzl
parents:
48969
diff
changeset
|
259 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
260 |
G1CollectionSetCandidates* CollectionSetChooser::build(WorkGang* workers, uint max_num_regions) { |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
261 |
uint num_workers = workers->active_workers(); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
262 |
uint chunk_size = calculate_work_chunk_size(num_workers, max_num_regions); |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
263 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
264 |
G1BuildCandidateRegionsTask cl(max_num_regions, chunk_size, num_workers); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
265 |
workers->run_task(&cl, num_workers); |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
266 |
|
53703
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
267 |
G1CollectionSetCandidates* result = cl.get_sorted_candidates(); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
268 |
result->verify(); |
24341625d8f2
8217330: Split G1CollectionSetChooser into collection set candidate container and the chooser algorithm
tschatzl
parents:
51494
diff
changeset
|
269 |
return result; |
37143
345ad6728be3
8151637: Move CollectionSetChooser rebuild code into CollectionSetChooser
mgerdin
parents:
35061
diff
changeset
|
270 |
} |