author | jjg |
Tue, 20 Dec 2016 05:50:39 -0800 | |
changeset 42841 | 1768507dae6b |
parent 42827 | 36468b5fa7f4 |
child 43138 | 680d378b9d64 |
permissions | -rw-r--r-- |
36526 | 1 |
/* |
2 |
* Copyright (c) 2009, 2016, Oracle and/or its affiliates. All rights reserved. |
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
|
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. Oracle designates this |
|
8 |
* particular file as subject to the "Classpath" exception as provided |
|
9 |
* by Oracle in the LICENSE file that accompanied this code. |
|
10 |
* |
|
11 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
12 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
13 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
14 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
15 |
* accompanied this code). |
|
16 |
* |
|
17 |
* You should have received a copy of the GNU General Public License version |
|
18 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
19 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
20 |
* |
|
21 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
22 |
* or visit www.oracle.com if you need additional information or have any |
|
23 |
* questions. |
|
24 |
*/ |
|
25 |
||
26 |
||
27 |
package com.sun.tools.javac.comp; |
|
28 |
||
29 |
import java.io.IOException; |
|
30 |
import java.util.Arrays; |
|
31 |
import java.util.Collection; |
|
32 |
import java.util.Collections; |
|
33 |
import java.util.EnumSet; |
|
34 |
import java.util.HashMap; |
|
35 |
import java.util.HashSet; |
|
36 |
import java.util.LinkedHashMap; |
|
37 |
import java.util.LinkedHashSet; |
|
38 |
import java.util.Map; |
|
39 |
import java.util.Set; |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
40 |
import java.util.function.Consumer; |
36526 | 41 |
import java.util.function.Predicate; |
42 |
import java.util.regex.Matcher; |
|
43 |
import java.util.regex.Pattern; |
|
44 |
import java.util.stream.Stream; |
|
45 |
||
46 |
import javax.lang.model.SourceVersion; |
|
47 |
import javax.tools.JavaFileManager; |
|
48 |
import javax.tools.JavaFileManager.Location; |
|
49 |
import javax.tools.JavaFileObject; |
|
50 |
import javax.tools.JavaFileObject.Kind; |
|
51 |
import javax.tools.StandardLocation; |
|
52 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
53 |
import com.sun.source.tree.ModuleTree.ModuleKind; |
39361
cd0aca7db174
8159439: javac throws NPE with Module attribute and super_class != 0
vromero
parents:
38827
diff
changeset
|
54 |
import com.sun.tools.javac.code.ClassFinder; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
55 |
import com.sun.tools.javac.code.DeferredLintHandler; |
36526 | 56 |
import com.sun.tools.javac.code.Directive; |
57 |
import com.sun.tools.javac.code.Directive.ExportsDirective; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
58 |
import com.sun.tools.javac.code.Directive.ExportsFlag; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
59 |
import com.sun.tools.javac.code.Directive.OpensDirective; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
60 |
import com.sun.tools.javac.code.Directive.OpensFlag; |
36526 | 61 |
import com.sun.tools.javac.code.Directive.RequiresDirective; |
62 |
import com.sun.tools.javac.code.Directive.RequiresFlag; |
|
63 |
import com.sun.tools.javac.code.Directive.UsesDirective; |
|
64 |
import com.sun.tools.javac.code.Flags; |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
65 |
import com.sun.tools.javac.code.Lint.LintCategory; |
36526 | 66 |
import com.sun.tools.javac.code.ModuleFinder; |
67 |
import com.sun.tools.javac.code.Source; |
|
68 |
import com.sun.tools.javac.code.Symbol; |
|
69 |
import com.sun.tools.javac.code.Symbol.ClassSymbol; |
|
70 |
import com.sun.tools.javac.code.Symbol.Completer; |
|
71 |
import com.sun.tools.javac.code.Symbol.CompletionFailure; |
|
72 |
import com.sun.tools.javac.code.Symbol.MethodSymbol; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
73 |
import com.sun.tools.javac.code.Symbol.ModuleFlags; |
36526 | 74 |
import com.sun.tools.javac.code.Symbol.ModuleSymbol; |
75 |
import com.sun.tools.javac.code.Symbol.PackageSymbol; |
|
76 |
import com.sun.tools.javac.code.Symtab; |
|
77 |
import com.sun.tools.javac.code.Type; |
|
38827
884d32899770
8152062: obscure error message for bad 'provides'
vromero
parents:
38619
diff
changeset
|
78 |
import com.sun.tools.javac.code.Types; |
36526 | 79 |
import com.sun.tools.javac.jvm.ClassWriter; |
80 |
import com.sun.tools.javac.jvm.JNIWriter; |
|
81 |
import com.sun.tools.javac.main.Option; |
|
82 |
import com.sun.tools.javac.resources.CompilerProperties.Errors; |
|
83 |
import com.sun.tools.javac.resources.CompilerProperties.Warnings; |
|
84 |
import com.sun.tools.javac.tree.JCTree; |
|
85 |
import com.sun.tools.javac.tree.JCTree.JCCompilationUnit; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
86 |
import com.sun.tools.javac.tree.JCTree.JCDirective; |
36526 | 87 |
import com.sun.tools.javac.tree.JCTree.JCExports; |
88 |
import com.sun.tools.javac.tree.JCTree.JCExpression; |
|
89 |
import com.sun.tools.javac.tree.JCTree.JCModuleDecl; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
90 |
import com.sun.tools.javac.tree.JCTree.JCOpens; |
36526 | 91 |
import com.sun.tools.javac.tree.JCTree.JCPackageDecl; |
92 |
import com.sun.tools.javac.tree.JCTree.JCProvides; |
|
93 |
import com.sun.tools.javac.tree.JCTree.JCRequires; |
|
94 |
import com.sun.tools.javac.tree.JCTree.JCUses; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
95 |
import com.sun.tools.javac.tree.JCTree.Tag; |
36526 | 96 |
import com.sun.tools.javac.tree.TreeInfo; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
97 |
import com.sun.tools.javac.util.Abort; |
36526 | 98 |
import com.sun.tools.javac.util.Assert; |
99 |
import com.sun.tools.javac.util.Context; |
|
100 |
import com.sun.tools.javac.util.JCDiagnostic; |
|
101 |
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition; |
|
102 |
import com.sun.tools.javac.util.List; |
|
103 |
import com.sun.tools.javac.util.ListBuffer; |
|
104 |
import com.sun.tools.javac.util.Log; |
|
105 |
import com.sun.tools.javac.util.Name; |
|
106 |
import com.sun.tools.javac.util.Names; |
|
107 |
import com.sun.tools.javac.util.Options; |
|
39361
cd0aca7db174
8159439: javac throws NPE with Module attribute and super_class != 0
vromero
parents:
38827
diff
changeset
|
108 |
import com.sun.tools.javac.util.Position; |
36526 | 109 |
|
110 |
import static com.sun.tools.javac.code.Flags.ABSTRACT; |
|
37854
a76a06106d02
8153268: javac accepts enums being referenced by 'uses' statement
vromero
parents:
37848
diff
changeset
|
111 |
import static com.sun.tools.javac.code.Flags.ENUM; |
36526 | 112 |
import static com.sun.tools.javac.code.Flags.PUBLIC; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
113 |
import static com.sun.tools.javac.code.Flags.UNATTRIBUTED; |
42841
1768507dae6b
8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
jjg
parents:
42827
diff
changeset
|
114 |
import static com.sun.tools.javac.code.Kinds.Kind.ERR; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
115 |
import static com.sun.tools.javac.code.Kinds.Kind.MDL; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
116 |
import static com.sun.tools.javac.code.Kinds.Kind.MTH; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
117 |
import static com.sun.tools.javac.code.TypeTag.CLASS; |
36526 | 118 |
|
119 |
/** |
|
120 |
* TODO: fill in |
|
121 |
* |
|
122 |
* <p><b>This is NOT part of any supported API. |
|
123 |
* If you write code that depends on this, you do so at your own risk. |
|
124 |
* This code and its internal interfaces are subject to change or |
|
125 |
* deletion without notice.</b> |
|
126 |
*/ |
|
127 |
public class Modules extends JCTree.Visitor { |
|
128 |
private static final String ALL_SYSTEM = "ALL-SYSTEM"; |
|
129 |
private static final String ALL_MODULE_PATH = "ALL-MODULE-PATH"; |
|
130 |
||
131 |
private final Log log; |
|
132 |
private final Names names; |
|
133 |
private final Symtab syms; |
|
134 |
private final Attr attr; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
135 |
private final Check chk; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
136 |
private final DeferredLintHandler deferredLintHandler; |
36526 | 137 |
private final TypeEnvs typeEnvs; |
38827
884d32899770
8152062: obscure error message for bad 'provides'
vromero
parents:
38619
diff
changeset
|
138 |
private final Types types; |
36526 | 139 |
private final JavaFileManager fileManager; |
140 |
private final ModuleFinder moduleFinder; |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
141 |
private final Source source; |
36526 | 142 |
private final boolean allowModules; |
143 |
||
144 |
public final boolean multiModuleMode; |
|
145 |
||
146 |
private final String moduleOverride; |
|
147 |
||
37848
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
148 |
private final Name java_se; |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
149 |
private final Name java_; |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
150 |
|
36526 | 151 |
ModuleSymbol defaultModule; |
152 |
||
153 |
private final String addExportsOpt; |
|
154 |
private Map<ModuleSymbol, Set<ExportsDirective>> addExports; |
|
155 |
private final String addReadsOpt; |
|
156 |
private Map<ModuleSymbol, Set<RequiresDirective>> addReads; |
|
157 |
private final String addModsOpt; |
|
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
158 |
private final Set<String> extraAddMods = new HashSet<>(); |
36526 | 159 |
private final String limitModsOpt; |
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
160 |
private final Set<String> extraLimitMods = new HashSet<>(); |
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
161 |
private final String moduleVersionOpt; |
36526 | 162 |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
163 |
private final boolean lintOptions; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
164 |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
165 |
private Set<ModuleSymbol> rootModules = null; |
36526 | 166 |
|
167 |
public static Modules instance(Context context) { |
|
168 |
Modules instance = context.get(Modules.class); |
|
169 |
if (instance == null) |
|
170 |
instance = new Modules(context); |
|
171 |
return instance; |
|
172 |
} |
|
173 |
||
174 |
protected Modules(Context context) { |
|
175 |
context.put(Modules.class, this); |
|
176 |
log = Log.instance(context); |
|
177 |
names = Names.instance(context); |
|
178 |
syms = Symtab.instance(context); |
|
179 |
attr = Attr.instance(context); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
180 |
chk = Check.instance(context); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
181 |
deferredLintHandler = DeferredLintHandler.instance(context); |
36526 | 182 |
typeEnvs = TypeEnvs.instance(context); |
183 |
moduleFinder = ModuleFinder.instance(context); |
|
38827
884d32899770
8152062: obscure error message for bad 'provides'
vromero
parents:
38619
diff
changeset
|
184 |
types = Types.instance(context); |
36526 | 185 |
fileManager = context.get(JavaFileManager.class); |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
186 |
source = Source.instance(context); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
187 |
allowModules = source.allowModules(); |
36526 | 188 |
Options options = Options.instance(context); |
189 |
||
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
190 |
lintOptions = options.isUnset(Option.XLINT_CUSTOM, "-" + LintCategory.OPTIONS.option); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
191 |
|
36526 | 192 |
moduleOverride = options.get(Option.XMODULE); |
193 |
||
194 |
multiModuleMode = fileManager.hasLocation(StandardLocation.MODULE_SOURCE_PATH); |
|
195 |
ClassWriter classWriter = ClassWriter.instance(context); |
|
196 |
classWriter.multiModuleMode = multiModuleMode; |
|
197 |
JNIWriter jniWriter = JNIWriter.instance(context); |
|
198 |
jniWriter.multiModuleMode = multiModuleMode; |
|
199 |
||
37848
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
200 |
java_se = names.fromString("java.se"); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
201 |
java_ = names.fromString("java."); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
202 |
|
40308
274367a99f98
8136930: Simplify use of module-system options by custom launchers
jjg
parents:
39917
diff
changeset
|
203 |
addExportsOpt = options.get(Option.ADD_EXPORTS); |
274367a99f98
8136930: Simplify use of module-system options by custom launchers
jjg
parents:
39917
diff
changeset
|
204 |
addReadsOpt = options.get(Option.ADD_READS); |
274367a99f98
8136930: Simplify use of module-system options by custom launchers
jjg
parents:
39917
diff
changeset
|
205 |
addModsOpt = options.get(Option.ADD_MODULES); |
274367a99f98
8136930: Simplify use of module-system options by custom launchers
jjg
parents:
39917
diff
changeset
|
206 |
limitModsOpt = options.get(Option.LIMIT_MODULES); |
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
207 |
moduleVersionOpt = options.get(Option.MODULE_VERSION); |
36526 | 208 |
} |
209 |
||
210 |
int depth = -1; |
|
211 |
private void dprintln(String msg) { |
|
212 |
for (int i = 0; i < depth; i++) |
|
213 |
System.err.print(" "); |
|
214 |
System.err.println(msg); |
|
215 |
} |
|
216 |
||
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
217 |
public void addExtraAddModules(String... extras) { |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
218 |
extraAddMods.addAll(Arrays.asList(extras)); |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
219 |
} |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
220 |
|
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
221 |
public void addExtraLimitModules(String... extras) { |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
222 |
extraLimitMods.addAll(Arrays.asList(extras)); |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
223 |
} |
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
224 |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
225 |
boolean inInitModules; |
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
226 |
public void initModules(List<JCCompilationUnit> trees) { |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
227 |
Assert.check(!inInitModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
228 |
try { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
229 |
inInitModules = true; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
230 |
Assert.checkNull(rootModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
231 |
enter(trees, modules -> { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
232 |
Assert.checkNull(rootModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
233 |
Assert.checkNull(allModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
234 |
this.rootModules = modules; |
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
235 |
setupAllModules(); //initialize the module graph |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
236 |
Assert.checkNonNull(allModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
237 |
inInitModules = false; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
238 |
}, null); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
239 |
} finally { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
240 |
inInitModules = false; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
241 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
242 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
243 |
|
36526 | 244 |
public boolean enter(List<JCCompilationUnit> trees, ClassSymbol c) { |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
245 |
Assert.check(rootModules != null || inInitModules || !allowModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
246 |
return enter(trees, modules -> {}, c); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
247 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
248 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
249 |
private boolean enter(List<JCCompilationUnit> trees, Consumer<Set<ModuleSymbol>> init, ClassSymbol c) { |
38619 | 250 |
if (!allowModules) { |
36526 | 251 |
for (JCCompilationUnit tree: trees) { |
252 |
tree.modle = syms.noModule; |
|
253 |
} |
|
254 |
defaultModule = syms.noModule; |
|
255 |
return true; |
|
256 |
} |
|
257 |
||
258 |
int startErrors = log.nerrors; |
|
259 |
||
260 |
depth++; |
|
261 |
try { |
|
262 |
// scan trees for module defs |
|
263 |
Set<ModuleSymbol> roots = enterModules(trees, c); |
|
264 |
||
42824 | 265 |
setCompilationUnitModules(trees, roots, c); |
36526 | 266 |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
267 |
init.accept(roots); |
36526 | 268 |
|
269 |
for (ModuleSymbol msym: roots) { |
|
270 |
msym.complete(); |
|
271 |
} |
|
39361
cd0aca7db174
8159439: javac throws NPE with Module attribute and super_class != 0
vromero
parents:
38827
diff
changeset
|
272 |
} catch (CompletionFailure ex) { |
cd0aca7db174
8159439: javac throws NPE with Module attribute and super_class != 0
vromero
parents:
38827
diff
changeset
|
273 |
log.error(JCDiagnostic.DiagnosticFlag.NON_DEFERRABLE, Position.NOPOS, "cant.access", ex.sym, ex.getDetailValue()); |
cd0aca7db174
8159439: javac throws NPE with Module attribute and super_class != 0
vromero
parents:
38827
diff
changeset
|
274 |
if (ex instanceof ClassFinder.BadClassFile) throw new Abort(); |
36526 | 275 |
} finally { |
276 |
depth--; |
|
277 |
} |
|
278 |
||
279 |
return (log.nerrors == startErrors); |
|
280 |
} |
|
281 |
||
282 |
public Completer getCompleter() { |
|
283 |
return mainCompleter; |
|
284 |
} |
|
285 |
||
286 |
public ModuleSymbol getDefaultModule() { |
|
287 |
return defaultModule; |
|
288 |
} |
|
289 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
290 |
public boolean modulesInitialized() { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
291 |
return allModules != null; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
292 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
293 |
|
36526 | 294 |
private Set<ModuleSymbol> enterModules(List<JCCompilationUnit> trees, ClassSymbol c) { |
295 |
Set<ModuleSymbol> modules = new LinkedHashSet<>(); |
|
296 |
for (JCCompilationUnit tree : trees) { |
|
297 |
JavaFileObject prev = log.useSource(tree.sourcefile); |
|
298 |
try { |
|
299 |
enterModule(tree, c, modules); |
|
300 |
} finally { |
|
301 |
log.useSource(prev); |
|
302 |
} |
|
303 |
} |
|
304 |
return modules; |
|
305 |
} |
|
306 |
||
307 |
||
308 |
private void enterModule(JCCompilationUnit toplevel, ClassSymbol c, Set<ModuleSymbol> modules) { |
|
309 |
boolean isModuleInfo = toplevel.sourcefile.isNameCompatible("module-info", Kind.SOURCE); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
310 |
boolean isModuleDecl = toplevel.getModuleDecl() != null; |
41999
dbf796210eff
8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
sadayapalam
parents:
41942
diff
changeset
|
311 |
if (isModuleDecl) { |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
312 |
JCModuleDecl decl = toplevel.getModuleDecl(); |
41999
dbf796210eff
8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
sadayapalam
parents:
41942
diff
changeset
|
313 |
if (!isModuleInfo) { |
dbf796210eff
8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
sadayapalam
parents:
41942
diff
changeset
|
314 |
log.error(decl.pos(), Errors.ModuleDeclSbInModuleInfoJava); |
dbf796210eff
8168312: javac throws NPE if annotation processor is specified and module is declared in a file named arbitrarily
sadayapalam
parents:
41942
diff
changeset
|
315 |
} |
36526 | 316 |
Name name = TreeInfo.fullName(decl.qualId); |
317 |
ModuleSymbol sym; |
|
318 |
if (c != null) { |
|
41254
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
319 |
sym = (ModuleSymbol) c.owner; |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
320 |
Assert.checkNonNull(sym.name); |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
321 |
Name treeName = TreeInfo.fullName(decl.qualId); |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
322 |
if (sym.name != treeName) { |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
323 |
log.error(decl.pos(), Errors.ModuleNameMismatch(name, sym.name)); |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
324 |
} |
36526 | 325 |
} else { |
326 |
sym = syms.enterModule(name); |
|
327 |
if (sym.module_info.sourcefile != null && sym.module_info.sourcefile != toplevel.sourcefile) { |
|
328 |
log.error(decl.pos(), Errors.DuplicateModule(sym)); |
|
329 |
return; |
|
330 |
} |
|
331 |
} |
|
332 |
sym.completer = getSourceCompleter(toplevel); |
|
333 |
sym.module_info.sourcefile = toplevel.sourcefile; |
|
334 |
decl.sym = sym; |
|
335 |
||
336 |
if (multiModuleMode || modules.isEmpty()) { |
|
337 |
modules.add(sym); |
|
338 |
} else { |
|
339 |
log.error(toplevel.pos(), Errors.TooManyModules); |
|
340 |
} |
|
341 |
||
342 |
Env<AttrContext> provisionalEnv = new Env<>(decl, null); |
|
343 |
||
344 |
provisionalEnv.toplevel = toplevel; |
|
345 |
typeEnvs.put(sym, provisionalEnv); |
|
346 |
} else if (isModuleInfo) { |
|
347 |
if (multiModuleMode) { |
|
348 |
JCTree tree = toplevel.defs.isEmpty() ? toplevel : toplevel.defs.head; |
|
349 |
log.error(tree.pos(), Errors.ExpectedModule); |
|
350 |
} |
|
351 |
} |
|
352 |
} |
|
353 |
||
42824 | 354 |
private void setCompilationUnitModules(List<JCCompilationUnit> trees, Set<ModuleSymbol> rootModules, ClassSymbol c) { |
36526 | 355 |
// update the module for each compilation unit |
356 |
if (multiModuleMode) { |
|
357 |
checkNoAllModulePath(); |
|
358 |
for (JCCompilationUnit tree: trees) { |
|
359 |
if (tree.defs.isEmpty()) { |
|
360 |
tree.modle = syms.unnamedModule; |
|
361 |
continue; |
|
362 |
} |
|
363 |
||
364 |
JavaFileObject prev = log.useSource(tree.sourcefile); |
|
365 |
try { |
|
366 |
Location locn = getModuleLocation(tree); |
|
367 |
if (locn != null) { |
|
368 |
Name name = names.fromString(fileManager.inferModuleName(locn)); |
|
369 |
ModuleSymbol msym; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
370 |
JCModuleDecl decl = tree.getModuleDecl(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
371 |
if (decl != null) { |
36526 | 372 |
msym = decl.sym; |
373 |
if (msym.name != name) { |
|
374 |
log.error(decl.qualId, Errors.ModuleNameMismatch(msym.name, name)); |
|
375 |
} |
|
376 |
} else { |
|
377 |
msym = syms.enterModule(name); |
|
378 |
} |
|
379 |
if (msym.sourceLocation == null) { |
|
380 |
msym.sourceLocation = locn; |
|
381 |
if (fileManager.hasLocation(StandardLocation.CLASS_OUTPUT)) { |
|
42261
bb52b5514ad5
8163190: Clarify JavaFileManager use of \"module location\"
jjg
parents:
41999
diff
changeset
|
382 |
msym.classLocation = fileManager.getLocationForModule( |
36526 | 383 |
StandardLocation.CLASS_OUTPUT, msym.name.toString()); |
384 |
} |
|
385 |
} |
|
386 |
tree.modle = msym; |
|
387 |
rootModules.add(msym); |
|
42824 | 388 |
} else if (c != null && c.packge().modle == syms.unnamedModule) { |
389 |
tree.modle = syms.unnamedModule; |
|
36526 | 390 |
} else { |
391 |
log.error(tree.pos(), Errors.UnnamedPkgNotAllowedNamedModules); |
|
392 |
tree.modle = syms.errModule; |
|
393 |
} |
|
394 |
} catch (IOException e) { |
|
395 |
throw new Error(e); // FIXME |
|
396 |
} finally { |
|
397 |
log.useSource(prev); |
|
398 |
} |
|
399 |
} |
|
400 |
if (syms.unnamedModule.sourceLocation == null) { |
|
401 |
syms.unnamedModule.completer = getUnnamedModuleCompleter(); |
|
402 |
syms.unnamedModule.sourceLocation = StandardLocation.SOURCE_PATH; |
|
403 |
syms.unnamedModule.classLocation = StandardLocation.CLASS_PATH; |
|
404 |
} |
|
405 |
defaultModule = syms.unnamedModule; |
|
406 |
} else { |
|
407 |
if (defaultModule == null) { |
|
408 |
switch (rootModules.size()) { |
|
409 |
case 0: |
|
410 |
defaultModule = moduleFinder.findSingleModule(); |
|
411 |
if (defaultModule == syms.unnamedModule) { |
|
412 |
if (moduleOverride != null) { |
|
413 |
checkNoAllModulePath(); |
|
414 |
defaultModule = moduleFinder.findModule(names.fromString(moduleOverride)); |
|
40768
8b6a878d8773
8165008: javac -Xmodule compiles the module in a way that reads the unnamed module
jlahoda
parents:
40762
diff
changeset
|
415 |
defaultModule.sourceLocation = StandardLocation.SOURCE_PATH; |
36526 | 416 |
} else { |
417 |
// Question: why not do findAllModules and initVisiblePackages here? |
|
418 |
// i.e. body of unnamedModuleCompleter |
|
419 |
defaultModule.completer = getUnnamedModuleCompleter(); |
|
420 |
defaultModule.classLocation = StandardLocation.CLASS_PATH; |
|
421 |
} |
|
422 |
} else { |
|
423 |
checkSpecifiedModule(trees, Errors.ModuleInfoWithXmoduleClasspath); |
|
424 |
checkNoAllModulePath(); |
|
425 |
defaultModule.complete(); |
|
426 |
// Question: why not do completeModule here? |
|
42827
36468b5fa7f4
8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents:
42824
diff
changeset
|
427 |
defaultModule.completer = sym -> completeModule((ModuleSymbol) sym); |
36526 | 428 |
} |
429 |
rootModules.add(defaultModule); |
|
430 |
break; |
|
431 |
case 1: |
|
432 |
checkSpecifiedModule(trees, Errors.ModuleInfoWithXmoduleSourcepath); |
|
433 |
checkNoAllModulePath(); |
|
434 |
defaultModule = rootModules.iterator().next(); |
|
435 |
defaultModule.classLocation = StandardLocation.CLASS_OUTPUT; |
|
436 |
break; |
|
437 |
default: |
|
438 |
Assert.error("too many modules"); |
|
439 |
} |
|
440 |
defaultModule.sourceLocation = StandardLocation.SOURCE_PATH; |
|
441 |
} else if (rootModules.size() == 1 && defaultModule == rootModules.iterator().next()) { |
|
442 |
defaultModule.complete(); |
|
443 |
defaultModule.completer = sym -> completeModule((ModuleSymbol) sym); |
|
444 |
} else { |
|
445 |
Assert.check(rootModules.isEmpty()); |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
446 |
rootModules.add(defaultModule); |
36526 | 447 |
} |
448 |
||
449 |
if (defaultModule != syms.unnamedModule) { |
|
450 |
syms.unnamedModule.completer = getUnnamedModuleCompleter(); |
|
451 |
syms.unnamedModule.classLocation = StandardLocation.CLASS_PATH; |
|
452 |
} |
|
453 |
||
454 |
for (JCCompilationUnit tree: trees) { |
|
455 |
tree.modle = defaultModule; |
|
456 |
} |
|
457 |
} |
|
458 |
} |
|
459 |
||
460 |
private Location getModuleLocation(JCCompilationUnit tree) throws IOException { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
461 |
if (tree.getModuleDecl() != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
462 |
return getModuleLocation(tree.sourcefile, null); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
463 |
} else if (tree.getPackage() != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
464 |
JCPackageDecl pkg = tree.getPackage(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
465 |
return getModuleLocation(tree.sourcefile, TreeInfo.fullName(pkg.pid)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
466 |
} else { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
467 |
// code in unnamed module |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
468 |
return null; |
36526 | 469 |
} |
470 |
} |
|
471 |
||
472 |
private Location getModuleLocation(JavaFileObject fo, Name pkgName) throws IOException { |
|
473 |
// For now, just check module source path. |
|
474 |
// We may want to check source path as well. |
|
42815
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
475 |
Location loc = |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
476 |
fileManager.getLocationForModule(StandardLocation.MODULE_SOURCE_PATH, |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
477 |
fo, (pkgName == null) ? null : pkgName.toString()); |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
478 |
if (loc == null) { |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
479 |
Location sourceOutput = fileManager.hasLocation(StandardLocation.SOURCE_OUTPUT) ? |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
480 |
StandardLocation.SOURCE_OUTPUT : StandardLocation.CLASS_OUTPUT; |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
481 |
loc = |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
482 |
fileManager.getLocationForModule(sourceOutput, |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
483 |
fo, (pkgName == null) ? null : pkgName.toString()); |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
484 |
} |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
485 |
|
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
486 |
return loc; |
36526 | 487 |
} |
488 |
||
489 |
private void checkSpecifiedModule(List<JCCompilationUnit> trees, JCDiagnostic.Error error) { |
|
490 |
if (moduleOverride != null) { |
|
491 |
JavaFileObject prev = log.useSource(trees.head.sourcefile); |
|
492 |
try { |
|
493 |
log.error(trees.head.pos(), error); |
|
494 |
} finally { |
|
495 |
log.useSource(prev); |
|
496 |
} |
|
497 |
} |
|
498 |
} |
|
499 |
||
500 |
private void checkNoAllModulePath() { |
|
501 |
if (addModsOpt != null && Arrays.asList(addModsOpt.split(",")).contains(ALL_MODULE_PATH)) { |
|
502 |
log.error(Errors.AddmodsAllModulePathInvalid); |
|
503 |
} |
|
504 |
} |
|
505 |
||
506 |
private final Completer mainCompleter = new Completer() { |
|
507 |
@Override |
|
508 |
public void complete(Symbol sym) throws CompletionFailure { |
|
509 |
ModuleSymbol msym = moduleFinder.findModule((ModuleSymbol) sym); |
|
510 |
||
42841
1768507dae6b
8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
jjg
parents:
42827
diff
changeset
|
511 |
if (msym.kind == ERR) { |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
512 |
log.error(Errors.ModuleNotFound(msym)); |
36526 | 513 |
//make sure the module is initialized: |
514 |
msym.directives = List.nil(); |
|
515 |
msym.exports = List.nil(); |
|
516 |
msym.provides = List.nil(); |
|
517 |
msym.requires = List.nil(); |
|
518 |
msym.uses = List.nil(); |
|
519 |
} else if ((msym.flags_field & Flags.AUTOMATIC_MODULE) != 0) { |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
520 |
setupAutomaticModule(msym); |
36526 | 521 |
} else { |
522 |
msym.module_info.complete(); |
|
523 |
} |
|
524 |
||
525 |
// If module-info comes from a .java file, the underlying |
|
526 |
// call of classFinder.fillIn will have called through the |
|
527 |
// source completer, to Enter, and then to Modules.enter, |
|
528 |
// which will call completeModule. |
|
529 |
// But, if module-info comes from a .class file, the underlying |
|
530 |
// call of classFinder.fillIn will just call ClassReader to read |
|
531 |
// the .class file, and so we call completeModule here. |
|
532 |
if (msym.module_info.classfile == null || msym.module_info.classfile.getKind() == Kind.CLASS) { |
|
533 |
completeModule(msym); |
|
534 |
} |
|
535 |
} |
|
536 |
||
537 |
@Override |
|
538 |
public String toString() { |
|
539 |
return "mainCompleter"; |
|
540 |
} |
|
541 |
}; |
|
542 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
543 |
private void setupAutomaticModule(ModuleSymbol msym) throws CompletionFailure { |
36526 | 544 |
try { |
545 |
ListBuffer<Directive> directives = new ListBuffer<>(); |
|
546 |
ListBuffer<ExportsDirective> exports = new ListBuffer<>(); |
|
547 |
Set<String> seenPackages = new HashSet<>(); |
|
548 |
||
549 |
for (JavaFileObject clazz : fileManager.list(msym.classLocation, "", EnumSet.of(Kind.CLASS), true)) { |
|
550 |
String binName = fileManager.inferBinaryName(msym.classLocation, clazz); |
|
551 |
String pack = binName.lastIndexOf('.') != (-1) ? binName.substring(0, binName.lastIndexOf('.')) : ""; //unnamed package???? |
|
552 |
if (seenPackages.add(pack)) { |
|
553 |
ExportsDirective d = new ExportsDirective(syms.enterPackage(msym, names.fromString(pack)), null); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
554 |
//TODO: opens? |
36526 | 555 |
directives.add(d); |
556 |
exports.add(d); |
|
557 |
} |
|
558 |
} |
|
559 |
||
560 |
msym.exports = exports.toList(); |
|
561 |
msym.provides = List.nil(); |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
562 |
msym.requires = List.nil(); |
36526 | 563 |
msym.uses = List.nil(); |
564 |
msym.directives = directives.toList(); |
|
565 |
msym.flags_field |= Flags.ACYCLIC; |
|
566 |
} catch (IOException ex) { |
|
567 |
throw new IllegalStateException(ex); |
|
568 |
} |
|
569 |
} |
|
570 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
571 |
private void completeAutomaticModule(ModuleSymbol msym) throws CompletionFailure { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
572 |
ListBuffer<Directive> directives = new ListBuffer<>(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
573 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
574 |
directives.addAll(msym.directives); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
575 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
576 |
ListBuffer<RequiresDirective> requires = new ListBuffer<>(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
577 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
578 |
for (ModuleSymbol ms : allModules()) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
579 |
if (ms == syms.unnamedModule || ms == msym) |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
580 |
continue; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
581 |
Set<RequiresFlag> flags = (ms.flags_field & Flags.AUTOMATIC_MODULE) != 0 ? |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
582 |
EnumSet.of(RequiresFlag.TRANSITIVE) : EnumSet.noneOf(RequiresFlag.class); |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
583 |
RequiresDirective d = new RequiresDirective(ms, flags); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
584 |
directives.add(d); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
585 |
requires.add(d); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
586 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
587 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
588 |
RequiresDirective requiresUnnamed = new RequiresDirective(syms.unnamedModule); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
589 |
directives.add(requiresUnnamed); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
590 |
requires.add(requiresUnnamed); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
591 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
592 |
msym.requires = requires.toList(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
593 |
msym.directives = directives.toList(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
594 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
595 |
|
36526 | 596 |
private Completer getSourceCompleter(JCCompilationUnit tree) { |
597 |
return new Completer() { |
|
598 |
@Override |
|
599 |
public void complete(Symbol sym) throws CompletionFailure { |
|
600 |
ModuleSymbol msym = (ModuleSymbol) sym; |
|
601 |
msym.flags_field |= UNATTRIBUTED; |
|
602 |
ModuleVisitor v = new ModuleVisitor(); |
|
603 |
JavaFileObject prev = log.useSource(tree.sourcefile); |
|
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
604 |
JCModuleDecl moduleDecl = tree.getModuleDecl(); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
605 |
DiagnosticPosition prevLintPos = deferredLintHandler.setPos(moduleDecl.pos()); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
606 |
|
36526 | 607 |
try { |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
608 |
moduleDecl.accept(v); |
36526 | 609 |
completeModule(msym); |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
610 |
checkCyclicDependencies(moduleDecl); |
36526 | 611 |
} finally { |
612 |
log.useSource(prev); |
|
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
613 |
deferredLintHandler.setPos(prevLintPos); |
36526 | 614 |
msym.flags_field &= ~UNATTRIBUTED; |
615 |
} |
|
616 |
} |
|
617 |
||
618 |
@Override |
|
619 |
public String toString() { |
|
620 |
return "SourceCompleter: " + tree.sourcefile.getName(); |
|
621 |
} |
|
622 |
||
623 |
}; |
|
624 |
} |
|
625 |
||
42815
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
626 |
public boolean isRootModule(ModuleSymbol module) { |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
627 |
Assert.checkNonNull(rootModules); |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
628 |
return rootModules.contains(module); |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
629 |
} |
050370edaade
8072988: Update javax.annotation.processing for modules
jlahoda
parents:
42408
diff
changeset
|
630 |
|
36526 | 631 |
class ModuleVisitor extends JCTree.Visitor { |
632 |
private ModuleSymbol sym; |
|
633 |
private final Set<ModuleSymbol> allRequires = new HashSet<>(); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
634 |
private final Map<PackageSymbol,List<ExportsDirective>> allExports = new HashMap<>(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
635 |
private final Map<PackageSymbol,List<OpensDirective>> allOpens = new HashMap<>(); |
36526 | 636 |
|
637 |
@Override |
|
638 |
public void visitModuleDef(JCModuleDecl tree) { |
|
639 |
sym = Assert.checkNonNull(tree.sym); |
|
640 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
641 |
if (tree.getModuleType() == ModuleKind.OPEN) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
642 |
sym.flags.add(ModuleFlags.OPEN); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
643 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
644 |
sym.flags_field |= (tree.mods.flags & Flags.DEPRECATED); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
645 |
|
36526 | 646 |
sym.requires = List.nil(); |
647 |
sym.exports = List.nil(); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
648 |
sym.opens = List.nil(); |
36526 | 649 |
tree.directives.forEach(t -> t.accept(this)); |
650 |
sym.requires = sym.requires.reverse(); |
|
651 |
sym.exports = sym.exports.reverse(); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
652 |
sym.opens = sym.opens.reverse(); |
36526 | 653 |
ensureJavaBase(); |
654 |
} |
|
655 |
||
656 |
@Override |
|
657 |
public void visitRequires(JCRequires tree) { |
|
658 |
ModuleSymbol msym = lookupModule(tree.moduleName); |
|
659 |
if (msym.kind != MDL) { |
|
660 |
log.error(tree.moduleName.pos(), Errors.ModuleNotFound(msym)); |
|
661 |
} else if (allRequires.contains(msym)) { |
|
662 |
log.error(tree.moduleName.pos(), Errors.DuplicateRequires(msym)); |
|
663 |
} else { |
|
664 |
allRequires.add(msym); |
|
665 |
Set<RequiresFlag> flags = EnumSet.noneOf(RequiresFlag.class); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
666 |
if (tree.isTransitive) |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
667 |
flags.add(RequiresFlag.TRANSITIVE); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
668 |
if (tree.isStaticPhase) |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
669 |
flags.add(RequiresFlag.STATIC_PHASE); |
36526 | 670 |
RequiresDirective d = new RequiresDirective(msym, flags); |
671 |
tree.directive = d; |
|
672 |
sym.requires = sym.requires.prepend(d); |
|
673 |
} |
|
674 |
} |
|
675 |
||
676 |
@Override |
|
677 |
public void visitExports(JCExports tree) { |
|
678 |
Name name = TreeInfo.fullName(tree.qualid); |
|
679 |
PackageSymbol packge = syms.enterPackage(sym, name); |
|
680 |
attr.setPackageSymbols(tree.qualid, packge); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
681 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
682 |
if (tree.hasTag(Tag.OPENS) && sym.flags.contains(ModuleFlags.OPEN)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
683 |
log.error(tree.pos(), Errors.NoOpensUnlessStrong); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
684 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
685 |
List<ExportsDirective> exportsForPackage = allExports.computeIfAbsent(packge, p -> List.nil()); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
686 |
for (ExportsDirective d : exportsForPackage) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
687 |
reportExportsConflict(tree, packge); |
36526 | 688 |
} |
689 |
||
690 |
List<ModuleSymbol> toModules = null; |
|
691 |
if (tree.moduleNames != null) { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
692 |
Set<ModuleSymbol> to = new LinkedHashSet<>(); |
36526 | 693 |
for (JCExpression n: tree.moduleNames) { |
694 |
ModuleSymbol msym = lookupModule(n); |
|
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
695 |
chk.checkModuleExists(n.pos(), msym); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
696 |
for (ExportsDirective d : exportsForPackage) { |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
697 |
checkDuplicateExportsToModule(n, msym, d); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
698 |
} |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
699 |
if (!to.add(msym)) { |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
700 |
reportExportsConflictToModule(n, msym); |
36526 | 701 |
} |
702 |
} |
|
703 |
toModules = List.from(to); |
|
704 |
} |
|
705 |
||
706 |
if (toModules == null || !toModules.isEmpty()) { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
707 |
Set<ExportsFlag> flags = EnumSet.noneOf(ExportsFlag.class); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
708 |
ExportsDirective d = new ExportsDirective(packge, toModules, flags); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
709 |
sym.exports = sym.exports.prepend(d); |
36526 | 710 |
tree.directive = d; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
711 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
712 |
allExports.put(packge, exportsForPackage.prepend(d)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
713 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
714 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
715 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
716 |
private void reportExportsConflict(JCExports tree, PackageSymbol packge) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
717 |
log.error(tree.qualid.pos(), Errors.ConflictingExports(packge)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
718 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
719 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
720 |
private void checkDuplicateExportsToModule(JCExpression name, ModuleSymbol msym, |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
721 |
ExportsDirective d) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
722 |
if (d.modules != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
723 |
for (ModuleSymbol other : d.modules) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
724 |
if (msym == other) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
725 |
reportExportsConflictToModule(name, msym); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
726 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
727 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
728 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
729 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
730 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
731 |
private void reportExportsConflictToModule(JCExpression name, ModuleSymbol msym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
732 |
log.error(name.pos(), Errors.ConflictingExportsToModule(msym)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
733 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
734 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
735 |
@Override |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
736 |
public void visitOpens(JCOpens tree) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
737 |
Name name = TreeInfo.fullName(tree.qualid); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
738 |
PackageSymbol packge = syms.enterPackage(sym, name); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
739 |
attr.setPackageSymbols(tree.qualid, packge); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
740 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
741 |
if (sym.flags.contains(ModuleFlags.OPEN)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
742 |
log.error(tree.pos(), Errors.NoOpensUnlessStrong); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
743 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
744 |
List<OpensDirective> opensForPackage = allOpens.computeIfAbsent(packge, p -> List.nil()); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
745 |
for (OpensDirective d : opensForPackage) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
746 |
reportOpensConflict(tree, packge); |
36526 | 747 |
} |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
748 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
749 |
List<ModuleSymbol> toModules = null; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
750 |
if (tree.moduleNames != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
751 |
Set<ModuleSymbol> to = new LinkedHashSet<>(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
752 |
for (JCExpression n: tree.moduleNames) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
753 |
ModuleSymbol msym = lookupModule(n); |
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
754 |
chk.checkModuleExists(n.pos(), msym); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
755 |
for (OpensDirective d : opensForPackage) { |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
756 |
checkDuplicateOpensToModule(n, msym, d); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
757 |
} |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
758 |
if (!to.add(msym)) { |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
759 |
reportOpensConflictToModule(n, msym); |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
760 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
761 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
762 |
toModules = List.from(to); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
763 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
764 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
765 |
if (toModules == null || !toModules.isEmpty()) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
766 |
Set<OpensFlag> flags = EnumSet.noneOf(OpensFlag.class); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
767 |
OpensDirective d = new OpensDirective(packge, toModules, flags); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
768 |
sym.opens = sym.opens.prepend(d); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
769 |
tree.directive = d; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
770 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
771 |
allOpens.put(packge, opensForPackage.prepend(d)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
772 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
773 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
774 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
775 |
private void reportOpensConflict(JCOpens tree, PackageSymbol packge) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
776 |
log.error(tree.qualid.pos(), Errors.ConflictingOpens(packge)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
777 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
778 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
779 |
private void checkDuplicateOpensToModule(JCExpression name, ModuleSymbol msym, |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
780 |
OpensDirective d) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
781 |
if (d.modules != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
782 |
for (ModuleSymbol other : d.modules) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
783 |
if (msym == other) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
784 |
reportOpensConflictToModule(name, msym); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
785 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
786 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
787 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
788 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
789 |
|
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
790 |
private void reportOpensConflictToModule(JCExpression name, ModuleSymbol msym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
791 |
log.error(name.pos(), Errors.ConflictingOpensToModule(msym)); |
36526 | 792 |
} |
793 |
||
794 |
@Override |
|
795 |
public void visitProvides(JCProvides tree) { } |
|
796 |
||
797 |
@Override |
|
798 |
public void visitUses(JCUses tree) { } |
|
799 |
||
800 |
private void ensureJavaBase() { |
|
801 |
if (sym.name == names.java_base) |
|
802 |
return; |
|
803 |
||
804 |
for (RequiresDirective d: sym.requires) { |
|
805 |
if (d.module.name == names.java_base) |
|
806 |
return; |
|
807 |
} |
|
808 |
||
809 |
ModuleSymbol java_base = syms.enterModule(names.java_base); |
|
810 |
Directive.RequiresDirective d = |
|
811 |
new Directive.RequiresDirective(java_base, |
|
812 |
EnumSet.of(Directive.RequiresFlag.MANDATED)); |
|
813 |
sym.requires = sym.requires.prepend(d); |
|
814 |
} |
|
815 |
||
816 |
private ModuleSymbol lookupModule(JCExpression moduleName) { |
|
817 |
Name name = TreeInfo.fullName(moduleName); |
|
818 |
ModuleSymbol msym = moduleFinder.findModule(name); |
|
819 |
TreeInfo.setSymbol(moduleName, msym); |
|
820 |
return msym; |
|
821 |
} |
|
822 |
} |
|
823 |
||
824 |
public Completer getUsesProvidesCompleter() { |
|
825 |
return sym -> { |
|
826 |
ModuleSymbol msym = (ModuleSymbol) sym; |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
827 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
828 |
msym.complete(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
829 |
|
36526 | 830 |
Env<AttrContext> env = typeEnvs.get(msym); |
831 |
UsesProvidesVisitor v = new UsesProvidesVisitor(msym, env); |
|
832 |
JavaFileObject prev = log.useSource(env.toplevel.sourcefile); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
833 |
JCModuleDecl decl = env.toplevel.getModuleDecl(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
834 |
DiagnosticPosition prevLintPos = deferredLintHandler.setPos(decl.pos()); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
835 |
|
36526 | 836 |
try { |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
837 |
decl.accept(v); |
36526 | 838 |
} finally { |
839 |
log.useSource(prev); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
840 |
deferredLintHandler.setPos(prevLintPos); |
36526 | 841 |
} |
842 |
}; |
|
843 |
} |
|
844 |
||
845 |
class UsesProvidesVisitor extends JCTree.Visitor { |
|
846 |
private final ModuleSymbol msym; |
|
847 |
private final Env<AttrContext> env; |
|
848 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
849 |
private final Set<ClassSymbol> allUses = new HashSet<>(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
850 |
private final Map<ClassSymbol, Set<ClassSymbol>> allProvides = new HashMap<>(); |
36526 | 851 |
|
852 |
public UsesProvidesVisitor(ModuleSymbol msym, Env<AttrContext> env) { |
|
853 |
this.msym = msym; |
|
854 |
this.env = env; |
|
855 |
} |
|
856 |
||
857 |
@Override @SuppressWarnings("unchecked") |
|
858 |
public void visitModuleDef(JCModuleDecl tree) { |
|
859 |
msym.directives = List.nil(); |
|
860 |
msym.provides = List.nil(); |
|
861 |
msym.uses = List.nil(); |
|
862 |
tree.directives.forEach(t -> t.accept(this)); |
|
863 |
msym.directives = msym.directives.reverse(); |
|
864 |
msym.provides = msym.provides.reverse(); |
|
865 |
msym.uses = msym.uses.reverse(); |
|
866 |
||
867 |
if (msym.requires.nonEmpty() && msym.requires.head.flags.contains(RequiresFlag.MANDATED)) |
|
868 |
msym.directives = msym.directives.prepend(msym.requires.head); |
|
869 |
||
870 |
msym.directives = msym.directives.appendList(List.from(addReads.getOrDefault(msym, Collections.emptySet()))); |
|
871 |
||
872 |
checkForCorrectness(); |
|
873 |
} |
|
874 |
||
875 |
@Override |
|
876 |
public void visitExports(JCExports tree) { |
|
877 |
if (tree.directive.packge.members().isEmpty()) { |
|
878 |
log.error(tree.qualid.pos(), Errors.PackageEmptyOrNotFound(tree.directive.packge)); |
|
879 |
} |
|
880 |
msym.directives = msym.directives.prepend(tree.directive); |
|
881 |
} |
|
882 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
883 |
@Override |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
884 |
public void visitOpens(JCOpens tree) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
885 |
if (tree.directive.packge.members().isEmpty() && |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
886 |
((tree.directive.packge.flags() & Flags.HAS_RESOURCE) == 0)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
887 |
log.error(tree.qualid.pos(), Errors.PackageEmptyOrNotFound(tree.directive.packge)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
888 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
889 |
msym.directives = msym.directives.prepend(tree.directive); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
890 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
891 |
|
36526 | 892 |
MethodSymbol noArgsConstructor(ClassSymbol tsym) { |
893 |
for (Symbol sym : tsym.members().getSymbolsByName(names.init)) { |
|
894 |
MethodSymbol mSym = (MethodSymbol)sym; |
|
895 |
if (mSym.params().isEmpty()) { |
|
896 |
return mSym; |
|
897 |
} |
|
898 |
} |
|
899 |
return null; |
|
900 |
} |
|
901 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
902 |
MethodSymbol factoryMethod(ClassSymbol tsym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
903 |
for (Symbol sym : tsym.members().getSymbolsByName(names.provider, sym -> sym.kind == MTH)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
904 |
MethodSymbol mSym = (MethodSymbol)sym; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
905 |
if (mSym.isStatic() && (mSym.flags() & Flags.PUBLIC) != 0 && mSym.params().isEmpty()) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
906 |
return mSym; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
907 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
908 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
909 |
return null; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
910 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
911 |
|
36526 | 912 |
Map<Directive.ProvidesDirective, JCProvides> directiveToTreeMap = new HashMap<>(); |
913 |
||
914 |
@Override |
|
915 |
public void visitProvides(JCProvides tree) { |
|
916 |
Type st = attr.attribType(tree.serviceName, env, syms.objectType); |
|
917 |
ClassSymbol service = (ClassSymbol) st.tsym; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
918 |
ListBuffer<ClassSymbol> impls = new ListBuffer<>(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
919 |
for (JCExpression implName : tree.implNames) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
920 |
Type it = attr.attribType(implName, env, syms.objectType); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
921 |
ClassSymbol impl = (ClassSymbol) it.tsym; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
922 |
//find provider factory: |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
923 |
MethodSymbol factory = factoryMethod(impl); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
924 |
if (factory != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
925 |
Type returnType = factory.type.getReturnType(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
926 |
if (!types.isSubtype(returnType, st)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
927 |
log.error(implName.pos(), Errors.ServiceImplementationProviderReturnMustBeSubtypeOfServiceInterface); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
928 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
929 |
} else { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
930 |
if (!types.isSubtype(it, st)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
931 |
log.error(implName.pos(), Errors.ServiceImplementationMustBeSubtypeOfServiceInterface); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
932 |
} else if ((impl.flags() & ABSTRACT) != 0) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
933 |
log.error(implName.pos(), Errors.ServiceImplementationIsAbstract(impl)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
934 |
} else if (impl.isInner()) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
935 |
log.error(implName.pos(), Errors.ServiceImplementationIsInner(impl)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
936 |
} else { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
937 |
MethodSymbol constr = noArgsConstructor(impl); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
938 |
if (constr == null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
939 |
log.error(implName.pos(), Errors.ServiceImplementationDoesntHaveANoArgsConstructor(impl)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
940 |
} else if ((constr.flags() & PUBLIC) == 0) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
941 |
log.error(implName.pos(), Errors.ServiceImplementationNoArgsConstructorNotPublic(impl)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
942 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
943 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
944 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
945 |
if (it.hasTag(CLASS)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
946 |
// For now, we just check the pair (service-type, impl-type) is unique |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
947 |
// TODO, check only one provides per service type as well |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
948 |
if (allProvides.computeIfAbsent(service, s -> new HashSet<>()).add(impl)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
949 |
impls.append(impl); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
950 |
} else { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
951 |
log.error(implName.pos(), Errors.DuplicateProvides(service, impl)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
952 |
} |
36526 | 953 |
} |
954 |
} |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
955 |
if (st.hasTag(CLASS) && !impls.isEmpty()) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
956 |
Directive.ProvidesDirective d = new Directive.ProvidesDirective(service, impls.toList()); |
36526 | 957 |
msym.provides = msym.provides.prepend(d); |
958 |
msym.directives = msym.directives.prepend(d); |
|
959 |
directiveToTreeMap.put(d, tree); |
|
960 |
} |
|
961 |
} |
|
962 |
||
963 |
@Override |
|
964 |
public void visitRequires(JCRequires tree) { |
|
39915
5d1e0740e709
8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
sadayapalam
parents:
39366
diff
changeset
|
965 |
if (tree.directive != null) { |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
966 |
chk.checkDeprecated(tree.moduleName.pos(), msym, tree.directive.module); |
39915
5d1e0740e709
8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
sadayapalam
parents:
39366
diff
changeset
|
967 |
msym.directives = msym.directives.prepend(tree.directive); |
5d1e0740e709
8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
sadayapalam
parents:
39366
diff
changeset
|
968 |
} |
36526 | 969 |
} |
970 |
||
971 |
@Override |
|
972 |
public void visitUses(JCUses tree) { |
|
973 |
Type st = attr.attribType(tree.qualid, env, syms.objectType); |
|
37854
a76a06106d02
8153268: javac accepts enums being referenced by 'uses' statement
vromero
parents:
37848
diff
changeset
|
974 |
Symbol sym = TreeInfo.symbol(tree.qualid); |
a76a06106d02
8153268: javac accepts enums being referenced by 'uses' statement
vromero
parents:
37848
diff
changeset
|
975 |
if ((sym.flags() & ENUM) != 0) { |
a76a06106d02
8153268: javac accepts enums being referenced by 'uses' statement
vromero
parents:
37848
diff
changeset
|
976 |
log.error(tree.qualid.pos(), Errors.ServiceDefinitionIsEnum(st.tsym)); |
a76a06106d02
8153268: javac accepts enums being referenced by 'uses' statement
vromero
parents:
37848
diff
changeset
|
977 |
} else if (st.hasTag(CLASS)) { |
36526 | 978 |
ClassSymbol service = (ClassSymbol) st.tsym; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
979 |
if (allUses.add(service)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
980 |
Directive.UsesDirective d = new Directive.UsesDirective(service); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
981 |
msym.uses = msym.uses.prepend(d); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
982 |
msym.directives = msym.directives.prepend(d); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
983 |
} else { |
36526 | 984 |
log.error(tree.pos(), Errors.DuplicateUses(service)); |
985 |
} |
|
986 |
} |
|
987 |
} |
|
988 |
||
989 |
private void checkForCorrectness() { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
990 |
for (Directive.ProvidesDirective provides : msym.provides) { |
36526 | 991 |
JCProvides tree = directiveToTreeMap.get(provides); |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
992 |
for (ClassSymbol impl : provides.impls) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
993 |
/* The implementation must be defined in the same module as the provides directive |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
994 |
* (else, error) |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
995 |
*/ |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
996 |
PackageSymbol implementationDefiningPackage = impl.packge(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
997 |
if (implementationDefiningPackage.modle != msym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
998 |
// TODO: should use tree for the implentation name, not the entire provides tree |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
999 |
// TODO: should improve error message to identify the implementation type |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1000 |
log.error(tree.pos(), Errors.ServiceImplementationNotInRightModule(implementationDefiningPackage.modle)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1001 |
} |
36526 | 1002 |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1003 |
/* There is no inherent requirement that module that provides a service should actually |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1004 |
* use it itself. However, it is a pointless declaration if the service package is not |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1005 |
* exported and there is no uses for the service. |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1006 |
*/ |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1007 |
PackageSymbol interfaceDeclaringPackage = provides.service.packge(); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1008 |
boolean isInterfaceDeclaredInCurrentModule = interfaceDeclaringPackage.modle == msym; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1009 |
boolean isInterfaceExportedFromAReadableModule = |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1010 |
msym.visiblePackages.get(interfaceDeclaringPackage.fullname) == interfaceDeclaringPackage; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1011 |
if (isInterfaceDeclaredInCurrentModule && !isInterfaceExportedFromAReadableModule) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1012 |
// ok the interface is declared in this module. Let's check if it's exported |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1013 |
boolean warn = true; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1014 |
for (ExportsDirective export : msym.exports) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1015 |
if (interfaceDeclaringPackage == export.packge) { |
36526 | 1016 |
warn = false; |
1017 |
break; |
|
1018 |
} |
|
1019 |
} |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1020 |
if (warn) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1021 |
for (UsesDirective uses : msym.uses) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1022 |
if (provides.service == uses.service) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1023 |
warn = false; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1024 |
break; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1025 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1026 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1027 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1028 |
if (warn) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1029 |
log.warning(tree.pos(), Warnings.ServiceProvidedButNotExportedOrUsed(provides.service)); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1030 |
} |
36526 | 1031 |
} |
1032 |
} |
|
1033 |
} |
|
1034 |
} |
|
1035 |
} |
|
1036 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1037 |
private Set<ModuleSymbol> allModules; |
36526 | 1038 |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1039 |
public Set<ModuleSymbol> allModules() { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1040 |
Assert.checkNonNull(allModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1041 |
return allModules; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1042 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1043 |
|
40311
bb76098875c8
8133884: javac moduleName/className and moduleName/packageName options
jlahoda
parents:
40308
diff
changeset
|
1044 |
private void setupAllModules() { |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1045 |
Assert.checkNonNull(rootModules); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1046 |
Assert.checkNull(allModules); |
36526 | 1047 |
|
1048 |
Set<ModuleSymbol> observable; |
|
1049 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1050 |
if (limitModsOpt == null && extraLimitMods.isEmpty()) { |
36526 | 1051 |
observable = null; |
1052 |
} else { |
|
1053 |
Set<ModuleSymbol> limitMods = new HashSet<>(); |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1054 |
if (limitModsOpt != null) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1055 |
for (String limit : limitModsOpt.split(",")) { |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1056 |
if (!isValidName(limit)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1057 |
continue; |
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1058 |
limitMods.add(syms.enterModule(names.fromString(limit))); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1059 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1060 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1061 |
for (String limit : extraLimitMods) { |
36526 | 1062 |
limitMods.add(syms.enterModule(names.fromString(limit))); |
1063 |
} |
|
1064 |
observable = computeTransitiveClosure(limitMods, null); |
|
1065 |
observable.addAll(rootModules); |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1066 |
if (lintOptions) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1067 |
for (ModuleSymbol msym : limitMods) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1068 |
if (!observable.contains(msym)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1069 |
log.warning(LintCategory.OPTIONS, |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1070 |
Warnings.ModuleForOptionNotFound(Option.LIMIT_MODULES, msym)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1071 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1072 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1073 |
} |
36526 | 1074 |
} |
1075 |
||
42841
1768507dae6b
8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
jjg
parents:
42827
diff
changeset
|
1076 |
Predicate<ModuleSymbol> observablePred = sym -> |
1768507dae6b
8171412: tools/javac/modules/AddLimitMods.java failed with "error: module not found"
jjg
parents:
42827
diff
changeset
|
1077 |
(observable == null) ? (moduleFinder.findModule(sym).kind != ERR) : observable.contains(sym); |
36526 | 1078 |
Predicate<ModuleSymbol> systemModulePred = sym -> (sym.flags() & Flags.SYSTEM_MODULE) != 0; |
1079 |
Set<ModuleSymbol> enabledRoot = new LinkedHashSet<>(); |
|
1080 |
||
1081 |
if (rootModules.contains(syms.unnamedModule)) { |
|
37848
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1082 |
ModuleSymbol javaSE = syms.getModule(java_se); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1083 |
Predicate<ModuleSymbol> jdkModulePred; |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1084 |
|
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1085 |
if (javaSE != null && (observable == null || observable.contains(javaSE))) { |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1086 |
jdkModulePred = sym -> { |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1087 |
sym.complete(); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1088 |
return !sym.name.startsWith(java_) |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1089 |
&& sym.exports.stream().anyMatch(e -> e.modules == null); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1090 |
}; |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1091 |
enabledRoot.add(javaSE); |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1092 |
} else { |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1093 |
jdkModulePred = sym -> true; |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1094 |
} |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1095 |
|
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1096 |
for (ModuleSymbol sym : new HashSet<>(syms.getAllModules())) { |
3c8ff4204d2d
8154956: Module system implementation refresh (4/2016)
alanb
parents:
36526
diff
changeset
|
1097 |
if (systemModulePred.test(sym) && observablePred.test(sym) && jdkModulePred.test(sym)) { |
36526 | 1098 |
enabledRoot.add(sym); |
1099 |
} |
|
1100 |
} |
|
1101 |
} |
|
1102 |
||
1103 |
enabledRoot.addAll(rootModules); |
|
1104 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1105 |
if (addModsOpt != null || !extraAddMods.isEmpty()) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1106 |
Set<String> fullAddMods = new HashSet<>(); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1107 |
fullAddMods.addAll(extraAddMods); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1108 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1109 |
if (addModsOpt != null) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1110 |
fullAddMods.addAll(Arrays.asList(addModsOpt.split(","))); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1111 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1112 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1113 |
for (String added : fullAddMods) { |
36526 | 1114 |
Stream<ModuleSymbol> modules; |
1115 |
switch (added) { |
|
1116 |
case ALL_SYSTEM: |
|
1117 |
modules = syms.getAllModules() |
|
1118 |
.stream() |
|
1119 |
.filter(systemModulePred.and(observablePred)); |
|
1120 |
break; |
|
1121 |
case ALL_MODULE_PATH: |
|
1122 |
modules = syms.getAllModules() |
|
1123 |
.stream() |
|
1124 |
.filter(systemModulePred.negate().and(observablePred)); |
|
1125 |
break; |
|
1126 |
default: |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1127 |
if (!isValidName(added)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1128 |
continue; |
36526 | 1129 |
modules = Stream.of(syms.enterModule(names.fromString(added))); |
1130 |
break; |
|
1131 |
} |
|
1132 |
modules.forEach(sym -> { |
|
1133 |
enabledRoot.add(sym); |
|
1134 |
if (observable != null) |
|
1135 |
observable.add(sym); |
|
1136 |
}); |
|
1137 |
} |
|
1138 |
} |
|
1139 |
||
1140 |
Set<ModuleSymbol> result = computeTransitiveClosure(enabledRoot, observable); |
|
1141 |
||
1142 |
result.add(syms.unnamedModule); |
|
1143 |
||
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1144 |
allModules = result; |
42822
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1145 |
|
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1146 |
//add module versions from options, if any: |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1147 |
if (moduleVersionOpt != null) { |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1148 |
Name version = names.fromString(moduleVersionOpt); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1149 |
rootModules.forEach(m -> m.version = version); |
a84956e7ee4d
8170987: Module system implementation refresh (12/2016)
alanb
parents:
42408
diff
changeset
|
1150 |
} |
36526 | 1151 |
} |
1152 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1153 |
public boolean isInModuleGraph(ModuleSymbol msym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1154 |
return allModules == null || allModules.contains(msym); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1155 |
} |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1156 |
|
36526 | 1157 |
private Set<ModuleSymbol> computeTransitiveClosure(Iterable<? extends ModuleSymbol> base, Set<ModuleSymbol> observable) { |
1158 |
List<ModuleSymbol> todo = List.nil(); |
|
1159 |
||
1160 |
for (ModuleSymbol ms : base) { |
|
1161 |
todo = todo.prepend(ms); |
|
1162 |
} |
|
1163 |
||
1164 |
Set<ModuleSymbol> result = new LinkedHashSet<>(); |
|
1165 |
result.add(syms.java_base); |
|
1166 |
||
1167 |
while (todo.nonEmpty()) { |
|
1168 |
ModuleSymbol current = todo.head; |
|
1169 |
todo = todo.tail; |
|
1170 |
if (observable != null && !observable.contains(current)) |
|
1171 |
continue; |
|
1172 |
if (!result.add(current) || current == syms.unnamedModule || ((current.flags_field & Flags.AUTOMATIC_MODULE) != 0)) |
|
1173 |
continue; |
|
1174 |
current.complete(); |
|
1175 |
for (RequiresDirective rd : current.requires) { |
|
1176 |
todo = todo.prepend(rd.module); |
|
1177 |
} |
|
1178 |
} |
|
1179 |
||
1180 |
return result; |
|
1181 |
} |
|
1182 |
||
1183 |
public ModuleSymbol getObservableModule(Name name) { |
|
1184 |
ModuleSymbol mod = syms.getModule(name); |
|
1185 |
||
1186 |
if (allModules().contains(mod)) { |
|
1187 |
return mod; |
|
1188 |
} |
|
1189 |
||
1190 |
return null; |
|
1191 |
} |
|
1192 |
||
1193 |
private Completer getUnnamedModuleCompleter() { |
|
1194 |
moduleFinder.findAllModules(); |
|
1195 |
return new Symbol.Completer() { |
|
1196 |
@Override |
|
1197 |
public void complete(Symbol sym) throws CompletionFailure { |
|
41254
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
1198 |
if (inInitModules) { |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
1199 |
sym.completer = this; |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
1200 |
return ; |
08f8dbf7741e
8152911: javac assertion error when compiling overlay sources
jlahoda
parents:
40768
diff
changeset
|
1201 |
} |
36526 | 1202 |
ModuleSymbol msym = (ModuleSymbol) sym; |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1203 |
Set<ModuleSymbol> allModules = new HashSet<>(allModules()); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1204 |
allModules.remove(syms.unnamedModule); |
36526 | 1205 |
for (ModuleSymbol m : allModules) { |
1206 |
m.complete(); |
|
1207 |
} |
|
1208 |
initVisiblePackages(msym, allModules); |
|
1209 |
} |
|
1210 |
||
1211 |
@Override |
|
1212 |
public String toString() { |
|
1213 |
return "unnamedModule Completer"; |
|
1214 |
} |
|
1215 |
}; |
|
1216 |
} |
|
1217 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1218 |
private final Map<ModuleSymbol, Set<ModuleSymbol>> requiresTransitiveCache = new HashMap<>(); |
36526 | 1219 |
|
1220 |
private void completeModule(ModuleSymbol msym) { |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1221 |
if (inInitModules) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1222 |
msym.completer = sym -> completeModule(msym); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1223 |
return ; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1224 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1225 |
|
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1226 |
if ((msym.flags_field & Flags.AUTOMATIC_MODULE) != 0) { |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1227 |
completeAutomaticModule(msym); |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1228 |
} |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1229 |
|
36526 | 1230 |
Assert.checkNonNull(msym.requires); |
1231 |
||
1232 |
initAddReads(); |
|
1233 |
||
1234 |
msym.requires = msym.requires.appendList(List.from(addReads.getOrDefault(msym, Collections.emptySet()))); |
|
1235 |
||
1236 |
List<RequiresDirective> requires = msym.requires; |
|
1237 |
List<RequiresDirective> previous = null; |
|
1238 |
||
1239 |
while (requires.nonEmpty()) { |
|
1240 |
if (!allModules().contains(requires.head.module)) { |
|
1241 |
Env<AttrContext> env = typeEnvs.get(msym); |
|
1242 |
if (env != null) { |
|
1243 |
JavaFileObject origSource = log.useSource(env.toplevel.sourcefile); |
|
1244 |
try { |
|
1245 |
log.error(/*XXX*/env.tree, Errors.ModuleNotFound(requires.head.module)); |
|
1246 |
} finally { |
|
1247 |
log.useSource(origSource); |
|
1248 |
} |
|
1249 |
} else { |
|
1250 |
Assert.check((msym.flags() & Flags.AUTOMATIC_MODULE) == 0); |
|
1251 |
} |
|
1252 |
if (previous != null) { |
|
1253 |
previous.tail = requires.tail; |
|
1254 |
} else { |
|
1255 |
msym.requires.tail = requires.tail; |
|
1256 |
} |
|
1257 |
} else { |
|
1258 |
previous = requires; |
|
1259 |
} |
|
1260 |
requires = requires.tail; |
|
1261 |
} |
|
1262 |
||
1263 |
Set<ModuleSymbol> readable = new LinkedHashSet<>(); |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1264 |
Set<ModuleSymbol> requiresTransitive = new HashSet<>(); |
39366
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1265 |
|
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1266 |
for (RequiresDirective d : msym.requires) { |
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1267 |
d.module.complete(); |
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1268 |
readable.add(d.module); |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1269 |
Set<ModuleSymbol> s = retrieveRequiresTransitive(d.module); |
39366
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1270 |
Assert.checkNonNull(s, () -> "no entry in cache for " + d.module); |
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1271 |
readable.addAll(s); |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1272 |
if (d.flags.contains(RequiresFlag.TRANSITIVE)) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1273 |
requiresTransitive.add(d.module); |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1274 |
requiresTransitive.addAll(s); |
36526 | 1275 |
} |
39366
8bf5fe72ca88
8155026: javac grants implied readability to explicit modules
jlahoda
parents:
39361
diff
changeset
|
1276 |
} |
36526 | 1277 |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1278 |
requiresTransitiveCache.put(msym, requiresTransitive); |
36526 | 1279 |
initVisiblePackages(msym, readable); |
1280 |
for (ExportsDirective d: msym.exports) { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1281 |
if (d.packge != null) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1282 |
d.packge.modle = msym; |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1283 |
} |
36526 | 1284 |
} |
1285 |
||
1286 |
} |
|
1287 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1288 |
private Set<ModuleSymbol> retrieveRequiresTransitive(ModuleSymbol msym) { |
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1289 |
Set<ModuleSymbol> requiresTransitive = requiresTransitiveCache.get(msym); |
36526 | 1290 |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1291 |
if (requiresTransitive == null) { |
40762
f8883aa0053c
8160851: Remove old launcher module-related options
mchung
parents:
40604
diff
changeset
|
1292 |
//the module graph may contain cycles involving automatic modules or --add-reads edges |
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1293 |
requiresTransitive = new HashSet<>(); |
36526 | 1294 |
|
1295 |
Set<ModuleSymbol> seen = new HashSet<>(); |
|
1296 |
List<ModuleSymbol> todo = List.of(msym); |
|
1297 |
||
1298 |
while (todo.nonEmpty()) { |
|
1299 |
ModuleSymbol current = todo.head; |
|
1300 |
todo = todo.tail; |
|
1301 |
if (!seen.add(current)) |
|
1302 |
continue; |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1303 |
requiresTransitive.add(current); |
36526 | 1304 |
current.complete(); |
1305 |
Iterable<? extends RequiresDirective> requires; |
|
1306 |
if (current != syms.unnamedModule) { |
|
1307 |
Assert.checkNonNull(current.requires, () -> current + ".requires == null; " + msym); |
|
1308 |
requires = current.requires; |
|
1309 |
for (RequiresDirective rd : requires) { |
|
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1310 |
if (rd.isTransitive()) |
36526 | 1311 |
todo = todo.prepend(rd.module); |
1312 |
} |
|
1313 |
} else { |
|
1314 |
for (ModuleSymbol mod : allModules()) { |
|
1315 |
todo = todo.prepend(mod); |
|
1316 |
} |
|
1317 |
} |
|
1318 |
} |
|
1319 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1320 |
requiresTransitive.remove(msym); |
36526 | 1321 |
} |
1322 |
||
42407
f3702cff2933
8169069: Module system implementation refresh (11/2016)
alanb
parents:
41999
diff
changeset
|
1323 |
return requiresTransitive; |
36526 | 1324 |
} |
1325 |
||
1326 |
private void initVisiblePackages(ModuleSymbol msym, Collection<ModuleSymbol> readable) { |
|
1327 |
initAddExports(); |
|
1328 |
||
1329 |
msym.visiblePackages = new LinkedHashMap<>(); |
|
1330 |
||
1331 |
Map<Name, ModuleSymbol> seen = new HashMap<>(); |
|
1332 |
||
1333 |
for (ModuleSymbol rm : readable) { |
|
1334 |
if (rm == syms.unnamedModule) |
|
1335 |
continue; |
|
1336 |
addVisiblePackages(msym, seen, rm, rm.exports); |
|
1337 |
} |
|
1338 |
||
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1339 |
addExports.forEach((exportsFrom, exports) -> { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1340 |
addVisiblePackages(msym, seen, exportsFrom, exports); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1341 |
}); |
36526 | 1342 |
} |
1343 |
||
1344 |
private void addVisiblePackages(ModuleSymbol msym, |
|
1345 |
Map<Name, ModuleSymbol> seenPackages, |
|
1346 |
ModuleSymbol exportsFrom, |
|
1347 |
Collection<ExportsDirective> exports) { |
|
1348 |
for (ExportsDirective d : exports) { |
|
1349 |
if (d.modules == null || d.modules.contains(msym)) { |
|
1350 |
Name packageName = d.packge.fullname; |
|
1351 |
ModuleSymbol previousModule = seenPackages.get(packageName); |
|
1352 |
||
1353 |
if (previousModule != null && previousModule != exportsFrom) { |
|
1354 |
Env<AttrContext> env = typeEnvs.get(msym); |
|
1355 |
JavaFileObject origSource = env != null ? log.useSource(env.toplevel.sourcefile) |
|
1356 |
: null; |
|
1357 |
DiagnosticPosition pos = env != null ? env.tree.pos() : null; |
|
1358 |
try { |
|
1359 |
log.error(pos, Errors.PackageClashFromRequires(msym, packageName, |
|
1360 |
previousModule, exportsFrom)); |
|
1361 |
} finally { |
|
1362 |
if (env != null) |
|
1363 |
log.useSource(origSource); |
|
1364 |
} |
|
1365 |
continue; |
|
1366 |
} |
|
1367 |
||
1368 |
seenPackages.put(packageName, exportsFrom); |
|
1369 |
msym.visiblePackages.put(d.packge.fullname, d.packge); |
|
1370 |
} |
|
1371 |
} |
|
1372 |
} |
|
1373 |
||
1374 |
private void initAddExports() { |
|
1375 |
if (addExports != null) |
|
1376 |
return; |
|
1377 |
||
1378 |
addExports = new LinkedHashMap<>(); |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1379 |
Set<ModuleSymbol> unknownModules = new HashSet<>(); |
36526 | 1380 |
|
1381 |
if (addExportsOpt == null) |
|
1382 |
return; |
|
1383 |
||
1384 |
Pattern ep = Pattern.compile("([^/]+)/([^=]+)=(.*)"); |
|
1385 |
for (String s: addExportsOpt.split("\0+")) { |
|
1386 |
if (s.isEmpty()) |
|
1387 |
continue; |
|
1388 |
Matcher em = ep.matcher(s); |
|
1389 |
if (!em.matches()) { |
|
1390 |
continue; |
|
1391 |
} |
|
1392 |
||
1393 |
// Terminology comes from |
|
40762
f8883aa0053c
8160851: Remove old launcher module-related options
mchung
parents:
40604
diff
changeset
|
1394 |
// --add-exports module/package=target,... |
36526 | 1395 |
// Compare to |
1396 |
// module module { exports package to target, ... } |
|
1397 |
String moduleName = em.group(1); |
|
1398 |
String packageName = em.group(2); |
|
1399 |
String targetNames = em.group(3); |
|
1400 |
||
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1401 |
if (!isValidName(moduleName)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1402 |
continue; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1403 |
|
36526 | 1404 |
ModuleSymbol msym = syms.enterModule(names.fromString(moduleName)); |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1405 |
if (!isKnownModule(msym, unknownModules)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1406 |
continue; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1407 |
|
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1408 |
if (!isValidName(packageName)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1409 |
continue; |
36526 | 1410 |
PackageSymbol p = syms.enterPackage(msym, names.fromString(packageName)); |
1411 |
p.modle = msym; // TODO: do we need this? |
|
1412 |
||
1413 |
List<ModuleSymbol> targetModules = List.nil(); |
|
1414 |
for (String toModule : targetNames.split("[ ,]+")) { |
|
1415 |
ModuleSymbol m; |
|
1416 |
if (toModule.equals("ALL-UNNAMED")) { |
|
1417 |
m = syms.unnamedModule; |
|
1418 |
} else { |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1419 |
if (!isValidName(toModule)) |
36526 | 1420 |
continue; |
1421 |
m = syms.enterModule(names.fromString(toModule)); |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1422 |
if (!isKnownModule(m, unknownModules)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1423 |
continue; |
36526 | 1424 |
} |
1425 |
targetModules = targetModules.prepend(m); |
|
1426 |
} |
|
1427 |
||
1428 |
Set<ExportsDirective> extra = addExports.computeIfAbsent(msym, _x -> new LinkedHashSet<>()); |
|
1429 |
ExportsDirective d = new ExportsDirective(p, targetModules); |
|
1430 |
extra.add(d); |
|
1431 |
} |
|
1432 |
} |
|
1433 |
||
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1434 |
private boolean isKnownModule(ModuleSymbol msym, Set<ModuleSymbol> unknownModules) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1435 |
if (allModules.contains(msym)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1436 |
return true; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1437 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1438 |
|
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1439 |
if (!unknownModules.contains(msym)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1440 |
if (lintOptions) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1441 |
log.warning(LintCategory.OPTIONS, |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1442 |
Warnings.ModuleForOptionNotFound(Option.ADD_EXPORTS, msym)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1443 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1444 |
unknownModules.add(msym); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1445 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1446 |
return false; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1447 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1448 |
|
36526 | 1449 |
private void initAddReads() { |
1450 |
if (addReads != null) |
|
1451 |
return; |
|
1452 |
||
1453 |
addReads = new LinkedHashMap<>(); |
|
1454 |
||
1455 |
if (addReadsOpt == null) |
|
1456 |
return; |
|
1457 |
||
1458 |
Pattern rp = Pattern.compile("([^=]+)=(.*)"); |
|
1459 |
for (String s : addReadsOpt.split("\0+")) { |
|
1460 |
if (s.isEmpty()) |
|
1461 |
continue; |
|
1462 |
Matcher rm = rp.matcher(s); |
|
1463 |
if (!rm.matches()) { |
|
1464 |
continue; |
|
1465 |
} |
|
1466 |
||
1467 |
// Terminology comes from |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1468 |
// --add-reads source-module=target-module,... |
36526 | 1469 |
// Compare to |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1470 |
// module source-module { requires target-module; ... } |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1471 |
String sourceName = rm.group(1); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1472 |
String targetNames = rm.group(2); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1473 |
|
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1474 |
if (!isValidName(sourceName)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1475 |
continue; |
36526 | 1476 |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1477 |
ModuleSymbol msym = syms.enterModule(names.fromString(sourceName)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1478 |
if (!allModules.contains(msym)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1479 |
if (lintOptions) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1480 |
log.warning(Warnings.ModuleForOptionNotFound(Option.ADD_READS, msym)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1481 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1482 |
continue; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1483 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1484 |
|
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1485 |
for (String targetName : targetNames.split("[ ,]+", -1)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1486 |
ModuleSymbol targetModule; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1487 |
if (targetName.equals("ALL-UNNAMED")) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1488 |
targetModule = syms.unnamedModule; |
36526 | 1489 |
} else { |
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1490 |
if (!isValidName(targetName)) |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1491 |
continue; |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1492 |
targetModule = syms.enterModule(names.fromString(targetName)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1493 |
if (!allModules.contains(targetModule)) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1494 |
if (lintOptions) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1495 |
log.warning(LintCategory.OPTIONS, Warnings.ModuleForOptionNotFound(Option.ADD_READS, targetModule)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1496 |
} |
36526 | 1497 |
continue; |
1498 |
} |
|
1499 |
} |
|
1500 |
addReads.computeIfAbsent(msym, m -> new HashSet<>()) |
|
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1501 |
.add(new RequiresDirective(targetModule, EnumSet.of(RequiresFlag.EXTRA))); |
36526 | 1502 |
} |
1503 |
} |
|
1504 |
} |
|
1505 |
||
1506 |
private void checkCyclicDependencies(JCModuleDecl mod) { |
|
1507 |
for (JCDirective d : mod.directives) { |
|
39915
5d1e0740e709
8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
sadayapalam
parents:
39366
diff
changeset
|
1508 |
JCRequires rd; |
5d1e0740e709
8158224: NullPointerException in com.sun.tools.javac.comp.Modules.checkCyclicDependencies when module missing
sadayapalam
parents:
39366
diff
changeset
|
1509 |
if (!d.hasTag(Tag.REQUIRES) || (rd = (JCRequires) d).directive == null) |
36526 | 1510 |
continue; |
1511 |
Set<ModuleSymbol> nonSyntheticDeps = new HashSet<>(); |
|
1512 |
List<ModuleSymbol> queue = List.of(rd.directive.module); |
|
1513 |
while (queue.nonEmpty()) { |
|
1514 |
ModuleSymbol current = queue.head; |
|
1515 |
queue = queue.tail; |
|
1516 |
if (!nonSyntheticDeps.add(current)) |
|
1517 |
continue; |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1518 |
current.complete(); |
36526 | 1519 |
if ((current.flags() & Flags.ACYCLIC) != 0) |
1520 |
continue; |
|
42827
36468b5fa7f4
8181370: Convert anonymous inner classes into lambdas/method references
mcimadamore
parents:
42824
diff
changeset
|
1521 |
Assert.checkNonNull(current.requires, current::toString); |
36526 | 1522 |
for (RequiresDirective dep : current.requires) { |
1523 |
if (!dep.flags.contains(RequiresFlag.EXTRA)) |
|
1524 |
queue = queue.prepend(dep.module); |
|
1525 |
} |
|
1526 |
} |
|
1527 |
if (nonSyntheticDeps.contains(mod.sym)) { |
|
1528 |
log.error(rd.moduleName.pos(), Errors.CyclicRequires(rd.directive.module)); |
|
1529 |
} |
|
1530 |
mod.sym.flags_field |= Flags.ACYCLIC; |
|
1531 |
} |
|
1532 |
} |
|
1533 |
||
41938
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1534 |
private boolean isValidName(CharSequence name) { |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1535 |
return SourceVersion.isName(name, Source.toSourceVersion(source)); |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1536 |
} |
8e66bf10fcec
8167975: align javac --add-* modules options with launcher
jjg
parents:
41932
diff
changeset
|
1537 |
|
36526 | 1538 |
// DEBUG |
1539 |
private String toString(ModuleSymbol msym) { |
|
1540 |
return msym.name + "[" |
|
1541 |
+ "kind:" + msym.kind + ";" |
|
1542 |
+ "locn:" + toString(msym.sourceLocation) + "," + toString(msym.classLocation) + ";" |
|
1543 |
+ "info:" + toString(msym.module_info.sourcefile) + "," |
|
1544 |
+ toString(msym.module_info.classfile) + "," |
|
1545 |
+ msym.module_info.completer |
|
1546 |
+ "]"; |
|
1547 |
} |
|
1548 |
||
1549 |
// DEBUG |
|
1550 |
String toString(Location locn) { |
|
1551 |
return (locn == null) ? "--" : locn.getName(); |
|
1552 |
} |
|
1553 |
||
1554 |
// DEBUG |
|
1555 |
String toString(JavaFileObject fo) { |
|
1556 |
return (fo == null) ? "--" : fo.getName(); |
|
1557 |
} |
|
1558 |
||
1559 |
public void newRound() { |
|
39917
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1560 |
rootModules = null; |
c51a8950f278
8154705: invalid use of ALL-MODULE-PATH causes crash
ksrini
parents:
39915
diff
changeset
|
1561 |
allModules = null; |
36526 | 1562 |
} |
1563 |
} |