Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
8056951: pico-optimize contains(Object) methods
authormartin
Fri, 29 Aug 2014 14:50:15 -0700 (2014-08-29)
changeset 26451 f86e59f18322
parent 26450 7d90b73e92d4
child 26452 04bfc550f2b4
8056951: pico-optimize contains(Object) methods Summary: use idiiom >= 0 consistently to check for valid index Reviewed-by: mduigou
jdk/src/java.base/share/classes/java/lang/String.java file | annotate | diff | comparison | revisions
jdk/src/java.base/share/classes/java/util/Arrays.java file | annotate | diff | comparison | revisions
jdk/src/java.base/share/classes/java/util/LinkedList.java file | annotate | diff | comparison | revisions
jdk/src/java.base/share/classes/java/util/PriorityQueue.java file | annotate | diff | comparison | revisions 
--- a/jdk/src/java.base/share/classes/java/lang/String.java	Fri Sep 05 15:09:05 2014 +0200
+++ b/jdk/src/java.base/share/classes/java/lang/String.java	Fri Aug 29 14:50:15 2014 -0700
@@ -2119,7 +2119,7 @@
      * @since 1.5
      */
     public boolean contains(CharSequence s) {
-        return indexOf(s.toString()) > -1;
+        return indexOf(s.toString()) >= 0;
     }
 
     /**
--- a/jdk/src/java.base/share/classes/java/util/Arrays.java	Fri Sep 05 15:09:05 2014 +0200
+++ b/jdk/src/java.base/share/classes/java/util/Arrays.java	Fri Aug 29 14:50:15 2014 -0700
@@ -3865,7 +3865,7 @@
 
         @Override
         public boolean contains(Object o) {
-            return indexOf(o) != -1;
+            return indexOf(o) >= 0;
         }
 
         @Override
--- a/jdk/src/java.base/share/classes/java/util/LinkedList.java	Fri Sep 05 15:09:05 2014 +0200
+++ b/jdk/src/java.base/share/classes/java/util/LinkedList.java	Fri Aug 29 14:50:15 2014 -0700
@@ -314,7 +314,7 @@
      * @return {@code true} if this list contains the specified element
      */
     public boolean contains(Object o) {
-        return indexOf(o) != -1;
+        return indexOf(o) >= 0;
     }
 
     /**
--- a/jdk/src/java.base/share/classes/java/util/PriorityQueue.java	Fri Sep 05 15:09:05 2014 +0200
+++ b/jdk/src/java.base/share/classes/java/util/PriorityQueue.java	Fri Aug 29 14:50:15 2014 -0700
@@ -406,7 +406,7 @@
      * @return {@code true} if this queue contains the specified element
      */
     public boolean contains(Object o) {
-        return indexOf(o) != -1;
+        return indexOf(o) >= 0;
     }
 
     /**
jdk-sandbox