--- a/jdk/src/share/classes/javax/management/openmbean/CompositeDataSupport.java Fri Aug 08 15:10:51 2008 +0200
+++ b/jdk/src/share/classes/javax/management/openmbean/CompositeDataSupport.java Fri Aug 08 18:36:19 2008 +0200
@@ -355,6 +355,7 @@
* @return <code>true</code> if the specified object is equal to this
* <code>CompositeDataSupport</code> instance.
*/
+ @Override
public boolean equals(Object obj) {
if (this == obj) {
return true;
@@ -419,6 +420,7 @@
*
* @return the hash code value for this <code>CompositeDataSupport</code> instance
*/
+ @Override
public int hashCode() {
int hashcode = compositeType.hashCode();
@@ -457,16 +459,28 @@
*
* @return a string representation of this <code>CompositeDataSupport</code> instance
*/
+ @Override
public String toString() {
-
return new StringBuilder()
.append(this.getClass().getName())
.append("(compositeType=")
.append(compositeType.toString())
.append(",contents=")
- .append(contents.toString())
+ .append(contentString())
.append(")")
.toString();
}
+ private String contentString() {
+ StringBuilder sb = new StringBuilder("{");
+ String sep = "";
+ for (Map.Entry<String, Object> entry : contents.entrySet()) {
+ sb.append(sep).append(entry.getKey()).append("=");
+ String s = Arrays.deepToString(new Object[] {entry.getValue()});
+ sb.append(s.substring(1, s.length() - 1));
+ sep = ", ";
+ }
+ sb.append("}");
+ return sb.toString();
+ }
}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/jdk/test/javax/management/openmbean/CompositeDataStringTest.java Fri Aug 08 18:36:19 2008 +0200
@@ -0,0 +1,89 @@
+/*
+ * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+import javax.management.openmbean.CompositeType;
+import javax.management.openmbean.OpenType;
+import javax.management.openmbean.SimpleType;
+
+/*
+ * @test
+ * @bug 6610174
+ * @summary Test that CompositeDataSupport.toString() represents arrays correctly
+ * @author Eamonn McManus
+ */
+import javax.management.openmbean.ArrayType;
+import javax.management.openmbean.CompositeData;
+import javax.management.openmbean.CompositeDataSupport;
+
+public class CompositeDataStringTest {
+ public static void main(String[] args) throws Exception {
+ CompositeType basicCT = new CompositeType(
+ "basicCT", "basic CompositeType",
+ new String[] {"name", "value"},
+ new String[] {"name", "value"},
+ new OpenType<?>[] {SimpleType.STRING, SimpleType.INTEGER});
+ CompositeType ct = new CompositeType(
+ "noddy", "descr",
+ new String[] {"strings", "ints", "cds"},
+ new String[] {"string array", "int array", "composite data array"},
+ new OpenType<?>[] {
+ ArrayType.getArrayType(SimpleType.STRING),
+ ArrayType.getPrimitiveArrayType(int[].class),
+ ArrayType.getArrayType(basicCT)
+ });
+ CompositeData basicCD1 = new CompositeDataSupport(
+ basicCT, new String[] {"name", "value"}, new Object[] {"ceathar", 4});
+ CompositeData basicCD2 = new CompositeDataSupport(
+ basicCT, new String[] {"name", "value"}, new Object[] {"naoi", 9});
+ CompositeData cd = new CompositeDataSupport(
+ ct,
+ new String[] {"strings", "ints", "cds"},
+ new Object[] {
+ new String[] {"fred", "jim", "sheila"},
+ new int[] {2, 3, 5, 7},
+ new CompositeData[] {basicCD1, basicCD2}
+ });
+ String s = cd.toString();
+ System.out.println("CompositeDataSupport.toString(): " + s);
+ String[] expected = {
+ "fred, jim, sheila",
+ "2, 3, 5, 7",
+ "ceathar",
+ "naoi",
+ };
+ boolean ok = true;
+ for (String expect : expected) {
+ if (s.contains(expect))
+ System.out.println("OK: string contains <" + expect + ">");
+ else {
+ ok = false;
+ System.out.println("NOT OK: string does not contain <" +
+ expect + ">");
+ }
+ }
+ if (ok)
+ System.out.println("TEST PASSED");
+ else
+ throw new Exception("TEST FAILED: string did not contain expected substrings");
+ }
+}