7067045: replaceAll("\u20ac", "$"); causses java.lang.StringIndexOutOfBoundsExceptio
Summary: Updated to throw IAE instead.
Reviewed-by: lancea
--- a/jdk/src/share/classes/java/util/regex/Matcher.java Thu Apr 12 10:55:51 2012 -0700
+++ b/jdk/src/share/classes/java/util/regex/Matcher.java Thu Apr 12 15:01:41 2012 -0700
@@ -759,16 +759,19 @@
char nextChar = replacement.charAt(cursor);
if (nextChar == '\\') {
cursor++;
+ if (cursor == replacement.length())
+ throw new IllegalArgumentException(
+ "character to be escaped is missing");
nextChar = replacement.charAt(cursor);
result.append(nextChar);
cursor++;
} else if (nextChar == '$') {
// Skip past $
cursor++;
- // A StringIndexOutOfBoundsException is thrown if
- // this "$" is the last character in replacement
- // string in current implementation, a IAE might be
- // more appropriate.
+ // Throw IAE if this "$" is the last character in replacement
+ if (cursor == replacement.length())
+ throw new IllegalArgumentException(
+ "Illegal group reference: group index is missing");
nextChar = replacement.charAt(cursor);
int refNum = -1;
if (nextChar == '{') {
--- a/jdk/test/java/util/regex/RegExTest.java Thu Apr 12 10:55:51 2012 -0700
+++ b/jdk/test/java/util/regex/RegExTest.java Thu Apr 12 15:01:41 2012 -0700
@@ -33,6 +33,7 @@
* 5013885 5003322 4988891 5098443 5110268 6173522 4829857 5027748 6376940
* 6358731 6178785 6284152 6231989 6497148 6486934 6233084 6504326 6635133
* 6350801 6676425 6878475 6919132 6931676 6948903 6990617 7014645 7039066
+ * 7067045
*/
import java.util.regex.*;
@@ -852,6 +853,17 @@
if (!result.equals(toSupplementaries("zzz\\t$\\$zzz")))
failCount++;
+ // IAE should be thrown if backslash or '$' is the last character
+ // in replacement string
+ try {
+ "\uac00".replaceAll("\uac00", "$");
+ "\uac00".replaceAll("\uac00", "\\");
+ failCount++;
+ } catch (IllegalArgumentException iie) {
+ } catch (Exception e) {
+ failCount++;
+ }
+
report("Literal replacement");
}