8022738: doclet should only generate functional interface text if source >= 8
Reviewed-by: jjg
--- a/langtools/src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java Fri Aug 30 16:27:08 2013 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java Fri Aug 30 16:38:54 2013 -0700
@@ -289,7 +289,7 @@
}
public boolean isFunctionalInterface() {
- return env.types.isFunctionalInterface(tsym);
+ return env.types.isFunctionalInterface(tsym) && env.source.allowLambda();
}
/**
--- a/langtools/src/share/classes/com/sun/tools/javadoc/DocEnv.java Fri Aug 30 16:27:08 2013 -0700
+++ b/langtools/src/share/classes/com/sun/tools/javadoc/DocEnv.java Fri Aug 30 16:38:54 2013 -0700
@@ -124,6 +124,11 @@
private boolean silent = false;
/**
+ * The source language version.
+ */
+ protected Source source;
+
+ /**
* Constructor
*
* @param context Context for this javadoc instance.
@@ -144,6 +149,7 @@
// Default. Should normally be reset with setLocale.
this.doclocale = new DocLocale(this, "", breakiterator);
+ source = Source.instance(context);
}
public void setSilent(boolean silent) {
--- a/langtools/test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java Fri Aug 30 16:27:08 2013 -0700
+++ b/langtools/test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java Fri Aug 30 16:38:54 2013 -0700
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -23,7 +23,7 @@
/*
* @test
- * @bug 8004893
+ * @bug 8004893 8022738
* @summary Make sure that the lambda feature changes work fine in
* javadoc.
* @author bpatel
@@ -35,11 +35,15 @@
public class TestLambdaFeature extends JavadocTester {
//Test information.
- private static final String BUG_ID = "8004893";
+ private static final String BUG_ID = "8004893-8022738";
//Javadoc arguments.
private static final String[] ARGS = new String[] {
- "-d", BUG_ID, "-sourcepath", SRC_DIR, "pkg"
+ "-d", BUG_ID, "-sourcepath", SRC_DIR, "pkg", "pkg1"
+ };
+
+ private static final String[] ARGS_1 = new String[] {
+ "-d", BUG_ID + "-2", "-sourcepath", SRC_DIR, "-source", "1.5", "pkg1"
};
//Input for string search tests.
@@ -63,6 +67,11 @@
"<dl>" + NL + "<dt>Functional Interface:</dt>" + NL +
"<dd>This is a functional interface and can therefore be used as " +
"the assignment target for a lambda expression or method " +
+ "reference.</dd>" + NL + "</dl>"},
+ {BUG_ID + FS + "pkg1" + FS + "FuncInf.html",
+ "<dl>" + NL + "<dt>Functional Interface:</dt>" + NL +
+ "<dd>This is a functional interface and can therefore be used as " +
+ "the assignment target for a lambda expression or method " +
"reference.</dd>" + NL + "</dl>"}
};
private static final String[][] NEGATED_TEST = {
@@ -75,6 +84,10 @@
{BUG_ID + FS + "pkg" + FS + "B.html",
"<dl>" + NL + "<dt>Functional Interface:</dt>"}
};
+ private static final String[][] NEGATED_TEST_1 = {
+ {BUG_ID + "-2" + FS + "pkg1" + FS + "FuncInf.html",
+ "<dl>" + NL + "<dt>Functional Interface:</dt>"}
+ };
/**
* The entry point of the test.
@@ -83,6 +96,7 @@
public static void main(String[] args) {
TestLambdaFeature tester = new TestLambdaFeature();
run(tester, ARGS, TEST, NEGATED_TEST);
+ run(tester, ARGS_1, NO_TEST, NEGATED_TEST_1);
tester.printSummary();
}
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/langtools/test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java Fri Aug 30 16:38:54 2013 -0700
@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+package pkg1;
+
+public interface FuncInf<V> {
+
+ V call() throws Exception;
+}