8233788: Remove useless asserts in PhaseCFG::insert_anti_dependences
authorthartmann
Fri, 08 Nov 2019 09:16:48 +0100
changeset 58979 1edb08142cea
parent 58978 ad157fab6bf5
child 58980 47c20fc6a517
8233788: Remove useless asserts in PhaseCFG::insert_anti_dependences Summary: Removed useless asserts. Reviewed-by: kvn
src/hotspot/share/opto/compile.cpp
src/hotspot/share/opto/gcm.cpp
--- a/src/hotspot/share/opto/compile.cpp	Thu Nov 07 16:26:57 2019 -0800
+++ b/src/hotspot/share/opto/compile.cpp	Fri Nov 08 09:16:48 2019 +0100
@@ -1653,6 +1653,7 @@
 }
 
 void Compile::AliasType::Init(int i, const TypePtr* at) {
+  assert(AliasIdxTop <= i && i < Compile::current()->_max_alias_types, "Invalid alias index");
   _index = i;
   _adr_type = at;
   _field = NULL;
--- a/src/hotspot/share/opto/gcm.cpp	Thu Nov 07 16:26:57 2019 -0800
+++ b/src/hotspot/share/opto/gcm.cpp	Fri Nov 08 09:16:48 2019 +0100
@@ -510,6 +510,7 @@
   // do not need anti-dependence edges.
   int load_alias_idx = C->get_alias_index(load->adr_type());
 #ifdef ASSERT
+  assert(Compile::AliasIdxTop <= load_alias_idx && load_alias_idx < C->num_alias_types(), "Invalid alias index");
   if (load_alias_idx == Compile::AliasIdxBot && C->AliasLevel() > 0 &&
       (PrintOpto || VerifyAliases ||
        (PrintMiscellaneous && (WizardMode || Verbose)))) {
@@ -522,18 +523,6 @@
     if (VerifyAliases)  assert(load_alias_idx != Compile::AliasIdxBot, "");
   }
 #endif
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_StrComp),
-         "String compare is only known 'load' that does not conflict with any stores");
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_StrEquals),
-         "String equals is a 'load' that does not conflict with any stores");
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_StrIndexOf),
-         "String indexOf is a 'load' that does not conflict with any stores");
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_StrIndexOfChar),
-         "String indexOfChar is a 'load' that does not conflict with any stores");
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_AryEq),
-         "Arrays equals is a 'load' that does not conflict with any stores");
-  assert(load_alias_idx || (load->is_Mach() && load->as_Mach()->ideal_Opcode() == Op_HasNegatives),
-         "HasNegatives is a 'load' that does not conflict with any stores");
 
   if (!C->alias_type(load_alias_idx)->is_rewritable()) {
     // It is impossible to spoil this load by putting stores before it,