author | kbarrett |
Wed, 31 Jul 2019 14:28:51 -0400 | |
changeset 57607 | 8d3886985964 |
parent 54786 | ebf733a324d4 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
54645
05aaccf7d558
8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
coleenp
parents:
49594
diff
changeset
|
2 |
* Copyright (c) 1997, 2019, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
670
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
670
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
670
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
30764 | 26 |
#include "gc/shared/collectedHeap.hpp" |
49594
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
27 |
#include "gc/shared/gcLocker.hpp" |
7397 | 28 |
#include "memory/resourceArea.hpp" |
54786 | 29 |
#include "memory/universe.hpp" |
35061 | 30 |
#include "logging/log.hpp" |
40655
9f644073d3a0
8157907: Incorrect inclusion of atomic.hpp instead of atomic.inline.hpp
dholmes
parents:
37242
diff
changeset
|
31 |
#include "runtime/atomic.hpp" |
49594
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
32 |
#include "runtime/safepoint.hpp" |
24351
61b33cc6d3cf
8042195: Introduce umbrella header orderAccess.inline.hpp.
goetz
parents:
23540
diff
changeset
|
33 |
#include "runtime/thread.inline.hpp" |
48105
8d15b1369c7a
8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents:
47216
diff
changeset
|
34 |
#include "runtime/threadSMR.hpp" |
1 | 35 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
36 |
volatile jint GCLocker::_jni_lock_count = 0; |
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
37 |
volatile bool GCLocker::_needs_gc = false; |
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
38 |
volatile bool GCLocker::_doing_gc = false; |
57607
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
39 |
unsigned int GCLocker::_total_collections = 0; |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
40 |
|
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
41 |
#ifdef ASSERT |
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
42 |
volatile jint GCLocker::_debug_jni_lock_count = 0; |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
43 |
#endif |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
44 |
|
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
45 |
|
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
46 |
#ifdef ASSERT |
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
47 |
void GCLocker::verify_critical_count() { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
48 |
if (SafepointSynchronize::is_at_safepoint()) { |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
49 |
assert(!needs_gc() || _debug_jni_lock_count == _jni_lock_count, "must agree"); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
50 |
int count = 0; |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
51 |
// Count the number of threads with critical operations in progress |
48105
8d15b1369c7a
8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents:
47216
diff
changeset
|
52 |
JavaThreadIteratorWithHandle jtiwh; |
8d15b1369c7a
8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents:
47216
diff
changeset
|
53 |
for (; JavaThread *thr = jtiwh.next(); ) { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
54 |
if (thr->in_critical()) { |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
55 |
count++; |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
56 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
57 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
58 |
if (_jni_lock_count != count) { |
37226
9b0d4b523ce4
8153188: Use log_error(gc, verify) for logging in verification code
brutisso
parents:
35492
diff
changeset
|
59 |
log_error(gc, verify)("critical counts don't match: %d != %d", _jni_lock_count, count); |
48105
8d15b1369c7a
8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents:
47216
diff
changeset
|
60 |
jtiwh.rewind(); |
8d15b1369c7a
8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents:
47216
diff
changeset
|
61 |
for (; JavaThread *thr = jtiwh.next(); ) { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
62 |
if (thr->in_critical()) { |
37226
9b0d4b523ce4
8153188: Use log_error(gc, verify) for logging in verification code
brutisso
parents:
35492
diff
changeset
|
63 |
log_error(gc, verify)(INTPTR_FORMAT " in_critical %d", p2i(thr), thr->in_critical()); |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
64 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
65 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
66 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
67 |
assert(_jni_lock_count == count, "must be equal"); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
68 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
69 |
} |
25351
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
70 |
|
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
71 |
// In debug mode track the locking state at all times |
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
72 |
void GCLocker::increment_debug_jni_lock_count() { |
25351
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
73 |
assert(_debug_jni_lock_count >= 0, "bad value"); |
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
74 |
Atomic::inc(&_debug_jni_lock_count); |
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
75 |
} |
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
76 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
77 |
void GCLocker::decrement_debug_jni_lock_count() { |
25351
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
78 |
assert(_debug_jni_lock_count > 0, "bad value"); |
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
79 |
Atomic::dec(&_debug_jni_lock_count); |
7c198a690050
8044775: Improve usage of umbrella header atomic.inline.hpp.
goetz
parents:
24424
diff
changeset
|
80 |
} |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
81 |
#endif |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
82 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
83 |
void GCLocker::log_debug_jni(const char* msg) { |
37242 | 84 |
Log(gc, jni) log; |
35061 | 85 |
if (log.is_debug()) { |
86 |
ResourceMark rm; // JavaThread::name() allocates to convert to UTF8 |
|
87 |
log.debug("%s Thread \"%s\" %d locked.", msg, Thread::current()->name(), _jni_lock_count); |
|
88 |
} |
|
89 |
} |
|
90 |
||
49594
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
91 |
bool GCLocker::is_at_safepoint() { |
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
92 |
return SafepointSynchronize::is_at_safepoint(); |
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
93 |
} |
898ef81cbc0e
8200106: Move NoSafepointVerifier out from gcLocker.hpp
stefank
parents:
48105
diff
changeset
|
94 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
95 |
bool GCLocker::check_active_before_gc() { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
96 |
assert(SafepointSynchronize::is_at_safepoint(), "only read at safepoint"); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
97 |
if (is_active() && !_needs_gc) { |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
98 |
verify_critical_count(); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
99 |
_needs_gc = true; |
35061 | 100 |
log_debug_jni("Setting _needs_gc."); |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
101 |
} |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
102 |
return is_active(); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
103 |
} |
1 | 104 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
105 |
void GCLocker::stall_until_clear() { |
1 | 106 |
assert(!JavaThread::current()->in_critical(), "Would deadlock"); |
54645
05aaccf7d558
8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
coleenp
parents:
49594
diff
changeset
|
107 |
MonitorLocker ml(JNICritical_lock); |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
108 |
|
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
109 |
if (needs_gc()) { |
35061 | 110 |
log_debug_jni("Allocation failed. Thread stalled by JNI critical section."); |
386
7f121b1192f2
6539517: CR 6186200 should be extended to perm gen allocation to prevent spurious OOM's from perm gen
apetrusenko
parents:
1
diff
changeset
|
111 |
} |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
112 |
|
1 | 113 |
// Wait for _needs_gc to be cleared |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
114 |
while (needs_gc()) { |
54645
05aaccf7d558
8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
coleenp
parents:
49594
diff
changeset
|
115 |
ml.wait(); |
1 | 116 |
} |
117 |
} |
|
118 |
||
57607
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
119 |
bool GCLocker::should_discard(GCCause::Cause cause, uint total_collections) { |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
120 |
return (cause == GCCause::_gc_locker) && |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
121 |
(_total_collections != total_collections); |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
122 |
} |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
123 |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
124 |
void GCLocker::jni_lock(JavaThread* thread) { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
125 |
assert(!thread->in_critical(), "shouldn't currently be in a critical region"); |
54645
05aaccf7d558
8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
coleenp
parents:
49594
diff
changeset
|
126 |
MonitorLocker ml(JNICritical_lock); |
1 | 127 |
// Block entering threads if we know at least one thread is in a |
128 |
// JNI critical region and we need a GC. |
|
129 |
// We check that at least one thread is in a critical region before |
|
130 |
// blocking because blocked threads are woken up by a thread exiting |
|
131 |
// a JNI critical region. |
|
23540
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
132 |
while (is_active_and_needs_gc() || _doing_gc) { |
54645
05aaccf7d558
8222988: Use MonitorLocker rather than MutexLocker when wait/notify used
coleenp
parents:
49594
diff
changeset
|
133 |
ml.wait(); |
1 | 134 |
} |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
135 |
thread->enter_critical(); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
136 |
_jni_lock_count++; |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
137 |
increment_debug_jni_lock_count(); |
1 | 138 |
} |
139 |
||
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35061
diff
changeset
|
140 |
void GCLocker::jni_unlock(JavaThread* thread) { |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
141 |
assert(thread->in_last_critical(), "should be exiting critical region"); |
1 | 142 |
MutexLocker mu(JNICritical_lock); |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
143 |
_jni_lock_count--; |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
144 |
decrement_debug_jni_lock_count(); |
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
145 |
thread->exit_critical(); |
23540
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
146 |
if (needs_gc() && !is_active_internal()) { |
57607
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
147 |
// We're the last thread out. Request a GC. |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
148 |
// Capture the current total collections, to allow detection of |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
149 |
// other collections that make this one unnecessary. The value of |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
150 |
// total_collections() is only changed at a safepoint, so there |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
151 |
// must not be a safepoint between the lock becoming inactive and |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
152 |
// getting the count, else there may be unnecessary GCLocker GCs. |
8d3886985964
8048556: Unnecessary GCLocker-initiated young GCs
kbarrett
parents:
54786
diff
changeset
|
153 |
_total_collections = Universe::heap()->total_collections(); |
23540
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
154 |
_doing_gc = true; |
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
155 |
{ |
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
156 |
// Must give up the lock while at a safepoint |
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
157 |
MutexUnlocker munlock(JNICritical_lock); |
35061 | 158 |
log_debug_jni("Performing GC after exiting critical section."); |
23540
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
159 |
Universe::heap()->collect(GCCause::_gc_locker); |
1 | 160 |
} |
23540
06f7d6e1f654
8028498: runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java asserts in RT_Baseline
sjohanss
parents:
22234
diff
changeset
|
161 |
_doing_gc = false; |
11631
33813f69207b
7129164: JNI Get/ReleasePrimitiveArrayCritical doesn't scale
never
parents:
7397
diff
changeset
|
162 |
_needs_gc = false; |
1 | 163 |
JNICritical_lock->notify_all(); |
164 |
} |
|
165 |
} |