test/jdk/com/sun/jdi/MethodInvokeWithTraceOnTest.java
author dtitov
Tue, 09 Oct 2018 19:11:09 -0700
changeset 52068 218b5b64f102
permissions -rw-r--r--
8193879: Java debugger hangs on method invocation Reviewed-by: sspitsyn, amenkov, gadams
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
52068
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     1
/*
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     2
 * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     4
 *
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     7
 * published by the Free Software Foundation.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     8
 *
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    13
 * accompanied this code).
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    14
 *
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    18
 *
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    21
 * questions.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    22
 */
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    23
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    24
/**
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    25
 * @test
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    26
 * @bug 8193879 8193801 8129348
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    27
 * @summary Invokes static and instance methods when debugger trace
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    28
 * mode is on.
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    29
 * @library /test/lib
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    30
 * @run build TestScaffold VMConnection TargetListener TargetAdapter
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    31
 * @run compile -g MethodInvokeWithTraceOnTest.java
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    32
 * @run driver MethodInvokeWithTraceOnTest
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    33
 */
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    34
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    35
import com.sun.jdi.*;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    36
import com.sun.jdi.event.*;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    37
import com.sun.jdi.request.*;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    38
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    39
import java.util.*;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    40
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    41
import static lib.jdb.JdbTest.*;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    42
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    43
/********** target program **********/
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    44
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    45
class MethodInvokeWithTraceOnTestTarg {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    46
    public static void main(String[] args) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    47
        new MethodInvokeWithTraceOnTestTarg().test();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    48
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    49
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    50
    private void test() {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    51
        Thread thread = Thread.currentThread();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    52
        print(thread); // @1 breakpoint
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    53
        String str = "test";
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    54
        printStatic(str); // @2 breakpoint
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    55
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    56
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    57
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    58
    public void print(Object obj) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    59
        System.out.println(obj);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    60
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    61
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    62
    public static void printStatic(Object obj) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    63
        System.out.println(obj);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    64
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    65
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    66
}
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    67
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    68
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    69
/********** test program **********/
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    70
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    71
public class MethodInvokeWithTraceOnTest extends TestScaffold {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    72
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    73
    MethodInvokeWithTraceOnTest(String args[]) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    74
        super(args);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    75
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    76
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    77
    public static void main(String[] args)
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    78
            throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    79
        new MethodInvokeWithTraceOnTest(args).startTests();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    80
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    81
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    82
    /********** test core **********/
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    83
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    84
    protected void runTests() throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    85
        init();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    86
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    87
        // Test with suspend policy set to SUSPEND_EVENT_THREAD
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    88
        BreakpointEvent be = resumeToBreakpoint(true, 1);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    89
        System.out.println("Breakpoint 1 is hit, suspendPolicy:" + be.request().suspendPolicy());
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    90
        testMethods(be);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    91
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    92
        // Test with suspend policy set to SUSPEND_ALL
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    93
        be = resumeToBreakpoint(false, 2);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    94
        System.out.println("Breakpoint 2 is hit, suspendPolicy:" + be.request().suspendPolicy());
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    95
        testMethods(be);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    96
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    97
        listenUntilVMDisconnect();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    98
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
    99
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   100
    private void init() throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   101
        startToMain("MethodInvokeWithTraceOnTestTarg");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   102
        vm().setDebugTraceMode(VirtualMachine.TRACE_ALL);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   103
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   104
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   105
    private BreakpointEvent resumeToBreakpoint(boolean suspendThread, int breakpointId) throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   106
        int bkpLine = parseBreakpoints(getTestSourcePath("MethodInvokeWithTraceOnTest.java"), breakpointId).get(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   107
        System.out.println("Running to line: " + bkpLine);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   108
        return resumeTo("MethodInvokeWithTraceOnTestTarg", bkpLine, suspendThread);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   109
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   110
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   111
    private void testMethods(BreakpointEvent be) throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   112
        System.out.println("Testing  methods...");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   113
        ThreadReference thread = be.thread();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   114
        StackFrame frame = thread.frame(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   115
        ObjectReference thisObj = frame.thisObject();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   116
        LocalVariable threadVar = frame.visibleVariableByName("thread");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   117
        ThreadReference threadObj = (ThreadReference) frame.getValue(threadVar);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   118
        StringReference stringObj = vm().mirrorOf("test string");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   119
        int invokeOptions = getMethodInvokeOptions(be);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   120
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   121
        testInstanceMethod1(thread, thisObj, stringObj, threadObj, invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   122
        testStaticMethod1(thread, thisObj, stringObj, threadObj, invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   123
        testStaticMethod2(thread, invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   124
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   125
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   126
    private void testInstanceMethod1(ThreadReference thread, ObjectReference thisObj, StringReference stringObj,
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   127
                                     ThreadReference threadObj, int invokeOptions) throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   128
        ClassType classType = (ClassType) thisObj.referenceType();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   129
        Method printMethod = classType.methodsByName("print",
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   130
                "(Ljava/lang/Object;)V").get(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   131
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   132
        System.out.println("Passing StringReference to instance method...");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   133
        thisObj.invokeMethod(thread, printMethod, Collections.singletonList(stringObj), invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   134
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   135
        System.out.println("Passing ThreadReference to instance method...");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   136
        thisObj.invokeMethod(thread, printMethod, Collections.singletonList(threadObj), invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   137
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   138
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   139
    private void testStaticMethod1(ThreadReference thread, ObjectReference thisObj, StringReference stringObj,
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   140
                                   ThreadReference threadObj, int invokeOptions) throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   141
        ClassType classType = (ClassType) thisObj.referenceType();
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   142
        Method printMethod = classType.methodsByName("printStatic",
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   143
                "(Ljava/lang/Object;)V").get(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   144
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   145
        System.out.println("Passing StringReference to static method...");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   146
        classType.invokeMethod(thread, printMethod, Collections.singletonList(stringObj), invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   147
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   148
        System.out.println("Passing ThreadReference to static method...");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   149
        classType.invokeMethod(thread, printMethod, Collections.singletonList(threadObj), invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   150
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   151
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   152
    private void testStaticMethod2(ThreadReference thread, int invokeOptions) throws Exception {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   153
        ClassType classType = getClassType("java.lang.Class");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   154
        Method forNameMethod = classType.methodsByName("forName",
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   155
                "(Ljava/lang/String;)Ljava/lang/Class;").get(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   156
        StringReference classNameParam = vm().mirrorOf("java.lang.String");
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   157
        classType.invokeMethod(thread, forNameMethod, Collections.singletonList(classNameParam), invokeOptions);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   158
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   159
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   160
    private ClassType getClassType(String className) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   161
        List classes = vm().classesByName(className);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   162
        return (ClassType) classes.get(0);
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   163
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   164
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   165
    private int getMethodInvokeOptions(BreakpointEvent be) {
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   166
        return be.request().suspendPolicy() == EventRequest.SUSPEND_EVENT_THREAD ?
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   167
                ObjectReference.INVOKE_SINGLE_THREADED : 0;
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   168
    }
218b5b64f102 8193879: Java debugger hangs on method invocation
dtitov
parents:
diff changeset
   169
}