8228753: Deprecate -XX:FieldsAllocationStyle product option
authorcoleenp
Tue, 06 Aug 2019 07:43:18 -0400
changeset 57654 dd0f6703203f
parent 57653 06eed83ab4cd
child 57655 a95e92c449bf
8228753: Deprecate -XX:FieldsAllocationStyle product option 8228749: Deprecate product flag -XX:CompactFields Reviewed-by: kvn, shade
src/hotspot/share/runtime/arguments.cpp
src/hotspot/share/runtime/globals.hpp
test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java
--- a/src/hotspot/share/runtime/arguments.cpp	Tue Aug 06 12:14:41 2019 +0200
+++ b/src/hotspot/share/runtime/arguments.cpp	Tue Aug 06 07:43:18 2019 -0400
@@ -537,6 +537,8 @@
   { "ThreadLocalHandshakes",        JDK_Version::jdk(13), JDK_Version::jdk(14), JDK_Version::jdk(15) },
   { "AllowRedefinitionToAddDeleteMethods", JDK_Version::jdk(13), JDK_Version::undefined(), JDK_Version::undefined() },
   { "FlightRecorder",               JDK_Version::jdk(13), JDK_Version::undefined(), JDK_Version::undefined() },
+  { "FieldsAllocationStyle",        JDK_Version::jdk(14), JDK_Version::jdk(15), JDK_Version::jdk(16) },
+  { "CompactFields",                JDK_Version::jdk(14), JDK_Version::jdk(15), JDK_Version::jdk(16) },
 
   // --- Deprecated alias flags (see also aliased_jvm_flags) - sorted by obsolete_in then expired_in:
   { "DefaultMaxRAMFraction",        JDK_Version::jdk(8),  JDK_Version::undefined(), JDK_Version::undefined() },
--- a/src/hotspot/share/runtime/globals.hpp	Tue Aug 06 12:14:41 2019 +0200
+++ b/src/hotspot/share/runtime/globals.hpp	Tue Aug 06 07:43:18 2019 -0400
@@ -788,13 +788,14 @@
           "Use SSE2 MOVQ instruction for Arraycopy")                        \
                                                                             \
   product(intx, FieldsAllocationStyle, 1,                                   \
-          "0 - type based with oops first, "                                \
+          "(Deprecated) 0 - type based with oops first, "                   \
           "1 - with oops last, "                                            \
           "2 - oops in super and sub classes are together")                 \
           range(0, 2)                                                       \
                                                                             \
   product(bool, CompactFields, true,                                        \
-          "Allocate nonstatic fields in gaps between previous fields")      \
+          "(Deprecated) Allocate nonstatic fields in gaps "                 \
+          "between previous fields")                                        \
                                                                             \
   notproduct(bool, PrintFieldLayout, false,                                 \
           "Print field layout for each class")                              \
--- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java	Tue Aug 06 12:14:41 2019 +0200
+++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java	Tue Aug 06 07:43:18 2019 -0400
@@ -46,6 +46,8 @@
         {"InitialRAMFraction",        "64"},
         {"TLABStats",                 "false"},
         {"AllowRedefinitionToAddDeleteMethods", "true"},
+        {"CompactFields", "true"},
+        {"FieldsAllocationStyle", "1"},
 
         // deprecated alias flags (see also aliased_jvm_flags):
         {"DefaultMaxRAMFraction", "4"},