--- a/hotspot/src/cpu/sparc/vm/macroAssembler_sparc.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/cpu/sparc/vm/macroAssembler_sparc.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -2943,24 +2943,14 @@
}
bind (IsInflated);
- if (EmitSync & 64) {
- // If m->owner != null goto IsLocked
- // Test-and-CAS vs CAS
- // Pessimistic form avoids futile (doomed) CAS attempts
- // The optimistic form avoids RTS->RTO cache line upgrades.
- ld_ptr(Rmark, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner), Rscratch);
- andcc(Rscratch, Rscratch, G0);
- brx(Assembler::notZero, false, Assembler::pn, done);
- delayed()->nop();
- // m->owner == null : it's unlocked.
- }
// Try to CAS m->owner from null to Self
// Invariant: if we acquire the lock then _recursions should be 0.
add(Rmark, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner), Rmark);
mov(G2_thread, Rscratch);
cas_ptr(Rmark, G0, Rscratch);
- cmp(Rscratch, G0);
+ andcc(Rscratch, Rscratch, G0); // set ICCs for done: icc.zf iff success
+ // set icc.zf : 1=success 0=failure
// ST box->displaced_header = NonZero.
// Any non-zero value suffices:
// markOopDesc::unused_mark(), G2_thread, RBox, RScratch, rsp, etc.
--- a/hotspot/src/cpu/x86/vm/macroAssembler_x86.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/cpu/x86/vm/macroAssembler_x86.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1718,27 +1718,6 @@
// Force all sync thru slow-path: slow_enter() and slow_exit()
movptr (Address(boxReg, 0), (int32_t)intptr_t(markOopDesc::unused_mark()));
cmpptr (rsp, (int32_t)NULL_WORD);
- } else
- if (EmitSync & 2) {
- Label DONE_LABEL ;
- if (UseBiasedLocking) {
- // Note: tmpReg maps to the swap_reg argument and scrReg to the tmp_reg argument.
- biased_locking_enter(boxReg, objReg, tmpReg, scrReg, false, DONE_LABEL, NULL, counters);
- }
-
- movptr(tmpReg, Address(objReg, 0)); // fetch markword
- orptr (tmpReg, 0x1);
- movptr(Address(boxReg, 0), tmpReg); // Anticipate successful CAS
- if (os::is_MP()) {
- lock();
- }
- cmpxchgptr(boxReg, Address(objReg, 0)); // Updates tmpReg
- jccb(Assembler::equal, DONE_LABEL);
- // Recursive locking
- subptr(tmpReg, rsp);
- andptr(tmpReg, (int32_t) (NOT_LP64(0xFFFFF003) LP64_ONLY(7 - os::vm_page_size())) );
- movptr(Address(boxReg, 0), tmpReg);
- bind(DONE_LABEL);
} else {
// Possible cases that we'll encounter in fast_lock
// ------------------------------------------------
@@ -1923,29 +1902,19 @@
}
#else // _LP64
// It's inflated
-
- // TODO: someday avoid the ST-before-CAS penalty by
- // relocating (deferring) the following ST.
- // We should also think about trying a CAS without having
- // fetched _owner. If the CAS is successful we may
- // avoid an RTO->RTS upgrade on the $line.
-
- // Without cast to int32_t a movptr will destroy r10 which is typically obj
- movptr(Address(boxReg, 0), (int32_t)intptr_t(markOopDesc::unused_mark()));
-
- movptr (boxReg, tmpReg);
- movptr(tmpReg, Address(boxReg, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner)));
- testptr(tmpReg, tmpReg);
- jccb (Assembler::notZero, DONE_LABEL);
-
- // It's inflated and appears unlocked
+ movq(scrReg, tmpReg);
+ xorq(tmpReg, tmpReg);
+
if (os::is_MP()) {
lock();
}
- cmpxchgptr(r15_thread, Address(boxReg, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner)));
+ cmpxchgptr(r15_thread, Address(scrReg, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner)));
+ // Unconditionally set box->_displaced_header = markOopDesc::unused_mark().
+ // Without cast to int32_t movptr will destroy r10 which is typically obj.
+ movptr(Address(boxReg, 0), (int32_t)intptr_t(markOopDesc::unused_mark()));
// Intentional fall-through into DONE_LABEL ...
+ // Propagate ICC.ZF from CAS above into DONE_LABEL.
#endif // _LP64
-
#if INCLUDE_RTM_OPT
} // use_rtm()
#endif
--- a/hotspot/src/share/vm/classfile/classLoader.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/classfile/classLoader.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -152,40 +152,6 @@
}
-MetaIndex::MetaIndex(char** meta_package_names, int num_meta_package_names) {
- if (num_meta_package_names == 0) {
- _meta_package_names = NULL;
- _num_meta_package_names = 0;
- } else {
- _meta_package_names = NEW_C_HEAP_ARRAY(char*, num_meta_package_names, mtClass);
- _num_meta_package_names = num_meta_package_names;
- memcpy(_meta_package_names, meta_package_names, num_meta_package_names * sizeof(char*));
- }
-}
-
-
-MetaIndex::~MetaIndex() {
- FREE_C_HEAP_ARRAY(char*, _meta_package_names);
-}
-
-
-bool MetaIndex::may_contain(const char* class_name) {
- if ( _num_meta_package_names == 0) {
- return false;
- }
- size_t class_name_len = strlen(class_name);
- for (int i = 0; i < _num_meta_package_names; i++) {
- char* pkg = _meta_package_names[i];
- size_t pkg_len = strlen(pkg);
- size_t min_len = MIN2(class_name_len, pkg_len);
- if (!strncmp(class_name, pkg, min_len)) {
- return true;
- }
- }
- return false;
-}
-
-
ClassPathEntry::ClassPathEntry() {
set_next(NULL);
}
@@ -315,7 +281,6 @@
LazyClassPathEntry::LazyClassPathEntry(const char* path, const struct stat* st, bool throw_exception) : ClassPathEntry() {
_path = os::strdup_check_oom(path);
_st = *st;
- _meta_index = NULL;
_resolved_entry = NULL;
_has_error = false;
_throw_exception = throw_exception;
@@ -354,10 +319,6 @@
}
ClassFileStream* LazyClassPathEntry::open_stream(const char* name, TRAPS) {
- if (_meta_index != NULL &&
- !_meta_index->may_contain(name)) {
- return NULL;
- }
if (_has_error) {
return NULL;
}
@@ -463,16 +424,6 @@
}
#endif
-static void print_meta_index(LazyClassPathEntry* entry,
- GrowableArray<char*>& meta_packages) {
- tty->print("[Meta index for %s=", entry->name());
- for (int i = 0; i < meta_packages.length(); i++) {
- if (i > 0) tty->print(" ");
- tty->print("%s", meta_packages.at(i));
- }
- tty->print_cr("]");
-}
-
#if INCLUDE_CDS
void ClassLoader::exit_with_path_failure(const char* error, const char* message) {
assert(DumpSharedSpaces, "only called at dump time");
@@ -508,123 +459,6 @@
}
}
-void ClassLoader::setup_bootstrap_meta_index() {
- // Set up meta index which allows us to open boot jars lazily if
- // class data sharing is enabled
- const char* meta_index_path = Arguments::get_meta_index_path();
- const char* meta_index_dir = Arguments::get_meta_index_dir();
- setup_meta_index(meta_index_path, meta_index_dir, 0);
-}
-
-void ClassLoader::setup_meta_index(const char* meta_index_path, const char* meta_index_dir, int start_index) {
- const char* known_version = "% VERSION 2";
- FILE* file = fopen(meta_index_path, "r");
- int line_no = 0;
-#if INCLUDE_CDS
- if (DumpSharedSpaces) {
- if (file != NULL) {
- _shared_paths_misc_info->add_required_file(meta_index_path);
- } else {
- _shared_paths_misc_info->add_nonexist_path(meta_index_path);
- }
- }
-#endif
- if (file != NULL) {
- ResourceMark rm;
- LazyClassPathEntry* cur_entry = NULL;
- GrowableArray<char*> boot_class_path_packages(10);
- char package_name[256];
- bool skipCurrentJar = false;
- while (fgets(package_name, sizeof(package_name), file) != NULL) {
- ++line_no;
- // Remove trailing newline
- package_name[strlen(package_name) - 1] = '\0';
- switch(package_name[0]) {
- case '%':
- {
- if ((line_no == 1) && (strcmp(package_name, known_version) != 0)) {
- if (TraceClassLoading && Verbose) {
- tty->print("[Unsupported meta index version]");
- }
- fclose(file);
- return;
- }
- }
-
- // These directives indicate jar files which contain only
- // classes, only non-classfile resources, or a combination of
- // the two. See src/share/classes/sun/misc/MetaIndex.java and
- // make/tools/MetaIndex/BuildMetaIndex.java in the J2SE
- // workspace.
- case '#':
- case '!':
- case '@':
- {
- // Hand off current packages to current lazy entry (if any)
- if ((cur_entry != NULL) &&
- (boot_class_path_packages.length() > 0)) {
- if ((TraceClassLoading || TraceClassPaths) && Verbose) {
- print_meta_index(cur_entry, boot_class_path_packages);
- }
- MetaIndex* index = new MetaIndex(boot_class_path_packages.adr_at(0),
- boot_class_path_packages.length());
- cur_entry->set_meta_index(index);
- }
- cur_entry = NULL;
- boot_class_path_packages.clear();
-
- // Find lazy entry corresponding to this jar file
- int count = 0;
- for (ClassPathEntry* entry = _first_entry; entry != NULL; entry = entry->next(), count++) {
- if (count >= start_index &&
- entry->is_lazy() &&
- string_starts_with(entry->name(), meta_index_dir) &&
- string_ends_with(entry->name(), &package_name[2])) {
- cur_entry = (LazyClassPathEntry*) entry;
- break;
- }
- }
-
- // If the first character is '@', it indicates the following jar
- // file is a resource only jar file in which case, we should skip
- // reading the subsequent entries since the resource loading is
- // totally handled by J2SE side.
- if (package_name[0] == '@') {
- if (cur_entry != NULL) {
- cur_entry->set_meta_index(new MetaIndex(NULL, 0));
- }
- cur_entry = NULL;
- skipCurrentJar = true;
- } else {
- skipCurrentJar = false;
- }
-
- break;
- }
-
- default:
- {
- if (!skipCurrentJar && cur_entry != NULL) {
- char* new_name = os::strdup_check_oom(package_name);
- boot_class_path_packages.append(new_name);
- }
- }
- }
- }
- // Hand off current packages to current lazy entry (if any)
- if ((cur_entry != NULL) &&
- (boot_class_path_packages.length() > 0)) {
- if ((TraceClassLoading || TraceClassPaths) && Verbose) {
- print_meta_index(cur_entry, boot_class_path_packages);
- }
- MetaIndex* index = new MetaIndex(boot_class_path_packages.adr_at(0),
- boot_class_path_packages.length());
- cur_entry->set_meta_index(index);
- }
- fclose(file);
- }
-}
-
#if INCLUDE_CDS
void ClassLoader::check_shared_classpath(const char *path) {
if (strcmp(path, "") == 0) {
@@ -1315,10 +1149,6 @@
}
#endif
setup_bootstrap_search_path();
- if (LazyBootClassLoader) {
- // set up meta index which makes boot classpath initialization lazier
- setup_bootstrap_meta_index();
- }
}
#if INCLUDE_CDS
@@ -1486,12 +1316,7 @@
}
bool ClassPathZipEntry::is_jrt() {
- real_jzfile* zip = (real_jzfile*) _zip;
- int len = (int)strlen(zip->name);
- // Check whether zip name ends in "rt.jar"
- // This will match other archives named rt.jar as well, but this is
- // only used for debugging.
- return string_ends_with(zip->name, "rt.jar");
+ return false;
}
void LazyClassPathEntry::compile_the_world(Handle loader, TRAPS) {
@@ -1519,7 +1344,7 @@
ClassPathEntry* e = _first_entry;
jlong start = os::javaTimeMillis();
while (e != NULL) {
- // We stop at rt.jar, unless it is the first bootstrap path entry
+ // We stop at bootmodules.jimage, unless it is the first bootstrap path entry
if (e->is_jrt() && e != _first_entry) break;
e->compile_the_world(system_class_loader, CATCH);
e = e->next();
--- a/hotspot/src/share/vm/classfile/classLoader.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/classfile/classLoader.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -33,18 +33,6 @@
#include <sys/stat.h>
-// Meta-index (optional, to be able to skip opening boot classpath jar files)
-class MetaIndex: public CHeapObj<mtClass> {
- private:
- char** _meta_package_names;
- int _num_meta_package_names;
- public:
- MetaIndex(char** meta_package_names, int num_meta_package_names);
- ~MetaIndex();
- bool may_contain(const char* class_name);
-};
-
-
// Class path entry (directory or zip file)
class ClassPathEntry: public CHeapObj<mtClass> {
@@ -122,7 +110,6 @@
private:
const char* _path; // dir or file
struct stat _st;
- MetaIndex* _meta_index;
bool _has_error;
bool _throw_exception;
volatile ClassPathEntry* _resolved_entry;
@@ -135,7 +122,6 @@
u1* open_entry(const char* name, jint* filesize, bool nul_terminate, TRAPS);
ClassFileStream* open_stream(const char* name, TRAPS);
- void set_meta_index(MetaIndex* meta_index) { _meta_index = meta_index; }
virtual bool is_lazy();
// Debugging
NOT_PRODUCT(void compile_the_world(Handle loader, TRAPS);)
@@ -231,9 +217,6 @@
static bool add_package(const char *pkgname, int classpath_index, TRAPS);
// Initialization
- static void setup_bootstrap_meta_index();
- static void setup_meta_index(const char* meta_index_path, const char* meta_index_dir,
- int start_index);
static void setup_bootstrap_search_path();
static void setup_search_path(const char *class_path);
--- a/hotspot/src/share/vm/memory/heapInspection.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/memory/heapInspection.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -24,6 +24,7 @@
#include "precompiled.hpp"
#include "classfile/classLoaderData.hpp"
+#include "classfile/systemDictionary.hpp"
#include "gc_interface/collectedHeap.hpp"
#include "memory/genCollectedHeap.hpp"
#include "memory/heapInspection.hpp"
@@ -40,6 +41,19 @@
// HeapInspection
+inline KlassInfoEntry::~KlassInfoEntry() {
+ if (_subclasses != NULL) {
+ delete _subclasses;
+ }
+}
+
+inline void KlassInfoEntry::add_subclass(KlassInfoEntry* cie) {
+ if (_subclasses == NULL) {
+ _subclasses = new (ResourceObj::C_HEAP, mtInternal) GrowableArray<KlassInfoEntry*>(4, true);
+ }
+ _subclasses->append(cie);
+}
+
int KlassInfoEntry::compare(KlassInfoEntry* e1, KlassInfoEntry* e2) {
if(e1->_instance_words > e2->_instance_words) {
return -1;
@@ -130,7 +144,7 @@
_table->lookup(k);
}
-KlassInfoTable::KlassInfoTable(bool need_class_stats) {
+KlassInfoTable::KlassInfoTable(bool add_all_classes) {
_size_of_instances_in_words = 0;
_size = 0;
_ref = (HeapWord*) Universe::boolArrayKlassObj();
@@ -142,7 +156,7 @@
for (int index = 0; index < _size; index++) {
_buckets[index].initialize();
}
- if (need_class_stats) {
+ if (add_all_classes) {
AllClassesFinder finder(this);
ClassLoaderDataGraph::classes_do(&finder);
}
@@ -300,6 +314,191 @@
st->cr();
}
+class HierarchyClosure : public KlassInfoClosure {
+private:
+ GrowableArray<KlassInfoEntry*> *_elements;
+public:
+ HierarchyClosure(GrowableArray<KlassInfoEntry*> *_elements) : _elements(_elements) {}
+
+ void do_cinfo(KlassInfoEntry* cie) {
+ // ignore array classes
+ if (cie->klass()->oop_is_instance()) {
+ _elements->append(cie);
+ }
+ }
+};
+
+void KlassHierarchy::print_class_hierarchy(outputStream* st, bool print_interfaces,
+ bool print_subclasses, char* classname) {
+ ResourceMark rm;
+ Stack <KlassInfoEntry*, mtClass> class_stack;
+ GrowableArray<KlassInfoEntry*> elements;
+
+ // Add all classes to the KlassInfoTable, which allows for quick lookup.
+ // A KlassInfoEntry will be created for each class.
+ KlassInfoTable cit(true);
+ if (cit.allocation_failed()) {
+ st->print_cr("ERROR: Ran out of C-heap; hierarchy not generated");
+ return;
+ }
+
+ // Add all created KlassInfoEntry instances to the elements array for easy
+ // iteration, and to allow each KlassInfoEntry instance to have a unique index.
+ HierarchyClosure hc(&elements);
+ cit.iterate(&hc);
+
+ for(int i = 0; i < elements.length(); i++) {
+ KlassInfoEntry* cie = elements.at(i);
+ const InstanceKlass* k = (InstanceKlass*)cie->klass();
+ Klass* super = ((InstanceKlass*)k)->java_super();
+
+ // Set the index for the class.
+ cie->set_index(i + 1);
+
+ // Add the class to the subclass array of its superclass.
+ if (super != NULL) {
+ KlassInfoEntry* super_cie = cit.lookup(super);
+ assert(super_cie != NULL, "could not lookup superclass");
+ super_cie->add_subclass(cie);
+ }
+ }
+
+ // Set the do_print flag for each class that should be printed.
+ for(int i = 0; i < elements.length(); i++) {
+ KlassInfoEntry* cie = elements.at(i);
+ if (classname == NULL) {
+ // We are printing all classes.
+ cie->set_do_print(true);
+ } else {
+ // We are only printing the hierarchy of a specific class.
+ if (strcmp(classname, cie->klass()->external_name()) == 0) {
+ KlassHierarchy::set_do_print_for_class_hierarchy(cie, &cit, print_subclasses);
+ }
+ }
+ }
+
+ // Now we do a depth first traversal of the class hierachry. The class_stack will
+ // maintain the list of classes we still need to process. Start things off
+ // by priming it with java.lang.Object.
+ KlassInfoEntry* jlo_cie = cit.lookup(SystemDictionary::Object_klass());
+ assert(jlo_cie != NULL, "could not lookup java.lang.Object");
+ class_stack.push(jlo_cie);
+
+ // Repeatedly pop the top item off the stack, print its class info,
+ // and push all of its subclasses on to the stack. Do this until there
+ // are no classes left on the stack.
+ while (!class_stack.is_empty()) {
+ KlassInfoEntry* curr_cie = class_stack.pop();
+ if (curr_cie->do_print()) {
+ print_class(st, curr_cie, print_interfaces);
+ if (curr_cie->subclasses() != NULL) {
+ // Current class has subclasses, so push all of them onto the stack.
+ for (int i = 0; i < curr_cie->subclasses()->length(); i++) {
+ KlassInfoEntry* cie = curr_cie->subclasses()->at(i);
+ if (cie->do_print()) {
+ class_stack.push(cie);
+ }
+ }
+ }
+ }
+ }
+
+ st->flush();
+}
+
+// Sets the do_print flag for every superclass and subclass of the specified class.
+void KlassHierarchy::set_do_print_for_class_hierarchy(KlassInfoEntry* cie, KlassInfoTable* cit,
+ bool print_subclasses) {
+ // Set do_print for all superclasses of this class.
+ Klass* super = ((InstanceKlass*)cie->klass())->java_super();
+ while (super != NULL) {
+ KlassInfoEntry* super_cie = cit->lookup(super);
+ super_cie->set_do_print(true);
+ super = super->super();
+ }
+
+ // Set do_print for this class and all of its subclasses.
+ Stack <KlassInfoEntry*, mtClass> class_stack;
+ class_stack.push(cie);
+ while (!class_stack.is_empty()) {
+ KlassInfoEntry* curr_cie = class_stack.pop();
+ curr_cie->set_do_print(true);
+ if (print_subclasses && curr_cie->subclasses() != NULL) {
+ // Current class has subclasses, so push all of them onto the stack.
+ for (int i = 0; i < curr_cie->subclasses()->length(); i++) {
+ KlassInfoEntry* cie = curr_cie->subclasses()->at(i);
+ class_stack.push(cie);
+ }
+ }
+ }
+}
+
+static void print_indent(outputStream* st, int indent) {
+ while (indent != 0) {
+ st->print("|");
+ indent--;
+ if (indent != 0) {
+ st->print(" ");
+ }
+ }
+}
+
+// Print the class name and its unique ClassLoader identifer.
+static void print_classname(outputStream* st, Klass* klass) {
+ oop loader_oop = klass->class_loader_data()->class_loader();
+ st->print("%s/", klass->external_name());
+ if (loader_oop == NULL) {
+ st->print("null");
+ } else {
+ st->print(INTPTR_FORMAT, klass->class_loader_data());
+ }
+}
+
+static void print_interface(outputStream* st, Klass* intf_klass, const char* intf_type, int indent) {
+ print_indent(st, indent);
+ st->print(" implements ");
+ print_classname(st, intf_klass);
+ st->print(" (%s intf)\n", intf_type);
+}
+
+void KlassHierarchy::print_class(outputStream* st, KlassInfoEntry* cie, bool print_interfaces) {
+ ResourceMark rm;
+ InstanceKlass* klass = (InstanceKlass*)cie->klass();
+ int indent = 0;
+
+ // Print indentation with proper indicators of superclass.
+ Klass* super = klass->super();
+ while (super != NULL) {
+ super = super->super();
+ indent++;
+ }
+ print_indent(st, indent);
+ if (indent != 0) st->print("--");
+
+ // Print the class name, its unique ClassLoader identifer, and if it is an interface.
+ print_classname(st, klass);
+ if (klass->is_interface()) {
+ st->print(" (intf)");
+ }
+ st->print("\n");
+
+ // Print any interfaces the class has.
+ if (print_interfaces) {
+ Array<Klass*>* local_intfs = klass->local_interfaces();
+ Array<Klass*>* trans_intfs = klass->transitive_interfaces();
+ for (int i = 0; i < local_intfs->length(); i++) {
+ print_interface(st, local_intfs->at(i), "declared", indent);
+ }
+ for (int i = 0; i < trans_intfs->length(); i++) {
+ Klass* trans_interface = trans_intfs->at(i);
+ // Only print transitive interfaces if they are not also declared.
+ if (!local_intfs->contains(trans_interface)) {
+ print_interface(st, trans_interface, "inherited", indent);
+ }
+ }
+ }
+}
+
void KlassInfoHisto::print_class_stats(outputStream* st,
bool csv_format, const char *columns) {
ResourceMark rm;
@@ -321,6 +520,8 @@
elements()->at(i)->set_index(i+1);
}
+ // First iteration is for accumulating stats totals in colsum_table[].
+ // Second iteration is for printing stats for each class.
for (int pass=1; pass<=2; pass++) {
if (pass == 2) {
print_title(st, csv_format, selected, width_table, name_table);
@@ -329,6 +530,7 @@
KlassInfoEntry* e = (KlassInfoEntry*)elements()->at(i);
const Klass* k = e->klass();
+ // Get the stats for this class.
memset(&sz, 0, sizeof(sz));
sz._inst_count = e->count();
sz._inst_bytes = HeapWordSize * e->words();
@@ -336,11 +538,13 @@
sz._total_bytes = sz._ro_bytes + sz._rw_bytes;
if (pass == 1) {
+ // Add the stats for this class to the overall totals.
for (int c=0; c<KlassSizeStats::_num_columns; c++) {
colsum_table[c] += col_table[c];
}
} else {
int super_index = -1;
+ // Print the stats for this class.
if (k->oop_is_instance()) {
Klass* super = ((InstanceKlass*)k)->java_super();
if (super) {
@@ -374,6 +578,8 @@
}
if (pass == 1) {
+ // Calculate the minimum width needed for the column by accounting for the
+ // column header width and the width of the largest value in the column.
for (int c=0; c<KlassSizeStats::_num_columns; c++) {
width_table[c] = col_width(colsum_table[c], name_table[c]);
}
@@ -382,6 +588,7 @@
sz_sum._inst_size = 0;
+ // Print the column totals.
if (csv_format) {
st->print(",");
for (int c=0; c<KlassSizeStats::_num_columns; c++) {
@@ -515,6 +722,7 @@
KlassInfoTable cit(_print_class_stats);
if (!cit.allocation_failed()) {
+ // populate table with object allocation info
size_t missed_count = populate_table(&cit);
if (missed_count != 0) {
st->print_cr("WARNING: Ran out of C-heap; undercounted " SIZE_FORMAT
@@ -534,7 +742,7 @@
histo.sort();
histo.print_histo_on(st, _print_class_stats, _csv_format, _columns);
} else {
- st->print_cr("WARNING: Ran out of C-heap; histogram not generated");
+ st->print_cr("ERROR: Ran out of C-heap; histogram not generated");
}
st->flush();
}
--- a/hotspot/src/share/vm/memory/heapInspection.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/memory/heapInspection.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -189,11 +189,15 @@
long _instance_count;
size_t _instance_words;
long _index;
+ bool _do_print; // True if we should print this class when printing the class hierarchy.
+ GrowableArray<KlassInfoEntry*>* _subclasses;
public:
KlassInfoEntry(Klass* k, KlassInfoEntry* next) :
- _klass(k), _instance_count(0), _instance_words(0), _next(next), _index(-1)
+ _klass(k), _instance_count(0), _instance_words(0), _next(next), _index(-1),
+ _do_print(false), _subclasses(NULL)
{}
+ ~KlassInfoEntry();
KlassInfoEntry* next() const { return _next; }
bool is_equal(const Klass* k) { return k == _klass; }
Klass* klass() const { return _klass; }
@@ -203,6 +207,10 @@
void set_words(size_t wds) { _instance_words = wds; }
void set_index(long index) { _index = index; }
long index() const { return _index; }
+ GrowableArray<KlassInfoEntry*>* subclasses() const { return _subclasses; }
+ void add_subclass(KlassInfoEntry* cie);
+ void set_do_print(bool do_print) { _do_print = do_print; }
+ bool do_print() const { return _do_print; }
int compare(KlassInfoEntry* e1, KlassInfoEntry* e2);
void print_on(outputStream* st) const;
const char* name() const;
@@ -249,7 +257,7 @@
};
public:
- KlassInfoTable(bool need_class_stats);
+ KlassInfoTable(bool add_all_classes);
~KlassInfoTable();
bool record_instance(const oop obj);
void iterate(KlassInfoClosure* cic);
@@ -257,6 +265,18 @@
size_t size_of_instances_in_words() const;
friend class KlassInfoHisto;
+ friend class KlassHierarchy;
+};
+
+class KlassHierarchy : AllStatic {
+ public:
+ static void print_class_hierarchy(outputStream* st, bool print_interfaces, bool print_subclasses,
+ char* classname);
+
+ private:
+ static void set_do_print_for_class_hierarchy(KlassInfoEntry* cie, KlassInfoTable* cit,
+ bool print_subclasse);
+ static void print_class(outputStream* st, KlassInfoEntry* cie, bool print_subclasses);
};
class KlassInfoHisto : public StackObj {
--- a/hotspot/src/share/vm/opto/cfgnode.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/opto/cfgnode.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1015,7 +1015,6 @@
if( jtip && ttip ) {
if( jtip->is_loaded() && jtip->klass()->is_interface() &&
ttip->is_loaded() && !ttip->klass()->is_interface() ) {
- // Happens in a CTW of rt.jar, 320-341, no extra flags
assert(ft == ttip->cast_to_ptr_type(jtip->ptr()) ||
ft->isa_narrowoop() && ft->make_ptr() == ttip->cast_to_ptr_type(jtip->ptr()), "");
jt = ft;
--- a/hotspot/src/share/vm/opto/library_call.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/opto/library_call.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -2598,8 +2598,7 @@
// bypassing each other. Happens after null checks, so the
// exception paths do not take memory state from the memory barrier,
// so there's no problems making a strong assert about mixing users
- // of safe & unsafe memory. Otherwise fails in a CTW of rt.jar
- // around 5701, class sun/reflect/UnsafeBooleanFieldAccessorImpl.
+ // of safe & unsafe memory.
if (need_mem_bar) insert_mem_bar(Op_MemBarCPUOrder);
if (!is_store) {
--- a/hotspot/src/share/vm/opto/type.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/opto/type.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -3122,7 +3122,6 @@
if (ftip != NULL && ktip != NULL &&
ftip->is_loaded() && ftip->klass()->is_interface() &&
ktip->is_loaded() && !ktip->klass()->is_interface()) {
- // Happens in a CTW of rt.jar, 320-341, no extra flags
assert(!ftip->klass_is_exact(), "interface could not be exact");
return ktip->cast_to_ptr_type(ftip->ptr());
}
--- a/hotspot/src/share/vm/runtime/arguments.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/arguments.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -109,8 +109,6 @@
SystemProperty *Arguments::_java_class_path = NULL;
SystemProperty *Arguments::_sun_boot_class_path = NULL;
-char* Arguments::_meta_index_path = NULL;
-char* Arguments::_meta_index_dir = NULL;
char* Arguments::_ext_dirs = NULL;
// Check if head of 'option' matches 'name', and sets 'tail' to the remaining
--- a/hotspot/src/share/vm/runtime/arguments.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/arguments.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -260,10 +260,6 @@
static SystemProperty *_java_class_path;
static SystemProperty *_sun_boot_class_path;
- // Meta-index for knowing what packages are in the boot class path
- static char* _meta_index_path;
- static char* _meta_index_dir;
-
// temporary: to emit warning if the default ext dirs are not empty.
// remove this variable when the warning is no longer needed.
static char* _ext_dirs;
@@ -600,16 +596,10 @@
static void set_ext_dirs(char *value) { _ext_dirs = os::strdup_check_oom(value); }
static void set_sysclasspath(char *value) { _sun_boot_class_path->set_value(value); }
static void append_sysclasspath(const char *value) { _sun_boot_class_path->append_value(value); }
- static void set_meta_index_path(char* meta_index_path, char* meta_index_dir) {
- _meta_index_path = meta_index_path;
- _meta_index_dir = meta_index_dir;
- }
static char* get_java_home() { return _java_home->value(); }
static char* get_dll_dir() { return _sun_boot_library_path->value(); }
static char* get_sysclasspath() { return _sun_boot_class_path->value(); }
- static char* get_meta_index_path() { return _meta_index_path; }
- static char* get_meta_index_dir() { return _meta_index_dir; }
static char* get_ext_dirs() { return _ext_dirs; }
static char* get_appclasspath() { return _java_class_path->value(); }
static void fix_appclasspath();
--- a/hotspot/src/share/vm/runtime/interfaceSupport.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/interfaceSupport.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -511,6 +511,12 @@
Thread* THREAD = thread; \
debug_only(VMEntryWrapper __vew;)
+#define JRT_BLOCK_NO_ASYNC \
+ { \
+ ThreadInVMfromJavaNoAsyncException __tiv(thread); \
+ Thread* THREAD = thread; \
+ debug_only(VMEntryWrapper __vew;)
+
#define JRT_BLOCK_END }
#define JRT_END }
--- a/hotspot/src/share/vm/runtime/os.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/os.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1223,14 +1223,6 @@
const char* home = Arguments::get_java_home();
int home_len = (int)strlen(home);
- static const char* meta_index_dir_format = "%/lib/";
- static const char* meta_index_format = "%/lib/meta-index";
- char* meta_index = format_boot_path(meta_index_format, home, home_len, fileSep, pathSep);
- if (meta_index == NULL) return false;
- char* meta_index_dir = format_boot_path(meta_index_dir_format, home, home_len, fileSep, pathSep);
- if (meta_index_dir == NULL) return false;
- Arguments::set_meta_index_path(meta_index, meta_index_dir);
-
char* sysclasspath = NULL;
struct stat st;
@@ -1244,38 +1236,17 @@
}
FREE_C_HEAP_ARRAY(char, jimage);
- // images build if rt.jar exists
- char* rt_jar = format_boot_path("%/lib/rt.jar", home, home_len, fileSep, pathSep);
- if (rt_jar == NULL) return false;
- bool has_rt_jar = (os::stat(rt_jar, &st) == 0);
- FREE_C_HEAP_ARRAY(char, rt_jar);
+ // check if developer build with exploded modules
+ char* modules_dir = format_boot_path("%/modules", home, home_len, fileSep, pathSep);
+ if (os::stat(modules_dir, &st) == 0) {
+ if ((st.st_mode & S_IFDIR) == S_IFDIR) {
+ sysclasspath = expand_entries_to_path(modules_dir, fileSep, pathSep);
+ }
+ }
- if (has_rt_jar) {
- // Any modification to the JAR-file list, for the boot classpath must be
- // aligned with install/install/make/common/Pack.gmk. Note: boot class
- // path class JARs, are stripped for StackMapTable to reduce download size.
- static const char classpath_format[] =
- "%/lib/resources.jar:"
- "%/lib/rt.jar:"
- "%/lib/jsse.jar:"
- "%/lib/jce.jar:"
- "%/lib/charsets.jar:"
- "%/lib/jfr.jar:"
- "%/classes";
- sysclasspath = format_boot_path(classpath_format, home, home_len, fileSep, pathSep);
- } else {
- // no rt.jar, check if developer build with exploded modules
- char* modules_dir = format_boot_path("%/modules", home, home_len, fileSep, pathSep);
- if (os::stat(modules_dir, &st) == 0) {
- if ((st.st_mode & S_IFDIR) == S_IFDIR) {
- sysclasspath = expand_entries_to_path(modules_dir, fileSep, pathSep);
- }
- }
-
- // fallback to classes
- if (sysclasspath == NULL)
- sysclasspath = format_boot_path("%/classes", home, home_len, fileSep, pathSep);
- }
+ // fallback to classes
+ if (sysclasspath == NULL)
+ sysclasspath = format_boot_path("%/classes", home, home_len, fileSep, pathSep);
if (sysclasspath == NULL) return false;
Arguments::set_sysclasspath(sysclasspath);
--- a/hotspot/src/share/vm/runtime/sharedRuntime.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/sharedRuntime.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -1792,7 +1792,17 @@
// Handles the uncommon case in locking, i.e., contention or an inflated lock.
-JRT_ENTRY_NO_ASYNC(void, SharedRuntime::complete_monitor_locking_C(oopDesc* _obj, BasicLock* lock, JavaThread* thread))
+JRT_BLOCK_ENTRY(void, SharedRuntime::complete_monitor_locking_C(oopDesc* _obj, BasicLock* lock, JavaThread* thread))
+ if (!SafepointSynchronize::is_synchronizing()) {
+ // Only try quick_enter() if we're not trying to reach a safepoint
+ // so that the calling thread reaches the safepoint more quickly.
+ if (ObjectSynchronizer::quick_enter(_obj, thread, lock)) return;
+ }
+ // NO_ASYNC required because an async exception on the state transition destructor
+ // would leave you with the lock held and it would never be released.
+ // The normal monitorenter NullPointerException is thrown without acquiring a lock
+ // and the model is that an exception implies the method failed.
+ JRT_BLOCK_NO_ASYNC
oop obj(_obj);
if (PrintBiasedLockingStatistics) {
Atomic::inc(BiasedLocking::slow_path_entry_count_addr());
@@ -1805,6 +1815,7 @@
ObjectSynchronizer::slow_enter(h_obj, lock, CHECK);
}
assert(!HAS_PENDING_EXCEPTION, "Should have no exception here");
+ JRT_BLOCK_END
JRT_END
// Handles the uncommon cases of monitor unlocking in compiled code
--- a/hotspot/src/share/vm/runtime/synchronizer.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/synchronizer.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -122,6 +122,70 @@
static volatile int MonitorPopulation = 0; // # Extant -- in circulation
#define CHAINMARKER (cast_to_oop<intptr_t>(-1))
+
+// =====================> Quick functions
+
+// The quick_* forms are special fast-path variants used to improve
+// performance. In the simplest case, a "quick_*" implementation could
+// simply return false, in which case the caller will perform the necessary
+// state transitions and call the slow-path form.
+// The fast-path is designed to handle frequently arising cases in an efficient
+// manner and is just a degenerate "optimistic" variant of the slow-path.
+// returns true -- to indicate the call was satisfied.
+// returns false -- to indicate the call needs the services of the slow-path.
+// A no-loitering ordinance is in effect for code in the quick_* family
+// operators: safepoints or indefinite blocking (blocking that might span a
+// safepoint) are forbidden. Generally the thread_state() is _in_Java upon
+// entry.
+
+// The LockNode emitted directly at the synchronization site would have
+// been too big if it were to have included support for the cases of inflated
+// recursive enter and exit, so they go here instead.
+// Note that we can't safely call AsyncPrintJavaStack() from within
+// quick_enter() as our thread state remains _in_Java.
+
+bool ObjectSynchronizer::quick_enter(oop obj, Thread * Self,
+ BasicLock * Lock) {
+ assert(!SafepointSynchronize::is_at_safepoint(), "invariant");
+ assert(Self->is_Java_thread(), "invariant");
+ assert(((JavaThread *) Self)->thread_state() == _thread_in_Java, "invariant");
+ No_Safepoint_Verifier nsv;
+ if (obj == NULL) return false; // Need to throw NPE
+ const markOop mark = obj->mark();
+
+ if (mark->has_monitor()) {
+ ObjectMonitor * const m = mark->monitor();
+ assert(m->object() == obj, "invariant");
+ Thread * const owner = (Thread *) m->_owner;
+
+ // Lock contention and Transactional Lock Elision (TLE) diagnostics
+ // and observability
+ // Case: light contention possibly amenable to TLE
+ // Case: TLE inimical operations such as nested/recursive synchronization
+
+ if (owner == Self) {
+ m->_recursions++;
+ return true;
+ }
+
+ if (owner == NULL &&
+ Atomic::cmpxchg_ptr(Self, &(m->_owner), NULL) == NULL) {
+ assert(m->_recursions == 0, "invariant");
+ assert(m->_owner == Self, "invariant");
+ return true;
+ }
+ }
+
+ // Note that we could inflate in quick_enter.
+ // This is likely a useful optimization
+ // Critically, in quick_enter() we must not:
+ // -- perform bias revocation, or
+ // -- block indefinitely, or
+ // -- reach a safepoint
+
+ return false; // revert to slow-path
+}
+
// -----------------------------------------------------------------------------
// Fast Monitor Enter/Exit
// This the fast monitor enter. The interpreter and compiler use
--- a/hotspot/src/share/vm/runtime/synchronizer.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/synchronizer.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -72,6 +72,8 @@
static void notify(Handle obj, TRAPS);
static void notifyall(Handle obj, TRAPS);
+ static bool quick_enter(oop obj, Thread* Self, BasicLock* Lock);
+
// Special internal-use-only method for use by JVM infrastructure
// that needs to wait() on a java-level object but that can't risk
// throwing unexpected InterruptedExecutionExceptions.
--- a/hotspot/src/share/vm/runtime/vm_operations.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/vm_operations.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -29,6 +29,7 @@
#include "compiler/compileBroker.hpp"
#include "compiler/compilerOracle.hpp"
#include "gc_implementation/shared/isGCActiveMark.hpp"
+#include "memory/heapInspection.hpp"
#include "memory/resourceArea.hpp"
#include "oops/symbol.hpp"
#include "runtime/arguments.hpp"
@@ -486,3 +487,9 @@
void VM_PrintCodeCache::doit() {
CodeCache::print_layout(_out);
}
+
+#if INCLUDE_SERVICES
+void VM_PrintClassHierarchy::doit() {
+ KlassHierarchy::print_class_hierarchy(_out, _print_interfaces, _print_subclasses, _classname);
+}
+#endif
--- a/hotspot/src/share/vm/runtime/vm_operations.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/runtime/vm_operations.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1997, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -105,6 +105,7 @@
template(PrintCompileQueue) \
template(PrintCodeList) \
template(PrintCodeCache) \
+ template(PrintClassHierarchy) \
class VM_Operation: public CHeapObj<mtInternal> {
public:
@@ -457,5 +458,21 @@
void doit();
};
+#if INCLUDE_SERVICES
+class VM_PrintClassHierarchy: public VM_Operation {
+ private:
+ outputStream* _out;
+ bool _print_interfaces;
+ bool _print_subclasses;
+ char* _classname;
+
+ public:
+ VM_PrintClassHierarchy(outputStream* st, bool print_interfaces, bool print_subclasses, char* classname) :
+ _out(st), _print_interfaces(print_interfaces), _print_subclasses(print_subclasses),
+ _classname(classname) {}
+ VMOp_Type type() const { return VMOp_PrintClassHierarchy; }
+ void doit();
+};
+#endif // INCLUDE_SERVICES
#endif // SHARE_VM_RUNTIME_VM_OPERATIONS_HPP
--- a/hotspot/src/share/vm/services/diagnosticCommand.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/services/diagnosticCommand.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -58,6 +58,7 @@
DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<HeapDumpDCmd>(DCmd_Source_Internal | DCmd_Source_AttachAPI, true, false));
DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<ClassHistogramDCmd>(full_export, true, false));
DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<ClassStatsDCmd>(full_export, true, false));
+ DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<ClassHierarchyDCmd>(full_export, true, false));
DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<SymboltableDCmd>(full_export, true, false));
DCmdFactory::register_DCmdFactory(new DCmdFactoryImpl<StringtableDCmd>(full_export, true, false));
#endif // INCLUDE_SERVICES
@@ -696,3 +697,35 @@
VMThread::execute(&printCodeCacheOp);
}
+#if INCLUDE_SERVICES
+ClassHierarchyDCmd::ClassHierarchyDCmd(outputStream* output, bool heap) :
+ DCmdWithParser(output, heap),
+ _print_interfaces("-i", "Inherited interfaces should be printed.", "BOOLEAN", false, "false"),
+ _print_subclasses("-s", "If a classname is specified, print its subclasses. "
+ "Otherwise only its superclasses are printed.", "BOOLEAN", false, "false"),
+ _classname("classname", "Name of class whose hierarchy should be printed. "
+ "If not specified, all class hierarchies are printed.",
+ "STRING", false) {
+ _dcmdparser.add_dcmd_option(&_print_interfaces);
+ _dcmdparser.add_dcmd_option(&_print_subclasses);
+ _dcmdparser.add_dcmd_argument(&_classname);
+}
+
+void ClassHierarchyDCmd::execute(DCmdSource source, TRAPS) {
+ VM_PrintClassHierarchy printClassHierarchyOp(output(), _print_interfaces.value(),
+ _print_subclasses.value(), _classname.value());
+ VMThread::execute(&printClassHierarchyOp);
+}
+
+int ClassHierarchyDCmd::num_arguments() {
+ ResourceMark rm;
+ ClassHierarchyDCmd* dcmd = new ClassHierarchyDCmd(NULL, false);
+ if (dcmd != NULL) {
+ DCmdMark mark(dcmd);
+ return dcmd->_dcmdparser.num_arguments();
+ } else {
+ return 0;
+ }
+}
+
+#endif
--- a/hotspot/src/share/vm/services/diagnosticCommand.hpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/services/diagnosticCommand.hpp Thu Feb 19 12:56:50 2015 +0100
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2011, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -271,6 +271,34 @@
virtual void execute(DCmdSource source, TRAPS);
};
+
+class ClassHierarchyDCmd : public DCmdWithParser {
+protected:
+ DCmdArgument<bool> _print_interfaces; // true if inherited interfaces should be printed.
+ DCmdArgument<bool> _print_subclasses; // true if subclasses of the specified classname should be printed.
+ DCmdArgument<char*> _classname; // Optional single class name whose hierarchy should be printed.
+public:
+ ClassHierarchyDCmd(outputStream* output, bool heap);
+ static const char* name() {
+ return "VM.class_hierarchy";
+ }
+ static const char* description() {
+ return "Print a list of all loaded classes, indented to show the class hiearchy. "
+ "The name of each class is followed by the ClassLoaderData* of its ClassLoader, "
+ "or \"null\" if loaded by the bootstrap class loader.";
+ }
+ static const char* impact() {
+ return "Medium: Depends on number of loaded classes.";
+ }
+ static const JavaPermission permission() {
+ JavaPermission p = {"java.lang.management.ManagementPermission",
+ "monitor", NULL};
+ return p;
+ }
+ static int num_arguments();
+ virtual void execute(DCmdSource source, TRAPS);
+};
+
// See also: thread_dump in attachListener.cpp
class ThreadDumpDCmd : public DCmdWithParser {
protected:
--- a/hotspot/src/share/vm/services/writeableFlags.cpp Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/src/share/vm/services/writeableFlags.cpp Thu Feb 19 12:56:50 2015 +0100
@@ -223,4 +223,5 @@
ShouldNotReachHere();
}
return ERR_OTHER;
-}
\ No newline at end of file
+}
+
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/hotspot/test/serviceability/dcmd/vm/ClassHierarchyTest.java Thu Feb 19 12:56:50 2015 +0100
@@ -0,0 +1,199 @@
+/*
+ * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @summary Test of diagnostic command VM.class_hierarchy
+ * @library /testlibrary
+ * @build com.oracle.java.testlibrary.*
+ * @build com.oracle.java.testlibrary.dcmd.*
+ * @run testng ClassHierarchyTest
+ */
+
+import org.testng.annotations.Test;
+import org.testng.Assert;
+
+import com.oracle.java.testlibrary.OutputAnalyzer;
+import com.oracle.java.testlibrary.dcmd.CommandExecutor;
+import com.oracle.java.testlibrary.dcmd.JMXExecutor;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.nio.channels.FileChannel;
+import java.util.Iterator;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+public class ClassHierarchyTest {
+
+ // $> jcmd DcmdTestClass VM.class_hierarchy DcmdTestClass | grep DcmdTestClass\$\$Lambda
+ // |--DcmdTestClass$$Lambda$1/4081552/0xa529fbb0
+
+ // > VM.class_hierarchy DcmdBaseClass
+ // java.lang.Object/null
+ // |--DcmdBaseClass/0xa4abcd48
+
+ // > VM.class_hierarchy DcmdBaseClass -s
+ // java.lang.Object/null
+ // |--DcmdBaseClass/0xa4abcd48
+ // | |--DcmdTestClass/0xa4abcd48
+
+ // > VM.class_hierarchy DcmdBaseClass -i -s
+ // java.lang.Object/null
+ // |--DcmdBaseClass/0xa4abcd48
+ // | implements Intf2/0xa4abcd48 (declared intf)
+ // | implements Intf1/0xa4abcd48 (inherited intf)
+ // | |--DcmdTestClass/0xa4abcd48
+ // | | implements Intf1/0xa4abcd48 (inherited intf)
+ // | | implements Intf2/0xa4abcd48 (inherited intf)
+
+ static Pattern expected_lambda_line =
+ Pattern.compile("\\|--DcmdTestClass\\$\\$Lambda.*");
+
+ static Pattern expected_lines[] = {
+ Pattern.compile("java.lang.Object/null"),
+ Pattern.compile("\\|--DcmdBaseClass/0x(\\p{XDigit}*)"),
+ Pattern.compile("\\| implements Intf2/0x(\\p{XDigit}*) \\(declared intf\\)"),
+ Pattern.compile("\\| implements Intf1/0x(\\p{XDigit}*) \\(inherited intf\\)"),
+ Pattern.compile("\\| \\|--DcmdTestClass/0x(\\p{XDigit}*)"),
+ Pattern.compile("\\| \\| implements Intf1/0x(\\p{XDigit}*) \\(inherited intf\\)"),
+ Pattern.compile("\\| \\| implements Intf2/0x(\\p{XDigit}*) \\(inherited intf\\)")
+ };
+
+ public void run(CommandExecutor executor) throws ClassNotFoundException {
+ OutputAnalyzer output;
+ Iterator<String> lines;
+ int i;
+
+ // Load our test class whose hierarchy we will print.
+ Class<?> c = Class.forName("DcmdTestClass");
+
+ // Verify the presence of the lamba anonymous class
+ output = executor.execute("VM.class_hierarchy");
+ lines = output.asLines().iterator();
+ Boolean foundMatch = false;
+ while (lines.hasNext()) {
+ String line = lines.next();
+ Matcher m = expected_lambda_line.matcher(line);
+ if (m.matches()) {
+ foundMatch = true;
+ break;
+ }
+ }
+ if (!foundMatch) {
+ Assert.fail("Failed to find lamda class");
+ }
+
+ // Verify the output for the simple hierachry of just DcmdBaseClass.
+ output = executor.execute("VM.class_hierarchy DcmdBaseClass");
+ lines = output.asLines().iterator();
+ i = 0;
+ while (lines.hasNext()) {
+ String line = lines.next();
+ Matcher m = expected_lines[i].matcher(line);
+ i++;
+ if (!m.matches()) {
+ Assert.fail("Failed to match line #" + i + ": " + line);
+ }
+ // Should only be two lines of output in this form.
+ if (i == 2) break;
+ }
+ if (lines.hasNext()) {
+ String line = lines.next();
+ Assert.fail("Unexpected dcmd output: " + line);
+ }
+
+ // Verify the output for the full hierarchy of DcmdBaseClass, but without interfaces.
+ output = executor.execute("VM.class_hierarchy DcmdBaseClass -s");
+ lines = output.asLines().iterator();
+ i = 0;
+ while (lines.hasNext()) {
+ String line = lines.next();
+ Matcher m = expected_lines[i].matcher(line);
+ i++;
+ if (!m.matches()) {
+ Assert.fail("Failed to match line #" + i + ": " + line);
+ }
+ // "implements" lines should not be in this output.
+ if (i == 2 || i == 4) i += 2;
+ }
+ if (lines.hasNext()) {
+ String line = lines.next();
+ Assert.fail("Unexpected dcmd output: " + line);
+ }
+
+ // Verify the output for the full hierarchy of DcmdBaseClass, including interfaces.
+ output = executor.execute("VM.class_hierarchy DcmdBaseClass -i -s");
+ lines = output.asLines().iterator();
+ i = 0;
+ String classLoaderAddr = null;
+ while (lines.hasNext()) {
+ String line = lines.next();
+ Matcher m = expected_lines[i].matcher(line);
+ i++;
+ if (!m.matches()) {
+ Assert.fail("Failed to match line #" + i + ": " + line);
+ }
+ if (i == 2) {
+ // Fetch the ClassLoader address, which should be the same in
+ // subsequent lines.
+ classLoaderAddr = m.group(1);
+ System.out.println(classLoaderAddr);
+ } else if (i > 2) {
+ if (!classLoaderAddr.equals(m.group(1))) {
+ Assert.fail("Classloader address didn't match on line #"
+ + i + ": " + line);
+ }
+ }
+ if (i == expected_lines.length) break;
+ }
+ if (lines.hasNext()) {
+ String line = lines.next();
+ Assert.fail("Unexpected dcmd output: " + line);
+ }
+ }
+
+ @Test
+ public void jmx() throws ClassNotFoundException {
+ run(new JMXExecutor());
+ }
+}
+
+interface Intf1 {
+}
+
+interface Intf2 extends Intf1 {
+}
+
+class DcmdBaseClass implements Intf2 {
+}
+
+class DcmdTestClass extends DcmdBaseClass {
+ static {
+ // Force creation of anonymous class (for the lambdaform).
+ Runnable r = () -> System.out.println("Hello");
+ r.run();
+ }
+}
--- a/hotspot/test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java Wed Feb 18 08:57:29 2015 +0100
+++ b/hotspot/test/testlibrary/com/oracle/java/testlibrary/ProcessTools.java Thu Feb 19 12:56:50 2015 +0100
@@ -33,8 +33,6 @@
import java.util.Collections;
import java.util.List;
-import sun.management.VMManagement;
-
public final class ProcessTools {
private ProcessTools() {
@@ -90,19 +88,8 @@
* @return Process id
*/
public static int getProcessId() throws Exception {
-
- // Get the current process id using a reflection hack
RuntimeMXBean runtime = ManagementFactory.getRuntimeMXBean();
- Field jvm = runtime.getClass().getDeclaredField("jvm");
-
- jvm.setAccessible(true);
- VMManagement mgmt = (sun.management.VMManagement) jvm.get(runtime);
-
- Method pid_method = mgmt.getClass().getDeclaredMethod("getProcessId");
-
- pid_method.setAccessible(true);
-
- int pid = (Integer) pid_method.invoke(mgmt);
+ int pid = Integer.parseInt(runtime.getName().split("@")[0]);
return pid;
}