8223080: Build team code review requests. JDK-8200758-branch
authorherrick
Fri, 07 Jun 2019 12:27:49 -0400
branchJDK-8200758-branch
changeset 57399 747416ba316d
parent 57398 99e0948cbd98
child 57401 8a257decfe24
8223080: Build team code review requests. Reviewed-by: erikj
make/CompileJavaModules.gmk
make/common/Modules.gmk
make/launcher/Launcher-jdk.jpackage.gmk
make/lib/Lib-jdk.jpackage.gmk
--- a/make/CompileJavaModules.gmk	Fri Jun 07 08:39:04 2019 -0400
+++ b/make/CompileJavaModules.gmk	Fri Jun 07 12:27:49 2019 -0400
@@ -380,8 +380,6 @@
 
 ################################################################################
 
-jdk.jpackage_ADD_JAVAC_FLAGS += -parameters -XDstringConcat=inline
-
 jdk.jpackage_COPY += .gif .png .txt .spec .script .prerm .preinst .postrm .postinst .list \
     .desktop .copyright .control .plist .template .icns .scpt .entitlements .wxs .iss .ico .bmp
 
--- a/make/common/Modules.gmk	Fri Jun 07 08:39:04 2019 -0400
+++ b/make/common/Modules.gmk	Fri Jun 07 12:27:49 2019 -0400
@@ -231,7 +231,7 @@
 ################################################################################
 # jpackage is only on windows, macosx, and linux
 
-ifeq ($(filter $(OPENJDK_TARGET_OS), windows macosx linux), )
+ifeq ($(call isTargetOs, windows macosx linux), false)
   MODULES_FILTER += jdk.jpackage
 endif
 
--- a/make/launcher/Launcher-jdk.jpackage.gmk	Fri Jun 07 08:39:04 2019 -0400
+++ b/make/launcher/Launcher-jdk.jpackage.gmk	Fri Jun 07 12:27:49 2019 -0400
@@ -57,7 +57,7 @@
 TARGETS += $(BUILD_JPACKAGE_APPLAUNCHEREXE)
 
 # Build non-console version of launcher
-ifeq ($(OPENJDK_TARGET_OS), windows)
+ifeq ($(call isTargetOs, windows), true)
 
   $(eval $(call SetupJdkExecutable, BUILD_JPACKAGE_APPLAUNCHERWEXE, \
       NAME := jpackageapplauncherw, \
--- a/make/lib/Lib-jdk.jpackage.gmk	Fri Jun 07 08:39:04 2019 -0400
+++ b/make/lib/Lib-jdk.jpackage.gmk	Fri Jun 07 12:27:49 2019 -0400
@@ -50,7 +50,7 @@
 
 ################################################################################
 
-ifeq ($(OPENJDK_TARGET_OS), windows)
+ifeq ($(call isTargetOs, windows), true)
 
   $(eval $(call SetupJdkLibrary, BUILD_LIB_JPACKAGE, \
       NAME := jpackage, \
@@ -69,7 +69,7 @@
 
 # Build Wix custom action helper
 # Output library in resources dir, and symbols in the object dir
-ifeq ($(OPENJDK_TARGET_OS), windows)
+ifeq ($(call isTargetOs, windows), true)
 
   $(eval $(call SetupJdkLibrary, BUILD_LIB_WIXHELPER, \
       NAME := wixhelper, \