8224666: Parallel GC: Use WorkGang (8: obsolete and remove flags)
authorlkorinth
Fri, 16 Aug 2019 09:18:41 +0200
changeset 57774 21dccfac0ec5
parent 57773 5cbc3bd9fdfd
child 57777 90ead0febf56
8224666: Parallel GC: Use WorkGang (8: obsolete and remove flags) Reviewed-by: stefank, kbarrett, tschatzl
src/hotspot/share/gc/shared/gc_globals.hpp
src/hotspot/share/runtime/arguments.cpp
--- a/src/hotspot/share/gc/shared/gc_globals.hpp	Fri Aug 16 09:18:38 2019 +0200
+++ b/src/hotspot/share/gc/shared/gc_globals.hpp	Fri Aug 16 09:18:41 2019 +0200
@@ -680,12 +680,6 @@
   product(bool, DisableExplicitGC, false,                                   \
           "Ignore calls to System.gc()")                                    \
                                                                             \
-  product(bool, BindGCTaskThreadsToCPUs, false,                             \
-          "Bind GCTaskThreads to CPUs if possible")                         \
-                                                                            \
-  product(bool, UseGCTaskAffinity, false,                                   \
-          "Use worker affinity when asking for GCTasks")                    \
-                                                                            \
   product(bool, PrintGC, false,                                             \
           "Print message at garbage collection. "                           \
           "Deprecated, use -Xlog:gc instead.")                              \
--- a/src/hotspot/share/runtime/arguments.cpp	Fri Aug 16 09:18:38 2019 +0200
+++ b/src/hotspot/share/runtime/arguments.cpp	Fri Aug 16 09:18:41 2019 +0200
@@ -553,6 +553,8 @@
   { "SharedMiscDataSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
   { "SharedMiscCodeSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
   { "FailOverToOldVerifier",         JDK_Version::undefined(), JDK_Version::jdk(14), JDK_Version::jdk(15) },
+  { "BindGCTaskThreadsToCPUs",       JDK_Version::undefined(), JDK_Version::jdk(14), JDK_Version::jdk(16) },
+  { "UseGCTaskAffinity",             JDK_Version::undefined(), JDK_Version::jdk(14), JDK_Version::jdk(16) },
 
 #ifdef TEST_VERIFY_SPECIAL_JVM_FLAGS
   // These entries will generate build errors.  Their purpose is to test the macros.
@@ -1968,13 +1970,6 @@
     return JNI_EINVAL;
   }
 
-  // Get around early Solaris scheduling bug
-  // (affinity vs other jobs on system)
-  // but disallow DR and offlining (5008695).
-  if (FLAG_SET_CMDLINE(BindGCTaskThreadsToCPUs, true) != JVMFlag::SUCCESS) {
-    return JNI_EINVAL;
-  }
-
   return JNI_OK;
 }