Mercurial Mercurial > jdk-sandbox / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6888847: TaskQueue needs release_store() for correctness on RMO machines
authorbobv
Wed, 07 Oct 2009 09:48:42 -0400
changeset 4027 1c62fbaf6b68
parent 4026 10386ea70fe5
child 4028 be6959017765
6888847: TaskQueue needs release_store() for correctness on RMO machines Summary: See title. Reviewed-by: jmasa, ysr, jcoomes, iveresov, tonyp
hotspot/src/share/vm/utilities/taskqueue.hpp file | annotate | diff | comparison | revisions 
--- a/hotspot/src/share/vm/utilities/taskqueue.hpp	Wed Oct 07 10:09:57 2009 -0400
+++ b/hotspot/src/share/vm/utilities/taskqueue.hpp	Wed Oct 07 09:48:42 2009 -0400
@@ -207,7 +207,7 @@
     // Actually means 0, so do the push.
     uint localBot = _bottom;
     _elems[localBot] = t;
-    _bottom = increment_index(localBot);
+    OrderAccess::release_store(&_bottom, increment_index(localBot));
     return true;
   }
   return false;
@@ -485,7 +485,7 @@
   assert((dirty_n_elems >= 0) && (dirty_n_elems < N), "n_elems out of range.");
   if (dirty_n_elems < max_elems()) {
     _elems[localBot] = t;
-    _bottom = increment_index(localBot);
+    OrderAccess::release_store(&_bottom, increment_index(localBot));
     return true;
   } else {
     return push_slow(t, dirty_n_elems);
jdk-sandbox