langtools/src/share/classes/com/sun/tools/doclint/Checker.java
author jjg
Mon, 14 Oct 2013 12:38:09 -0700
changeset 21017 f61558e07e14
parent 20256 9154c5cc0d9f
child 21500 475e59d3b40c
permissions -rw-r--r--
8026368: doclint does not report empty tags when tag closed implicitly Reviewed-by: darcy
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     1
/*
15359
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
     2
 * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved.
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     4
 *
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    10
 *
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    15
 * accompanied this code).
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    16
 *
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    20
 *
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    23
 * questions.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    24
 */
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    25
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    26
package com.sun.tools.doclint;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    27
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    28
import java.io.IOException;
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    29
import java.io.StringWriter;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    30
import java.net.URI;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    31
import java.net.URISyntaxException;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    32
import java.util.Deque;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    33
import java.util.EnumSet;
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
    34
import java.util.HashMap;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    35
import java.util.HashSet;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    36
import java.util.LinkedList;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    37
import java.util.List;
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
    38
import java.util.Map;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    39
import java.util.Set;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    40
import java.util.regex.Matcher;
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    41
import java.util.regex.Pattern;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    42
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    43
import javax.lang.model.element.Element;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    44
import javax.lang.model.element.ElementKind;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    45
import javax.lang.model.element.ExecutableElement;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    46
import javax.lang.model.element.Name;
20255
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
    47
import javax.lang.model.element.VariableElement;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    48
import javax.lang.model.type.TypeKind;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    49
import javax.lang.model.type.TypeMirror;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    50
import javax.tools.Diagnostic.Kind;
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
    51
import javax.tools.JavaFileObject;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    52
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    53
import com.sun.source.doctree.AttributeTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    54
import com.sun.source.doctree.AuthorTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    55
import com.sun.source.doctree.DocCommentTree;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    56
import com.sun.source.doctree.DocRootTree;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    57
import com.sun.source.doctree.DocTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    58
import com.sun.source.doctree.EndElementTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    59
import com.sun.source.doctree.EntityTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    60
import com.sun.source.doctree.ErroneousTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    61
import com.sun.source.doctree.IdentifierTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    62
import com.sun.source.doctree.InheritDocTree;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    63
import com.sun.source.doctree.LinkTree;
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    64
import com.sun.source.doctree.LiteralTree;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    65
import com.sun.source.doctree.ParamTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    66
import com.sun.source.doctree.ReferenceTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    67
import com.sun.source.doctree.ReturnTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    68
import com.sun.source.doctree.SerialDataTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    69
import com.sun.source.doctree.SerialFieldTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    70
import com.sun.source.doctree.SinceTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    71
import com.sun.source.doctree.StartElementTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    72
import com.sun.source.doctree.TextTree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    73
import com.sun.source.doctree.ThrowsTree;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    74
import com.sun.source.doctree.ValueTree;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    75
import com.sun.source.doctree.VersionTree;
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
    76
import com.sun.source.util.DocTreePath;
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
    77
import com.sun.source.util.DocTreePathScanner;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    78
import com.sun.source.util.TreePath;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    79
import com.sun.tools.doclint.HtmlTag.AttrKind;
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
    80
import com.sun.tools.javac.tree.DocPretty;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    81
import static com.sun.tools.doclint.Messages.Group.*;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    82
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    83
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    84
/**
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    85
 * Validate a doc comment.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    86
 *
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    87
 * <p><b>This is NOT part of any supported API.
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    88
 * If you write code that depends on this, you do so at your own
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    89
 * risk.  This code and its internal interfaces are subject to change
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    90
 * or deletion without notice.</b></p>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    91
 */
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
    92
public class Checker extends DocTreePathScanner<Void, Void> {
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    93
    final Env env;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    94
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
    95
    Set<Element> foundParams = new HashSet<>();
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
    96
    Set<TypeMirror> foundThrows = new HashSet<>();
20254
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
    97
    Map<Element, Set<String>> foundAnchors = new HashMap<>();
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    98
    boolean foundInheritDoc = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
    99
    boolean foundReturn = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   100
15370
c1c9a9e11b26 8006263: Supplementary test cases needed for doclint
jjg
parents: 15366
diff changeset
   101
    public enum Flag {
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   102
        TABLE_HAS_CAPTION,
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   103
        HAS_ELEMENT,
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   104
        HAS_INLINE_TAG,
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   105
        HAS_TEXT,
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   106
        REPORTED_BAD_INLINE
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   107
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   108
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   109
    static class TagStackItem {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   110
        final DocTree tree; // typically, but not always, StartElementTree
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   111
        final HtmlTag tag;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   112
        final Set<HtmlTag.Attr> attrs;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   113
        final Set<Flag> flags;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   114
        TagStackItem(DocTree tree, HtmlTag tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   115
            this.tree = tree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   116
            this.tag = tag;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   117
            attrs = EnumSet.noneOf(HtmlTag.Attr.class);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   118
            flags = EnumSet.noneOf(Flag.class);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   119
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   120
        @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   121
        public String toString() {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   122
            return String.valueOf(tag);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   123
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   124
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   125
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   126
    private Deque<TagStackItem> tagStack; // TODO: maybe want to record starting tree as well
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   127
    private HtmlTag currHeaderTag;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   128
16799
fbe4d27b8791 8006346: doclint should make allowance for headers generated by standard doclet
jjg
parents: 16562
diff changeset
   129
    private final int implicitHeaderLevel;
fbe4d27b8791 8006346: doclint should make allowance for headers generated by standard doclet
jjg
parents: 16562
diff changeset
   130
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   131
    // <editor-fold defaultstate="collapsed" desc="Top level">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   132
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   133
    Checker(Env env) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   134
        env.getClass();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   135
        this.env = env;
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   136
        tagStack = new LinkedList<>();
16799
fbe4d27b8791 8006346: doclint should make allowance for headers generated by standard doclet
jjg
parents: 16562
diff changeset
   137
        implicitHeaderLevel = env.implicitHeaderLevel;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   138
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   139
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   140
    public Void scan(DocCommentTree tree, TreePath p) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   141
        env.setCurrent(p, tree);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   142
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   143
        boolean isOverridingMethod = !env.currOverriddenMethods.isEmpty();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   144
19123
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   145
        if (p.getLeaf() == p.getCompilationUnit()) {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   146
            // If p points to a compilation unit, the implied declaration is the
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   147
            // package declaration (if any) for the compilation unit.
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   148
            // Handle this case specially, because doc comments are only
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   149
            // expected in package-info files.
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   150
            JavaFileObject fo = p.getCompilationUnit().getSourceFile();
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   151
            boolean isPkgInfo = fo.isNameCompatible("package-info", JavaFileObject.Kind.SOURCE);
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   152
            if (tree == null) {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   153
                if (isPkgInfo)
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   154
                    reportMissing("dc.missing.comment");
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   155
                return null;
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   156
            } else {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   157
                if (!isPkgInfo)
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   158
                    reportReference("dc.unexpected.comment");
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   159
            }
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   160
        } else {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   161
            if (tree == null) {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   162
                if (!isSynthetic() && !isOverridingMethod)
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   163
                    reportMissing("dc.missing.comment");
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   164
                return null;
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   165
            }
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   166
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   167
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   168
        tagStack.clear();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   169
        currHeaderTag = null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   170
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   171
        foundParams.clear();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   172
        foundThrows.clear();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   173
        foundInheritDoc = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   174
        foundReturn = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   175
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   176
        scan(new DocTreePath(p, tree), null);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   177
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   178
        if (!isOverridingMethod) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   179
            switch (env.currElement.getKind()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   180
                case METHOD:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   181
                case CONSTRUCTOR: {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   182
                    ExecutableElement ee = (ExecutableElement) env.currElement;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   183
                    checkParamsDocumented(ee.getTypeParameters());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   184
                    checkParamsDocumented(ee.getParameters());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   185
                    switch (ee.getReturnType().getKind()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   186
                        case VOID:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   187
                        case NONE:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   188
                            break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   189
                        default:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   190
                            if (!foundReturn
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   191
                                    && !foundInheritDoc
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   192
                                    && !env.types.isSameType(ee.getReturnType(), env.java_lang_Void)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   193
                                reportMissing("dc.missing.return");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   194
                            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   195
                    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   196
                    checkThrowsDocumented(ee.getThrownTypes());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   197
                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   198
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   199
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   200
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   201
        return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   202
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   203
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   204
    private void reportMissing(String code, Object... args) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   205
        env.messages.report(MISSING, Kind.WARNING, env.currPath.getLeaf(), code, args);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   206
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   207
19123
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   208
    private void reportReference(String code, Object... args) {
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   209
        env.messages.report(REFERENCE, Kind.WARNING, env.currPath.getLeaf(), code, args);
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   210
    }
50733e28eaca 8021215: javac gives incorrect doclint warnings on normal package statements
jjg
parents: 19120
diff changeset
   211
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   212
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   213
    public Void visitDocComment(DocCommentTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   214
        super.visitDocComment(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   215
        for (TagStackItem tsi: tagStack) {
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   216
            warnIfEmpty(tsi, null);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   217
            if (tsi.tree.getKind() == DocTree.Kind.START_ELEMENT
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   218
                    && tsi.tag.endKind == HtmlTag.EndKind.REQUIRED) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   219
                StartElementTree t = (StartElementTree) tsi.tree;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   220
                env.messages.error(HTML, t, "dc.tag.not.closed", t.getName());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   221
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   222
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   223
        return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   224
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   225
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   226
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   227
    // <editor-fold defaultstate="collapsed" desc="Text and entities.">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   228
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   229
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   230
    public Void visitText(TextTree tree, Void ignore) {
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   231
        if (hasNonWhitespace(tree)) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   232
            checkAllowsText(tree);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   233
            markEnclosingTag(Flag.HAS_TEXT);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   234
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   235
        return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   236
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   237
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   238
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   239
    public Void visitEntity(EntityTree tree, Void ignore) {
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   240
        checkAllowsText(tree);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   241
        markEnclosingTag(Flag.HAS_TEXT);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   242
        String name = tree.getName().toString();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   243
        if (name.startsWith("#")) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   244
            int v = name.toLowerCase().startsWith("#x")
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   245
                    ? Integer.parseInt(name.substring(2), 16)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   246
                    : Integer.parseInt(name.substring(1), 10);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   247
            if (!Entity.isValid(v)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   248
                env.messages.error(HTML, tree, "dc.entity.invalid", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   249
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   250
        } else if (!Entity.isValid(name)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   251
            env.messages.error(HTML, tree, "dc.entity.invalid", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   252
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   253
        return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   254
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   255
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   256
    void checkAllowsText(DocTree tree) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   257
        TagStackItem top = tagStack.peek();
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   258
        if (top != null
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   259
                && top.tree.getKind() == DocTree.Kind.START_ELEMENT
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   260
                && !top.tag.acceptsText()) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   261
            if (top.flags.add(Flag.REPORTED_BAD_INLINE)) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   262
                env.messages.error(HTML, tree, "dc.text.not.allowed",
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   263
                        ((StartElementTree) top.tree).getName());
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   264
            }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   265
        }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   266
    }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   267
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   268
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   269
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   270
    // <editor-fold defaultstate="collapsed" desc="HTML elements">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   271
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   272
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   273
    public Void visitStartElement(StartElementTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   274
        final Name treeName = tree.getName();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   275
        final HtmlTag t = HtmlTag.get(treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   276
        if (t == null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   277
            env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   278
        } else {
15707
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   279
            boolean done = false;
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   280
            for (TagStackItem tsi: tagStack) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   281
                if (tsi.tag.accepts(t)) {
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   282
                    while (tagStack.peek() != tsi) {
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   283
                        warnIfEmpty(tagStack.peek(), null);
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   284
                        tagStack.pop();
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   285
                    }
15707
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   286
                    done = true;
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   287
                    break;
15707
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   288
                } else if (tsi.tag.endKind != HtmlTag.EndKind.OPTIONAL) {
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   289
                    done = true;
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   290
                    break;
15707
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   291
                }
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   292
            }
7b2411328a5c 8007566: DocLint too aggressive with not allowed here: <p>
jjg
parents: 15371
diff changeset
   293
            if (!done && HtmlTag.BODY.accepts(t)) {
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   294
                while (!tagStack.isEmpty()) {
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   295
                    warnIfEmpty(tagStack.peek(), null);
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   296
                    tagStack.pop();
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   297
                }
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   298
            }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   299
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   300
            markEnclosingTag(Flag.HAS_ELEMENT);
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   301
            checkStructure(tree, t);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   302
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   303
            // tag specific checks
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   304
            switch (t) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   305
                // check for out of sequence headers, such as <h1>...</h1>  <h3>...</h3>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   306
                case H1: case H2: case H3: case H4: case H5: case H6:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   307
                    checkHeader(tree, t);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   308
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   309
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   310
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   311
            if (t.flags.contains(HtmlTag.Flag.NO_NEST)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   312
                for (TagStackItem i: tagStack) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   313
                    if (t == i.tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   314
                        env.messages.warning(HTML, tree, "dc.tag.nested.not.allowed", treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   315
                        break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   316
                    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   317
                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   318
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   319
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   320
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   321
        // check for self closing tags, such as <a id="name"/>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   322
        if (tree.isSelfClosing()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   323
            env.messages.error(HTML, tree, "dc.tag.self.closing", treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   324
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   325
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   326
        try {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   327
            TagStackItem parent = tagStack.peek();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   328
            TagStackItem top = new TagStackItem(tree, t);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   329
            tagStack.push(top);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   330
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   331
            super.visitStartElement(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   332
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   333
            // handle attributes that may or may not have been found in start element
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   334
            if (t != null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   335
                switch (t) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   336
                    case CAPTION:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   337
                        if (parent != null && parent.tag == HtmlTag.TABLE)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   338
                            parent.flags.add(Flag.TABLE_HAS_CAPTION);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   339
                        break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   340
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   341
                    case IMG:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   342
                        if (!top.attrs.contains(HtmlTag.Attr.ALT))
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   343
                            env.messages.error(ACCESSIBILITY, tree, "dc.no.alt.attr.for.image");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   344
                        break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   345
                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   346
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   347
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   348
            return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   349
        } finally {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   350
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   351
            if (t == null || t.endKind == HtmlTag.EndKind.NONE)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   352
                tagStack.pop();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   353
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   354
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   355
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   356
    private void checkStructure(StartElementTree tree, HtmlTag t) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   357
        Name treeName = tree.getName();
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   358
        TagStackItem top = tagStack.peek();
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   359
        switch (t.blockType) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   360
            case BLOCK:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   361
                if (top == null || top.tag.accepts(t))
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   362
                    return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   363
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   364
                switch (top.tree.getKind()) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   365
                    case START_ELEMENT: {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   366
                        if (top.tag.blockType == HtmlTag.BlockType.INLINE) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   367
                            Name name = ((StartElementTree) top.tree).getName();
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   368
                            env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.element",
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   369
                                    treeName, name);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   370
                            return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   371
                        }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   372
                    }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   373
                    break;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   374
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   375
                    case LINK:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   376
                    case LINK_PLAIN: {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   377
                        String name = top.tree.getKind().tagName;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   378
                        env.messages.error(HTML, tree, "dc.tag.not.allowed.inline.tag",
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   379
                                treeName, name);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   380
                        return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   381
                    }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   382
                }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   383
                break;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   384
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   385
            case INLINE:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   386
                if (top == null || top.tag.accepts(t))
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   387
                    return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   388
                break;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   389
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   390
            case LIST_ITEM:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   391
            case TABLE_ITEM:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   392
                if (top != null) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   393
                    // reset this flag so subsequent bad inline content gets reported
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   394
                    top.flags.remove(Flag.REPORTED_BAD_INLINE);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   395
                    if (top.tag.accepts(t))
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   396
                        return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   397
                }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   398
                break;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   399
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   400
            case OTHER:
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   401
                env.messages.error(HTML, tree, "dc.tag.not.allowed", treeName);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   402
                return;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   403
        }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   404
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   405
        env.messages.error(HTML, tree, "dc.tag.not.allowed.here", treeName);
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   406
    }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   407
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   408
    private void checkHeader(StartElementTree tree, HtmlTag tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   409
        // verify the new tag
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   410
        if (getHeaderLevel(tag) > getHeaderLevel(currHeaderTag) + 1) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   411
            if (currHeaderTag == null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   412
                env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.1", tag);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   413
            } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   414
                env.messages.error(ACCESSIBILITY, tree, "dc.tag.header.sequence.2",
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   415
                    tag, currHeaderTag);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   416
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   417
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   418
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   419
        currHeaderTag = tag;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   420
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   421
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   422
    private int getHeaderLevel(HtmlTag tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   423
        if (tag == null)
16799
fbe4d27b8791 8006346: doclint should make allowance for headers generated by standard doclet
jjg
parents: 16562
diff changeset
   424
            return implicitHeaderLevel;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   425
        switch (tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   426
            case H1: return 1;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   427
            case H2: return 2;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   428
            case H3: return 3;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   429
            case H4: return 4;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   430
            case H5: return 5;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   431
            case H6: return 6;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   432
            default: throw new IllegalArgumentException();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   433
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   434
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   435
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   436
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   437
    public Void visitEndElement(EndElementTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   438
        final Name treeName = tree.getName();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   439
        final HtmlTag t = HtmlTag.get(treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   440
        if (t == null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   441
            env.messages.error(HTML, tree, "dc.tag.unknown", treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   442
        } else if (t.endKind == HtmlTag.EndKind.NONE) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   443
            env.messages.error(HTML, tree, "dc.tag.end.not.permitted", treeName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   444
        } else {
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   445
            boolean done = false;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   446
            while (!tagStack.isEmpty()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   447
                TagStackItem top = tagStack.peek();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   448
                if (t == top.tag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   449
                    switch (t) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   450
                        case TABLE:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   451
                            if (!top.attrs.contains(HtmlTag.Attr.SUMMARY)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   452
                                    && !top.flags.contains(Flag.TABLE_HAS_CAPTION)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   453
                                env.messages.error(ACCESSIBILITY, tree,
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   454
                                        "dc.no.summary.or.caption.for.table");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   455
                            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   456
                    }
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   457
                    warnIfEmpty(top, tree);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   458
                    tagStack.pop();
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   459
                    done = true;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   460
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   461
                } else if (top.tag == null || top.tag.endKind != HtmlTag.EndKind.REQUIRED) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   462
                    tagStack.pop();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   463
                } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   464
                    boolean found = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   465
                    for (TagStackItem si: tagStack) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   466
                        if (si.tag == t) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   467
                            found = true;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   468
                            break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   469
                        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   470
                    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   471
                    if (found && top.tree.getKind() == DocTree.Kind.START_ELEMENT) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   472
                        env.messages.error(HTML, top.tree, "dc.tag.start.unmatched",
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   473
                                ((StartElementTree) top.tree).getName());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   474
                        tagStack.pop();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   475
                    } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   476
                        env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   477
                        done = true;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   478
                        break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   479
                    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   480
                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   481
            }
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   482
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   483
            if (!done && tagStack.isEmpty()) {
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   484
                env.messages.error(HTML, tree, "dc.tag.end.unexpected", treeName);
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   485
            }
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   486
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   487
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   488
        return super.visitEndElement(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   489
    }
21017
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   490
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   491
    void warnIfEmpty(TagStackItem tsi, DocTree endTree) {
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   492
        if (tsi.tag != null && tsi.tree instanceof StartElementTree) {
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   493
            if (tsi.tag.flags.contains(HtmlTag.Flag.EXPECT_CONTENT)
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   494
                    && !tsi.flags.contains(Flag.HAS_TEXT)
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   495
                    && !tsi.flags.contains(Flag.HAS_ELEMENT)
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   496
                    && !tsi.flags.contains(Flag.HAS_INLINE_TAG)) {
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   497
                DocTree tree = (endTree != null) ? endTree : tsi.tree;
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   498
                Name treeName = ((StartElementTree) tsi.tree).getName();
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   499
                env.messages.warning(HTML, tree, "dc.tag.empty", treeName);
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   500
            }
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   501
        }
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   502
    }
f61558e07e14 8026368: doclint does not report empty tags when tag closed implicitly
jjg
parents: 20256
diff changeset
   503
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   504
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   505
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   506
    // <editor-fold defaultstate="collapsed" desc="HTML attributes">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   507
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   508
    @Override @SuppressWarnings("fallthrough")
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   509
    public Void visitAttribute(AttributeTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   510
        HtmlTag currTag = tagStack.peek().tag;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   511
        if (currTag != null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   512
            Name name = tree.getName();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   513
            HtmlTag.Attr attr = currTag.getAttr(name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   514
            if (attr != null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   515
                boolean first = tagStack.peek().attrs.add(attr);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   516
                if (!first)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   517
                    env.messages.error(HTML, tree, "dc.attr.repeated", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   518
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   519
            AttrKind k = currTag.getAttrKind(name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   520
            switch (k) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   521
                case OK:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   522
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   523
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   524
                case INVALID:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   525
                    env.messages.error(HTML, tree, "dc.attr.unknown", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   526
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   527
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   528
                case OBSOLETE:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   529
                    env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   530
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   531
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   532
                case USE_CSS:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   533
                    env.messages.warning(ACCESSIBILITY, tree, "dc.attr.obsolete.use.css", name);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   534
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   535
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   536
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   537
            if (attr != null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   538
                switch (attr) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   539
                    case NAME:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   540
                        if (currTag != HtmlTag.A) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   541
                            break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   542
                        }
15359
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   543
                        // fallthrough
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   544
                    case ID:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   545
                        String value = getAttrValue(tree);
15359
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   546
                        if (value == null) {
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   547
                            env.messages.error(HTML, tree, "dc.anchor.value.missing");
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   548
                        } else {
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   549
                            if (!validName.matcher(value).matches()) {
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   550
                                env.messages.error(HTML, tree, "dc.invalid.anchor", value);
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   551
                            }
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   552
                            if (!checkAnchor(value)) {
15359
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   553
                                env.messages.error(HTML, tree, "dc.anchor.already.defined", value);
a73dcb8dcbae 8006224: Doclint NPE for attribute with no value
jjg
parents: 14952
diff changeset
   554
                            }
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   555
                        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   556
                        break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   557
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   558
                    case HREF:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   559
                        if (currTag == HtmlTag.A) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   560
                            String v = getAttrValue(tree);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   561
                            if (v == null || v.isEmpty()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   562
                                env.messages.error(HTML, tree, "dc.attr.lacks.value");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   563
                            } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   564
                                Matcher m = docRoot.matcher(v);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   565
                                if (m.matches()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   566
                                    String rest = m.group(2);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   567
                                    if (!rest.isEmpty())
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   568
                                        checkURI(tree, rest);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   569
                                } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   570
                                    checkURI(tree, v);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   571
                                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   572
                            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   573
                        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   574
                        break;
18001
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   575
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   576
                    case VALUE:
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   577
                        if (currTag == HtmlTag.LI) {
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   578
                            String v = getAttrValue(tree);
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   579
                            if (v == null || v.isEmpty()) {
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   580
                                env.messages.error(HTML, tree, "dc.attr.lacks.value");
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   581
                            } else if (!validNumber.matcher(v).matches()) {
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   582
                                env.messages.error(HTML, tree, "dc.attr.not.number");
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   583
                            }
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   584
                        }
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   585
                        break;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   586
                }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   587
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   588
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   589
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   590
        // TODO: basic check on value
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   591
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   592
        return super.visitAttribute(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   593
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   594
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   595
    private boolean checkAnchor(String name) {
20254
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   596
        Element e = getEnclosingPackageOrClass(env.currElement);
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   597
        if (e == null)
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   598
            return true;
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   599
        Set<String> set = foundAnchors.get(e);
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   600
        if (set == null)
20254
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   601
            foundAnchors.put(e, set = new HashSet<>());
19120
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   602
        return set.add(name);
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   603
    }
7766f69bffc7 8020313: doclint doesn't reset HTML anchors correctly
jjg
parents: 18001
diff changeset
   604
20254
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   605
    private Element getEnclosingPackageOrClass(Element e) {
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   606
        while (e != null) {
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   607
            switch (e.getKind()) {
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   608
                case CLASS:
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   609
                case ENUM:
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   610
                case INTERFACE:
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   611
                case PACKAGE:
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   612
                    return e;
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   613
                default:
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   614
                    e = e.getEnclosingElement();
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   615
            }
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   616
        }
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   617
        return e;
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   618
    }
8246fe4d6638 8025246: [doclint] doclint is showing error on anchor already defined when it's not
jjg
parents: 19125
diff changeset
   619
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   620
    // http://www.w3.org/TR/html401/types.html#type-name
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   621
    private static final Pattern validName = Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   622
18001
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   623
    private static final Pattern validNumber = Pattern.compile("-?[0-9]+");
e6193c14cc7e 8013405: DocLint should support <LI value="value">
jjg
parents: 17549
diff changeset
   624
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   625
    // pattern to remove leading {@docRoot}/?
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   626
    private static final Pattern docRoot = Pattern.compile("(?i)(\\{@docRoot *\\}/?)?(.*)");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   627
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   628
    private String getAttrValue(AttributeTree tree) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   629
        if (tree.getValue() == null)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   630
            return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   631
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   632
        StringWriter sw = new StringWriter();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   633
        try {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   634
            new DocPretty(sw).print(tree.getValue());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   635
        } catch (IOException e) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   636
            // cannot happen
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   637
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   638
        // ignore potential use of entities for now
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   639
        return sw.toString();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   640
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   641
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   642
    private void checkURI(AttributeTree tree, String uri) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   643
        try {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   644
            URI u = new URI(uri);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   645
        } catch (URISyntaxException e) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   646
            env.messages.error(HTML, tree, "dc.invalid.uri", uri);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   647
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   648
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   649
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   650
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   651
    // <editor-fold defaultstate="collapsed" desc="javadoc tags">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   652
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   653
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   654
    public Void visitAuthor(AuthorTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   655
        warnIfEmpty(tree, tree.getName());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   656
        return super.visitAuthor(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   657
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   658
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   659
    @Override
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   660
    public Void visitDocRoot(DocRootTree tree, Void ignore) {
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   661
        markEnclosingTag(Flag.HAS_INLINE_TAG);
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   662
        return super.visitDocRoot(tree, ignore);
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   663
    }
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   664
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   665
    @Override
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   666
    public Void visitInheritDoc(InheritDocTree tree, Void ignore) {
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   667
        markEnclosingTag(Flag.HAS_INLINE_TAG);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   668
        // TODO: verify on overridden method
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   669
        foundInheritDoc = true;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   670
        return super.visitInheritDoc(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   671
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   672
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   673
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   674
    public Void visitLink(LinkTree tree, Void ignore) {
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   675
        markEnclosingTag(Flag.HAS_INLINE_TAG);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   676
        // simulate inline context on tag stack
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   677
        HtmlTag t = (tree.getKind() == DocTree.Kind.LINK)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   678
                ? HtmlTag.CODE : HtmlTag.SPAN;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   679
        tagStack.push(new TagStackItem(tree, t));
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   680
        try {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   681
            return super.visitLink(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   682
        } finally {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   683
            tagStack.pop();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   684
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   685
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   686
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   687
    @Override
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   688
    public Void visitLiteral(LiteralTree tree, Void ignore) {
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   689
        markEnclosingTag(Flag.HAS_INLINE_TAG);
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   690
        if (tree.getKind() == DocTree.Kind.CODE) {
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   691
            for (TagStackItem tsi: tagStack) {
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   692
                if (tsi.tag == HtmlTag.CODE) {
15366
545307ec740c 8006228: Doclint doesn't detect <code> {@code nested inline} </code>
jjg
parents: 15363
diff changeset
   693
                    env.messages.warning(HTML, tree, "dc.tag.code.within.code");
15363
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   694
                    break;
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   695
                }
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   696
            }
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   697
        }
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   698
        return super.visitLiteral(tree, ignore);
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   699
    }
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   700
5c503b455dc8 8006236: doclint: structural issue hidden
jjg
parents: 15359
diff changeset
   701
    @Override
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   702
    @SuppressWarnings("fallthrough")
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   703
    public Void visitParam(ParamTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   704
        boolean typaram = tree.isTypeParameter();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   705
        IdentifierTree nameTree = tree.getName();
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   706
        Element paramElement = nameTree != null ? env.trees.getElement(new DocTreePath(getCurrentPath(), nameTree)) : null;
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   707
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   708
        if (paramElement == null) {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   709
            switch (env.currElement.getKind()) {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   710
                case CLASS: case INTERFACE: {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   711
                    if (!typaram) {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   712
                        env.messages.error(REFERENCE, tree, "dc.invalid.param");
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   713
                        break;
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   714
                    }
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   715
                }
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   716
                case METHOD: case CONSTRUCTOR: {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   717
                    env.messages.error(REFERENCE, nameTree, "dc.param.name.not.found");
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   718
                    break;
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   719
                }
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   720
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   721
                default:
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   722
                    env.messages.error(REFERENCE, tree, "dc.invalid.param");
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   723
                    break;
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   724
            }
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   725
        } else {
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   726
            foundParams.add(paramElement);
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   727
        }
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   728
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   729
        warnIfEmpty(tree, tree.getDescription());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   730
        return super.visitParam(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   731
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   732
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   733
    private void checkParamsDocumented(List<? extends Element> list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   734
        if (foundInheritDoc)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   735
            return;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   736
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   737
        for (Element e: list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   738
            if (!foundParams.contains(e)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   739
                CharSequence paramName = (e.getKind() == ElementKind.TYPE_PARAMETER)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   740
                        ? "<" + e.getSimpleName() + ">"
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   741
                        : e.getSimpleName();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   742
                reportMissing("dc.missing.param", paramName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   743
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   744
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   745
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   746
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   747
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   748
    public Void visitReference(ReferenceTree tree, Void ignore) {
20256
9154c5cc0d9f 8002154: [doclint] doclint should check for issues which are errors in javadoc
jjg
parents: 20255
diff changeset
   749
        String sig = tree.getSignature();
9154c5cc0d9f 8002154: [doclint] doclint should check for issues which are errors in javadoc
jjg
parents: 20255
diff changeset
   750
        if (sig.contains("<") || sig.contains(">"))
9154c5cc0d9f 8002154: [doclint] doclint should check for issues which are errors in javadoc
jjg
parents: 20255
diff changeset
   751
            env.messages.error(REFERENCE, tree, "dc.type.arg.not.allowed");
9154c5cc0d9f 8002154: [doclint] doclint should check for issues which are errors in javadoc
jjg
parents: 20255
diff changeset
   752
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   753
        Element e = env.trees.getElement(getCurrentPath());
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   754
        if (e == null)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   755
            env.messages.error(REFERENCE, tree, "dc.ref.not.found");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   756
        return super.visitReference(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   757
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   758
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   759
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   760
    public Void visitReturn(ReturnTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   761
        Element e = env.trees.getElement(env.currPath);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   762
        if (e.getKind() != ElementKind.METHOD
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   763
                || ((ExecutableElement) e).getReturnType().getKind() == TypeKind.VOID)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   764
            env.messages.error(REFERENCE, tree, "dc.invalid.return");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   765
        foundReturn = true;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   766
        warnIfEmpty(tree, tree.getDescription());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   767
        return super.visitReturn(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   768
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   769
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   770
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   771
    public Void visitSerialData(SerialDataTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   772
        warnIfEmpty(tree, tree.getDescription());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   773
        return super.visitSerialData(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   774
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   775
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   776
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   777
    public Void visitSerialField(SerialFieldTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   778
        warnIfEmpty(tree, tree.getDescription());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   779
        return super.visitSerialField(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   780
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   781
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   782
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   783
    public Void visitSince(SinceTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   784
        warnIfEmpty(tree, tree.getBody());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   785
        return super.visitSince(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   786
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   787
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   788
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   789
    public Void visitThrows(ThrowsTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   790
        ReferenceTree exName = tree.getExceptionName();
17549
65ea6f3b72d9 8009724: Enhance the DocTree API with DocTreePath
jlahoda
parents: 16799
diff changeset
   791
        Element ex = env.trees.getElement(new DocTreePath(getCurrentPath(), exName));
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   792
        if (ex == null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   793
            env.messages.error(REFERENCE, tree, "dc.ref.not.found");
19125
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   794
        } else if (isThrowable(ex.asType())) {
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   795
            switch (env.currElement.getKind()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   796
                case CONSTRUCTOR:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   797
                case METHOD:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   798
                    if (isCheckedException(ex.asType())) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   799
                        ExecutableElement ee = (ExecutableElement) env.currElement;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   800
                        checkThrowsDeclared(exName, ex.asType(), ee.getThrownTypes());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   801
                    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   802
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   803
                default:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   804
                    env.messages.error(REFERENCE, tree, "dc.invalid.throws");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   805
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   806
        } else {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   807
            env.messages.error(REFERENCE, tree, "dc.invalid.throws");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   808
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   809
        warnIfEmpty(tree, tree.getDescription());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   810
        return scan(tree.getDescription(), ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   811
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   812
19125
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   813
    private boolean isThrowable(TypeMirror tm) {
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   814
        switch (tm.getKind()) {
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   815
            case DECLARED:
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   816
            case TYPEVAR:
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   817
                return env.types.isAssignable(tm, env.java_lang_Throwable);
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   818
        }
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   819
        return false;
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   820
    }
db8cab0ecbd9 8020556: doclint does not check type variables for @throws
jjg
parents: 19123
diff changeset
   821
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   822
    private void checkThrowsDeclared(ReferenceTree tree, TypeMirror t, List<? extends TypeMirror> list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   823
        boolean found = false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   824
        for (TypeMirror tl : list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   825
            if (env.types.isAssignable(t, tl)) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   826
                foundThrows.add(tl);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   827
                found = true;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   828
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   829
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   830
        if (!found)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   831
            env.messages.error(REFERENCE, tree, "dc.exception.not.thrown", t);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   832
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   833
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   834
    private void checkThrowsDocumented(List<? extends TypeMirror> list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   835
        if (foundInheritDoc)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   836
            return;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   837
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   838
        for (TypeMirror tl: list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   839
            if (isCheckedException(tl) && !foundThrows.contains(tl))
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   840
                reportMissing("dc.missing.throws", tl);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   841
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   842
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   843
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   844
    @Override
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   845
    public Void visitValue(ValueTree tree, Void ignore) {
20255
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   846
        ReferenceTree ref = tree.getReference();
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   847
        if (ref == null || ref.getSignature().isEmpty()) {
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   848
            if (!isConstant(env.currElement))
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   849
                env.messages.error(REFERENCE, tree, "dc.value.not.allowed.here");
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   850
        } else {
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   851
            Element e = env.trees.getElement(new DocTreePath(getCurrentPath(), ref));
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   852
            if (!isConstant(e))
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   853
                env.messages.error(REFERENCE, tree, "dc.value.not.a.constant");
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   854
        }
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   855
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   856
        markEnclosingTag(Flag.HAS_INLINE_TAG);
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   857
        return super.visitValue(tree, ignore);
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   858
    }
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   859
20255
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   860
    private boolean isConstant(Element e) {
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   861
        if (e == null)
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   862
            return false;
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   863
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   864
        switch (e.getKind()) {
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   865
            case FIELD:
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   866
                Object value = ((VariableElement) e).getConstantValue();
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   867
                return (value != null); // can't distinguish "not a constant" from "constant is null"
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   868
            default:
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   869
                return false;
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   870
        }
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   871
    }
f8be1ea20e1a 8025272: doclint needs to check for valid usage of @value tag
jjg
parents: 20254
diff changeset
   872
16562
9f09744e221a 8010317: DocLint incorrectly reports some <pre> tags as empty
jjg
parents: 15707
diff changeset
   873
    @Override
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   874
    public Void visitVersion(VersionTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   875
        warnIfEmpty(tree, tree.getBody());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   876
        return super.visitVersion(tree, ignore);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   877
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   878
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   879
    @Override
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   880
    public Void visitErroneous(ErroneousTree tree, Void ignore) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   881
        env.messages.error(SYNTAX, tree, null, tree.getDiagnostic().getMessage(null));
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   882
        return null;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   883
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   884
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   885
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   886
    // <editor-fold defaultstate="collapsed" desc="Utility methods">
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   887
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   888
    private boolean isCheckedException(TypeMirror t) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   889
        return !(env.types.isAssignable(t, env.java_lang_Error)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   890
                || env.types.isAssignable(t, env.java_lang_RuntimeException));
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   891
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   892
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   893
    private boolean isSynthetic() {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   894
        switch (env.currElement.getKind()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   895
            case CONSTRUCTOR:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   896
                // A synthetic default constructor has the same pos as the
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   897
                // enclosing class
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   898
                TreePath p = env.currPath;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   899
                return env.getPos(p) == env.getPos(p.getParentPath());
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   900
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   901
        return false;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   902
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   903
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   904
    void markEnclosingTag(Flag flag) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   905
        TagStackItem top = tagStack.peek();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   906
        if (top != null)
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   907
            top.flags.add(flag);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   908
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   909
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   910
    String toString(TreePath p) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   911
        StringBuilder sb = new StringBuilder("TreePath[");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   912
        toString(p, sb);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   913
        sb.append("]");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   914
        return sb.toString();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   915
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   916
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   917
    void toString(TreePath p, StringBuilder sb) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   918
        TreePath parent = p.getParentPath();
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   919
        if (parent != null) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   920
            toString(parent, sb);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   921
            sb.append(",");
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   922
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   923
       sb.append(p.getLeaf().getKind()).append(":").append(env.getPos(p)).append(":S").append(env.getStartPos(p));
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   924
    }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   925
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   926
    void warnIfEmpty(DocTree tree, List<? extends DocTree> list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   927
        for (DocTree d: list) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   928
            switch (d.getKind()) {
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   929
                case TEXT:
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   930
                    if (hasNonWhitespace((TextTree) d))
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   931
                        return;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   932
                    break;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   933
                default:
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   934
                    return;
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   935
            }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   936
        }
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   937
        env.messages.warning(SYNTAX, tree, "dc.empty", tree.getKind().tagName);
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   938
    }
15371
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   939
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   940
    boolean hasNonWhitespace(TextTree tree) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   941
        String s = tree.getBody();
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   942
        for (int i = 0; i < s.length(); i++) {
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   943
            if (!Character.isWhitespace(s.charAt(i)))
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   944
                return true;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   945
        }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   946
        return false;
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   947
    }
8f719dc43e1f 8006251: doclint: incorrect position for diagnostic for illegal text in tags
jjg
parents: 15370
diff changeset
   948
14952
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   949
    // </editor-fold>
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   950
d0022ae20516 8004832: Add new doclint package
jjg
parents:
diff changeset
   951
}