src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/AssignSymbols.java
author attila
Wed, 20 Dec 2017 17:36:50 +0100
changeset 48354 c96d4c720995
parent 48334 fdefa410d655
permissions -rw-r--r--
8193371: Use Dynalink REMOVE operation in Nashorn Reviewed-by: hannesw, sundar
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     1
/*
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     2
 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     4
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    10
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    15
 * accompanied this code).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    16
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    20
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    23
 * questions.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    24
 */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    25
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    26
package jdk.nashorn.internal.codegen;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    27
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    28
import static jdk.nashorn.internal.codegen.CompilerConstants.ARGUMENTS;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    29
import static jdk.nashorn.internal.codegen.CompilerConstants.ARGUMENTS_VAR;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    30
import static jdk.nashorn.internal.codegen.CompilerConstants.CALLEE;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    31
import static jdk.nashorn.internal.codegen.CompilerConstants.EXCEPTION_PREFIX;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    32
import static jdk.nashorn.internal.codegen.CompilerConstants.ITERATOR_PREFIX;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    33
import static jdk.nashorn.internal.codegen.CompilerConstants.RETURN;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    34
import static jdk.nashorn.internal.codegen.CompilerConstants.SCOPE;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    35
import static jdk.nashorn.internal.codegen.CompilerConstants.SWITCH_TAG_PREFIX;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    36
import static jdk.nashorn.internal.codegen.CompilerConstants.THIS;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    37
import static jdk.nashorn.internal.codegen.CompilerConstants.VARARGS;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    38
import static jdk.nashorn.internal.ir.Symbol.HAS_OBJECT_VALUE;
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    39
import static jdk.nashorn.internal.ir.Symbol.IS_CONST;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    40
import static jdk.nashorn.internal.ir.Symbol.IS_FUNCTION_SELF;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    41
import static jdk.nashorn.internal.ir.Symbol.IS_GLOBAL;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    42
import static jdk.nashorn.internal.ir.Symbol.IS_INTERNAL;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    43
import static jdk.nashorn.internal.ir.Symbol.IS_LET;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    44
import static jdk.nashorn.internal.ir.Symbol.IS_PARAM;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    45
import static jdk.nashorn.internal.ir.Symbol.IS_PROGRAM_LEVEL;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    46
import static jdk.nashorn.internal.ir.Symbol.IS_SCOPE;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    47
import static jdk.nashorn.internal.ir.Symbol.IS_THIS;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    48
import static jdk.nashorn.internal.ir.Symbol.IS_VAR;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    49
import static jdk.nashorn.internal.ir.Symbol.KINDMASK;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    50
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    51
import java.util.ArrayDeque;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    52
import java.util.ArrayList;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    53
import java.util.Deque;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    54
import java.util.HashMap;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    55
import java.util.HashSet;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    56
import java.util.Iterator;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    57
import java.util.List;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    58
import java.util.ListIterator;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    59
import java.util.Map;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    60
import java.util.Set;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    61
import jdk.nashorn.internal.ir.AccessNode;
48354
c96d4c720995 8193371: Use Dynalink REMOVE operation in Nashorn
attila
parents: 48334
diff changeset
    62
import jdk.nashorn.internal.ir.BaseNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    63
import jdk.nashorn.internal.ir.BinaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    64
import jdk.nashorn.internal.ir.Block;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    65
import jdk.nashorn.internal.ir.CatchNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    66
import jdk.nashorn.internal.ir.Expression;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    67
import jdk.nashorn.internal.ir.ForNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    68
import jdk.nashorn.internal.ir.FunctionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    69
import jdk.nashorn.internal.ir.IdentNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    70
import jdk.nashorn.internal.ir.IndexNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    71
import jdk.nashorn.internal.ir.LexicalContextNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    72
import jdk.nashorn.internal.ir.LiteralNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    73
import jdk.nashorn.internal.ir.Node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    74
import jdk.nashorn.internal.ir.RuntimeNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    75
import jdk.nashorn.internal.ir.RuntimeNode.Request;
32781
d8f34ffbbc7a 8135190: Method code too large in Babel browser.js script
hannesw
parents: 32692
diff changeset
    76
import jdk.nashorn.internal.ir.Splittable;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    77
import jdk.nashorn.internal.ir.Statement;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    78
import jdk.nashorn.internal.ir.SwitchNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    79
import jdk.nashorn.internal.ir.Symbol;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    80
import jdk.nashorn.internal.ir.TryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    81
import jdk.nashorn.internal.ir.UnaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    82
import jdk.nashorn.internal.ir.VarNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    83
import jdk.nashorn.internal.ir.WithNode;
32888
24f99be3d5ab 8134502: introduce abstraction for basic NodeVisitor usage
attila
parents: 32781
diff changeset
    84
import jdk.nashorn.internal.ir.visitor.SimpleNodeVisitor;
30392
dc4a419b2982 8079362: Enforce best practices for Node token API usage
attila
parents: 29281
diff changeset
    85
import jdk.nashorn.internal.parser.TokenType;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    86
import jdk.nashorn.internal.runtime.Context;
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    87
import jdk.nashorn.internal.runtime.ECMAErrors;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    88
import jdk.nashorn.internal.runtime.ErrorManager;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    89
import jdk.nashorn.internal.runtime.JSErrorType;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    90
import jdk.nashorn.internal.runtime.ParserException;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
    91
import jdk.nashorn.internal.runtime.Source;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    92
import jdk.nashorn.internal.runtime.logging.DebugLogger;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    93
import jdk.nashorn.internal.runtime.logging.Loggable;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    94
import jdk.nashorn.internal.runtime.logging.Logger;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    95
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    96
/**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    97
 * This visitor assigns symbols to identifiers denoting variables. It does few more minor calculations that are only
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    98
 * possible after symbols have been assigned; such is the transformation of "delete" and "typeof" operators into runtime
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    99
 * nodes and counting of number of properties assigned to "this" in constructor functions. This visitor is also notable
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   100
 * for what it doesn't do, most significantly it does no type calculations as in JavaScript variables can change types
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   101
 * during runtime and as such symbols don't have types. Calculation of expression types is performed by a separate
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   102
 * visitor.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   103
 */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   104
@Logger(name="symbols")
32888
24f99be3d5ab 8134502: introduce abstraction for basic NodeVisitor usage
attila
parents: 32781
diff changeset
   105
final class AssignSymbols extends SimpleNodeVisitor implements Loggable {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   106
    private final DebugLogger log;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   107
    private final boolean     debug;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   108
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   109
    private static boolean isParamOrVar(final IdentNode identNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   110
        final Symbol symbol = identNode.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   111
        return symbol.isParam() || symbol.isVar();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   112
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   113
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   114
    private static String name(final Node node) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   115
        final String cn = node.getClass().getName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   116
        final int lastDot = cn.lastIndexOf('.');
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   117
        if (lastDot == -1) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   118
            return cn;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   119
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   120
        return cn.substring(lastDot + 1);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   121
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   122
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   123
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   124
     * Checks if various symbols that were provisionally marked as needing a slot ended up unused, and marks them as not
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   125
     * needing a slot after all.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   126
     * @param functionNode the function node
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   127
     * @return the passed in node, for easy chaining
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   128
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   129
    private static FunctionNode removeUnusedSlots(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   130
        if (!functionNode.needsCallee()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   131
            functionNode.compilerConstant(CALLEE).setNeedsSlot(false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   132
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   133
        if (!(functionNode.hasScopeBlock() || functionNode.needsParentScope())) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   134
            functionNode.compilerConstant(SCOPE).setNeedsSlot(false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   135
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   136
        // Named function expressions that end up not referencing themselves won't need a local slot for the self symbol.
27822
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   137
        if(functionNode.isNamedFunctionExpression() && !functionNode.usesSelfSymbol()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   138
            final Symbol selfSymbol = functionNode.getBody().getExistingSymbol(functionNode.getIdent().getName());
27822
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   139
            if(selfSymbol != null && selfSymbol.isFunctionSelf()) {
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   140
                selfSymbol.setNeedsSlot(false);
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   141
                selfSymbol.clearFlag(Symbol.IS_VAR);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   142
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   143
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   144
        return functionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   145
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   146
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   147
    private final Deque<Set<String>> thisProperties = new ArrayDeque<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   148
    private final Map<String, Symbol> globalSymbols = new HashMap<>(); //reuse the same global symbol
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   149
    private final Compiler compiler;
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   150
    private final boolean isOnDemand;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   151
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   152
    public AssignSymbols(final Compiler compiler) {
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   153
        this.compiler = compiler;
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   154
        this.log   = initLogger(compiler.getContext());
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   155
        this.debug = log.isEnabled();
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   156
        this.isOnDemand = compiler.isOnDemandCompilation();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   157
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   158
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   159
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   160
    public DebugLogger getLogger() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   161
        return log;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   162
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   163
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   164
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   165
    public DebugLogger initLogger(final Context context) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   166
        return context.getLogger(this.getClass());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   167
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   168
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   169
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   170
     * Define symbols for all variable declarations at the top of the function scope. This way we can get around
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   171
     * problems like
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   172
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   173
     * while (true) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   174
     *   break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   175
     *   if (true) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   176
     *     var s;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   177
     *   }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   178
     * }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   179
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   180
     * to an arbitrary nesting depth.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   181
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   182
     * see NASHORN-73
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   183
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   184
     * @param functionNode the FunctionNode we are entering
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   185
     * @param body the body of the FunctionNode we are entering
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   186
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   187
    private void acceptDeclarations(final FunctionNode functionNode, final Block body) {
27817
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   188
        // This visitor will assign symbol to all declared variables.
32888
24f99be3d5ab 8134502: introduce abstraction for basic NodeVisitor usage
attila
parents: 32781
diff changeset
   189
        body.accept(new SimpleNodeVisitor() {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   190
            @Override
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   191
            protected boolean enterDefault(final Node node) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   192
                // Don't bother visiting expressions; var is a statement, it can't be inside an expression.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   193
                // This will also prevent visiting nested functions (as FunctionNode is an expression).
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   194
                return !(node instanceof Expression);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   195
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   196
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   197
            @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   198
            public Node leaveVarNode(final VarNode varNode) {
27817
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   199
                final IdentNode ident  = varNode.getName();
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   200
                final boolean blockScoped = varNode.isBlockScoped();
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   201
                if (blockScoped && lc.inUnprotectedSwitchContext()) {
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   202
                    throwUnprotectedSwitchError(varNode);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   203
                }
27817
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   204
                final Block block = blockScoped ? lc.getCurrentBlock() : body;
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   205
                final Symbol symbol = defineSymbol(block, ident.getName(), ident, varNode.getSymbolFlags());
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   206
                if (varNode.isFunctionDeclaration()) {
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   207
                    symbol.setIsFunctionDeclaration();
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   208
                }
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   209
                return varNode.setName(ident.setSymbol(symbol));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   210
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   211
        });
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   212
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   213
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   214
    private IdentNode compilerConstantIdentifier(final CompilerConstants cc) {
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25238
diff changeset
   215
        return createImplicitIdentifier(cc.symbolName()).setSymbol(lc.getCurrentFunction().compilerConstant(cc));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   216
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   217
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   218
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   219
     * Creates an ident node for an implicit identifier within the function (one not declared in the script source
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   220
     * code). These identifiers are defined with function's token and finish.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   221
     * @param name the name of the identifier
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   222
     * @return an ident node representing the implicit identifier.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   223
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   224
    private IdentNode createImplicitIdentifier(final String name) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   225
        final FunctionNode fn = lc.getCurrentFunction();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   226
        return new IdentNode(fn.getToken(), fn.getFinish(), name);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   227
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   228
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   229
    private Symbol createSymbol(final String name, final int flags) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   230
        if ((flags & Symbol.KINDMASK) == IS_GLOBAL) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   231
            //reuse global symbols so they can be hashed
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   232
            Symbol global = globalSymbols.get(name);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   233
            if (global == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   234
                global = new Symbol(name, flags);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   235
                globalSymbols.put(name, global);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   236
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   237
            return global;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   238
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   239
        return new Symbol(name, flags);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   240
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   241
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   242
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   243
     * Creates a synthetic initializer for a variable (a var statement that doesn't occur in the source code). Typically
32534
b3ec7f3b3c2a 8136349: Typos patch for nashorn sources submitted on Sep 10, 2015
sundar
parents: 32435
diff changeset
   244
     * used to create assignment of {@code :callee} to the function name symbol in self-referential function
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   245
     * expressions as well as for assignment of {@code :arguments} to {@code arguments}.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   246
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   247
     * @param name the ident node identifying the variable to initialize
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   248
     * @param initConstant the compiler constant it is initialized to
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   249
     * @param fn the function node the assignment is for
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   250
     * @return a var node with the appropriate assignment
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   251
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   252
    private VarNode createSyntheticInitializer(final IdentNode name, final CompilerConstants initConstant, final FunctionNode fn) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   253
        final IdentNode init = compilerConstantIdentifier(initConstant);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   254
        assert init.getSymbol() != null && init.getSymbol().isBytecodeLocal();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   255
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   256
        final VarNode synthVar = new VarNode(fn.getLineNumber(), fn.getToken(), fn.getFinish(), name, init);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   257
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   258
        final Symbol nameSymbol = fn.getBody().getExistingSymbol(name.getName());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   259
        assert nameSymbol != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   260
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25238
diff changeset
   261
        return (VarNode)synthVar.setName(name.setSymbol(nameSymbol)).accept(this);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   262
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   263
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   264
    private FunctionNode createSyntheticInitializers(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   265
        final List<VarNode> syntheticInitializers = new ArrayList<>(2);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   266
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   267
        // Must visit the new var nodes in the context of the body. We could also just set the new statements into the
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   268
        // block and then revisit the entire block, but that seems to be too much double work.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   269
        final Block body = functionNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   270
        lc.push(body);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   271
        try {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   272
            if (functionNode.usesSelfSymbol()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   273
                // "var fn = :callee"
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   274
                syntheticInitializers.add(createSyntheticInitializer(functionNode.getIdent(), CALLEE, functionNode));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   275
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   276
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   277
            if (functionNode.needsArguments()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   278
                // "var arguments = :arguments"
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   279
                syntheticInitializers.add(createSyntheticInitializer(createImplicitIdentifier(ARGUMENTS_VAR.symbolName()),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   280
                        ARGUMENTS, functionNode));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   281
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   282
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   283
            if (syntheticInitializers.isEmpty()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   284
                return functionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   285
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   286
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   287
            for(final ListIterator<VarNode> it = syntheticInitializers.listIterator(); it.hasNext();) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   288
                it.set((VarNode)it.next().accept(this));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   289
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   290
        } finally {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   291
            lc.pop(body);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   292
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   293
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   294
        final List<Statement> stmts = body.getStatements();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   295
        final List<Statement> newStatements = new ArrayList<>(stmts.size() + syntheticInitializers.size());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   296
        newStatements.addAll(syntheticInitializers);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   297
        newStatements.addAll(stmts);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   298
        return functionNode.setBody(lc, body.setStatements(lc, newStatements));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   299
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   300
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   301
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   302
     * Defines a new symbol in the given block.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   303
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   304
     * @param block        the block in which to define the symbol
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   305
     * @param name         name of symbol.
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   306
     * @param origin       origin node
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   307
     * @param symbolFlags  Symbol flags.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   308
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   309
     * @return Symbol for given name or null for redefinition.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   310
     */
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   311
    private Symbol defineSymbol(final Block block, final String name, final Node origin, final int symbolFlags) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   312
        int    flags  = symbolFlags;
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   313
        final boolean isBlockScope = (flags & IS_LET) != 0 || (flags & IS_CONST) != 0;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   314
        final boolean isGlobal     = (flags & KINDMASK) == IS_GLOBAL;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   315
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   316
        Symbol symbol;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   317
        final FunctionNode function;
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   318
        if (isBlockScope) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   319
            // block scoped variables always live in current block, no need to look for existing symbols in parent blocks.
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   320
            symbol = block.getExistingSymbol(name);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   321
            function = lc.getCurrentFunction();
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   322
        } else {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   323
            symbol = findSymbol(block, name);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   324
            function = lc.getFunction(block);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   325
        }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   326
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   327
        // Global variables are implicitly always scope variables too.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   328
        if (isGlobal) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   329
            flags |= IS_SCOPE;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   330
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   331
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   332
        if (lc.getCurrentFunction().isProgram()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   333
            flags |= IS_PROGRAM_LEVEL;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   334
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   335
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   336
        final boolean isParam = (flags & KINDMASK) == IS_PARAM;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   337
        final boolean isVar =   (flags & KINDMASK) == IS_VAR;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   338
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   339
        if (symbol != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   340
            // Symbol was already defined. Check if it needs to be redefined.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   341
            if (isParam) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   342
                if (!isLocal(function, symbol)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   343
                    // Not defined in this function. Create a new definition.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   344
                    symbol = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   345
                } else if (symbol.isParam()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   346
                    // Duplicate parameter. Null return will force an error.
41924
d55f24e8953e 8156619: Unimplemented ES6 features should result in clear Error being thrown
hannesw
parents: 36696
diff changeset
   347
                    throwParserException(ECMAErrors.getMessage("syntax.error.duplicate.parameter", name), origin);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   348
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   349
            } else if (isVar) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   350
                if (isBlockScope) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   351
                    // Check redeclaration in same block
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   352
                    if (symbol.hasBeenDeclared()) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   353
                        throwParserException(ECMAErrors.getMessage("syntax.error.redeclare.variable", name), origin);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   354
                    } else {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   355
                        symbol.setHasBeenDeclared();
27814
96427359f4fe 8057691: Nashorn: let & const declarations are not shared between scripts
hannesw
parents: 27206
diff changeset
   356
                        // Set scope flag on top-level block scoped symbols
96427359f4fe 8057691: Nashorn: let & const declarations are not shared between scripts
hannesw
parents: 27206
diff changeset
   357
                        if (function.isProgram() && function.getBody() == block) {
96427359f4fe 8057691: Nashorn: let & const declarations are not shared between scripts
hannesw
parents: 27206
diff changeset
   358
                            symbol.setIsScope();
96427359f4fe 8057691: Nashorn: let & const declarations are not shared between scripts
hannesw
parents: 27206
diff changeset
   359
                        }
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   360
                    }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   361
                } else if ((flags & IS_INTERNAL) != 0) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   362
                    // Always create a new definition.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   363
                    symbol = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   364
                } else {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   365
                    // Found LET or CONST in parent scope of same function - s SyntaxError
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   366
                    if (symbol.isBlockScoped() && isLocal(lc.getCurrentFunction(), symbol)) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   367
                        throwParserException(ECMAErrors.getMessage("syntax.error.redeclare.variable", name), origin);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   368
                    }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   369
                    // Not defined in this function. Create a new definition.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   370
                    if (!isLocal(function, symbol) || symbol.less(IS_VAR)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   371
                        symbol = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   372
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   373
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   374
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   375
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   376
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   377
        if (symbol == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   378
            // If not found, then create a new one.
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   379
            final Block symbolBlock;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   380
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   381
            // Determine where to create it.
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   382
            if (isVar && ((flags & IS_INTERNAL) != 0 || isBlockScope)) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   383
                symbolBlock = block; //internal vars are always defined in the block closest to them
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   384
            } else if (isGlobal) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   385
                symbolBlock = lc.getOutermostFunction().getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   386
            } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   387
                symbolBlock = lc.getFunctionBody(function);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   388
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   389
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   390
            // Create and add to appropriate block.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   391
            symbol = createSymbol(name, flags);
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   392
            symbolBlock.putSymbol(symbol);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   393
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   394
            if ((flags & IS_SCOPE) == 0) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   395
                // Initial assumption; symbol can lose its slot later
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   396
                symbol.setNeedsSlot(true);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   397
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   398
        } else if (symbol.less(flags)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   399
            symbol.setFlags(flags);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   400
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   401
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   402
        return symbol;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   403
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   404
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   405
    private <T extends Node> T end(final T node) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   406
        return end(node, true);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   407
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   408
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   409
    private <T extends Node> T end(final T node, final boolean printNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   410
        if (debug) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   411
            final StringBuilder sb = new StringBuilder();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   412
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   413
            sb.append("[LEAVE ").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   414
                append(name(node)).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   415
                append("] ").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   416
                append(printNode ? node.toString() : "").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   417
                append(" in '").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   418
                append(lc.getCurrentFunction().getName()).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   419
                append('\'');
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   420
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   421
            if (node instanceof IdentNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   422
                final Symbol symbol = ((IdentNode)node).getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   423
                if (symbol == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   424
                    sb.append(" <NO SYMBOL>");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   425
                } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   426
                    sb.append(" <symbol=").append(symbol).append('>');
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   427
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   428
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   429
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   430
            log.unindent();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   431
            log.info(sb);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   432
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   433
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   434
        return node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   435
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   436
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   437
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   438
    public boolean enterBlock(final Block block) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   439
        start(block);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   440
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   441
        if (lc.isFunctionBody()) {
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   442
            assert !block.hasSymbols();
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   443
            final FunctionNode fn = lc.getCurrentFunction();
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   444
            if (isUnparsedFunction(fn)) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   445
                // It's a skipped nested function. Just mark the symbols being used by it as being in use.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   446
                for(final String name: compiler.getScriptFunctionData(fn.getId()).getExternalSymbolNames()) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   447
                    nameIsUsed(name, null);
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   448
                }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   449
                // Don't bother descending into it, it must be empty anyway.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   450
                assert block.getStatements().isEmpty();
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   451
                return false;
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   452
            }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   453
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   454
            enterFunctionBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   455
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   456
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   457
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   458
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   459
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   460
    private boolean isUnparsedFunction(final FunctionNode fn) {
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   461
        return isOnDemand && fn != lc.getOutermostFunction();
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   462
    }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   463
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   464
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   465
    public boolean enterCatchNode(final CatchNode catchNode) {
41983
eb674141ab03 8156615: Catch parameter can be a BindingPattern in ES6 mode
sdama
parents: 41924
diff changeset
   466
        final IdentNode exception = catchNode.getExceptionIdentifier();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   467
        final Block     block     = lc.getCurrentBlock();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   468
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   469
        start(catchNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   470
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   471
        // define block-local exception variable
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   472
        final String exname = exception.getName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   473
        // If the name of the exception starts with ":e", this is a synthetic catch block, likely a catch-all. Its
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   474
        // symbol is naturally internal, and should be treated as such.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   475
        final boolean isInternal = exname.startsWith(EXCEPTION_PREFIX.symbolName());
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   476
        // IS_LET flag is required to make sure symbol is not visible outside catch block. However, we need to
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   477
        // clear the IS_LET flag after creation to allow redefinition of symbol inside the catch block.
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   478
        final Symbol symbol = defineSymbol(block, exname, catchNode, IS_VAR | IS_LET | (isInternal ? IS_INTERNAL : 0) | HAS_OBJECT_VALUE);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   479
        symbol.clearFlag(IS_LET);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   480
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   481
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   482
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   483
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   484
    private void enterFunctionBody() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   485
        final FunctionNode functionNode = lc.getCurrentFunction();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   486
        final Block body = lc.getCurrentBlock();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   487
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   488
        initFunctionWideVariables(functionNode, body);
27822
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   489
        acceptDeclarations(functionNode, body);
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   490
        defineFunctionSelfSymbol(functionNode, body);
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   491
    }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   492
27822
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   493
    private void defineFunctionSelfSymbol(final FunctionNode functionNode, final Block body) {
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   494
        // Function self-symbol is only declared as a local variable for named function expressions. Declared functions
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   495
        // don't need it as they are local variables in their declaring scope.
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   496
        if (!functionNode.isNamedFunctionExpression()) {
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   497
            return;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   498
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   499
27822
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   500
        final String name = functionNode.getIdent().getName();
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   501
        assert name != null; // As it's a named function expression.
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   502
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   503
        if (body.getExistingSymbol(name) != null) {
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   504
            // Body already has a declaration for the name. It's either a parameter "function x(x)" or a
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   505
            // top-level variable "function x() { ... var x; ... }".
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   506
            return;
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   507
        }
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   508
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   509
        defineSymbol(body, name, functionNode, IS_VAR | IS_FUNCTION_SELF | HAS_OBJECT_VALUE);
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   510
        if(functionNode.allVarsInScope()) { // basically, has deep eval
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   511
            // We must conservatively presume that eval'd code can dynamically use the function symbol.
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   512
            lc.setFlag(functionNode, FunctionNode.USES_SELF_SYMBOL);
a3866b9fb44d 8066222: too strong assertion on function expression names
attila
parents: 27817
diff changeset
   513
        }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   514
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   515
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   516
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   517
    public boolean enterFunctionNode(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   518
        start(functionNode, false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   519
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   520
        thisProperties.push(new HashSet<String>());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   521
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   522
        // Every function has a body, even the ones skipped on reparse (they have an empty one). We're
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   523
        // asserting this as even for those, enterBlock() must be invoked to correctly process symbols that
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   524
        // are used in them.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   525
        assert functionNode.getBody() != null;
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   526
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   527
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   528
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   529
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   530
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   531
    public boolean enterVarNode(final VarNode varNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   532
        start(varNode);
27100
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   533
        // Normally, a symbol assigned in a var statement is not live for its RHS. Since we also represent function
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   534
        // declarations as VarNodes, they are exception to the rule, as they need to have the symbol visible to the
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   535
        // body of the declared function for self-reference.
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   536
        if (varNode.isFunctionDeclaration()) {
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   537
            defineVarIdent(varNode);
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   538
        }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   539
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   540
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   541
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   542
    @Override
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   543
    public Node leaveVarNode(final VarNode varNode) {
27100
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   544
        if (!varNode.isFunctionDeclaration()) {
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   545
            defineVarIdent(varNode);
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   546
        }
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   547
        return super.leaveVarNode(varNode);
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   548
    }
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   549
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   550
    private void defineVarIdent(final VarNode varNode) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   551
        final IdentNode ident = varNode.getName();
27100
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   552
        final int flags;
31485
be1acaee8e9e 8114838: Anonymous functions escape to surrounding scope when defined under "with" statement
sundar
parents: 30392
diff changeset
   553
        if (!varNode.isBlockScoped() && lc.getCurrentFunction().isProgram()) {
27100
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   554
            flags = IS_SCOPE;
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   555
        } else {
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   556
            flags = 0;
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   557
        }
44341993b5c1 8059842: Creating symbols for declared functions shouldn't be a special case
attila
parents: 26503
diff changeset
   558
        defineSymbol(lc.getCurrentBlock(), ident.getName(), ident, varNode.getSymbolFlags() | flags);
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   559
    }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   560
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   561
    private Symbol exceptionSymbol() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   562
        return newObjectInternal(EXCEPTION_PREFIX);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   563
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   564
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   565
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   566
     * This has to run before fix assignment types, store any type specializations for
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   567
     * parameters, then turn them into objects for the generic version of this method.
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   568
     *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   569
     * @param functionNode functionNode
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   570
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   571
    private FunctionNode finalizeParameters(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   572
        final List<IdentNode> newParams = new ArrayList<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   573
        final boolean isVarArg = functionNode.isVarArg();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   574
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   575
        final Block body = functionNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   576
        for (final IdentNode param : functionNode.getParameters()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   577
            final Symbol paramSymbol = body.getExistingSymbol(param.getName());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   578
            assert paramSymbol != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   579
            assert paramSymbol.isParam() : paramSymbol + " " + paramSymbol.getFlags();
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25238
diff changeset
   580
            newParams.add(param.setSymbol(paramSymbol));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   581
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   582
            // parameters should not be slots for a function that uses variable arity signature
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   583
            if (isVarArg) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   584
                paramSymbol.setNeedsSlot(false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   585
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   586
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   587
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   588
        return functionNode.setParameters(lc, newParams);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   589
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   590
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   591
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   592
     * Search for symbol in the lexical context starting from the given block.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   593
     * @param name Symbol name.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   594
     * @return Found symbol or null if not found.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   595
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   596
    private Symbol findSymbol(final Block block, final String name) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   597
        for (final Iterator<Block> blocks = lc.getBlocks(block); blocks.hasNext();) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   598
            final Symbol symbol = blocks.next().getExistingSymbol(name);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   599
            if (symbol != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   600
                return symbol;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   601
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   602
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   603
        return null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   604
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   605
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   606
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   607
     * Marks the current function as one using any global symbol. The function and all its parent functions will all be
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   608
     * marked as needing parent scope.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   609
     * @see FunctionNode#needsParentScope()
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   610
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   611
    private void functionUsesGlobalSymbol() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   612
        for (final Iterator<FunctionNode> fns = lc.getFunctions(); fns.hasNext();) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   613
            lc.setFlag(fns.next(), FunctionNode.USES_ANCESTOR_SCOPE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   614
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   615
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   616
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   617
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   618
     * Marks the current function as one using a scoped symbol. The block defining the symbol will be marked as needing
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   619
     * its own scope to hold the variable. If the symbol is defined outside of the current function, it and all
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   620
     * functions up to (but not including) the function containing the defining block will be marked as needing parent
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   621
     * function scope.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   622
     * @see FunctionNode#needsParentScope()
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   623
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   624
    private void functionUsesScopeSymbol(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   625
        final String name = symbol.getName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   626
        for (final Iterator<LexicalContextNode> contextNodeIter = lc.getAllNodes(); contextNodeIter.hasNext(); ) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   627
            final LexicalContextNode node = contextNodeIter.next();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   628
            if (node instanceof Block) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   629
                final Block block = (Block)node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   630
                if (block.getExistingSymbol(name) != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   631
                    assert lc.contains(block);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   632
                    lc.setBlockNeedsScope(block);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   633
                    break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   634
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   635
            } else if (node instanceof FunctionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   636
                lc.setFlag(node, FunctionNode.USES_ANCESTOR_SCOPE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   637
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   638
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   639
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   640
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   641
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   642
     * Declares that the current function is using the symbol.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   643
     * @param symbol the symbol used by the current function.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   644
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   645
    private void functionUsesSymbol(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   646
        assert symbol != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   647
        if (symbol.isScope()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   648
            if (symbol.isGlobal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   649
                functionUsesGlobalSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   650
            } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   651
                functionUsesScopeSymbol(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   652
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   653
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   654
            assert !symbol.isGlobal(); // Every global is also scope
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   655
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   656
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   657
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   658
    private void initCompileConstant(final CompilerConstants cc, final Block block, final int flags) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   659
        defineSymbol(block, cc.symbolName(), null, flags).setNeedsSlot(true);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   660
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   661
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   662
    private void initFunctionWideVariables(final FunctionNode functionNode, final Block body) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   663
        initCompileConstant(CALLEE, body, IS_PARAM | IS_INTERNAL | HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   664
        initCompileConstant(THIS, body, IS_PARAM | IS_THIS | HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   665
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   666
        if (functionNode.isVarArg()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   667
            initCompileConstant(VARARGS, body, IS_PARAM | IS_INTERNAL | HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   668
            if (functionNode.needsArguments()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   669
                initCompileConstant(ARGUMENTS, body, IS_VAR | IS_INTERNAL | HAS_OBJECT_VALUE);
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   670
                defineSymbol(body, ARGUMENTS_VAR.symbolName(), null, IS_VAR | HAS_OBJECT_VALUE);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   671
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   672
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   673
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   674
        initParameters(functionNode, body);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   675
        initCompileConstant(SCOPE, body, IS_VAR | IS_INTERNAL | HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   676
        initCompileConstant(RETURN, body, IS_VAR | IS_INTERNAL);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   677
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   678
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   679
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   680
     * Initialize parameters for function node.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   681
     * @param functionNode the function node
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   682
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   683
    private void initParameters(final FunctionNode functionNode, final Block body) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   684
        final boolean isVarArg = functionNode.isVarArg();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   685
        final boolean scopeParams = functionNode.allVarsInScope() || isVarArg;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   686
        for (final IdentNode param : functionNode.getParameters()) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   687
            final Symbol symbol = defineSymbol(body, param.getName(), param, IS_PARAM);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   688
            if(scopeParams) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   689
                // NOTE: this "set is scope" is a poor substitute for clear expression of where the symbol is stored.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   690
                // It will force creation of scopes where they would otherwise not necessarily be needed (functions
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   691
                // using arguments object and other variable arity functions). Tracked by JDK-8038942.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   692
                symbol.setIsScope();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   693
                assert symbol.hasSlot();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   694
                if(isVarArg) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   695
                    symbol.setNeedsSlot(false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   696
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   697
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   698
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   699
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   700
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   701
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   702
     * Is the symbol local to (that is, defined in) the specified function?
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   703
     * @param function the function
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   704
     * @param symbol the symbol
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   705
     * @return true if the symbol is defined in the specified function
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   706
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   707
    private boolean isLocal(final FunctionNode function, final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   708
        final FunctionNode definingFn = lc.getDefiningFunction(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   709
        assert definingFn != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   710
        return definingFn == function;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   711
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   712
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   713
    @Override
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   714
    public Node leaveBinaryNode(final BinaryNode binaryNode) {
30392
dc4a419b2982 8079362: Enforce best practices for Node token API usage
attila
parents: 29281
diff changeset
   715
        if (binaryNode.isTokenType(TokenType.ASSIGN)) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   716
            return leaveASSIGN(binaryNode);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   717
        }
30392
dc4a419b2982 8079362: Enforce best practices for Node token API usage
attila
parents: 29281
diff changeset
   718
        return super.leaveBinaryNode(binaryNode);
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   719
    }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   720
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   721
    private Node leaveASSIGN(final BinaryNode binaryNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   722
        // If we're assigning a property of the this object ("this.foo = ..."), record it.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   723
        final Expression lhs = binaryNode.lhs();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   724
        if (lhs instanceof AccessNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   725
            final AccessNode accessNode = (AccessNode) lhs;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   726
            final Expression base = accessNode.getBase();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   727
            if (base instanceof IdentNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   728
                final Symbol symbol = ((IdentNode)base).getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   729
                if(symbol.isThis()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   730
                    thisProperties.peek().add(accessNode.getProperty());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   731
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   732
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   733
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   734
        return binaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   735
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   736
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   737
    @Override
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   738
    public Node leaveUnaryNode(final UnaryNode unaryNode) {
48354
c96d4c720995 8193371: Use Dynalink REMOVE operation in Nashorn
attila
parents: 48334
diff changeset
   739
        if (unaryNode.tokenType() == TokenType.TYPEOF) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   740
            return leaveTYPEOF(unaryNode);
48354
c96d4c720995 8193371: Use Dynalink REMOVE operation in Nashorn
attila
parents: 48334
diff changeset
   741
        } else {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   742
            return super.leaveUnaryNode(unaryNode);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   743
        }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   744
    }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   745
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   746
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   747
    public Node leaveForNode(final ForNode forNode) {
36696
39ff39c8e396 8151700: Add support for ES6 for-of
hannesw
parents: 32888
diff changeset
   748
        if (forNode.isForInOrOf()) {
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   749
            return forNode.setIterator(lc, newObjectInternal(ITERATOR_PREFIX)); //NASHORN-73
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   750
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   752
        return end(forNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   753
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   754
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   755
    @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   756
    public Node leaveFunctionNode(final FunctionNode functionNode) {
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   757
        final FunctionNode finalizedFunction;
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   758
        if (isUnparsedFunction(functionNode)) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   759
            finalizedFunction = functionNode;
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   760
        } else {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   761
            finalizedFunction =
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   762
               markProgramBlock(
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   763
               removeUnusedSlots(
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   764
               createSyntheticInitializers(
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   765
               finalizeParameters(
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   766
                       lc.applyTopFlags(functionNode))))
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   767
                       .setThisProperties(lc, thisProperties.pop().size()));
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   768
        }
32692
8f60bd284bf4 8055917: jdk.nashorn.internal.codegen.CompilationPhase$N should be renamed to proper classes
sundar
parents: 32534
diff changeset
   769
        return finalizedFunction;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   770
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   771
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   772
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   773
    public Node leaveIdentNode(final IdentNode identNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   774
        if (identNode.isPropertyName()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   775
            return identNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   776
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   777
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   778
        final Symbol symbol = nameIsUsed(identNode.getName(), identNode);
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   779
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   780
        if (!identNode.isInitializedHere()) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   781
            symbol.increaseUseCount();
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   782
        }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   783
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   784
        IdentNode newIdentNode = identNode.setSymbol(symbol);
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   785
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   786
        // If a block-scoped var is used before its declaration mark it as dead.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   787
        // We can only statically detect this for local vars, cross-function symbols require runtime checks.
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   788
        if (symbol.isBlockScoped() && !symbol.hasBeenDeclared() && !identNode.isDeclaredHere() && isLocal(lc.getCurrentFunction(), symbol)) {
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   789
            newIdentNode = newIdentNode.markDead();
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   790
        }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   791
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   792
        return end(newIdentNode);
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   793
    }
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   794
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   795
    private Symbol nameIsUsed(final String name, final IdentNode origin) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   796
        final Block block = lc.getCurrentBlock();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   797
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   798
        Symbol symbol = findSymbol(block, name);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   799
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   800
        //If an existing symbol with the name is found, use that otherwise, declare a new one
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   801
        if (symbol != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   802
            log.info("Existing symbol = ", symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   803
            if (symbol.isFunctionSelf()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   804
                final FunctionNode functionNode = lc.getDefiningFunction(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   805
                assert functionNode != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   806
                assert lc.getFunctionBody(functionNode).getExistingSymbol(CALLEE.symbolName()) != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   807
                lc.setFlag(functionNode, FunctionNode.USES_SELF_SYMBOL);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   808
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   809
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   810
            // if symbol is non-local or we're in a with block, we need to put symbol in scope (if it isn't already)
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   811
            maybeForceScope(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   812
        } else {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   813
            log.info("No symbol exists. Declare as global: ", name);
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   814
            symbol = defineSymbol(block, name, origin, IS_GLOBAL | IS_SCOPE);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   815
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   816
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   817
        functionUsesSymbol(symbol);
26503
3ed48a01100c 8057148: Skip nested functions on reparse
attila
parents: 26377
diff changeset
   818
        return symbol;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   819
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   820
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   821
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   822
    public Node leaveSwitchNode(final SwitchNode switchNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   823
        // We only need a symbol for the tag if it's not an integer switch node
27970
7b0048b90967 8066225: NPE in MethodEmitter with duplicate integer switch cases
attila
parents: 27822
diff changeset
   824
        if(!switchNode.isUniqueInteger()) {
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   825
            return switchNode.setTag(lc, newObjectInternal(SWITCH_TAG_PREFIX));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   826
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   827
        return switchNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   828
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   829
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   830
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   831
    public Node leaveTryNode(final TryNode tryNode) {
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 27970
diff changeset
   832
        assert tryNode.getFinallyBody() == null;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   833
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   834
        end(tryNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   835
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   836
        return tryNode.setException(lc, exceptionSymbol());
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   837
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   838
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   839
    private Node leaveTYPEOF(final UnaryNode unaryNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   840
        final Expression rhs = unaryNode.getExpression();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   841
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   842
        final List<Expression> args = new ArrayList<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   843
        if (rhs instanceof IdentNode && !isParamOrVar((IdentNode)rhs)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   844
            args.add(compilerConstantIdentifier(SCOPE));
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   845
            args.add(LiteralNode.newInstance(rhs, ((IdentNode)rhs).getName())); //null
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   846
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   847
            args.add(rhs);
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   848
            args.add(LiteralNode.newInstance(unaryNode)); //null, do not reuse token of identifier rhs, it can be e.g. 'this'
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   849
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   850
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   851
        final Node runtimeNode = new RuntimeNode(unaryNode, Request.TYPEOF, args);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   852
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   853
        end(unaryNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   854
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   855
        return runtimeNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   856
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   857
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   858
    private FunctionNode markProgramBlock(final FunctionNode functionNode) {
32435
cfd619ef23a6 8133300: Ensure symbol table immutability in Nashorn AST
attila
parents: 31828
diff changeset
   859
        if (isOnDemand || !functionNode.isProgram()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   860
            return functionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   861
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   862
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   863
        return functionNode.setBody(lc, functionNode.getBody().setFlag(lc, Block.IS_GLOBAL_SCOPE));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   864
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   865
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   866
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   867
     * If the symbol isn't already a scope symbol, but it needs to be (see {@link #symbolNeedsToBeScope(Symbol)}, it is
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   868
     * promoted to a scope symbol and its block marked as needing a scope.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   869
     * @param symbol the symbol that might be scoped
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   870
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   871
    private void maybeForceScope(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   872
        if (!symbol.isScope() && symbolNeedsToBeScope(symbol)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   873
            Symbol.setSymbolIsScope(lc, symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   874
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   875
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   876
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   877
    private Symbol newInternal(final CompilerConstants cc, final int flags) {
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   878
        return defineSymbol(lc.getCurrentBlock(), lc.getCurrentFunction().uniqueName(cc.symbolName()), null, IS_VAR | IS_INTERNAL | flags); //NASHORN-73
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   879
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   880
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   881
    private Symbol newObjectInternal(final CompilerConstants cc) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   882
        return newInternal(cc, HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   883
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   884
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   885
    private boolean start(final Node node) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   886
        return start(node, true);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   887
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   888
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   889
    private boolean start(final Node node, final boolean printNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   890
        if (debug) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   891
            final StringBuilder sb = new StringBuilder();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   892
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   893
            sb.append("[ENTER ").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   894
                append(name(node)).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   895
                append("] ").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   896
                append(printNode ? node.toString() : "").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   897
                append(" in '").
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   898
                append(lc.getCurrentFunction().getName()).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   899
                append("'");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   900
            log.info(sb);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   901
            log.indent();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   902
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   903
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   904
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   905
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   906
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   907
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   908
     * Determines if the symbol has to be a scope symbol. In general terms, it has to be a scope symbol if it can only
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   909
     * be reached from the current block by traversing a function node, a split node, or a with node.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   910
     * @param symbol the symbol checked for needing to be a scope symbol
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   911
     * @return true if the symbol has to be a scope symbol.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   912
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   913
    private boolean symbolNeedsToBeScope(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   914
        if (symbol.isThis() || symbol.isInternal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   915
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   916
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   917
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   918
        final FunctionNode func = lc.getCurrentFunction();
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   919
        if ( func.allVarsInScope() || (!symbol.isBlockScoped() && func.isProgram())) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   920
            return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   921
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   922
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   923
        boolean previousWasBlock = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   924
        for (final Iterator<LexicalContextNode> it = lc.getAllNodes(); it.hasNext();) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   925
            final LexicalContextNode node = it.next();
32781
d8f34ffbbc7a 8135190: Method code too large in Babel browser.js script
hannesw
parents: 32692
diff changeset
   926
            if (node instanceof FunctionNode || isSplitLiteral(node)) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   927
                // We reached the function boundary or a splitting boundary without seeing a definition for the symbol.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   928
                // It needs to be in scope.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   929
                return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   930
            } else if (node instanceof WithNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   931
                if (previousWasBlock) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   932
                    // We reached a WithNode; the symbol must be scoped. Note that if the WithNode was not immediately
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   933
                    // preceded by a block, this means we're currently processing its expression, not its body,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   934
                    // therefore it doesn't count.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   935
                    return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   936
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   937
                previousWasBlock = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   938
            } else if (node instanceof Block) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   939
                if (((Block)node).getExistingSymbol(symbol.getName()) == symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   940
                    // We reached the block that defines the symbol without reaching either the function boundary, or a
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   941
                    // WithNode. The symbol need not be scoped.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   942
                    return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   943
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   944
                previousWasBlock = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   945
            } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   946
                previousWasBlock = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   947
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   948
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   949
        throw new AssertionError();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   950
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   951
32781
d8f34ffbbc7a 8135190: Method code too large in Babel browser.js script
hannesw
parents: 32692
diff changeset
   952
    private static boolean isSplitLiteral(final LexicalContextNode expr) {
d8f34ffbbc7a 8135190: Method code too large in Babel browser.js script
hannesw
parents: 32692
diff changeset
   953
        return expr instanceof Splittable && ((Splittable) expr).getSplitRanges() != null;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   954
    }
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   955
27817
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   956
    private void throwUnprotectedSwitchError(final VarNode varNode) {
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   957
        // Block scoped declarations in switch statements without explicit blocks should be declared
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   958
        // in a common block that contains all the case clauses. We cannot support this without a
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   959
        // fundamental rewrite of how switch statements are handled (case nodes contain blocks and are
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   960
        // directly contained by switch node). As a temporary solution we throw a reference error here.
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   961
        final String msg = ECMAErrors.getMessage("syntax.error.unprotected.switch.declaration", varNode.isLet() ? "let" : "const");
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   962
        throwParserException(msg, varNode);
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   963
    }
56f6161c3e55 8057980: let & const: remaining issues with lexical scoping
hannesw
parents: 27814
diff changeset
   964
26377
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   965
    private void throwParserException(final String message, final Node origin) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   966
        if (origin == null) {
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   967
            throw new ParserException(message);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   968
        }
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   969
        final Source source = compiler.getSource();
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   970
        final long token = origin.getToken();
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   971
        final int line = source.getLine(origin.getStart());
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   972
        final int column = source.getColumn(origin.getStart());
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   973
        final String formatted = ErrorManager.format(message, source, line, column, token);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   974
        throw new ParserException(JSErrorType.SYNTAX_ERROR, formatted, source, line, column, token);
028dad61662f 8051889: Implement block scoping in symbol assignment and scope computation
hannesw
parents: 26252
diff changeset
   975
    }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   976
}