jdk/test/tools/launcher/modules/addreads/AddReadsTestWarningError.java
author alanb
Wed, 22 Mar 2017 16:26:27 +0000
changeset 44359 c6761862ca0b
parent 42993 d761de69e27f
child 45191 ba48b1679390
permissions -rw-r--r--
8174823: Module system implementation refresh (3/2017) Reviewed-by: chegar, mchung, alanb Contributed-by: alan.bateman@oracle.com, mandy.chung@oracle.com, sundararajan.athijegannathan@oracle.com, peter.levart@gmail.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     1
/*
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     2
 * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     4
 *
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     7
 * published by the Free Software Foundation.
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     8
 *
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    13
 * accompanied this code).
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    14
 *
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    18
 *
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    21
 * questions.
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    22
 */
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    23
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    24
/**
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    25
 * @test
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    26
 * @bug 8168836
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    27
 * @summary  Basic argument validation for --add-reads
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    28
 * @library /lib/testlibrary
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    29
 * @modules jdk.compiler
42993
d761de69e27f 8172215: java launcher no longer accepts -cp "" empty string
mchung
parents: 42774
diff changeset
    30
 * @build AddReadsTestWarningError CompilerUtils ModuleInfoMaker
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    31
 * @build jdk.testlibrary.*
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    32
 * @run testng AddReadsTestWarningError
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    33
 */
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    34
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    35
import java.io.BufferedOutputStream;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    36
import java.io.ByteArrayOutputStream;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    37
import java.io.PrintStream;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    38
import java.nio.file.Path;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    39
import java.nio.file.Paths;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    40
import java.util.Arrays;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    41
import java.util.stream.Stream;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    42
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    43
import jdk.testlibrary.OutputAnalyzer;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    44
import static jdk.testlibrary.ProcessTools.*;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    45
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    46
import org.testng.annotations.BeforeTest;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    47
import org.testng.annotations.DataProvider;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    48
import org.testng.annotations.Test;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    49
import static org.testng.Assert.*;
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    50
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    51
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    52
@Test
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    53
public class AddReadsTestWarningError {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    54
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    55
    private static final Path MODS_DIR = Paths.get("mods");
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    56
    private static final Path SRC_DIR = Paths.get("src");
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    57
    private static final String M1_MAIN = "m1/p1.C1";
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    58
    private static final String M4_MAIN = "m4/p4.C4";
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    59
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    60
    @BeforeTest
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    61
    public void setup() throws Exception {
42993
d761de69e27f 8172215: java launcher no longer accepts -cp "" empty string
mchung
parents: 42774
diff changeset
    62
        ModuleInfoMaker builder = new ModuleInfoMaker(SRC_DIR);
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    63
        builder.writeJavaFiles("m1",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    64
            "module m1 { requires m4; }",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    65
            "package p1; public class C1 { " +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    66
            "    public static void main(String... args) {" +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    67
            "        p2.C2 c2 = new p2.C2();" +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    68
            "        p3.C3 c3 = new p3.C3();" +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    69
            "    }" +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    70
            "}"
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    71
        );
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    72
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    73
        builder.writeJavaFiles("m2",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    74
            "module m2 { exports p2; }",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    75
            "package p2; public class C2 { }"
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    76
        );
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    77
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    78
        builder.writeJavaFiles("m3",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    79
            "module m3 { exports p3; }",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    80
            "package p3; public class C3 { }"
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    81
        );
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    82
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    83
        builder.writeJavaFiles("m4",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    84
            "module m4 { requires m2; requires m3; }",
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    85
            "package p4; public class C4 { " +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    86
            "    public static void main(String... args) {}" +
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    87
            "}"
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    88
        );
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    89
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    90
        builder.compile("m2", MODS_DIR);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    91
        builder.compile("m3", MODS_DIR);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    92
        builder.compile("m4", MODS_DIR);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    93
        builder.compile("m1", MODS_DIR, "--add-reads", "m1=m2,m3");
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    94
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    95
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    96
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    97
    @DataProvider(name = "goodcases")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    98
    public Object[][] goodCases() {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
    99
        return new Object[][]{
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   100
            // empty items
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   101
            { "m1=,m2,m3",       null },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   102
            { "m1=m2,,m3",       null },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   103
            { "m1=m2,m3,",       null },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   104
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   105
            // duplicates
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   106
            { "m1=m2,m2,m3,,",  null },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   107
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   108
        };
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   109
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   110
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   111
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   112
    @Test(dataProvider = "goodcases")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   113
    public void test(String value, String ignore) throws Exception {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   114
        ByteArrayOutputStream baos = new ByteArrayOutputStream();
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   115
        PrintStream ps = new PrintStream(new BufferedOutputStream(baos));
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   116
        OutputAnalyzer outputAnalyzer =
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   117
            executeTestJava("--add-reads", value,
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   118
                            "--module-path", MODS_DIR.toString(),
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   119
                            "-m", M1_MAIN)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   120
                .outputTo(ps)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   121
                .errorTo(ps);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   122
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   123
        assertTrue(outputAnalyzer.getExitValue() == 0);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   124
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   125
        System.out.println(baos.toString());
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   126
        String[] output = baos.toString().split("\\R");
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   127
        assertFalse(Arrays.stream(output)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   128
                          .filter(s -> !s.matches("WARNING: Module name .* may soon be illegal"))
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   129
                          .filter(s -> s.startsWith("WARNING:"))
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   130
                          .findAny().isPresent());
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   131
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   132
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   133
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   134
    @DataProvider(name = "illFormedAddReads")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   135
    public Object[][] illFormedAddReads() {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   136
        return new Object[][]{
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   137
            { "m1",         "Unable to parse --add-reads <module>=<value>: m1" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   138
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   139
            // missing source part
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   140
            { "=m2",        "Unable to parse --add-reads <module>=<value>: =m2" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   141
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   142
            // empty list, missing target
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   143
            { "m1=",        "Unable to parse --add-reads <module>=<value>: m1=" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   144
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   145
            // empty list
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   146
            { "m1=,,",      "Target must be specified: --add-reads m1=,," },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   147
        };
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   148
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   149
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   150
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   151
    @Test(dataProvider = "illFormedAddReads")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   152
    public void testIllFormedAddReads(String value, String msg) throws Exception {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   153
        int exitValue =
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   154
            executeTestJava("--add-reads", value,
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   155
                            "--module-path", MODS_DIR.toString(),
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   156
                            "-m", M4_MAIN)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   157
                .outputTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   158
                .errorTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   159
                .shouldContain(msg)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   160
                .getExitValue();
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   161
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   162
        assertTrue(exitValue != 0);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   163
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   164
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   165
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   166
    @DataProvider(name = "unknownNames")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   167
    public Object[][] unknownNames() {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   168
        return new Object[][]{
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   169
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   170
            // source not found
44359
c6761862ca0b 8174823: Module system implementation refresh (3/2017)
alanb
parents: 42993
diff changeset
   171
            {"DoesNotExist=m2",    "WARNING: Unknown module: DoesNotExist specified to --add-reads"},
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   172
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   173
            // target not found
44359
c6761862ca0b 8174823: Module system implementation refresh (3/2017)
alanb
parents: 42993
diff changeset
   174
            {"m2=DoesNotExist",    "WARNING: Unknown module: DoesNotExist specified to --add-reads"},
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   175
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   176
            // bad names
44359
c6761862ca0b 8174823: Module system implementation refresh (3/2017)
alanb
parents: 42993
diff changeset
   177
            {"m*=m2",              "WARNING: Unknown module: m* specified to --add-reads"},
c6761862ca0b 8174823: Module system implementation refresh (3/2017)
alanb
parents: 42993
diff changeset
   178
            {"m2=m!",              "WARNING: Unknown module: m! specified to --add-reads"},
42774
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   179
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   180
        };
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   181
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   182
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   183
    @Test(dataProvider = "unknownNames")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   184
    public void testUnknownNames(String value, String msg) throws Exception {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   185
        int exitValue =
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   186
            executeTestJava("--add-reads", value,
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   187
                            "--module-path", MODS_DIR.toString(),
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   188
                            "-m", M4_MAIN)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   189
                .outputTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   190
                .errorTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   191
                .shouldContain(msg)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   192
                .getExitValue();
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   193
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   194
        assertTrue(exitValue == 0);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   195
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   196
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   197
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   198
    @DataProvider(name = "missingArguments")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   199
    public Object[][] missingArguments() {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   200
        return new Object[][]{
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   201
            { new String[] {"--add-reads" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   202
                "Error: --add-reads requires modules to be specified"},
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   203
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   204
            { new String[] { "--add-reads=" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   205
                "Error: --add-reads= requires modules to be specified"},
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   206
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   207
            { new String[] { "--add-reads", "" },
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   208
                "Error: --add-reads requires modules to be specified"},
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   209
        };
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   210
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   211
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   212
    @Test(dataProvider = "missingArguments")
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   213
    public void testEmptyArgument(String[] options, String msg) throws Exception {
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   214
        String[] args = Stream.concat(Arrays.stream(options), Stream.of("-version"))
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   215
                              .toArray(String[]::new);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   216
        int exitValue = executeTestJava(args)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   217
            .outputTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   218
            .errorTo(System.out)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   219
            .shouldContain(msg)
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   220
            .getExitValue();
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   221
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   222
        assertTrue(exitValue != 0);
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   223
    }
74bcf37d15d8 8168836: Minor clean up on warning/error messages on --add-exports and --add-reads
mchung
parents:
diff changeset
   224
}