test/jdk/java/lang/constant/NameValidationTest.java
author vromero
Wed, 09 Jan 2019 08:07:23 -0500
changeset 53224 bae765528fcc
parent 52914 4fa75d8ad418
permissions -rw-r--r--
8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec Reviewed-by: goetz
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
52914
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     1
/*
53224
bae765528fcc 8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec
vromero
parents: 52914
diff changeset
     2
 * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
52914
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     4
 *
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     7
 * published by the Free Software Foundation.
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     8
 *
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    13
 * accompanied this code).
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    14
 *
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    18
 *
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    21
 * questions.
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    22
 */
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    23
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    24
/**
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    25
 * @test
53224
bae765528fcc 8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec
vromero
parents: 52914
diff changeset
    26
 * @bug 8215510
52914
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    27
 * @compile NameValidationTest.java
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    28
 * @run testng NameValidationTest
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    29
 * @summary unit tests for verifying member names
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    30
 */
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    31
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    32
import java.lang.constant.*;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    33
import java.lang.invoke.*;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    34
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    35
import org.testng.annotations.Test;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    36
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    37
import static java.lang.constant.DirectMethodHandleDesc.*;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    38
import static java.lang.constant.ConstantDescs.*;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    39
import static java.lang.constant.DirectMethodHandleDesc.Kind.VIRTUAL;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    40
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    41
import static org.testng.Assert.fail;
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    42
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    43
@Test
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    44
public class NameValidationTest {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    45
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    46
    private static final String[] badMemberNames = new String[] {"xx.xx", "zz;zz", "[l", "aa/aa", "<cinit>"};
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    47
    private static final String[] goodMemberNames = new String[] {"<clinit>", "<init>", "3", "~", "$", "qq"};
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    48
53224
bae765528fcc 8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec
vromero
parents: 52914
diff changeset
    49
    private static final String[] badClassNames = new String[] {"zz;zz", "[l", "aa/aa", ".", "a..b"};
bae765528fcc 8215510: j.l.c.ClassDesc is accepting descriptors not allowed by the spec
vromero
parents: 52914
diff changeset
    50
    private static final String[] goodClassNames = new String[] {"3", "~", "$", "qq", "a.a"};
52914
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    51
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    52
    public void testMemberNames() {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    53
        DirectMethodHandleDesc mh = MethodHandleDesc.of(Kind.VIRTUAL, CD_String, "isEmpty", "()Z");
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    54
        for (String badName : badMemberNames) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    55
            try {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    56
                memberNamesHelper(badName, mh, CD_int, null);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    57
                fail("Expected failure for name " + badName);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    58
            } catch (IllegalArgumentException iae) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    59
                // expected
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    60
            }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    61
            try {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    62
                memberNamesHelper(badName, mh, CD_int, new ConstantDesc[0]);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    63
                fail("Expected failure for name " + badName);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    64
            } catch (IllegalArgumentException iae) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    65
                // expected
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    66
            }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    67
        }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    68
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    69
        for (String badName : goodMemberNames) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    70
            memberNamesHelper(badName, mh, CD_int, null);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    71
            memberNamesHelper(badName, mh, CD_int, new ConstantDesc[0]);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    72
        }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    73
    }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    74
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    75
    private void memberNamesHelper(String constantName,
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    76
                               DirectMethodHandleDesc bootstrapMethod,
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    77
                               ClassDesc constantType,
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    78
                               ConstantDesc... bootstrapArgs) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    79
        if (bootstrapArgs == null) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    80
            DynamicConstantDesc.ofNamed(bootstrapMethod, constantName, constantType);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    81
        } else {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    82
            DynamicConstantDesc.ofNamed(bootstrapMethod, constantName, constantType, bootstrapArgs);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    83
        }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    84
    }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    85
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    86
    public void testClassNames() {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    87
        for (String badName : badClassNames) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    88
            try {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    89
                ClassDesc.of(badName);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    90
                fail("Expected failure for name " + badName);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    91
            } catch (IllegalArgumentException iae) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    92
                // expected
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    93
            }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    94
        }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    95
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    96
        for (String goodName : goodClassNames) {
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    97
            ClassDesc.of(goodName);
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    98
        }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
    99
    }
4fa75d8ad418 8210031: implementation for JVM Constants API
vromero
parents:
diff changeset
   100
}