author | rehn |
Mon, 09 May 2016 22:22:15 +0200 | |
changeset 38259 | b495d1cfe673 |
parent 37242 | 91e5f98fff6f |
child 39714 | 976b97b59d87 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
35898
ddc274f0052f
8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size
coleenp
parents:
35492
diff
changeset
|
2 |
* Copyright (c) 1997, 2016, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
5403
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
26 |
#include "classfile/systemDictionary.hpp" |
|
27 |
#include "classfile/vmSymbols.hpp" |
|
30764 | 28 |
#include "gc/shared/gcLocker.hpp" |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
29 |
#include "logging/log.hpp" |
7397 | 30 |
#include "memory/resourceArea.hpp" |
31 |
#include "memory/universe.inline.hpp" |
|
32 |
#include "oops/instanceKlass.hpp" |
|
33 |
#include "oops/klassVtable.hpp" |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
34 |
#include "oops/method.hpp" |
7397 | 35 |
#include "oops/objArrayOop.hpp" |
36 |
#include "oops/oop.inline.hpp" |
|
37 |
#include "runtime/arguments.hpp" |
|
38 |
#include "runtime/handles.inline.hpp" |
|
39 |
#include "utilities/copy.hpp" |
|
1 | 40 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
41 |
inline InstanceKlass* klassVtable::ik() const { |
33602 | 42 |
return InstanceKlass::cast(_klass()); |
1 | 43 |
} |
44 |
||
45 |
||
46 |
// this function computes the vtable size (including the size needed for miranda |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
47 |
// methods) and the number of miranda methods in this class. |
1 | 48 |
// Note on Miranda methods: Let's say there is a class C that implements |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
49 |
// interface I, and none of C's superclasses implements I. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
50 |
// Let's say there is an abstract method m in I that neither C |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
51 |
// nor any of its super classes implement (i.e there is no method of any access, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
52 |
// with the same name and signature as m), then m is a Miranda method which is |
1 | 53 |
// entered as a public abstract method in C's vtable. From then on it should |
54 |
// treated as any other public method in C for method over-ride purposes. |
|
14385 | 55 |
void klassVtable::compute_vtable_size_and_num_mirandas( |
56 |
int* vtable_length_ret, int* num_new_mirandas, |
|
34666 | 57 |
GrowableArray<Method*>* all_mirandas, const Klass* super, |
14385 | 58 |
Array<Method*>* methods, AccessFlags class_flags, |
59 |
Handle classloader, Symbol* classname, Array<Klass*>* local_interfaces, |
|
60 |
TRAPS) { |
|
35492
c8c0273e6b91
8146690: Make all classes in GC follow the naming convention.
david
parents:
35463
diff
changeset
|
61 |
NoSafepointVerifier nsv; |
1 | 62 |
|
63 |
// set up default result values |
|
14385 | 64 |
int vtable_length = 0; |
1 | 65 |
|
66 |
// start off with super's vtable length |
|
33602 | 67 |
vtable_length = super == NULL ? 0 : super->vtable_length(); |
1 | 68 |
|
69 |
// go thru each method in the methods table to see if it needs a new entry |
|
70 |
int len = methods->length(); |
|
71 |
for (int i = 0; i < len; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
72 |
assert(methods->at(i)->is_method(), "must be a Method*"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
73 |
methodHandle mh(THREAD, methods->at(i)); |
1 | 74 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
75 |
if (needs_new_vtable_entry(mh, super, classloader, classname, class_flags, THREAD)) { |
1 | 76 |
vtable_length += vtableEntry::size(); // we need a new entry |
77 |
} |
|
78 |
} |
|
79 |
||
14385 | 80 |
GrowableArray<Method*> new_mirandas(20); |
1 | 81 |
// compute the number of mirandas methods that must be added to the end |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
82 |
get_mirandas(&new_mirandas, all_mirandas, super, methods, NULL, local_interfaces); |
14385 | 83 |
*num_new_mirandas = new_mirandas.length(); |
84 |
||
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
85 |
// Interfaces do not need interface methods in their vtables |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
86 |
// This includes miranda methods and during later processing, default methods |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
87 |
if (!class_flags.is_interface()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
88 |
vtable_length += *num_new_mirandas * vtableEntry::size(); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
89 |
} |
1 | 90 |
|
91 |
if (Universe::is_bootstrapping() && vtable_length == 0) { |
|
92 |
// array classes don't have their superclass set correctly during |
|
93 |
// bootstrapping |
|
94 |
vtable_length = Universe::base_vtable_size(); |
|
95 |
} |
|
96 |
||
28373
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
97 |
if (super == NULL && vtable_length != Universe::base_vtable_size()) { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
98 |
if (Universe::is_bootstrapping()) { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
99 |
// Someone is attempting to override java.lang.Object incorrectly on the |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
100 |
// bootclasspath. The JVM cannot recover from this error including throwing |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
101 |
// an exception |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
102 |
vm_exit_during_initialization("Incompatible definition of java.lang.Object"); |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
103 |
} else { |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
104 |
// Someone is attempting to redefine java.lang.Object incorrectly. The |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
105 |
// only way this should happen is from |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
106 |
// SystemDictionary::resolve_from_stream(), which will detect this later |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
107 |
// and throw a security exception. So don't assert here to let |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
108 |
// the exception occur. |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
109 |
vtable_length = Universe::base_vtable_size(); |
26fdc99d32f8
6583051: crash when adding non-static methods to java.lang.Object class
coleenp
parents:
25504
diff
changeset
|
110 |
} |
1 | 111 |
} |
112 |
assert(vtable_length % vtableEntry::size() == 0, "bad vtable length"); |
|
113 |
assert(vtable_length >= Universe::base_vtable_size(), "vtable too small"); |
|
14385 | 114 |
|
115 |
*vtable_length_ret = vtable_length; |
|
1 | 116 |
} |
117 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
118 |
int klassVtable::index_of(Method* m, int len) const { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
119 |
assert(m->has_vtable_index(), "do not ask this of non-vtable methods"); |
1 | 120 |
return m->vtable_index(); |
121 |
} |
|
122 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
123 |
// Copy super class's vtable to the first part (prefix) of this class's vtable, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
124 |
// and return the number of entries copied. Expects that 'super' is the Java |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
125 |
// super class (arrays can have "array" super classes that must be skipped). |
1 | 126 |
int klassVtable::initialize_from_super(KlassHandle super) { |
127 |
if (super.is_null()) { |
|
128 |
return 0; |
|
129 |
} else { |
|
130 |
// copy methods from superKlass |
|
33602 | 131 |
klassVtable* superVtable = super->vtable(); |
1 | 132 |
assert(superVtable->length() <= _length, "vtable too short"); |
133 |
#ifdef ASSERT |
|
134 |
superVtable->verify(tty, true); |
|
135 |
#endif |
|
136 |
superVtable->copy_vtable_to(table()); |
|
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
137 |
if (log_develop_is_enabled(Trace, vtables)) { |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
138 |
ResourceMark rm; |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
139 |
log_develop_trace(vtables)("copy vtable from %s to %s size %d", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
140 |
super->internal_name(), klass()->internal_name(), |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
141 |
_length); |
1 | 142 |
} |
143 |
return superVtable->length(); |
|
144 |
} |
|
145 |
} |
|
146 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
147 |
// |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
148 |
// Revised lookup semantics introduced 1.3 (Kestrel beta) |
1 | 149 |
void klassVtable::initialize_vtable(bool checkconstraints, TRAPS) { |
150 |
||
151 |
// Note: Arrays can have intermediate array supers. Use java_super to skip them. |
|
152 |
KlassHandle super (THREAD, klass()->java_super()); |
|
153 |
int nofNewEntries = 0; |
|
154 |
||
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
155 |
if (!klass()->is_array_klass()) { |
1 | 156 |
ResourceMark rm(THREAD); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
157 |
log_develop_debug(vtables)("Initializing: %s", _klass->name()->as_C_string()); |
1 | 158 |
} |
159 |
||
160 |
#ifdef ASSERT |
|
161 |
oop* end_of_obj = (oop*)_klass() + _klass()->size(); |
|
162 |
oop* end_of_vtable = (oop*)&table()[_length]; |
|
163 |
assert(end_of_vtable <= end_of_obj, "vtable extends beyond end"); |
|
164 |
#endif |
|
165 |
||
166 |
if (Universe::is_bootstrapping()) { |
|
167 |
// just clear everything |
|
168 |
for (int i = 0; i < _length; i++) table()[i].clear(); |
|
169 |
return; |
|
170 |
} |
|
171 |
||
172 |
int super_vtable_len = initialize_from_super(super); |
|
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
173 |
if (klass()->is_array_klass()) { |
1 | 174 |
assert(super_vtable_len == _length, "arrays shouldn't introduce new methods"); |
175 |
} else { |
|
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
176 |
assert(_klass->is_instance_klass(), "must be InstanceKlass"); |
1 | 177 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
178 |
Array<Method*>* methods = ik()->methods(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
179 |
int len = methods->length(); |
1 | 180 |
int initialized = super_vtable_len; |
181 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
182 |
// Check each of this class's methods against super; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
183 |
// if override, replace in copy of super vtable, otherwise append to end |
1 | 184 |
for (int i = 0; i < len; i++) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
185 |
// update_inherited_vtable can stop for gc - ensure using handles |
1 | 186 |
HandleMark hm(THREAD); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
187 |
assert(methods->at(i)->is_method(), "must be a Method*"); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
188 |
methodHandle mh(THREAD, methods->at(i)); |
1 | 189 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
190 |
bool needs_new_entry = update_inherited_vtable(ik(), mh, super_vtable_len, -1, checkconstraints, CHECK); |
1 | 191 |
|
192 |
if (needs_new_entry) { |
|
193 |
put_method_at(mh(), initialized); |
|
194 |
mh()->set_vtable_index(initialized); // set primary vtable index |
|
195 |
initialized++; |
|
196 |
} |
|
197 |
} |
|
198 |
||
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
199 |
// update vtable with default_methods |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
200 |
Array<Method*>* default_methods = ik()->default_methods(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
201 |
if (default_methods != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
202 |
len = default_methods->length(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
203 |
if (len > 0) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
204 |
Array<int>* def_vtable_indices = NULL; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
205 |
if ((def_vtable_indices = ik()->default_vtable_indices()) == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
206 |
def_vtable_indices = ik()->create_new_default_vtable_indices(len, CHECK); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
207 |
} else { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
208 |
assert(def_vtable_indices->length() == len, "reinit vtable len?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
209 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
210 |
for (int i = 0; i < len; i++) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
211 |
HandleMark hm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
212 |
assert(default_methods->at(i)->is_method(), "must be a Method*"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
213 |
methodHandle mh(THREAD, default_methods->at(i)); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
214 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
215 |
bool needs_new_entry = update_inherited_vtable(ik(), mh, super_vtable_len, i, checkconstraints, CHECK); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
216 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
217 |
// needs new entry |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
218 |
if (needs_new_entry) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
219 |
put_method_at(mh(), initialized); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
220 |
def_vtable_indices->at_put(i, initialized); //set vtable index |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
221 |
initialized++; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
222 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
223 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
224 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
225 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
226 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
227 |
// add miranda methods; it will also return the updated initialized |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
228 |
// Interfaces do not need interface methods in their vtables |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
229 |
// This includes miranda methods and during later processing, default methods |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
230 |
if (!ik()->is_interface()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
231 |
initialized = fill_in_mirandas(initialized); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
232 |
} |
1 | 233 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
234 |
// In class hierarchies where the accessibility is not increasing (i.e., going from private -> |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
235 |
// package_private -> public/protected), the vtable might actually be smaller than our initial |
1 | 236 |
// calculation. |
237 |
assert(initialized <= _length, "vtable initialization failed"); |
|
238 |
for(;initialized < _length; initialized++) { |
|
239 |
put_method_at(NULL, initialized); |
|
240 |
} |
|
241 |
NOT_PRODUCT(verify(tty, true)); |
|
242 |
} |
|
243 |
} |
|
244 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
245 |
// Called for cases where a method does not override its superclass' vtable entry |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
246 |
// For bytecodes not produced by javac together it is possible that a method does not override |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
247 |
// the superclass's method, but might indirectly override a super-super class's vtable entry |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
248 |
// If none found, return a null superk, else return the superk of the method this does override |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
249 |
// For public and protected methods: if they override a superclass, they will |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
250 |
// also be overridden themselves appropriately. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
251 |
// Private methods do not override and are not overridden. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
252 |
// Package Private methods are trickier: |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
253 |
// e.g. P1.A, pub m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
254 |
// P2.B extends A, package private m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
255 |
// P1.C extends B, public m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
256 |
// P1.C.m needs to override P1.A.m and can not override P2.B.m |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
257 |
// Therefore: all package private methods need their own vtable entries for |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
258 |
// them to be the root of an inheritance overriding decision |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
259 |
// Package private methods may also override other vtable entries |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
260 |
InstanceKlass* klassVtable::find_transitive_override(InstanceKlass* initialsuper, methodHandle target_method, |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
261 |
int vtable_index, Handle target_loader, Symbol* target_classname, Thread * THREAD) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
262 |
InstanceKlass* superk = initialsuper; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
263 |
while (superk != NULL && superk->super() != NULL) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
264 |
InstanceKlass* supersuperklass = InstanceKlass::cast(superk->super()); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
265 |
klassVtable* ssVtable = supersuperklass->vtable(); |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
266 |
if (vtable_index < ssVtable->length()) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
267 |
Method* super_method = ssVtable->method_at(vtable_index); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
268 |
#ifndef PRODUCT |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
269 |
Symbol* name= target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
270 |
Symbol* signature = target_method()->signature(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
271 |
assert(super_method->name() == name && super_method->signature() == signature, "vtable entry name/sig mismatch"); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
272 |
#endif |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
273 |
if (supersuperklass->is_override(super_method, target_loader, target_classname, THREAD)) { |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
274 |
if (log_develop_is_enabled(Trace, vtables)) { |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
275 |
ResourceMark rm(THREAD); |
37242 | 276 |
outputStream* logst = Log(vtables)::trace_stream(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
277 |
char* sig = target_method()->name_and_sig_as_C_string(); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
278 |
logst->print("transitive overriding superclass %s with %s::%s index %d, original flags: ", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
279 |
supersuperklass->internal_name(), |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
280 |
_klass->internal_name(), sig, vtable_index); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
281 |
super_method->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
282 |
logst->print("overriders flags: "); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
283 |
target_method->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
284 |
logst->cr(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
285 |
} |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
286 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
287 |
break; // return found superk |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
288 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
289 |
} else { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
290 |
// super class has no vtable entry here, stop transitive search |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
291 |
superk = (InstanceKlass*)NULL; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
292 |
break; |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
293 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
294 |
// if no override found yet, continue to search up |
33602 | 295 |
superk = superk->super() == NULL ? NULL : InstanceKlass::cast(superk->super()); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
296 |
} |
1 | 297 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
298 |
return superk; |
1 | 299 |
} |
300 |
||
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
301 |
static void log_vtables(int i, bool overrides, methodHandle target_method, |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
302 |
KlassHandle target_klass, Method* super_method, |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
303 |
Thread* thread) { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
304 |
#ifndef PRODUCT |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
305 |
if (log_develop_is_enabled(Trace, vtables)) { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
306 |
ResourceMark rm(thread); |
37242 | 307 |
outputStream* logst = Log(vtables)::trace_stream(); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
308 |
char* sig = target_method()->name_and_sig_as_C_string(); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
309 |
if (overrides) { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
310 |
logst->print("overriding with %s::%s index %d, original flags: ", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
311 |
target_klass->internal_name(), sig, i); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
312 |
} else { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
313 |
logst->print("NOT overriding with %s::%s index %d, original flags: ", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
314 |
target_klass->internal_name(), sig, i); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
315 |
} |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
316 |
super_method->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
317 |
logst->print("overriders flags: "); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
318 |
target_method->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
319 |
logst->cr(); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
320 |
} |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
321 |
#endif |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
322 |
} |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
323 |
|
1 | 324 |
// Update child's copy of super vtable for overrides |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
325 |
// OR return true if a new vtable entry is required. |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
326 |
// Only called for InstanceKlass's, i.e. not for arrays |
1 | 327 |
// If that changed, could not use _klass as handle for klass |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
328 |
bool klassVtable::update_inherited_vtable(InstanceKlass* klass, methodHandle target_method, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
329 |
int super_vtable_len, int default_index, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
330 |
bool checkconstraints, TRAPS) { |
1 | 331 |
ResourceMark rm; |
332 |
bool allocate_new = true; |
|
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
333 |
assert(klass->is_instance_klass(), "must be InstanceKlass"); |
1 | 334 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
335 |
Array<int>* def_vtable_indices = NULL; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
336 |
bool is_default = false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
337 |
// default methods are concrete methods in superinterfaces which are added to the vtable |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
338 |
// with their real method_holder |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
339 |
// Since vtable and itable indices share the same storage, don't touch |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
340 |
// the default method's real vtable/itable index |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
341 |
// default_vtable_indices stores the vtable value relative to this inheritor |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
342 |
if (default_index >= 0 ) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
343 |
is_default = true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
344 |
def_vtable_indices = klass->default_vtable_indices(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
345 |
assert(def_vtable_indices != NULL, "def vtable alloc?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
346 |
assert(default_index <= def_vtable_indices->length(), "def vtable len?"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
347 |
} else { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
348 |
assert(klass == target_method()->method_holder(), "caller resp."); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
349 |
// Initialize the method's vtable index to "nonvirtual". |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
350 |
// If we allocate a vtable entry, we will update it to a non-negative number. |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
351 |
target_method()->set_vtable_index(Method::nonvirtual_vtable_index); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
352 |
} |
1 | 353 |
|
354 |
// Static and <init> methods are never in |
|
355 |
if (target_method()->is_static() || target_method()->name() == vmSymbols::object_initializer_name()) { |
|
356 |
return false; |
|
357 |
} |
|
358 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
359 |
if (target_method->is_final_method(klass->access_flags())) { |
1 | 360 |
// a final method never needs a new entry; final methods can be statically |
361 |
// resolved and they have to be present in the vtable only if they override |
|
362 |
// a super's method, in which case they re-use its entry |
|
363 |
allocate_new = false; |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
364 |
} else if (klass->is_interface()) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
365 |
allocate_new = false; // see note below in needs_new_vtable_entry |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
366 |
// An interface never allocates new vtable slots, only inherits old ones. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
367 |
// This method will either be assigned its own itable index later, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
368 |
// or be assigned an inherited vtable index in the loop below. |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
369 |
// default methods inherited by classes store their vtable indices |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
370 |
// in the inheritor's default_vtable_indices |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
371 |
// default methods inherited by interfaces may already have a |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
372 |
// valid itable index, if so, don't change it |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
373 |
// overpass methods in an interface will be assigned an itable index later |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
374 |
// by an inheriting class |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
375 |
if (!is_default || !target_method()->has_itable_index()) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
376 |
target_method()->set_vtable_index(Method::pending_itable_index); |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
377 |
} |
1 | 378 |
} |
379 |
||
380 |
// we need a new entry if there is no superclass |
|
381 |
if (klass->super() == NULL) { |
|
382 |
return allocate_new; |
|
383 |
} |
|
384 |
||
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
385 |
// private methods in classes always have a new entry in the vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
386 |
// specification interpretation since classic has |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
387 |
// private methods not overriding |
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
388 |
// JDK8 adds private methods in interfaces which require invokespecial |
1 | 389 |
if (target_method()->is_private()) { |
390 |
return allocate_new; |
|
391 |
} |
|
392 |
||
393 |
// search through the vtable and update overridden entries |
|
394 |
// Since check_signature_loaders acquires SystemDictionary_lock |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
395 |
// which can block for gc, once we are in this loop, use handles |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
396 |
// For classfiles built with >= jdk7, we now look for transitive overrides |
1 | 397 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
398 |
Symbol* name = target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
399 |
Symbol* signature = target_method()->signature(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
400 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
401 |
KlassHandle target_klass(THREAD, target_method()->method_holder()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
402 |
if (target_klass == NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
403 |
target_klass = _klass; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
404 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
405 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
406 |
Handle target_loader(THREAD, target_klass->class_loader()); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
407 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
408 |
Symbol* target_classname = target_klass->name(); |
1 | 409 |
for(int i = 0; i < super_vtable_len; i++) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
410 |
Method* super_method = method_at(i); |
1 | 411 |
// Check if method name matches |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
412 |
if (super_method->name() == name && super_method->signature() == signature) { |
1 | 413 |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
414 |
// get super_klass for method_holder for the found method |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
415 |
InstanceKlass* super_klass = super_method->method_holder(); |
1 | 416 |
|
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
417 |
// Whether the method is being overridden |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
418 |
bool overrides = false; |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
419 |
|
29871 | 420 |
// private methods are also never overridden |
421 |
if (!super_method->is_private() && |
|
422 |
(is_default |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
423 |
|| ((super_klass->is_override(super_method, target_loader, target_classname, THREAD)) |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
424 |
|| ((klass->major_version() >= VTABLE_TRANSITIVE_OVERRIDE_VERSION) |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
425 |
&& ((super_klass = find_transitive_override(super_klass, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
426 |
target_method, i, target_loader, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
427 |
target_classname, THREAD)) |
29871 | 428 |
!= (InstanceKlass*)NULL))))) |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
429 |
{ |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
430 |
// Package private methods always need a new entry to root their own |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
431 |
// overriding. They may also override other methods. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
432 |
if (!target_method()->is_package_private()) { |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
433 |
allocate_new = false; |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
434 |
} |
1 | 435 |
|
436 |
if (checkconstraints) { |
|
437 |
// Override vtable entry if passes loader constraint check |
|
438 |
// if loader constraint checking requested |
|
439 |
// No need to visit his super, since he and his super |
|
440 |
// have already made any needed loader constraints. |
|
441 |
// Since loader constraints are transitive, it is enough |
|
442 |
// to link to the first super, and we get all the others. |
|
443 |
Handle super_loader(THREAD, super_klass->class_loader()); |
|
444 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
445 |
if (target_loader() != super_loader()) { |
1 | 446 |
ResourceMark rm(THREAD); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
447 |
Symbol* failed_type_symbol = |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
448 |
SystemDictionary::check_signature_loaders(signature, target_loader, |
1 | 449 |
super_loader, true, |
450 |
CHECK_(false)); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
451 |
if (failed_type_symbol != NULL) { |
1 | 452 |
const char* msg = "loader constraint violation: when resolving " |
453 |
"overridden method \"%s\" the class loader (instance" |
|
454 |
" of %s) of the current class, %s, and its superclass loader " |
|
455 |
"(instance of %s), have different Class objects for the type " |
|
456 |
"%s used in the signature"; |
|
457 |
char* sig = target_method()->name_and_sig_as_C_string(); |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
458 |
const char* loader1 = SystemDictionary::loader_name(target_loader()); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
459 |
char* current = target_klass->name()->as_C_string(); |
1 | 460 |
const char* loader2 = SystemDictionary::loader_name(super_loader()); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
461 |
char* failed_type_name = failed_type_symbol->as_C_string(); |
1 | 462 |
size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + |
463 |
strlen(current) + strlen(loader2) + strlen(failed_type_name); |
|
464 |
char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); |
|
465 |
jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, |
|
466 |
failed_type_name); |
|
467 |
THROW_MSG_(vmSymbols::java_lang_LinkageError(), buf, false); |
|
468 |
} |
|
469 |
} |
|
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
470 |
} |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
471 |
|
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
472 |
put_method_at(target_method(), i); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
473 |
overrides = true; |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
474 |
if (!is_default) { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
475 |
target_method()->set_vtable_index(i); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
476 |
} else { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
477 |
if (def_vtable_indices != NULL) { |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
478 |
def_vtable_indices->at_put(default_index, i); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
479 |
} |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
480 |
assert(super_method->is_default_method() || super_method->is_overpass() |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
481 |
|| super_method->is_abstract(), "default override error"); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
482 |
} |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
483 |
} else { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
484 |
overrides = false; |
1 | 485 |
} |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
486 |
log_vtables(i, overrides, target_method, target_klass, super_method, THREAD); |
1 | 487 |
} |
488 |
} |
|
489 |
return allocate_new; |
|
490 |
} |
|
491 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
492 |
void klassVtable::put_method_at(Method* m, int index) { |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
493 |
if (log_develop_is_enabled(Trace, vtables)) { |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
494 |
ResourceMark rm; |
37242 | 495 |
outputStream* logst = Log(vtables)::trace_stream(); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
496 |
const char* sig = (m != NULL) ? m->name_and_sig_as_C_string() : "<NULL>"; |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
497 |
logst->print("adding %s at index %d, flags: ", sig, index); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
498 |
if (m != NULL) { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
499 |
m->print_linkage_flags(logst); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
500 |
} |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
501 |
logst->cr(); |
1 | 502 |
} |
503 |
table()[index].set(m); |
|
504 |
} |
|
505 |
||
506 |
// Find out if a method "m" with superclass "super", loader "classloader" and |
|
507 |
// name "classname" needs a new vtable entry. Let P be a class package defined |
|
508 |
// by "classloader" and "classname". |
|
509 |
// NOTE: The logic used here is very similar to the one used for computing |
|
510 |
// the vtables indices for a method. We cannot directly use that function because, |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
511 |
// we allocate the InstanceKlass at load time, and that requires that the |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
512 |
// superclass has been loaded. |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
513 |
// However, the vtable entries are filled in at link time, and therefore |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
514 |
// the superclass' vtable may not yet have been filled in. |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
515 |
bool klassVtable::needs_new_vtable_entry(methodHandle target_method, |
34666 | 516 |
const Klass* super, |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
517 |
Handle classloader, |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
518 |
Symbol* classname, |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
519 |
AccessFlags class_flags, |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
520 |
TRAPS) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
521 |
if (class_flags.is_interface()) { |
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
522 |
// Interfaces do not use vtables, except for java.lang.Object methods, |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
523 |
// so there is no point to assigning |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
524 |
// a vtable index to any of their local methods. If we refrain from doing this, |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
525 |
// we can use Method::_vtable_index to hold the itable index |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
526 |
return false; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
527 |
} |
14385 | 528 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
529 |
if (target_method->is_final_method(class_flags) || |
1 | 530 |
// a final method never needs a new entry; final methods can be statically |
531 |
// resolved and they have to be present in the vtable only if they override |
|
532 |
// a super's method, in which case they re-use its entry |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
533 |
(target_method()->is_static()) || |
1 | 534 |
// static methods don't need to be in vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
535 |
(target_method()->name() == vmSymbols::object_initializer_name()) |
1 | 536 |
// <init> is never called dynamically-bound |
537 |
) { |
|
538 |
return false; |
|
539 |
} |
|
540 |
||
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
541 |
// Concrete interface methods do not need new entries, they override |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
542 |
// abstract method entries using default inheritance rules |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
543 |
if (target_method()->method_holder() != NULL && |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
544 |
target_method()->method_holder()->is_interface() && |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
545 |
!target_method()->is_abstract() ) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
546 |
return false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
547 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
548 |
|
1 | 549 |
// we need a new entry if there is no superclass |
550 |
if (super == NULL) { |
|
551 |
return true; |
|
552 |
} |
|
553 |
||
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
554 |
// private methods in classes always have a new entry in the vtable |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
555 |
// specification interpretation since classic has |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
556 |
// private methods not overriding |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
557 |
// JDK8 adds private methods in interfaces which require invokespecial |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
558 |
if (target_method()->is_private()) { |
1 | 559 |
return true; |
560 |
} |
|
561 |
||
25504
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
562 |
// Package private methods always need a new entry to root their own |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
563 |
// overriding. This allows transitive overriding to work. |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
564 |
if (target_method()->is_package_private()) { |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
565 |
return true; |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
566 |
} |
69de8357bc53
8032536: JVM resolves wrong method in some unusual cases
hseigel
parents:
24424
diff
changeset
|
567 |
|
1 | 568 |
// search through the super class hierarchy to see if we need |
569 |
// a new entry |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
570 |
ResourceMark rm; |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
571 |
Symbol* name = target_method()->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
572 |
Symbol* signature = target_method()->signature(); |
34666 | 573 |
const Klass* k = super; |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
574 |
Method* super_method = NULL; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
575 |
InstanceKlass *holder = NULL; |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
576 |
Method* recheck_method = NULL; |
1 | 577 |
while (k != NULL) { |
578 |
// lookup through the hierarchy for a method with matching name and sign. |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
579 |
super_method = InstanceKlass::cast(k)->lookup_method(name, signature); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
580 |
if (super_method == NULL) { |
1 | 581 |
break; // we still have to search for a matching miranda method |
582 |
} |
|
583 |
// get the class holding the matching method |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
584 |
// make sure you use that class for is_override |
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
585 |
InstanceKlass* superk = super_method->method_holder(); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
586 |
// we want only instance method matches |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
587 |
// pretend private methods are not in the super vtable |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
588 |
// since we do override around them: e.g. a.m pub/b.m private/c.m pub, |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
589 |
// ignore private, c.m pub does override a.m pub |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
590 |
// For classes that were not javac'd together, we also do transitive overriding around |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
591 |
// methods that have less accessibility |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
592 |
if ((!super_method->is_static()) && |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
593 |
(!super_method->is_private())) { |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
594 |
if (superk->is_override(super_method, classloader, classname, THREAD)) { |
1 | 595 |
return false; |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
596 |
// else keep looking for transitive overrides |
1 | 597 |
} |
598 |
} |
|
599 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
600 |
// Start with lookup result and continue to search up |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
601 |
k = superk->super(); // haven't found an override match yet; continue to look |
1 | 602 |
} |
603 |
||
604 |
// if the target method is public or protected it may have a matching |
|
605 |
// miranda method in the super, whose entry it should re-use. |
|
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
606 |
// Actually, to handle cases that javac would not generate, we need |
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
607 |
// this check for all access permissions. |
34666 | 608 |
const InstanceKlass *sk = InstanceKlass::cast(super); |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
609 |
if (sk->has_miranda_methods()) { |
28731
f7339cba0a6a
8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents:
28373
diff
changeset
|
610 |
if (sk->lookup_method_in_all_interfaces(name, signature, Klass::find_defaults) != NULL) { |
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
611 |
return false; // found a matching miranda; we do not need a new entry |
1 | 612 |
} |
613 |
} |
|
614 |
return true; // found no match; we need a new entry |
|
615 |
} |
|
616 |
||
617 |
// Support for miranda methods |
|
618 |
||
619 |
// get the vtable index of a miranda method with matching "name" and "signature" |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
620 |
int klassVtable::index_of_miranda(Symbol* name, Symbol* signature) { |
1 | 621 |
// search from the bottom, might be faster |
622 |
for (int i = (length() - 1); i >= 0; i--) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
623 |
Method* m = table()[i].method(); |
1 | 624 |
if (is_miranda_entry_at(i) && |
625 |
m->name() == name && m->signature() == signature) { |
|
626 |
return i; |
|
627 |
} |
|
628 |
} |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
629 |
return Method::invalid_vtable_index; |
1 | 630 |
} |
631 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
632 |
// check if an entry at an index is miranda |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
633 |
// requires that method m at entry be declared ("held") by an interface. |
1 | 634 |
bool klassVtable::is_miranda_entry_at(int i) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
635 |
Method* m = method_at(i); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
636 |
Klass* method_holder = m->method_holder(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
637 |
InstanceKlass *mhk = InstanceKlass::cast(method_holder); |
1 | 638 |
|
20284
595a25ab9474
8011311: Private interface methods. Default conflicts:ICCE. no erased_super_default.
acorn
parents:
20017
diff
changeset
|
639 |
// miranda methods are public abstract instance interface methods in a class's vtable |
1 | 640 |
if (mhk->is_interface()) { |
14385 | 641 |
assert(m->is_public(), "should be public"); |
1 | 642 |
assert(ik()->implements_interface(method_holder) , "this class should implement the interface"); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
643 |
if (is_miranda(m, ik()->methods(), ik()->default_methods(), ik()->super())) { |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
644 |
return true; |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
645 |
} |
1 | 646 |
} |
647 |
return false; |
|
648 |
} |
|
649 |
||
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
650 |
// Check if a method is a miranda method, given a class's methods array, |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
651 |
// its default_method table and its super class. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
652 |
// "Miranda" means an abstract non-private method that would not be |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
653 |
// overridden for the local class. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
654 |
// A "miranda" method should only include non-private interface |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
655 |
// instance methods, i.e. not private methods, not static methods, |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
656 |
// not default methods (concrete interface methods), not overpass methods. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
657 |
// If a given class already has a local (including overpass) method, a |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
658 |
// default method, or any of its superclasses has the same which would have |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
659 |
// overridden an abstract method, then this is not a miranda method. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
660 |
// |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
661 |
// Miranda methods are checked multiple times. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
662 |
// Pass 1: during class load/class file parsing: before vtable size calculation: |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
663 |
// include superinterface abstract and default methods (non-private instance). |
29871 | 664 |
// We include potential default methods to give them space in the vtable. |
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
665 |
// During the first run, the current instanceKlass has not yet been |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
666 |
// created, the superclasses and superinterfaces do have instanceKlasses |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
667 |
// but may not have vtables, the default_methods list is empty, no overpasses. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
668 |
// This is seen by default method creation. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
669 |
// |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
670 |
// Pass 2: recalculated during vtable initialization: only include abstract methods. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
671 |
// The goal of pass 2 is to walk through the superinterfaces to see if any of |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
672 |
// the superinterface methods (which were all abstract pre-default methods) |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
673 |
// need to be added to the vtable. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
674 |
// With the addition of default methods, we have three new challenges: |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
675 |
// overpasses, static interface methods and private interface methods. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
676 |
// Static and private interface methods do not get added to the vtable and |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
677 |
// are not seen by the method resolution process, so we skip those. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
678 |
// Overpass methods are already in the vtable, so vtable lookup will |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
679 |
// find them and we don't need to add a miranda method to the end of |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
680 |
// the vtable. So we look for overpass methods and if they are found we |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
681 |
// return false. Note that we inherit our superclasses vtable, so |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
682 |
// the superclass' search also needs to use find_overpass so that if |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
683 |
// one is found we return false. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
684 |
// False means - we don't need a miranda method added to the vtable. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
685 |
// |
29871 | 686 |
// During the second run, default_methods is set up, so concrete methods from |
687 |
// superinterfaces with matching names/signatures to default_methods are already |
|
688 |
// in the default_methods list and do not need to be appended to the vtable |
|
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
689 |
// as mirandas. Abstract methods may already have been handled via |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
690 |
// overpasses - either local or superclass overpasses, which may be |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
691 |
// in the vtable already. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
692 |
// |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
693 |
// Pass 3: They are also checked by link resolution and selection, |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
694 |
// for invocation on a method (not interface method) reference that |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
695 |
// resolves to a method with an interface as its method_holder. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
696 |
// Used as part of walking from the bottom of the vtable to find |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
697 |
// the vtable index for the miranda method. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
698 |
// |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
699 |
// Part of the Miranda Rights in the US mean that if you do not have |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
700 |
// an attorney one will be appointed for you. |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
701 |
bool klassVtable::is_miranda(Method* m, Array<Method*>* class_methods, |
34666 | 702 |
Array<Method*>* default_methods, const Klass* super) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
703 |
if (m->is_static() || m->is_private() || m->is_overpass()) { |
17092
8d0bef547de9
8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
bharadwaj
parents:
16591
diff
changeset
|
704 |
return false; |
8d0bef547de9
8013418: assert(i == total_args_passed) in AdapterHandlerLibrary::get_adapter since 8-b87
bharadwaj
parents:
16591
diff
changeset
|
705 |
} |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
706 |
Symbol* name = m->name(); |
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7443
diff
changeset
|
707 |
Symbol* signature = m->signature(); |
21913
0e2fd7282ac6
8028438: static superclass method masks default methods
acorn
parents:
21770
diff
changeset
|
708 |
|
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
709 |
// First look in local methods to see if already covered |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
710 |
if (InstanceKlass::find_local_method(class_methods, name, signature, |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
711 |
Klass::find_overpass, Klass::skip_static, Klass::skip_private) != NULL) |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
712 |
{ |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
713 |
return false; |
1 | 714 |
} |
7443
39c85d63abf2
6989076: JVM crashes in klassItable::initialize_itable_for_interface
dsamersoff
parents:
7397
diff
changeset
|
715 |
|
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
716 |
// Check local default methods |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
717 |
if ((default_methods != NULL) && |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
718 |
(InstanceKlass::find_method(default_methods, name, signature) != NULL)) |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
719 |
{ |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
720 |
return false; |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
721 |
} |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
722 |
|
33602 | 723 |
// Iterate on all superclasses, which should be InstanceKlasses. |
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
724 |
// Note that we explicitly look for overpasses at each level. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
725 |
// Overpasses may or may not exist for supers for pass 1, |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
726 |
// they should have been created for pass 2 and later. |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
727 |
|
34666 | 728 |
for (const Klass* cursuper = super; cursuper != NULL; cursuper = cursuper->super()) |
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
729 |
{ |
33602 | 730 |
if (InstanceKlass::cast(cursuper)->find_local_method(name, signature, |
32189
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
731 |
Klass::find_overpass, Klass::skip_static, Klass::skip_private) != NULL) { |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
732 |
return false; |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
733 |
} |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
734 |
} |
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
735 |
|
5264b560ab1b
8087342: Crash in klassItable::initialize_itable_for_interface
acorn
parents:
31019
diff
changeset
|
736 |
return true; |
1 | 737 |
} |
738 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
739 |
// Scans current_interface_methods for miranda methods that do not |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
740 |
// already appear in new_mirandas, or default methods, and are also not defined-and-non-private |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
741 |
// in super (superclass). These mirandas are added to all_mirandas if it is |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
742 |
// not null; in addition, those that are not duplicates of miranda methods |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
743 |
// inherited by super from its interfaces are added to new_mirandas. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
744 |
// Thus, new_mirandas will be the set of mirandas that this class introduces, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
745 |
// all_mirandas will be the set of all mirandas applicable to this class |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
746 |
// including all defined in superclasses. |
14385 | 747 |
void klassVtable::add_new_mirandas_to_lists( |
748 |
GrowableArray<Method*>* new_mirandas, GrowableArray<Method*>* all_mirandas, |
|
749 |
Array<Method*>* current_interface_methods, Array<Method*>* class_methods, |
|
34666 | 750 |
Array<Method*>* default_methods, const Klass* super) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
751 |
|
1 | 752 |
// iterate thru the current interface's method to see if it a miranda |
753 |
int num_methods = current_interface_methods->length(); |
|
754 |
for (int i = 0; i < num_methods; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
755 |
Method* im = current_interface_methods->at(i); |
1 | 756 |
bool is_duplicate = false; |
14385 | 757 |
int num_of_current_mirandas = new_mirandas->length(); |
1 | 758 |
// check for duplicate mirandas in different interfaces we implement |
759 |
for (int j = 0; j < num_of_current_mirandas; j++) { |
|
14385 | 760 |
Method* miranda = new_mirandas->at(j); |
1 | 761 |
if ((im->name() == miranda->name()) && |
762 |
(im->signature() == miranda->signature())) { |
|
763 |
is_duplicate = true; |
|
764 |
break; |
|
765 |
} |
|
766 |
} |
|
767 |
||
768 |
if (!is_duplicate) { // we don't want duplicate miranda entries in the vtable |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
769 |
if (is_miranda(im, class_methods, default_methods, super)) { // is it a miranda at all? |
34666 | 770 |
const InstanceKlass *sk = InstanceKlass::cast(super); |
1 | 771 |
// check if it is a duplicate of a super's miranda |
28731
f7339cba0a6a
8067480: Crash in klassItable::initialize_itable_for_interface when running vm.runtime.defmeth.StaticMethodsTest.
lfoltan
parents:
28373
diff
changeset
|
772 |
if (sk->lookup_method_in_all_interfaces(im->name(), im->signature(), Klass::find_defaults) == NULL) { |
14385 | 773 |
new_mirandas->append(im); |
774 |
} |
|
775 |
if (all_mirandas != NULL) { |
|
776 |
all_mirandas->append(im); |
|
1 | 777 |
} |
778 |
} |
|
779 |
} |
|
780 |
} |
|
781 |
} |
|
782 |
||
14385 | 783 |
void klassVtable::get_mirandas(GrowableArray<Method*>* new_mirandas, |
784 |
GrowableArray<Method*>* all_mirandas, |
|
34666 | 785 |
const Klass* super, |
786 |
Array<Method*>* class_methods, |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
787 |
Array<Method*>* default_methods, |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
788 |
Array<Klass*>* local_interfaces) { |
14385 | 789 |
assert((new_mirandas->length() == 0) , "current mirandas must be 0"); |
1 | 790 |
|
791 |
// iterate thru the local interfaces looking for a miranda |
|
792 |
int num_local_ifs = local_interfaces->length(); |
|
793 |
for (int i = 0; i < num_local_ifs; i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
794 |
InstanceKlass *ik = InstanceKlass::cast(local_interfaces->at(i)); |
14385 | 795 |
add_new_mirandas_to_lists(new_mirandas, all_mirandas, |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
796 |
ik->methods(), class_methods, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
797 |
default_methods, super); |
1 | 798 |
// iterate thru each local's super interfaces |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
799 |
Array<Klass*>* super_ifs = ik->transitive_interfaces(); |
1 | 800 |
int num_super_ifs = super_ifs->length(); |
801 |
for (int j = 0; j < num_super_ifs; j++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
802 |
InstanceKlass *sik = InstanceKlass::cast(super_ifs->at(j)); |
14385 | 803 |
add_new_mirandas_to_lists(new_mirandas, all_mirandas, |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
804 |
sik->methods(), class_methods, |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
805 |
default_methods, super); |
1 | 806 |
} |
807 |
} |
|
808 |
} |
|
809 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
810 |
// Discover miranda methods ("miranda" = "interface abstract, no binding"), |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
811 |
// and append them into the vtable starting at index initialized, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
812 |
// return the new value of initialized. |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
813 |
// Miranda methods use vtable entries, but do not get assigned a vtable_index |
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
814 |
// The vtable_index is discovered by searching from the end of the vtable |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
815 |
int klassVtable::fill_in_mirandas(int initialized) { |
14385 | 816 |
GrowableArray<Method*> mirandas(20); |
817 |
get_mirandas(&mirandas, NULL, ik()->super(), ik()->methods(), |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
818 |
ik()->default_methods(), ik()->local_interfaces()); |
14385 | 819 |
for (int i = 0; i < mirandas.length(); i++) { |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
820 |
if (log_develop_is_enabled(Trace, vtables)) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
821 |
Method* meth = mirandas.at(i); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
822 |
ResourceMark rm(Thread::current()); |
37242 | 823 |
outputStream* logst = Log(vtables)::trace_stream(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
824 |
if (meth != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
825 |
char* sig = meth->name_and_sig_as_C_string(); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
826 |
logst->print("fill in mirandas with %s index %d, flags: ", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
827 |
sig, initialized); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
828 |
meth->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
829 |
logst->cr(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
830 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
831 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
832 |
put_method_at(mirandas.at(i), initialized); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
833 |
++initialized; |
1 | 834 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
835 |
return initialized; |
1 | 836 |
} |
837 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
838 |
// Copy this class's vtable to the vtable beginning at start. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
839 |
// Used to copy superclass vtable to prefix of subclass's vtable. |
1 | 840 |
void klassVtable::copy_vtable_to(vtableEntry* start) { |
841 |
Copy::disjoint_words((HeapWord*)table(), (HeapWord*)start, _length * vtableEntry::size()); |
|
842 |
} |
|
843 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
844 |
#if INCLUDE_JVMTI |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
845 |
bool klassVtable::adjust_default_method(int vtable_index, Method* old_method, Method* new_method) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
846 |
// If old_method is default, find this vtable index in default_vtable_indices |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
847 |
// and replace that method in the _default_methods list |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
848 |
bool updated = false; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
849 |
|
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
850 |
Array<Method*>* default_methods = ik()->default_methods(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
851 |
if (default_methods != NULL) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
852 |
int len = default_methods->length(); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
853 |
for (int idx = 0; idx < len; idx++) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
854 |
if (vtable_index == ik()->default_vtable_indices()->at(idx)) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
855 |
if (default_methods->at(idx) == old_method) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
856 |
default_methods->at_put(idx, new_method); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
857 |
updated = true; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
858 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
859 |
break; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
860 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
861 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
862 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
863 |
return updated; |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
864 |
} |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
865 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
866 |
// search the vtable for uses of either obsolete or EMCP methods |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
867 |
void klassVtable::adjust_method_entries(InstanceKlass* holder, bool * trace_name_printed) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
868 |
int prn_enabled = 0; |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
869 |
for (int index = 0; index < length(); index++) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
870 |
Method* old_method = unchecked_method_at(index); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
871 |
if (old_method == NULL || old_method->method_holder() != holder || !old_method->is_old()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
872 |
continue; // skip uninteresting entries |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
873 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
874 |
assert(!old_method->is_deleted(), "vtable methods may not be deleted"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
875 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
876 |
Method* new_method = holder->method_with_idnum(old_method->orig_method_idnum()); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
877 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
878 |
assert(new_method != NULL, "method_with_idnum() should not be NULL"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
879 |
assert(old_method != new_method, "sanity check"); |
1 | 880 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
881 |
put_method_at(new_method, index); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
882 |
// For default methods, need to update the _default_methods array |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
883 |
// which can only have one method entry for a given signature |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
884 |
bool updated_default = false; |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
885 |
if (old_method->is_default_method()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
886 |
updated_default = adjust_default_method(index, old_method, new_method); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
887 |
} |
1 | 888 |
|
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
889 |
if (log_is_enabled(Info, redefine, class, update)) { |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
890 |
ResourceMark rm; |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
891 |
if (!(*trace_name_printed)) { |
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
892 |
log_info(redefine, class, update) |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
893 |
("adjust: klassname=%s for methods from name=%s", |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
894 |
klass()->external_name(), old_method->method_holder()->external_name()); |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
895 |
*trace_name_printed = true; |
1 | 896 |
} |
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
897 |
log_debug(redefine, class, update, vtables) |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
898 |
("vtable method update: %s(%s), updated default = %s", |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
899 |
new_method->name()->as_C_string(), new_method->signature()->as_C_string(), updated_default ? "true" : "false"); |
1 | 900 |
} |
901 |
} |
|
902 |
} |
|
903 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
904 |
// a vtable should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
905 |
bool klassVtable::check_no_old_or_obsolete_entries() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
906 |
for (int i = 0; i < length(); i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
907 |
Method* m = unchecked_method_at(i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
908 |
if (m != NULL && |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
909 |
(NOT_PRODUCT(!m->is_valid() ||) m->is_old() || m->is_obsolete())) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
910 |
return false; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
911 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
912 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
913 |
return true; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
914 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
915 |
|
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
916 |
void klassVtable::dump_vtable() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
917 |
tty->print_cr("vtable dump --"); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
918 |
for (int i = 0; i < length(); i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
919 |
Method* m = unchecked_method_at(i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
920 |
if (m != NULL) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
921 |
tty->print(" (%5d) ", i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
922 |
m->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
923 |
if (m->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
924 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
925 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
926 |
if (m->is_overpass()) { |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
927 |
tty->print("overpass"); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
928 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
929 |
tty->print(" -- "); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
930 |
m->print_name(tty); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
931 |
tty->cr(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
932 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
933 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
934 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
935 |
#endif // INCLUDE_JVMTI |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
936 |
|
9172
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
937 |
// CDS/RedefineClasses support - clear vtables so they can be reinitialized |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
938 |
void klassVtable::clear_vtable() { |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
939 |
for (int i = 0; i < _length; i++) table()[i].clear(); |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
940 |
} |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
941 |
|
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
942 |
bool klassVtable::is_initialized() { |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
943 |
return _length == 0 || table()[0].method() != NULL; |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
944 |
} |
a4e13ccafc44
7032407: Crash in LinkResolver::runtime_resolve_virtual_method()
coleenp
parents:
8725
diff
changeset
|
945 |
|
1 | 946 |
//----------------------------------------------------------------------------------------- |
947 |
// Itable code |
|
948 |
||
949 |
// Initialize a itableMethodEntry |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
950 |
void itableMethodEntry::initialize(Method* m) { |
1 | 951 |
if (m == NULL) return; |
952 |
||
953 |
_method = m; |
|
954 |
} |
|
955 |
||
956 |
klassItable::klassItable(instanceKlassHandle klass) { |
|
957 |
_klass = klass; |
|
958 |
||
959 |
if (klass->itable_length() > 0) { |
|
960 |
itableOffsetEntry* offset_entry = (itableOffsetEntry*)klass->start_of_itable(); |
|
961 |
if (offset_entry != NULL && offset_entry->interface_klass() != NULL) { // Check that itable is initialized |
|
962 |
// First offset entry points to the first method_entry |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
963 |
intptr_t* method_entry = (intptr_t *)(((address)klass()) + offset_entry->offset()); |
1 | 964 |
intptr_t* end = klass->end_of_itable(); |
965 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
966 |
_table_offset = (intptr_t*)offset_entry - (intptr_t*)klass(); |
1 | 967 |
_size_offset_table = (method_entry - ((intptr_t*)offset_entry)) / itableOffsetEntry::size(); |
968 |
_size_method_table = (end - method_entry) / itableMethodEntry::size(); |
|
969 |
assert(_table_offset >= 0 && _size_offset_table >= 0 && _size_method_table >= 0, "wrong computation"); |
|
970 |
return; |
|
971 |
} |
|
972 |
} |
|
973 |
||
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
974 |
// The length of the itable was either zero, or it has not yet been initialized. |
1 | 975 |
_table_offset = 0; |
976 |
_size_offset_table = 0; |
|
977 |
_size_method_table = 0; |
|
978 |
} |
|
979 |
||
980 |
static int initialize_count = 0; |
|
981 |
||
982 |
// Initialization |
|
983 |
void klassItable::initialize_itable(bool checkconstraints, TRAPS) { |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
984 |
if (_klass->is_interface()) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
985 |
// This needs to go after vtable indices are assigned but |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
986 |
// before implementors need to know the number of itable indices. |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
987 |
assign_itable_indices_for_interface(_klass()); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
988 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
989 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
990 |
// Cannot be setup doing bootstrapping, interfaces don't have |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
991 |
// itables, and klass with only ones entry have empty itables |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
992 |
if (Universe::is_bootstrapping() || |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
993 |
_klass->is_interface() || |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
994 |
_klass->itable_length() == itableOffsetEntry::size()) return; |
1 | 995 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
996 |
// There's alway an extra itable entry so we can null-terminate it. |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
997 |
guarantee(size_offset_table() >= 1, "too small"); |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
998 |
int num_interfaces = size_offset_table() - 1; |
1 | 999 |
if (num_interfaces > 0) { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1000 |
log_develop_debug(itables)("%3d: Initializing itables for %s", ++initialize_count, |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1001 |
_klass->name()->as_C_string()); |
1 | 1002 |
|
1003 |
||
2264
55d0115a54fe
4766230: Hotspot vtable inconsistencies cause core dumps. 6579515. 6582242.
acorn
parents:
2136
diff
changeset
|
1004 |
// Iterate through all interfaces |
1 | 1005 |
int i; |
1006 |
for(i = 0; i < num_interfaces; i++) { |
|
1007 |
itableOffsetEntry* ioe = offset_entry(i); |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1008 |
HandleMark hm(THREAD); |
1 | 1009 |
KlassHandle interf_h (THREAD, ioe->interface_klass()); |
1010 |
assert(interf_h() != NULL && ioe->offset() != 0, "bad offset entry in itable"); |
|
1011 |
initialize_itable_for_interface(ioe->offset(), interf_h, checkconstraints, CHECK); |
|
1012 |
} |
|
1013 |
||
1014 |
} |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1015 |
// Check that the last entry is empty |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1016 |
itableOffsetEntry* ioe = offset_entry(size_offset_table() - 1); |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1017 |
guarantee(ioe->interface_klass() == NULL && ioe->offset() == 0, "terminator entry missing"); |
1 | 1018 |
} |
1019 |
||
1020 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1021 |
inline bool interface_method_needs_itable_index(Method* m) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1022 |
if (m->is_static()) return false; // e.g., Stream.empty |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1023 |
if (m->is_initializer()) return false; // <init> or <clinit> |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1024 |
// If an interface redeclares a method from java.lang.Object, |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1025 |
// it should already have a vtable index, don't touch it. |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1026 |
// e.g., CharSequence.toString (from initialize_vtable) |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1027 |
// if (m->has_vtable_index()) return false; // NO! |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1028 |
return true; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1029 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1030 |
|
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1031 |
int klassItable::assign_itable_indices_for_interface(Klass* klass) { |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1032 |
// an interface does not have an itable, but its methods need to be numbered |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1033 |
log_develop_debug(itables)("%3d: Initializing itable indices for interface %s", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1034 |
++initialize_count, klass->name()->as_C_string()); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1035 |
Array<Method*>* methods = InstanceKlass::cast(klass)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1036 |
int nof_methods = methods->length(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1037 |
int ime_num = 0; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1038 |
for (int i = 0; i < nof_methods; i++) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1039 |
Method* m = methods->at(i); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1040 |
if (interface_method_needs_itable_index(m)) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1041 |
assert(!m->is_final_method(), "no final interface methods"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1042 |
// If m is already assigned a vtable index, do not disturb it. |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
1043 |
if (log_develop_is_enabled(Trace, itables)) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1044 |
ResourceMark rm; |
37242 | 1045 |
outputStream* logst = Log(itables)::trace_stream(); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1046 |
assert(m != NULL, "methods can never be null"); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1047 |
const char* sig = m->name_and_sig_as_C_string(); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1048 |
if (m->has_vtable_index()) { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1049 |
logst->print("vtable index %d for method: %s, flags: ", m->vtable_index(), sig); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1050 |
} else { |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1051 |
logst->print("itable index %d for method: %s, flags: ", ime_num, sig); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1052 |
} |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1053 |
m->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1054 |
logst->cr(); |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1055 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1056 |
if (!m->has_vtable_index()) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1057 |
assert(m->vtable_index() == Method::pending_itable_index, "set by initialize_vtable"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1058 |
m->set_itable_index(ime_num); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1059 |
// Progress to next itable entry |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1060 |
ime_num++; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1061 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1062 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1063 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1064 |
assert(ime_num == method_count_for_interface(klass), "proper sizing"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1065 |
return ime_num; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1066 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1067 |
|
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1068 |
int klassItable::method_count_for_interface(Klass* interf) { |
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
1069 |
assert(interf->is_instance_klass(), "must be"); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1070 |
assert(interf->is_interface(), "must be"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1071 |
Array<Method*>* methods = InstanceKlass::cast(interf)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1072 |
int nof_methods = methods->length(); |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1073 |
int length = 0; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1074 |
while (nof_methods > 0) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1075 |
Method* m = methods->at(nof_methods-1); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1076 |
if (m->has_itable_index()) { |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1077 |
length = m->itable_index() + 1; |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1078 |
break; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1079 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1080 |
nof_methods -= 1; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1081 |
} |
30615
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1082 |
#ifdef ASSERT |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1083 |
int nof_methods_copy = nof_methods; |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1084 |
while (nof_methods_copy > 0) { |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1085 |
Method* mm = methods->at(--nof_methods_copy); |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1086 |
assert(!mm->has_itable_index() || mm->itable_index() < length, ""); |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1087 |
} |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1088 |
#endif //ASSERT |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1089 |
// return the rightmost itable index, plus one; or 0 if no methods have |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1090 |
// itable indices |
4713e7c7b96f
8030680: 292 cleanup from default method code assessment
acorn
parents:
29871
diff
changeset
|
1091 |
return length; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1092 |
} |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1093 |
|
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1094 |
|
1 | 1095 |
void klassItable::initialize_itable_for_interface(int method_table_offset, KlassHandle interf_h, bool checkconstraints, TRAPS) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1096 |
Array<Method*>* methods = InstanceKlass::cast(interf_h())->methods(); |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1097 |
int nof_methods = methods->length(); |
1 | 1098 |
HandleMark hm; |
5402
c51fd0c1d005
6888953: some calls to function-like macros are missing semicolons
jcoomes
parents:
2343
diff
changeset
|
1099 |
assert(nof_methods > 0, "at least one method must exist for interface to be in vtable"); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1100 |
Handle interface_loader (THREAD, InstanceKlass::cast(interf_h())->class_loader()); |
1 | 1101 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1102 |
int ime_count = method_count_for_interface(interf_h()); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1103 |
for (int i = 0; i < nof_methods; i++) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1104 |
Method* m = methods->at(i); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1105 |
methodHandle target; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1106 |
if (m->has_itable_index()) { |
22232
26acfad336c0
8027804: JCK resolveMethod test fails expecting AbstractMethodError
hseigel
parents:
21913
diff
changeset
|
1107 |
// This search must match the runtime resolution, i.e. selection search for invokeinterface |
26acfad336c0
8027804: JCK resolveMethod test fails expecting AbstractMethodError
hseigel
parents:
21913
diff
changeset
|
1108 |
// to correctly enforce loader constraints for interface method inheritance |
31019 | 1109 |
target = LinkResolver::lookup_instance_method_in_klasses(_klass, m->name(), m->signature(), CHECK); |
1 | 1110 |
} |
1111 |
if (target == NULL || !target->is_public() || target->is_abstract()) { |
|
21770
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1112 |
// Entry does not resolve. Leave it empty for AbstractMethodError. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1113 |
if (!(target == NULL) && !target->is_public()) { |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1114 |
// Stuff an IllegalAccessError throwing method in there instead. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1115 |
itableOffsetEntry::method_entry(_klass(), method_table_offset)[m->itable_index()]. |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1116 |
initialize(Universe::throw_illegal_access_error()); |
e8932d2fda2c
8016839: JSR292: AME instead of IAE when calling a method
drchase
parents:
21556
diff
changeset
|
1117 |
} |
1 | 1118 |
} else { |
1119 |
// Entry did resolve, check loader constraints before initializing |
|
1120 |
// if checkconstraints requested |
|
1121 |
if (checkconstraints) { |
|
14391
df0a1573d5bd
8000725: NPG: method_holder() and pool_holder() and pool_holder field should be InstanceKlass
coleenp
parents:
14385
diff
changeset
|
1122 |
Handle method_holder_loader (THREAD, target->method_holder()->class_loader()); |
1 | 1123 |
if (method_holder_loader() != interface_loader()) { |
1124 |
ResourceMark rm(THREAD); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1125 |
Symbol* failed_type_symbol = |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1126 |
SystemDictionary::check_signature_loaders(m->signature(), |
1 | 1127 |
method_holder_loader, |
1128 |
interface_loader, |
|
1129 |
true, CHECK); |
|
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1130 |
if (failed_type_symbol != NULL) { |
1 | 1131 |
const char* msg = "loader constraint violation in interface " |
1132 |
"itable initialization: when resolving method \"%s\" the class" |
|
1133 |
" loader (instance of %s) of the current class, %s, " |
|
1134 |
"and the class loader (instance of %s) for interface " |
|
1135 |
"%s have different Class objects for the type %s " |
|
1136 |
"used in the signature"; |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1137 |
char* sig = target()->name_and_sig_as_C_string(); |
1 | 1138 |
const char* loader1 = SystemDictionary::loader_name(method_holder_loader()); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1139 |
char* current = _klass->name()->as_C_string(); |
1 | 1140 |
const char* loader2 = SystemDictionary::loader_name(interface_loader()); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1141 |
char* iface = InstanceKlass::cast(interf_h())->name()->as_C_string(); |
16591
73047b0eb568
8009731: Confusing error message for loader constraint violation
acorn
parents:
15591
diff
changeset
|
1142 |
char* failed_type_name = failed_type_symbol->as_C_string(); |
1 | 1143 |
size_t buflen = strlen(msg) + strlen(sig) + strlen(loader1) + |
1144 |
strlen(current) + strlen(loader2) + strlen(iface) + |
|
1145 |
strlen(failed_type_name); |
|
1146 |
char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen); |
|
1147 |
jio_snprintf(buf, buflen, msg, sig, loader1, current, loader2, |
|
1148 |
iface, failed_type_name); |
|
1149 |
THROW_MSG(vmSymbols::java_lang_LinkageError(), buf); |
|
1150 |
} |
|
1151 |
} |
|
1152 |
} |
|
1153 |
||
1154 |
// ime may have moved during GC so recalculate address |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1155 |
int ime_num = m->itable_index(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1156 |
assert(ime_num < ime_count, "oob"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1157 |
itableOffsetEntry::method_entry(_klass(), method_table_offset)[ime_num].initialize(target()); |
35901
f5028c67e7cb
8147918: Rename develop_log_is_enabled() to log_develop_is_enabled()
pliden
parents:
35898
diff
changeset
|
1158 |
if (log_develop_is_enabled(Trace, itables)) { |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1159 |
ResourceMark rm(THREAD); |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1160 |
if (target() != NULL) { |
37242 | 1161 |
outputStream* logst = Log(itables)::trace_stream(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1162 |
char* sig = target()->name_and_sig_as_C_string(); |
35463
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1163 |
logst->print("interface: %s, ime_num: %d, target: %s, method_holder: %s ", |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1164 |
interf_h()->internal_name(), ime_num, sig, |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1165 |
target()->method_holder()->internal_name()); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1166 |
logst->print("target_method flags: "); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1167 |
target()->print_linkage_flags(logst); |
b32e362563bb
8141564: Convert TraceItables and PrintVtables to Unified Logging
rprotacio
parents:
34666
diff
changeset
|
1168 |
logst->cr(); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1169 |
} |
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1170 |
} |
1 | 1171 |
} |
1172 |
} |
|
1173 |
} |
|
1174 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1175 |
// Update entry for specific Method* |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1176 |
void klassItable::initialize_with_method(Method* m) { |
1 | 1177 |
itableMethodEntry* ime = method_entry(0); |
1178 |
for(int i = 0; i < _size_method_table; i++) { |
|
1179 |
if (ime->method() == m) { |
|
1180 |
ime->initialize(m); |
|
1181 |
} |
|
1182 |
ime++; |
|
1183 |
} |
|
1184 |
} |
|
1185 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1186 |
#if INCLUDE_JVMTI |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1187 |
// search the itable for uses of either obsolete or EMCP methods |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1188 |
void klassItable::adjust_method_entries(InstanceKlass* holder, bool * trace_name_printed) { |
1 | 1189 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1190 |
itableMethodEntry* ime = method_entry(0); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1191 |
for (int i = 0; i < _size_method_table; i++, ime++) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1192 |
Method* old_method = ime->method(); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1193 |
if (old_method == NULL || old_method->method_holder() != holder || !old_method->is_old()) { |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1194 |
continue; // skip uninteresting entries |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1195 |
} |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1196 |
assert(!old_method->is_deleted(), "itable methods may not be deleted"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1197 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1198 |
Method* new_method = holder->method_with_idnum(old_method->orig_method_idnum()); |
1 | 1199 |
|
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1200 |
assert(new_method != NULL, "method_with_idnum() should not be NULL"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1201 |
assert(old_method != new_method, "sanity check"); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1202 |
|
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1203 |
ime->initialize(new_method); |
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1204 |
|
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
1205 |
if (log_is_enabled(Info, redefine, class, update)) { |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
1206 |
ResourceMark rm; |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1207 |
if (!(*trace_name_printed)) { |
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
1208 |
log_info(redefine, class, update)("adjust: name=%s", old_method->method_holder()->external_name()); |
29316
5287df8a8972
8046246: the constantPoolCacheOopDesc::adjust_method_entries() used in RedefineClasses does not scale
sspitsyn
parents:
28731
diff
changeset
|
1209 |
*trace_name_printed = true; |
1 | 1210 |
} |
38259
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
1211 |
log_trace(redefine, class, update, itables) |
b495d1cfe673
8153535: Convert TraceRedefineClasses to Unified Logging
rehn
parents:
37242
diff
changeset
|
1212 |
("itable method update: %s(%s)", new_method->name()->as_C_string(), new_method->signature()->as_C_string()); |
1 | 1213 |
} |
1214 |
} |
|
1215 |
} |
|
1216 |
||
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1217 |
// an itable should never contain old or obsolete methods |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1218 |
bool klassItable::check_no_old_or_obsolete_entries() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1219 |
itableMethodEntry* ime = method_entry(0); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1220 |
for (int i = 0; i < _size_method_table; i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1221 |
Method* m = ime->method(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1222 |
if (m != NULL && |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1223 |
(NOT_PRODUCT(!m->is_valid() ||) m->is_old() || m->is_obsolete())) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1224 |
return false; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1225 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1226 |
ime++; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1227 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1228 |
return true; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1229 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1230 |
|
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1231 |
void klassItable::dump_itable() { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1232 |
itableMethodEntry* ime = method_entry(0); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1233 |
tty->print_cr("itable dump --"); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1234 |
for (int i = 0; i < _size_method_table; i++) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1235 |
Method* m = ime->method(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1236 |
if (m != NULL) { |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1237 |
tty->print(" (%5d) ", i); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1238 |
m->access_flags().print_on(tty); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1239 |
if (m->is_default_method()) { |
21556
e75cd34a59e0
8027229: ICCE expected for >=2 maximally specific default methods.
acorn
parents:
20391
diff
changeset
|
1240 |
tty->print("default "); |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1241 |
} |
15591
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1242 |
tty->print(" -- "); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1243 |
m->print_name(tty); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1244 |
tty->cr(); |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1245 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1246 |
ime++; |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1247 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1248 |
} |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1249 |
#endif // INCLUDE_JVMTI |
b8aa0577f137
7182152: Instrumentation hot swap test incorrect monitor count
dcubed
parents:
14488
diff
changeset
|
1250 |
|
1 | 1251 |
|
1252 |
// Setup |
|
1253 |
class InterfaceVisiterClosure : public StackObj { |
|
1254 |
public: |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1255 |
virtual void doit(Klass* intf, int method_count) = 0; |
1 | 1256 |
}; |
1257 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1258 |
// Visit all interfaces with at least one itable method |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1259 |
void visit_all_interfaces(Array<Klass*>* transitive_intf, InterfaceVisiterClosure *blk) { |
1 | 1260 |
// Handle array argument |
1261 |
for(int i = 0; i < transitive_intf->length(); i++) { |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1262 |
Klass* intf = transitive_intf->at(i); |
14488 | 1263 |
assert(intf->is_interface(), "sanity check"); |
1 | 1264 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1265 |
// Find no. of itable methods |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1266 |
int method_count = 0; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1267 |
// method_count = klassItable::method_count_for_interface(intf); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1268 |
Array<Method*>* methods = InstanceKlass::cast(intf)->methods(); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1269 |
if (methods->length() > 0) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1270 |
for (int i = methods->length(); --i >= 0; ) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1271 |
if (interface_method_needs_itable_index(methods->at(i))) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1272 |
method_count++; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1273 |
} |
1 | 1274 |
} |
1275 |
} |
|
1276 |
||
1277 |
// Only count interfaces with at least one method |
|
1278 |
if (method_count > 0) { |
|
1279 |
blk->doit(intf, method_count); |
|
1280 |
} |
|
1281 |
} |
|
1282 |
} |
|
1283 |
||
1284 |
class CountInterfacesClosure : public InterfaceVisiterClosure { |
|
1285 |
private: |
|
1286 |
int _nof_methods; |
|
1287 |
int _nof_interfaces; |
|
1288 |
public: |
|
1289 |
CountInterfacesClosure() { _nof_methods = 0; _nof_interfaces = 0; } |
|
1290 |
||
1291 |
int nof_methods() const { return _nof_methods; } |
|
1292 |
int nof_interfaces() const { return _nof_interfaces; } |
|
1293 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1294 |
void doit(Klass* intf, int method_count) { _nof_methods += method_count; _nof_interfaces++; } |
1 | 1295 |
}; |
1296 |
||
1297 |
class SetupItableClosure : public InterfaceVisiterClosure { |
|
1298 |
private: |
|
1299 |
itableOffsetEntry* _offset_entry; |
|
1300 |
itableMethodEntry* _method_entry; |
|
1301 |
address _klass_begin; |
|
1302 |
public: |
|
1303 |
SetupItableClosure(address klass_begin, itableOffsetEntry* offset_entry, itableMethodEntry* method_entry) { |
|
1304 |
_klass_begin = klass_begin; |
|
1305 |
_offset_entry = offset_entry; |
|
1306 |
_method_entry = method_entry; |
|
1307 |
} |
|
1308 |
||
1309 |
itableMethodEntry* method_entry() const { return _method_entry; } |
|
1310 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1311 |
void doit(Klass* intf, int method_count) { |
1 | 1312 |
int offset = ((address)_method_entry) - _klass_begin; |
1313 |
_offset_entry->initialize(intf, offset); |
|
1314 |
_offset_entry++; |
|
1315 |
_method_entry += method_count; |
|
1316 |
} |
|
1317 |
}; |
|
1318 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1319 |
int klassItable::compute_itable_size(Array<Klass*>* transitive_interfaces) { |
1 | 1320 |
// Count no of interfaces and total number of interface methods |
1321 |
CountInterfacesClosure cic; |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1322 |
visit_all_interfaces(transitive_interfaces, &cic); |
1 | 1323 |
|
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1324 |
// There's alway an extra itable entry so we can null-terminate it. |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1325 |
int itable_size = calc_itable_size(cic.nof_interfaces() + 1, cic.nof_methods()); |
1 | 1326 |
|
1327 |
// Statistics |
|
35898
ddc274f0052f
8145628: hotspot metadata classes shouldn't use HeapWordSize or heap related macros like align_object_size
coleenp
parents:
35492
diff
changeset
|
1328 |
update_stats(itable_size * wordSize); |
1 | 1329 |
|
1330 |
return itable_size; |
|
1331 |
} |
|
1332 |
||
1333 |
||
1334 |
// Fill out offset table and interface klasses into the itable space |
|
1335 |
void klassItable::setup_itable_offset_table(instanceKlassHandle klass) { |
|
1336 |
if (klass->itable_length() == 0) return; |
|
1337 |
assert(!klass->is_interface(), "Should have zero length itable"); |
|
1338 |
||
1339 |
// Count no of interfaces and total number of interface methods |
|
1340 |
CountInterfacesClosure cic; |
|
1341 |
visit_all_interfaces(klass->transitive_interfaces(), &cic); |
|
1342 |
int nof_methods = cic.nof_methods(); |
|
1343 |
int nof_interfaces = cic.nof_interfaces(); |
|
1344 |
||
189
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1345 |
// Add one extra entry so we can null-terminate the table |
4248c8e21063
6664627: Merge changes made only in hotspot 11 forward to jdk 7
dcubed
parents:
1
diff
changeset
|
1346 |
nof_interfaces++; |
1 | 1347 |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1348 |
assert(compute_itable_size(klass->transitive_interfaces()) == |
1 | 1349 |
calc_itable_size(nof_interfaces, nof_methods), |
1350 |
"mismatch calculation of itable size"); |
|
1351 |
||
1352 |
// Fill-out offset table |
|
1353 |
itableOffsetEntry* ioe = (itableOffsetEntry*)klass->start_of_itable(); |
|
1354 |
itableMethodEntry* ime = (itableMethodEntry*)(ioe + nof_interfaces); |
|
1355 |
intptr_t* end = klass->end_of_itable(); |
|
8725
8c1e3dd5fe1b
7017732: move static fields into Class to prepare for perm gen removal
never
parents:
8653
diff
changeset
|
1356 |
assert((oop*)(ime + nof_methods) <= (oop*)klass->start_of_nonstatic_oop_maps(), "wrong offset calculation (1)"); |
360
21d113ecbf6a
6420645: Create a vm that uses compressed oops for up to 32gb heapsizes
coleenp
parents:
189
diff
changeset
|
1357 |
assert((oop*)(end) == (oop*)(ime + nof_methods), "wrong offset calculation (2)"); |
1 | 1358 |
|
1359 |
// Visit all interfaces and initialize itable offset table |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1360 |
SetupItableClosure sic((address)klass(), ioe, ime); |
1 | 1361 |
visit_all_interfaces(klass->transitive_interfaces(), &sic); |
1362 |
||
1363 |
#ifdef ASSERT |
|
1364 |
ime = sic.method_entry(); |
|
1365 |
oop* v = (oop*) klass->end_of_itable(); |
|
1366 |
assert( (oop*)(ime) == v, "wrong offset calculation (2)"); |
|
1367 |
#endif |
|
1368 |
} |
|
1369 |
||
1370 |
||
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1371 |
// inverse to itable_index |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1372 |
Method* klassItable::method_for_itable_index(Klass* intf, int itable_index) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1373 |
assert(InstanceKlass::cast(intf)->is_interface(), "sanity check"); |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1374 |
assert(intf->verify_itable_index(itable_index), ""); |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1375 |
Array<Method*>* methods = InstanceKlass::cast(intf)->methods(); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1376 |
|
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1377 |
if (itable_index < 0 || itable_index >= method_count_for_interface(intf)) |
20391
7b146c5ebb18
8009130: Lambda: Fix access controls, loader constraints.
acorn
parents:
20284
diff
changeset
|
1378 |
return NULL; // help caller defend against bad indices |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1379 |
|
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1380 |
int index = itable_index; |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1381 |
Method* m = methods->at(index); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1382 |
int index2 = -1; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1383 |
while (!m->has_itable_index() || |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1384 |
(index2 = m->itable_index()) != itable_index) { |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1385 |
assert(index2 < itable_index, "monotonic"); |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1386 |
if (++index == methods->length()) |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1387 |
return NULL; |
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1388 |
m = methods->at(index); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1389 |
} |
20017
81eba62e9048
8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation
drchase
parents:
17092
diff
changeset
|
1390 |
assert(m->itable_index() == itable_index, "correct inverse"); |
2332
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1391 |
|
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1392 |
return m; |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1393 |
} |
5c7b6f4ce0a1
6814659: separable cleanups and subroutines for 6655638
jrose
parents:
2136
diff
changeset
|
1394 |
|
1 | 1395 |
void klassVtable::verify(outputStream* st, bool forced) { |
1396 |
// make sure table is initialized |
|
1397 |
if (!Universe::is_fully_initialized()) return; |
|
1398 |
#ifndef PRODUCT |
|
1399 |
// avoid redundant verifies |
|
1400 |
if (!forced && _verify_count == Universe::verify_count()) return; |
|
1401 |
_verify_count = Universe::verify_count(); |
|
1402 |
#endif |
|
1403 |
oop* end_of_obj = (oop*)_klass() + _klass()->size(); |
|
1404 |
oop* end_of_vtable = (oop *)&table()[_length]; |
|
1405 |
if (end_of_vtable > end_of_obj) { |
|
33105
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32189
diff
changeset
|
1406 |
fatal("klass %s: klass object too short (vtable extends beyond end)", |
294e48b4f704
8080775: Better argument formatting for assert() and friends
david
parents:
32189
diff
changeset
|
1407 |
_klass->internal_name()); |
1 | 1408 |
} |
1409 |
||
1410 |
for (int i = 0; i < _length; i++) table()[i].verify(this, st); |
|
1411 |
// verify consistency with superKlass vtable |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1412 |
Klass* super = _klass->super(); |
1 | 1413 |
if (super != NULL) { |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1414 |
InstanceKlass* sk = InstanceKlass::cast(super); |
1 | 1415 |
klassVtable* vt = sk->vtable(); |
1416 |
for (int i = 0; i < vt->length(); i++) { |
|
1417 |
verify_against(st, vt, i); |
|
1418 |
} |
|
1419 |
} |
|
1420 |
} |
|
1421 |
||
1422 |
void klassVtable::verify_against(outputStream* st, klassVtable* vt, int index) { |
|
1423 |
vtableEntry* vte = &vt->table()[index]; |
|
1424 |
if (vte->method()->name() != table()[index].method()->name() || |
|
1425 |
vte->method()->signature() != table()[index].method()->signature()) { |
|
1426 |
fatal("mismatched name/signature of vtable entries"); |
|
1427 |
} |
|
1428 |
} |
|
1429 |
||
1430 |
#ifndef PRODUCT |
|
1431 |
void klassVtable::print() { |
|
1432 |
ResourceMark rm; |
|
1433 |
tty->print("klassVtable for klass %s (length %d):\n", _klass->internal_name(), length()); |
|
1434 |
for (int i = 0; i < length(); i++) { |
|
1435 |
table()[i].print(); |
|
1436 |
tty->cr(); |
|
1437 |
} |
|
1438 |
} |
|
1439 |
#endif |
|
1440 |
||
1441 |
void vtableEntry::verify(klassVtable* vt, outputStream* st) { |
|
1442 |
NOT_PRODUCT(FlagSetting fs(IgnoreLockingAssertions, true)); |
|
1443 |
assert(method() != NULL, "must have set method"); |
|
1444 |
method()->verify(); |
|
1445 |
// we sub_type, because it could be a miranda method |
|
1446 |
if (!vt->klass()->is_subtype_of(method()->method_holder())) { |
|
1447 |
#ifndef PRODUCT |
|
1448 |
print(); |
|
1449 |
#endif |
|
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
33105
diff
changeset
|
1450 |
fatal("vtableEntry " PTR_FORMAT ": method is from subclass", p2i(this)); |
1 | 1451 |
} |
1452 |
} |
|
1453 |
||
1454 |
#ifndef PRODUCT |
|
1455 |
||
1456 |
void vtableEntry::print() { |
|
1457 |
ResourceMark rm; |
|
1458 |
tty->print("vtableEntry %s: ", method()->name()->as_C_string()); |
|
1459 |
if (Verbose) { |
|
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
33105
diff
changeset
|
1460 |
tty->print("m " PTR_FORMAT " ", p2i(method())); |
1 | 1461 |
} |
1462 |
} |
|
1463 |
||
1464 |
class VtableStats : AllStatic { |
|
1465 |
public: |
|
1466 |
static int no_klasses; // # classes with vtables |
|
1467 |
static int no_array_klasses; // # array classes |
|
1468 |
static int no_instance_klasses; // # instanceKlasses |
|
1469 |
static int sum_of_vtable_len; // total # of vtable entries |
|
1470 |
static int sum_of_array_vtable_len; // total # of vtable entries in array klasses only |
|
1471 |
static int fixed; // total fixed overhead in bytes |
|
1472 |
static int filler; // overhead caused by filler bytes |
|
1473 |
static int entries; // total bytes consumed by vtable entries |
|
1474 |
static int array_entries; // total bytes consumed by array vtable entries |
|
1475 |
||
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1476 |
static void do_class(Klass* k) { |
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
9172
diff
changeset
|
1477 |
Klass* kl = k; |
1 | 1478 |
klassVtable* vt = kl->vtable(); |
1479 |
if (vt == NULL) return; |
|
1480 |
no_klasses++; |
|
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
1481 |
if (kl->is_instance_klass()) { |
1 | 1482 |
no_instance_klasses++; |
1483 |
kl->array_klasses_do(do_class); |
|
1484 |
} |
|
33611
9abd65805e19
8139203: Consistent naming for klass type predicates
coleenp
parents:
33602
diff
changeset
|
1485 |
if (kl->is_array_klass()) { |
1 | 1486 |
no_array_klasses++; |
1487 |
sum_of_array_vtable_len += vt->length(); |
|
1488 |
} |
|
1489 |
sum_of_vtable_len += vt->length(); |
|
1490 |
} |
|
1491 |
||
1492 |
static void compute() { |
|
1493 |
SystemDictionary::classes_do(do_class); |
|
1494 |
fixed = no_klasses * oopSize; // vtable length |
|
1495 |
// filler size is a conservative approximation |
|
13952
e3cf184080bc
8000213: NPG: Should have renamed arrayKlass and typeArrayKlass
coleenp
parents:
13728
diff
changeset
|
1496 |
filler = oopSize * (no_klasses - no_instance_klasses) * (sizeof(InstanceKlass) - sizeof(ArrayKlass) - 1); |
1 | 1497 |
entries = sizeof(vtableEntry) * sum_of_vtable_len; |
1498 |
array_entries = sizeof(vtableEntry) * sum_of_array_vtable_len; |
|
1499 |
} |
|
1500 |
}; |
|
1501 |
||
1502 |
int VtableStats::no_klasses = 0; |
|
1503 |
int VtableStats::no_array_klasses = 0; |
|
1504 |
int VtableStats::no_instance_klasses = 0; |
|
1505 |
int VtableStats::sum_of_vtable_len = 0; |
|
1506 |
int VtableStats::sum_of_array_vtable_len = 0; |
|
1507 |
int VtableStats::fixed = 0; |
|
1508 |
int VtableStats::filler = 0; |
|
1509 |
int VtableStats::entries = 0; |
|
1510 |
int VtableStats::array_entries = 0; |
|
1511 |
||
1512 |
void klassVtable::print_statistics() { |
|
1513 |
ResourceMark rm; |
|
1514 |
HandleMark hm; |
|
1515 |
VtableStats::compute(); |
|
1516 |
tty->print_cr("vtable statistics:"); |
|
1517 |
tty->print_cr("%6d classes (%d instance, %d array)", VtableStats::no_klasses, VtableStats::no_instance_klasses, VtableStats::no_array_klasses); |
|
1518 |
int total = VtableStats::fixed + VtableStats::filler + VtableStats::entries; |
|
1519 |
tty->print_cr("%6d bytes fixed overhead (refs + vtable object header)", VtableStats::fixed); |
|
1520 |
tty->print_cr("%6d bytes filler overhead", VtableStats::filler); |
|
1521 |
tty->print_cr("%6d bytes for vtable entries (%d for arrays)", VtableStats::entries, VtableStats::array_entries); |
|
1522 |
tty->print_cr("%6d bytes total", total); |
|
1523 |
} |
|
1524 |
||
1525 |
int klassItable::_total_classes; // Total no. of classes with itables |
|
1526 |
long klassItable::_total_size; // Total no. of bytes used for itables |
|
1527 |
||
1528 |
void klassItable::print_statistics() { |
|
1529 |
tty->print_cr("itable statistics:"); |
|
1530 |
tty->print_cr("%6d classes with itables", _total_classes); |
|
33148
68fa8b6c4340
8042893: compiler: PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC needs to be removed from source files
david
parents:
33105
diff
changeset
|
1531 |
tty->print_cr("%6lu K uses for itables (average by class: %ld bytes)", _total_size / K, _total_size / _total_classes); |
1 | 1532 |
} |
1533 |
||
1534 |
#endif // PRODUCT |