src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GuardPrioritiesTest.java
author dlong
Thu, 31 Oct 2019 16:54:16 -0700
changeset 58877 aec7bf35d6f5
parent 58299 6df94ce3ab2f
permissions -rw-r--r--
8233273: Update Graal Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     1
/*
58299
6df94ce3ab2f 8229201: Update Graal
dlong
parents: 54084
diff changeset
     2
 * Copyright (c) 2017, 2019, Oracle and/or its affiliates. All rights reserved.
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     4
 *
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     7
 * published by the Free Software Foundation.
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     8
 *
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    13
 * accompanied this code).
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    14
 *
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    18
 *
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    21
 * questions.
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    22
 */
50858
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    23
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    24
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    25
package org.graalvm.compiler.core.test;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    26
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    27
import static org.graalvm.compiler.graph.test.matchers.NodeIterableCount.hasCount;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    28
import static org.graalvm.compiler.graph.test.matchers.NodeIterableIsEmpty.isNotEmpty;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    29
import static org.junit.Assert.assertThat;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    30
import static org.junit.Assume.assumeThat;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    31
import static org.junit.Assume.assumeTrue;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    32
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    33
import java.util.Iterator;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    34
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    35
import org.graalvm.compiler.api.directives.GraalDirectives;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    36
import org.graalvm.compiler.core.common.GraalOptions;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    37
import org.graalvm.compiler.graph.iterators.NodeIterable;
54084
84f10bbf993f 8218074: Update Graal
jwilhelm
parents: 52910
diff changeset
    38
import org.graalvm.compiler.loop.phases.ConvertDeoptimizeToGuardPhase;
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    39
import org.graalvm.compiler.nodes.GuardNode;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    40
import org.graalvm.compiler.nodes.ParameterNode;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    41
import org.graalvm.compiler.nodes.StructuredGraph;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    42
import org.graalvm.compiler.nodes.calc.IntegerLowerThanNode;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    43
import org.graalvm.compiler.nodes.calc.IsNullNode;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    44
import org.graalvm.compiler.nodes.spi.LoweringTool;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    45
import org.graalvm.compiler.phases.common.CanonicalizerPhase;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    46
import org.graalvm.compiler.phases.common.FloatingReadPhase;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    47
import org.graalvm.compiler.phases.common.LoweringPhase;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    48
import org.graalvm.compiler.phases.schedule.SchedulePhase;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    49
import org.graalvm.compiler.phases.tiers.HighTierContext;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    50
import org.junit.Test;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    51
50858
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    52
import jdk.vm.ci.meta.SpeculationLog;
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    53
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    54
public class GuardPrioritiesTest extends GraphScheduleTest {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    55
    private int[] array;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    56
    private int size;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    57
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    58
    public void growing(int e) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    59
        if (size >= array.length) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    60
            // grow
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    61
            GraalDirectives.deoptimizeAndInvalidateWithSpeculation();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    62
        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    63
        array[size++] = e;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    64
    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    65
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    66
    @Test
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    67
    public void growingTest() {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    68
        assumeTrue("GuardPriorities must be turned one", GraalOptions.GuardPriorities.getValue(getInitialOptions()));
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    69
        StructuredGraph graph = prepareGraph("growing");
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    70
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    71
        NodeIterable<GuardNode> guards = graph.getNodes(GuardNode.TYPE).filter(n -> n.inputs().filter(i -> i instanceof IntegerLowerThanNode).isNotEmpty());
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    72
        assertThat(guards, isNotEmpty());
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    73
        assumeThat(guards, hasCount(2));
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    74
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    75
        Iterator<GuardNode> iterator = guards.iterator();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    76
        GuardNode g1 = iterator.next();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    77
        GuardNode g2 = iterator.next();
50858
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    78
        assertTrue("There should be one guard with speculation, the other one without",
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    79
                        (g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION)) ^ (g2.getSpeculation().equals(SpeculationLog.NO_SPECULATION)));
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    80
        GuardNode withSpeculation = g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION) ? g2 : g1;
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
    81
        GuardNode withoutSpeculation = g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION) ? g1 : g2;
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    82
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    83
        assertOrderedAfterSchedule(graph, SchedulePhase.SchedulingStrategy.EARLIEST_WITH_GUARD_ORDER, withSpeculation, withoutSpeculation);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    84
    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    85
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    86
    private StructuredGraph prepareGraph(String method) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    87
        StructuredGraph graph = parseEager(method, StructuredGraph.AllowAssumptions.YES);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    88
        HighTierContext highTierContext = getDefaultHighTierContext();
58877
aec7bf35d6f5 8233273: Update Graal
dlong
parents: 58299
diff changeset
    89
        CanonicalizerPhase canonicalizer = createCanonicalizerPhase();
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    90
        new ConvertDeoptimizeToGuardPhase().apply(graph, highTierContext);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    91
        new LoweringPhase(canonicalizer, LoweringTool.StandardLoweringStage.HIGH_TIER).apply(graph, highTierContext);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    92
        new FloatingReadPhase().apply(graph);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    93
        return graph;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    94
    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    95
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    96
    public int unknownCondition(Integer c, Object o, int[] a, Integer i) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    97
        if (o != null) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    98
            GraalDirectives.deoptimizeAndInvalidate();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
    99
        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   100
        if (i > 5560) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   101
            GraalDirectives.deoptimizeAndInvalidate();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   102
        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   103
        if (c >= 10) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   104
            GraalDirectives.deoptimizeAndInvalidateWithSpeculation();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   105
        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   106
        return array[8] + a[i];
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   107
    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   108
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   109
    @Test
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   110
    public void unknownTest() {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   111
        assumeTrue("GuardPriorities must be turned one", GraalOptions.GuardPriorities.getValue(getInitialOptions()));
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   112
        StructuredGraph graph = prepareGraph("unknownCondition");
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   113
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   114
        new SchedulePhase(SchedulePhase.SchedulingStrategy.EARLIEST_WITH_GUARD_ORDER).apply(graph);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   115
        for (GuardNode g1 : graph.getNodes(GuardNode.TYPE)) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   116
            for (GuardNode g2 : graph.getNodes(GuardNode.TYPE)) {
50858
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
   117
                if (g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION) ^ g2.getSpeculation().equals(SpeculationLog.NO_SPECULATION)) {
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
   118
                    GuardNode withSpeculation = g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION) ? g2 : g1;
2d3e99a72541 8205824: Update Graal
never
parents: 48861
diff changeset
   119
                    GuardNode withoutSpeculation = g1.getSpeculation().equals(SpeculationLog.NO_SPECULATION) ? g1 : g2;
48861
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   120
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   121
                    if (withoutSpeculation.isNegated() && withoutSpeculation.getCondition() instanceof IsNullNode) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   122
                        IsNullNode isNullNode = (IsNullNode) withoutSpeculation.getCondition();
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   123
                        if (isNullNode.getValue() instanceof ParameterNode && ((ParameterNode) isNullNode.getValue()).index() == 1) {
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   124
                            // this is the null check before the speculative guard, it's the only
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   125
                            // one that should be above
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   126
                            assertOrderedAfterLastSchedule(graph, withoutSpeculation, withSpeculation);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   127
                            continue;
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   128
                        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   129
                    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   130
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   131
                    assertOrderedAfterLastSchedule(graph, withSpeculation, withoutSpeculation);
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   132
                }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   133
            }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   134
        }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   135
    }
47f19ff9903c 8194819: Update Graal
iveresov
parents:
diff changeset
   136
}