author | alanb |
Thu, 01 Dec 2016 08:57:53 +0000 | |
changeset 42338 | a60f280f803c |
parent 37363 | 329dba26ffd2 |
permissions | -rw-r--r-- |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
1 |
/* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
2 |
* Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
4 |
* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
5 |
* This code is free software; you can redistribute it and/or modify it |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
7 |
* published by the Free Software Foundation. |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
8 |
* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
13 |
* accompanied this code). |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
14 |
* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
15 |
* You should have received a copy of the GNU General Public License version |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
18 |
* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
21 |
* questions. |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
22 |
*/ |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
23 |
|
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
24 |
import com.sun.tools.classfile.*; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
25 |
import com.sun.tools.jdeps.ClassFileReader; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
26 |
import static com.sun.tools.classfile.ConstantPool.*; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
27 |
import java.io.File; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
28 |
import java.io.IOException; |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
29 |
import java.io.UncheckedIOException; |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
30 |
import java.net.URI; |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
31 |
import java.nio.file.FileSystem; |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
32 |
import java.nio.file.FileSystems; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
33 |
import java.nio.file.Files; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
34 |
import java.nio.file.Path; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
35 |
import java.nio.file.Paths; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
36 |
import java.util.ArrayList; |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
37 |
import java.util.Collections; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
38 |
import java.util.List; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
39 |
import java.util.concurrent.Callable; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
40 |
import java.util.concurrent.ExecutionException; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
41 |
import java.util.concurrent.ExecutorService; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
42 |
import java.util.concurrent.Executors; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
43 |
import java.util.concurrent.FutureTask; |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
44 |
import java.util.stream.Stream; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
45 |
|
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
46 |
/* |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
47 |
* @test |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
48 |
* @bug 8010117 |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
49 |
* @summary Verify if CallerSensitive methods are annotated with |
37363
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
50 |
* CallerSensitive annotation |
35315 | 51 |
* @modules jdk.jdeps/com.sun.tools.classfile jdk.jdeps/com.sun.tools.jdeps |
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
52 |
* @build CallerSensitiveFinder |
26966
580934a3052b
8056909: test/sun/reflect/CallerSensitive/CallerSensitiveFinder.java fails with OOME
mchung
parents:
20881
diff
changeset
|
53 |
* @run main/othervm/timeout=900 CallerSensitiveFinder |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
54 |
*/ |
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
55 |
public class CallerSensitiveFinder { |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
56 |
private static int numThreads = 3; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
57 |
private static boolean verbose = false; |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
58 |
private final ExecutorService pool; |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
59 |
|
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
60 |
public static void main(String[] args) throws Exception { |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
61 |
Stream<Path> classes = null; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
62 |
String testclasses = System.getProperty("test.classes", "."); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
63 |
int i = 0; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
64 |
while (i < args.length) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
65 |
String arg = args[i++]; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
66 |
if (arg.equals("-v")) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
67 |
verbose = true; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
68 |
} else { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
69 |
Path p = Paths.get(testclasses, arg); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
70 |
if (!p.toFile().exists()) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
71 |
throw new IllegalArgumentException(arg + " does not exist"); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
72 |
} |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
73 |
classes = Stream.of(p); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
74 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
75 |
} |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
76 |
|
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
77 |
if (classes == null) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
78 |
classes = getPlatformClasses(); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
79 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
80 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
81 |
CallerSensitiveFinder csfinder = new CallerSensitiveFinder(); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
82 |
List<String> errors = csfinder.run(classes); |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
83 |
|
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
84 |
if (!errors.isEmpty()) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
85 |
throw new RuntimeException(errors.size() + |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
86 |
" caller-sensitive methods are missing @CallerSensitive annotation"); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
87 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
88 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
89 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
90 |
private final List<String> csMethodsMissingAnnotation = |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
91 |
Collections.synchronizedList(new ArrayList<>()); |
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
92 |
private final ReferenceFinder finder; |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
93 |
public CallerSensitiveFinder() { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
94 |
this.finder = new ReferenceFinder(getFilter(), getVisitor()); |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
95 |
pool = Executors.newFixedThreadPool(numThreads); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
96 |
|
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
97 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
98 |
|
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
99 |
private ReferenceFinder.Filter getFilter() { |
37363
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
100 |
final String classname = "jdk/internal/reflect/Reflection"; |
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
101 |
final String method = "getCallerClass"; |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
102 |
return new ReferenceFinder.Filter() { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
103 |
public boolean accept(ConstantPool cpool, CPRefInfo cpref) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
104 |
try { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
105 |
CONSTANT_NameAndType_info nat = cpref.getNameAndTypeInfo(); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
106 |
return cpref.getClassName().equals(classname) && nat.getName().equals(method); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
107 |
} catch (ConstantPoolException ex) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
108 |
throw new RuntimeException(ex); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
109 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
110 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
111 |
}; |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
112 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
113 |
|
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
114 |
private ReferenceFinder.Visitor getVisitor() { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
115 |
return new ReferenceFinder.Visitor() { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
116 |
public void visit(ClassFile cf, Method m, List<CPRefInfo> refs) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
117 |
try { |
37363
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
118 |
// ignore jdk.unsupported/sun.reflect.Reflection.getCallerClass |
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
119 |
// which is a "special" delegate to the internal getCallerClass |
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
120 |
if (cf.getName().equals("sun/reflect/Reflection") && |
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
121 |
m.getName(cf.constant_pool).equals("getCallerClass")) |
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
122 |
return; |
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
123 |
|
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
124 |
String name = String.format("%s#%s %s", cf.getName(), |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
125 |
m.getName(cf.constant_pool), |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
126 |
m.descriptor.getValue(cf.constant_pool)); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
127 |
if (!CallerSensitiveFinder.isCallerSensitive(m, cf.constant_pool)) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
128 |
csMethodsMissingAnnotation.add(name); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
129 |
System.err.println("Missing @CallerSensitive: " + name); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
130 |
} else { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
131 |
if (verbose) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
132 |
System.out.format("@CS %s%n", name); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
133 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
134 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
135 |
} catch (ConstantPoolException ex) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
136 |
throw new RuntimeException(ex); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
137 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
138 |
} |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
139 |
}; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
140 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
141 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
142 |
public List<String> run(Stream<Path> classes)throws IOException, InterruptedException, |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
143 |
ExecutionException, ConstantPoolException |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
144 |
{ |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
145 |
classes.forEach(this::processPath); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
146 |
waitForCompletion(); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
147 |
pool.shutdown(); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
148 |
return csMethodsMissingAnnotation; |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
149 |
} |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
150 |
|
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
151 |
void processPath(Path path) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
152 |
try { |
20881
9e14db54cb2f
8015912: jdeps support to output in dot file format
mchung
parents:
17204
diff
changeset
|
153 |
ClassFileReader reader = ClassFileReader.newInstance(path); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
154 |
for (ClassFile cf : reader.getClassFiles()) { |
42338
a60f280f803c
8169069: Module system implementation refresh (11/2016)
alanb
parents:
37363
diff
changeset
|
155 |
if (cf.access_flags.is(AccessFlags.ACC_MODULE)) |
a60f280f803c
8169069: Module system implementation refresh (11/2016)
alanb
parents:
37363
diff
changeset
|
156 |
continue; |
a60f280f803c
8169069: Module system implementation refresh (11/2016)
alanb
parents:
37363
diff
changeset
|
157 |
|
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
158 |
String classFileName = cf.getName(); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
159 |
// for each ClassFile |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
160 |
// parse constant pool to find matching method refs |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
161 |
// parse each method (caller) |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
162 |
// - visit and find method references matching the given method name |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
163 |
pool.submit(getTask(cf)); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
164 |
} |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
165 |
} catch (IOException x) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
166 |
throw new UncheckedIOException(x); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
167 |
} catch (ConstantPoolException x) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
168 |
throw new RuntimeException(x); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
169 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
170 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
171 |
|
37363
329dba26ffd2
8137058: Clear out all non-Critical APIs from sun.reflect
chegar
parents:
35315
diff
changeset
|
172 |
private static final String CALLER_SENSITIVE_ANNOTATION = "Ljdk/internal/reflect/CallerSensitive;"; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
173 |
private static boolean isCallerSensitive(Method m, ConstantPool cp) |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
174 |
throws ConstantPoolException |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
175 |
{ |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
176 |
RuntimeAnnotations_attribute attr = |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
177 |
(RuntimeAnnotations_attribute)m.attributes.get(Attribute.RuntimeVisibleAnnotations); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
178 |
int index = 0; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
179 |
if (attr != null) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
180 |
for (int i = 0; i < attr.annotations.length; i++) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
181 |
Annotation ann = attr.annotations[i]; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
182 |
String annType = cp.getUTF8Value(ann.type_index); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
183 |
if (CALLER_SENSITIVE_ANNOTATION.equals(annType)) { |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
184 |
return true; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
185 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
186 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
187 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
188 |
return false; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
189 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
190 |
|
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
191 |
private final List<FutureTask<Void>> tasks = new ArrayList<FutureTask<Void>>(); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
192 |
private FutureTask<Void> getTask(final ClassFile cf) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
193 |
FutureTask<Void> task = new FutureTask<Void>(new Callable<Void>() { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
194 |
public Void call() throws Exception { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
195 |
finder.parse(cf); |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
196 |
return null; |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
197 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
198 |
}); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
199 |
tasks.add(task); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
200 |
return task; |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
201 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
202 |
|
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
203 |
private void waitForCompletion() throws InterruptedException, ExecutionException { |
17204
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
204 |
for (FutureTask<Void> t : tasks) { |
d0540971275f
8013531: Provide a utility class in com.sun.tools.classfile to find field/method references
mchung
parents:
16906
diff
changeset
|
205 |
t.get(); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
206 |
} |
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
207 |
if (tasks.isEmpty()) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
208 |
throw new RuntimeException("No classes found, or specified."); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
209 |
} |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
210 |
System.out.println("Parsed " + tasks.size() + " classfiles"); |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
211 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
212 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
213 |
static Stream<Path> getPlatformClasses() throws IOException { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
214 |
Path home = Paths.get(System.getProperty("java.home")); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
215 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
216 |
// Either an exploded build or an image. |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
217 |
File classes = home.resolve("modules").toFile(); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
218 |
if (classes.isDirectory()) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
219 |
return Stream.of(classes.toPath()); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
220 |
} else { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
221 |
return jrtPaths(); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
222 |
} |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
223 |
} |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
224 |
|
28426
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
225 |
static Stream<Path> jrtPaths() { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
226 |
FileSystem jrt = FileSystems.getFileSystem(URI.create("jrt:/")); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
227 |
Path root = jrt.getPath("/"); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
228 |
|
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
229 |
try { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
230 |
return Files.walk(root) |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
231 |
.filter(p -> p.getNameCount() > 1) |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
232 |
.filter(p -> p.toString().endsWith(".class")); |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
233 |
} catch (IOException x) { |
7439e01a464b
8061297: sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem
chegar
parents:
26966
diff
changeset
|
234 |
throw new UncheckedIOException(x); |
16906
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
235 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
236 |
} |
44dfee24cb71
8010117: Annotate jdk caller sensitive methods with @sun.reflect.CallerSensitive
mchung
parents:
diff
changeset
|
237 |
} |