hotspot/src/share/vm/opto/stringopts.cpp
author vlivanov
Mon, 11 Apr 2016 21:42:55 +0300
changeset 38030 93f24e7b3c43
parent 36077 fa6d92de1c70
child 39418 6b03cc6f758a
permissions -rw-r--r--
8152590: C2: @Stable support doesn't always work w/ incremental inlining Reviewed-by: kvn
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     1
/*
29081
c61eb4914428 8072911: Remove includes of oop.inline.hpp from .hpp files
stefank
parents: 28642
diff changeset
     2
 * Copyright (c) 2009, 2015, Oracle and/or its affiliates. All rights reserved.
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     4
 *
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     7
 * published by the Free Software Foundation.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     8
 *
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    13
 * accompanied this code).
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    14
 *
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    18
 *
5547
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4891
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4891
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
f4b087cbb361 6941466: Oracle rebranding changes for Hotspot repositories
trims
parents: 4891
diff changeset
    21
 * questions.
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    22
 *
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    23
 */
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    24
7397
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    25
#include "precompiled.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    26
#include "compiler/compileLog.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    27
#include "opto/addnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    28
#include "opto/callGenerator.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    29
#include "opto/callnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    30
#include "opto/divnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    31
#include "opto/graphKit.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    32
#include "opto/idealKit.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    33
#include "opto/rootnode.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    34
#include "opto/runtime.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    35
#include "opto/stringopts.hpp"
5b173b4ca846 6989984: Use standard include model for Hospot
stefank
parents: 6743
diff changeset
    36
#include "opto/subnode.hpp"
29081
c61eb4914428 8072911: Remove includes of oop.inline.hpp from .hpp files
stefank
parents: 28642
diff changeset
    37
#include "runtime/sharedRuntime.hpp"
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    38
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    39
#define __ kit.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    40
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    41
class StringConcat : public ResourceObj {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    42
 private:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    43
  PhaseStringOpts*    _stringopts;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    44
  Node*               _string_alloc;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    45
  AllocateNode*       _begin;          // The allocation the begins the pattern
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    46
  CallStaticJavaNode* _end;            // The final call of the pattern.  Will either be
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    47
                                       // SB.toString or or String.<init>(SB.toString)
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    48
  bool                _multiple;       // indicates this is a fusion of two or more
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    49
                                       // separate StringBuilders
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    50
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    51
  Node*               _arguments;      // The list of arguments to be concatenated
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    52
  GrowableArray<int>  _mode;           // into a String along with a mode flag
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    53
                                       // indicating how to treat the value.
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
    54
  Node_List           _constructors;   // List of constructors (many in case of stacked concat)
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    55
  Node_List           _control;        // List of control nodes that will be deleted
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    56
  Node_List           _uncommon_traps; // Uncommon traps that needs to be rewritten
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    57
                                       // to restart at the initial JVMState.
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
    58
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    59
 public:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    60
  // Mode for converting arguments to Strings
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    61
  enum {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    62
    StringMode,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    63
    IntMode,
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
    64
    CharMode,
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
    65
    StringNullCheckMode
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    66
  };
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    67
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    68
  StringConcat(PhaseStringOpts* stringopts, CallStaticJavaNode* end):
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    69
    _end(end),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    70
    _begin(NULL),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    71
    _multiple(false),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    72
    _string_alloc(NULL),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    73
    _stringopts(stringopts) {
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
    74
    _arguments = new Node(1);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    75
    _arguments->del_req(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    76
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    77
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
    78
  bool validate_mem_flow();
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    79
  bool validate_control_flow();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    80
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    81
  void merge_add() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    82
#if 0
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    83
    // XXX This is place holder code for reusing an existing String
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    84
    // allocation but the logic for checking the state safety is
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    85
    // probably inadequate at the moment.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    86
    CallProjections endprojs;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    87
    sc->end()->extract_projections(&endprojs, false);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    88
    if (endprojs.resproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    89
      for (SimpleDUIterator i(endprojs.resproj); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    90
        CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    91
        if (use != NULL && use->method() != NULL &&
6743
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
    92
            use->method()->intrinsic_id() == vmIntrinsics::_String_String &&
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    93
            use->in(TypeFunc::Parms + 1) == endprojs.resproj) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    94
          // Found useless new String(sb.toString()) so reuse the newly allocated String
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    95
          // when creating the result instead of allocating a new one.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    96
          sc->set_string_alloc(use->in(TypeFunc::Parms));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    97
          sc->set_end(use);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    98
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
    99
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   100
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   101
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   102
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   103
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   104
  StringConcat* merge(StringConcat* other, Node* arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   105
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   106
  void set_allocation(AllocateNode* alloc) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   107
    _begin = alloc;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   108
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   109
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   110
  void append(Node* value, int mode) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   111
    _arguments->add_req(value);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   112
    _mode.append(mode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   113
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   114
  void push(Node* value, int mode) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   115
    _arguments->ins_req(0, value);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   116
    _mode.insert_before(0, mode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   117
  }
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   118
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   119
  void push_string(Node* value) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   120
    push(value, StringMode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   121
  }
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   122
  void push_string_null_check(Node* value) {
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   123
    push(value, StringNullCheckMode);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   124
  }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   125
  void push_int(Node* value) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   126
    push(value, IntMode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   127
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   128
  void push_char(Node* value) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   129
    push(value, CharMode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   130
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   131
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   132
  static bool is_SB_toString(Node* call) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   133
    if (call->is_CallStaticJava()) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   134
      CallStaticJavaNode* csj = call->as_CallStaticJava();
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   135
      ciMethod* m = csj->method();
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   136
      if (m != NULL &&
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   137
          (m->intrinsic_id() == vmIntrinsics::_StringBuilder_toString ||
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   138
           m->intrinsic_id() == vmIntrinsics::_StringBuffer_toString)) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   139
        return true;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   140
      }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   141
    }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   142
    return false;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   143
  }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   144
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   145
  static Node* skip_string_null_check(Node* value) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   146
    // Look for a diamond shaped Null check of toString() result
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   147
    // (could be code from String.valueOf()):
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   148
    // (Proj == NULL) ? "null":"CastPP(Proj)#NotNULL
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   149
    if (value->is_Phi()) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   150
      int true_path = value->as_Phi()->is_diamond_phi();
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   151
      if (true_path != 0) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   152
        // phi->region->if_proj->ifnode->bool
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   153
        BoolNode* b = value->in(0)->in(1)->in(0)->in(1)->as_Bool();
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   154
        Node* cmp = b->in(1);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   155
        Node* v1 = cmp->in(1);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   156
        Node* v2 = cmp->in(2);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   157
        // Null check of the return of toString which can simply be skipped.
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   158
        if (b->_test._test == BoolTest::ne &&
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   159
            v2->bottom_type() == TypePtr::NULL_PTR &&
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   160
            value->in(true_path)->Opcode() == Op_CastPP &&
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   161
            value->in(true_path)->in(1) == v1 &&
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   162
            v1->is_Proj() && is_SB_toString(v1->in(0))) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   163
          return v1;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   164
        }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   165
      }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   166
    }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   167
    return value;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   168
  }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   169
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   170
  Node* argument(int i) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   171
    return _arguments->in(i);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   172
  }
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   173
  Node* argument_uncast(int i) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   174
    Node* arg = argument(i);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   175
    int amode = mode(i);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   176
    if (amode == StringConcat::StringMode ||
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   177
        amode == StringConcat::StringNullCheckMode) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   178
      arg = skip_string_null_check(arg);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   179
    }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   180
    return arg;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   181
  }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   182
  void set_argument(int i, Node* value) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   183
    _arguments->set_req(i, value);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   184
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   185
  int num_arguments() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   186
    return _mode.length();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   187
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   188
  int mode(int i) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   189
    return _mode.at(i);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   190
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   191
  void add_control(Node* ctrl) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   192
    assert(!_control.contains(ctrl), "only push once");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   193
    _control.push(ctrl);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   194
  }
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   195
  void add_constructor(Node* init) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   196
    assert(!_constructors.contains(init), "only push once");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   197
    _constructors.push(init);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   198
  }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   199
  CallStaticJavaNode* end() { return _end; }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   200
  AllocateNode* begin() { return _begin; }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   201
  Node* string_alloc() { return _string_alloc; }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   202
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   203
  void eliminate_unneeded_control();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   204
  void eliminate_initialize(InitializeNode* init);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   205
  void eliminate_call(CallNode* call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   206
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   207
  void maybe_log_transform() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   208
    CompileLog* log = _stringopts->C->log();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   209
    if (log != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   210
      log->head("replace_string_concat arguments='%d' string_alloc='%d' multiple='%d'",
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   211
                num_arguments(),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   212
                _string_alloc != NULL,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   213
                _multiple);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   214
      JVMState* p = _begin->jvms();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   215
      while (p != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   216
        log->elem("jvms bci='%d' method='%d'", p->bci(), log->identify(p->method()));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   217
        p = p->caller();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   218
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   219
      log->tail("replace_string_concat");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   220
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   221
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   222
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   223
  void convert_uncommon_traps(GraphKit& kit, const JVMState* jvms) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   224
    for (uint u = 0; u < _uncommon_traps.size(); u++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   225
      Node* uct = _uncommon_traps.at(u);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   226
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   227
      // Build a new call using the jvms state of the allocate
6418
6671edbd230e 6978355: renaming for 6961697
twisti
parents: 5547
diff changeset
   228
      address call_addr = SharedRuntime::uncommon_trap_blob()->entry_point();
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   229
      const TypeFunc* call_type = OptoRuntime::uncommon_trap_Type();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   230
      const TypePtr* no_memory_effects = NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   231
      Compile* C = _stringopts->C;
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
   232
      CallStaticJavaNode* call = new CallStaticJavaNode(call_type, call_addr, "uncommon_trap",
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
   233
                                                        jvms->bci(), no_memory_effects);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   234
      for (int e = 0; e < TypeFunc::Parms; e++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   235
        call->init_req(e, uct->in(e));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   236
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   237
      // Set the trap request to record intrinsic failure if this trap
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   238
      // is taken too many times.  Ideally we would handle then traps by
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   239
      // doing the original bookkeeping in the MDO so that if it caused
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   240
      // the code to be thrown out we could still recompile and use the
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   241
      // optimization.  Failing the uncommon traps doesn't really mean
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   242
      // that the optimization is a bad idea but there's no other way to
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   243
      // do the MDO updates currently.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   244
      int trap_request = Deoptimization::make_trap_request(Deoptimization::Reason_intrinsic,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   245
                                                           Deoptimization::Action_make_not_entrant);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   246
      call->init_req(TypeFunc::Parms, __ intcon(trap_request));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   247
      kit.add_safepoint_edges(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   248
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   249
      _stringopts->gvn()->transform(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   250
      C->gvn_replace_by(uct, call);
14623
70c4c1be0a14 7092905: C2: Keep track of the number of dead nodes
bharadwaj
parents: 13895
diff changeset
   251
      uct->disconnect_inputs(NULL, C);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   252
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   253
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   254
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   255
  void cleanup() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   256
    // disconnect the hook node
14623
70c4c1be0a14 7092905: C2: Keep track of the number of dead nodes
bharadwaj
parents: 13895
diff changeset
   257
    _arguments->disconnect_inputs(NULL, _stringopts->C);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   258
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   259
};
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   260
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   261
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   262
void StringConcat::eliminate_unneeded_control() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   263
  for (uint i = 0; i < _control.size(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   264
    Node* n = _control.at(i);
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   265
    if (n->is_Allocate()) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   266
      eliminate_initialize(n->as_Allocate()->initialization());
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   267
    }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   268
    if (n->is_Call()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   269
      if (n != _end) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   270
        eliminate_call(n->as_Call());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   271
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   272
    } else if (n->is_IfTrue()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   273
      Compile* C = _stringopts->C;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   274
      C->gvn_replace_by(n, n->in(0)->in(0));
15113
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   275
      // get rid of the other projection
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   276
      C->gvn_replace_by(n->in(0)->as_If()->proj_out(false), C->top());
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   277
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   278
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   279
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   280
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   281
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   282
StringConcat* StringConcat::merge(StringConcat* other, Node* arg) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   283
  StringConcat* result = new StringConcat(_stringopts, _end);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   284
  for (uint x = 0; x < _control.size(); x++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   285
    Node* n = _control.at(x);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   286
    if (n->is_Call()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   287
      result->_control.push(n);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   288
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   289
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   290
  for (uint x = 0; x < other->_control.size(); x++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   291
    Node* n = other->_control.at(x);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   292
    if (n->is_Call()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   293
      result->_control.push(n);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   294
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   295
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   296
  assert(result->_control.contains(other->_end), "what?");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   297
  assert(result->_control.contains(_begin), "what?");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   298
  for (int x = 0; x < num_arguments(); x++) {
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   299
    Node* argx = argument_uncast(x);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   300
    if (argx == arg) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   301
      // replace the toString result with the all the arguments that
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   302
      // made up the other StringConcat
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   303
      for (int y = 0; y < other->num_arguments(); y++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   304
        result->append(other->argument(y), other->mode(y));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   305
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   306
    } else {
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   307
      result->append(argx, mode(x));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   308
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   309
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   310
  result->set_allocation(other->_begin);
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   311
  for (uint i = 0; i < _constructors.size(); i++) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   312
    result->add_constructor(_constructors.at(i));
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   313
  }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   314
  for (uint i = 0; i < other->_constructors.size(); i++) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   315
    result->add_constructor(other->_constructors.at(i));
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   316
  }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   317
  result->_multiple = true;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   318
  return result;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   319
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   320
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   321
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   322
void StringConcat::eliminate_call(CallNode* call) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   323
  Compile* C = _stringopts->C;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   324
  CallProjections projs;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   325
  call->extract_projections(&projs, false);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   326
  if (projs.fallthrough_catchproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   327
    C->gvn_replace_by(projs.fallthrough_catchproj, call->in(TypeFunc::Control));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   328
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   329
  if (projs.fallthrough_memproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   330
    C->gvn_replace_by(projs.fallthrough_memproj, call->in(TypeFunc::Memory));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   331
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   332
  if (projs.catchall_memproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   333
    C->gvn_replace_by(projs.catchall_memproj, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   334
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   335
  if (projs.fallthrough_ioproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   336
    C->gvn_replace_by(projs.fallthrough_ioproj, call->in(TypeFunc::I_O));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   337
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   338
  if (projs.catchall_ioproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   339
    C->gvn_replace_by(projs.catchall_ioproj, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   340
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   341
  if (projs.catchall_catchproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   342
    // EA can't cope with the partially collapsed graph this
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   343
    // creates so put it on the worklist to be collapsed later.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   344
    for (SimpleDUIterator i(projs.catchall_catchproj); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   345
      Node *use = i.get();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   346
      int opc = use->Opcode();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   347
      if (opc == Op_CreateEx || opc == Op_Region) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   348
        _stringopts->record_dead_node(use);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   349
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   350
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   351
    C->gvn_replace_by(projs.catchall_catchproj, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   352
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   353
  if (projs.resproj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   354
    C->gvn_replace_by(projs.resproj, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   355
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   356
  C->gvn_replace_by(call, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   357
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   358
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   359
void StringConcat::eliminate_initialize(InitializeNode* init) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   360
  Compile* C = _stringopts->C;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   361
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   362
  // Eliminate Initialize node.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   363
  assert(init->outcnt() <= 2, "only a control and memory projection expected");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   364
  assert(init->req() <= InitializeNode::RawStores, "no pending inits");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   365
  Node *ctrl_proj = init->proj_out(TypeFunc::Control);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   366
  if (ctrl_proj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   367
    C->gvn_replace_by(ctrl_proj, init->in(TypeFunc::Control));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   368
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   369
  Node *mem_proj = init->proj_out(TypeFunc::Memory);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   370
  if (mem_proj != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   371
    Node *mem = init->in(TypeFunc::Memory);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   372
    C->gvn_replace_by(mem_proj, mem);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   373
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   374
  C->gvn_replace_by(init, C->top());
14623
70c4c1be0a14 7092905: C2: Keep track of the number of dead nodes
bharadwaj
parents: 13895
diff changeset
   375
  init->disconnect_inputs(NULL, C);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   376
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   377
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   378
Node_List PhaseStringOpts::collect_toString_calls() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   379
  Node_List string_calls;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   380
  Node_List worklist;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   381
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   382
  _visited.Clear();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   383
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   384
  // Prime the worklist
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   385
  for (uint i = 1; i < C->root()->len(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   386
    Node* n = C->root()->in(i);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   387
    if (n != NULL && !_visited.test_set(n->_idx)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   388
      worklist.push(n);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   389
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   390
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   391
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   392
  while (worklist.size() > 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   393
    Node* ctrl = worklist.pop();
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   394
    if (StringConcat::is_SB_toString(ctrl)) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   395
      CallStaticJavaNode* csj = ctrl->as_CallStaticJava();
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   396
      string_calls.push(csj);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   397
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   398
    if (ctrl->in(0) != NULL && !_visited.test_set(ctrl->in(0)->_idx)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   399
      worklist.push(ctrl->in(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   400
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   401
    if (ctrl->is_Region()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   402
      for (uint i = 1; i < ctrl->len(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   403
        if (ctrl->in(i) != NULL && !_visited.test_set(ctrl->in(i)->_idx)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   404
          worklist.push(ctrl->in(i));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   405
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   406
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   407
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   408
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   409
  return string_calls;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   410
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   411
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   412
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   413
StringConcat* PhaseStringOpts::build_candidate(CallStaticJavaNode* call) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   414
  ciMethod* m = call->method();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   415
  ciSymbol* string_sig;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   416
  ciSymbol* int_sig;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   417
  ciSymbol* char_sig;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   418
  if (m->holder() == C->env()->StringBuilder_klass()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   419
    string_sig = ciSymbol::String_StringBuilder_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   420
    int_sig = ciSymbol::int_StringBuilder_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   421
    char_sig = ciSymbol::char_StringBuilder_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   422
  } else if (m->holder() == C->env()->StringBuffer_klass()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   423
    string_sig = ciSymbol::String_StringBuffer_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   424
    int_sig = ciSymbol::int_StringBuffer_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   425
    char_sig = ciSymbol::char_StringBuffer_signature();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   426
  } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   427
    return NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   428
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   429
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   430
  if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   431
    tty->print("considering toString call in ");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   432
    call->jvms()->dump_spec(tty); tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   433
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   434
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   435
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   436
  StringConcat* sc = new StringConcat(this, call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   437
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   438
  AllocateNode* alloc = NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   439
  InitializeNode* init = NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   440
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   441
  // possible opportunity for StringBuilder fusion
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   442
  CallStaticJavaNode* cnode = call;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   443
  while (cnode) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   444
    Node* recv = cnode->in(TypeFunc::Parms)->uncast();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   445
    if (recv->is_Proj()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   446
      recv = recv->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   447
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   448
    cnode = recv->isa_CallStaticJava();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   449
    if (cnode == NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   450
      alloc = recv->isa_Allocate();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   451
      if (alloc == NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   452
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   453
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   454
      // Find the constructor call
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   455
      Node* result = alloc->result_cast();
15113
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   456
      if (result == NULL || !result->is_CheckCastPP() || alloc->in(TypeFunc::Memory)->is_top()) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   457
        // strange looking allocation
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   458
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   459
        if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   460
          tty->print("giving up because allocation looks strange ");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   461
          alloc->jvms()->dump_spec(tty); tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   462
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   463
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   464
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   465
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   466
      Node* constructor = NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   467
      for (SimpleDUIterator i(result); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   468
        CallStaticJavaNode *use = i.get()->isa_CallStaticJava();
6743
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
   469
        if (use != NULL &&
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
   470
            use->method() != NULL &&
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
   471
            !use->method()->is_static() &&
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   472
            use->method()->name() == ciSymbol::object_initializer_name() &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   473
            use->method()->holder() == m->holder()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   474
          // Matched the constructor.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   475
          ciSymbol* sig = use->method()->signature()->as_symbol();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   476
          if (sig == ciSymbol::void_method_signature() ||
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   477
              sig == ciSymbol::int_void_signature() ||
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   478
              sig == ciSymbol::string_void_signature()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   479
            if (sig == ciSymbol::string_void_signature()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   480
              // StringBuilder(String) so pick this up as the first argument
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   481
              assert(use->in(TypeFunc::Parms + 1) != NULL, "what?");
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   482
              const Type* type = _gvn->type(use->in(TypeFunc::Parms + 1));
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   483
              if (type == TypePtr::NULL_PTR) {
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   484
                // StringBuilder(null) throws exception.
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   485
#ifndef PRODUCT
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   486
                if (PrintOptimizeStringConcat) {
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   487
                  tty->print("giving up because StringBuilder(null) throws exception");
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   488
                  alloc->jvms()->dump_spec(tty); tty->cr();
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   489
                }
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   490
#endif
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   491
                return NULL;
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   492
              }
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   493
              // StringBuilder(str) argument needs null check.
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   494
              sc->push_string_null_check(use->in(TypeFunc::Parms + 1));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   495
            }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   496
            // The int variant takes an initial size for the backing
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   497
            // array so just treat it like the void version.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   498
            constructor = use;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   499
          } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   500
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   501
            if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   502
              tty->print("unexpected constructor signature: %s", sig->as_utf8());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   503
            }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   504
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   505
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   506
          break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   507
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   508
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   509
      if (constructor == NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   510
        // couldn't find constructor
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   511
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   512
        if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   513
          tty->print("giving up because couldn't find constructor ");
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
   514
          alloc->jvms()->dump_spec(tty); tty->cr();
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   515
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   516
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   517
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   518
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   519
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   520
      // Walked all the way back and found the constructor call so see
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   521
      // if this call converted into a direct string concatenation.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   522
      sc->add_control(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   523
      sc->add_control(constructor);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   524
      sc->add_control(alloc);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   525
      sc->set_allocation(alloc);
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   526
      sc->add_constructor(constructor);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   527
      if (sc->validate_control_flow() && sc->validate_mem_flow()) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   528
        return sc;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   529
      } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   530
        return NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   531
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   532
    } else if (cnode->method() == NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   533
      break;
6743
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
   534
    } else if (!cnode->method()->is_static() &&
ef1795cd50a7 6986028: assert(_base == Int) failed: Not an Int in CmpINode::sub
never
parents: 6418
diff changeset
   535
               cnode->method()->holder() == m->holder() &&
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   536
               cnode->method()->name() == ciSymbol::append_name() &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   537
               (cnode->method()->signature()->as_symbol() == string_sig ||
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   538
                cnode->method()->signature()->as_symbol() == char_sig ||
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   539
                cnode->method()->signature()->as_symbol() == int_sig)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   540
      sc->add_control(cnode);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   541
      Node* arg = cnode->in(TypeFunc::Parms + 1);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   542
      if (cnode->method()->signature()->as_symbol() == int_sig) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   543
        sc->push_int(arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   544
      } else if (cnode->method()->signature()->as_symbol() == char_sig) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   545
        sc->push_char(arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   546
      } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   547
        if (arg->is_Proj() && arg->in(0)->is_CallStaticJava()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   548
          CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   549
          if (csj->method() != NULL &&
13292
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   550
              csj->method()->intrinsic_id() == vmIntrinsics::_Integer_toString &&
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   551
              arg->outcnt() == 1) {
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   552
            // _control is the list of StringBuilder calls nodes which
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   553
            // will be replaced by new String code after this optimization.
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   554
            // Integer::toString() call is not part of StringBuilder calls
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   555
            // chain. It could be eliminated only if its result is used
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   556
            // only by this SB calls chain.
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   557
            // Another limitation: it should be used only once because
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   558
            // it is unknown that it is used only by this SB calls chain
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   559
            // until all related SB calls nodes are collected.
587bb173cf43 7123926: Some CTW test crash: !_control.contains(ctrl)
kvn
parents: 13111
diff changeset
   560
            assert(arg->unique_out() == cnode, "sanity");
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   561
            sc->add_control(csj);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   562
            sc->push_int(csj->in(TypeFunc::Parms));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   563
            continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   564
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   565
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   566
        sc->push_string(arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   567
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   568
      continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   569
    } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   570
      // some unhandled signature
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   571
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   572
      if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   573
        tty->print("giving up because encountered unexpected signature ");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   574
        cnode->tf()->dump(); tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   575
        cnode->in(TypeFunc::Parms + 1)->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   576
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   577
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   578
      break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   579
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   580
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   581
  return NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   582
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   583
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   584
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   585
PhaseStringOpts::PhaseStringOpts(PhaseGVN* gvn, Unique_Node_List*):
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   586
  Phase(StringOpts),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   587
  _gvn(gvn),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   588
  _visited(Thread::current()->resource_area()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   589
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   590
  assert(OptimizeStringConcat, "shouldn't be here");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   591
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   592
  size_table_field = C->env()->Integer_klass()->get_field_by_name(ciSymbol::make("sizeTable"),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   593
                                                                  ciSymbol::make("[I"), true);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   594
  if (size_table_field == NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   595
    // Something wrong so give up.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   596
    assert(false, "why can't we find Integer.sizeTable?");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   597
    return;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   598
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   599
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   600
  // Collect the types needed to talk about the various slices of memory
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
   601
  byte_adr_idx = C->get_alias_index(TypeAryPtr::BYTES);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   602
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   603
  // For each locally allocated StringBuffer see if the usages can be
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   604
  // collapsed into a single String construction.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   605
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   606
  // Run through the list of allocation looking for SB.toString to see
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   607
  // if it's possible to fuse the usage of the SB into a single String
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   608
  // construction.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   609
  GrowableArray<StringConcat*> concats;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   610
  Node_List toStrings = collect_toString_calls();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   611
  while (toStrings.size() > 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   612
    StringConcat* sc = build_candidate(toStrings.pop()->as_CallStaticJava());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   613
    if (sc != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   614
      concats.push(sc);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   615
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   616
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   617
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   618
  // try to coalesce separate concats
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   619
 restart:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   620
  for (int c = 0; c < concats.length(); c++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   621
    StringConcat* sc = concats.at(c);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   622
    for (int i = 0; i < sc->num_arguments(); i++) {
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   623
      Node* arg = sc->argument_uncast(i);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   624
      if (arg->is_Proj() && StringConcat::is_SB_toString(arg->in(0))) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   625
        CallStaticJavaNode* csj = arg->in(0)->as_CallStaticJava();
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   626
        for (int o = 0; o < concats.length(); o++) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   627
          if (c == o) continue;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   628
          StringConcat* other = concats.at(o);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   629
          if (other->end() == csj) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   630
#ifndef PRODUCT
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   631
            if (PrintOptimizeStringConcat) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   632
              tty->print_cr("considering stacked concats");
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   633
            }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   634
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   635
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   636
            StringConcat* merged = sc->merge(other, arg);
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   637
            if (merged->validate_control_flow() && merged->validate_mem_flow()) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   638
#ifndef PRODUCT
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   639
              if (PrintOptimizeStringConcat) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   640
                tty->print_cr("stacking would succeed");
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   641
              }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   642
#endif
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   643
              if (c < o) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   644
                concats.remove_at(o);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   645
                concats.at_put(c, merged);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   646
              } else {
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   647
                concats.remove_at(c);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   648
                concats.at_put(o, merged);
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   649
              }
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   650
              goto restart;
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   651
            } else {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   652
#ifndef PRODUCT
13111
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   653
              if (PrintOptimizeStringConcat) {
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   654
                tty->print_cr("stacking would fail");
e8a578a9b20a 7179138: Incorrect result with String concatenation optimization
kvn
parents: 12623
diff changeset
   655
              }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   656
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   657
            }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   658
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   659
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   660
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   661
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   662
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   663
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   664
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   665
  for (int c = 0; c < concats.length(); c++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   666
    StringConcat* sc = concats.at(c);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   667
    replace_string_concat(sc);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   668
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   669
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   670
  remove_dead_nodes();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   671
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   672
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   673
void PhaseStringOpts::record_dead_node(Node* dead) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   674
  dead_worklist.push(dead);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   675
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   676
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   677
void PhaseStringOpts::remove_dead_nodes() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   678
  // Delete any dead nodes to make things clean enough that escape
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   679
  // analysis doesn't get unhappy.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   680
  while (dead_worklist.size() > 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   681
    Node* use = dead_worklist.pop();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   682
    int opc = use->Opcode();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   683
    switch (opc) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   684
      case Op_Region: {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   685
        uint i = 1;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   686
        for (i = 1; i < use->req(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   687
          if (use->in(i) != C->top()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   688
            break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   689
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   690
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   691
        if (i >= use->req()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   692
          for (SimpleDUIterator i(use); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   693
            Node* m = i.get();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   694
            if (m->is_Phi()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   695
              dead_worklist.push(m);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   696
            }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   697
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   698
          C->gvn_replace_by(use, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   699
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   700
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   701
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   702
      case Op_AddP:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   703
      case Op_CreateEx: {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   704
        // Recurisvely clean up references to CreateEx so EA doesn't
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   705
        // get unhappy about the partially collapsed graph.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   706
        for (SimpleDUIterator i(use); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   707
          Node* m = i.get();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   708
          if (m->is_AddP()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   709
            dead_worklist.push(m);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   710
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   711
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   712
        C->gvn_replace_by(use, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   713
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   714
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   715
      case Op_Phi:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   716
        if (use->in(0) == C->top()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   717
          C->gvn_replace_by(use, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   718
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   719
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   720
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   721
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   722
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   723
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   724
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   725
bool StringConcat::validate_mem_flow() {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   726
  Compile* C = _stringopts->C;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   727
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   728
  for (uint i = 0; i < _control.size(); i++) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   729
#ifndef PRODUCT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   730
    Node_List path;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   731
#endif
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   732
    Node* curr = _control.at(i);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   733
    if (curr->is_Call() && curr != _begin) { // For all calls except the first allocation
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   734
      // Now here's the main invariant in our case:
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   735
      // For memory between the constructor, and appends, and toString we should only see bottom memory,
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   736
      // produced by the previous call we know about.
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   737
      if (!_constructors.contains(curr)) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   738
        NOT_PRODUCT(path.push(curr);)
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   739
        Node* mem = curr->in(TypeFunc::Memory);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   740
        assert(mem != NULL, "calls should have memory edge");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   741
        assert(!mem->is_Phi(), "should be handled by control flow validation");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   742
        NOT_PRODUCT(path.push(mem);)
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   743
        while (mem->is_MergeMem()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   744
          for (uint i = 1; i < mem->req(); i++) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   745
            if (i != Compile::AliasIdxBot && mem->in(i) != C->top()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   746
#ifndef PRODUCT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   747
              if (PrintOptimizeStringConcat) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   748
                tty->print("fusion has incorrect memory flow (side effects) for ");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   749
                _begin->jvms()->dump_spec(tty); tty->cr();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   750
                path.dump();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   751
              }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   752
#endif
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   753
              return false;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   754
            }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   755
          }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   756
          // skip through a potential MergeMem chain, linked through Bot
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   757
          mem = mem->in(Compile::AliasIdxBot);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   758
          NOT_PRODUCT(path.push(mem);)
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   759
        }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   760
        // now let it fall through, and see if we have a projection
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   761
        if (mem->is_Proj()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   762
          // Should point to a previous known call
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   763
          Node *prev = mem->in(0);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   764
          NOT_PRODUCT(path.push(prev);)
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   765
          if (!prev->is_Call() || !_control.contains(prev)) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   766
#ifndef PRODUCT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   767
            if (PrintOptimizeStringConcat) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   768
              tty->print("fusion has incorrect memory flow (unknown call) for ");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   769
              _begin->jvms()->dump_spec(tty); tty->cr();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   770
              path.dump();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   771
            }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   772
#endif
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   773
            return false;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   774
          }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   775
        } else {
33105
294e48b4f704 8080775: Better argument formatting for assert() and friends
david
parents: 32467
diff changeset
   776
          assert(mem->is_Store() || mem->is_LoadStore(), "unexpected node type: %s", mem->Name());
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   777
#ifndef PRODUCT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   778
          if (PrintOptimizeStringConcat) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   779
            tty->print("fusion has incorrect memory flow (unexpected source) for ");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   780
            _begin->jvms()->dump_spec(tty); tty->cr();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   781
            path.dump();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   782
          }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   783
#endif
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   784
          return false;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   785
        }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   786
      } else {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   787
        // For memory that feeds into constructors it's more complicated.
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   788
        // However the advantage is that any side effect that happens between the Allocate/Initialize and
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   789
        // the constructor will have to be control-dependent on Initialize.
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   790
        // So we actually don't have to do anything, since it's going to be caught by the control flow
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   791
        // analysis.
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   792
#ifdef ASSERT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   793
        // Do a quick verification of the control pattern between the constructor and the initialize node
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   794
        assert(curr->is_Call(), "constructor should be a call");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   795
        // Go up the control starting from the constructor call
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   796
        Node* ctrl = curr->in(0);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   797
        IfNode* iff = NULL;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   798
        RegionNode* copy = NULL;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   799
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   800
        while (true) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   801
          // skip known check patterns
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   802
          if (ctrl->is_Region()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   803
            if (ctrl->as_Region()->is_copy()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   804
              copy = ctrl->as_Region();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   805
              ctrl = copy->is_copy();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   806
            } else { // a cast
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   807
              assert(ctrl->req() == 3 &&
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   808
                     ctrl->in(1) != NULL && ctrl->in(1)->is_Proj() &&
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   809
                     ctrl->in(2) != NULL && ctrl->in(2)->is_Proj() &&
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   810
                     ctrl->in(1)->in(0) == ctrl->in(2)->in(0) &&
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   811
                     ctrl->in(1)->in(0) != NULL && ctrl->in(1)->in(0)->is_If(),
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   812
                     "must be a simple diamond");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   813
              Node* true_proj = ctrl->in(1)->is_IfTrue() ? ctrl->in(1) : ctrl->in(2);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   814
              for (SimpleDUIterator i(true_proj); i.has_next(); i.next()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   815
                Node* use = i.get();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   816
                assert(use == ctrl || use->is_ConstraintCast(),
33105
294e48b4f704 8080775: Better argument formatting for assert() and friends
david
parents: 32467
diff changeset
   817
                       "unexpected user: %s", use->Name());
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   818
              }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   819
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   820
              iff = ctrl->in(1)->in(0)->as_If();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   821
              ctrl = iff->in(0);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   822
            }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   823
          } else if (ctrl->is_IfTrue()) { // null checks, class checks
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   824
            iff = ctrl->in(0)->as_If();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   825
            // Verify that the other arm is an uncommon trap
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   826
            Node* otherproj = iff->proj_out(1 - ctrl->as_Proj()->_con);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   827
            CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
35552
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   828
            assert(strcmp(call->_name, "uncommon_trap") == 0, "must be uncommon trap");
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   829
            ctrl = iff->in(0);
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   830
          } else {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   831
            break;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   832
          }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   833
        }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   834
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   835
        assert(ctrl->is_Proj(), "must be a projection");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   836
        assert(ctrl->in(0)->is_Initialize(), "should be initialize");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   837
        for (SimpleDUIterator i(ctrl); i.has_next(); i.next()) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   838
          Node* use = i.get();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   839
          assert(use == copy || use == iff || use == curr || use->is_CheckCastPP() || use->is_Load(),
33105
294e48b4f704 8080775: Better argument formatting for assert() and friends
david
parents: 32467
diff changeset
   840
                 "unexpected user: %s", use->Name());
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   841
        }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   842
#endif // ASSERT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   843
      }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   844
    }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   845
  }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   846
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   847
#ifndef PRODUCT
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   848
  if (PrintOptimizeStringConcat) {
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   849
    tty->print("fusion has correct memory flow for ");
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   850
    _begin->jvms()->dump_spec(tty); tty->cr();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   851
    tty->cr();
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   852
  }
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   853
#endif
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   854
  return true;
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   855
}
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   856
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   857
bool StringConcat::validate_control_flow() {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   858
  // We found all the calls and arguments now lets see if it's
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   859
  // safe to transform the graph as we would expect.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   860
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   861
  // Check to see if this resulted in too many uncommon traps previously
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   862
  if (Compile::current()->too_many_traps(_begin->jvms()->method(), _begin->jvms()->bci(),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   863
                        Deoptimization::Reason_intrinsic)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   864
    return false;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   865
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   866
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   867
  // Walk backwards over the control flow from toString to the
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   868
  // allocation and make sure all the control flow is ok.  This
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   869
  // means it's either going to be eliminated once the calls are
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   870
  // removed or it can safely be transformed into an uncommon
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   871
  // trap.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   872
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   873
  int null_check_count = 0;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   874
  Unique_Node_List ctrl_path;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   875
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   876
  assert(_control.contains(_begin), "missing");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   877
  assert(_control.contains(_end), "missing");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   878
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   879
  // Collect the nodes that we know about and will eliminate into ctrl_path
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   880
  for (uint i = 0; i < _control.size(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   881
    // Push the call and it's control projection
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   882
    Node* n = _control.at(i);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   883
    if (n->is_Allocate()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   884
      AllocateNode* an = n->as_Allocate();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   885
      InitializeNode* init = an->initialization();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   886
      ctrl_path.push(init);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   887
      ctrl_path.push(init->as_Multi()->proj_out(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   888
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   889
    if (n->is_Call()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   890
      CallNode* cn = n->as_Call();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   891
      ctrl_path.push(cn);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   892
      ctrl_path.push(cn->proj_out(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   893
      ctrl_path.push(cn->proj_out(0)->unique_out());
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   894
      if (cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0) != NULL) {
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   895
        ctrl_path.push(cn->proj_out(0)->unique_out()->as_Catch()->proj_out(0));
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   896
      }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   897
    } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   898
      ShouldNotReachHere();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   899
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   900
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   901
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
   902
  // Skip backwards through the control checking for unexpected control flow
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   903
  Node* ptr = _end;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   904
  bool fail = false;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   905
  while (ptr != _begin) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   906
    if (ptr->is_Call() && ctrl_path.member(ptr)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   907
      ptr = ptr->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   908
    } else if (ptr->is_CatchProj() && ctrl_path.member(ptr)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   909
      ptr = ptr->in(0)->in(0)->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   910
      assert(ctrl_path.member(ptr), "should be a known piece of control");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   911
    } else if (ptr->is_IfTrue()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   912
      IfNode* iff = ptr->in(0)->as_If();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   913
      BoolNode* b = iff->in(1)->isa_Bool();
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   914
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   915
      if (b == NULL) {
35552
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   916
#ifndef PRODUCT
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   917
        if (PrintOptimizeStringConcat) {
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   918
          tty->print_cr("unexpected input to IfNode");
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   919
          iff->in(1)->dump();
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   920
          tty->cr();
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   921
        }
be1bff8945dc 8136469: OptimizeStringConcat fails on pre-sized StringBuilder shapes
thartmann
parents: 34204
diff changeset
   922
#endif
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   923
        fail = true;
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   924
        break;
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   925
      }
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
   926
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   927
      Node* cmp = b->in(1);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   928
      Node* v1 = cmp->in(1);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   929
      Node* v2 = cmp->in(2);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   930
      Node* otherproj = iff->proj_out(1 - ptr->as_Proj()->_con);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   931
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   932
      // Null check of the return of append which can simply be eliminated
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   933
      if (b->_test._test == BoolTest::ne &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   934
          v2->bottom_type() == TypePtr::NULL_PTR &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   935
          v1->is_Proj() && ctrl_path.member(v1->in(0))) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   936
        // NULL check of the return value of the append
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   937
        null_check_count++;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   938
        if (otherproj->outcnt() == 1) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   939
          CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   940
          if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   941
            ctrl_path.push(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   942
          }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   943
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   944
        _control.push(ptr);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   945
        ptr = ptr->in(0)->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   946
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   947
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   948
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   949
      // A test which leads to an uncommon trap which should be safe.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   950
      // Later this trap will be converted into a trap that restarts
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   951
      // at the beginning.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   952
      if (otherproj->outcnt() == 1) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   953
        CallStaticJavaNode* call = otherproj->unique_out()->isa_CallStaticJava();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   954
        if (call != NULL && call->_name != NULL && strcmp(call->_name, "uncommon_trap") == 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   955
          // control flow leads to uct so should be ok
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   956
          _uncommon_traps.push(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   957
          ctrl_path.push(call);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   958
          ptr = ptr->in(0)->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   959
          continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   960
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   961
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   962
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   963
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   964
      // Some unexpected control flow we don't know how to handle.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   965
      if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   966
        tty->print_cr("failing with unknown test");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   967
        b->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   968
        cmp->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   969
        v1->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   970
        v2->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   971
        tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   972
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   973
#endif
9953
a0f68ceb2f77 7046096: SEGV IN C2 WITH 6U25
kvn
parents: 9332
diff changeset
   974
      fail = true;
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   975
      break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   976
    } else if (ptr->is_Proj() && ptr->in(0)->is_Initialize()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   977
      ptr = ptr->in(0)->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   978
    } else if (ptr->is_Region()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   979
      Node* copy = ptr->as_Region()->is_copy();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   980
      if (copy != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   981
        ptr = copy;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   982
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   983
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   984
      if (ptr->req() == 3 &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   985
          ptr->in(1) != NULL && ptr->in(1)->is_Proj() &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   986
          ptr->in(2) != NULL && ptr->in(2)->is_Proj() &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   987
          ptr->in(1)->in(0) == ptr->in(2)->in(0) &&
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   988
          ptr->in(1)->in(0) != NULL && ptr->in(1)->in(0)->is_If()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   989
        // Simple diamond.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   990
        // XXX should check for possibly merging stores.  simple data merges are ok.
15113
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   991
        // The IGVN will make this simple diamond go away when it
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   992
        // transforms the Region. Make sure it sees it.
823590505eb4 8005071: Incremental inlining for JSR 292
roland
parents: 14828
diff changeset
   993
        Compile::current()->record_for_igvn(ptr);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   994
        ptr = ptr->in(1)->in(0)->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   995
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   996
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   997
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   998
      if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
   999
        tty->print_cr("fusion would fail for region");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1000
        _begin->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1001
        ptr->dump(2);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1002
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1003
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1004
      fail = true;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1005
      break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1006
    } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1007
      // other unknown control
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1008
      if (!fail) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1009
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1010
        if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1011
          tty->print_cr("fusion would fail for");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1012
          _begin->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1013
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1014
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1015
        fail = true;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1016
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1017
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1018
      if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1019
        ptr->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1020
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1021
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1022
      ptr = ptr->in(0);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1023
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1024
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1025
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1026
  if (PrintOptimizeStringConcat && fail) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1027
    tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1028
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1029
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1030
  if (fail) return !fail;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1031
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1032
  // Validate that all these results produced are contained within
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1033
  // this cluster of objects.  First collect all the results produced
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1034
  // by calls in the region.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1035
  _stringopts->_visited.Clear();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1036
  Node_List worklist;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1037
  Node* final_result = _end->proj_out(TypeFunc::Parms);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1038
  for (uint i = 0; i < _control.size(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1039
    CallNode* cnode = _control.at(i)->isa_Call();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1040
    if (cnode != NULL) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1041
      _stringopts->_visited.test_set(cnode->_idx);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1042
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1043
    Node* result = cnode != NULL ? cnode->proj_out(TypeFunc::Parms) : NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1044
    if (result != NULL && result != final_result) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1045
      worklist.push(result);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1046
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1047
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1048
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1049
  Node* last_result = NULL;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1050
  while (worklist.size() > 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1051
    Node* result = worklist.pop();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1052
    if (_stringopts->_visited.test_set(result->_idx))
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1053
      continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1054
    for (SimpleDUIterator i(result); i.has_next(); i.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1055
      Node *use = i.get();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1056
      if (ctrl_path.member(use)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1057
        // already checked this
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1058
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1059
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1060
      int opc = use->Opcode();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1061
      if (opc == Op_CmpP || opc == Op_Node) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1062
        ctrl_path.push(use);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1063
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1064
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1065
      if (opc == Op_CastPP || opc == Op_CheckCastPP) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1066
        for (SimpleDUIterator j(use); j.has_next(); j.next()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1067
          worklist.push(j.get());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1068
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1069
        worklist.push(use->in(1));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1070
        ctrl_path.push(use);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1071
        continue;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1072
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1073
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1074
      if (PrintOptimizeStringConcat) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1075
        if (result != last_result) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1076
          last_result = result;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1077
          tty->print_cr("extra uses for result:");
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1078
          last_result->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1079
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1080
        use->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1081
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1082
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1083
      fail = true;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1084
      break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1085
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1086
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1087
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1088
#ifndef PRODUCT
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1089
  if (PrintOptimizeStringConcat && !fail) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1090
    ttyLocker ttyl;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1091
    tty->cr();
20716
5093ad743df4 8009303: Tiered: incorrect results in VM tests stringconcat with -Xcomp -XX:+DeoptimizeALot on solaris-amd64
iveresov
parents: 15113
diff changeset
  1092
    tty->print("fusion has correct control flow (%d %d) for ", null_check_count, _uncommon_traps.size());
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1093
    _begin->jvms()->dump_spec(tty); tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1094
    for (int i = 0; i < num_arguments(); i++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1095
      argument(i)->dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1096
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1097
    _control.dump();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1098
    tty->cr();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1099
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1100
#endif
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1101
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1102
  return !fail;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1103
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1104
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1105
Node* PhaseStringOpts::fetch_static_field(GraphKit& kit, ciField* field) {
12592
6d69203a4cb0 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror
never
parents: 9953
diff changeset
  1106
  const TypeInstPtr* mirror_type = TypeInstPtr::make(field->holder()->java_mirror());
6d69203a4cb0 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror
never
parents: 9953
diff changeset
  1107
  Node* klass_node = __ makecon(mirror_type);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1108
  BasicType bt = field->layout_type();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1109
  ciType* field_klass = field->type();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1110
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1111
  const Type *type;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1112
  if( bt == T_OBJECT ) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1113
    if (!field->type()->is_loaded()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1114
      type = TypeInstPtr::BOTTOM;
38030
93f24e7b3c43 8152590: C2: @Stable support doesn't always work w/ incremental inlining
vlivanov
parents: 36077
diff changeset
  1115
    } else if (field->is_static_constant()) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1116
      // This can happen if the constant oop is non-perm.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1117
      ciObject* con = field->constant_value().as_object();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1118
      // Do not "join" in the previous type; it doesn't add value,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1119
      // and may yield a vacuous result if the field is of interface type.
8728
3f1bcd33068e 6962931: move interned strings out of the perm gen
jcoomes
parents: 7714
diff changeset
  1120
      type = TypeOopPtr::make_from_constant(con, true)->isa_oopptr();
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1121
      assert(type != NULL, "field singleton type must be consistent");
12592
6d69203a4cb0 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror
never
parents: 9953
diff changeset
  1122
      return __ makecon(type);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1123
    } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1124
      type = TypeOopPtr::make_from_klass(field_klass->as_klass());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1125
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1126
  } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1127
    type = Type::get_const_basic_type(bt);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1128
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1129
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1130
  return kit.make_load(NULL, kit.basic_plus_adr(klass_node, field->offset_in_bytes()),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1131
                       type, T_OBJECT,
22845
d8812d0ff387 8024921: PPC64 (part 113): Extend Load and Store nodes to know about memory ordering
goetz
parents: 20716
diff changeset
  1132
                       C->get_alias_index(mirror_type->add_offset(field->offset_in_bytes())),
d8812d0ff387 8024921: PPC64 (part 113): Extend Load and Store nodes to know about memory ordering
goetz
parents: 20716
diff changeset
  1133
                       MemNode::unordered);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1134
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1135
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1136
Node* PhaseStringOpts::int_stringSize(GraphKit& kit, Node* arg) {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1137
  if (arg->is_Con()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1138
    // Constant integer. Compute constant length using Integer.sizeTable
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1139
    int arg_val = arg->get_int();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1140
    int count = 1;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1141
    if (arg_val < 0) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1142
      arg_val = -arg_val;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1143
      count++;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1144
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1145
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1146
    ciArray* size_table = (ciArray*)size_table_field->constant_value().as_object();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1147
    for (int i = 0; i < size_table->length(); i++) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1148
      if (arg_val <= size_table->element_value(i).as_int()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1149
        count += i;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1150
        break;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1151
      }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1152
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1153
    return __ intcon(count);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1154
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1155
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1156
  RegionNode *final_merge = new RegionNode(3);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1157
  kit.gvn().set_type(final_merge, Type::CONTROL);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1158
  Node* final_size = new PhiNode(final_merge, TypeInt::INT);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1159
  kit.gvn().set_type(final_size, TypeInt::INT);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1160
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1161
  IfNode* iff = kit.create_and_map_if(kit.control(),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1162
                                      __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1163
                                      PROB_FAIR, COUNT_UNKNOWN);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1164
  Node* is_min = __ IfFalse(iff);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1165
  final_merge->init_req(1, is_min);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1166
  final_size->init_req(1, __ intcon(11));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1167
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1168
  kit.set_control(__ IfTrue(iff));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1169
  if (kit.stopped()) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1170
    final_merge->init_req(2, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1171
    final_size->init_req(2, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1172
  } else {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1173
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1174
    // int size = (i < 0) ? stringSize(-i) + 1 : stringSize(i);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1175
    RegionNode *r = new RegionNode(3);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1176
    kit.gvn().set_type(r, Type::CONTROL);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1177
    Node *phi = new PhiNode(r, TypeInt::INT);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1178
    kit.gvn().set_type(phi, TypeInt::INT);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1179
    Node *size = new PhiNode(r, TypeInt::INT);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1180
    kit.gvn().set_type(size, TypeInt::INT);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1181
    Node* chk = __ CmpI(arg, __ intcon(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1182
    Node* p = __ Bool(chk, BoolTest::lt);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1183
    IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_FAIR, COUNT_UNKNOWN);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1184
    Node* lessthan = __ IfTrue(iff);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1185
    Node* greaterequal = __ IfFalse(iff);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1186
    r->init_req(1, lessthan);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1187
    phi->init_req(1, __ SubI(__ intcon(0), arg));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1188
    size->init_req(1, __ intcon(1));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1189
    r->init_req(2, greaterequal);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1190
    phi->init_req(2, arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1191
    size->init_req(2, __ intcon(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1192
    kit.set_control(r);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1193
    C->record_for_igvn(r);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1194
    C->record_for_igvn(phi);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1195
    C->record_for_igvn(size);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1196
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1197
    // for (int i=0; ; i++)
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1198
    //   if (x <= sizeTable[i])
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1199
    //     return i+1;
8732
16fc1c68714b 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 7714
diff changeset
  1200
16fc1c68714b 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 7714
diff changeset
  1201
    // Add loop predicate first.
16fc1c68714b 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 7714
diff changeset
  1202
    kit.add_predicate();
16fc1c68714b 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 7714
diff changeset
  1203
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1204
    RegionNode *loop = new RegionNode(3);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1205
    loop->init_req(1, kit.control());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1206
    kit.gvn().set_type(loop, Type::CONTROL);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1207
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1208
    Node *index = new PhiNode(loop, TypeInt::INT);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1209
    index->init_req(1, __ intcon(0));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1210
    kit.gvn().set_type(index, TypeInt::INT);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1211
    kit.set_control(loop);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1212
    Node* sizeTable = fetch_static_field(kit, size_table_field);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1213
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1214
    Node* value = kit.load_array_element(NULL, sizeTable, index, TypeAryPtr::INTS);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1215
    C->record_for_igvn(value);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1216
    Node* limit = __ CmpI(phi, value);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1217
    Node* limitb = __ Bool(limit, BoolTest::le);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1218
    IfNode* iff2 = kit.create_and_map_if(kit.control(), limitb, PROB_MIN, COUNT_UNKNOWN);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1219
    Node* lessEqual = __ IfTrue(iff2);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1220
    Node* greater = __ IfFalse(iff2);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1221
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1222
    loop->init_req(2, greater);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1223
    index->init_req(2, __ AddI(index, __ intcon(1)));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1224
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1225
    kit.set_control(lessEqual);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1226
    C->record_for_igvn(loop);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1227
    C->record_for_igvn(index);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1228
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1229
    final_merge->init_req(2, kit.control());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1230
    final_size->init_req(2, __ AddI(__ AddI(index, size), __ intcon(1)));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1231
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1232
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1233
  kit.set_control(final_merge);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1234
  C->record_for_igvn(final_merge);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1235
  C->record_for_igvn(final_size);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1236
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1237
  return final_size;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1238
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1239
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1240
// Simplified version of Integer.getChars
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1241
void PhaseStringOpts::getChars(GraphKit& kit, Node* arg, Node* dst_array, BasicType bt, Node* end, Node* final_merge, Node* final_mem, int merge_index) {
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1242
  // if (i < 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1243
  //     sign = '-';
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1244
  //     i = -i;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1245
  // }
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1246
  IfNode* iff = kit.create_and_map_if(kit.control(), __ Bool(__ CmpI(arg, __ intcon(0)), BoolTest::lt),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1247
                                      PROB_FAIR, COUNT_UNKNOWN);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1248
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1249
  RegionNode* merge = new RegionNode(3);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1250
  kit.gvn().set_type(merge, Type::CONTROL);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1251
  Node* i = new PhiNode(merge, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1252
  kit.gvn().set_type(i, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1253
  Node* sign = new PhiNode(merge, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1254
  kit.gvn().set_type(sign, TypeInt::INT);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1255
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1256
  merge->init_req(1, __ IfTrue(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1257
  i->init_req(1, __ SubI(__ intcon(0), arg));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1258
  sign->init_req(1, __ intcon('-'));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1259
  merge->init_req(2, __ IfFalse(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1260
  i->init_req(2, arg);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1261
  sign->init_req(2, __ intcon(0));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1262
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1263
  kit.set_control(merge);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1264
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1265
  C->record_for_igvn(merge);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1266
  C->record_for_igvn(i);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1267
  C->record_for_igvn(sign);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1268
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1269
  // for (;;) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1270
  //     q = i / 10;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1271
  //     r = i - ((q << 3) + (q << 1));  // r = i-(q*10) ...
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1272
  //     buf [--charPos] = digits [r];
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1273
  //     i = q;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1274
  //     if (i == 0) break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1275
  // }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1276
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1277
  // Add loop predicate first.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1278
  kit.add_predicate();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1279
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1280
  RegionNode* head = new RegionNode(3);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1281
  head->init_req(1, kit.control());
8732
16fc1c68714b 7008866: Missing loop predicate for loop with multiple entries
kvn
parents: 7714
diff changeset
  1282
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1283
  kit.gvn().set_type(head, Type::CONTROL);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1284
  Node* i_phi = new PhiNode(head, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1285
  i_phi->init_req(1, i);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1286
  kit.gvn().set_type(i_phi, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1287
  Node* charPos = new PhiNode(head, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1288
  charPos->init_req(1, end);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1289
  kit.gvn().set_type(charPos, TypeInt::INT);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1290
  Node* mem = PhiNode::make(head, kit.memory(byte_adr_idx), Type::MEMORY, TypeAryPtr::BYTES);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1291
  kit.gvn().set_type(mem, Type::MEMORY);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1292
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1293
  kit.set_control(head);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1294
  kit.set_memory(mem, byte_adr_idx);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1295
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1296
  Node* q = __ DivI(kit.null(), i_phi, __ intcon(10));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1297
  Node* r = __ SubI(i_phi, __ AddI(__ LShiftI(q, __ intcon(3)),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1298
                                   __ LShiftI(q, __ intcon(1))));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1299
  Node* index = __ SubI(charPos, __ intcon((bt == T_BYTE) ? 1 : 2));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1300
  Node* ch = __ AddI(r, __ intcon('0'));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1301
  Node* st = __ store_to_memory(kit.control(), kit.array_element_address(dst_array, index, T_BYTE),
34204
5ad1ba3afecc 8140390: Char stores/loads accessing byte arrays must be marked as unmatched
thartmann
parents: 33636
diff changeset
  1302
                                ch, bt, byte_adr_idx, MemNode::unordered, (bt != T_BYTE) /* mismatched */);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1303
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1304
  iff = kit.create_and_map_if(head, __ Bool(__ CmpI(q, __ intcon(0)), BoolTest::ne),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1305
                              PROB_FAIR, COUNT_UNKNOWN);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1306
  Node* ne = __ IfTrue(iff);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1307
  Node* eq = __ IfFalse(iff);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1308
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1309
  head->init_req(2, ne);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1310
  mem->init_req(2, st);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1311
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1312
  i_phi->init_req(2, q);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1313
  charPos->init_req(2, index);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1314
  charPos = index;
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1315
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1316
  kit.set_control(eq);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1317
  kit.set_memory(st, byte_adr_idx);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1318
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1319
  C->record_for_igvn(head);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1320
  C->record_for_igvn(mem);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1321
  C->record_for_igvn(i_phi);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1322
  C->record_for_igvn(charPos);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1323
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1324
  // if (sign != 0) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1325
  //     buf [--charPos] = sign;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1326
  // }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1327
  iff = kit.create_and_map_if(kit.control(), __ Bool(__ CmpI(sign, __ intcon(0)), BoolTest::ne),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1328
                              PROB_FAIR, COUNT_UNKNOWN);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1329
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1330
  final_merge->init_req(merge_index + 2, __ IfFalse(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1331
  final_mem->init_req(merge_index + 2, kit.memory(byte_adr_idx));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1332
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1333
  kit.set_control(__ IfTrue(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1334
  if (kit.stopped()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1335
    final_merge->init_req(merge_index + 1, C->top());
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1336
    final_mem->init_req(merge_index + 1, C->top());
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1337
  } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1338
    Node* index = __ SubI(charPos, __ intcon((bt == T_BYTE) ? 1 : 2));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1339
    st = __ store_to_memory(kit.control(), kit.array_element_address(dst_array, index, T_BYTE),
34204
5ad1ba3afecc 8140390: Char stores/loads accessing byte arrays must be marked as unmatched
thartmann
parents: 33636
diff changeset
  1340
                            sign, bt, byte_adr_idx, MemNode::unordered, (bt != T_BYTE) /* mismatched */);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1341
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1342
    final_merge->init_req(merge_index + 1, kit.control());
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1343
    final_mem->init_req(merge_index + 1, st);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1344
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1345
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1346
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1347
// Copy the characters representing arg into dst_array starting at start
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1348
Node* PhaseStringOpts::int_getChars(GraphKit& kit, Node* arg, Node* dst_array, Node* dst_coder, Node* start, Node* size) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1349
  bool dcon = dst_coder->is_Con();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1350
  bool dbyte = dcon ? (dst_coder->get_int() == java_lang_String::CODER_LATIN1) : false;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1351
  Node* end = __ AddI(start, __ LShiftI(size, dst_coder));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1352
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1353
  // The final_merge node has 4 entries in case the encoding is known:
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1354
  // (0) Control, (1) result w/ sign, (2) result w/o sign, (3) result for Integer.min_value
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1355
  // or 6 entries in case the encoding is not known:
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1356
  // (0) Control, (1) Latin1 w/ sign, (2) Latin1 w/o sign, (3) min_value, (4) UTF16 w/ sign, (5) UTF16 w/o sign
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1357
  RegionNode* final_merge = new RegionNode(dcon ? 4 : 6);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1358
  kit.gvn().set_type(final_merge, Type::CONTROL);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1359
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1360
  Node* final_mem = PhiNode::make(final_merge, kit.memory(byte_adr_idx), Type::MEMORY, TypeAryPtr::BYTES);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1361
  kit.gvn().set_type(final_mem, Type::MEMORY);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1362
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1363
  // need to handle arg == Integer.MIN_VALUE specially because negating doesn't make it positive
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1364
  IfNode* iff = kit.create_and_map_if(kit.control(), __ Bool(__ CmpI(arg, __ intcon(0x80000000)), BoolTest::ne),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1365
                                      PROB_FAIR, COUNT_UNKNOWN);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1366
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1367
  Node* old_mem = kit.memory(byte_adr_idx);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1368
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1369
  kit.set_control(__ IfFalse(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1370
  if (kit.stopped()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1371
    // Statically not equal to MIN_VALUE so this path is dead
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1372
    final_merge->init_req(3, kit.control());
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1373
  } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1374
    copy_string(kit, __ makecon(TypeInstPtr::make(C->env()->the_min_jint_string())),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1375
                dst_array, dst_coder, start);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1376
    final_merge->init_req(3, kit.control());
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1377
    final_mem->init_req(3, kit.memory(byte_adr_idx));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1378
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1379
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1380
  kit.set_control(__ IfTrue(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1381
  kit.set_memory(old_mem, byte_adr_idx);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1382
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1383
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1384
    // Check encoding of destination
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1385
    iff = kit.create_and_map_if(kit.control(), __ Bool(__ CmpI(dst_coder, __ intcon(0)), BoolTest::eq),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1386
                                PROB_FAIR, COUNT_UNKNOWN);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1387
    old_mem = kit.memory(byte_adr_idx);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1388
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1389
  if (!dcon || dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1390
    // Destination is Latin1,
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1391
    if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1392
      kit.set_control(__ IfTrue(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1393
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1394
    getChars(kit, arg, dst_array, T_BYTE, end, final_merge, final_mem);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1395
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1396
  if (!dcon || !dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1397
    // Destination is UTF16
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1398
    int merge_index = 0;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1399
    if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1400
      kit.set_control(__ IfFalse(iff));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1401
      kit.set_memory(old_mem, byte_adr_idx);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1402
      merge_index = 3; // Account for Latin1 case
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1403
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1404
    getChars(kit, arg, dst_array, T_CHAR, end, final_merge, final_mem, merge_index);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1405
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1406
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1407
  // Final merge point for Latin1 and UTF16 case
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1408
  kit.set_control(final_merge);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1409
  kit.set_memory(final_mem, byte_adr_idx);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1410
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1411
  C->record_for_igvn(final_merge);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1412
  C->record_for_igvn(final_mem);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1413
  return end;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1414
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1415
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1416
// Copy 'count' bytes/chars from src_array to dst_array starting at index start
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1417
void PhaseStringOpts::arraycopy(GraphKit& kit, IdealKit& ideal, Node* src_array, Node* dst_array, BasicType elembt, Node* start, Node* count) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1418
  assert(elembt == T_BYTE || elembt == T_CHAR, "Invalid type for arraycopy");
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1419
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1420
  if (elembt == T_CHAR) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1421
    // Get number of chars
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1422
    count = __ RShiftI(count, __ intcon(1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1423
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1424
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1425
  Node* extra = NULL;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1426
#ifdef _LP64
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1427
  count = __ ConvI2L(count);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1428
  extra = C->top();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1429
#endif
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1430
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1431
  Node* src_ptr = __ array_element_address(src_array, __ intcon(0), T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1432
  Node* dst_ptr = __ array_element_address(dst_array, start, T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1433
  // Check if destination address is aligned to HeapWordSize
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1434
  const TypeInt* tdst = __ gvn().type(start)->is_int();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1435
  bool aligned = tdst->is_con() && ((tdst->get_con() * type2aelembytes(T_BYTE)) % HeapWordSize == 0);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1436
  // Figure out which arraycopy runtime method to call (disjoint, uninitialized).
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1437
  const char* copyfunc_name = "arraycopy";
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1438
  address     copyfunc_addr = StubRoutines::select_arraycopy_function(elembt, aligned, true, copyfunc_name, true);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1439
  ideal.make_leaf_call_no_fp(OptoRuntime::fast_arraycopy_Type(), copyfunc_addr, copyfunc_name,
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1440
                             TypeAryPtr::BYTES, src_ptr, dst_ptr, count, extra);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1441
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1442
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1443
#undef __
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1444
#define __ ideal.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1445
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1446
// Copy contents of a Latin1 encoded string from src_array to dst_array
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1447
void PhaseStringOpts::copy_latin1_string(GraphKit& kit, IdealKit& ideal, Node* src_array, IdealVariable& count,
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1448
                                         Node* dst_array, Node* dst_coder, Node* start) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1449
  bool dcon = dst_coder->is_Con();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1450
  bool dbyte = dcon ? (dst_coder->get_int() == java_lang_String::CODER_LATIN1) : false;
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1451
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1452
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1453
    __ if_then(dst_coder, BoolTest::eq, __ ConI(java_lang_String::CODER_LATIN1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1454
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1455
  if (!dcon || dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1456
    // Destination is Latin1. Simply emit a byte arraycopy.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1457
    arraycopy(kit, ideal, src_array, dst_array, T_BYTE, start, __ value(count));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1458
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1459
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1460
    __ else_();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1461
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1462
  if (!dcon || !dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1463
    // Destination is UTF16. Inflate src_array into dst_array.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1464
    kit.sync_kit(ideal);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1465
    if (Matcher::match_rule_supported(Op_StrInflatedCopy)) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1466
      // Use fast intrinsic
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1467
      Node* src = kit.array_element_address(src_array, kit.intcon(0), T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1468
      Node* dst = kit.array_element_address(dst_array, start, T_BYTE);
35573
e6c6e7a3b036 8144212: JDK 9 b93 breaks Apache Lucene due to compact strings
thartmann
parents: 35552
diff changeset
  1469
      kit.inflate_string(src, dst, TypeAryPtr::BYTES, __ value(count));
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1470
    } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1471
      // No intrinsic available, use slow method
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1472
      kit.inflate_string_slow(src_array, dst_array, start, __ value(count));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1473
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1474
    ideal.sync_kit(&kit);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1475
    // Multiply count by two since we now need two bytes per char
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1476
    __ set(count, __ LShiftI(__ value(count), __ ConI(1)));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1477
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1478
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1479
    __ end_if();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1480
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1481
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1482
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1483
// Read two bytes from index and index+1 and convert them to a char
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1484
static jchar readChar(ciTypeArray* array, int index) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1485
  int shift_high, shift_low;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1486
#ifdef VM_LITTLE_ENDIAN
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1487
    shift_high = 0;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1488
    shift_low = 8;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1489
#else
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1490
    shift_high = 8;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1491
    shift_low = 0;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1492
#endif
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1493
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1494
  jchar b1 = ((jchar) array->byte_at(index)) & 0xff;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1495
  jchar b2 = ((jchar) array->byte_at(index+1)) & 0xff;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1496
  return (b1 << shift_high) | (b2 << shift_low);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1497
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1498
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1499
// Copy contents of constant src_array to dst_array by emitting individual stores
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1500
void PhaseStringOpts::copy_constant_string(GraphKit& kit, IdealKit& ideal, ciTypeArray* src_array, IdealVariable& count,
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1501
                                           bool src_is_byte, Node* dst_array, Node* dst_coder, Node* start) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1502
  bool dcon = dst_coder->is_Con();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1503
  bool dbyte = dcon ? (dst_coder->get_int() == java_lang_String::CODER_LATIN1) : false;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1504
  int length = src_array->length();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1505
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1506
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1507
    __ if_then(dst_coder, BoolTest::eq, __ ConI(java_lang_String::CODER_LATIN1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1508
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1509
  if (!dcon || dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1510
    // Destination is Latin1. Copy each byte of src_array into dst_array.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1511
    Node* index = start;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1512
    for (int i = 0; i < length; i++) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1513
      Node* adr = kit.array_element_address(dst_array, index, T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1514
      Node* val = __ ConI(src_array->byte_at(i));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1515
      __ store(__ ctrl(), adr, val, T_BYTE, byte_adr_idx, MemNode::unordered);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1516
      index = __ AddI(index, __ ConI(1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1517
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1518
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1519
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1520
    __ else_();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1521
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1522
  if (!dcon || !dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1523
    // Destination is UTF16. Copy each char of src_array into dst_array.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1524
    Node* index = start;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1525
    for (int i = 0; i < length; i++) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1526
      Node* adr = kit.array_element_address(dst_array, index, T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1527
      jchar val;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1528
      if (src_is_byte) {
33636
58b6bcd2ecac 8141443: jdk/test/java/util/regex/RegExTest.java fails: No match found
thartmann
parents: 33628
diff changeset
  1529
        val = src_array->byte_at(i) & 0xff;
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1530
      } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1531
        val = readChar(src_array, i++);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1532
      }
34204
5ad1ba3afecc 8140390: Char stores/loads accessing byte arrays must be marked as unmatched
thartmann
parents: 33636
diff changeset
  1533
      __ store(__ ctrl(), adr, __ ConI(val), T_CHAR, byte_adr_idx, MemNode::unordered, true /* mismatched */);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1534
      index = __ AddI(index, __ ConI(2));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1535
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1536
    if (src_is_byte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1537
      // Multiply count by two since we now need two bytes per char
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1538
      __ set(count, __ ConI(2 * length));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1539
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1540
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1541
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1542
    __ end_if();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1543
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1544
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1545
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1546
// Compress copy contents of the byte/char String str into dst_array starting at index start.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1547
Node* PhaseStringOpts::copy_string(GraphKit& kit, Node* str, Node* dst_array, Node* dst_coder, Node* start) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1548
  Node* src_array = kit.load_String_value(kit.control(), str);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1549
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1550
  IdealKit ideal(&kit, true, true);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1551
  IdealVariable count(ideal); __ declarations_done();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1552
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1553
  if (str->is_Con()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1554
    // Constant source string
36077
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1555
    ciTypeArray* src_array_type = get_constant_value(kit, str);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1556
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1557
    // Check encoding of constant string
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1558
    bool src_is_byte = (get_constant_coder(kit, str) == java_lang_String::CODER_LATIN1);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1559
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1560
    // For small constant strings just emit individual stores.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1561
    // A length of 6 seems like a good space/speed tradeof.
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1562
    __ set(count, __ ConI(src_array_type->length()));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1563
    int src_len = src_array_type->length() / (src_is_byte ? 1 : 2);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1564
    if (src_len < unroll_string_copy_length) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1565
      // Small constant string
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1566
      copy_constant_string(kit, ideal, src_array_type, count, src_is_byte, dst_array, dst_coder, start);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1567
    } else if (src_is_byte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1568
      // Source is Latin1
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1569
      copy_latin1_string(kit, ideal, src_array, count, dst_array, dst_coder, start);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1570
    } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1571
      // Source is UTF16 (destination too). Simply emit a char arraycopy.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1572
      arraycopy(kit, ideal, src_array, dst_array, T_CHAR, start, __ value(count));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1573
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1574
  } else {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1575
    Node* size = kit.load_array_length(src_array);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1576
    __ set(count, size);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1577
    // Non-constant source string
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1578
    if (CompactStrings) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1579
      // Emit runtime check for coder
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1580
      Node* coder = kit.load_String_coder(__ ctrl(), str);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1581
      __ if_then(coder, BoolTest::eq, __ ConI(java_lang_String::CODER_LATIN1)); {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1582
        // Source is Latin1
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1583
        copy_latin1_string(kit, ideal, src_array, count, dst_array, dst_coder, start);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1584
      } __ else_();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1585
    }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1586
    // Source is UTF16 (destination too). Simply emit a char arraycopy.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1587
    arraycopy(kit, ideal, src_array, dst_array, T_CHAR, start, __ value(count));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1588
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1589
    if (CompactStrings) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1590
      __ end_if();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1591
    }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1592
  }
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1593
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1594
  // Finally sync IdealKit and GraphKit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1595
  kit.sync_kit(ideal);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1596
  return __ AddI(start, __ value(count));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1597
}
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1598
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1599
// Compress copy the char into dst_array at index start.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1600
Node* PhaseStringOpts::copy_char(GraphKit& kit, Node* val, Node* dst_array, Node* dst_coder, Node* start) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1601
  bool dcon = (dst_coder != NULL) && dst_coder->is_Con();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1602
  bool dbyte = dcon ? (dst_coder->get_int() == java_lang_String::CODER_LATIN1) : false;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1603
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1604
  IdealKit ideal(&kit, true, true);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1605
  IdealVariable end(ideal); __ declarations_done();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1606
  Node* adr = kit.array_element_address(dst_array, start, T_BYTE);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1607
  if (!dcon){
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1608
    __ if_then(dst_coder, BoolTest::eq, __ ConI(java_lang_String::CODER_LATIN1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1609
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1610
  if (!dcon || dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1611
    // Destination is Latin1. Store a byte.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1612
    __ store(__ ctrl(), adr, val, T_BYTE, byte_adr_idx, MemNode::unordered);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1613
    __ set(end, __ AddI(start, __ ConI(1)));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1614
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1615
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1616
    __ else_();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1617
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1618
  if (!dcon || !dbyte) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1619
    // Destination is UTF16. Store a char.
34204
5ad1ba3afecc 8140390: Char stores/loads accessing byte arrays must be marked as unmatched
thartmann
parents: 33636
diff changeset
  1620
    __ store(__ ctrl(), adr, val, T_CHAR, byte_adr_idx, MemNode::unordered, true /* mismatched */);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1621
    __ set(end, __ AddI(start, __ ConI(2)));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1622
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1623
  if (!dcon) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1624
    __ end_if();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1625
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1626
  // Finally sync IdealKit and GraphKit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1627
  kit.sync_kit(ideal);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1628
  return __ value(end);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1629
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1630
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1631
#undef __
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1632
#define __ kit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1633
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1634
// Allocate a byte array of specified length.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1635
Node* PhaseStringOpts::allocate_byte_array(GraphKit& kit, IdealKit* ideal, Node* length) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1636
  if (ideal != NULL) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1637
    // Sync IdealKit and graphKit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1638
    kit.sync_kit(*ideal);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1639
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1640
  Node* byte_array = NULL;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1641
  {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1642
    PreserveReexecuteState preexecs(&kit);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1643
    // The original jvms is for an allocation of either a String or
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1644
    // StringBuffer so no stack adjustment is necessary for proper
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1645
    // reexecution.  If we deoptimize in the slow path the bytecode
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1646
    // will be reexecuted and the char[] allocation will be thrown away.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1647
    kit.jvms()->set_should_reexecute(true);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1648
    byte_array = kit.new_array(__ makecon(TypeKlassPtr::make(ciTypeArrayKlass::make(T_BYTE))),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1649
                               length, 1);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1650
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1651
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1652
  // Mark the allocation so that zeroing is skipped since the code
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1653
  // below will overwrite the entire array
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1654
  AllocateArrayNode* byte_alloc = AllocateArrayNode::Ideal_array_allocation(byte_array, _gvn);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1655
  byte_alloc->maybe_set_complete(_gvn);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1656
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1657
  if (ideal != NULL) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1658
    // Sync IdealKit and graphKit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1659
    ideal->sync_kit(&kit);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1660
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1661
  return byte_array;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1662
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1663
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1664
jbyte PhaseStringOpts::get_constant_coder(GraphKit& kit, Node* str) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1665
  assert(str->is_Con(), "String must be constant");
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1666
  const TypeOopPtr* str_type = kit.gvn().type(str)->isa_oopptr();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1667
  ciInstance* str_instance = str_type->const_oop()->as_instance();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1668
  jbyte coder = str_instance->field_value_by_offset(java_lang_String::coder_offset_in_bytes()).as_byte();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1669
  assert(CompactStrings || (coder == java_lang_String::CODER_UTF16), "Strings must be UTF16 encoded");
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1670
  return coder;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1671
}
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1672
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1673
int PhaseStringOpts::get_constant_length(GraphKit& kit, Node* str) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1674
  assert(str->is_Con(), "String must be constant");
36077
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1675
  return get_constant_value(kit, str)->length();
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1676
}
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1677
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1678
ciTypeArray* PhaseStringOpts::get_constant_value(GraphKit& kit, Node* str) {
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1679
  assert(str->is_Con(), "String must be constant");
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1680
  const TypeOopPtr* str_type = kit.gvn().type(str)->isa_oopptr();
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1681
  ciInstance* str_instance = str_type->const_oop()->as_instance();
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1682
  ciObject* src_array = str_instance->field_value_by_offset(java_lang_String::value_offset_in_bytes()).as_object();
fa6d92de1c70 8149813: Move trusted final field handling from C2 LoadNode::Value to shared code
shade
parents: 35573
diff changeset
  1683
  return src_array->as_type_array();
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1684
}
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1685
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1686
void PhaseStringOpts::replace_string_concat(StringConcat* sc) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1687
  // Log a little info about the transformation
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1688
  sc->maybe_log_transform();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1689
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1690
  // pull the JVMState of the allocation into a SafePointNode to serve as
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1691
  // as a shim for the insertion of the new code.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1692
  JVMState* jvms     = sc->begin()->jvms()->clone_shallow(C);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1693
  uint size = sc->begin()->req();
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1694
  SafePointNode* map = new SafePointNode(size, jvms);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1695
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1696
  // copy the control and memory state from the final call into our
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1697
  // new starting state.  This allows any preceeding tests to feed
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1698
  // into the new section of code.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1699
  for (uint i1 = 0; i1 < TypeFunc::Parms; i1++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1700
    map->init_req(i1, sc->end()->in(i1));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1701
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1702
  // blow away old allocation arguments
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1703
  for (uint i1 = TypeFunc::Parms; i1 < jvms->debug_start(); i1++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1704
    map->init_req(i1, C->top());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1705
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1706
  // Copy the rest of the inputs for the JVMState
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1707
  for (uint i1 = jvms->debug_start(); i1 < sc->begin()->req(); i1++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1708
    map->init_req(i1, sc->begin()->in(i1));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1709
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1710
  // Make sure the memory state is a MergeMem for parsing.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1711
  if (!map->in(TypeFunc::Memory)->is_MergeMem()) {
25930
eae8b7490d2c 8054033: Remove unused references to Compile*
thartmann
parents: 24923
diff changeset
  1712
    map->set_req(TypeFunc::Memory, MergeMemNode::make(map->in(TypeFunc::Memory)));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1713
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1714
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1715
  jvms->set_map(map);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1716
  map->ensure_stack(jvms, jvms->method()->max_stack());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1717
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1718
  // disconnect all the old StringBuilder calls from the graph
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1719
  sc->eliminate_unneeded_control();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1720
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1721
  // At this point all the old work has been completely removed from
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1722
  // the graph and the saved JVMState exists at the point where the
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1723
  // final toString call used to be.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1724
  GraphKit kit(jvms);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1725
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1726
  // There may be uncommon traps which are still using the
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1727
  // intermediate states and these need to be rewritten to point at
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1728
  // the JVMState at the beginning of the transformation.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1729
  sc->convert_uncommon_traps(kit, jvms);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1730
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1731
  // Now insert the logic to compute the size of the string followed
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1732
  // by all the logic to construct array and resulting string.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1733
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1734
  Node* null_string = __ makecon(TypeInstPtr::make(C->env()->the_null_string()));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1735
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1736
  // Create a region for the overflow checks to merge into.
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1737
  int args = MAX2(sc->num_arguments(), 1);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1738
  RegionNode* overflow = new RegionNode(args);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1739
  kit.gvn().set_type(overflow, Type::CONTROL);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1740
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1741
  // Create a hook node to hold onto the individual sizes since they
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1742
  // are need for the copying phase.
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1743
  Node* string_sizes = new Node(args);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1744
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1745
  Node* coder = __ intcon(0);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1746
  Node* length = __ intcon(0);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1747
  // If at least one argument is UTF16 encoded, we can fix the encoding.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1748
  bool coder_fixed = false;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1749
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1750
  if (!CompactStrings) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1751
    // Fix encoding of result string to UTF16
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1752
    coder_fixed = true;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1753
    coder = __ intcon(java_lang_String::CODER_UTF16);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1754
  }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1755
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1756
  for (int argi = 0; argi < sc->num_arguments(); argi++) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1757
    Node* arg = sc->argument(argi);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1758
    switch (sc->mode(argi)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1759
      case StringConcat::IntMode: {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1760
        Node* string_size = int_stringSize(kit, arg);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1761
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1762
        // accumulate total
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1763
        length = __ AddI(length, string_size);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1764
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1765
        // Cache this value for the use by int_toString
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1766
        string_sizes->init_req(argi, string_size);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1767
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1768
      }
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1769
      case StringConcat::StringNullCheckMode: {
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1770
        const Type* type = kit.gvn().type(arg);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1771
        assert(type != TypePtr::NULL_PTR, "missing check");
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1772
        if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1773
          // Null check with uncommon trap since
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1774
          // StringBuilder(null) throws exception.
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1775
          // Use special uncommon trap instead of
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1776
          // calling normal do_null_check().
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1777
          Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1778
          IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1779
          overflow->add_req(__ IfFalse(iff));
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1780
          Node* notnull = __ IfTrue(iff);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1781
          kit.set_control(notnull); // set control for the cast_not_null
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1782
          arg = kit.cast_not_null(arg, false);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1783
          sc->set_argument(argi, arg);
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1784
        }
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1785
        assert(kit.gvn().type(arg)->higher_equal(TypeInstPtr::NOTNULL), "sanity");
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1786
        // Fallthrough to add string length.
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1787
      }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1788
      case StringConcat::StringMode: {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1789
        const Type* type = kit.gvn().type(arg);
28642
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1790
        Node* count = NULL;
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1791
        Node* arg_coder = NULL;
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1792
        if (type == TypePtr::NULL_PTR) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1793
          // replace the argument with the null checked version
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1794
          arg = null_string;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1795
          sc->set_argument(argi, arg);
28642
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1796
          count = kit.load_String_length(kit.control(), arg);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1797
          arg_coder = kit.load_String_coder(kit.control(), arg);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1798
        } else if (!type->higher_equal(TypeInstPtr::NOTNULL)) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1799
          // s = s != null ? s : "null";
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1800
          // length = length + (s.count - s.offset);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1801
          RegionNode *r = new RegionNode(3);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1802
          kit.gvn().set_type(r, Type::CONTROL);
24923
9631f7d691dc 8034812: remove IDX_INIT macro hack in Node class
thartmann
parents: 22845
diff changeset
  1803
          Node *phi = new PhiNode(r, type);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1804
          kit.gvn().set_type(phi, phi->bottom_type());
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1805
          Node* p = __ Bool(__ CmpP(arg, kit.null()), BoolTest::ne);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1806
          IfNode* iff = kit.create_and_map_if(kit.control(), p, PROB_MIN, COUNT_UNKNOWN);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1807
          Node* notnull = __ IfTrue(iff);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1808
          Node* isnull =  __ IfFalse(iff);
4891
7c8755dd5bb2 6920293: OptimizeStringConcat causing core dumps
never
parents: 4450
diff changeset
  1809
          kit.set_control(notnull); // set control for the cast_not_null
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1810
          r->init_req(1, notnull);
4891
7c8755dd5bb2 6920293: OptimizeStringConcat causing core dumps
never
parents: 4450
diff changeset
  1811
          phi->init_req(1, kit.cast_not_null(arg, false));
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1812
          r->init_req(2, isnull);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1813
          phi->init_req(2, null_string);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1814
          kit.set_control(r);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1815
          C->record_for_igvn(r);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1816
          C->record_for_igvn(phi);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1817
          // replace the argument with the null checked version
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1818
          arg = phi;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1819
          sc->set_argument(argi, arg);
28642
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1820
          count = kit.load_String_length(kit.control(), arg);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1821
          arg_coder = kit.load_String_coder(kit.control(), arg);
28642
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1822
        } else {
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1823
          // A corresponding nullcheck will be connected during IGVN MemNode::Ideal_common_DU_postCCP
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1824
          // kit.control might be a different test, that can be hoisted above the actual nullcheck
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1825
          // in case, that the control input is not null, Ideal_common_DU_postCCP will not look for a nullcheck.
a42fefc69922 8068909: SIGSEGV in c2 compiled code with OptimizeStringConcat
asiebenborn
parents: 25930
diff changeset
  1826
          count = kit.load_String_length(NULL, arg);
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1827
          arg_coder = kit.load_String_coder(NULL, arg);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1828
        }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1829
        if (arg->is_Con()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1830
          // Constant string. Get constant coder and length.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1831
          jbyte const_coder = get_constant_coder(kit, arg);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1832
          int const_length = get_constant_length(kit, arg);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1833
          if (const_coder == java_lang_String::CODER_LATIN1) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1834
            // Can be latin1 encoded
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1835
            arg_coder = __ intcon(const_coder);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1836
            count = __ intcon(const_length);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1837
          } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1838
            // Found UTF16 encoded string. Fix result array encoding to UTF16.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1839
            coder_fixed = true;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1840
            coder = __ intcon(const_coder);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1841
            count = __ intcon(const_length / 2);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1842
          }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1843
        }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1844
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1845
        if (!coder_fixed) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1846
          coder = __ OrI(coder, arg_coder);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1847
        }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1848
        length = __ AddI(length, count);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1849
        string_sizes->init_req(argi, NULL);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1850
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1851
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1852
      case StringConcat::CharMode: {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1853
        // one character only
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1854
        const TypeInt* t = kit.gvn().type(arg)->is_int();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1855
        if (!coder_fixed && t->is_con()) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1856
          // Constant char
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1857
          if (t->get_con() <= 255) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1858
            // Can be latin1 encoded
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1859
            coder = __ OrI(coder, __ intcon(java_lang_String::CODER_LATIN1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1860
          } else {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1861
            // Must be UTF16 encoded. Fix result array encoding to UTF16.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1862
            coder_fixed = true;
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1863
            coder = __ intcon(java_lang_String::CODER_UTF16);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1864
          }
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1865
        } else if (!coder_fixed) {
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1866
          // Not constant
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1867
#undef __
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1868
#define __ ideal.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1869
          IdealKit ideal(&kit, true, true);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1870
          IdealVariable char_coder(ideal); __ declarations_done();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1871
          // Check if character can be latin1 encoded
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1872
          __ if_then(arg, BoolTest::le, __ ConI(0xFF));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1873
            __ set(char_coder, __ ConI(java_lang_String::CODER_LATIN1));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1874
          __ else_();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1875
            __ set(char_coder, __ ConI(java_lang_String::CODER_UTF16));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1876
          __ end_if();
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1877
          kit.sync_kit(ideal);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1878
          coder = __ OrI(coder, __ value(char_coder));
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1879
#undef __
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1880
#define __ kit.
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1881
        }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1882
        length = __ AddI(length, __ intcon(1));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1883
        break;
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1884
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1885
      default:
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1886
        ShouldNotReachHere();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1887
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1888
    if (argi > 0) {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1889
      // Check that the sum hasn't overflowed
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1890
      IfNode* iff = kit.create_and_map_if(kit.control(),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1891
                                          __ Bool(__ CmpI(length, __ intcon(0)), BoolTest::lt),
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1892
                                          PROB_MIN, COUNT_UNKNOWN);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1893
      kit.set_control(__ IfFalse(iff));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1894
      overflow->set_req(argi, __ IfTrue(iff));
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1895
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1896
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1897
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1898
  {
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1899
    // Hook
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1900
    PreserveJVMState pjvms(&kit);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1901
    kit.set_control(overflow);
7714
f078cdefa674 7009359: HS with -XX:+AggressiveOpts optimize new StringBuffer(null) so it does not throw NPE as expected
kvn
parents: 7397
diff changeset
  1902
    C->record_for_igvn(overflow);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1903
    kit.uncommon_trap(Deoptimization::Reason_intrinsic,
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1904
                      Deoptimization::Action_make_not_entrant);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1905
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1906
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1907
  Node* result;
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1908
  if (!kit.stopped()) {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1909
    assert(CompactStrings || (coder->is_Con() && coder->get_int() == java_lang_String::CODER_UTF16),
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1910
           "Result string must be UTF16 encoded if CompactStrings is disabled");
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1911
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1912
    Node* dst_array = NULL;
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1913
    if (sc->num_arguments() == 1 &&
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1914
        (sc->mode(0) == StringConcat::StringMode ||
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1915
         sc->mode(0) == StringConcat::StringNullCheckMode)) {
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1916
      // Handle the case when there is only a single String argument.
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1917
      // In this case, we can just pull the value from the String itself.
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1918
      dst_array = kit.load_String_value(kit.control(), sc->argument(0));
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1919
    } else {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1920
      // Allocate destination byte array according to coder
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1921
      dst_array = allocate_byte_array(kit, NULL, __ LShiftI(length, coder));
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1922
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1923
      // Now copy the string representations into the final byte[]
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1924
      Node* start = __ intcon(0);
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1925
      for (int argi = 0; argi < sc->num_arguments(); argi++) {
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1926
        Node* arg = sc->argument(argi);
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1927
        switch (sc->mode(argi)) {
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1928
          case StringConcat::IntMode: {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1929
            start = int_getChars(kit, arg, dst_array, coder, start, string_sizes->in(argi));
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1930
            break;
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1931
          }
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1932
          case StringConcat::StringNullCheckMode:
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1933
          case StringConcat::StringMode: {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1934
            start = copy_string(kit, arg, dst_array, coder, start);
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1935
            break;
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1936
          }
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1937
          case StringConcat::CharMode: {
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1938
            start = copy_char(kit, arg, dst_array, coder, start);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1939
          break;
32467
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1940
          }
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1941
          default:
23b29549f8d1 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat
shade
parents: 29081
diff changeset
  1942
            ShouldNotReachHere();
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1943
        }
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1944
      }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1945
    }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1946
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1947
    // If we're not reusing an existing String allocation then allocate one here.
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1948
    result = sc->string_alloc();
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1949
    if (result == NULL) {
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1950
      PreserveReexecuteState preexecs(&kit);
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1951
      // The original jvms is for an allocation of either a String or
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1952
      // StringBuffer so no stack adjustment is necessary for proper
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1953
      // reexecution.
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1954
      kit.jvms()->set_should_reexecute(true);
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1955
      result = kit.new_instance(__ makecon(TypeKlassPtr::make(C->env()->String_klass())));
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1956
    }
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1957
33628
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1958
    // Initialize the string
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1959
    kit.store_String_value(kit.control(), result, dst_array);
09241459a8b8 8141132: JEP 254: Compact Strings
thartmann
parents: 33105
diff changeset
  1960
    kit.store_String_coder(kit.control(), result, coder);
14828
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1961
  } else {
bb9dffedf46c 8005031: Some cleanup in c2 to prepare for incremental inlining support
roland
parents: 14623
diff changeset
  1962
    result = C->top();
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1963
  }
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1964
  // hook up the outgoing control and result
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1965
  kit.replace_call(sc->end(), result);
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1966
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1967
  // Unhook any hook nodes
14623
70c4c1be0a14 7092905: C2: Keep track of the number of dead nodes
bharadwaj
parents: 13895
diff changeset
  1968
  string_sizes->disconnect_inputs(NULL, C);
4450
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1969
  sc->cleanup();
6d700b859b3e 6892658: C2 should optimize some stringbuilder patterns
never
parents:
diff changeset
  1970
}