src/hotspot/share/runtime/handshake.cpp
author rehn
Thu, 04 Oct 2018 14:03:13 +0200
changeset 52013 92383597fa21
parent 51432 90024ea291b4
child 52341 2b58b8e1d28f
permissions -rw-r--r--
8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable" Reviewed-by: dcubed, dholmes
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     1
/*
52013
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
     2
 * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     4
 *
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     7
 * published by the Free Software Foundation.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     8
 *
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    13
 * accompanied this code).
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    14
 *
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    18
 *
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    21
 * questions.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    22
 *
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    23
 */
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    24
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    25
#include "precompiled.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    26
#include "logging/log.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    27
#include "logging/logStream.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    28
#include "memory/resourceArea.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    29
#include "runtime/handshake.hpp"
49449
ef5d5d343e2a 8199263: Split interfaceSupport.hpp to not require including .inline.hpp files
coleenp
parents: 48105
diff changeset
    30
#include "runtime/interfaceSupport.inline.hpp"
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    31
#include "runtime/orderAccess.hpp"
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    32
#include "runtime/osThread.hpp"
50192
8bc79d2d1568 8203341: Add a safepoint-aware Semaphore
stefank
parents: 49449
diff changeset
    33
#include "runtime/semaphore.inline.hpp"
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    34
#include "runtime/task.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    35
#include "runtime/timerTrace.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    36
#include "runtime/thread.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    37
#include "runtime/vmThread.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    38
#include "utilities/formatBuffer.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    39
#include "utilities/preserveException.hpp"
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    40
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    41
class HandshakeOperation: public StackObj {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    42
public:
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    43
  virtual void do_handshake(JavaThread* thread) = 0;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    44
  virtual void cancel_handshake(JavaThread* thread) = 0;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    45
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    46
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    47
class HandshakeThreadsOperation: public HandshakeOperation {
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    48
  static Semaphore _done;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    49
  ThreadClosure* _thread_cl;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    50
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    51
public:
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    52
  HandshakeThreadsOperation(ThreadClosure* cl) : _thread_cl(cl) {}
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    53
  void do_handshake(JavaThread* thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    54
  void cancel_handshake(JavaThread* thread) { _done.signal(); };
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    55
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    56
  bool thread_has_completed() { return _done.trywait(); }
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    57
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    58
#ifdef ASSERT
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    59
  void check_state() {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    60
    assert(!_done.trywait(), "Must be zero");
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    61
  }
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    62
#endif
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    63
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    64
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    65
Semaphore HandshakeThreadsOperation::_done(0);
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    66
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    67
class VM_Handshake: public VM_Operation {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    68
  const jlong _handshake_timeout;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    69
 public:
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    70
  bool evaluate_at_safepoint() const { return false; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    71
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    72
  bool evaluate_concurrently() const { return false; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    73
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    74
 protected:
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
    75
  HandshakeThreadsOperation* const _op;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    76
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    77
  VM_Handshake(HandshakeThreadsOperation* op) :
51334
cc2c79d22508 8208671: Runtime, JFR, Serviceability changes to allow enabling -Wreorder
tschatzl
parents: 50921
diff changeset
    78
      _handshake_timeout(TimeHelper::millis_to_counter(HandshakeTimeout)), _op(op) {}
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    79
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    80
  void set_handshake(JavaThread* target) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    81
    target->set_handshake_operation(_op);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    82
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    83
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    84
  // This method returns true for threads completed their operation
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    85
  // and true for threads canceled their operation.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    86
  // A cancellation can happen if the thread is exiting.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    87
  bool poll_for_completed_thread() { return _op->thread_has_completed(); }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    88
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    89
  bool handshake_has_timed_out(jlong start_time);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    90
  static void handle_timeout();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    91
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    92
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    93
bool VM_Handshake::handshake_has_timed_out(jlong start_time) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    94
  // Check if handshake operation has timed out
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    95
  if (_handshake_timeout > 0) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    96
    return os::elapsed_counter() >= (start_time + _handshake_timeout);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    97
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    98
  return false;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
    99
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   100
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   101
void VM_Handshake::handle_timeout() {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   102
  LogStreamHandle(Warning, handshake) log_stream;
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   103
  for (JavaThreadIteratorWithHandle jtiwh; JavaThread *thr = jtiwh.next(); ) {
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   104
    if (thr->has_handshake()) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   105
      log_stream.print("Thread " PTR_FORMAT " has not cleared its handshake op", p2i(thr));
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   106
      thr->print_thread_state_on(&log_stream);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   107
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   108
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   109
  log_stream.flush();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   110
  fatal("Handshake operation timed out");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   111
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   112
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   113
class VM_HandshakeOneThread: public VM_Handshake {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   114
  JavaThread* _target;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   115
  bool _thread_alive;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   116
 public:
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   117
  VM_HandshakeOneThread(HandshakeThreadsOperation* op, JavaThread* target) :
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   118
    VM_Handshake(op), _target(target), _thread_alive(false) {}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   119
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   120
  void doit() {
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   121
    DEBUG_ONLY(_op->check_state();)
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   122
    TraceTime timer("Performing single-target operation (vmoperation doit)", TRACETIME_LOG(Info, handshake));
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   123
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   124
    {
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   125
      ThreadsListHandle tlh;
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   126
      if (tlh.includes(_target)) {
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   127
        set_handshake(_target);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   128
        _thread_alive = true;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   129
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   130
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   131
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   132
    if (!_thread_alive) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   133
      return;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   134
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   135
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   136
    if (!UseMembar) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   137
      os::serialize_thread_states();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   138
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   139
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   140
    log_trace(handshake)("Thread signaled, begin processing by VMThtread");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   141
    jlong start_time = os::elapsed_counter();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   142
    do {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   143
      if (handshake_has_timed_out(start_time)) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   144
        handle_timeout();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   145
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   146
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   147
      // We need to re-think this with SMR ThreadsList.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   148
      // There is an assumption in the code that the Threads_lock should be
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   149
      // locked during certain phases.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   150
      MutexLockerEx ml(Threads_lock, Mutex::_no_safepoint_check_flag);
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   151
      ThreadsListHandle tlh;
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   152
      if (tlh.includes(_target)) {
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   153
        // Warning _target's address might be re-used.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   154
        // handshake_process_by_vmthread will check the semaphore for us again.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   155
        // Since we can't have more then one handshake in flight a reuse of
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   156
        // _target's address should be okay since the new thread will not have
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   157
        // an operation.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   158
        _target->handshake_process_by_vmthread();
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   159
      } else {
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   160
        // We can't warn here since the thread does cancel_handshake after
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   161
        // it has been removed from the ThreadsList. So we should just keep
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   162
        // looping here until while below returns false. If we have a bug,
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   163
        // then we hang here, which is good for debugging.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   164
      }
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   165
    } while (!poll_for_completed_thread());
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   166
    DEBUG_ONLY(_op->check_state();)
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   167
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   168
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   169
  VMOp_Type type() const { return VMOp_HandshakeOneThread; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   170
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   171
  bool thread_alive() const { return _thread_alive; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   172
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   173
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   174
class VM_HandshakeAllThreads: public VM_Handshake {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   175
 public:
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   176
  VM_HandshakeAllThreads(HandshakeThreadsOperation* op) : VM_Handshake(op) {}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   177
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   178
  void doit() {
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   179
    DEBUG_ONLY(_op->check_state();)
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   180
    TraceTime timer("Performing operation (vmoperation doit)", TRACETIME_LOG(Info, handshake));
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   181
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   182
    int number_of_threads_issued = 0;
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   183
    for (JavaThreadIteratorWithHandle jtiwh; JavaThread *thr = jtiwh.next(); ) {
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   184
      set_handshake(thr);
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   185
      number_of_threads_issued++;
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   186
    }
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   187
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   188
    if (number_of_threads_issued < 1) {
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   189
      log_debug(handshake)("No threads to handshake.");
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   190
      return;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   191
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   192
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   193
    if (!UseMembar) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   194
      os::serialize_thread_states();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   195
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   196
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   197
    log_debug(handshake)("Threads signaled, begin processing blocked threads by VMThtread");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   198
    const jlong start_time = os::elapsed_counter();
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   199
    int number_of_threads_completed = 0;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   200
    do {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   201
      // Check if handshake operation has timed out
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   202
      if (handshake_has_timed_out(start_time)) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   203
        handle_timeout();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   204
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   205
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   206
      // Have VM thread perform the handshake operation for blocked threads.
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   207
      // Observing a blocked state may of course be transient but the processing is guarded
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   208
      // by semaphores and we optimistically begin by working on the blocked threads
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   209
      {
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   210
          // We need to re-think this with SMR ThreadsList.
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   211
          // There is an assumption in the code that the Threads_lock should
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   212
          // be locked during certain phases.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   213
          MutexLockerEx ml(Threads_lock, Mutex::_no_safepoint_check_flag);
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   214
          for (JavaThreadIteratorWithHandle jtiwh; JavaThread *thr = jtiwh.next(); ) {
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   215
            // A new thread on the ThreadsList will not have an operation,
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   216
            // hence it is skipped in handshake_process_by_vmthread.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   217
            thr->handshake_process_by_vmthread();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   218
          }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   219
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   220
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   221
      while (poll_for_completed_thread()) {
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   222
        // Includes canceled operations by exiting threads.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   223
        number_of_threads_completed++;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   224
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   225
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   226
    } while (number_of_threads_issued > number_of_threads_completed);
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   227
    assert(number_of_threads_issued == number_of_threads_completed, "Must be the same");
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   228
    DEBUG_ONLY(_op->check_state();)
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   229
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   230
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   231
  VMOp_Type type() const { return VMOp_HandshakeAllThreads; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   232
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   233
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   234
class VM_HandshakeFallbackOperation : public VM_Operation {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   235
  ThreadClosure* _thread_cl;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   236
  Thread* _target_thread;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   237
  bool _all_threads;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   238
  bool _thread_alive;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   239
public:
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   240
  VM_HandshakeFallbackOperation(ThreadClosure* cl) :
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   241
      _thread_cl(cl), _target_thread(NULL), _all_threads(true), _thread_alive(true) {}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   242
  VM_HandshakeFallbackOperation(ThreadClosure* cl, Thread* target) :
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   243
      _thread_cl(cl), _target_thread(target), _all_threads(false), _thread_alive(false) {}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   244
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   245
  void doit() {
48105
8d15b1369c7a 8167108: inconsistent handling of SR_lock can lead to crashes
dcubed
parents: 47881
diff changeset
   246
    for (JavaThreadIteratorWithHandle jtiwh; JavaThread *t = jtiwh.next(); ) {
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   247
      if (_all_threads || t == _target_thread) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   248
        if (t == _target_thread) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   249
          _thread_alive = true;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   250
        }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   251
        _thread_cl->do_thread(t);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   252
      }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   253
    }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   254
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   255
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   256
  VMOp_Type type() const { return VMOp_HandshakeFallback; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   257
  bool thread_alive() const { return _thread_alive; }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   258
};
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   259
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   260
void HandshakeThreadsOperation::do_handshake(JavaThread* thread) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   261
  ResourceMark rm;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   262
  FormatBufferResource message("Operation for thread " PTR_FORMAT ", is_vm_thread: %s",
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   263
                               p2i(thread), BOOL_TO_STR(Thread::current()->is_VM_thread()));
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   264
  TraceTime timer(message, TRACETIME_LOG(Debug, handshake, task));
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   265
  _thread_cl->do_thread(thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   266
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   267
  // Use the semaphore to inform the VM thread that we have completed the operation
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   268
  _done.signal();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   269
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   270
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   271
void Handshake::execute(ThreadClosure* thread_cl) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   272
  if (ThreadLocalHandshakes) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   273
    HandshakeThreadsOperation cto(thread_cl);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   274
    VM_HandshakeAllThreads handshake(&cto);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   275
    VMThread::execute(&handshake);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   276
  } else {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   277
    VM_HandshakeFallbackOperation op(thread_cl);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   278
    VMThread::execute(&op);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   279
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   280
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   281
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   282
bool Handshake::execute(ThreadClosure* thread_cl, JavaThread* target) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   283
  if (ThreadLocalHandshakes) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   284
    HandshakeThreadsOperation cto(thread_cl);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   285
    VM_HandshakeOneThread handshake(&cto, target);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   286
    VMThread::execute(&handshake);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   287
    return handshake.thread_alive();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   288
  } else {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   289
    VM_HandshakeFallbackOperation op(thread_cl, target);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   290
    VMThread::execute(&op);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   291
    return op.thread_alive();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   292
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   293
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   294
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   295
HandshakeState::HandshakeState() : _operation(NULL), _semaphore(1), _thread_in_process_handshake(false) {}
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   296
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   297
void HandshakeState::set_operation(JavaThread* target, HandshakeOperation* op) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   298
  _operation = op;
50921
7f462e8383f6 8206003: SafepointSynchronize with TLH: StoreStore barriers should be moved out of the loop
mdoerr
parents: 50626
diff changeset
   299
  SafepointMechanism::arm_local_poll_release(target);
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   300
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   301
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   302
void HandshakeState::clear_handshake(JavaThread* target) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   303
  _operation = NULL;
50921
7f462e8383f6 8206003: SafepointSynchronize with TLH: StoreStore barriers should be moved out of the loop
mdoerr
parents: 50626
diff changeset
   304
  SafepointMechanism::disarm_local_poll_release(target);
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   305
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   306
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   307
void HandshakeState::process_self_inner(JavaThread* thread) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   308
  assert(Thread::current() == thread, "should call from thread");
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   309
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   310
  if (thread->is_terminated()) {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   311
    // If thread is not on threads list but armed, cancel.
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   312
    thread->cancel_handshake();
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   313
    return;
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   314
  }
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   315
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   316
  CautiouslyPreserveExceptionMark pem(thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   317
  ThreadInVMForHandshake tivm(thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   318
  if (!_semaphore.trywait()) {
50192
8bc79d2d1568 8203341: Add a safepoint-aware Semaphore
stefank
parents: 49449
diff changeset
   319
    _semaphore.wait_with_safepoint_check(thread);
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   320
  }
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   321
  HandshakeOperation* op = OrderAccess::load_acquire(&_operation);
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   322
  if (op != NULL) {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   323
    // Disarm before execute the operation
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   324
    clear_handshake(thread);
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   325
    op->do_handshake(thread);
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   326
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   327
  _semaphore.signal();
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   328
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   329
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   330
void HandshakeState::cancel_inner(JavaThread* thread) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   331
  assert(Thread::current() == thread, "should call from thread");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   332
  assert(thread->thread_state() == _thread_in_vm, "must be in vm state");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   333
  HandshakeOperation* op = _operation;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   334
  clear_handshake(thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   335
  if (op != NULL) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   336
    op->cancel_handshake(thread);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   337
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   338
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   339
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   340
bool HandshakeState::vmthread_can_process_handshake(JavaThread* target) {
51432
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   341
  // SafepointSynchronize::safepoint_safe() does not consider an externally
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   342
  // suspended thread to be safe. However, this function must be called with
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   343
  // the Threads_lock held so an externally suspended thread cannot be
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   344
  // resumed thus it is safe.
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   345
  assert(Threads_lock->owned_by_self(), "Not holding Threads_lock.");
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   346
  return SafepointSynchronize::safepoint_safe(target, target->thread_state()) ||
90024ea291b4 8207334: VM times out in VM_HandshakeAllThreads::doit() with RunThese30M
rehn
parents: 51334
diff changeset
   347
         target->is_ext_suspended();
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   348
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   349
52013
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   350
static bool possibly_vmthread_can_process_handshake(JavaThread* target) {
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   351
  // An externally suspended thread cannot be resumed while the
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   352
  // Threads_lock is held so it is safe.
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   353
  // Note that this method is allowed to produce false positives.
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   354
  assert(Threads_lock->owned_by_self(), "Not holding Threads_lock.");
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   355
  if (target->is_ext_suspended()) {
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   356
    return true;
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   357
  }
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   358
  switch (target->thread_state()) {
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   359
  case _thread_in_native:
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   360
    // native threads are safe if they have no java stack or have walkable stack
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   361
    return !target->has_last_Java_frame() || target->frame_anchor()->walkable();
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   362
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   363
  case _thread_blocked:
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   364
    return true;
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   365
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   366
  default:
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   367
    return false;
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   368
  }
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   369
}
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   370
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   371
bool HandshakeState::claim_handshake_for_vmthread() {
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   372
  if (!_semaphore.trywait()) {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   373
    return false;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   374
  }
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   375
  if (has_operation()) {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   376
    return true;
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   377
  }
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   378
  _semaphore.signal();
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   379
  return false;
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   380
}
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   381
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   382
void HandshakeState::process_by_vmthread(JavaThread* target) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   383
  assert(Thread::current()->is_VM_thread(), "should call from vm thread");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   384
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   385
  if (!has_operation()) {
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   386
    // JT has already cleared its handshake
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   387
    return;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   388
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   389
52013
92383597fa21 8210303: VM_HandshakeAllThreads fails assert with "failed: blocked and not walkable"
rehn
parents: 51432
diff changeset
   390
  if (!possibly_vmthread_can_process_handshake(target)) {
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   391
    // JT is observed in an unsafe state, it must notice the handshake itself
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   392
    return;
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   393
  }
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   394
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   395
  // Claim the semaphore if there still an operation to be executed.
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   396
  if (!claim_handshake_for_vmthread()) {
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   397
    return;
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   398
  }
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   399
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   400
  // If we own the semaphore at this point and while owning the semaphore
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   401
  // can observe a safe state the thread cannot possibly continue without
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   402
  // getting caught by the semaphore.
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   403
  if (vmthread_can_process_handshake(target)) {
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   404
    guarantee(!_semaphore.trywait(), "we should already own the semaphore");
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   405
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   406
    _operation->do_handshake(target);
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   407
    // Disarm after VM thread have executed the operation.
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   408
    clear_handshake(target);
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   409
    // Release the thread
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   410
  }
50626
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   411
9fdfe5ca0e5e 8204166: TLH: Semaphore may not be destroy until signal have returned.
rehn
parents: 50192
diff changeset
   412
  _semaphore.signal();
47881
0ce0ac68ace7 8189941: Implementation JEP 312: Thread-local handshake
rehn
parents:
diff changeset
   413
}