hotspot/src/share/vm/classfile/protectionDomainCache.cpp
author coleenp
Wed, 23 Aug 2017 14:52:55 -0400
changeset 46968 9119841280f4
parent 46742 24ec8a039c90
permissions -rw-r--r--
8160399: is_oop_or_null involves undefined behavior 8164984: Improper use of is_oop in production code Summary: replace oop->is_oop*() with oopDesc::is_oop*(oop) so this pointer can be verified Reviewed-by: iklam, kvn, dholmes
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     1
/*
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     2
 * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     4
 *
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     7
 * published by the Free Software Foundation.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     8
 *
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    13
 * accompanied this code).
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    14
 *
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    18
 *
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    21
 * questions.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    22
 *
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    23
 */
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    24
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    25
#include "precompiled.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    26
#include "classfile/protectionDomainCache.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    27
#include "classfile/systemDictionary.hpp"
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    28
#include "logging/log.hpp"
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    29
#include "logging/logStream.hpp"
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    30
#include "memory/iterator.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    31
#include "memory/resourceArea.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    32
#include "oops/oop.inline.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    33
#include "utilities/hashtable.inline.hpp"
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    34
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    35
unsigned int ProtectionDomainCacheTable::compute_hash(Handle protection_domain) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    36
  // Identity hash can safepoint, so keep protection domain in a Handle.
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    37
  return (unsigned int)(protection_domain->identity_hash());
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    38
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    39
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    40
int ProtectionDomainCacheTable::index_for(Handle protection_domain) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    41
  return hash_to_index(compute_hash(protection_domain));
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    42
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    43
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    44
ProtectionDomainCacheTable::ProtectionDomainCacheTable(int table_size)
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    45
  : Hashtable<oop, mtClass>(table_size, sizeof(ProtectionDomainCacheEntry))
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    46
{
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    47
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    48
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    49
void ProtectionDomainCacheTable::unlink(BoolObjectClosure* is_alive) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    50
  assert(SafepointSynchronize::is_at_safepoint(), "must be");
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    51
  for (int i = 0; i < table_size(); ++i) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    52
    ProtectionDomainCacheEntry** p = bucket_addr(i);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    53
    ProtectionDomainCacheEntry* entry = bucket(i);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    54
    while (entry != NULL) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    55
      if (is_alive->do_object_b(entry->literal())) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    56
        p = entry->next_addr();
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    57
      } else {
46701
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    58
        LogTarget(Debug, protectiondomain) lt;
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    59
        if (lt.is_enabled()) {
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    60
          LogStream ls(lt);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    61
          ls.print("protection domain unlinked: ");
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    62
          entry->literal()->print_value_on(&ls);
f559541c0daa 8181917: Refactor UL LogStreams to avoid using resource area
stuefe
parents: 46475
diff changeset
    63
          ls.cr();
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    64
        }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    65
        *p = entry->next();
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    66
        free_entry(entry);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    67
      }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    68
      entry = *p;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    69
    }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    70
  }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    71
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    72
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    73
void ProtectionDomainCacheTable::oops_do(OopClosure* f) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    74
  for (int index = 0; index < table_size(); index++) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    75
    for (ProtectionDomainCacheEntry* probe = bucket(index);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    76
                                     probe != NULL;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    77
                                     probe = probe->next()) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    78
      probe->oops_do(f);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    79
    }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    80
  }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    81
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    82
46742
24ec8a039c90 8184994: Add Dictionary size logging and jcmd
coleenp
parents: 46729
diff changeset
    83
void ProtectionDomainCacheTable::print_on(outputStream* st) const {
24ec8a039c90 8184994: Add Dictionary size logging and jcmd
coleenp
parents: 46729
diff changeset
    84
  st->print_cr("Protection domain cache table (table_size=%d, classes=%d)",
24ec8a039c90 8184994: Add Dictionary size logging and jcmd
coleenp
parents: 46729
diff changeset
    85
               table_size(), number_of_entries());
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    86
  for (int index = 0; index < table_size(); index++) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    87
    for (ProtectionDomainCacheEntry* probe = bucket(index);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    88
                                     probe != NULL;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    89
                                     probe = probe->next()) {
46742
24ec8a039c90 8184994: Add Dictionary size logging and jcmd
coleenp
parents: 46729
diff changeset
    90
      st->print_cr("%4d: protection_domain: " PTR_FORMAT, index, p2i(probe->literal()));
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    91
    }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    92
  }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    93
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    94
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    95
void ProtectionDomainCacheTable::verify() {
46475
75902cea18af 8166848: Performance bug: SystemDictionary - optimization
coleenp
parents: 46382
diff changeset
    96
  verify_table<ProtectionDomainCacheEntry>("Protection Domain Table");
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    97
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    98
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
    99
void ProtectionDomainCacheEntry::verify() {
46968
9119841280f4 8160399: is_oop_or_null involves undefined behavior
coleenp
parents: 46742
diff changeset
   100
  guarantee(oopDesc::is_oop(literal()), "must be an oop");
46382
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   101
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   102
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   103
ProtectionDomainCacheEntry* ProtectionDomainCacheTable::get(Handle protection_domain) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   104
  unsigned int hash = compute_hash(protection_domain);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   105
  int index = hash_to_index(hash);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   106
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   107
  ProtectionDomainCacheEntry* entry = find_entry(index, protection_domain);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   108
  if (entry == NULL) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   109
    entry = add_entry(index, hash, protection_domain);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   110
  }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   111
  return entry;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   112
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   113
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   114
ProtectionDomainCacheEntry* ProtectionDomainCacheTable::find_entry(int index, Handle protection_domain) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   115
  for (ProtectionDomainCacheEntry* e = bucket(index); e != NULL; e = e->next()) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   116
    if (e->protection_domain() == protection_domain()) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   117
      return e;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   118
    }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   119
  }
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   120
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   121
  return NULL;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   122
}
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   123
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   124
ProtectionDomainCacheEntry* ProtectionDomainCacheTable::add_entry(int index, unsigned int hash, Handle protection_domain) {
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   125
  assert_locked_or_safepoint(SystemDictionary_lock);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   126
  assert(index == index_for(protection_domain), "incorrect index?");
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   127
  assert(find_entry(index, protection_domain) == NULL, "no double entry");
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   128
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   129
  ProtectionDomainCacheEntry* p = new_entry(hash, protection_domain);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   130
  Hashtable<oop, mtClass>::add_entry(index, p);
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   131
  return p;
5520c435279b 8178336: Unnecessary SystemDictionary walk for Protection domain liveness
coleenp
parents:
diff changeset
   132
}