langtools/src/share/classes/com/sun/tools/javac/comp/Flow.java
author pgovereau
Tue, 27 May 2014 22:26:53 +0100
changeset 24610 8b3b718970a9
parent 24218 9102c46a15dc
child 25443 9187d77f2c64
permissions -rw-r--r--
8042741: Java 8 compiler throws NullPointerException depending location in source file Reviewed-by: vromero, jlahoda
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     1
/*
24066
1dfb66929538 8029718: Should always use lambda body structure to disambiguate overload resolution
vromero
parents: 22166
diff changeset
     2
 * Copyright (c) 1999, 2014, Oracle and/or its affiliates. All rights reserved.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
06bc494ca11e Initial load
duke
parents:
diff changeset
     4
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
06bc494ca11e Initial load
duke
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
10
06bc494ca11e Initial load
duke
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    10
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
06bc494ca11e Initial load
duke
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
06bc494ca11e Initial load
duke
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
06bc494ca11e Initial load
duke
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
06bc494ca11e Initial load
duke
parents:
diff changeset
    15
 * accompanied this code).
06bc494ca11e Initial load
duke
parents:
diff changeset
    16
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
06bc494ca11e Initial load
duke
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
06bc494ca11e Initial load
duke
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
06bc494ca11e Initial load
duke
parents:
diff changeset
    20
 *
5520
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
86e4b9a9da40 6943119: Rebrand source copyright notices
ohair
parents: 5492
diff changeset
    23
 * questions.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    24
 */
06bc494ca11e Initial load
duke
parents:
diff changeset
    25
06bc494ca11e Initial load
duke
parents:
diff changeset
    26
//todo: one might eliminate uninits.andSets when monotonic
06bc494ca11e Initial load
duke
parents:
diff changeset
    27
06bc494ca11e Initial load
duke
parents:
diff changeset
    28
package com.sun.tools.javac.comp;
06bc494ca11e Initial load
duke
parents:
diff changeset
    29
5492
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 3149
diff changeset
    30
import java.util.HashMap;
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 3149
diff changeset
    31
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    32
import com.sun.tools.javac.code.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    33
import com.sun.tools.javac.tree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    34
import com.sun.tools.javac.util.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    35
import com.sun.tools.javac.util.JCDiagnostic.DiagnosticPosition;
06bc494ca11e Initial load
duke
parents:
diff changeset
    36
06bc494ca11e Initial load
duke
parents:
diff changeset
    37
import com.sun.tools.javac.code.Symbol.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    38
import com.sun.tools.javac.tree.JCTree.*;
06bc494ca11e Initial load
duke
parents:
diff changeset
    39
06bc494ca11e Initial load
duke
parents:
diff changeset
    40
import static com.sun.tools.javac.code.Flags.*;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 9601
diff changeset
    41
import static com.sun.tools.javac.code.Flags.BLOCK;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    42
import static com.sun.tools.javac.code.Kinds.*;
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14259
diff changeset
    43
import static com.sun.tools.javac.code.TypeTag.BOOLEAN;
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14259
diff changeset
    44
import static com.sun.tools.javac.code.TypeTag.VOID;
10950
e87b50888909 6921494: provide way to print javac tree tag values
jjg
parents: 9601
diff changeset
    45
import static com.sun.tools.javac.tree.JCTree.Tag.*;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    46
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    47
/** This pass implements dataflow analysis for Java programs though
24066
1dfb66929538 8029718: Should always use lambda body structure to disambiguate overload resolution
vromero
parents: 22166
diff changeset
    48
 *  different AST visitor steps. Liveness analysis (see AliveAnalyzer) checks that
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    49
 *  every statement is reachable. Exception analysis (see FlowAnalyzer) ensures that
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    50
 *  every checked exception that is thrown is declared or caught.  Definite assignment analysis
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    51
 *  (see AssignAnalyzer) ensures that each variable is assigned when used.  Definite
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    52
 *  unassignment analysis (see AssignAnalyzer) in ensures that no final variable
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
    53
 *  is assigned more than once. Finally, local variable capture analysis (see CaptureAnalyzer)
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
    54
 *  determines that local variables accessed within the scope of an inner class/lambda
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
    55
 *  are either final or effectively-final.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    56
 *
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
    57
 *  <p>The JLS has a number of problems in the
10
06bc494ca11e Initial load
duke
parents:
diff changeset
    58
 *  specification of these flow analysis problems. This implementation
06bc494ca11e Initial load
duke
parents:
diff changeset
    59
 *  attempts to address those issues.
06bc494ca11e Initial load
duke
parents:
diff changeset
    60
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    61
 *  <p>First, there is no accommodation for a finally clause that cannot
06bc494ca11e Initial load
duke
parents:
diff changeset
    62
 *  complete normally. For liveness analysis, an intervening finally
06bc494ca11e Initial load
duke
parents:
diff changeset
    63
 *  clause can cause a break, continue, or return not to reach its
06bc494ca11e Initial load
duke
parents:
diff changeset
    64
 *  target.  For exception analysis, an intervening finally clause can
06bc494ca11e Initial load
duke
parents:
diff changeset
    65
 *  cause any exception to be "caught".  For DA/DU analysis, the finally
06bc494ca11e Initial load
duke
parents:
diff changeset
    66
 *  clause can prevent a transfer of control from propagating DA/DU
06bc494ca11e Initial load
duke
parents:
diff changeset
    67
 *  state to the target.  In addition, code in the finally clause can
06bc494ca11e Initial load
duke
parents:
diff changeset
    68
 *  affect the DA/DU status of variables.
06bc494ca11e Initial load
duke
parents:
diff changeset
    69
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
    70
 *  <p>For try statements, we introduce the idea of a variable being
06bc494ca11e Initial load
duke
parents:
diff changeset
    71
 *  definitely unassigned "everywhere" in a block.  A variable V is
06bc494ca11e Initial load
duke
parents:
diff changeset
    72
 *  "unassigned everywhere" in a block iff it is unassigned at the
06bc494ca11e Initial load
duke
parents:
diff changeset
    73
 *  beginning of the block and there is no reachable assignment to V
06bc494ca11e Initial load
duke
parents:
diff changeset
    74
 *  in the block.  An assignment V=e is reachable iff V is not DA
06bc494ca11e Initial load
duke
parents:
diff changeset
    75
 *  after e.  Then we can say that V is DU at the beginning of the
06bc494ca11e Initial load
duke
parents:
diff changeset
    76
 *  catch block iff V is DU everywhere in the try block.  Similarly, V
06bc494ca11e Initial load
duke
parents:
diff changeset
    77
 *  is DU at the beginning of the finally block iff V is DU everywhere
06bc494ca11e Initial load
duke
parents:
diff changeset
    78
 *  in the try block and in every catch block.  Specifically, the
06bc494ca11e Initial load
duke
parents:
diff changeset
    79
 *  following bullet is added to 16.2.2
06bc494ca11e Initial load
duke
parents:
diff changeset
    80
 *  <pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    81
 *      V is <em>unassigned everywhere</em> in a block if it is
06bc494ca11e Initial load
duke
parents:
diff changeset
    82
 *      unassigned before the block and there is no reachable
06bc494ca11e Initial load
duke
parents:
diff changeset
    83
 *      assignment to V within the block.
06bc494ca11e Initial load
duke
parents:
diff changeset
    84
 *  </pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    85
 *  <p>In 16.2.15, the third bullet (and all of its sub-bullets) for all
06bc494ca11e Initial load
duke
parents:
diff changeset
    86
 *  try blocks is changed to
06bc494ca11e Initial load
duke
parents:
diff changeset
    87
 *  <pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    88
 *      V is definitely unassigned before a catch block iff V is
06bc494ca11e Initial load
duke
parents:
diff changeset
    89
 *      definitely unassigned everywhere in the try block.
06bc494ca11e Initial load
duke
parents:
diff changeset
    90
 *  </pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    91
 *  <p>The last bullet (and all of its sub-bullets) for try blocks that
06bc494ca11e Initial load
duke
parents:
diff changeset
    92
 *  have a finally block is changed to
06bc494ca11e Initial load
duke
parents:
diff changeset
    93
 *  <pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    94
 *      V is definitely unassigned before the finally block iff
06bc494ca11e Initial load
duke
parents:
diff changeset
    95
 *      V is definitely unassigned everywhere in the try block
06bc494ca11e Initial load
duke
parents:
diff changeset
    96
 *      and everywhere in each catch block of the try statement.
06bc494ca11e Initial load
duke
parents:
diff changeset
    97
 *  </pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
    98
 *  <p>In addition,
06bc494ca11e Initial load
duke
parents:
diff changeset
    99
 *  <pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
   100
 *      V is definitely assigned at the end of a constructor iff
06bc494ca11e Initial load
duke
parents:
diff changeset
   101
 *      V is definitely assigned after the block that is the body
06bc494ca11e Initial load
duke
parents:
diff changeset
   102
 *      of the constructor and V is definitely assigned at every
06bc494ca11e Initial load
duke
parents:
diff changeset
   103
 *      return that can return from the constructor.
06bc494ca11e Initial load
duke
parents:
diff changeset
   104
 *  </pre>
06bc494ca11e Initial load
duke
parents:
diff changeset
   105
 *  <p>In addition, each continue statement with the loop as its target
06bc494ca11e Initial load
duke
parents:
diff changeset
   106
 *  is treated as a jump to the end of the loop body, and "intervening"
06bc494ca11e Initial load
duke
parents:
diff changeset
   107
 *  finally clauses are treated as follows: V is DA "due to the
06bc494ca11e Initial load
duke
parents:
diff changeset
   108
 *  continue" iff V is DA before the continue statement or V is DA at
06bc494ca11e Initial load
duke
parents:
diff changeset
   109
 *  the end of any intervening finally block.  V is DU "due to the
06bc494ca11e Initial load
duke
parents:
diff changeset
   110
 *  continue" iff any intervening finally cannot complete normally or V
06bc494ca11e Initial load
duke
parents:
diff changeset
   111
 *  is DU at the end of every intervening finally block.  This "due to
06bc494ca11e Initial load
duke
parents:
diff changeset
   112
 *  the continue" concept is then used in the spec for the loops.
06bc494ca11e Initial load
duke
parents:
diff changeset
   113
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   114
 *  <p>Similarly, break statements must consider intervening finally
06bc494ca11e Initial load
duke
parents:
diff changeset
   115
 *  blocks.  For liveness analysis, a break statement for which any
06bc494ca11e Initial load
duke
parents:
diff changeset
   116
 *  intervening finally cannot complete normally is not considered to
06bc494ca11e Initial load
duke
parents:
diff changeset
   117
 *  cause the target statement to be able to complete normally. Then
06bc494ca11e Initial load
duke
parents:
diff changeset
   118
 *  we say V is DA "due to the break" iff V is DA before the break or
06bc494ca11e Initial load
duke
parents:
diff changeset
   119
 *  V is DA at the end of any intervening finally block.  V is DU "due
06bc494ca11e Initial load
duke
parents:
diff changeset
   120
 *  to the break" iff any intervening finally cannot complete normally
06bc494ca11e Initial load
duke
parents:
diff changeset
   121
 *  or V is DU at the break and at the end of every intervening
06bc494ca11e Initial load
duke
parents:
diff changeset
   122
 *  finally block.  (I suspect this latter condition can be
06bc494ca11e Initial load
duke
parents:
diff changeset
   123
 *  simplified.)  This "due to the break" is then used in the spec for
06bc494ca11e Initial load
duke
parents:
diff changeset
   124
 *  all statements that can be "broken".
06bc494ca11e Initial load
duke
parents:
diff changeset
   125
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   126
 *  <p>The return statement is treated similarly.  V is DA "due to a
06bc494ca11e Initial load
duke
parents:
diff changeset
   127
 *  return statement" iff V is DA before the return statement or V is
06bc494ca11e Initial load
duke
parents:
diff changeset
   128
 *  DA at the end of any intervening finally block.  Note that we
06bc494ca11e Initial load
duke
parents:
diff changeset
   129
 *  don't have to worry about the return expression because this
06bc494ca11e Initial load
duke
parents:
diff changeset
   130
 *  concept is only used for construcrors.
06bc494ca11e Initial load
duke
parents:
diff changeset
   131
 *
9303
eae35c201e19 7032975: API files in javax.annotation.processing need to be updated for references to JLS
jjh
parents: 9300
diff changeset
   132
 *  <p>There is no spec in the JLS for when a variable is definitely
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   133
 *  assigned at the end of a constructor, which is needed for final
06bc494ca11e Initial load
duke
parents:
diff changeset
   134
 *  fields (8.3.1.2).  We implement the rule that V is DA at the end
06bc494ca11e Initial load
duke
parents:
diff changeset
   135
 *  of the constructor iff it is DA and the end of the body of the
06bc494ca11e Initial load
duke
parents:
diff changeset
   136
 *  constructor and V is DA "due to" every return of the constructor.
06bc494ca11e Initial load
duke
parents:
diff changeset
   137
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   138
 *  <p>Intervening finally blocks similarly affect exception analysis.  An
06bc494ca11e Initial load
duke
parents:
diff changeset
   139
 *  intervening finally that cannot complete normally allows us to ignore
06bc494ca11e Initial load
duke
parents:
diff changeset
   140
 *  an otherwise uncaught exception.
06bc494ca11e Initial load
duke
parents:
diff changeset
   141
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   142
 *  <p>To implement the semantics of intervening finally clauses, all
06bc494ca11e Initial load
duke
parents:
diff changeset
   143
 *  nonlocal transfers (break, continue, return, throw, method call that
06bc494ca11e Initial load
duke
parents:
diff changeset
   144
 *  can throw a checked exception, and a constructor invocation that can
06bc494ca11e Initial load
duke
parents:
diff changeset
   145
 *  thrown a checked exception) are recorded in a queue, and removed
06bc494ca11e Initial load
duke
parents:
diff changeset
   146
 *  from the queue when we complete processing the target of the
06bc494ca11e Initial load
duke
parents:
diff changeset
   147
 *  nonlocal transfer.  This allows us to modify the queue in accordance
06bc494ca11e Initial load
duke
parents:
diff changeset
   148
 *  with the above rules when we encounter a finally clause.  The only
06bc494ca11e Initial load
duke
parents:
diff changeset
   149
 *  exception to this [no pun intended] is that checked exceptions that
06bc494ca11e Initial load
duke
parents:
diff changeset
   150
 *  are known to be caught or declared to be caught in the enclosing
06bc494ca11e Initial load
duke
parents:
diff changeset
   151
 *  method are not recorded in the queue, but instead are recorded in a
14259
fb94a1df0d53 8000208: fix langtools javadoc comment issues
jjg
parents: 14058
diff changeset
   152
 *  global variable "{@code Set<Type> thrown}" that records the type of all
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   153
 *  exceptions that can be thrown.
06bc494ca11e Initial load
duke
parents:
diff changeset
   154
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   155
 *  <p>Other minor issues the treatment of members of other classes
06bc494ca11e Initial load
duke
parents:
diff changeset
   156
 *  (always considered DA except that within an anonymous class
06bc494ca11e Initial load
duke
parents:
diff changeset
   157
 *  constructor, where DA status from the enclosing scope is
06bc494ca11e Initial load
duke
parents:
diff changeset
   158
 *  preserved), treatment of the case expression (V is DA before the
06bc494ca11e Initial load
duke
parents:
diff changeset
   159
 *  case expression iff V is DA after the switch expression),
06bc494ca11e Initial load
duke
parents:
diff changeset
   160
 *  treatment of variables declared in a switch block (the implied
06bc494ca11e Initial load
duke
parents:
diff changeset
   161
 *  DA/DU status after the switch expression is DU and not DA for
06bc494ca11e Initial load
duke
parents:
diff changeset
   162
 *  variables defined in a switch block), the treatment of boolean ?:
06bc494ca11e Initial load
duke
parents:
diff changeset
   163
 *  expressions (The JLS rules only handle b and c non-boolean; the
06bc494ca11e Initial load
duke
parents:
diff changeset
   164
 *  new rule is that if b and c are boolean valued, then V is
06bc494ca11e Initial load
duke
parents:
diff changeset
   165
 *  (un)assigned after a?b:c when true/false iff V is (un)assigned
06bc494ca11e Initial load
duke
parents:
diff changeset
   166
 *  after b when true/false and V is (un)assigned after c when
06bc494ca11e Initial load
duke
parents:
diff changeset
   167
 *  true/false).
06bc494ca11e Initial load
duke
parents:
diff changeset
   168
 *
06bc494ca11e Initial load
duke
parents:
diff changeset
   169
 *  <p>There is the remaining question of what syntactic forms constitute a
06bc494ca11e Initial load
duke
parents:
diff changeset
   170
 *  reference to a variable.  It is conventional to allow this.x on the
06bc494ca11e Initial load
duke
parents:
diff changeset
   171
 *  left-hand-side to initialize a final instance field named x, yet
06bc494ca11e Initial load
duke
parents:
diff changeset
   172
 *  this.x isn't considered a "use" when appearing on a right-hand-side
06bc494ca11e Initial load
duke
parents:
diff changeset
   173
 *  in most implementations.  Should parentheses affect what is
06bc494ca11e Initial load
duke
parents:
diff changeset
   174
 *  considered a variable reference?  The simplest rule would be to
06bc494ca11e Initial load
duke
parents:
diff changeset
   175
 *  allow unqualified forms only, parentheses optional, and phase out
06bc494ca11e Initial load
duke
parents:
diff changeset
   176
 *  support for assigning to a final field via this.x.
06bc494ca11e Initial load
duke
parents:
diff changeset
   177
 *
5847
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5520
diff changeset
   178
 *  <p><b>This is NOT part of any supported API.
1908176fd6e3 6944312: Potential rebranding issues in openjdk/langtools repository sources
jjg
parents: 5520
diff changeset
   179
 *  If you write code that depends on this, you do so at your own risk.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   180
 *  This code and its internal interfaces are subject to change or
06bc494ca11e Initial load
duke
parents:
diff changeset
   181
 *  deletion without notice.</b>
06bc494ca11e Initial load
duke
parents:
diff changeset
   182
 */
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   183
public class Flow {
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   184
    protected static final Context.Key<Flow> flowKey = new Context.Key<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   185
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 10
diff changeset
   186
    private final Names names;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   187
    private final Log log;
06bc494ca11e Initial load
duke
parents:
diff changeset
   188
    private final Symtab syms;
06bc494ca11e Initial load
duke
parents:
diff changeset
   189
    private final Types types;
06bc494ca11e Initial load
duke
parents:
diff changeset
   190
    private final Check chk;
06bc494ca11e Initial load
duke
parents:
diff changeset
   191
    private       TreeMaker make;
6156
e15c221efaac 6970833: Try-with-resource implementation throws an NPE during Flow analysis
mcimadamore
parents: 6151
diff changeset
   192
    private final Resolve rs;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   193
    private final JCDiagnostic.Factory diags;
6156
e15c221efaac 6970833: Try-with-resource implementation throws an NPE during Flow analysis
mcimadamore
parents: 6151
diff changeset
   194
    private Env<AttrContext> attrEnv;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   195
    private       Lint lint;
8849
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
   196
    private final boolean allowImprovedRethrowAnalysis;
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
   197
    private final boolean allowImprovedCatchAnalysis;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   198
    private final boolean allowEffectivelyFinalInInnerClasses;
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
   199
    private final boolean enforceThisDotInit;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   200
06bc494ca11e Initial load
duke
parents:
diff changeset
   201
    public static Flow instance(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   202
        Flow instance = context.get(flowKey);
06bc494ca11e Initial load
duke
parents:
diff changeset
   203
        if (instance == null)
06bc494ca11e Initial load
duke
parents:
diff changeset
   204
            instance = new Flow(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   205
        return instance;
06bc494ca11e Initial load
duke
parents:
diff changeset
   206
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   207
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   208
    public void analyzeTree(Env<AttrContext> env, TreeMaker make) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   209
        new AliveAnalyzer().analyzeTree(env, make);
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
   210
        new AssignAnalyzer(log, syms, lint, names, enforceThisDotInit).analyzeTree(env);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   211
        new FlowAnalyzer().analyzeTree(env, make);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   212
        new CaptureAnalyzer().analyzeTree(env, make);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   213
    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   214
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   215
    public void analyzeLambda(Env<AttrContext> env, JCLambda that, TreeMaker make, boolean speculative) {
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14359
diff changeset
   216
        Log.DiagnosticHandler diagHandler = null;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   217
        //we need to disable diagnostics temporarily; the problem is that if
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   218
        //a lambda expression contains e.g. an unreachable statement, an error
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   219
        //message will be reported and will cause compilation to skip the flow analyis
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   220
        //step - if we suppress diagnostics, we won't stop at Attr for flow-analysis
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   221
        //related errors, which will allow for more errors to be detected
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   222
        if (!speculative) {
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14359
diff changeset
   223
            diagHandler = new Log.DiscardDiagnosticHandler(log);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   224
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   225
        try {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   226
            new AliveAnalyzer().analyzeTree(env, that, make);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   227
        } finally {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   228
            if (!speculative) {
14538
384681be798f 8003299: Cleanup javac Log support for deferred diagnostics
jjg
parents: 14359
diff changeset
   229
                log.popDiagnosticHandler(diagHandler);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   230
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   231
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   232
    }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   233
24610
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   234
    public List<Type> analyzeLambdaThrownTypes(final Env<AttrContext> env,
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   235
            JCLambda that, TreeMaker make) {
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   236
        //we need to disable diagnostics temporarily; the problem is that if
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   237
        //a lambda expression contains e.g. an unreachable statement, an error
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   238
        //message will be reported and will cause compilation to skip the flow analyis
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   239
        //step - if we suppress diagnostics, we won't stop at Attr for flow-analysis
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   240
        //related errors, which will allow for more errors to be detected
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   241
        Log.DiagnosticHandler diagHandler = new Log.DiscardDiagnosticHandler(log);
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   242
        try {
24610
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   243
            new AssignAnalyzer(log, syms, lint, names, enforceThisDotInit) {
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   244
                @Override
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   245
                protected boolean trackable(VarSymbol sym) {
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   246
                    return !env.info.scope.includes(sym) &&
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   247
                           sym.owner.kind == MTH;
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   248
                }
8b3b718970a9 8042741: Java 8 compiler throws NullPointerException depending location in source file
pgovereau
parents: 24218
diff changeset
   249
            }.analyzeTree(env);
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   250
            LambdaFlowAnalyzer flowAnalyzer = new LambdaFlowAnalyzer();
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   251
            flowAnalyzer.analyzeTree(env, that, make);
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   252
            return flowAnalyzer.inferredThrownTypes;
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   253
        } finally {
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   254
            log.popDiagnosticHandler(diagHandler);
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   255
        }
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   256
    }
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
   257
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   258
    /**
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   259
     * Definite assignment scan mode
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   260
     */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   261
    enum FlowKind {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   262
        /**
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   263
         * This is the normal DA/DU analysis mode
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   264
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   265
        NORMAL("var.might.already.be.assigned", false),
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   266
        /**
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   267
         * This is the speculative DA/DU analysis mode used to speculatively
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   268
         * derive assertions within loop bodies
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   269
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   270
        SPECULATIVE_LOOP("var.might.be.assigned.in.loop", true);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   271
14801
d66cab4ef397 8003967: detect and remove all mutable implicit static enum fields in langtools
vromero
parents: 14547
diff changeset
   272
        final String errKey;
d66cab4ef397 8003967: detect and remove all mutable implicit static enum fields in langtools
vromero
parents: 14547
diff changeset
   273
        final boolean isFinal;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   274
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   275
        FlowKind(String errKey, boolean isFinal) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   276
            this.errKey = errKey;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   277
            this.isFinal = isFinal;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   278
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   279
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   280
        boolean isFinal() {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   281
            return isFinal;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   282
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   283
    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   284
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   285
    protected Flow(Context context) {
06bc494ca11e Initial load
duke
parents:
diff changeset
   286
        context.put(flowKey, this);
1260
a772ba9ba43d 6574134: Allow for alternative implementation of Name Table with garbage collection of name bytes
jjg
parents: 10
diff changeset
   287
        names = Names.instance(context);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   288
        log = Log.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   289
        syms = Symtab.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   290
        types = Types.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   291
        chk = Check.instance(context);
06bc494ca11e Initial load
duke
parents:
diff changeset
   292
        lint = Lint.instance(context);
6156
e15c221efaac 6970833: Try-with-resource implementation throws an NPE during Flow analysis
mcimadamore
parents: 6151
diff changeset
   293
        rs = Resolve.instance(context);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   294
        diags = JCDiagnostic.Factory.instance(context);
5492
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 3149
diff changeset
   295
        Source source = Source.instance(context);
8849
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
   296
        allowImprovedRethrowAnalysis = source.allowImprovedRethrowAnalysis();
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
   297
        allowImprovedCatchAnalysis = source.allowImprovedCatchAnalysis();
14547
86d8d242b0c4 8003280: Add lambda tests
mcimadamore
parents: 14538
diff changeset
   298
        allowEffectivelyFinalInInnerClasses = source.allowEffectivelyFinalInInnerClasses();
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
   299
        enforceThisDotInit = source.enforceThisDotInit();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   300
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   301
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   302
    /**
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   303
     * Base visitor class for all visitors implementing dataflow analysis logic.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   304
     * This class define the shared logic for handling jumps (break/continue statements).
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   305
     */
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   306
    static abstract class BaseAnalyzer<P extends BaseAnalyzer.PendingExit> extends TreeScanner {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   307
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   308
        enum JumpKind {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   309
            BREAK(JCTree.Tag.BREAK) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   310
                @Override
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   311
                JCTree getTarget(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   312
                    return ((JCBreak)tree).target;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   313
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   314
            },
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   315
            CONTINUE(JCTree.Tag.CONTINUE) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   316
                @Override
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   317
                JCTree getTarget(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   318
                    return ((JCContinue)tree).target;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   319
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   320
            };
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   321
14801
d66cab4ef397 8003967: detect and remove all mutable implicit static enum fields in langtools
vromero
parents: 14547
diff changeset
   322
            final JCTree.Tag treeTag;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   323
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   324
            private JumpKind(Tag treeTag) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   325
                this.treeTag = treeTag;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   326
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   327
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   328
            abstract JCTree getTarget(JCTree tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   329
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   330
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   331
        /** The currently pending exits that go from current inner blocks
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   332
         *  to an enclosing block, in source order.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   333
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   334
        ListBuffer<P> pendingExits;
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5847
diff changeset
   335
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   336
        /** A pending exit.  These are the statements return, break, and
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   337
         *  continue.  In addition, exception-throwing expressions or
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   338
         *  statements are put here when not known to be caught.  This
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   339
         *  will typically result in an error unless it is within a
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   340
         *  try-finally whose finally block cannot complete normally.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   341
         */
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   342
        static class PendingExit {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   343
            JCTree tree;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   344
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   345
            PendingExit(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   346
                this.tree = tree;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   347
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   348
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   349
            void resolveJump(JCTree tree) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   350
                //do nothing
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   351
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   352
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   353
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   354
        abstract void markDead(JCTree tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   355
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   356
        /** Record an outward transfer of control. */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   357
        void recordExit(JCTree tree, P pe) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   358
            pendingExits.append(pe);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   359
            markDead(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   360
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   361
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   362
        /** Resolve all jumps of this statement. */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   363
        private boolean resolveJump(JCTree tree,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   364
                        ListBuffer<P> oldPendingExits,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   365
                        JumpKind jk) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   366
            boolean resolved = false;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   367
            List<P> exits = pendingExits.toList();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   368
            pendingExits = oldPendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   369
            for (; exits.nonEmpty(); exits = exits.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   370
                P exit = exits.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   371
                if (exit.tree.hasTag(jk.treeTag) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   372
                        jk.getTarget(exit.tree) == tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   373
                    exit.resolveJump(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   374
                    resolved = true;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   375
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   376
                    pendingExits.append(exit);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   377
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   378
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   379
            return resolved;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   380
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   381
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   382
        /** Resolve all continues of this statement. */
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   383
        boolean resolveContinues(JCTree tree) {
22165
ec53c8946fc2 8030807: langtools should still build using jdk 7
vromero
parents: 22163
diff changeset
   384
            return resolveJump(tree, new ListBuffer<P>(), JumpKind.CONTINUE);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   385
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   386
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   387
        /** Resolve all breaks of this statement. */
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   388
        boolean resolveBreaks(JCTree tree, ListBuffer<P> oldPendingExits) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   389
            return resolveJump(tree, oldPendingExits, JumpKind.BREAK);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   390
        }
18912
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   391
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   392
        @Override
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   393
        public void scan(JCTree tree) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   394
            if (tree != null && (
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   395
                    tree.type == null ||
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   396
                    tree.type != Type.stuckType)) {
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   397
                super.scan(tree);
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   398
            }
e25cd61d8e59 8020147: Spurious errors when compiling nested stuck lambdas
mcimadamore
parents: 18672
diff changeset
   399
        }
24069
dfb8f11542fc 8034245: Refactor TopLevel tree node.
pgovereau
parents: 24066
diff changeset
   400
dfb8f11542fc 8034245: Refactor TopLevel tree node.
pgovereau
parents: 24066
diff changeset
   401
        public void visitPackageDef(JCPackageDecl tree) {
dfb8f11542fc 8034245: Refactor TopLevel tree node.
pgovereau
parents: 24066
diff changeset
   402
            // Do nothing for PackageDecl
dfb8f11542fc 8034245: Refactor TopLevel tree node.
pgovereau
parents: 24066
diff changeset
   403
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   404
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
   405
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   406
    /**
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   407
     * This pass implements the first step of the dataflow analysis, namely
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   408
     * the liveness analysis check. This checks that every statement is reachable.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   409
     * The output of this analysis pass are used by other analyzers. This analyzer
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   410
     * sets the 'finallyCanCompleteNormally' field in the JCTry class.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   411
     */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   412
    class AliveAnalyzer extends BaseAnalyzer<BaseAnalyzer.PendingExit> {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   413
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   414
        /** A flag that indicates whether the last statement could
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   415
         *  complete normally.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   416
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   417
        private boolean alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   418
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   419
        @Override
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   420
        void markDead(JCTree tree) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   421
            alive = false;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   422
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   423
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   424
    /*************************************************************************
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   425
     * Visitor methods for statements and definitions
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   426
     *************************************************************************/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   427
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   428
        /** Analyze a definition.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   429
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   430
        void scanDef(JCTree tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   431
            scanStat(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   432
            if (tree != null && tree.hasTag(JCTree.Tag.BLOCK) && !alive) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   433
                log.error(tree.pos(),
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   434
                          "initializer.must.be.able.to.complete.normally");
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   435
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   436
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   437
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   438
        /** Analyze a statement. Check that statement is reachable.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   439
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   440
        void scanStat(JCTree tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   441
            if (!alive && tree != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   442
                log.error(tree.pos(), "unreachable.stmt");
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   443
                if (!tree.hasTag(SKIP)) alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   444
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   445
            scan(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   446
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   447
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   448
        /** Analyze list of statements.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   449
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   450
        void scanStats(List<? extends JCStatement> trees) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   451
            if (trees != null)
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   452
                for (List<? extends JCStatement> l = trees; l.nonEmpty(); l = l.tail)
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   453
                    scanStat(l.head);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   454
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   455
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   456
        /* ------------ Visitor methods for various sorts of trees -------------*/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   457
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   458
        public void visitClassDef(JCClassDecl tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   459
            if (tree.sym == null) return;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   460
            boolean alivePrev = alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   461
            ListBuffer<PendingExit> pendingExitsPrev = pendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   462
            Lint lintPrev = lint;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   463
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   464
            pendingExits = new ListBuffer<>();
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   465
            lint = lint.augment(tree.sym);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   466
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   467
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   468
                // process all the static initializers
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   469
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   470
                    if (!l.head.hasTag(METHODDEF) &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   471
                        (TreeInfo.flags(l.head) & STATIC) != 0) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   472
                        scanDef(l.head);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   473
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   474
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   475
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   476
                // process all the instance initializers
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   477
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   478
                    if (!l.head.hasTag(METHODDEF) &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   479
                        (TreeInfo.flags(l.head) & STATIC) == 0) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   480
                        scanDef(l.head);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   481
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   482
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   483
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   484
                // process all the methods
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   485
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   486
                    if (l.head.hasTag(METHODDEF)) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   487
                        scan(l.head);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   488
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   489
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   490
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   491
                pendingExits = pendingExitsPrev;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   492
                alive = alivePrev;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   493
                lint = lintPrev;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   494
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   495
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   496
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   497
        public void visitMethodDef(JCMethodDecl tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   498
            if (tree.body == null) return;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   499
            Lint lintPrev = lint;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   500
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   501
            lint = lint.augment(tree.sym);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   502
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   503
            Assert.check(pendingExits.isEmpty());
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   504
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   505
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   506
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   507
                scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   508
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14259
diff changeset
   509
                if (alive && !tree.sym.type.getReturnType().hasTag(VOID))
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   510
                    log.error(TreeInfo.diagEndPos(tree.body), "missing.ret.stmt");
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   511
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   512
                List<PendingExit> exits = pendingExits.toList();
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   513
                pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   514
                while (exits.nonEmpty()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   515
                    PendingExit exit = exits.head;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   516
                    exits = exits.tail;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   517
                    Assert.check(exit.tree.hasTag(RETURN));
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   518
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   519
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   520
                lint = lintPrev;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   521
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   522
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   523
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   524
        public void visitVarDef(JCVariableDecl tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   525
            if (tree.init != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   526
                Lint lintPrev = lint;
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   527
                lint = lint.augment(tree.sym);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   528
                try{
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   529
                    scan(tree.init);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   530
                } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   531
                    lint = lintPrev;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   532
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   533
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   534
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   535
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   536
        public void visitBlock(JCBlock tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   537
            scanStats(tree.stats);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   538
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   539
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   540
        public void visitDoLoop(JCDoWhileLoop tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   541
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   542
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   543
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   544
            alive |= resolveContinues(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   545
            scan(tree.cond);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   546
            alive = alive && !tree.cond.type.isTrue();
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   547
            alive |= resolveBreaks(tree, prevPendingExits);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   548
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   549
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   550
        public void visitWhileLoop(JCWhileLoop tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   551
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   552
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   553
            scan(tree.cond);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   554
            alive = !tree.cond.type.isFalse();
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   555
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   556
            alive |= resolveContinues(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   557
            alive = resolveBreaks(tree, prevPendingExits) ||
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   558
                !tree.cond.type.isTrue();
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   559
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   560
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   561
        public void visitForLoop(JCForLoop tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   562
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   563
            scanStats(tree.init);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   564
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   565
            if (tree.cond != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   566
                scan(tree.cond);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   567
                alive = !tree.cond.type.isFalse();
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   568
            } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   569
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   570
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   571
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   572
            alive |= resolveContinues(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   573
            scan(tree.step);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   574
            alive = resolveBreaks(tree, prevPendingExits) ||
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   575
                tree.cond != null && !tree.cond.type.isTrue();
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   576
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   577
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   578
        public void visitForeachLoop(JCEnhancedForLoop tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   579
            visitVarDef(tree.var);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   580
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   581
            scan(tree.expr);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   582
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   583
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   584
            alive |= resolveContinues(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   585
            resolveBreaks(tree, prevPendingExits);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   586
            alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   587
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   588
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   589
        public void visitLabelled(JCLabeledStatement tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   590
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   591
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   592
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   593
            alive |= resolveBreaks(tree, prevPendingExits);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   594
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   595
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   596
        public void visitSwitch(JCSwitch tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   597
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   598
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   599
            scan(tree.selector);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   600
            boolean hasDefault = false;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   601
            for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   602
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   603
                JCCase c = l.head;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   604
                if (c.pat == null)
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   605
                    hasDefault = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   606
                else
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   607
                    scan(c.pat);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   608
                scanStats(c.stats);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   609
                // Warn about fall-through if lint switch fallthrough enabled.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   610
                if (alive &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   611
                    lint.isEnabled(Lint.LintCategory.FALLTHROUGH) &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   612
                    c.stats.nonEmpty() && l.tail.nonEmpty())
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   613
                    log.warning(Lint.LintCategory.FALLTHROUGH,
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   614
                                l.tail.head.pos(),
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   615
                                "possible.fall-through.into.case");
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   616
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   617
            if (!hasDefault) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   618
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   619
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   620
            alive |= resolveBreaks(tree, prevPendingExits);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   621
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   622
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   623
        public void visitTry(JCTry tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   624
            ListBuffer<PendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   625
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   626
            for (JCTree resource : tree.resources) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   627
                if (resource instanceof JCVariableDecl) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   628
                    JCVariableDecl vdecl = (JCVariableDecl) resource;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   629
                    visitVarDef(vdecl);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   630
                } else if (resource instanceof JCExpression) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   631
                    scan((JCExpression) resource);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   632
                } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   633
                    throw new AssertionError(tree);  // parser error
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   634
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   635
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   636
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   637
            scanStat(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   638
            boolean aliveEnd = alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   639
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   640
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   641
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   642
                JCVariableDecl param = l.head.param;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   643
                scan(param);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   644
                scanStat(l.head.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   645
                aliveEnd |= alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   646
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   647
            if (tree.finalizer != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   648
                ListBuffer<PendingExit> exits = pendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   649
                pendingExits = prevPendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   650
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   651
                scanStat(tree.finalizer);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   652
                tree.finallyCanCompleteNormally = alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   653
                if (!alive) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   654
                    if (lint.isEnabled(Lint.LintCategory.FINALLY)) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   655
                        log.warning(Lint.LintCategory.FINALLY,
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   656
                                TreeInfo.diagEndPos(tree.finalizer),
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   657
                                "finally.cannot.complete");
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   658
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   659
                } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   660
                    while (exits.nonEmpty()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   661
                        pendingExits.append(exits.next());
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   662
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   663
                    alive = aliveEnd;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   664
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   665
            } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   666
                alive = aliveEnd;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   667
                ListBuffer<PendingExit> exits = pendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   668
                pendingExits = prevPendingExits;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   669
                while (exits.nonEmpty()) pendingExits.append(exits.next());
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   670
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   671
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   672
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   673
        @Override
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   674
        public void visitIf(JCIf tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   675
            scan(tree.cond);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   676
            scanStat(tree.thenpart);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   677
            if (tree.elsepart != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   678
                boolean aliveAfterThen = alive;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   679
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   680
                scanStat(tree.elsepart);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   681
                alive = alive | aliveAfterThen;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   682
            } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   683
                alive = true;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   684
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   685
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   686
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   687
        public void visitBreak(JCBreak tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   688
            recordExit(tree, new PendingExit(tree));
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   689
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   690
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   691
        public void visitContinue(JCContinue tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   692
            recordExit(tree, new PendingExit(tree));
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   693
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   694
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   695
        public void visitReturn(JCReturn tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   696
            scan(tree.expr);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   697
            recordExit(tree, new PendingExit(tree));
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   698
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   699
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   700
        public void visitThrow(JCThrow tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   701
            scan(tree.expr);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   702
            markDead(tree);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   703
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   704
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   705
        public void visitApply(JCMethodInvocation tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   706
            scan(tree.meth);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   707
            scan(tree.args);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   708
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   709
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   710
        public void visitNewClass(JCNewClass tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   711
            scan(tree.encl);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   712
            scan(tree.args);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   713
            if (tree.def != null) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   714
                scan(tree.def);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   715
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   716
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   717
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   718
        @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   719
        public void visitLambda(JCLambda tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   720
            if (tree.type != null &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   721
                    tree.type.isErroneous()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   722
                return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   723
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   724
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   725
            ListBuffer<PendingExit> prevPending = pendingExits;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   726
            boolean prevAlive = alive;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   727
            try {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19941
diff changeset
   728
                pendingExits = new ListBuffer<>();
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   729
                alive = true;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   730
                scanStat(tree.body);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   731
                tree.canCompleteNormally = alive;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   732
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   733
            finally {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   734
                pendingExits = prevPending;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   735
                alive = prevAlive;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   736
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   737
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   738
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   739
    /**************************************************************************
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   740
     * main method
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   741
     *************************************************************************/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   742
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   743
        /** Perform definite assignment/unassignment analysis on a tree.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   744
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   745
        public void analyzeTree(Env<AttrContext> env, TreeMaker make) {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   746
            analyzeTree(env, env.tree, make);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   747
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
   748
        public void analyzeTree(Env<AttrContext> env, JCTree tree, TreeMaker make) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   749
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   750
                attrEnv = env;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   751
                Flow.this.make = make;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   752
                pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   753
                alive = true;
16971
f4a2840bf9ad 8011377: Javac crashes when multiple lambdas are defined in an array
mcimadamore
parents: 15385
diff changeset
   754
                scan(tree);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   755
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   756
                pendingExits = null;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   757
                Flow.this.make = null;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   758
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   759
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   760
    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   761
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   762
    /**
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   763
     * This pass implements the second step of the dataflow analysis, namely
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   764
     * the exception analysis. This is to ensure that every checked exception that is
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   765
     * thrown is declared or caught. The analyzer uses some info that has been set by
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   766
     * the liveliness analyzer.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   767
     */
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   768
    class FlowAnalyzer extends BaseAnalyzer<FlowAnalyzer.FlowPendingExit> {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   769
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   770
        /** A flag that indicates whether the last statement could
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   771
         *  complete normally.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   772
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   773
        HashMap<Symbol, List<Type>> preciseRethrowTypes;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   774
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   775
        /** The current class being defined.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   776
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   777
        JCClassDecl classDef;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   778
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   779
        /** The list of possibly thrown declarable exceptions.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   780
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   781
        List<Type> thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   782
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   783
        /** The list of exceptions that are either caught or declared to be
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   784
         *  thrown.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   785
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   786
        List<Type> caught;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   787
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   788
        class FlowPendingExit extends BaseAnalyzer.PendingExit {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   789
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   790
            Type thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   791
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   792
            FlowPendingExit(JCTree tree, Type thrown) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   793
                super(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   794
                this.thrown = thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   795
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   796
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   797
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   798
        @Override
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
   799
        void markDead(JCTree tree) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   800
            //do nothing
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   801
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   802
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   803
        /*-------------------- Exceptions ----------------------*/
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   804
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   805
        /** Complain that pending exceptions are not caught.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   806
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   807
        void errorUncaught() {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   808
            for (FlowPendingExit exit = pendingExits.next();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   809
                 exit != null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   810
                 exit = pendingExits.next()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   811
                if (classDef != null &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   812
                    classDef.pos == exit.tree.pos) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   813
                    log.error(exit.tree.pos(),
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   814
                            "unreported.exception.default.constructor",
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   815
                            exit.thrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   816
                } else if (exit.tree.hasTag(VARDEF) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   817
                        ((JCVariableDecl)exit.tree).sym.isResourceVariable()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   818
                    log.error(exit.tree.pos(),
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   819
                            "unreported.exception.implicit.close",
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   820
                            exit.thrown,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   821
                            ((JCVariableDecl)exit.tree).sym.name);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   822
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   823
                    log.error(exit.tree.pos(),
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   824
                            "unreported.exception.need.to.catch.or.throw",
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   825
                            exit.thrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   826
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   827
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   828
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   829
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   830
        /** Record that exception is potentially thrown and check that it
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   831
         *  is caught.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   832
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   833
        void markThrown(JCTree tree, Type exc) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   834
            if (!chk.isUnchecked(tree.pos(), exc)) {
17998
02a5abb2ae2f 7179353: try-with-resources fails to compile with generic exception parameters
vromero
parents: 17282
diff changeset
   835
                if (!chk.isHandled(exc, caught)) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   836
                    pendingExits.append(new FlowPendingExit(tree, exc));
17998
02a5abb2ae2f 7179353: try-with-resources fails to compile with generic exception parameters
vromero
parents: 17282
diff changeset
   837
                }
02a5abb2ae2f 7179353: try-with-resources fails to compile with generic exception parameters
vromero
parents: 17282
diff changeset
   838
                thrown = chk.incl(exc, thrown);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   839
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   840
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   841
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   842
    /*************************************************************************
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   843
     * Visitor methods for statements and definitions
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   844
     *************************************************************************/
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   845
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   846
        /* ------------ Visitor methods for various sorts of trees -------------*/
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   847
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   848
        public void visitClassDef(JCClassDecl tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   849
            if (tree.sym == null) return;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   850
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   851
            JCClassDecl classDefPrev = classDef;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   852
            List<Type> thrownPrev = thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   853
            List<Type> caughtPrev = caught;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   854
            ListBuffer<FlowPendingExit> pendingExitsPrev = pendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   855
            Lint lintPrev = lint;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   856
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   857
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   858
            if (tree.name != names.empty) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   859
                caught = List.nil();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   860
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   861
            classDef = tree;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   862
            thrown = List.nil();
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   863
            lint = lint.augment(tree.sym);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   864
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   865
            try {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   866
                // process all the static initializers
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   867
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   868
                    if (!l.head.hasTag(METHODDEF) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   869
                        (TreeInfo.flags(l.head) & STATIC) != 0) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   870
                        scan(l.head);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   871
                        errorUncaught();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   872
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   873
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   874
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   875
                // add intersection of all thrown clauses of initial constructors
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   876
                // to set of caught exceptions, unless class is anonymous.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   877
                if (tree.name != names.empty) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   878
                    boolean firstConstructor = true;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   879
                    for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   880
                        if (TreeInfo.isInitialConstructor(l.head)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   881
                            List<Type> mthrown =
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   882
                                ((JCMethodDecl) l.head).sym.type.getThrownTypes();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   883
                            if (firstConstructor) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   884
                                caught = mthrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   885
                                firstConstructor = false;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   886
                            } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   887
                                caught = chk.intersect(mthrown, caught);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   888
                            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   889
                        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   890
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   891
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   892
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   893
                // process all the instance initializers
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   894
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   895
                    if (!l.head.hasTag(METHODDEF) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   896
                        (TreeInfo.flags(l.head) & STATIC) == 0) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   897
                        scan(l.head);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   898
                        errorUncaught();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   899
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   900
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   901
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   902
                // in an anonymous class, add the set of thrown exceptions to
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   903
                // the throws clause of the synthetic constructor and propagate
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   904
                // outwards.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   905
                // Changing the throws clause on the fly is okay here because
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   906
                // the anonymous constructor can't be invoked anywhere else,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   907
                // and its type hasn't been cached.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   908
                if (tree.name == names.empty) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   909
                    for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   910
                        if (TreeInfo.isInitialConstructor(l.head)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   911
                            JCMethodDecl mdef = (JCMethodDecl)l.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   912
                            mdef.thrown = make.Types(thrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   913
                            mdef.sym.type = types.createMethodTypeWithThrown(mdef.sym.type, thrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   914
                        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   915
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   916
                    thrownPrev = chk.union(thrown, thrownPrev);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   917
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   918
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   919
                // process all the methods
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   920
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   921
                    if (l.head.hasTag(METHODDEF)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   922
                        scan(l.head);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   923
                        errorUncaught();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   924
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   925
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   926
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   927
                thrown = thrownPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   928
            } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   929
                pendingExits = pendingExitsPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   930
                caught = caughtPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   931
                classDef = classDefPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   932
                lint = lintPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   933
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   934
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   935
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   936
        public void visitMethodDef(JCMethodDecl tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   937
            if (tree.body == null) return;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   938
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   939
            List<Type> caughtPrev = caught;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   940
            List<Type> mthrown = tree.sym.type.getThrownTypes();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   941
            Lint lintPrev = lint;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   942
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   943
            lint = lint.augment(tree.sym);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   944
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   945
            Assert.check(pendingExits.isEmpty());
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   946
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   947
            try {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   948
                for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   949
                    JCVariableDecl def = l.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   950
                    scan(def);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   951
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   952
                if (TreeInfo.isInitialConstructor(tree))
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   953
                    caught = chk.union(caught, mthrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   954
                else if ((tree.sym.flags() & (BLOCK | STATIC)) != BLOCK)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   955
                    caught = mthrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   956
                // else we are in an instance initializer block;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   957
                // leave caught unchanged.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   958
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   959
                scan(tree.body);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   960
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   961
                List<FlowPendingExit> exits = pendingExits.toList();
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   962
                pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   963
                while (exits.nonEmpty()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   964
                    FlowPendingExit exit = exits.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   965
                    exits = exits.tail;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   966
                    if (exit.thrown == null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   967
                        Assert.check(exit.tree.hasTag(RETURN));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   968
                    } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   969
                        // uncaught throws will be reported later
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   970
                        pendingExits.append(exit);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   971
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   972
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   973
            } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   974
                caught = caughtPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   975
                lint = lintPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   976
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   977
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   978
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   979
        public void visitVarDef(JCVariableDecl tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   980
            if (tree.init != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   981
                Lint lintPrev = lint;
18010
604faee85350 8004643: Reduce javac space overhead introduced with compiler support for repeating annotations
jjg
parents: 17998
diff changeset
   982
                lint = lint.augment(tree.sym);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   983
                try{
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   984
                    scan(tree.init);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   985
                } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   986
                    lint = lintPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   987
                }
8428
1e9935b883cd 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources
mcimadamore
parents: 8036
diff changeset
   988
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   989
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   990
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   991
        public void visitBlock(JCBlock tree) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   992
            scan(tree.stats);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   993
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
   994
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   995
        public void visitDoLoop(JCDoWhileLoop tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
   996
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
   997
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   998
            scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
   999
            resolveContinues(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1000
            scan(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1001
            resolveBreaks(tree, prevPendingExits);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1002
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1003
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1004
        public void visitWhileLoop(JCWhileLoop tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1005
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1006
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1007
            scan(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1008
            scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1009
            resolveContinues(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1010
            resolveBreaks(tree, prevPendingExits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1011
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1012
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1013
        public void visitForLoop(JCForLoop tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1014
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1015
            scan(tree.init);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1016
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1017
            if (tree.cond != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1018
                scan(tree.cond);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1019
            }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1020
            scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1021
            resolveContinues(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1022
            scan(tree.step);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1023
            resolveBreaks(tree, prevPendingExits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1024
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1025
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1026
        public void visitForeachLoop(JCEnhancedForLoop tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1027
            visitVarDef(tree.var);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1028
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1029
            scan(tree.expr);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1030
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1031
            scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1032
            resolveContinues(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1033
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1034
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1035
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1036
        public void visitLabelled(JCLabeledStatement tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1037
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1038
            pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1039
            scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1040
            resolveBreaks(tree, prevPendingExits);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1041
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1042
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1043
        public void visitSwitch(JCSwitch tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1044
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1045
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1046
            scan(tree.selector);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1047
            for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1048
                JCCase c = l.head;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1049
                if (c.pat != null) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1050
                    scan(c.pat);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1051
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1052
                scan(c.stats);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1053
            }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1054
            resolveBreaks(tree, prevPendingExits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1055
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1056
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1057
        public void visitTry(JCTry tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1058
            List<Type> caughtPrev = caught;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1059
            List<Type> thrownPrev = thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1060
            thrown = List.nil();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1061
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1062
                List<JCExpression> subClauses = TreeInfo.isMultiCatch(l.head) ?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1063
                        ((JCTypeUnion)l.head.param.vartype).alternatives :
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1064
                        List.of(l.head.param.vartype);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1065
                for (JCExpression ct : subClauses) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1066
                    caught = chk.incl(ct.type, caught);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1067
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1068
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1069
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1070
            ListBuffer<FlowPendingExit> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1071
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1072
            for (JCTree resource : tree.resources) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1073
                if (resource instanceof JCVariableDecl) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1074
                    JCVariableDecl vdecl = (JCVariableDecl) resource;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1075
                    visitVarDef(vdecl);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1076
                } else if (resource instanceof JCExpression) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1077
                    scan((JCExpression) resource);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1078
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1079
                    throw new AssertionError(tree);  // parser error
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1080
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1081
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1082
            for (JCTree resource : tree.resources) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1083
                List<Type> closeableSupertypes = resource.type.isCompound() ?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1084
                    types.interfaces(resource.type).prepend(types.supertype(resource.type)) :
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1085
                    List.of(resource.type);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1086
                for (Type sup : closeableSupertypes) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1087
                    if (types.asSuper(sup, syms.autoCloseableType.tsym) != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1088
                        Symbol closeMethod = rs.resolveQualifiedMethod(tree,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1089
                                attrEnv,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1090
                                sup,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1091
                                names.close,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1092
                                List.<Type>nil(),
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1093
                                List.<Type>nil());
17998
02a5abb2ae2f 7179353: try-with-resources fails to compile with generic exception parameters
vromero
parents: 17282
diff changeset
  1094
                        Type mt = types.memberType(resource.type, closeMethod);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1095
                        if (closeMethod.kind == MTH) {
17998
02a5abb2ae2f 7179353: try-with-resources fails to compile with generic exception parameters
vromero
parents: 17282
diff changeset
  1096
                            for (Type t : mt.getThrownTypes()) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1097
                                markThrown(resource, t);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1098
                            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1099
                        }
5492
515e4b33b335 6943289: Project Coin: Improved Exception Handling for Java (aka 'multicatch')
mcimadamore
parents: 3149
diff changeset
  1100
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1101
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1102
            }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1103
            scan(tree.body);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1104
            List<Type> thrownInTry = allowImprovedCatchAnalysis ?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1105
                chk.union(thrown, List.of(syms.runtimeExceptionType, syms.errorType)) :
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1106
                thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1107
            thrown = thrownPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1108
            caught = caughtPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1109
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1110
            List<Type> caughtInTry = List.nil();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1111
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1112
                JCVariableDecl param = l.head.param;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1113
                List<JCExpression> subClauses = TreeInfo.isMultiCatch(l.head) ?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1114
                        ((JCTypeUnion)l.head.param.vartype).alternatives :
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1115
                        List.of(l.head.param.vartype);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1116
                List<Type> ctypes = List.nil();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1117
                List<Type> rethrownTypes = chk.diff(thrownInTry, caughtInTry);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1118
                for (JCExpression ct : subClauses) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1119
                    Type exc = ct.type;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1120
                    if (exc != syms.unknownType) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1121
                        ctypes = ctypes.append(exc);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1122
                        if (types.isSameType(exc, syms.objectType))
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1123
                            continue;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1124
                        checkCaughtType(l.head.pos(), exc, thrownInTry, caughtInTry);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1125
                        caughtInTry = chk.incl(exc, caughtInTry);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1126
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1127
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1128
                scan(param);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1129
                preciseRethrowTypes.put(param.sym, chk.intersect(ctypes, rethrownTypes));
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1130
                scan(l.head.body);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1131
                preciseRethrowTypes.remove(param.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1132
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1133
            if (tree.finalizer != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1134
                List<Type> savedThrown = thrown;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1135
                thrown = List.nil();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1136
                ListBuffer<FlowPendingExit> exits = pendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1137
                pendingExits = prevPendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1138
                scan(tree.finalizer);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1139
                if (!tree.finallyCanCompleteNormally) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1140
                    // discard exits and exceptions from try and finally
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1141
                    thrown = chk.union(thrown, thrownPrev);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1142
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1143
                    thrown = chk.union(thrown, chk.diff(thrownInTry, caughtInTry));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1144
                    thrown = chk.union(thrown, savedThrown);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1145
                    // FIX: this doesn't preserve source order of exits in catch
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1146
                    // versus finally!
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1147
                    while (exits.nonEmpty()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1148
                        pendingExits.append(exits.next());
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1149
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1150
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1151
            } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1152
                thrown = chk.union(thrown, chk.diff(thrownInTry, caughtInTry));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1153
                ListBuffer<FlowPendingExit> exits = pendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1154
                pendingExits = prevPendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1155
                while (exits.nonEmpty()) pendingExits.append(exits.next());
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1156
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1157
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1158
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1159
        @Override
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1160
        public void visitIf(JCIf tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1161
            scan(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1162
            scan(tree.thenpart);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1163
            if (tree.elsepart != null) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1164
                scan(tree.elsepart);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1165
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1166
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1167
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1168
        void checkCaughtType(DiagnosticPosition pos, Type exc, List<Type> thrownInTry, List<Type> caughtInTry) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1169
            if (chk.subset(exc, caughtInTry)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1170
                log.error(pos, "except.already.caught", exc);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1171
            } else if (!chk.isUnchecked(pos, exc) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1172
                    !isExceptionOrThrowable(exc) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1173
                    !chk.intersects(exc, thrownInTry)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1174
                log.error(pos, "except.never.thrown.in.try", exc);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1175
            } else if (allowImprovedCatchAnalysis) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1176
                List<Type> catchableThrownTypes = chk.intersect(List.of(exc), thrownInTry);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1177
                // 'catchableThrownTypes' cannnot possibly be empty - if 'exc' was an
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1178
                // unchecked exception, the result list would not be empty, as the augmented
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1179
                // thrown set includes { RuntimeException, Error }; if 'exc' was a checked
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1180
                // exception, that would have been covered in the branch above
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1181
                if (chk.diff(catchableThrownTypes, caughtInTry).isEmpty() &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1182
                        !isExceptionOrThrowable(exc)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1183
                    String key = catchableThrownTypes.length() == 1 ?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1184
                            "unreachable.catch" :
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1185
                            "unreachable.catch.1";
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1186
                    log.warning(pos, key, catchableThrownTypes);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1187
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1188
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1189
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1190
        //where
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1191
            private boolean isExceptionOrThrowable(Type exc) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1192
                return exc.tsym == syms.throwableType.tsym ||
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1193
                    exc.tsym == syms.exceptionType.tsym;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1194
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1195
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1196
        public void visitBreak(JCBreak tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1197
            recordExit(tree, new FlowPendingExit(tree, null));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1198
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1199
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1200
        public void visitContinue(JCContinue tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1201
            recordExit(tree, new FlowPendingExit(tree, null));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1202
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1203
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1204
        public void visitReturn(JCReturn tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1205
            scan(tree.expr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1206
            recordExit(tree, new FlowPendingExit(tree, null));
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1207
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1208
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1209
        public void visitThrow(JCThrow tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1210
            scan(tree.expr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1211
            Symbol sym = TreeInfo.symbol(tree.expr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1212
            if (sym != null &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1213
                sym.kind == VAR &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1214
                (sym.flags() & (FINAL | EFFECTIVELY_FINAL)) != 0 &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1215
                preciseRethrowTypes.get(sym) != null &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1216
                allowImprovedRethrowAnalysis) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1217
                for (Type t : preciseRethrowTypes.get(sym)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1218
                    markThrown(tree, t);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1219
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1220
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1221
            else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1222
                markThrown(tree, tree.expr.type);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1223
            }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1224
            markDead(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1225
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1226
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1227
        public void visitApply(JCMethodInvocation tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1228
            scan(tree.meth);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1229
            scan(tree.args);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1230
            for (List<Type> l = tree.meth.type.getThrownTypes(); l.nonEmpty(); l = l.tail)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1231
                markThrown(tree, l.head);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1232
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1233
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1234
        public void visitNewClass(JCNewClass tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1235
            scan(tree.encl);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1236
            scan(tree.args);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1237
           // scan(tree.def);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1238
            for (List<Type> l = tree.constructorType.getThrownTypes();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1239
                 l.nonEmpty();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1240
                 l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1241
                markThrown(tree, l.head);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1242
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1243
            List<Type> caughtPrev = caught;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1244
            try {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1245
                // If the new class expression defines an anonymous class,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1246
                // analysis of the anonymous constructor may encounter thrown
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1247
                // types which are unsubstituted type variables.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1248
                // However, since the constructor's actual thrown types have
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1249
                // already been marked as thrown, it is safe to simply include
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1250
                // each of the constructor's formal thrown types in the set of
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1251
                // 'caught/declared to be thrown' types, for the duration of
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1252
                // the class def analysis.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1253
                if (tree.def != null)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1254
                    for (List<Type> l = tree.constructor.type.getThrownTypes();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1255
                         l.nonEmpty();
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1256
                         l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1257
                        caught = chk.incl(l.head, caught);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1258
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1259
                scan(tree.def);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1260
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1261
            finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1262
                caught = caughtPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1263
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1264
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1265
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1266
        @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1267
        public void visitLambda(JCLambda tree) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1268
            if (tree.type != null &&
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1269
                    tree.type.isErroneous()) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1270
                return;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1271
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1272
            List<Type> prevCaught = caught;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1273
            List<Type> prevThrown = thrown;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1274
            ListBuffer<FlowPendingExit> prevPending = pendingExits;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1275
            try {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19941
diff changeset
  1276
                pendingExits = new ListBuffer<>();
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1277
                caught = tree.getDescriptorType(types).getThrownTypes();
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1278
                thrown = List.nil();
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1279
                scan(tree.body);
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1280
                List<FlowPendingExit> exits = pendingExits.toList();
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1281
                pendingExits = new ListBuffer<>();
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1282
                while (exits.nonEmpty()) {
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1283
                    FlowPendingExit exit = exits.head;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1284
                    exits = exits.tail;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1285
                    if (exit.thrown == null) {
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1286
                        Assert.check(exit.tree.hasTag(RETURN));
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1287
                    } else {
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1288
                        // uncaught throws will be reported later
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1289
                        pendingExits.append(exit);
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1290
                    }
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1291
                }
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1292
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1293
                errorUncaught();
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1294
            } finally {
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1295
                pendingExits = prevPending;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1296
                caught = prevCaught;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1297
                thrown = prevThrown;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1298
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1299
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1300
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1301
    /**************************************************************************
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1302
     * main method
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1303
     *************************************************************************/
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1304
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1305
        /** Perform definite assignment/unassignment analysis on a tree.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1306
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1307
        public void analyzeTree(Env<AttrContext> env, TreeMaker make) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1308
            analyzeTree(env, env.tree, make);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1309
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1310
        public void analyzeTree(Env<AttrContext> env, JCTree tree, TreeMaker make) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1311
            try {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1312
                attrEnv = env;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1313
                Flow.this.make = make;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1314
                pendingExits = new ListBuffer<>();
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1315
                preciseRethrowTypes = new HashMap<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1316
                this.thrown = this.caught = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1317
                this.classDef = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1318
                scan(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1319
            } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1320
                pendingExits = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1321
                Flow.this.make = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1322
                this.thrown = this.caught = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1323
                this.classDef = null;
6594
d43f068fba19 6970584: Flow.java should be more error-friendly
mcimadamore
parents: 6156
diff changeset
  1324
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1325
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1326
    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1327
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1328
    /**
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1329
     * Specialized pass that performs inference of thrown types for lambdas.
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1330
     */
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1331
    class LambdaFlowAnalyzer extends FlowAnalyzer {
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1332
        List<Type> inferredThrownTypes;
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1333
        boolean inLambda;
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1334
        @Override
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1335
        public void visitLambda(JCLambda tree) {
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1336
            if ((tree.type != null &&
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1337
                    tree.type.isErroneous()) || inLambda) {
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1338
                return;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1339
            }
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1340
            List<Type> prevCaught = caught;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1341
            List<Type> prevThrown = thrown;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1342
            ListBuffer<FlowPendingExit> prevPending = pendingExits;
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1343
            inLambda = true;
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1344
            try {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19941
diff changeset
  1345
                pendingExits = new ListBuffer<>();
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1346
                caught = List.of(syms.throwableType);
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1347
                thrown = List.nil();
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1348
                scan(tree.body);
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1349
                inferredThrownTypes = thrown;
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1350
            } finally {
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1351
                pendingExits = prevPending;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1352
                caught = prevCaught;
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1353
                thrown = prevThrown;
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1354
                inLambda = false;
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1355
            }
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1356
        }
19933
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1357
        @Override
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1358
        public void visitClassDef(JCClassDecl tree) {
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1359
            //skip
5182bc65845b 8019521: Enhanced rethrow disabled in lambdas
jlahoda
parents: 19502
diff changeset
  1360
        }
19502
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1361
    }
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1362
f30b3ef165ea 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression
jlahoda
parents: 19122
diff changeset
  1363
    /**
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1364
     * This pass implements (i) definite assignment analysis, which ensures that
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1365
     * each variable is assigned when used and (ii) definite unassignment analysis,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1366
     * which ensures that no final variable is assigned more than once. This visitor
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1367
     * depends on the results of the liveliness analyzer. This pass is also used to mark
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1368
     * effectively-final local variables/parameters.
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1369
     */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1370
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1371
    public abstract static class AbstractAssignAnalyzer<P extends AbstractAssignAnalyzer.AbstractAssignPendingExit>
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1372
        extends BaseAnalyzer<P> {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1373
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1374
        /** The set of definitely assigned variables.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1375
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1376
        protected final Bits inits;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1377
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1378
        /** The set of definitely unassigned variables.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1379
         */
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1380
        final Bits uninits;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1381
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1382
        /** The set of variables that are definitely unassigned everywhere
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1383
         *  in current try block. This variable is maintained lazily; it is
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1384
         *  updated only when something gets removed from uninits,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1385
         *  typically by being assigned in reachable code.  To obtain the
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1386
         *  correct set of variables which are definitely unassigned
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1387
         *  anywhere in current try block, intersect uninitsTry and
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1388
         *  uninits.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1389
         */
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1390
        final Bits uninitsTry;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1391
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1392
        /** When analyzing a condition, inits and uninits are null.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1393
         *  Instead we have:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1394
         */
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1395
        final Bits initsWhenTrue;
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1396
        final Bits initsWhenFalse;
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1397
        final Bits uninitsWhenTrue;
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1398
        final Bits uninitsWhenFalse;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1399
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1400
        /** A mapping from addresses to variable symbols.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1401
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1402
        protected JCVariableDecl[] vardecls;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1403
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1404
        /** The current class being defined.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1405
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1406
        JCClassDecl classDef;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1407
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1408
        /** The first variable sequence number in this class definition.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1409
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1410
        int firstadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1411
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1412
        /** The next available variable sequence number.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1413
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1414
        protected int nextadr;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1415
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1416
        /** The first variable sequence number in a block that can return.
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1417
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1418
        protected int returnadr;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1419
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1420
        /** The list of unreferenced automatic resources.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1421
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1422
        Scope unrefdResources;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1423
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1424
        /** Set when processing a loop body the second time for DU analysis. */
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1425
        FlowKind flowKind = FlowKind.NORMAL;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1426
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1427
        /** The starting position of the analysed tree */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1428
        int startPos;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1429
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1430
        final Symtab syms;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1431
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1432
        protected Names names;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1433
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  1434
        final boolean enforceThisDotInit;
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  1435
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1436
        public static class AbstractAssignPendingExit extends BaseAnalyzer.PendingExit {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1437
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1438
            final Bits inits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1439
            final Bits uninits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1440
            final Bits exit_inits = new Bits(true);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1441
            final Bits exit_uninits = new Bits(true);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1442
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1443
            public AbstractAssignPendingExit(JCTree tree, final Bits inits, final Bits uninits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1444
                super(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1445
                this.inits = inits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1446
                this.uninits = uninits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1447
                this.exit_inits.assign(inits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1448
                this.exit_uninits.assign(uninits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1449
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1450
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1451
            @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1452
            public void resolveJump(JCTree tree) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1453
                inits.andSet(exit_inits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1454
                uninits.andSet(exit_uninits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1455
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1456
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1457
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  1458
        public AbstractAssignAnalyzer(Bits inits, Symtab syms, Names names, boolean enforceThisDotInit) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1459
            this.inits = inits;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1460
            uninits = new Bits();
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1461
            uninitsTry = new Bits();
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1462
            initsWhenTrue = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1463
            initsWhenFalse = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1464
            uninitsWhenTrue = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1465
            uninitsWhenFalse = new Bits(true);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1466
            this.syms = syms;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1467
            this.names = names;
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  1468
            this.enforceThisDotInit = enforceThisDotInit;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1469
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1470
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1471
        private boolean isInitialConstructor = false;
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1472
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1473
        @Override
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1474
        protected void markDead(JCTree tree) {
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1475
            if (!isInitialConstructor) {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1476
                inits.inclRange(returnadr, nextadr);
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1477
            } else {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1478
                for (int address = returnadr; address < nextadr; address++) {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1479
                    if (!(isFinalUninitializedStaticField(vardecls[address].sym))) {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1480
                        inits.incl(address);
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1481
                    }
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1482
                }
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1483
            }
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1484
            uninits.inclRange(returnadr, nextadr);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1485
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1486
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1487
        /*-------------- Processing variables ----------------------*/
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1488
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1489
        /** Do we need to track init/uninit state of this symbol?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1490
         *  I.e. is symbol either a local or a blank final variable?
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1491
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1492
        protected boolean trackable(VarSymbol sym) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1493
            return
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1494
                sym.pos >= startPos &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1495
                ((sym.owner.kind == MTH ||
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1496
                isFinalUninitializedField(sym)));
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1497
        }
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1498
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1499
        boolean isFinalUninitializedField(VarSymbol sym) {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1500
            return sym.owner.kind == TYP &&
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1501
                   ((sym.flags() & (FINAL | HASINIT | PARAMETER)) == FINAL &&
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1502
                   classDef.sym.isEnclosedBy((ClassSymbol)sym.owner));
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1503
        }
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1504
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1505
        boolean isFinalUninitializedStaticField(VarSymbol sym) {
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1506
            return isFinalUninitializedField(sym) && sym.isStatic();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1507
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1508
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1509
        /** Initialize new trackable variable by setting its address field
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1510
         *  to the next available sequence number and entering it under that
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1511
         *  index into the vars array.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1512
         */
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1513
        void newVar(JCVariableDecl varDecl) {
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1514
            VarSymbol sym = varDecl.sym;
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1515
            vardecls = ArrayUtils.ensureCapacity(vardecls, nextadr);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1516
            if ((sym.flags() & FINAL) == 0) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1517
                sym.flags_field |= EFFECTIVELY_FINAL;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1518
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1519
            sym.adr = nextadr;
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1520
            vardecls[nextadr] = varDecl;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1521
            exclVarFromInits(varDecl, nextadr);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1522
            uninits.incl(nextadr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1523
            nextadr++;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1524
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1525
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1526
        protected void exclVarFromInits(JCTree tree, int adr) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1527
            inits.excl(adr);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1528
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1529
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1530
        protected void assignToInits(JCTree tree, Bits bits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1531
            inits.assign(bits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1532
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1533
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1534
        protected void andSetInits(JCTree tree, Bits bits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1535
            inits.andSet(bits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1536
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1537
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1538
        protected void orSetInits(JCTree tree, Bits bits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1539
            inits.orSet(bits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1540
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1541
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1542
        /** Record an initialization of a trackable variable.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1543
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1544
        void letInit(DiagnosticPosition pos, VarSymbol sym) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1545
            if (sym.adr >= firstadr && trackable(sym)) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1546
                if (uninits.isMember(sym.adr)) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1547
                    uninit(sym);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1548
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1549
                inits.incl(sym.adr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1550
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1551
        }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1552
        //where
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1553
            void uninit(VarSymbol sym) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1554
                if (!inits.isMember(sym.adr)) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1555
                    // reachable assignment
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1556
                    uninits.excl(sym.adr);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1557
                    uninitsTry.excl(sym.adr);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1558
                } else {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1559
                    //log.rawWarning(pos, "unreachable assignment");//DEBUG
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1560
                    uninits.excl(sym.adr);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1561
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1562
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1563
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1564
        /** If tree is either a simple name or of the form this.name or
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1565
         *  C.this.name, and tree represents a trackable variable,
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1566
         *  record an initialization of the variable.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1567
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1568
        void letInit(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1569
            tree = TreeInfo.skipParens(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1570
            if (tree.hasTag(IDENT) || tree.hasTag(SELECT)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1571
                Symbol sym = TreeInfo.symbol(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1572
                if (sym.kind == VAR) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1573
                    letInit(tree.pos(), (VarSymbol)sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1574
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1575
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1576
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1577
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1578
        /** Check that trackable variable is initialized.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1579
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1580
        void checkInit(DiagnosticPosition pos, VarSymbol sym) {
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1581
            checkInit(pos, sym, "var.might.not.have.been.initialized");
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1582
        }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1583
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1584
        void checkInit(DiagnosticPosition pos, VarSymbol sym, String errkey) {}
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1585
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1586
        /** Utility method to reset several Bits instances.
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1587
         */
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1588
        private void resetBits(Bits... bits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1589
            for (Bits b : bits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1590
                b.reset();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1591
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1592
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1593
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1594
        /** Split (duplicate) inits/uninits into WhenTrue/WhenFalse sets
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1595
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1596
        void split(boolean setToNull) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1597
            initsWhenFalse.assign(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1598
            uninitsWhenFalse.assign(uninits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1599
            initsWhenTrue.assign(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1600
            uninitsWhenTrue.assign(uninits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1601
            if (setToNull) {
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1602
                resetBits(inits, uninits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1603
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1604
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1605
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1606
        /** Merge (intersect) inits/uninits from WhenTrue/WhenFalse sets.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1607
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1608
        protected void merge(JCTree tree) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1609
            inits.assign(initsWhenFalse.andSet(initsWhenTrue));
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1610
            uninits.assign(uninitsWhenFalse.andSet(uninitsWhenTrue));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1611
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1612
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1613
    /* ************************************************************************
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1614
     * Visitor methods for statements and definitions
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1615
     *************************************************************************/
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1616
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1617
        /** Analyze an expression. Make sure to set (un)inits rather than
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1618
         *  (un)initsWhenTrue(WhenFalse) on exit.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1619
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1620
        void scanExpr(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1621
            if (tree != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1622
                scan(tree);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1623
                if (inits.isReset()) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1624
                    merge(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1625
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1626
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1627
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1628
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1629
        /** Analyze a list of expressions.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1630
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1631
        void scanExprs(List<? extends JCExpression> trees) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1632
            if (trees != null)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1633
                for (List<? extends JCExpression> l = trees; l.nonEmpty(); l = l.tail)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1634
                    scanExpr(l.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1635
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1636
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1637
        /** Analyze a condition. Make sure to set (un)initsWhenTrue(WhenFalse)
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1638
         *  rather than (un)inits on exit.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1639
         */
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1640
        void scanCond(JCTree tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1641
            if (tree.type.isFalse()) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1642
                if (inits.isReset()) merge(tree);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1643
                initsWhenTrue.assign(inits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1644
                initsWhenTrue.inclRange(firstadr, nextadr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1645
                uninitsWhenTrue.assign(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1646
                uninitsWhenTrue.inclRange(firstadr, nextadr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1647
                initsWhenFalse.assign(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1648
                uninitsWhenFalse.assign(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1649
            } else if (tree.type.isTrue()) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1650
                if (inits.isReset()) merge(tree);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1651
                initsWhenFalse.assign(inits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1652
                initsWhenFalse.inclRange(firstadr, nextadr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1653
                uninitsWhenFalse.assign(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1654
                uninitsWhenFalse.inclRange(firstadr, nextadr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1655
                initsWhenTrue.assign(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1656
                uninitsWhenTrue.assign(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1657
            } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1658
                scan(tree);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1659
                if (!inits.isReset())
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1660
                    split(tree.type != syms.unknownType);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1661
            }
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1662
            if (tree.type != syms.unknownType) {
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1663
                resetBits(inits, uninits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1664
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1665
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1666
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1667
        /* ------------ Visitor methods for various sorts of trees -------------*/
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1668
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1669
        @Override
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1670
        public void visitClassDef(JCClassDecl tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1671
            if (tree.sym == null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1672
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1673
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1674
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1675
            JCClassDecl classDefPrev = classDef;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1676
            int firstadrPrev = firstadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1677
            int nextadrPrev = nextadr;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1678
            ListBuffer<P> pendingExitsPrev = pendingExits;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1679
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1680
            pendingExits = new ListBuffer<>();
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1681
            if (tree.name != names.empty) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1682
                firstadr = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1683
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1684
            classDef = tree;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1685
            try {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1686
                // define all the static fields
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1687
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1688
                    if (l.head.hasTag(VARDEF)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1689
                        JCVariableDecl def = (JCVariableDecl)l.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1690
                        if ((def.mods.flags & STATIC) != 0) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1691
                            VarSymbol sym = def.sym;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1692
                            if (trackable(sym)) {
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1693
                                newVar(def);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1694
                            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1695
                        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1696
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1697
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1698
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1699
                // process all the static initializers
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1700
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1701
                    if (!l.head.hasTag(METHODDEF) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1702
                        (TreeInfo.flags(l.head) & STATIC) != 0) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1703
                        scan(l.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1704
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1705
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1706
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1707
                // define all the instance fields
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1708
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1709
                    if (l.head.hasTag(VARDEF)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1710
                        JCVariableDecl def = (JCVariableDecl)l.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1711
                        if ((def.mods.flags & STATIC) == 0) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1712
                            VarSymbol sym = def.sym;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1713
                            if (trackable(sym)) {
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1714
                                newVar(def);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1715
                            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1716
                        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1717
                    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1718
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1719
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1720
                // process all the instance initializers
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1721
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1722
                    if (!l.head.hasTag(METHODDEF) &&
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1723
                        (TreeInfo.flags(l.head) & STATIC) == 0) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1724
                        scan(l.head);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1725
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1726
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1727
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1728
                // process all the methods
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1729
                for (List<JCTree> l = tree.defs; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1730
                    if (l.head.hasTag(METHODDEF)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1731
                        scan(l.head);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1732
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1733
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1734
            } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1735
                pendingExits = pendingExitsPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1736
                nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1737
                firstadr = firstadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1738
                classDef = classDefPrev;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1739
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1740
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1741
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1742
        @Override
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1743
        public void visitMethodDef(JCMethodDecl tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1744
            if (tree.body == null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1745
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1746
            }
21477
02dc78554e0c 8026749: Missing LV table in lambda bodies
jjg
parents: 21042
diff changeset
  1747
            /*  Ignore synthetic methods, except for translated lambda methods.
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1748
             */
21477
02dc78554e0c 8026749: Missing LV table in lambda bodies
jjg
parents: 21042
diff changeset
  1749
            if ((tree.sym.flags() & (SYNTHETIC | LAMBDA_METHOD)) == SYNTHETIC) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1750
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1751
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1752
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1753
            final Bits initsPrev = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1754
            final Bits uninitsPrev = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1755
            int nextadrPrev = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1756
            int firstadrPrev = firstadr;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1757
            int returnadrPrev = returnadr;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1758
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1759
            Assert.check(pendingExits.isEmpty());
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1760
            boolean lastInitialConstructor = isInitialConstructor;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1761
            try {
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1762
                isInitialConstructor = TreeInfo.isInitialConstructor(tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1763
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1764
                if (!isInitialConstructor) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1765
                    firstadr = nextadr;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1766
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1767
                for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1768
                    JCVariableDecl def = l.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1769
                    scan(def);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1770
                    Assert.check((def.sym.flags() & PARAMETER) != 0, "Method parameter without PARAMETER flag");
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1771
                    /*  If we are executing the code from Gen, then there can be
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1772
                     *  synthetic or mandated variables, ignore them.
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1773
                     */
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1774
                    initParam(def);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1775
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1776
                // else we are in an instance initializer block;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1777
                // leave caught unchanged.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1778
                scan(tree.body);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1779
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1780
                if (isInitialConstructor) {
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1781
                    boolean isSynthesized = (tree.sym.flags() &
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1782
                                             GENERATEDCONSTR) != 0;
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1783
                    for (int i = firstadr; i < nextadr; i++) {
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1784
                        JCVariableDecl vardecl = vardecls[i];
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1785
                        VarSymbol var = vardecl.sym;
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1786
                        if (var.owner == classDef.sym) {
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1787
                            // choose the diagnostic position based on whether
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1788
                            // the ctor is default(synthesized) or not
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1789
                            if (isSynthesized) {
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1790
                                checkInit(TreeInfo.diagnosticPositionFor(var, vardecl),
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1791
                                    var, "var.not.initialized.in.default.constructor");
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1792
                            } else {
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1793
                                checkInit(TreeInfo.diagEndPos(tree.body), var);
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1794
                            }
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1795
                        }
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1796
                    }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1797
                }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1798
                List<P> exits = pendingExits.toList();
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1799
                pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1800
                while (exits.nonEmpty()) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1801
                    P exit = exits.head;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1802
                    exits = exits.tail;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1803
                    Assert.check(exit.tree.hasTag(RETURN), exit.tree);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1804
                    if (isInitialConstructor) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1805
                        assignToInits(exit.tree, exit.exit_inits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1806
                        for (int i = firstadr; i < nextadr; i++) {
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  1807
                            checkInit(exit.tree.pos(), vardecls[i].sym);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1808
                        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1809
                    }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1810
                }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1811
            } finally {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1812
                assignToInits(tree, initsPrev);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1813
                uninits.assign(uninitsPrev);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1814
                nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1815
                firstadr = firstadrPrev;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  1816
                returnadr = returnadrPrev;
22166
adc980c0dbcc 8030218: javac, compile time error isn't shown when final static field is not assigned, follow-up
vromero
parents: 22165
diff changeset
  1817
                isInitialConstructor = lastInitialConstructor;
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1818
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1819
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  1820
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1821
        protected void initParam(JCVariableDecl def) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1822
            inits.incl(def.sym.adr);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1823
            uninits.excl(def.sym.adr);
21477
02dc78554e0c 8026749: Missing LV table in lambda bodies
jjg
parents: 21042
diff changeset
  1824
            }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1825
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1826
        public void visitVarDef(JCVariableDecl tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1827
            boolean track = trackable(tree.sym);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1828
            if (track && tree.sym.owner.kind == MTH) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1829
                newVar(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1830
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1831
            if (tree.init != null) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1832
                scanExpr(tree.init);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1833
                if (track) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1834
                    letInit(tree.pos(), tree.sym);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1835
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1836
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1837
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1838
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1839
        public void visitBlock(JCBlock tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1840
            int nextadrPrev = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1841
            scan(tree.stats);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1842
            nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1843
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1844
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1845
        int getLogNumberOfErrors() {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1846
            return 0;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1847
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1848
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1849
        public void visitDoLoop(JCDoWhileLoop tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1850
            ListBuffer<P> prevPendingExits = pendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1851
            FlowKind prevFlowKind = flowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1852
            flowKind = FlowKind.NORMAL;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1853
            final Bits initsSkip = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1854
            final Bits uninitsSkip = new Bits(true);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1855
            pendingExits = new ListBuffer<>();
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1856
            int prevErrors = getLogNumberOfErrors();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1857
            do {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1858
                final Bits uninitsEntry = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1859
                uninitsEntry.excludeFrom(nextadr);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1860
                scan(tree.body);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1861
                resolveContinues(tree);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1862
                scanCond(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1863
                if (!flowKind.isFinal()) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1864
                    initsSkip.assign(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1865
                    uninitsSkip.assign(uninitsWhenFalse);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1866
                }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1867
                if (getLogNumberOfErrors() !=  prevErrors ||
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1868
                    flowKind.isFinal() ||
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1869
                    new Bits(uninitsEntry).diffSet(uninitsWhenTrue).nextBit(firstadr)==-1)
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1870
                    break;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1871
                assignToInits(tree.cond, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1872
                uninits.assign(uninitsEntry.andSet(uninitsWhenTrue));
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1873
                flowKind = FlowKind.SPECULATIVE_LOOP;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1874
            } while (true);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1875
            flowKind = prevFlowKind;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1876
            assignToInits(tree, initsSkip);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1877
            uninits.assign(uninitsSkip);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1878
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1879
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1880
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1881
        public void visitWhileLoop(JCWhileLoop tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1882
            ListBuffer<P> prevPendingExits = pendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1883
            FlowKind prevFlowKind = flowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1884
            flowKind = FlowKind.NORMAL;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1885
            final Bits initsSkip = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1886
            final Bits uninitsSkip = new Bits(true);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1887
            pendingExits = new ListBuffer<>();
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1888
            int prevErrors = getLogNumberOfErrors();
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1889
            final Bits uninitsEntry = new Bits(uninits);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1890
            uninitsEntry.excludeFrom(nextadr);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1891
            do {
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1892
                scanCond(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1893
                if (!flowKind.isFinal()) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1894
                    initsSkip.assign(initsWhenFalse) ;
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1895
                    uninitsSkip.assign(uninitsWhenFalse);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1896
                }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1897
                assignToInits(tree, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1898
                uninits.assign(uninitsWhenTrue);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1899
                scan(tree.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1900
                resolveContinues(tree);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1901
                if (getLogNumberOfErrors() != prevErrors ||
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1902
                    flowKind.isFinal() ||
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1903
                    new Bits(uninitsEntry).diffSet(uninits).nextBit(firstadr) == -1) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1904
                    break;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1905
                }
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1906
                uninits.assign(uninitsEntry.andSet(uninits));
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1907
                flowKind = FlowKind.SPECULATIVE_LOOP;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1908
            } while (true);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1909
            flowKind = prevFlowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1910
            //a variable is DA/DU after the while statement, if it's DA/DU assuming the
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1911
            //branch is not taken AND if it's DA/DU before any break statement
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1912
            assignToInits(tree.body, initsSkip);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1913
            uninits.assign(uninitsSkip);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1914
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1915
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1916
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1917
        public void visitForLoop(JCForLoop tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1918
            ListBuffer<P> prevPendingExits = pendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1919
            FlowKind prevFlowKind = flowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1920
            flowKind = FlowKind.NORMAL;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1921
            int nextadrPrev = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1922
            scan(tree.init);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1923
            final Bits initsSkip = new Bits(true);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1924
            final Bits uninitsSkip = new Bits(true);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1925
            pendingExits = new ListBuffer<>();
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1926
            int prevErrors = getLogNumberOfErrors();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1927
            do {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1928
                final Bits uninitsEntry = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1929
                uninitsEntry.excludeFrom(nextadr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1930
                if (tree.cond != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1931
                    scanCond(tree.cond);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1932
                    if (!flowKind.isFinal()) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1933
                        initsSkip.assign(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1934
                        uninitsSkip.assign(uninitsWhenFalse);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1935
                    }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1936
                    assignToInits(tree.body, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1937
                    uninits.assign(uninitsWhenTrue);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1938
                } else if (!flowKind.isFinal()) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1939
                    initsSkip.assign(inits);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1940
                    initsSkip.inclRange(firstadr, nextadr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1941
                    uninitsSkip.assign(uninits);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1942
                    uninitsSkip.inclRange(firstadr, nextadr);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1943
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1944
                scan(tree.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1945
                resolveContinues(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1946
                scan(tree.step);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1947
                if (getLogNumberOfErrors() != prevErrors ||
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1948
                    flowKind.isFinal() ||
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1949
                    new Bits(uninitsEntry).diffSet(uninits).nextBit(firstadr) == -1)
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1950
                    break;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1951
                uninits.assign(uninitsEntry.andSet(uninits));
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1952
                flowKind = FlowKind.SPECULATIVE_LOOP;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1953
            } while (true);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1954
            flowKind = prevFlowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1955
            //a variable is DA/DU after a for loop, if it's DA/DU assuming the
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1956
            //branch is not taken AND if it's DA/DU before any break statement
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1957
            assignToInits(tree.body, initsSkip);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1958
            uninits.assign(uninitsSkip);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1959
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1960
            nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1961
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  1962
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1963
        public void visitForeachLoop(JCEnhancedForLoop tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1964
            visitVarDef(tree.var);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1965
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1966
            ListBuffer<P> prevPendingExits = pendingExits;
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1967
            FlowKind prevFlowKind = flowKind;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1968
            flowKind = FlowKind.NORMAL;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1969
            int nextadrPrev = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1970
            scan(tree.expr);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1971
            final Bits initsStart = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1972
            final Bits uninitsStart = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1973
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1974
            letInit(tree.pos(), tree.var.sym);
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1975
            pendingExits = new ListBuffer<>();
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1976
            int prevErrors = getLogNumberOfErrors();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1977
            do {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1978
                final Bits uninitsEntry = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1979
                uninitsEntry.excludeFrom(nextadr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1980
                scan(tree.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1981
                resolveContinues(tree);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1982
                if (getLogNumberOfErrors() != prevErrors ||
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1983
                    flowKind.isFinal() ||
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1984
                    new Bits(uninitsEntry).diffSet(uninits).nextBit(firstadr) == -1)
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1985
                    break;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1986
                uninits.assign(uninitsEntry.andSet(uninits));
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1987
                flowKind = FlowKind.SPECULATIVE_LOOP;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1988
            } while (true);
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  1989
            flowKind = prevFlowKind;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1990
            assignToInits(tree.body, initsStart);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  1991
            uninits.assign(uninitsStart.andSet(uninits));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1992
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1993
            nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1994
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1995
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1996
        public void visitLabelled(JCLabeledStatement tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  1997
            ListBuffer<P> prevPendingExits = pendingExits;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  1998
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  1999
            scan(tree.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2000
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2001
        }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2002
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2003
        public void visitSwitch(JCSwitch tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2004
            ListBuffer<P> prevPendingExits = pendingExits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2005
            pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2006
            int nextadrPrev = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2007
            scanExpr(tree.selector);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2008
            final Bits initsSwitch = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2009
            final Bits uninitsSwitch = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2010
            boolean hasDefault = false;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2011
            for (List<JCCase> l = tree.cases; l.nonEmpty(); l = l.tail) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2012
                assignToInits(l.head, initsSwitch);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2013
                uninits.assign(uninits.andSet(uninitsSwitch));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2014
                JCCase c = l.head;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2015
                if (c.pat == null) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2016
                    hasDefault = true;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2017
                } else {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2018
                    scanExpr(c.pat);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2019
                }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2020
                if (hasDefault) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2021
                    assignToInits(null, initsSwitch);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2022
                    uninits.assign(uninits.andSet(uninitsSwitch));
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2023
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2024
                scan(c.stats);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2025
                addVars(c.stats, initsSwitch, uninitsSwitch);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2026
                if (!hasDefault) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2027
                    assignToInits(l.head.stats.last(), initsSwitch);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2028
                    uninits.assign(uninits.andSet(uninitsSwitch));
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2029
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2030
                // Warn about fall-through if lint switch fallthrough enabled.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2031
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2032
            if (!hasDefault) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2033
                andSetInits(null, initsSwitch);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2034
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2035
            resolveBreaks(tree, prevPendingExits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2036
            nextadr = nextadrPrev;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2037
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2038
        // where
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2039
            /** Add any variables defined in stats to inits and uninits. */
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2040
            private void addVars(List<JCStatement> stats, final Bits inits,
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2041
                                        final Bits uninits) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2042
                for (;stats.nonEmpty(); stats = stats.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2043
                    JCTree stat = stats.head;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2044
                    if (stat.hasTag(VARDEF)) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2045
                        int adr = ((JCVariableDecl) stat).sym.adr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2046
                        inits.excl(adr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2047
                        uninits.incl(adr);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2048
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2049
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2050
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2051
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2052
        boolean isEnabled(Lint.LintCategory lc) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2053
            return false;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2054
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2055
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2056
        void reportWarning(Lint.LintCategory lc, DiagnosticPosition pos, String key, Object ... args) {}
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2057
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2058
        public void visitTry(JCTry tree) {
20249
93f8eae31092 6386236: Please rename com.sun.tools.javac.util.ListBuffer.lb()
alundblad
parents: 19941
diff changeset
  2059
            ListBuffer<JCVariableDecl> resourceVarDecls = new ListBuffer<>();
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2060
            final Bits uninitsTryPrev = new Bits(uninitsTry);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2061
            ListBuffer<P> prevPendingExits = pendingExits;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2062
            pendingExits = new ListBuffer<>();
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2063
            final Bits initsTry = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2064
            uninitsTry.assign(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2065
            for (JCTree resource : tree.resources) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2066
                if (resource instanceof JCVariableDecl) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2067
                    JCVariableDecl vdecl = (JCVariableDecl) resource;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2068
                    visitVarDef(vdecl);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2069
                    unrefdResources.enter(vdecl.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2070
                    resourceVarDecls.append(vdecl);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2071
                } else if (resource instanceof JCExpression) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2072
                    scanExpr((JCExpression) resource);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2073
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2074
                    throw new AssertionError(tree);  // parser error
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2075
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2076
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2077
            scan(tree.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2078
            uninitsTry.andSet(uninits);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2079
            final Bits initsEnd = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2080
            final Bits uninitsEnd = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2081
            int nextadrCatch = nextadr;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2082
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2083
            if (!resourceVarDecls.isEmpty() &&
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2084
                    isEnabled(Lint.LintCategory.TRY)) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2085
                for (JCVariableDecl resVar : resourceVarDecls) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2086
                    if (unrefdResources.includes(resVar.sym)) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2087
                        reportWarning(Lint.LintCategory.TRY, resVar.pos(),
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2088
                                    "try.resource.not.referenced", resVar.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2089
                        unrefdResources.remove(resVar.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2090
                    }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2091
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2092
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2093
18672
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2094
            /*  The analysis of each catch should be independent.
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2095
             *  Each one should have the same initial values of inits and
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2096
             *  uninits.
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2097
             */
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2098
            final Bits initsCatchPrev = new Bits(initsTry);
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2099
            final Bits uninitsCatchPrev = new Bits(uninitsTry);
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2100
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2101
            for (List<JCCatch> l = tree.catchers; l.nonEmpty(); l = l.tail) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2102
                JCVariableDecl param = l.head.param;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2103
                assignToInits(tree.body, initsCatchPrev);
18672
1d6d1be0a94f 6326693: variable x might already have been assigned, when assignment is in catch block
vromero
parents: 18010
diff changeset
  2104
                uninits.assign(uninitsCatchPrev);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2105
                scan(param);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2106
                /* If this is a TWR and we are executing the code from Gen,
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2107
                 * then there can be synthetic variables, ignore them.
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2108
                 */
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2109
                initParam(param);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2110
                scan(l.head.body);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2111
                initsEnd.andSet(inits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2112
                uninitsEnd.andSet(uninits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2113
                nextadr = nextadrCatch;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2114
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2115
            if (tree.finalizer != null) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2116
                assignToInits(tree.finalizer, initsTry);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2117
                uninits.assign(uninitsTry);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2118
                ListBuffer<P> exits = pendingExits;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2119
                pendingExits = prevPendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2120
                scan(tree.finalizer);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2121
                if (!tree.finallyCanCompleteNormally) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2122
                    // discard exits and exceptions from try and finally
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2123
                } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2124
                    uninits.andSet(uninitsEnd);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2125
                    // FIX: this doesn't preserve source order of exits in catch
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2126
                    // versus finally!
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2127
                    while (exits.nonEmpty()) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2128
                        P exit = exits.next();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2129
                        if (exit.exit_inits != null) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2130
                            exit.exit_inits.orSet(inits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2131
                            exit.exit_uninits.andSet(uninits);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2132
                        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2133
                        pendingExits.append(exit);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2134
                    }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2135
                    orSetInits(tree, initsEnd);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2136
                }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2137
            } else {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2138
                assignToInits(tree, initsEnd);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2139
                uninits.assign(uninitsEnd);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2140
                ListBuffer<P> exits = pendingExits;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2141
                pendingExits = prevPendingExits;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2142
                while (exits.nonEmpty()) pendingExits.append(exits.next());
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2143
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2144
            uninitsTry.andSet(uninitsTryPrev).andSet(uninits);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2145
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2146
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2147
        public void visitConditional(JCConditional tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2148
            scanCond(tree.cond);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2149
            final Bits initsBeforeElse = new Bits(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2150
            final Bits uninitsBeforeElse = new Bits(uninitsWhenFalse);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2151
            assignToInits(tree.cond, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2152
            uninits.assign(uninitsWhenTrue);
14359
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14259
diff changeset
  2153
            if (tree.truepart.type.hasTag(BOOLEAN) &&
d4099818ab70 7200915: convert TypeTags from a series of small ints to an enum
jjg
parents: 14259
diff changeset
  2154
                tree.falsepart.type.hasTag(BOOLEAN)) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2155
                // if b and c are boolean valued, then
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2156
                // v is (un)assigned after a?b:c when true iff
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2157
                //    v is (un)assigned after b when true and
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2158
                //    v is (un)assigned after c when true
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2159
                scanCond(tree.truepart);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2160
                final Bits initsAfterThenWhenTrue = new Bits(initsWhenTrue);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2161
                final Bits initsAfterThenWhenFalse = new Bits(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2162
                final Bits uninitsAfterThenWhenTrue = new Bits(uninitsWhenTrue);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2163
                final Bits uninitsAfterThenWhenFalse = new Bits(uninitsWhenFalse);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2164
                assignToInits(tree.truepart, initsBeforeElse);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2165
                uninits.assign(uninitsBeforeElse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2166
                scanCond(tree.falsepart);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2167
                initsWhenTrue.andSet(initsAfterThenWhenTrue);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2168
                initsWhenFalse.andSet(initsAfterThenWhenFalse);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2169
                uninitsWhenTrue.andSet(uninitsAfterThenWhenTrue);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2170
                uninitsWhenFalse.andSet(uninitsAfterThenWhenFalse);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2171
            } else {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2172
                scanExpr(tree.truepart);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2173
                final Bits initsAfterThen = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2174
                final Bits uninitsAfterThen = new Bits(uninits);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2175
                assignToInits(tree.truepart, initsBeforeElse);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2176
                uninits.assign(uninitsBeforeElse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2177
                scanExpr(tree.falsepart);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2178
                andSetInits(tree.falsepart, initsAfterThen);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2179
                uninits.andSet(uninitsAfterThen);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2180
            }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2181
        }
06bc494ca11e Initial load
duke
parents:
diff changeset
  2182
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2183
        public void visitIf(JCIf tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2184
            scanCond(tree.cond);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2185
            final Bits initsBeforeElse = new Bits(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2186
            final Bits uninitsBeforeElse = new Bits(uninitsWhenFalse);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2187
            assignToInits(tree.cond, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2188
            uninits.assign(uninitsWhenTrue);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2189
            scan(tree.thenpart);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2190
            if (tree.elsepart != null) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2191
                final Bits initsAfterThen = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2192
                final Bits uninitsAfterThen = new Bits(uninits);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2193
                assignToInits(tree.thenpart, initsBeforeElse);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2194
                uninits.assign(uninitsBeforeElse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2195
                scan(tree.elsepart);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2196
                andSetInits(tree.elsepart, initsAfterThen);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2197
                uninits.andSet(uninitsAfterThen);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5847
diff changeset
  2198
            } else {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2199
                andSetInits(tree.thenpart, initsBeforeElse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2200
                uninits.andSet(uninitsBeforeElse);
6148
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5847
diff changeset
  2201
            }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5847
diff changeset
  2202
        }
3a8158299c51 6911256: Project Coin: Support Automatic Resource Management (ARM) blocks in the compiler
darcy
parents: 5847
diff changeset
  2203
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2204
        protected P createNewPendingExit(JCTree tree, Bits inits, Bits uninits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2205
            return null;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2206
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2207
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2208
        @Override
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2209
        public void visitBreak(JCBreak tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2210
            recordExit(tree, createNewPendingExit(tree, inits, uninits));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2211
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2212
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2213
        @Override
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2214
        public void visitContinue(JCContinue tree) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2215
            recordExit(tree, createNewPendingExit(tree, inits, uninits));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2216
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2217
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2218
        @Override
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2219
        public void visitReturn(JCReturn tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2220
            scanExpr(tree.expr);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2221
            recordExit(tree, createNewPendingExit(tree, inits, uninits));
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2222
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2223
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2224
        public void visitThrow(JCThrow tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2225
            scanExpr(tree.expr);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2226
            markDead(tree.expr);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2227
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2228
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2229
        public void visitApply(JCMethodInvocation tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2230
            scanExpr(tree.meth);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2231
            scanExprs(tree.args);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2232
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2233
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2234
        public void visitNewClass(JCNewClass tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2235
            scanExpr(tree.encl);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2236
            scanExprs(tree.args);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2237
            scan(tree.def);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2238
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2239
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2240
        @Override
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2241
        public void visitLambda(JCLambda tree) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2242
            final Bits prevUninits = new Bits(uninits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2243
            final Bits prevInits = new Bits(inits);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2244
            int returnadrPrev = returnadr;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2245
            ListBuffer<P> prevPending = pendingExits;
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2246
            try {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2247
                returnadr = nextadr;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  2248
                pendingExits = new ListBuffer<>();
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2249
                for (List<JCVariableDecl> l = tree.params; l.nonEmpty(); l = l.tail) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2250
                    JCVariableDecl def = l.head;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2251
                    scan(def);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2252
                    inits.incl(def.sym.adr);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2253
                    uninits.excl(def.sym.adr);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2254
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2255
                if (tree.getBodyKind() == JCLambda.BodyKind.EXPRESSION) {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2256
                    scanExpr(tree.body);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2257
                } else {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2258
                    scan(tree.body);
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2259
                }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2260
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2261
            finally {
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2262
                returnadr = returnadrPrev;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2263
                uninits.assign(prevUninits);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2264
                assignToInits(tree, prevInits);
14058
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2265
                pendingExits = prevPending;
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2266
            }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2267
        }
c7ec7facdd20 7177385: Add attribution support for lambda expressions
mcimadamore
parents: 14049
diff changeset
  2268
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2269
        public void visitNewArray(JCNewArray tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2270
            scanExprs(tree.dims);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2271
            scanExprs(tree.elems);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2272
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2273
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2274
        public void visitAssert(JCAssert tree) {
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2275
            final Bits initsExit = new Bits(inits);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2276
            final Bits uninitsExit = new Bits(uninits);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2277
            scanCond(tree.cond);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2278
            uninitsExit.andSet(uninitsWhenTrue);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2279
            if (tree.detail != null) {
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2280
                assignToInits(tree, initsWhenFalse);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2281
                uninits.assign(uninitsWhenFalse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2282
                scanExpr(tree.detail);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2283
            }
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2284
            assignToInits(tree, initsExit);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2285
            uninits.assign(uninitsExit);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2286
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2287
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2288
        public void visitAssign(JCAssign tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2289
            JCTree lhs = TreeInfo.skipParens(tree.lhs);
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2290
            if (!isIdentOrThisDotIdent(lhs))
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2291
                scanExpr(lhs);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2292
            scanExpr(tree.rhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2293
            letInit(lhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2294
        }
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2295
        private boolean isIdentOrThisDotIdent(JCTree lhs) {
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2296
            if (lhs.hasTag(IDENT))
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2297
                return true;
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2298
            if (!lhs.hasTag(SELECT))
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2299
                return false;
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2300
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2301
            JCFieldAccess fa = (JCFieldAccess)lhs;
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2302
            return fa.selected.hasTag(IDENT) &&
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2303
                   ((JCIdent)fa.selected).name == names._this;
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2304
        }
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2305
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2306
        // check fields accessed through this.<field> are definitely
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2307
        // assigned before reading their value
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2308
        public void visitSelect(JCFieldAccess tree) {
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2309
            super.visitSelect(tree);
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2310
            if (enforceThisDotInit &&
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2311
                tree.selected.hasTag(IDENT) &&
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2312
                ((JCIdent)tree.selected).name == names._this &&
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2313
                tree.sym.kind == VAR)
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2314
            {
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2315
                checkInit(tree.pos(), (VarSymbol)tree.sym);
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2316
            }
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2317
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2318
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2319
        public void visitAssignop(JCAssignOp tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2320
            scanExpr(tree.lhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2321
            scanExpr(tree.rhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2322
            letInit(tree.lhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2323
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2324
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2325
        public void visitUnary(JCUnary tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2326
            switch (tree.getTag()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2327
            case NOT:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2328
                scanCond(tree.arg);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2329
                final Bits t = new Bits(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2330
                initsWhenFalse.assign(initsWhenTrue);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2331
                initsWhenTrue.assign(t);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2332
                t.assign(uninitsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2333
                uninitsWhenFalse.assign(uninitsWhenTrue);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2334
                uninitsWhenTrue.assign(t);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2335
                break;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2336
            case PREINC: case POSTINC:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2337
            case PREDEC: case POSTDEC:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2338
                scanExpr(tree.arg);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2339
                letInit(tree.arg);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2340
                break;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2341
            default:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2342
                scanExpr(tree.arg);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2343
            }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2344
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2345
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2346
        public void visitBinary(JCBinary tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2347
            switch (tree.getTag()) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2348
            case AND:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2349
                scanCond(tree.lhs);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2350
                final Bits initsWhenFalseLeft = new Bits(initsWhenFalse);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2351
                final Bits uninitsWhenFalseLeft = new Bits(uninitsWhenFalse);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2352
                assignToInits(tree.lhs, initsWhenTrue);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2353
                uninits.assign(uninitsWhenTrue);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2354
                scanCond(tree.rhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2355
                initsWhenFalse.andSet(initsWhenFalseLeft);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2356
                uninitsWhenFalse.andSet(uninitsWhenFalseLeft);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2357
                break;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2358
            case OR:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2359
                scanCond(tree.lhs);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2360
                final Bits initsWhenTrueLeft = new Bits(initsWhenTrue);
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2361
                final Bits uninitsWhenTrueLeft = new Bits(uninitsWhenTrue);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2362
                assignToInits(tree.lhs, initsWhenFalse);
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2363
                uninits.assign(uninitsWhenFalse);
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2364
                scanCond(tree.rhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2365
                initsWhenTrue.andSet(initsWhenTrueLeft);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2366
                uninitsWhenTrue.andSet(uninitsWhenTrueLeft);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2367
                break;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2368
            default:
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2369
                scanExpr(tree.lhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2370
                scanExpr(tree.rhs);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2371
            }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2372
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2373
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2374
        public void visitIdent(JCIdent tree) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2375
            if (tree.sym.kind == VAR) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2376
                checkInit(tree.pos(), (VarSymbol)tree.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2377
                referenced(tree.sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2378
            }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2379
        }
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2380
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2381
        void referenced(Symbol sym) {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2382
            unrefdResources.remove(sym);
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2383
        }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2384
15385
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 14801
diff changeset
  2385
        public void visitAnnotatedType(JCAnnotatedType tree) {
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 14801
diff changeset
  2386
            // annotations don't get scanned
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 14801
diff changeset
  2387
            tree.underlyingType.accept(this);
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 14801
diff changeset
  2388
        }
ee1eebe7e210 8006775: JSR 308: Compiler changes in JDK8
jjg
parents: 14801
diff changeset
  2389
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2390
    /**************************************************************************
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2391
     * main method
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2392
     *************************************************************************/
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2393
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2394
        /** Perform definite assignment/unassignment analysis on a tree.
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2395
         */
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2396
        public void analyzeTree(Env<?> env) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2397
            analyzeTree(env, env.tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2398
         }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2399
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2400
        public void analyzeTree(Env<?> env, JCTree tree) {
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2401
            try {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2402
                startPos = tree.pos().getStartPosition();
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2403
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  2404
                if (vardecls == null)
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  2405
                    vardecls = new JCVariableDecl[32];
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2406
                else
19122
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  2407
                    for (int i=0; i<vardecls.length; i++)
1841f2fa76de 8017216: javac doesn't fill in end position for some errors of type not found
ksrini
parents: 18912
diff changeset
  2408
                        vardecls[i] = null;
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2409
                firstadr = 0;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2410
                nextadr = 0;
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2411
                pendingExits = new ListBuffer<>();
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2412
                this.classDef = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2413
                unrefdResources = new Scope(env.enclClass.sym);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2414
                scan(tree);
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2415
            } finally {
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2416
                // note that recursive invocations of this method fail hard
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2417
                startPos = -1;
17282
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2418
                resetBits(inits, uninits, uninitsTry, initsWhenTrue,
c6964ad7df63 8008562: javac, a refactoring to Bits is necessary in order to provide a change history
vromero
parents: 16971
diff changeset
  2419
                        initsWhenFalse, uninitsWhenTrue, uninitsWhenFalse);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2420
                if (vardecls != null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2421
                    for (int i=0; i<vardecls.length; i++)
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2422
                        vardecls[i] = null;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2423
                }
12333
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2424
                firstadr = 0;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2425
                nextadr = 0;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2426
                pendingExits = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2427
                this.classDef = null;
7b02d0529a97 7151580: Separate DA/DU logic from exception checking logic in Flow.java
mcimadamore
parents: 10950
diff changeset
  2428
                unrefdResources = null;
8849
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
  2429
            }
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
  2430
        }
4189ac38ddc9 6558548: The compiler needs to be aligned with clarified specification of throws
mcimadamore
parents: 8627
diff changeset
  2431
    }
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2432
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2433
    public static class AssignAnalyzer
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2434
        extends AbstractAssignAnalyzer<AssignAnalyzer.AssignPendingExit> {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2435
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2436
        Log log;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2437
        Lint lint;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2438
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2439
        public static class AssignPendingExit
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2440
            extends AbstractAssignAnalyzer.AbstractAssignPendingExit {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2441
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2442
            public AssignPendingExit(JCTree tree, final Bits inits, final Bits uninits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2443
                super(tree, inits, uninits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2444
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2445
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2446
24218
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2447
        public AssignAnalyzer(Log log, Symtab syms, Lint lint, Names names, boolean enforceThisDotInit) {
9102c46a15dc 8039026: Definitely unassigned field can be accessed
pgovereau
parents: 24069
diff changeset
  2448
            super(new Bits(), syms, names, enforceThisDotInit);
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2449
            this.log = log;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2450
            this.lint = lint;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2451
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2452
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2453
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2454
        protected AssignPendingExit createNewPendingExit(JCTree tree,
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2455
            Bits inits, Bits uninits) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2456
            return new AssignPendingExit(tree, inits, uninits);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2457
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2458
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2459
        /** Record an initialization of a trackable variable.
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2460
         */
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2461
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2462
        void letInit(DiagnosticPosition pos, VarSymbol sym) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2463
            if (sym.adr >= firstadr && trackable(sym)) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2464
                if ((sym.flags() & EFFECTIVELY_FINAL) != 0) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2465
                    if (!uninits.isMember(sym.adr)) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2466
                        //assignment targeting an effectively final variable
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2467
                        //makes the variable lose its status of effectively final
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2468
                        //if the variable is _not_ definitively unassigned
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2469
                        sym.flags_field &= ~EFFECTIVELY_FINAL;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2470
                    } else {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2471
                        uninit(sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2472
                    }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2473
                }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2474
                else if ((sym.flags() & FINAL) != 0) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2475
                    if ((sym.flags() & PARAMETER) != 0) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2476
                        if ((sym.flags() & UNION) != 0) { //multi-catch parameter
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2477
                            log.error(pos, "multicatch.parameter.may.not.be.assigned", sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2478
                        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2479
                        else {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2480
                            log.error(pos, "final.parameter.may.not.be.assigned",
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2481
                                  sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2482
                        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2483
                    } else if (!uninits.isMember(sym.adr)) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2484
                        log.error(pos, flowKind.errKey, sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2485
                    } else {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2486
                        uninit(sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2487
                    }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2488
                }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2489
                inits.incl(sym.adr);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2490
            } else if ((sym.flags() & FINAL) != 0) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2491
                log.error(pos, "var.might.already.be.assigned", sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2492
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2493
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2494
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2495
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2496
        void checkInit(DiagnosticPosition pos, VarSymbol sym, String errkey) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2497
            if ((sym.adr >= firstadr || sym.owner.kind != TYP) &&
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2498
                trackable(sym) &&
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2499
                !inits.isMember(sym.adr)) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2500
                log.error(pos, errkey, sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2501
                inits.incl(sym.adr);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2502
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2503
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2504
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2505
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2506
        void reportWarning(Lint.LintCategory lc, DiagnosticPosition pos,
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2507
            String key, Object ... args) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2508
            log.warning(lc, pos, key, args);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2509
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2510
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2511
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2512
        int getLogNumberOfErrors() {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2513
            return log.nerrors;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2514
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2515
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2516
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2517
        boolean isEnabled(Lint.LintCategory lc) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2518
            return lint.isEnabled(lc);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2519
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2520
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2521
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2522
        public void visitClassDef(JCClassDecl tree) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2523
            if (tree.sym == null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2524
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2525
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2526
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2527
            Lint lintPrev = lint;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2528
            lint = lint.augment(tree.sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2529
            try {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2530
                super.visitClassDef(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2531
            } finally {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2532
                lint = lintPrev;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2533
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2534
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2535
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2536
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2537
        public void visitMethodDef(JCMethodDecl tree) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2538
            if (tree.body == null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2539
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2540
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2541
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2542
            /*  MemberEnter can generate synthetic methods ignore them
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2543
             */
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2544
            if ((tree.sym.flags() & SYNTHETIC) != 0) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2545
                return;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2546
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2547
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2548
            Lint lintPrev = lint;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2549
            lint = lint.augment(tree.sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2550
            try {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2551
                super.visitMethodDef(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2552
            } finally {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2553
                lint = lintPrev;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2554
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2555
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2556
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2557
        @Override
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2558
        public void visitVarDef(JCVariableDecl tree) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2559
            if (tree.init == null) {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2560
                super.visitVarDef(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2561
            } else {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2562
                Lint lintPrev = lint;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2563
                lint = lint.augment(tree.sym);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2564
                try{
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2565
                    super.visitVarDef(tree);
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2566
                } finally {
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2567
                    lint = lintPrev;
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2568
                }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2569
            }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2570
        }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2571
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2572
    }
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2573
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2574
    /**
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2575
     * This pass implements the last step of the dataflow analysis, namely
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2576
     * the effectively-final analysis check. This checks that every local variable
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2577
     * reference from a lambda body/local inner class is either final or effectively final.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2578
     * As effectively final variables are marked as such during DA/DU, this pass must run after
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2579
     * AssignAnalyzer.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2580
     */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2581
    class CaptureAnalyzer extends BaseAnalyzer<BaseAnalyzer.PendingExit> {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2582
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2583
        JCTree currentTree; //local class or lambda
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2584
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2585
        @Override
19941
8b91e8eb2d20 7047734: javac, the LVT is not generated correctly in several scenarios
vromero
parents: 19933
diff changeset
  2586
        void markDead(JCTree tree) {
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2587
            //do nothing
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2588
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2589
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2590
        @SuppressWarnings("fallthrough")
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2591
        void checkEffectivelyFinal(DiagnosticPosition pos, VarSymbol sym) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2592
            if (currentTree != null &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2593
                    sym.owner.kind == MTH &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2594
                    sym.pos < currentTree.getStartPosition()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2595
                switch (currentTree.getTag()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2596
                    case CLASSDEF:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2597
                        if (!allowEffectivelyFinalInInnerClasses) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2598
                            if ((sym.flags() & FINAL) == 0) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2599
                                reportInnerClsNeedsFinalError(pos, sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2600
                            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2601
                            break;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2602
                        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2603
                    case LAMBDA:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2604
                        if ((sym.flags() & (EFFECTIVELY_FINAL | FINAL)) == 0) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2605
                           reportEffectivelyFinalError(pos, sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2606
                        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2607
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2608
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2609
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2610
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2611
        @SuppressWarnings("fallthrough")
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2612
        void letInit(JCTree tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2613
            tree = TreeInfo.skipParens(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2614
            if (tree.hasTag(IDENT) || tree.hasTag(SELECT)) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2615
                Symbol sym = TreeInfo.symbol(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2616
                if (currentTree != null &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2617
                        sym.kind == VAR &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2618
                        sym.owner.kind == MTH &&
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2619
                        ((VarSymbol)sym).pos < currentTree.getStartPosition()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2620
                    switch (currentTree.getTag()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2621
                        case CLASSDEF:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2622
                            if (!allowEffectivelyFinalInInnerClasses) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2623
                                reportInnerClsNeedsFinalError(tree, sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2624
                                break;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2625
                            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2626
                        case LAMBDA:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2627
                            reportEffectivelyFinalError(tree, sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2628
                    }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2629
                }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2630
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2631
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2632
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2633
        void reportEffectivelyFinalError(DiagnosticPosition pos, Symbol sym) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2634
            String subKey = currentTree.hasTag(LAMBDA) ?
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2635
                  "lambda"  : "inner.cls";
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2636
            log.error(pos, "cant.ref.non.effectively.final.var", sym, diags.fragment(subKey));
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2637
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2638
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2639
        void reportInnerClsNeedsFinalError(DiagnosticPosition pos, Symbol sym) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2640
            log.error(pos,
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2641
                    "local.var.accessed.from.icls.needs.final",
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2642
                    sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2643
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2644
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2645
    /*************************************************************************
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2646
     * Visitor methods for statements and definitions
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2647
     *************************************************************************/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2648
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2649
        /* ------------ Visitor methods for various sorts of trees -------------*/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2650
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2651
        public void visitClassDef(JCClassDecl tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2652
            JCTree prevTree = currentTree;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2653
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2654
                currentTree = tree.sym.isLocal() ? tree : null;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2655
                super.visitClassDef(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2656
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2657
                currentTree = prevTree;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2658
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2659
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2660
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2661
        @Override
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2662
        public void visitLambda(JCLambda tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2663
            JCTree prevTree = currentTree;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2664
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2665
                currentTree = tree;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2666
                super.visitLambda(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2667
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2668
                currentTree = prevTree;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2669
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2670
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2671
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2672
        @Override
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2673
        public void visitIdent(JCIdent tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2674
            if (tree.sym.kind == VAR) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2675
                checkEffectivelyFinal(tree, (VarSymbol)tree.sym);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2676
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2677
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2678
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2679
        public void visitAssign(JCAssign tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2680
            JCTree lhs = TreeInfo.skipParens(tree.lhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2681
            if (!(lhs instanceof JCIdent)) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2682
                scan(lhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2683
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2684
            scan(tree.rhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2685
            letInit(lhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2686
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2687
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2688
        public void visitAssignop(JCAssignOp tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2689
            scan(tree.lhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2690
            scan(tree.rhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2691
            letInit(tree.lhs);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2692
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2693
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2694
        public void visitUnary(JCUnary tree) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2695
            switch (tree.getTag()) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2696
                case PREINC: case POSTINC:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2697
                case PREDEC: case POSTDEC:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2698
                    scan(tree.arg);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2699
                    letInit(tree.arg);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2700
                    break;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2701
                default:
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2702
                    scan(tree.arg);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2703
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2704
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2705
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2706
    /**************************************************************************
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2707
     * main method
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2708
     *************************************************************************/
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2709
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2710
        /** Perform definite assignment/unassignment analysis on a tree.
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2711
         */
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2712
        public void analyzeTree(Env<AttrContext> env, TreeMaker make) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2713
            analyzeTree(env, env.tree, make);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2714
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2715
        public void analyzeTree(Env<AttrContext> env, JCTree tree, TreeMaker make) {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2716
            try {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2717
                attrEnv = env;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2718
                Flow.this.make = make;
22163
3651128c74eb 8030244: Update langtools to use Diamond
briangoetz
parents: 22150
diff changeset
  2719
                pendingExits = new ListBuffer<>();
13439
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2720
                scan(tree);
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2721
            } finally {
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2722
                pendingExits = null;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2723
                Flow.this.make = null;
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2724
            }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2725
        }
3025d6ac1401 7175538: Integrate efectively final check with DA/DU analysis
mcimadamore
parents: 13273
diff changeset
  2726
    }
10
06bc494ca11e Initial load
duke
parents:
diff changeset
  2727
}