langtools/test/tools/javac/modules/PoorChoiceForModuleNameTest.java
author ihse
Tue, 09 May 2017 12:55:07 +0200
changeset 45045 834233132ab1
parent 44568 3d870d326626
permissions -rw-r--r--
8179889: Fix typographic errors in copyright headers Reviewed-by: erikj, dholmes
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     1
/*
45045
834233132ab1 8179889: Fix typographic errors in copyright headers
ihse
parents: 44568
diff changeset
     2
 * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     4
 *
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     7
 * published by the Free Software Foundation.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     8
 *
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    13
 * accompanied this code).
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    14
 *
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    18
 *
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    21
 * questions.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    22
 */
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    23
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    24
/*
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    25
 * @test
44568
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    26
 * @bug 8160181 8176572
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    27
 * @summary Add lint warning for digits in module names
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    28
 * @library /tools/lib
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    29
 * @modules
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    30
 *      jdk.compiler/com.sun.tools.javac.api
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    31
 *      jdk.compiler/com.sun.tools.javac.code
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    32
 *      jdk.compiler/com.sun.tools.javac.main
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    33
 * @build toolbox.ToolBox toolbox.JavacTask ModuleTestBase
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    34
 * @run main PoorChoiceForModuleNameTest
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    35
 */
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    36
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    37
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    38
import java.nio.file.Path;
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    39
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    40
import toolbox.JavacTask;
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    41
import toolbox.Task;
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    42
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    43
public class PoorChoiceForModuleNameTest extends ModuleTestBase {
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    44
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    45
    public static void main(String... args) throws Exception {
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    46
        new PoorChoiceForModuleNameTest().runTests();
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    47
    }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    48
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    49
    @Test
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    50
    public void testDigitsInModuleNames(Path base) throws Exception {
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    51
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    52
        Path src = base.resolve("src");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    53
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    54
        // Nitpickable module name
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    55
        Path src_m1 = src.resolve("mango19");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    56
        tb.writeJavaFiles(src_m1, "module mango19 { }");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    57
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    58
        // Acceptable module name.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    59
        Path src_m2 = src.resolve("mango20kg");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    60
        tb.writeJavaFiles(src_m2, "module mango20kg { }");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    61
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    62
        // Nitpickable, but should not due to annotation.
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    63
        Path src_m3 = src.resolve("mango100");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    64
        tb.writeJavaFiles(src_m3, "@SuppressWarnings(\"module\") module mango100 { }");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    65
44568
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    66
        // Check that there is no warning at use site.
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    67
        Path src_m4 = src.resolve("mangouser");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    68
        tb.writeJavaFiles(src_m4, "module mangouser { requires mango19; }");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    69
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    70
        // Check that we warn about component names ending in digit also
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    71
        Path src_m5 = src.resolve("mango1000.mangofruit.mangomodule");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    72
        tb.writeJavaFiles(src_m5, "module mango1000.mangofruit.mangomodule { }");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    73
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    74
        // Check that we warn about component names ending in digit also
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    75
        Path src_m6 = src.resolve("mangofruit.mango1000.mangomodule");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    76
        tb.writeJavaFiles(src_m6, "module mangofruit.mango1000.mangomodule { }");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    77
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    78
        // Check that we warn about component names ending in digit also
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    79
        Path src_m7 = src.resolve("mangomodule.mangofruit.mango1000");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    80
        tb.writeJavaFiles(src_m7, "module mangomodule.mangofruit.mango1000 { }");
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    81
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    82
        Path classes = base.resolve("classes");
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    83
        tb.createDirectories(classes);
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    84
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    85
        String log = new JavacTask(tb)
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    86
                .options("-XDrawDiagnostics",
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    87
                         "-Xlint:module",
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    88
                         "-Werror",
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    89
                         "--module-source-path", src.toString())
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    90
                .outdir(classes)
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    91
                .files(findJavaFiles(src))
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    92
                .run(Task.Expect.FAIL)
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    93
                .writeAll()
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    94
                .getOutput(Task.OutputKind.DIRECT);
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    95
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
    96
        if (!log.contains("module-info.java:1:8: compiler.warn.poor.choice.for.module.name: mango19") ||
44568
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    97
            !log.contains("module-info.java:1:8: compiler.warn.poor.choice.for.module.name: mango1000") ||
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    98
            !log.contains("module-info.java:1:18: compiler.warn.poor.choice.for.module.name: mango1000") ||
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
    99
            !log.contains("module-info.java:1:30: compiler.warn.poor.choice.for.module.name: mango1000") ||
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
   100
            !log.contains("- compiler.err.warnings.and.werror") ||
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
   101
            !log.contains("1 error") ||
44568
3d870d326626 8176572: Javac does not enforce module name restrictions
sadayapalam
parents: 42822
diff changeset
   102
            !log.contains("4 warning"))
42822
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
   103
            throw new Exception("expected output not found: " + log);
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
   104
    }
a84956e7ee4d 8170987: Module system implementation refresh (12/2016)
alanb
parents:
diff changeset
   105
}