langtools/test/tools/javac/linenumbers/FinallyLineNumberTest.java
author vromero
Mon, 22 May 2017 12:49:05 -0700
changeset 45220 7c775294b6f1
parent 33371 b6f6281b4c07
permissions -rw-r--r--
8180660: missing LNT entry for finally block Reviewed-by: mcimadamore, vromero Contributed-by: maurizio.cimadamore@oracle.com, vicente.romero@oracle.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     1
/*
45220
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
     2
 * Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     4
 *
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     7
 * published by the Free Software Foundation.
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     8
 *
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    13
 * accompanied this code).
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    14
 *
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    18
 *
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    21
 * questions.
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    22
 */
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    23
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    24
/*
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    25
 * @test
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    26
 * @bug 8134759
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    27
 * @summary Add LineNumberTable attribute for return bytecodes split around finally code
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    28
 * @modules jdk.jdeps/com.sun.tools.classfile
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    29
 */
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    30
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    31
import com.sun.tools.classfile.ClassFile;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    32
import com.sun.tools.classfile.ConstantPoolException;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    33
import com.sun.tools.classfile.Method;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    34
import com.sun.tools.classfile.Attribute;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    35
import com.sun.tools.classfile.Code_attribute;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    36
import com.sun.tools.classfile.LineNumberTable_attribute;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    37
import com.sun.tools.classfile.LineNumberTable_attribute.Entry;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    38
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    39
import java.io.IOException;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    40
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    41
public class FinallyLineNumberTest {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    42
    public static void main(String[] args) throws Exception {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    43
        // check that we have 5 consecutive entries for method()
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    44
        Entry[] lines = findEntries();
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    45
        if (lines == null) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    46
            throw new Exception("finally line number table could not be loaded");
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    47
        }
45220
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    48
        if (lines.length != 5) {
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    49
            // Help debug
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    50
            System.err.println("LineTable error, got lines:");
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    51
            for (Entry e : lines) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    52
                System.err.println(e.line_number);
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    53
            }
45220
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    54
            throw new Exception("finally line number table incorrect: length=" + lines.length + " expected length=5");
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    55
        }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    56
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    57
        // return null line, for the load null operation
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    58
        int current = lines[0].line_number;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    59
        int first = current;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    60
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    61
        // finally line
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    62
        current = lines[1].line_number;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    63
        if (current != first + 2) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    64
            throw new Exception("finally line number table incorrect: got=" + current + " expected=" + (first + 2));
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    65
        }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    66
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    67
        // return null line, for the return operation
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    68
        current = lines[2].line_number;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    69
        if (current != first) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    70
            throw new Exception("finally line number table incorrect: got=" + current + " expected=" + first);
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    71
        }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    72
45220
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    73
        // for when exception is thrown
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    74
        current = lines[3].line_number;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    75
        if (current != first + 2) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    76
            throw new Exception("finally line number table incorrect: got=" + current + " expected=" + (first + 2));
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    77
        }
45220
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    78
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    79
        // the '}' closing the finally block
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    80
        current = lines[4].line_number;
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    81
        if (current != first + 3) {
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    82
            throw new Exception("finally line number table incorrect: got=" + current + " expected=" + (first + 3));
7c775294b6f1 8180660: missing LNT entry for finally block
vromero
parents: 33371
diff changeset
    83
        }
33371
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    84
    }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    85
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    86
    static Entry[] findEntries() throws IOException, ConstantPoolException {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    87
        ClassFile self = ClassFile.read(FinallyLineNumberTest.class.getResourceAsStream("FinallyLineNumberTest.class"));
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    88
        for (Method m : self.methods) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    89
            if ("method".equals(m.getName(self.constant_pool))) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    90
                Code_attribute code_attribute = (Code_attribute)m.attributes.get(Attribute.Code);
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    91
                for (Attribute at : code_attribute.attributes) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    92
                    if (Attribute.LineNumberTable.equals(at.getName(self.constant_pool))) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    93
                        return ((LineNumberTable_attribute)at).line_number_table;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    94
                    }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    95
                }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    96
            }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    97
        }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    98
        return null;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
    99
    }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   100
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   101
    // This method should get LineNumberTable entries for:
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   102
    // *) The load of the null
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   103
    // *) The finally code for when an exception is *not* thrown
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   104
    // *) The actual return, which should have the same line as the load of the null
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   105
    // *) The finally code for when an exception *is* thrown, should have the same line as above finally code
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   106
    public static String method(int field) {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   107
        try {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   108
            return null;
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   109
        } finally {
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   110
            field+=1; // Dummy
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   111
        }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   112
    }
b6f6281b4c07 8134759: jdb: Incorrect stepping inside finally block
aeriksso
parents:
diff changeset
   113
}