nashorn/src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/codegen/LocalVariableTypesCalculator.java
author attila
Wed, 28 Jan 2015 17:58:08 +0100
changeset 28690 78317797ab62
parent 28130 433d6755c5f8
child 29283 fb47e4d25a9f
permissions -rw-r--r--
8067139: Finally blocks inlined incorrectly Reviewed-by: hannesw, lagergren
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     1
/*
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     2
 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     4
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     7
 * published by the Free Software Foundation.  Oracle designates this
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     8
 * particular file as subject to the "Classpath" exception as provided
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
     9
 * by Oracle in the LICENSE file that accompanied this code.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    10
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    11
 * This code is distributed in the hope that it will be useful, but WITHOUT
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    12
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    13
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    14
 * version 2 for more details (a copy is included in the LICENSE file that
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    15
 * accompanied this code).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    16
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    17
 * You should have received a copy of the GNU General Public License version
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    18
 * 2 along with this work; if not, write to the Free Software Foundation,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    19
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    20
 *
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    21
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    22
 * or visit www.oracle.com if you need additional information or have any
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    23
 * questions.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    24
 */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    25
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    26
package jdk.nashorn.internal.codegen;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    27
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
    28
import static jdk.nashorn.internal.codegen.CompilerConstants.RETURN;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    29
import static jdk.nashorn.internal.ir.Expression.isAlwaysFalse;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    30
import static jdk.nashorn.internal.ir.Expression.isAlwaysTrue;
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
    31
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    32
import java.util.ArrayDeque;
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
    33
import java.util.ArrayList;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    34
import java.util.Collections;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    35
import java.util.Deque;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    36
import java.util.HashSet;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    37
import java.util.IdentityHashMap;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    38
import java.util.Iterator;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    39
import java.util.LinkedList;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    40
import java.util.List;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    41
import java.util.Map;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    42
import java.util.Set;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    43
import jdk.nashorn.internal.codegen.types.Type;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    44
import jdk.nashorn.internal.ir.AccessNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    45
import jdk.nashorn.internal.ir.BinaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    46
import jdk.nashorn.internal.ir.Block;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    47
import jdk.nashorn.internal.ir.BreakNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    48
import jdk.nashorn.internal.ir.BreakableNode;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    49
import jdk.nashorn.internal.ir.CallNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    50
import jdk.nashorn.internal.ir.CaseNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    51
import jdk.nashorn.internal.ir.CatchNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    52
import jdk.nashorn.internal.ir.ContinueNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    53
import jdk.nashorn.internal.ir.Expression;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    54
import jdk.nashorn.internal.ir.ExpressionStatement;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    55
import jdk.nashorn.internal.ir.ForNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    56
import jdk.nashorn.internal.ir.FunctionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    57
import jdk.nashorn.internal.ir.FunctionNode.CompilationState;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    58
import jdk.nashorn.internal.ir.GetSplitState;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    59
import jdk.nashorn.internal.ir.IdentNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    60
import jdk.nashorn.internal.ir.IfNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    61
import jdk.nashorn.internal.ir.IndexNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    62
import jdk.nashorn.internal.ir.JoinPredecessor;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    63
import jdk.nashorn.internal.ir.JoinPredecessorExpression;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    64
import jdk.nashorn.internal.ir.JumpStatement;
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
    65
import jdk.nashorn.internal.ir.JumpToInlinedFinally;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    66
import jdk.nashorn.internal.ir.LabelNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    67
import jdk.nashorn.internal.ir.LexicalContext;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    68
import jdk.nashorn.internal.ir.LexicalContextNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    69
import jdk.nashorn.internal.ir.LiteralNode;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    70
import jdk.nashorn.internal.ir.LiteralNode.ArrayLiteralNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    71
import jdk.nashorn.internal.ir.LocalVariableConversion;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    72
import jdk.nashorn.internal.ir.LoopNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    73
import jdk.nashorn.internal.ir.Node;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    74
import jdk.nashorn.internal.ir.ObjectNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    75
import jdk.nashorn.internal.ir.PropertyNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    76
import jdk.nashorn.internal.ir.ReturnNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    77
import jdk.nashorn.internal.ir.RuntimeNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    78
import jdk.nashorn.internal.ir.RuntimeNode.Request;
27206
d4a707c9db5a 8059844: Implement optimistic splitter
attila
parents: 26889
diff changeset
    79
import jdk.nashorn.internal.ir.SplitReturn;
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
    80
import jdk.nashorn.internal.ir.Statement;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    81
import jdk.nashorn.internal.ir.SwitchNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    82
import jdk.nashorn.internal.ir.Symbol;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    83
import jdk.nashorn.internal.ir.TernaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    84
import jdk.nashorn.internal.ir.ThrowNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    85
import jdk.nashorn.internal.ir.TryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    86
import jdk.nashorn.internal.ir.UnaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    87
import jdk.nashorn.internal.ir.VarNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    88
import jdk.nashorn.internal.ir.WhileNode;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
    89
import jdk.nashorn.internal.ir.WithNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    90
import jdk.nashorn.internal.ir.visitor.NodeVisitor;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    91
import jdk.nashorn.internal.parser.TokenType;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    92
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    93
/**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    94
 * Calculates types for local variables. For purposes of local variable type calculation, the only types used are
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    95
 * Undefined, boolean, int, long, double, and Object. The calculation eagerly widens types of local variable to their
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    96
 * widest at control flow join points.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    97
 * TODO: investigate a more sophisticated solution that uses use/def information to only widens the type of a local
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    98
 * variable to its widest used type after the join point. That would eliminate some widenings of undefined variables to
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
    99
 * object, most notably those used only in loops. We need a full liveness analysis for that. Currently, we can establish
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   100
 * per-type liveness, which eliminates most of unwanted dead widenings.
27972
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   101
 * NOTE: the way this class is implemented, it actually processes the AST in two passes. The first pass is top-down and
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   102
 * implemented in {@code enterXxx} methods. This pass does not mutate the AST (except for one occurrence, noted below),
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   103
 * as being able to find relevant labels for control flow joins is sensitive to their reference identity, and mutated
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   104
 * label-carrying nodes will create copies of their labels. A second bottom-up pass applying the changes is implemented
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   105
 * in the separate visitor sitting in {@link #leaveFunctionNode(FunctionNode)}. This visitor will also instantiate new
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   106
 * instances of the calculator to be run on nested functions (when not lazy compiling).
8ec664fdf8da 8066236: RuntimeNode forces copy creation on visitation
attila
parents: 27970
diff changeset
   107
 *
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   108
 */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   109
final class LocalVariableTypesCalculator extends NodeVisitor<LexicalContext>{
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   110
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   111
    private static class JumpOrigin {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   112
        final JoinPredecessor node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   113
        final Map<Symbol, LvarType> types;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   114
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   115
        JumpOrigin(final JoinPredecessor node, final Map<Symbol, LvarType> types) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   116
            this.node = node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   117
            this.types = types;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   118
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   119
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   120
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   121
    private static class JumpTarget {
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   122
        private final List<JumpOrigin> origins = new LinkedList<>();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   123
        private Map<Symbol, LvarType> types = Collections.emptyMap();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   124
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   125
        void addOrigin(final JoinPredecessor originNode, final Map<Symbol, LvarType> originTypes) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   126
            origins.add(new JumpOrigin(originNode, originTypes));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   127
            this.types = getUnionTypes(this.types, originTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   128
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   129
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   130
    private enum LvarType {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   131
        UNDEFINED(Type.UNDEFINED),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   132
        BOOLEAN(Type.BOOLEAN),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   133
        INT(Type.INT),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   134
        LONG(Type.LONG),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   135
        DOUBLE(Type.NUMBER),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   136
        OBJECT(Type.OBJECT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   137
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   138
        private final Type type;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   139
        private final TypeHolderExpression typeExpression;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   140
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   141
        private LvarType(final Type type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   142
            this.type = type;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   143
            this.typeExpression = new TypeHolderExpression(type);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   144
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   145
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   146
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   147
    /**
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   148
     * A bogus Expression subclass that only reports its type. Used to interrogate BinaryNode and UnaryNode about their
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   149
     * types by creating temporary copies of them and replacing their operands with instances of these. An alternative
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   150
     * solution would be to add BinaryNode.getType(Type lhsType, Type rhsType) and UnaryNode.getType(Type exprType)
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   151
     * methods. For the time being though, this is easier to implement and is in fact fairly clean. It does result in
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   152
     * generation of higher number of temporary short lived nodes, though.
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   153
     */
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   154
    private static class TypeHolderExpression extends Expression {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   155
        private static final long serialVersionUID = 1L;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   156
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   157
        private final Type type;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   158
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   159
        TypeHolderExpression(final Type type) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   160
            super(0L, 0, 0);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   161
            this.type = type;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   162
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   163
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   164
        @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   165
        public Node accept(final NodeVisitor<? extends LexicalContext> visitor) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   166
            throw new AssertionError();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   167
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   168
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   169
        @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   170
        public Type getType() {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   171
            return type;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   172
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   173
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   174
        @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   175
        public void toString(final StringBuilder sb, final boolean printType) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   176
            throw new AssertionError();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   177
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   178
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   179
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   180
    private static final Map<Type, LvarType> TO_LVAR_TYPE = new IdentityHashMap<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   181
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   182
    static {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   183
        for(final LvarType lvarType: LvarType.values()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   184
            TO_LVAR_TYPE.put(lvarType.type, lvarType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   185
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   186
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   187
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   188
    @SuppressWarnings("unchecked")
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   189
    private static IdentityHashMap<Symbol, LvarType> cloneMap(final Map<Symbol, LvarType> map) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   190
        return (IdentityHashMap<Symbol, LvarType>)((IdentityHashMap<?,?>)map).clone();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   191
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   192
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   193
    private LocalVariableConversion createConversion(final Symbol symbol, final LvarType branchLvarType,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   194
            final Map<Symbol, LvarType> joinLvarTypes, final LocalVariableConversion next) {
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   195
        final LvarType targetType = joinLvarTypes.get(symbol);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   196
        assert targetType != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   197
        if(targetType == branchLvarType) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   198
            return next;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   199
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   200
        // NOTE: we could naively just use symbolIsUsed(symbol, branchLvarType) here, but that'd be wrong. While
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   201
        // technically a conversion will read the value of the symbol with that type, but it will also write it to a new
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   202
        // type, and that type might be dead (we can't know yet). For this reason, we don't treat conversion reads as
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   203
        // real uses until we know their target type is live. If we didn't do this, and just did a symbolIsUsed here,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   204
        // we'd introduce false live variables which could nevertheless turn into dead ones in a subsequent
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   205
        // deoptimization, causing a shift in the list of live locals that'd cause erroneous restoration of
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   206
        // continuations (since RewriteException's byteCodeSlots carries an array and not a name-value map).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   207
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   208
        symbolIsConverted(symbol, branchLvarType, targetType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   209
        //symbolIsUsed(symbol, branchLvarType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   210
        return new LocalVariableConversion(symbol, branchLvarType.type, targetType.type, next);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   211
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   212
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   213
    private static Map<Symbol, LvarType> getUnionTypes(final Map<Symbol, LvarType> types1, final Map<Symbol, LvarType> types2) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   214
        if(types1 == types2 || types1.isEmpty()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   215
            return types2;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   216
        } else if(types2.isEmpty()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   217
            return types1;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   218
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   219
        final Set<Symbol> commonSymbols = new HashSet<>(types1.keySet());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   220
        commonSymbols.retainAll(types2.keySet());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   221
        // We have a chance of returning an unmodified set if both sets have the same keys and one is strictly wider
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   222
        // than the other.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   223
        final int commonSize = commonSymbols.size();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   224
        final int types1Size = types1.size();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   225
        final int types2Size = types2.size();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   226
        if(commonSize == types1Size && commonSize == types2Size) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   227
            boolean matches1 = true, matches2 = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   228
            Map<Symbol, LvarType> union = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   229
            for(final Symbol symbol: commonSymbols) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   230
                final LvarType type1 = types1.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   231
                final LvarType type2 = types2.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   232
                final LvarType widest = widestLvarType(type1,  type2);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   233
                if(widest != type1 && matches1) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   234
                    matches1 = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   235
                    if(!matches2) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   236
                        union = cloneMap(types1);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   237
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   238
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   239
                if (widest != type2 && matches2) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   240
                    matches2 = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   241
                    if(!matches1) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   242
                        union = cloneMap(types2);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   243
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   244
                }
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   245
                if(!(matches1 || matches2) && union != null) { //remove overly enthusiastic "union can be null" warning
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   246
                    assert union != null;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   247
                    union.put(symbol, widest);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   248
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   249
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   250
            return matches1 ? types1 : matches2 ? types2 : union;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   251
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   252
        // General case
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   253
        final Map<Symbol, LvarType> union;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   254
        if(types1Size > types2Size) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   255
            union = cloneMap(types1);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   256
            union.putAll(types2);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   257
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   258
            union = cloneMap(types2);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   259
            union.putAll(types1);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   260
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   261
        for(final Symbol symbol: commonSymbols) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   262
            final LvarType type1 = types1.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   263
            final LvarType type2 = types2.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   264
            union.put(symbol, widestLvarType(type1,  type2));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   265
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   266
        return union;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   267
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   268
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   269
    private static void symbolIsUsed(final Symbol symbol, final LvarType type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   270
        if(type != LvarType.UNDEFINED) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   271
            symbol.setHasSlotFor(type.type);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   272
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   273
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   274
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   275
    private static class SymbolConversions {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   276
        private static byte I2L = 1 << 0;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   277
        private static byte I2D = 1 << 1;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   278
        private static byte I2O = 1 << 2;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   279
        private static byte L2D = 1 << 3;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   280
        private static byte L2O = 1 << 4;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   281
        private static byte D2O = 1 << 5;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   282
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   283
        private byte conversions;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   284
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   285
        void recordConversion(final LvarType from, final LvarType to) {
27361
86c4ddb4797b 8060204: Fix warnings in Joni and tests
lagergren
parents: 27206
diff changeset
   286
            switch (from) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   287
            case UNDEFINED:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   288
                return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   289
            case INT:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   290
            case BOOLEAN:
27361
86c4ddb4797b 8060204: Fix warnings in Joni and tests
lagergren
parents: 27206
diff changeset
   291
                switch (to) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   292
                case LONG:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   293
                    recordConversion(I2L);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   294
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   295
                case DOUBLE:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   296
                    recordConversion(I2D);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   297
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   298
                case OBJECT:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   299
                    recordConversion(I2O);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   300
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   301
                default:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   302
                    illegalConversion(from, to);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   303
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   304
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   305
            case LONG:
27361
86c4ddb4797b 8060204: Fix warnings in Joni and tests
lagergren
parents: 27206
diff changeset
   306
                switch (to) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   307
                case DOUBLE:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   308
                    recordConversion(L2D);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   309
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   310
                case OBJECT:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   311
                    recordConversion(L2O);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   312
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   313
                default:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   314
                    illegalConversion(from, to);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   315
                    return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   316
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   317
            case DOUBLE:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   318
                if(to == LvarType.OBJECT) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   319
                    recordConversion(D2O);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   320
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   321
                return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   322
            default:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   323
                illegalConversion(from, to);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   324
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   325
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   326
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   327
        private static void illegalConversion(final LvarType from, final LvarType to) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   328
            throw new AssertionError("Invalid conversion from " + from + " to " + to);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   329
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   330
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   331
        void recordConversion(final byte convFlag) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   332
            conversions = (byte)(conversions | convFlag);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   333
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   334
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   335
        boolean hasConversion(final byte convFlag) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   336
            return (conversions & convFlag) != 0;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   337
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   338
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   339
        void calculateTypeLiveness(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   340
            if(symbol.hasSlotFor(Type.OBJECT)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   341
                if(hasConversion(D2O)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   342
                    symbol.setHasSlotFor(Type.NUMBER);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   343
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   344
                if(hasConversion(L2O)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   345
                    symbol.setHasSlotFor(Type.LONG);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   346
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   347
                if(hasConversion(I2O)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   348
                    symbol.setHasSlotFor(Type.INT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   349
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   350
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   351
            if(symbol.hasSlotFor(Type.NUMBER)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   352
                if(hasConversion(L2D)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   353
                    symbol.setHasSlotFor(Type.LONG);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   354
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   355
                if(hasConversion(I2D)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   356
                    symbol.setHasSlotFor(Type.INT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   357
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   358
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   359
            if(symbol.hasSlotFor(Type.LONG)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   360
                if(hasConversion(I2L)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   361
                    symbol.setHasSlotFor(Type.INT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   362
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   363
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   364
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   365
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   366
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   367
    private void symbolIsConverted(final Symbol symbol, final LvarType from, final LvarType to) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   368
        SymbolConversions conversions = symbolConversions.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   369
        if(conversions == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   370
            conversions = new SymbolConversions();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   371
            symbolConversions.put(symbol, conversions);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   372
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   373
        conversions.recordConversion(from, to);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   374
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   375
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   376
    private static LvarType toLvarType(final Type type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   377
        assert type != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   378
        final LvarType lvarType = TO_LVAR_TYPE.get(type);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   379
        if(lvarType != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   380
            return lvarType;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   381
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   382
        assert type.isObject();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   383
        return LvarType.OBJECT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   384
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   385
    private static LvarType widestLvarType(final LvarType t1, final LvarType t2) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   386
        if(t1 == t2) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   387
            return t1;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   388
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   389
        // Undefined or boolean to anything always widens to object.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   390
        if(t1.ordinal() < LvarType.INT.ordinal() || t2.ordinal() < LvarType.INT.ordinal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   391
            return LvarType.OBJECT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   392
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   393
        // NOTE: we allow "widening" of long to double even though it can lose precision. ECMAScript doesn't have an
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   394
        // Int64 type anyway, so this loss of precision is actually more conformant to the specification...
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   395
        return LvarType.values()[Math.max(t1.ordinal(), t2.ordinal())];
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   396
    }
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   397
    private final Compiler compiler;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   398
    private final Map<Label, JumpTarget> jumpTargets = new IdentityHashMap<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   399
    // Local variable type mapping at the currently evaluated point. No map instance is ever modified; setLvarType() always
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   400
    // allocates a new map. Immutability of maps allows for cheap snapshots by just keeping the reference to the current
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   401
    // value.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   402
    private Map<Symbol, LvarType> localVariableTypes = new IdentityHashMap<>();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   403
    // Stack for evaluated expression types.
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   404
    private final Deque<LvarType> typeStack = new ArrayDeque<>();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   405
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   406
    // Whether the current point in the AST is reachable code
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   407
    private boolean reachable = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   408
    // Return type of the function
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   409
    private Type returnType = Type.UNKNOWN;
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
   410
    // Synthetic return node that we must insert at the end of the function if it's end is reachable.
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
   411
    private ReturnNode syntheticReturn;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   412
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   413
    private boolean alreadyEnteredTopLevelFunction;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   414
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   415
    // LvarType and conversion information gathered during the top-down pass; applied to nodes in the bottom-up pass.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   416
    private final Map<JoinPredecessor, LocalVariableConversion> localVariableConversions = new IdentityHashMap<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   417
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   418
    private final Map<IdentNode, LvarType> identifierLvarTypes = new IdentityHashMap<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   419
    private final Map<Symbol, SymbolConversions> symbolConversions = new IdentityHashMap<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   420
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   421
    // Stack of open labels for starts of catch blocks, one for every currently traversed try block; for inserting
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   422
    // control flow edges to them. Note that we currently don't insert actual control flow edges, but instead edges that
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   423
    // help us with type calculations. This means that some operations that can result in an exception being thrown
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   424
    // aren't considered (function calls, side effecting property getters and setters etc.), while some operations that
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   425
    // don't result in control flow transfers do originate an edge to the catch blocks (namely, assignments to local
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   426
    // variables).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   427
    private final Deque<Label> catchLabels = new ArrayDeque<>();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   428
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   429
    LocalVariableTypesCalculator(final Compiler compiler) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   430
        super(new LexicalContext());
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   431
        this.compiler = compiler;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   432
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   433
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   434
    private JumpTarget createJumpTarget(final Label label) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   435
        assert !jumpTargets.containsKey(label);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   436
        final JumpTarget jumpTarget = new JumpTarget();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   437
        jumpTargets.put(label, jumpTarget);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   438
        return jumpTarget;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   439
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   440
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   441
    private void doesNotContinueSequentially() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   442
        reachable = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   443
        localVariableTypes = Collections.emptyMap();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   444
        assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   445
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   446
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   447
    private boolean pushExpressionType(final Expression expr) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   448
        typeStack.push(toLvarType(expr.getType()));
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   449
        return false;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   450
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   451
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   452
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   453
    public boolean enterAccessNode(final AccessNode accessNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   454
        visitExpression(accessNode.getBase());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   455
        return pushExpressionType(accessNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   456
    }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   457
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   458
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   459
    public boolean enterBinaryNode(final BinaryNode binaryNode) {
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   460
        // NOTE: regardless of operator's lexical associativity, lhs is always evaluated first.
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   461
        final Expression lhs = binaryNode.lhs();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   462
        final LvarType lhsType;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   463
        if (!(lhs instanceof IdentNode && binaryNode.tokenType() == TokenType.ASSIGN)) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   464
            lhsType = visitExpression(lhs);
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   465
        } else {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   466
            // Can't visit IdentNode on LHS of a simple assignment, as visits imply use, and this is def.
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   467
            // The type is irrelevant, as only RHS is used to determine the type anyway.
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   468
            lhsType = LvarType.UNDEFINED;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   469
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   470
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   471
        final boolean isLogical = binaryNode.isLogical();
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   472
        final Label joinLabel = isLogical ? new Label("") : null;
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   473
        if(isLogical) {
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   474
            jumpToLabel((JoinPredecessor)lhs, joinLabel);
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   475
        }
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   476
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   477
        final Expression rhs = binaryNode.rhs();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   478
        final LvarType rhsType = visitExpression(rhs);
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   479
        if(isLogical) {
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   480
            jumpToLabel((JoinPredecessor)rhs, joinLabel);
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   481
        }
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   482
        joinOnLabel(joinLabel);
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
   483
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   484
        final LvarType type = toLvarType(binaryNode.setOperands(lhsType.typeExpression, rhsType.typeExpression).getType());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   485
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   486
        if(binaryNode.isAssignment() && lhs instanceof IdentNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   487
            if(binaryNode.isSelfModifying()) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   488
                onSelfAssignment((IdentNode)lhs, type);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   489
            } else {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   490
                onAssignment((IdentNode)lhs, type);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   491
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   492
        }
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   493
        typeStack.push(type);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   494
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   495
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   496
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   497
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   498
    public boolean enterBlock(final Block block) {
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   499
        for(final Symbol symbol: block.getSymbols()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   500
            if(symbol.isBytecodeLocal() && getLocalVariableTypeOrNull(symbol) == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   501
                setType(symbol, LvarType.UNDEFINED);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   502
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   503
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   504
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   505
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   506
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   507
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   508
    public boolean enterBreakNode(final BreakNode breakNode) {
26889
dba314d7a634 8059371: Code duplication in handling of break and continue
attila
parents: 26766
diff changeset
   509
        return enterJumpStatement(breakNode);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   510
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   511
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   512
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   513
    public boolean enterCallNode(final CallNode callNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   514
        visitExpression(callNode.getFunction());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   515
        visitExpressions(callNode.getArgs());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   516
        final CallNode.EvalArgs evalArgs = callNode.getEvalArgs();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   517
        if (evalArgs != null) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   518
            visitExpressions(evalArgs.getArgs());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   519
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   520
        return pushExpressionType(callNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   521
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   522
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   523
    @Override
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   524
    public boolean enterContinueNode(final ContinueNode continueNode) {
26889
dba314d7a634 8059371: Code duplication in handling of break and continue
attila
parents: 26766
diff changeset
   525
        return enterJumpStatement(continueNode);
dba314d7a634 8059371: Code duplication in handling of break and continue
attila
parents: 26766
diff changeset
   526
    }
dba314d7a634 8059371: Code duplication in handling of break and continue
attila
parents: 26766
diff changeset
   527
dba314d7a634 8059371: Code duplication in handling of break and continue
attila
parents: 26766
diff changeset
   528
    private boolean enterJumpStatement(final JumpStatement jump) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   529
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   530
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   531
        }
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   532
        assertTypeStackIsEmpty();
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   533
        jumpToLabel(jump, jump.getTargetLabel(lc), getBreakTargetTypes(jump.getPopScopeLimit(lc)));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   534
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   535
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   536
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   537
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   538
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   539
    protected boolean enterDefault(final Node node) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   540
        return reachable;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   541
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   542
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   543
    private void enterDoWhileLoop(final WhileNode loopNode) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   544
        assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   545
        final JoinPredecessorExpression test = loopNode.getTest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   546
        final Block body = loopNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   547
        final Label continueLabel = loopNode.getContinueLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   548
        final Label breakLabel = loopNode.getBreakLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   549
        final Map<Symbol, LvarType> beforeLoopTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   550
        final Label repeatLabel = new Label("");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   551
        for(;;) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   552
            jumpToLabel(loopNode, repeatLabel, beforeLoopTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   553
            final Map<Symbol, LvarType> beforeRepeatTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   554
            body.accept(this);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   555
            if(reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   556
                jumpToLabel(body, continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   557
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   558
            joinOnLabel(continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   559
            if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   560
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   561
            }
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   562
            visitExpressionOnEmptyStack(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   563
            jumpToLabel(test, breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   564
            if(isAlwaysFalse(test)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   565
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   566
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   567
            jumpToLabel(test, repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   568
            joinOnLabel(repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   569
            if(localVariableTypes.equals(beforeRepeatTypes)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   570
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   571
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   572
            resetJoinPoint(continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   573
            resetJoinPoint(breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   574
            resetJoinPoint(repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   575
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   576
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   577
        if(isAlwaysTrue(test)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   578
            doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   579
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   580
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   581
        leaveBreakable(loopNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   582
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   583
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   584
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   585
    public boolean enterExpressionStatement(final ExpressionStatement expressionStatement) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   586
        if (reachable) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   587
            visitExpressionOnEmptyStack(expressionStatement.getExpression());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   588
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   589
        return false;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   590
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   591
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   592
    private void assertTypeStackIsEmpty() {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   593
        assert typeStack.isEmpty();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   594
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   595
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   596
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   597
    protected Node leaveDefault(final Node node) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   598
        assert !(node instanceof Expression); // All expressions were handled
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   599
        assert !(node instanceof Statement) || typeStack.isEmpty(); // No statements leave with a non-empty stack
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   600
        return node;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   601
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   602
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   603
    private LvarType visitExpressionOnEmptyStack(final Expression expr) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   604
        assertTypeStackIsEmpty();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   605
        return visitExpression(expr);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   606
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   607
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   608
    private LvarType visitExpression(final Expression expr) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   609
        final int stackSize = typeStack.size();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   610
        expr.accept(this);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   611
        assert typeStack.size() == stackSize + 1;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   612
        return typeStack.pop();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   613
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   614
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   615
    private void visitExpressions(final List<Expression> exprs) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   616
        for(final Expression expr: exprs) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   617
            if (expr != null) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   618
                visitExpression(expr);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   619
            }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   620
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   621
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   622
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   623
    @Override
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   624
    public boolean enterForNode(final ForNode forNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   625
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   626
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   627
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   628
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   629
        final Expression init = forNode.getInit();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   630
        if(forNode.isForIn()) {
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   631
            final JoinPredecessorExpression iterable = forNode.getModify();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   632
            visitExpression(iterable);
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   633
            enterTestFirstLoop(forNode, null, init,
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   634
                    // If we're iterating over property names, and we can discern from the runtime environment
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   635
                    // of the compilation that the object being iterated over must use strings for property
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   636
                    // names (e.g., it is a native JS object or array), then we'll not bother trying to treat
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   637
                    // the property names optimistically.
26766
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
   638
                    !compiler.useOptimisticTypes() || (!forNode.isForEach() && compiler.hasStringPropertyIterator(iterable.getExpression())));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   639
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   640
            if(init != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   641
                visitExpressionOnEmptyStack(init);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   642
            }
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   643
            enterTestFirstLoop(forNode, forNode.getModify(), null, false);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   644
        }
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   645
        assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   646
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   647
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   648
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   649
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   650
    public boolean enterFunctionNode(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   651
        if(alreadyEnteredTopLevelFunction) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   652
            typeStack.push(LvarType.OBJECT);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   653
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   654
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   655
        int pos = 0;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   656
        if(!functionNode.isVarArg()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   657
            for (final IdentNode param : functionNode.getParameters()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   658
                final Symbol symbol = param.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   659
                // Parameter is not necessarily bytecode local as it can be scoped due to nested context use, but it
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   660
                // must have a slot if we aren't in a function with vararg signature.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   661
                assert symbol.hasSlot();
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
   662
                final Type callSiteParamType = compiler.getParamType(functionNode, pos);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   663
                final LvarType paramType = callSiteParamType == null ? LvarType.OBJECT : toLvarType(callSiteParamType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   664
                setType(symbol, paramType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   665
                // Make sure parameter slot for its incoming value is not marked dead. NOTE: this is a heuristic. Right
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   666
                // now, CodeGenerator.expandParameters() relies on the fact that every parameter's final slot width will
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   667
                // be at least the same as incoming width, therefore even if a parameter is never read, we'll still keep
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   668
                // its slot.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   669
                symbolIsUsed(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   670
                setIdentifierLvarType(param, paramType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   671
                pos++;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   672
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   673
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   674
        setCompilerConstantAsObject(functionNode, CompilerConstants.THIS);
25238
28476bdc25ce 8047728: (function(x){var o={x:0}; with(o){delete x} return o.x})() evaluates to 0 instead of undefined
sundar
parents: 25234
diff changeset
   675
25240
f92c14b1ca11 8047959: bindings created for declarations in eval code are not mutable
sundar
parents: 25238
diff changeset
   676
        // TODO: coarse-grained. If we wanted to solve it completely precisely,
25238
28476bdc25ce 8047728: (function(x){var o={x:0}; with(o){delete x} return o.x})() evaluates to 0 instead of undefined
sundar
parents: 25234
diff changeset
   677
        // we'd also need to push/pop its type when handling WithNode (so that
28476bdc25ce 8047728: (function(x){var o={x:0}; with(o){delete x} return o.x})() evaluates to 0 instead of undefined
sundar
parents: 25234
diff changeset
   678
        // it can go back to undefined after a 'with' block.
28476bdc25ce 8047728: (function(x){var o={x:0}; with(o){delete x} return o.x})() evaluates to 0 instead of undefined
sundar
parents: 25234
diff changeset
   679
        if(functionNode.hasScopeBlock() || functionNode.needsParentScope()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   680
            setCompilerConstantAsObject(functionNode, CompilerConstants.SCOPE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   681
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   682
        if(functionNode.needsCallee()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   683
            setCompilerConstantAsObject(functionNode, CompilerConstants.CALLEE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   684
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   685
        if(functionNode.needsArguments()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   686
            setCompilerConstantAsObject(functionNode, CompilerConstants.ARGUMENTS);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   687
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   688
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   689
        alreadyEnteredTopLevelFunction = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   690
        return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   691
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   692
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   693
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   694
    public boolean enterGetSplitState(final GetSplitState getSplitState) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   695
        return pushExpressionType(getSplitState);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   696
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   697
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   698
    @Override
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   699
    public boolean enterIdentNode(final IdentNode identNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   700
        final Symbol symbol = identNode.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   701
        if(symbol.isBytecodeLocal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   702
            symbolIsUsed(symbol);
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   703
            final LvarType type = getLocalVariableType(symbol);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   704
            setIdentifierLvarType(identNode, type);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   705
            typeStack.push(type);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   706
        } else {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   707
            pushExpressionType(identNode);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   708
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   709
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   710
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   711
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   712
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   713
    public boolean enterIfNode(final IfNode ifNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   714
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   715
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   716
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   717
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   718
        final Expression test = ifNode.getTest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   719
        final Block pass = ifNode.getPass();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   720
        final Block fail = ifNode.getFail();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   721
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   722
        visitExpressionOnEmptyStack(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   723
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   724
        final Map<Symbol, LvarType> afterTestLvarTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   725
        if(!isAlwaysFalse(test)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   726
            pass.accept(this);
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   727
            assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   728
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   729
        final Map<Symbol, LvarType> passLvarTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   730
        final boolean reachableFromPass = reachable;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   731
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   732
        reachable = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   733
        localVariableTypes = afterTestLvarTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   734
        if(!isAlwaysTrue(test) && fail != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   735
            fail.accept(this);
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   736
            assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   737
            final boolean reachableFromFail = reachable;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   738
            reachable |= reachableFromPass;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   739
            if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   740
                return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   741
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   742
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   743
            if(reachableFromFail) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   744
                if(reachableFromPass) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   745
                    final Map<Symbol, LvarType> failLvarTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   746
                    localVariableTypes = getUnionTypes(passLvarTypes, failLvarTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   747
                    setConversion(pass, passLvarTypes, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   748
                    setConversion(fail, failLvarTypes, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   749
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   750
                return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   751
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   752
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   753
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   754
        if(reachableFromPass) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   755
            localVariableTypes = getUnionTypes(afterTestLvarTypes, passLvarTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   756
            // IfNode itself is associated with conversions that might need to be performed after the test if there's no
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   757
            // else branch. E.g.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   758
            // if(x = 1, cond) { x = 1.0 } must widen "x = 1" to a double.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   759
            setConversion(pass, passLvarTypes, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   760
            setConversion(ifNode, afterTestLvarTypes, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   761
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   762
            localVariableTypes = afterTestLvarTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   763
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   764
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   765
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   766
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   767
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   768
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   769
    public boolean enterIndexNode(final IndexNode indexNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   770
        visitExpression(indexNode.getBase());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   771
        visitExpression(indexNode.getIndex());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   772
        return pushExpressionType(indexNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   773
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   774
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   775
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   776
    public boolean enterJoinPredecessorExpression(final JoinPredecessorExpression joinExpr) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   777
        final Expression expr = joinExpr.getExpression();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   778
        if (expr != null) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   779
            expr.accept(this);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   780
        } else {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   781
            typeStack.push(LvarType.UNDEFINED);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   782
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   783
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   784
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   785
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   786
    @Override
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   787
    public boolean enterJumpToInlinedFinally(final JumpToInlinedFinally jumpToInlinedFinally) {
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   788
        return enterJumpStatement(jumpToInlinedFinally);
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   789
    }
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   790
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
   791
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   792
    public boolean enterLiteralNode(final LiteralNode<?> literalNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   793
        if (literalNode instanceof ArrayLiteralNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   794
            final List<Expression> expressions = ((ArrayLiteralNode)literalNode).getElementExpressions();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   795
            if (expressions != null) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   796
                visitExpressions(expressions);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   797
            }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   798
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   799
        pushExpressionType(literalNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   800
        return false;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   801
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   802
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   803
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   804
    public boolean enterObjectNode(final ObjectNode objectNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   805
        for(final PropertyNode propertyNode: objectNode.getElements()) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   806
            // Avoid falsely adding property keys to the control flow graph
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   807
            final Expression value = propertyNode.getValue();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   808
            if (value != null) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   809
                visitExpression(value);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   810
            }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   811
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   812
        return pushExpressionType(objectNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   813
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   814
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   815
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   816
    public boolean enterPropertyNode(final PropertyNode propertyNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   817
        // Property nodes are only accessible through object literals, and we handled that case above
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   818
        throw new AssertionError();
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   819
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   820
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   821
    @Override
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   822
    public boolean enterReturnNode(final ReturnNode returnNode) {
26766
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
   823
        if(!reachable) {
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
   824
            return false;
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
   825
        }
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
   826
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   827
        final Expression returnExpr = returnNode.getExpression();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   828
        final Type returnExprType;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   829
        if(returnExpr != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   830
            returnExprType = visitExpressionOnEmptyStack(returnExpr).type;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   831
        } else {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   832
            assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   833
            returnExprType = Type.UNDEFINED;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   834
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   835
        returnType = Type.widestReturnType(returnType, returnExprType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   836
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   837
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   838
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   839
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   840
    @Override
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   841
    public boolean enterRuntimeNode(final RuntimeNode runtimeNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   842
        visitExpressions(runtimeNode.getArgs());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   843
        return pushExpressionType(runtimeNode);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   844
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   845
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   846
    @Override
27206
d4a707c9db5a 8059844: Implement optimistic splitter
attila
parents: 26889
diff changeset
   847
    public boolean enterSplitReturn(final SplitReturn splitReturn) {
d4a707c9db5a 8059844: Implement optimistic splitter
attila
parents: 26889
diff changeset
   848
        doesNotContinueSequentially();
d4a707c9db5a 8059844: Implement optimistic splitter
attila
parents: 26889
diff changeset
   849
        return false;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   850
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   851
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   852
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   853
    public boolean enterSwitchNode(final SwitchNode switchNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   854
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   855
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   856
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   857
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   858
        visitExpressionOnEmptyStack(switchNode.getExpression());
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   859
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   860
        final List<CaseNode> cases = switchNode.getCases();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   861
        if(cases.isEmpty()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   862
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   863
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   864
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   865
        // Control flow is different for all-integer cases where we dispatch by switch table, and for all other cases
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   866
        // where we do sequential comparison. Note that CaseNode objects act as join points.
27970
7b0048b90967 8066225: NPE in MethodEmitter with duplicate integer switch cases
attila
parents: 27969
diff changeset
   867
        final boolean isInteger = switchNode.isUniqueInteger();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   868
        final Label breakLabel = switchNode.getBreakLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   869
        final boolean hasDefault = switchNode.getDefaultCase() != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   870
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   871
        boolean tagUsed = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   872
        for(final CaseNode caseNode: cases) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   873
            final Expression test = caseNode.getTest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   874
            if(!isInteger && test != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   875
                visitExpressionOnEmptyStack(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   876
                if(!tagUsed) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   877
                    symbolIsUsed(switchNode.getTag(), LvarType.OBJECT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   878
                    tagUsed = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   879
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   880
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   881
            // CaseNode carries the conversions that need to be performed on its entry from the test.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   882
            // CodeGenerator ensures these are only emitted when arriving on the branch and not through a
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   883
            // fallthrough.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   884
            jumpToLabel(caseNode, caseNode.getBody().getEntryLabel());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   885
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   886
        if(!hasDefault) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   887
            // No default case means we can arrive at the break label without entering any cases. In that case
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   888
            // SwitchNode will carry the conversions that need to be performed before it does that jump.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   889
            jumpToLabel(switchNode, breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   890
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   891
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   892
        // All cases are arrived at through jumps
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   893
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   894
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   895
        Block previousBlock = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   896
        for(final CaseNode caseNode: cases) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   897
            final Block body = caseNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   898
            final Label entryLabel = body.getEntryLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   899
            if(previousBlock != null && reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   900
                jumpToLabel(previousBlock, entryLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   901
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   902
            joinOnLabel(entryLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   903
            assert reachable == true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   904
            body.accept(this);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   905
            previousBlock = body;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   906
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   907
        if(previousBlock != null && reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   908
            jumpToLabel(previousBlock, breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   909
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   910
        leaveBreakable(switchNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   911
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   912
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   913
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   914
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   915
    public boolean enterTernaryNode(final TernaryNode ternaryNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   916
        final Expression test = ternaryNode.getTest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   917
        final Expression trueExpr = ternaryNode.getTrueExpression();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   918
        final Expression falseExpr = ternaryNode.getFalseExpression();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   919
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   920
        visitExpression(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   921
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   922
        final Map<Symbol, LvarType> testExitLvarTypes = localVariableTypes;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   923
        final LvarType trueType;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   924
        if(!isAlwaysFalse(test)) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   925
            trueType = visitExpression(trueExpr);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   926
        } else {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   927
            trueType = null;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   928
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   929
        final Map<Symbol, LvarType> trueExitLvarTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   930
        localVariableTypes = testExitLvarTypes;
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   931
        final LvarType falseType;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   932
        if(!isAlwaysTrue(test)) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   933
            falseType = visitExpression(falseExpr);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   934
        } else {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   935
            falseType = null;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   936
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   937
        final Map<Symbol, LvarType> falseExitLvarTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   938
        localVariableTypes = getUnionTypes(trueExitLvarTypes, falseExitLvarTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   939
        setConversion((JoinPredecessor)trueExpr, trueExitLvarTypes, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   940
        setConversion((JoinPredecessor)falseExpr, falseExitLvarTypes, localVariableTypes);
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   941
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   942
        typeStack.push(trueType != null ? falseType != null ? widestLvarType(trueType, falseType) : trueType : assertNotNull(falseType));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   943
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   944
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   945
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   946
    private static <T> T assertNotNull(final T t) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   947
        assert t != null;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   948
        return t;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   949
    }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   950
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   951
    private void enterTestFirstLoop(final LoopNode loopNode, final JoinPredecessorExpression modify,
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   952
            final Expression iteratorValues, final boolean iteratorValuesAreObject) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   953
        final JoinPredecessorExpression test = loopNode.getTest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   954
        if(isAlwaysFalse(test)) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   955
            visitExpressionOnEmptyStack(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   956
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   957
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   958
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   959
        final Label continueLabel = loopNode.getContinueLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   960
        final Label breakLabel = loopNode.getBreakLabel();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   961
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   962
        final Label repeatLabel = modify == null ? continueLabel : new Label("");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   963
        final Map<Symbol, LvarType> beforeLoopTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   964
        for(;;) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   965
            jumpToLabel(loopNode, repeatLabel, beforeLoopTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   966
            final Map<Symbol, LvarType> beforeRepeatTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   967
            if(test != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   968
                visitExpressionOnEmptyStack(test);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   969
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   970
            if(!isAlwaysTrue(test)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   971
                jumpToLabel(test, breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   972
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   973
            if(iteratorValues instanceof IdentNode) {
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   974
                final IdentNode ident = (IdentNode)iteratorValues;
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   975
                // Receives iterator values; the optimistic type of the iterator values is tracked on the
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   976
                // identifier, but we override optimism if it's known that the object being iterated over will
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   977
                // never have primitive property names.
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   978
                onAssignment(ident, iteratorValuesAreObject ? LvarType.OBJECT :
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
   979
                    toLvarType(compiler.getOptimisticType(ident)));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   980
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   981
            final Block body = loopNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   982
            body.accept(this);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   983
            if(reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   984
                jumpToLabel(body, continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   985
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   986
            joinOnLabel(continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   987
            if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   988
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   989
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   990
            if(modify != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
   991
                visitExpressionOnEmptyStack(modify);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   992
                jumpToLabel(modify, repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   993
                joinOnLabel(repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   994
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   995
            if(localVariableTypes.equals(beforeRepeatTypes)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   996
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   997
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   998
            // Reset the join points and repeat the analysis
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
   999
            resetJoinPoint(continueLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1000
            resetJoinPoint(breakLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1001
            resetJoinPoint(repeatLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1002
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1003
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1004
        if(isAlwaysTrue(test) && iteratorValues == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1005
            doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1006
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1007
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1008
        leaveBreakable(loopNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1009
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1010
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1011
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1012
    public boolean enterThrowNode(final ThrowNode throwNode) {
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1013
        if(!reachable) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1014
            return false;
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1015
        }
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1016
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1017
        visitExpressionOnEmptyStack(throwNode.getExpression());
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1018
        jumpToCatchBlock(throwNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1019
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1020
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1021
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1022
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1023
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1024
    public boolean enterTryNode(final TryNode tryNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1025
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1026
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1027
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1028
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1029
        // This is the label for the join point at the entry of the catch blocks.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1030
        final Label catchLabel = new Label("");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1031
        catchLabels.push(catchLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1032
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1033
        // Presume that even the start of the try block can immediately go to the catch
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1034
        jumpToLabel(tryNode, catchLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1035
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1036
        final Block body = tryNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1037
        body.accept(this);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1038
        catchLabels.pop();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1039
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1040
        // Final exit label for the whole try/catch construct (after the try block and after all catches).
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1041
        final Label endLabel = new Label("");
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1042
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1043
        boolean canExit = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1044
        if(reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1045
            jumpToLabel(body, endLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1046
            canExit = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1047
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1048
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1049
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1050
        for (final Block inlinedFinally : tryNode.getInlinedFinallies()) {
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1051
            final Block finallyBody = TryNode.getLabelledInlinedFinallyBlock(inlinedFinally);
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1052
            joinOnLabel(finallyBody.getEntryLabel());
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1053
            // NOTE: the jump to inlined finally can end up in dead code, so it is not necessarily reachable.
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1054
            if (reachable) {
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1055
                finallyBody.accept(this);
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1056
                // All inlined finallies end with a jump or a return
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1057
                assert !reachable;
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1058
            }
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1059
        }
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1060
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1061
        joinOnLabel(catchLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1062
        for(final CatchNode catchNode: tryNode.getCatches()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1063
            final IdentNode exception = catchNode.getException();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1064
            onAssignment(exception, LvarType.OBJECT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1065
            final Expression condition = catchNode.getExceptionCondition();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1066
            if(condition != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1067
                visitExpression(condition);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1068
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1069
            final Map<Symbol, LvarType> afterConditionTypes = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1070
            final Block catchBody = catchNode.getBody();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1071
            // TODO: currently, we consider that the catch blocks are always reachable from the try block as currently
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1072
            // we lack enough analysis to prove that no statement before a break/continue/return in the try block can
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1073
            // throw an exception.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1074
            reachable = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1075
            catchBody.accept(this);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1076
            final Symbol exceptionSymbol = exception.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1077
            if(reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1078
                localVariableTypes = cloneMap(localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1079
                localVariableTypes.remove(exceptionSymbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1080
                jumpToLabel(catchBody, endLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1081
                canExit = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1082
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1083
            localVariableTypes = cloneMap(afterConditionTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1084
            localVariableTypes.remove(exceptionSymbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1085
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1086
        // NOTE: if we had one or more conditional catch blocks with no unconditional catch block following them, then
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1087
        // there will be an unconditional rethrow, so the join point can never be reached from the last
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1088
        // conditionExpression.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1089
        doesNotContinueSequentially();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1090
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1091
        if(canExit) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1092
            joinOnLabel(endLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1093
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1094
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1095
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1096
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1097
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1098
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1099
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1100
    public boolean enterUnaryNode(final UnaryNode unaryNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1101
        final Expression expr = unaryNode.getExpression();
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1102
        final LvarType unaryType = toLvarType(unaryNode.setExpression(visitExpression(expr).typeExpression).getType());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1103
        if(unaryNode.isSelfModifying() && expr instanceof IdentNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1104
            onSelfAssignment((IdentNode)expr, unaryType);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1105
        }
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1106
        typeStack.push(unaryType);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1107
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1108
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1109
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1110
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1111
    public boolean enterVarNode(final VarNode varNode) {
26766
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
  1112
        if (!reachable) {
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
  1113
            return false;
523242aab20f 8058561: NPE in LocalVariableTypesCalculator
attila
parents: 26507
diff changeset
  1114
        }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1115
        final Expression init = varNode.getInit();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1116
        if(init != null) {
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1117
            onAssignment(varNode.getName(), visitExpression(init));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1118
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1119
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1120
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1121
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1122
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1123
    public boolean enterWhileNode(final WhileNode whileNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1124
        if(!reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1125
            return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1126
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1127
        if(whileNode.isDoWhile()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1128
            enterDoWhileLoop(whileNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1129
        } else {
26507
9d6e3ec59878 8034954: Optimistic iteration in for-in and for-each
attila
parents: 25865
diff changeset
  1130
            enterTestFirstLoop(whileNode, null, null, false);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1131
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1132
        return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1133
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1134
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1135
    @Override
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1136
    public boolean enterWithNode(final WithNode withNode) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1137
        if (reachable) {
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1138
            visitExpression(withNode.getExpression());
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1139
            withNode.getBody().accept(this);
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1140
        }
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1141
        return false;
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1142
    };
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1143
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1144
    private Map<Symbol, LvarType> getBreakTargetTypes(final LexicalContextNode target) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1145
        // Remove symbols defined in the the blocks that are being broken out of.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1146
        Map<Symbol, LvarType> types = localVariableTypes;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1147
        for(final Iterator<LexicalContextNode> it = lc.getAllNodes(); it.hasNext();) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1148
            final LexicalContextNode node = it.next();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1149
            if(node instanceof Block) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1150
                for(final Symbol symbol: ((Block)node).getSymbols()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1151
                    if(localVariableTypes.containsKey(symbol)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1152
                        if(types == localVariableTypes) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1153
                            types = cloneMap(localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1154
                        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1155
                        types.remove(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1156
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1157
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1158
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1159
            if(node == target) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1160
                break;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1161
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1162
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1163
        return types;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1164
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1165
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1166
    /**
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1167
     * Returns the current type of the local variable represented by the symbol. This is the most strict of all
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1168
     * {@code getLocalVariableType*} methods, as it will throw an assertion if the type is null. Therefore, it is only
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1169
     * safe to be invoked on symbols known to be bytecode locals, and only after they have been initialized.
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1170
     * Regardless, it is recommended to use this method in majority of cases, as because of its strictness it is the
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1171
     * best suited for catching missing type calculation bugs early.
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1172
     * @param symbol a symbol representing a bytecode local variable.
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1173
     * @return the current type of the local variable represented by the symbol
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1174
     */
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1175
    private LvarType getLocalVariableType(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1176
        final LvarType type = getLocalVariableTypeOrNull(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1177
        assert type != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1178
        return type;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1179
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1180
27969
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1181
    /**
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1182
     * Gets the type for a variable represented by a symbol, or null if the type is not know. This is the least strict
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1183
     * of all local variable type getters, and as such its use is discouraged except in initialization scenarios (where
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1184
     * a just-defined symbol might still be null).
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1185
     * @param symbol the symbol
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1186
     * @return the current type for the symbol, or null if the type is not known either because the symbol has not been
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1187
     * initialized, or because the symbol does not represent a bytecode local variable.
c03b64ccbd0f 8066227: CodeGenerator load unitialized slot
attila
parents: 27361
diff changeset
  1188
     */
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1189
    private LvarType getLocalVariableTypeOrNull(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1190
        return localVariableTypes.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1191
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1192
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1193
    private JumpTarget getOrCreateJumpTarget(final Label label) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1194
        JumpTarget jumpTarget = jumpTargets.get(label);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1195
        if(jumpTarget == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1196
            jumpTarget = createJumpTarget(label);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1197
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1198
        return jumpTarget;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1199
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1200
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1201
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1202
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1203
     * If there's a join point associated with a label, insert the join point into the flow.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1204
     * @param label the label to insert a join point for.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1205
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1206
    private void joinOnLabel(final Label label) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1207
        final JumpTarget jumpTarget = jumpTargets.remove(label);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1208
        if(jumpTarget == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1209
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1210
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1211
        assert !jumpTarget.origins.isEmpty();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1212
        reachable = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1213
        localVariableTypes = getUnionTypes(jumpTarget.types, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1214
        for(final JumpOrigin jumpOrigin: jumpTarget.origins) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1215
            setConversion(jumpOrigin.node, jumpOrigin.types, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1216
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1217
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1218
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1219
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1220
     * If we're in a try/catch block, add an edge from the specified node to the try node's pre-catch label.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1221
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1222
    private void jumpToCatchBlock(final JoinPredecessor jumpOrigin) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1223
        final Label currentCatchLabel = catchLabels.peek();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1224
        if(currentCatchLabel != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1225
            jumpToLabel(jumpOrigin, currentCatchLabel);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1226
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1227
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1228
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1229
    private void jumpToLabel(final JoinPredecessor jumpOrigin, final Label label) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1230
        jumpToLabel(jumpOrigin, label, localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1231
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1232
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1233
    private void jumpToLabel(final JoinPredecessor jumpOrigin, final Label label, final Map<Symbol, LvarType> types) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1234
        getOrCreateJumpTarget(label).addOrigin(jumpOrigin, types);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1235
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1236
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1237
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1238
    public Node leaveBlock(final Block block) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1239
        if(lc.isFunctionBody()) {
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1240
            if(reachable) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1241
                // reachable==true means we can reach the end of the function without an explicit return statement. We
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1242
                // need to insert a synthetic one then. This logic used to be in Lower.leaveBlock(), but Lower's
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1243
                // reachability analysis (through Terminal.isTerminal() flags) is not precise enough so
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1244
                // Lower$BlockLexicalContext.afterSetStatements will sometimes think the control flow terminates even
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1245
                // when it didn't. Example: function() { switch((z)) { default: {break; } throw x; } }.
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1246
                createSyntheticReturn(block);
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1247
                assert !reachable;
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1248
            }
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1249
            // We must calculate the return type here (and not in leaveFunctionNode) as it can affect the liveness of
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1250
            // the :return symbol and thus affect conversion type liveness calculations for it.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1251
            calculateReturnType();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1252
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1253
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1254
        boolean cloned = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1255
        for(final Symbol symbol: block.getSymbols()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1256
            // Undefine the symbol outside the block
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1257
            if(localVariableTypes.containsKey(symbol)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1258
                if(!cloned) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1259
                    localVariableTypes = cloneMap(localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1260
                    cloned = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1261
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1262
                localVariableTypes.remove(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1263
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1264
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1265
            if(symbol.hasSlot()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1266
                final SymbolConversions conversions = symbolConversions.get(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1267
                if(conversions != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1268
                    // Potentially make some currently dead types live if they're needed as a source of a type
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1269
                    // conversion at a join.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1270
                    conversions.calculateTypeLiveness(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1271
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1272
                if(symbol.slotCount() == 0) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1273
                    // This is a local variable that is never read. It won't need a slot.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1274
                    symbol.setNeedsSlot(false);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1275
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1276
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1277
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1278
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1279
        if(reachable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1280
            // TODO: this is totally backwards. Block should not be breakable, LabelNode should be breakable.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1281
            final LabelNode labelNode = lc.getCurrentBlockLabelNode();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1282
            if(labelNode != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1283
                jumpToLabel(labelNode, block.getBreakLabel());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1284
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1285
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1286
        leaveBreakable(block);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1287
        return block;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1288
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1289
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1290
    private void calculateReturnType() {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1291
        // NOTE: if return type is unknown, then the function does not explicitly return a value. Such a function under
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1292
        // ECMAScript rules returns Undefined, which has Type.OBJECT. We might consider an optimization in the future
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1293
        // where we can return void functions.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1294
        if(returnType.isUnknown()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1295
            returnType = Type.OBJECT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1296
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1297
    }
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1298
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1299
    private void createSyntheticReturn(final Block body) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1300
        final FunctionNode functionNode = lc.getCurrentFunction();
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1301
        final long token = functionNode.getToken();
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1302
        final int finish = functionNode.getFinish();
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1303
        final List<Statement> statements = body.getStatements();
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1304
        final int lineNumber = statements.isEmpty() ? functionNode.getLineNumber() : statements.get(statements.size() - 1).getLineNumber();
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1305
        final IdentNode returnExpr;
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1306
        if(functionNode.isProgram()) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1307
            returnExpr = new IdentNode(token, finish, RETURN.symbolName()).setSymbol(getCompilerConstantSymbol(functionNode, RETURN));
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1308
        } else {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1309
            returnExpr = null;
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1310
        }
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1311
        syntheticReturn = new ReturnNode(lineNumber, token, finish, returnExpr);
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1312
        syntheticReturn.accept(this);
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1313
    }
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1314
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1315
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1316
     * Leave a breakable node. If there's a join point associated with its break label (meaning there was at least one
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1317
     * break statement to the end of the node), insert the join point into the flow.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1318
     * @param breakable the breakable node being left.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1319
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1320
    private void leaveBreakable(final BreakableNode breakable) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1321
        joinOnLabel(breakable.getBreakLabel());
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1322
        assertTypeStackIsEmpty();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1323
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1324
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1325
    @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1326
    public Node leaveFunctionNode(final FunctionNode functionNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1327
        // Sets the return type of the function and also performs the bottom-up pass of applying type and conversion
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1328
        // information to nodes as well as doing the calculation on nested functions as required.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1329
        FunctionNode newFunction = functionNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1330
        final NodeVisitor<LexicalContext> applyChangesVisitor = new NodeVisitor<LexicalContext>(new LexicalContext()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1331
            private boolean inOuterFunction = true;
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1332
            private final Deque<JoinPredecessor> joinPredecessors = new ArrayDeque<>();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1333
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1334
            @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1335
            protected boolean enterDefault(final Node node) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1336
                if(!inOuterFunction) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1337
                    return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1338
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1339
                if(node instanceof JoinPredecessor) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1340
                    joinPredecessors.push((JoinPredecessor)node);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1341
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1342
                return inOuterFunction;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1343
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1344
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1345
            @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1346
            public boolean enterFunctionNode(final FunctionNode fn) {
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1347
                if(compiler.isOnDemandCompilation()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1348
                    // Only calculate nested function local variable types if we're doing eager compilation
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1349
                    return false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1350
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1351
                inOuterFunction = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1352
                return true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1353
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1354
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1355
            @SuppressWarnings("fallthrough")
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1356
            @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1357
            public Node leaveBinaryNode(final BinaryNode binaryNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1358
                if(binaryNode.isComparison()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1359
                    final Expression lhs = binaryNode.lhs();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1360
                    final Expression rhs = binaryNode.rhs();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1361
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1362
                    Type cmpWidest = Type.widest(lhs.getType(), rhs.getType());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1363
                    boolean newRuntimeNode = false, finalized = false;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1364
                    final TokenType tt = binaryNode.tokenType();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1365
                    switch (tt) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1366
                    case EQ_STRICT:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1367
                    case NE_STRICT:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1368
                        // Specialize comparison with undefined
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1369
                        final Expression undefinedNode = createIsUndefined(binaryNode, lhs, rhs,
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1370
                                tt == TokenType.EQ_STRICT ? Request.IS_UNDEFINED : Request.IS_NOT_UNDEFINED);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1371
                        if(undefinedNode != binaryNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1372
                            return undefinedNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1373
                        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1374
                        // Specialize comparison of boolean with non-boolean
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1375
                        if (lhs.getType().isBoolean() != rhs.getType().isBoolean()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1376
                            newRuntimeNode = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1377
                            cmpWidest = Type.OBJECT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1378
                            finalized = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1379
                        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1380
                        // fallthrough
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1381
                    default:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1382
                        if (newRuntimeNode || cmpWidest.isObject()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1383
                            return new RuntimeNode(binaryNode).setIsFinal(finalized);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1384
                        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1385
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1386
                } else if(binaryNode.isOptimisticUndecidedType()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1387
                    // At this point, we can assign a static type to the optimistic binary ADD operator as now we know
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1388
                    // the types of its operands.
25829
1a5e1de71e57 8051439: Wrong type calculated for ADD operator with undefined operand
attila
parents: 25249
diff changeset
  1389
                    return binaryNode.decideType();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1390
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1391
                return binaryNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1392
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1393
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1394
            @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1395
            protected Node leaveDefault(final Node node) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1396
                if(node instanceof JoinPredecessor) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1397
                    final JoinPredecessor original = joinPredecessors.pop();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1398
                    assert original.getClass() == node.getClass() : original.getClass().getName() + "!=" + node.getClass().getName();
28690
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1399
                    final JoinPredecessor newNode = setLocalVariableConversion(original, (JoinPredecessor)node);
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1400
                    if (newNode instanceof LexicalContextNode) {
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1401
                        lc.replace((LexicalContextNode)node, (LexicalContextNode)newNode);
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1402
                    }
78317797ab62 8067139: Finally blocks inlined incorrectly
attila
parents: 28130
diff changeset
  1403
                    return (Node)newNode;
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1404
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1405
                return node;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1406
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1407
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1408
            @Override
25244
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1409
            public Node leaveBlock(final Block block) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1410
                if(inOuterFunction && syntheticReturn != null && lc.isFunctionBody()) {
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1411
                    final ArrayList<Statement> stmts = new ArrayList<>(block.getStatements());
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1412
                    stmts.add((ReturnNode)syntheticReturn.accept(this));
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1413
                    return block.setStatements(lc, stmts);
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1414
                }
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1415
                return super.leaveBlock(block);
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1416
            }
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1417
627d7e86f3b5 8047357: More precise synthetic return + unreachable throw
attila
parents: 25240
diff changeset
  1418
            @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1419
            public Node leaveFunctionNode(final FunctionNode nestedFunctionNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1420
                inOuterFunction = true;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1421
                final FunctionNode newNestedFunction = (FunctionNode)nestedFunctionNode.accept(
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1422
                        new LocalVariableTypesCalculator(compiler));
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1423
                lc.replace(nestedFunctionNode, newNestedFunction);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1424
                return newNestedFunction;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1425
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1426
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1427
            @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1428
            public Node leaveIdentNode(final IdentNode identNode) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1429
                final IdentNode original = (IdentNode)joinPredecessors.pop();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1430
                final Symbol symbol = identNode.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1431
                if(symbol == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1432
                    assert identNode.isPropertyName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1433
                    return identNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1434
                } else if(symbol.hasSlot()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1435
                    assert !symbol.isScope() || symbol.isParam(); // Only params can be slotted and scoped.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1436
                    assert original.getName().equals(identNode.getName());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1437
                    final LvarType lvarType = identifierLvarTypes.remove(original);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1438
                    if(lvarType != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1439
                        return setLocalVariableConversion(original, identNode.setType(lvarType.type));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1440
                    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1441
                    // If there's no type, then the identifier must've been in unreachable code. In that case, it can't
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1442
                    // have assigned conversions either.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1443
                    assert localVariableConversions.get(original) == null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1444
                } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1445
                    assert identIsDeadAndHasNoLiveConversions(original);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1446
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1447
                return identNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1448
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1449
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1450
            @Override
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1451
            public Node leaveLiteralNode(final LiteralNode<?> literalNode) {
25234
e2f9df6b8797 8047078: Fuzzing bug discovered when ArrayLiteralNodes weren't immutable
lagergren
parents: 24759
diff changeset
  1452
                //for e.g. ArrayLiteralNodes the initial types may have been narrowed due to the
e2f9df6b8797 8047078: Fuzzing bug discovered when ArrayLiteralNodes weren't immutable
lagergren
parents: 24759
diff changeset
  1453
                //introduction of optimistic behavior - hence ensure that all literal nodes are
e2f9df6b8797 8047078: Fuzzing bug discovered when ArrayLiteralNodes weren't immutable
lagergren
parents: 24759
diff changeset
  1454
                //reinitialized
e2f9df6b8797 8047078: Fuzzing bug discovered when ArrayLiteralNodes weren't immutable
lagergren
parents: 24759
diff changeset
  1455
                return literalNode.initialize(lc);
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1456
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1457
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1458
            @Override
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1459
            public Node leaveRuntimeNode(final RuntimeNode runtimeNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1460
                final Request request = runtimeNode.getRequest();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1461
                final boolean isEqStrict = request == Request.EQ_STRICT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1462
                if(isEqStrict || request == Request.NE_STRICT) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1463
                    return createIsUndefined(runtimeNode, runtimeNode.getArgs().get(0), runtimeNode.getArgs().get(1),
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1464
                            isEqStrict ? Request.IS_UNDEFINED : Request.IS_NOT_UNDEFINED);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1465
                }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1466
                return runtimeNode;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1467
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1468
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1469
            @SuppressWarnings("unchecked")
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1470
            private <T extends JoinPredecessor> T setLocalVariableConversion(final JoinPredecessor original, final T jp) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1471
                // NOTE: can't use Map.remove() as our copy-on-write AST semantics means some nodes appear twice (in
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1472
                // finally blocks), so we need to be able to access conversions for them multiple times.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1473
                return (T)jp.setLocalVariableConversion(lc, localVariableConversions.get(original));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1474
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1475
        };
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1476
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1477
        newFunction = newFunction.setBody(lc, (Block)newFunction.getBody().accept(applyChangesVisitor));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1478
        newFunction = newFunction.setReturnType(lc, returnType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1479
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1480
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1481
        newFunction = newFunction.setState(lc, CompilationState.LOCAL_VARIABLE_TYPES_CALCULATED);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1482
        newFunction = newFunction.setParameters(lc, newFunction.visitParameters(applyChangesVisitor));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1483
        return newFunction;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1484
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1485
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1486
    private static Expression createIsUndefined(final Expression parent, final Expression lhs, final Expression rhs, final Request request) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1487
        if (isUndefinedIdent(lhs) || isUndefinedIdent(rhs)) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1488
            return new RuntimeNode(parent, request, lhs, rhs);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1489
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1490
        return parent;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1491
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1492
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1493
    private static boolean isUndefinedIdent(final Expression expr) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1494
        return expr instanceof IdentNode && "undefined".equals(((IdentNode)expr).getName());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1495
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1496
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1497
    private boolean identIsDeadAndHasNoLiveConversions(final IdentNode identNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1498
        final LocalVariableConversion conv = localVariableConversions.get(identNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1499
        return conv == null || !conv.isLive();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1500
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1501
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1502
    private void onAssignment(final IdentNode identNode, final LvarType type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1503
        final Symbol symbol = identNode.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1504
        assert symbol != null : identNode.getName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1505
        if(!symbol.isBytecodeLocal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1506
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1507
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1508
        assert type != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1509
        final LvarType finalType;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1510
        if(type == LvarType.UNDEFINED && getLocalVariableType(symbol) != LvarType.UNDEFINED) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1511
            // Explicit assignment of a known undefined local variable to a local variable that is not undefined will
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1512
            // materialize that undefined in the assignment target. Note that assigning known undefined to known
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1513
            // undefined will *not* initialize the variable, e.g. "var x; var y = x;" compiles to no-op.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1514
            finalType = LvarType.OBJECT;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1515
            symbol.setFlag(Symbol.HAS_OBJECT_VALUE);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1516
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1517
            finalType = type;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1518
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1519
        setType(symbol, finalType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1520
        // Explicit assignment of an undefined value. Make sure the variable can store an object
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1521
        // TODO: if we communicated the fact to codegen with a flag on the IdentNode that the value was already
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1522
        // undefined before the assignment, we could just ignore it. In general, we could ignore an assignment if we
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1523
        // know that the value assigned is the same as the current value of the variable, but we'd need constant
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1524
        // propagation for that.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1525
        setIdentifierLvarType(identNode, finalType);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1526
        // For purposes of type calculation, we consider an assignment to a local variable to be followed by
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1527
        // the catch nodes of the current (if any) try block. This will effectively enforce that narrower
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1528
        // assignments to a local variable in a try block will also have to store a widened value as well. Code
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1529
        // within the try block will be able to keep loading the narrower value, but after the try block only
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1530
        // the widest value will remain live.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1531
        // Rationale for this is that if there's an use for that variable in any of the catch blocks, or
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1532
        // following the catch blocks, they must use the widest type.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1533
        // Example:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1534
        /*
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1535
            Originally:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1536
            ===========
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1537
            var x;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1538
            try {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1539
              x = 1; <-- stores into int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1540
              f(x); <-- loads the int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1541
              x = 3.14 <-- stores into the double slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1542
              f(x); <-- loads the double slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1543
              x = 1; <-- stores into int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1544
              f(x); <-- loads the int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1545
            } finally {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1546
              f(x); <-- loads the double slot for x, but can be reached by a path where x is int, so we need
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1547
                           to go back and ensure that double values are also always stored along with int
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1548
                           values.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1549
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1550
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1551
            After correction:
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1552
            =================
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1553
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1554
            var x;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1555
            try {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1556
              x = 1; <-- stores into both int and double slots for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1557
              f(x); <-- loads the int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1558
              x = 3.14 <-- stores into the double slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1559
              f(x); <-- loads the double slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1560
              x = 1; <-- stores into both int and double slots for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1561
              f(x); <-- loads the int slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1562
            } finally {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1563
              f(x); <-- loads the double slot for x
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1564
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1565
         */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1566
        jumpToCatchBlock(identNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1567
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1568
28130
433d6755c5f8 8067774: Use a stack of types when calculating local variable types
attila
parents: 27972
diff changeset
  1569
    private void onSelfAssignment(final IdentNode identNode, final LvarType type) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1570
        final Symbol symbol = identNode.getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1571
        assert symbol != null : identNode.getName();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1572
        if(!symbol.isBytecodeLocal()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1573
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1574
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1575
        // Self-assignment never produce either a boolean or undefined
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1576
        assert type != null && type != LvarType.UNDEFINED && type != LvarType.BOOLEAN;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1577
        setType(symbol, type);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1578
        jumpToCatchBlock(identNode);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1579
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1580
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1581
    private void resetJoinPoint(final Label label) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1582
        jumpTargets.remove(label);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1583
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1584
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1585
    private void setCompilerConstantAsObject(final FunctionNode functionNode, final CompilerConstants cc) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1586
        final Symbol symbol = getCompilerConstantSymbol(functionNode, cc);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1587
        setType(symbol, LvarType.OBJECT);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1588
        // never mark compiler constants as dead
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1589
        symbolIsUsed(symbol);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1590
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1591
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1592
    private static Symbol getCompilerConstantSymbol(final FunctionNode functionNode, final CompilerConstants cc) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1593
        return functionNode.getBody().getExistingSymbol(cc.symbolName());
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1594
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1595
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1596
    private void setConversion(final JoinPredecessor node, final Map<Symbol, LvarType> branchLvarTypes, final Map<Symbol, LvarType> joinLvarTypes) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1597
        if(node == null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1598
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1599
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1600
        if(branchLvarTypes.isEmpty() || joinLvarTypes.isEmpty()) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1601
            localVariableConversions.remove(node);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1602
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1603
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1604
        LocalVariableConversion conversion = null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1605
        if(node instanceof IdentNode) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1606
            // conversions on variable assignment in try block are special cases, as they only apply to the variable
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1607
            // being assigned and all other conversions should be ignored.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1608
            final Symbol symbol = ((IdentNode)node).getSymbol();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1609
            conversion = createConversion(symbol, branchLvarTypes.get(symbol), joinLvarTypes, null);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1610
        } else {
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1611
            for(final Map.Entry<Symbol, LvarType> entry: branchLvarTypes.entrySet()) {
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1612
                final Symbol symbol = entry.getKey();
24759
31aed7d9c02a 8034206: Make parts of code pipeline reusable in order to facilitate faster warmup and faster lazy compilation.
lagergren
parents: 24751
diff changeset
  1613
                final LvarType branchLvarType = entry.getValue();
24751
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1614
                conversion = createConversion(symbol, branchLvarType, joinLvarTypes, conversion);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1615
            }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1616
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1617
        if(conversion != null) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1618
            localVariableConversions.put(node, conversion);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1619
        } else {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1620
            localVariableConversions.remove(node);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1621
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1622
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1623
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1624
    private void setIdentifierLvarType(final IdentNode identNode, final LvarType type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1625
        assert type != null;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1626
        identifierLvarTypes.put(identNode, type);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1627
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1628
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1629
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1630
     * Marks a local variable as having a specific type from this point onward. Invoked by stores to local variables.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1631
     * @param symbol the symbol representing the variable
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1632
     * @param type the type
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1633
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1634
    private void setType(final Symbol symbol, final LvarType type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1635
        if(getLocalVariableTypeOrNull(symbol) == type) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1636
            return;
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1637
        }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1638
        assert symbol.hasSlot();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1639
        assert !symbol.isGlobal();
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1640
        localVariableTypes = localVariableTypes.isEmpty() ? new IdentityHashMap<Symbol, LvarType>() : cloneMap(localVariableTypes);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1641
        localVariableTypes.put(symbol, type);
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1642
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1643
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1644
    /**
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1645
     * Set a flag in the symbol marking it as needing to be able to store a value of a particular type. Every symbol for
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1646
     * a local variable will be assigned between 1 and 6 local variable slots for storing all types it is known to need
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1647
     * to store.
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1648
     * @param symbol the symbol
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1649
     */
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1650
    private void symbolIsUsed(final Symbol symbol) {
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1651
        symbolIsUsed(symbol, getLocalVariableType(symbol));
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1652
    }
ccbd9cd3f720 8042118: Separate types from symbols
attila
parents:
diff changeset
  1653
}