author | coleenp |
Thu, 18 May 2017 08:17:52 -0400 | |
changeset 46475 | 75902cea18af |
parent 46435 | 3f6cac9867d4 |
child 46488 | 01c282163d38 |
permissions | -rw-r--r-- |
1 | 1 |
/* |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
2 |
* Copyright (c) 2003, 2017, Oracle and/or its affiliates. All rights reserved. |
1 | 3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
5547
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1623
diff
changeset
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1623
diff
changeset
|
20 |
* or visit www.oracle.com if you need additional information or have any |
f4b087cbb361
6941466: Oracle rebranding changes for Hotspot repositories
trims
parents:
1623
diff
changeset
|
21 |
* questions. |
1 | 22 |
* |
23 |
*/ |
|
24 |
||
7397 | 25 |
#include "precompiled.hpp" |
13199
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
26 |
#include "classfile/altHashing.hpp" |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
27 |
#include "classfile/dictionary.hpp" |
35498
392b50de06c6
8146401: Clean up oop.hpp: add inline directives and fix header files
goetz
parents:
34257
diff
changeset
|
28 |
#include "classfile/javaClasses.inline.hpp" |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
29 |
#include "classfile/moduleEntry.hpp" |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
30 |
#include "classfile/packageEntry.hpp" |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
31 |
#include "classfile/protectionDomainCache.hpp" |
24426
0a69c8cdfca9
8038654: Separate SymbolTable and StringTable code
gziemski
parents:
23187
diff
changeset
|
32 |
#include "classfile/stringTable.hpp" |
7397 | 33 |
#include "memory/allocation.inline.hpp" |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
34 |
#include "memory/filemap.hpp" |
7397 | 35 |
#include "memory/resourceArea.hpp" |
36 |
#include "oops/oop.inline.hpp" |
|
37 |
#include "runtime/safepoint.hpp" |
|
38 |
#include "utilities/dtrace.hpp" |
|
39 |
#include "utilities/hashtable.hpp" |
|
40 |
#include "utilities/hashtable.inline.hpp" |
|
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
41 |
#include "utilities/numberSeq.hpp" |
1 | 42 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
43 |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
44 |
// This hashtable is implemented as an open hash table with a fixed number of buckets. |
1 | 45 |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
46 |
template <MEMFLAGS F> BasicHashtableEntry<F>* BasicHashtable<F>::new_entry_free_list() { |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
47 |
BasicHashtableEntry<F>* entry = NULL; |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
48 |
if (_free_list != NULL) { |
1 | 49 |
entry = _free_list; |
50 |
_free_list = _free_list->next(); |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
51 |
} |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
52 |
return entry; |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
53 |
} |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
54 |
|
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
55 |
// HashtableEntrys are allocated in blocks to reduce the space overhead. |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
56 |
template <MEMFLAGS F> BasicHashtableEntry<F>* BasicHashtable<F>::new_entry(unsigned int hashValue) { |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
57 |
BasicHashtableEntry<F>* entry = new_entry_free_list(); |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
58 |
|
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
59 |
if (entry == NULL) { |
1551 | 60 |
if (_first_free_entry + _entry_size >= _end_block) { |
61 |
int block_size = MIN2(512, MAX2((int)_table_size / 2, (int)_number_of_entries)); |
|
1 | 62 |
int len = _entry_size * block_size; |
1551 | 63 |
len = 1 << log2_intptr(len); // round down to power of 2 |
64 |
assert(len >= _entry_size, ""); |
|
13195 | 65 |
_first_free_entry = NEW_C_HEAP_ARRAY2(char, len, F, CURRENT_PC); |
1 | 66 |
_end_block = _first_free_entry + len; |
67 |
} |
|
13195 | 68 |
entry = (BasicHashtableEntry<F>*)_first_free_entry; |
1 | 69 |
_first_free_entry += _entry_size; |
70 |
} |
|
71 |
||
1551 | 72 |
assert(_entry_size % HeapWordSize == 0, ""); |
1 | 73 |
entry->set_hash(hashValue); |
74 |
return entry; |
|
75 |
} |
|
76 |
||
77 |
||
13195 | 78 |
template <class T, MEMFLAGS F> HashtableEntry<T, F>* Hashtable<T, F>::new_entry(unsigned int hashValue, T obj) { |
79 |
HashtableEntry<T, F>* entry; |
|
1 | 80 |
|
13195 | 81 |
entry = (HashtableEntry<T, F>*)BasicHashtable<F>::new_entry(hashValue); |
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
82 |
entry->set_literal(obj); |
1 | 83 |
return entry; |
84 |
} |
|
85 |
||
13087 | 86 |
// Check to see if the hashtable is unbalanced. The caller set a flag to |
87 |
// rehash at the next safepoint. If this bucket is 60 times greater than the |
|
88 |
// expected average bucket length, it's an unbalanced hashtable. |
|
89 |
// This is somewhat an arbitrary heuristic but if one bucket gets to |
|
90 |
// rehash_count which is currently 100, there's probably something wrong. |
|
91 |
||
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
92 |
template <class T, MEMFLAGS F> bool RehashableHashtable<T, F>::check_rehash_table(int count) { |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
93 |
assert(this->table_size() != 0, "underflow"); |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
94 |
if (count > (((double)this->number_of_entries()/(double)this->table_size())*rehash_multiple)) { |
13087 | 95 |
// Set a flag for the next safepoint, which should be at some guaranteed |
96 |
// safepoint interval. |
|
97 |
return true; |
|
98 |
} |
|
99 |
return false; |
|
100 |
} |
|
101 |
||
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
102 |
template <class T, MEMFLAGS F> juint RehashableHashtable<T, F>::_seed = 0; |
13199
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
103 |
|
13087 | 104 |
// Create a new table and using alternate hash code, populate the new table |
105 |
// with the existing elements. This can be used to change the hash code |
|
106 |
// and could in the future change the size of the table. |
|
107 |
||
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
108 |
template <class T, MEMFLAGS F> void RehashableHashtable<T, F>::move_to(RehashableHashtable<T, F>* new_table) { |
13199
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
109 |
|
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
110 |
// Initialize the global seed for hashing. |
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
111 |
_seed = AltHashing::compute_seed(); |
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
112 |
assert(seed() != 0, "shouldn't be zero"); |
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
113 |
|
025b0984feea
7181200: JVM new hashing code breaks SA in product mode
coleenp
parents:
13195
diff
changeset
|
114 |
int saved_entry_count = this->number_of_entries(); |
13087 | 115 |
|
116 |
// Iterate through the table and create a new entry for the new table |
|
117 |
for (int i = 0; i < new_table->table_size(); ++i) { |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
118 |
for (HashtableEntry<T, F>* p = this->bucket(i); p != NULL; ) { |
13195 | 119 |
HashtableEntry<T, F>* next = p->next(); |
13087 | 120 |
T string = p->literal(); |
121 |
// Use alternate hashing algorithm on the symbol in the first table |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13342
diff
changeset
|
122 |
unsigned int hashValue = string->new_hash(seed()); |
13087 | 123 |
// Get a new index relative to the new table (can also change size) |
124 |
int index = new_table->hash_to_index(hashValue); |
|
125 |
p->set_hash(hashValue); |
|
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
126 |
// Keep the shared bit in the Hashtable entry to indicate that this entry |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
127 |
// can't be deleted. The shared bit is the LSB in the _next field so |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
128 |
// walking the hashtable past these entries requires |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
129 |
// BasicHashtableEntry::make_ptr() call. |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
130 |
bool keep_shared = p->is_shared(); |
13342
76a5de64aa62
7186278: Build error after CR#6995781 / 7151532 with GCC 4.7.0
andrew
parents:
13199
diff
changeset
|
131 |
this->unlink_entry(p); |
13087 | 132 |
new_table->add_entry(index, p); |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
133 |
if (keep_shared) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
134 |
p->set_shared(); |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
135 |
} |
13087 | 136 |
p = next; |
137 |
} |
|
138 |
} |
|
139 |
// give the new table the free list as well |
|
140 |
new_table->copy_freelist(this); |
|
141 |
assert(new_table->number_of_entries() == saved_entry_count, "lost entry on dictionary copy?"); |
|
142 |
||
143 |
// Destroy memory used by the buckets in the hashtable. The memory |
|
144 |
// for the elements has been used in a new table and is not |
|
145 |
// destroyed. The memory reuse will benefit resizing the SystemDictionary |
|
146 |
// to avoid a memory allocation spike at safepoint. |
|
13195 | 147 |
BasicHashtable<F>::free_buckets(); |
13087 | 148 |
} |
149 |
||
13195 | 150 |
template <MEMFLAGS F> void BasicHashtable<F>::free_buckets() { |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
151 |
if (NULL != _buckets) { |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
152 |
// Don't delete the buckets in the shared space. They aren't |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
153 |
// allocated by os::malloc |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
154 |
if (!UseSharedSpaces || |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
155 |
!FileMapInfo::current_info()->is_in_shared_space(_buckets)) { |
27880
afb974a04396
8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents:
26422
diff
changeset
|
156 |
FREE_C_HEAP_ARRAY(HashtableBucket, _buckets); |
13097
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
157 |
} |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
158 |
_buckets = NULL; |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
159 |
} |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
160 |
} |
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
161 |
|
c146b608d91f
7178670: runtime/7158800/BadUtf8.java fails in SymbolTable::rehash_table
coleenp
parents:
13087
diff
changeset
|
162 |
|
1 | 163 |
// Copy the table to the shared space. |
164 |
||
13195 | 165 |
template <MEMFLAGS F> void BasicHashtable<F>::copy_table(char** top, char* end) { |
1 | 166 |
|
167 |
// Dump the hash table entries. |
|
168 |
||
169 |
intptr_t *plen = (intptr_t*)(*top); |
|
170 |
*top += sizeof(*plen); |
|
171 |
||
172 |
int i; |
|
173 |
for (i = 0; i < _table_size; ++i) { |
|
13195 | 174 |
for (BasicHashtableEntry<F>** p = _buckets[i].entry_addr(); |
1 | 175 |
*p != NULL; |
176 |
p = (*p)->next_addr()) { |
|
177 |
if (*top + entry_size() > end) { |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
178 |
report_out_of_shared_space(SharedMiscData); |
1 | 179 |
} |
13195 | 180 |
*p = (BasicHashtableEntry<F>*)memcpy(*top, *p, entry_size()); |
1 | 181 |
*top += entry_size(); |
182 |
} |
|
183 |
} |
|
184 |
*plen = (char*)(*top) - (char*)plen - sizeof(*plen); |
|
185 |
||
186 |
// Set the shared bit. |
|
187 |
||
188 |
for (i = 0; i < _table_size; ++i) { |
|
13195 | 189 |
for (BasicHashtableEntry<F>* p = bucket(i); p != NULL; p = p->next()) { |
1 | 190 |
p->set_shared(); |
191 |
} |
|
192 |
} |
|
193 |
} |
|
194 |
||
195 |
||
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
196 |
template <class T, MEMFLAGS F> int RehashableHashtable<T, F>::literal_size(Symbol *symbol) { |
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
197 |
return symbol->size() * HeapWordSize; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
198 |
} |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
199 |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
200 |
template <class T, MEMFLAGS F> int RehashableHashtable<T, F>::literal_size(oop oop) { |
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
201 |
// NOTE: this would over-count if (pre-JDK8) java_lang_Class::has_offset_field() is true, |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
202 |
// and the String.value array is shared by several Strings. However, starting from JDK8, |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
203 |
// the String.value array is not shared anymore. |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
204 |
assert(oop != NULL && oop->klass() == SystemDictionary::String_klass(), "only strings are supported"); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
205 |
return (oop->size() + java_lang_String::value(oop)->size()) * HeapWordSize; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
206 |
} |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
207 |
|
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
208 |
// Dump footprint and bucket length statistics |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
209 |
// |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
210 |
// Note: if you create a new subclass of Hashtable<MyNewType, F>, you will need to |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
211 |
// add a new function Hashtable<T, F>::literal_size(MyNewType lit) |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
212 |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
213 |
template <class T, MEMFLAGS F> void RehashableHashtable<T, F>::dump_table(outputStream* st, const char *table_name) { |
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
214 |
NumberSeq summary; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
215 |
int literal_bytes = 0; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
216 |
for (int i = 0; i < this->table_size(); ++i) { |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
217 |
int count = 0; |
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
218 |
for (HashtableEntry<T, F>* e = this->bucket(i); |
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
219 |
e != NULL; e = e->next()) { |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
220 |
count++; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
221 |
literal_bytes += literal_size(e->literal()); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
222 |
} |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
223 |
summary.add((double)count); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
224 |
} |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
225 |
double num_buckets = summary.num(); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
226 |
double num_entries = summary.sum(); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
227 |
|
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
228 |
int bucket_bytes = (int)num_buckets * sizeof(HashtableBucket<F>); |
17610
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
229 |
int entry_bytes = (int)num_entries * sizeof(HashtableEntry<T, F>); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
230 |
int total_bytes = literal_bytes + bucket_bytes + entry_bytes; |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
231 |
|
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
232 |
double bucket_avg = (num_buckets <= 0) ? 0 : (bucket_bytes / num_buckets); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
233 |
double entry_avg = (num_entries <= 0) ? 0 : (entry_bytes / num_entries); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
234 |
double literal_avg = (num_entries <= 0) ? 0 : (literal_bytes / num_entries); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
235 |
|
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
236 |
st->print_cr("%s statistics:", table_name); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
237 |
st->print_cr("Number of buckets : %9d = %9d bytes, avg %7.3f", (int)num_buckets, bucket_bytes, bucket_avg); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
238 |
st->print_cr("Number of entries : %9d = %9d bytes, avg %7.3f", (int)num_entries, entry_bytes, entry_avg); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
239 |
st->print_cr("Number of literals : %9d = %9d bytes, avg %7.3f", (int)num_entries, literal_bytes, literal_avg); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
240 |
st->print_cr("Total footprint : %9s = %9d bytes", "", total_bytes); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
241 |
st->print_cr("Average bucket size : %9.3f", summary.avg()); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
242 |
st->print_cr("Variance of bucket size : %9.3f", summary.variance()); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
243 |
st->print_cr("Std. dev. of bucket size: %9.3f", summary.sd()); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
244 |
st->print_cr("Maximum bucket size : %9d", (int)summary.maximum()); |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
245 |
} |
c6857feaac47
8014262: PrintStringTableStatistics should include more footprint info
iklam
parents:
13728
diff
changeset
|
246 |
|
1 | 247 |
|
248 |
// Dump the hash table buckets. |
|
249 |
||
13195 | 250 |
template <MEMFLAGS F> void BasicHashtable<F>::copy_buckets(char** top, char* end) { |
251 |
intptr_t len = _table_size * sizeof(HashtableBucket<F>); |
|
1 | 252 |
*(intptr_t*)(*top) = len; |
253 |
*top += sizeof(intptr_t); |
|
254 |
||
255 |
*(intptr_t*)(*top) = _number_of_entries; |
|
256 |
*top += sizeof(intptr_t); |
|
257 |
||
258 |
if (*top + len > end) { |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
259 |
report_out_of_shared_space(SharedMiscData); |
1 | 260 |
} |
13195 | 261 |
_buckets = (HashtableBucket<F>*)memcpy(*top, _buckets, len); |
1 | 262 |
*top += len; |
263 |
} |
|
264 |
||
265 |
||
266 |
#ifndef PRODUCT |
|
267 |
||
13195 | 268 |
template <class T, MEMFLAGS F> void Hashtable<T, F>::print() { |
1 | 269 |
ResourceMark rm; |
270 |
||
13195 | 271 |
for (int i = 0; i < BasicHashtable<F>::table_size(); i++) { |
272 |
HashtableEntry<T, F>* entry = bucket(i); |
|
1 | 273 |
while(entry != NULL) { |
274 |
tty->print("%d : ", i); |
|
275 |
entry->literal()->print(); |
|
276 |
tty->cr(); |
|
277 |
entry = entry->next(); |
|
278 |
} |
|
279 |
} |
|
280 |
} |
|
281 |
||
282 |
||
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
283 |
template <MEMFLAGS F> |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
284 |
template <class T> void BasicHashtable<F>::verify_table(const char* table_name) { |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
285 |
int element_count = 0; |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
286 |
int max_bucket_count = 0; |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
287 |
for (int index = 0; index < table_size(); index++) { |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
288 |
int bucket_count = 0; |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
289 |
for (T* probe = (T*)bucket(index); probe != NULL; probe = probe->next()) { |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
290 |
probe->verify(); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
291 |
bucket_count++; |
1 | 292 |
} |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
293 |
element_count += bucket_count; |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
294 |
max_bucket_count = MAX2(max_bucket_count, bucket_count); |
1 | 295 |
} |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
296 |
guarantee(number_of_entries() == element_count, |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
297 |
"Verify of %s failed", table_name); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
298 |
DEBUG_ONLY(verify_lookup_length(max_bucket_count, table_name)); |
1 | 299 |
} |
300 |
||
301 |
||
302 |
#endif // PRODUCT |
|
303 |
||
304 |
#ifdef ASSERT |
|
305 |
||
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
306 |
// Assert if the longest bucket is 10x longer than the average bucket size. |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
307 |
// Could change back to a warning, but warnings are not noticed. |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
308 |
template <MEMFLAGS F> void BasicHashtable<F>::verify_lookup_length(int max_bucket_count, const char *table_name) { |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
309 |
log_info(hashtables)("%s max bucket size %d element count %d table size %d", table_name, |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
310 |
max_bucket_count, _number_of_entries, _table_size); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
311 |
assert (max_bucket_count < ((1 + number_of_entries()/table_size())*10), "Table is unbalanced"); |
1 | 312 |
} |
313 |
||
314 |
#endif |
|
22921
ee35d5c0b1dc
8034839: jvm hangs with gc/gctests/LoadUnloadGC test
anoll
parents:
22757
diff
changeset
|
315 |
|
ee35d5c0b1dc
8034839: jvm hangs with gc/gctests/LoadUnloadGC test
anoll
parents:
22757
diff
changeset
|
316 |
|
8076
96d498ec7ae1
6990754: Use native memory and reference counting to implement SymbolTable
coleenp
parents:
7397
diff
changeset
|
317 |
// Explicitly instantiate these types |
26422 | 318 |
#if INCLUDE_ALL_GCS |
319 |
template class Hashtable<nmethod*, mtGC>; |
|
320 |
template class HashtableEntry<nmethod*, mtGC>; |
|
321 |
template class BasicHashtable<mtGC>; |
|
322 |
#endif |
|
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13342
diff
changeset
|
323 |
template class Hashtable<ConstantPool*, mtClass>; |
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
324 |
template class RehashableHashtable<Symbol*, mtSymbol>; |
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
325 |
template class RehashableHashtable<oopDesc*, mtSymbol>; |
13195 | 326 |
template class Hashtable<Symbol*, mtSymbol>; |
13728
882756847a04
6964458: Reimplement class meta-data storage to use native memory
coleenp
parents:
13342
diff
changeset
|
327 |
template class Hashtable<Klass*, mtClass>; |
34257
4be3504cc03b
8140802: Clean up and refactor of class loading code for CDS
iklam
parents:
30593
diff
changeset
|
328 |
template class Hashtable<InstanceKlass*, mtClass>; |
13195 | 329 |
template class Hashtable<oop, mtClass>; |
20282
7f9cbdf89af2
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
17610
diff
changeset
|
330 |
#if defined(SOLARIS) || defined(CHECK_UNHANDLED_OOPS) |
13195 | 331 |
template class Hashtable<oop, mtSymbol>; |
26421
37d88e604ad0
8056084: Refactor Hashtable to allow implementations without rehashing support
mgerdin
parents:
24426
diff
changeset
|
332 |
template class RehashableHashtable<oop, mtSymbol>; |
20282
7f9cbdf89af2
7195622: CheckUnhandledOops has limited usefulness now
hseigel
parents:
17610
diff
changeset
|
333 |
#endif // SOLARIS || CHECK_UNHANDLED_OOPS |
13195 | 334 |
template class Hashtable<oopDesc*, mtSymbol>; |
335 |
template class Hashtable<Symbol*, mtClass>; |
|
336 |
template class HashtableEntry<Symbol*, mtSymbol>; |
|
337 |
template class HashtableEntry<Symbol*, mtClass>; |
|
338 |
template class HashtableEntry<oop, mtSymbol>; |
|
339 |
template class BasicHashtableEntry<mtSymbol>; |
|
340 |
template class BasicHashtableEntry<mtCode>; |
|
341 |
template class BasicHashtable<mtClass>; |
|
34257
4be3504cc03b
8140802: Clean up and refactor of class loading code for CDS
iklam
parents:
30593
diff
changeset
|
342 |
template class BasicHashtable<mtClassShared>; |
13195 | 343 |
template class BasicHashtable<mtSymbol>; |
344 |
template class BasicHashtable<mtCode>; |
|
345 |
template class BasicHashtable<mtInternal>; |
|
38733 | 346 |
template class BasicHashtable<mtModule>; |
36384 | 347 |
#if INCLUDE_TRACE |
348 |
template class Hashtable<Symbol*, mtTracing>; |
|
349 |
template class HashtableEntry<Symbol*, mtTracing>; |
|
350 |
template class BasicHashtable<mtTracing>; |
|
351 |
#endif |
|
30593 | 352 |
template class BasicHashtable<mtCompiler>; |
46475
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
353 |
|
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
354 |
template void BasicHashtable<mtClass>::verify_table<DictionaryEntry>(char const*); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
355 |
template void BasicHashtable<mtModule>::verify_table<ModuleEntry>(char const*); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
356 |
template void BasicHashtable<mtModule>::verify_table<PackageEntry>(char const*); |
75902cea18af
8166848: Performance bug: SystemDictionary - optimization
coleenp
parents:
46435
diff
changeset
|
357 |
template void BasicHashtable<mtClass>::verify_table<ProtectionDomainCacheEntry>(char const*); |