author | herrick |
Fri, 18 Oct 2019 14:14:37 -0400 | |
branch | JDK-8200758-branch |
changeset 58696 | 61c44899b4eb |
parent 58695 | 64adf683bc7b |
child 58762 | 0fe62353385b |
permissions | -rw-r--r-- |
58648 | 1 |
/* |
2 |
* Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved. |
|
3 |
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
|
4 |
* |
|
5 |
* This code is free software; you can redistribute it and/or modify it |
|
6 |
* under the terms of the GNU General Public License version 2 only, as |
|
7 |
* published by the Free Software Foundation. |
|
8 |
* |
|
9 |
* This code is distributed in the hope that it will be useful, but WITHOUT |
|
10 |
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
|
11 |
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
|
12 |
* version 2 for more details (a copy is included in the LICENSE file that |
|
13 |
* accompanied this code). |
|
14 |
* |
|
15 |
* You should have received a copy of the GNU General Public License version |
|
16 |
* 2 along with this work; if not, write to the Free Software Foundation, |
|
17 |
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
|
18 |
* |
|
19 |
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
|
20 |
* or visit www.oracle.com if you need additional information or have any |
|
21 |
* questions. |
|
22 |
*/ |
|
23 |
||
24 |
package jdk.jpackage.tests; |
|
25 |
||
26 |
import java.io.IOException; |
|
27 |
import java.nio.file.Files; |
|
28 |
import java.util.Collection; |
|
29 |
import java.util.ArrayList; |
|
30 |
import java.util.List; |
|
31 |
import java.util.Set; |
|
32 |
import java.util.jar.JarFile; |
|
33 |
import java.util.Objects; |
|
34 |
import java.util.stream.Collectors; |
|
35 |
import java.util.stream.Stream; |
|
36 |
import java.nio.file.Path; |
|
37 |
import java.util.function.Predicate; |
|
38 |
import java.util.jar.JarEntry; |
|
39 |
import jdk.jpackage.test.Annotations.Parameters; |
|
40 |
import jdk.jpackage.test.Annotations.Test; |
|
41 |
import jdk.jpackage.test.*; |
|
42 |
import jdk.jpackage.test.Functional.ThrowingConsumer; |
|
43 |
import static jdk.jpackage.tests.MainClassTest.Script.MainClassType.*; |
|
44 |
||
45 |
||
46 |
/* |
|
47 |
* @test |
|
48 |
* @summary test different settings of main class name for jpackage |
|
49 |
* @library ../../../../helpers |
|
50 |
* @build jdk.jpackage.test.* |
|
51 |
* @modules jdk.jpackage/jdk.jpackage.internal |
|
52 |
* @compile MainClassTest.java |
|
53 |
* @run main/othervm/timeout=360 -Xmx512m jdk.jpackage.test.Main |
|
54 |
* --jpt-run=jdk.jpackage.tests.MainClassTest |
|
55 |
* --jpt-space-subst=_ |
|
56 |
*/ |
|
57 |
||
58 |
public final class MainClassTest { |
|
59 |
||
60 |
static final class Script { |
|
61 |
Script() { |
|
62 |
appDesc = JavaAppDesc.parse("test.Hello"); |
|
63 |
} |
|
64 |
||
65 |
Script modular(boolean v) { |
|
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
66 |
appDesc.setModuleName(v ? "com.other" : null); |
58648 | 67 |
return this; |
68 |
} |
|
69 |
||
70 |
Script withJLink(boolean v) { |
|
71 |
withJLink = v; |
|
72 |
return this; |
|
73 |
} |
|
74 |
||
75 |
Script withMainClass(MainClassType v) { |
|
76 |
mainClass = v; |
|
77 |
return this; |
|
78 |
} |
|
79 |
||
80 |
Script withJarMainClass(MainClassType v) { |
|
81 |
appDesc.setJarWithMainClass(v != NotSet); |
|
82 |
jarMainClass = v; |
|
83 |
return this; |
|
84 |
} |
|
85 |
||
86 |
Script expectedErrorMessage(String v) { |
|
87 |
expectedErrorMessage = v; |
|
88 |
return this; |
|
89 |
} |
|
90 |
||
91 |
@Override |
|
92 |
public String toString() { |
|
93 |
return Stream.of( |
|
94 |
format("modular", appDesc.moduleName() != null ? 'y' : 'n'), |
|
95 |
format("main-class", mainClass), |
|
96 |
format("jar-main-class", jarMainClass), |
|
97 |
format("jlink", withJLink ? 'y' : 'n'), |
|
98 |
format("error", expectedErrorMessage) |
|
99 |
).filter(Objects::nonNull).collect(Collectors.joining("; ")); |
|
100 |
} |
|
101 |
||
102 |
private static String format(String key, Object value) { |
|
103 |
if (value == null) { |
|
104 |
return null; |
|
105 |
} |
|
106 |
return String.join("=", key, value.toString()); |
|
107 |
} |
|
108 |
||
109 |
enum MainClassType { |
|
110 |
NotSet("n"), |
|
111 |
SetWrong("b"), |
|
112 |
SetRight("y"); |
|
113 |
||
114 |
MainClassType(String label) { |
|
115 |
this.label = label; |
|
116 |
} |
|
117 |
||
118 |
@Override |
|
119 |
public String toString() { |
|
120 |
return label; |
|
121 |
} |
|
122 |
||
123 |
private final String label; |
|
124 |
}; |
|
125 |
||
126 |
private JavaAppDesc appDesc; |
|
127 |
private boolean withJLink; |
|
128 |
private MainClassType mainClass; |
|
129 |
private MainClassType jarMainClass; |
|
130 |
private String expectedErrorMessage; |
|
131 |
} |
|
132 |
||
133 |
public MainClassTest(Script script) { |
|
134 |
this.script = script; |
|
135 |
||
136 |
nonExistingMainClass = Stream.of( |
|
137 |
script.appDesc.packageName(), "ThereIsNoSuchClass").filter( |
|
138 |
Objects::nonNull).collect(Collectors.joining(".")); |
|
139 |
||
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
140 |
cmd = JPackageCommand |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
141 |
.helloAppImage(script.appDesc) |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
142 |
.ignoreDefaultRuntime(true); |
58648 | 143 |
if (!script.withJLink) { |
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
144 |
cmd.addArguments("--runtime-image", Path.of(System.getProperty( |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
145 |
"java.home"))); |
58648 | 146 |
} |
147 |
||
148 |
final String moduleName = script.appDesc.moduleName(); |
|
149 |
switch (script.mainClass) { |
|
150 |
case NotSet: |
|
151 |
if (moduleName != null) { |
|
152 |
// Don't specify class name, only module name. |
|
153 |
cmd.setArgumentValue("--module", moduleName); |
|
154 |
} else { |
|
155 |
cmd.removeArgumentWithValue("--main-class"); |
|
156 |
} |
|
157 |
break; |
|
158 |
||
159 |
case SetWrong: |
|
160 |
if (moduleName != null) { |
|
161 |
cmd.setArgumentValue("--module", |
|
162 |
String.join("/", moduleName, nonExistingMainClass)); |
|
163 |
} else { |
|
164 |
cmd.setArgumentValue("--main-class", nonExistingMainClass); |
|
165 |
} |
|
166 |
} |
|
167 |
} |
|
168 |
||
169 |
@Parameters |
|
170 |
public static Collection scripts() { |
|
171 |
final var withMainClass = Set.of(SetWrong, SetRight); |
|
172 |
||
173 |
List<Script[]> scripts = new ArrayList<>(); |
|
174 |
for (var withJLink : List.of(true, false)) { |
|
175 |
for (var modular : List.of(true, false)) { |
|
176 |
for (var mainClass : Script.MainClassType.values()) { |
|
177 |
for (var jarMainClass : Script.MainClassType.values()) { |
|
178 |
Script script = new Script() |
|
179 |
.modular(modular) |
|
180 |
.withJLink(withJLink) |
|
181 |
.withMainClass(mainClass) |
|
182 |
.withJarMainClass(jarMainClass); |
|
183 |
||
184 |
if (withMainClass.contains(jarMainClass) |
|
185 |
|| withMainClass.contains(mainClass)) { |
|
186 |
} else if (modular) { |
|
187 |
script.expectedErrorMessage( |
|
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
188 |
"Error: Main application class is missing"); |
58648 | 189 |
} else { |
190 |
script.expectedErrorMessage( |
|
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
191 |
"A main class was not specified nor was one found in the jar"); |
58648 | 192 |
} |
193 |
||
194 |
scripts.add(new Script[]{script}); |
|
195 |
} |
|
196 |
} |
|
197 |
} |
|
198 |
} |
|
199 |
return scripts; |
|
200 |
} |
|
201 |
||
202 |
@Test |
|
203 |
public void test() throws IOException { |
|
204 |
if (script.jarMainClass == SetWrong) { |
|
205 |
initJarWithWrongMainClass(); |
|
206 |
} |
|
207 |
||
208 |
if (script.expectedErrorMessage != null) { |
|
209 |
// This is the case when main class is not found nor in jar |
|
210 |
// file nor on command line. |
|
211 |
List<String> output = cmd |
|
212 |
.saveConsoleOutput(true) |
|
213 |
.execute() |
|
214 |
.assertExitCodeIs(1) |
|
215 |
.getOutput(); |
|
216 |
TKit.assertTextStream(script.expectedErrorMessage).apply(output.stream()); |
|
217 |
return; |
|
218 |
} |
|
219 |
||
220 |
// Get here only if main class is specified. |
|
221 |
boolean appShouldSucceed = false; |
|
222 |
||
223 |
// Should succeed if valid main class is set on the command line. |
|
224 |
appShouldSucceed |= (script.mainClass == SetRight); |
|
225 |
||
226 |
// Should succeed if main class is not set on the command line but set |
|
227 |
// to valid value in the jar. |
|
228 |
appShouldSucceed |= (script.mainClass == NotSet && script.jarMainClass == SetRight); |
|
229 |
||
230 |
if (appShouldSucceed) { |
|
231 |
cmd.executeAndAssertHelloAppImageCreated(); |
|
232 |
} else { |
|
233 |
cmd.executeAndAssertImageCreated(); |
|
234 |
if (!cmd.isFakeRuntime(String.format("Not running [%s]", |
|
235 |
cmd.appLauncherPath()))) { |
|
236 |
List<String> output = new Executor() |
|
237 |
.setDirectory(cmd.outputDir()) |
|
238 |
.setExecutable(cmd.appLauncherPath()) |
|
239 |
.dumpOutput().saveOutput() |
|
240 |
.execute().assertExitCodeIs(1).getOutput(); |
|
241 |
TKit.assertTextStream(String.format( |
|
242 |
"Error: Could not find or load main class %s", |
|
243 |
nonExistingMainClass)).apply(output.stream()); |
|
244 |
} |
|
245 |
} |
|
246 |
} |
|
247 |
||
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
248 |
private void initJarWithWrongMainClass() throws IOException { |
58648 | 249 |
// Call JPackageCommand.executePrerequisiteActions() to build app's jar. |
250 |
// executePrerequisiteActions() is called by JPackageCommand instance |
|
251 |
// only once. |
|
252 |
cmd.executePrerequisiteActions(); |
|
253 |
||
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
254 |
final Path jarFile; |
58648 | 255 |
if (script.appDesc.moduleName() != null) { |
256 |
jarFile = Path.of(cmd.getArgumentValue("--module-path"), |
|
257 |
script.appDesc.jarFileName()); |
|
258 |
} else { |
|
259 |
jarFile = cmd.inputDir().resolve(cmd.getArgumentValue("--main-jar")); |
|
260 |
} |
|
261 |
||
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
262 |
// Create new jar file filtering out main class from the old jar file. |
58648 | 263 |
TKit.withTempDirectory("repack-jar", workDir -> { |
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
264 |
// Extract app's class from the old jar. |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
265 |
explodeJar(jarFile, workDir, |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
266 |
jarEntry -> Path.of(jarEntry.getName()).equals( |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
267 |
script.appDesc.classFilePath())); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
268 |
|
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
269 |
// Create app's jar file with different main class. |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
270 |
var badAppDesc = JavaAppDesc.parse(script.appDesc.toString()).setClassName( |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
271 |
nonExistingMainClass); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
272 |
JPackageCommand.helloAppImage(badAppDesc).executePrerequisiteActions(); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
273 |
|
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
274 |
// Extract new jar but skip app's class. |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
275 |
explodeJar(jarFile, workDir, |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
276 |
jarEntry -> !Path.of(jarEntry.getName()).equals( |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
277 |
badAppDesc.classFilePath())); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
278 |
|
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
279 |
// At this point we should have: |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
280 |
// 1. Manifest from the new jar referencing non-existing class |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
281 |
// as the main class. |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
282 |
// 2. Module descriptor referencing non-existing class as the main |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
283 |
// class in case of modular app. |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
284 |
// 3. App's class from the old jar. We need it to let jlink find some |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
285 |
// classes in the package declared in module descriptor |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
286 |
// in case of modular app. |
58648 | 287 |
|
288 |
Files.delete(jarFile); |
|
289 |
new Executor().setToolProvider(JavaTool.JAR) |
|
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
290 |
.addArguments("-v", "-c", "-M", "-f", jarFile.toString()) |
58648 | 291 |
.addArguments("-C", workDir.toString(), ".") |
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
292 |
.dumpOutput() |
58648 | 293 |
.execute().assertExitCodeIsZero(); |
294 |
}); |
|
295 |
} |
|
296 |
||
58696
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
297 |
private static void explodeJar(Path jarFile, Path workDir, |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
298 |
Predicate<JarEntry> filter) throws IOException { |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
299 |
try (var jar = new JarFile(jarFile.toFile())) { |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
300 |
jar.stream() |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
301 |
.filter(Predicate.not(JarEntry::isDirectory)) |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
302 |
.filter(filter) |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
303 |
.sequential().forEachOrdered(ThrowingConsumer.toConsumer( |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
304 |
jarEntry -> { |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
305 |
try (var in = jar.getInputStream(jarEntry)) { |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
306 |
Path fileName = workDir.resolve(jarEntry.getName()); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
307 |
Files.createDirectories(fileName.getParent()); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
308 |
Files.copy(in, fileName); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
309 |
} |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
310 |
})); |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
311 |
} |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
312 |
} |
61c44899b4eb
8223325: Improve wix sources generated by jpackage
herrick
parents:
58695
diff
changeset
|
313 |
|
58648 | 314 |
private final JPackageCommand cmd; |
315 |
private final Script script; |
|
316 |
private final String nonExistingMainClass; |
|
317 |
} |