hotspot/test/compiler/rtm/locking/TestRTMAbortRatio.java
author iignatyev
Fri, 11 Apr 2014 00:35:23 +0400
changeset 24006 54399106938f
child 25958 8dc85547d6d6
permissions -rw-r--r--
8037860: Add tests to cover Intel RTM instructions support Reviewed-by: kvn, iignatyev Contributed-by: filipp.zhinkin@oracle.com
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
24006
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     1
/*
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     2
 * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     4
 *
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     7
 * published by the Free Software Foundation.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     8
 *
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    13
 * accompanied this code).
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    14
 *
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    18
 *
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    21
 * questions.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    22
 *
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    23
 */
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    24
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    25
/**
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    26
 * @test
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    27
 * @bug 8031320
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    28
 * @summary Verify that RTMAbortRatio affects amount of aborts before
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    29
 *          deoptimization.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    30
 * @library /testlibrary /testlibrary/whitebox /compiler/testlibrary
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    31
 * @build TestRTMAbortRatio
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    32
 * @run main ClassFileInstaller sun.hotspot.WhiteBox
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    33
 * @run main/othervm -Xbootclasspath/a:. -XX:+UnlockDiagnosticVMOptions
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    34
 *                   -XX:+WhiteBoxAPI TestRTMAbortRatio
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    35
 */
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    36
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    37
import java.util.List;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    38
import com.oracle.java.testlibrary.*;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    39
import com.oracle.java.testlibrary.cli.CommandLineOptionTest;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    40
import com.oracle.java.testlibrary.cli.predicate.AndPredicate;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    41
import rtm.*;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    42
import rtm.predicate.SupportedCPU;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    43
import rtm.predicate.SupportedVM;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    44
import sun.misc.Unsafe;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    45
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    46
/**
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    47
 * Test verifies that method will be deoptimized on high abort ratio
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    48
 * as soon as abort ratio reaches RTMAbortRatio's value.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    49
 */
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    50
public class TestRTMAbortRatio extends CommandLineOptionTest {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    51
    private TestRTMAbortRatio() {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    52
        super(new AndPredicate(new SupportedCPU(), new SupportedVM()));
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    53
    }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    54
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    55
    @Override
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    56
    protected void runTestCases() throws Throwable {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    57
        verifyAbortRatio(0, false);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    58
        verifyAbortRatio(10, false);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    59
        verifyAbortRatio(50, false);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    60
        verifyAbortRatio(100, false);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    61
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    62
        verifyAbortRatio(0, true);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    63
        verifyAbortRatio(10, true);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    64
        verifyAbortRatio(50, true);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    65
        verifyAbortRatio(100, true);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    66
    }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    67
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    68
    private void verifyAbortRatio(int abortRatio, boolean useStackLock)
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    69
            throws Throwable {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    70
        CompilableTest test = new Test();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    71
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    72
        OutputAnalyzer outputAnalyzer = RTMTestBase.executeRTMTest(
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    73
                test,
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    74
                CommandLineOptionTest.prepareBooleanFlag("UseRTMForStackLocks",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    75
                        useStackLock),
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    76
                "-XX:+UseRTMDeopt",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    77
                "-XX:RTMTotalCountIncrRate=1",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    78
                "-XX:RTMAbortThreshold=0",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    79
                CommandLineOptionTest.prepareNumericFlag("RTMLockingThreshold",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    80
                        10 * Test.TOTAL_ITERATIONS),
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    81
                CommandLineOptionTest.prepareNumericFlag("RTMAbortRatio",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    82
                        abortRatio),
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    83
                "-XX:+PrintPreciseRTMLockingStatistics",
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    84
                test.getClass().getName(),
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    85
                Boolean.toString(!useStackLock));
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    86
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    87
        outputAnalyzer.shouldHaveExitValue(0);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    88
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    89
        List<RTMLockingStatistics> statistics = RTMLockingStatistics.fromString(
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    90
                test.getMethodWithLockName(), outputAnalyzer.getOutput());
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    91
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    92
        Asserts.assertEQ(statistics.size(), 1, "VM output should contain "
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    93
                + "exactly one RTM locking statistics entry.");
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    94
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    95
        RTMLockingStatistics lock = statistics.get(0);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    96
        int actualRatio;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    97
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    98
        if (lock.getTotalAborts() == 1L) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
    99
            actualRatio = 0;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   100
        } else {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   101
            actualRatio = (int) (lock.getTotalLocks()
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   102
                    / (lock.getTotalAborts() - 1L));
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   103
        }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   104
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   105
        Asserts.assertLTE(actualRatio, abortRatio, String.format(
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   106
                "Actual abort ratio (%d) should lower or equal to "
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   107
                + "specified (%d).", actualRatio, abortRatio));
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   108
    }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   109
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   110
    /**
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   111
     * Force abort after {@code Test.WARMUP_ITERATIONS} is done.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   112
     */
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   113
    public static class Test implements CompilableTest {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   114
        private static final int TOTAL_ITERATIONS = 10000;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   115
        private static final int WARMUP_ITERATIONS = 1000;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   116
        private static final Unsafe UNSAFE = Utils.getUnsafe();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   117
        private final Object monitor = new Object();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   118
        // Following field have to be static in order to avoid escape analysis.
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   119
        @SuppressWarnings("UnsuedDeclaration")
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   120
        private static int field = 0;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   121
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   122
        @Override
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   123
        public String getMethodWithLockName() {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   124
             return this.getClass().getName() + "::lock";
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   125
         }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   126
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   127
        @Override
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   128
        public String[] getMethodsToCompileNames() {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   129
            return new String[] {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   130
                    getMethodWithLockName(),
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   131
                    Unsafe.class.getName() + "::addressSize"
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   132
            };
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   133
        }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   134
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   135
        public void lock(boolean abort) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   136
            synchronized(monitor) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   137
                if (abort) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   138
                    Test.UNSAFE.addressSize();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   139
                }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   140
            }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   141
        }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   142
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   143
        /**
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   144
         * Usage:
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   145
         * Test &lt;inflate monitor&gt;
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   146
         */
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   147
        public static void main(String args[]) throws Throwable {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   148
            Asserts.assertGTE(args.length, 1, "One argument required.");
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   149
            Test t = new Test();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   150
            if (Boolean.valueOf(args[0])) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   151
                AbortProvoker.inflateMonitor(t.monitor);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   152
            }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   153
            for (int i = 0; i < Test.TOTAL_ITERATIONS; i++) {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   154
                t.lock(i >= Test.WARMUP_ITERATIONS);
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   155
            }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   156
        }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   157
    }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   158
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   159
    public static void main(String args[]) throws Throwable {
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   160
        new TestRTMAbortRatio().test();
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   161
    }
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   162
}
54399106938f 8037860: Add tests to cover Intel RTM instructions support
iignatyev
parents:
diff changeset
   163