hotspot/src/share/vm/gc/g1/g1CodeCacheRemSet.cpp
author bpittore
Wed, 24 Jun 2015 12:12:25 -0400
changeset 31592 43f48e165466
parent 30764 fec48bf5a827
child 33093 5aa0f908f8cd
permissions -rw-r--r--
8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier" Summary: Need to add a space between macro identifier and string literal Reviewed-by: stefank, dholmes, kbarrett
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     1
/*
30764
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29796
diff changeset
     2
 * Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights reserved.
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     4
 *
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     7
 * published by the Free Software Foundation.
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     8
 *
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    13
 * accompanied this code).
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    14
 *
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    18
 *
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    21
 * questions.
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    22
 *
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    23
 */
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    24
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    25
#include "precompiled.hpp"
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    26
#include "code/codeCache.hpp"
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    27
#include "code/nmethod.hpp"
30764
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29796
diff changeset
    28
#include "gc/g1/g1CodeCacheRemSet.hpp"
fec48bf5a827 8079792: GC directory structure cleanup
pliden
parents: 29796
diff changeset
    29
#include "gc/g1/heapRegion.hpp"
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    30
#include "memory/heap.hpp"
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    31
#include "memory/iterator.hpp"
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    32
#include "oops/oop.inline.hpp"
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    33
#include "utilities/hashtable.inline.hpp"
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    34
#include "utilities/stack.inline.hpp"
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    35
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    36
class CodeRootSetTable : public Hashtable<nmethod*, mtGC> {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    37
  friend class G1CodeRootSetTest;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    38
  typedef HashtableEntry<nmethod*, mtGC> Entry;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    39
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    40
  static CodeRootSetTable* volatile _purge_list;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    41
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    42
  CodeRootSetTable* _purge_next;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    43
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    44
  unsigned int compute_hash(nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    45
    uintptr_t hash = (uintptr_t)nm;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    46
    return hash ^ (hash >> 7); // code heap blocks are 128byte aligned
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    47
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    48
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    49
  void remove_entry(Entry* e, Entry* previous);
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    50
  Entry* new_entry(nmethod* nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    51
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    52
 public:
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    53
  CodeRootSetTable(int size) : Hashtable<nmethod*, mtGC>(size, sizeof(Entry)), _purge_next(NULL) {}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    54
  ~CodeRootSetTable();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    55
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    56
  // Needs to be protected locks
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    57
  bool add(nmethod* nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    58
  bool remove(nmethod* nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    59
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    60
  // Can be called without locking
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    61
  bool contains(nmethod* nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    62
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    63
  int entry_size() const { return BasicHashtable<mtGC>::entry_size(); }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    64
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    65
  void copy_to(CodeRootSetTable* new_table);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    66
  void nmethods_do(CodeBlobClosure* blk);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    67
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    68
  template<typename CB>
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    69
  int remove_if(CB& should_remove);
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    70
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    71
  static void purge_list_append(CodeRootSetTable* tbl);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    72
  static void purge();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    73
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    74
  static size_t static_mem_size() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    75
    return sizeof(_purge_list);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    76
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    77
};
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    78
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    79
CodeRootSetTable* volatile CodeRootSetTable::_purge_list = NULL;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    80
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    81
CodeRootSetTable::Entry* CodeRootSetTable::new_entry(nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    82
  unsigned int hash = compute_hash(nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    83
  Entry* entry = (Entry*) new_entry_free_list();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    84
  if (entry == NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    85
    entry = (Entry*) NEW_C_HEAP_ARRAY2(char, entry_size(), mtGC, CURRENT_PC);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    86
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    87
  entry->set_next(NULL);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    88
  entry->set_hash(hash);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    89
  entry->set_literal(nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
    90
  return entry;
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    91
}
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
    92
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    93
void CodeRootSetTable::remove_entry(Entry* e, Entry* previous) {
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    94
  int index = hash_to_index(e->hash());
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    95
  assert((e == bucket(index)) == (previous == NULL), "if e is the first entry then previous should be null");
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    96
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    97
  if (previous == NULL) {
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    98
    set_entry(index, e->next());
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
    99
  } else {
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   100
    previous->set_next(e->next());
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   101
  }
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   102
  free_entry(e);
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   103
}
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   104
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   105
CodeRootSetTable::~CodeRootSetTable() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   106
  for (int index = 0; index < table_size(); ++index) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   107
    for (Entry* e = bucket(index); e != NULL; ) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   108
      Entry* to_remove = e;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   109
      // read next before freeing.
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   110
      e = e->next();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   111
      unlink_entry(to_remove);
27880
afb974a04396 8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents: 26574
diff changeset
   112
      FREE_C_HEAP_ARRAY(char, to_remove);
25492
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   113
    }
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   114
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   115
  assert(number_of_entries() == 0, "should have removed all entries");
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   116
  free_buckets();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   117
  for (BasicHashtableEntry<mtGC>* e = new_entry_free_list(); e != NULL; e = new_entry_free_list()) {
27880
afb974a04396 8060074: os::free() takes MemoryTrackingLevel but doesn't need it
coleenp
parents: 26574
diff changeset
   118
    FREE_C_HEAP_ARRAY(char, e);
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   119
  }
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   120
}
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   121
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   122
bool CodeRootSetTable::add(nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   123
  if (!contains(nm)) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   124
    Entry* e = new_entry(nm);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   125
    int index = hash_to_index(e->hash());
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   126
    add_entry(index, e);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   127
    return true;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   128
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   129
  return false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   130
}
25492
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   131
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   132
bool CodeRootSetTable::contains(nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   133
  int index = hash_to_index(compute_hash(nm));
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   134
  for (Entry* e = bucket(index); e != NULL; e = e->next()) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   135
    if (e->literal() == nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   136
      return true;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   137
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   138
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   139
  return false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   140
}
25492
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   141
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   142
bool CodeRootSetTable::remove(nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   143
  int index = hash_to_index(compute_hash(nm));
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   144
  Entry* previous = NULL;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   145
  for (Entry* e = bucket(index); e != NULL; previous = e, e = e->next()) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   146
    if (e->literal() == nm) {
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   147
      remove_entry(e, previous);
25492
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   148
      return true;
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   149
    }
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   150
  }
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   151
  return false;
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   152
}
d27050bdfb04 8049421: G1 Class Unloading after completing a concurrent mark cycle
stefank
parents: 25491
diff changeset
   153
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   154
void CodeRootSetTable::copy_to(CodeRootSetTable* new_table) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   155
  for (int index = 0; index < table_size(); ++index) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   156
    for (Entry* e = bucket(index); e != NULL; e = e->next()) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   157
      new_table->add(e->literal());
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   158
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   159
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   160
  new_table->copy_freelist(this);
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   161
}
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   162
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   163
void CodeRootSetTable::nmethods_do(CodeBlobClosure* blk) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   164
  for (int index = 0; index < table_size(); ++index) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   165
    for (Entry* e = bucket(index); e != NULL; e = e->next()) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   166
      blk->do_code_blob(e->literal());
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   167
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   168
  }
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   169
}
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   170
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   171
template<typename CB>
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   172
int CodeRootSetTable::remove_if(CB& should_remove) {
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   173
  int num_removed = 0;
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   174
  for (int index = 0; index < table_size(); ++index) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   175
    Entry* previous = NULL;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   176
    Entry* e = bucket(index);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   177
    while (e != NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   178
      Entry* next = e->next();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   179
      if (should_remove(e->literal())) {
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   180
        remove_entry(e, previous);
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   181
        ++num_removed;
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   182
      } else {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   183
        previous = e;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   184
      }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   185
      e = next;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   186
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   187
  }
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   188
  return num_removed;
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   189
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   190
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   191
G1CodeRootSet::~G1CodeRootSet() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   192
  delete _table;
24099
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   193
}
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   194
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   195
CodeRootSetTable* G1CodeRootSet::load_acquire_table() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   196
  return (CodeRootSetTable*) OrderAccess::load_ptr_acquire(&_table);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   197
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   198
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   199
void G1CodeRootSet::allocate_small_table() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   200
  _table = new CodeRootSetTable(SmallSize);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   201
}
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   202
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   203
void CodeRootSetTable::purge_list_append(CodeRootSetTable* table) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   204
  for (;;) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   205
    table->_purge_next = _purge_list;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   206
    CodeRootSetTable* old = (CodeRootSetTable*) Atomic::cmpxchg_ptr(table, &_purge_list, table->_purge_next);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   207
    if (old == table->_purge_next) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   208
      break;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   209
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   210
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   211
}
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   212
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   213
void CodeRootSetTable::purge() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   214
  CodeRootSetTable* table = _purge_list;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   215
  _purge_list = NULL;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   216
  while (table != NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   217
    CodeRootSetTable* to_purge = table;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   218
    table = table->_purge_next;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   219
    delete to_purge;
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   220
  }
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   221
}
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   222
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   223
void G1CodeRootSet::move_to_large() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   224
  CodeRootSetTable* temp = new CodeRootSetTable(LargeSize);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   225
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   226
  _table->copy_to(temp);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   227
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   228
  CodeRootSetTable::purge_list_append(_table);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   229
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   230
  OrderAccess::release_store_ptr(&_table, temp);
24099
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   231
}
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   232
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   233
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   234
void G1CodeRootSet::purge() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   235
  CodeRootSetTable::purge();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   236
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   237
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   238
size_t G1CodeRootSet::static_mem_size() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   239
  return CodeRootSetTable::static_mem_size();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   240
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   241
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   242
void G1CodeRootSet::add(nmethod* method) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   243
  bool added = false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   244
  if (is_empty()) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   245
    allocate_small_table();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   246
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   247
  added = _table->add(method);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   248
  if (_length == Threshold) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   249
    move_to_large();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   250
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   251
  if (added) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   252
    ++_length;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   253
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   254
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   255
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   256
bool G1CodeRootSet::remove(nmethod* method) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   257
  bool removed = false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   258
  if (_table != NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   259
    removed = _table->remove(method);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   260
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   261
  if (removed) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   262
    _length--;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   263
    if (_length == 0) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   264
      clear();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   265
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   266
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   267
  return removed;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   268
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   269
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   270
bool G1CodeRootSet::contains(nmethod* method) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   271
  CodeRootSetTable* table = load_acquire_table();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   272
  if (table != NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   273
    return table->contains(method);
24099
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   274
  }
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   275
  return false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   276
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   277
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   278
void G1CodeRootSet::clear() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   279
  delete _table;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   280
  _table = NULL;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   281
  _length = 0;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   282
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   283
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   284
size_t G1CodeRootSet::mem_size() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   285
  return sizeof(*this) +
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   286
      (_table != NULL ? sizeof(CodeRootSetTable) + _table->entry_size() * _length : 0);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   287
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   288
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   289
void G1CodeRootSet::nmethods_do(CodeBlobClosure* blk) const {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   290
  if (_table != NULL) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   291
    _table->nmethods_do(blk);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   292
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   293
}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   294
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   295
class CleanCallback : public StackObj {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   296
  class PointsIntoHRDetectionClosure : public OopClosure {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   297
    HeapRegion* _hr;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   298
   public:
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   299
    bool _points_into;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   300
    PointsIntoHRDetectionClosure(HeapRegion* hr) : _hr(hr), _points_into(false) {}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   301
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   302
    void do_oop(narrowOop* o) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   303
      do_oop_work(o);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   304
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   305
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   306
    void do_oop(oop* o) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   307
      do_oop_work(o);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   308
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   309
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   310
    template <typename T>
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   311
    void do_oop_work(T* p) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   312
      if (_hr->is_in(oopDesc::load_decode_heap_oop(p))) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   313
        _points_into = true;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   314
      }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   315
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   316
  };
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   317
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   318
  PointsIntoHRDetectionClosure _detector;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   319
  CodeBlobToOopClosure _blobs;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   320
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   321
 public:
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   322
  CleanCallback(HeapRegion* hr) : _detector(hr), _blobs(&_detector, !CodeBlobToOopClosure::FixRelocations) {}
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   323
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   324
  bool operator() (nmethod* nm) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   325
    _detector._points_into = false;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   326
    _blobs.do_code_blob(nm);
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   327
    return !_detector._points_into;
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   328
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   329
};
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   330
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   331
void G1CodeRootSet::clean(HeapRegion* owner) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   332
  CleanCallback should_clean(owner);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   333
  if (_table != NULL) {
26574
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   334
    int removed = _table->remove_if(should_clean);
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   335
    assert((size_t)removed <= _length, "impossible");
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   336
    _length -= removed;
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   337
  }
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   338
  if (_length == 0) {
59219d1be209 8057722: G1: Code root hashtable updated incorrectly when evacuation failed
mgerdin
parents: 26422
diff changeset
   339
    clear();
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   340
  }
24099
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   341
}
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   342
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   343
#ifndef PRODUCT
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   344
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   345
class G1CodeRootSetTest {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   346
 public:
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   347
  static void test() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   348
    {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   349
      G1CodeRootSet set1;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   350
      assert(set1.is_empty(), "Code root set must be initially empty but is not.");
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   351
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   352
      assert(G1CodeRootSet::static_mem_size() == sizeof(void*),
31592
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   353
          err_msg("The code root set's static memory usage is incorrect, " SIZE_FORMAT " bytes", G1CodeRootSet::static_mem_size()));
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   354
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   355
      set1.add((nmethod*)1);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   356
      assert(set1.length() == 1, err_msg("Added exactly one element, but set contains "
31592
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   357
          SIZE_FORMAT " elements", set1.length()));
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   358
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   359
      const size_t num_to_add = (size_t)G1CodeRootSet::Threshold + 1;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   360
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   361
      for (size_t i = 1; i <= num_to_add; i++) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   362
        set1.add((nmethod*)1);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   363
      }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   364
      assert(set1.length() == 1,
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   365
          err_msg("Duplicate detection should not have increased the set size but "
31592
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   366
              "is " SIZE_FORMAT, set1.length()));
23451
ed2b8bb28fed 8035406: Improve data structure for Code Cache remembered sets
tschatzl
parents:
diff changeset
   367
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   368
      for (size_t i = 2; i <= num_to_add; i++) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   369
        set1.add((nmethod*)(uintptr_t)(i));
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   370
      }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   371
      assert(set1.length() == num_to_add,
31592
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   372
          err_msg("After adding in total " SIZE_FORMAT " distinct code roots, they "
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   373
              "need to be in the set, but there are only " SIZE_FORMAT,
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   374
              num_to_add, set1.length()));
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   375
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   376
      assert(CodeRootSetTable::_purge_list != NULL, "should have grown to large hashtable");
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   377
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   378
      size_t num_popped = 0;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   379
      for (size_t i = 1; i <= num_to_add; i++) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   380
        bool removed = set1.remove((nmethod*)i);
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   381
        if (removed) {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   382
          num_popped += 1;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   383
        } else {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   384
          break;
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   385
        }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   386
      }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   387
      assert(num_popped == num_to_add,
31592
43f48e165466 8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
bpittore
parents: 30764
diff changeset
   388
          err_msg("Managed to pop " SIZE_FORMAT " code roots, but only " SIZE_FORMAT " "
26422
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   389
              "were added", num_popped, num_to_add));
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   390
      assert(CodeRootSetTable::_purge_list != NULL, "should have grown to large hashtable");
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   391
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   392
      G1CodeRootSet::purge();
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   393
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   394
      assert(CodeRootSetTable::_purge_list == NULL, "should have purged old small tables");
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   395
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   396
    }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   397
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   398
  }
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   399
};
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   400
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   401
void TestCodeCacheRemSet_test() {
4ee5901e205e 8048268: G1 Code Root Migration performs poorly
mgerdin
parents: 25500
diff changeset
   402
  G1CodeRootSetTest::test();
24099
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   403
}
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   404
9c132a88935d 8038930: G1CodeRootSet::test fails with assert(_num_chunks_handed_out == 0) failed: No elements must have been handed out yet
tschatzl
parents: 23451
diff changeset
   405
#endif