test/jdk/java/lang/ThreadGroup/Destroy.java
author dfuchs
Wed, 13 Mar 2019 18:43:16 +0000
changeset 54108 43a379369b0e
permissions -rw-r--r--
8219197: ThreadGroup.enumerate() may return wrong value Summary: ThreadGroup.enumerate(list,n,recurse) should never return a value that is less than n. Reviewed-by: clanger, chegar, prappo
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
54108
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     1
/*
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     2
 * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     4
 *
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     7
 * published by the Free Software Foundation.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     8
 *
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    13
 * accompanied this code).
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    14
 *
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    18
 *
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    21
 * questions.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    22
 */
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    23
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    24
/**
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    25
 * @test
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    26
 * @summary enumerate(list,n,recurse) may return 0 if the group is being destroyed,
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    27
 *          whereas it should never return a value < n. This lead to inconsistent
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    28
 *          results if ThreadGroup::enumerate is called concurrently at the same
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    29
 *          time that a child group is being destroyed. This is a race condition,
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    30
 *          and this test will not always fail without the fix, but it does fail
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    31
 *          often enough.
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    32
 * @bug 8219197
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    33
 *
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    34
 */
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    35
import java.util.concurrent.CountDownLatch;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    36
import java.util.concurrent.Semaphore;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    37
import java.util.concurrent.atomic.AtomicInteger;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    38
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    39
public class Destroy {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    40
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    41
    static final class Task implements Runnable {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    42
        final Semaphore sem;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    43
        final CountDownLatch count;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    44
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    45
        public Task(Semaphore sem, CountDownLatch count) {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    46
            this.sem = sem;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    47
            this.count = count;
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    48
        }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    49
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    50
        @Override
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    51
        public void run() {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    52
            try {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    53
                count.countDown();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    54
                sem.acquire();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    55
            } catch (Throwable t) {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    56
                t.printStackTrace();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    57
            } finally {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    58
                System.out.println(Thread.currentThread().getName()
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    59
                        + " exiting");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    60
            }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    61
        }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    62
    }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    63
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    64
    public static void main(String[] args) throws Exception {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    65
        testDestroyChild();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    66
    }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    67
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    68
    public static void testDestroyChild() throws Exception {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    69
        ThreadGroup root = new ThreadGroup("root");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    70
        ThreadGroup parent = new ThreadGroup(root,"parent");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    71
        ThreadGroup child1 = new ThreadGroup(parent, "child1");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    72
        CountDownLatch count = new CountDownLatch(2);
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    73
        Semaphore sem1 = new Semaphore(1);
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    74
        Semaphore sem2 = new Semaphore(1);
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    75
        Thread t1 = new Thread(parent, new Task(sem1, count), "PT1");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    76
        Thread t2 = new Thread(parent, new Task(sem2, count), "PT2");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    77
        sem1.acquire();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    78
        sem2.acquire();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    79
        try {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    80
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    81
            t1.start();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    82
            t2.start();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    83
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    84
            System.out.println("\nAwaiting parent threads...");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    85
            count.await();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    86
            Thread[] threads = new Thread[2];
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    87
            int nb = root.enumerate(threads, true);
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    88
            if (nb != 2) {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    89
                throw new AssertionError("wrong number of threads: " + nb);
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    90
            }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    91
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    92
            Thread t3 = new Thread(child1::destroy, "destroy");
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    93
            AtomicInteger nbr = new AtomicInteger();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    94
            Thread t4 = new Thread("enumerate") {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    95
                public void run() {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    96
                    Thread[] threads = new Thread[42];
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    97
                    nbr.addAndGet(root.enumerate(threads, true));
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    98
                }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
    99
            };
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   100
            t4.start();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   101
            t3.start();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   102
            t4.join();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   103
            t3.join();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   104
            if (nbr.get() != nb) {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   105
                throw new AssertionError("wrong number of threads: " + nbr.get());
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   106
            }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   107
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   108
        } finally {
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   109
            sem1.release();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   110
            sem2.release();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   111
        }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   112
        t1.join();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   113
        t2.join();
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   114
    }
43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value
dfuchs
parents:
diff changeset
   115
}