test/jdk/tools/jpackage/share/ArgumentsTest.java
author herrick
Wed, 16 Oct 2019 10:32:08 -0400
branchJDK-8200758-branch
changeset 58648 3bf53ffa9ae7
parent 58416 f09bf58c1f17
child 58994 b09ba68c6a19
permissions -rw-r--r--
8232279 : Improve test helpers #2 Submitted-by: asemenyuk Reviewed-by: aherrick, almatvee
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
57307
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     1
/*
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     2
 * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     3
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     4
 *
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     5
 * This code is free software; you can redistribute it and/or modify it
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     6
 * under the terms of the GNU General Public License version 2 only, as
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     7
 * published by the Free Software Foundation.
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     8
 *
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
     9
 * This code is distributed in the hope that it will be useful, but WITHOUT
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    10
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    11
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    12
 * version 2 for more details (a copy is included in the LICENSE file that
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    13
 * accompanied this code).
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    14
 *
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    15
 * You should have received a copy of the GNU General Public License version
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    16
 * 2 along with this work; if not, write to the Free Software Foundation,
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    17
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    18
 *
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    19
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    20
 * or visit www.oracle.com if you need additional information or have any
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    21
 * questions.
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    22
 */
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    23
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    24
import java.nio.file.Path;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    25
import java.util.List;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    26
import jdk.jpackage.test.TKit;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    27
import jdk.jpackage.test.HelloApp;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    28
import jdk.jpackage.test.Functional.ThrowingConsumer;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    29
import jdk.jpackage.test.JPackageCommand;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    30
import jdk.jpackage.test.Annotations.*;
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    31
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    32
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    33
/*
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    34
 * Tricky arguments used in the test require a bunch of levels of character
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    35
 * escaping for proper encoding them in a single string to be used as a value of
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    36
 * `--arguments` option. String with encoded arguments doesn't go through the
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    37
 * system to jpackage executable as is because OS is interpreting escape
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    38
 * characters. This is true for Windows at least.
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    39
 *
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    40
 * String mapping performed by the system corrupts the string and jpackage exits
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    41
 * with error. There is no problem with string corruption when jpackage is used
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    42
 * as tool provider. This is not jpackage issue, so just always run this test
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    43
 * with jpackage used as tool provider.
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    44
 * /
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    45
57307
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    46
/*
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    47
 * @test
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    48
 * @summary jpackage create image with --arguments test
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    49
 * @library ../helpers
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    50
 * @build jdk.jpackage.test.*
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    51
 * @modules jdk.jpackage/jdk.jpackage.internal
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    52
 * @compile ArgumentsTest.java
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    53
 * @run main/othervm -Xmx512m jdk.jpackage.test.Main
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    54
 *  --jpt-run=ArgumentsTest
57307
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    55
 */
57446
5a5b85f00a63 8226891: rename and re-layout jpackage tests.
herrick
parents: 57414
diff changeset
    56
public class ArgumentsTest {
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    57
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    58
    @BeforeEach
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    59
    public static void useJPackageToolProvider() {
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    60
        JPackageCommand.useToolProviderByDefault();
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    61
    }
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    62
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    63
    @Test
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    64
    @Parameter("Goodbye")
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    65
    @Parameter("com.hello/com.hello.Hello")
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    66
    public static void testApp(String javaAppDesc) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    67
        testIt(javaAppDesc, null);
57307
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    68
    }
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    69
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    70
    private static void testIt(String javaAppDesc,
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    71
            ThrowingConsumer<JPackageCommand> initializer) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    72
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    73
        JPackageCommand cmd = JPackageCommand.helloAppImage(javaAppDesc).addArguments(
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    74
                "--arguments", JPackageCommand.escapeAndJoin(TRICKY_ARGUMENTS));
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    75
        if (initializer != null) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    76
            ThrowingConsumer.toConsumer(initializer).accept(cmd);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    77
        }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    78
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    79
        cmd.executeAndAssertImageCreated();
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    80
58648
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    81
        Path launcherPath = cmd.appLauncherPath();
3bf53ffa9ae7 8232279 : Improve test helpers #2
herrick
parents: 58416
diff changeset
    82
        if (!cmd.isFakeRuntime(String.format(
58416
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    83
                "Not running [%s] launcher", launcherPath))) {
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    84
            HelloApp.executeAndVerifyOutput(launcherPath, TRICKY_ARGUMENTS);
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    85
        }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    86
    }
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    87
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    88
    private final static List<String> TRICKY_ARGUMENTS = List.of(
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    89
        "argument",
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    90
        "Some Arguments",
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    91
        "Value \"with\" quotes"
f09bf58c1f17 8231605: Improve test helpers
herrick
parents: 58147
diff changeset
    92
    );
57307
4948a1944cf9 8221777: CLI changes from jpackage EA5 feedback
herrick
parents:
diff changeset
    93
}